{"action":"created","issue":{"url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/362","repository_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info","labels_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/362/labels{/name}","comments_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/362/comments","events_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/362/events","html_url":"https://github.com/rebeccahughes/react-native-device-info/pull/362","id":306222449,"number":362,"title":"check to detect is iphone x of not","user":{"login":"fattahmuhyiddeen","id":24792201,"avatar_url":"https://avatars3.githubusercontent.com/u/24792201?v=4","gravatar_id":"","url":"https://api.github.com/users/fattahmuhyiddeen","html_url":"https://github.com/fattahmuhyiddeen","followers_url":"https://api.github.com/users/fattahmuhyiddeen/followers","following_url":"https://api.github.com/users/fattahmuhyiddeen/following{/other_user}","gists_url":"https://api.github.com/users/fattahmuhyiddeen/gists{/gist_id}","starred_url":"https://api.github.com/users/fattahmuhyiddeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fattahmuhyiddeen/subscriptions","organizations_url":"https://api.github.com/users/fattahmuhyiddeen/orgs","repos_url":"https://api.github.com/users/fattahmuhyiddeen/repos","events_url":"https://api.github.com/users/fattahmuhyiddeen/events{/privacy}","received_events_url":"https://api.github.com/users/fattahmuhyiddeen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-18T08:30:36Z","updated_at":"2018-03-18T08:55:14Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/pulls/362","html_url":"https://github.com/rebeccahughes/react-native-device-info/pull/362","diff_url":"https://github.com/rebeccahughes/react-native-device-info/pull/362.diff","patch_url":"https://github.com/rebeccahughes/react-native-device-info/pull/362.patch"},"body":"<!--\r\nHi there and thank you for your change proposal!\r\n\r\nPlease fill out the following template to make the review process\r\nas quick and smooth as possible.\r\n-->\r\n\r\n## Description\r\n\r\n\r\nAdded `isIphoneX()` that allows to check if user are using iphoneX\r\n\r\n## Compatibility\r\n\r\n| OS      | Implemented |\r\n| ------- | :---------: |\r\n| iOS          |    ✅     |\r\n| Android   |    ✅     |\r\n| Windows |    ✅    |\r\n\r\n## Checklist\r\n\r\n<!-- Check completed item: [X] -->\r\n\r\n* [x] I have tested this on a device/simulator for each compatible OS\r\n* [x] I added the documentation in `README.md`.\r\n* [x] I mentionned this change in `CHANGELOG.md`.\r\n"},"comment":{"url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/comments/373982381","html_url":"https://github.com/rebeccahughes/react-native-device-info/pull/362#issuecomment-373982381","issue_url":"https://api.github.com/repos/rebeccahughes/react-native-device-info/issues/362","id":373982381,"user":{"login":"fattahmuhyiddeen","id":24792201,"avatar_url":"https://avatars3.githubusercontent.com/u/24792201?v=4","gravatar_id":"","url":"https://api.github.com/users/fattahmuhyiddeen","html_url":"https://github.com/fattahmuhyiddeen","followers_url":"https://api.github.com/users/fattahmuhyiddeen/followers","following_url":"https://api.github.com/users/fattahmuhyiddeen/following{/other_user}","gists_url":"https://api.github.com/users/fattahmuhyiddeen/gists{/gist_id}","starred_url":"https://api.github.com/users/fattahmuhyiddeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fattahmuhyiddeen/subscriptions","organizations_url":"https://api.github.com/users/fattahmuhyiddeen/orgs","repos_url":"https://api.github.com/users/fattahmuhyiddeen/repos","events_url":"https://api.github.com/users/fattahmuhyiddeen/events{/privacy}","received_events_url":"https://api.github.com/users/fattahmuhyiddeen/received_events","type":"User","site_admin":false},"created_at":"2018-03-18T08:55:14Z","updated_at":"2018-03-18T08:55:14Z","author_association":"NONE","body":"it make sense because iphonex has notch and i really need make my app\nheader taller just for that iphone to avoid that notch\n\nOn Sun, Mar 18, 2018 at 4:53 PM, Mehdi Achour <notifications@github.com>\nwrote:\n\n> isIphoneX() is really easy to replicate in your application using:\n>\n> const isIphoneX = () => DeviceInfo.getModel() === 'iPhone X';\n>\n> Adding it to this library doesn't really make sense to me (or else we will\n> end up with isSamsungS8(), isOnePlus5t(), etc..).\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/rebeccahughes/react-native-device-info/pull/362#issuecomment-373982280>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AXpMiWR850qUy3eUdYyIO5OFOveKBE0Hks5tfiCLgaJpZM4SvHUb>\n> .\n>\n"}}
{"actor":{"display_login":"fattahmuhyiddeen"}}