{"action":"created","issue":{"url":"https://api.github.com/repos/bolt-design-system/bolt/issues/919","repository_url":"https://api.github.com/repos/bolt-design-system/bolt","labels_url":"https://api.github.com/repos/bolt-design-system/bolt/issues/919/labels{/name}","comments_url":"https://api.github.com/repos/bolt-design-system/bolt/issues/919/comments","events_url":"https://api.github.com/repos/bolt-design-system/bolt/issues/919/events","html_url":"https://github.com/bolt-design-system/bolt/pull/919","id":371550780,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzOTcyMzg5","number":919,"title":"Support row_gutter in IE","user":{"login":"remydenton","id":677668,"node_id":"MDQ6VXNlcjY3NzY2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/677668?v=4","gravatar_id":"","url":"https://api.github.com/users/remydenton","html_url":"https://github.com/remydenton","followers_url":"https://api.github.com/users/remydenton/followers","following_url":"https://api.github.com/users/remydenton/following{/other_user}","gists_url":"https://api.github.com/users/remydenton/gists{/gist_id}","starred_url":"https://api.github.com/users/remydenton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remydenton/subscriptions","organizations_url":"https://api.github.com/users/remydenton/orgs","repos_url":"https://api.github.com/users/remydenton/repos","events_url":"https://api.github.com/users/remydenton/events{/privacy}","received_events_url":"https://api.github.com/users/remydenton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-18T14:12:07Z","updated_at":"2018-10-18T17:45:41Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/bolt-design-system/bolt/pulls/919","html_url":"https://github.com/bolt-design-system/bolt/pull/919","diff_url":"https://github.com/bolt-design-system/bolt/pull/919.diff","patch_url":"https://github.com/bolt-design-system/bolt/pull/919.patch"},"body":"## Jira\r\n\r\nhttp://vjira2:8080/browse/BDS-719\r\n\r\n## Summary\r\n\r\nAdds support for the grid component's row_gutter parameter in IE 11.\r\n\r\n## Details\r\n\r\nNotes:\r\n- I did not add CSS for `row_gutter=none` since it works by default.\r\n\r\nQuestions that should be resolved before merging:\r\n- Is it correct to use the `$bolt-spacing-values` variable for the scss loop?\r\n- vinset doesn't appear to work as I would have expected in the examples (`pattern-lab/?p=components-grid-row-vinset-variations`).  Namely, It only adds an inset to the bottom of the grid.  Am I doing something wrong or is this a separate bug?\r\n\r\n## How to test\r\n\r\n- On the this branch, go to `/pattern-lab/?p=components-grid-row-gutter-variations`\r\n- Confirm that the row gutter have parity between IE-11 and other modern browsers\r\n"},"comment":{"url":"https://api.github.com/repos/bolt-design-system/bolt/issues/comments/431100333","html_url":"https://github.com/bolt-design-system/bolt/pull/919#issuecomment-431100333","issue_url":"https://api.github.com/repos/bolt-design-system/bolt/issues/919","id":431100333,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTEwMDMzMw==","user":{"login":"sghoweri","id":1617209,"node_id":"MDQ6VXNlcjE2MTcyMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1617209?v=4","gravatar_id":"","url":"https://api.github.com/users/sghoweri","html_url":"https://github.com/sghoweri","followers_url":"https://api.github.com/users/sghoweri/followers","following_url":"https://api.github.com/users/sghoweri/following{/other_user}","gists_url":"https://api.github.com/users/sghoweri/gists{/gist_id}","starred_url":"https://api.github.com/users/sghoweri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sghoweri/subscriptions","organizations_url":"https://api.github.com/users/sghoweri/orgs","repos_url":"https://api.github.com/users/sghoweri/repos","events_url":"https://api.github.com/users/sghoweri/events{/privacy}","received_events_url":"https://api.github.com/users/sghoweri/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T17:45:41Z","updated_at":"2018-10-18T17:45:41Z","author_association":"CONTRIBUTOR","body":"> Is it correct to use the $bolt-spacing-values variable for the scss loop?\r\n\r\n@remydenton since we need to loop through all the spacing size options and the values of those options are 1:1 here, I'd say yes it is correct. \r\n\r\nIf we needed to add or adjust which values are in this Sass map then instead I'd suggest creating a new local variable that takes the global spacing sizes and changes things out as needed.\r\n\r\nMake sense?"}}
{"actor":{"display_login":"sghoweri"}}