{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/13796","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/13796/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/13796/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/13796/events","html_url":"https://github.com/xbmc/xbmc/pull/13796","id":316455518,"number":13796,"title":"[addons] service add-ons start and stop on profile login and logout","user":{"login":"rmrector","id":260815,"avatar_url":"https://avatars2.githubusercontent.com/u/260815?v=4","gravatar_id":"","url":"https://api.github.com/users/rmrector","html_url":"https://github.com/rmrector","followers_url":"https://api.github.com/users/rmrector/followers","following_url":"https://api.github.com/users/rmrector/following{/other_user}","gists_url":"https://api.github.com/users/rmrector/gists{/gist_id}","starred_url":"https://api.github.com/users/rmrector/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmrector/subscriptions","organizations_url":"https://api.github.com/users/rmrector/orgs","repos_url":"https://api.github.com/users/rmrector/repos","events_url":"https://api.github.com/users/rmrector/events{/privacy}","received_events_url":"https://api.github.com/users/rmrector/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-21T02:53:15Z","updated_at":"2018-04-25T18:41:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/13796","html_url":"https://github.com/xbmc/xbmc/pull/13796","diff_url":"https://github.com/xbmc/xbmc/pull/13796.diff","patch_url":"https://github.com/xbmc/xbmc/pull/13796.patch"},"body":"And no service add-ons are started _before_ profile login.\r\n\r\n_This PR started life as a fix for some of the goofy behavior `start=\"startup\"` caused, but now it's just getting the boot._\r\n\r\n## Motivation and Context\r\n`start=\"startup\"` service add-ons made things goofy and weren't particularly useful. Simplify!\r\n\r\n## How Has This Been Tested?\r\nManually by restarting Kodi with [these simple service add-ons](https://github.com/rmrector/repository.rector.stuff/raw/master/testing/service-startup-testing.zip) that log and notify when they start and stop, testing application with and without login screen, and switching profiles after login. I also checked that service add-ons are still started and stopped when enabled and disabled from the GUI after changing profiles, as I moved the `m_addonMgr.Events().Subscribe()` from every profile login to once on application start.\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [X] Breaking change (technically, though I'm not sure how many service add-ons ever used it effectively)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [X] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [X] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n\r\n[This wiki page](https://kodi.wiki/view/HOW-TO:Automatically_start_addons_using_services) needs a note of this change for Leia, but it's on lockdown right now."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/384392255","html_url":"https://github.com/xbmc/xbmc/pull/13796#issuecomment-384392255","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/13796","id":384392255,"user":{"login":"tamland","id":148836,"avatar_url":"https://avatars1.githubusercontent.com/u/148836?v=4","gravatar_id":"","url":"https://api.github.com/users/tamland","html_url":"https://github.com/tamland","followers_url":"https://api.github.com/users/tamland/followers","following_url":"https://api.github.com/users/tamland/following{/other_user}","gists_url":"https://api.github.com/users/tamland/gists{/gist_id}","starred_url":"https://api.github.com/users/tamland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamland/subscriptions","organizations_url":"https://api.github.com/users/tamland/orgs","repos_url":"https://api.github.com/users/tamland/repos","events_url":"https://api.github.com/users/tamland/events{/privacy}","received_events_url":"https://api.github.com/users/tamland/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T18:41:20Z","updated_at":"2018-04-25T18:41:20Z","author_association":"OWNER","body":"Just force push and he will build again"}}
{"actor":{"display_login":"tamland"}}