{"action":"created","issue":{"url":"https://api.github.com/repos/learningequality/kolibri/issues/4226","repository_url":"https://api.github.com/repos/learningequality/kolibri","labels_url":"https://api.github.com/repos/learningequality/kolibri/issues/4226/labels{/name}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/4226/comments","events_url":"https://api.github.com/repos/learningequality/kolibri/issues/4226/events","html_url":"https://github.com/learningequality/kolibri/pull/4226","id":358256309,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDcyNzMx","number":4226,"title":"Calculate ChannelMetadata public api fields","user":{"login":"ralphiee22","id":6361732,"node_id":"MDQ6VXNlcjYzNjE3MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/6361732?v=4","gravatar_id":"","url":"https://api.github.com/users/ralphiee22","html_url":"https://github.com/ralphiee22","followers_url":"https://api.github.com/users/ralphiee22/followers","following_url":"https://api.github.com/users/ralphiee22/following{/other_user}","gists_url":"https://api.github.com/users/ralphiee22/gists{/gist_id}","starred_url":"https://api.github.com/users/ralphiee22/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ralphiee22/subscriptions","organizations_url":"https://api.github.com/users/ralphiee22/orgs","repos_url":"https://api.github.com/users/ralphiee22/repos","events_url":"https://api.github.com/users/ralphiee22/events{/privacy}","received_events_url":"https://api.github.com/users/ralphiee22/received_events","type":"User","site_admin":false},"labels":[{"id":410338552,"node_id":"MDU6TGFiZWw0MTAzMzg1NTI=","url":"https://api.github.com/repos/learningequality/kolibri/labels/PR:%20needs%20review","name":"PR: needs review","color":"1f6ad6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/learningequality/kolibri/milestones/22","html_url":"https://github.com/learningequality/kolibri/milestone/22","labels_url":"https://api.github.com/repos/learningequality/kolibri/milestones/22/labels","id":3254318,"node_id":"MDk6TWlsZXN0b25lMzI1NDMxOA==","number":22,"title":"0.11.0","description":"","creator":{"login":"indirectlylit","id":2367265,"node_id":"MDQ6VXNlcjIzNjcyNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"open_issues":77,"closed_issues":86,"state":"open","created_at":"2018-04-09T23:34:55Z","updated_at":"2018-09-18T19:40:50Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2018-09-08T02:27:17Z","updated_at":"2018-09-18T20:51:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/4226","html_url":"https://github.com/learningequality/kolibri/pull/4226","diff_url":"https://github.com/learningequality/kolibri/pull/4226.diff","patch_url":"https://github.com/learningequality/kolibri/pull/4226.patch"},"body":"<!--\r\n 1. Following guidance below, replace …'s with your own words\r\n 2. After saving the PR, tick of completed checklist items\r\n 3. Skip checklist items that are not applicable or not necessary\r\n 4. Delete instruction/comment blocks\r\n-->\r\n\r\n### Summary\r\n<!--\r\n * description of the change\r\n * manual verification steps performed\r\n * screenshots if the PR affects the UI\r\n-->\r\n\r\nAdds fields to `ChannelMetadata` that will be returned by the public channel api. We now calculate these fields during channel import, as well as during a migration.\r\nAdded a test for calculating fields during data migration. \r\nWe now have a blacklist of models to exclude during channel import, such as the `Language` M2M field on `ChannelMetadata`.\r\n\r\n### Reviewer guidance\r\n<!--\r\n * how can a reviewer test these changes?\r\n * are there any risky areas that deserve extra testing\r\n-->\r\n\r\nmake sure you have content locally and \r\nA. go to http://0.0.0.0:8000/api/remotechannel?baseurl=http://0.0.0.0:8000/ to see public api.\r\nB. migrate old dbs\r\nC. import channel/content from studio\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [x] Contributor has fully tested the PR manually\r\n- [x] PR has the correct target branch and milestone\r\n- [x] PR has 'needs review' or 'work-in-progress' label\r\n- [x] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [ ] If there are any front-end changes, before/after screenshots are included\r\n- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n"},"comment":{"url":"https://api.github.com/repos/learningequality/kolibri/issues/comments/422549883","html_url":"https://github.com/learningequality/kolibri/pull/4226#issuecomment-422549883","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/4226","id":422549883,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjU0OTg4Mw==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-09-18T20:51:27Z","updated_at":"2018-09-18T20:51:27Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4226?src=pr&el=h1) Report\n> Merging [#4226](https://codecov.io/gh/learningequality/kolibri/pull/4226?src=pr&el=desc) into [develop](https://codecov.io/gh/learningequality/kolibri/commit/46a7e4fc945715c5f5a110812998018e05681051?src=pr&el=desc) will **increase** coverage by `0.1%`.\n> The diff coverage is `90%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/learningequality/kolibri/pull/4226/graphs/tree.svg?width=650&token=l3yT7YuBEg&height=150&src=pr)](https://codecov.io/gh/learningequality/kolibri/pull/4226?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           develop    #4226     +/-   ##\n==========================================\n+ Coverage    53.28%   53.38%   +0.1%     \n==========================================\n  Files          695      696      +1     \n  Lines        22144    22210     +66     \n  Branches      3001     3005      +4     \n==========================================\n+ Hits         11799    11857     +58     \n- Misses        9648     9656      +8     \n  Partials       697      697\n```\n\n\n| [Impacted Files](https://codecov.io/gh/learningequality/kolibri/pull/4226?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [kolibri/core/public/api.py](https://codecov.io/gh/learningequality/kolibri/pull/4226/diff?src=pr&el=tree#diff-a29saWJyaS9jb3JlL3B1YmxpYy9hcGkucHk=) | `100% <100%> (ø)` | :arrow_up: |\n| [kolibri/core/content/utils/paths.py](https://codecov.io/gh/learningequality/kolibri/pull/4226/diff?src=pr&el=tree#diff-a29saWJyaS9jb3JlL2NvbnRlbnQvdXRpbHMvcGF0aHMucHk=) | `98.41% <100%> (+0.07%)` | :arrow_up: |\n| [kolibri/core/content/serializers.py](https://codecov.io/gh/learningequality/kolibri/pull/4226/diff?src=pr&el=tree#diff-a29saWJyaS9jb3JlL2NvbnRlbnQvc2VyaWFsaXplcnMucHk=) | `91.55% <100%> (-0.27%)` | :arrow_down: |\n| [kolibri/core/content/utils/channel\\_import.py](https://codecov.io/gh/learningequality/kolibri/pull/4226/diff?src=pr&el=tree#diff-a29saWJyaS9jb3JlL2NvbnRlbnQvdXRpbHMvY2hhbm5lbF9pbXBvcnQucHk=) | `90.98% <100%> (+0.1%)` | :arrow_up: |\n| [kolibri/core/content/models.py](https://codecov.io/gh/learningequality/kolibri/pull/4226/diff?src=pr&el=tree#diff-a29saWJyaS9jb3JlL2NvbnRlbnQvbW9kZWxzLnB5) | `94.65% <100%> (+0.08%)` | :arrow_up: |\n| [kolibri/core/content/utils/annotation.py](https://codecov.io/gh/learningequality/kolibri/pull/4226/diff?src=pr&el=tree#diff-a29saWJyaS9jb3JlL2NvbnRlbnQvdXRpbHMvYW5ub3RhdGlvbi5weQ==) | `86.9% <83.33%> (-1.72%)` | :arrow_down: |\n| [kolibri/core/auth/test/migrationtestcase.py](https://codecov.io/gh/learningequality/kolibri/pull/4226/diff?src=pr&el=tree#diff-a29saWJyaS9jb3JlL2F1dGgvdGVzdC9taWdyYXRpb250ZXN0Y2FzZS5weQ==) | `95.23% <95.23%> (ø)` | |\n| [...olibri/core/content/utils/import\\_export\\_content.py](https://codecov.io/gh/learningequality/kolibri/pull/4226/diff?src=pr&el=tree#diff-a29saWJyaS9jb3JlL2NvbnRlbnQvdXRpbHMvaW1wb3J0X2V4cG9ydF9jb250ZW50LnB5) | `85.1% <0%> (+2.12%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4226?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/learningequality/kolibri/pull/4226?src=pr&el=footer). Last update [46a7e4f...c08b1a9](https://codecov.io/gh/learningequality/kolibri/pull/4226?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}