{"action":"created","issue":{"url":"https://api.github.com/repos/skatejs/skatejs/issues/1443","repository_url":"https://api.github.com/repos/skatejs/skatejs","labels_url":"https://api.github.com/repos/skatejs/skatejs/issues/1443/labels{/name}","comments_url":"https://api.github.com/repos/skatejs/skatejs/issues/1443/comments","events_url":"https://api.github.com/repos/skatejs/skatejs/issues/1443/events","html_url":"https://github.com/skatejs/skatejs/issues/1443","id":322886325,"node_id":"MDU6SXNzdWUzMjI4ODYzMjU=","number":1443,"title":"Do not set props.children in renderer","user":{"login":"blikblum","id":3047126,"node_id":"MDQ6VXNlcjMwNDcxMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/3047126?v=4","gravatar_id":"","url":"https://api.github.com/users/blikblum","html_url":"https://github.com/blikblum","followers_url":"https://api.github.com/users/blikblum/followers","following_url":"https://api.github.com/users/blikblum/following{/other_user}","gists_url":"https://api.github.com/users/blikblum/gists{/gist_id}","starred_url":"https://api.github.com/users/blikblum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blikblum/subscriptions","organizations_url":"https://api.github.com/users/blikblum/orgs","repos_url":"https://api.github.com/users/blikblum/repos","events_url":"https://api.github.com/users/blikblum/events{/privacy}","received_events_url":"https://api.github.com/users/blikblum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/skatejs/skatejs/milestones/36","html_url":"https://github.com/skatejs/skatejs/milestone/36","labels_url":"https://api.github.com/repos/skatejs/skatejs/milestones/36/labels","id":3086780,"node_id":"MDk6TWlsZXN0b25lMzA4Njc4MA==","number":36,"title":"6.0.0","description":null,"creator":{"login":"treshugart","id":136556,"node_id":"MDQ6VXNlcjEzNjU1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/136556?v=4","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2018-02-04T04:17:06Z","updated_at":"2018-06-08T10:45:40Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2018-05-14T16:17:11Z","updated_at":"2018-07-27T06:06:28Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Current behavior\r\n\r\nAll renderers, be default, set a children property to props\r\n\r\n### Expected behavior\r\n\r\nNo children property should be set to props\r\n\r\n### Use case(s)\r\n\r\nReasons to remove:\r\n - props.children in skatejs components has a different meaning than, e.g., Preact, Snabbdom or React. In former is just a slot element, in later, the children vnodes. This can:\r\n   * cause confusion when, e.g., developing a component in Preact and then in skatejs (with renderer-preact)\r\n   * lead to not expected dom structure (in skatejs component will have at least an extra slot element, not counting named slots) \r\n - using slot elements directly are easy and open the doors the more advanced features like named slots \r\n - it requires run extra code, with creation of a temporary vnode (not used in most cases) and a extra shallow copy of props, increasing pressure on garbage collection\r\n - when not using shadow dom as rootEl the props.children will not work which is not evident for those not familiar with the implementation\r\n - It's already removed in v6 branch\r\n"},"comment":{"url":"https://api.github.com/repos/skatejs/skatejs/issues/comments/408320979","html_url":"https://github.com/skatejs/skatejs/issues/1443#issuecomment-408320979","issue_url":"https://api.github.com/repos/skatejs/skatejs/issues/1443","id":408320979,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODMyMDk3OQ==","user":{"login":"treshugart","id":136556,"node_id":"MDQ6VXNlcjEzNjU1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/136556?v=4","gravatar_id":"","url":"https://api.github.com/users/treshugart","html_url":"https://github.com/treshugart","followers_url":"https://api.github.com/users/treshugart/followers","following_url":"https://api.github.com/users/treshugart/following{/other_user}","gists_url":"https://api.github.com/users/treshugart/gists{/gist_id}","starred_url":"https://api.github.com/users/treshugart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/treshugart/subscriptions","organizations_url":"https://api.github.com/users/treshugart/orgs","repos_url":"https://api.github.com/users/treshugart/repos","events_url":"https://api.github.com/users/treshugart/events{/privacy}","received_events_url":"https://api.github.com/users/treshugart/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T06:06:28Z","updated_at":"2018-07-27T06:06:28Z","author_association":"MEMBER","body":"The idea before was that you can just spread props onto the react element and it will render a `<slot>` wherever it renders `{this.props.children}`. I'm torn because this was pretty nice to have but maybe not necessary. Do we have a PR for this yet?"}}
{"actor":{"display_login":"treshugart"}}