{"action":"created","comment":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments/223947423","pull_request_review_id":163196815,"id":223947423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzk0NzQyMw==","diff_hunk":"@@ -1812,6 +1827,20 @@ private BType checkStructFieldAccess(BLangVariableReference varReferExpr, Name f\n             return symTable.errType;\n         }\n \n+        // If it's an index-based access, the return type is a nil-able.\n+        if (varReferExpr.getKind() == NodeKind.INDEX_BASED_ACCESS_EXPR) {\n+            Set<BType> types = new LinkedHashSet<>();","path":"compiler/ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/TypeChecker.java","position":null,"original_position":28,"commit_id":"eed04053a7b33256bc2cc0a9d35ebf1bd516bcae","original_commit_id":"c5e858e90c74d2641057354f1217dee4c6ceef35","user":{"login":"pubudu91","id":6260009,"node_id":"MDQ6VXNlcjYyNjAwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6260009?v=4","gravatar_id":"","url":"https://api.github.com/users/pubudu91","html_url":"https://github.com/pubudu91","followers_url":"https://api.github.com/users/pubudu91/followers","following_url":"https://api.github.com/users/pubudu91/following{/other_user}","gists_url":"https://api.github.com/users/pubudu91/gists{/gist_id}","starred_url":"https://api.github.com/users/pubudu91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubudu91/subscriptions","organizations_url":"https://api.github.com/users/pubudu91/orgs","repos_url":"https://api.github.com/users/pubudu91/repos","events_url":"https://api.github.com/users/pubudu91/events{/privacy}","received_events_url":"https://api.github.com/users/pubudu91/received_events","type":"User","site_admin":false},"body":"This code was unnecessary. Hence removed it.","created_at":"2018-10-10T06:14:00Z","updated_at":"2018-10-10T06:14:00Z","html_url":"https://github.com/ballerina-platform/ballerina-lang/pull/10632#discussion_r223947423","pull_request_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments/223947423"},"html":{"href":"https://github.com/ballerina-platform/ballerina-lang/pull/10632#discussion_r223947423"},"pull_request":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10632"}},"in_reply_to_id":223680232},"pull_request":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10632","id":219273310,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjczMzEw","html_url":"https://github.com/ballerina-platform/ballerina-lang/pull/10632","diff_url":"https://github.com/ballerina-platform/ballerina-lang/pull/10632.diff","patch_url":"https://github.com/ballerina-platform/ballerina-lang/pull/10632.patch","issue_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/10632","number":10632,"state":"open","locked":false,"title":"Correct the runtime behaviour for non-existent key access in records","user":{"login":"pubudu91","id":6260009,"node_id":"MDQ6VXNlcjYyNjAwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6260009?v=4","gravatar_id":"","url":"https://api.github.com/users/pubudu91","html_url":"https://github.com/pubudu91","followers_url":"https://api.github.com/users/pubudu91/followers","following_url":"https://api.github.com/users/pubudu91/following{/other_user}","gists_url":"https://api.github.com/users/pubudu91/gists{/gist_id}","starred_url":"https://api.github.com/users/pubudu91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubudu91/subscriptions","organizations_url":"https://api.github.com/users/pubudu91/orgs","repos_url":"https://api.github.com/users/pubudu91/repos","events_url":"https://api.github.com/users/pubudu91/events{/privacy}","received_events_url":"https://api.github.com/users/pubudu91/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n> This PR is to correct the behaviour of records when a non-existent key is accessed. This will align the behaviour with that of maps. Fix #10393 \r\n\r\n## Samples\r\n```ballerina\r\nimport ballerina/io;\r\n\r\ntype Foo record {\r\n    string a;\r\n    int x;\r\n    string...\r\n};\r\n\r\npublic function main() {\r\n    Foo f = {a: \"foo\"};\r\n    string? indexAccess = f[\"rest\"]; // index based access always returns `T|()`\r\n    string fieldAccess = f.rest; // field based access returns T, but throws a runtime error if the key is not present.\r\n}\r\n```\r\nRunning the above results in the following output:\r\n```\r\nerror: error, message: cannot find key 'rest'\r\n\tat main(rec.bal:12)\r\n```\r\n","created_at":"2018-10-01T06:41:19Z","updated_at":"2018-10-10T06:14:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91933c15fbc86c93e4dcb3b171ef219335e66fa3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":828131785,"node_id":"MDU6TGFiZWw4MjgxMzE3ODU=","url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels/Component/BVM","name":"Component/BVM","color":"0b6664","default":false},{"id":828131123,"node_id":"MDU6TGFiZWw4MjgxMzExMjM=","url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels/Component/Compiler","name":"Component/Compiler","color":"0b6664","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10632/commits","review_comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10632/comments","review_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/10632/comments","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/eed04053a7b33256bc2cc0a9d35ebf1bd516bcae","head":{"label":"pubudu91:fix-10393","ref":"fix-10393","sha":"eed04053a7b33256bc2cc0a9d35ebf1bd516bcae","user":{"login":"pubudu91","id":6260009,"node_id":"MDQ6VXNlcjYyNjAwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6260009?v=4","gravatar_id":"","url":"https://api.github.com/users/pubudu91","html_url":"https://github.com/pubudu91","followers_url":"https://api.github.com/users/pubudu91/followers","following_url":"https://api.github.com/users/pubudu91/following{/other_user}","gists_url":"https://api.github.com/users/pubudu91/gists{/gist_id}","starred_url":"https://api.github.com/users/pubudu91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubudu91/subscriptions","organizations_url":"https://api.github.com/users/pubudu91/orgs","repos_url":"https://api.github.com/users/pubudu91/repos","events_url":"https://api.github.com/users/pubudu91/events{/privacy}","received_events_url":"https://api.github.com/users/pubudu91/received_events","type":"User","site_admin":false},"repo":{"id":88832164,"node_id":"MDEwOlJlcG9zaXRvcnk4ODgzMjE2NA==","name":"ballerina","full_name":"pubudu91/ballerina","private":false,"owner":{"login":"pubudu91","id":6260009,"node_id":"MDQ6VXNlcjYyNjAwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/6260009?v=4","gravatar_id":"","url":"https://api.github.com/users/pubudu91","html_url":"https://github.com/pubudu91","followers_url":"https://api.github.com/users/pubudu91/followers","following_url":"https://api.github.com/users/pubudu91/following{/other_user}","gists_url":"https://api.github.com/users/pubudu91/gists{/gist_id}","starred_url":"https://api.github.com/users/pubudu91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pubudu91/subscriptions","organizations_url":"https://api.github.com/users/pubudu91/orgs","repos_url":"https://api.github.com/users/pubudu91/repos","events_url":"https://api.github.com/users/pubudu91/events{/privacy}","received_events_url":"https://api.github.com/users/pubudu91/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pubudu91/ballerina","description":"Ballerina is a new programming language for integration built on a sequence diagram metaphor.","fork":true,"url":"https://api.github.com/repos/pubudu91/ballerina","forks_url":"https://api.github.com/repos/pubudu91/ballerina/forks","keys_url":"https://api.github.com/repos/pubudu91/ballerina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pubudu91/ballerina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pubudu91/ballerina/teams","hooks_url":"https://api.github.com/repos/pubudu91/ballerina/hooks","issue_events_url":"https://api.github.com/repos/pubudu91/ballerina/issues/events{/number}","events_url":"https://api.github.com/repos/pubudu91/ballerina/events","assignees_url":"https://api.github.com/repos/pubudu91/ballerina/assignees{/user}","branches_url":"https://api.github.com/repos/pubudu91/ballerina/branches{/branch}","tags_url":"https://api.github.com/repos/pubudu91/ballerina/tags","blobs_url":"https://api.github.com/repos/pubudu91/ballerina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pubudu91/ballerina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pubudu91/ballerina/git/refs{/sha}","trees_url":"https://api.github.com/repos/pubudu91/ballerina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pubudu91/ballerina/statuses/{sha}","languages_url":"https://api.github.com/repos/pubudu91/ballerina/languages","stargazers_url":"https://api.github.com/repos/pubudu91/ballerina/stargazers","contributors_url":"https://api.github.com/repos/pubudu91/ballerina/contributors","subscribers_url":"https://api.github.com/repos/pubudu91/ballerina/subscribers","subscription_url":"https://api.github.com/repos/pubudu91/ballerina/subscription","commits_url":"https://api.github.com/repos/pubudu91/ballerina/commits{/sha}","git_commits_url":"https://api.github.com/repos/pubudu91/ballerina/git/commits{/sha}","comments_url":"https://api.github.com/repos/pubudu91/ballerina/comments{/number}","issue_comment_url":"https://api.github.com/repos/pubudu91/ballerina/issues/comments{/number}","contents_url":"https://api.github.com/repos/pubudu91/ballerina/contents/{+path}","compare_url":"https://api.github.com/repos/pubudu91/ballerina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pubudu91/ballerina/merges","archive_url":"https://api.github.com/repos/pubudu91/ballerina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pubudu91/ballerina/downloads","issues_url":"https://api.github.com/repos/pubudu91/ballerina/issues{/number}","pulls_url":"https://api.github.com/repos/pubudu91/ballerina/pulls{/number}","milestones_url":"https://api.github.com/repos/pubudu91/ballerina/milestones{/number}","notifications_url":"https://api.github.com/repos/pubudu91/ballerina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pubudu91/ballerina/labels{/name}","releases_url":"https://api.github.com/repos/pubudu91/ballerina/releases{/id}","deployments_url":"https://api.github.com/repos/pubudu91/ballerina/deployments","created_at":"2017-04-20T07:04:37Z","updated_at":"2018-04-25T18:17:23Z","pushed_at":"2018-10-10T06:12:32Z","git_url":"git://github.com/pubudu91/ballerina.git","ssh_url":"git@github.com:pubudu91/ballerina.git","clone_url":"https://github.com/pubudu91/ballerina.git","svn_url":"https://github.com/pubudu91/ballerina","homepage":"","size":260340,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ballerina-platform:master","ref":"master","sha":"3f775bd6b44506e97b5dfaccae479ddcc6bbb8fb","user":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":73930305,"node_id":"MDEwOlJlcG9zaXRvcnk3MzkzMDMwNQ==","name":"ballerina-lang","full_name":"ballerina-platform/ballerina-lang","private":false,"owner":{"login":"ballerina-platform","id":34733518,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzMzNTE4","avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ballerina-platform/ballerina-lang","description":"Ballerina is a compiled, transactional, statically and strongly typed programming language with textual and graphical syntaxes.","fork":false,"url":"https://api.github.com/repos/ballerina-platform/ballerina-lang","forks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/forks","keys_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/teams","hooks_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/hooks","issue_events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/events{/number}","events_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/events","assignees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/assignees{/user}","branches_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/branches{/branch}","tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/tags","blobs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/refs{/sha}","trees_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/{sha}","languages_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/languages","stargazers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/stargazers","contributors_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contributors","subscribers_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscribers","subscription_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/subscription","commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/commits{/sha}","git_commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/git/commits{/sha}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/comments{/number}","issue_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/comments{/number}","contents_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/contents/{+path}","compare_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/merges","archive_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/downloads","issues_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues{/number}","pulls_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls{/number}","milestones_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/milestones{/number}","notifications_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/labels{/name}","releases_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/releases{/id}","deployments_url":"https://api.github.com/repos/ballerina-platform/ballerina-lang/deployments","created_at":"2016-11-16T14:58:44Z","updated_at":"2018-10-10T05:57:49Z","pushed_at":"2018-10-10T06:12:34Z","git_url":"git://github.com/ballerina-platform/ballerina-lang.git","ssh_url":"git@github.com:ballerina-platform/ballerina-lang.git","clone_url":"https://github.com/ballerina-platform/ballerina-lang.git","svn_url":"https://github.com/ballerina-platform/ballerina-lang","homepage":"","size":260195,"stargazers_count":1410,"watchers_count":1410,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":397,"mirror_url":null,"archived":false,"open_issues_count":501,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":397,"open_issues":501,"watchers":1410,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10632"},"html":{"href":"https://github.com/ballerina-platform/ballerina-lang/pull/10632"},"issue":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/10632"},"comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/issues/10632/comments"},"review_comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10632/comments"},"review_comment":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/pulls/10632/commits"},"statuses":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-lang/statuses/eed04053a7b33256bc2cc0a9d35ebf1bd516bcae"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pubudu91"}}