{"action":"opened","number":1288,"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1288","id":188841108,"html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1288","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1288.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1288.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1288","number":1288,"state":"open","locked":false,"title":" Consistent names for dive modes plus enable translations","user":{"login":"sfuchs79","id":25316050,"avatar_url":"https://avatars1.githubusercontent.com/u/25316050?v=4","gravatar_id":"","url":"https://api.github.com/users/sfuchs79","html_url":"https://github.com/sfuchs79","followers_url":"https://api.github.com/users/sfuchs79/followers","following_url":"https://api.github.com/users/sfuchs79/following{/other_user}","gists_url":"https://api.github.com/users/sfuchs79/gists{/gist_id}","starred_url":"https://api.github.com/users/sfuchs79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfuchs79/subscriptions","organizations_url":"https://api.github.com/users/sfuchs79/orgs","repos_url":"https://api.github.com/users/sfuchs79/repos","events_url":"https://api.github.com/users/sfuchs79/events{/privacy}","received_events_url":"https://api.github.com/users/sfuchs79/received_events","type":"User","site_admin":false},"body":"<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [ ] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [x] Code cleanup\r\n- [ ] Build system change\r\n- [ ] Documentation change\r\n- [x] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\nConsistent names for dive modes:\r\nOpen circuit\r\nCCR\r\npSCR\r\nFreedive\r\n\r\nPlus enable translations for dive mode names and event name \"modechange\".\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\nThis is a little bit tricky because it could work as long as strings are not present in translation files but break s.th. after new strings are added. Please someone needs to carefully review this!\r\n\r\n### Release note:\r\n<!-- Describe if this change needs a release note present in CHANGELOG.md. -->\r\n<!-- Also, please make sure to add the release note on top of the file CHANGELOG.md. -->\r\n\r\n### Documentation change:\r\n<!-- If this PR makes changes to user functionality, then the documentation has to be updated too. -->\r\n<!-- Please, briefly outline here what has changed in terms of the user experience (UX). -->\r\n<!-- If UX changes have been made, a maintainer should apply the 'needs-documentation-change' label. -->\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n@atdotde @willemferguson ","created_at":"2018-05-17T19:42:15Z","updated_at":"2018-05-17T19:42:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1288/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1288/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1288/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/bd76f0314b274583afe3939915c8263d69638f0e","head":{"label":"sfuchs79:divemode_names","ref":"divemode_names","sha":"bd76f0314b274583afe3939915c8263d69638f0e","user":{"login":"sfuchs79","id":25316050,"avatar_url":"https://avatars1.githubusercontent.com/u/25316050?v=4","gravatar_id":"","url":"https://api.github.com/users/sfuchs79","html_url":"https://github.com/sfuchs79","followers_url":"https://api.github.com/users/sfuchs79/followers","following_url":"https://api.github.com/users/sfuchs79/following{/other_user}","gists_url":"https://api.github.com/users/sfuchs79/gists{/gist_id}","starred_url":"https://api.github.com/users/sfuchs79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfuchs79/subscriptions","organizations_url":"https://api.github.com/users/sfuchs79/orgs","repos_url":"https://api.github.com/users/sfuchs79/repos","events_url":"https://api.github.com/users/sfuchs79/events{/privacy}","received_events_url":"https://api.github.com/users/sfuchs79/received_events","type":"User","site_admin":false},"repo":{"id":80315820,"name":"subsurface","full_name":"sfuchs79/subsurface","owner":{"login":"sfuchs79","id":25316050,"avatar_url":"https://avatars1.githubusercontent.com/u/25316050?v=4","gravatar_id":"","url":"https://api.github.com/users/sfuchs79","html_url":"https://github.com/sfuchs79","followers_url":"https://api.github.com/users/sfuchs79/followers","following_url":"https://api.github.com/users/sfuchs79/following{/other_user}","gists_url":"https://api.github.com/users/sfuchs79/gists{/gist_id}","starred_url":"https://api.github.com/users/sfuchs79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfuchs79/subscriptions","organizations_url":"https://api.github.com/users/sfuchs79/orgs","repos_url":"https://api.github.com/users/sfuchs79/repos","events_url":"https://api.github.com/users/sfuchs79/events{/privacy}","received_events_url":"https://api.github.com/users/sfuchs79/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sfuchs79/subsurface","description":"Subsurface divelog program","fork":true,"url":"https://api.github.com/repos/sfuchs79/subsurface","forks_url":"https://api.github.com/repos/sfuchs79/subsurface/forks","keys_url":"https://api.github.com/repos/sfuchs79/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sfuchs79/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sfuchs79/subsurface/teams","hooks_url":"https://api.github.com/repos/sfuchs79/subsurface/hooks","issue_events_url":"https://api.github.com/repos/sfuchs79/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/sfuchs79/subsurface/events","assignees_url":"https://api.github.com/repos/sfuchs79/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/sfuchs79/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/sfuchs79/subsurface/tags","blobs_url":"https://api.github.com/repos/sfuchs79/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sfuchs79/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sfuchs79/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/sfuchs79/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sfuchs79/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/sfuchs79/subsurface/languages","stargazers_url":"https://api.github.com/repos/sfuchs79/subsurface/stargazers","contributors_url":"https://api.github.com/repos/sfuchs79/subsurface/contributors","subscribers_url":"https://api.github.com/repos/sfuchs79/subsurface/subscribers","subscription_url":"https://api.github.com/repos/sfuchs79/subsurface/subscription","commits_url":"https://api.github.com/repos/sfuchs79/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/sfuchs79/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/sfuchs79/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/sfuchs79/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/sfuchs79/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/sfuchs79/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sfuchs79/subsurface/merges","archive_url":"https://api.github.com/repos/sfuchs79/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sfuchs79/subsurface/downloads","issues_url":"https://api.github.com/repos/sfuchs79/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/sfuchs79/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/sfuchs79/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/sfuchs79/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sfuchs79/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/sfuchs79/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/sfuchs79/subsurface/deployments","created_at":"2017-01-28T22:44:35Z","updated_at":"2017-01-31T15:39:47Z","pushed_at":"2018-05-17T19:37:24Z","git_url":"git://github.com/sfuchs79/subsurface.git","ssh_url":"git@github.com:sfuchs79/subsurface.git","clone_url":"https://github.com/sfuchs79/subsurface.git","svn_url":"https://github.com/sfuchs79/subsurface","homepage":"","size":88490,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"21bf811a57f999423b1d37ed753364dba2d2cb8b","user":{"login":"Subsurface-divelog","id":24829199,"avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"name":"subsurface","full_name":"Subsurface-divelog/subsurface","owner":{"login":"Subsurface-divelog","id":24829199,"avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2018-05-17T18:33:00Z","pushed_at":"2018-05-17T18:48:07Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":89375,"stargazers_count":1369,"watchers_count":1369,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":349,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":349,"open_issues":75,"watchers":1369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1288"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1288"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1288"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1288/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1288/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1288/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/bd76f0314b274583afe3939915c8263d69638f0e"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":17,"deletions":14,"changed_files":6}}
{"actor":{"display_login":"sfuchs79"}}