{"action":"created","comment":{"url":"https://api.github.com/repos/KayEss/odin/pulls/comments/209241183","pull_request_review_id":145216982,"id":209241183,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTI0MTE4Mw==","diff_hunk":"@@ -0,0 +1,29 @@\n+/**\n+    Copyright 2018 Felspar Co Ltd. <http://odin.felspar.com/>\n+\n+    Distributed under the Boost Software License, Version 1.0.\n+    See <http://www.boost.org/LICENSE_1_0.txt>\n+*/\n+\n+\n+#pragma once\n+\n+#include <fost/crypto>\n+#include <fost/postgres>\n+\n+\n+namespace odin {\n+\n+    namespace app {\n+\n+        /// Return the database row for the app\n+        fostlib::json get_detail(fostlib::pg::connection &cnx, const f5::u8view &app_id);","path":"Cpp/include/odin/app.hpp","position":20,"original_position":20,"commit_id":"bcdebb67184ca679fe644596fd5d7c2959e3e8a8","original_commit_id":"bcdebb67184ca679fe644596fd5d7c2959e3e8a8","user":{"login":"KayEss","id":90561,"node_id":"MDQ6VXNlcjkwNTYx","avatar_url":"https://avatars3.githubusercontent.com/u/90561?v=4","gravatar_id":"","url":"https://api.github.com/users/KayEss","html_url":"https://github.com/KayEss","followers_url":"https://api.github.com/users/KayEss/followers","following_url":"https://api.github.com/users/KayEss/following{/other_user}","gists_url":"https://api.github.com/users/KayEss/gists{/gist_id}","starred_url":"https://api.github.com/users/KayEss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KayEss/subscriptions","organizations_url":"https://api.github.com/users/KayEss/orgs","repos_url":"https://api.github.com/users/KayEss/repos","events_url":"https://api.github.com/users/KayEss/events{/privacy}","received_events_url":"https://api.github.com/users/KayEss/received_events","type":"User","site_admin":false},"body":"You can take the `u8view` by value. Less syntactic clutter that way","created_at":"2018-08-10T12:24:09Z","updated_at":"2018-08-10T12:33:56Z","html_url":"https://github.com/KayEss/odin/pull/34#discussion_r209241183","pull_request_url":"https://api.github.com/repos/KayEss/odin/pulls/34","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/KayEss/odin/pulls/comments/209241183"},"html":{"href":"https://github.com/KayEss/odin/pull/34#discussion_r209241183"},"pull_request":{"href":"https://api.github.com/repos/KayEss/odin/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/KayEss/odin/pulls/34","id":207585240,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTg1MjQw","html_url":"https://github.com/KayEss/odin/pull/34","diff_url":"https://github.com/KayEss/odin/pull/34.diff","patch_url":"https://github.com/KayEss/odin/pull/34.patch","issue_url":"https://api.github.com/repos/KayEss/odin/issues/34","number":34,"state":"open","locked":false,"title":"App Module & app login API","user":{"login":"tleekkul","id":3469414,"node_id":"MDQ6VXNlcjM0Njk0MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/3469414?v=4","gravatar_id":"","url":"https://api.github.com/users/tleekkul","html_url":"https://github.com/tleekkul","followers_url":"https://api.github.com/users/tleekkul/followers","following_url":"https://api.github.com/users/tleekkul/following{/other_user}","gists_url":"https://api.github.com/users/tleekkul/gists{/gist_id}","starred_url":"https://api.github.com/users/tleekkul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tleekkul/subscriptions","organizations_url":"https://api.github.com/users/tleekkul/orgs","repos_url":"https://api.github.com/users/tleekkul/repos","events_url":"https://api.github.com/users/tleekkul/events{/privacy}","received_events_url":"https://api.github.com/users/tleekkul/received_events","type":"User","site_admin":false},"body":"- Add app module migrations\r\n- Add `odin.app.login` view\r\n- Can POST to API to login with App and return 303\r\n\r\n*Client request*\r\n```\r\ncurl -X POST \\\r\n  http://localhost:8001/odin/app/login/bowling_app/ \\\r\n  -H 'Content-Type: application/json' \\\r\n  -d '{\r\n\t\"username\": \"barney\",\r\n\t\"password\": \"password123\"\r\n}'\r\n```\r\n*Server response*\r\n```\r\nHTTP/1.1 303 See Other\r\nLocation: http://example.org#<APP_SPECIFIC_JWT>\r\n```\r\n","created_at":"2018-08-10T11:33:15Z","updated_at":"2018-08-10T12:33:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a58661577f760fd99d926e1a3902a4cf9647a9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KayEss/odin/pulls/34/commits","review_comments_url":"https://api.github.com/repos/KayEss/odin/pulls/34/comments","review_comment_url":"https://api.github.com/repos/KayEss/odin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KayEss/odin/issues/34/comments","statuses_url":"https://api.github.com/repos/KayEss/odin/statuses/bcdebb67184ca679fe644596fd5d7c2959e3e8a8","head":{"label":"KayEss:feature/odin-21","ref":"feature/odin-21","sha":"bcdebb67184ca679fe644596fd5d7c2959e3e8a8","user":{"login":"KayEss","id":90561,"node_id":"MDQ6VXNlcjkwNTYx","avatar_url":"https://avatars3.githubusercontent.com/u/90561?v=4","gravatar_id":"","url":"https://api.github.com/users/KayEss","html_url":"https://github.com/KayEss","followers_url":"https://api.github.com/users/KayEss/followers","following_url":"https://api.github.com/users/KayEss/following{/other_user}","gists_url":"https://api.github.com/users/KayEss/gists{/gist_id}","starred_url":"https://api.github.com/users/KayEss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KayEss/subscriptions","organizations_url":"https://api.github.com/users/KayEss/orgs","repos_url":"https://api.github.com/users/KayEss/repos","events_url":"https://api.github.com/users/KayEss/events{/privacy}","received_events_url":"https://api.github.com/users/KayEss/received_events","type":"User","site_admin":false},"repo":{"id":62944112,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk0NDExMg==","name":"odin","full_name":"KayEss/odin","owner":{"login":"KayEss","id":90561,"node_id":"MDQ6VXNlcjkwNTYx","avatar_url":"https://avatars3.githubusercontent.com/u/90561?v=4","gravatar_id":"","url":"https://api.github.com/users/KayEss","html_url":"https://github.com/KayEss","followers_url":"https://api.github.com/users/KayEss/followers","following_url":"https://api.github.com/users/KayEss/following{/other_user}","gists_url":"https://api.github.com/users/KayEss/gists{/gist_id}","starred_url":"https://api.github.com/users/KayEss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KayEss/subscriptions","organizations_url":"https://api.github.com/users/KayEss/orgs","repos_url":"https://api.github.com/users/KayEss/repos","events_url":"https://api.github.com/users/KayEss/events{/privacy}","received_events_url":"https://api.github.com/users/KayEss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KayEss/odin","description":"Authentication and authorisation plug in for Mengmom and Fostgres","fork":false,"url":"https://api.github.com/repos/KayEss/odin","forks_url":"https://api.github.com/repos/KayEss/odin/forks","keys_url":"https://api.github.com/repos/KayEss/odin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KayEss/odin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KayEss/odin/teams","hooks_url":"https://api.github.com/repos/KayEss/odin/hooks","issue_events_url":"https://api.github.com/repos/KayEss/odin/issues/events{/number}","events_url":"https://api.github.com/repos/KayEss/odin/events","assignees_url":"https://api.github.com/repos/KayEss/odin/assignees{/user}","branches_url":"https://api.github.com/repos/KayEss/odin/branches{/branch}","tags_url":"https://api.github.com/repos/KayEss/odin/tags","blobs_url":"https://api.github.com/repos/KayEss/odin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KayEss/odin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KayEss/odin/git/refs{/sha}","trees_url":"https://api.github.com/repos/KayEss/odin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KayEss/odin/statuses/{sha}","languages_url":"https://api.github.com/repos/KayEss/odin/languages","stargazers_url":"https://api.github.com/repos/KayEss/odin/stargazers","contributors_url":"https://api.github.com/repos/KayEss/odin/contributors","subscribers_url":"https://api.github.com/repos/KayEss/odin/subscribers","subscription_url":"https://api.github.com/repos/KayEss/odin/subscription","commits_url":"https://api.github.com/repos/KayEss/odin/commits{/sha}","git_commits_url":"https://api.github.com/repos/KayEss/odin/git/commits{/sha}","comments_url":"https://api.github.com/repos/KayEss/odin/comments{/number}","issue_comment_url":"https://api.github.com/repos/KayEss/odin/issues/comments{/number}","contents_url":"https://api.github.com/repos/KayEss/odin/contents/{+path}","compare_url":"https://api.github.com/repos/KayEss/odin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KayEss/odin/merges","archive_url":"https://api.github.com/repos/KayEss/odin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KayEss/odin/downloads","issues_url":"https://api.github.com/repos/KayEss/odin/issues{/number}","pulls_url":"https://api.github.com/repos/KayEss/odin/pulls{/number}","milestones_url":"https://api.github.com/repos/KayEss/odin/milestones{/number}","notifications_url":"https://api.github.com/repos/KayEss/odin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KayEss/odin/labels{/name}","releases_url":"https://api.github.com/repos/KayEss/odin/releases{/id}","deployments_url":"https://api.github.com/repos/KayEss/odin/deployments","created_at":"2016-07-09T10:18:27Z","updated_at":"2018-06-21T05:40:33Z","pushed_at":"2018-08-10T11:36:56Z","git_url":"git://github.com/KayEss/odin.git","ssh_url":"git@github.com:KayEss/odin.git","clone_url":"https://github.com/KayEss/odin.git","svn_url":"https://github.com/KayEss/odin","homepage":"","size":327,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":2,"open_issues":8,"watchers":0,"default_branch":"master"}},"base":{"label":"KayEss:develop","ref":"develop","sha":"7974e118be482b520f1998a3056f83f68afd02ec","user":{"login":"KayEss","id":90561,"node_id":"MDQ6VXNlcjkwNTYx","avatar_url":"https://avatars3.githubusercontent.com/u/90561?v=4","gravatar_id":"","url":"https://api.github.com/users/KayEss","html_url":"https://github.com/KayEss","followers_url":"https://api.github.com/users/KayEss/followers","following_url":"https://api.github.com/users/KayEss/following{/other_user}","gists_url":"https://api.github.com/users/KayEss/gists{/gist_id}","starred_url":"https://api.github.com/users/KayEss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KayEss/subscriptions","organizations_url":"https://api.github.com/users/KayEss/orgs","repos_url":"https://api.github.com/users/KayEss/repos","events_url":"https://api.github.com/users/KayEss/events{/privacy}","received_events_url":"https://api.github.com/users/KayEss/received_events","type":"User","site_admin":false},"repo":{"id":62944112,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjk0NDExMg==","name":"odin","full_name":"KayEss/odin","owner":{"login":"KayEss","id":90561,"node_id":"MDQ6VXNlcjkwNTYx","avatar_url":"https://avatars3.githubusercontent.com/u/90561?v=4","gravatar_id":"","url":"https://api.github.com/users/KayEss","html_url":"https://github.com/KayEss","followers_url":"https://api.github.com/users/KayEss/followers","following_url":"https://api.github.com/users/KayEss/following{/other_user}","gists_url":"https://api.github.com/users/KayEss/gists{/gist_id}","starred_url":"https://api.github.com/users/KayEss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KayEss/subscriptions","organizations_url":"https://api.github.com/users/KayEss/orgs","repos_url":"https://api.github.com/users/KayEss/repos","events_url":"https://api.github.com/users/KayEss/events{/privacy}","received_events_url":"https://api.github.com/users/KayEss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KayEss/odin","description":"Authentication and authorisation plug in for Mengmom and Fostgres","fork":false,"url":"https://api.github.com/repos/KayEss/odin","forks_url":"https://api.github.com/repos/KayEss/odin/forks","keys_url":"https://api.github.com/repos/KayEss/odin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KayEss/odin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KayEss/odin/teams","hooks_url":"https://api.github.com/repos/KayEss/odin/hooks","issue_events_url":"https://api.github.com/repos/KayEss/odin/issues/events{/number}","events_url":"https://api.github.com/repos/KayEss/odin/events","assignees_url":"https://api.github.com/repos/KayEss/odin/assignees{/user}","branches_url":"https://api.github.com/repos/KayEss/odin/branches{/branch}","tags_url":"https://api.github.com/repos/KayEss/odin/tags","blobs_url":"https://api.github.com/repos/KayEss/odin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KayEss/odin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KayEss/odin/git/refs{/sha}","trees_url":"https://api.github.com/repos/KayEss/odin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KayEss/odin/statuses/{sha}","languages_url":"https://api.github.com/repos/KayEss/odin/languages","stargazers_url":"https://api.github.com/repos/KayEss/odin/stargazers","contributors_url":"https://api.github.com/repos/KayEss/odin/contributors","subscribers_url":"https://api.github.com/repos/KayEss/odin/subscribers","subscription_url":"https://api.github.com/repos/KayEss/odin/subscription","commits_url":"https://api.github.com/repos/KayEss/odin/commits{/sha}","git_commits_url":"https://api.github.com/repos/KayEss/odin/git/commits{/sha}","comments_url":"https://api.github.com/repos/KayEss/odin/comments{/number}","issue_comment_url":"https://api.github.com/repos/KayEss/odin/issues/comments{/number}","contents_url":"https://api.github.com/repos/KayEss/odin/contents/{+path}","compare_url":"https://api.github.com/repos/KayEss/odin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KayEss/odin/merges","archive_url":"https://api.github.com/repos/KayEss/odin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KayEss/odin/downloads","issues_url":"https://api.github.com/repos/KayEss/odin/issues{/number}","pulls_url":"https://api.github.com/repos/KayEss/odin/pulls{/number}","milestones_url":"https://api.github.com/repos/KayEss/odin/milestones{/number}","notifications_url":"https://api.github.com/repos/KayEss/odin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KayEss/odin/labels{/name}","releases_url":"https://api.github.com/repos/KayEss/odin/releases{/id}","deployments_url":"https://api.github.com/repos/KayEss/odin/deployments","created_at":"2016-07-09T10:18:27Z","updated_at":"2018-06-21T05:40:33Z","pushed_at":"2018-08-10T11:36:56Z","git_url":"git://github.com/KayEss/odin.git","ssh_url":"git@github.com:KayEss/odin.git","clone_url":"https://github.com/KayEss/odin.git","svn_url":"https://github.com/KayEss/odin","homepage":"","size":327,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":2,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KayEss/odin/pulls/34"},"html":{"href":"https://github.com/KayEss/odin/pull/34"},"issue":{"href":"https://api.github.com/repos/KayEss/odin/issues/34"},"comments":{"href":"https://api.github.com/repos/KayEss/odin/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/KayEss/odin/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/KayEss/odin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KayEss/odin/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/KayEss/odin/statuses/bcdebb67184ca679fe644596fd5d7c2959e3e8a8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"KayEss"}}