{"action":"created","comment":{"url":"https://api.github.com/repos/datamade/large-lots/pulls/comments/167007307","pull_request_review_id":95160254,"id":167007307,"diff_hunk":"@@ -116,6 +116,7 @@ <h4>{{content.data.street_number}} {{content.data.dir}} {{content.data.street_na\n     <script type=\"text/javascript\" src=\"https://maps.google.com/maps/api/js?sensor=false&libraries=places&v=3.17&key=AIzaSyCSg3bQurfz0U61uKn_8CYgPHzcl_Y2JE8\"></script>\n     <script src=\"{% static 'js/lib/jquery.address.js' %}\"></script>\n     <script src=\"{% static 'js/lib/jquery.scrollto.js' %}\"></script>\n+    <script src=\"{% static 'js/lib/jquery-ui.js' %}\"></script>","path":"templates/apply.html","position":4,"original_position":4,"commit_id":"aec58ec8e772d26c117e230adc11970f592aed1e","original_commit_id":"3a7051d56b258f51ac97d3967eb74f31916544c2","user":{"login":"reginafcompton","id":13078679,"avatar_url":"https://avatars1.githubusercontent.com/u/13078679?v=4","gravatar_id":"","url":"https://api.github.com/users/reginafcompton","html_url":"https://github.com/reginafcompton","followers_url":"https://api.github.com/users/reginafcompton/followers","following_url":"https://api.github.com/users/reginafcompton/following{/other_user}","gists_url":"https://api.github.com/users/reginafcompton/gists{/gist_id}","starred_url":"https://api.github.com/users/reginafcompton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reginafcompton/subscriptions","organizations_url":"https://api.github.com/users/reginafcompton/orgs","repos_url":"https://api.github.com/users/reginafcompton/repos","events_url":"https://api.github.com/users/reginafcompton/events{/privacy}","received_events_url":"https://api.github.com/users/reginafcompton/received_events","type":"User","site_admin":false},"body":"Are we? I do not see this library loaded there. (N.B. JQueryUI is a library built on top of JQuery: https://jqueryui.com/)","created_at":"2018-02-08T17:20:03Z","updated_at":"2018-02-08T17:20:03Z","html_url":"https://github.com/datamade/large-lots/pull/316#discussion_r167007307","pull_request_url":"https://api.github.com/repos/datamade/large-lots/pulls/316","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/datamade/large-lots/pulls/comments/167007307"},"html":{"href":"https://github.com/datamade/large-lots/pull/316#discussion_r167007307"},"pull_request":{"href":"https://api.github.com/repos/datamade/large-lots/pulls/316"}},"in_reply_to_id":166981162},"pull_request":{"url":"https://api.github.com/repos/datamade/large-lots/pulls/316","id":166923208,"html_url":"https://github.com/datamade/large-lots/pull/316","diff_url":"https://github.com/datamade/large-lots/pull/316.diff","patch_url":"https://github.com/datamade/large-lots/pull/316.patch","issue_url":"https://api.github.com/repos/datamade/large-lots/issues/316","number":316,"state":"open","locked":false,"title":"Address validation","user":{"login":"reginafcompton","id":13078679,"avatar_url":"https://avatars1.githubusercontent.com/u/13078679?v=4","gravatar_id":"","url":"https://api.github.com/users/reginafcompton","html_url":"https://github.com/reginafcompton","followers_url":"https://api.github.com/users/reginafcompton/followers","following_url":"https://api.github.com/users/reginafcompton/following{/other_user}","gists_url":"https://api.github.com/users/reginafcompton/gists{/gist_id}","starred_url":"https://api.github.com/users/reginafcompton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reginafcompton/subscriptions","organizations_url":"https://api.github.com/users/reginafcompton/orgs","repos_url":"https://api.github.com/users/reginafcompton/repos","events_url":"https://api.github.com/users/reginafcompton/events{/privacy}","received_events_url":"https://api.github.com/users/reginafcompton/received_events","type":"User","site_admin":false},"body":"This PR handles issue #295 and #322 \r\n\r\nThis PR also implements JSHint. I added a few custom configurations in `.jshintrc`:\r\n- `\"asi\": true` - [turns off the \"missing semicolon\" warning (unless we want this?)](http://jshint.com/docs/options/#asi)\r\n- `\"sub\": true` - http://jshint.com/docs/options/#sub\r\n- `\"multistr\": true` - http://jshint.com/docs/options/#multistr\r\n\r\nI learned a couple things when running jshint:\r\n\r\n* We tend to close function declarations with semicolons, though [our preferred style guide](https://github.com/datamade/node-style-guide) does not recommend it, not does JSHint. Let's be cautious of this.\r\n* We call view/context variables in the JS - an entirely common practice (e.g., \"{{ my_context_variable_made_avaliable_in_the_template }}\"). I found an instance where we (1) did not stringify the variable, and (2) called a Django filter on the JS side (e.g., {{ variable|safe }}).  It seems safer to convert such variables to JSON on the python side and then parse it on the JS side. (We can also use [escapejs](https://docs.djangoproject.com/en/2.0/ref/templates/builtins/#escapejs) when appropriate, too.) \r\n\r\n@hancush - I'd like to start documenting these JS \"hints\" (as it were) in the testing guidelines. At end of [this section](https://github.com/datamade/testing-guidelines/blob/master/intro-to-javascript-testing.md) makes sense, no?\r\n","created_at":"2018-02-02T23:01:12Z","updated_at":"2018-02-08T17:20:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43c9b848344c426f9e2511f2890da4a22eb12dc1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/datamade/large-lots/pulls/316/commits","review_comments_url":"https://api.github.com/repos/datamade/large-lots/pulls/316/comments","review_comment_url":"https://api.github.com/repos/datamade/large-lots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datamade/large-lots/issues/316/comments","statuses_url":"https://api.github.com/repos/datamade/large-lots/statuses/aec58ec8e772d26c117e230adc11970f592aed1e","head":{"label":"datamade:address-verify","ref":"address-verify","sha":"aec58ec8e772d26c117e230adc11970f592aed1e","user":{"login":"datamade","id":3723931,"avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"repo":{"id":18152936,"name":"large-lots","full_name":"datamade/large-lots","owner":{"login":"datamade","id":3723931,"avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datamade/large-lots","description":":seedling: The City of Chicago is selling vacant residential lots for $1. Here's how you get one.","fork":false,"url":"https://api.github.com/repos/datamade/large-lots","forks_url":"https://api.github.com/repos/datamade/large-lots/forks","keys_url":"https://api.github.com/repos/datamade/large-lots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datamade/large-lots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datamade/large-lots/teams","hooks_url":"https://api.github.com/repos/datamade/large-lots/hooks","issue_events_url":"https://api.github.com/repos/datamade/large-lots/issues/events{/number}","events_url":"https://api.github.com/repos/datamade/large-lots/events","assignees_url":"https://api.github.com/repos/datamade/large-lots/assignees{/user}","branches_url":"https://api.github.com/repos/datamade/large-lots/branches{/branch}","tags_url":"https://api.github.com/repos/datamade/large-lots/tags","blobs_url":"https://api.github.com/repos/datamade/large-lots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datamade/large-lots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datamade/large-lots/git/refs{/sha}","trees_url":"https://api.github.com/repos/datamade/large-lots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datamade/large-lots/statuses/{sha}","languages_url":"https://api.github.com/repos/datamade/large-lots/languages","stargazers_url":"https://api.github.com/repos/datamade/large-lots/stargazers","contributors_url":"https://api.github.com/repos/datamade/large-lots/contributors","subscribers_url":"https://api.github.com/repos/datamade/large-lots/subscribers","subscription_url":"https://api.github.com/repos/datamade/large-lots/subscription","commits_url":"https://api.github.com/repos/datamade/large-lots/commits{/sha}","git_commits_url":"https://api.github.com/repos/datamade/large-lots/git/commits{/sha}","comments_url":"https://api.github.com/repos/datamade/large-lots/comments{/number}","issue_comment_url":"https://api.github.com/repos/datamade/large-lots/issues/comments{/number}","contents_url":"https://api.github.com/repos/datamade/large-lots/contents/{+path}","compare_url":"https://api.github.com/repos/datamade/large-lots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datamade/large-lots/merges","archive_url":"https://api.github.com/repos/datamade/large-lots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datamade/large-lots/downloads","issues_url":"https://api.github.com/repos/datamade/large-lots/issues{/number}","pulls_url":"https://api.github.com/repos/datamade/large-lots/pulls{/number}","milestones_url":"https://api.github.com/repos/datamade/large-lots/milestones{/number}","notifications_url":"https://api.github.com/repos/datamade/large-lots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datamade/large-lots/labels{/name}","releases_url":"https://api.github.com/repos/datamade/large-lots/releases{/id}","deployments_url":"https://api.github.com/repos/datamade/large-lots/deployments","created_at":"2014-03-26T20:34:00Z","updated_at":"2018-01-24T01:14:42Z","pushed_at":"2018-02-08T17:15:12Z","git_url":"git://github.com/datamade/large-lots.git","ssh_url":"git@github.com:datamade/large-lots.git","clone_url":"https://github.com/datamade/large-lots.git","svn_url":"https://github.com/datamade/large-lots","homepage":"http://largelots.org/","size":48510,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":38,"watchers":12,"default_branch":"master"}},"base":{"label":"datamade:master","ref":"master","sha":"5b155be884757f1bc82f1b6edcb8b914648602fa","user":{"login":"datamade","id":3723931,"avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"repo":{"id":18152936,"name":"large-lots","full_name":"datamade/large-lots","owner":{"login":"datamade","id":3723931,"avatar_url":"https://avatars3.githubusercontent.com/u/3723931?v=4","gravatar_id":"","url":"https://api.github.com/users/datamade","html_url":"https://github.com/datamade","followers_url":"https://api.github.com/users/datamade/followers","following_url":"https://api.github.com/users/datamade/following{/other_user}","gists_url":"https://api.github.com/users/datamade/gists{/gist_id}","starred_url":"https://api.github.com/users/datamade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datamade/subscriptions","organizations_url":"https://api.github.com/users/datamade/orgs","repos_url":"https://api.github.com/users/datamade/repos","events_url":"https://api.github.com/users/datamade/events{/privacy}","received_events_url":"https://api.github.com/users/datamade/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/datamade/large-lots","description":":seedling: The City of Chicago is selling vacant residential lots for $1. Here's how you get one.","fork":false,"url":"https://api.github.com/repos/datamade/large-lots","forks_url":"https://api.github.com/repos/datamade/large-lots/forks","keys_url":"https://api.github.com/repos/datamade/large-lots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datamade/large-lots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datamade/large-lots/teams","hooks_url":"https://api.github.com/repos/datamade/large-lots/hooks","issue_events_url":"https://api.github.com/repos/datamade/large-lots/issues/events{/number}","events_url":"https://api.github.com/repos/datamade/large-lots/events","assignees_url":"https://api.github.com/repos/datamade/large-lots/assignees{/user}","branches_url":"https://api.github.com/repos/datamade/large-lots/branches{/branch}","tags_url":"https://api.github.com/repos/datamade/large-lots/tags","blobs_url":"https://api.github.com/repos/datamade/large-lots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datamade/large-lots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datamade/large-lots/git/refs{/sha}","trees_url":"https://api.github.com/repos/datamade/large-lots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datamade/large-lots/statuses/{sha}","languages_url":"https://api.github.com/repos/datamade/large-lots/languages","stargazers_url":"https://api.github.com/repos/datamade/large-lots/stargazers","contributors_url":"https://api.github.com/repos/datamade/large-lots/contributors","subscribers_url":"https://api.github.com/repos/datamade/large-lots/subscribers","subscription_url":"https://api.github.com/repos/datamade/large-lots/subscription","commits_url":"https://api.github.com/repos/datamade/large-lots/commits{/sha}","git_commits_url":"https://api.github.com/repos/datamade/large-lots/git/commits{/sha}","comments_url":"https://api.github.com/repos/datamade/large-lots/comments{/number}","issue_comment_url":"https://api.github.com/repos/datamade/large-lots/issues/comments{/number}","contents_url":"https://api.github.com/repos/datamade/large-lots/contents/{+path}","compare_url":"https://api.github.com/repos/datamade/large-lots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datamade/large-lots/merges","archive_url":"https://api.github.com/repos/datamade/large-lots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datamade/large-lots/downloads","issues_url":"https://api.github.com/repos/datamade/large-lots/issues{/number}","pulls_url":"https://api.github.com/repos/datamade/large-lots/pulls{/number}","milestones_url":"https://api.github.com/repos/datamade/large-lots/milestones{/number}","notifications_url":"https://api.github.com/repos/datamade/large-lots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datamade/large-lots/labels{/name}","releases_url":"https://api.github.com/repos/datamade/large-lots/releases{/id}","deployments_url":"https://api.github.com/repos/datamade/large-lots/deployments","created_at":"2014-03-26T20:34:00Z","updated_at":"2018-01-24T01:14:42Z","pushed_at":"2018-02-08T17:15:12Z","git_url":"git://github.com/datamade/large-lots.git","ssh_url":"git@github.com:datamade/large-lots.git","clone_url":"https://github.com/datamade/large-lots.git","svn_url":"https://github.com/datamade/large-lots","homepage":"http://largelots.org/","size":48510,"stargazers_count":12,"watchers_count":12,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":38,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datamade/large-lots/pulls/316"},"html":{"href":"https://github.com/datamade/large-lots/pull/316"},"issue":{"href":"https://api.github.com/repos/datamade/large-lots/issues/316"},"comments":{"href":"https://api.github.com/repos/datamade/large-lots/issues/316/comments"},"review_comments":{"href":"https://api.github.com/repos/datamade/large-lots/pulls/316/comments"},"review_comment":{"href":"https://api.github.com/repos/datamade/large-lots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datamade/large-lots/pulls/316/commits"},"statuses":{"href":"https://api.github.com/repos/datamade/large-lots/statuses/aec58ec8e772d26c117e230adc11970f592aed1e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"reginafcompton"}}