{"action":"created","comment":{"url":"https://api.github.com/repos/consul/consul/pulls/comments/219461360","pull_request_review_id":157635327,"id":219461360,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQ2MTM2MA==","diff_hunk":"@@ -116,6 +116,8 @@\n     t.datetime \"updated_at\",                  null: false\n     t.text     \"background_color\"\n     t.text     \"font_color\"\n+    t.string   \"banner_position\"\n+    t.text     \"headings\"","path":"db/schema.rb","position":14,"original_position":14,"commit_id":"3fcb4114ca2191ab73cd817aaa36aea0e21109c8","original_commit_id":"3fcb4114ca2191ab73cd817aaa36aea0e21109c8","user":{"login":"javierm","id":35156,"node_id":"MDQ6VXNlcjM1MTU2","avatar_url":"https://avatars0.githubusercontent.com/u/35156?v=4","gravatar_id":"","url":"https://api.github.com/users/javierm","html_url":"https://github.com/javierm","followers_url":"https://api.github.com/users/javierm/followers","following_url":"https://api.github.com/users/javierm/following{/other_user}","gists_url":"https://api.github.com/users/javierm/gists{/gist_id}","starred_url":"https://api.github.com/users/javierm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javierm/subscriptions","organizations_url":"https://api.github.com/users/javierm/orgs","repos_url":"https://api.github.com/users/javierm/repos","events_url":"https://api.github.com/users/javierm/events{/privacy}","received_events_url":"https://api.github.com/users/javierm/received_events","type":"User","site_admin":false},"body":"I think these lines aren't related to this pull request.","created_at":"2018-09-21T11:08:22Z","updated_at":"2018-09-21T11:13:59Z","html_url":"https://github.com/consul/consul/pull/2913#discussion_r219461360","pull_request_url":"https://api.github.com/repos/consul/consul/pulls/2913","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/consul/consul/pulls/comments/219461360"},"html":{"href":"https://github.com/consul/consul/pull/2913#discussion_r219461360"},"pull_request":{"href":"https://api.github.com/repos/consul/consul/pulls/2913"}}},"pull_request":{"url":"https://api.github.com/repos/consul/consul/pulls/2913","id":216968869,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTY4ODY5","html_url":"https://github.com/consul/consul/pull/2913","diff_url":"https://github.com/consul/consul/pull/2913.diff","patch_url":"https://github.com/consul/consul/pull/2913.patch","issue_url":"https://api.github.com/repos/consul/consul/issues/2913","number":2913,"state":"open","locked":false,"title":"Updates translatable custom pages","user":{"login":"papayalabs","id":5271149,"node_id":"MDQ6VXNlcjUyNzExNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5271149?v=4","gravatar_id":"","url":"https://api.github.com/users/papayalabs","html_url":"https://github.com/papayalabs","followers_url":"https://api.github.com/users/papayalabs/followers","following_url":"https://api.github.com/users/papayalabs/following{/other_user}","gists_url":"https://api.github.com/users/papayalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/papayalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papayalabs/subscriptions","organizations_url":"https://api.github.com/users/papayalabs/orgs","repos_url":"https://api.github.com/users/papayalabs/repos","events_url":"https://api.github.com/users/papayalabs/events{/privacy}","received_events_url":"https://api.github.com/users/papayalabs/received_events","type":"User","site_admin":false},"body":"References\r\n===================\r\nIssue [#2741](https://github.com/consul/consul/issues/2741)\r\n\r\nVisual Changes\r\n===================\r\n> In custom page index we replace 'title' with 'slug' because title could be in many languages. We drop 'locale' from table because does not make sense now.\r\n![screen shot 2018-08-06 at 3 51 03 pm](https://user-images.githubusercontent.com/5271149/43740798-ef4a590c-9991-11e8-8c3d-a66755ed0c77.jpg)\r\nEditing with many languages\r\n![screen shot 2018-08-06 at 3 51 16 pm](https://user-images.githubusercontent.com/5271149/43740831-09e0693c-9992-11e8-8b05-07054630d6f8.jpg)\r\n\r\n\r\nNotes\r\n===================\r\nIn custom page index we replace 'title' with 'slug' because title could be in many languages. We drop 'locale' from table because does not make sense now.\r\n\r\nIn the migration of translation tables of custom pages ( 20180802221830_add_translate_pages.rb ) we add a change_column to allow null in title. Title is not used anymore as index in table and now is used in many languages title_en,title_es,title_fr, etc. Give NullConstraint from database if do not make this change.\r\n\r\n    class AddTranslatePages < ActiveRecord::Migration\r\n      def self.up\r\n        SiteCustomization::Page.create_translation_table!({\r\n          title: :string,\r\n          subtitle: :string,\r\n          content: :text\r\n        })\r\n        change_column :site_customization_pages, :title, :string, :null => true\r\n      end\r\n\r\n      def self.down\r\n        SiteCustomization::Page.drop_translation_table!\r\n        change_column :site_customization_pages, :title, :string, :null => false\r\n      end\r\n    end\r\n","created_at":"2018-09-20T13:19:05Z","updated_at":"2018-09-21T11:13:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0f904f6a0a948849062fa23ae82df9e21db4923","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/consul/consul/pulls/2913/commits","review_comments_url":"https://api.github.com/repos/consul/consul/pulls/2913/comments","review_comment_url":"https://api.github.com/repos/consul/consul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/consul/consul/issues/2913/comments","statuses_url":"https://api.github.com/repos/consul/consul/statuses/3fcb4114ca2191ab73cd817aaa36aea0e21109c8","head":{"label":"papayalabs:2741-updates-translatable-custom-pages-reloaded","ref":"2741-updates-translatable-custom-pages-reloaded","sha":"3fcb4114ca2191ab73cd817aaa36aea0e21109c8","user":{"login":"papayalabs","id":5271149,"node_id":"MDQ6VXNlcjUyNzExNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5271149?v=4","gravatar_id":"","url":"https://api.github.com/users/papayalabs","html_url":"https://github.com/papayalabs","followers_url":"https://api.github.com/users/papayalabs/followers","following_url":"https://api.github.com/users/papayalabs/following{/other_user}","gists_url":"https://api.github.com/users/papayalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/papayalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papayalabs/subscriptions","organizations_url":"https://api.github.com/users/papayalabs/orgs","repos_url":"https://api.github.com/users/papayalabs/repos","events_url":"https://api.github.com/users/papayalabs/events{/privacy}","received_events_url":"https://api.github.com/users/papayalabs/received_events","type":"User","site_admin":false},"repo":{"id":143572624,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1NzI2MjQ=","name":"consul","full_name":"papayalabs/consul","private":false,"owner":{"login":"papayalabs","id":5271149,"node_id":"MDQ6VXNlcjUyNzExNDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5271149?v=4","gravatar_id":"","url":"https://api.github.com/users/papayalabs","html_url":"https://github.com/papayalabs","followers_url":"https://api.github.com/users/papayalabs/followers","following_url":"https://api.github.com/users/papayalabs/following{/other_user}","gists_url":"https://api.github.com/users/papayalabs/gists{/gist_id}","starred_url":"https://api.github.com/users/papayalabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papayalabs/subscriptions","organizations_url":"https://api.github.com/users/papayalabs/orgs","repos_url":"https://api.github.com/users/papayalabs/repos","events_url":"https://api.github.com/users/papayalabs/events{/privacy}","received_events_url":"https://api.github.com/users/papayalabs/received_events","type":"User","site_admin":false},"html_url":"https://github.com/papayalabs/consul","description":"Consul - Open Government and E-Participation Web Software","fork":true,"url":"https://api.github.com/repos/papayalabs/consul","forks_url":"https://api.github.com/repos/papayalabs/consul/forks","keys_url":"https://api.github.com/repos/papayalabs/consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/papayalabs/consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/papayalabs/consul/teams","hooks_url":"https://api.github.com/repos/papayalabs/consul/hooks","issue_events_url":"https://api.github.com/repos/papayalabs/consul/issues/events{/number}","events_url":"https://api.github.com/repos/papayalabs/consul/events","assignees_url":"https://api.github.com/repos/papayalabs/consul/assignees{/user}","branches_url":"https://api.github.com/repos/papayalabs/consul/branches{/branch}","tags_url":"https://api.github.com/repos/papayalabs/consul/tags","blobs_url":"https://api.github.com/repos/papayalabs/consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/papayalabs/consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/papayalabs/consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/papayalabs/consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/papayalabs/consul/statuses/{sha}","languages_url":"https://api.github.com/repos/papayalabs/consul/languages","stargazers_url":"https://api.github.com/repos/papayalabs/consul/stargazers","contributors_url":"https://api.github.com/repos/papayalabs/consul/contributors","subscribers_url":"https://api.github.com/repos/papayalabs/consul/subscribers","subscription_url":"https://api.github.com/repos/papayalabs/consul/subscription","commits_url":"https://api.github.com/repos/papayalabs/consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/papayalabs/consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/papayalabs/consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/papayalabs/consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/papayalabs/consul/contents/{+path}","compare_url":"https://api.github.com/repos/papayalabs/consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/papayalabs/consul/merges","archive_url":"https://api.github.com/repos/papayalabs/consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/papayalabs/consul/downloads","issues_url":"https://api.github.com/repos/papayalabs/consul/issues{/number}","pulls_url":"https://api.github.com/repos/papayalabs/consul/pulls{/number}","milestones_url":"https://api.github.com/repos/papayalabs/consul/milestones{/number}","notifications_url":"https://api.github.com/repos/papayalabs/consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/papayalabs/consul/labels{/name}","releases_url":"https://api.github.com/repos/papayalabs/consul/releases{/id}","deployments_url":"https://api.github.com/repos/papayalabs/consul/deployments","created_at":"2018-08-05T00:37:42Z","updated_at":"2018-09-19T14:38:34Z","pushed_at":"2018-09-20T13:15:54Z","git_url":"git://github.com/papayalabs/consul.git","ssh_url":"git@github.com:papayalabs/consul.git","clone_url":"https://github.com/papayalabs/consul.git","svn_url":"https://github.com/papayalabs/consul","homepage":"","size":36208,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"consul:master","ref":"master","sha":"c1d705ff30216fc239f903f479d30211872775f1","user":{"login":"consul","id":14167322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY3MzIy","avatar_url":"https://avatars2.githubusercontent.com/u/14167322?v=4","gravatar_id":"","url":"https://api.github.com/users/consul","html_url":"https://github.com/consul","followers_url":"https://api.github.com/users/consul/followers","following_url":"https://api.github.com/users/consul/following{/other_user}","gists_url":"https://api.github.com/users/consul/gists{/gist_id}","starred_url":"https://api.github.com/users/consul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/consul/subscriptions","organizations_url":"https://api.github.com/users/consul/orgs","repos_url":"https://api.github.com/users/consul/repos","events_url":"https://api.github.com/users/consul/events{/privacy}","received_events_url":"https://api.github.com/users/consul/received_events","type":"Organization","site_admin":false},"repo":{"id":39152554,"node_id":"MDEwOlJlcG9zaXRvcnkzOTE1MjU1NA==","name":"consul","full_name":"consul/consul","private":false,"owner":{"login":"consul","id":14167322,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTY3MzIy","avatar_url":"https://avatars2.githubusercontent.com/u/14167322?v=4","gravatar_id":"","url":"https://api.github.com/users/consul","html_url":"https://github.com/consul","followers_url":"https://api.github.com/users/consul/followers","following_url":"https://api.github.com/users/consul/following{/other_user}","gists_url":"https://api.github.com/users/consul/gists{/gist_id}","starred_url":"https://api.github.com/users/consul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/consul/subscriptions","organizations_url":"https://api.github.com/users/consul/orgs","repos_url":"https://api.github.com/users/consul/repos","events_url":"https://api.github.com/users/consul/events{/privacy}","received_events_url":"https://api.github.com/users/consul/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/consul/consul","description":"Consul - Open Government and E-Participation Web Software","fork":false,"url":"https://api.github.com/repos/consul/consul","forks_url":"https://api.github.com/repos/consul/consul/forks","keys_url":"https://api.github.com/repos/consul/consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/consul/consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/consul/consul/teams","hooks_url":"https://api.github.com/repos/consul/consul/hooks","issue_events_url":"https://api.github.com/repos/consul/consul/issues/events{/number}","events_url":"https://api.github.com/repos/consul/consul/events","assignees_url":"https://api.github.com/repos/consul/consul/assignees{/user}","branches_url":"https://api.github.com/repos/consul/consul/branches{/branch}","tags_url":"https://api.github.com/repos/consul/consul/tags","blobs_url":"https://api.github.com/repos/consul/consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/consul/consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/consul/consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/consul/consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/consul/consul/statuses/{sha}","languages_url":"https://api.github.com/repos/consul/consul/languages","stargazers_url":"https://api.github.com/repos/consul/consul/stargazers","contributors_url":"https://api.github.com/repos/consul/consul/contributors","subscribers_url":"https://api.github.com/repos/consul/consul/subscribers","subscription_url":"https://api.github.com/repos/consul/consul/subscription","commits_url":"https://api.github.com/repos/consul/consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/consul/consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/consul/consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/consul/consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/consul/consul/contents/{+path}","compare_url":"https://api.github.com/repos/consul/consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/consul/consul/merges","archive_url":"https://api.github.com/repos/consul/consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/consul/consul/downloads","issues_url":"https://api.github.com/repos/consul/consul/issues{/number}","pulls_url":"https://api.github.com/repos/consul/consul/pulls{/number}","milestones_url":"https://api.github.com/repos/consul/consul/milestones{/number}","notifications_url":"https://api.github.com/repos/consul/consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/consul/consul/labels{/name}","releases_url":"https://api.github.com/repos/consul/consul/releases{/id}","deployments_url":"https://api.github.com/repos/consul/consul/deployments","created_at":"2015-07-15T18:04:16Z","updated_at":"2018-09-21T10:59:17Z","pushed_at":"2018-09-21T11:10:07Z","git_url":"git://github.com/consul/consul.git","ssh_url":"git@github.com:consul/consul.git","clone_url":"https://github.com/consul/consul.git","svn_url":"https://github.com/consul/consul","homepage":"","size":37656,"stargazers_count":658,"watchers_count":658,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":420,"mirror_url":null,"archived":false,"open_issues_count":300,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":420,"open_issues":300,"watchers":658,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/consul/consul/pulls/2913"},"html":{"href":"https://github.com/consul/consul/pull/2913"},"issue":{"href":"https://api.github.com/repos/consul/consul/issues/2913"},"comments":{"href":"https://api.github.com/repos/consul/consul/issues/2913/comments"},"review_comments":{"href":"https://api.github.com/repos/consul/consul/pulls/2913/comments"},"review_comment":{"href":"https://api.github.com/repos/consul/consul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/consul/consul/pulls/2913/commits"},"statuses":{"href":"https://api.github.com/repos/consul/consul/statuses/3fcb4114ca2191ab73cd817aaa36aea0e21109c8"}},"author_association":"NONE"}}
{"actor":{"display_login":"javierm"}}