{"action":"created","issue":{"url":"https://api.github.com/repos/python-cmd2/cmd2/issues/299","repository_url":"https://api.github.com/repos/python-cmd2/cmd2","labels_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/299/labels{/name}","comments_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/299/comments","events_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/299/events","html_url":"https://github.com/python-cmd2/cmd2/pull/299","id":303991141,"number":299,"title":"Tweaked complete function to handle cases where a flag appears before…","user":{"login":"kmvanbrunt","id":28899027,"avatar_url":"https://avatars1.githubusercontent.com/u/28899027?v=4","gravatar_id":"","url":"https://api.github.com/users/kmvanbrunt","html_url":"https://github.com/kmvanbrunt","followers_url":"https://api.github.com/users/kmvanbrunt/followers","following_url":"https://api.github.com/users/kmvanbrunt/following{/other_user}","gists_url":"https://api.github.com/users/kmvanbrunt/gists{/gist_id}","starred_url":"https://api.github.com/users/kmvanbrunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmvanbrunt/subscriptions","organizations_url":"https://api.github.com/users/kmvanbrunt/orgs","repos_url":"https://api.github.com/users/kmvanbrunt/repos","events_url":"https://api.github.com/users/kmvanbrunt/events{/privacy}","received_events_url":"https://api.github.com/users/kmvanbrunt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-09T21:48:33Z","updated_at":"2018-03-09T22:06:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/python-cmd2/cmd2/pulls/299","html_url":"https://github.com/python-cmd2/cmd2/pull/299","diff_url":"https://github.com/python-cmd2/cmd2/pull/299.diff","patch_url":"https://github.com/python-cmd2/cmd2/pull/299.patch"},"body":"… subcommand name"},"comment":{"url":"https://api.github.com/repos/python-cmd2/cmd2/issues/comments/371958759","html_url":"https://github.com/python-cmd2/cmd2/pull/299#issuecomment-371958759","issue_url":"https://api.github.com/repos/python-cmd2/cmd2/issues/299","id":371958759,"user":{"login":"kmvanbrunt","id":28899027,"avatar_url":"https://avatars1.githubusercontent.com/u/28899027?v=4","gravatar_id":"","url":"https://api.github.com/users/kmvanbrunt","html_url":"https://github.com/kmvanbrunt","followers_url":"https://api.github.com/users/kmvanbrunt/followers","following_url":"https://api.github.com/users/kmvanbrunt/following{/other_user}","gists_url":"https://api.github.com/users/kmvanbrunt/gists{/gist_id}","starred_url":"https://api.github.com/users/kmvanbrunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmvanbrunt/subscriptions","organizations_url":"https://api.github.com/users/kmvanbrunt/orgs","repos_url":"https://api.github.com/users/kmvanbrunt/repos","events_url":"https://api.github.com/users/kmvanbrunt/events{/privacy}","received_events_url":"https://api.github.com/users/kmvanbrunt/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T22:06:42Z","updated_at":"2018-03-09T22:06:42Z","author_association":"CONTRIBUTOR","body":"I don't yet have an example for those since I've been to sick to do\nanything. I will be using this at work though, so an example will exist\nsometime next week.\n\nOn Fri, Mar 9, 2018 at 5:02 PM, Todd Leonhardt <notifications@github.com>\nwrote:\n\n> *@tleonhardt* approved this pull request.\n> ------------------------------\n>\n> In cmd2.py\n> <https://github.com/python-cmd2/cmd2/pull/299#discussion_r173579757>:\n>\n> > @@ -193,7 +193,7 @@ def flag_based_complete(text, line, begidx, endidx, flag_dict, default_completer\n>          return []\n>\n>      completions = []\n> -    flag_processed = False\n> +    flag_present = False\n>\n> As far as I can tell, these changes look good. You might consider\n> modifying either the tab_completion.py or subcommands.py example to\n> illustrate the case where this PR would matter.\n>\n> —\n> You are receiving this because you authored the thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/python-cmd2/cmd2/pull/299#pullrequestreview-102803432>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/Abj2073VZtBRnjeHu_JwyfAfT3PvxKYQks5tcvvYgaJpZM4Sk6ou>\n> .\n>\n"}}
{"actor":{"display_login":"kmvanbrunt"}}