{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/214907329","pull_request_review_id":152057195,"id":214907329,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDkwNzMyOQ==","diff_hunk":"@@ -72,10 +73,14 @@ public function configureOptions(OptionsResolver $resolver)\n      */\n     public function isApplicable(array $record)\n     {\n-        $options = $this->getOptions();\n+        $accessibilityChecker = $this->getOptions()['accessibility_checker'];\n \n-        if (is_callable($options['is_applicable_callback'])) {\n-            return call_user_func($options['is_applicable_callback'], [$record]);\n+        if ($accessibilityChecker instanceof AccessibilityCheckerInterface) {","path":"src/Core/Grid/Action/Row/Type/SubmitRowAction.php","position":null,"original_position":34,"commit_id":"cf5c5092978b6242f53e5f16a4d3e699cb7901c7","original_commit_id":"aea8853445768aac236082a8ad9c675b8b3f4115","user":{"login":"mickaelandrieu","id":1247388,"node_id":"MDQ6VXNlcjEyNDczODg=","avatar_url":"https://avatars2.githubusercontent.com/u/1247388?v=4","gravatar_id":"","url":"https://api.github.com/users/mickaelandrieu","html_url":"https://github.com/mickaelandrieu","followers_url":"https://api.github.com/users/mickaelandrieu/followers","following_url":"https://api.github.com/users/mickaelandrieu/following{/other_user}","gists_url":"https://api.github.com/users/mickaelandrieu/gists{/gist_id}","starred_url":"https://api.github.com/users/mickaelandrieu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mickaelandrieu/subscriptions","organizations_url":"https://api.github.com/users/mickaelandrieu/orgs","repos_url":"https://api.github.com/users/mickaelandrieu/repos","events_url":"https://api.github.com/users/mickaelandrieu/events{/privacy}","received_events_url":"https://api.github.com/users/mickaelandrieu/received_events","type":"User","site_admin":false},"body":"looks like we could have a hook here for instance, and the only expected return is a boolean so people can define their own rules in module.\r\n\r\njust an idea: I don't think we should do it right now (we need feedbacks from developers after 1.7.5 release)","created_at":"2018-09-04T13:12:08Z","updated_at":"2018-09-04T13:12:08Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/10160#discussion_r214907329","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/10160","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/214907329"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/10160#discussion_r214907329"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/10160"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/10160","id":211205992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjA1OTky","html_url":"https://github.com/PrestaShop/PrestaShop/pull/10160","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/10160.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/10160.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/10160","number":10160,"state":"open","locked":false,"title":"[WIP] Migrate categories listing","user":{"login":"sarjon","id":15143151,"node_id":"MDQ6VXNlcjE1MTQzMTUx","avatar_url":"https://avatars3.githubusercontent.com/u/15143151?v=4","gravatar_id":"","url":"https://api.github.com/users/sarjon","html_url":"https://github.com/sarjon","followers_url":"https://api.github.com/users/sarjon/followers","following_url":"https://api.github.com/users/sarjon/following{/other_user}","gists_url":"https://api.github.com/users/sarjon/gists{/gist_id}","starred_url":"https://api.github.com/users/sarjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarjon/subscriptions","organizations_url":"https://api.github.com/users/sarjon/orgs","repos_url":"https://api.github.com/users/sarjon/repos","events_url":"https://api.github.com/users/sarjon/events{/privacy}","received_events_url":"https://api.github.com/users/sarjon/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to the PrestaShop project! \r\n\r\nPlease take the time to edit the \"Answers\" rows with the necessary information.\r\n\r\nCheck out our contribution guidelines to find out how to complete it:\r\nhttps://devdocs.prestashop.com/1.7/contribute/contribution-guidelines/#pull-requests\r\n -->\r\n\r\n| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | develop\r\n| Description?  | Migrates categories listing page\r\n| Type?         | new feature\r\n| Category?     | CO\r\n| BC breaks?    | no\r\n| Deprecations? |no\r\n| Fixed ticket? | n/a\r\n| How to test?  | Not yet.\r\n\r\n<!-- Click the form's \"Preview\" button to make sure the table is functional in GitHub. Thank you! -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/10160)\n<!-- Reviewable:end -->\n","created_at":"2018-08-27T19:25:47Z","updated_at":"2018-09-04T13:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9fc9b5970e2cb196d37b7e30b7e4e6c6fa4d9d5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":982530767,"node_id":"MDU6TGFiZWw5ODI1MzA3Njc=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/Feature","name":"Feature","color":"d4c5f9","default":false},{"id":904910825,"node_id":"MDU6TGFiZWw5MDQ5MTA4MjU=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/develop","name":"develop","color":"6270ea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/10160/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/10160/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/10160/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/cf5c5092978b6242f53e5f16a4d3e699cb7901c7","head":{"label":"sarjon:migrate/categories-listing","ref":"migrate/categories-listing","sha":"cf5c5092978b6242f53e5f16a4d3e699cb7901c7","user":{"login":"sarjon","id":15143151,"node_id":"MDQ6VXNlcjE1MTQzMTUx","avatar_url":"https://avatars3.githubusercontent.com/u/15143151?v=4","gravatar_id":"","url":"https://api.github.com/users/sarjon","html_url":"https://github.com/sarjon","followers_url":"https://api.github.com/users/sarjon/followers","following_url":"https://api.github.com/users/sarjon/following{/other_user}","gists_url":"https://api.github.com/users/sarjon/gists{/gist_id}","starred_url":"https://api.github.com/users/sarjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarjon/subscriptions","organizations_url":"https://api.github.com/users/sarjon/orgs","repos_url":"https://api.github.com/users/sarjon/repos","events_url":"https://api.github.com/users/sarjon/events{/privacy}","received_events_url":"https://api.github.com/users/sarjon/received_events","type":"User","site_admin":false},"repo":{"id":77449609,"node_id":"MDEwOlJlcG9zaXRvcnk3NzQ0OTYwOQ==","name":"PrestaShop","full_name":"sarjon/PrestaShop","owner":{"login":"sarjon","id":15143151,"node_id":"MDQ6VXNlcjE1MTQzMTUx","avatar_url":"https://avatars3.githubusercontent.com/u/15143151?v=4","gravatar_id":"","url":"https://api.github.com/users/sarjon","html_url":"https://github.com/sarjon","followers_url":"https://api.github.com/users/sarjon/followers","following_url":"https://api.github.com/users/sarjon/following{/other_user}","gists_url":"https://api.github.com/users/sarjon/gists{/gist_id}","starred_url":"https://api.github.com/users/sarjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarjon/subscriptions","organizations_url":"https://api.github.com/users/sarjon/orgs","repos_url":"https://api.github.com/users/sarjon/repos","events_url":"https://api.github.com/users/sarjon/events{/privacy}","received_events_url":"https://api.github.com/users/sarjon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sarjon/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open Source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/sarjon/PrestaShop","forks_url":"https://api.github.com/repos/sarjon/PrestaShop/forks","keys_url":"https://api.github.com/repos/sarjon/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarjon/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarjon/PrestaShop/teams","hooks_url":"https://api.github.com/repos/sarjon/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/sarjon/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/sarjon/PrestaShop/events","assignees_url":"https://api.github.com/repos/sarjon/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/sarjon/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/sarjon/PrestaShop/tags","blobs_url":"https://api.github.com/repos/sarjon/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarjon/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarjon/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarjon/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarjon/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/sarjon/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/sarjon/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/sarjon/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/sarjon/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/sarjon/PrestaShop/subscription","commits_url":"https://api.github.com/repos/sarjon/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarjon/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarjon/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarjon/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarjon/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/sarjon/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarjon/PrestaShop/merges","archive_url":"https://api.github.com/repos/sarjon/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarjon/PrestaShop/downloads","issues_url":"https://api.github.com/repos/sarjon/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/sarjon/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/sarjon/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/sarjon/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarjon/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/sarjon/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/sarjon/PrestaShop/deployments","created_at":"2016-12-27T11:12:19Z","updated_at":"2018-09-04T06:34:23Z","pushed_at":"2018-09-04T13:08:35Z","git_url":"git://github.com/sarjon/PrestaShop.git","ssh_url":"git@github.com:sarjon/PrestaShop.git","clone_url":"https://github.com/sarjon/PrestaShop.git","svn_url":"https://github.com/sarjon/PrestaShop","homepage":"http://www.prestashop.com/","size":330675,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:develop","ref":"develop","sha":"ced42fb54bacd06163b2b6e0bbb188bc4c743843","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYzNTg3","name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a fully scalable open source ecommerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2018-09-04T12:19:06Z","pushed_at":"2018-09-04T13:08:45Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":361083,"stargazers_count":3160,"watchers_count":3160,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2881,"mirror_url":null,"archived":false,"open_issues_count":967,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2881,"open_issues":967,"watchers":3160,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/10160"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/10160"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/10160"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/10160/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/10160/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/10160/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/cf5c5092978b6242f53e5f16a4d3e699cb7901c7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mickaelandrieu"}}