{"action":"created","comment":{"url":"https://api.github.com/repos/fossas/fossa-cli/pulls/comments/217232532","pull_request_review_id":154895622,"id":217232532,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzIzMjUzMg==","diff_hunk":"@@ -38,21 +38,21 @@ $(PREFIX)/fossa: $(BIN)/fossa\n \n # Building various Docker images.\n docker-base: ./docker/base/Dockerfile\n-\tsudo docker build -t quay.io/fossa/fossa-cli-base -f ./docker/base/Dockerfile .\n+\tdocker build -t quay.io/fossa/fossa-cli-base -f ./docker/base/Dockerfile .","path":"Makefile","position":11,"original_position":11,"commit_id":"49419e96778b772845535654cb0f813bb922b6d9","original_commit_id":"49419e96778b772845535654cb0f813bb922b6d9","user":{"login":"liftM","id":2092654,"node_id":"MDQ6VXNlcjIwOTI2NTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2092654?v=4","gravatar_id":"","url":"https://api.github.com/users/liftM","html_url":"https://github.com/liftM","followers_url":"https://api.github.com/users/liftM/followers","following_url":"https://api.github.com/users/liftM/following{/other_user}","gists_url":"https://api.github.com/users/liftM/gists{/gist_id}","starred_url":"https://api.github.com/users/liftM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liftM/subscriptions","organizations_url":"https://api.github.com/users/liftM/orgs","repos_url":"https://api.github.com/users/liftM/repos","events_url":"https://api.github.com/users/liftM/events{/privacy}","received_events_url":"https://api.github.com/users/liftM/received_events","type":"User","site_admin":false},"body":"That's _true_, but I'm not sure that \"being in the `docker` group\" a good assumption.\r\n\r\n1) Being in the `docker` group is effectively equivalent to being root, and I want to discourage this behaviour as much as possible.\r\n2) You're effectively root anyway, so `sudo docker ...` is only more typing, not actually less secure.","created_at":"2018-09-13T00:49:42Z","updated_at":"2018-09-13T00:49:42Z","html_url":"https://github.com/fossas/fossa-cli/pull/255#discussion_r217232532","pull_request_url":"https://api.github.com/repos/fossas/fossa-cli/pulls/255","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/fossas/fossa-cli/pulls/comments/217232532"},"html":{"href":"https://github.com/fossas/fossa-cli/pull/255#discussion_r217232532"},"pull_request":{"href":"https://api.github.com/repos/fossas/fossa-cli/pulls/255"}},"in_reply_to_id":216481121},"pull_request":{"url":"https://api.github.com/repos/fossas/fossa-cli/pulls/255","id":213955769,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTU1NzY5","html_url":"https://github.com/fossas/fossa-cli/pull/255","diff_url":"https://github.com/fossas/fossa-cli/pull/255.diff","patch_url":"https://github.com/fossas/fossa-cli/pull/255.patch","issue_url":"https://api.github.com/repos/fossas/fossa-cli/issues/255","number":255,"state":"open","locked":false,"title":"235: Filter NodeJS dev dependencies","user":{"login":"bsima","id":200617,"node_id":"MDQ6VXNlcjIwMDYxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/200617?v=4","gravatar_id":"","url":"https://api.github.com/users/bsima","html_url":"https://github.com/bsima","followers_url":"https://api.github.com/users/bsima/followers","following_url":"https://api.github.com/users/bsima/following{/other_user}","gists_url":"https://api.github.com/users/bsima/gists{/gist_id}","starred_url":"https://api.github.com/users/bsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsima/subscriptions","organizations_url":"https://api.github.com/users/bsima/orgs","repos_url":"https://api.github.com/users/bsima/repos","events_url":"https://api.github.com/users/bsima/events{/privacy}","received_events_url":"https://api.github.com/users/bsima/received_events","type":"User","site_admin":false},"body":"I'm really not sure how to test this - I looked at \"testing/quick\" but couldn't figure out how to generate a `pkgMap` to run against a unit test. Any advice is appreciated.\r\n\r\nCloses https://github.com/fossas/fossa-cli/issues/235\r\n\r\n","created_at":"2018-09-07T15:01:17Z","updated_at":"2018-09-13T00:49:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68b9385067e5ab2d87ceb5718b274039f328c236","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fossas/fossa-cli/pulls/255/commits","review_comments_url":"https://api.github.com/repos/fossas/fossa-cli/pulls/255/comments","review_comment_url":"https://api.github.com/repos/fossas/fossa-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossas/fossa-cli/issues/255/comments","statuses_url":"https://api.github.com/repos/fossas/fossa-cli/statuses/49419e96778b772845535654cb0f813bb922b6d9","head":{"label":"bsima:235","ref":"235","sha":"49419e96778b772845535654cb0f813bb922b6d9","user":{"login":"bsima","id":200617,"node_id":"MDQ6VXNlcjIwMDYxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/200617?v=4","gravatar_id":"","url":"https://api.github.com/users/bsima","html_url":"https://github.com/bsima","followers_url":"https://api.github.com/users/bsima/followers","following_url":"https://api.github.com/users/bsima/following{/other_user}","gists_url":"https://api.github.com/users/bsima/gists{/gist_id}","starred_url":"https://api.github.com/users/bsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsima/subscriptions","organizations_url":"https://api.github.com/users/bsima/orgs","repos_url":"https://api.github.com/users/bsima/repos","events_url":"https://api.github.com/users/bsima/events{/privacy}","received_events_url":"https://api.github.com/users/bsima/received_events","type":"User","site_admin":false},"repo":{"id":147837956,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4Mzc5NTY=","name":"fossa-cli","full_name":"bsima/fossa-cli","owner":{"login":"bsima","id":200617,"node_id":"MDQ6VXNlcjIwMDYxNw==","avatar_url":"https://avatars1.githubusercontent.com/u/200617?v=4","gravatar_id":"","url":"https://api.github.com/users/bsima","html_url":"https://github.com/bsima","followers_url":"https://api.github.com/users/bsima/followers","following_url":"https://api.github.com/users/bsima/following{/other_user}","gists_url":"https://api.github.com/users/bsima/gists{/gist_id}","starred_url":"https://api.github.com/users/bsima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsima/subscriptions","organizations_url":"https://api.github.com/users/bsima/orgs","repos_url":"https://api.github.com/users/bsima/repos","events_url":"https://api.github.com/users/bsima/events{/privacy}","received_events_url":"https://api.github.com/users/bsima/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsima/fossa-cli","description":"Fast, portable and reliable dependency analysis for any codebase. Supports license reporting, large monoliths and polyglot projects. Integrates with 20+ build systems.","fork":true,"url":"https://api.github.com/repos/bsima/fossa-cli","forks_url":"https://api.github.com/repos/bsima/fossa-cli/forks","keys_url":"https://api.github.com/repos/bsima/fossa-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsima/fossa-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsima/fossa-cli/teams","hooks_url":"https://api.github.com/repos/bsima/fossa-cli/hooks","issue_events_url":"https://api.github.com/repos/bsima/fossa-cli/issues/events{/number}","events_url":"https://api.github.com/repos/bsima/fossa-cli/events","assignees_url":"https://api.github.com/repos/bsima/fossa-cli/assignees{/user}","branches_url":"https://api.github.com/repos/bsima/fossa-cli/branches{/branch}","tags_url":"https://api.github.com/repos/bsima/fossa-cli/tags","blobs_url":"https://api.github.com/repos/bsima/fossa-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsima/fossa-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsima/fossa-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsima/fossa-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsima/fossa-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/bsima/fossa-cli/languages","stargazers_url":"https://api.github.com/repos/bsima/fossa-cli/stargazers","contributors_url":"https://api.github.com/repos/bsima/fossa-cli/contributors","subscribers_url":"https://api.github.com/repos/bsima/fossa-cli/subscribers","subscription_url":"https://api.github.com/repos/bsima/fossa-cli/subscription","commits_url":"https://api.github.com/repos/bsima/fossa-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsima/fossa-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsima/fossa-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsima/fossa-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsima/fossa-cli/contents/{+path}","compare_url":"https://api.github.com/repos/bsima/fossa-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsima/fossa-cli/merges","archive_url":"https://api.github.com/repos/bsima/fossa-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsima/fossa-cli/downloads","issues_url":"https://api.github.com/repos/bsima/fossa-cli/issues{/number}","pulls_url":"https://api.github.com/repos/bsima/fossa-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/bsima/fossa-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/bsima/fossa-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsima/fossa-cli/labels{/name}","releases_url":"https://api.github.com/repos/bsima/fossa-cli/releases{/id}","deployments_url":"https://api.github.com/repos/bsima/fossa-cli/deployments","created_at":"2018-09-07T14:56:26Z","updated_at":"2018-09-07T14:56:29Z","pushed_at":"2018-09-07T14:58:34Z","git_url":"git://github.com/bsima/fossa-cli.git","ssh_url":"git@github.com:bsima/fossa-cli.git","clone_url":"https://github.com/bsima/fossa-cli.git","svn_url":"https://github.com/bsima/fossa-cli","homepage":"https://fossa.io","size":18047,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fossas:master","ref":"master","sha":"d9afc8f5c02c1aeb4361421d59f8a1d40c236bbd","user":{"login":"fossas","id":9543448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/9543448?v=4","gravatar_id":"","url":"https://api.github.com/users/fossas","html_url":"https://github.com/fossas","followers_url":"https://api.github.com/users/fossas/followers","following_url":"https://api.github.com/users/fossas/following{/other_user}","gists_url":"https://api.github.com/users/fossas/gists{/gist_id}","starred_url":"https://api.github.com/users/fossas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossas/subscriptions","organizations_url":"https://api.github.com/users/fossas/orgs","repos_url":"https://api.github.com/users/fossas/repos","events_url":"https://api.github.com/users/fossas/events{/privacy}","received_events_url":"https://api.github.com/users/fossas/received_events","type":"Organization","site_admin":false},"repo":{"id":116995448,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5OTU0NDg=","name":"fossa-cli","full_name":"fossas/fossa-cli","owner":{"login":"fossas","id":9543448,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk1NDM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/9543448?v=4","gravatar_id":"","url":"https://api.github.com/users/fossas","html_url":"https://github.com/fossas","followers_url":"https://api.github.com/users/fossas/followers","following_url":"https://api.github.com/users/fossas/following{/other_user}","gists_url":"https://api.github.com/users/fossas/gists{/gist_id}","starred_url":"https://api.github.com/users/fossas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossas/subscriptions","organizations_url":"https://api.github.com/users/fossas/orgs","repos_url":"https://api.github.com/users/fossas/repos","events_url":"https://api.github.com/users/fossas/events{/privacy}","received_events_url":"https://api.github.com/users/fossas/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fossas/fossa-cli","description":"Fast, portable and reliable dependency analysis for any codebase. Supports license reporting, large monoliths and polyglot projects. Integrates with 20+ build systems.","fork":false,"url":"https://api.github.com/repos/fossas/fossa-cli","forks_url":"https://api.github.com/repos/fossas/fossa-cli/forks","keys_url":"https://api.github.com/repos/fossas/fossa-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossas/fossa-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossas/fossa-cli/teams","hooks_url":"https://api.github.com/repos/fossas/fossa-cli/hooks","issue_events_url":"https://api.github.com/repos/fossas/fossa-cli/issues/events{/number}","events_url":"https://api.github.com/repos/fossas/fossa-cli/events","assignees_url":"https://api.github.com/repos/fossas/fossa-cli/assignees{/user}","branches_url":"https://api.github.com/repos/fossas/fossa-cli/branches{/branch}","tags_url":"https://api.github.com/repos/fossas/fossa-cli/tags","blobs_url":"https://api.github.com/repos/fossas/fossa-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossas/fossa-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossas/fossa-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossas/fossa-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossas/fossa-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/fossas/fossa-cli/languages","stargazers_url":"https://api.github.com/repos/fossas/fossa-cli/stargazers","contributors_url":"https://api.github.com/repos/fossas/fossa-cli/contributors","subscribers_url":"https://api.github.com/repos/fossas/fossa-cli/subscribers","subscription_url":"https://api.github.com/repos/fossas/fossa-cli/subscription","commits_url":"https://api.github.com/repos/fossas/fossa-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossas/fossa-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossas/fossa-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossas/fossa-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossas/fossa-cli/contents/{+path}","compare_url":"https://api.github.com/repos/fossas/fossa-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossas/fossa-cli/merges","archive_url":"https://api.github.com/repos/fossas/fossa-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossas/fossa-cli/downloads","issues_url":"https://api.github.com/repos/fossas/fossa-cli/issues{/number}","pulls_url":"https://api.github.com/repos/fossas/fossa-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/fossas/fossa-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/fossas/fossa-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossas/fossa-cli/labels{/name}","releases_url":"https://api.github.com/repos/fossas/fossa-cli/releases{/id}","deployments_url":"https://api.github.com/repos/fossas/fossa-cli/deployments","created_at":"2018-01-10T18:30:32Z","updated_at":"2018-09-12T08:50:53Z","pushed_at":"2018-09-13T00:34:34Z","git_url":"git://github.com/fossas/fossa-cli.git","ssh_url":"git@github.com:fossas/fossa-cli.git","clone_url":"https://github.com/fossas/fossa-cli.git","svn_url":"https://github.com/fossas/fossa-cli","homepage":"https://fossa.io","size":18450,"stargazers_count":545,"watchers_count":545,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":35,"open_issues":73,"watchers":545,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fossas/fossa-cli/pulls/255"},"html":{"href":"https://github.com/fossas/fossa-cli/pull/255"},"issue":{"href":"https://api.github.com/repos/fossas/fossa-cli/issues/255"},"comments":{"href":"https://api.github.com/repos/fossas/fossa-cli/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/fossas/fossa-cli/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/fossas/fossa-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossas/fossa-cli/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/fossas/fossa-cli/statuses/49419e96778b772845535654cb0f813bb922b6d9"}},"author_association":"NONE"}}
{"actor":{"display_login":"liftM"}}