{"action":"created","issue":{"url":"https://api.github.com/repos/contiamo/operational-ui/issues/781","repository_url":"https://api.github.com/repos/contiamo/operational-ui","labels_url":"https://api.github.com/repos/contiamo/operational-ui/issues/781/labels{/name}","comments_url":"https://api.github.com/repos/contiamo/operational-ui/issues/781/comments","events_url":"https://api.github.com/repos/contiamo/operational-ui/issues/781/events","html_url":"https://github.com/contiamo/operational-ui/pull/781","id":368542741,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjk0OTA4","number":781,"title":"**Breaking:** opinionated table actions","user":{"login":"peterszerzo","id":6738398,"node_id":"MDQ6VXNlcjY3MzgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6738398?v=4","gravatar_id":"","url":"https://api.github.com/users/peterszerzo","html_url":"https://github.com/peterszerzo","followers_url":"https://api.github.com/users/peterszerzo/followers","following_url":"https://api.github.com/users/peterszerzo/following{/other_user}","gists_url":"https://api.github.com/users/peterszerzo/gists{/gist_id}","starred_url":"https://api.github.com/users/peterszerzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterszerzo/subscriptions","organizations_url":"https://api.github.com/users/peterszerzo/orgs","repos_url":"https://api.github.com/users/peterszerzo/repos","events_url":"https://api.github.com/users/peterszerzo/events{/privacy}","received_events_url":"https://api.github.com/users/peterszerzo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"peterszerzo","id":6738398,"node_id":"MDQ6VXNlcjY3MzgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6738398?v=4","gravatar_id":"","url":"https://api.github.com/users/peterszerzo","html_url":"https://github.com/peterszerzo","followers_url":"https://api.github.com/users/peterszerzo/followers","following_url":"https://api.github.com/users/peterszerzo/following{/other_user}","gists_url":"https://api.github.com/users/peterszerzo/gists{/gist_id}","starred_url":"https://api.github.com/users/peterszerzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterszerzo/subscriptions","organizations_url":"https://api.github.com/users/peterszerzo/orgs","repos_url":"https://api.github.com/users/peterszerzo/repos","events_url":"https://api.github.com/users/peterszerzo/events{/privacy}","received_events_url":"https://api.github.com/users/peterszerzo/received_events","type":"User","site_admin":false},"assignees":[{"login":"peterszerzo","id":6738398,"node_id":"MDQ6VXNlcjY3MzgzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6738398?v=4","gravatar_id":"","url":"https://api.github.com/users/peterszerzo","html_url":"https://github.com/peterszerzo","followers_url":"https://api.github.com/users/peterszerzo/followers","following_url":"https://api.github.com/users/peterszerzo/following{/other_user}","gists_url":"https://api.github.com/users/peterszerzo/gists{/gist_id}","starred_url":"https://api.github.com/users/peterszerzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterszerzo/subscriptions","organizations_url":"https://api.github.com/users/peterszerzo/orgs","repos_url":"https://api.github.com/users/peterszerzo/repos","events_url":"https://api.github.com/users/peterszerzo/events{/privacy}","received_events_url":"https://api.github.com/users/peterszerzo/received_events","type":"User","site_admin":false},{"login":"TejasQ","id":9947422,"node_id":"MDQ6VXNlcjk5NDc0MjI=","avatar_url":"https://avatars1.githubusercontent.com/u/9947422?v=4","gravatar_id":"","url":"https://api.github.com/users/TejasQ","html_url":"https://github.com/TejasQ","followers_url":"https://api.github.com/users/TejasQ/followers","following_url":"https://api.github.com/users/TejasQ/following{/other_user}","gists_url":"https://api.github.com/users/TejasQ/gists{/gist_id}","starred_url":"https://api.github.com/users/TejasQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TejasQ/subscriptions","organizations_url":"https://api.github.com/users/TejasQ/orgs","repos_url":"https://api.github.com/users/TejasQ/repos","events_url":"https://api.github.com/users/TejasQ/events{/privacy}","received_events_url":"https://api.github.com/users/TejasQ/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-10-10T08:11:55Z","updated_at":"2018-10-18T13:31:59Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/contiamo/operational-ui/pulls/781","html_url":"https://github.com/contiamo/operational-ui/pull/781","diff_url":"https://github.com/contiamo/operational-ui/pull/781.diff","patch_url":"https://github.com/contiamo/operational-ui/pull/781.patch"},"body":"<!-- \r\n  ❗️IMPORTANT ❗️\r\n  Please prefix the title of this PR with _one_ of the following.\r\n\r\n  **Breaking:**\r\n    For when we break a public API.\r\n\r\n  **Feature:** \r\n    For when we add something NEW that doesn't\r\n    break the public API.\r\n      \r\n  **Fix:**\r\n    For when we fix something that previously\r\n    did not look or work correctly.\r\n    \r\n  Leaving off this prefix will prevent the PR from being\r\n  included in a release. A good case to omit the prefix\r\n  is when proposing infrastructural changes to the repo\r\n  that do not affect the library.\r\n-->\r\n# Summary\r\n\r\nAdds an opinionated, `ActionMenu `-based table row actions solution, replacing `__experimentalRowActions` with `rowActions`. The API is the same as the `items` prop of `ActionMenu` so it should be familiar both on an API level and visually.\r\n\r\n<img width=\"1093\" alt=\"screen shot 2018-10-10 at 10 04 31 am\" src=\"https://user-images.githubusercontent.com/6738398/46721950-a3223200-cc74-11e8-9678-33c7bcbe500a.png\">\r\n\r\n# Related issue\r\n\r\nFixes #766.\r\n\r\n# To be tested\r\n\r\nMe\r\n- [x] No error or warning in the console on `localhost:6060`\r\n- [x] Table actions work\r\n- [x] Click propagation is stopped so that default row click events are not triggered \r\n\r\nTester 1\r\n\r\n- [x] Things look good on the demo.\r\n- [x] No regressions on tables.\r\n  <!-- Put here everything that the reviewer 1 should test to be sure that everything is working properly -->\r\n\r\nTester 2\r\n\r\n- [ ] Things look good on the demo.\r\n- [ ] No regressions on tables.\r\n  <!-- Put here everything that the reviewer 2 should test to be sure that everything is working properly -->\r\n"},"comment":{"url":"https://api.github.com/repos/contiamo/operational-ui/issues/comments/431009519","html_url":"https://github.com/contiamo/operational-ui/pull/781#issuecomment-431009519","issue_url":"https://api.github.com/repos/contiamo/operational-ui/issues/781","id":431009519,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTAwOTUxOQ==","user":{"login":"fabien0102","id":1761469,"node_id":"MDQ6VXNlcjE3NjE0Njk=","avatar_url":"https://avatars1.githubusercontent.com/u/1761469?v=4","gravatar_id":"","url":"https://api.github.com/users/fabien0102","html_url":"https://github.com/fabien0102","followers_url":"https://api.github.com/users/fabien0102/followers","following_url":"https://api.github.com/users/fabien0102/following{/other_user}","gists_url":"https://api.github.com/users/fabien0102/gists{/gist_id}","starred_url":"https://api.github.com/users/fabien0102/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabien0102/subscriptions","organizations_url":"https://api.github.com/users/fabien0102/orgs","repos_url":"https://api.github.com/users/fabien0102/repos","events_url":"https://api.github.com/users/fabien0102/events{/privacy}","received_events_url":"https://api.github.com/users/fabien0102/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T13:31:59Z","updated_at":"2018-10-18T13:31:59Z","author_association":"CONTRIBUTOR","body":"@peterszerzo Nice job, and the API is better than before, but do we really want to break this API now?\r\n\r\nThis a lot of works to migrate in all our apps and we are quite short in time before the launch ^^\r\n\r\nI propose three options:\r\n1. keep this for later\r\n2. don't break the API with some deprecated props for a smooth migration\r\n3. A codemod to insure a nice and easy migration"}}
{"actor":{"display_login":"fabien0102"}}