{"action":"opened","number":1769,"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/1769","id":215455788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDU1Nzg4","html_url":"https://github.com/allenai/allennlp/pull/1769","diff_url":"https://github.com/allenai/allennlp/pull/1769.diff","patch_url":"https://github.com/allenai/allennlp/pull/1769.patch","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/1769","number":1769,"state":"open","locked":false,"title":"use managers for queues","user":{"login":"joelgrus","id":1308313,"node_id":"MDQ6VXNlcjEzMDgzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1308313?v=4","gravatar_id":"","url":"https://api.github.com/users/joelgrus","html_url":"https://github.com/joelgrus","followers_url":"https://api.github.com/users/joelgrus/followers","following_url":"https://api.github.com/users/joelgrus/following{/other_user}","gists_url":"https://api.github.com/users/joelgrus/gists{/gist_id}","starred_url":"https://api.github.com/users/joelgrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelgrus/subscriptions","organizations_url":"https://api.github.com/users/joelgrus/orgs","repos_url":"https://api.github.com/users/joelgrus/repos","events_url":"https://api.github.com/users/joelgrus/events{/privacy}","received_events_url":"https://api.github.com/users/joelgrus/received_events","type":"User","site_admin":false},"body":"this was a real nightmare to debug, but it seems like it fixes the problem. (as best as I can tell it was some kind of race condition with queues getting deleted before they were done being used. the `Manager` seems to avoid that.)\r\n\r\nverified by building the Dockerfile.pip image and running the relevant tests inside it","created_at":"2018-09-14T01:08:07Z","updated_at":"2018-09-14T01:08:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp/pulls/1769/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp/pulls/1769/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/1769/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/e737ec129cee8028aeac7c1ed4f65ae3f7630208","head":{"label":"joelgrus:mpfix","ref":"mpfix","sha":"e737ec129cee8028aeac7c1ed4f65ae3f7630208","user":{"login":"joelgrus","id":1308313,"node_id":"MDQ6VXNlcjEzMDgzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1308313?v=4","gravatar_id":"","url":"https://api.github.com/users/joelgrus","html_url":"https://github.com/joelgrus","followers_url":"https://api.github.com/users/joelgrus/followers","following_url":"https://api.github.com/users/joelgrus/following{/other_user}","gists_url":"https://api.github.com/users/joelgrus/gists{/gist_id}","starred_url":"https://api.github.com/users/joelgrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelgrus/subscriptions","organizations_url":"https://api.github.com/users/joelgrus/orgs","repos_url":"https://api.github.com/users/joelgrus/repos","events_url":"https://api.github.com/users/joelgrus/events{/privacy}","received_events_url":"https://api.github.com/users/joelgrus/received_events","type":"User","site_admin":false},"repo":{"id":114700287,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ3MDAyODc=","name":"allennlp","full_name":"joelgrus/allennlp","owner":{"login":"joelgrus","id":1308313,"node_id":"MDQ6VXNlcjEzMDgzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1308313?v=4","gravatar_id":"","url":"https://api.github.com/users/joelgrus","html_url":"https://github.com/joelgrus","followers_url":"https://api.github.com/users/joelgrus/followers","following_url":"https://api.github.com/users/joelgrus/following{/other_user}","gists_url":"https://api.github.com/users/joelgrus/gists{/gist_id}","starred_url":"https://api.github.com/users/joelgrus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelgrus/subscriptions","organizations_url":"https://api.github.com/users/joelgrus/orgs","repos_url":"https://api.github.com/users/joelgrus/repos","events_url":"https://api.github.com/users/joelgrus/events{/privacy}","received_events_url":"https://api.github.com/users/joelgrus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joelgrus/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":true,"url":"https://api.github.com/repos/joelgrus/allennlp","forks_url":"https://api.github.com/repos/joelgrus/allennlp/forks","keys_url":"https://api.github.com/repos/joelgrus/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joelgrus/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joelgrus/allennlp/teams","hooks_url":"https://api.github.com/repos/joelgrus/allennlp/hooks","issue_events_url":"https://api.github.com/repos/joelgrus/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/joelgrus/allennlp/events","assignees_url":"https://api.github.com/repos/joelgrus/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/joelgrus/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/joelgrus/allennlp/tags","blobs_url":"https://api.github.com/repos/joelgrus/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joelgrus/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joelgrus/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/joelgrus/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joelgrus/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/joelgrus/allennlp/languages","stargazers_url":"https://api.github.com/repos/joelgrus/allennlp/stargazers","contributors_url":"https://api.github.com/repos/joelgrus/allennlp/contributors","subscribers_url":"https://api.github.com/repos/joelgrus/allennlp/subscribers","subscription_url":"https://api.github.com/repos/joelgrus/allennlp/subscription","commits_url":"https://api.github.com/repos/joelgrus/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/joelgrus/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/joelgrus/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/joelgrus/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/joelgrus/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/joelgrus/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joelgrus/allennlp/merges","archive_url":"https://api.github.com/repos/joelgrus/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joelgrus/allennlp/downloads","issues_url":"https://api.github.com/repos/joelgrus/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/joelgrus/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/joelgrus/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/joelgrus/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joelgrus/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/joelgrus/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/joelgrus/allennlp/deployments","created_at":"2017-12-19T00:12:40Z","updated_at":"2017-12-19T00:12:43Z","pushed_at":"2018-09-14T01:06:37Z","git_url":"git://github.com/joelgrus/allennlp.git","ssh_url":"git@github.com:joelgrus/allennlp.git","clone_url":"https://github.com/joelgrus/allennlp.git","svn_url":"https://github.com/joelgrus/allennlp","homepage":"http://www.allennlp.org/","size":51732,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"64f253faa5aeb42edff1cb367b8e1fbb96da2931","user":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":91356408,"node_id":"MDEwOlJlcG9zaXRvcnk5MTM1NjQwOA==","name":"allennlp","full_name":"allenai/allennlp","owner":{"login":"allenai","id":5667695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Njc2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allenai/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":false,"url":"https://api.github.com/repos/allenai/allennlp","forks_url":"https://api.github.com/repos/allenai/allennlp/forks","keys_url":"https://api.github.com/repos/allenai/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp/events","assignees_url":"https://api.github.com/repos/allenai/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp/merges","archive_url":"https://api.github.com/repos/allenai/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp/deployments","created_at":"2017-05-15T15:52:41Z","updated_at":"2018-09-14T00:55:03Z","pushed_at":"2018-09-13T23:17:21Z","git_url":"git://github.com/allenai/allennlp.git","ssh_url":"git@github.com:allenai/allennlp.git","clone_url":"https://github.com/allenai/allennlp.git","svn_url":"https://github.com/allenai/allennlp","homepage":"http://www.allennlp.org/","size":50192,"stargazers_count":3272,"watchers_count":3272,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":575,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":575,"open_issues":103,"watchers":3272,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1769"},"html":{"href":"https://github.com/allenai/allennlp/pull/1769"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp/issues/1769"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp/issues/1769/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1769/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/1769/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp/statuses/e737ec129cee8028aeac7c1ed4f65ae3f7630208"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":10,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"joelgrus"}}