{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8835","repository_url":"https://api.github.com/repos/RIOT-OS/RIOT","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8835/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8835/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8835/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/8835","id":308522312,"number":8835,"title":"pkg/semtech-loramac: fix tx_power get/set functions","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars3.githubusercontent.com/u/1375137?v=4","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"labels":[{"id":718654448,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/LoRa","name":"LoRa","color":"2699d3","default":false},{"id":214816571,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":23399098,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-26T10:50:26Z","updated_at":"2018-03-26T12:19:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8835","html_url":"https://github.com/RIOT-OS/RIOT/pull/8835","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8835.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8835.patch"},"body":"<!--\r\nThe RIOT community cares a lot about code quality.\r\nTherefore, before describing what your contribution is about, we would like\r\nyou to make sure that your modifications are compliant with the RIOT\r\ncoding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.\r\n-->\r\n\r\n### Contribution description\r\n\r\nThis PR fixes the issue reported in this [comment](https://github.com/RIOT-OS/RIOT/pull/8798#issuecomment-376111162)\r\n\r\nUsing `MIB_CHANNELS_TX_POWER` has no effect on the MAC. The fix simply consists in using `MIB_CHANNELS_DEFAULT_TX_POWER` instead.\r\n\r\n<!--\r\nPut here the description of your contribution:\r\n- describe which part(s) of RIOT is (are) involved\r\n- if it's a bug fix, describe the bug that it solves and how it is solved\r\n- you can also give more information to reviewers about how to test your changes\r\n-->\r\n\r\n\r\n### Issues/PRs references\r\n\r\ncomment raised while reviewing #8798 \r\n\r\n<!--\r\nExamples: Fixes #1234. See also #5678. Depends on PR #9876.\r\n\r\nPlease use keywords (e.g., fixes, resolve) with the links to the issues you\r\nresolved, this way they will be automatically closed when your pull request\r\nis merged. See https://help.github.com/articles/closing-issues-using-keywords/.\r\n-->"},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/376146166","html_url":"https://github.com/RIOT-OS/RIOT/pull/8835#issuecomment-376146166","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8835","id":376146166,"user":{"login":"dylad","id":22391368,"avatar_url":"https://avatars1.githubusercontent.com/u/22391368?v=4","gravatar_id":"","url":"https://api.github.com/users/dylad","html_url":"https://github.com/dylad","followers_url":"https://api.github.com/users/dylad/followers","following_url":"https://api.github.com/users/dylad/following{/other_user}","gists_url":"https://api.github.com/users/dylad/gists{/gist_id}","starred_url":"https://api.github.com/users/dylad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dylad/subscriptions","organizations_url":"https://api.github.com/users/dylad/orgs","repos_url":"https://api.github.com/users/dylad/repos","events_url":"https://api.github.com/users/dylad/events{/privacy}","received_events_url":"https://api.github.com/users/dylad/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T12:19:01Z","updated_at":"2018-03-26T12:19:01Z","author_association":"MEMBER","body":"I re test with and without, it works and it was working before\r\nSorry, I should have check the required values before reporting an non-existent issue."}}
{"actor":{"display_login":"dylad"}}