{"action":"created","comment":{"url":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/comments/241684802","pull_request_review_id":185018864,"id":241684802,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTY4NDgwMg==","diff_hunk":"@@ -12,29 +13,29 @@ namespace KenticoCloud.Delivery.InlineContentItems\n     internal class InlineContentItemsProcessor : IInlineContentItemsProcessor\n     {\n         private readonly IDictionary<Type, Func<object, string>> _inlineContentItemsResolvers;\n-        private readonly IInlineContentItemsResolver<UnretrievedContentItem> _unretrievedInlineContentItemsResolver;\n         private readonly HtmlParser _htmlParser;\n         private readonly HtmlParser _strictHtmlParser;\n \n-        /// <summary>\n-        /// Resolver used in case no other resolver was registered for type of inline content item\n-        /// </summary>\n-        public IInlineContentItemsResolver<object> DefaultResolver { get; set; }\n-\n         // Used by tests only\n-        internal IEnumerable<Type> ContentItemTypesWithResolver => _inlineContentItemsResolvers.Keys;\n+        internal IEnumerable<Type> ContentItemTypesWithResolver => _inlineContentItemsResolvers.Keys.ToArray();","path":"KenticoCloud.Delivery/InlineContentItems/InlineContentItemsProcessor.cs","position":23,"original_position":23,"commit_id":"cd556222deedd8a6200c0e88dff1e500c34f2090","original_commit_id":"cd556222deedd8a6200c0e88dff1e500c34f2090","user":{"login":"petrsvihlik","id":9810625,"node_id":"MDQ6VXNlcjk4MTA2MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/9810625?v=4","gravatar_id":"","url":"https://api.github.com/users/petrsvihlik","html_url":"https://github.com/petrsvihlik","followers_url":"https://api.github.com/users/petrsvihlik/followers","following_url":"https://api.github.com/users/petrsvihlik/following{/other_user}","gists_url":"https://api.github.com/users/petrsvihlik/gists{/gist_id}","starred_url":"https://api.github.com/users/petrsvihlik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrsvihlik/subscriptions","organizations_url":"https://api.github.com/users/petrsvihlik/orgs","repos_url":"https://api.github.com/users/petrsvihlik/repos","events_url":"https://api.github.com/users/petrsvihlik/events{/privacy}","received_events_url":"https://api.github.com/users/petrsvihlik/received_events","type":"User","site_admin":false},"body":"yeah, i can see that, thank you very much :D \r\nwhat I meant is - why not to convert it into an automatic property and do all the `.Keys` and `.ToArray()`s calls outside, in the tests to be precise... now it really feels like a single-purpose solution.","created_at":"2018-12-14T09:09:32Z","updated_at":"2018-12-14T09:09:32Z","html_url":"https://github.com/Kentico/delivery-sdk-net/pull/150#discussion_r241684802","pull_request_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/150","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/comments/241684802"},"html":{"href":"https://github.com/Kentico/delivery-sdk-net/pull/150#discussion_r241684802"},"pull_request":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/150"}},"in_reply_to_id":241440249},"pull_request":{"url":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/150","id":236115988,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MTE1OTg4","html_url":"https://github.com/Kentico/delivery-sdk-net/pull/150","diff_url":"https://github.com/Kentico/delivery-sdk-net/pull/150.diff","patch_url":"https://github.com/Kentico/delivery-sdk-net/pull/150.patch","issue_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues/150","number":150,"state":"open","locked":false,"title":"Allow registering of default inline content items resolver","user":{"login":"matus12","id":14801630,"node_id":"MDQ6VXNlcjE0ODAxNjMw","avatar_url":"https://avatars3.githubusercontent.com/u/14801630?v=4","gravatar_id":"","url":"https://api.github.com/users/matus12","html_url":"https://github.com/matus12","followers_url":"https://api.github.com/users/matus12/followers","following_url":"https://api.github.com/users/matus12/following{/other_user}","gists_url":"https://api.github.com/users/matus12/gists{/gist_id}","starred_url":"https://api.github.com/users/matus12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matus12/subscriptions","organizations_url":"https://api.github.com/users/matus12/orgs","repos_url":"https://api.github.com/users/matus12/repos","events_url":"https://api.github.com/users/matus12/events{/privacy}","received_events_url":"https://api.github.com/users/matus12/received_events","type":"User","site_admin":false},"body":"Includes fix of a bug where content items without model made DeliveryClient to fail.\r\n\r\n### Motivation\r\n\r\nFixes #145 & #149 \r\n\r\n### Checklist\r\n\r\n- [x] Code follows coding conventions held in this repo\r\n- [x] Automated tests have been added\r\n- [x] Tests are passing\r\n- [ ] Docu has been updated (if applicable)\r\n- [x] Temporary settings (e.g. project ID used during development and testing) have been reverted to defaults\r\n","created_at":"2018-12-05T10:13:26Z","updated_at":"2018-12-14T09:09:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6748f5486dee2b42bea0abf8088216516f481ccc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/150/commits","review_comments_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/150/comments","review_comment_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues/150/comments","statuses_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/statuses/cd556222deedd8a6200c0e88dff1e500c34f2090","head":{"label":"Kentico:fix-InlineContentItemsProcessor-bugs","ref":"fix-InlineContentItemsProcessor-bugs","sha":"cd556222deedd8a6200c0e88dff1e500c34f2090","user":{"login":"Kentico","id":8819690,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4MTk2OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8819690?v=4","gravatar_id":"","url":"https://api.github.com/users/Kentico","html_url":"https://github.com/Kentico","followers_url":"https://api.github.com/users/Kentico/followers","following_url":"https://api.github.com/users/Kentico/following{/other_user}","gists_url":"https://api.github.com/users/Kentico/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentico/subscriptions","organizations_url":"https://api.github.com/users/Kentico/orgs","repos_url":"https://api.github.com/users/Kentico/repos","events_url":"https://api.github.com/users/Kentico/events{/privacy}","received_events_url":"https://api.github.com/users/Kentico/received_events","type":"Organization","site_admin":false},"repo":{"id":69869792,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg2OTc5Mg==","name":"delivery-sdk-net","full_name":"Kentico/delivery-sdk-net","private":false,"owner":{"login":"Kentico","id":8819690,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4MTk2OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8819690?v=4","gravatar_id":"","url":"https://api.github.com/users/Kentico","html_url":"https://github.com/Kentico","followers_url":"https://api.github.com/users/Kentico/followers","following_url":"https://api.github.com/users/Kentico/following{/other_user}","gists_url":"https://api.github.com/users/Kentico/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentico/subscriptions","organizations_url":"https://api.github.com/users/Kentico/orgs","repos_url":"https://api.github.com/users/Kentico/repos","events_url":"https://api.github.com/users/Kentico/events{/privacy}","received_events_url":"https://api.github.com/users/Kentico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Kentico/delivery-sdk-net","description":"Kentico Cloud Delivery .NET SDK","fork":false,"url":"https://api.github.com/repos/Kentico/delivery-sdk-net","forks_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/forks","keys_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/teams","hooks_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/hooks","issue_events_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues/events{/number}","events_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/events","assignees_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/assignees{/user}","branches_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/branches{/branch}","tags_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/tags","blobs_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/languages","stargazers_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/stargazers","contributors_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/contributors","subscribers_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/subscribers","subscription_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/subscription","commits_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/contents/{+path}","compare_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/merges","archive_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/downloads","issues_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues{/number}","pulls_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/labels{/name}","releases_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/releases{/id}","deployments_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/deployments","created_at":"2016-10-03T12:46:58Z","updated_at":"2018-12-07T13:14:56Z","pushed_at":"2018-12-12T15:48:12Z","git_url":"git://github.com/Kentico/delivery-sdk-net.git","ssh_url":"git@github.com:Kentico/delivery-sdk-net.git","clone_url":"https://github.com/Kentico/delivery-sdk-net.git","svn_url":"https://github.com/Kentico/delivery-sdk-net","homepage":"https://kenticocloud.com/","size":1729,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":16,"watchers":12,"default_branch":"master"}},"base":{"label":"Kentico:master","ref":"master","sha":"f267724e2291736c5d36108e439f8495d018cdc1","user":{"login":"Kentico","id":8819690,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4MTk2OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8819690?v=4","gravatar_id":"","url":"https://api.github.com/users/Kentico","html_url":"https://github.com/Kentico","followers_url":"https://api.github.com/users/Kentico/followers","following_url":"https://api.github.com/users/Kentico/following{/other_user}","gists_url":"https://api.github.com/users/Kentico/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentico/subscriptions","organizations_url":"https://api.github.com/users/Kentico/orgs","repos_url":"https://api.github.com/users/Kentico/repos","events_url":"https://api.github.com/users/Kentico/events{/privacy}","received_events_url":"https://api.github.com/users/Kentico/received_events","type":"Organization","site_admin":false},"repo":{"id":69869792,"node_id":"MDEwOlJlcG9zaXRvcnk2OTg2OTc5Mg==","name":"delivery-sdk-net","full_name":"Kentico/delivery-sdk-net","private":false,"owner":{"login":"Kentico","id":8819690,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4MTk2OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/8819690?v=4","gravatar_id":"","url":"https://api.github.com/users/Kentico","html_url":"https://github.com/Kentico","followers_url":"https://api.github.com/users/Kentico/followers","following_url":"https://api.github.com/users/Kentico/following{/other_user}","gists_url":"https://api.github.com/users/Kentico/gists{/gist_id}","starred_url":"https://api.github.com/users/Kentico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kentico/subscriptions","organizations_url":"https://api.github.com/users/Kentico/orgs","repos_url":"https://api.github.com/users/Kentico/repos","events_url":"https://api.github.com/users/Kentico/events{/privacy}","received_events_url":"https://api.github.com/users/Kentico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Kentico/delivery-sdk-net","description":"Kentico Cloud Delivery .NET SDK","fork":false,"url":"https://api.github.com/repos/Kentico/delivery-sdk-net","forks_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/forks","keys_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/teams","hooks_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/hooks","issue_events_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues/events{/number}","events_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/events","assignees_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/assignees{/user}","branches_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/branches{/branch}","tags_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/tags","blobs_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/statuses/{sha}","languages_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/languages","stargazers_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/stargazers","contributors_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/contributors","subscribers_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/subscribers","subscription_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/subscription","commits_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/contents/{+path}","compare_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/merges","archive_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/downloads","issues_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues{/number}","pulls_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls{/number}","milestones_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/milestones{/number}","notifications_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/labels{/name}","releases_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/releases{/id}","deployments_url":"https://api.github.com/repos/Kentico/delivery-sdk-net/deployments","created_at":"2016-10-03T12:46:58Z","updated_at":"2018-12-07T13:14:56Z","pushed_at":"2018-12-12T15:48:12Z","git_url":"git://github.com/Kentico/delivery-sdk-net.git","ssh_url":"git@github.com:Kentico/delivery-sdk-net.git","clone_url":"https://github.com/Kentico/delivery-sdk-net.git","svn_url":"https://github.com/Kentico/delivery-sdk-net","homepage":"https://kenticocloud.com/","size":1729,"stargazers_count":12,"watchers_count":12,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":25,"open_issues":16,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/150"},"html":{"href":"https://github.com/Kentico/delivery-sdk-net/pull/150"},"issue":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues/150"},"comments":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/issues/150/comments"},"review_comments":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/150/comments"},"review_comment":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/pulls/150/commits"},"statuses":{"href":"https://api.github.com/repos/Kentico/delivery-sdk-net/statuses/cd556222deedd8a6200c0e88dff1e500c34f2090"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"petrsvihlik"}}