{"action":"created","issue":{"url":"https://api.github.com/repos/trevor-vincent/d4est/issues/3","repository_url":"https://api.github.com/repos/trevor-vincent/d4est","labels_url":"https://api.github.com/repos/trevor-vincent/d4est/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/trevor-vincent/d4est/issues/3/comments","events_url":"https://api.github.com/repos/trevor-vincent/d4est/issues/3/events","html_url":"https://github.com/trevor-vincent/d4est/pull/3","id":294009684,"number":3,"title":"Added norms.log output in working directory","user":{"login":"nilsleiffischer","id":746230,"avatar_url":"https://avatars2.githubusercontent.com/u/746230?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsleiffischer","html_url":"https://github.com/nilsleiffischer","followers_url":"https://api.github.com/users/nilsleiffischer/followers","following_url":"https://api.github.com/users/nilsleiffischer/following{/other_user}","gists_url":"https://api.github.com/users/nilsleiffischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsleiffischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsleiffischer/subscriptions","organizations_url":"https://api.github.com/users/nilsleiffischer/orgs","repos_url":"https://api.github.com/users/nilsleiffischer/repos","events_url":"https://api.github.com/users/nilsleiffischer/events{/privacy}","received_events_url":"https://api.github.com/users/nilsleiffischer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-02-02T20:13:20Z","updated_at":"2018-02-07T21:13:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/trevor-vincent/d4est/pulls/3","html_url":"https://github.com/trevor-vincent/d4est/pull/3","diff_url":"https://github.com/trevor-vincent/d4est/pull/3.diff","patch_url":"https://github.com/trevor-vincent/d4est/pull/3.patch"},"body":"Hi Trevor, just putting this out there as a pull request for you - I simply write the norms you print to the console into a file as well, to get easier access to them from python scripts.\r\n\r\nIf you want you can merge this, but since I haven't written a whole lot of C code recently and am just getting into this again, could I ask you, when you get the chance, to review what I am writing in pull requests (this and the ones to come) and let me know any comments you may have (on flaws in my code, best-practices, ...)? This would help me a lot to get up to speed I think. Just feel free to comment on any lines of code 🙂\r\n\r\nAlso, how do you think about integrating a logging library such as [zlog](https://github.com/HardySimpson/zlog) into the code? It's an additional dependency, but could be compiled from another submodule, and I always prefer to ditch `printf`s in favour of a more flexible logging."},"comment":{"url":"https://api.github.com/repos/trevor-vincent/d4est/issues/comments/363912617","html_url":"https://github.com/trevor-vincent/d4est/pull/3#issuecomment-363912617","issue_url":"https://api.github.com/repos/trevor-vincent/d4est/issues/3","id":363912617,"user":{"login":"nilsleiffischer","id":746230,"avatar_url":"https://avatars2.githubusercontent.com/u/746230?v=4","gravatar_id":"","url":"https://api.github.com/users/nilsleiffischer","html_url":"https://github.com/nilsleiffischer","followers_url":"https://api.github.com/users/nilsleiffischer/followers","following_url":"https://api.github.com/users/nilsleiffischer/following{/other_user}","gists_url":"https://api.github.com/users/nilsleiffischer/gists{/gist_id}","starred_url":"https://api.github.com/users/nilsleiffischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nilsleiffischer/subscriptions","organizations_url":"https://api.github.com/users/nilsleiffischer/orgs","repos_url":"https://api.github.com/users/nilsleiffischer/repos","events_url":"https://api.github.com/users/nilsleiffischer/events{/privacy}","received_events_url":"https://api.github.com/users/nilsleiffischer/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T21:13:52Z","updated_at":"2018-02-07T21:13:52Z","author_association":"CONTRIBUTOR","body":"Yep makes sense, it's really only keeping the `sc_reduce`s together that makes things difficult, and that's not a big issue. I'll refactor tomorrow 😄"}}
{"actor":{"display_login":"nilsleiffischer"}}