{"action":"created","issue":{"url":"https://api.github.com/repos/guardianproject/NetCipher/issues/74","repository_url":"https://api.github.com/repos/guardianproject/NetCipher","labels_url":"https://api.github.com/repos/guardianproject/NetCipher/issues/74/labels{/name}","comments_url":"https://api.github.com/repos/guardianproject/NetCipher/issues/74/comments","events_url":"https://api.github.com/repos/guardianproject/NetCipher/issues/74/events","html_url":"https://github.com/guardianproject/NetCipher/pull/74","id":324667100,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MjEwNzIy","number":74,"title":"Fix TLSv1.3 compatibility by not adding TLS_FALLBACK_SCSV","user":{"login":"tmolitor-stud-tu","id":6234248,"node_id":"MDQ6VXNlcjYyMzQyNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/6234248?v=4","gravatar_id":"","url":"https://api.github.com/users/tmolitor-stud-tu","html_url":"https://github.com/tmolitor-stud-tu","followers_url":"https://api.github.com/users/tmolitor-stud-tu/followers","following_url":"https://api.github.com/users/tmolitor-stud-tu/following{/other_user}","gists_url":"https://api.github.com/users/tmolitor-stud-tu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmolitor-stud-tu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmolitor-stud-tu/subscriptions","organizations_url":"https://api.github.com/users/tmolitor-stud-tu/orgs","repos_url":"https://api.github.com/users/tmolitor-stud-tu/repos","events_url":"https://api.github.com/users/tmolitor-stud-tu/events{/privacy}","received_events_url":"https://api.github.com/users/tmolitor-stud-tu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":33,"created_at":"2018-05-19T23:06:36Z","updated_at":"2018-06-13T07:45:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/guardianproject/NetCipher/pulls/74","html_url":"https://github.com/guardianproject/NetCipher/pull/74","diff_url":"https://github.com/guardianproject/NetCipher/pull/74.diff","patch_url":"https://github.com/guardianproject/NetCipher/pull/74.patch"},"body":"`TLS_FALLBACK_SCSV` **MUST NOT** be set on first connect, see\r\nhttps://github.com/yeriomin/YalpStore/issues/447#issuecomment-390105926\r\nand RFC 7507 (https://tools.ietf.org/html/rfc7507)\r\n\r\nWithout this patch **every** android device not supporting TLSv1.3 trying to connect to an TLSv1.3 enabled server will fail!\r\n\r\nSome more insights: https://www.mail-archive.com/openssl-users@openssl.org/msg75283.html"},"comment":{"url":"https://api.github.com/repos/guardianproject/NetCipher/issues/comments/396845980","html_url":"https://github.com/guardianproject/NetCipher/pull/74#issuecomment-396845980","issue_url":"https://api.github.com/repos/guardianproject/NetCipher/issues/74","id":396845980,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Njg0NTk4MA==","user":{"login":"eighthave","id":143465,"node_id":"MDQ6VXNlcjE0MzQ2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/143465?v=4","gravatar_id":"","url":"https://api.github.com/users/eighthave","html_url":"https://github.com/eighthave","followers_url":"https://api.github.com/users/eighthave/followers","following_url":"https://api.github.com/users/eighthave/following{/other_user}","gists_url":"https://api.github.com/users/eighthave/gists{/gist_id}","starred_url":"https://api.github.com/users/eighthave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eighthave/subscriptions","organizations_url":"https://api.github.com/users/eighthave/orgs","repos_url":"https://api.github.com/users/eighthave/repos","events_url":"https://api.github.com/users/eighthave/events{/privacy}","received_events_url":"https://api.github.com/users/eighthave/received_events","type":"User","site_admin":false},"created_at":"2018-06-13T07:45:22Z","updated_at":"2018-06-13T07:45:22Z","author_association":"MEMBER","body":"@tmolitor-stud-tu if the core OS will never add _TLS_FALLBACK_SCSV_ to the Enabled Cipher List, then there should never be code that tries to remove it.  NetCipher shouldn't second guess the OS here for the Enabled Cipher List, and security sensitive code should never add code that does not have a tested and deliberate purpose."}}
{"actor":{"display_login":"eighthave"}}