{"action":"created","comment":{"url":"https://api.github.com/repos/Shopify/buy-button-js/pulls/comments/233608451","pull_request_review_id":175060877,"id":233608451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzYwODQ1MQ==","diff_hunk":"@@ -1,189 +1,211 @@\n-import ShopifyBuy from '../../src/buybutton';\n import Component from '../../src/component';\n import View from '../../src/view';\n+import Updater from '../../src/updater';\n import componentDefaults from '../../src/defaults/components';\n \n-describe('Component class', () => {\n \n+describe('Component class', () => {\n   describe('constructor', () => {\n-    it('stores id, node, and handle on instance', () => {\n-      let node = document.createElement('div');\n-      let component = new Component({\n-        id: 1234,\n-        handle: 'lol',\n-        node: node,\n-      });\n+    let component;\n+    const node = document.createElement('div');\n+\n+    beforeEach(() => {\n+      component = new Component({","path":"test/unit/component.js","position":22,"original_position":22,"commit_id":"007cfa71d91190e2ed242725c0650c296083fd40","original_commit_id":"007cfa71d91190e2ed242725c0650c296083fd40","user":{"login":"melissaluu","id":6719231,"node_id":"MDQ6VXNlcjY3MTkyMzE=","avatar_url":"https://avatars2.githubusercontent.com/u/6719231?v=4","gravatar_id":"","url":"https://api.github.com/users/melissaluu","html_url":"https://github.com/melissaluu","followers_url":"https://api.github.com/users/melissaluu/followers","following_url":"https://api.github.com/users/melissaluu/following{/other_user}","gists_url":"https://api.github.com/users/melissaluu/gists{/gist_id}","starred_url":"https://api.github.com/users/melissaluu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissaluu/subscriptions","organizations_url":"https://api.github.com/users/melissaluu/orgs","repos_url":"https://api.github.com/users/melissaluu/repos","events_url":"https://api.github.com/users/melissaluu/events{/privacy}","received_events_url":"https://api.github.com/users/melissaluu/received_events","type":"User","site_admin":false},"body":"Let's abstract this out to a constant and use the constant reference in our assertions","created_at":"2018-11-14T20:30:11Z","updated_at":"2018-11-14T20:30:14Z","html_url":"https://github.com/Shopify/buy-button-js/pull/543#discussion_r233608451","pull_request_url":"https://api.github.com/repos/Shopify/buy-button-js/pulls/543","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Shopify/buy-button-js/pulls/comments/233608451"},"html":{"href":"https://github.com/Shopify/buy-button-js/pull/543#discussion_r233608451"},"pull_request":{"href":"https://api.github.com/repos/Shopify/buy-button-js/pulls/543"}}},"pull_request":{"url":"https://api.github.com/repos/Shopify/buy-button-js/pulls/543","id":230953569,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTUzNTY5","html_url":"https://github.com/Shopify/buy-button-js/pull/543","diff_url":"https://github.com/Shopify/buy-button-js/pull/543.diff","patch_url":"https://github.com/Shopify/buy-button-js/pull/543.patch","issue_url":"https://api.github.com/repos/Shopify/buy-button-js/issues/543","number":543,"state":"open","locked":false,"title":"Updated constructor tests in component","user":{"login":"jameskim08","id":16577705,"node_id":"MDQ6VXNlcjE2NTc3NzA1","avatar_url":"https://avatars2.githubusercontent.com/u/16577705?v=4","gravatar_id":"","url":"https://api.github.com/users/jameskim08","html_url":"https://github.com/jameskim08","followers_url":"https://api.github.com/users/jameskim08/followers","following_url":"https://api.github.com/users/jameskim08/following{/other_user}","gists_url":"https://api.github.com/users/jameskim08/gists{/gist_id}","starred_url":"https://api.github.com/users/jameskim08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameskim08/subscriptions","organizations_url":"https://api.github.com/users/jameskim08/orgs","repos_url":"https://api.github.com/users/jameskim08/repos","events_url":"https://api.github.com/users/jameskim08/events{/privacy}","received_events_url":"https://api.github.com/users/jameskim08/received_events","type":"User","site_admin":false},"body":"- extracted instantiation to a beforeEach\r\n- updated existing constructor tests\r\n- created new constructor tests","created_at":"2018-11-14T19:27:32Z","updated_at":"2018-11-14T20:30:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b539e92c6d828d47189fd23a7e811d06a0e9f9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Shopify/buy-button-js/pulls/543/commits","review_comments_url":"https://api.github.com/repos/Shopify/buy-button-js/pulls/543/comments","review_comment_url":"https://api.github.com/repos/Shopify/buy-button-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Shopify/buy-button-js/issues/543/comments","statuses_url":"https://api.github.com/repos/Shopify/buy-button-js/statuses/007cfa71d91190e2ed242725c0650c296083fd40","head":{"label":"Shopify:update-component-constructor-tests","ref":"update-component-constructor-tests","sha":"007cfa71d91190e2ed242725c0650c296083fd40","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":61155651,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1NTY1MQ==","name":"buy-button-js","full_name":"Shopify/buy-button-js","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/buy-button-js","description":"BuyButton.js is a highly customizable UI library for adding ecommerce functionality to any website.","fork":false,"url":"https://api.github.com/repos/Shopify/buy-button-js","forks_url":"https://api.github.com/repos/Shopify/buy-button-js/forks","keys_url":"https://api.github.com/repos/Shopify/buy-button-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/buy-button-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/buy-button-js/teams","hooks_url":"https://api.github.com/repos/Shopify/buy-button-js/hooks","issue_events_url":"https://api.github.com/repos/Shopify/buy-button-js/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/buy-button-js/events","assignees_url":"https://api.github.com/repos/Shopify/buy-button-js/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/buy-button-js/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/buy-button-js/tags","blobs_url":"https://api.github.com/repos/Shopify/buy-button-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/buy-button-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/buy-button-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/buy-button-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/buy-button-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/buy-button-js/languages","stargazers_url":"https://api.github.com/repos/Shopify/buy-button-js/stargazers","contributors_url":"https://api.github.com/repos/Shopify/buy-button-js/contributors","subscribers_url":"https://api.github.com/repos/Shopify/buy-button-js/subscribers","subscription_url":"https://api.github.com/repos/Shopify/buy-button-js/subscription","commits_url":"https://api.github.com/repos/Shopify/buy-button-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/buy-button-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/buy-button-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/buy-button-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/buy-button-js/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/buy-button-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/buy-button-js/merges","archive_url":"https://api.github.com/repos/Shopify/buy-button-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/buy-button-js/downloads","issues_url":"https://api.github.com/repos/Shopify/buy-button-js/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/buy-button-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/buy-button-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/buy-button-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/buy-button-js/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/buy-button-js/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/buy-button-js/deployments","created_at":"2016-06-14T21:04:01Z","updated_at":"2018-11-14T20:29:25Z","pushed_at":"2018-11-14T20:29:32Z","git_url":"git://github.com/Shopify/buy-button-js.git","ssh_url":"git@github.com:Shopify/buy-button-js.git","clone_url":"https://github.com/Shopify/buy-button-js.git","svn_url":"https://github.com/Shopify/buy-button-js","homepage":"http://shopify.github.io/buy-button-js/","size":1996,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":37,"open_issues":60,"watchers":71,"default_branch":"master"}},"base":{"label":"Shopify:master","ref":"master","sha":"a6a58705f0e0c859987155acd247702ef8be5658","user":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"repo":{"id":61155651,"node_id":"MDEwOlJlcG9zaXRvcnk2MTE1NTY1MQ==","name":"buy-button-js","full_name":"Shopify/buy-button-js","private":false,"owner":{"login":"Shopify","id":8085,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwODU=","avatar_url":"https://avatars1.githubusercontent.com/u/8085?v=4","gravatar_id":"","url":"https://api.github.com/users/Shopify","html_url":"https://github.com/Shopify","followers_url":"https://api.github.com/users/Shopify/followers","following_url":"https://api.github.com/users/Shopify/following{/other_user}","gists_url":"https://api.github.com/users/Shopify/gists{/gist_id}","starred_url":"https://api.github.com/users/Shopify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shopify/subscriptions","organizations_url":"https://api.github.com/users/Shopify/orgs","repos_url":"https://api.github.com/users/Shopify/repos","events_url":"https://api.github.com/users/Shopify/events{/privacy}","received_events_url":"https://api.github.com/users/Shopify/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Shopify/buy-button-js","description":"BuyButton.js is a highly customizable UI library for adding ecommerce functionality to any website.","fork":false,"url":"https://api.github.com/repos/Shopify/buy-button-js","forks_url":"https://api.github.com/repos/Shopify/buy-button-js/forks","keys_url":"https://api.github.com/repos/Shopify/buy-button-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shopify/buy-button-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shopify/buy-button-js/teams","hooks_url":"https://api.github.com/repos/Shopify/buy-button-js/hooks","issue_events_url":"https://api.github.com/repos/Shopify/buy-button-js/issues/events{/number}","events_url":"https://api.github.com/repos/Shopify/buy-button-js/events","assignees_url":"https://api.github.com/repos/Shopify/buy-button-js/assignees{/user}","branches_url":"https://api.github.com/repos/Shopify/buy-button-js/branches{/branch}","tags_url":"https://api.github.com/repos/Shopify/buy-button-js/tags","blobs_url":"https://api.github.com/repos/Shopify/buy-button-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shopify/buy-button-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shopify/buy-button-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shopify/buy-button-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shopify/buy-button-js/statuses/{sha}","languages_url":"https://api.github.com/repos/Shopify/buy-button-js/languages","stargazers_url":"https://api.github.com/repos/Shopify/buy-button-js/stargazers","contributors_url":"https://api.github.com/repos/Shopify/buy-button-js/contributors","subscribers_url":"https://api.github.com/repos/Shopify/buy-button-js/subscribers","subscription_url":"https://api.github.com/repos/Shopify/buy-button-js/subscription","commits_url":"https://api.github.com/repos/Shopify/buy-button-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shopify/buy-button-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shopify/buy-button-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shopify/buy-button-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shopify/buy-button-js/contents/{+path}","compare_url":"https://api.github.com/repos/Shopify/buy-button-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shopify/buy-button-js/merges","archive_url":"https://api.github.com/repos/Shopify/buy-button-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shopify/buy-button-js/downloads","issues_url":"https://api.github.com/repos/Shopify/buy-button-js/issues{/number}","pulls_url":"https://api.github.com/repos/Shopify/buy-button-js/pulls{/number}","milestones_url":"https://api.github.com/repos/Shopify/buy-button-js/milestones{/number}","notifications_url":"https://api.github.com/repos/Shopify/buy-button-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shopify/buy-button-js/labels{/name}","releases_url":"https://api.github.com/repos/Shopify/buy-button-js/releases{/id}","deployments_url":"https://api.github.com/repos/Shopify/buy-button-js/deployments","created_at":"2016-06-14T21:04:01Z","updated_at":"2018-11-14T20:29:25Z","pushed_at":"2018-11-14T20:29:32Z","git_url":"git://github.com/Shopify/buy-button-js.git","ssh_url":"git@github.com:Shopify/buy-button-js.git","clone_url":"https://github.com/Shopify/buy-button-js.git","svn_url":"https://github.com/Shopify/buy-button-js","homepage":"http://shopify.github.io/buy-button-js/","size":1996,"stargazers_count":71,"watchers_count":71,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":37,"open_issues":60,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Shopify/buy-button-js/pulls/543"},"html":{"href":"https://github.com/Shopify/buy-button-js/pull/543"},"issue":{"href":"https://api.github.com/repos/Shopify/buy-button-js/issues/543"},"comments":{"href":"https://api.github.com/repos/Shopify/buy-button-js/issues/543/comments"},"review_comments":{"href":"https://api.github.com/repos/Shopify/buy-button-js/pulls/543/comments"},"review_comment":{"href":"https://api.github.com/repos/Shopify/buy-button-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Shopify/buy-button-js/pulls/543/commits"},"statuses":{"href":"https://api.github.com/repos/Shopify/buy-button-js/statuses/007cfa71d91190e2ed242725c0650c296083fd40"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"melissaluu"}}