{"action":"closed","number":126,"pull_request":{"url":"https://api.github.com/repos/mozilla-services/pytest-services/pulls/126","id":203267248,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjY3MjQ4","html_url":"https://github.com/mozilla-services/pytest-services/pull/126","diff_url":"https://github.com/mozilla-services/pytest-services/pull/126.diff","patch_url":"https://github.com/mozilla-services/pytest-services/pull/126.patch","issue_url":"https://api.github.com/repos/mozilla-services/pytest-services/issues/126","number":126,"state":"closed","locked":false,"title":"Fix conftest imports","user":{"login":"g-k","id":226605,"node_id":"MDQ6VXNlcjIyNjYwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/226605?v=4","gravatar_id":"","url":"https://api.github.com/users/g-k","html_url":"https://github.com/g-k","followers_url":"https://api.github.com/users/g-k/followers","following_url":"https://api.github.com/users/g-k/following{/other_user}","gists_url":"https://api.github.com/users/g-k/gists{/gist_id}","starred_url":"https://api.github.com/users/g-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-k/subscriptions","organizations_url":"https://api.github.com/users/g-k/orgs","repos_url":"https://api.github.com/users/g-k/repos","events_url":"https://api.github.com/users/g-k/events{/privacy}","received_events_url":"https://api.github.com/users/g-k/received_events","type":"User","site_admin":false},"body":"fixes: #119 \r\n\r\nAdd checks for the patterns in https://github.com/mozilla-services/pytest-services/issues/119#issuecomment-391153748\r\n\r\nNB: This requires ripgrep which might not be installed in CI.\r\n\r\nFunctional Tests:\r\n\r\n- [x] Add `import conftest` to a file and check that `make check_conftest_imports` errors\r\n\r\n- [x] Add `from conftest import ` to a file and check that `make check_conftest_imports` errors\r\n\r\n- [x] Run on master and check that `make check_conftest_imports` does not error","created_at":"2018-07-23T16:01:11Z","updated_at":"2018-07-24T15:31:47Z","closed_at":"2018-07-24T15:31:47Z","merged_at":"2018-07-24T15:31:47Z","merge_commit_sha":"93708055e712b98e7e3331c2bebd0876d09810d3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-services/pytest-services/pulls/126/commits","review_comments_url":"https://api.github.com/repos/mozilla-services/pytest-services/pulls/126/comments","review_comment_url":"https://api.github.com/repos/mozilla-services/pytest-services/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-services/pytest-services/issues/126/comments","statuses_url":"https://api.github.com/repos/mozilla-services/pytest-services/statuses/568e9d13c4b2a5e9eb9c1da035e25d68ffa9b9bb","head":{"label":"mozilla-services:fix-conftest-imports","ref":"fix-conftest-imports","sha":"568e9d13c4b2a5e9eb9c1da035e25d68ffa9b9bb","user":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":105812506,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MTI1MDY=","name":"pytest-services","full_name":"mozilla-services/pytest-services","owner":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pytest-services","description":"Unit testing framework for test driven security of AWS configurations, and more.","fork":false,"url":"https://api.github.com/repos/mozilla-services/pytest-services","forks_url":"https://api.github.com/repos/mozilla-services/pytest-services/forks","keys_url":"https://api.github.com/repos/mozilla-services/pytest-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pytest-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pytest-services/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pytest-services/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pytest-services/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pytest-services/events","assignees_url":"https://api.github.com/repos/mozilla-services/pytest-services/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pytest-services/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pytest-services/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pytest-services/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pytest-services/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pytest-services/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pytest-services/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pytest-services/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pytest-services/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pytest-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pytest-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pytest-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/pytest-services/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pytest-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pytest-services/merges","archive_url":"https://api.github.com/repos/mozilla-services/pytest-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pytest-services/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pytest-services/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pytest-services/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pytest-services/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pytest-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pytest-services/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pytest-services/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/pytest-services/deployments","created_at":"2017-10-04T20:00:35Z","updated_at":"2018-07-16T21:31:28Z","pushed_at":"2018-07-24T15:31:47Z","git_url":"git://github.com/mozilla-services/pytest-services.git","ssh_url":"git@github.com:mozilla-services/pytest-services.git","clone_url":"https://github.com/mozilla-services/pytest-services.git","svn_url":"https://github.com/mozilla-services/pytest-services","homepage":"","size":393,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":31,"watchers":13,"default_branch":"master"}},"base":{"label":"mozilla-services:master","ref":"master","sha":"e5da7eadbcba0eb77ecb84eb207a28159a1c41ba","user":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"repo":{"id":105812506,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MTI1MDY=","name":"pytest-services","full_name":"mozilla-services/pytest-services","owner":{"login":"mozilla-services","id":1066228,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjYyMjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1066228?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla-services","html_url":"https://github.com/mozilla-services","followers_url":"https://api.github.com/users/mozilla-services/followers","following_url":"https://api.github.com/users/mozilla-services/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-services/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-services/subscriptions","organizations_url":"https://api.github.com/users/mozilla-services/orgs","repos_url":"https://api.github.com/users/mozilla-services/repos","events_url":"https://api.github.com/users/mozilla-services/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-services/pytest-services","description":"Unit testing framework for test driven security of AWS configurations, and more.","fork":false,"url":"https://api.github.com/repos/mozilla-services/pytest-services","forks_url":"https://api.github.com/repos/mozilla-services/pytest-services/forks","keys_url":"https://api.github.com/repos/mozilla-services/pytest-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-services/pytest-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-services/pytest-services/teams","hooks_url":"https://api.github.com/repos/mozilla-services/pytest-services/hooks","issue_events_url":"https://api.github.com/repos/mozilla-services/pytest-services/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-services/pytest-services/events","assignees_url":"https://api.github.com/repos/mozilla-services/pytest-services/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-services/pytest-services/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-services/pytest-services/tags","blobs_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-services/pytest-services/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-services/pytest-services/languages","stargazers_url":"https://api.github.com/repos/mozilla-services/pytest-services/stargazers","contributors_url":"https://api.github.com/repos/mozilla-services/pytest-services/contributors","subscribers_url":"https://api.github.com/repos/mozilla-services/pytest-services/subscribers","subscription_url":"https://api.github.com/repos/mozilla-services/pytest-services/subscription","commits_url":"https://api.github.com/repos/mozilla-services/pytest-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-services/pytest-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-services/pytest-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-services/pytest-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-services/pytest-services/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-services/pytest-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-services/pytest-services/merges","archive_url":"https://api.github.com/repos/mozilla-services/pytest-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-services/pytest-services/downloads","issues_url":"https://api.github.com/repos/mozilla-services/pytest-services/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-services/pytest-services/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-services/pytest-services/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-services/pytest-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-services/pytest-services/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-services/pytest-services/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla-services/pytest-services/deployments","created_at":"2017-10-04T20:00:35Z","updated_at":"2018-07-16T21:31:28Z","pushed_at":"2018-07-24T15:31:47Z","git_url":"git://github.com/mozilla-services/pytest-services.git","ssh_url":"git@github.com:mozilla-services/pytest-services.git","clone_url":"https://github.com/mozilla-services/pytest-services.git","svn_url":"https://github.com/mozilla-services/pytest-services","homepage":"","size":393,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":2,"open_issues":31,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-services/pytest-services/pulls/126"},"html":{"href":"https://github.com/mozilla-services/pytest-services/pull/126"},"issue":{"href":"https://api.github.com/repos/mozilla-services/pytest-services/issues/126"},"comments":{"href":"https://api.github.com/repos/mozilla-services/pytest-services/issues/126/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-services/pytest-services/pulls/126/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-services/pytest-services/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-services/pytest-services/pulls/126/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-services/pytest-services/statuses/568e9d13c4b2a5e9eb9c1da035e25d68ffa9b9bb"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"g-k","id":226605,"node_id":"MDQ6VXNlcjIyNjYwNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/226605?v=4","gravatar_id":"","url":"https://api.github.com/users/g-k","html_url":"https://github.com/g-k","followers_url":"https://api.github.com/users/g-k/followers","following_url":"https://api.github.com/users/g-k/following{/other_user}","gists_url":"https://api.github.com/users/g-k/gists{/gist_id}","starred_url":"https://api.github.com/users/g-k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/g-k/subscriptions","organizations_url":"https://api.github.com/users/g-k/orgs","repos_url":"https://api.github.com/users/g-k/repos","events_url":"https://api.github.com/users/g-k/events{/privacy}","received_events_url":"https://api.github.com/users/g-k/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":11,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"g-k"}}