{"action":"created","issue":{"url":"https://api.github.com/repos/cmcaine/tridactyl/issues/619","repository_url":"https://api.github.com/repos/cmcaine/tridactyl","labels_url":"https://api.github.com/repos/cmcaine/tridactyl/issues/619/labels{/name}","comments_url":"https://api.github.com/repos/cmcaine/tridactyl/issues/619/comments","events_url":"https://api.github.com/repos/cmcaine/tridactyl/issues/619/events","html_url":"https://github.com/cmcaine/tridactyl/pull/619","id":326755587,"number":619,"title":"Js pipes","user":{"login":"glacambre","id":11534587,"avatar_url":"https://avatars2.githubusercontent.com/u/11534587?v=4","gravatar_id":"","url":"https://api.github.com/users/glacambre","html_url":"https://github.com/glacambre","followers_url":"https://api.github.com/users/glacambre/followers","following_url":"https://api.github.com/users/glacambre/following{/other_user}","gists_url":"https://api.github.com/users/glacambre/gists{/gist_id}","starred_url":"https://api.github.com/users/glacambre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glacambre/subscriptions","organizations_url":"https://api.github.com/users/glacambre/orgs","repos_url":"https://api.github.com/users/glacambre/repos","events_url":"https://api.github.com/users/glacambre/events{/privacy}","received_events_url":"https://api.github.com/users/glacambre/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-26T17:46:32Z","updated_at":"2018-05-26T18:01:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cmcaine/tridactyl/pulls/619","html_url":"https://github.com/cmcaine/tridactyl/pull/619","diff_url":"https://github.com/cmcaine/tridactyl/pull/619.diff","patch_url":"https://github.com/cmcaine/tridactyl/pull/619.patch"},"body":"Issue with previous discussion: https://github.com/cmcaine/tridactyl/issues/563\r\n\r\nMy code doesn't have the error handling the previous code had, but I'm not sure passing errors through pipes is a good idea. I believe it's better to just let the whole pipeline break. Are there disadvantages to not doing any \"internal\" error handling?\r\n\r\nAlso, I've added an \"arg\" variable to js and jsb for easy access to the piped value. I thought a bit about how to automatically insert \"//\" in the evaluated string but I can't come up with something that would be reliable. We could add a flag to js, perhaps \"-p\" for \"pipe\", which would be required to be at the very beginning of the command and would let js know it should insert \"//\" at the end of the string. Not having to manually remove the \"//\" at the end of a command you're editing from your history could be nice.\r\nAre there alternatives I haven't thought of?"},"comment":{"url":"https://api.github.com/repos/cmcaine/tridactyl/issues/comments/392277840","html_url":"https://github.com/cmcaine/tridactyl/pull/619#issuecomment-392277840","issue_url":"https://api.github.com/repos/cmcaine/tridactyl/issues/619","id":392277840,"user":{"login":"bovine3dom","id":6505246,"avatar_url":"https://avatars3.githubusercontent.com/u/6505246?v=4","gravatar_id":"","url":"https://api.github.com/users/bovine3dom","html_url":"https://github.com/bovine3dom","followers_url":"https://api.github.com/users/bovine3dom/followers","following_url":"https://api.github.com/users/bovine3dom/following{/other_user}","gists_url":"https://api.github.com/users/bovine3dom/gists{/gist_id}","starred_url":"https://api.github.com/users/bovine3dom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bovine3dom/subscriptions","organizations_url":"https://api.github.com/users/bovine3dom/orgs","repos_url":"https://api.github.com/users/bovine3dom/repos","events_url":"https://api.github.com/users/bovine3dom/events{/privacy}","received_events_url":"https://api.github.com/users/bovine3dom/received_events","type":"User","site_admin":false},"created_at":"2018-05-26T18:01:35Z","updated_at":"2018-05-26T18:01:35Z","author_association":"COLLABORATOR","body":"I think `js -p` could be a sound idea - outside of a pipe, `arg` will probably be nonsense, so we shouldn't define it at all."}}
{"actor":{"display_login":"bovine3dom"}}