{"action":"created","comment":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/185047675","pull_request_review_id":116361592,"id":185047675,"diff_hunk":"@@ -183,6 +193,10 @@ object KafkaDataStoreFactory {\n     val CacheConsistency = new GeoMesaParam[Duration](\"kafka.cache.consistency\", \"Check the feature cache for consistency at this interval\", deprecatedParams = Seq(DeprecatedConsistency))\n     val CacheTicker      = new GeoMesaParam[Ticker](\"kafka.cache.ticker\", \"Ticker to use for expiring/cleaning feature cache\")\n     val CqEngineCache    = new GeoMesaParam[java.lang.Boolean](\"kafka.cache.cqengine\", \"Use CQEngine-based implementation of live feature cache\", default = false, deprecatedKeys = Seq(\"useCQCache\"))\n+    val EventTime        = new GeoMesaParam[java.lang.Boolean](\"kafka.cache.eventtime\", \"Use Event Time for managing cache of features\", default = false)\n+    val EventTimeAttribute = new GeoMesaParam[String](\"kafka.cache.eventtime.attribute\", \"Use the configured attribute to compute Event Time\", default = \"\")\n+    val EventTimeOrdering  = new GeoMesaParam[java.lang.Boolean](\"kafka.cache.eventtime.ordering\", \"Use order of event time to update a feature or not\", default = false)\n+    val EventTimeExpiry    = new GeoMesaParam[java.lang.Boolean](\"kafka.cache.eventtime.expiry\", \"Use event time to determine expiry of features\", default = false)","path":"geomesa-kafka/geomesa-kafka-datastore/src/main/scala/org/locationtech/geomesa/kafka/data/KafkaDataStoreFactory.scala","position":40,"original_position":40,"commit_id":"efb8563c918980ed6101a446fbb5a7ca6b8bec9e","original_commit_id":"a93c98bdd319051a38d012b8e162645b3502ef31","user":{"login":"jahhulbert-ccri","id":7433591,"avatar_url":"https://avatars3.githubusercontent.com/u/7433591?v=4","gravatar_id":"","url":"https://api.github.com/users/jahhulbert-ccri","html_url":"https://github.com/jahhulbert-ccri","followers_url":"https://api.github.com/users/jahhulbert-ccri/followers","following_url":"https://api.github.com/users/jahhulbert-ccri/following{/other_user}","gists_url":"https://api.github.com/users/jahhulbert-ccri/gists{/gist_id}","starred_url":"https://api.github.com/users/jahhulbert-ccri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jahhulbert-ccri/subscriptions","organizations_url":"https://api.github.com/users/jahhulbert-ccri/orgs","repos_url":"https://api.github.com/users/jahhulbert-ccri/repos","events_url":"https://api.github.com/users/jahhulbert-ccri/events{/privacy}","received_events_url":"https://api.github.com/users/jahhulbert-ccri/received_events","type":"User","site_admin":false},"body":"got it.","created_at":"2018-04-30T17:07:10Z","updated_at":"2018-04-30T17:07:10Z","html_url":"https://github.com/locationtech/geomesa/pull/1922#discussion_r185047675","pull_request_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1922","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments/185047675"},"html":{"href":"https://github.com/locationtech/geomesa/pull/1922#discussion_r185047675"},"pull_request":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1922"}},"in_reply_to_id":179132681},"pull_request":{"url":"https://api.github.com/repos/locationtech/geomesa/pulls/1922","id":179217918,"html_url":"https://github.com/locationtech/geomesa/pull/1922","diff_url":"https://github.com/locationtech/geomesa/pull/1922.diff","patch_url":"https://github.com/locationtech/geomesa/pull/1922.patch","issue_url":"https://api.github.com/repos/locationtech/geomesa/issues/1922","number":1922,"state":"open","locked":false,"title":"GEOMESA-2251 Kafka - event time","user":{"login":"anthonyccri","id":893732,"avatar_url":"https://avatars3.githubusercontent.com/u/893732?v=4","gravatar_id":"","url":"https://api.github.com/users/anthonyccri","html_url":"https://github.com/anthonyccri","followers_url":"https://api.github.com/users/anthonyccri/followers","following_url":"https://api.github.com/users/anthonyccri/following{/other_user}","gists_url":"https://api.github.com/users/anthonyccri/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonyccri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonyccri/subscriptions","organizations_url":"https://api.github.com/users/anthonyccri/orgs","repos_url":"https://api.github.com/users/anthonyccri/repos","events_url":"https://api.github.com/users/anthonyccri/events{/privacy}","received_events_url":"https://api.github.com/users/anthonyccri/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-03T20:57:32Z","updated_at":"2018-04-30T17:07:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c77203f227f5fd2dbfc2ac3903a21213d9c69df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":882882231,"url":"https://api.github.com/repos/locationtech/geomesa/labels/needs%20work","name":"needs work","color":"d4c5f9","default":false}],"milestone":{"url":"https://api.github.com/repos/locationtech/geomesa/milestones/20","html_url":"https://github.com/locationtech/geomesa/milestone/20","labels_url":"https://api.github.com/repos/locationtech/geomesa/milestones/20/labels","id":3248301,"number":20,"title":"2.1.0","description":null,"creator":{"login":"elahrvivaz","id":7715322,"avatar_url":"https://avatars0.githubusercontent.com/u/7715322?v=4","gravatar_id":"","url":"https://api.github.com/users/elahrvivaz","html_url":"https://github.com/elahrvivaz","followers_url":"https://api.github.com/users/elahrvivaz/followers","following_url":"https://api.github.com/users/elahrvivaz/following{/other_user}","gists_url":"https://api.github.com/users/elahrvivaz/gists{/gist_id}","starred_url":"https://api.github.com/users/elahrvivaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elahrvivaz/subscriptions","organizations_url":"https://api.github.com/users/elahrvivaz/orgs","repos_url":"https://api.github.com/users/elahrvivaz/repos","events_url":"https://api.github.com/users/elahrvivaz/events{/privacy}","received_events_url":"https://api.github.com/users/elahrvivaz/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":2,"state":"open","created_at":"2018-04-06T16:42:07Z","updated_at":"2018-04-30T13:52:52Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1922/commits","review_comments_url":"https://api.github.com/repos/locationtech/geomesa/pulls/1922/comments","review_comment_url":"https://api.github.com/repos/locationtech/geomesa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/locationtech/geomesa/issues/1922/comments","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/efb8563c918980ed6101a446fbb5a7ca6b8bec9e","head":{"label":"locationtech:fcr_kafka_event_time","ref":"fcr_kafka_event_time","sha":"efb8563c918980ed6101a446fbb5a7ca6b8bec9e","user":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars2.githubusercontent.com/u/1991411?v=4","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"repo":{"id":13226069,"name":"geomesa","full_name":"locationtech/geomesa","owner":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars2.githubusercontent.com/u/1991411?v=4","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locationtech/geomesa","description":"GeoMesa is a suite of tools for working with big geo-spatial data in a distributed fashion.","fork":false,"url":"https://api.github.com/repos/locationtech/geomesa","forks_url":"https://api.github.com/repos/locationtech/geomesa/forks","keys_url":"https://api.github.com/repos/locationtech/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locationtech/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locationtech/geomesa/teams","hooks_url":"https://api.github.com/repos/locationtech/geomesa/hooks","issue_events_url":"https://api.github.com/repos/locationtech/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/locationtech/geomesa/events","assignees_url":"https://api.github.com/repos/locationtech/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/locationtech/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/locationtech/geomesa/tags","blobs_url":"https://api.github.com/repos/locationtech/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locationtech/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locationtech/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/locationtech/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/locationtech/geomesa/languages","stargazers_url":"https://api.github.com/repos/locationtech/geomesa/stargazers","contributors_url":"https://api.github.com/repos/locationtech/geomesa/contributors","subscribers_url":"https://api.github.com/repos/locationtech/geomesa/subscribers","subscription_url":"https://api.github.com/repos/locationtech/geomesa/subscription","commits_url":"https://api.github.com/repos/locationtech/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/locationtech/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/locationtech/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/locationtech/geomesa/issues/comments{/number}","contents_url":"https://api.github.com/repos/locationtech/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/locationtech/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locationtech/geomesa/merges","archive_url":"https://api.github.com/repos/locationtech/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locationtech/geomesa/downloads","issues_url":"https://api.github.com/repos/locationtech/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/locationtech/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/locationtech/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/locationtech/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locationtech/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/locationtech/geomesa/releases{/id}","deployments_url":"https://api.github.com/repos/locationtech/geomesa/deployments","created_at":"2013-09-30T20:13:46Z","updated_at":"2018-04-30T15:38:20Z","pushed_at":"2018-04-30T13:54:13Z","git_url":"git://github.com/locationtech/geomesa.git","ssh_url":"git@github.com:locationtech/geomesa.git","clone_url":"https://github.com/locationtech/geomesa.git","svn_url":"https://github.com/locationtech/geomesa","homepage":"https://www.locationtech.org/projects/technology.geomesa","size":51232,"stargazers_count":438,"watchers_count":438,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":182,"open_issues":10,"watchers":438,"default_branch":"master"}},"base":{"label":"locationtech:master","ref":"master","sha":"a408b2ea1adee44582bdb6062326906d2391bf34","user":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars2.githubusercontent.com/u/1991411?v=4","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"repo":{"id":13226069,"name":"geomesa","full_name":"locationtech/geomesa","owner":{"login":"locationtech","id":1991411,"avatar_url":"https://avatars2.githubusercontent.com/u/1991411?v=4","gravatar_id":"","url":"https://api.github.com/users/locationtech","html_url":"https://github.com/locationtech","followers_url":"https://api.github.com/users/locationtech/followers","following_url":"https://api.github.com/users/locationtech/following{/other_user}","gists_url":"https://api.github.com/users/locationtech/gists{/gist_id}","starred_url":"https://api.github.com/users/locationtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/locationtech/subscriptions","organizations_url":"https://api.github.com/users/locationtech/orgs","repos_url":"https://api.github.com/users/locationtech/repos","events_url":"https://api.github.com/users/locationtech/events{/privacy}","received_events_url":"https://api.github.com/users/locationtech/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/locationtech/geomesa","description":"GeoMesa is a suite of tools for working with big geo-spatial data in a distributed fashion.","fork":false,"url":"https://api.github.com/repos/locationtech/geomesa","forks_url":"https://api.github.com/repos/locationtech/geomesa/forks","keys_url":"https://api.github.com/repos/locationtech/geomesa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/locationtech/geomesa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/locationtech/geomesa/teams","hooks_url":"https://api.github.com/repos/locationtech/geomesa/hooks","issue_events_url":"https://api.github.com/repos/locationtech/geomesa/issues/events{/number}","events_url":"https://api.github.com/repos/locationtech/geomesa/events","assignees_url":"https://api.github.com/repos/locationtech/geomesa/assignees{/user}","branches_url":"https://api.github.com/repos/locationtech/geomesa/branches{/branch}","tags_url":"https://api.github.com/repos/locationtech/geomesa/tags","blobs_url":"https://api.github.com/repos/locationtech/geomesa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/locationtech/geomesa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/locationtech/geomesa/git/refs{/sha}","trees_url":"https://api.github.com/repos/locationtech/geomesa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/locationtech/geomesa/statuses/{sha}","languages_url":"https://api.github.com/repos/locationtech/geomesa/languages","stargazers_url":"https://api.github.com/repos/locationtech/geomesa/stargazers","contributors_url":"https://api.github.com/repos/locationtech/geomesa/contributors","subscribers_url":"https://api.github.com/repos/locationtech/geomesa/subscribers","subscription_url":"https://api.github.com/repos/locationtech/geomesa/subscription","commits_url":"https://api.github.com/repos/locationtech/geomesa/commits{/sha}","git_commits_url":"https://api.github.com/repos/locationtech/geomesa/git/commits{/sha}","comments_url":"https://api.github.com/repos/locationtech/geomesa/comments{/number}","issue_comment_url":"https://api.github.com/repos/locationtech/geomesa/issues/comments{/number}","contents_url":"https://api.github.com/repos/locationtech/geomesa/contents/{+path}","compare_url":"https://api.github.com/repos/locationtech/geomesa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/locationtech/geomesa/merges","archive_url":"https://api.github.com/repos/locationtech/geomesa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/locationtech/geomesa/downloads","issues_url":"https://api.github.com/repos/locationtech/geomesa/issues{/number}","pulls_url":"https://api.github.com/repos/locationtech/geomesa/pulls{/number}","milestones_url":"https://api.github.com/repos/locationtech/geomesa/milestones{/number}","notifications_url":"https://api.github.com/repos/locationtech/geomesa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/locationtech/geomesa/labels{/name}","releases_url":"https://api.github.com/repos/locationtech/geomesa/releases{/id}","deployments_url":"https://api.github.com/repos/locationtech/geomesa/deployments","created_at":"2013-09-30T20:13:46Z","updated_at":"2018-04-30T15:38:20Z","pushed_at":"2018-04-30T13:54:13Z","git_url":"git://github.com/locationtech/geomesa.git","ssh_url":"git@github.com:locationtech/geomesa.git","clone_url":"https://github.com/locationtech/geomesa.git","svn_url":"https://github.com/locationtech/geomesa","homepage":"https://www.locationtech.org/projects/technology.geomesa","size":51232,"stargazers_count":438,"watchers_count":438,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":182,"open_issues":10,"watchers":438,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1922"},"html":{"href":"https://github.com/locationtech/geomesa/pull/1922"},"issue":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/1922"},"comments":{"href":"https://api.github.com/repos/locationtech/geomesa/issues/1922/comments"},"review_comments":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1922/comments"},"review_comment":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/locationtech/geomesa/pulls/1922/commits"},"statuses":{"href":"https://api.github.com/repos/locationtech/geomesa/statuses/efb8563c918980ed6101a446fbb5a7ca6b8bec9e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jahhulbert-ccri"}}