{"action":"created","issue":{"url":"https://api.github.com/repos/JLLeitschuh/ktlint-gradle/issues/183","repository_url":"https://api.github.com/repos/JLLeitschuh/ktlint-gradle","labels_url":"https://api.github.com/repos/JLLeitschuh/ktlint-gradle/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/JLLeitschuh/ktlint-gradle/issues/183/comments","events_url":"https://api.github.com/repos/JLLeitschuh/ktlint-gradle/issues/183/events","html_url":"https://github.com/JLLeitschuh/ktlint-gradle/pull/183","id":389058436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTUzMzYx","number":183,"title":"Add meta tasks for Android variants","user":{"login":"Tapchicoma","id":1595262,"node_id":"MDQ6VXNlcjE1OTUyNjI=","avatar_url":"https://avatars0.githubusercontent.com/u/1595262?v=4","gravatar_id":"","url":"https://api.github.com/users/Tapchicoma","html_url":"https://github.com/Tapchicoma","followers_url":"https://api.github.com/users/Tapchicoma/followers","following_url":"https://api.github.com/users/Tapchicoma/following{/other_user}","gists_url":"https://api.github.com/users/Tapchicoma/gists{/gist_id}","starred_url":"https://api.github.com/users/Tapchicoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tapchicoma/subscriptions","organizations_url":"https://api.github.com/users/Tapchicoma/orgs","repos_url":"https://api.github.com/users/Tapchicoma/repos","events_url":"https://api.github.com/users/Tapchicoma/events{/privacy}","received_events_url":"https://api.github.com/users/Tapchicoma/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-09T20:04:29Z","updated_at":"2018-12-10T18:31:02Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/JLLeitschuh/ktlint-gradle/pulls/183","html_url":"https://github.com/JLLeitschuh/ktlint-gradle/pull/183","diff_url":"https://github.com/JLLeitschuh/ktlint-gradle/pull/183.diff","patch_url":"https://github.com/JLLeitschuh/ktlint-gradle/pull/183.patch"},"body":"This PR adds android variants meta tasks, that trigger tasks for all source sets in given variant.\r\n\r\nFor example running `ktlintKellerbierDebugCheck` meta task triggers following tasks:\r\n```bash\r\n$ ./gradlew :samples:android-app:ktlintKellerbierDebugCheck -m\r\n\r\n:samples:android-app:ktlintDebugSourceSetCheck SKIPPED\r\n:samples:android-app:ktlintKellerbierDebugSourceSetCheck SKIPPED\r\n:samples:android-app:ktlintKellerbierSourceSetCheck SKIPPED\r\n:samples:android-app:ktlintMainSourceSetCheck SKIPPED\r\n:samples:android-app:ktlintKellerbierDebugCheck SKIPPED\r\n```\r\n\r\nAlso added limited support for android projects in new Kotlin multiplatform plugin:\r\n```bash\r\n$ ./gradlew -m :samples:kotlin-mpp-android:ktlintKellerbierDebugAndroidLibCheck\r\n\r\n:samples:kotlin-mpp-android:ktlintAndroidLibDebugSourceSetCheck SKIPPED\r\n:samples:kotlin-mpp-android:ktlintAndroidLibKellerbierDebugSourceSetCheck SKIPPED\r\n:samples:kotlin-mpp-android:ktlintAndroidLibKellerbierSourceSetCheck SKIPPED\r\n:samples:kotlin-mpp-android:ktlintAndroidLibMainSourceSetCheck SKIPPED\r\n:samples:kotlin-mpp-android:ktlintKellerbierDebugAndroidLibCheck SKIPPED\r\n```\r\n\r\nCurrently variant task name is inconsistent with source sets tasks names, but that will be addressed in #182 issue.\r\n\r\nCloses #170."},"comment":{"url":"https://api.github.com/repos/JLLeitschuh/ktlint-gradle/issues/comments/445921432","html_url":"https://github.com/JLLeitschuh/ktlint-gradle/pull/183#issuecomment-445921432","issue_url":"https://api.github.com/repos/JLLeitschuh/ktlint-gradle/issues/183","id":445921432,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTkyMTQzMg==","user":{"login":"tasomaniac","id":763339,"node_id":"MDQ6VXNlcjc2MzMzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/763339?v=4","gravatar_id":"","url":"https://api.github.com/users/tasomaniac","html_url":"https://github.com/tasomaniac","followers_url":"https://api.github.com/users/tasomaniac/followers","following_url":"https://api.github.com/users/tasomaniac/following{/other_user}","gists_url":"https://api.github.com/users/tasomaniac/gists{/gist_id}","starred_url":"https://api.github.com/users/tasomaniac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tasomaniac/subscriptions","organizations_url":"https://api.github.com/users/tasomaniac/orgs","repos_url":"https://api.github.com/users/tasomaniac/repos","events_url":"https://api.github.com/users/tasomaniac/events{/privacy}","received_events_url":"https://api.github.com/users/tasomaniac/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T18:31:02Z","updated_at":"2018-12-10T18:31:02Z","author_association":"CONTRIBUTOR","body":"I don't see any problems. It will bring back the old functionality of the tasks back.\r\n\r\nThe breaking change would be that the type of the tasks has changed together with the report file destinations. We are using that actually but I will make the necessary changes to support the new structure. I guess the `meta task` wording in the changelog already captures this. "}}
{"actor":{"display_login":"tasomaniac"}}