{"action":"created","issue":{"url":"https://api.github.com/repos/execom-eu/OOP-Test-Generator/issues/91","repository_url":"https://api.github.com/repos/execom-eu/OOP-Test-Generator","labels_url":"https://api.github.com/repos/execom-eu/OOP-Test-Generator/issues/91/labels{/name}","comments_url":"https://api.github.com/repos/execom-eu/OOP-Test-Generator/issues/91/comments","events_url":"https://api.github.com/repos/execom-eu/OOP-Test-Generator/issues/91/events","html_url":"https://github.com/execom-eu/OOP-Test-Generator/pull/91","id":302344601,"number":91,"title":"Varadski submit test","user":{"login":"Varadski","id":36164099,"avatar_url":"https://avatars0.githubusercontent.com/u/36164099?v=4","gravatar_id":"","url":"https://api.github.com/users/Varadski","html_url":"https://github.com/Varadski","followers_url":"https://api.github.com/users/Varadski/followers","following_url":"https://api.github.com/users/Varadski/following{/other_user}","gists_url":"https://api.github.com/users/Varadski/gists{/gist_id}","starred_url":"https://api.github.com/users/Varadski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Varadski/subscriptions","organizations_url":"https://api.github.com/users/Varadski/orgs","repos_url":"https://api.github.com/users/Varadski/repos","events_url":"https://api.github.com/users/Varadski/events{/privacy}","received_events_url":"https://api.github.com/users/Varadski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"Varadski","id":36164099,"avatar_url":"https://avatars0.githubusercontent.com/u/36164099?v=4","gravatar_id":"","url":"https://api.github.com/users/Varadski","html_url":"https://github.com/Varadski","followers_url":"https://api.github.com/users/Varadski/followers","following_url":"https://api.github.com/users/Varadski/following{/other_user}","gists_url":"https://api.github.com/users/Varadski/gists{/gist_id}","starred_url":"https://api.github.com/users/Varadski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Varadski/subscriptions","organizations_url":"https://api.github.com/users/Varadski/orgs","repos_url":"https://api.github.com/users/Varadski/repos","events_url":"https://api.github.com/users/Varadski/events{/privacy}","received_events_url":"https://api.github.com/users/Varadski/received_events","type":"User","site_admin":false},"assignees":[{"login":"Varadski","id":36164099,"avatar_url":"https://avatars0.githubusercontent.com/u/36164099?v=4","gravatar_id":"","url":"https://api.github.com/users/Varadski","html_url":"https://github.com/Varadski","followers_url":"https://api.github.com/users/Varadski/followers","following_url":"https://api.github.com/users/Varadski/following{/other_user}","gists_url":"https://api.github.com/users/Varadski/gists{/gist_id}","starred_url":"https://api.github.com/users/Varadski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Varadski/subscriptions","organizations_url":"https://api.github.com/users/Varadski/orgs","repos_url":"https://api.github.com/users/Varadski/repos","events_url":"https://api.github.com/users/Varadski/events{/privacy}","received_events_url":"https://api.github.com/users/Varadski/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-03-05T15:31:31Z","updated_at":"2018-03-12T10:15:24Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/execom-eu/OOP-Test-Generator/pulls/91","html_url":"https://github.com/execom-eu/OOP-Test-Generator/pull/91","diff_url":"https://github.com/execom-eu/OOP-Test-Generator/pull/91.diff","patch_url":"https://github.com/execom-eu/OOP-Test-Generator/pull/91.patch"},"body":"Removed `List<TestQuestionAnswer>` from `Answer`. Made no change in the database since this connection was never established there.\r\nIn `getSelectedAnswers()` in `TestQuestion` removed the `isSelected` filter as it is not necessary.\r\nIn `isCorrectlyAnswered()` in `TestQuestion` resolved issue #88.\r\nCreated `TestQuestionTest` and added unit test to validate `isAnsweredCorrectly` method of `TestQuestion`.\r\nAdded `answeredCorrectly` to `QuestionMother` for use in aforementioned test.\r\nAdded unit test in `TestServiceTest` to validate the new `submit` method.\r\nModified and added additional Mother classes for use in the aforementioned test.\r\nRemoved `isSelected` in `TestQuestionAnswer`. Any instance of `TestQuestionAnswer` will exist only if the answer for the specific question was selected, so this was redundant.\r\nMade a change in `db.changelog-initializeDatabaseSchema.xml` via `<changeSet>` to reflect the change of the `TestQuestionAnswer` model.\r\nAdded `submit` method to `TestService` and its implementation in `TestServiceImpl`.\r\nModified `TestQuestionMother` in `eu.execom.textgenerator.core` to exlude the use of a setter method for the now obsolete `isSelected` field of `TestQuestionAnswer`.\r\nModified `testQuestion` method in `TestQuestionMother` to use `forEach` instead of the old `for each` loop.\r\nAdded `testQuestionAnswer.setTestQuestion(testQuestion);` in `TestQuestionMother` so all testQuestionAsnwers have their testQuestion set.\r\nAdded `/submit` endpoint in `TestController` which is to be used for submitting completed tests.\r\nAdded `SubmittedTest` DTO for use with the aforementioned REST method.\r\nRemoved unnecessary Cors filter from the `MockMvcBuilders` in `TestControllerTest`.\r\nAdded a unit test for the REST method.\r\nModified and added additional Mother classes for use in the aforementioned test.\r\nRemoved unused code from `shouldGetTotalTestPoints` in `TestControllerTest` and fixed expected value.\r\nRemoved unused imports in modified classes."},"comment":{"url":"https://api.github.com/repos/execom-eu/OOP-Test-Generator/issues/comments/372258232","html_url":"https://github.com/execom-eu/OOP-Test-Generator/pull/91#issuecomment-372258232","issue_url":"https://api.github.com/repos/execom-eu/OOP-Test-Generator/issues/91","id":372258232,"user":{"login":"stanislavgrujic","id":2743162,"avatar_url":"https://avatars1.githubusercontent.com/u/2743162?v=4","gravatar_id":"","url":"https://api.github.com/users/stanislavgrujic","html_url":"https://github.com/stanislavgrujic","followers_url":"https://api.github.com/users/stanislavgrujic/followers","following_url":"https://api.github.com/users/stanislavgrujic/following{/other_user}","gists_url":"https://api.github.com/users/stanislavgrujic/gists{/gist_id}","starred_url":"https://api.github.com/users/stanislavgrujic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanislavgrujic/subscriptions","organizations_url":"https://api.github.com/users/stanislavgrujic/orgs","repos_url":"https://api.github.com/users/stanislavgrujic/repos","events_url":"https://api.github.com/users/stanislavgrujic/events{/privacy}","received_events_url":"https://api.github.com/users/stanislavgrujic/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T10:15:24Z","updated_at":"2018-03-12T10:15:24Z","author_association":"CONTRIBUTOR","body":"Please resolve merge conflicts."}}
{"actor":{"display_login":"stanislavgrujic"}}