{"action":"created","issue":{"url":"https://api.github.com/repos/batfish/batfish/issues/1395","repository_url":"https://api.github.com/repos/batfish/batfish","labels_url":"https://api.github.com/repos/batfish/batfish/issues/1395/labels{/name}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/1395/comments","events_url":"https://api.github.com/repos/batfish/batfish/issues/1395/events","html_url":"https://github.com/batfish/batfish/pull/1395","id":323105997,"number":1395,"title":"Node properties","user":{"login":"ratulm","id":4723124,"avatar_url":"https://avatars2.githubusercontent.com/u/4723124?v=4","gravatar_id":"","url":"https://api.github.com/users/ratulm","html_url":"https://github.com/ratulm","followers_url":"https://api.github.com/users/ratulm/followers","following_url":"https://api.github.com/users/ratulm/following{/other_user}","gists_url":"https://api.github.com/users/ratulm/gists{/gist_id}","starred_url":"https://api.github.com/users/ratulm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ratulm/subscriptions","organizations_url":"https://api.github.com/users/ratulm/orgs","repos_url":"https://api.github.com/users/ratulm/repos","events_url":"https://api.github.com/users/ratulm/events{/privacy}","received_events_url":"https://api.github.com/users/ratulm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-15T07:57:33Z","updated_at":"2018-05-16T17:14:36Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/1395","html_url":"https://github.com/batfish/batfish/pull/1395","diff_url":"https://github.com/batfish/batfish/pull/1395.diff","patch_url":"https://github.com/batfish/batfish/pull/1395.patch"},"body":"I'll fill out the properties and add a few more tests if this seem directionally OK. \r\n\r\non the example testrig, \"get nodeproperties\" yields:\r\n\r\n```\r\n{\r\n  \"class\" : \"org.batfish.question.nodeproperties.NodePropertiesAnswerElement\",\r\n  \"metadata\" : {\r\n    \"columnMetadata\" : [\r\n      {\r\n        \"description\" : \"Node\",\r\n        \"isKey\" : true,\r\n        \"isValue\" : false,\r\n        \"name\" : \"node\",\r\n        \"schema\" : \"Node\"\r\n      },\r\n      {\r\n        \"description\" : \"Property interfaces\",\r\n        \"isKey\" : false,\r\n        \"isValue\" : true,\r\n        \"name\" : \"interfaces\",\r\n        \"schema\" : \"List<String>\"\r\n      },\r\n      {\r\n        \"description\" : \"Property ntpServers\",\r\n        \"isKey\" : false,\r\n        \"isValue\" : true,\r\n        \"name\" : \"ntpServers\",\r\n        \"schema\" : \"List<String>\"\r\n      },\r\n      {\r\n        \"description\" : \"Property ntpSourceInterface\",\r\n        \"isKey\" : false,\r\n        \"isValue\" : true,\r\n        \"name\" : \"ntpSourceInterface\",\r\n        \"schema\" : \"Object\"\r\n      }\r\n    ],\r\n    \"displayHints\" : {\r\n      \"textDesc\" : \"Properties of node ${node}.\"\r\n    }\r\n  },\r\n  \"rows\" : [\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as3border2\",\r\n        \"name\" : \"as3border2\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [\r\n        \"18.18.18.18\",\r\n        \"23.23.23.23\"\r\n      ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-host2\",\r\n        \"name\" : \"host2\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"eth0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as3core1\",\r\n        \"name\" : \"as3core1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"GigabitEthernet3/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-host1\",\r\n        \"name\" : \"host1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"eth0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as3border1\",\r\n        \"name\" : \"as3border1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [\r\n        \"18.18.18.18\",\r\n        \"23.23.23.23\"\r\n      ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as1core1\",\r\n        \"name\" : \"as1core1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as1border2\",\r\n        \"name\" : \"as1border2\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [\r\n        \"18.18.18.18\",\r\n        \"23.23.23.23\"\r\n      ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as2border2\",\r\n        \"name\" : \"as2border2\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [\r\n        \"18.18.18.18\"\r\n      ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as2border1\",\r\n        \"name\" : \"as2border1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [\r\n        \"18.18.18.18\",\r\n        \"23.23.23.23\"\r\n      ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as2dist2\",\r\n        \"name\" : \"as2dist2\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as2core1\",\r\n        \"name\" : \"as2core1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"GigabitEthernet3/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as2core2\",\r\n        \"name\" : \"as2core2\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"GigabitEthernet3/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as1border1\",\r\n        \"name\" : \"as1border1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as2dept1\",\r\n        \"name\" : \"as2dept1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"GigabitEthernet3/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    },\r\n    {\r\n      \"node\" : {\r\n        \"id\" : \"node-as2dist1\",\r\n        \"name\" : \"as2dist1\"\r\n      },\r\n      \"interfaces\" : [\r\n        \"Ethernet0/0\",\r\n        \"GigabitEthernet0/0\",\r\n        \"GigabitEthernet1/0\",\r\n        \"GigabitEthernet2/0\",\r\n        \"Loopback0\"\r\n      ],\r\n      \"ntpServers\" : [ ],\r\n      \"ntpSourceInterface\" : null\r\n    }\r\n  ],\r\n  \"summary\" : {\r\n    \"notes\" : \"Found 15 results\",\r\n    \"numFailed\" : 0,\r\n    \"numPassed\" : 0,\r\n    \"numResults\" : 15\r\n  }\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/batfish/batfish/issues/comments/389596710","html_url":"https://github.com/batfish/batfish/pull/1395#issuecomment-389596710","issue_url":"https://api.github.com/repos/batfish/batfish/issues/1395","id":389596710,"user":{"login":"dhalperi","id":526415,"avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T17:14:36Z","updated_at":"2018-05-16T17:14:36Z","author_association":"MEMBER","body":"\n\n\n\nReviewed 1 of 25 files at r1.\nReview status: all files reviewed at latest revision, 7 unresolved discussions.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/batfish/batfish/1395)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dhalperi"}}