{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/20640","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/20640/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/20640/comments","events_url":"https://api.github.com/repos/apache/spark/issues/20640/events","html_url":"https://github.com/apache/spark/pull/20640","id":298577160,"number":20640,"title":"[SPARK-19755][Mesos] Blacklist is always active for MesosCoarseGrainedSchedulerBackend","user":{"login":"IgorBerman","id":3739735,"avatar_url":"https://avatars1.githubusercontent.com/u/3739735?v=4","gravatar_id":"","url":"https://api.github.com/users/IgorBerman","html_url":"https://github.com/IgorBerman","followers_url":"https://api.github.com/users/IgorBerman/followers","following_url":"https://api.github.com/users/IgorBerman/following{/other_user}","gists_url":"https://api.github.com/users/IgorBerman/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorBerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorBerman/subscriptions","organizations_url":"https://api.github.com/users/IgorBerman/orgs","repos_url":"https://api.github.com/users/IgorBerman/repos","events_url":"https://api.github.com/users/IgorBerman/events{/privacy}","received_events_url":"https://api.github.com/users/IgorBerman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-20T12:32:02Z","updated_at":"2018-02-20T14:47:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20640","html_url":"https://github.com/apache/spark/pull/20640","diff_url":"https://github.com/apache/spark/pull/20640.diff","patch_url":"https://github.com/apache/spark/pull/20640.patch"},"body":"## What changes were proposed in this pull request?\r\nThis is another variant of https://github.com/apache/spark/pull/17619\r\nI propose less intrusive change, which won't remove blacklisting of mesos slaves completely, but rather will give ability to control constant of max failures and to enable/disable this behavior, thus giving ability to decide in each usecase. \r\nProposed defaults will setup behavior as before to be \"backward compatible\"\r\n\r\n## How was this patch tested?\r\nCreated unit test for blacklisting of slaves\r\n\r\n@timout \r\n@squito (as reviewer of previous PR)"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/367000316","html_url":"https://github.com/apache/spark/pull/20640#issuecomment-367000316","issue_url":"https://api.github.com/repos/apache/spark/issues/20640","id":367000316,"user":{"login":"squito","id":71240,"avatar_url":"https://avatars2.githubusercontent.com/u/71240?v=4","gravatar_id":"","url":"https://api.github.com/users/squito","html_url":"https://github.com/squito","followers_url":"https://api.github.com/users/squito/followers","following_url":"https://api.github.com/users/squito/following{/other_user}","gists_url":"https://api.github.com/users/squito/gists{/gist_id}","starred_url":"https://api.github.com/users/squito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squito/subscriptions","organizations_url":"https://api.github.com/users/squito/orgs","repos_url":"https://api.github.com/users/squito/repos","events_url":"https://api.github.com/users/squito/events{/privacy}","received_events_url":"https://api.github.com/users/squito/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T14:47:46Z","updated_at":"2018-02-20T14:47:46Z","author_association":"CONTRIBUTOR","body":"@IgorBerman I actually think that https://github.com/apache/spark/pull/17619 is the right approach.  As @timout pointed out on that one, this functionality doesn't need to be covered in mesos specific code at all, as its covered by the BlacklistTracker.  I don't like introducing new configs when we don't really need them.  Other than this being less invasive, is there another advantage here?\r\n\r\nThe modifications I suggested to that PR are relatively small -- I think its fine if you want to open a PR that is the original updated with my suggestions (credit still to @timout), as I'm not sure if they're still working on it.  (my fault too as there was such a long delay for a proper review.)\r\n\r\nWhile I had some open questions, I think its a clear improvement in any case.  I just need to get a little help on mesos testing, we can ask on the dev list."}}
{"actor":{"display_login":"squito"}}