{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack/salt/issues/49705","repository_url":"https://api.github.com/repos/saltstack/salt","labels_url":"https://api.github.com/repos/saltstack/salt/issues/49705/labels{/name}","comments_url":"https://api.github.com/repos/saltstack/salt/issues/49705/comments","events_url":"https://api.github.com/repos/saltstack/salt/issues/49705/events","html_url":"https://github.com/saltstack/salt/pull/49705","id":361509747,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NDY0MjMy","number":49705,"title":"Bugfix/rework: IPv6 scope errors","user":{"login":"isbm","id":1073714,"node_id":"MDQ6VXNlcjEwNzM3MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1073714?v=4","gravatar_id":"","url":"https://api.github.com/users/isbm","html_url":"https://github.com/isbm","followers_url":"https://api.github.com/users/isbm/followers","following_url":"https://api.github.com/users/isbm/following{/other_user}","gists_url":"https://api.github.com/users/isbm/gists{/gist_id}","starred_url":"https://api.github.com/users/isbm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isbm/subscriptions","organizations_url":"https://api.github.com/users/isbm/orgs","repos_url":"https://api.github.com/users/isbm/repos","events_url":"https://api.github.com/users/isbm/events{/privacy}","received_events_url":"https://api.github.com/users/isbm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-09-18T22:36:48Z","updated_at":"2018-09-24T14:42:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/saltstack/salt/pulls/49705","html_url":"https://github.com/saltstack/salt/pull/49705","diff_url":"https://github.com/saltstack/salt/pull/49705.diff","patch_url":"https://github.com/saltstack/salt/pull/49705.patch"},"body":"### What does this PR do?\r\n\r\n- Fixes IPv6 scope issues that aren't supported in Python `ipaddress`.\r\n- Support IPv6 scope at `IPv6Address` object level.\r\n- Reworks `salt._compat` for code duplication and other issues\r\n- Fixes import of `ipaddress` across everywhere\r\n- Uses proper `ipaddress` instance for Python 3\r\n- Adds debug logging instead of just `pass`.\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n### Previous Behavior\r\n\r\nIf your `/etc/resolv.conf` has a scope in IPv6 address, something like this:\r\n\r\n`nameserver fe80::20d:b9ff:fe01:ea8%eth0`\r\n\r\n...then you are getting errors like this:\r\n```\r\n  2018-09-15 13:14:45,014 [salt.utils.dns   :1039][ERROR   ][845] \r\n  /etc/resolv.conf: u'fe80::20d:b9ff:fe01:ea8%eth0' does not\r\n  appear to be an IPv4 or IPv6 address\r\n```\r\n\r\nThis is hitting users since 2016: https://github.com/saltstack/salt/issues/37949\r\n\r\n### New Behavior\r\n\r\n:metal:  :sunglasses: :metal: \r\n\r\n### Tests written?\r\n\r\nExisting should just pass.\r\n"},"comment":{"url":"https://api.github.com/repos/saltstack/salt/issues/comments/423999418","html_url":"https://github.com/saltstack/salt/pull/49705#issuecomment-423999418","issue_url":"https://api.github.com/repos/saltstack/salt/issues/49705","id":423999418,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzk5OTQxOA==","user":{"login":"isbm","id":1073714,"node_id":"MDQ6VXNlcjEwNzM3MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1073714?v=4","gravatar_id":"","url":"https://api.github.com/users/isbm","html_url":"https://github.com/isbm","followers_url":"https://api.github.com/users/isbm/followers","following_url":"https://api.github.com/users/isbm/following{/other_user}","gists_url":"https://api.github.com/users/isbm/gists{/gist_id}","starred_url":"https://api.github.com/users/isbm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isbm/subscriptions","organizations_url":"https://api.github.com/users/isbm/orgs","repos_url":"https://api.github.com/users/isbm/repos","events_url":"https://api.github.com/users/isbm/events{/privacy}","received_events_url":"https://api.github.com/users/isbm/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T14:42:29Z","updated_at":"2018-09-24T14:42:29Z","author_association":"CONTRIBUTOR","body":"@aphor this doesn't really help, I've been there already. First, the issue is like three years old. Second, even they will fix in some upcoming versions, we still need this even on 2.7 and SUSE on 2.6 that is just simply EOL."}}
{"actor":{"display_login":"isbm"}}