{"action":"created","issue":{"url":"https://api.github.com/repos/NVIDIA/k8s-device-plugin/issues/27","repository_url":"https://api.github.com/repos/NVIDIA/k8s-device-plugin","labels_url":"https://api.github.com/repos/NVIDIA/k8s-device-plugin/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/NVIDIA/k8s-device-plugin/issues/27/comments","events_url":"https://api.github.com/repos/NVIDIA/k8s-device-plugin/issues/27/events","html_url":"https://github.com/NVIDIA/k8s-device-plugin/issues/27","id":296083031,"number":27,"title":"Is it better to change the docker runtime from nvidia to the default runC？","user":{"login":"pineking","id":72760,"avatar_url":"https://avatars1.githubusercontent.com/u/72760?v=4","gravatar_id":"","url":"https://api.github.com/users/pineking","html_url":"https://github.com/pineking","followers_url":"https://api.github.com/users/pineking/followers","following_url":"https://api.github.com/users/pineking/following{/other_user}","gists_url":"https://api.github.com/users/pineking/gists{/gist_id}","starred_url":"https://api.github.com/users/pineking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pineking/subscriptions","organizations_url":"https://api.github.com/users/pineking/orgs","repos_url":"https://api.github.com/users/pineking/repos","events_url":"https://api.github.com/users/pineking/events{/privacy}","received_events_url":"https://api.github.com/users/pineking/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-10T08:00:39Z","updated_at":"2018-02-12T02:33:45Z","closed_at":"2018-02-10T22:38:56Z","author_association":"NONE","body":"In the current settings, the nvidia runtime is set to the default docker runtime instead of the origin runC.\r\nso an issue as described in https://github.com/kubernetes/kubernetes/issues/59631 https://github.com/kubernetes/kubernetes/issues/59629\r\nAll GPUs are exposed into the container.\r\n\r\nso one way of the solution is to use env to tell nvidia-container-runtime not to expose the GPUs.\r\nanother better way:\r\n1. set the default docker runtime back to runC.\r\n2. we do not need nvidia-container-runtime to do pre-start hooks, use k8s-device-plugin to do the same jobs, such as inject GPU device.\r\n\r\nso the issue https://github.com/kubernetes/kubernetes/issues/59631 can be fixed. \r\n\r\n@flx42 @RenaudWasTaken @cmluciano @jiayingz @vikaschoudhary16"},"comment":{"url":"https://api.github.com/repos/NVIDIA/k8s-device-plugin/issues/comments/364816301","html_url":"https://github.com/NVIDIA/k8s-device-plugin/issues/27#issuecomment-364816301","issue_url":"https://api.github.com/repos/NVIDIA/k8s-device-plugin/issues/27","id":364816301,"user":{"login":"pineking","id":72760,"avatar_url":"https://avatars1.githubusercontent.com/u/72760?v=4","gravatar_id":"","url":"https://api.github.com/users/pineking","html_url":"https://github.com/pineking","followers_url":"https://api.github.com/users/pineking/followers","following_url":"https://api.github.com/users/pineking/following{/other_user}","gists_url":"https://api.github.com/users/pineking/gists{/gist_id}","starred_url":"https://api.github.com/users/pineking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pineking/subscriptions","organizations_url":"https://api.github.com/users/pineking/orgs","repos_url":"https://api.github.com/users/pineking/repos","events_url":"https://api.github.com/users/pineking/events{/privacy}","received_events_url":"https://api.github.com/users/pineking/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T02:33:45Z","updated_at":"2018-02-12T02:33:45Z","author_association":"NONE","body":">That doesn't really work as the device plugin isn't called on every container, just containers requesting at least one GPU.\r\n\r\nAs you said, it does's work to set the env via device plugin when there is no GPU request or `request == 0`. \r\nI also file a PR https://github.com/kubernetes/kubernetes/pull/59698 to solve this, make the device plugin can be called by the device manager when `limit == 0`, but the PR is closed since that's not a good solution. \r\n"}}
{"actor":{"display_login":"pineking"}}