{"action":"created","comment":{"url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments/186368581","pull_request_review_id":117930752,"id":186368581,"diff_hunk":"@@ -177,7 +177,7 @@ void DirectoryService::ComposeFinalBlockCore()\n                       blockNum, timestamp, microblockTrieRoot, stateRoot,\n                       numTxs, numMicroBlocks, m_mediator.m_selfKey.second,\n                       lastDSBlockNum, dsBlockHeader, m_viewChangeCounter),\n-        isMicroBlockEmpty, microBlockTxHashes,\n+        vector<bool>(isMicroBlockEmpty), vector<TxnHash>(microBlockTxHashes),","path":"src/libDirectoryService/FinalBlockPreProcessing.cpp","position":5,"original_position":5,"commit_id":"fa897cec20561c932791d8ec9f1b726d9a5b620e","original_commit_id":"fa897cec20561c932791d8ec9f1b726d9a5b620e","user":{"login":"Gnnng","id":3510144,"avatar_url":"https://avatars3.githubusercontent.com/u/3510144?v=4","gravatar_id":"","url":"https://api.github.com/users/Gnnng","html_url":"https://github.com/Gnnng","followers_url":"https://api.github.com/users/Gnnng/followers","following_url":"https://api.github.com/users/Gnnng/following{/other_user}","gists_url":"https://api.github.com/users/Gnnng/gists{/gist_id}","starred_url":"https://api.github.com/users/Gnnng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gnnng/subscriptions","organizations_url":"https://api.github.com/users/Gnnng/orgs","repos_url":"https://api.github.com/users/Gnnng/repos","events_url":"https://api.github.com/users/Gnnng/events{/privacy}","received_events_url":"https://api.github.com/users/Gnnng/received_events","type":"User","site_admin":false},"body":"Just found another place that could use {} initialization. ","created_at":"2018-05-07T09:09:07Z","updated_at":"2018-05-07T09:09:07Z","html_url":"https://github.com/Zilliqa/Zilliqa/pull/265#discussion_r186368581","pull_request_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/265","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments/186368581"},"html":{"href":"https://github.com/Zilliqa/Zilliqa/pull/265#discussion_r186368581"},"pull_request":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/265"}}},"pull_request":{"url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/265","id":184510229,"html_url":"https://github.com/Zilliqa/Zilliqa/pull/265","diff_url":"https://github.com/Zilliqa/Zilliqa/pull/265.diff","patch_url":"https://github.com/Zilliqa/Zilliqa/pull/265.patch","issue_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/265","number":265,"state":"open","locked":false,"title":"Feature/accounts","user":{"login":"ansnunez","id":19547037,"avatar_url":"https://avatars1.githubusercontent.com/u/19547037?v=4","gravatar_id":"","url":"https://api.github.com/users/ansnunez","html_url":"https://github.com/ansnunez","followers_url":"https://api.github.com/users/ansnunez/followers","following_url":"https://api.github.com/users/ansnunez/following{/other_user}","gists_url":"https://api.github.com/users/ansnunez/gists{/gist_id}","starred_url":"https://api.github.com/users/ansnunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansnunez/subscriptions","organizations_url":"https://api.github.com/users/ansnunez/orgs","repos_url":"https://api.github.com/users/ansnunez/repos","events_url":"https://api.github.com/users/ansnunez/events{/privacy}","received_events_url":"https://api.github.com/users/ansnunez/received_events","type":"User","site_admin":false},"body":"- Added storage root and code hash to Account class\r\n- Minor update to TxBlock\r\n- Quickly tested on test_node_simple.h and Test_Account","created_at":"2018-04-27T02:37:55Z","updated_at":"2018-05-07T09:09:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05fccc90739c2b54e75b34dcc4b58b5f916b8389","assignee":{"login":"ansnunez","id":19547037,"avatar_url":"https://avatars1.githubusercontent.com/u/19547037?v=4","gravatar_id":"","url":"https://api.github.com/users/ansnunez","html_url":"https://github.com/ansnunez","followers_url":"https://api.github.com/users/ansnunez/followers","following_url":"https://api.github.com/users/ansnunez/following{/other_user}","gists_url":"https://api.github.com/users/ansnunez/gists{/gist_id}","starred_url":"https://api.github.com/users/ansnunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansnunez/subscriptions","organizations_url":"https://api.github.com/users/ansnunez/orgs","repos_url":"https://api.github.com/users/ansnunez/repos","events_url":"https://api.github.com/users/ansnunez/events{/privacy}","received_events_url":"https://api.github.com/users/ansnunez/received_events","type":"User","site_admin":false},"assignees":[{"login":"ansnunez","id":19547037,"avatar_url":"https://avatars1.githubusercontent.com/u/19547037?v=4","gravatar_id":"","url":"https://api.github.com/users/ansnunez","html_url":"https://github.com/ansnunez","followers_url":"https://api.github.com/users/ansnunez/followers","following_url":"https://api.github.com/users/ansnunez/following{/other_user}","gists_url":"https://api.github.com/users/ansnunez/gists{/gist_id}","starred_url":"https://api.github.com/users/ansnunez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansnunez/subscriptions","organizations_url":"https://api.github.com/users/ansnunez/orgs","repos_url":"https://api.github.com/users/ansnunez/repos","events_url":"https://api.github.com/users/ansnunez/events{/privacy}","received_events_url":"https://api.github.com/users/ansnunez/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jiayaoqijia","id":1453879,"avatar_url":"https://avatars3.githubusercontent.com/u/1453879?v=4","gravatar_id":"","url":"https://api.github.com/users/jiayaoqijia","html_url":"https://github.com/jiayaoqijia","followers_url":"https://api.github.com/users/jiayaoqijia/followers","following_url":"https://api.github.com/users/jiayaoqijia/following{/other_user}","gists_url":"https://api.github.com/users/jiayaoqijia/gists{/gist_id}","starred_url":"https://api.github.com/users/jiayaoqijia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiayaoqijia/subscriptions","organizations_url":"https://api.github.com/users/jiayaoqijia/orgs","repos_url":"https://api.github.com/users/jiayaoqijia/repos","events_url":"https://api.github.com/users/jiayaoqijia/events{/privacy}","received_events_url":"https://api.github.com/users/jiayaoqijia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/265/commits","review_comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/265/comments","review_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/265/comments","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/fa897cec20561c932791d8ec9f1b726d9a5b620e","head":{"label":"Zilliqa:feature/accounts","ref":"feature/accounts","sha":"fa897cec20561c932791d8ec9f1b726d9a5b620e","user":{"login":"Zilliqa","id":32560879,"avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"name":"Zilliqa","full_name":"Zilliqa/Zilliqa","owner":{"login":"Zilliqa","id":32560879,"avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-05-07T06:41:48Z","pushed_at":"2018-05-07T09:06:49Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":12891,"stargazers_count":360,"watchers_count":360,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":77,"open_issues":41,"watchers":360,"default_branch":"master"}},"base":{"label":"Zilliqa:master","ref":"master","sha":"260f4f4b551a6afa4b9888117328223d4fc04262","user":{"login":"Zilliqa","id":32560879,"avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"repo":{"id":115495630,"name":"Zilliqa","full_name":"Zilliqa/Zilliqa","owner":{"login":"Zilliqa","id":32560879,"avatar_url":"https://avatars1.githubusercontent.com/u/32560879?v=4","gravatar_id":"","url":"https://api.github.com/users/Zilliqa","html_url":"https://github.com/Zilliqa","followers_url":"https://api.github.com/users/Zilliqa/followers","following_url":"https://api.github.com/users/Zilliqa/following{/other_user}","gists_url":"https://api.github.com/users/Zilliqa/gists{/gist_id}","starred_url":"https://api.github.com/users/Zilliqa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zilliqa/subscriptions","organizations_url":"https://api.github.com/users/Zilliqa/orgs","repos_url":"https://api.github.com/users/Zilliqa/repos","events_url":"https://api.github.com/users/Zilliqa/events{/privacy}","received_events_url":"https://api.github.com/users/Zilliqa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Zilliqa/Zilliqa","description":"Zilliqa is the world's first high-throughput public blockchain platform - designed to scale to thousands ​of transactions per second.","fork":false,"url":"https://api.github.com/repos/Zilliqa/Zilliqa","forks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/forks","keys_url":"https://api.github.com/repos/Zilliqa/Zilliqa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zilliqa/Zilliqa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zilliqa/Zilliqa/teams","hooks_url":"https://api.github.com/repos/Zilliqa/Zilliqa/hooks","issue_events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/events{/number}","events_url":"https://api.github.com/repos/Zilliqa/Zilliqa/events","assignees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/assignees{/user}","branches_url":"https://api.github.com/repos/Zilliqa/Zilliqa/branches{/branch}","tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/tags","blobs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/{sha}","languages_url":"https://api.github.com/repos/Zilliqa/Zilliqa/languages","stargazers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/stargazers","contributors_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contributors","subscribers_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscribers","subscription_url":"https://api.github.com/repos/Zilliqa/Zilliqa/subscription","commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zilliqa/Zilliqa/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zilliqa/Zilliqa/contents/{+path}","compare_url":"https://api.github.com/repos/Zilliqa/Zilliqa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zilliqa/Zilliqa/merges","archive_url":"https://api.github.com/repos/Zilliqa/Zilliqa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zilliqa/Zilliqa/downloads","issues_url":"https://api.github.com/repos/Zilliqa/Zilliqa/issues{/number}","pulls_url":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls{/number}","milestones_url":"https://api.github.com/repos/Zilliqa/Zilliqa/milestones{/number}","notifications_url":"https://api.github.com/repos/Zilliqa/Zilliqa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zilliqa/Zilliqa/labels{/name}","releases_url":"https://api.github.com/repos/Zilliqa/Zilliqa/releases{/id}","deployments_url":"https://api.github.com/repos/Zilliqa/Zilliqa/deployments","created_at":"2017-12-27T07:42:33Z","updated_at":"2018-05-07T06:41:48Z","pushed_at":"2018-05-07T09:06:49Z","git_url":"git://github.com/Zilliqa/Zilliqa.git","ssh_url":"git@github.com:Zilliqa/Zilliqa.git","clone_url":"https://github.com/Zilliqa/Zilliqa.git","svn_url":"https://github.com/Zilliqa/Zilliqa","homepage":"https://www.zilliqa.com","size":12891,"stargazers_count":360,"watchers_count":360,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":77,"open_issues":41,"watchers":360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/265"},"html":{"href":"https://github.com/Zilliqa/Zilliqa/pull/265"},"issue":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/265"},"comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/issues/265/comments"},"review_comments":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/265/comments"},"review_comment":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/pulls/265/commits"},"statuses":{"href":"https://api.github.com/repos/Zilliqa/Zilliqa/statuses/fa897cec20561c932791d8ec9f1b726d9a5b620e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Gnnng"}}