{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls/3","id":211957105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTU3MTA1","html_url":"https://github.com/josephfriesen/holdem-poker/pull/3","diff_url":"https://github.com/josephfriesen/holdem-poker/pull/3.diff","patch_url":"https://github.com/josephfriesen/holdem-poker/pull/3.patch","issue_url":"https://api.github.com/repos/josephfriesen/holdem-poker/issues/3","number":3,"state":"open","locked":false,"title":"Poker rules","user":{"login":"josephfriesen","id":41608043,"node_id":"MDQ6VXNlcjQxNjA4MDQz","avatar_url":"https://avatars3.githubusercontent.com/u/41608043?v=4","gravatar_id":"","url":"https://api.github.com/users/josephfriesen","html_url":"https://github.com/josephfriesen","followers_url":"https://api.github.com/users/josephfriesen/followers","following_url":"https://api.github.com/users/josephfriesen/following{/other_user}","gists_url":"https://api.github.com/users/josephfriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/josephfriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephfriesen/subscriptions","organizations_url":"https://api.github.com/users/josephfriesen/orgs","repos_url":"https://api.github.com/users/josephfriesen/repos","events_url":"https://api.github.com/users/josephfriesen/events{/privacy}","received_events_url":"https://api.github.com/users/josephfriesen/received_events","type":"User","site_admin":false},"body":"So here's all I did tonight at home.\r\n\r\n1) Fixed the few handEvaluators arrange functions that weren't sorting the hands properly. I think there is likely still an issue in handEvaluators.twoPair but I couldn't figure it out: given the hand [jack,jack,ace,ace,four], it did the thing we were seeing earlier, putting a card in its own array, and the resulting card array looks like [jack, jack, ace, ace, [four]].\r\n\r\n2) Wrote the breakTie functions. They are largely untested, but they are straightforward and if they don't work it is likely a simple typo somewhere.\r\n\r\n3) Started the findBestHand and findWiinner functions. The last issue left undone is, I'm not sure, given two hands with a shared handValue key-value, how do we pick out the correct breakTie function to run? Example: hand1 and hand2 are both two pair, so we need to call handEvaluators.twoPair.breakTie(hand1, hand2), but how do we pick that specific function out?\r\n\r\nI'd love to keep at it, fix these issues then hit the ground  running tomorrow but I'm nearly falling asleep on the couch. Oh well.","created_at":"2018-08-30T05:09:44Z","updated_at":"2018-08-30T05:09:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls/3/commits","review_comments_url":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls/3/comments","review_comment_url":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/josephfriesen/holdem-poker/issues/3/comments","statuses_url":"https://api.github.com/repos/josephfriesen/holdem-poker/statuses/47c025d5cb74c6cadca3a37cfce78ae546572e1d","head":{"label":"josephfriesen:poker-rules","ref":"poker-rules","sha":"47c025d5cb74c6cadca3a37cfce78ae546572e1d","user":{"login":"josephfriesen","id":41608043,"node_id":"MDQ6VXNlcjQxNjA4MDQz","avatar_url":"https://avatars3.githubusercontent.com/u/41608043?v=4","gravatar_id":"","url":"https://api.github.com/users/josephfriesen","html_url":"https://github.com/josephfriesen","followers_url":"https://api.github.com/users/josephfriesen/followers","following_url":"https://api.github.com/users/josephfriesen/following{/other_user}","gists_url":"https://api.github.com/users/josephfriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/josephfriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephfriesen/subscriptions","organizations_url":"https://api.github.com/users/josephfriesen/orgs","repos_url":"https://api.github.com/users/josephfriesen/repos","events_url":"https://api.github.com/users/josephfriesen/events{/privacy}","received_events_url":"https://api.github.com/users/josephfriesen/received_events","type":"User","site_admin":false},"repo":{"id":146324265,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzMjQyNjU=","name":"holdem-poker","full_name":"josephfriesen/holdem-poker","owner":{"login":"josephfriesen","id":41608043,"node_id":"MDQ6VXNlcjQxNjA4MDQz","avatar_url":"https://avatars3.githubusercontent.com/u/41608043?v=4","gravatar_id":"","url":"https://api.github.com/users/josephfriesen","html_url":"https://github.com/josephfriesen","followers_url":"https://api.github.com/users/josephfriesen/followers","following_url":"https://api.github.com/users/josephfriesen/following{/other_user}","gists_url":"https://api.github.com/users/josephfriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/josephfriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephfriesen/subscriptions","organizations_url":"https://api.github.com/users/josephfriesen/orgs","repos_url":"https://api.github.com/users/josephfriesen/repos","events_url":"https://api.github.com/users/josephfriesen/events{/privacy}","received_events_url":"https://api.github.com/users/josephfriesen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josephfriesen/holdem-poker","description":"Epicodus 8/27/2018 Intro Team Week Project: In-browser Texas Hold'em Poker game.","fork":false,"url":"https://api.github.com/repos/josephfriesen/holdem-poker","forks_url":"https://api.github.com/repos/josephfriesen/holdem-poker/forks","keys_url":"https://api.github.com/repos/josephfriesen/holdem-poker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephfriesen/holdem-poker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephfriesen/holdem-poker/teams","hooks_url":"https://api.github.com/repos/josephfriesen/holdem-poker/hooks","issue_events_url":"https://api.github.com/repos/josephfriesen/holdem-poker/issues/events{/number}","events_url":"https://api.github.com/repos/josephfriesen/holdem-poker/events","assignees_url":"https://api.github.com/repos/josephfriesen/holdem-poker/assignees{/user}","branches_url":"https://api.github.com/repos/josephfriesen/holdem-poker/branches{/branch}","tags_url":"https://api.github.com/repos/josephfriesen/holdem-poker/tags","blobs_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephfriesen/holdem-poker/statuses/{sha}","languages_url":"https://api.github.com/repos/josephfriesen/holdem-poker/languages","stargazers_url":"https://api.github.com/repos/josephfriesen/holdem-poker/stargazers","contributors_url":"https://api.github.com/repos/josephfriesen/holdem-poker/contributors","subscribers_url":"https://api.github.com/repos/josephfriesen/holdem-poker/subscribers","subscription_url":"https://api.github.com/repos/josephfriesen/holdem-poker/subscription","commits_url":"https://api.github.com/repos/josephfriesen/holdem-poker/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephfriesen/holdem-poker/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephfriesen/holdem-poker/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephfriesen/holdem-poker/contents/{+path}","compare_url":"https://api.github.com/repos/josephfriesen/holdem-poker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephfriesen/holdem-poker/merges","archive_url":"https://api.github.com/repos/josephfriesen/holdem-poker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephfriesen/holdem-poker/downloads","issues_url":"https://api.github.com/repos/josephfriesen/holdem-poker/issues{/number}","pulls_url":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls{/number}","milestones_url":"https://api.github.com/repos/josephfriesen/holdem-poker/milestones{/number}","notifications_url":"https://api.github.com/repos/josephfriesen/holdem-poker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephfriesen/holdem-poker/labels{/name}","releases_url":"https://api.github.com/repos/josephfriesen/holdem-poker/releases{/id}","deployments_url":"https://api.github.com/repos/josephfriesen/holdem-poker/deployments","created_at":"2018-08-27T16:27:03Z","updated_at":"2018-08-30T02:07:42Z","pushed_at":"2018-08-30T04:59:09Z","git_url":"git://github.com/josephfriesen/holdem-poker.git","ssh_url":"git@github.com:josephfriesen/holdem-poker.git","clone_url":"https://github.com/josephfriesen/holdem-poker.git","svn_url":"https://github.com/josephfriesen/holdem-poker","homepage":null,"size":3778,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"josephfriesen:master","ref":"master","sha":"20b817130c309370b22077dfe939a32ef052080c","user":{"login":"josephfriesen","id":41608043,"node_id":"MDQ6VXNlcjQxNjA4MDQz","avatar_url":"https://avatars3.githubusercontent.com/u/41608043?v=4","gravatar_id":"","url":"https://api.github.com/users/josephfriesen","html_url":"https://github.com/josephfriesen","followers_url":"https://api.github.com/users/josephfriesen/followers","following_url":"https://api.github.com/users/josephfriesen/following{/other_user}","gists_url":"https://api.github.com/users/josephfriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/josephfriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephfriesen/subscriptions","organizations_url":"https://api.github.com/users/josephfriesen/orgs","repos_url":"https://api.github.com/users/josephfriesen/repos","events_url":"https://api.github.com/users/josephfriesen/events{/privacy}","received_events_url":"https://api.github.com/users/josephfriesen/received_events","type":"User","site_admin":false},"repo":{"id":146324265,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYzMjQyNjU=","name":"holdem-poker","full_name":"josephfriesen/holdem-poker","owner":{"login":"josephfriesen","id":41608043,"node_id":"MDQ6VXNlcjQxNjA4MDQz","avatar_url":"https://avatars3.githubusercontent.com/u/41608043?v=4","gravatar_id":"","url":"https://api.github.com/users/josephfriesen","html_url":"https://github.com/josephfriesen","followers_url":"https://api.github.com/users/josephfriesen/followers","following_url":"https://api.github.com/users/josephfriesen/following{/other_user}","gists_url":"https://api.github.com/users/josephfriesen/gists{/gist_id}","starred_url":"https://api.github.com/users/josephfriesen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephfriesen/subscriptions","organizations_url":"https://api.github.com/users/josephfriesen/orgs","repos_url":"https://api.github.com/users/josephfriesen/repos","events_url":"https://api.github.com/users/josephfriesen/events{/privacy}","received_events_url":"https://api.github.com/users/josephfriesen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josephfriesen/holdem-poker","description":"Epicodus 8/27/2018 Intro Team Week Project: In-browser Texas Hold'em Poker game.","fork":false,"url":"https://api.github.com/repos/josephfriesen/holdem-poker","forks_url":"https://api.github.com/repos/josephfriesen/holdem-poker/forks","keys_url":"https://api.github.com/repos/josephfriesen/holdem-poker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephfriesen/holdem-poker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephfriesen/holdem-poker/teams","hooks_url":"https://api.github.com/repos/josephfriesen/holdem-poker/hooks","issue_events_url":"https://api.github.com/repos/josephfriesen/holdem-poker/issues/events{/number}","events_url":"https://api.github.com/repos/josephfriesen/holdem-poker/events","assignees_url":"https://api.github.com/repos/josephfriesen/holdem-poker/assignees{/user}","branches_url":"https://api.github.com/repos/josephfriesen/holdem-poker/branches{/branch}","tags_url":"https://api.github.com/repos/josephfriesen/holdem-poker/tags","blobs_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephfriesen/holdem-poker/statuses/{sha}","languages_url":"https://api.github.com/repos/josephfriesen/holdem-poker/languages","stargazers_url":"https://api.github.com/repos/josephfriesen/holdem-poker/stargazers","contributors_url":"https://api.github.com/repos/josephfriesen/holdem-poker/contributors","subscribers_url":"https://api.github.com/repos/josephfriesen/holdem-poker/subscribers","subscription_url":"https://api.github.com/repos/josephfriesen/holdem-poker/subscription","commits_url":"https://api.github.com/repos/josephfriesen/holdem-poker/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephfriesen/holdem-poker/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephfriesen/holdem-poker/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephfriesen/holdem-poker/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephfriesen/holdem-poker/contents/{+path}","compare_url":"https://api.github.com/repos/josephfriesen/holdem-poker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephfriesen/holdem-poker/merges","archive_url":"https://api.github.com/repos/josephfriesen/holdem-poker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephfriesen/holdem-poker/downloads","issues_url":"https://api.github.com/repos/josephfriesen/holdem-poker/issues{/number}","pulls_url":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls{/number}","milestones_url":"https://api.github.com/repos/josephfriesen/holdem-poker/milestones{/number}","notifications_url":"https://api.github.com/repos/josephfriesen/holdem-poker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephfriesen/holdem-poker/labels{/name}","releases_url":"https://api.github.com/repos/josephfriesen/holdem-poker/releases{/id}","deployments_url":"https://api.github.com/repos/josephfriesen/holdem-poker/deployments","created_at":"2018-08-27T16:27:03Z","updated_at":"2018-08-30T02:07:42Z","pushed_at":"2018-08-30T04:59:09Z","git_url":"git://github.com/josephfriesen/holdem-poker.git","ssh_url":"git@github.com:josephfriesen/holdem-poker.git","clone_url":"https://github.com/josephfriesen/holdem-poker.git","svn_url":"https://github.com/josephfriesen/holdem-poker","homepage":null,"size":3778,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls/3"},"html":{"href":"https://github.com/josephfriesen/holdem-poker/pull/3"},"issue":{"href":"https://api.github.com/repos/josephfriesen/holdem-poker/issues/3"},"comments":{"href":"https://api.github.com/repos/josephfriesen/holdem-poker/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/josephfriesen/holdem-poker/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/josephfriesen/holdem-poker/statuses/47c025d5cb74c6cadca3a37cfce78ae546572e1d"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":362,"deletions":317,"changed_files":1}}
{"actor":{"display_login":"josephfriesen"}}