{"action":"created","issue":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/3858","repository_url":"https://api.github.com/repos/musescore/MuseScore","labels_url":"https://api.github.com/repos/musescore/MuseScore/issues/3858/labels{/name}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/3858/comments","events_url":"https://api.github.com/repos/musescore/MuseScore/issues/3858/events","html_url":"https://github.com/musescore/MuseScore/pull/3858","id":348750522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDI2NzI2","number":3858,"title":"Fix MSVC warnings","user":{"login":"Jojo-Schmitz","id":1786669,"node_id":"MDQ6VXNlcjE3ODY2Njk=","avatar_url":"https://avatars3.githubusercontent.com/u/1786669?v=4","gravatar_id":"","url":"https://api.github.com/users/Jojo-Schmitz","html_url":"https://github.com/Jojo-Schmitz","followers_url":"https://api.github.com/users/Jojo-Schmitz/followers","following_url":"https://api.github.com/users/Jojo-Schmitz/following{/other_user}","gists_url":"https://api.github.com/users/Jojo-Schmitz/gists{/gist_id}","starred_url":"https://api.github.com/users/Jojo-Schmitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jojo-Schmitz/subscriptions","organizations_url":"https://api.github.com/users/Jojo-Schmitz/orgs","repos_url":"https://api.github.com/users/Jojo-Schmitz/repos","events_url":"https://api.github.com/users/Jojo-Schmitz/events{/privacy}","received_events_url":"https://api.github.com/users/Jojo-Schmitz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-08T14:26:31Z","updated_at":"2018-08-11T08:15:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/3858","html_url":"https://github.com/musescore/MuseScore/pull/3858","diff_url":"https://github.com/musescore/MuseScore/pull/3858.diff","patch_url":"https://github.com/musescore/MuseScore/pull/3858.patch"},"body":"Fixes:\r\n\r\n* Warnings C4304, C4804 and C4838.\r\n* Warnings C4065 and most C4702 (all but two, see below).\r\n* Warnings C4701.\r\n* Issue with lrelease failing when path to repo is longer apparently resulting in a command line to long for MSVC to handle.\r\n* Warnings C4244.\r\n* Speed up MSVC builds by using all CPUs. Saves some 4 minutes out of some 18 on AppVeyor, so should help getting 4 builds done per hour rather than 3. Helps even more with local builds, for me a 50% boost.\r\n* Warnings C4457.\r\n* Warnings C4459.\r\n\r\nLeaves us with: \r\n\r\n* Those four C4702 warnings (unreachable code), two each in `libmscore/instrtemplate.cpp` (lines [341](https://github.com/musescore/MuseScore/blob/0e7cd231f360aac342514b1563a978dfd3d16e05/libmscore/instrtemplate.cpp#L341) and [350](https://github.com/musescore/MuseScore/blob/0e7cd231f360aac342514b1563a978dfd3d16e05/libmscore/instrtemplate.cpp#L350), (edit: both understood and fixed now) and `mscore/importgtp-gp4.cpp` (lines [1023](https://github.com/musescore/MuseScore/blob/0e7cd231f360aac342514b1563a978dfd3d16e05/mscore/importgtp-gp4.cpp#L1023) and [1082](https://github.com/musescore/MuseScore/blob/0e7cd231f360aac342514b1563a978dfd3d16e05/mscore/importgtp-gp4.cpp#L1082)), which I don't understand at all. Those do not show on the AppVeyor builds, might be due to me using a slightly different MSVC?\r\n* A whole bunch (425!) of C4456 and C4458 warnings (variables shadowing others, either local or class members)."},"comment":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/comments/412259904","html_url":"https://github.com/musescore/MuseScore/pull/3858#issuecomment-412259904","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/3858","id":412259904,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjI1OTkwNA==","user":{"login":"19joho66","id":15361970,"node_id":"MDQ6VXNlcjE1MzYxOTcw","avatar_url":"https://avatars1.githubusercontent.com/u/15361970?v=4","gravatar_id":"","url":"https://api.github.com/users/19joho66","html_url":"https://github.com/19joho66","followers_url":"https://api.github.com/users/19joho66/followers","following_url":"https://api.github.com/users/19joho66/following{/other_user}","gists_url":"https://api.github.com/users/19joho66/gists{/gist_id}","starred_url":"https://api.github.com/users/19joho66/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/19joho66/subscriptions","organizations_url":"https://api.github.com/users/19joho66/orgs","repos_url":"https://api.github.com/users/19joho66/repos","events_url":"https://api.github.com/users/19joho66/events{/privacy}","received_events_url":"https://api.github.com/users/19joho66/received_events","type":"User","site_admin":false},"created_at":"2018-08-11T08:15:52Z","updated_at":"2018-08-11T08:15:52Z","author_association":"CONTRIBUTOR","body":"concerning:  mscore/importgtp-gp4.cpp (lines 1023 and 1082)\r\n\r\nIf I counted the braced correctly I think the for loop is left prematurely due to the break direktly after the If clause"}}
{"actor":{"display_login":"19joho66"}}