{"action":"created","issue":{"url":"https://api.github.com/repos/quantnetwork/overledger-sdk-javascript/issues/20","repository_url":"https://api.github.com/repos/quantnetwork/overledger-sdk-javascript","labels_url":"https://api.github.com/repos/quantnetwork/overledger-sdk-javascript/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/quantnetwork/overledger-sdk-javascript/issues/20/comments","events_url":"https://api.github.com/repos/quantnetwork/overledger-sdk-javascript/issues/20/events","html_url":"https://github.com/quantnetwork/overledger-sdk-javascript/issues/20","id":390325234,"node_id":"MDU6SXNzdWUzOTAzMjUyMzQ=","number":20,"title":"readTransactionsByMappId/readByTransactionId  giving server error","user":{"login":"anshuman-singh-93","id":8060767,"node_id":"MDQ6VXNlcjgwNjA3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/8060767?v=4","gravatar_id":"","url":"https://api.github.com/users/anshuman-singh-93","html_url":"https://github.com/anshuman-singh-93","followers_url":"https://api.github.com/users/anshuman-singh-93/followers","following_url":"https://api.github.com/users/anshuman-singh-93/following{/other_user}","gists_url":"https://api.github.com/users/anshuman-singh-93/gists{/gist_id}","starred_url":"https://api.github.com/users/anshuman-singh-93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anshuman-singh-93/subscriptions","organizations_url":"https://api.github.com/users/anshuman-singh-93/orgs","repos_url":"https://api.github.com/users/anshuman-singh-93/repos","events_url":"https://api.github.com/users/anshuman-singh-93/events{/privacy}","received_events_url":"https://api.github.com/users/anshuman-singh-93/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-12T17:14:01Z","updated_at":"2018-12-21T14:35:31Z","closed_at":"2018-12-21T14:35:31Z","author_association":"NONE","body":"readTransactionsByMappId/readByTransactionId method returns error with status code 500 but the error is silently dropped and appear as success because this method is wrapped inside try/catch. end user will never know if there was any error while calling this method\r\n\r\nsnippet-\r\n\r\n    public async readByTransactionId(ovlTransactionId: string): Promise<Object> \r\n    {\r\n      try {\r\n        const response = await this.request.get(${this.overledgerUri}/transactions/${ovlTransactionId});\r\n        return response.data;\r\n      } catch (e) {\r\n        return e.response.data;\r\n    }}\r\n\r\nshouln't it be like this so that user can know if there was any error\r\n\r\n     public async readByTransactionId(ovlTransactionId: string): Promise<Object>\r\n     {\r\n       return await this.request.get(${this.overledgerUri}/transactions/${ovlTransactionId});\r\n     }"},"comment":{"url":"https://api.github.com/repos/quantnetwork/overledger-sdk-javascript/issues/comments/449404015","html_url":"https://github.com/quantnetwork/overledger-sdk-javascript/issues/20#issuecomment-449404015","issue_url":"https://api.github.com/repos/quantnetwork/overledger-sdk-javascript/issues/20","id":449404015,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQwNDAxNQ==","user":{"login":"oktapodia","id":2752200,"node_id":"MDQ6VXNlcjI3NTIyMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/2752200?v=4","gravatar_id":"","url":"https://api.github.com/users/oktapodia","html_url":"https://github.com/oktapodia","followers_url":"https://api.github.com/users/oktapodia/followers","following_url":"https://api.github.com/users/oktapodia/following{/other_user}","gists_url":"https://api.github.com/users/oktapodia/gists{/gist_id}","starred_url":"https://api.github.com/users/oktapodia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oktapodia/subscriptions","organizations_url":"https://api.github.com/users/oktapodia/orgs","repos_url":"https://api.github.com/users/oktapodia/repos","events_url":"https://api.github.com/users/oktapodia/events{/privacy}","received_events_url":"https://api.github.com/users/oktapodia/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T14:35:31Z","updated_at":"2018-12-21T14:35:31Z","author_association":"MEMBER","body":"It has been deployed with the v1.0.0-alpha.7 version"}}
{"actor":{"display_login":"oktapodia"}}