{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/recipes/pulls/comments/244573172","pull_request_review_id":188482546,"id":244573172,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU3MzE3Mg==","diff_hunk":"@@ -13,19 +14,19 @@ class Kernel extends BaseKernel\n {\n     use MicroKernelTrait;\n \n-    const CONFIG_EXTS = '.{php,xml,yaml,yml}';\n+    private const CONFIG_EXTS = '.{php,xml,yaml,yml}';\n \n-    public function getCacheDir()\n+    public function getCacheDir(): string\n     {\n         return $this->getProjectDir().'/var/cache/'.$this->environment;\n     }\n \n-    public function getLogDir()\n+    public function getLogDir(): string\n     {\n         return $this->getProjectDir().'/var/log';\n     }\n \n-    public function registerBundles()\n+    public function registerBundles(): Generator","path":"symfony/framework-bundle/4.2/src/Kernel.php","position":30,"original_position":30,"commit_id":"8d42000bb9cb29dd45706da961d383f5c0878cb2","original_commit_id":"8d42000bb9cb29dd45706da961d383f5c0878cb2","user":{"login":"xabbuh","id":1957048,"node_id":"MDQ6VXNlcjE5NTcwNDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1957048?v=4","gravatar_id":"","url":"https://api.github.com/users/xabbuh","html_url":"https://github.com/xabbuh","followers_url":"https://api.github.com/users/xabbuh/followers","following_url":"https://api.github.com/users/xabbuh/following{/other_user}","gists_url":"https://api.github.com/users/xabbuh/gists{/gist_id}","starred_url":"https://api.github.com/users/xabbuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xabbuh/subscriptions","organizations_url":"https://api.github.com/users/xabbuh/orgs","repos_url":"https://api.github.com/users/xabbuh/repos","events_url":"https://api.github.com/users/xabbuh/events{/privacy}","received_events_url":"https://api.github.com/users/xabbuh/received_events","type":"User","site_admin":false},"body":"should be `\\Generator` to comply with Symfony's code style","created_at":"2018-12-31T10:40:44Z","updated_at":"2018-12-31T10:40:44Z","html_url":"https://github.com/symfony/recipes/pull/507#discussion_r244573172","pull_request_url":"https://api.github.com/repos/symfony/recipes/pulls/507","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/recipes/pulls/comments/244573172"},"html":{"href":"https://github.com/symfony/recipes/pull/507#discussion_r244573172"},"pull_request":{"href":"https://api.github.com/repos/symfony/recipes/pulls/507"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/recipes/pulls/507","id":240625217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjI1MjE3","html_url":"https://github.com/symfony/recipes/pull/507","diff_url":"https://github.com/symfony/recipes/pull/507.diff","patch_url":"https://github.com/symfony/recipes/pull/507.patch","issue_url":"https://api.github.com/repos/symfony/recipes/issues/507","number":507,"state":"open","locked":false,"title":"symfony/framework-bundle 4.2 can use PHP 7.1 features","user":{"login":"mhujer","id":353372,"node_id":"MDQ6VXNlcjM1MzM3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/353372?v=4","gravatar_id":"","url":"https://api.github.com/users/mhujer","html_url":"https://github.com/mhujer","followers_url":"https://api.github.com/users/mhujer/followers","following_url":"https://api.github.com/users/mhujer/following{/other_user}","gists_url":"https://api.github.com/users/mhujer/gists{/gist_id}","starred_url":"https://api.github.com/users/mhujer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhujer/subscriptions","organizations_url":"https://api.github.com/users/mhujer/orgs","repos_url":"https://api.github.com/users/mhujer/repos","events_url":"https://api.github.com/users/mhujer/events{/privacy}","received_events_url":"https://api.github.com/users/mhujer/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| License       | MIT\r\n\r\n<!--\r\nPlease, carefully read the README before submitting a pull request.\r\n-->\r\n\r\nSymfony 4 requires PHP 7.1 so I think that the recipe can use features from 7.1. Otherwise I was doing those changes manually when creating a new SF project.\r\n\r\nWhat do you think?","created_at":"2018-12-22T09:12:16Z","updated_at":"2018-12-31T10:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f91a7ee84b0bf37eb0956b5b7d5b960f17a7c439","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/recipes/pulls/507/commits","review_comments_url":"https://api.github.com/repos/symfony/recipes/pulls/507/comments","review_comment_url":"https://api.github.com/repos/symfony/recipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/recipes/issues/507/comments","statuses_url":"https://api.github.com/repos/symfony/recipes/statuses/8d42000bb9cb29dd45706da961d383f5c0878cb2","head":{"label":"mhujer:framework-bundle-4.2","ref":"framework-bundle-4.2","sha":"8d42000bb9cb29dd45706da961d383f5c0878cb2","user":{"login":"mhujer","id":353372,"node_id":"MDQ6VXNlcjM1MzM3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/353372?v=4","gravatar_id":"","url":"https://api.github.com/users/mhujer","html_url":"https://github.com/mhujer","followers_url":"https://api.github.com/users/mhujer/followers","following_url":"https://api.github.com/users/mhujer/following{/other_user}","gists_url":"https://api.github.com/users/mhujer/gists{/gist_id}","starred_url":"https://api.github.com/users/mhujer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhujer/subscriptions","organizations_url":"https://api.github.com/users/mhujer/orgs","repos_url":"https://api.github.com/users/mhujer/repos","events_url":"https://api.github.com/users/mhujer/events{/privacy}","received_events_url":"https://api.github.com/users/mhujer/received_events","type":"User","site_admin":false},"repo":{"id":162796879,"node_id":"MDEwOlJlcG9zaXRvcnkxNjI3OTY4Nzk=","name":"recipes","full_name":"mhujer/recipes","private":false,"owner":{"login":"mhujer","id":353372,"node_id":"MDQ6VXNlcjM1MzM3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/353372?v=4","gravatar_id":"","url":"https://api.github.com/users/mhujer","html_url":"https://github.com/mhujer","followers_url":"https://api.github.com/users/mhujer/followers","following_url":"https://api.github.com/users/mhujer/following{/other_user}","gists_url":"https://api.github.com/users/mhujer/gists{/gist_id}","starred_url":"https://api.github.com/users/mhujer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhujer/subscriptions","organizations_url":"https://api.github.com/users/mhujer/orgs","repos_url":"https://api.github.com/users/mhujer/repos","events_url":"https://api.github.com/users/mhujer/events{/privacy}","received_events_url":"https://api.github.com/users/mhujer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mhujer/recipes","description":"Symfony Recipes Repository","fork":true,"url":"https://api.github.com/repos/mhujer/recipes","forks_url":"https://api.github.com/repos/mhujer/recipes/forks","keys_url":"https://api.github.com/repos/mhujer/recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhujer/recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhujer/recipes/teams","hooks_url":"https://api.github.com/repos/mhujer/recipes/hooks","issue_events_url":"https://api.github.com/repos/mhujer/recipes/issues/events{/number}","events_url":"https://api.github.com/repos/mhujer/recipes/events","assignees_url":"https://api.github.com/repos/mhujer/recipes/assignees{/user}","branches_url":"https://api.github.com/repos/mhujer/recipes/branches{/branch}","tags_url":"https://api.github.com/repos/mhujer/recipes/tags","blobs_url":"https://api.github.com/repos/mhujer/recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhujer/recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhujer/recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhujer/recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhujer/recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/mhujer/recipes/languages","stargazers_url":"https://api.github.com/repos/mhujer/recipes/stargazers","contributors_url":"https://api.github.com/repos/mhujer/recipes/contributors","subscribers_url":"https://api.github.com/repos/mhujer/recipes/subscribers","subscription_url":"https://api.github.com/repos/mhujer/recipes/subscription","commits_url":"https://api.github.com/repos/mhujer/recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhujer/recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhujer/recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhujer/recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhujer/recipes/contents/{+path}","compare_url":"https://api.github.com/repos/mhujer/recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhujer/recipes/merges","archive_url":"https://api.github.com/repos/mhujer/recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhujer/recipes/downloads","issues_url":"https://api.github.com/repos/mhujer/recipes/issues{/number}","pulls_url":"https://api.github.com/repos/mhujer/recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/mhujer/recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/mhujer/recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhujer/recipes/labels{/name}","releases_url":"https://api.github.com/repos/mhujer/recipes/releases{/id}","deployments_url":"https://api.github.com/repos/mhujer/recipes/deployments","created_at":"2018-12-22T09:01:58Z","updated_at":"2018-12-27T18:52:13Z","pushed_at":"2018-12-23T09:11:08Z","git_url":"git://github.com/mhujer/recipes.git","ssh_url":"git@github.com:mhujer/recipes.git","clone_url":"https://github.com/mhujer/recipes.git","svn_url":"https://github.com/mhujer/recipes","homepage":"https://flex.symfony.com/","size":516,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"8d8b44411b1b435f1b82cb0ac6e4cd4c7f86fe63","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":79607905,"node_id":"MDEwOlJlcG9zaXRvcnk3OTYwNzkwNQ==","name":"recipes","full_name":"symfony/recipes","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/recipes","description":"Symfony Recipes Repository","fork":false,"url":"https://api.github.com/repos/symfony/recipes","forks_url":"https://api.github.com/repos/symfony/recipes/forks","keys_url":"https://api.github.com/repos/symfony/recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/recipes/teams","hooks_url":"https://api.github.com/repos/symfony/recipes/hooks","issue_events_url":"https://api.github.com/repos/symfony/recipes/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/recipes/events","assignees_url":"https://api.github.com/repos/symfony/recipes/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/recipes/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/recipes/tags","blobs_url":"https://api.github.com/repos/symfony/recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/recipes/languages","stargazers_url":"https://api.github.com/repos/symfony/recipes/stargazers","contributors_url":"https://api.github.com/repos/symfony/recipes/contributors","subscribers_url":"https://api.github.com/repos/symfony/recipes/subscribers","subscription_url":"https://api.github.com/repos/symfony/recipes/subscription","commits_url":"https://api.github.com/repos/symfony/recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/recipes/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/recipes/merges","archive_url":"https://api.github.com/repos/symfony/recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/recipes/downloads","issues_url":"https://api.github.com/repos/symfony/recipes/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/recipes/labels{/name}","releases_url":"https://api.github.com/repos/symfony/recipes/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/recipes/deployments","created_at":"2017-01-20T22:59:16Z","updated_at":"2018-12-28T17:35:01Z","pushed_at":"2018-12-28T18:07:42Z","git_url":"git://github.com/symfony/recipes.git","ssh_url":"git@github.com:symfony/recipes.git","clone_url":"https://github.com/symfony/recipes.git","svn_url":"https://github.com/symfony/recipes","homepage":"https://flex.symfony.com/","size":537,"stargazers_count":556,"watchers_count":556,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":178,"open_issues":27,"watchers":556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/recipes/pulls/507"},"html":{"href":"https://github.com/symfony/recipes/pull/507"},"issue":{"href":"https://api.github.com/repos/symfony/recipes/issues/507"},"comments":{"href":"https://api.github.com/repos/symfony/recipes/issues/507/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/recipes/pulls/507/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/recipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/recipes/pulls/507/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/recipes/statuses/8d42000bb9cb29dd45706da961d383f5c0878cb2"}},"author_association":"NONE"}}
{"actor":{"display_login":"xabbuh"}}