{"action":"created","comment":{"url":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/comments/239751475","pull_request_review_id":182621230,"id":239751475,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTc1MTQ3NQ==","diff_hunk":"@@ -3,18 +3,20 @@ import PropTypes from 'prop-types';\n \n const Button = ({\n   label,\n+  id,\n   classes,\n   type,\n   onClick,\n }) => (\n-  <button type={type} className={`btn ${classes}`} onClick={onClick}>{label}</button>\n+  <button id={id} type={type} className={`btn ${classes}`} onClick={onClick}>{label}</button>\n );\n \n // eslint-disable-next-line\n Button.propTypes = {\n   label: PropTypes.oneOfType([PropTypes.string, PropTypes.node]).isRequired,\n   classes: PropTypes.string,\n   type: PropTypes.string,\n+  id: PropTypes.string.isRequired,","path":"lib/components/Button/index.jsx","position":18,"original_position":18,"commit_id":"9a2802fa942a968163bbe67a741057b8182c1809","original_commit_id":"9a2802fa942a968163bbe67a741057b8182c1809","user":{"login":"clicktravel-mark","id":28703446,"node_id":"MDQ6VXNlcjI4NzAzNDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/28703446?v=4","gravatar_id":"","url":"https://api.github.com/users/clicktravel-mark","html_url":"https://github.com/clicktravel-mark","followers_url":"https://api.github.com/users/clicktravel-mark/followers","following_url":"https://api.github.com/users/clicktravel-mark/following{/other_user}","gists_url":"https://api.github.com/users/clicktravel-mark/gists{/gist_id}","starred_url":"https://api.github.com/users/clicktravel-mark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clicktravel-mark/subscriptions","organizations_url":"https://api.github.com/users/clicktravel-mark/orgs","repos_url":"https://api.github.com/users/clicktravel-mark/repos","events_url":"https://api.github.com/users/clicktravel-mark/events{/privacy}","received_events_url":"https://api.github.com/users/clicktravel-mark/received_events","type":"User","site_admin":false},"body":"Aren't we going to get loads of failures/warnings when whatever uses this now does not provide the id?","created_at":"2018-12-07T09:58:37Z","updated_at":"2018-12-07T09:58:54Z","html_url":"https://github.com/travel-cloud/react-component-library/pull/83#discussion_r239751475","pull_request_url":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/83","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/comments/239751475"},"html":{"href":"https://github.com/travel-cloud/react-component-library/pull/83#discussion_r239751475"},"pull_request":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/83","id":236810568,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODEwNTY4","html_url":"https://github.com/travel-cloud/react-component-library/pull/83","diff_url":"https://github.com/travel-cloud/react-component-library/pull/83.diff","patch_url":"https://github.com/travel-cloud/react-component-library/pull/83.patch","issue_url":"https://api.github.com/repos/travel-cloud/react-component-library/issues/83","number":83,"state":"open","locked":false,"title":"[NO-JIRA] minor updates to component library","user":{"login":"dnimmo","id":1625813,"node_id":"MDQ6VXNlcjE2MjU4MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1625813?v=4","gravatar_id":"","url":"https://api.github.com/users/dnimmo","html_url":"https://github.com/dnimmo","followers_url":"https://api.github.com/users/dnimmo/followers","following_url":"https://api.github.com/users/dnimmo/following{/other_user}","gists_url":"https://api.github.com/users/dnimmo/gists{/gist_id}","starred_url":"https://api.github.com/users/dnimmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnimmo/subscriptions","organizations_url":"https://api.github.com/users/dnimmo/orgs","repos_url":"https://api.github.com/users/dnimmo/repos","events_url":"https://api.github.com/users/dnimmo/events{/privacy}","received_events_url":"https://api.github.com/users/dnimmo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-07T09:54:56Z","updated_at":"2018-12-07T09:58:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"173a7af7fbb668e3956ac640c838f15fe566409f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/83/commits","review_comments_url":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/83/comments","review_comment_url":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/comments{/number}","comments_url":"https://api.github.com/repos/travel-cloud/react-component-library/issues/83/comments","statuses_url":"https://api.github.com/repos/travel-cloud/react-component-library/statuses/9a2802fa942a968163bbe67a741057b8182c1809","head":{"label":"dnimmo:master","ref":"master","sha":"9a2802fa942a968163bbe67a741057b8182c1809","user":{"login":"dnimmo","id":1625813,"node_id":"MDQ6VXNlcjE2MjU4MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1625813?v=4","gravatar_id":"","url":"https://api.github.com/users/dnimmo","html_url":"https://github.com/dnimmo","followers_url":"https://api.github.com/users/dnimmo/followers","following_url":"https://api.github.com/users/dnimmo/following{/other_user}","gists_url":"https://api.github.com/users/dnimmo/gists{/gist_id}","starred_url":"https://api.github.com/users/dnimmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnimmo/subscriptions","organizations_url":"https://api.github.com/users/dnimmo/orgs","repos_url":"https://api.github.com/users/dnimmo/repos","events_url":"https://api.github.com/users/dnimmo/events{/privacy}","received_events_url":"https://api.github.com/users/dnimmo/received_events","type":"User","site_admin":false},"repo":{"id":138147233,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNDcyMzM=","name":"react-component-library","full_name":"dnimmo/react-component-library","private":false,"owner":{"login":"dnimmo","id":1625813,"node_id":"MDQ6VXNlcjE2MjU4MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1625813?v=4","gravatar_id":"","url":"https://api.github.com/users/dnimmo","html_url":"https://github.com/dnimmo","followers_url":"https://api.github.com/users/dnimmo/followers","following_url":"https://api.github.com/users/dnimmo/following{/other_user}","gists_url":"https://api.github.com/users/dnimmo/gists{/gist_id}","starred_url":"https://api.github.com/users/dnimmo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnimmo/subscriptions","organizations_url":"https://api.github.com/users/dnimmo/orgs","repos_url":"https://api.github.com/users/dnimmo/repos","events_url":"https://api.github.com/users/dnimmo/events{/privacy}","received_events_url":"https://api.github.com/users/dnimmo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dnimmo/react-component-library","description":"React UI component library","fork":true,"url":"https://api.github.com/repos/dnimmo/react-component-library","forks_url":"https://api.github.com/repos/dnimmo/react-component-library/forks","keys_url":"https://api.github.com/repos/dnimmo/react-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnimmo/react-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnimmo/react-component-library/teams","hooks_url":"https://api.github.com/repos/dnimmo/react-component-library/hooks","issue_events_url":"https://api.github.com/repos/dnimmo/react-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/dnimmo/react-component-library/events","assignees_url":"https://api.github.com/repos/dnimmo/react-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/dnimmo/react-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/dnimmo/react-component-library/tags","blobs_url":"https://api.github.com/repos/dnimmo/react-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnimmo/react-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnimmo/react-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnimmo/react-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnimmo/react-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/dnimmo/react-component-library/languages","stargazers_url":"https://api.github.com/repos/dnimmo/react-component-library/stargazers","contributors_url":"https://api.github.com/repos/dnimmo/react-component-library/contributors","subscribers_url":"https://api.github.com/repos/dnimmo/react-component-library/subscribers","subscription_url":"https://api.github.com/repos/dnimmo/react-component-library/subscription","commits_url":"https://api.github.com/repos/dnimmo/react-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnimmo/react-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnimmo/react-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnimmo/react-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnimmo/react-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/dnimmo/react-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnimmo/react-component-library/merges","archive_url":"https://api.github.com/repos/dnimmo/react-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnimmo/react-component-library/downloads","issues_url":"https://api.github.com/repos/dnimmo/react-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/dnimmo/react-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/dnimmo/react-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/dnimmo/react-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnimmo/react-component-library/labels{/name}","releases_url":"https://api.github.com/repos/dnimmo/react-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/dnimmo/react-component-library/deployments","created_at":"2018-06-21T09:11:11Z","updated_at":"2018-12-07T09:53:45Z","pushed_at":"2018-12-07T09:53:43Z","git_url":"git://github.com/dnimmo/react-component-library.git","ssh_url":"git@github.com:dnimmo/react-component-library.git","clone_url":"https://github.com/dnimmo/react-component-library.git","svn_url":"https://github.com/dnimmo/react-component-library","homepage":null,"size":957,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"travel-cloud:master","ref":"master","sha":"147b4e863cf6cc3b4be9cc0d7556f6b4302c956c","user":{"login":"travel-cloud","id":885969,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NTk2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/885969?v=4","gravatar_id":"","url":"https://api.github.com/users/travel-cloud","html_url":"https://github.com/travel-cloud","followers_url":"https://api.github.com/users/travel-cloud/followers","following_url":"https://api.github.com/users/travel-cloud/following{/other_user}","gists_url":"https://api.github.com/users/travel-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/travel-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travel-cloud/subscriptions","organizations_url":"https://api.github.com/users/travel-cloud/orgs","repos_url":"https://api.github.com/users/travel-cloud/repos","events_url":"https://api.github.com/users/travel-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/travel-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":109963008,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5NjMwMDg=","name":"react-component-library","full_name":"travel-cloud/react-component-library","private":false,"owner":{"login":"travel-cloud","id":885969,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NTk2OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/885969?v=4","gravatar_id":"","url":"https://api.github.com/users/travel-cloud","html_url":"https://github.com/travel-cloud","followers_url":"https://api.github.com/users/travel-cloud/followers","following_url":"https://api.github.com/users/travel-cloud/following{/other_user}","gists_url":"https://api.github.com/users/travel-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/travel-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/travel-cloud/subscriptions","organizations_url":"https://api.github.com/users/travel-cloud/orgs","repos_url":"https://api.github.com/users/travel-cloud/repos","events_url":"https://api.github.com/users/travel-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/travel-cloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/travel-cloud/react-component-library","description":"React UI component library","fork":false,"url":"https://api.github.com/repos/travel-cloud/react-component-library","forks_url":"https://api.github.com/repos/travel-cloud/react-component-library/forks","keys_url":"https://api.github.com/repos/travel-cloud/react-component-library/keys{/key_id}","collaborators_url":"https://api.github.com/repos/travel-cloud/react-component-library/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/travel-cloud/react-component-library/teams","hooks_url":"https://api.github.com/repos/travel-cloud/react-component-library/hooks","issue_events_url":"https://api.github.com/repos/travel-cloud/react-component-library/issues/events{/number}","events_url":"https://api.github.com/repos/travel-cloud/react-component-library/events","assignees_url":"https://api.github.com/repos/travel-cloud/react-component-library/assignees{/user}","branches_url":"https://api.github.com/repos/travel-cloud/react-component-library/branches{/branch}","tags_url":"https://api.github.com/repos/travel-cloud/react-component-library/tags","blobs_url":"https://api.github.com/repos/travel-cloud/react-component-library/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/travel-cloud/react-component-library/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/travel-cloud/react-component-library/git/refs{/sha}","trees_url":"https://api.github.com/repos/travel-cloud/react-component-library/git/trees{/sha}","statuses_url":"https://api.github.com/repos/travel-cloud/react-component-library/statuses/{sha}","languages_url":"https://api.github.com/repos/travel-cloud/react-component-library/languages","stargazers_url":"https://api.github.com/repos/travel-cloud/react-component-library/stargazers","contributors_url":"https://api.github.com/repos/travel-cloud/react-component-library/contributors","subscribers_url":"https://api.github.com/repos/travel-cloud/react-component-library/subscribers","subscription_url":"https://api.github.com/repos/travel-cloud/react-component-library/subscription","commits_url":"https://api.github.com/repos/travel-cloud/react-component-library/commits{/sha}","git_commits_url":"https://api.github.com/repos/travel-cloud/react-component-library/git/commits{/sha}","comments_url":"https://api.github.com/repos/travel-cloud/react-component-library/comments{/number}","issue_comment_url":"https://api.github.com/repos/travel-cloud/react-component-library/issues/comments{/number}","contents_url":"https://api.github.com/repos/travel-cloud/react-component-library/contents/{+path}","compare_url":"https://api.github.com/repos/travel-cloud/react-component-library/compare/{base}...{head}","merges_url":"https://api.github.com/repos/travel-cloud/react-component-library/merges","archive_url":"https://api.github.com/repos/travel-cloud/react-component-library/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/travel-cloud/react-component-library/downloads","issues_url":"https://api.github.com/repos/travel-cloud/react-component-library/issues{/number}","pulls_url":"https://api.github.com/repos/travel-cloud/react-component-library/pulls{/number}","milestones_url":"https://api.github.com/repos/travel-cloud/react-component-library/milestones{/number}","notifications_url":"https://api.github.com/repos/travel-cloud/react-component-library/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/travel-cloud/react-component-library/labels{/name}","releases_url":"https://api.github.com/repos/travel-cloud/react-component-library/releases{/id}","deployments_url":"https://api.github.com/repos/travel-cloud/react-component-library/deployments","created_at":"2017-11-08T10:45:21Z","updated_at":"2018-04-30T10:51:15Z","pushed_at":"2018-12-07T09:54:57Z","git_url":"git://github.com/travel-cloud/react-component-library.git","ssh_url":"git@github.com:travel-cloud/react-component-library.git","clone_url":"https://github.com/travel-cloud/react-component-library.git","svn_url":"https://github.com/travel-cloud/react-component-library","homepage":null,"size":957,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/83"},"html":{"href":"https://github.com/travel-cloud/react-component-library/pull/83"},"issue":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/issues/83"},"comments":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/travel-cloud/react-component-library/statuses/9a2802fa942a968163bbe67a741057b8182c1809"}},"author_association":"NONE"}}
{"actor":{"display_login":"clicktravel-mark"}}