{"action":"created","comment":{"url":"https://api.github.com/repos/transcom/mymove/pulls/comments/208016015","pull_request_review_id":143744390,"id":208016015,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODAxNjAxNQ==","diff_hunk":"@@ -63,9 +77,9 @@ export function updateShipment(\n   };\n }\n \n-export const selectShipment = (state, id) => {\n+export function selectShipment(state, id) {\n   if (!id) {\n     return null;\n   }\n   return denormalize([id], shipments, state.entities)[0];\n-};\n+}","path":"src/shared/Entities/modules/shipments.js","position":42,"original_position":42,"commit_id":"60407478237d35bb1c26b80984d4124b816cb793","original_commit_id":"60407478237d35bb1c26b80984d4124b816cb793","user":{"login":"jim","id":3331,"node_id":"MDQ6VXNlcjMzMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3331?v=4","gravatar_id":"","url":"https://api.github.com/users/jim","html_url":"https://github.com/jim","followers_url":"https://api.github.com/users/jim/followers","following_url":"https://api.github.com/users/jim/following{/other_user}","gists_url":"https://api.github.com/users/jim/gists{/gist_id}","starred_url":"https://api.github.com/users/jim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim/subscriptions","organizations_url":"https://api.github.com/users/jim/orgs","repos_url":"https://api.github.com/users/jim/repos","events_url":"https://api.github.com/users/jim/events{/privacy}","received_events_url":"https://api.github.com/users/jim/received_events","type":"User","site_admin":false},"body":"Don't need 'em after `function` declarations. We don't want to capture the enclosing scope at `this` or use implicit returns, which I think means that it's better to use good ol' `function` instead of `=>`.","created_at":"2018-08-06T20:17:41Z","updated_at":"2018-08-06T20:17:41Z","html_url":"https://github.com/transcom/mymove/pull/835#discussion_r208016015","pull_request_url":"https://api.github.com/repos/transcom/mymove/pulls/835","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments/208016015"},"html":{"href":"https://github.com/transcom/mymove/pull/835#discussion_r208016015"},"pull_request":{"href":"https://api.github.com/repos/transcom/mymove/pulls/835"}},"in_reply_to_id":207975906},"pull_request":{"url":"https://api.github.com/repos/transcom/mymove/pulls/835","id":206078092,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDc4MDky","html_url":"https://github.com/transcom/mymove/pull/835","diff_url":"https://github.com/transcom/mymove/pull/835.diff","patch_url":"https://github.com/transcom/mymove/pull/835.patch","issue_url":"https://api.github.com/repos/transcom/mymove/issues/835","number":835,"state":"open","locked":false,"title":"Populate HHG form with existing data [delivers #159451240]","user":{"login":"jim","id":3331,"node_id":"MDQ6VXNlcjMzMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3331?v=4","gravatar_id":"","url":"https://api.github.com/users/jim","html_url":"https://github.com/jim","followers_url":"https://api.github.com/users/jim/followers","following_url":"https://api.github.com/users/jim/following{/other_user}","gists_url":"https://api.github.com/users/jim/gists{/gist_id}","starred_url":"https://api.github.com/users/jim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim/subscriptions","organizations_url":"https://api.github.com/users/jim/orgs","repos_url":"https://api.github.com/users/jim/repos","events_url":"https://api.github.com/users/jim/events{/privacy}","received_events_url":"https://api.github.com/users/jim/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nShipment data that was previously saved is now displayed in the HHG form.\r\n\r\nTo make this work, I had to add `shipments` to the payload returned by `showLoggedInUser`. The Shipment form then fetches the shipment, and its data is then displayed in the form.\r\n\r\n## Reviewer Notes\r\n\r\nI could not get Pop to load the `*Address` associations on the Shipment during the `FetchOrder` call within `showLoggedInUser`, which is why I went with this approach.\r\n\r\nThis PR also stores a lot of the SM-side data in `state.entities` as a side-affect of loading the shipments using that approach. We'll need to be careful not to get confused about which data to use as there is now duplication, but my hope is that this will help us move towards using the normalized data layout.\r\n\r\n## Code Review Verification Steps\r\n\r\n* [ ] End to end tests pass (`make e2e_test`).\r\n* [ ] Request review from a member of a different team.\r\n* [ ] Have the Pivotal acceptance criteria been met for this change?\r\n\r\n## References\r\n\r\n* [Pivotal story](https://www.pivotaltracker.com/story/show/159451240) for this change","created_at":"2018-08-03T16:20:28Z","updated_at":"2018-08-06T20:17:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"900d1feda886bdc3c03c441c2b81388bdc1c8321","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tinyels","id":3142631,"node_id":"MDQ6VXNlcjMxNDI2MzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3142631?v=4","gravatar_id":"","url":"https://api.github.com/users/tinyels","html_url":"https://github.com/tinyels","followers_url":"https://api.github.com/users/tinyels/followers","following_url":"https://api.github.com/users/tinyels/following{/other_user}","gists_url":"https://api.github.com/users/tinyels/gists{/gist_id}","starred_url":"https://api.github.com/users/tinyels/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinyels/subscriptions","organizations_url":"https://api.github.com/users/tinyels/orgs","repos_url":"https://api.github.com/users/tinyels/repos","events_url":"https://api.github.com/users/tinyels/events{/privacy}","received_events_url":"https://api.github.com/users/tinyels/received_events","type":"User","site_admin":false},{"login":"stangah","id":5151804,"node_id":"MDQ6VXNlcjUxNTE4MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5151804?v=4","gravatar_id":"","url":"https://api.github.com/users/stangah","html_url":"https://github.com/stangah","followers_url":"https://api.github.com/users/stangah/followers","following_url":"https://api.github.com/users/stangah/following{/other_user}","gists_url":"https://api.github.com/users/stangah/gists{/gist_id}","starred_url":"https://api.github.com/users/stangah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stangah/subscriptions","organizations_url":"https://api.github.com/users/stangah/orgs","repos_url":"https://api.github.com/users/stangah/repos","events_url":"https://api.github.com/users/stangah/events{/privacy}","received_events_url":"https://api.github.com/users/stangah/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transcom/mymove/pulls/835/commits","review_comments_url":"https://api.github.com/repos/transcom/mymove/pulls/835/comments","review_comment_url":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transcom/mymove/issues/835/comments","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/60407478237d35bb1c26b80984d4124b816cb793","head":{"label":"transcom:jb-159451240-sm-hhg-flow-autopopulate","ref":"jb-159451240-sm-hhg-flow-autopopulate","sha":"60407478237d35bb1c26b80984d4124b816cb793","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-08-06T17:57:39Z","pushed_at":"2018-08-06T19:41:18Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":17534,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":4,"watchers":12,"default_branch":"master"}},"base":{"label":"transcom:master","ref":"master","sha":"7d96e19a9eda5183951eb488d30b7b80c93f6aa8","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/transcom/mymove","description":"Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-08-06T17:57:39Z","pushed_at":"2018-08-06T19:41:18Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"git@github.com:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":null,"size":17534,"stargazers_count":12,"watchers_count":12,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":4,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/835"},"html":{"href":"https://github.com/transcom/mymove/pull/835"},"issue":{"href":"https://api.github.com/repos/transcom/mymove/issues/835"},"comments":{"href":"https://api.github.com/repos/transcom/mymove/issues/835/comments"},"review_comments":{"href":"https://api.github.com/repos/transcom/mymove/pulls/835/comments"},"review_comment":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transcom/mymove/pulls/835/commits"},"statuses":{"href":"https://api.github.com/repos/transcom/mymove/statuses/60407478237d35bb1c26b80984d4124b816cb793"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jim"}}