{"action":"created","issue":{"url":"https://api.github.com/repos/secdev/scapy/issues/1381","repository_url":"https://api.github.com/repos/secdev/scapy","labels_url":"https://api.github.com/repos/secdev/scapy/issues/1381/labels{/name}","comments_url":"https://api.github.com/repos/secdev/scapy/issues/1381/comments","events_url":"https://api.github.com/repos/secdev/scapy/issues/1381/events","html_url":"https://github.com/secdev/scapy/pull/1381","id":318768593,"number":1381,"title":"RadioTap flags support + Dot11 FCS&improvements","user":{"login":"gpotter2","id":10530980,"avatar_url":"https://avatars0.githubusercontent.com/u/10530980?v=4","gravatar_id":"","url":"https://api.github.com/users/gpotter2","html_url":"https://github.com/gpotter2","followers_url":"https://api.github.com/users/gpotter2/followers","following_url":"https://api.github.com/users/gpotter2/following{/other_user}","gists_url":"https://api.github.com/users/gpotter2/gists{/gist_id}","starred_url":"https://api.github.com/users/gpotter2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpotter2/subscriptions","organizations_url":"https://api.github.com/users/gpotter2/orgs","repos_url":"https://api.github.com/users/gpotter2/repos","events_url":"https://api.github.com/users/gpotter2/events{/privacy}","received_events_url":"https://api.github.com/users/gpotter2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-30T01:34:32Z","updated_at":"2018-05-02T16:05:46Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/secdev/scapy/pulls/1381","html_url":"https://github.com/secdev/scapy/pull/1381","diff_url":"https://github.com/secdev/scapy/pull/1381.diff","patch_url":"https://github.com/secdev/scapy/pull/1381.patch"},"body":"This PR:\r\n- fixes https://github.com/secdev/scapy/issues/1379 by improving RadioTap fields support. This required the implementation of ReversePadField (RadioTap padding is reversed), which itself required a `pkt._tmp_dissect_pos`)\r\n- Supports FCS in Dot11\r\n- introducing `pkt._tmp_dissect_pos`. It is a variable which contains the size of the current layer, at the time that it is used, and can only be used during the dissection. It is very useful in `length_from` functions, as it gets what has been exactly dissected when the lambda gets executed. It is changing dynamically\r\n- merging contrib/ppi with dot11: the `PPI()` layer was implemented twice."},"comment":{"url":"https://api.github.com/repos/secdev/scapy/issues/comments/386031114","html_url":"https://github.com/secdev/scapy/pull/1381#issuecomment-386031114","issue_url":"https://api.github.com/repos/secdev/scapy/issues/1381","id":386031114,"user":{"login":"guedou","id":11683796,"avatar_url":"https://avatars1.githubusercontent.com/u/11683796?v=4","gravatar_id":"","url":"https://api.github.com/users/guedou","html_url":"https://github.com/guedou","followers_url":"https://api.github.com/users/guedou/followers","following_url":"https://api.github.com/users/guedou/following{/other_user}","gists_url":"https://api.github.com/users/guedou/gists{/gist_id}","starred_url":"https://api.github.com/users/guedou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guedou/subscriptions","organizations_url":"https://api.github.com/users/guedou/orgs","repos_url":"https://api.github.com/users/guedou/repos","events_url":"https://api.github.com/users/guedou/events{/privacy}","received_events_url":"https://api.github.com/users/guedou/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T16:05:46Z","updated_at":"2018-05-02T16:05:46Z","author_association":"OWNER","body":"I restarted the failing test."}}
{"actor":{"display_login":"guedou"}}