{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/242219806","pull_request_review_id":185680670,"id":242219806,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjIxOTgwNg==","diff_hunk":"@@ -848,6 +852,8 @@ def course_about(request, course_id):\n \n         sidebar_html_enabled = course_experience_waffle().is_enabled(ENABLE_COURSE_ABOUT_SIDEBAR_HTML)\n \n+        allow_anonymous = COURSE_ENABLE_UNENROLLED_ACCESS_FLAG.is_enabled(course_key)","path":"lms/djangoapps/courseware/views/views.py","position":null,"original_position":17,"commit_id":"b378348f55f1b338497305c7af04d3cd79c5c9e1","original_commit_id":"1cab41fa79939f738861ce68e5918a92f4ae39db","user":{"login":"pkulkark","id":13742492,"node_id":"MDQ6VXNlcjEzNzQyNDky","avatar_url":"https://avatars1.githubusercontent.com/u/13742492?v=4","gravatar_id":"","url":"https://api.github.com/users/pkulkark","html_url":"https://github.com/pkulkark","followers_url":"https://api.github.com/users/pkulkark/followers","following_url":"https://api.github.com/users/pkulkark/following{/other_user}","gists_url":"https://api.github.com/users/pkulkark/gists{/gist_id}","starred_url":"https://api.github.com/users/pkulkark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkulkark/subscriptions","organizations_url":"https://api.github.com/users/pkulkark/orgs","repos_url":"https://api.github.com/users/pkulkark/repos","events_url":"https://api.github.com/users/pkulkark/events{/privacy}","received_events_url":"https://api.github.com/users/pkulkark/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-12-17T16:32:51Z","updated_at":"2018-12-17T16:32:52Z","html_url":"https://github.com/edx/edx-platform/pull/19385#discussion_r242219806","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/19385","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/242219806"},"html":{"href":"https://github.com/edx/edx-platform/pull/19385#discussion_r242219806"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/19385"}},"in_reply_to_id":242180869},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/19385","id":236760836,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2NzYwODM2","html_url":"https://github.com/edx/edx-platform/pull/19385","diff_url":"https://github.com/edx/edx-platform/pull/19385.diff","patch_url":"https://github.com/edx/edx-platform/pull/19385.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/19385","number":19385,"state":"open","locked":false,"title":"WIP: Implement public cohort for anonymous and unenrolled users","user":{"login":"pkulkark","id":13742492,"node_id":"MDQ6VXNlcjEzNzQyNDky","avatar_url":"https://avatars1.githubusercontent.com/u/13742492?v=4","gravatar_id":"","url":"https://api.github.com/users/pkulkark","html_url":"https://github.com/pkulkark","followers_url":"https://api.github.com/users/pkulkark/followers","following_url":"https://api.github.com/users/pkulkark/following{/other_user}","gists_url":"https://api.github.com/users/pkulkark/gists{/gist_id}","starred_url":"https://api.github.com/users/pkulkark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkulkark/subscriptions","organizations_url":"https://api.github.com/users/pkulkark/orgs","repos_url":"https://api.github.com/users/pkulkark/repos","events_url":"https://api.github.com/users/pkulkark/events{/privacy}","received_events_url":"https://api.github.com/users/pkulkark/received_events","type":"User","site_admin":false},"body":"**Work-in-progress**: Do not merge. We will ping once our internal review is completed\r\n\r\nThis PR is based on #19284 and is part of the series of work related to the proposal #18134 .\r\n\r\n**Description:**\r\n\r\nAllow anonymous and unenrolled users access to public courses with cohorts enabled. \r\nCurrent behaviour is that if the course had cohorts enabled and any user accessing the course that is not assigned to a cohort gets assigned to a \"default\" cohort. This PR avoids the assignment of anonymous/unenrolled users to any cohort when course is public. Anonymous or unenrolled users will only see content that does not have a content group assigned.\r\nThis PR also shows \"View Course\" link to the course outline on the course about page for a course marked public/public outline. It also makes course handouts available for public courses (not for public_outline).\r\n\r\nSandbox server:\r\n\r\n- LMS: https://pr19385.sandbox.opencraft.hosting/\r\n\r\n- Studio: https://studio-pr19385.sandbox.opencraft.hosting/\r\n\r\nContains 2 courses:\r\n\r\n- [edX Demo Course](https://pr19385.sandbox.opencraft.hosting/courses/course-v1:edX+DemoX+Demo_Course/about) has `seo.enable_anonymous_courseware_access` course waffle flag, and the \"Advanced Settings > Course Visibility For Unenrolled Learners\" set to public.\r\n\r\n- [Test Course](https://pr19385.sandbox.opencraft.hosting/courses/course-v1:test+test01+2018_T1/course/) also is set to public. It contains 2 units : Unit-1 is accessible to all and Unit-2 has access restricted to \"test_cohort\" and can only be seen by the `verified@example.com` user.\r\n\r\n**Testing Instructions:**\r\n\r\n- Create a course and enable cohorts.\r\n\r\n- Mark the course as public and try accessing the course content as an anonymous or unenrolled user. The course content not assigned to any content group should be accessible.\r\n\r\n- Mark the course as public/public_outline and access the course about page. There should be a \"View Course\" button visible which links to the course outline.\r\n\r\n- If the course is marked public, the course handouts should be available to anonymous/unenrolled users as well. If course is marked public_outline, handouts should not be available.","created_at":"2018-12-07T05:45:30Z","updated_at":"2018-12-17T16:32:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88bcf7ebfb2b00dfd5b7d927d28aef8e7f29497d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":78051711,"node_id":"MDU6TGFiZWw3ODA1MTcxMQ==","url":"https://api.github.com/repos/edx/edx-platform/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf","default":false},{"id":95143255,"node_id":"MDU6TGFiZWw5NTE0MzI1NQ==","url":"https://api.github.com/repos/edx/edx-platform/labels/waiting%20on%20author","name":"waiting on author","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/19385/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/19385/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/19385/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/b378348f55f1b338497305c7af04d3cd79c5c9e1","head":{"label":"open-craft:pooja/implement-public-cohort","ref":"pooja/implement-public-cohort","sha":"b378348f55f1b338497305c7af04d3cd79c5c9e1","user":{"login":"open-craft","id":7414786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MTQ3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":19940883,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk0MDg4Mw==","name":"edx-platform","full_name":"open-craft/edx-platform","private":false,"owner":{"login":"open-craft","id":7414786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0MTQ3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/open-craft/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/open-craft/edx-platform","forks_url":"https://api.github.com/repos/open-craft/edx-platform/forks","keys_url":"https://api.github.com/repos/open-craft/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/edx-platform/teams","hooks_url":"https://api.github.com/repos/open-craft/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/open-craft/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/edx-platform/events","assignees_url":"https://api.github.com/repos/open-craft/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/edx-platform/tags","blobs_url":"https://api.github.com/repos/open-craft/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/edx-platform/languages","stargazers_url":"https://api.github.com/repos/open-craft/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/open-craft/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/open-craft/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/open-craft/edx-platform/subscription","commits_url":"https://api.github.com/repos/open-craft/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/edx-platform/merges","archive_url":"https://api.github.com/repos/open-craft/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/edx-platform/downloads","issues_url":"https://api.github.com/repos/open-craft/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/edx-platform/deployments","created_at":"2014-05-19T12:28:25Z","updated_at":"2018-07-20T16:54:43Z","pushed_at":"2018-12-17T16:11:55Z","git_url":"git://github.com/open-craft/edx-platform.git","ssh_url":"git@github.com:open-craft/edx-platform.git","clone_url":"https://github.com/open-craft/edx-platform.git","svn_url":"https://github.com/open-craft/edx-platform","homepage":"http://code.edx.org/","size":1001163,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":6,"default_branch":"open-craft-notice"}},"base":{"label":"edx:master","ref":"master","sha":"51af02e28d649119f55a17a82ae242201395613f","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MTA3Mw==","name":"edx-platform","full_name":"edx/edx-platform","private":false,"owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2018-12-17T16:23:20Z","pushed_at":"2018-12-17T16:28:43Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":992039,"stargazers_count":4008,"watchers_count":4008,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2274,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2274,"open_issues":217,"watchers":4008,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/19385"},"html":{"href":"https://github.com/edx/edx-platform/pull/19385"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/19385"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/19385/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/19385/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/19385/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/b378348f55f1b338497305c7af04d3cd79c5c9e1"}},"author_association":"NONE"}}
{"actor":{"display_login":"pkulkark"}}