{"action":"closed","number":747,"pull_request":{"url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/747","id":214355629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzU1NjI5","html_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/747","diff_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/747.diff","patch_url":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/747.patch","issue_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/747","number":747,"state":"closed","locked":false,"title":"Docs and log message for bad Route spec","user":{"login":"sjberman","id":8921145,"node_id":"MDQ6VXNlcjg5MjExNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8921145?v=4","gravatar_id":"","url":"https://api.github.com/users/sjberman","html_url":"https://github.com/sjberman","followers_url":"https://api.github.com/users/sjberman/followers","following_url":"https://api.github.com/users/sjberman/following{/other_user}","gists_url":"https://api.github.com/users/sjberman/gists{/gist_id}","starred_url":"https://api.github.com/users/sjberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjberman/subscriptions","organizations_url":"https://api.github.com/users/sjberman/orgs","repos_url":"https://api.github.com/users/sjberman/repos","events_url":"https://api.github.com/users/sjberman/events{/privacy}","received_events_url":"https://api.github.com/users/sjberman/received_events","type":"User","site_admin":false},"body":"Problem: The controller requires either literal cert/key info or annotations to be specified for Route profiles. If neither were specified, the controller silently failed.\r\n\r\nSolution: Added docs and a log warning to inform the user that one of these fields is required.\r\n\r\nFixes #746 ","created_at":"2018-09-10T15:31:52Z","updated_at":"2018-09-10T17:36:45Z","closed_at":"2018-09-10T17:36:45Z","merged_at":"2018-09-10T17:36:45Z","merge_commit_sha":"da2aed8246ff11cc1678061fa3863436eb136505","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/747/commits","review_comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/747/comments","review_comment_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/747/comments","statuses_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/9b43d4c0b9b2258907d3fa737508510724d55fa2","head":{"label":"sjberman:route_docs","ref":"route_docs","sha":"9b43d4c0b9b2258907d3fa737508510724d55fa2","user":{"login":"sjberman","id":8921145,"node_id":"MDQ6VXNlcjg5MjExNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8921145?v=4","gravatar_id":"","url":"https://api.github.com/users/sjberman","html_url":"https://github.com/sjberman","followers_url":"https://api.github.com/users/sjberman/followers","following_url":"https://api.github.com/users/sjberman/following{/other_user}","gists_url":"https://api.github.com/users/sjberman/gists{/gist_id}","starred_url":"https://api.github.com/users/sjberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjberman/subscriptions","organizations_url":"https://api.github.com/users/sjberman/orgs","repos_url":"https://api.github.com/users/sjberman/repos","events_url":"https://api.github.com/users/sjberman/events{/privacy}","received_events_url":"https://api.github.com/users/sjberman/received_events","type":"User","site_admin":false},"repo":{"id":95817853,"node_id":"MDEwOlJlcG9zaXRvcnk5NTgxNzg1Mw==","name":"k8s-bigip-ctlr","full_name":"sjberman/k8s-bigip-ctlr","owner":{"login":"sjberman","id":8921145,"node_id":"MDQ6VXNlcjg5MjExNDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8921145?v=4","gravatar_id":"","url":"https://api.github.com/users/sjberman","html_url":"https://github.com/sjberman","followers_url":"https://api.github.com/users/sjberman/followers","following_url":"https://api.github.com/users/sjberman/following{/other_user}","gists_url":"https://api.github.com/users/sjberman/gists{/gist_id}","starred_url":"https://api.github.com/users/sjberman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjberman/subscriptions","organizations_url":"https://api.github.com/users/sjberman/orgs","repos_url":"https://api.github.com/users/sjberman/repos","events_url":"https://api.github.com/users/sjberman/events{/privacy}","received_events_url":"https://api.github.com/users/sjberman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sjberman/k8s-bigip-ctlr","description":"Repository for F5 Kubernetes BIG-IP Controller.","fork":true,"url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr","forks_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/forks","keys_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/teams","hooks_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/hooks","issue_events_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/issues/events{/number}","events_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/events","assignees_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/assignees{/user}","branches_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/branches{/branch}","tags_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/tags","blobs_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/statuses/{sha}","languages_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/languages","stargazers_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/stargazers","contributors_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/contributors","subscribers_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/subscribers","subscription_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/subscription","commits_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/contents/{+path}","compare_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/merges","archive_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/downloads","issues_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/issues{/number}","pulls_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/pulls{/number}","milestones_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/milestones{/number}","notifications_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/labels{/name}","releases_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/releases{/id}","deployments_url":"https://api.github.com/repos/sjberman/k8s-bigip-ctlr/deployments","created_at":"2017-06-29T20:40:42Z","updated_at":"2018-09-07T22:42:34Z","pushed_at":"2018-09-10T16:09:38Z","git_url":"git://github.com/sjberman/k8s-bigip-ctlr.git","ssh_url":"git@github.com:sjberman/k8s-bigip-ctlr.git","clone_url":"https://github.com/sjberman/k8s-bigip-ctlr.git","svn_url":"https://github.com/sjberman/k8s-bigip-ctlr","homepage":null,"size":6709,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"F5Networks:master","ref":"master","sha":"c783702e1c08be75fff94eba5cd47086d6a3e083","user":{"login":"F5Networks","id":8935905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MzU5MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8935905?v=4","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"repo":{"id":84464014,"node_id":"MDEwOlJlcG9zaXRvcnk4NDQ2NDAxNA==","name":"k8s-bigip-ctlr","full_name":"F5Networks/k8s-bigip-ctlr","owner":{"login":"F5Networks","id":8935905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MzU5MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8935905?v=4","gravatar_id":"","url":"https://api.github.com/users/F5Networks","html_url":"https://github.com/F5Networks","followers_url":"https://api.github.com/users/F5Networks/followers","following_url":"https://api.github.com/users/F5Networks/following{/other_user}","gists_url":"https://api.github.com/users/F5Networks/gists{/gist_id}","starred_url":"https://api.github.com/users/F5Networks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/F5Networks/subscriptions","organizations_url":"https://api.github.com/users/F5Networks/orgs","repos_url":"https://api.github.com/users/F5Networks/repos","events_url":"https://api.github.com/users/F5Networks/events{/privacy}","received_events_url":"https://api.github.com/users/F5Networks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/F5Networks/k8s-bigip-ctlr","description":"Repository for F5 BIG-IP Controller for Kubernetes.","fork":false,"url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr","forks_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/forks","keys_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/teams","hooks_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/hooks","issue_events_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/events{/number}","events_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/events","assignees_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/assignees{/user}","branches_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/branches{/branch}","tags_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/tags","blobs_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/{sha}","languages_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/languages","stargazers_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/stargazers","contributors_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/contributors","subscribers_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/subscribers","subscription_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/subscription","commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/contents/{+path}","compare_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/merges","archive_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/downloads","issues_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues{/number}","pulls_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls{/number}","milestones_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/milestones{/number}","notifications_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/labels{/name}","releases_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/releases{/id}","deployments_url":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/deployments","created_at":"2017-03-09T16:24:02Z","updated_at":"2018-09-07T21:58:27Z","pushed_at":"2018-09-10T17:36:45Z","git_url":"git://github.com/F5Networks/k8s-bigip-ctlr.git","ssh_url":"git@github.com:F5Networks/k8s-bigip-ctlr.git","clone_url":"https://github.com/F5Networks/k8s-bigip-ctlr.git","svn_url":"https://github.com/F5Networks/k8s-bigip-ctlr","homepage":"","size":6811,"stargazers_count":79,"watchers_count":79,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":46,"mirror_url":null,"archived":false,"open_issues_count":53,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":46,"open_issues":53,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/747"},"html":{"href":"https://github.com/F5Networks/k8s-bigip-ctlr/pull/747"},"issue":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/747"},"comments":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/issues/747/comments"},"review_comments":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/747/comments"},"review_comment":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/pulls/747/commits"},"statuses":{"href":"https://api.github.com/repos/F5Networks/k8s-bigip-ctlr/statuses/9b43d4c0b9b2258907d3fa737508510724d55fa2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"amudukutore","id":1004624,"node_id":"MDQ6VXNlcjEwMDQ2MjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1004624?v=4","gravatar_id":"","url":"https://api.github.com/users/amudukutore","html_url":"https://github.com/amudukutore","followers_url":"https://api.github.com/users/amudukutore/followers","following_url":"https://api.github.com/users/amudukutore/following{/other_user}","gists_url":"https://api.github.com/users/amudukutore/gists{/gist_id}","starred_url":"https://api.github.com/users/amudukutore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amudukutore/subscriptions","organizations_url":"https://api.github.com/users/amudukutore/orgs","repos_url":"https://api.github.com/users/amudukutore/repos","events_url":"https://api.github.com/users/amudukutore/events{/privacy}","received_events_url":"https://api.github.com/users/amudukutore/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":0,"changed_files":3}}
{"actor":{"display_login":"amudukutore"}}