{"action":"created","issue":{"url":"https://api.github.com/repos/a-a-ron/continuous-integration/issues/4","repository_url":"https://api.github.com/repos/a-a-ron/continuous-integration","labels_url":"https://api.github.com/repos/a-a-ron/continuous-integration/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/a-a-ron/continuous-integration/issues/4/comments","events_url":"https://api.github.com/repos/a-a-ron/continuous-integration/issues/4/events","html_url":"https://github.com/a-a-ron/continuous-integration/pull/4","id":392826260,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDEwOTQx","number":4,"title":"Add external links to the 'docs' directory","user":{"login":"galileo[bot]","id":34040521,"node_id":"MDM6Qm90MzQwNDA1MjE=","avatar_url":"https://avatars3.githubusercontent.com/in/7044?v=4","gravatar_id":"","url":"https://api.github.com/users/galileo%5Bbot%5D","html_url":"https://github.com/apps/galileo","followers_url":"https://api.github.com/users/galileo%5Bbot%5D/followers","following_url":"https://api.github.com/users/galileo%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/galileo%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/galileo%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galileo%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/galileo%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/galileo%5Bbot%5D/repos","events_url":"https://api.github.com/users/galileo%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/galileo%5Bbot%5D/received_events","type":"Bot","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"a-a-ron","id":6351798,"node_id":"MDQ6VXNlcjYzNTE3OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6351798?v=4","gravatar_id":"","url":"https://api.github.com/users/a-a-ron","html_url":"https://github.com/a-a-ron","followers_url":"https://api.github.com/users/a-a-ron/followers","following_url":"https://api.github.com/users/a-a-ron/following{/other_user}","gists_url":"https://api.github.com/users/a-a-ron/gists{/gist_id}","starred_url":"https://api.github.com/users/a-a-ron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-a-ron/subscriptions","organizations_url":"https://api.github.com/users/a-a-ron/orgs","repos_url":"https://api.github.com/users/a-a-ron/repos","events_url":"https://api.github.com/users/a-a-ron/events{/privacy}","received_events_url":"https://api.github.com/users/a-a-ron/received_events","type":"User","site_admin":true},"assignees":[{"login":"a-a-ron","id":6351798,"node_id":"MDQ6VXNlcjYzNTE3OTg=","avatar_url":"https://avatars1.githubusercontent.com/u/6351798?v=4","gravatar_id":"","url":"https://api.github.com/users/a-a-ron","html_url":"https://github.com/a-a-ron","followers_url":"https://api.github.com/users/a-a-ron/followers","following_url":"https://api.github.com/users/a-a-ron/following{/other_user}","gists_url":"https://api.github.com/users/a-a-ron/gists{/gist_id}","starred_url":"https://api.github.com/users/a-a-ron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-a-ron/subscriptions","organizations_url":"https://api.github.com/users/a-a-ron/orgs","repos_url":"https://api.github.com/users/a-a-ron/repos","events_url":"https://api.github.com/users/a-a-ron/events{/privacy}","received_events_url":"https://api.github.com/users/a-a-ron/received_events","type":"User","site_admin":true}],"milestone":null,"comments":0,"created_at":"2018-12-19T23:53:25Z","updated_at":"2018-12-19T23:53:48Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/a-a-ron/continuous-integration/pulls/4","html_url":"https://github.com/a-a-ron/continuous-integration/pull/4","diff_url":"https://github.com/a-a-ron/continuous-integration/pull/4.diff","patch_url":"https://github.com/a-a-ron/continuous-integration/pull/4.patch"},"body":"With the addition of links to our code base, we should add a unit test as one of our CircleCI jobs that run whenever it builds. Let's add a test using HTMLProofer to test for any broken links, images, or HTML. By adding this to our `testlinks` unit test, HTMLProofer will test our code before it gets merged.\n\nI've already added some things necessary for HTMLProofer test to run. Next, replace the placeholder text with the following:\n\n```yaml\nbundle exec htmlproofer ./_site --check-html\n```\n\n## Step 9: Add an HTMLProofer unit test\n\nLet's make sure all links are valid by adding a link checker unit test.\n\n### :keyboard: Activity: Check for broken links using CircleCI\n\n1. In this pull request, replace the `REPLACE-ME-WITH-SCRIPT` placeholder text with `bundle exec htmlproofer ./_site --check-html`. **You can do this by editing the file from the _Files changed_ tab, or by scrolling down and accepting the suggested change.**\n\n<hr>\n<h3 align=\"center\">I'll respond below with your next step.</h3>\n"},"comment":{"url":"https://api.github.com/repos/a-a-ron/continuous-integration/issues/comments/448794820","html_url":"https://github.com/a-a-ron/continuous-integration/pull/4#issuecomment-448794820","issue_url":"https://api.github.com/repos/a-a-ron/continuous-integration/issues/4","id":448794820,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODc5NDgyMA==","user":{"login":"galileo[bot]","id":34040521,"node_id":"MDM6Qm90MzQwNDA1MjE=","avatar_url":"https://avatars3.githubusercontent.com/in/7044?v=4","gravatar_id":"","url":"https://api.github.com/users/galileo%5Bbot%5D","html_url":"https://github.com/apps/galileo","followers_url":"https://api.github.com/users/galileo%5Bbot%5D/followers","following_url":"https://api.github.com/users/galileo%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/galileo%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/galileo%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galileo%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/galileo%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/galileo%5Bbot%5D/repos","events_url":"https://api.github.com/users/galileo%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/galileo%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-19T23:53:48Z","updated_at":"2018-12-19T23:53:48Z","author_association":"CONTRIBUTOR","body":"Nice work! We've added a unit test to check for broken links. When a broken link was committed to our pull request, the test caught it and let us know the build had failed.\n\n![screen shot 2018-12-13 at 4 51 01 pm](https://user-images.githubusercontent.com/6351798/49974597-54547b00-fef7-11e8-899d-3a0f227bed10.png)\n\nNotice how the two parts **build** and **testlinks** both show as CircleCI checks in our build, but the build unit test succeeds while the `testlinks` build fails due to a broken link. Also, notice that even though the `testlinks` test fails, we are still able to merge in the pull request. The branch protection only requires a build test before merging.\n\nWhen adding tests, or **jobs**, you can decide which ones must pass before allowing the pull request to merge.\n\n![screen shot 2018-12-13 at 5 01 36 pm](https://user-images.githubusercontent.com/6351798/49974946-ca0d1680-fef8-11e8-890e-90a568b50c56.png)\n\n## Step 10: Fix the broken link\n\nEven though it's not required, let's fix the broken link so both CircleCI checks are passing. You can click on the **Details** link next to the failed **testlinks** CircleCI test for more information. By doing so, you'll find the following error:\n\n```\nExternal link https://help.github.com/setupgithub failed: 404 No error\n```\n\n### :keyboard: Activity: Fix the broken link\n\n1. In this pull request, change `https://help.github.com/setupgithub` to `https://help.github.com/articles/set-up-git/`. **You can do this by editing the file from the _Files changed_ tab, or by scrolling down and accepting the suggested change.**\n\n<hr>\n<h3 align=\"center\">I'll respond below with your next step.</h3>\n"}}
{"actor":{"display_login":"galileo"}}