{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/glow/pulls/comments/219112876","pull_request_review_id":157206104,"id":219112876,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTExMjg3Ng==","diff_hunk":"@@ -2684,6 +2684,51 @@ TEST_P(InterpAndCPU, Int8Tanh) {\n   }\n }\n \n+/// Verify that a quantized Log works correctly.\n+TEST_P(InterpAndCPU, Int8Log) {","path":"tests/unittests/OperatorTest.cpp","position":5,"original_position":5,"commit_id":"506535d2ac7671ec62a8409185e587b48811b57d","original_commit_id":"f79945dfc13207473facaafd7d48aad48cf0e3d5","user":{"login":"jfix71","id":1198212,"node_id":"MDQ6VXNlcjExOTgyMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1198212?v=4","gravatar_id":"","url":"https://api.github.com/users/jfix71","html_url":"https://github.com/jfix71","followers_url":"https://api.github.com/users/jfix71/followers","following_url":"https://api.github.com/users/jfix71/following{/other_user}","gists_url":"https://api.github.com/users/jfix71/gists{/gist_id}","starred_url":"https://api.github.com/users/jfix71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfix71/subscriptions","organizations_url":"https://api.github.com/users/jfix71/orgs","repos_url":"https://api.github.com/users/jfix71/repos","events_url":"https://api.github.com/users/jfix71/events{/privacy}","received_events_url":"https://api.github.com/users/jfix71/received_events","type":"User","site_admin":false},"body":"@nadavrot Let me know if you would like me to change this test.","created_at":"2018-09-20T10:32:50Z","updated_at":"2018-09-20T10:32:51Z","html_url":"https://github.com/pytorch/glow/pull/1654#discussion_r219112876","pull_request_url":"https://api.github.com/repos/pytorch/glow/pulls/1654","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments/219112876"},"html":{"href":"https://github.com/pytorch/glow/pull/1654#discussion_r219112876"},"pull_request":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1654"}},"in_reply_to_id":218541123},"pull_request":{"url":"https://api.github.com/repos/pytorch/glow/pulls/1654","id":215939352,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTM5MzUy","html_url":"https://github.com/pytorch/glow/pull/1654","diff_url":"https://github.com/pytorch/glow/pull/1654.diff","patch_url":"https://github.com/pytorch/glow/pull/1654.patch","issue_url":"https://api.github.com/repos/pytorch/glow/issues/1654","number":1654,"state":"open","locked":false,"title":"[Quantization] Add support for quantizing Log","user":{"login":"jfix71","id":1198212,"node_id":"MDQ6VXNlcjExOTgyMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1198212?v=4","gravatar_id":"","url":"https://api.github.com/users/jfix71","html_url":"https://github.com/jfix71","followers_url":"https://api.github.com/users/jfix71/followers","following_url":"https://api.github.com/users/jfix71/following{/other_user}","gists_url":"https://api.github.com/users/jfix71/gists{/gist_id}","starred_url":"https://api.github.com/users/jfix71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfix71/subscriptions","organizations_url":"https://api.github.com/users/jfix71/orgs","repos_url":"https://api.github.com/users/jfix71/repos","events_url":"https://api.github.com/users/jfix71/events{/privacy}","received_events_url":"https://api.github.com/users/jfix71/received_events","type":"User","site_admin":false},"body":"*Description*: Quantized `SigmoidNode` and `TanhNode` are implemented with a pre-calculated mapping that is input to a `IntLookupTable`. However implementing a quantized `LogNode` with a `IntLookupTable` requires calculating a new mapping depending on the input and output min/max. I added a helper `createMapping()` for creating such a mapping to Quantization/Base in the first commit. The second commit adds support for lowering a quantized `LogNode` into a `IntLookupTable` that has its mapping created via `createMapping()`.\r\n\r\n*Testing*: Added a unit test for quantized log","created_at":"2018-09-17T10:45:58Z","updated_at":"2018-09-20T10:32:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e6e55b4d3495bd48153ffefd8589d176059ab294","assignee":{"login":"rdzhabarov","id":34466929,"node_id":"MDQ6VXNlcjM0NDY2OTI5","avatar_url":"https://avatars0.githubusercontent.com/u/34466929?v=4","gravatar_id":"","url":"https://api.github.com/users/rdzhabarov","html_url":"https://github.com/rdzhabarov","followers_url":"https://api.github.com/users/rdzhabarov/followers","following_url":"https://api.github.com/users/rdzhabarov/following{/other_user}","gists_url":"https://api.github.com/users/rdzhabarov/gists{/gist_id}","starred_url":"https://api.github.com/users/rdzhabarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdzhabarov/subscriptions","organizations_url":"https://api.github.com/users/rdzhabarov/orgs","repos_url":"https://api.github.com/users/rdzhabarov/repos","events_url":"https://api.github.com/users/rdzhabarov/events{/privacy}","received_events_url":"https://api.github.com/users/rdzhabarov/received_events","type":"User","site_admin":false},"assignees":[{"login":"rdzhabarov","id":34466929,"node_id":"MDQ6VXNlcjM0NDY2OTI5","avatar_url":"https://avatars0.githubusercontent.com/u/34466929?v=4","gravatar_id":"","url":"https://api.github.com/users/rdzhabarov","html_url":"https://github.com/rdzhabarov","followers_url":"https://api.github.com/users/rdzhabarov/followers","following_url":"https://api.github.com/users/rdzhabarov/following{/other_user}","gists_url":"https://api.github.com/users/rdzhabarov/gists{/gist_id}","starred_url":"https://api.github.com/users/rdzhabarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdzhabarov/subscriptions","organizations_url":"https://api.github.com/users/rdzhabarov/orgs","repos_url":"https://api.github.com/users/rdzhabarov/repos","events_url":"https://api.github.com/users/rdzhabarov/events{/privacy}","received_events_url":"https://api.github.com/users/rdzhabarov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":706497924,"node_id":"MDU6TGFiZWw3MDY0OTc5MjQ=","url":"https://api.github.com/repos/pytorch/glow/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/glow/pulls/1654/commits","review_comments_url":"https://api.github.com/repos/pytorch/glow/pulls/1654/comments","review_comment_url":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/glow/issues/1654/comments","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/506535d2ac7671ec62a8409185e587b48811b57d","head":{"label":"jfix71:log_quantization","ref":"log_quantization","sha":"506535d2ac7671ec62a8409185e587b48811b57d","user":{"login":"jfix71","id":1198212,"node_id":"MDQ6VXNlcjExOTgyMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1198212?v=4","gravatar_id":"","url":"https://api.github.com/users/jfix71","html_url":"https://github.com/jfix71","followers_url":"https://api.github.com/users/jfix71/followers","following_url":"https://api.github.com/users/jfix71/following{/other_user}","gists_url":"https://api.github.com/users/jfix71/gists{/gist_id}","starred_url":"https://api.github.com/users/jfix71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfix71/subscriptions","organizations_url":"https://api.github.com/users/jfix71/orgs","repos_url":"https://api.github.com/users/jfix71/repos","events_url":"https://api.github.com/users/jfix71/events{/privacy}","received_events_url":"https://api.github.com/users/jfix71/received_events","type":"User","site_admin":false},"repo":{"id":137809651,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc4MDk2NTE=","name":"glow","full_name":"jfix71/glow","private":false,"owner":{"login":"jfix71","id":1198212,"node_id":"MDQ6VXNlcjExOTgyMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1198212?v=4","gravatar_id":"","url":"https://api.github.com/users/jfix71","html_url":"https://github.com/jfix71","followers_url":"https://api.github.com/users/jfix71/followers","following_url":"https://api.github.com/users/jfix71/following{/other_user}","gists_url":"https://api.github.com/users/jfix71/gists{/gist_id}","starred_url":"https://api.github.com/users/jfix71/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfix71/subscriptions","organizations_url":"https://api.github.com/users/jfix71/orgs","repos_url":"https://api.github.com/users/jfix71/repos","events_url":"https://api.github.com/users/jfix71/events{/privacy}","received_events_url":"https://api.github.com/users/jfix71/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jfix71/glow","description":"Compiler for Neural Network hardware accelerators","fork":true,"url":"https://api.github.com/repos/jfix71/glow","forks_url":"https://api.github.com/repos/jfix71/glow/forks","keys_url":"https://api.github.com/repos/jfix71/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jfix71/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jfix71/glow/teams","hooks_url":"https://api.github.com/repos/jfix71/glow/hooks","issue_events_url":"https://api.github.com/repos/jfix71/glow/issues/events{/number}","events_url":"https://api.github.com/repos/jfix71/glow/events","assignees_url":"https://api.github.com/repos/jfix71/glow/assignees{/user}","branches_url":"https://api.github.com/repos/jfix71/glow/branches{/branch}","tags_url":"https://api.github.com/repos/jfix71/glow/tags","blobs_url":"https://api.github.com/repos/jfix71/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jfix71/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jfix71/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/jfix71/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jfix71/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/jfix71/glow/languages","stargazers_url":"https://api.github.com/repos/jfix71/glow/stargazers","contributors_url":"https://api.github.com/repos/jfix71/glow/contributors","subscribers_url":"https://api.github.com/repos/jfix71/glow/subscribers","subscription_url":"https://api.github.com/repos/jfix71/glow/subscription","commits_url":"https://api.github.com/repos/jfix71/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/jfix71/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/jfix71/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/jfix71/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/jfix71/glow/contents/{+path}","compare_url":"https://api.github.com/repos/jfix71/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jfix71/glow/merges","archive_url":"https://api.github.com/repos/jfix71/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jfix71/glow/downloads","issues_url":"https://api.github.com/repos/jfix71/glow/issues{/number}","pulls_url":"https://api.github.com/repos/jfix71/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/jfix71/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/jfix71/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jfix71/glow/labels{/name}","releases_url":"https://api.github.com/repos/jfix71/glow/releases{/id}","deployments_url":"https://api.github.com/repos/jfix71/glow/deployments","created_at":"2018-06-18T21:42:26Z","updated_at":"2018-09-20T10:28:20Z","pushed_at":"2018-09-20T10:30:36Z","git_url":"git://github.com/jfix71/glow.git","ssh_url":"git@github.com:jfix71/glow.git","clone_url":"https://github.com/jfix71/glow.git","svn_url":"https://github.com/jfix71/glow","homepage":null,"size":8356,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"31131476026f83e5bae0c8e3e8fe17f43f343bfe","user":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":105281531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUyODE1MzE=","name":"glow","full_name":"pytorch/glow","private":false,"owner":{"login":"pytorch","id":21003710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDAzNzEw","avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pytorch/glow","description":"Compiler for Neural Network hardware accelerators","fork":false,"url":"https://api.github.com/repos/pytorch/glow","forks_url":"https://api.github.com/repos/pytorch/glow/forks","keys_url":"https://api.github.com/repos/pytorch/glow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/glow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/glow/teams","hooks_url":"https://api.github.com/repos/pytorch/glow/hooks","issue_events_url":"https://api.github.com/repos/pytorch/glow/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/glow/events","assignees_url":"https://api.github.com/repos/pytorch/glow/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/glow/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/glow/tags","blobs_url":"https://api.github.com/repos/pytorch/glow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/glow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/glow/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/glow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/glow/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/glow/languages","stargazers_url":"https://api.github.com/repos/pytorch/glow/stargazers","contributors_url":"https://api.github.com/repos/pytorch/glow/contributors","subscribers_url":"https://api.github.com/repos/pytorch/glow/subscribers","subscription_url":"https://api.github.com/repos/pytorch/glow/subscription","commits_url":"https://api.github.com/repos/pytorch/glow/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/glow/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/glow/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/glow/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/glow/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/glow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/glow/merges","archive_url":"https://api.github.com/repos/pytorch/glow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/glow/downloads","issues_url":"https://api.github.com/repos/pytorch/glow/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/glow/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/glow/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/glow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/glow/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/glow/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/glow/deployments","created_at":"2017-09-29T14:28:18Z","updated_at":"2018-09-20T09:33:55Z","pushed_at":"2018-09-20T10:30:38Z","git_url":"git://github.com/pytorch/glow.git","ssh_url":"git@github.com:pytorch/glow.git","clone_url":"https://github.com/pytorch/glow.git","svn_url":"https://github.com/pytorch/glow","homepage":null,"size":8312,"stargazers_count":780,"watchers_count":780,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":99,"open_issues":56,"watchers":780,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1654"},"html":{"href":"https://github.com/pytorch/glow/pull/1654"},"issue":{"href":"https://api.github.com/repos/pytorch/glow/issues/1654"},"comments":{"href":"https://api.github.com/repos/pytorch/glow/issues/1654/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1654/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/glow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/glow/pulls/1654/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/glow/statuses/506535d2ac7671ec62a8409185e587b48811b57d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jfix71"}}