{"action":"created","comment":{"url":"https://api.github.com/repos/zcash/zcash/pulls/comments/166491976","pull_request_review_id":94561973,"id":166491976,"diff_hunk":"@@ -1074,8 +1111,35 @@ bool AcceptToMemoryPool(CTxMemPool& pool, CValidationState &state, const CTransa\n         }\n     }\n \n+    // Reject Overwintered transactions which have expired\n+    if (tx.fOverwintered &&\n+        tx.nVersion == 3 &&\n+        tx.nFormatBranchId != 0 &&\n+        tx.nExpiryHeight != std::numeric_limits<uint32_t>::max())\n+    {\n+        // FIXME: Narrowing from using cast because types mismatched with expiry height as uint32, height as int","path":"src/main.cpp","position":null,"original_position":80,"commit_id":"eb4d5326e82423dfda1f618409b16a973cb3efda","original_commit_id":"c45beeee6335e210b5ec3cd1cec3e6a07bdf3674","user":{"login":"bitcartel","id":194979,"avatar_url":"https://avatars2.githubusercontent.com/u/194979?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcartel","html_url":"https://github.com/bitcartel","followers_url":"https://api.github.com/users/bitcartel/followers","following_url":"https://api.github.com/users/bitcartel/following{/other_user}","gists_url":"https://api.github.com/users/bitcartel/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcartel/subscriptions","organizations_url":"https://api.github.com/users/bitcartel/orgs","repos_url":"https://api.github.com/users/bitcartel/repos","events_url":"https://api.github.com/users/bitcartel/events{/privacy}","received_events_url":"https://api.github.com/users/bitcartel/received_events","type":"User","site_admin":false},"body":"Adding TX_EXPIRY_HEIGHT_THRESHOLD","created_at":"2018-02-07T01:01:34Z","updated_at":"2018-02-07T01:01:34Z","html_url":"https://github.com/zcash/zcash/pull/2925#discussion_r166491976","pull_request_url":"https://api.github.com/repos/zcash/zcash/pulls/2925","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments/166491976"},"html":{"href":"https://github.com/zcash/zcash/pull/2925#discussion_r166491976"},"pull_request":{"href":"https://api.github.com/repos/zcash/zcash/pulls/2925"}},"in_reply_to_id":165359844},"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/2925","id":166411167,"html_url":"https://github.com/zcash/zcash/pull/2925","diff_url":"https://github.com/zcash/zcash/pull/2925.diff","patch_url":"https://github.com/zcash/zcash/pull/2925.patch","issue_url":"https://api.github.com/repos/zcash/zcash/issues/2925","number":2925,"state":"open","locked":false,"title":"[WIP] 2906 overwinter tx format","user":{"login":"bitcartel","id":194979,"avatar_url":"https://avatars2.githubusercontent.com/u/194979?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcartel","html_url":"https://github.com/bitcartel","followers_url":"https://api.github.com/users/bitcartel/followers","following_url":"https://api.github.com/users/bitcartel/following{/other_user}","gists_url":"https://api.github.com/users/bitcartel/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcartel/subscriptions","organizations_url":"https://api.github.com/users/bitcartel/orgs","repos_url":"https://api.github.com/users/bitcartel/repos","events_url":"https://api.github.com/users/bitcartel/events{/privacy}","received_events_url":"https://api.github.com/users/bitcartel/received_events","type":"User","site_admin":false},"body":"Early feedback on this PR is needed, specifically commit https://github.com/zcash/zcash/pull/2925/commits/0e003a7bf4b44f4ccac78993b42b8faefb90fcc0. This PR depends on #2898 \r\nRelated ZIP for Overwinter transaction format is https://github.com/zcash/zips/pull/133\r\n","created_at":"2018-02-01T00:08:27Z","updated_at":"2018-02-07T01:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0a2e14541db0360d8d0e1cd9408c5e86a5d27ed","assignee":{"login":"bitcartel","id":194979,"avatar_url":"https://avatars2.githubusercontent.com/u/194979?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcartel","html_url":"https://github.com/bitcartel","followers_url":"https://api.github.com/users/bitcartel/followers","following_url":"https://api.github.com/users/bitcartel/following{/other_user}","gists_url":"https://api.github.com/users/bitcartel/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcartel/subscriptions","organizations_url":"https://api.github.com/users/bitcartel/orgs","repos_url":"https://api.github.com/users/bitcartel/repos","events_url":"https://api.github.com/users/bitcartel/events{/privacy}","received_events_url":"https://api.github.com/users/bitcartel/received_events","type":"User","site_admin":false},"assignees":[{"login":"bitcartel","id":194979,"avatar_url":"https://avatars2.githubusercontent.com/u/194979?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcartel","html_url":"https://github.com/bitcartel","followers_url":"https://api.github.com/users/bitcartel/followers","following_url":"https://api.github.com/users/bitcartel/following{/other_user}","gists_url":"https://api.github.com/users/bitcartel/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcartel/subscriptions","organizations_url":"https://api.github.com/users/bitcartel/orgs","repos_url":"https://api.github.com/users/bitcartel/repos","events_url":"https://api.github.com/users/bitcartel/events{/privacy}","received_events_url":"https://api.github.com/users/bitcartel/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"daira","id":643204,"avatar_url":"https://avatars2.githubusercontent.com/u/643204?v=4","gravatar_id":"","url":"https://api.github.com/users/daira","html_url":"https://github.com/daira","followers_url":"https://api.github.com/users/daira/followers","following_url":"https://api.github.com/users/daira/following{/other_user}","gists_url":"https://api.github.com/users/daira/gists{/gist_id}","starred_url":"https://api.github.com/users/daira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daira/subscriptions","organizations_url":"https://api.github.com/users/daira/orgs","repos_url":"https://api.github.com/users/daira/repos","events_url":"https://api.github.com/users/daira/events{/privacy}","received_events_url":"https://api.github.com/users/daira/received_events","type":"User","site_admin":false},{"login":"ebfull","id":3794471,"avatar_url":"https://avatars1.githubusercontent.com/u/3794471?v=4","gravatar_id":"","url":"https://api.github.com/users/ebfull","html_url":"https://github.com/ebfull","followers_url":"https://api.github.com/users/ebfull/followers","following_url":"https://api.github.com/users/ebfull/following{/other_user}","gists_url":"https://api.github.com/users/ebfull/gists{/gist_id}","starred_url":"https://api.github.com/users/ebfull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebfull/subscriptions","organizations_url":"https://api.github.com/users/ebfull/orgs","repos_url":"https://api.github.com/users/ebfull/repos","events_url":"https://api.github.com/users/ebfull/events{/privacy}","received_events_url":"https://api.github.com/users/ebfull/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/zcash/zcash/milestones/67","html_url":"https://github.com/zcash/zcash/milestone/67","labels_url":"https://api.github.com/repos/zcash/zcash/milestones/67/labels","id":2993514,"number":67,"title":"1.0.15","description":"","creator":{"login":"str4d","id":4993799,"avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"open_issues":48,"closed_issues":16,"state":"open","created_at":"2017-12-21T18:06:01Z","updated_at":"2018-02-05T06:55:11Z","due_on":"2018-02-12T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zcash/zcash/pulls/2925/commits","review_comments_url":"https://api.github.com/repos/zcash/zcash/pulls/2925/comments","review_comment_url":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/2925/comments","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/eb4d5326e82423dfda1f618409b16a973cb3efda","head":{"label":"bitcartel:2906_overwinter_tx_format","ref":"2906_overwinter_tx_format","sha":"eb4d5326e82423dfda1f618409b16a973cb3efda","user":{"login":"bitcartel","id":194979,"avatar_url":"https://avatars2.githubusercontent.com/u/194979?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcartel","html_url":"https://github.com/bitcartel","followers_url":"https://api.github.com/users/bitcartel/followers","following_url":"https://api.github.com/users/bitcartel/following{/other_user}","gists_url":"https://api.github.com/users/bitcartel/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcartel/subscriptions","organizations_url":"https://api.github.com/users/bitcartel/orgs","repos_url":"https://api.github.com/users/bitcartel/repos","events_url":"https://api.github.com/users/bitcartel/events{/privacy}","received_events_url":"https://api.github.com/users/bitcartel/received_events","type":"User","site_admin":false},"repo":{"id":58775418,"name":"zcash","full_name":"bitcartel/zcash","owner":{"login":"bitcartel","id":194979,"avatar_url":"https://avatars2.githubusercontent.com/u/194979?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcartel","html_url":"https://github.com/bitcartel","followers_url":"https://api.github.com/users/bitcartel/followers","following_url":"https://api.github.com/users/bitcartel/following{/other_user}","gists_url":"https://api.github.com/users/bitcartel/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcartel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcartel/subscriptions","organizations_url":"https://api.github.com/users/bitcartel/orgs","repos_url":"https://api.github.com/users/bitcartel/repos","events_url":"https://api.github.com/users/bitcartel/events{/privacy}","received_events_url":"https://api.github.com/users/bitcartel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bitcartel/zcash","description":"zcash","fork":true,"url":"https://api.github.com/repos/bitcartel/zcash","forks_url":"https://api.github.com/repos/bitcartel/zcash/forks","keys_url":"https://api.github.com/repos/bitcartel/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcartel/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcartel/zcash/teams","hooks_url":"https://api.github.com/repos/bitcartel/zcash/hooks","issue_events_url":"https://api.github.com/repos/bitcartel/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/bitcartel/zcash/events","assignees_url":"https://api.github.com/repos/bitcartel/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/bitcartel/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/bitcartel/zcash/tags","blobs_url":"https://api.github.com/repos/bitcartel/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcartel/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcartel/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcartel/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcartel/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcartel/zcash/languages","stargazers_url":"https://api.github.com/repos/bitcartel/zcash/stargazers","contributors_url":"https://api.github.com/repos/bitcartel/zcash/contributors","subscribers_url":"https://api.github.com/repos/bitcartel/zcash/subscribers","subscription_url":"https://api.github.com/repos/bitcartel/zcash/subscription","commits_url":"https://api.github.com/repos/bitcartel/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcartel/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcartel/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcartel/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcartel/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/bitcartel/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcartel/zcash/merges","archive_url":"https://api.github.com/repos/bitcartel/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcartel/zcash/downloads","issues_url":"https://api.github.com/repos/bitcartel/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/bitcartel/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcartel/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcartel/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcartel/zcash/labels{/name}","releases_url":"https://api.github.com/repos/bitcartel/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/bitcartel/zcash/deployments","created_at":"2016-05-13T22:11:54Z","updated_at":"2017-03-07T02:42:49Z","pushed_at":"2018-02-07T00:17:58Z","git_url":"git://github.com/bitcartel/zcash.git","ssh_url":"git@github.com:bitcartel/zcash.git","clone_url":"https://github.com/bitcartel/zcash.git","svn_url":"https://github.com/bitcartel/zcash","homepage":"https://z.cash/","size":48171,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":1,"default_branch":"zc.v0.11.2.latest"}},"base":{"label":"zcash:master","ref":"master","sha":"70109a74e9e25f8da9e1edb7418f4efc2c5c9843","user":{"login":"zcash","id":16122764,"avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"repo":{"id":26987049,"name":"zcash","full_name":"zcash/zcash","owner":{"login":"zcash","id":16122764,"avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zcash/zcash","description":"Zcash - Internet Money","fork":false,"url":"https://api.github.com/repos/zcash/zcash","forks_url":"https://api.github.com/repos/zcash/zcash/forks","keys_url":"https://api.github.com/repos/zcash/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcash/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcash/zcash/teams","hooks_url":"https://api.github.com/repos/zcash/zcash/hooks","issue_events_url":"https://api.github.com/repos/zcash/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/zcash/zcash/events","assignees_url":"https://api.github.com/repos/zcash/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/zcash/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/zcash/zcash/tags","blobs_url":"https://api.github.com/repos/zcash/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcash/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcash/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcash/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/zcash/zcash/languages","stargazers_url":"https://api.github.com/repos/zcash/zcash/stargazers","contributors_url":"https://api.github.com/repos/zcash/zcash/contributors","subscribers_url":"https://api.github.com/repos/zcash/zcash/subscribers","subscription_url":"https://api.github.com/repos/zcash/zcash/subscription","commits_url":"https://api.github.com/repos/zcash/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcash/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcash/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcash/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcash/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/zcash/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcash/zcash/merges","archive_url":"https://api.github.com/repos/zcash/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcash/zcash/downloads","issues_url":"https://api.github.com/repos/zcash/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/zcash/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/zcash/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/zcash/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcash/zcash/labels{/name}","releases_url":"https://api.github.com/repos/zcash/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/zcash/zcash/deployments","created_at":"2014-11-22T03:13:10Z","updated_at":"2018-02-06T18:27:08Z","pushed_at":"2018-02-07T00:18:00Z","git_url":"git://github.com/zcash/zcash.git","ssh_url":"git@github.com:zcash/zcash.git","clone_url":"https://github.com/zcash/zcash.git","svn_url":"https://github.com/zcash/zcash","homepage":"https://z.cash/","size":47260,"stargazers_count":3450,"watchers_count":3450,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":997,"mirror_url":null,"archived":false,"open_issues_count":765,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":997,"open_issues":765,"watchers":3450,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/2925"},"html":{"href":"https://github.com/zcash/zcash/pull/2925"},"issue":{"href":"https://api.github.com/repos/zcash/zcash/issues/2925"},"comments":{"href":"https://api.github.com/repos/zcash/zcash/issues/2925/comments"},"review_comments":{"href":"https://api.github.com/repos/zcash/zcash/pulls/2925/comments"},"review_comment":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcash/zcash/pulls/2925/commits"},"statuses":{"href":"https://api.github.com/repos/zcash/zcash/statuses/eb4d5326e82423dfda1f618409b16a973cb3efda"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bitcartel"}}