{"action":"created","issue":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/24217","repository_url":"https://api.github.com/repos/code-dot-org/code-dot-org","labels_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/24217/labels{/name}","comments_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/24217/comments","events_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/24217/events","html_url":"https://github.com/code-dot-org/code-dot-org/pull/24217","id":349580025,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjYyNTA0","number":24217,"title":"open a PopUpMenu when clicking version selector","user":{"login":"davidsbailey","id":8001765,"node_id":"MDQ6VXNlcjgwMDE3NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8001765?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsbailey","html_url":"https://github.com/davidsbailey","followers_url":"https://api.github.com/users/davidsbailey/followers","following_url":"https://api.github.com/users/davidsbailey/following{/other_user}","gists_url":"https://api.github.com/users/davidsbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsbailey/subscriptions","organizations_url":"https://api.github.com/users/davidsbailey/orgs","repos_url":"https://api.github.com/users/davidsbailey/repos","events_url":"https://api.github.com/users/davidsbailey/events{/privacy}","received_events_url":"https://api.github.com/users/davidsbailey/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-10T16:28:47Z","updated_at":"2018-08-10T17:46:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/pulls/24217","html_url":"https://github.com/code-dot-org/code-dot-org/pull/24217","diff_url":"https://github.com/code-dot-org/code-dot-org/pull/24217.diff","patch_url":"https://github.com/code-dot-org/code-dot-org/pull/24217.patch"},"body":"### Background\r\n\r\n* the spec shows [menu content details](https://docs.google.com/document/d/14RnmNy9QngJB8Y6mMd7IDiYrFs-_fNgr_zXklJ-MsUU/edit#heading=h.4ef837nn8mb6) \r\n* [menu in context](https://docs.google.com/document/d/14RnmNy9QngJB8Y6mMd7IDiYrFs-_fNgr_zXklJ-MsUU/edit#heading=h.r6xz9tw63znh) \r\n\r\n### Description\r\n\r\nWith `versionMenu` experiment enabled, this gets us to where we can select a version of a course in the AssignmentSelector using a new PopUpMenu. This lays the necessary groundwork for adding more complex layout as shown in the spec.\r\n\r\n### other notes\r\n\r\nFYI @epeach , it looks like the SectionActionDrowpdown (dimly visible in screenshot) does not disappear when the dialog is opened. This was initially a bigger problem for me because I had changed the zIndex of all `PopUpMenu`s to appear in front of `.modal` dialogs, but I sidestepped the problem by only applying the new, higher zIndex for the one menu I'm adding in this PR. It's possible this could be solved more generally by attaching a click handler in QuickActionsCell which closes the menu on any click on PopUpMenu. A more granular solution of closing the menu only in certain click handlers in SectionActionDropdown would probably require some refactoring because the open/closed state lives inside QuickActionsCell."},"comment":{"url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/comments/412156163","html_url":"https://github.com/code-dot-org/code-dot-org/pull/24217#issuecomment-412156163","issue_url":"https://api.github.com/repos/code-dot-org/code-dot-org/issues/24217","id":412156163,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjE1NjE2Mw==","user":{"login":"davidsbailey","id":8001765,"node_id":"MDQ6VXNlcjgwMDE3NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/8001765?v=4","gravatar_id":"","url":"https://api.github.com/users/davidsbailey","html_url":"https://github.com/davidsbailey","followers_url":"https://api.github.com/users/davidsbailey/followers","following_url":"https://api.github.com/users/davidsbailey/following{/other_user}","gists_url":"https://api.github.com/users/davidsbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/davidsbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidsbailey/subscriptions","organizations_url":"https://api.github.com/users/davidsbailey/orgs","repos_url":"https://api.github.com/users/davidsbailey/repos","events_url":"https://api.github.com/users/davidsbailey/events{/privacy}","received_events_url":"https://api.github.com/users/davidsbailey/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T17:46:45Z","updated_at":"2018-08-10T17:46:45Z","author_association":"CONTRIBUTOR","body":"Re: scrolling, the dialog and the document body behind are both capable of scrolling. Whatever their scroll position, the menu appears in the right place when it is opened, but then fails to update its position correctly when the document or dialog are scrolled while the menu is open. for example:\r\n![version-menu-scrolling](https://user-images.githubusercontent.com/8001765/43972874-ab397e68-9c8a-11e8-99fe-f1ac67759cd5.gif)\r\n"}}
{"actor":{"display_login":"davidsbailey"}}