{"action":"created","comment":{"url":"https://api.github.com/repos/ElemeFE/element/pulls/comments/209429551","pull_request_review_id":145449486,"id":209429551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQyOTU1MQ==","diff_hunk":"@@ -24,17 +84,14 @@ export default {\n       type: String,\n       default: 'bottom'\n     },\n-    boundariesPadding: {\n-      type: Number,\n-      default: 5\n-    },\n-    reference: {},\n-    popper: {},\n-    offset: {\n-      default: 0\n-    },\n+    reference: HTMLElement,","path":"src/utils/vue-popper.js","position":99,"original_position":99,"commit_id":"46284143d971b05d0ae1ebfe38dcea3167d0d6f5","original_commit_id":"46284143d971b05d0ae1ebfe38dcea3167d0d6f5","user":{"login":"yuchonghua","id":17898715,"node_id":"MDQ6VXNlcjE3ODk4NzE1","avatar_url":"https://avatars1.githubusercontent.com/u/17898715?v=4","gravatar_id":"","url":"https://api.github.com/users/yuchonghua","html_url":"https://github.com/yuchonghua","followers_url":"https://api.github.com/users/yuchonghua/followers","following_url":"https://api.github.com/users/yuchonghua/following{/other_user}","gists_url":"https://api.github.com/users/yuchonghua/gists{/gist_id}","starred_url":"https://api.github.com/users/yuchonghua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuchonghua/subscriptions","organizations_url":"https://api.github.com/users/yuchonghua/orgs","repos_url":"https://api.github.com/users/yuchonghua/repos","events_url":"https://api.github.com/users/yuchonghua/events{/privacy}","received_events_url":"https://api.github.com/users/yuchonghua/received_events","type":"User","site_admin":false},"body":"我在nuxt运行该版本的是否发现，HTMLElement直接使用会报错，因为服务器渲染不支持HTMLElement，不知道 @ziyoung 有没有更好的解决方案，不过个人有个小建议\r\n```js\r\n    reference: Vue.prototype.$isServer ? {} : HTMLElement,\r\n    popper: Vue.prototype.$isServer ? {} : HTMLElement,\r\n    boundariesElement: Vue.prototype.$isServer ? {} : [String, HTMLElement],\r\n```\r\n\r\n在服务器渲染报错如下图：\r\n![nuxt-error-HTMLElement is not defined](https://user-images.githubusercontent.com/17898715/43993306-bbdefcfa-9dbd-11e8-8e92-83e61229ccf3.jpg)","created_at":"2018-08-11T15:28:20Z","updated_at":"2018-08-11T15:28:20Z","html_url":"https://github.com/ElemeFE/element/pull/11778#discussion_r209429551","pull_request_url":"https://api.github.com/repos/ElemeFE/element/pulls/11778","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/comments/209429551"},"html":{"href":"https://github.com/ElemeFE/element/pull/11778#discussion_r209429551"},"pull_request":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/11778"}}},"pull_request":{"url":"https://api.github.com/repos/ElemeFE/element/pulls/11778","id":197912402,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3OTEyNDAy","html_url":"https://github.com/ElemeFE/element/pull/11778","diff_url":"https://github.com/ElemeFE/element/pull/11778.diff","patch_url":"https://github.com/ElemeFE/element/pull/11778.patch","issue_url":"https://api.github.com/repos/ElemeFE/element/issues/11778","number":11778,"state":"open","locked":false,"title":"Popper: update vue-popper","user":{"login":"ziyoung","id":12947422,"node_id":"MDQ6VXNlcjEyOTQ3NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/12947422?v=4","gravatar_id":"","url":"https://api.github.com/users/ziyoung","html_url":"https://github.com/ziyoung","followers_url":"https://api.github.com/users/ziyoung/followers","following_url":"https://api.github.com/users/ziyoung/following{/other_user}","gists_url":"https://api.github.com/users/ziyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/ziyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziyoung/subscriptions","organizations_url":"https://api.github.com/users/ziyoung/orgs","repos_url":"https://api.github.com/users/ziyoung/repos","events_url":"https://api.github.com/users/ziyoung/events{/privacy}","received_events_url":"https://api.github.com/users/ziyoung/received_events","type":"User","site_admin":false},"body":"- 更新了 popper.js，把 popper.js 添加为项目依赖\r\n- 修改了 Vue-popper 的实现\r\n- 统一了 vue-popper 的用法\r\n","created_at":"2018-06-28T04:10:47Z","updated_at":"2018-08-11T15:28:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56238d44f47190144e26df3a22974ebd1b022cc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/ElemeFE/element/milestones/6","html_url":"https://github.com/ElemeFE/element/milestone/6","labels_url":"https://api.github.com/repos/ElemeFE/element/milestones/6/labels","id":3490526,"node_id":"MDk6TWlsZXN0b25lMzQ5MDUyNg==","number":6,"title":"3.0","description":null,"creator":{"login":"jikkai","id":14025786,"node_id":"MDQ6VXNlcjE0MDI1Nzg2","avatar_url":"https://avatars0.githubusercontent.com/u/14025786?v=4","gravatar_id":"","url":"https://api.github.com/users/jikkai","html_url":"https://github.com/jikkai","followers_url":"https://api.github.com/users/jikkai/followers","following_url":"https://api.github.com/users/jikkai/following{/other_user}","gists_url":"https://api.github.com/users/jikkai/gists{/gist_id}","starred_url":"https://api.github.com/users/jikkai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jikkai/subscriptions","organizations_url":"https://api.github.com/users/jikkai/orgs","repos_url":"https://api.github.com/users/jikkai/repos","events_url":"https://api.github.com/users/jikkai/events{/privacy}","received_events_url":"https://api.github.com/users/jikkai/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":4,"state":"open","created_at":"2018-07-12T07:02:26Z","updated_at":"2018-08-09T09:45:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ElemeFE/element/pulls/11778/commits","review_comments_url":"https://api.github.com/repos/ElemeFE/element/pulls/11778/comments","review_comment_url":"https://api.github.com/repos/ElemeFE/element/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ElemeFE/element/issues/11778/comments","statuses_url":"https://api.github.com/repos/ElemeFE/element/statuses/46284143d971b05d0ae1ebfe38dcea3167d0d6f5","head":{"label":"ziyoung:vue-popper","ref":"vue-popper","sha":"46284143d971b05d0ae1ebfe38dcea3167d0d6f5","user":{"login":"ziyoung","id":12947422,"node_id":"MDQ6VXNlcjEyOTQ3NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/12947422?v=4","gravatar_id":"","url":"https://api.github.com/users/ziyoung","html_url":"https://github.com/ziyoung","followers_url":"https://api.github.com/users/ziyoung/followers","following_url":"https://api.github.com/users/ziyoung/following{/other_user}","gists_url":"https://api.github.com/users/ziyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/ziyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziyoung/subscriptions","organizations_url":"https://api.github.com/users/ziyoung/orgs","repos_url":"https://api.github.com/users/ziyoung/repos","events_url":"https://api.github.com/users/ziyoung/events{/privacy}","received_events_url":"https://api.github.com/users/ziyoung/received_events","type":"User","site_admin":false},"repo":{"id":132563705,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI1NjM3MDU=","name":"element","full_name":"ziyoung/element","owner":{"login":"ziyoung","id":12947422,"node_id":"MDQ6VXNlcjEyOTQ3NDIy","avatar_url":"https://avatars1.githubusercontent.com/u/12947422?v=4","gravatar_id":"","url":"https://api.github.com/users/ziyoung","html_url":"https://github.com/ziyoung","followers_url":"https://api.github.com/users/ziyoung/followers","following_url":"https://api.github.com/users/ziyoung/following{/other_user}","gists_url":"https://api.github.com/users/ziyoung/gists{/gist_id}","starred_url":"https://api.github.com/users/ziyoung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ziyoung/subscriptions","organizations_url":"https://api.github.com/users/ziyoung/orgs","repos_url":"https://api.github.com/users/ziyoung/repos","events_url":"https://api.github.com/users/ziyoung/events{/privacy}","received_events_url":"https://api.github.com/users/ziyoung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ziyoung/element","description":"A Vue.js 2.0 UI Toolkit for Web","fork":true,"url":"https://api.github.com/repos/ziyoung/element","forks_url":"https://api.github.com/repos/ziyoung/element/forks","keys_url":"https://api.github.com/repos/ziyoung/element/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ziyoung/element/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ziyoung/element/teams","hooks_url":"https://api.github.com/repos/ziyoung/element/hooks","issue_events_url":"https://api.github.com/repos/ziyoung/element/issues/events{/number}","events_url":"https://api.github.com/repos/ziyoung/element/events","assignees_url":"https://api.github.com/repos/ziyoung/element/assignees{/user}","branches_url":"https://api.github.com/repos/ziyoung/element/branches{/branch}","tags_url":"https://api.github.com/repos/ziyoung/element/tags","blobs_url":"https://api.github.com/repos/ziyoung/element/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ziyoung/element/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ziyoung/element/git/refs{/sha}","trees_url":"https://api.github.com/repos/ziyoung/element/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ziyoung/element/statuses/{sha}","languages_url":"https://api.github.com/repos/ziyoung/element/languages","stargazers_url":"https://api.github.com/repos/ziyoung/element/stargazers","contributors_url":"https://api.github.com/repos/ziyoung/element/contributors","subscribers_url":"https://api.github.com/repos/ziyoung/element/subscribers","subscription_url":"https://api.github.com/repos/ziyoung/element/subscription","commits_url":"https://api.github.com/repos/ziyoung/element/commits{/sha}","git_commits_url":"https://api.github.com/repos/ziyoung/element/git/commits{/sha}","comments_url":"https://api.github.com/repos/ziyoung/element/comments{/number}","issue_comment_url":"https://api.github.com/repos/ziyoung/element/issues/comments{/number}","contents_url":"https://api.github.com/repos/ziyoung/element/contents/{+path}","compare_url":"https://api.github.com/repos/ziyoung/element/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ziyoung/element/merges","archive_url":"https://api.github.com/repos/ziyoung/element/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ziyoung/element/downloads","issues_url":"https://api.github.com/repos/ziyoung/element/issues{/number}","pulls_url":"https://api.github.com/repos/ziyoung/element/pulls{/number}","milestones_url":"https://api.github.com/repos/ziyoung/element/milestones{/number}","notifications_url":"https://api.github.com/repos/ziyoung/element/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ziyoung/element/labels{/name}","releases_url":"https://api.github.com/repos/ziyoung/element/releases{/id}","deployments_url":"https://api.github.com/repos/ziyoung/element/deployments","created_at":"2018-05-08T06:22:42Z","updated_at":"2018-08-10T08:55:01Z","pushed_at":"2018-08-11T11:56:07Z","git_url":"git://github.com/ziyoung/element.git","ssh_url":"git@github.com:ziyoung/element.git","clone_url":"https://github.com/ziyoung/element.git","svn_url":"https://github.com/ziyoung/element","homepage":"http://element.eleme.io/","size":43198,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"ElemeFE:next","ref":"next","sha":"0d63af516683bc06ff6095ce6e8ed8f4616f02be","user":{"login":"ElemeFE","id":12810740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODEwNzQw","avatar_url":"https://avatars1.githubusercontent.com/u/12810740?v=4","gravatar_id":"","url":"https://api.github.com/users/ElemeFE","html_url":"https://github.com/ElemeFE","followers_url":"https://api.github.com/users/ElemeFE/followers","following_url":"https://api.github.com/users/ElemeFE/following{/other_user}","gists_url":"https://api.github.com/users/ElemeFE/gists{/gist_id}","starred_url":"https://api.github.com/users/ElemeFE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElemeFE/subscriptions","organizations_url":"https://api.github.com/users/ElemeFE/orgs","repos_url":"https://api.github.com/users/ElemeFE/repos","events_url":"https://api.github.com/users/ElemeFE/events{/privacy}","received_events_url":"https://api.github.com/users/ElemeFE/received_events","type":"Organization","site_admin":false},"repo":{"id":67274736,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3NDczNg==","name":"element","full_name":"ElemeFE/element","owner":{"login":"ElemeFE","id":12810740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODEwNzQw","avatar_url":"https://avatars1.githubusercontent.com/u/12810740?v=4","gravatar_id":"","url":"https://api.github.com/users/ElemeFE","html_url":"https://github.com/ElemeFE","followers_url":"https://api.github.com/users/ElemeFE/followers","following_url":"https://api.github.com/users/ElemeFE/following{/other_user}","gists_url":"https://api.github.com/users/ElemeFE/gists{/gist_id}","starred_url":"https://api.github.com/users/ElemeFE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElemeFE/subscriptions","organizations_url":"https://api.github.com/users/ElemeFE/orgs","repos_url":"https://api.github.com/users/ElemeFE/repos","events_url":"https://api.github.com/users/ElemeFE/events{/privacy}","received_events_url":"https://api.github.com/users/ElemeFE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ElemeFE/element","description":"A Vue.js 2.0 UI Toolkit for Web","fork":false,"url":"https://api.github.com/repos/ElemeFE/element","forks_url":"https://api.github.com/repos/ElemeFE/element/forks","keys_url":"https://api.github.com/repos/ElemeFE/element/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ElemeFE/element/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ElemeFE/element/teams","hooks_url":"https://api.github.com/repos/ElemeFE/element/hooks","issue_events_url":"https://api.github.com/repos/ElemeFE/element/issues/events{/number}","events_url":"https://api.github.com/repos/ElemeFE/element/events","assignees_url":"https://api.github.com/repos/ElemeFE/element/assignees{/user}","branches_url":"https://api.github.com/repos/ElemeFE/element/branches{/branch}","tags_url":"https://api.github.com/repos/ElemeFE/element/tags","blobs_url":"https://api.github.com/repos/ElemeFE/element/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ElemeFE/element/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ElemeFE/element/git/refs{/sha}","trees_url":"https://api.github.com/repos/ElemeFE/element/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ElemeFE/element/statuses/{sha}","languages_url":"https://api.github.com/repos/ElemeFE/element/languages","stargazers_url":"https://api.github.com/repos/ElemeFE/element/stargazers","contributors_url":"https://api.github.com/repos/ElemeFE/element/contributors","subscribers_url":"https://api.github.com/repos/ElemeFE/element/subscribers","subscription_url":"https://api.github.com/repos/ElemeFE/element/subscription","commits_url":"https://api.github.com/repos/ElemeFE/element/commits{/sha}","git_commits_url":"https://api.github.com/repos/ElemeFE/element/git/commits{/sha}","comments_url":"https://api.github.com/repos/ElemeFE/element/comments{/number}","issue_comment_url":"https://api.github.com/repos/ElemeFE/element/issues/comments{/number}","contents_url":"https://api.github.com/repos/ElemeFE/element/contents/{+path}","compare_url":"https://api.github.com/repos/ElemeFE/element/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ElemeFE/element/merges","archive_url":"https://api.github.com/repos/ElemeFE/element/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ElemeFE/element/downloads","issues_url":"https://api.github.com/repos/ElemeFE/element/issues{/number}","pulls_url":"https://api.github.com/repos/ElemeFE/element/pulls{/number}","milestones_url":"https://api.github.com/repos/ElemeFE/element/milestones{/number}","notifications_url":"https://api.github.com/repos/ElemeFE/element/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ElemeFE/element/labels{/name}","releases_url":"https://api.github.com/repos/ElemeFE/element/releases{/id}","deployments_url":"https://api.github.com/repos/ElemeFE/element/deployments","created_at":"2016-09-03T06:19:26Z","updated_at":"2018-08-11T15:24:14Z","pushed_at":"2018-08-11T14:11:35Z","git_url":"git://github.com/ElemeFE/element.git","ssh_url":"git@github.com:ElemeFE/element.git","clone_url":"https://github.com/ElemeFE/element.git","svn_url":"https://github.com/ElemeFE/element","homepage":"https://element.eleme.io/","size":48473,"stargazers_count":29690,"watchers_count":29690,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5733,"mirror_url":null,"archived":false,"open_issues_count":384,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5733,"open_issues":384,"watchers":29690,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/11778"},"html":{"href":"https://github.com/ElemeFE/element/pull/11778"},"issue":{"href":"https://api.github.com/repos/ElemeFE/element/issues/11778"},"comments":{"href":"https://api.github.com/repos/ElemeFE/element/issues/11778/comments"},"review_comments":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/11778/comments"},"review_comment":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ElemeFE/element/pulls/11778/commits"},"statuses":{"href":"https://api.github.com/repos/ElemeFE/element/statuses/46284143d971b05d0ae1ebfe38dcea3167d0d6f5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yuchonghua"}}