{"action":"created","comment":{"url":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/comments/210838340","pull_request_review_id":147137047,"id":210838340,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDgzODM0MA==","diff_hunk":"@@ -116,6 +116,6 @@ type DummyOSORegistrationApp struct {\n \tErr    error\n }\n \n-func (regApp *DummyOSORegistrationApp) LoadOSOSubscriptionStatus(ctx context.Context, config login.Configuration, keycloakToken oauth2.Token) (string, error) {\n+func (regApp *DummyOSORegistrationApp) LoadOSOSubscriptionStatus(ctx context.Context, config login.Configuration, OAuth2Token oauth2.Token) (string, error) {","path":"test/login.go","position":5,"original_position":5,"commit_id":"c7c7707f8a79696308bec0685643eaae6f10b8dc","original_commit_id":"c7c7707f8a79696308bec0685643eaae6f10b8dc","user":{"login":"xcoulon","id":178502,"node_id":"MDQ6VXNlcjE3ODUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/178502?v=4","gravatar_id":"","url":"https://api.github.com/users/xcoulon","html_url":"https://github.com/xcoulon","followers_url":"https://api.github.com/users/xcoulon/followers","following_url":"https://api.github.com/users/xcoulon/following{/other_user}","gists_url":"https://api.github.com/users/xcoulon/gists{/gist_id}","starred_url":"https://api.github.com/users/xcoulon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xcoulon/subscriptions","organizations_url":"https://api.github.com/users/xcoulon/orgs","repos_url":"https://api.github.com/users/xcoulon/repos","events_url":"https://api.github.com/users/xcoulon/events{/privacy}","received_events_url":"https://api.github.com/users/xcoulon/received_events","type":"User","site_admin":false},"body":"this variable's name should start with a lowercase (ie, `oauth2Token`), or even just `t`, as short names are usually preferred","created_at":"2018-08-17T08:25:46Z","updated_at":"2018-08-17T08:39:23Z","html_url":"https://github.com/fabric8-services/fabric8-auth/pull/594#discussion_r210838340","pull_request_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/594","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/comments/210838340"},"html":{"href":"https://github.com/fabric8-services/fabric8-auth/pull/594#discussion_r210838340"},"pull_request":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/594"}}},"pull_request":{"url":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/594","id":207384916,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Mzg0OTE2","html_url":"https://github.com/fabric8-services/fabric8-auth/pull/594","diff_url":"https://github.com/fabric8-services/fabric8-auth/pull/594.diff","patch_url":"https://github.com/fabric8-services/fabric8-auth/pull/594.patch","issue_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/issues/594","number":594,"state":"open","locked":false,"title":"refactor: renames all keycloak providers/tokens/services.","user":{"login":"hemanik","id":8680543,"node_id":"MDQ6VXNlcjg2ODA1NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8680543?v=4","gravatar_id":"","url":"https://api.github.com/users/hemanik","html_url":"https://github.com/hemanik","followers_url":"https://api.github.com/users/hemanik/followers","following_url":"https://api.github.com/users/hemanik/following{/other_user}","gists_url":"https://api.github.com/users/hemanik/gists{/gist_id}","starred_url":"https://api.github.com/users/hemanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemanik/subscriptions","organizations_url":"https://api.github.com/users/hemanik/orgs","repos_url":"https://api.github.com/users/hemanik/repos","events_url":"https://api.github.com/users/hemanik/events{/privacy}","received_events_url":"https://api.github.com/users/hemanik/received_events","type":"User","site_admin":false},"body":"This PR renames all references to Keycloak providers/tokens/services to make it more generic and move towards decoupling with Keycloak for the login process. \r\n\r\nFixes: #583 ","created_at":"2018-08-09T17:13:25Z","updated_at":"2018-08-17T08:39:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c27ef3593d8de95e4ddacdd5eeef19bc5c8cca3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/594/commits","review_comments_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/594/comments","review_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/issues/594/comments","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/statuses/c7c7707f8a79696308bec0685643eaae6f10b8dc","head":{"label":"hemanik:ISSUE-583","ref":"ISSUE-583","sha":"c7c7707f8a79696308bec0685643eaae6f10b8dc","user":{"login":"hemanik","id":8680543,"node_id":"MDQ6VXNlcjg2ODA1NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8680543?v=4","gravatar_id":"","url":"https://api.github.com/users/hemanik","html_url":"https://github.com/hemanik","followers_url":"https://api.github.com/users/hemanik/followers","following_url":"https://api.github.com/users/hemanik/following{/other_user}","gists_url":"https://api.github.com/users/hemanik/gists{/gist_id}","starred_url":"https://api.github.com/users/hemanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemanik/subscriptions","organizations_url":"https://api.github.com/users/hemanik/orgs","repos_url":"https://api.github.com/users/hemanik/repos","events_url":"https://api.github.com/users/hemanik/events{/privacy}","received_events_url":"https://api.github.com/users/hemanik/received_events","type":"User","site_admin":false},"repo":{"id":139672738,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2NzI3Mzg=","name":"fabric8-auth","full_name":"hemanik/fabric8-auth","owner":{"login":"hemanik","id":8680543,"node_id":"MDQ6VXNlcjg2ODA1NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/8680543?v=4","gravatar_id":"","url":"https://api.github.com/users/hemanik","html_url":"https://github.com/hemanik","followers_url":"https://api.github.com/users/hemanik/followers","following_url":"https://api.github.com/users/hemanik/following{/other_user}","gists_url":"https://api.github.com/users/hemanik/gists{/gist_id}","starred_url":"https://api.github.com/users/hemanik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hemanik/subscriptions","organizations_url":"https://api.github.com/users/hemanik/orgs","repos_url":"https://api.github.com/users/hemanik/repos","events_url":"https://api.github.com/users/hemanik/events{/privacy}","received_events_url":"https://api.github.com/users/hemanik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hemanik/fabric8-auth","description":"Identity and Access Management for fabric8 services","fork":true,"url":"https://api.github.com/repos/hemanik/fabric8-auth","forks_url":"https://api.github.com/repos/hemanik/fabric8-auth/forks","keys_url":"https://api.github.com/repos/hemanik/fabric8-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hemanik/fabric8-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hemanik/fabric8-auth/teams","hooks_url":"https://api.github.com/repos/hemanik/fabric8-auth/hooks","issue_events_url":"https://api.github.com/repos/hemanik/fabric8-auth/issues/events{/number}","events_url":"https://api.github.com/repos/hemanik/fabric8-auth/events","assignees_url":"https://api.github.com/repos/hemanik/fabric8-auth/assignees{/user}","branches_url":"https://api.github.com/repos/hemanik/fabric8-auth/branches{/branch}","tags_url":"https://api.github.com/repos/hemanik/fabric8-auth/tags","blobs_url":"https://api.github.com/repos/hemanik/fabric8-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hemanik/fabric8-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hemanik/fabric8-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/hemanik/fabric8-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hemanik/fabric8-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/hemanik/fabric8-auth/languages","stargazers_url":"https://api.github.com/repos/hemanik/fabric8-auth/stargazers","contributors_url":"https://api.github.com/repos/hemanik/fabric8-auth/contributors","subscribers_url":"https://api.github.com/repos/hemanik/fabric8-auth/subscribers","subscription_url":"https://api.github.com/repos/hemanik/fabric8-auth/subscription","commits_url":"https://api.github.com/repos/hemanik/fabric8-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/hemanik/fabric8-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/hemanik/fabric8-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/hemanik/fabric8-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/hemanik/fabric8-auth/contents/{+path}","compare_url":"https://api.github.com/repos/hemanik/fabric8-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hemanik/fabric8-auth/merges","archive_url":"https://api.github.com/repos/hemanik/fabric8-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hemanik/fabric8-auth/downloads","issues_url":"https://api.github.com/repos/hemanik/fabric8-auth/issues{/number}","pulls_url":"https://api.github.com/repos/hemanik/fabric8-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/hemanik/fabric8-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/hemanik/fabric8-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hemanik/fabric8-auth/labels{/name}","releases_url":"https://api.github.com/repos/hemanik/fabric8-auth/releases{/id}","deployments_url":"https://api.github.com/repos/hemanik/fabric8-auth/deployments","created_at":"2018-07-04T05:32:46Z","updated_at":"2018-07-04T05:32:49Z","pushed_at":"2018-08-16T09:09:54Z","git_url":"git://github.com/hemanik/fabric8-auth.git","ssh_url":"git@github.com:hemanik/fabric8-auth.git","clone_url":"https://github.com/hemanik/fabric8-auth.git","svn_url":"https://github.com/hemanik/fabric8-auth","homepage":"https://auth.openshift.io/api/status","size":6877,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fabric8-services:master","ref":"master","sha":"9d855d80053b54776839a5316c6c609500dc072d","user":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"repo":{"id":96831576,"node_id":"MDEwOlJlcG9zaXRvcnk5NjgzMTU3Ng==","name":"fabric8-auth","full_name":"fabric8-services/fabric8-auth","owner":{"login":"fabric8-services","id":29751612,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzUxNjEy","avatar_url":"https://avatars1.githubusercontent.com/u/29751612?v=4","gravatar_id":"","url":"https://api.github.com/users/fabric8-services","html_url":"https://github.com/fabric8-services","followers_url":"https://api.github.com/users/fabric8-services/followers","following_url":"https://api.github.com/users/fabric8-services/following{/other_user}","gists_url":"https://api.github.com/users/fabric8-services/gists{/gist_id}","starred_url":"https://api.github.com/users/fabric8-services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabric8-services/subscriptions","organizations_url":"https://api.github.com/users/fabric8-services/orgs","repos_url":"https://api.github.com/users/fabric8-services/repos","events_url":"https://api.github.com/users/fabric8-services/events{/privacy}","received_events_url":"https://api.github.com/users/fabric8-services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fabric8-services/fabric8-auth","description":"Identity and Access Management for fabric8 services","fork":false,"url":"https://api.github.com/repos/fabric8-services/fabric8-auth","forks_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/forks","keys_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/teams","hooks_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/hooks","issue_events_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/issues/events{/number}","events_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/events","assignees_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/assignees{/user}","branches_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/branches{/branch}","tags_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/tags","blobs_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/statuses/{sha}","languages_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/languages","stargazers_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/stargazers","contributors_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/contributors","subscribers_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/subscribers","subscription_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/subscription","commits_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/contents/{+path}","compare_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/merges","archive_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/downloads","issues_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/issues{/number}","pulls_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls{/number}","milestones_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/milestones{/number}","notifications_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/labels{/name}","releases_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/releases{/id}","deployments_url":"https://api.github.com/repos/fabric8-services/fabric8-auth/deployments","created_at":"2017-07-10T23:57:55Z","updated_at":"2018-08-10T07:20:04Z","pushed_at":"2018-08-17T06:46:29Z","git_url":"git://github.com/fabric8-services/fabric8-auth.git","ssh_url":"git@github.com:fabric8-services/fabric8-auth.git","clone_url":"https://github.com/fabric8-services/fabric8-auth.git","svn_url":"https://github.com/fabric8-services/fabric8-auth","homepage":"https://auth.openshift.io/api/status","size":6807,"stargazers_count":7,"watchers_count":7,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":64,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/594"},"html":{"href":"https://github.com/fabric8-services/fabric8-auth/pull/594"},"issue":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/issues/594"},"comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/fabric8-services/fabric8-auth/statuses/c7c7707f8a79696308bec0685643eaae6f10b8dc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"xcoulon"}}