{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/209180137","pull_request_review_id":145143730,"id":209180137,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTE4MDEzNw==","diff_hunk":"@@ -661,7 +661,7 @@ module rec Bad : A = Bad;;\n [%%expect{|\n module type Alias = sig module N : sig  end module M = N end\n module F : functor (X : sig  end) -> sig type t end\n-Line 1:\n+Characters -1--1:","path":"testsuite/tests/typing-modules/aliases.ml","position":5,"original_position":5,"commit_id":"3aca99dcde298cac969280b04a37108aae03c8c5","original_commit_id":"3aca99dcde298cac969280b04a37108aae03c8c5","user":{"login":"Armael","id":315125,"node_id":"MDQ6VXNlcjMxNTEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/315125?v=4","gravatar_id":"","url":"https://api.github.com/users/Armael","html_url":"https://github.com/Armael","followers_url":"https://api.github.com/users/Armael/followers","following_url":"https://api.github.com/users/Armael/following{/other_user}","gists_url":"https://api.github.com/users/Armael/gists{/gist_id}","starred_url":"https://api.github.com/users/Armael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armael/subscriptions","organizations_url":"https://api.github.com/users/Armael/orgs","repos_url":"https://api.github.com/users/Armael/repos","events_url":"https://api.github.com/users/Armael/events{/privacy}","received_events_url":"https://api.github.com/users/Armael/received_events","type":"User","site_admin":false},"body":"I would argue it is not. The `Line 1` here was nonsensical and unrelated to the actual location of the error; it is the result of a dummy location leaking out. A dummy location is now printed as `Characters -1--1`, which I think is slightly better because it makes it clear that it is a dummy location.\r\nI don't think it is worth trying to improve this situation printing time: the proper fix should instead be to not emit dummy locations in places where actual locations are expected. ","created_at":"2018-08-10T08:12:55Z","updated_at":"2018-08-10T08:12:55Z","html_url":"https://github.com/ocaml/ocaml/pull/1981#discussion_r209180137","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1981","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/209180137"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1981#discussion_r209180137"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1981"}},"in_reply_to_id":209171561},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/1981","id":207406772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDA2Nzcy","html_url":"https://github.com/ocaml/ocaml/pull/1981","diff_url":"https://github.com/ocaml/ocaml/pull/1981.diff","patch_url":"https://github.com/ocaml/ocaml/pull/1981.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/1981","number":1981,"state":"open","locked":false,"title":"Fix spurious \"line 1\" in displayed locations","user":{"login":"Armael","id":315125,"node_id":"MDQ6VXNlcjMxNTEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/315125?v=4","gravatar_id":"","url":"https://api.github.com/users/Armael","html_url":"https://github.com/Armael","followers_url":"https://api.github.com/users/Armael/followers","following_url":"https://api.github.com/users/Armael/following{/other_user}","gists_url":"https://api.github.com/users/Armael/gists{/gist_id}","starred_url":"https://api.github.com/users/Armael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armael/subscriptions","organizations_url":"https://api.github.com/users/Armael/orgs","repos_url":"https://api.github.com/users/Armael/repos","events_url":"https://api.github.com/users/Armael/events{/privacy}","received_events_url":"https://api.github.com/users/Armael/received_events","type":"User","site_admin":false},"body":"The goal of this PR is to fix the spurious \"line 1\" that would sometimes appear in printed locations.\r\n\r\nThe reason for this is that dummy locations (as produced by `Location.none` and `Location.in_file`) did specify dummy character positions, but a valid line number (1). This PR changes the code to use `dummy_pos` directly (which has 0 as a dummy line number).","created_at":"2018-08-09T18:39:44Z","updated_at":"2018-08-10T08:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"467d94e9e58519659ef2871df44da9999d2827ea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":489423308,"node_id":"MDU6TGFiZWw0ODk0MjMzMDg=","url":"https://api.github.com/repos/ocaml/ocaml/labels/no-change-entry-needed","name":"no-change-entry-needed","color":"FFFFFF","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1981/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/1981/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/1981/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/3aca99dcde298cac969280b04a37108aae03c8c5","head":{"label":"Armael:loc-line","ref":"loc-line","sha":"3aca99dcde298cac969280b04a37108aae03c8c5","user":{"login":"Armael","id":315125,"node_id":"MDQ6VXNlcjMxNTEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/315125?v=4","gravatar_id":"","url":"https://api.github.com/users/Armael","html_url":"https://github.com/Armael","followers_url":"https://api.github.com/users/Armael/followers","following_url":"https://api.github.com/users/Armael/following{/other_user}","gists_url":"https://api.github.com/users/Armael/gists{/gist_id}","starred_url":"https://api.github.com/users/Armael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armael/subscriptions","organizations_url":"https://api.github.com/users/Armael/orgs","repos_url":"https://api.github.com/users/Armael/repos","events_url":"https://api.github.com/users/Armael/events{/privacy}","received_events_url":"https://api.github.com/users/Armael/received_events","type":"User","site_admin":false},"repo":{"id":74139961,"node_id":"MDEwOlJlcG9zaXRvcnk3NDEzOTk2MQ==","name":"ocaml","full_name":"Armael/ocaml","owner":{"login":"Armael","id":315125,"node_id":"MDQ6VXNlcjMxNTEyNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/315125?v=4","gravatar_id":"","url":"https://api.github.com/users/Armael","html_url":"https://github.com/Armael","followers_url":"https://api.github.com/users/Armael/followers","following_url":"https://api.github.com/users/Armael/following{/other_user}","gists_url":"https://api.github.com/users/Armael/gists{/gist_id}","starred_url":"https://api.github.com/users/Armael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armael/subscriptions","organizations_url":"https://api.github.com/users/Armael/orgs","repos_url":"https://api.github.com/users/Armael/repos","events_url":"https://api.github.com/users/Armael/events{/privacy}","received_events_url":"https://api.github.com/users/Armael/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Armael/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":true,"url":"https://api.github.com/repos/Armael/ocaml","forks_url":"https://api.github.com/repos/Armael/ocaml/forks","keys_url":"https://api.github.com/repos/Armael/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Armael/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Armael/ocaml/teams","hooks_url":"https://api.github.com/repos/Armael/ocaml/hooks","issue_events_url":"https://api.github.com/repos/Armael/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/Armael/ocaml/events","assignees_url":"https://api.github.com/repos/Armael/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/Armael/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/Armael/ocaml/tags","blobs_url":"https://api.github.com/repos/Armael/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Armael/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Armael/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/Armael/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Armael/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/Armael/ocaml/languages","stargazers_url":"https://api.github.com/repos/Armael/ocaml/stargazers","contributors_url":"https://api.github.com/repos/Armael/ocaml/contributors","subscribers_url":"https://api.github.com/repos/Armael/ocaml/subscribers","subscription_url":"https://api.github.com/repos/Armael/ocaml/subscription","commits_url":"https://api.github.com/repos/Armael/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/Armael/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/Armael/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/Armael/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/Armael/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/Armael/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Armael/ocaml/merges","archive_url":"https://api.github.com/repos/Armael/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Armael/ocaml/downloads","issues_url":"https://api.github.com/repos/Armael/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/Armael/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/Armael/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/Armael/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Armael/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/Armael/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/Armael/ocaml/deployments","created_at":"2016-11-18T15:07:30Z","updated_at":"2016-11-18T15:07:39Z","pushed_at":"2018-08-09T18:36:18Z","git_url":"git://github.com/Armael/ocaml.git","ssh_url":"git@github.com:Armael/ocaml.git","clone_url":"https://github.com/Armael/ocaml.git","svn_url":"https://github.com/Armael/ocaml","homepage":"","size":169950,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"7b44242b62a2d4a55df398c44abb3a138fc94084","user":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzg2MTY2","name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NDE0ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/1841483?v=4","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","deployments_url":"https://api.github.com/repos/ocaml/ocaml/deployments","created_at":"2012-11-20T22:18:22Z","updated_at":"2018-08-10T05:09:27Z","pushed_at":"2018-08-10T04:51:44Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":175644,"stargazers_count":1927,"watchers_count":1927,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":477,"mirror_url":null,"archived":false,"open_issues_count":177,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":477,"open_issues":177,"watchers":1927,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1981"},"html":{"href":"https://github.com/ocaml/ocaml/pull/1981"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1981"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/1981/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1981/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/1981/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/3aca99dcde298cac969280b04a37108aae03c8c5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Armael"}}