{"action":"created","issue":{"url":"https://api.github.com/repos/breese/trial.protocol/issues/19","repository_url":"https://api.github.com/repos/breese/trial.protocol","labels_url":"https://api.github.com/repos/breese/trial.protocol/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/breese/trial.protocol/issues/19/comments","events_url":"https://api.github.com/repos/breese/trial.protocol/issues/19/events","html_url":"https://github.com/breese/trial.protocol/issues/19","id":295679967,"number":19,"title":"obj.erase(it) fails on map","user":{"login":"vinipsmaker2","id":25609657,"avatar_url":"https://avatars0.githubusercontent.com/u/25609657?v=4","gravatar_id":"","url":"https://api.github.com/users/vinipsmaker2","html_url":"https://github.com/vinipsmaker2","followers_url":"https://api.github.com/users/vinipsmaker2/followers","following_url":"https://api.github.com/users/vinipsmaker2/following{/other_user}","gists_url":"https://api.github.com/users/vinipsmaker2/gists{/gist_id}","starred_url":"https://api.github.com/users/vinipsmaker2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vinipsmaker2/subscriptions","organizations_url":"https://api.github.com/users/vinipsmaker2/orgs","repos_url":"https://api.github.com/users/vinipsmaker2/repos","events_url":"https://api.github.com/users/vinipsmaker2/events{/privacy}","received_events_url":"https://api.github.com/users/vinipsmaker2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-02-08T21:57:31Z","updated_at":"2018-02-10T17:11:19Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Tested on commit cea147e0523a13c39a9d4b10a76e7d927a2397d6, but looking at the source code from latest develop, I think it should be failing too. I can write an isolated case to test it on `develop` later.\r\n\r\nCompiler is clang. Error is:\r\n\r\n```\r\napplication.cpp:36:9: error: no matching member function for call to 'erase'\r\n    obj.erase(it);\r\n    ~~~~^~~~~\r\n3rd/trial.protocol/include/trial/dynamic/variable.hpp:869:14: note: candidate function not viable: no known conversion\r\n      from 'trial::dynamic::basic_variable<std::allocator>::key_iterator' to 'trial::dynamic::basic_variable<std::allocator>::const_iterator' for 1st argument\r\n    iterator erase(const_iterator position);\r\n             ^\r\n```\r\n\r\nAlso, finally I am coding the part where performance is not the critical and I can do whole parses and get the convenience of `dynamic::variable` on my code 🎉🎉🎉."},"comment":{"url":"https://api.github.com/repos/breese/trial.protocol/issues/comments/364672712","html_url":"https://github.com/breese/trial.protocol/issues/19#issuecomment-364672712","issue_url":"https://api.github.com/repos/breese/trial.protocol/issues/19","id":364672712,"user":{"login":"breese","id":241540,"avatar_url":"https://avatars1.githubusercontent.com/u/241540?v=4","gravatar_id":"","url":"https://api.github.com/users/breese","html_url":"https://github.com/breese","followers_url":"https://api.github.com/users/breese/followers","following_url":"https://api.github.com/users/breese/following{/other_user}","gists_url":"https://api.github.com/users/breese/gists{/gist_id}","starred_url":"https://api.github.com/users/breese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/breese/subscriptions","organizations_url":"https://api.github.com/users/breese/orgs","repos_url":"https://api.github.com/users/breese/repos","events_url":"https://api.github.com/users/breese/events{/privacy}","received_events_url":"https://api.github.com/users/breese/received_events","type":"User","site_admin":false},"created_at":"2018-02-10T17:11:19Z","updated_at":"2018-02-10T17:11:19Z","author_association":"OWNER","body":"I have added a `key_iterator::base()` function to convert a key_iterator into a const_iterator in db775c48ad3624b7570f9bbd4512bed6ae238c27, so now `v.erase(kit.base())` is doable.\r\n\r\nRegarding the `key_erase()` function, I would rather have such functionality as algorithms, e.g. like the `dynamic::key::count()` and `dynamic::key::find()` algorithms, to prevent a proliferation of the `variable` interface."}}
{"actor":{"display_login":"breese"}}