{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/196138884","pull_request_review_id":129635794,"id":196138884,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjEzODg4NA==","diff_hunk":"@@ -53,12 +55,42 @@ function add_new_tab($className, $name, $id_parent, $returnId = false, $parentTa\n \t\t');\n     }\n \n-    Db::getInstance()->execute('INSERT IGNORE INTO `'._DB_PREFIX_.'access` (`id_profile`, `id_tab`, `view`, `add`, `edit`, `delete`)\n+    if (version_compare(_PS_VERSION_, '1.7.0.0', '<')) {","path":"install-dev/upgrade/php/add_new_tab.php","position":null,"original_position":14,"commit_id":"14ac402e29b78f8c18a194931db83342cbc525d0","original_commit_id":"47cf1f514be97b02a0d562a44c3c7599a2ba8dfa","user":{"login":"Quetzacoalt91","id":6768917,"node_id":"MDQ6VXNlcjY3Njg5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6768917?v=4","gravatar_id":"","url":"https://api.github.com/users/Quetzacoalt91","html_url":"https://github.com/Quetzacoalt91","followers_url":"https://api.github.com/users/Quetzacoalt91/followers","following_url":"https://api.github.com/users/Quetzacoalt91/following{/other_user}","gists_url":"https://api.github.com/users/Quetzacoalt91/gists{/gist_id}","starred_url":"https://api.github.com/users/Quetzacoalt91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quetzacoalt91/subscriptions","organizations_url":"https://api.github.com/users/Quetzacoalt91/orgs","repos_url":"https://api.github.com/users/Quetzacoalt91/repos","events_url":"https://api.github.com/users/Quetzacoalt91/events{/privacy}","received_events_url":"https://api.github.com/users/Quetzacoalt91/received_events","type":"User","site_admin":false},"body":"You never know from where you start the upgrade. `PS_VERSION` is not updated at each upgrade file. :wink: ","created_at":"2018-06-18T16:16:21Z","updated_at":"2018-06-18T16:16:21Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9194#discussion_r196138884","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9194","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/196138884"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/9194#discussion_r196138884"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9194"}},"in_reply_to_id":196120972},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9194","id":195480932,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDgwOTMy","html_url":"https://github.com/PrestaShop/PrestaShop/pull/9194","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/9194.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/9194.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9194","number":9194,"state":"open","locked":false,"title":"Handle 1.7 method in update function 'add_new_tab'","user":{"login":"Quetzacoalt91","id":6768917,"node_id":"MDQ6VXNlcjY3Njg5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6768917?v=4","gravatar_id":"","url":"https://api.github.com/users/Quetzacoalt91","html_url":"https://github.com/Quetzacoalt91","followers_url":"https://api.github.com/users/Quetzacoalt91/followers","following_url":"https://api.github.com/users/Quetzacoalt91/following{/other_user}","gists_url":"https://api.github.com/users/Quetzacoalt91/gists{/gist_id}","starred_url":"https://api.github.com/users/Quetzacoalt91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quetzacoalt91/subscriptions","organizations_url":"https://api.github.com/users/Quetzacoalt91/orgs","repos_url":"https://api.github.com/users/Quetzacoalt91/repos","events_url":"https://api.github.com/users/Quetzacoalt91/events{/privacy}","received_events_url":"https://api.github.com/users/Quetzacoalt91/received_events","type":"User","site_admin":false},"body":"| Questions     | Answers\r\n| ------------- | -------------------------------------------------------\r\n| Branch?       | 1.7.4.x\r\n| Description?  | While running a specific upgrade script, it appeared the access system was not adapted for 1.7 versions. The upgrade method has been updated to prevent merchants to loose access to the module pages with the new tabs.\r\n| Type?         | bug fix\r\n| Category?     | BO\r\n| BC breaks?    | Nope\r\n| Deprecations? | Nope\r\n| Fixed ticket? | /\r\n| How to test?  | From PrestaShop 1.7.3.3, start an upgrade to 1.7.4.0 or launch the following code on a database from version older than 1.7.4.0.\r\n\r\nYou can use the following code, for instance in `index.php` after `require(dirname(__FILE__).'/config/config.inc.php');`\r\n```php\r\nrequire_once(__DIR__.'/install-dev/upgrade/php/ps_1740_update_module_tabs.php');\r\nps_1740_update_module_tabs();\r\ndie('ok');\r\n```\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/prestashop/prestashop/9194)\n<!-- Reviewable:end -->\n","created_at":"2018-06-18T10:24:47Z","updated_at":"2018-06-18T16:16:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0f33eea287eeaa77ad3f9bb9189bdf2987734f6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":925512081,"node_id":"MDU6TGFiZWw5MjU1MTIwODE=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/1.7.4.x","name":"1.7.4.x","color":"6270ea","default":false},{"id":330551716,"node_id":"MDU6TGFiZWwzMzA1NTE3MTY=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/waiting%20for%20QA%20feedback","name":"waiting for QA feedback","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones/34","html_url":"https://github.com/PrestaShop/PrestaShop/milestone/34","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones/34/labels","id":2810726,"node_id":"MDk6TWlsZXN0b25lMjgxMDcyNg==","number":34,"title":"1.7.4.0","description":null,"creator":{"login":"eternoendless","id":1009343,"node_id":"MDQ6VXNlcjEwMDkzNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1009343?v=4","gravatar_id":"","url":"https://api.github.com/users/eternoendless","html_url":"https://github.com/eternoendless","followers_url":"https://api.github.com/users/eternoendless/followers","following_url":"https://api.github.com/users/eternoendless/following{/other_user}","gists_url":"https://api.github.com/users/eternoendless/gists{/gist_id}","starred_url":"https://api.github.com/users/eternoendless/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eternoendless/subscriptions","organizations_url":"https://api.github.com/users/eternoendless/orgs","repos_url":"https://api.github.com/users/eternoendless/repos","events_url":"https://api.github.com/users/eternoendless/events{/privacy}","received_events_url":"https://api.github.com/users/eternoendless/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":245,"state":"open","created_at":"2017-10-03T14:54:58Z","updated_at":"2018-06-18T16:03:42Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9194/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9194/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9194/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/14ac402e29b78f8c18a194931db83342cbc525d0","head":{"label":"Quetzacoalt91:fix-new-tab-1.7","ref":"fix-new-tab-1.7","sha":"14ac402e29b78f8c18a194931db83342cbc525d0","user":{"login":"Quetzacoalt91","id":6768917,"node_id":"MDQ6VXNlcjY3Njg5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6768917?v=4","gravatar_id":"","url":"https://api.github.com/users/Quetzacoalt91","html_url":"https://github.com/Quetzacoalt91","followers_url":"https://api.github.com/users/Quetzacoalt91/followers","following_url":"https://api.github.com/users/Quetzacoalt91/following{/other_user}","gists_url":"https://api.github.com/users/Quetzacoalt91/gists{/gist_id}","starred_url":"https://api.github.com/users/Quetzacoalt91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quetzacoalt91/subscriptions","organizations_url":"https://api.github.com/users/Quetzacoalt91/orgs","repos_url":"https://api.github.com/users/Quetzacoalt91/repos","events_url":"https://api.github.com/users/Quetzacoalt91/events{/privacy}","received_events_url":"https://api.github.com/users/Quetzacoalt91/received_events","type":"User","site_admin":false},"repo":{"id":34853736,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg1MzczNg==","name":"PrestaShop","full_name":"Quetzacoalt91/PrestaShop","owner":{"login":"Quetzacoalt91","id":6768917,"node_id":"MDQ6VXNlcjY3Njg5MTc=","avatar_url":"https://avatars0.githubusercontent.com/u/6768917?v=4","gravatar_id":"","url":"https://api.github.com/users/Quetzacoalt91","html_url":"https://github.com/Quetzacoalt91","followers_url":"https://api.github.com/users/Quetzacoalt91/followers","following_url":"https://api.github.com/users/Quetzacoalt91/following{/other_user}","gists_url":"https://api.github.com/users/Quetzacoalt91/gists{/gist_id}","starred_url":"https://api.github.com/users/Quetzacoalt91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Quetzacoalt91/subscriptions","organizations_url":"https://api.github.com/users/Quetzacoalt91/orgs","repos_url":"https://api.github.com/users/Quetzacoalt91/repos","events_url":"https://api.github.com/users/Quetzacoalt91/events{/privacy}","received_events_url":"https://api.github.com/users/Quetzacoalt91/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Quetzacoalt91/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop","forks_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/forks","keys_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/teams","hooks_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/events","assignees_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/tags","blobs_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/subscription","commits_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/merges","archive_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/downloads","issues_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/Quetzacoalt91/PrestaShop/deployments","created_at":"2015-04-30T12:40:13Z","updated_at":"2016-05-18T15:15:04Z","pushed_at":"2018-06-18T16:14:52Z","git_url":"git://github.com/Quetzacoalt91/PrestaShop.git","ssh_url":"git@github.com:Quetzacoalt91/PrestaShop.git","clone_url":"https://github.com/Quetzacoalt91/PrestaShop.git","svn_url":"https://github.com/Quetzacoalt91/PrestaShop","homepage":"http://www.prestashop.com/","size":327138,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":1,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"PrestaShop:1.7.4.x","ref":"1.7.4.x","sha":"92d9606343ede54b4f8668ec6669e1003bf4c4fb","user":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"node_id":"MDEwOlJlcG9zaXRvcnk2NzYzNTg3","name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTU2OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/2815696?v=4","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open Source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","deployments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/deployments","created_at":"2012-11-19T16:41:31Z","updated_at":"2018-06-18T08:04:58Z","pushed_at":"2018-06-18T16:15:00Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":342131,"stargazers_count":3058,"watchers_count":3058,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2783,"mirror_url":null,"archived":false,"open_issues_count":348,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2783,"open_issues":348,"watchers":3058,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9194"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/9194"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9194"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/9194/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9194/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/9194/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/14ac402e29b78f8c18a194931db83342cbc525d0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Quetzacoalt91"}}