{"action":"created","issue":{"url":"https://api.github.com/repos/cloudflare/zlib/issues/6","repository_url":"https://api.github.com/repos/cloudflare/zlib","labels_url":"https://api.github.com/repos/cloudflare/zlib/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/cloudflare/zlib/issues/6/comments","events_url":"https://api.github.com/repos/cloudflare/zlib/issues/6/events","html_url":"https://github.com/cloudflare/zlib/pull/6","id":231635239,"number":6,"title":"Mac and compatibility fixes","user":{"login":"RJVB","id":1756884,"avatar_url":"https://avatars0.githubusercontent.com/u/1756884?v=4","gravatar_id":"","url":"https://api.github.com/users/RJVB","html_url":"https://github.com/RJVB","followers_url":"https://api.github.com/users/RJVB/followers","following_url":"https://api.github.com/users/RJVB/following{/other_user}","gists_url":"https://api.github.com/users/RJVB/gists{/gist_id}","starred_url":"https://api.github.com/users/RJVB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJVB/subscriptions","organizations_url":"https://api.github.com/users/RJVB/orgs","repos_url":"https://api.github.com/users/RJVB/repos","events_url":"https://api.github.com/users/RJVB/events{/privacy}","received_events_url":"https://api.github.com/users/RJVB/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-05-26T14:01:23Z","updated_at":"2018-05-22T09:38:28Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/cloudflare/zlib/pulls/6","html_url":"https://github.com/cloudflare/zlib/pull/6","diff_url":"https://github.com/cloudflare/zlib/pull/6.diff","patch_url":"https://github.com/cloudflare/zlib/pull/6.patch"},"body":"These are my current fixes for getting zlib/CloudFlare to build on Mac *and* work as a real drop-in replacement:\r\n\r\n- build with clang\r\n- fix the crc32_pclmul assembly so it builds on Mac (NB: it will crash in 32bit mode, PCLMUL support has to be disabled some way!)\r\n- revert a change to the uInt and uLong types which broke building Qt and were probably dangerous anyway (several functions receive pointers to these types, and dependent software is not guaranteed to use the typedefs from zlib)."},"comment":{"url":"https://api.github.com/repos/cloudflare/zlib/issues/comments/390928133","html_url":"https://github.com/cloudflare/zlib/pull/6#issuecomment-390928133","issue_url":"https://api.github.com/repos/cloudflare/zlib/issues/6","id":390928133,"user":{"login":"RJVB","id":1756884,"avatar_url":"https://avatars0.githubusercontent.com/u/1756884?v=4","gravatar_id":"","url":"https://api.github.com/users/RJVB","html_url":"https://github.com/RJVB","followers_url":"https://api.github.com/users/RJVB/followers","following_url":"https://api.github.com/users/RJVB/following{/other_user}","gists_url":"https://api.github.com/users/RJVB/gists{/gist_id}","starred_url":"https://api.github.com/users/RJVB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJVB/subscriptions","organizations_url":"https://api.github.com/users/RJVB/orgs","repos_url":"https://api.github.com/users/RJVB/repos","events_url":"https://api.github.com/users/RJVB/events{/privacy}","received_events_url":"https://api.github.com/users/RJVB/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T09:38:28Z","updated_at":"2018-05-22T09:38:28Z","author_association":"NONE","body":"I'll need to find some time to get back to this, but don't hesitate to do a PR of your own. The speed-up is impressive indeed, but you can get an almost identical speed-up from zlib-ng which is based on \"zlib current\", not on an older version...\n\nLast time I looked at sizeof(unsigned int) I concluded that it should be 32bit on all 32bit and wider architectures (in standard C at least). I admit I didn't consider 16bit architectures, but are those still relevant for this project?\n\n> #ifndef uint32_t \n\nThat's almost guaranteed not to work universally (= on systems that typedef uint32_t instead of #defining it).\n\n"}}
{"actor":{"display_login":"RJVB"}}