{"action":"created","comment":{"url":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/comments/210637191","pull_request_review_id":146894125,"id":210637191,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDYzNzE5MQ==","diff_hunk":"@@ -104,15 +104,27 @@ export const buyProduct = (sku) => Platform.select({\n   android: () => RNIapModule.buyItemByType(ANDROID_ITEM_TYPE_IAP, sku, null)\n })();\n \n+/**\n+ * Buy a product with a specified quantity (iOS only)\n+ *   Call finishTransaction after receipt validation process.\n+ * @param {string} sku The product's sku/ID\n+ * @param {number} quantity The amount of product to buy\n+ * @returns {Promise<ProductPurchase>}\n+ */\n+export const buyProductWithQuantity = (sku, quantity) => Platform.select({\n+  ios: () => RNIapIos.buyProductWithQuantity(sku, quantity),\n+  android: () => RNIapModule.buyItemByType(ANDROID_ITEM_TYPE_IAP, sku, null)","path":"index.js","position":13,"original_position":13,"commit_id":"678fabdb5a1ae8fd032c56a63d230f8643c89cc4","original_commit_id":"678fabdb5a1ae8fd032c56a63d230f8643c89cc4","user":{"login":"dooboolab","id":27461460,"node_id":"MDQ6VXNlcjI3NDYxNDYw","avatar_url":"https://avatars0.githubusercontent.com/u/27461460?v=4","gravatar_id":"","url":"https://api.github.com/users/dooboolab","html_url":"https://github.com/dooboolab","followers_url":"https://api.github.com/users/dooboolab/followers","following_url":"https://api.github.com/users/dooboolab/following{/other_user}","gists_url":"https://api.github.com/users/dooboolab/gists{/gist_id}","starred_url":"https://api.github.com/users/dooboolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooboolab/subscriptions","organizations_url":"https://api.github.com/users/dooboolab/orgs","repos_url":"https://api.github.com/users/dooboolab/repos","events_url":"https://api.github.com/users/dooboolab/events{/privacy}","received_events_url":"https://api.github.com/users/dooboolab/received_events","type":"User","site_admin":false},"body":"I think it would be better to just resolve in `android`.\r\n```\r\n() => Promise.resolve(),\r\n```\r\n\r\nJust make above method only `ios` dependent. Naming it as `buyProductWithQuantityIOS` will be better too.","created_at":"2018-08-16T15:17:03Z","updated_at":"2018-08-16T15:17:03Z","html_url":"https://github.com/dooboolab/react-native-iap/pull/240#discussion_r210637191","pull_request_url":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/240","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/comments/210637191"},"html":{"href":"https://github.com/dooboolab/react-native-iap/pull/240#discussion_r210637191"},"pull_request":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/240"}}},"pull_request":{"url":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/240","id":208846788,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4ODQ2Nzg4","html_url":"https://github.com/dooboolab/react-native-iap/pull/240","diff_url":"https://github.com/dooboolab/react-native-iap/pull/240.diff","patch_url":"https://github.com/dooboolab/react-native-iap/pull/240.patch","issue_url":"https://api.github.com/repos/dooboolab/react-native-iap/issues/240","number":240,"state":"open","locked":false,"title":"Add buyWithQuantity iOS function","user":{"login":"lefoy","id":2258085,"node_id":"MDQ6VXNlcjIyNTgwODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2258085?v=4","gravatar_id":"","url":"https://api.github.com/users/lefoy","html_url":"https://github.com/lefoy","followers_url":"https://api.github.com/users/lefoy/followers","following_url":"https://api.github.com/users/lefoy/following{/other_user}","gists_url":"https://api.github.com/users/lefoy/gists{/gist_id}","starred_url":"https://api.github.com/users/lefoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefoy/subscriptions","organizations_url":"https://api.github.com/users/lefoy/orgs","repos_url":"https://api.github.com/users/lefoy/repos","events_url":"https://api.github.com/users/lefoy/events{/privacy}","received_events_url":"https://api.github.com/users/lefoy/received_events","type":"User","site_admin":false},"body":"This PR add the buyWithQuantity iOS only function. I also added an optional parameter to the buyProductWithoutFinishTransaction since it's already iOS only.","created_at":"2018-08-16T12:44:46Z","updated_at":"2018-08-16T15:17:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90fd9a5fc460234e8971174ce33ec81f50d54cc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/240/commits","review_comments_url":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/240/comments","review_comment_url":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dooboolab/react-native-iap/issues/240/comments","statuses_url":"https://api.github.com/repos/dooboolab/react-native-iap/statuses/678fabdb5a1ae8fd032c56a63d230f8643c89cc4","head":{"label":"exposio:feature/buyWithQuantity","ref":"feature/buyWithQuantity","sha":"678fabdb5a1ae8fd032c56a63d230f8643c89cc4","user":{"login":"exposio","id":29754096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzU0MDk2","avatar_url":"https://avatars2.githubusercontent.com/u/29754096?v=4","gravatar_id":"","url":"https://api.github.com/users/exposio","html_url":"https://github.com/exposio","followers_url":"https://api.github.com/users/exposio/followers","following_url":"https://api.github.com/users/exposio/following{/other_user}","gists_url":"https://api.github.com/users/exposio/gists{/gist_id}","starred_url":"https://api.github.com/users/exposio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exposio/subscriptions","organizations_url":"https://api.github.com/users/exposio/orgs","repos_url":"https://api.github.com/users/exposio/repos","events_url":"https://api.github.com/users/exposio/events{/privacy}","received_events_url":"https://api.github.com/users/exposio/received_events","type":"Organization","site_admin":false},"repo":{"id":144728478,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3Mjg0Nzg=","name":"react-native-iap","full_name":"exposio/react-native-iap","owner":{"login":"exposio","id":29754096,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NzU0MDk2","avatar_url":"https://avatars2.githubusercontent.com/u/29754096?v=4","gravatar_id":"","url":"https://api.github.com/users/exposio","html_url":"https://github.com/exposio","followers_url":"https://api.github.com/users/exposio/followers","following_url":"https://api.github.com/users/exposio/following{/other_user}","gists_url":"https://api.github.com/users/exposio/gists{/gist_id}","starred_url":"https://api.github.com/users/exposio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exposio/subscriptions","organizations_url":"https://api.github.com/users/exposio/orgs","repos_url":"https://api.github.com/users/exposio/repos","events_url":"https://api.github.com/users/exposio/events{/privacy}","received_events_url":"https://api.github.com/users/exposio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exposio/react-native-iap","description":"react native in app purchase module.","fork":true,"url":"https://api.github.com/repos/exposio/react-native-iap","forks_url":"https://api.github.com/repos/exposio/react-native-iap/forks","keys_url":"https://api.github.com/repos/exposio/react-native-iap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exposio/react-native-iap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exposio/react-native-iap/teams","hooks_url":"https://api.github.com/repos/exposio/react-native-iap/hooks","issue_events_url":"https://api.github.com/repos/exposio/react-native-iap/issues/events{/number}","events_url":"https://api.github.com/repos/exposio/react-native-iap/events","assignees_url":"https://api.github.com/repos/exposio/react-native-iap/assignees{/user}","branches_url":"https://api.github.com/repos/exposio/react-native-iap/branches{/branch}","tags_url":"https://api.github.com/repos/exposio/react-native-iap/tags","blobs_url":"https://api.github.com/repos/exposio/react-native-iap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exposio/react-native-iap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exposio/react-native-iap/git/refs{/sha}","trees_url":"https://api.github.com/repos/exposio/react-native-iap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exposio/react-native-iap/statuses/{sha}","languages_url":"https://api.github.com/repos/exposio/react-native-iap/languages","stargazers_url":"https://api.github.com/repos/exposio/react-native-iap/stargazers","contributors_url":"https://api.github.com/repos/exposio/react-native-iap/contributors","subscribers_url":"https://api.github.com/repos/exposio/react-native-iap/subscribers","subscription_url":"https://api.github.com/repos/exposio/react-native-iap/subscription","commits_url":"https://api.github.com/repos/exposio/react-native-iap/commits{/sha}","git_commits_url":"https://api.github.com/repos/exposio/react-native-iap/git/commits{/sha}","comments_url":"https://api.github.com/repos/exposio/react-native-iap/comments{/number}","issue_comment_url":"https://api.github.com/repos/exposio/react-native-iap/issues/comments{/number}","contents_url":"https://api.github.com/repos/exposio/react-native-iap/contents/{+path}","compare_url":"https://api.github.com/repos/exposio/react-native-iap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exposio/react-native-iap/merges","archive_url":"https://api.github.com/repos/exposio/react-native-iap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exposio/react-native-iap/downloads","issues_url":"https://api.github.com/repos/exposio/react-native-iap/issues{/number}","pulls_url":"https://api.github.com/repos/exposio/react-native-iap/pulls{/number}","milestones_url":"https://api.github.com/repos/exposio/react-native-iap/milestones{/number}","notifications_url":"https://api.github.com/repos/exposio/react-native-iap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exposio/react-native-iap/labels{/name}","releases_url":"https://api.github.com/repos/exposio/react-native-iap/releases{/id}","deployments_url":"https://api.github.com/repos/exposio/react-native-iap/deployments","created_at":"2018-08-14T14:03:24Z","updated_at":"2018-08-14T14:03:26Z","pushed_at":"2018-08-16T12:41:33Z","git_url":"git://github.com/exposio/react-native-iap.git","ssh_url":"git@github.com:exposio/react-native-iap.git","clone_url":"https://github.com/exposio/react-native-iap.git","svn_url":"https://github.com/exposio/react-native-iap","homepage":null,"size":733,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dooboolab:master","ref":"master","sha":"36b045ed95750c9ff68c3d99b5da57f0ff356b74","user":{"login":"dooboolab","id":27461460,"node_id":"MDQ6VXNlcjI3NDYxNDYw","avatar_url":"https://avatars0.githubusercontent.com/u/27461460?v=4","gravatar_id":"","url":"https://api.github.com/users/dooboolab","html_url":"https://github.com/dooboolab","followers_url":"https://api.github.com/users/dooboolab/followers","following_url":"https://api.github.com/users/dooboolab/following{/other_user}","gists_url":"https://api.github.com/users/dooboolab/gists{/gist_id}","starred_url":"https://api.github.com/users/dooboolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooboolab/subscriptions","organizations_url":"https://api.github.com/users/dooboolab/orgs","repos_url":"https://api.github.com/users/dooboolab/repos","events_url":"https://api.github.com/users/dooboolab/events{/privacy}","received_events_url":"https://api.github.com/users/dooboolab/received_events","type":"User","site_admin":false},"repo":{"id":107826162,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc4MjYxNjI=","name":"react-native-iap","full_name":"dooboolab/react-native-iap","owner":{"login":"dooboolab","id":27461460,"node_id":"MDQ6VXNlcjI3NDYxNDYw","avatar_url":"https://avatars0.githubusercontent.com/u/27461460?v=4","gravatar_id":"","url":"https://api.github.com/users/dooboolab","html_url":"https://github.com/dooboolab","followers_url":"https://api.github.com/users/dooboolab/followers","following_url":"https://api.github.com/users/dooboolab/following{/other_user}","gists_url":"https://api.github.com/users/dooboolab/gists{/gist_id}","starred_url":"https://api.github.com/users/dooboolab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dooboolab/subscriptions","organizations_url":"https://api.github.com/users/dooboolab/orgs","repos_url":"https://api.github.com/users/dooboolab/repos","events_url":"https://api.github.com/users/dooboolab/events{/privacy}","received_events_url":"https://api.github.com/users/dooboolab/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dooboolab/react-native-iap","description":"react native in app purchase module.","fork":false,"url":"https://api.github.com/repos/dooboolab/react-native-iap","forks_url":"https://api.github.com/repos/dooboolab/react-native-iap/forks","keys_url":"https://api.github.com/repos/dooboolab/react-native-iap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dooboolab/react-native-iap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dooboolab/react-native-iap/teams","hooks_url":"https://api.github.com/repos/dooboolab/react-native-iap/hooks","issue_events_url":"https://api.github.com/repos/dooboolab/react-native-iap/issues/events{/number}","events_url":"https://api.github.com/repos/dooboolab/react-native-iap/events","assignees_url":"https://api.github.com/repos/dooboolab/react-native-iap/assignees{/user}","branches_url":"https://api.github.com/repos/dooboolab/react-native-iap/branches{/branch}","tags_url":"https://api.github.com/repos/dooboolab/react-native-iap/tags","blobs_url":"https://api.github.com/repos/dooboolab/react-native-iap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dooboolab/react-native-iap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dooboolab/react-native-iap/git/refs{/sha}","trees_url":"https://api.github.com/repos/dooboolab/react-native-iap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dooboolab/react-native-iap/statuses/{sha}","languages_url":"https://api.github.com/repos/dooboolab/react-native-iap/languages","stargazers_url":"https://api.github.com/repos/dooboolab/react-native-iap/stargazers","contributors_url":"https://api.github.com/repos/dooboolab/react-native-iap/contributors","subscribers_url":"https://api.github.com/repos/dooboolab/react-native-iap/subscribers","subscription_url":"https://api.github.com/repos/dooboolab/react-native-iap/subscription","commits_url":"https://api.github.com/repos/dooboolab/react-native-iap/commits{/sha}","git_commits_url":"https://api.github.com/repos/dooboolab/react-native-iap/git/commits{/sha}","comments_url":"https://api.github.com/repos/dooboolab/react-native-iap/comments{/number}","issue_comment_url":"https://api.github.com/repos/dooboolab/react-native-iap/issues/comments{/number}","contents_url":"https://api.github.com/repos/dooboolab/react-native-iap/contents/{+path}","compare_url":"https://api.github.com/repos/dooboolab/react-native-iap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dooboolab/react-native-iap/merges","archive_url":"https://api.github.com/repos/dooboolab/react-native-iap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dooboolab/react-native-iap/downloads","issues_url":"https://api.github.com/repos/dooboolab/react-native-iap/issues{/number}","pulls_url":"https://api.github.com/repos/dooboolab/react-native-iap/pulls{/number}","milestones_url":"https://api.github.com/repos/dooboolab/react-native-iap/milestones{/number}","notifications_url":"https://api.github.com/repos/dooboolab/react-native-iap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dooboolab/react-native-iap/labels{/name}","releases_url":"https://api.github.com/repos/dooboolab/react-native-iap/releases{/id}","deployments_url":"https://api.github.com/repos/dooboolab/react-native-iap/deployments","created_at":"2017-10-22T00:31:20Z","updated_at":"2018-08-16T09:16:58Z","pushed_at":"2018-08-16T12:44:47Z","git_url":"git://github.com/dooboolab/react-native-iap.git","ssh_url":"git@github.com:dooboolab/react-native-iap.git","clone_url":"https://github.com/dooboolab/react-native-iap.git","svn_url":"https://github.com/dooboolab/react-native-iap","homepage":null,"size":726,"stargazers_count":310,"watchers_count":310,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":45,"open_issues":17,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/240"},"html":{"href":"https://github.com/dooboolab/react-native-iap/pull/240"},"issue":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/issues/240"},"comments":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/issues/240/comments"},"review_comments":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/240/comments"},"review_comment":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/pulls/240/commits"},"statuses":{"href":"https://api.github.com/repos/dooboolab/react-native-iap/statuses/678fabdb5a1ae8fd032c56a63d230f8643c89cc4"}},"author_association":"NONE"}}
{"actor":{"display_login":"dooboolab"}}