{"action":"opened","number":319,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls/319","id":168861967,"html_url":"https://github.com/ManageIQ/manageiq-api/pull/319","diff_url":"https://github.com/ManageIQ/manageiq-api/pull/319.diff","patch_url":"https://github.com/ManageIQ/manageiq-api/pull/319.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-api/issues/319","number":319,"state":"open","locked":false,"title":"Do not return hrefs for objects without a collection","user":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars2.githubusercontent.com/u/2433314?v=4","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"body":"When expanding \"service_resources\" on \"service_templates\", an invalid href is returned for the service resources. The href being returned is \"/api/service_templates/<service_resource_id>\", which is a nonexistent resource. This is due to always returning the `reftype` instead of a nil, which then allows the normalizer to believe it can generate an href for it. There is no collection for service resources, therefore no href should be present.\r\n\r\ncc: @bzwei ","created_at":"2018-02-13T14:41:28Z","updated_at":"2018-02-13T14:41:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":663822610,"url":"https://api.github.com/repos/ManageIQ/manageiq-api/labels/bug","name":"bug","color":"ee0701","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls/319/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls/319/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-api/issues/319/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-api/statuses/3016d98ef727dc7b0d647743bb64a59fbd586368","head":{"label":"jntullo:no_href","ref":"no_href","sha":"3016d98ef727dc7b0d647743bb64a59fbd586368","user":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars2.githubusercontent.com/u/2433314?v=4","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"repo":{"id":112510340,"name":"manageiq-api","full_name":"jntullo/manageiq-api","owner":{"login":"jntullo","id":2433314,"avatar_url":"https://avatars2.githubusercontent.com/u/2433314?v=4","gravatar_id":"","url":"https://api.github.com/users/jntullo","html_url":"https://github.com/jntullo","followers_url":"https://api.github.com/users/jntullo/followers","following_url":"https://api.github.com/users/jntullo/following{/other_user}","gists_url":"https://api.github.com/users/jntullo/gists{/gist_id}","starred_url":"https://api.github.com/users/jntullo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jntullo/subscriptions","organizations_url":"https://api.github.com/users/jntullo/orgs","repos_url":"https://api.github.com/users/jntullo/repos","events_url":"https://api.github.com/users/jntullo/events{/privacy}","received_events_url":"https://api.github.com/users/jntullo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jntullo/manageiq-api","description":"ManageIQ API","fork":true,"url":"https://api.github.com/repos/jntullo/manageiq-api","forks_url":"https://api.github.com/repos/jntullo/manageiq-api/forks","keys_url":"https://api.github.com/repos/jntullo/manageiq-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jntullo/manageiq-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jntullo/manageiq-api/teams","hooks_url":"https://api.github.com/repos/jntullo/manageiq-api/hooks","issue_events_url":"https://api.github.com/repos/jntullo/manageiq-api/issues/events{/number}","events_url":"https://api.github.com/repos/jntullo/manageiq-api/events","assignees_url":"https://api.github.com/repos/jntullo/manageiq-api/assignees{/user}","branches_url":"https://api.github.com/repos/jntullo/manageiq-api/branches{/branch}","tags_url":"https://api.github.com/repos/jntullo/manageiq-api/tags","blobs_url":"https://api.github.com/repos/jntullo/manageiq-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jntullo/manageiq-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jntullo/manageiq-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/jntullo/manageiq-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jntullo/manageiq-api/statuses/{sha}","languages_url":"https://api.github.com/repos/jntullo/manageiq-api/languages","stargazers_url":"https://api.github.com/repos/jntullo/manageiq-api/stargazers","contributors_url":"https://api.github.com/repos/jntullo/manageiq-api/contributors","subscribers_url":"https://api.github.com/repos/jntullo/manageiq-api/subscribers","subscription_url":"https://api.github.com/repos/jntullo/manageiq-api/subscription","commits_url":"https://api.github.com/repos/jntullo/manageiq-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/jntullo/manageiq-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/jntullo/manageiq-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/jntullo/manageiq-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/jntullo/manageiq-api/contents/{+path}","compare_url":"https://api.github.com/repos/jntullo/manageiq-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jntullo/manageiq-api/merges","archive_url":"https://api.github.com/repos/jntullo/manageiq-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jntullo/manageiq-api/downloads","issues_url":"https://api.github.com/repos/jntullo/manageiq-api/issues{/number}","pulls_url":"https://api.github.com/repos/jntullo/manageiq-api/pulls{/number}","milestones_url":"https://api.github.com/repos/jntullo/manageiq-api/milestones{/number}","notifications_url":"https://api.github.com/repos/jntullo/manageiq-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jntullo/manageiq-api/labels{/name}","releases_url":"https://api.github.com/repos/jntullo/manageiq-api/releases{/id}","deployments_url":"https://api.github.com/repos/jntullo/manageiq-api/deployments","created_at":"2017-11-29T18:08:13Z","updated_at":"2017-11-29T18:08:15Z","pushed_at":"2018-02-13T14:38:59Z","git_url":"git://github.com/jntullo/manageiq-api.git","ssh_url":"git@github.com:jntullo/manageiq-api.git","clone_url":"https://github.com/jntullo/manageiq-api.git","svn_url":"https://github.com/jntullo/manageiq-api","homepage":null,"size":3607,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"077c0361cc6ea0c8780928c29dad665b7c4afba9","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":99615440,"name":"manageiq-api","full_name":"ManageIQ/manageiq-api","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-api","description":"ManageIQ API","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-api","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-api/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-api/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-api/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-api/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-api/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-api/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-api/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-api/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-api/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-api/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-api/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-api/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-api/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-api/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-api/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-api/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-api/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-api/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-api/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-api/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-api/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-api/deployments","created_at":"2017-08-07T20:05:29Z","updated_at":"2018-02-06T19:44:30Z","pushed_at":"2018-02-13T13:08:19Z","git_url":"git://github.com/ManageIQ/manageiq-api.git","ssh_url":"git@github.com:ManageIQ/manageiq-api.git","clone_url":"https://github.com/ManageIQ/manageiq-api.git","svn_url":"https://github.com/ManageIQ/manageiq-api","homepage":null,"size":3572,"stargazers_count":5,"watchers_count":5,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":62,"open_issues":41,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls/319"},"html":{"href":"https://github.com/ManageIQ/manageiq-api/pull/319"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api/issues/319"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-api/statuses/3016d98ef727dc7b0d647743bb64a59fbd586368"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":13,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"jntullo"}}