{"action":"created","comment":{"url":"https://api.github.com/repos/billyquith/GWork/pulls/comments/202518270","pull_request_review_id":137241473,"id":202518270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjUxODI3MA==","diff_hunk":"@@ -111,6 +112,8 @@ namespace Gwk\n \n             std::unordered_map<Font, ALFontData> m_fonts;\n             std::unordered_map<Texture, ALTextureData> m_textures;\n+            std::pair<const Font, ALFontData>* m_lastFont;","path":"source/platform/include/Gwork/Renderers/Allegro5.h","position":29,"original_position":12,"commit_id":"6a017cddde55def3b22f748db4f39f10a2eb3e26","original_commit_id":"f920ad2c39ce5c807a3c18ac35600eaa92f050ef","user":{"login":"topblast","id":4210885,"node_id":"MDQ6VXNlcjQyMTA4ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/4210885?v=4","gravatar_id":"","url":"https://api.github.com/users/topblast","html_url":"https://github.com/topblast","followers_url":"https://api.github.com/users/topblast/followers","following_url":"https://api.github.com/users/topblast/following{/other_user}","gists_url":"https://api.github.com/users/topblast/gists{/gist_id}","starred_url":"https://api.github.com/users/topblast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topblast/subscriptions","organizations_url":"https://api.github.com/users/topblast/orgs","repos_url":"https://api.github.com/users/topblast/repos","events_url":"https://api.github.com/users/topblast/events{/privacy}","received_events_url":"https://api.github.com/users/topblast/received_events","type":"User","site_admin":false},"body":"One example of multiple renderers is in-game overlays. Without knowing which rendering API the game will you, multiple backends are used. However, some game when switching between lobby & battle(for lack of a better word), different rendering APIs are used. Usually different versions of Direct X. And in rare cases, the HUD is rendered in DX 10 and the 3D environment in DX 11.","created_at":"2018-07-14T15:46:43Z","updated_at":"2018-07-14T15:46:43Z","html_url":"https://github.com/billyquith/GWork/pull/86#discussion_r202518270","pull_request_url":"https://api.github.com/repos/billyquith/GWork/pulls/86","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/billyquith/GWork/pulls/comments/202518270"},"html":{"href":"https://github.com/billyquith/GWork/pull/86#discussion_r202518270"},"pull_request":{"href":"https://api.github.com/repos/billyquith/GWork/pulls/86"}},"in_reply_to_id":202513562},"pull_request":{"url":"https://api.github.com/repos/billyquith/GWork/pulls/86","id":201447581,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDQ3NTgx","html_url":"https://github.com/billyquith/GWork/pull/86","diff_url":"https://github.com/billyquith/GWork/pull/86.diff","patch_url":"https://github.com/billyquith/GWork/pull/86.patch","issue_url":"https://api.github.com/repos/billyquith/GWork/issues/86","number":86,"state":"open","locked":false,"title":"Fix #83 issues","user":{"login":"topblast","id":4210885,"node_id":"MDQ6VXNlcjQyMTA4ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/4210885?v=4","gravatar_id":"","url":"https://api.github.com/users/topblast","html_url":"https://github.com/topblast","followers_url":"https://api.github.com/users/topblast/followers","following_url":"https://api.github.com/users/topblast/following{/other_user}","gists_url":"https://api.github.com/users/topblast/gists{/gist_id}","starred_url":"https://api.github.com/users/topblast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topblast/subscriptions","organizations_url":"https://api.github.com/users/topblast/orgs","repos_url":"https://api.github.com/users/topblast/repos","events_url":"https://api.github.com/users/topblast/events{/privacy}","received_events_url":"https://api.github.com/users/topblast/received_events","type":"User","site_admin":false},"body":">  - The renderer textures are looked up everytime a rect is drawn. This is too inefficient. How about storing a user data in the Texture.\r\n>  - The utf8_to_wchart utility has unreachable code (returns).\r\n>  - ...\r\n>  - The software renderer texture colour sampling is broken.\r\n\r\nThis pull request aims to solve the issues you pointed out in #84. \r\nIt also includes the update for the SFML2 renderer.","created_at":"2018-07-14T11:17:32Z","updated_at":"2018-07-14T15:46:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e31345aa05f6b4a21e8296265d945a3d66dff15","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/billyquith/GWork/pulls/86/commits","review_comments_url":"https://api.github.com/repos/billyquith/GWork/pulls/86/comments","review_comment_url":"https://api.github.com/repos/billyquith/GWork/pulls/comments{/number}","comments_url":"https://api.github.com/repos/billyquith/GWork/issues/86/comments","statuses_url":"https://api.github.com/repos/billyquith/GWork/statuses/6a017cddde55def3b22f748db4f39f10a2eb3e26","head":{"label":"topblast:fontdata","ref":"fontdata","sha":"6a017cddde55def3b22f748db4f39f10a2eb3e26","user":{"login":"topblast","id":4210885,"node_id":"MDQ6VXNlcjQyMTA4ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/4210885?v=4","gravatar_id":"","url":"https://api.github.com/users/topblast","html_url":"https://github.com/topblast","followers_url":"https://api.github.com/users/topblast/followers","following_url":"https://api.github.com/users/topblast/following{/other_user}","gists_url":"https://api.github.com/users/topblast/gists{/gist_id}","starred_url":"https://api.github.com/users/topblast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topblast/subscriptions","organizations_url":"https://api.github.com/users/topblast/orgs","repos_url":"https://api.github.com/users/topblast/repos","events_url":"https://api.github.com/users/topblast/events{/privacy}","received_events_url":"https://api.github.com/users/topblast/received_events","type":"User","site_admin":false},"repo":{"id":137563719,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1NjM3MTk=","name":"GWork","full_name":"topblast/GWork","owner":{"login":"topblast","id":4210885,"node_id":"MDQ6VXNlcjQyMTA4ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/4210885?v=4","gravatar_id":"","url":"https://api.github.com/users/topblast","html_url":"https://github.com/topblast","followers_url":"https://api.github.com/users/topblast/followers","following_url":"https://api.github.com/users/topblast/following{/other_user}","gists_url":"https://api.github.com/users/topblast/gists{/gist_id}","starred_url":"https://api.github.com/users/topblast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/topblast/subscriptions","organizations_url":"https://api.github.com/users/topblast/orgs","repos_url":"https://api.github.com/users/topblast/repos","events_url":"https://api.github.com/users/topblast/events{/privacy}","received_events_url":"https://api.github.com/users/topblast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/topblast/GWork","description":"Skinnable GUI with useful widget collection. Fork of GWEN.","fork":true,"url":"https://api.github.com/repos/topblast/GWork","forks_url":"https://api.github.com/repos/topblast/GWork/forks","keys_url":"https://api.github.com/repos/topblast/GWork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/topblast/GWork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/topblast/GWork/teams","hooks_url":"https://api.github.com/repos/topblast/GWork/hooks","issue_events_url":"https://api.github.com/repos/topblast/GWork/issues/events{/number}","events_url":"https://api.github.com/repos/topblast/GWork/events","assignees_url":"https://api.github.com/repos/topblast/GWork/assignees{/user}","branches_url":"https://api.github.com/repos/topblast/GWork/branches{/branch}","tags_url":"https://api.github.com/repos/topblast/GWork/tags","blobs_url":"https://api.github.com/repos/topblast/GWork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/topblast/GWork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/topblast/GWork/git/refs{/sha}","trees_url":"https://api.github.com/repos/topblast/GWork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/topblast/GWork/statuses/{sha}","languages_url":"https://api.github.com/repos/topblast/GWork/languages","stargazers_url":"https://api.github.com/repos/topblast/GWork/stargazers","contributors_url":"https://api.github.com/repos/topblast/GWork/contributors","subscribers_url":"https://api.github.com/repos/topblast/GWork/subscribers","subscription_url":"https://api.github.com/repos/topblast/GWork/subscription","commits_url":"https://api.github.com/repos/topblast/GWork/commits{/sha}","git_commits_url":"https://api.github.com/repos/topblast/GWork/git/commits{/sha}","comments_url":"https://api.github.com/repos/topblast/GWork/comments{/number}","issue_comment_url":"https://api.github.com/repos/topblast/GWork/issues/comments{/number}","contents_url":"https://api.github.com/repos/topblast/GWork/contents/{+path}","compare_url":"https://api.github.com/repos/topblast/GWork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/topblast/GWork/merges","archive_url":"https://api.github.com/repos/topblast/GWork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/topblast/GWork/downloads","issues_url":"https://api.github.com/repos/topblast/GWork/issues{/number}","pulls_url":"https://api.github.com/repos/topblast/GWork/pulls{/number}","milestones_url":"https://api.github.com/repos/topblast/GWork/milestones{/number}","notifications_url":"https://api.github.com/repos/topblast/GWork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/topblast/GWork/labels{/name}","releases_url":"https://api.github.com/repos/topblast/GWork/releases{/id}","deployments_url":"https://api.github.com/repos/topblast/GWork/deployments","created_at":"2018-06-16T07:54:00Z","updated_at":"2018-07-14T06:18:11Z","pushed_at":"2018-07-14T14:56:11Z","git_url":"git://github.com/topblast/GWork.git","ssh_url":"git@github.com:topblast/GWork.git","clone_url":"https://github.com/topblast/GWork.git","svn_url":"https://github.com/topblast/GWork","homepage":"https://billyquith.github.io/GWork/","size":12751,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"gwork"}},"base":{"label":"billyquith:gwork","ref":"gwork","sha":"8221dca17640836ba1e5737bfbed70d6c3ffa81f","user":{"login":"billyquith","id":1754471,"node_id":"MDQ6VXNlcjE3NTQ0NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1754471?v=4","gravatar_id":"","url":"https://api.github.com/users/billyquith","html_url":"https://github.com/billyquith","followers_url":"https://api.github.com/users/billyquith/followers","following_url":"https://api.github.com/users/billyquith/following{/other_user}","gists_url":"https://api.github.com/users/billyquith/gists{/gist_id}","starred_url":"https://api.github.com/users/billyquith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billyquith/subscriptions","organizations_url":"https://api.github.com/users/billyquith/orgs","repos_url":"https://api.github.com/users/billyquith/repos","events_url":"https://api.github.com/users/billyquith/events{/privacy}","received_events_url":"https://api.github.com/users/billyquith/received_events","type":"User","site_admin":false},"repo":{"id":7449996,"node_id":"MDEwOlJlcG9zaXRvcnk3NDQ5OTk2","name":"GWork","full_name":"billyquith/GWork","owner":{"login":"billyquith","id":1754471,"node_id":"MDQ6VXNlcjE3NTQ0NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1754471?v=4","gravatar_id":"","url":"https://api.github.com/users/billyquith","html_url":"https://github.com/billyquith","followers_url":"https://api.github.com/users/billyquith/followers","following_url":"https://api.github.com/users/billyquith/following{/other_user}","gists_url":"https://api.github.com/users/billyquith/gists{/gist_id}","starred_url":"https://api.github.com/users/billyquith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billyquith/subscriptions","organizations_url":"https://api.github.com/users/billyquith/orgs","repos_url":"https://api.github.com/users/billyquith/repos","events_url":"https://api.github.com/users/billyquith/events{/privacy}","received_events_url":"https://api.github.com/users/billyquith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/billyquith/GWork","description":"Skinnable GUI with useful widget collection. Fork of GWEN.","fork":false,"url":"https://api.github.com/repos/billyquith/GWork","forks_url":"https://api.github.com/repos/billyquith/GWork/forks","keys_url":"https://api.github.com/repos/billyquith/GWork/keys{/key_id}","collaborators_url":"https://api.github.com/repos/billyquith/GWork/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/billyquith/GWork/teams","hooks_url":"https://api.github.com/repos/billyquith/GWork/hooks","issue_events_url":"https://api.github.com/repos/billyquith/GWork/issues/events{/number}","events_url":"https://api.github.com/repos/billyquith/GWork/events","assignees_url":"https://api.github.com/repos/billyquith/GWork/assignees{/user}","branches_url":"https://api.github.com/repos/billyquith/GWork/branches{/branch}","tags_url":"https://api.github.com/repos/billyquith/GWork/tags","blobs_url":"https://api.github.com/repos/billyquith/GWork/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/billyquith/GWork/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/billyquith/GWork/git/refs{/sha}","trees_url":"https://api.github.com/repos/billyquith/GWork/git/trees{/sha}","statuses_url":"https://api.github.com/repos/billyquith/GWork/statuses/{sha}","languages_url":"https://api.github.com/repos/billyquith/GWork/languages","stargazers_url":"https://api.github.com/repos/billyquith/GWork/stargazers","contributors_url":"https://api.github.com/repos/billyquith/GWork/contributors","subscribers_url":"https://api.github.com/repos/billyquith/GWork/subscribers","subscription_url":"https://api.github.com/repos/billyquith/GWork/subscription","commits_url":"https://api.github.com/repos/billyquith/GWork/commits{/sha}","git_commits_url":"https://api.github.com/repos/billyquith/GWork/git/commits{/sha}","comments_url":"https://api.github.com/repos/billyquith/GWork/comments{/number}","issue_comment_url":"https://api.github.com/repos/billyquith/GWork/issues/comments{/number}","contents_url":"https://api.github.com/repos/billyquith/GWork/contents/{+path}","compare_url":"https://api.github.com/repos/billyquith/GWork/compare/{base}...{head}","merges_url":"https://api.github.com/repos/billyquith/GWork/merges","archive_url":"https://api.github.com/repos/billyquith/GWork/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/billyquith/GWork/downloads","issues_url":"https://api.github.com/repos/billyquith/GWork/issues{/number}","pulls_url":"https://api.github.com/repos/billyquith/GWork/pulls{/number}","milestones_url":"https://api.github.com/repos/billyquith/GWork/milestones{/number}","notifications_url":"https://api.github.com/repos/billyquith/GWork/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/billyquith/GWork/labels{/name}","releases_url":"https://api.github.com/repos/billyquith/GWork/releases{/id}","deployments_url":"https://api.github.com/repos/billyquith/GWork/deployments","created_at":"2013-01-05T01:20:46Z","updated_at":"2018-07-13T12:50:27Z","pushed_at":"2018-07-14T14:56:12Z","git_url":"git://github.com/billyquith/GWork.git","ssh_url":"git@github.com:billyquith/GWork.git","clone_url":"https://github.com/billyquith/GWork.git","svn_url":"https://github.com/billyquith/GWork","homepage":"https://billyquith.github.io/GWork/","size":12716,"stargazers_count":91,"watchers_count":91,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":19,"watchers":91,"default_branch":"gwork"}},"_links":{"self":{"href":"https://api.github.com/repos/billyquith/GWork/pulls/86"},"html":{"href":"https://github.com/billyquith/GWork/pull/86"},"issue":{"href":"https://api.github.com/repos/billyquith/GWork/issues/86"},"comments":{"href":"https://api.github.com/repos/billyquith/GWork/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/billyquith/GWork/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/billyquith/GWork/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/billyquith/GWork/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/billyquith/GWork/statuses/6a017cddde55def3b22f748db4f39f10a2eb3e26"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"topblast"}}