{"action":"created","issue":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/9498","repository_url":"https://api.github.com/repos/Yoast/wordpress-seo","labels_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/9498/labels{/name}","comments_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/9498/comments","events_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/9498/events","html_url":"https://github.com/Yoast/wordpress-seo/pull/9498","id":315021342,"number":9498,"title":"Backport WordPress globals to classic editor","user":{"login":"atimmer","id":584693,"avatar_url":"https://avatars3.githubusercontent.com/u/584693?v=4","gravatar_id":"","url":"https://api.github.com/users/atimmer","html_url":"https://github.com/atimmer","followers_url":"https://api.github.com/users/atimmer/followers","following_url":"https://api.github.com/users/atimmer/following{/other_user}","gists_url":"https://api.github.com/users/atimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/atimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atimmer/subscriptions","organizations_url":"https://api.github.com/users/atimmer/orgs","repos_url":"https://api.github.com/users/atimmer/repos","events_url":"https://api.github.com/users/atimmer/events{/privacy}","received_events_url":"https://api.github.com/users/atimmer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-17T11:38:57Z","updated_at":"2018-04-24T09:35:02Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/pulls/9498","html_url":"https://github.com/Yoast/wordpress-seo/pull/9498","diff_url":"https://github.com/Yoast/wordpress-seo/pull/9498.diff","patch_url":"https://github.com/Yoast/wordpress-seo/pull/9498.patch"},"body":"## Summary\n\nThis PR can be summarized in the following changelog entry:\n\n* not applicable\n\n## Relevant technical choices:\n\nThis code takes into account 3 scenarios:\n\n1. WordPress without Gutenberg. We then bundle the Gutenberg scripts using the backporting script.\n\n2. WordPress with Gutenberg, editing in classic editor. We enqueue the scripts Gutenberg provides and then put the things we need on our global variable.\n\n3. WordPress with Gutenberg, editing in Gutenberg. We copy the variables from the Gutenberg globals to our own globals.\n\nAs soon as we only support a version of WordPress that includes Gutenberg we can drop scenario 3.\n\nI use a custom pragma, because that way we don't have to check in the scripts that use React if React is present where we expect it.\n\n## Test instructions\n\nThis PR can be tested by following these steps:\n\n* Make sure that all our React interfaces still work.\n\n## Quality assurance\n\n* [ ] I have tested this code to the best of my abilities\n* [ ] I have added unittests to verify the code works as intended\n\nFixes #9329"},"comment":{"url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/comments/383868209","html_url":"https://github.com/Yoast/wordpress-seo/pull/9498#issuecomment-383868209","issue_url":"https://api.github.com/repos/Yoast/wordpress-seo/issues/9498","id":383868209,"user":{"login":"IreneStr","id":17744553,"avatar_url":"https://avatars3.githubusercontent.com/u/17744553?v=4","gravatar_id":"","url":"https://api.github.com/users/IreneStr","html_url":"https://github.com/IreneStr","followers_url":"https://api.github.com/users/IreneStr/followers","following_url":"https://api.github.com/users/IreneStr/following{/other_user}","gists_url":"https://api.github.com/users/IreneStr/gists{/gist_id}","starred_url":"https://api.github.com/users/IreneStr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IreneStr/subscriptions","organizations_url":"https://api.github.com/users/IreneStr/orgs","repos_url":"https://api.github.com/users/IreneStr/repos","events_url":"https://api.github.com/users/IreneStr/events{/privacy}","received_events_url":"https://api.github.com/users/IreneStr/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T09:35:01Z","updated_at":"2018-04-24T09:35:01Z","author_association":"CONTRIBUTOR","body":"Acceptance 🚧 The configuration wizard is broken."}}
{"actor":{"display_login":"IreneStr"}}