{"push_id":2436827684,"size":29,"distinct_size":0,"ref":"refs/heads/master","head":"0415b1e6b2f7d1f4954fc8d83802468e2d7604e2","before":"7466a26cab5d66665991433947964a638f5b957e","commits":[{"sha":"ffcc687c556692de9dd368872d5361faa9aba0e4","author":{"name":"Sjors Provoost","email":"835808b55573ba31cadb0eb51d484750adf96093@sprovoost.nl"},"message":"[net] add seed.bitcoin.sprovoost.nl to DNS seeds","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/ffcc687c556692de9dd368872d5361faa9aba0e4"},{"sha":"3dba3c3ac1679cf0086ee7734eee12268004ace7","author":{"name":"Luke Dashjr","email":"986dde70a730265007c35a7f9456afb08ce5825f@utopios.org"},"message":"Qt: Load all wallets into WalletModels","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/3dba3c3ac1679cf0086ee7734eee12268004ace7"},{"sha":"e449f9a9e620fb909eb7b32d815b413d235f05ad","author":{"name":"Luke Dashjr","email":"986dde70a730265007c35a7f9456afb08ce5825f@utopios.org"},"message":"Qt: Add a combobox to toolbar to select from multiple wallets","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/e449f9a9e620fb909eb7b32d815b413d235f05ad"},{"sha":"85d5319716b7b31b27bc7950d756465ae472f11d","author":{"name":"Luke Dashjr","email":"986dde70a730265007c35a7f9456afb08ce5825f@utopios.org"},"message":"Qt: Ensure UI updates only come from the currently selected walletView","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/85d5319716b7b31b27bc7950d756465ae472f11d"},{"sha":"d558f44c58b61671899d6ef897df271de3f4f20a","author":{"name":"Luke Dashjr","email":"986dde70a730265007c35a7f9456afb08ce5825f@utopios.org"},"message":"Bugfix: RPC: Add missing UnregisterHTTPHandler for /wallet/","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/d558f44c58b61671899d6ef897df271de3f4f20a"},{"sha":"1f45e2164a7674f716b425a6658c41ca7c30265b","author":{"name":"practicalswift","email":"7bc8dfe66114fb97ee9aed052bc05e17800b570f@users.noreply.github.com"},"message":"scripted-diff: Convert 11 enums into scoped enums (C++11)\n\n-BEGIN VERIFY SCRIPT-\n\nsed -i 's/enum DBErrors/enum class DBErrors/g' src/wallet/walletdb.h\ngit grep -l DB_ | xargs sed -i 's/DB_\\(LOAD_OK\\|CORRUPT\\|NONCRITICAL_ERROR\\|TOO_NEW\\|LOAD_FAIL\\|NEED_REWRITE\\)/DBErrors::\\1/g'\nsed -i 's/^    DBErrors::/    /g' src/wallet/walletdb.h\n\nsed -i 's/enum VerifyResult/enum class VerifyResult/g' src/wallet/db.h\nsed -i 's/\\(VERIFY_OK\\|RECOVER_OK\\|RECOVER_FAIL\\)/VerifyResult::\\1/g' src/wallet/db.cpp\n\nsed -i 's/enum ThresholdState/enum class ThresholdState/g' src/versionbits.h\ngit grep -l THRESHOLD_ | xargs sed -i 's/THRESHOLD_\\(DEFINED\\|STARTED\\|LOCKED_IN\\|ACTIVE\\|FAILED\\)/ThresholdState::\\1/g'\nsed -i 's/^    ThresholdState::/    /g' src/versionbits.h\n\nsed -i 's/enum SigVersion/enum class SigVersion/g' src/script/interpreter.h\ngit grep -l SIGVERSION_ | xargs sed -i 's/SIGVERSION_\\(BASE\\|WITNESS_V0\\)/SigVersion::\\1/g'\nsed -i 's/^    SigVersion::/    /g' src/script/interpreter.h\n\nsed -i 's/enum RetFormat {/enum class RetFormat {/g' src/rest.cpp\nsed -i 's/RF_\\(UNDEF\\|BINARY\\|HEX\\|JSON\\)/RetFormat::\\1/g' src/rest.cpp\nsed -i 's/^    RetFormat::/    /g' src/rest.cpp\n\nsed -i 's/enum HelpMessageMode {/enum class HelpMessageMode {/g' src/init.h\ngit grep -l HMM_ | xargs sed -i 's/HMM_BITCOIN/HelpMessageMode::BITCOIN/g'\nsed -i 's/^    HelpMessageMode::/    /g' src/init.h\n\nsed -i 's/enum FeeEstimateHorizon/enum class FeeEstimateHorizon/g' src/policy/fees.h\n\nsed -i 's/enum RBFTransactionState/enum class RBFTransactionState/g' src/policy/rbf.h\ngit grep -l RBF_ | xargs sed -i 's/RBF_TRANSACTIONSTATE_\\(UNKNOWN\\|REPLACEABLE_BIP125\\|FINAL\\)/RBFTransactionState::\\1/g'\nsed -i 's/^    RBFTransactionState::/    /g' src/policy/rbf.h\n\nsed -i 's/enum BlockSource {/enum class BlockSource {/g' src/qt/clientmodel.h\ngit grep -l BLOCK_SOURCE_ | xargs sed -i 's/BLOCK_SOURCE_\\(NONE\\|REINDEX\\|DISK\\|NETWORK\\)/BlockSource::\\1/g'\nsed -i 's/^    BlockSource::/    /g' src/qt/clientmodel.h\n\nsed -i 's/enum FlushStateMode {/enum class FlushStateMode {/g' src/validation.cpp\nsed -i 's/FLUSH_STATE_\\(NONE\\|IF_NEEDED\\|PERIODIC\\|ALWAYS\\)/FlushStateMode::\\1/g' src/validation.cpp\nsed -i 's/^    FlushStateMode::/    /g' src/validation.cpp\n\nsed -i 's/enum WitnessMode {/enum class WitnessMode {/g' src/test/script_tests.cpp\nsed -i 's/WITNESS_\\(NONE\\|PKH\\|SH\\)/WitnessMode::\\1/g' src/test/script_tests.cpp\nsed -i 's/^    WitnessMode::/    /g' src/test/script_tests.cpp\n\n-END VERIFY SCRIPT-","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/1f45e2164a7674f716b425a6658c41ca7c30265b"},{"sha":"2fb9c1e6681370478e24a19172ed6d78d95d50d3","author":{"name":"Gregory Sanders","email":"d17144689daef62d32d4b0dc230531c88d2ef5fb@gmail.com"},"message":"shuffle selected coins before transaction finalization","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/2fb9c1e6681370478e24a19172ed6d78d95d50d3"},{"sha":"4757c04cb98df2ab3a54c7e33ff9af3b1f7dc78b","author":{"name":"John Newbery","email":"febb44f0a3536761749f6c82b901d79bfa74cce8@johnnewbery.com"},"message":"[config] Remove blockmaxsize option\n\nThe blockmaxsize option was marked as deprecated in V0.15.1, and code\nwas added to convert provided blockmaxsize into blockmaxweight. However,\nthis code was incorrectly implemented, and blockmaxsize was silently\nignored.\n\nNo users have complained about blockmaxsize being ignored, so just\nremove it in V0.17.","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/4757c04cb98df2ab3a54c7e33ff9af3b1f7dc78b"},{"sha":"3a0f8d795a96bdab4fffad7fcb00f73c615cf817","author":{"name":"practicalswift","email":"7bc8dfe66114fb97ee9aed052bc05e17800b570f@users.noreply.github.com"},"message":"Qt: Remove unused method setupAmountWidget(...)","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/3a0f8d795a96bdab4fffad7fcb00f73c615cf817"},{"sha":"d49cc70e6d96b45a4c062cbe2fa49a8181c8560f","author":{"name":"Jonas Schnelli","email":"80cd025df02680755871ffc10a22624c746ed388@jonasschnelli.ch"},"message":"Qt: Add wallet selector to debug console","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/d49cc70e6d96b45a4c062cbe2fa49a8181c8560f"},{"sha":"d1ec34a761d1d99b84e792fb6a6e62dbd8b5bdde","author":{"name":"Luke Dashjr","email":"986dde70a730265007c35a7f9456afb08ce5825f@utopios.org"},"message":"Qt: QComboBox::setVisible doesn't work in toolbars, so defer adding it at all until needed","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/d1ec34a761d1d99b84e792fb6a6e62dbd8b5bdde"},{"sha":"12d8d2681e34a191f5d82f15448f8c4c9a14f6d0","author":{"name":"Jonas Schnelli","email":"80cd025df02680755871ffc10a22624c746ed388@jonasschnelli.ch"},"message":"Qt: When multiple wallets are used, include in notifications the name","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/12d8d2681e34a191f5d82f15448f8c4c9a14f6d0"},{"sha":"b6d04fc7cc5de3370d2d8255f2b3e43f6bf9c80d","author":{"name":"Luke Dashjr","email":"986dde70a730265007c35a7f9456afb08ce5825f@utopios.org"},"message":"Qt: Get wallet name from WalletModel rather than passing it around","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/b6d04fc7cc5de3370d2d8255f2b3e43f6bf9c80d"},{"sha":"cfa4133ce53db2de8791ee7fa758d50a438083a6","author":{"name":"Luke Dashjr","email":"986dde70a730265007c35a7f9456afb08ce5825f@utopios.org"},"message":"GUI: RPCConsole: Log wallet changes","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/cfa4133ce53db2de8791ee7fa758d50a438083a6"},{"sha":"4826ca4b8438b6dd97701bb921f9d5122d8f832a","author":{"name":"Jonas Schnelli","email":"80cd025df02680755871ffc10a22624c746ed388@jonasschnelli.ch"},"message":"Qt: show wallet name in send confirmation dlg in case of multiwallet","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/4826ca4b8438b6dd97701bb921f9d5122d8f832a"},{"sha":"dc6f150f350f9c669d1c33e20afd0fdbb7fcf047","author":{"name":"Jonas Schnelli","email":"80cd025df02680755871ffc10a22624c746ed388@jonasschnelli.ch"},"message":"Qt: show wallet name in request dlg in case of multiwallet","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/dc6f150f350f9c669d1c33e20afd0fdbb7fcf047"},{"sha":"779c5f984064cfc48304b78da664de13fc3d9bb4","author":{"name":"Jonas Schnelli","email":"80cd025df02680755871ffc10a22624c746ed388@jonasschnelli.ch"},"message":"Qt: hide RPCConsole wallet selector when no wallets are present","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/779c5f984064cfc48304b78da664de13fc3d9bb4"},{"sha":"25cf18f239f0d812fe458435d064e522a6cab5f8","author":{"name":"Jonas Schnelli","email":"80cd025df02680755871ffc10a22624c746ed388@jonasschnelli.ch"},"message":"Merge #12610: Multiwallet for the GUI\n\n779c5f984 Qt: hide RPCConsole wallet selector when no wallets are present (Jonas Schnelli)\ndc6f150f3 Qt: show wallet name in request dlg in case of multiwallet (Jonas Schnelli)\n4826ca4b8 Qt: show wallet name in send confirmation dlg in case of multiwallet (Jonas Schnelli)\ncfa4133ce GUI: RPCConsole: Log wallet changes (Luke Dashjr)\nb6d04fc7c Qt: Get wallet name from WalletModel rather than passing it around (Luke Dashjr)\n12d8d2681 Qt: When multiple wallets are used, include in notifications the name (Jonas Schnelli)\nd1ec34a76 Qt: QComboBox::setVisible doesn't work in toolbars, so defer adding it at all until needed (Luke Dashjr)\nd49cc70e6 Qt: Add wallet selector to debug console (Jonas Schnelli)\nd558f44c5 Bugfix: RPC: Add missing UnregisterHTTPHandler for /wallet/ (Luke Dashjr)\n85d531971 Qt: Ensure UI updates only come from the currently selected walletView (Luke Dashjr)\ne449f9a9e Qt: Add a combobox to toolbar to select from multiple wallets (Luke Dashjr)\n3dba3c3ac Qt: Load all wallets into WalletModels (Luke Dashjr)\n\nPull request description:\n\n  This is an overhaul of #11383 (plus some additions).\n  It avoids unnecessary coupling of httpserver/jsonrpc and the wallet as well as it avoids pointer pure passing (and pointer deletion) of `CWallet` (plus other minor design changes).\n\n  Additionally it adds the wallet name to the sendconfirmation and request dialog (in case multiwallet is active)\n\nTree-SHA512: 3d06e18badbc5d1821e488bf1dae463bb0be544cf11b2b618e025812bfdd13c5f39604bb93b4c705313930e7dc4e66f4848b9469ba14871bade58e7a027246a1","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/25cf18f239f0d812fe458435d064e522a6cab5f8"},{"sha":"ec7dbaa37c233599e9fc68f8284ee85c1261652b","author":{"name":"Wladimir J. van der Laan","email":"c34e7a7f54ce6bae7e557bf240ec1aad7766c5ce@gmail.com"},"message":"Merge #12756: [config] Remove blockmaxsize option\n\n4757c04 [config] Remove blockmaxsize option (John Newbery)\n\nPull request description:\n\n  The blockmaxsize option was marked as deprecated in V0.15.1, and code\n  was added to convert provided blockmaxsize into blockmaxweight. However,\n  this code was incorrectly implemented, and blockmaxsize was silently\n  ignored.\n\n  No users have complained about blockmaxsize being ignored, so just\n  remove it in V0.17.\n\n  Fixes #12640\n\n  cc @ajtowns\n\nTree-SHA512: 968d71d37bf175c5a02539ddec289a12586f886e1dfe64c1d9aa5e39db48d06d21665153824fac3b11503a55f0812d2f1115a2d726aafd37b76ed629ec0aa671","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/ec7dbaa37c233599e9fc68f8284ee85c1261652b"},{"sha":"c948dc8f4285e27d8c0f3553d9d427b2a7b01b77","author":{"name":"Wladimir J. van der Laan","email":"c34e7a7f54ce6bae7e557bf240ec1aad7766c5ce@gmail.com"},"message":"Merge #12699: [wallet] Shuffle transaction inputs before signing\n\n2fb9c1e shuffle selected coins before transaction finalization (Gregory Sanders)\n\nPull request description:\n\n  Currently inputs are ordered based on COutPoint ordering, which while doesn't leak additional internal wallet state, likely further fingerprints the wallet as a Core wallet to observers.\n\n  Note: This slightly changed behavior of `fundrawtransaction` in that the newly-appended inputs will now be shuffled rather than in outpoint-order. This does not break API compatibility.\n\n  Simple shuffling of the coins being returned will hopefully allow the wallet to blend in a bit more, in lieu of additional data to find what other wallets are doing, or another standard, ala @gmaxwell's suggested of ordering via scriptPubKey.\n\nTree-SHA512: 70689a6eccf9fa7fc6e3d884f2eba4b482446a1e6128beff7a98f446d0c60f7966c5a6c55e9b0b3d73a9b539ce54889a26c7efe78ab7f34af386d5e4f3fa6df2","distinct":false,"url":"https://api.github.com/repos/practicalswift/bitcoin/commits/c948dc8f4285e27d8c0f3553d9d427b2a7b01b77"}]}
{"actor":{"display_login":"practicalswift"}}