{"action":"created","comment":{"url":"https://api.github.com/repos/secdev/scapy/pulls/comments/234562996","pull_request_review_id":176226655,"id":234562996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDU2Mjk5Ng==","diff_hunk":"@@ -32,6 +32,8 @@ def __init__(self, objlist=None):\n         self.chars = \"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789\"  # noqa: E501\n \n     def _fix(self, n=0):\n+        # Because it's crypto, use SystemRandom (safer but ~30% slower)","path":"scapy/asn1/asn1.py","position":15,"original_position":15,"commit_id":"b53466e83c02a388e83ef6f24331d40bb5cf7b64","original_commit_id":"b53466e83c02a388e83ef6f24331d40bb5cf7b64","user":{"login":"guedou","id":11683796,"node_id":"MDQ6VXNlcjExNjgzNzk2","avatar_url":"https://avatars1.githubusercontent.com/u/11683796?v=4","gravatar_id":"","url":"https://api.github.com/users/guedou","html_url":"https://github.com/guedou","followers_url":"https://api.github.com/users/guedou/followers","following_url":"https://api.github.com/users/guedou/following{/other_user}","gists_url":"https://api.github.com/users/guedou/gists{/gist_id}","starred_url":"https://api.github.com/users/guedou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guedou/subscriptions","organizations_url":"https://api.github.com/users/guedou/orgs","repos_url":"https://api.github.com/users/guedou/repos","events_url":"https://api.github.com/users/guedou/events{/privacy}","received_events_url":"https://api.github.com/users/guedou/received_events","type":"User","site_admin":false},"body":"I think that we don't care =)","created_at":"2018-11-19T10:21:11Z","updated_at":"2018-11-19T10:21:11Z","html_url":"https://github.com/secdev/scapy/pull/1695#discussion_r234562996","pull_request_url":"https://api.github.com/repos/secdev/scapy/pulls/1695","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/secdev/scapy/pulls/comments/234562996"},"html":{"href":"https://github.com/secdev/scapy/pull/1695#discussion_r234562996"},"pull_request":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1695"}}},"pull_request":{"url":"https://api.github.com/repos/secdev/scapy/pulls/1695","id":229900746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTAwNzQ2","html_url":"https://github.com/secdev/scapy/pull/1695","diff_url":"https://github.com/secdev/scapy/pull/1695.diff","patch_url":"https://github.com/secdev/scapy/pull/1695.patch","issue_url":"https://api.github.com/repos/secdev/scapy/issues/1695","number":1695,"state":"open","locked":false,"title":"Dig through code quality","user":{"login":"gpotter2","id":10530980,"node_id":"MDQ6VXNlcjEwNTMwOTgw","avatar_url":"https://avatars0.githubusercontent.com/u/10530980?v=4","gravatar_id":"","url":"https://api.github.com/users/gpotter2","html_url":"https://github.com/gpotter2","followers_url":"https://api.github.com/users/gpotter2/followers","following_url":"https://api.github.com/users/gpotter2/following{/other_user}","gists_url":"https://api.github.com/users/gpotter2/gists{/gist_id}","starred_url":"https://api.github.com/users/gpotter2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpotter2/subscriptions","organizations_url":"https://api.github.com/users/gpotter2/orgs","repos_url":"https://api.github.com/users/gpotter2/repos","events_url":"https://api.github.com/users/gpotter2/events{/privacy}","received_events_url":"https://api.github.com/users/gpotter2/received_events","type":"User","site_admin":false},"body":"Various cleanups/duplications fixed according to Codacy:\r\n- `except Exception: pass` fixed\r\n- unused variables\r\n- variables overwriting builtins\r\n- general cleanup","created_at":"2018-11-10T17:09:06Z","updated_at":"2018-11-19T10:21:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e45b4e88027f853ded082b8d093c056334e972ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1000112749,"node_id":"MDU6TGFiZWwxMDAwMTEyNzQ5","url":"https://api.github.com/repos/secdev/scapy/labels/cleanup","name":"cleanup","color":"FF68F6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/secdev/scapy/pulls/1695/commits","review_comments_url":"https://api.github.com/repos/secdev/scapy/pulls/1695/comments","review_comment_url":"https://api.github.com/repos/secdev/scapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/secdev/scapy/issues/1695/comments","statuses_url":"https://api.github.com/repos/secdev/scapy/statuses/b53466e83c02a388e83ef6f24331d40bb5cf7b64","head":{"label":"gpotter2:codacy-2","ref":"codacy-2","sha":"b53466e83c02a388e83ef6f24331d40bb5cf7b64","user":{"login":"gpotter2","id":10530980,"node_id":"MDQ6VXNlcjEwNTMwOTgw","avatar_url":"https://avatars0.githubusercontent.com/u/10530980?v=4","gravatar_id":"","url":"https://api.github.com/users/gpotter2","html_url":"https://github.com/gpotter2","followers_url":"https://api.github.com/users/gpotter2/followers","following_url":"https://api.github.com/users/gpotter2/following{/other_user}","gists_url":"https://api.github.com/users/gpotter2/gists{/gist_id}","starred_url":"https://api.github.com/users/gpotter2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpotter2/subscriptions","organizations_url":"https://api.github.com/users/gpotter2/orgs","repos_url":"https://api.github.com/users/gpotter2/repos","events_url":"https://api.github.com/users/gpotter2/events{/privacy}","received_events_url":"https://api.github.com/users/gpotter2/received_events","type":"User","site_admin":false},"repo":{"id":73421635,"node_id":"MDEwOlJlcG9zaXRvcnk3MzQyMTYzNQ==","name":"scapy","full_name":"gpotter2/scapy","private":false,"owner":{"login":"gpotter2","id":10530980,"node_id":"MDQ6VXNlcjEwNTMwOTgw","avatar_url":"https://avatars0.githubusercontent.com/u/10530980?v=4","gravatar_id":"","url":"https://api.github.com/users/gpotter2","html_url":"https://github.com/gpotter2","followers_url":"https://api.github.com/users/gpotter2/followers","following_url":"https://api.github.com/users/gpotter2/following{/other_user}","gists_url":"https://api.github.com/users/gpotter2/gists{/gist_id}","starred_url":"https://api.github.com/users/gpotter2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpotter2/subscriptions","organizations_url":"https://api.github.com/users/gpotter2/orgs","repos_url":"https://api.github.com/users/gpotter2/repos","events_url":"https://api.github.com/users/gpotter2/events{/privacy}","received_events_url":"https://api.github.com/users/gpotter2/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gpotter2/scapy","description":"Scapy: the python-based interactive packet manipulation program & library","fork":true,"url":"https://api.github.com/repos/gpotter2/scapy","forks_url":"https://api.github.com/repos/gpotter2/scapy/forks","keys_url":"https://api.github.com/repos/gpotter2/scapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gpotter2/scapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gpotter2/scapy/teams","hooks_url":"https://api.github.com/repos/gpotter2/scapy/hooks","issue_events_url":"https://api.github.com/repos/gpotter2/scapy/issues/events{/number}","events_url":"https://api.github.com/repos/gpotter2/scapy/events","assignees_url":"https://api.github.com/repos/gpotter2/scapy/assignees{/user}","branches_url":"https://api.github.com/repos/gpotter2/scapy/branches{/branch}","tags_url":"https://api.github.com/repos/gpotter2/scapy/tags","blobs_url":"https://api.github.com/repos/gpotter2/scapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gpotter2/scapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gpotter2/scapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gpotter2/scapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gpotter2/scapy/statuses/{sha}","languages_url":"https://api.github.com/repos/gpotter2/scapy/languages","stargazers_url":"https://api.github.com/repos/gpotter2/scapy/stargazers","contributors_url":"https://api.github.com/repos/gpotter2/scapy/contributors","subscribers_url":"https://api.github.com/repos/gpotter2/scapy/subscribers","subscription_url":"https://api.github.com/repos/gpotter2/scapy/subscription","commits_url":"https://api.github.com/repos/gpotter2/scapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gpotter2/scapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gpotter2/scapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gpotter2/scapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gpotter2/scapy/contents/{+path}","compare_url":"https://api.github.com/repos/gpotter2/scapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gpotter2/scapy/merges","archive_url":"https://api.github.com/repos/gpotter2/scapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gpotter2/scapy/downloads","issues_url":"https://api.github.com/repos/gpotter2/scapy/issues{/number}","pulls_url":"https://api.github.com/repos/gpotter2/scapy/pulls{/number}","milestones_url":"https://api.github.com/repos/gpotter2/scapy/milestones{/number}","notifications_url":"https://api.github.com/repos/gpotter2/scapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gpotter2/scapy/labels{/name}","releases_url":"https://api.github.com/repos/gpotter2/scapy/releases{/id}","deployments_url":"https://api.github.com/repos/gpotter2/scapy/deployments","created_at":"2016-11-10T21:18:19Z","updated_at":"2018-10-26T09:20:28Z","pushed_at":"2018-11-18T00:39:03Z","git_url":"git://github.com/gpotter2/scapy.git","ssh_url":"git@github.com:gpotter2/scapy.git","clone_url":"https://github.com/gpotter2/scapy.git","svn_url":"https://github.com/gpotter2/scapy","homepage":"http://www.secdev.org/projects/scapy/","size":86961,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"secdev:master","ref":"master","sha":"de9d564798a259309474a776f1c2725f8c4bc85b","user":{"login":"secdev","id":14927208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTI3MjA4","avatar_url":"https://avatars0.githubusercontent.com/u/14927208?v=4","gravatar_id":"","url":"https://api.github.com/users/secdev","html_url":"https://github.com/secdev","followers_url":"https://api.github.com/users/secdev/followers","following_url":"https://api.github.com/users/secdev/following{/other_user}","gists_url":"https://api.github.com/users/secdev/gists{/gist_id}","starred_url":"https://api.github.com/users/secdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secdev/subscriptions","organizations_url":"https://api.github.com/users/secdev/orgs","repos_url":"https://api.github.com/users/secdev/repos","events_url":"https://api.github.com/users/secdev/events{/privacy}","received_events_url":"https://api.github.com/users/secdev/received_events","type":"Organization","site_admin":false},"repo":{"id":43509302,"node_id":"MDEwOlJlcG9zaXRvcnk0MzUwOTMwMg==","name":"scapy","full_name":"secdev/scapy","private":false,"owner":{"login":"secdev","id":14927208,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0OTI3MjA4","avatar_url":"https://avatars0.githubusercontent.com/u/14927208?v=4","gravatar_id":"","url":"https://api.github.com/users/secdev","html_url":"https://github.com/secdev","followers_url":"https://api.github.com/users/secdev/followers","following_url":"https://api.github.com/users/secdev/following{/other_user}","gists_url":"https://api.github.com/users/secdev/gists{/gist_id}","starred_url":"https://api.github.com/users/secdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/secdev/subscriptions","organizations_url":"https://api.github.com/users/secdev/orgs","repos_url":"https://api.github.com/users/secdev/repos","events_url":"https://api.github.com/users/secdev/events{/privacy}","received_events_url":"https://api.github.com/users/secdev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/secdev/scapy","description":"Scapy: the Python-based interactive packet manipulation program & library. Supports Python 2 & Python 3.","fork":false,"url":"https://api.github.com/repos/secdev/scapy","forks_url":"https://api.github.com/repos/secdev/scapy/forks","keys_url":"https://api.github.com/repos/secdev/scapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/secdev/scapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/secdev/scapy/teams","hooks_url":"https://api.github.com/repos/secdev/scapy/hooks","issue_events_url":"https://api.github.com/repos/secdev/scapy/issues/events{/number}","events_url":"https://api.github.com/repos/secdev/scapy/events","assignees_url":"https://api.github.com/repos/secdev/scapy/assignees{/user}","branches_url":"https://api.github.com/repos/secdev/scapy/branches{/branch}","tags_url":"https://api.github.com/repos/secdev/scapy/tags","blobs_url":"https://api.github.com/repos/secdev/scapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/secdev/scapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/secdev/scapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/secdev/scapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/secdev/scapy/statuses/{sha}","languages_url":"https://api.github.com/repos/secdev/scapy/languages","stargazers_url":"https://api.github.com/repos/secdev/scapy/stargazers","contributors_url":"https://api.github.com/repos/secdev/scapy/contributors","subscribers_url":"https://api.github.com/repos/secdev/scapy/subscribers","subscription_url":"https://api.github.com/repos/secdev/scapy/subscription","commits_url":"https://api.github.com/repos/secdev/scapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/secdev/scapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/secdev/scapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/secdev/scapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/secdev/scapy/contents/{+path}","compare_url":"https://api.github.com/repos/secdev/scapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/secdev/scapy/merges","archive_url":"https://api.github.com/repos/secdev/scapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/secdev/scapy/downloads","issues_url":"https://api.github.com/repos/secdev/scapy/issues{/number}","pulls_url":"https://api.github.com/repos/secdev/scapy/pulls{/number}","milestones_url":"https://api.github.com/repos/secdev/scapy/milestones{/number}","notifications_url":"https://api.github.com/repos/secdev/scapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/secdev/scapy/labels{/name}","releases_url":"https://api.github.com/repos/secdev/scapy/releases{/id}","deployments_url":"https://api.github.com/repos/secdev/scapy/deployments","created_at":"2015-10-01T17:06:46Z","updated_at":"2018-11-19T04:36:36Z","pushed_at":"2018-11-18T23:09:47Z","git_url":"git://github.com/secdev/scapy.git","ssh_url":"git@github.com:secdev/scapy.git","clone_url":"https://github.com/secdev/scapy.git","svn_url":"https://github.com/secdev/scapy","homepage":"https://scapy.net","size":72778,"stargazers_count":3178,"watchers_count":3178,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":735,"mirror_url":null,"archived":false,"open_issues_count":63,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":735,"open_issues":63,"watchers":3178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1695"},"html":{"href":"https://github.com/secdev/scapy/pull/1695"},"issue":{"href":"https://api.github.com/repos/secdev/scapy/issues/1695"},"comments":{"href":"https://api.github.com/repos/secdev/scapy/issues/1695/comments"},"review_comments":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1695/comments"},"review_comment":{"href":"https://api.github.com/repos/secdev/scapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/secdev/scapy/pulls/1695/commits"},"statuses":{"href":"https://api.github.com/repos/secdev/scapy/statuses/b53466e83c02a388e83ef6f24331d40bb5cf7b64"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"guedou"}}