{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/web3.js/issues/2084","repository_url":"https://api.github.com/repos/ethereum/web3.js","labels_url":"https://api.github.com/repos/ethereum/web3.js/issues/2084/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/web3.js/issues/2084/comments","events_url":"https://api.github.com/repos/ethereum/web3.js/issues/2084/events","html_url":"https://github.com/ethereum/web3.js/pull/2084","id":386147428,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0OTU1NzY5","number":2084,"title":"Web3 utils full test coverage","user":{"login":"joshstevens19","id":18472422,"node_id":"MDQ6VXNlcjE4NDcyNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/18472422?v=4","gravatar_id":"","url":"https://api.github.com/users/joshstevens19","html_url":"https://github.com/joshstevens19","followers_url":"https://api.github.com/users/joshstevens19/followers","following_url":"https://api.github.com/users/joshstevens19/following{/other_user}","gists_url":"https://api.github.com/users/joshstevens19/gists{/gist_id}","starred_url":"https://api.github.com/users/joshstevens19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshstevens19/subscriptions","organizations_url":"https://api.github.com/users/joshstevens19/orgs","repos_url":"https://api.github.com/users/joshstevens19/repos","events_url":"https://api.github.com/users/joshstevens19/events{/privacy}","received_events_url":"https://api.github.com/users/joshstevens19/received_events","type":"User","site_admin":false},"labels":[{"id":133846863,"node_id":"MDU6TGFiZWwxMzM4NDY4NjM=","url":"https://api.github.com/repos/ethereum/web3.js/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-30T11:22:32Z","updated_at":"2018-12-02T08:07:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ethereum/web3.js/pulls/2084","html_url":"https://github.com/ethereum/web3.js/pull/2084","diff_url":"https://github.com/ethereum/web3.js/pull/2084.diff","patch_url":"https://github.com/ethereum/web3.js/pull/2084.patch"},"body":"Hi @nivida \r\n\r\nI have gone through the utils repo and got the `dtslint` within all the typings. We have full test coverage on all of the types now (look at `test.ts file, it's to big so you have to expand it ha ha).\r\n\r\nI have added this in the `npm test` step as well which will run before `jest`. We have everything nearly strongly typed so if you could supply me with the interface of the last few objects below we can have a fully supported ts for web3-utils :)\r\n\r\n- _jsonInterfaceMethodToString - json parameter ?\r\n- _flattenTypes - puts parameter ? \r\n\r\nHave a look through - this is going to be the foundations for all testing of all types in all packages. \r\n\r\nOh and i spotted some docs incorrect while doing it so i corrected that as well.\r\n\r\nCheers"},"comment":{"url":"https://api.github.com/repos/ethereum/web3.js/issues/comments/443489482","html_url":"https://github.com/ethereum/web3.js/pull/2084#issuecomment-443489482","issue_url":"https://api.github.com/repos/ethereum/web3.js/issues/2084","id":443489482,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQ4OTQ4Mg==","user":{"login":"joshstevens19","id":18472422,"node_id":"MDQ6VXNlcjE4NDcyNDIy","avatar_url":"https://avatars0.githubusercontent.com/u/18472422?v=4","gravatar_id":"","url":"https://api.github.com/users/joshstevens19","html_url":"https://github.com/joshstevens19","followers_url":"https://api.github.com/users/joshstevens19/followers","following_url":"https://api.github.com/users/joshstevens19/following{/other_user}","gists_url":"https://api.github.com/users/joshstevens19/gists{/gist_id}","starred_url":"https://api.github.com/users/joshstevens19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshstevens19/subscriptions","organizations_url":"https://api.github.com/users/joshstevens19/orgs","repos_url":"https://api.github.com/users/joshstevens19/repos","events_url":"https://api.github.com/users/joshstevens19/events{/privacy}","received_events_url":"https://api.github.com/users/joshstevens19/received_events","type":"User","site_admin":false},"created_at":"2018-12-02T08:07:27Z","updated_at":"2018-12-02T08:07:27Z","author_association":"CONTRIBUTOR","body":"@nivida it be good to strongly type these objects \r\n\r\n_jsonInterfaceMethodToString - json parameter ?\r\n_flattenTypes - puts parameter ?\r\n\r\nCan you let me know what object you expect for those?\r\n\r\n"}}
{"actor":{"display_login":"joshstevens19"}}