{"action":"created","comment":{"url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments/186059861","pull_request_review_id":117576592,"id":186059861,"diff_hunk":"@@ -26,10 +26,17 @@ const WebpackMonitor = require(\"webpack-monitor\");\n  *\n  * See: http://webpack.github.io/docs/configuration.html#cli\n  */\n-module.exports = function() {\n+module.exports = function(env, argv) {\n+\tconsole.log(env);\n \tconst ENV = (process.env.ENV = process.env.NODE_ENV = \"development\");\n \tconst HOST = process.env.HOST || \"localhost\";\n \tconst PORT = process.env.PORT || 3000;\n+\tlet MONITOR = false;\n+\tif (typeof env !== \"undefined\") {","path":"packages/stark-build/config/webpack.dev.js","position":11,"original_position":11,"commit_id":"a922e4a1fa15feca5a3178106b069ddbd9cf6e30","original_commit_id":"a922e4a1fa15feca5a3178106b069ddbd9cf6e30","user":{"login":"tenretC","id":32298791,"avatar_url":"https://avatars0.githubusercontent.com/u/32298791?v=4","gravatar_id":"","url":"https://api.github.com/users/tenretC","html_url":"https://github.com/tenretC","followers_url":"https://api.github.com/users/tenretC/followers","following_url":"https://api.github.com/users/tenretC/following{/other_user}","gists_url":"https://api.github.com/users/tenretC/gists{/gist_id}","starred_url":"https://api.github.com/users/tenretC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenretC/subscriptions","organizations_url":"https://api.github.com/users/tenretC/orgs","repos_url":"https://api.github.com/users/tenretC/repos","events_url":"https://api.github.com/users/tenretC/events{/privacy}","received_events_url":"https://api.github.com/users/tenretC/received_events","type":"User","site_admin":false},"body":"1.- https://webpack.js.org/api/cli/#environment-options","created_at":"2018-05-04T11:53:39Z","updated_at":"2018-05-04T11:53:39Z","html_url":"https://github.com/NationalBankBelgium/stark/pull/351#discussion_r186059861","pull_request_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/351","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments/186059861"},"html":{"href":"https://github.com/NationalBankBelgium/stark/pull/351#discussion_r186059861"},"pull_request":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/351"}},"in_reply_to_id":186048052},"pull_request":{"url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/351","id":185938226,"html_url":"https://github.com/NationalBankBelgium/stark/pull/351","diff_url":"https://github.com/NationalBankBelgium/stark/pull/351.diff","patch_url":"https://github.com/NationalBankBelgium/stark/pull/351.patch","issue_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/351","number":351,"state":"open","locked":false,"title":"fix(stark-build) fix(stark-starter): fix webpack monitor issues with reports folder and HMR","user":{"login":"tenretC","id":32298791,"avatar_url":"https://avatars0.githubusercontent.com/u/32298791?v=4","gravatar_id":"","url":"https://api.github.com/users/tenretC","html_url":"https://github.com/tenretC","followers_url":"https://api.github.com/users/tenretC/followers","following_url":"https://api.github.com/users/tenretC/following{/other_user}","gists_url":"https://api.github.com/users/tenretC/gists{/gist_id}","starred_url":"https://api.github.com/users/tenretC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenretC/subscriptions","organizations_url":"https://api.github.com/users/tenretC/orgs","repos_url":"https://api.github.com/users/tenretC/repos","events_url":"https://api.github.com/users/tenretC/events{/privacy}","received_events_url":"https://api.github.com/users/tenretC/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x] The commit message follows our guidelines: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#-commit-message-guidelines\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\n\r\nIssue Number: N/A\r\n\r\n\r\n## What is the new behavior?\r\n- Fix bug in the starter when `reports` folder doesn't exist\r\n\r\n- Add script to run webpack monitor (`npm run start:monitor`). In other situations, webpack monitor is not launched and HMR can work (Webpack monitor make crash the HMR). \r\n\r\n- Update  `webpack dev config` for the previous point\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information","created_at":"2018-05-04T09:55:11Z","updated_at":"2018-05-04T11:53:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44b3a88e2affd31a3b5e5796fa4df1a20d103afa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones/3","html_url":"https://github.com/NationalBankBelgium/stark/milestone/3","labels_url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones/3/labels","id":3142912,"number":3,"title":"10.0.0-alpha.3","description":"","creator":{"login":"dsebastien","id":89887,"avatar_url":"https://avatars3.githubusercontent.com/u/89887?v=4","gravatar_id":"","url":"https://api.github.com/users/dsebastien","html_url":"https://github.com/dsebastien","followers_url":"https://api.github.com/users/dsebastien/followers","following_url":"https://api.github.com/users/dsebastien/following{/other_user}","gists_url":"https://api.github.com/users/dsebastien/gists{/gist_id}","starred_url":"https://api.github.com/users/dsebastien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsebastien/subscriptions","organizations_url":"https://api.github.com/users/dsebastien/orgs","repos_url":"https://api.github.com/users/dsebastien/repos","events_url":"https://api.github.com/users/dsebastien/events{/privacy}","received_events_url":"https://api.github.com/users/dsebastien/received_events","type":"User","site_admin":false},"open_issues":41,"closed_issues":11,"state":"open","created_at":"2018-02-26T09:04:47Z","updated_at":"2018-05-04T10:41:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/351/commits","review_comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/351/comments","review_comment_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/351/comments","statuses_url":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/a922e4a1fa15feca5a3178106b069ddbd9cf6e30","head":{"label":"tenretC:feature/monitor","ref":"feature/monitor","sha":"a922e4a1fa15feca5a3178106b069ddbd9cf6e30","user":{"login":"tenretC","id":32298791,"avatar_url":"https://avatars0.githubusercontent.com/u/32298791?v=4","gravatar_id":"","url":"https://api.github.com/users/tenretC","html_url":"https://github.com/tenretC","followers_url":"https://api.github.com/users/tenretC/followers","following_url":"https://api.github.com/users/tenretC/following{/other_user}","gists_url":"https://api.github.com/users/tenretC/gists{/gist_id}","starred_url":"https://api.github.com/users/tenretC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenretC/subscriptions","organizations_url":"https://api.github.com/users/tenretC/orgs","repos_url":"https://api.github.com/users/tenretC/repos","events_url":"https://api.github.com/users/tenretC/events{/privacy}","received_events_url":"https://api.github.com/users/tenretC/received_events","type":"User","site_admin":false},"repo":{"id":126314585,"name":"stark","full_name":"tenretC/stark","owner":{"login":"tenretC","id":32298791,"avatar_url":"https://avatars0.githubusercontent.com/u/32298791?v=4","gravatar_id":"","url":"https://api.github.com/users/tenretC","html_url":"https://github.com/tenretC","followers_url":"https://api.github.com/users/tenretC/followers","following_url":"https://api.github.com/users/tenretC/following{/other_user}","gists_url":"https://api.github.com/users/tenretC/gists{/gist_id}","starred_url":"https://api.github.com/users/tenretC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tenretC/subscriptions","organizations_url":"https://api.github.com/users/tenretC/orgs","repos_url":"https://api.github.com/users/tenretC/repos","events_url":"https://api.github.com/users/tenretC/events{/privacy}","received_events_url":"https://api.github.com/users/tenretC/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tenretC/stark","description":"Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...","fork":true,"url":"https://api.github.com/repos/tenretC/stark","forks_url":"https://api.github.com/repos/tenretC/stark/forks","keys_url":"https://api.github.com/repos/tenretC/stark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tenretC/stark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tenretC/stark/teams","hooks_url":"https://api.github.com/repos/tenretC/stark/hooks","issue_events_url":"https://api.github.com/repos/tenretC/stark/issues/events{/number}","events_url":"https://api.github.com/repos/tenretC/stark/events","assignees_url":"https://api.github.com/repos/tenretC/stark/assignees{/user}","branches_url":"https://api.github.com/repos/tenretC/stark/branches{/branch}","tags_url":"https://api.github.com/repos/tenretC/stark/tags","blobs_url":"https://api.github.com/repos/tenretC/stark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tenretC/stark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tenretC/stark/git/refs{/sha}","trees_url":"https://api.github.com/repos/tenretC/stark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tenretC/stark/statuses/{sha}","languages_url":"https://api.github.com/repos/tenretC/stark/languages","stargazers_url":"https://api.github.com/repos/tenretC/stark/stargazers","contributors_url":"https://api.github.com/repos/tenretC/stark/contributors","subscribers_url":"https://api.github.com/repos/tenretC/stark/subscribers","subscription_url":"https://api.github.com/repos/tenretC/stark/subscription","commits_url":"https://api.github.com/repos/tenretC/stark/commits{/sha}","git_commits_url":"https://api.github.com/repos/tenretC/stark/git/commits{/sha}","comments_url":"https://api.github.com/repos/tenretC/stark/comments{/number}","issue_comment_url":"https://api.github.com/repos/tenretC/stark/issues/comments{/number}","contents_url":"https://api.github.com/repos/tenretC/stark/contents/{+path}","compare_url":"https://api.github.com/repos/tenretC/stark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tenretC/stark/merges","archive_url":"https://api.github.com/repos/tenretC/stark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tenretC/stark/downloads","issues_url":"https://api.github.com/repos/tenretC/stark/issues{/number}","pulls_url":"https://api.github.com/repos/tenretC/stark/pulls{/number}","milestones_url":"https://api.github.com/repos/tenretC/stark/milestones{/number}","notifications_url":"https://api.github.com/repos/tenretC/stark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tenretC/stark/labels{/name}","releases_url":"https://api.github.com/repos/tenretC/stark/releases{/id}","deployments_url":"https://api.github.com/repos/tenretC/stark/deployments","created_at":"2018-03-22T09:55:33Z","updated_at":"2018-05-04T10:19:43Z","pushed_at":"2018-05-04T10:19:40Z","git_url":"git://github.com/tenretC/stark.git","ssh_url":"git@github.com:tenretC/stark.git","clone_url":"https://github.com/tenretC/stark.git","svn_url":"https://github.com/tenretC/stark","homepage":"","size":6389,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NationalBankBelgium:master","ref":"master","sha":"40f745b351bf1ae3276975ddd88375a5e0c57cf7","user":{"login":"NationalBankBelgium","id":22069913,"avatar_url":"https://avatars1.githubusercontent.com/u/22069913?v=4","gravatar_id":"","url":"https://api.github.com/users/NationalBankBelgium","html_url":"https://github.com/NationalBankBelgium","followers_url":"https://api.github.com/users/NationalBankBelgium/followers","following_url":"https://api.github.com/users/NationalBankBelgium/following{/other_user}","gists_url":"https://api.github.com/users/NationalBankBelgium/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalBankBelgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalBankBelgium/subscriptions","organizations_url":"https://api.github.com/users/NationalBankBelgium/orgs","repos_url":"https://api.github.com/users/NationalBankBelgium/repos","events_url":"https://api.github.com/users/NationalBankBelgium/events{/privacy}","received_events_url":"https://api.github.com/users/NationalBankBelgium/received_events","type":"Organization","site_admin":false},"repo":{"id":105157749,"name":"stark","full_name":"NationalBankBelgium/stark","owner":{"login":"NationalBankBelgium","id":22069913,"avatar_url":"https://avatars1.githubusercontent.com/u/22069913?v=4","gravatar_id":"","url":"https://api.github.com/users/NationalBankBelgium","html_url":"https://github.com/NationalBankBelgium","followers_url":"https://api.github.com/users/NationalBankBelgium/followers","following_url":"https://api.github.com/users/NationalBankBelgium/following{/other_user}","gists_url":"https://api.github.com/users/NationalBankBelgium/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalBankBelgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalBankBelgium/subscriptions","organizations_url":"https://api.github.com/users/NationalBankBelgium/orgs","repos_url":"https://api.github.com/users/NationalBankBelgium/repos","events_url":"https://api.github.com/users/NationalBankBelgium/events{/privacy}","received_events_url":"https://api.github.com/users/NationalBankBelgium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NationalBankBelgium/stark","description":"Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...","fork":false,"url":"https://api.github.com/repos/NationalBankBelgium/stark","forks_url":"https://api.github.com/repos/NationalBankBelgium/stark/forks","keys_url":"https://api.github.com/repos/NationalBankBelgium/stark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NationalBankBelgium/stark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NationalBankBelgium/stark/teams","hooks_url":"https://api.github.com/repos/NationalBankBelgium/stark/hooks","issue_events_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/events{/number}","events_url":"https://api.github.com/repos/NationalBankBelgium/stark/events","assignees_url":"https://api.github.com/repos/NationalBankBelgium/stark/assignees{/user}","branches_url":"https://api.github.com/repos/NationalBankBelgium/stark/branches{/branch}","tags_url":"https://api.github.com/repos/NationalBankBelgium/stark/tags","blobs_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/refs{/sha}","trees_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/{sha}","languages_url":"https://api.github.com/repos/NationalBankBelgium/stark/languages","stargazers_url":"https://api.github.com/repos/NationalBankBelgium/stark/stargazers","contributors_url":"https://api.github.com/repos/NationalBankBelgium/stark/contributors","subscribers_url":"https://api.github.com/repos/NationalBankBelgium/stark/subscribers","subscription_url":"https://api.github.com/repos/NationalBankBelgium/stark/subscription","commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/commits{/sha}","git_commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/commits{/sha}","comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/comments{/number}","issue_comment_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/comments{/number}","contents_url":"https://api.github.com/repos/NationalBankBelgium/stark/contents/{+path}","compare_url":"https://api.github.com/repos/NationalBankBelgium/stark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NationalBankBelgium/stark/merges","archive_url":"https://api.github.com/repos/NationalBankBelgium/stark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NationalBankBelgium/stark/downloads","issues_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues{/number}","pulls_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls{/number}","milestones_url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones{/number}","notifications_url":"https://api.github.com/repos/NationalBankBelgium/stark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NationalBankBelgium/stark/labels{/name}","releases_url":"https://api.github.com/repos/NationalBankBelgium/stark/releases{/id}","deployments_url":"https://api.github.com/repos/NationalBankBelgium/stark/deployments","created_at":"2017-09-28T14:20:05Z","updated_at":"2018-05-03T13:03:05Z","pushed_at":"2018-05-04T10:19:43Z","git_url":"git://github.com/NationalBankBelgium/stark.git","ssh_url":"git@github.com:NationalBankBelgium/stark.git","clone_url":"https://github.com/NationalBankBelgium/stark.git","svn_url":"https://github.com/NationalBankBelgium/stark","homepage":"","size":6381,"stargazers_count":5,"watchers_count":5,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":214,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":214,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/351"},"html":{"href":"https://github.com/NationalBankBelgium/stark/pull/351"},"issue":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/issues/351"},"comments":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/issues/351/comments"},"review_comments":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/351/comments"},"review_comment":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/351/commits"},"statuses":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/a922e4a1fa15feca5a3178106b069ddbd9cf6e30"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tenretC"}}