{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3978","repository_url":"https://api.github.com/repos/input-output-hk/cardano-sl","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3978/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3978/comments","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3978/events","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3978","id":393191039,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMjg1NDQ3","number":3978,"title":"Enable monitoring API (and corresponding doc) for all nodes in the cluster","user":{"login":"KtorZ","id":5680256,"node_id":"MDQ6VXNlcjU2ODAyNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"KtorZ","id":5680256,"node_id":"MDQ6VXNlcjU2ODAyNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false},"assignees":[{"login":"KtorZ","id":5680256,"node_id":"MDQ6VXNlcjU2ODAyNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-12-20T19:58:46Z","updated_at":"2018-12-25T00:16:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/3978","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3978","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/3978.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/3978.patch"},"body":"## Description\r\n\r\n<!--- A brief description of this PR and the problem is trying to solve -->\r\n\r\n@parsonsmatt, this should unlock quite a few things for you to fix integration tests on `cardano-wallet`. Now, we generate a TLS environment for each node in the cluster, and they all start a monitoring api (and it's corresponding doc) using the generated certificates as an authentication mean.\r\n\r\nThis will have some rippling effects in `cardano-wallet` here:\r\n\r\nhttps://github.com/input-output-hk/cardano-wallet/blob/develop/test/integration/Test/Integration/Framework/Cluster.hs#L75-L87\r\n\r\nI'll leave that to you if that's okay :)\r\n\r\n## Linked issue\r\n\r\n<!--- Put here the relevant issue from YouTrack -->\r\n\r\n## Type of change\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply and `~` in the ones that do not: -->\r\n- [ ] 🐞 Bug fix (non-breaking change which fixes an issue)\r\n- [x] 🛠 New feature (non-breaking change which adds functionality)\r\n- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)\r\n- [x] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc\r\n- [x] 🔨 New or improved tests for existing code\r\n- [ ] ⛑ git-flow chore (backport, hotfix, etc)\r\n\r\n## Developer checklist\r\n<!--- A mental checklist for the developer submitting the PR. Put an `x` in all the boxes that apply and `~` in the ones that do not: --->\r\n- [x] I have read the [style guide](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/style-guide.md) document, and my code follows the code style of this project.\r\n- [x] If my code deals with exceptions, it follows the [guidelines](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/exceptions.md).\r\n- [x] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on [cardanodocs.com](https://github.com/input-output-hk/cardanodocs.com), amending the inline [Haddock](https://www.haskell.org/haddock/) comments, any relevant README file or one of the document listed in the [docs](https://github.com/input-output-hk/cardano-sl/tree/develop/docs) directory.\r\n- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub.\r\n\r\n## Testing checklist\r\n<!-- If you aren't providing any tests as part of this PR, use this section to state clearly why. It needs to be a strong motivation and definitely the exception, not the rule. -->\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n## QA Steps\r\n<!--- Which are the steps needed to test this feature, if any? -->\r\n\r\n```\r\n$ stack exec -- cardano-sl-cluster-demo\r\nCluster is starting (4 core(s), 1 relay(s), 1 edge(s))...\r\n...core0 OK!\r\n......address:       127.0.0.1:3000\r\n......api address:   127.0.0.1:8080\r\n......doc address:   127.0.0.1:8180\r\n......system start:  1545335561\r\n...core1 OK!\r\n......address:       127.0.0.1:3001\r\n......api address:   127.0.0.1:8081\r\n......doc address:   127.0.0.1:8181\r\n......system start:  1545335561\r\n...core2 OK!\r\n......address:       127.0.0.1:3002\r\n......api address:   127.0.0.1:8082\r\n......doc address:   127.0.0.1:8182\r\n......system start:  1545335561\r\n...core3 OK!\r\n......address:       127.0.0.1:3003\r\n......api address:   127.0.0.1:8083\r\n......doc address:   127.0.0.1:8183\r\n......system start:  1545335561\r\n...relay OK!\r\n......address:       127.0.0.1:3100\r\n......api address:   127.0.0.1:8084\r\n......doc address:   127.0.0.1:8184\r\n......system start:  1545335561\r\n...edge OK!\r\n......api address:   127.0.0.1:8085\r\n......doc address:   127.0.0.1:8185\r\n......system start:  1545335561\r\nCluster is ready!\r\n```\r\n\r\n## Screenshots (if available)\r\n<!--- Upload a GIF, an asciinema video or an image demoing the feature -->\r\n\r\n## How to merge\r\n\r\nSend the message `bors r+` to merge this PR. For more information, see\r\n[`docs/how-to/bors.md`](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/how-to/bors.md).\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments/449780053","html_url":"https://github.com/input-output-hk/cardano-sl/pull/3978#issuecomment-449780053","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/3978","id":449780053,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTc4MDA1Mw==","user":{"login":"iohk-bors[bot]","id":43231472,"node_id":"MDM6Qm90NDMyMzE0NzI=","avatar_url":"https://avatars1.githubusercontent.com/in/17473?v=4","gravatar_id":"","url":"https://api.github.com/users/iohk-bors%5Bbot%5D","html_url":"https://github.com/apps/iohk-bors","followers_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/followers","following_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/repos","events_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/iohk-bors%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-25T00:16:32Z","updated_at":"2018-12-25T00:16:32Z","author_association":"CONTRIBUTOR","body":"# Build succeeded\n  * [buildkite/cardano-sl](https://buildkite.com/input-output-hk/cardano-sl/builds/12617)\n  * [ci/hydra:serokell:cardano-sl:required](https://hydra.iohk.io/build/469667)"}}
{"actor":{"display_login":"iohk-bors"}}