{"action":"closed","number":800,"pull_request":{"url":"https://api.github.com/repos/gcarq/freqtrade/pulls/800","id":191685876,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjg1ODc2","html_url":"https://github.com/gcarq/freqtrade/pull/800","diff_url":"https://github.com/gcarq/freqtrade/pull/800.diff","patch_url":"https://github.com/gcarq/freqtrade/pull/800.patch","issue_url":"https://api.github.com/repos/gcarq/freqtrade/issues/800","number":800,"state":"closed","locked":false,"title":"trim_tickerlist - fix out of range index, download json data","user":{"login":"creslinux","id":34645187,"node_id":"MDQ6VXNlcjM0NjQ1MTg3","avatar_url":"https://avatars0.githubusercontent.com/u/34645187?v=4","gravatar_id":"","url":"https://api.github.com/users/creslinux","html_url":"https://github.com/creslinux","followers_url":"https://api.github.com/users/creslinux/followers","following_url":"https://api.github.com/users/creslinux/following{/other_user}","gists_url":"https://api.github.com/users/creslinux/gists{/gist_id}","starred_url":"https://api.github.com/users/creslinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creslinux/subscriptions","organizations_url":"https://api.github.com/users/creslinux/orgs","repos_url":"https://api.github.com/users/creslinux/repos","events_url":"https://api.github.com/users/creslinux/events{/privacy}","received_events_url":"https://api.github.com/users/creslinux/received_events","type":"User","site_admin":false},"body":"trim_tickerlist will throw an index out of range error when parsing an exiting pair data json file for a timerange outside it contents. \r\n\r\nThere exists a test to check the file exits, which returns None is not.  \r\nThe file will then to be downloaded with the timerange requested.\r\n\r\nThis change runs after the test to check if the json file exists checking the required range exists within the file.  If not then also returns None, the file is then downloaded with the timerange requested.\r\n\r\nHere is an example of the out or range index being hit. \r\n```\r\n  File \"/Users/creslin/PycharmProjects/freqtrade/freqtrade/optimize/__init__.py\", line 107, in load_data\r\n    pairdata = load_tickerdata_file(datadir, pair, ticker_interval, timerange=timerange)\r\n  File \"/Users/creslin/PycharmProjects/freqtrade/freqtrade/optimize/__init__.py\", line 84, in load_tickerdata_file\r\n    pairdata = trim_tickerlist(pairdata, timerange)\r\n  File \"/Users/creslin/PycharmProjects/freqtrade/freqtrade/optimize/__init__.py\", line 36, in trim_tickerlist\r\nwhile tickerlist[start_index][0] < start * 1000:\r\nIndexError: list index out of range\r\n```\r\nThank you for sending your pull request. But first, have you included\r\nunit tests, and is your code PEP8 conformant? [More details](https://github.com/gcarq/freqtrade/blob/develop/CONTRIBUTING.md)\r\n\r\n## Summary\r\nExplain in one sentence the goal of this PR\r\n\r\nSolve the issue: #___\r\n\r\n## Quick changelog\r\n\r\n- <change log #1>\r\n- <change log #2>\r\n\r\n## What's new?\r\n*Explain in details what this PR solve or improve. You can include visuals.* \r\n","created_at":"2018-05-31T08:55:42Z","updated_at":"2018-05-31T09:11:12Z","closed_at":"2018-05-31T09:11:12Z","merged_at":null,"merge_commit_sha":"a2028104726e082f1f0f618d84e0d03fab6f59ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/800/commits","review_comments_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/800/comments","review_comment_url":"https://api.github.com/repos/gcarq/freqtrade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gcarq/freqtrade/issues/800/comments","statuses_url":"https://api.github.com/repos/gcarq/freqtrade/statuses/2c269a39b9b3ba04e2d4d4cae82a0aa021d5f569","head":{"label":"creslinux:patch-2","ref":"patch-2","sha":"2c269a39b9b3ba04e2d4d4cae82a0aa021d5f569","user":{"login":"creslinux","id":34645187,"node_id":"MDQ6VXNlcjM0NjQ1MTg3","avatar_url":"https://avatars0.githubusercontent.com/u/34645187?v=4","gravatar_id":"","url":"https://api.github.com/users/creslinux","html_url":"https://github.com/creslinux","followers_url":"https://api.github.com/users/creslinux/followers","following_url":"https://api.github.com/users/creslinux/following{/other_user}","gists_url":"https://api.github.com/users/creslinux/gists{/gist_id}","starred_url":"https://api.github.com/users/creslinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creslinux/subscriptions","organizations_url":"https://api.github.com/users/creslinux/orgs","repos_url":"https://api.github.com/users/creslinux/repos","events_url":"https://api.github.com/users/creslinux/events{/privacy}","received_events_url":"https://api.github.com/users/creslinux/received_events","type":"User","site_admin":false},"repo":{"id":134533728,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ1MzM3Mjg=","name":"freqtrade","full_name":"creslinux/freqtrade","owner":{"login":"creslinux","id":34645187,"node_id":"MDQ6VXNlcjM0NjQ1MTg3","avatar_url":"https://avatars0.githubusercontent.com/u/34645187?v=4","gravatar_id":"","url":"https://api.github.com/users/creslinux","html_url":"https://github.com/creslinux","followers_url":"https://api.github.com/users/creslinux/followers","following_url":"https://api.github.com/users/creslinux/following{/other_user}","gists_url":"https://api.github.com/users/creslinux/gists{/gist_id}","starred_url":"https://api.github.com/users/creslinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/creslinux/subscriptions","organizations_url":"https://api.github.com/users/creslinux/orgs","repos_url":"https://api.github.com/users/creslinux/repos","events_url":"https://api.github.com/users/creslinux/events{/privacy}","received_events_url":"https://api.github.com/users/creslinux/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/creslinux/freqtrade","description":"Simple High Frequency Trading Bot for crypto currencies","fork":true,"url":"https://api.github.com/repos/creslinux/freqtrade","forks_url":"https://api.github.com/repos/creslinux/freqtrade/forks","keys_url":"https://api.github.com/repos/creslinux/freqtrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/creslinux/freqtrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/creslinux/freqtrade/teams","hooks_url":"https://api.github.com/repos/creslinux/freqtrade/hooks","issue_events_url":"https://api.github.com/repos/creslinux/freqtrade/issues/events{/number}","events_url":"https://api.github.com/repos/creslinux/freqtrade/events","assignees_url":"https://api.github.com/repos/creslinux/freqtrade/assignees{/user}","branches_url":"https://api.github.com/repos/creslinux/freqtrade/branches{/branch}","tags_url":"https://api.github.com/repos/creslinux/freqtrade/tags","blobs_url":"https://api.github.com/repos/creslinux/freqtrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/creslinux/freqtrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/creslinux/freqtrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/creslinux/freqtrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/creslinux/freqtrade/statuses/{sha}","languages_url":"https://api.github.com/repos/creslinux/freqtrade/languages","stargazers_url":"https://api.github.com/repos/creslinux/freqtrade/stargazers","contributors_url":"https://api.github.com/repos/creslinux/freqtrade/contributors","subscribers_url":"https://api.github.com/repos/creslinux/freqtrade/subscribers","subscription_url":"https://api.github.com/repos/creslinux/freqtrade/subscription","commits_url":"https://api.github.com/repos/creslinux/freqtrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/creslinux/freqtrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/creslinux/freqtrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/creslinux/freqtrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/creslinux/freqtrade/contents/{+path}","compare_url":"https://api.github.com/repos/creslinux/freqtrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/creslinux/freqtrade/merges","archive_url":"https://api.github.com/repos/creslinux/freqtrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/creslinux/freqtrade/downloads","issues_url":"https://api.github.com/repos/creslinux/freqtrade/issues{/number}","pulls_url":"https://api.github.com/repos/creslinux/freqtrade/pulls{/number}","milestones_url":"https://api.github.com/repos/creslinux/freqtrade/milestones{/number}","notifications_url":"https://api.github.com/repos/creslinux/freqtrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/creslinux/freqtrade/labels{/name}","releases_url":"https://api.github.com/repos/creslinux/freqtrade/releases{/id}","deployments_url":"https://api.github.com/repos/creslinux/freqtrade/deployments","created_at":"2018-05-23T07:52:46Z","updated_at":"2018-05-30T07:42:53Z","pushed_at":"2018-05-31T08:47:34Z","git_url":"git://github.com/creslinux/freqtrade.git","ssh_url":"git@github.com:creslinux/freqtrade.git","clone_url":"https://github.com/creslinux/freqtrade.git","svn_url":"https://github.com/creslinux/freqtrade","homepage":null,"size":30090,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"gcarq:develop","ref":"develop","sha":"52386d81537048c0063582ff5f2aa120e0406c02","user":{"login":"gcarq","id":4720529,"node_id":"MDQ6VXNlcjQ3MjA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"repo":{"id":91629816,"node_id":"MDEwOlJlcG9zaXRvcnk5MTYyOTgxNg==","name":"freqtrade","full_name":"gcarq/freqtrade","owner":{"login":"gcarq","id":4720529,"node_id":"MDQ6VXNlcjQ3MjA1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/4720529?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarq","html_url":"https://github.com/gcarq","followers_url":"https://api.github.com/users/gcarq/followers","following_url":"https://api.github.com/users/gcarq/following{/other_user}","gists_url":"https://api.github.com/users/gcarq/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarq/subscriptions","organizations_url":"https://api.github.com/users/gcarq/orgs","repos_url":"https://api.github.com/users/gcarq/repos","events_url":"https://api.github.com/users/gcarq/events{/privacy}","received_events_url":"https://api.github.com/users/gcarq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcarq/freqtrade","description":"Simple High Frequency Trading Bot for crypto currencies","fork":false,"url":"https://api.github.com/repos/gcarq/freqtrade","forks_url":"https://api.github.com/repos/gcarq/freqtrade/forks","keys_url":"https://api.github.com/repos/gcarq/freqtrade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcarq/freqtrade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcarq/freqtrade/teams","hooks_url":"https://api.github.com/repos/gcarq/freqtrade/hooks","issue_events_url":"https://api.github.com/repos/gcarq/freqtrade/issues/events{/number}","events_url":"https://api.github.com/repos/gcarq/freqtrade/events","assignees_url":"https://api.github.com/repos/gcarq/freqtrade/assignees{/user}","branches_url":"https://api.github.com/repos/gcarq/freqtrade/branches{/branch}","tags_url":"https://api.github.com/repos/gcarq/freqtrade/tags","blobs_url":"https://api.github.com/repos/gcarq/freqtrade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcarq/freqtrade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcarq/freqtrade/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcarq/freqtrade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcarq/freqtrade/statuses/{sha}","languages_url":"https://api.github.com/repos/gcarq/freqtrade/languages","stargazers_url":"https://api.github.com/repos/gcarq/freqtrade/stargazers","contributors_url":"https://api.github.com/repos/gcarq/freqtrade/contributors","subscribers_url":"https://api.github.com/repos/gcarq/freqtrade/subscribers","subscription_url":"https://api.github.com/repos/gcarq/freqtrade/subscription","commits_url":"https://api.github.com/repos/gcarq/freqtrade/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcarq/freqtrade/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcarq/freqtrade/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcarq/freqtrade/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcarq/freqtrade/contents/{+path}","compare_url":"https://api.github.com/repos/gcarq/freqtrade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcarq/freqtrade/merges","archive_url":"https://api.github.com/repos/gcarq/freqtrade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcarq/freqtrade/downloads","issues_url":"https://api.github.com/repos/gcarq/freqtrade/issues{/number}","pulls_url":"https://api.github.com/repos/gcarq/freqtrade/pulls{/number}","milestones_url":"https://api.github.com/repos/gcarq/freqtrade/milestones{/number}","notifications_url":"https://api.github.com/repos/gcarq/freqtrade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcarq/freqtrade/labels{/name}","releases_url":"https://api.github.com/repos/gcarq/freqtrade/releases{/id}","deployments_url":"https://api.github.com/repos/gcarq/freqtrade/deployments","created_at":"2017-05-17T23:48:53Z","updated_at":"2018-05-30T18:40:38Z","pushed_at":"2018-05-31T08:55:43Z","git_url":"git://github.com/gcarq/freqtrade.git","ssh_url":"git@github.com:gcarq/freqtrade.git","clone_url":"https://github.com/gcarq/freqtrade.git","svn_url":"https://github.com/gcarq/freqtrade","homepage":null,"size":30105,"stargazers_count":772,"watchers_count":772,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":265,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":265,"open_issues":65,"watchers":772,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/800"},"html":{"href":"https://github.com/gcarq/freqtrade/pull/800"},"issue":{"href":"https://api.github.com/repos/gcarq/freqtrade/issues/800"},"comments":{"href":"https://api.github.com/repos/gcarq/freqtrade/issues/800/comments"},"review_comments":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/800/comments"},"review_comment":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gcarq/freqtrade/pulls/800/commits"},"statuses":{"href":"https://api.github.com/repos/gcarq/freqtrade/statuses/2c269a39b9b3ba04e2d4d4cae82a0aa021d5f569"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":19,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"creslinux"}}