{"action":"created","issue":{"url":"https://api.github.com/repos/rook/rook/issues/1667","repository_url":"https://api.github.com/repos/rook/rook","labels_url":"https://api.github.com/repos/rook/rook/issues/1667/labels{/name}","comments_url":"https://api.github.com/repos/rook/rook/issues/1667/comments","events_url":"https://api.github.com/repos/rook/rook/issues/1667/events","html_url":"https://github.com/rook/rook/issues/1667","id":317655047,"node_id":"MDU6SXNzdWUzMTc2NTUwNDc=","number":1667,"title":"Remove tini for Docker 1.13 or greater","user":{"login":"harmjanblok","id":17157801,"node_id":"MDQ6VXNlcjE3MTU3ODAx","avatar_url":"https://avatars3.githubusercontent.com/u/17157801?v=4","gravatar_id":"","url":"https://api.github.com/users/harmjanblok","html_url":"https://github.com/harmjanblok","followers_url":"https://api.github.com/users/harmjanblok/followers","following_url":"https://api.github.com/users/harmjanblok/following{/other_user}","gists_url":"https://api.github.com/users/harmjanblok/gists{/gist_id}","starred_url":"https://api.github.com/users/harmjanblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harmjanblok/subscriptions","organizations_url":"https://api.github.com/users/harmjanblok/orgs","repos_url":"https://api.github.com/users/harmjanblok/repos","events_url":"https://api.github.com/users/harmjanblok/events{/privacy}","received_events_url":"https://api.github.com/users/harmjanblok/received_events","type":"User","site_admin":false},"labels":[{"id":496388704,"node_id":"MDU6TGFiZWw0OTYzODg3MDQ=","url":"https://api.github.com/repos/rook/rook/labels/daemon","name":"daemon","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-25T14:31:52Z","updated_at":"2018-11-04T17:09:20Z","closed_at":null,"author_association":"NONE","body":"Is this a bug report or feature request?\r\n* Feature request\r\n\r\n**Feature Request**\r\nWe've recently upgraded to docker 1.13.1, and rook Pods now show a warning in the logfiles regarding `tini`:\r\n\r\n```\r\n[WARN  tini (7)] Tini is not running as PID 1 and isn't registered as a child subreaper.\r\nZombie processes will not be re-parented to Tini, so zombie reaping won't work.\r\nTo fix the problem, use the -s option or set the environment variable TINI_SUBREAPER to register Tini as a child subreaper, or run Tini as PID 1.\r\n2018-04-25 07:06:57.930568 I | rook: starting Rook v0.6.2 with arguments '/usr/local/bin/rook agent'\r\n2018-04-25 07:06:57.932837 I | rook: flag values: --help=false, --log-level=INFO\r\n2018-04-25 07:06:57.934068 I | rook: starting rook agent\r\n...\r\n```\r\n\r\nAs described on https://github.com/krallin/tini#using-tini, Tini is included in Docker itself, when you are using Docker 1.13 or greater.\r\n\r\nWhat would be the correct way to handle this and simultaneously provide compatibility with docker 1.12 or older?\r\n\r\n**Environment**:\r\n* OS (e.g. from /etc/os-release): CentOS 7\r\n* Kernel (e.g. `uname -a`): 3.10.0-693.17.1.el7.x86_64\r\n* Cloud provider or hardware configuration: vCloudDirector\r\n* Rook version (use `rook version` inside of a Rook Pod): 0.6.2\r\n* Kubernetes version (use `kubectl version`): 1.7.5\r\n* Docker version: 1.13.1\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/rook/rook/issues/comments/435687252","html_url":"https://github.com/rook/rook/issues/1667#issuecomment-435687252","issue_url":"https://api.github.com/repos/rook/rook/issues/1667","id":435687252,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTY4NzI1Mg==","user":{"login":"stale[bot]","id":26384082,"node_id":"MDM6Qm90MjYzODQwODI=","avatar_url":"https://avatars3.githubusercontent.com/in/1724?v=4","gravatar_id":"","url":"https://api.github.com/users/stale%5Bbot%5D","html_url":"https://github.com/apps/stale","followers_url":"https://api.github.com/users/stale%5Bbot%5D/followers","following_url":"https://api.github.com/users/stale%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/stale%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/stale%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stale%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/stale%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/stale%5Bbot%5D/repos","events_url":"https://api.github.com/users/stale%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/stale%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-04T17:09:20Z","updated_at":"2018-11-04T17:09:20Z","author_association":"NONE","body":"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n"}}
{"actor":{"display_login":"stale"}}