{"action":"created","issue":{"url":"https://api.github.com/repos/prometheus/alertmanager/issues/1335","repository_url":"https://api.github.com/repos/prometheus/alertmanager","labels_url":"https://api.github.com/repos/prometheus/alertmanager/issues/1335/labels{/name}","comments_url":"https://api.github.com/repos/prometheus/alertmanager/issues/1335/comments","events_url":"https://api.github.com/repos/prometheus/alertmanager/issues/1335/events","html_url":"https://github.com/prometheus/alertmanager/pull/1335","id":316296270,"number":1335,"title":"Improve notification instrumentation","user":{"login":"stuartnelson3","id":1398104,"avatar_url":"https://avatars2.githubusercontent.com/u/1398104?v=4","gravatar_id":"","url":"https://api.github.com/users/stuartnelson3","html_url":"https://github.com/stuartnelson3","followers_url":"https://api.github.com/users/stuartnelson3/followers","following_url":"https://api.github.com/users/stuartnelson3/following{/other_user}","gists_url":"https://api.github.com/users/stuartnelson3/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartnelson3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartnelson3/subscriptions","organizations_url":"https://api.github.com/users/stuartnelson3/orgs","repos_url":"https://api.github.com/users/stuartnelson3/repos","events_url":"https://api.github.com/users/stuartnelson3/events{/privacy}","received_events_url":"https://api.github.com/users/stuartnelson3/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-20T14:44:35Z","updated_at":"2018-04-23T11:02:41Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/prometheus/alertmanager/pulls/1335","html_url":"https://github.com/prometheus/alertmanager/pull/1335","diff_url":"https://github.com/prometheus/alertmanager/pull/1335.diff","patch_url":"https://github.com/prometheus/alertmanager/pull/1335.patch"},"body":"- ~~Add the groupName on notification\r\nsuccess/failure counter, to help users debug\r\nquicker which group is failing (in case they use\r\ndifferent configs)~~\r\n- Add notificationLatencySeconds histogram to\r\ndebug duplicate messages. This can help rule out\r\nif duplicate messages are being caused by\r\nexcessive latency when sending a notification.\r\n\r\nThe buckets are very coarse. The current default delay is 15s, set by `--cluster.peer-timeout`, and I'm mostly interested in seeing if this threshhold is causing duplicate messages that have been reported.\r\n\r\n~~I wanted to add the groupName to the success/failure counter for integrations, but now this makes it difficult to initialize the metrics with values. I'm not sure if this is worth it (I think it will help reduce the time taken to fix a broken receiver's config), but if so then I'm not sure what would be the best way to handle initialization.~~\r\n\r\nEDIT:\r\nAddresses #1241 "},"comment":{"url":"https://api.github.com/repos/prometheus/alertmanager/issues/comments/383537066","html_url":"https://github.com/prometheus/alertmanager/pull/1335#issuecomment-383537066","issue_url":"https://api.github.com/repos/prometheus/alertmanager/issues/1335","id":383537066,"user":{"login":"stuartnelson3","id":1398104,"avatar_url":"https://avatars2.githubusercontent.com/u/1398104?v=4","gravatar_id":"","url":"https://api.github.com/users/stuartnelson3","html_url":"https://github.com/stuartnelson3","followers_url":"https://api.github.com/users/stuartnelson3/followers","following_url":"https://api.github.com/users/stuartnelson3/following{/other_user}","gists_url":"https://api.github.com/users/stuartnelson3/gists{/gist_id}","starred_url":"https://api.github.com/users/stuartnelson3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stuartnelson3/subscriptions","organizations_url":"https://api.github.com/users/stuartnelson3/orgs","repos_url":"https://api.github.com/users/stuartnelson3/repos","events_url":"https://api.github.com/users/stuartnelson3/events{/privacy}","received_events_url":"https://api.github.com/users/stuartnelson3/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T11:02:41Z","updated_at":"2018-04-23T11:02:41Z","author_association":"OWNER","body":"@simonpasquier could you take a look?"}}
{"actor":{"display_login":"stuartnelson3"}}