{"action":"created","comment":{"url":"https://api.github.com/repos/linkerd/linkerd/pulls/comments/195575335","pull_request_review_id":128974316,"id":195575335,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTU3NTMzNQ==","diff_hunk":"@@ -0,0 +1,122 @@\n+package com.twitter.finagle.naming.buoyant\n+\n+import com.twitter.finagle.buoyant.Dst\n+import com.twitter.finagle.naming.NameInterpreter\n+import com.twitter.finagle._\n+import com.twitter.util.Future\n+import io.buoyant.namer.{DelegateTree, Delegator}\n+import java.net.SocketAddress\n+import scala.util.control.NoStackTrace\n+\n+/**\n+ * An exception indicating that a connection could not be established to a remote peer.  This\n+ * exception also includes additional information about the routing context for the purposes of\n+ * displaying a more useful error message.  Since this exception is typically thrown in a router's\n+ * client stack, the service name is not available and the `withPath` method can be used to\n+ * argument this exception with the service name.\n+ */\n+case class RichConnectionFailedException(\n+  client: Option[Name.Bound],\n+  remote: SocketAddress,\n+  namer: NameInterpreter\n+) extends Exception(null, null)\n+  with NoStackTrace\n+  with SourcedException {\n+\n+  def withPath(service: Dst.Path): Future[Nothing] = {\n+    RichConnectionFailedExceptionWithPath(\n+      service,\n+      client,\n+      remote,\n+      namer\n+    )\n+  }\n+}\n+\n+/**\n+ * RichConnectionFailedExceptionWithPath is a RichConnectionFailedException augmented with the\n+ * service name and can be formatted as a user facing error message.\n+ */\n+class RichConnectionFailedExceptionWithPath(\n+  service: Dst.Path,\n+  client: String,\n+  addresses: Set[Address],\n+  remote: String,\n+  resolution: Seq[String]\n+) extends Exception(null, null)\n+  with NoStackTrace\n+  with SourcedException {\n+\n+  private[this] val addressList = addresses.collect {\n+    case Address.Inet(isa, _) => isa.toString.stripPrefix(\"/\")\n+  }.mkString(\"[\", \", \", \"]\")\n+\n+  private[this] val resolutionList = resolution.mkString(\"\\n\")\n+\n+  override def exceptionMessage(): String =\n+    s\"\"\"Unable to establish connection to $remote.\n+\n+service name: ${service.path.show}\n+client name: $client\n+addresses: $addressList\n+selected address: ${remote.toString.stripPrefix(\"/\")}\n+dtab resolution:\n+$resolutionList\n+\"\"\"\n+}\n+\n+object RichConnectionFailedExceptionWithPath {\n+\n+  def apply(\n+    path: Dst.Path,\n+    client: Option[Name.Bound],\n+    remote: SocketAddress,\n+    namer: NameInterpreter\n+  ): Future[Nothing] = {\n+\n+    val addresses = client match {","path":"router/core/src/main/scala/com/twitter/finagle/naming/buoyant/RichConnectionFailedException.scala","position":89,"original_position":77,"commit_id":"8e5d605762f5f2bb89ed8867a66d7ffc3fe03efc","original_commit_id":"f7b8220c4f742e637d9b45c9a481df2a3f6fef49","user":{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false},"body":"possibly, although this code is short enough that I'm not sure how much there is to be gained by factoring it out.  ","created_at":"2018-06-14T21:21:48Z","updated_at":"2018-06-14T21:21:48Z","html_url":"https://github.com/linkerd/linkerd/pull/1989#discussion_r195575335","pull_request_url":"https://api.github.com/repos/linkerd/linkerd/pulls/1989","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/comments/195575335"},"html":{"href":"https://github.com/linkerd/linkerd/pull/1989#discussion_r195575335"},"pull_request":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/1989"}},"in_reply_to_id":195265714},"pull_request":{"url":"https://api.github.com/repos/linkerd/linkerd/pulls/1989","id":194734950,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzM0OTUw","html_url":"https://github.com/linkerd/linkerd/pull/1989","diff_url":"https://github.com/linkerd/linkerd/pull/1989.diff","patch_url":"https://github.com/linkerd/linkerd/pull/1989.patch","issue_url":"https://api.github.com/repos/linkerd/linkerd/issues/1989","number":1989,"state":"open","locked":false,"title":"Improve ConnectionFailed exception error message","user":{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false},"body":"The ConnectionFailed error message does not provide very much information, making it sometimes hard to tell why Linkerd is attempting to connect to that address in the first place.\r\n\r\nWe update the error message with contextual routing information, including much of the same information that is displayed in a diagnostic trace.\r\n\r\nOld error message:\r\n```\r\n$ curl -v localhost:4140 -H \"Host: default\"\r\n* Rebuilt URL to: localhost:4140/\r\n*   Trying ::1...\r\n* TCP_NODELAY set\r\n* Connection failed\r\n* connect to ::1 port 4140 failed: Connection refused\r\n*   Trying 127.0.0.1...\r\n* TCP_NODELAY set\r\n* Connected to localhost (127.0.0.1) port 4140 (#0)\r\n> GET / HTTP/1.1\r\n> Host: default\r\n> User-Agent: curl/7.54.0\r\n> Accept: */*\r\n>\r\n< HTTP/1.1 502 Bad Gateway\r\n< Via: 1.1 linkerd\r\n< l5d-success-class: 0.0\r\n< l5d-err: Connection+refused%3A+%2F127.0.0.1%3A8888+at+remote+address%3A+%2F127.0.0.1%3A8888.+Remote+Info%3A+Not+Available\r\n< l5d-retryable: true\r\n< Content-Length: 98\r\n< Content-Type: text/plain\r\n<\r\n* Connection #0 to host localhost left intact\r\nConnection refused: /127.0.0.1:8888 at remote address: /127.0.0.1:8888. Remote Info: Not Available\r\n```\r\n\r\nNew error message:\r\n```\r\n$ curl -v localhost:4140 -H \"Host: default\"\r\n* Rebuilt URL to: localhost:4140/\r\n*   Trying ::1...\r\n* TCP_NODELAY set\r\n* Connection failed\r\n* connect to ::1 port 4140 failed: Connection refused\r\n*   Trying 127.0.0.1...\r\n* TCP_NODELAY set\r\n* Connected to localhost (127.0.0.1) port 4140 (#0)\r\n> GET / HTTP/1.1\r\n> Host: default\r\n> User-Agent: curl/7.54.0\r\n> Accept: */*\r\n>\r\n< HTTP/1.1 502 Bad Gateway\r\n< Via: 1.1 linkerd\r\n< l5d-success-class: 0.0\r\n< l5d-err: Unable+to+establish+connection+to+127.0.0.1%3A8888.%0A%0Aservice+name%3A+%2Fsvc%2Fdefault%0Aclient+name%3A+%2F%25%2Fio.l5d.localhost%2F%23%2Fio.l5d.fs%2Fdefault%0Aaddresses%3A+%5B127.0.0.1%3A8888%5D%0Aselected+address%3A+127.0.0.1%3A8888%0Adtab+resolution%3A%0A++++%2Fsvc%2Fdefault%0A++++%2F%23%2Fio.l5d.fs%2Fdefault+%28%2Fsvc%3D%3E%2F%23%2Fio.l5d.fs%29%0A++++%2F%25%2Fio.l5d.localhost%2F%23%2Fio.l5d.fs%2Fdefault+%28SubnetLocalTransformer%29%0A\r\n< Content-Length: 341\r\n< Content-Type: text/plain\r\n<\r\nUnable to establish connection to 127.0.0.1:8888.\r\n\r\nservice name: /svc/default\r\nclient name: /%/io.l5d.localhost/#/io.l5d.fs/default\r\naddresses: [127.0.0.1:8888]\r\nselected address: 127.0.0.1:8888\r\ndtab resolution:\r\n    /svc/default\r\n    /#/io.l5d.fs/default (/svc=>/#/io.l5d.fs)\r\n    /%/io.l5d.localhost/#/io.l5d.fs/default (SubnetLocalTransformer)\r\n* Connection #0 to host localhost left intact\r\n```\r\n\r\nBased on #1988 \r\nFixes #1959 ","created_at":"2018-06-13T22:39:17Z","updated_at":"2018-06-14T21:21:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15beefba0b15d6d18a445b38ef9aa19f4060f6c0","assignee":{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false},"assignees":[{"login":"adleong","id":3979810,"node_id":"MDQ6VXNlcjM5Nzk4MTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3979810?v=4","gravatar_id":"","url":"https://api.github.com/users/adleong","html_url":"https://github.com/adleong","followers_url":"https://api.github.com/users/adleong/followers","following_url":"https://api.github.com/users/adleong/following{/other_user}","gists_url":"https://api.github.com/users/adleong/gists{/gist_id}","starred_url":"https://api.github.com/users/adleong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adleong/subscriptions","organizations_url":"https://api.github.com/users/adleong/orgs","repos_url":"https://api.github.com/users/adleong/repos","events_url":"https://api.github.com/users/adleong/events{/privacy}","received_events_url":"https://api.github.com/users/adleong/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"olix0r","id":240738,"node_id":"MDQ6VXNlcjI0MDczOA==","avatar_url":"https://avatars3.githubusercontent.com/u/240738?v=4","gravatar_id":"","url":"https://api.github.com/users/olix0r","html_url":"https://github.com/olix0r","followers_url":"https://api.github.com/users/olix0r/followers","following_url":"https://api.github.com/users/olix0r/following{/other_user}","gists_url":"https://api.github.com/users/olix0r/gists{/gist_id}","starred_url":"https://api.github.com/users/olix0r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olix0r/subscriptions","organizations_url":"https://api.github.com/users/olix0r/orgs","repos_url":"https://api.github.com/users/olix0r/repos","events_url":"https://api.github.com/users/olix0r/events{/privacy}","received_events_url":"https://api.github.com/users/olix0r/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkerd/linkerd/pulls/1989/commits","review_comments_url":"https://api.github.com/repos/linkerd/linkerd/pulls/1989/comments","review_comment_url":"https://api.github.com/repos/linkerd/linkerd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkerd/linkerd/issues/1989/comments","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/8e5d605762f5f2bb89ed8867a66d7ffc3fe03efc","head":{"label":"linkerd:alex/connection-info","ref":"alex/connection-info","sha":"8e5d605762f5f2bb89ed8867a66d7ffc3fe03efc","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"node_id":"MDEwOlJlcG9zaXRvcnk0OTYwNTU5Ng==","name":"linkerd","full_name":"linkerd/linkerd","owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkerd/linkerd","description":"Open source service mesh for cloud-native applications","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd","forks_url":"https://api.github.com/repos/linkerd/linkerd/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2018-06-14T21:14:11Z","pushed_at":"2018-06-14T21:19:38Z","git_url":"git://github.com/linkerd/linkerd.git","ssh_url":"git@github.com:linkerd/linkerd.git","clone_url":"https://github.com/linkerd/linkerd.git","svn_url":"https://github.com/linkerd/linkerd","homepage":"https://linkerd.io","size":17628,"stargazers_count":4227,"watchers_count":4227,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":423,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":423,"open_issues":163,"watchers":4227,"default_branch":"master"}},"base":{"label":"linkerd:alex/dtree-find","ref":"alex/dtree-find","sha":"a26e6a9488d94bb6f48ebdc8a38b8a614173f442","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":49605596,"node_id":"MDEwOlJlcG9zaXRvcnk0OTYwNTU5Ng==","name":"linkerd","full_name":"linkerd/linkerd","owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkerd/linkerd","description":"Open source service mesh for cloud-native applications","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd","forks_url":"https://api.github.com/repos/linkerd/linkerd/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd/deployments","created_at":"2016-01-13T22:14:52Z","updated_at":"2018-06-14T21:14:11Z","pushed_at":"2018-06-14T21:19:38Z","git_url":"git://github.com/linkerd/linkerd.git","ssh_url":"git@github.com:linkerd/linkerd.git","clone_url":"https://github.com/linkerd/linkerd.git","svn_url":"https://github.com/linkerd/linkerd","homepage":"https://linkerd.io","size":17628,"stargazers_count":4227,"watchers_count":4227,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":423,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":423,"open_issues":163,"watchers":4227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/1989"},"html":{"href":"https://github.com/linkerd/linkerd/pull/1989"},"issue":{"href":"https://api.github.com/repos/linkerd/linkerd/issues/1989"},"comments":{"href":"https://api.github.com/repos/linkerd/linkerd/issues/1989/comments"},"review_comments":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/1989/comments"},"review_comment":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkerd/linkerd/pulls/1989/commits"},"statuses":{"href":"https://api.github.com/repos/linkerd/linkerd/statuses/8e5d605762f5f2bb89ed8867a66d7ffc3fe03efc"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"adleong"}}