{"action":"opened","number":2482,"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/2482","id":182295302,"html_url":"https://github.com/pravega/pravega/pull/2482","diff_url":"https://github.com/pravega/pravega/pull/2482.diff","patch_url":"https://github.com/pravega/pravega/pull/2482.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/2482","number":2482,"state":"open","locked":false,"title":"Issue 2481 ZkStreamStore.getCurrentTxns should not throw DataNotFoundException ","user":{"login":"shiveshr","id":13659022,"avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Shivesh Ranjan <shivesh.ranjan@gmail.com>\r\n\r\n**Change log description**\r\nHandles DataNotFoundException in getCurrentTransactions store api. \r\nRemoves all transactions for which DataNotFoundException was thrown and returns the remainder. \r\n\r\n**Purpose of the change**\r\nFixes #2481 \r\n\r\n**What the code does**\r\nZkStreamStore.getCurrentTxns is a two step process-\r\n\r\n    gets all txn ids by querying path for children of active epoch znode.\r\n    gets records for each txn id.\r\n\r\nIf between 1 and 2 txns records are deleted (by virtue of txn completing) then we can get DataNotFoundException\r\n\r\nSo in getCurrentTransactions, we check if DataNotFoundExcecption is thrown, and ignore it and remove such transactions from the response. \r\n\r\n**How to verify it**\r\nUnit test added","created_at":"2018-04-17T20:52:20Z","updated_at":"2018-04-17T20:52:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/2482/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/2482/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/2482/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/a500d0aa22dbf8491e351c7fb8832b864846a3f0","head":{"label":"shiveshr:issue2481","ref":"issue2481","sha":"a500d0aa22dbf8491e351c7fb8832b864846a3f0","user":{"login":"shiveshr","id":13659022,"avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false},"repo":{"id":92372740,"name":"pravega-1","full_name":"shiveshr/pravega-1","owner":{"login":"shiveshr","id":13659022,"avatar_url":"https://avatars2.githubusercontent.com/u/13659022?v=4","gravatar_id":"","url":"https://api.github.com/users/shiveshr","html_url":"https://github.com/shiveshr","followers_url":"https://api.github.com/users/shiveshr/followers","following_url":"https://api.github.com/users/shiveshr/following{/other_user}","gists_url":"https://api.github.com/users/shiveshr/gists{/gist_id}","starred_url":"https://api.github.com/users/shiveshr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shiveshr/subscriptions","organizations_url":"https://api.github.com/users/shiveshr/orgs","repos_url":"https://api.github.com/users/shiveshr/repos","events_url":"https://api.github.com/users/shiveshr/events{/privacy}","received_events_url":"https://api.github.com/users/shiveshr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shiveshr/pravega-1","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/shiveshr/pravega-1","forks_url":"https://api.github.com/repos/shiveshr/pravega-1/forks","keys_url":"https://api.github.com/repos/shiveshr/pravega-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shiveshr/pravega-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shiveshr/pravega-1/teams","hooks_url":"https://api.github.com/repos/shiveshr/pravega-1/hooks","issue_events_url":"https://api.github.com/repos/shiveshr/pravega-1/issues/events{/number}","events_url":"https://api.github.com/repos/shiveshr/pravega-1/events","assignees_url":"https://api.github.com/repos/shiveshr/pravega-1/assignees{/user}","branches_url":"https://api.github.com/repos/shiveshr/pravega-1/branches{/branch}","tags_url":"https://api.github.com/repos/shiveshr/pravega-1/tags","blobs_url":"https://api.github.com/repos/shiveshr/pravega-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shiveshr/pravega-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shiveshr/pravega-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/shiveshr/pravega-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shiveshr/pravega-1/statuses/{sha}","languages_url":"https://api.github.com/repos/shiveshr/pravega-1/languages","stargazers_url":"https://api.github.com/repos/shiveshr/pravega-1/stargazers","contributors_url":"https://api.github.com/repos/shiveshr/pravega-1/contributors","subscribers_url":"https://api.github.com/repos/shiveshr/pravega-1/subscribers","subscription_url":"https://api.github.com/repos/shiveshr/pravega-1/subscription","commits_url":"https://api.github.com/repos/shiveshr/pravega-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/shiveshr/pravega-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/shiveshr/pravega-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/shiveshr/pravega-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/shiveshr/pravega-1/contents/{+path}","compare_url":"https://api.github.com/repos/shiveshr/pravega-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shiveshr/pravega-1/merges","archive_url":"https://api.github.com/repos/shiveshr/pravega-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shiveshr/pravega-1/downloads","issues_url":"https://api.github.com/repos/shiveshr/pravega-1/issues{/number}","pulls_url":"https://api.github.com/repos/shiveshr/pravega-1/pulls{/number}","milestones_url":"https://api.github.com/repos/shiveshr/pravega-1/milestones{/number}","notifications_url":"https://api.github.com/repos/shiveshr/pravega-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shiveshr/pravega-1/labels{/name}","releases_url":"https://api.github.com/repos/shiveshr/pravega-1/releases{/id}","deployments_url":"https://api.github.com/repos/shiveshr/pravega-1/deployments","created_at":"2017-05-25T06:31:49Z","updated_at":"2018-04-17T17:53:51Z","pushed_at":"2018-04-17T20:45:54Z","git_url":"git://github.com/shiveshr/pravega-1.git","ssh_url":"git@github.com:shiveshr/pravega-1.git","clone_url":"https://github.com/shiveshr/pravega-1.git","svn_url":"https://github.com/shiveshr/pravega-1","homepage":"http://pravega.io","size":24216,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"9338880d7155186a8df3e2bbeea3c94666674a72","user":{"login":"pravega","id":25698199,"avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"name":"pravega","full_name":"pravega/pravega","owner":{"login":"pravega","id":25698199,"avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2018-04-17T11:18:50Z","pushed_at":"2018-04-17T11:42:28Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":24131,"stargazers_count":204,"watchers_count":204,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":385,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":64,"open_issues":385,"watchers":204,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2482"},"html":{"href":"https://github.com/pravega/pravega/pull/2482"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/2482"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/2482/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2482/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2482/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/a500d0aa22dbf8491e351c7fb8832b864846a3f0"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":58,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"shiveshr"}}