{"action":"created","issue":{"url":"https://api.github.com/repos/globus/globus-sdk-python/issues/309","repository_url":"https://api.github.com/repos/globus/globus-sdk-python","labels_url":"https://api.github.com/repos/globus/globus-sdk-python/issues/309/labels{/name}","comments_url":"https://api.github.com/repos/globus/globus-sdk-python/issues/309/comments","events_url":"https://api.github.com/repos/globus/globus-sdk-python/issues/309/events","html_url":"https://github.com/globus/globus-sdk-python/pull/309","id":354885993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTQzODM3","number":309,"title":"Make RenewingAuthorizer expiration check public","user":{"login":"sirosen","id":1300022,"node_id":"MDQ6VXNlcjEzMDAwMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1300022?v=4","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-28T20:13:40Z","updated_at":"2018-08-28T20:30:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/globus/globus-sdk-python/pulls/309","html_url":"https://github.com/globus/globus-sdk-python/pull/309","diff_url":"https://github.com/globus/globus-sdk-python/pull/309.diff","patch_url":"https://github.com/globus/globus-sdk-python/pull/309.patch"},"body":"Simply rename:\r\n```\r\n-    def _check_expiration_time(self):\r\n+    def check_expiration_time(self):\r\n```\r\nso that it's official.\r\n\r\nAlso improve documentation around Renewing Authorizer and its subclasses. In order to do this without writing some complex sphinx extension code or other shenanigans, I accepted a bit of repetition. It makes the docs a tiny bit harder to maintain in exchange for making the docs a lot easier to maintain."},"comment":{"url":"https://api.github.com/repos/globus/globus-sdk-python/issues/comments/416729723","html_url":"https://github.com/globus/globus-sdk-python/pull/309#issuecomment-416729723","issue_url":"https://api.github.com/repos/globus/globus-sdk-python/issues/309","id":416729723,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjcyOTcyMw==","user":{"login":"sirosen","id":1300022,"node_id":"MDQ6VXNlcjEzMDAwMjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1300022?v=4","gravatar_id":"","url":"https://api.github.com/users/sirosen","html_url":"https://github.com/sirosen","followers_url":"https://api.github.com/users/sirosen/followers","following_url":"https://api.github.com/users/sirosen/following{/other_user}","gists_url":"https://api.github.com/users/sirosen/gists{/gist_id}","starred_url":"https://api.github.com/users/sirosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sirosen/subscriptions","organizations_url":"https://api.github.com/users/sirosen/orgs","repos_url":"https://api.github.com/users/sirosen/repos","events_url":"https://api.github.com/users/sirosen/events{/privacy}","received_events_url":"https://api.github.com/users/sirosen/received_events","type":"User","site_admin":false},"created_at":"2018-08-28T20:30:08Z","updated_at":"2018-08-28T20:30:08Z","author_association":"MEMBER","body":"Yes, that's my perspective on it. It was an `_...` method, which is as private as python gets.\r\n\r\nI want to get this shipped before the CLI, so that we can use the new name."}}
{"actor":{"display_login":"sirosen"}}