{"action":"created","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/2728","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2728/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2728/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2728/events","html_url":"https://github.com/envoyproxy/envoy/pull/2728","id":302492054,"number":2728,"title":"Updated Docker builds to persist Bazel cache.","user":{"login":"asridharan","id":3128730,"avatar_url":"https://avatars3.githubusercontent.com/u/3128730?v=4","gravatar_id":"","url":"https://api.github.com/users/asridharan","html_url":"https://github.com/asridharan","followers_url":"https://api.github.com/users/asridharan/followers","following_url":"https://api.github.com/users/asridharan/following{/other_user}","gists_url":"https://api.github.com/users/asridharan/gists{/gist_id}","starred_url":"https://api.github.com/users/asridharan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asridharan/subscriptions","organizations_url":"https://api.github.com/users/asridharan/orgs","repos_url":"https://api.github.com/users/asridharan/repos","events_url":"https://api.github.com/users/asridharan/events{/privacy}","received_events_url":"https://api.github.com/users/asridharan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-05T22:36:47Z","updated_at":"2018-03-06T04:54:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/2728","html_url":"https://github.com/envoyproxy/envoy/pull/2728","diff_url":"https://github.com/envoyproxy/envoy/pull/2728.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/2728.patch"},"body":"*Title*:*Updated Docker builds to persist Bazel cache.*\r\n\r\n*Description*:\r\nUsing the docker builds is currently painful since the Bazel cache is\r\nnot persisted. This implies that every build is a clean build and hence\r\nthe docker build system cannot be used during regular development\r\nworkflows.\r\n\r\nIn this change have introduced a data-volume to the Docker build system\r\nthat would persist the Bazel cache across different Docker runs. The\r\nname of the data-volumen defaults to `bazel-cache` but can be changed by\r\nthe developer using the environment variable `ENVOY_DOCKER_BAZEL_CACHE`.\r\n\r\n*Risk Level*: Low\r\n\r\n*Testing*:\r\n* Ran build with `./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.asan'` to test that the cache is working correctly, and we don't have any re-runs of the builds.\r\n* Ran build with ./ci/run_envoy_docker.sh './ci/do_ci.sh bazel.release.server_only' to test that the cache is working correctly, and we don't have any re-runs of the builds.\r\n\r\nSigned-off-by: Avinash Sridharan <avinash.sridharan@gmail.com>\r\n\r\n*title*: *one line description*\r\n\r\n>Title can be a one or two words to describe the subsystem or the aspect\r\n this PR applies to. Title and description must be lower case. For example:\r\n* ci: update build image to 44d539cb\r\n* docs: fix indent, buffer: add copyOut() method\r\n* router:add x-envoy-overloaded header\r\n* tls: add support for specifying TLS session ticket keys\r\n\r\n*Description*:\r\n>What does this PR do? What was the behavior before the PR?\r\nWhat is the behavior with the PR? If fixing a bug, please describe what\r\nthe original issue is and how the change resolves it. How does this\r\nfeature get enabled? By default, config change, etc...\r\n\r\n*Risk Level*: Low | Medium | High\r\n>Low: Small bug fix or small optional feature.\r\n\r\n>Medium: New features that are not enabled(for example: new filter). Small-medium\r\nfeatures added to existing components(for example: modification to an existing\r\nfilter).\r\n\r\n>High: Complicated changes such as flow control, rewrites of critical\r\ncomponents, etc.\r\n\r\n>Note: The above is only a rough guide for choosing a level,\r\nplease ask if you have any concerns about the risk of the PR.\r\n\r\n*Testing*:\r\n>Explanation of what testing was done, for example: unit test,\r\nintegration, manual testing, etc.\r\n\r\n>Note: It isn’t expected to do all\r\nforms of testing, please use your best judgement or ask for guidance\r\nif you are unsure. A good rule of thumb is the riskier the change, the\r\nmore comprehensive the testing should be.\r\n\r\n*Docs Changes*:\r\n>Link to [Data Plane PR](https://github.com/envoyproxy/data-plane-api/pulls)]\r\nif your PR involves documentation changes. Please write in N/A if there were no\r\ndocumentation changes.\r\n\r\n*Release Notes*:\r\n>If this change is user impacting you **must** add a release note to\r\n[RAW_RELEASE_NOTES.md](RAW_RELEASE_NOTES.md). Thank you! Please write in N/A if\r\nthere are no release notes.\r\n\r\n[Optional Fixes #Issue]\r\n\r\n[Optional *API Changes*:]\r\n>Link to [Data Plane PR](https://github.com/envoyproxy/data-plane-api/pulls)]\r\n\r\n[Optional *Deprecated*:]\r\n>Description of what is deprecated.\r\n"},"comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments/370662275","html_url":"https://github.com/envoyproxy/envoy/pull/2728#issuecomment-370662275","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/2728","id":370662275,"user":{"login":"htuch","id":10914751,"avatar_url":"https://avatars1.githubusercontent.com/u/10914751?v=4","gravatar_id":"","url":"https://api.github.com/users/htuch","html_url":"https://github.com/htuch","followers_url":"https://api.github.com/users/htuch/followers","following_url":"https://api.github.com/users/htuch/following{/other_user}","gists_url":"https://api.github.com/users/htuch/gists{/gist_id}","starred_url":"https://api.github.com/users/htuch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/htuch/subscriptions","organizations_url":"https://api.github.com/users/htuch/orgs","repos_url":"https://api.github.com/users/htuch/repos","events_url":"https://api.github.com/users/htuch/events{/privacy}","received_events_url":"https://api.github.com/users/htuch/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T04:54:15Z","updated_at":"2018-03-06T04:54:15Z","author_association":"OWNER","body":"@asridharan The cache is in `/build`, which is bind mounted already. Do you not see a persisted cache in that directory? \r\n\r\n@jmillikin-stripe do you have any experience here with Bazel and cache placement? I thought `TEST_TMPDIR` was sufficient, and I can see this in my Docker setup working, but there's also the option of `--output_base`."}}
{"actor":{"display_login":"htuch"}}