{"action":"created","issue":{"url":"https://api.github.com/repos/containers/image/issues/468","repository_url":"https://api.github.com/repos/containers/image","labels_url":"https://api.github.com/repos/containers/image/issues/468/labels{/name}","comments_url":"https://api.github.com/repos/containers/image/issues/468/comments","events_url":"https://api.github.com/repos/containers/image/issues/468/events","html_url":"https://github.com/containers/image/pull/468","id":333990010,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDcxMDM3","number":468,"title":"dockerClient: skip TLS verification if configured in registries","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-06-20T09:13:56Z","updated_at":"2018-07-10T06:29:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/containers/image/pulls/468","html_url":"https://github.com/containers/image/pull/468","diff_url":"https://github.com/containers/image/pull/468.diff","patch_url":"https://github.com/containers/image/pull/468.patch"},"body":"Based on a discussion from: https://github.com/containers/image/pull/464#issuecomment-397744605\r\n\r\n- sysregistriesv2: adjust API to SystemContext\r\n- dockerClient: skip TLS verification if configured in registries"},"comment":{"url":"https://api.github.com/repos/containers/image/issues/comments/403715042","html_url":"https://github.com/containers/image/pull/468#issuecomment-403715042","issue_url":"https://api.github.com/repos/containers/image/issues/468","id":403715042,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzcxNTA0Mg==","user":{"login":"vrothberg","id":11679875,"node_id":"MDQ6VXNlcjExNjc5ODc1","avatar_url":"https://avatars1.githubusercontent.com/u/11679875?v=4","gravatar_id":"","url":"https://api.github.com/users/vrothberg","html_url":"https://github.com/vrothberg","followers_url":"https://api.github.com/users/vrothberg/followers","following_url":"https://api.github.com/users/vrothberg/following{/other_user}","gists_url":"https://api.github.com/users/vrothberg/gists{/gist_id}","starred_url":"https://api.github.com/users/vrothberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrothberg/subscriptions","organizations_url":"https://api.github.com/users/vrothberg/orgs","repos_url":"https://api.github.com/users/vrothberg/repos","events_url":"https://api.github.com/users/vrothberg/events{/privacy}","received_events_url":"https://api.github.com/users/vrothberg/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T06:29:10Z","updated_at":"2018-07-10T06:29:10Z","author_association":"CONTRIBUTOR","body":"> FWIW, the failed tests in there prompted me to write unit tests for contextFromGlobalOptions, and I’m not at all happy with how that handles the --tls-verify flag (notably if one of the subcommands does not declare the flag, it is silently set to the insecure value right now). So I’m trying to overhaul the CLI parsing in there to actually work reliably, I’m not yet quite sure where that will lead me (WIP https://github.com/mtrmac/skopeo/tree/cli-parsing ).\r\n\r\nOuch. There are quite some unexpected pain points in the stack. CLI parsing sucks big time.\r\nThanks for doing that!\r\n\r\n> There might be a simple way to make the specifically the --tls-verify reliable enough without that overhaul, I haven’t really been looking to be honest.\r\n\r\nI may find time next week to help you untangle the code."}}
{"actor":{"display_login":"vrothberg"}}