{"action":"created","issue":{"url":"https://api.github.com/repos/dlang/dmd/issues/8841","repository_url":"https://api.github.com/repos/dlang/dmd","labels_url":"https://api.github.com/repos/dlang/dmd/issues/8841/labels{/name}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8841/comments","events_url":"https://api.github.com/repos/dlang/dmd/issues/8841/events","html_url":"https://github.com/dlang/dmd/pull/8841","id":371806026,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTcwMTkw","number":8841,"title":"de-virtualize cgobj.c and mscoffobj.c","user":{"login":"WalterBright","id":568298,"node_id":"MDQ6VXNlcjU2ODI5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/568298?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false},"labels":[{"id":953336750,"node_id":"MDU6TGFiZWw5NTMzMzY3NTA=","url":"https://api.github.com/repos/dlang/dmd/labels/D%20Conversion","name":"D Conversion","color":"9f15d6","default":false},{"id":806268296,"node_id":"MDU6TGFiZWw4MDYyNjgyOTY=","url":"https://api.github.com/repos/dlang/dmd/labels/Refactoring","name":"Refactoring","color":"15db6b","default":false},{"id":502721241,"node_id":"MDU6TGFiZWw1MDI3MjEyNDE=","url":"https://api.github.com/repos/dlang/dmd/labels/auto-merge","name":"auto-merge","color":"d3d3d3","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-19T04:49:20Z","updated_at":"2018-10-19T07:42:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8841","html_url":"https://github.com/dlang/dmd/pull/8841","diff_url":"https://github.com/dlang/dmd/pull/8841.diff","patch_url":"https://github.com/dlang/dmd/pull/8841.patch"},"body":"This changes the member functions in obj.d from virtuals to statics. It's the most straightforward way to convert cgobj.c and mscoffobj.c to D. Will do the same treatment later to elfobj.c and machobj.c."},"comment":{"url":"https://api.github.com/repos/dlang/dmd/issues/comments/431274383","html_url":"https://github.com/dlang/dmd/pull/8841#issuecomment-431274383","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8841","id":431274383,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTI3NDM4Mw==","user":{"login":"rainers","id":702284,"node_id":"MDQ6VXNlcjcwMjI4NA==","avatar_url":"https://avatars3.githubusercontent.com/u/702284?v=4","gravatar_id":"","url":"https://api.github.com/users/rainers","html_url":"https://github.com/rainers","followers_url":"https://api.github.com/users/rainers/followers","following_url":"https://api.github.com/users/rainers/following{/other_user}","gists_url":"https://api.github.com/users/rainers/gists{/gist_id}","starred_url":"https://api.github.com/users/rainers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rainers/subscriptions","organizations_url":"https://api.github.com/users/rainers/orgs","repos_url":"https://api.github.com/users/rainers/repos","events_url":"https://api.github.com/users/rainers/events{/privacy}","received_events_url":"https://api.github.com/users/rainers/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T07:42:44Z","updated_at":"2018-10-19T07:42:44Z","author_association":"MEMBER","body":"Renaming Obj to OmfObj is good, but why is it necessary to turn static member functions into free functions?\r\n\r\nIf we ever want to support cross compilation this seems the wrong direction. I don't think virtual function calls are expensive here as the \"indirect branch predictor\" will always be right. These calls are not very performance sensitive to begin with."}}
{"actor":{"display_login":"rainers"}}