{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/216755948","pull_request_review_id":154314027,"id":216755948,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjc1NTk0OA==","diff_hunk":"@@ -130,6 +130,12 @@ def verify_vnodes_state(self, expected_state):\n     def tearDown(self):\r\n         TestFunctional.tearDown(self)\r\n \r\n+        # Delete the hooks created by the test\r\n+        hooks_list = [\"h1\", \"h2\", \"h3\"]\r\n+        for h in hooks_list:\r\n+            if h in self.server.hooks:\r\n+                self.server.manager(MGR_CMD_DELETE, HOOK, id=h, expect=True)\r","path":"test/tests/functional/pbs_offline_vnodes.py","position":null,"original_position":8,"commit_id":"9eb4c46f2fefdb42d4b8a4d15d3f438ef95de488","original_commit_id":"1332a5396ae0dd152d2cd88edcc3e89fe2b72065","user":{"login":"latha-subramanian","id":33468106,"node_id":"MDQ6VXNlcjMzNDY4MTA2","avatar_url":"https://avatars0.githubusercontent.com/u/33468106?v=4","gravatar_id":"","url":"https://api.github.com/users/latha-subramanian","html_url":"https://github.com/latha-subramanian","followers_url":"https://api.github.com/users/latha-subramanian/followers","following_url":"https://api.github.com/users/latha-subramanian/following{/other_user}","gists_url":"https://api.github.com/users/latha-subramanian/gists{/gist_id}","starred_url":"https://api.github.com/users/latha-subramanian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latha-subramanian/subscriptions","organizations_url":"https://api.github.com/users/latha-subramanian/orgs","repos_url":"https://api.github.com/users/latha-subramanian/repos","events_url":"https://api.github.com/users/latha-subramanian/events{/privacy}","received_events_url":"https://api.github.com/users/latha-subramanian/received_events","type":"User","site_admin":false},"body":"Yes. revert_to_defaults() is deleting the hooks anyways. removing this code from the test.","created_at":"2018-09-11T17:36:14Z","updated_at":"2018-09-11T17:36:14Z","html_url":"https://github.com/PBSPro/pbspro/pull/805#discussion_r216755948","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/805","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/216755948"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/805#discussion_r216755948"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/805"}},"in_reply_to_id":216508287},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/805","id":214351969,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzUxOTY5","html_url":"https://github.com/PBSPro/pbspro/pull/805","diff_url":"https://github.com/PBSPro/pbspro/pull/805.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/805.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/805","number":805,"state":"open","locked":false,"title":"TestOfflineVnode - Race condition in momhook file copy","user":{"login":"latha-subramanian","id":33468106,"node_id":"MDQ6VXNlcjMzNDY4MTA2","avatar_url":"https://avatars0.githubusercontent.com/u/33468106?v=4","gravatar_id":"","url":"https://api.github.com/users/latha-subramanian","html_url":"https://github.com/latha-subramanian","followers_url":"https://api.github.com/users/latha-subramanian/followers","following_url":"https://api.github.com/users/latha-subramanian/following{/other_user}","gists_url":"https://api.github.com/users/latha-subramanian/gists{/gist_id}","starred_url":"https://api.github.com/users/latha-subramanian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latha-subramanian/subscriptions","organizations_url":"https://api.github.com/users/latha-subramanian/orgs","repos_url":"https://api.github.com/users/latha-subramanian/repos","events_url":"https://api.github.com/users/latha-subramanian/events{/privacy}","received_events_url":"https://api.github.com/users/latha-subramanian/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Bug/feature Description\r\nIntermittent test failures in TestOfflineVode due to mom hook sync timing issues\r\n\r\n#### Affected Platform(s)\r\n* All Linux platforms\r\n\r\n#### Cause / Analysis / Design\r\nThere is a race condition between the mom hook files copy and subsequent operations by the test.  The test does not check if the hook files were successfully copied to the mom, before expecting the fail actions. Delay in mom hook file copy causes tests to fail intermittently in some test bed machines.\r\n\r\n#### Solution Description\r\nAdd checks in the test to confirm successful copy of the hook files to the mom, before expecting fail actions. On tearDown, delete hooks created by the tests.\r\n\r\n#### Testing logs/output\r\n\r\n\r\n[TestOfflinevnode_beforefix.txt](https://github.com/PBSPro/pbspro/files/2367189/TestOfflinevnode_beforefix.txt)\r\n\r\n[TestOfflinevnode_afterfix.txt](https://github.com/PBSPro/pbspro/files/2367190/TestOfflinevnode_afterfix.txt)\r\n\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n   - [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n   - [ ] I have added  **manual test(s) to this pull request and explained why PTL is not appropriate** for this case.\r\n- [ ] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to this pull request** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__","created_at":"2018-09-10T15:20:55Z","updated_at":"2018-09-11T17:36:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"679488b114e177edad3ff5c5f73a2c9c88d19b81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/805/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/805/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/805/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/9eb4c46f2fefdb42d4b8a4d15d3f438ef95de488","head":{"label":"latha-subramanian:test_momhookrace","ref":"test_momhookrace","sha":"9eb4c46f2fefdb42d4b8a4d15d3f438ef95de488","user":{"login":"latha-subramanian","id":33468106,"node_id":"MDQ6VXNlcjMzNDY4MTA2","avatar_url":"https://avatars0.githubusercontent.com/u/33468106?v=4","gravatar_id":"","url":"https://api.github.com/users/latha-subramanian","html_url":"https://github.com/latha-subramanian","followers_url":"https://api.github.com/users/latha-subramanian/followers","following_url":"https://api.github.com/users/latha-subramanian/following{/other_user}","gists_url":"https://api.github.com/users/latha-subramanian/gists{/gist_id}","starred_url":"https://api.github.com/users/latha-subramanian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latha-subramanian/subscriptions","organizations_url":"https://api.github.com/users/latha-subramanian/orgs","repos_url":"https://api.github.com/users/latha-subramanian/repos","events_url":"https://api.github.com/users/latha-subramanian/events{/privacy}","received_events_url":"https://api.github.com/users/latha-subramanian/received_events","type":"User","site_admin":false},"repo":{"id":110583203,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1ODMyMDM=","name":"pbspro","full_name":"latha-subramanian/pbspro","owner":{"login":"latha-subramanian","id":33468106,"node_id":"MDQ6VXNlcjMzNDY4MTA2","avatar_url":"https://avatars0.githubusercontent.com/u/33468106?v=4","gravatar_id":"","url":"https://api.github.com/users/latha-subramanian","html_url":"https://github.com/latha-subramanian","followers_url":"https://api.github.com/users/latha-subramanian/followers","following_url":"https://api.github.com/users/latha-subramanian/following{/other_user}","gists_url":"https://api.github.com/users/latha-subramanian/gists{/gist_id}","starred_url":"https://api.github.com/users/latha-subramanian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latha-subramanian/subscriptions","organizations_url":"https://api.github.com/users/latha-subramanian/orgs","repos_url":"https://api.github.com/users/latha-subramanian/repos","events_url":"https://api.github.com/users/latha-subramanian/events{/privacy}","received_events_url":"https://api.github.com/users/latha-subramanian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/latha-subramanian/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/latha-subramanian/pbspro","forks_url":"https://api.github.com/repos/latha-subramanian/pbspro/forks","keys_url":"https://api.github.com/repos/latha-subramanian/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/latha-subramanian/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/latha-subramanian/pbspro/teams","hooks_url":"https://api.github.com/repos/latha-subramanian/pbspro/hooks","issue_events_url":"https://api.github.com/repos/latha-subramanian/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/latha-subramanian/pbspro/events","assignees_url":"https://api.github.com/repos/latha-subramanian/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/latha-subramanian/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/latha-subramanian/pbspro/tags","blobs_url":"https://api.github.com/repos/latha-subramanian/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/latha-subramanian/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/latha-subramanian/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/latha-subramanian/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/latha-subramanian/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/latha-subramanian/pbspro/languages","stargazers_url":"https://api.github.com/repos/latha-subramanian/pbspro/stargazers","contributors_url":"https://api.github.com/repos/latha-subramanian/pbspro/contributors","subscribers_url":"https://api.github.com/repos/latha-subramanian/pbspro/subscribers","subscription_url":"https://api.github.com/repos/latha-subramanian/pbspro/subscription","commits_url":"https://api.github.com/repos/latha-subramanian/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/latha-subramanian/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/latha-subramanian/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/latha-subramanian/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/latha-subramanian/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/latha-subramanian/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/latha-subramanian/pbspro/merges","archive_url":"https://api.github.com/repos/latha-subramanian/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/latha-subramanian/pbspro/downloads","issues_url":"https://api.github.com/repos/latha-subramanian/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/latha-subramanian/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/latha-subramanian/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/latha-subramanian/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/latha-subramanian/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/latha-subramanian/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/latha-subramanian/pbspro/deployments","created_at":"2017-11-13T18:07:35Z","updated_at":"2018-09-07T20:43:18Z","pushed_at":"2018-09-11T17:35:10Z","git_url":"git://github.com/latha-subramanian/pbspro.git","ssh_url":"git@github.com:latha-subramanian/pbspro.git","clone_url":"https://github.com/latha-subramanian/pbspro.git","svn_url":"https://github.com/latha-subramanian/pbspro","homepage":"www.pbspro.org","size":15890,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"5b3c404054a0d1ac95a6891ec2dec33843234ead","user":{"login":"PBSPro","id":19280436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjgwNDM2","avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"node_id":"MDEwOlJlcG9zaXRvcnk1OTA4MjA3Mg==","name":"pbspro","full_name":"PBSPro/pbspro","owner":{"login":"PBSPro","id":19280436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjgwNDM2","avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2018-09-07T07:46:25Z","pushed_at":"2018-09-11T17:35:12Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":15912,"stargazers_count":195,"watchers_count":195,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":151,"open_issues":17,"watchers":195,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/805"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/805"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/805"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/805/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/805/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/805/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/9eb4c46f2fefdb42d4b8a4d15d3f438ef95de488"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"latha-subramanian"}}