{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/175615314","pull_request_review_id":105173627,"id":175615314,"diff_hunk":"@@ -90,6 +90,133 @@ type Backends struct {\n \tnamer        *utils.Namer\n }\n \n+// BackendService embeds both the GA and alpha compute BackendService types\n+type BackendService struct {\n+\tAlpha *computealpha.BackendService\n+\tGa    *compute.BackendService\n+\t// Flag to indicate we want to use the Alpha compute type\n+\tisAlpha bool\n+}\n+\n+// GetProtocol gets the Protocol off the correct BackendService\n+func (be *BackendService) GetProtocol() string {\n+\tif be.isAlpha {\n+\t\treturn be.Alpha.Protocol\n+\t}\n+\n+\treturn be.Ga.Protocol\n+}\n+\n+// GetDescription gets the Description off the correct BackendService\n+func (be *BackendService) GetDescription() string {\n+\tif be.isAlpha {\n+\t\treturn be.Alpha.Description\n+\t}\n+\n+\treturn be.Ga.Description\n+}\n+\n+// GetHealthCheckLink gets the Healthcheck link off the correct BackendService\n+func (be *BackendService) GetHealthCheckLink() string {\n+\tif be.isAlpha && len(be.Alpha.HealthChecks) == 1 {\n+\t\treturn be.Alpha.HealthChecks[0]\n+\t} else if len(be.Ga.HealthChecks) == 1 {","path":"pkg/backends/backends.go","position":34,"original_position":34,"commit_id":"4955018e7192176a4514614e95368b4f6835f5d3","original_commit_id":"4955018e7192176a4514614e95368b4f6835f5d3","user":{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"body":"you don't need `else` here","created_at":"2018-03-19T23:19:17Z","updated_at":"2018-03-19T23:26:53Z","html_url":"https://github.com/kubernetes/ingress-gce/pull/146#discussion_r175615314","pull_request_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/146","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments/175615314"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/146#discussion_r175615314"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/146"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/146","id":173819024,"html_url":"https://github.com/kubernetes/ingress-gce/pull/146","diff_url":"https://github.com/kubernetes/ingress-gce/pull/146.diff","patch_url":"https://github.com/kubernetes/ingress-gce/pull/146.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/146","number":146,"state":"open","locked":false,"title":"Ingress HTTP/2 Support","user":{"login":"agau4779","id":1696790,"avatar_url":"https://avatars2.githubusercontent.com/u/1696790?v=4","gravatar_id":"","url":"https://api.github.com/users/agau4779","html_url":"https://github.com/agau4779","followers_url":"https://api.github.com/users/agau4779/followers","following_url":"https://api.github.com/users/agau4779/following{/other_user}","gists_url":"https://api.github.com/users/agau4779/gists{/gist_id}","starred_url":"https://api.github.com/users/agau4779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agau4779/subscriptions","organizations_url":"https://api.github.com/users/agau4779/orgs","repos_url":"https://api.github.com/users/agau4779/repos","events_url":"https://api.github.com/users/agau4779/events{/privacy}","received_events_url":"https://api.github.com/users/agau4779/received_events","type":"User","site_admin":false},"body":"- Adds HTTP2 annotation to Service\r\n- Creates alpha HealthCheck and BackendService resources when the protocol is HTTP/2, by using a composite BackendService type\r\n- Tests for HealthCheck/BackendServices using HTTP/2","created_at":"2018-03-08T18:52:00Z","updated_at":"2018-03-19T23:26:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34356ad0c17c488d9da46e20f25968e397adcba6","assignee":{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false},"assignees":[{"login":"nicksardo","id":184976,"avatar_url":"https://avatars0.githubusercontent.com/u/184976?v=4","gravatar_id":"","url":"https://api.github.com/users/nicksardo","html_url":"https://github.com/nicksardo","followers_url":"https://api.github.com/users/nicksardo/followers","following_url":"https://api.github.com/users/nicksardo/following{/other_user}","gists_url":"https://api.github.com/users/nicksardo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicksardo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicksardo/subscriptions","organizations_url":"https://api.github.com/users/nicksardo/orgs","repos_url":"https://api.github.com/users/nicksardo/repos","events_url":"https://api.github.com/users/nicksardo/events{/privacy}","received_events_url":"https://api.github.com/users/nicksardo/received_events","type":"User","site_admin":false},{"login":"bowei","id":837034,"avatar_url":"https://avatars1.githubusercontent.com/u/837034?v=4","gravatar_id":"","url":"https://api.github.com/users/bowei","html_url":"https://github.com/bowei","followers_url":"https://api.github.com/users/bowei/followers","following_url":"https://api.github.com/users/bowei/following{/other_user}","gists_url":"https://api.github.com/users/bowei/gists{/gist_id}","starred_url":"https://api.github.com/users/bowei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bowei/subscriptions","organizations_url":"https://api.github.com/users/bowei/orgs","repos_url":"https://api.github.com/users/bowei/repos","events_url":"https://api.github.com/users/bowei/events{/privacy}","received_events_url":"https://api.github.com/users/bowei/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712525210,"url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":716477038,"url":"https://api.github.com/repos/kubernetes/ingress-gce/labels/size/XL","name":"size/XL","color":"ee5500","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/146/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/146/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/146/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/4955018e7192176a4514614e95368b4f6835f5d3","head":{"label":"agau4779:http2","ref":"http2","sha":"4955018e7192176a4514614e95368b4f6835f5d3","user":{"login":"agau4779","id":1696790,"avatar_url":"https://avatars2.githubusercontent.com/u/1696790?v=4","gravatar_id":"","url":"https://api.github.com/users/agau4779","html_url":"https://github.com/agau4779","followers_url":"https://api.github.com/users/agau4779/followers","following_url":"https://api.github.com/users/agau4779/following{/other_user}","gists_url":"https://api.github.com/users/agau4779/gists{/gist_id}","starred_url":"https://api.github.com/users/agau4779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agau4779/subscriptions","organizations_url":"https://api.github.com/users/agau4779/orgs","repos_url":"https://api.github.com/users/agau4779/repos","events_url":"https://api.github.com/users/agau4779/events{/privacy}","received_events_url":"https://api.github.com/users/agau4779/received_events","type":"User","site_admin":false},"repo":{"id":123482031,"name":"ingress-gce","full_name":"agau4779/ingress-gce","owner":{"login":"agau4779","id":1696790,"avatar_url":"https://avatars2.githubusercontent.com/u/1696790?v=4","gravatar_id":"","url":"https://api.github.com/users/agau4779","html_url":"https://github.com/agau4779","followers_url":"https://api.github.com/users/agau4779/followers","following_url":"https://api.github.com/users/agau4779/following{/other_user}","gists_url":"https://api.github.com/users/agau4779/gists{/gist_id}","starred_url":"https://api.github.com/users/agau4779/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agau4779/subscriptions","organizations_url":"https://api.github.com/users/agau4779/orgs","repos_url":"https://api.github.com/users/agau4779/repos","events_url":"https://api.github.com/users/agau4779/events{/privacy}","received_events_url":"https://api.github.com/users/agau4779/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agau4779/ingress-gce","description":"Ingress controller for Google Cloud","fork":true,"url":"https://api.github.com/repos/agau4779/ingress-gce","forks_url":"https://api.github.com/repos/agau4779/ingress-gce/forks","keys_url":"https://api.github.com/repos/agau4779/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agau4779/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agau4779/ingress-gce/teams","hooks_url":"https://api.github.com/repos/agau4779/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/agau4779/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/agau4779/ingress-gce/events","assignees_url":"https://api.github.com/repos/agau4779/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/agau4779/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/agau4779/ingress-gce/tags","blobs_url":"https://api.github.com/repos/agau4779/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agau4779/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agau4779/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/agau4779/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agau4779/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/agau4779/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/agau4779/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/agau4779/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/agau4779/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/agau4779/ingress-gce/subscription","commits_url":"https://api.github.com/repos/agau4779/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/agau4779/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/agau4779/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/agau4779/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/agau4779/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/agau4779/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agau4779/ingress-gce/merges","archive_url":"https://api.github.com/repos/agau4779/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agau4779/ingress-gce/downloads","issues_url":"https://api.github.com/repos/agau4779/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/agau4779/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/agau4779/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/agau4779/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agau4779/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/agau4779/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/agau4779/ingress-gce/deployments","created_at":"2018-03-01T19:24:13Z","updated_at":"2018-03-01T19:24:15Z","pushed_at":"2018-03-19T22:09:58Z","git_url":"git://github.com/agau4779/ingress-gce.git","ssh_url":"git@github.com:agau4779/ingress-gce.git","clone_url":"https://github.com/agau4779/ingress-gce.git","svn_url":"https://github.com/agau4779/ingress-gce","homepage":"","size":33427,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"33b231cff57eaaa5e3fe8c7e234f98ba88c22ac9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":105967469,"name":"ingress-gce","full_name":"kubernetes/ingress-gce","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/ingress-gce","description":"Ingress controller for Google Cloud","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-gce","forks_url":"https://api.github.com/repos/kubernetes/ingress-gce/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-gce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-gce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-gce/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-gce/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-gce/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-gce/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-gce/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-gce/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-gce/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-gce/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-gce/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-gce/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-gce/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-gce/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-gce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-gce/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-gce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-gce/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-gce/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-gce/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-gce/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-gce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-gce/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-gce/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-gce/deployments","created_at":"2017-10-06T04:32:12Z","updated_at":"2018-03-19T16:57:41Z","pushed_at":"2018-03-19T22:09:59Z","git_url":"git://github.com/kubernetes/ingress-gce.git","ssh_url":"git@github.com:kubernetes/ingress-gce.git","clone_url":"https://github.com/kubernetes/ingress-gce.git","svn_url":"https://github.com/kubernetes/ingress-gce","homepage":"","size":33408,"stargazers_count":146,"watchers_count":146,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":42,"license":null,"forks":47,"open_issues":42,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/146"},"html":{"href":"https://github.com/kubernetes/ingress-gce/pull/146"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/146"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/issues/146/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/146/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/pulls/146/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-gce/statuses/4955018e7192176a4514614e95368b4f6835f5d3"}},"author_association":"NONE"}}
{"actor":{"display_login":"bowei"}}