{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/21348","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/21348/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/21348/comments","events_url":"https://api.github.com/repos/servo/servo/issues/21348/events","html_url":"https://github.com/servo/servo/pull/21348","id":348024503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NDczMjc3","number":21348,"title":"Replace Servo DL items with WR ones","user":{"login":"pyfisch","id":2781017,"node_id":"MDQ6VXNlcjI3ODEwMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2781017?v=4","gravatar_id":"","url":"https://api.github.com/users/pyfisch","html_url":"https://github.com/pyfisch","followers_url":"https://api.github.com/users/pyfisch/followers","following_url":"https://api.github.com/users/pyfisch/following{/other_user}","gists_url":"https://api.github.com/users/pyfisch/gists{/gist_id}","starred_url":"https://api.github.com/users/pyfisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyfisch/subscriptions","organizations_url":"https://api.github.com/users/pyfisch/orgs","repos_url":"https://api.github.com/users/pyfisch/repos","events_url":"https://api.github.com/users/pyfisch/events{/privacy}","received_events_url":"https://api.github.com/users/pyfisch/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"node_id":"MDU6TGFiZWwxNTIzMTAwNDM=","url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"asajeffrey","id":403333,"node_id":"MDQ6VXNlcjQwMzMzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false},"assignees":[{"login":"asajeffrey","id":403333,"node_id":"MDQ6VXNlcjQwMzMzMw==","avatar_url":"https://avatars1.githubusercontent.com/u/403333?v=4","gravatar_id":"","url":"https://api.github.com/users/asajeffrey","html_url":"https://github.com/asajeffrey","followers_url":"https://api.github.com/users/asajeffrey/followers","following_url":"https://api.github.com/users/asajeffrey/following{/other_user}","gists_url":"https://api.github.com/users/asajeffrey/gists{/gist_id}","starred_url":"https://api.github.com/users/asajeffrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asajeffrey/subscriptions","organizations_url":"https://api.github.com/users/asajeffrey/orgs","repos_url":"https://api.github.com/users/asajeffrey/repos","events_url":"https://api.github.com/users/asajeffrey/events{/privacy}","received_events_url":"https://api.github.com/users/asajeffrey/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-08-06T17:58:58Z","updated_at":"2018-08-07T07:29:20Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/21348","html_url":"https://github.com/servo/servo/pull/21348","diff_url":"https://github.com/servo/servo/pull/21348.diff","patch_url":"https://github.com/servo/servo/pull/21348.patch"},"body":"The Servo internal display list items are already pretty much\r\nequivalent to the WebRender ones. Except that Servo items contain\r\nbase information and associated glyphs and gradient stops which are\r\nstored implicitly in WebRender. Remove the display items for\r\nrectangles, text, images, border, gradients and box shadow and\r\nreplace them with their WebRender counter parts.\r\n\r\nSome more internal items like line, text shadow and iframe can definitively be replaced with WebRender equivalents but I think the PR is already quite huge. If WebRender would expose a quite minimal API which allowed servo to directly push items onto the display list most of webrender_helpers boilerplate code could go away. As WebRender performs normalization of gradients this would need to be called by servo explicitly in this case.\r\n\r\nIt should be noted that gradient borders don't actually work neither with the old version nor with this PR as the measurements are all set to zero.\r\n\r\nPart of #19676\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/21348)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/410961671","html_url":"https://github.com/servo/servo/pull/21348#issuecomment-410961671","issue_url":"https://api.github.com/repos/servo/servo/issues/21348","id":410961671,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDk2MTY3MQ==","user":{"login":"bors-servo","id":4368172,"node_id":"MDQ6VXNlcjQzNjgxNzI=","avatar_url":"https://avatars1.githubusercontent.com/u/4368172?v=4","gravatar_id":"","url":"https://api.github.com/users/bors-servo","html_url":"https://github.com/bors-servo","followers_url":"https://api.github.com/users/bors-servo/followers","following_url":"https://api.github.com/users/bors-servo/following{/other_user}","gists_url":"https://api.github.com/users/bors-servo/gists{/gist_id}","starred_url":"https://api.github.com/users/bors-servo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors-servo/subscriptions","organizations_url":"https://api.github.com/users/bors-servo/orgs","repos_url":"https://api.github.com/users/bors-servo/repos","events_url":"https://api.github.com/users/bors-servo/events{/privacy}","received_events_url":"https://api.github.com/users/bors-servo/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T07:29:20Z","updated_at":"2018-08-07T07:29:20Z","author_association":"CONTRIBUTOR","body":":hourglass: Trying commit 3d2957c737f63105c12fd09b1c4bd6dbe6321719 with merge e373497b6c928a5474bfad26bff1d5816d3e75c4..."}}
{"actor":{"display_login":"bors-servo"}}