{"action":"created","issue":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3389","repository_url":"https://api.github.com/repos/OpenLiberty/open-liberty","labels_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3389/labels{/name}","comments_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3389/comments","events_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3389/events","html_url":"https://github.com/OpenLiberty/open-liberty/issues/3389","id":319293646,"number":3389,"title":"Clash on /metrics, /health between mpMetrics, mpHealth and Spring Boot actuators","user":{"login":"tjwatson","id":656475,"avatar_url":"https://avatars3.githubusercontent.com/u/656475?v=4","gravatar_id":"","url":"https://api.github.com/users/tjwatson","html_url":"https://github.com/tjwatson","followers_url":"https://api.github.com/users/tjwatson/followers","following_url":"https://api.github.com/users/tjwatson/following{/other_user}","gists_url":"https://api.github.com/users/tjwatson/gists{/gist_id}","starred_url":"https://api.github.com/users/tjwatson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjwatson/subscriptions","organizations_url":"https://api.github.com/users/tjwatson/orgs","repos_url":"https://api.github.com/users/tjwatson/repos","events_url":"https://api.github.com/users/tjwatson/events{/privacy}","received_events_url":"https://api.github.com/users/tjwatson/received_events","type":"User","site_admin":false},"labels":[{"id":738848802,"url":"https://api.github.com/repos/OpenLiberty/open-liberty/labels/in:SpringBoot","name":"in:SpringBoot","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-01T19:07:25Z","updated_at":"2018-05-02T16:46:49Z","closed_at":null,"author_association":"MEMBER","body":"The mpMetrics features (1.0 and 1.1) in Liberty use the `/metrics` URI for endpoint for their REST API, see: https://www.ibm.com/support/knowledgecenter/en/SSD28V_9.0.0/com.ibm.websphere.wlp.core.doc/ae/twlp_mp_metrics_monitor.html\r\n\r\nThe Spring Boot actuator also uses the metrics/ URI endpoint, see https://docs.spring.io/spring-boot/docs/current/reference/html/production-ready-endpoints.html\r\n\r\nBy default Spring Boot applications take over the \"/\" context-path and Spring Boot actuators use the /metrics URI within the context of the Spring Boot context-path.  The mpMetrics also tries to take over the /metrics URI for the server.  Need to determine how the two clash and which one \"wins\".  I think we need to ensure the spring boot actuator endpoint wins for the /metrics endpoint.  If that is not possible we need to provide a warning of some sorts."},"comment":{"url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/comments/386044094","html_url":"https://github.com/OpenLiberty/open-liberty/issues/3389#issuecomment-386044094","issue_url":"https://api.github.com/repos/OpenLiberty/open-liberty/issues/3389","id":386044094,"user":{"login":"anjumfatima90","id":31773161,"avatar_url":"https://avatars2.githubusercontent.com/u/31773161?v=4","gravatar_id":"","url":"https://api.github.com/users/anjumfatima90","html_url":"https://github.com/anjumfatima90","followers_url":"https://api.github.com/users/anjumfatima90/followers","following_url":"https://api.github.com/users/anjumfatima90/following{/other_user}","gists_url":"https://api.github.com/users/anjumfatima90/gists{/gist_id}","starred_url":"https://api.github.com/users/anjumfatima90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anjumfatima90/subscriptions","organizations_url":"https://api.github.com/users/anjumfatima90/orgs","repos_url":"https://api.github.com/users/anjumfatima90/repos","events_url":"https://api.github.com/users/anjumfatima90/events{/privacy}","received_events_url":"https://api.github.com/users/anjumfatima90/received_events","type":"User","site_admin":false},"created_at":"2018-05-02T16:46:49Z","updated_at":"2018-05-02T16:46:49Z","author_association":"CONTRIBUTOR","body":"We need to determine if mpMetrics or mpHealth features are enabled then give some kind of warning that </metrics> and </health> are already taken to make sure that the users use </metrics.json> and </health.json> for spring boot actuator endpoints."}}
{"actor":{"display_login":"anjumfatima90"}}