{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cordova-ios/issues/382","repository_url":"https://api.github.com/repos/apache/cordova-ios","labels_url":"https://api.github.com/repos/apache/cordova-ios/issues/382/labels{/name}","comments_url":"https://api.github.com/repos/apache/cordova-ios/issues/382/comments","events_url":"https://api.github.com/repos/apache/cordova-ios/issues/382/events","html_url":"https://github.com/apache/cordova-ios/pull/382","id":345554274,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjU2MzM1","number":382,"title":"WIP - update dev deps with additional TODO list","user":{"login":"brodybits","id":1559888,"node_id":"MDQ6VXNlcjE1NTk4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1559888?v=4","gravatar_id":"","url":"https://api.github.com/users/brodybits","html_url":"https://github.com/brodybits","followers_url":"https://api.github.com/users/brodybits/followers","following_url":"https://api.github.com/users/brodybits/following{/other_user}","gists_url":"https://api.github.com/users/brodybits/gists{/gist_id}","starred_url":"https://api.github.com/users/brodybits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brodybits/subscriptions","organizations_url":"https://api.github.com/users/brodybits/orgs","repos_url":"https://api.github.com/users/brodybits/repos","events_url":"https://api.github.com/users/brodybits/events{/privacy}","received_events_url":"https://api.github.com/users/brodybits/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-29T19:02:23Z","updated_at":"2018-08-01T18:52:29Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/cordova-ios/pulls/382","html_url":"https://github.com/apache/cordova-ios/pull/382","diff_url":"https://github.com/apache/cordova-ios/pull/382.diff","patch_url":"https://github.com/apache/cordova-ios/pull/382.patch"},"body":"<!--\r\nPlease make sure the checklist boxes are all checked before submitting the PR. The checklist\r\nis intended as a quick reference, for complete details please see our Contributor Guidelines:\r\n\r\nhttp://cordova.apache.org/contribute/contribute_guidelines.html\r\n\r\nThanks!\r\n-->\r\n\r\n### Platforms affected\r\n\r\niOS\r\n\r\n### What does this PR do?\r\n\r\nUpdate devDependencies in `master` branch:\r\n- remove `nodeunit`\r\n- _update `jasmine`, `rewire`, and `tmp`_\r\n- _update `eslint` devDependencies, using eslint-config-standard@next (^12.0.0-alpha.0) to resolve `[ESLINT_LEGACY_OBJECT_REST_SPREAD]` DeprecationWarning (<https://github.com/standard/eslint-config-standard/issues/123#issuecomment-404772247>)_\r\n\r\n_(includes fix to simplify AppVeyor CI install, ~~which now passes on all covered Node.js versions including deprecated Node.js version 4 as proposed in GH-383~~ *no longer passes on deprecated Node.js 4 version due to eslint update*)_\r\n\r\n_This can be considered a continuation of the devDep cleanup merged from GH-368._\r\n\r\nTODO:\r\n- ~~migrate from `istanbul` to `nyc`~~ _(**definitely** outside the scope of this PR, already proposed in GH-377)_\r\n- [x] ~~try updating other devDependencies: `jasmine`, `rewire`, `tmp`~~\r\n\r\n_TO BE MOVED OUT OF THIS PR:_\r\n- _update `eslint` devDependencies - breaks on deprecated Node.js 4 version; suffers from `[ESLINT_LEGACY_OBJECT_REST_SPREAD]` DeprecationWarning (<https://github.com/standard/eslint-config-standard/issues/123#issuecomment-404772247>)_\r\n\r\n_Extra TODO items outside this PR:_\r\n- [ ] _fix AppVeyor CI as done by dropping support for deprecated Node.js 4 as proposed by GH-375_\r\n- [ ] _drop support for deprecated Node.js 4 version (GH-375), completely remove `node_modules`, drop `bundledDependencies`, and mark next major version_\r\n- [ ] update `dependencies`, which should resolve existing `npm audit` issues _as_ was already done in GH-381 for patch release\r\n- [ ] _review GH-376 - Fixed Get Apple OSX Version method_\r\n- [ ] _GH-377 - increase code coverage and migrate to nyc_\r\n- [ ] _apply similar fixes to cordova-osx (mac OS)_\r\n- [ ] _check if similar fixes are needed on the other platforms_\r\n- [ ] _check if any other Cordova packages still need nyc_\r\n\r\n### What testing has been done on this change?\r\n\r\n- [x] `npm run unit-tests` succeeds on mac \"desktop\"\r\n- [x] check that `npm test` items succeed on Travis CI _(skipping deprecated Node.js 4 version due to eslint update)_\r\n- [x] check that `eslint` & `npm run unit-tests` items succeed on AppVeyor CI ~~_(now passes on all covered Node.js versions including deprecated Node.js version 4 if fix proposed in GH-383 is included)_~~ _(skipping deprecated Node.js 4 version due to eslint update)_\r\n\r\n### Checklist\r\n\r\n- ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~\r\n- ~~Commit message follows the format: \"CB-3232: (android) Fix bug with resolving file paths\", where CB-xxxx is the JIRA ID & \"android\" is the platform affected.~~\r\n- ~~Added automated test coverage as appropriate for this change.~~"},"comment":{"url":"https://api.github.com/repos/apache/cordova-ios/issues/comments/409683246","html_url":"https://github.com/apache/cordova-ios/pull/382#issuecomment-409683246","issue_url":"https://api.github.com/repos/apache/cordova-ios/issues/382","id":409683246,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTY4MzI0Ng==","user":{"login":"brodybits","id":1559888,"node_id":"MDQ6VXNlcjE1NTk4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1559888?v=4","gravatar_id":"","url":"https://api.github.com/users/brodybits","html_url":"https://github.com/brodybits","followers_url":"https://api.github.com/users/brodybits/followers","following_url":"https://api.github.com/users/brodybits/following{/other_user}","gists_url":"https://api.github.com/users/brodybits/gists{/gist_id}","starred_url":"https://api.github.com/users/brodybits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brodybits/subscriptions","organizations_url":"https://api.github.com/users/brodybits/orgs","repos_url":"https://api.github.com/users/brodybits/repos","events_url":"https://api.github.com/users/brodybits/events{/privacy}","received_events_url":"https://api.github.com/users/brodybits/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T18:52:29Z","updated_at":"2018-08-01T18:52:29Z","author_association":"CONTRIBUTOR","body":"This PR includes extra items that I will be moving out:\r\n- eslint-* updates\r\n- additional TODO list"}}
{"actor":{"display_login":"brodybits"}}