{"action":"created","comment":{"url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/comments/203437863","pull_request_review_id":138327254,"id":203437863,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzQzNzg2Mw==","diff_hunk":"@@ -67,9 +67,8 @@ function simulate(parameters, biomass; concentration::Vector{Float64}=rand(Float\n \n   affect_function = parameters[:rewire_method] == :none ? remove_species! : remove_species_and_rewire!\n \n-  extinction_callback = DiscreteCallback(species_under_extinction_threshold, affect_function)\n-  sol = solve(prob, alg, callback = extinction_callback, saveat=t_keep, dense=false, save_timeseries=false)\n-\n+  extinction_callback = DiscreteCallback(species_under_extinction_threshold, affect_function; save_positions=(true,true))\n+  sol = solve(prob, alg, callback = CallbackSet(extinction_callback, PositiveDomain()), saveat=t_keep, dense=false, save_timeseries=false, force_dtmin=true)","path":"src/simulate.jl","position":null,"original_position":23,"commit_id":"367ab51215f522469c42d02e61e8feda233750f2","original_commit_id":"367ab51215f522469c42d02e61e8feda233750f2","user":{"login":"ChrisRackauckas","id":1814174,"node_id":"MDQ6VXNlcjE4MTQxNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1814174?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisRackauckas","html_url":"https://github.com/ChrisRackauckas","followers_url":"https://api.github.com/users/ChrisRackauckas/followers","following_url":"https://api.github.com/users/ChrisRackauckas/following{/other_user}","gists_url":"https://api.github.com/users/ChrisRackauckas/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisRackauckas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisRackauckas/subscriptions","organizations_url":"https://api.github.com/users/ChrisRackauckas/orgs","repos_url":"https://api.github.com/users/ChrisRackauckas/repos","events_url":"https://api.github.com/users/ChrisRackauckas/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisRackauckas/received_events","type":"User","site_admin":false},"body":"Ahh, there could be some issue in the callback since I got this issue I forgot about: https://github.com/JuliaDiffEq/DiffEqCallbacks.jl/issues/44","created_at":"2018-07-18T16:04:42Z","updated_at":"2018-07-18T16:04:42Z","html_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl/pull/58#discussion_r203437863","pull_request_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/58","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/comments/203437863"},"html":{"href":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl/pull/58#discussion_r203437863"},"pull_request":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/58"}},"in_reply_to_id":203433199},"pull_request":{"url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/58","id":202290599,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjkwNTk5","html_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl/pull/58","diff_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl/pull/58.diff","patch_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl/pull/58.patch","issue_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues/58","number":58,"state":"open","locked":false,"title":"Correct the callback for extinctions","user":{"login":"tpoisot","id":579329,"node_id":"MDQ6VXNlcjU3OTMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/579329?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoisot","html_url":"https://github.com/tpoisot","followers_url":"https://api.github.com/users/tpoisot/followers","following_url":"https://api.github.com/users/tpoisot/following{/other_user}","gists_url":"https://api.github.com/users/tpoisot/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoisot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoisot/subscriptions","organizations_url":"https://api.github.com/users/tpoisot/orgs","repos_url":"https://api.github.com/users/tpoisot/repos","events_url":"https://api.github.com/users/tpoisot/events{/privacy}","received_events_url":"https://api.github.com/users/tpoisot/received_events","type":"User","site_admin":false},"body":"@evadelmas  I'm pretty sure these changes correct the behavior of the callback for extinctions (and also make the code simpler in `simulate`) -- I have no negative biomasses on the few simulations I ran.","created_at":"2018-07-18T15:22:10Z","updated_at":"2018-07-18T16:04:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c4bddd50364798069399f8d03acc604457d55cea","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/58/commits","review_comments_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/58/comments","review_comment_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues/58/comments","statuses_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/statuses/367ab51215f522469c42d02e61e8feda233750f2","head":{"label":"PoisotLab:next-speed","ref":"next-speed","sha":"367ab51215f522469c42d02e61e8feda233750f2","user":{"login":"PoisotLab","id":7968754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Njg3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7968754?v=4","gravatar_id":"","url":"https://api.github.com/users/PoisotLab","html_url":"https://github.com/PoisotLab","followers_url":"https://api.github.com/users/PoisotLab/followers","following_url":"https://api.github.com/users/PoisotLab/following{/other_user}","gists_url":"https://api.github.com/users/PoisotLab/gists{/gist_id}","starred_url":"https://api.github.com/users/PoisotLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PoisotLab/subscriptions","organizations_url":"https://api.github.com/users/PoisotLab/orgs","repos_url":"https://api.github.com/users/PoisotLab/repos","events_url":"https://api.github.com/users/PoisotLab/events{/privacy}","received_events_url":"https://api.github.com/users/PoisotLab/received_events","type":"Organization","site_admin":false},"repo":{"id":70102258,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEwMjI1OA==","name":"BioEnergeticFoodWebs.jl","full_name":"PoisotLab/BioEnergeticFoodWebs.jl","owner":{"login":"PoisotLab","id":7968754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Njg3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7968754?v=4","gravatar_id":"","url":"https://api.github.com/users/PoisotLab","html_url":"https://github.com/PoisotLab","followers_url":"https://api.github.com/users/PoisotLab/followers","following_url":"https://api.github.com/users/PoisotLab/following{/other_user}","gists_url":"https://api.github.com/users/PoisotLab/gists{/gist_id}","starred_url":"https://api.github.com/users/PoisotLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PoisotLab/subscriptions","organizations_url":"https://api.github.com/users/PoisotLab/orgs","repos_url":"https://api.github.com/users/PoisotLab/repos","events_url":"https://api.github.com/users/PoisotLab/events{/privacy}","received_events_url":"https://api.github.com/users/PoisotLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl","description":"A unified interface for simulations of the Bio-Energetic model on food webs","fork":false,"url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl","forks_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/forks","keys_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/teams","hooks_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/hooks","issue_events_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues/events{/number}","events_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/events","assignees_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/assignees{/user}","branches_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/branches{/branch}","tags_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/tags","blobs_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/languages","stargazers_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/stargazers","contributors_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/contributors","subscribers_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/subscribers","subscription_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/subscription","commits_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/contents/{+path}","compare_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/merges","archive_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/downloads","issues_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues{/number}","pulls_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/labels{/name}","releases_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/releases{/id}","deployments_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/deployments","created_at":"2016-10-05T21:51:27Z","updated_at":"2018-05-17T18:59:40Z","pushed_at":"2018-07-18T15:49:11Z","git_url":"git://github.com/PoisotLab/BioEnergeticFoodWebs.jl.git","ssh_url":"git@github.com:PoisotLab/BioEnergeticFoodWebs.jl.git","clone_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl.git","svn_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl","homepage":"http://poisotlab.io/BioEnergeticFoodWebs.jl/latest/","size":1920,"stargazers_count":8,"watchers_count":8,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":12,"watchers":8,"default_branch":"master"}},"base":{"label":"PoisotLab:next","ref":"next","sha":"1f1308adebea56a2e904cf9c7dfb0ba078fade0f","user":{"login":"PoisotLab","id":7968754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Njg3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7968754?v=4","gravatar_id":"","url":"https://api.github.com/users/PoisotLab","html_url":"https://github.com/PoisotLab","followers_url":"https://api.github.com/users/PoisotLab/followers","following_url":"https://api.github.com/users/PoisotLab/following{/other_user}","gists_url":"https://api.github.com/users/PoisotLab/gists{/gist_id}","starred_url":"https://api.github.com/users/PoisotLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PoisotLab/subscriptions","organizations_url":"https://api.github.com/users/PoisotLab/orgs","repos_url":"https://api.github.com/users/PoisotLab/repos","events_url":"https://api.github.com/users/PoisotLab/events{/privacy}","received_events_url":"https://api.github.com/users/PoisotLab/received_events","type":"Organization","site_admin":false},"repo":{"id":70102258,"node_id":"MDEwOlJlcG9zaXRvcnk3MDEwMjI1OA==","name":"BioEnergeticFoodWebs.jl","full_name":"PoisotLab/BioEnergeticFoodWebs.jl","owner":{"login":"PoisotLab","id":7968754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5Njg3NTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7968754?v=4","gravatar_id":"","url":"https://api.github.com/users/PoisotLab","html_url":"https://github.com/PoisotLab","followers_url":"https://api.github.com/users/PoisotLab/followers","following_url":"https://api.github.com/users/PoisotLab/following{/other_user}","gists_url":"https://api.github.com/users/PoisotLab/gists{/gist_id}","starred_url":"https://api.github.com/users/PoisotLab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PoisotLab/subscriptions","organizations_url":"https://api.github.com/users/PoisotLab/orgs","repos_url":"https://api.github.com/users/PoisotLab/repos","events_url":"https://api.github.com/users/PoisotLab/events{/privacy}","received_events_url":"https://api.github.com/users/PoisotLab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl","description":"A unified interface for simulations of the Bio-Energetic model on food webs","fork":false,"url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl","forks_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/forks","keys_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/teams","hooks_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/hooks","issue_events_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues/events{/number}","events_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/events","assignees_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/assignees{/user}","branches_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/branches{/branch}","tags_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/tags","blobs_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/refs{/sha}","trees_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/statuses/{sha}","languages_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/languages","stargazers_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/stargazers","contributors_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/contributors","subscribers_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/subscribers","subscription_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/subscription","commits_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/commits{/sha}","git_commits_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/git/commits{/sha}","comments_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/comments{/number}","issue_comment_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues/comments{/number}","contents_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/contents/{+path}","compare_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/merges","archive_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/downloads","issues_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues{/number}","pulls_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls{/number}","milestones_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/milestones{/number}","notifications_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/labels{/name}","releases_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/releases{/id}","deployments_url":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/deployments","created_at":"2016-10-05T21:51:27Z","updated_at":"2018-05-17T18:59:40Z","pushed_at":"2018-07-18T15:49:11Z","git_url":"git://github.com/PoisotLab/BioEnergeticFoodWebs.jl.git","ssh_url":"git@github.com:PoisotLab/BioEnergeticFoodWebs.jl.git","clone_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl.git","svn_url":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl","homepage":"http://poisotlab.io/BioEnergeticFoodWebs.jl/latest/","size":1920,"stargazers_count":8,"watchers_count":8,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":12,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/58"},"html":{"href":"https://github.com/PoisotLab/BioEnergeticFoodWebs.jl/pull/58"},"issue":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues/58"},"comments":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/PoisotLab/BioEnergeticFoodWebs.jl/statuses/367ab51215f522469c42d02e61e8feda233750f2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ChrisRackauckas"}}