{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments/237628220","pull_request_review_id":179975058,"id":237628220,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzYyODIyMA==","diff_hunk":"@@ -461,14 +462,14 @@ - (void)testLinkOptionsParamsPropertiesSetProperly {\n \n - (void)testFDLComponentsFactoryReturnsInstanceOfCorrectClass {\n   NSURL *link = [NSURL URLWithString:@\"https://google.com\"];\n-  id returnValue = [FIRDynamicLinkComponents componentsWithLink:link domain:kFDLURLDomain];","path":"Example/DynamicLinks/Tests/FDLURLComponentsTests.m","position":14,"original_position":14,"commit_id":"73cf063027ba0e1665630c1a67ffbcdca7b29a42","original_commit_id":"155ae377681f439727271f032dd75a1b54d0799f","user":{"login":"dmandar","id":11888634,"node_id":"MDQ6VXNlcjExODg4NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/11888634?v=4","gravatar_id":"","url":"https://api.github.com/users/dmandar","html_url":"https://github.com/dmandar","followers_url":"https://api.github.com/users/dmandar/followers","following_url":"https://api.github.com/users/dmandar/following{/other_user}","gists_url":"https://api.github.com/users/dmandar/gists{/gist_id}","starred_url":"https://api.github.com/users/dmandar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmandar/subscriptions","organizations_url":"https://api.github.com/users/dmandar/orgs","repos_url":"https://api.github.com/users/dmandar/repos","events_url":"https://api.github.com/users/dmandar/events{/privacy}","received_events_url":"https://api.github.com/users/dmandar/received_events","type":"User","site_admin":false},"body":"sure, will add more tests for the deprecated constructor.","created_at":"2018-11-29T19:31:41Z","updated_at":"2018-11-29T19:31:41Z","html_url":"https://github.com/firebase/firebase-ios-sdk/pull/2119#discussion_r237628220","pull_request_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/2119","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments/237628220"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/2119#discussion_r237628220"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/2119"}},"in_reply_to_id":237532793},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/2119","id":233671269,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjcxMjY5","html_url":"https://github.com/firebase/firebase-ios-sdk/pull/2119","diff_url":"https://github.com/firebase/firebase-ios-sdk/pull/2119.diff","patch_url":"https://github.com/firebase/firebase-ios-sdk/pull/2119.patch","issue_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/2119","number":2119,"state":"closed","locked":false,"title":"Move to `domainURIPrefix` for FIRDynamicLinkComponents","user":{"login":"dmandar","id":11888634,"node_id":"MDQ6VXNlcjExODg4NjM0","avatar_url":"https://avatars2.githubusercontent.com/u/11888634?v=4","gravatar_id":"","url":"https://api.github.com/users/dmandar","html_url":"https://github.com/dmandar","followers_url":"https://api.github.com/users/dmandar/followers","following_url":"https://api.github.com/users/dmandar/following{/other_user}","gists_url":"https://api.github.com/users/dmandar/gists{/gist_id}","starred_url":"https://api.github.com/users/dmandar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmandar/subscriptions","organizations_url":"https://api.github.com/users/dmandar/orgs","repos_url":"https://api.github.com/users/dmandar/repos","events_url":"https://api.github.com/users/dmandar/events{/privacy}","received_events_url":"https://api.github.com/users/dmandar/received_events","type":"User","site_admin":false},"body":"The new API is optional and current API is fully supported.\r\n\r\nThis reverts commit 46cb564067c3cfb720cf2adc33366ce651c59e17.\r\n\r\nHey there! So you want to contribute to a Firebase SDK?\r\nBefore you file this pull request, please read these guidelines:\r\n\r\n### Discussion\r\n\r\n  * Read the contribution guidelines (CONTRIBUTING.md).\r\n  * If this has been discussed in an issue, make sure to link to the issue here.\r\n    If not, go file an issue about this **before creating a pull request** to discuss.\r\n\r\n### Testing\r\n\r\n  * Make sure all existing tests in the repository pass after your change.\r\n  * If you fixed a bug or added a feature, add a new test to cover your code.\r\n\r\n### API Changes\r\n\r\n  * At this time we cannot accept changes that affect the public API.  If you'd like to help\r\n    us make Firebase APIs better, please propose your change in a feature request so that we\r\n    can discuss it together.\r\n","created_at":"2018-11-26T19:31:57Z","updated_at":"2018-11-29T19:31:41Z","closed_at":"2018-11-29T18:58:38Z","merged_at":"2018-11-29T18:58:38Z","merge_commit_sha":"36b79e633ff6cdcd2a3b80a942b1fc3cc9517e44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":658858759,"node_id":"MDU6TGFiZWw2NTg4NTg3NTk=","url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/2119/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/2119/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/2119/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/73cf063027ba0e1665630c1a67ffbcdca7b29a42","head":{"label":"firebase:md-undocustomdomainrevert","ref":"md-undocustomdomainrevert","sha":"73cf063027ba0e1665630c1a67ffbcdca7b29a42","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTAzMzU1Ng==","name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-11-29T19:02:50Z","pushed_at":"2018-11-29T19:17:22Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":15648,"stargazers_count":945,"watchers_count":945,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":204,"open_issues":100,"watchers":945,"default_branch":"master"}},"base":{"label":"firebase:master","ref":"master","sha":"013565e9f41c06abfb4c4070620e1b5b1480fe05","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":89033556,"node_id":"MDEwOlJlcG9zaXRvcnk4OTAzMzU1Ng==","name":"firebase-ios-sdk","full_name":"firebase/firebase-ios-sdk","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-ios-sdk","description":"Firebase iOS SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-ios-sdk","forks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/forks","keys_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/events","assignees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/merges","archive_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-ios-sdk/deployments","created_at":"2017-04-22T00:26:50Z","updated_at":"2018-11-29T19:02:50Z","pushed_at":"2018-11-29T19:17:22Z","git_url":"git://github.com/firebase/firebase-ios-sdk.git","ssh_url":"git@github.com:firebase/firebase-ios-sdk.git","clone_url":"https://github.com/firebase/firebase-ios-sdk.git","svn_url":"https://github.com/firebase/firebase-ios-sdk","homepage":"https://firebase.google.com","size":15648,"stargazers_count":945,"watchers_count":945,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":204,"mirror_url":null,"archived":false,"open_issues_count":100,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":204,"open_issues":100,"watchers":945,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/2119"},"html":{"href":"https://github.com/firebase/firebase-ios-sdk/pull/2119"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/2119"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/issues/2119/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/2119/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/pulls/2119/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-ios-sdk/statuses/73cf063027ba0e1665630c1a67ffbcdca7b29a42"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dmandar"}}