{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/open-craft/edx-theme/pulls/33","id":171193805,"html_url":"https://github.com/open-craft/edx-theme/pull/33","diff_url":"https://github.com/open-craft/edx-theme/pull/33.diff","patch_url":"https://github.com/open-craft/edx-theme/pull/33.patch","issue_url":"https://api.github.com/repos/open-craft/edx-theme/issues/33","number":33,"state":"closed","locked":false,"title":"Add additional \"Enquire now\" button on small screens","user":{"login":"clemente","id":132703,"avatar_url":"https://avatars3.githubusercontent.com/u/132703?v=4","gravatar_id":"","url":"https://api.github.com/users/clemente","html_url":"https://github.com/clemente","followers_url":"https://api.github.com/users/clemente/followers","following_url":"https://api.github.com/users/clemente/following{/other_user}","gists_url":"https://api.github.com/users/clemente/gists{/gist_id}","starred_url":"https://api.github.com/users/clemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clemente/subscriptions","organizations_url":"https://api.github.com/users/clemente/orgs","repos_url":"https://api.github.com/users/clemente/repos","events_url":"https://api.github.com/users/clemente/events{/privacy}","received_events_url":"https://api.github.com/users/clemente/received_events","type":"User","site_admin":false},"body":"This adds a 2nd „Enquire now“ button, only for small screens, before the course description.\r\n\r\nNote that several changes had to be done to achieve this:\r\n- add a block to the platform. https://github.com/open-craft/edx-platform/pull/114\r\n- move the code to generate the enquiry URL into a function (a mako block), to avoid duplicate code\r\n- clean some SASS styles that weren't being applied because they were redefined. Merge SCSS\r\n- create a SASS mixin to be able to use the same button style for buttons in different places \r\n- update documentation about the differences between upstream and this theme\r\n\r\nOther concerns:\r\n- the original „Enroll now“ button in the sandbox shows a strange behaviour when you hover the top part: it blinks (fades in and out). It's due to a remnant of the social icons above. It doesn't happen when the social icons are disabled, which is the case in production.\r\n- the new „enquiry now“ is as wide as the screen allows, but this shouldn't be too wide because it's shown just when the screen is small \r\n\r\nTest instructions in sandbox:\r\n1. Go to https://pearson-test.sandbox.stage.opencraft.hosting/courses/course-v1:testing1+other2+2018_02/about as anonymous. Refresh cache as needed\r\n2. Verify: only the „Enquire now“ button is added, not any other (add to cart, etc.)\r\n3. Verify: the new button only appears in the same conditions as the original button. E.g. if you're logged in you don't see any „Enquire now“ button\r\n4. Verify: the new button and the old button don't appear at the same time\r\n5. Verify URLs of both old and new, compare it with production too\r\n6. Compare the style of all buttons with production\r\n7. Try clicking it\r\n8. Read the code\r\n9. Try in devstack?\r\n\r\nReviewers:\r\n- [ ] @jcdyer\r\n","created_at":"2018-02-24T19:35:42Z","updated_at":"2018-02-26T09:35:45Z","closed_at":"2018-02-26T09:35:45Z","merged_at":"2018-02-26T09:35:45Z","merge_commit_sha":"67a5e28c4a5c34e7d6719dde414969ee4120490c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-craft/edx-theme/pulls/33/commits","review_comments_url":"https://api.github.com/repos/open-craft/edx-theme/pulls/33/comments","review_comment_url":"https://api.github.com/repos/open-craft/edx-theme/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-craft/edx-theme/issues/33/comments","statuses_url":"https://api.github.com/repos/open-craft/edx-theme/statuses/3277e005dd820700ea1c7ce3ff9c5a182ad02298","head":{"label":"open-craft:clemente/pearson-additional-enquire-now-button","ref":"clemente/pearson-additional-enquire-now-button","sha":"3277e005dd820700ea1c7ce3ff9c5a182ad02298","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":26311079,"name":"edx-theme","full_name":"open-craft/edx-theme","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/edx-theme","description":"edX Theme","fork":true,"url":"https://api.github.com/repos/open-craft/edx-theme","forks_url":"https://api.github.com/repos/open-craft/edx-theme/forks","keys_url":"https://api.github.com/repos/open-craft/edx-theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/edx-theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/edx-theme/teams","hooks_url":"https://api.github.com/repos/open-craft/edx-theme/hooks","issue_events_url":"https://api.github.com/repos/open-craft/edx-theme/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/edx-theme/events","assignees_url":"https://api.github.com/repos/open-craft/edx-theme/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/edx-theme/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/edx-theme/tags","blobs_url":"https://api.github.com/repos/open-craft/edx-theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/edx-theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/edx-theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/edx-theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/edx-theme/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/edx-theme/languages","stargazers_url":"https://api.github.com/repos/open-craft/edx-theme/stargazers","contributors_url":"https://api.github.com/repos/open-craft/edx-theme/contributors","subscribers_url":"https://api.github.com/repos/open-craft/edx-theme/subscribers","subscription_url":"https://api.github.com/repos/open-craft/edx-theme/subscription","commits_url":"https://api.github.com/repos/open-craft/edx-theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/edx-theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/edx-theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/edx-theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/edx-theme/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/edx-theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/edx-theme/merges","archive_url":"https://api.github.com/repos/open-craft/edx-theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/edx-theme/downloads","issues_url":"https://api.github.com/repos/open-craft/edx-theme/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/edx-theme/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/edx-theme/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/edx-theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/edx-theme/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/edx-theme/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/edx-theme/deployments","created_at":"2014-11-07T08:38:57Z","updated_at":"2017-07-14T08:50:58Z","pushed_at":"2018-02-26T09:35:45Z","git_url":"git://github.com/open-craft/edx-theme.git","ssh_url":"git@github.com:open-craft/edx-theme.git","clone_url":"https://github.com/open-craft/edx-theme.git","svn_url":"https://github.com/open-craft/edx-theme","homepage":"","size":30452,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"open-craft:pearsonx","ref":"pearsonx","sha":"8191c6014a8e20df873907b8412da6a634965d12","user":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"repo":{"id":26311079,"name":"edx-theme","full_name":"open-craft/edx-theme","owner":{"login":"open-craft","id":7414786,"avatar_url":"https://avatars0.githubusercontent.com/u/7414786?v=4","gravatar_id":"","url":"https://api.github.com/users/open-craft","html_url":"https://github.com/open-craft","followers_url":"https://api.github.com/users/open-craft/followers","following_url":"https://api.github.com/users/open-craft/following{/other_user}","gists_url":"https://api.github.com/users/open-craft/gists{/gist_id}","starred_url":"https://api.github.com/users/open-craft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-craft/subscriptions","organizations_url":"https://api.github.com/users/open-craft/orgs","repos_url":"https://api.github.com/users/open-craft/repos","events_url":"https://api.github.com/users/open-craft/events{/privacy}","received_events_url":"https://api.github.com/users/open-craft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-craft/edx-theme","description":"edX Theme","fork":true,"url":"https://api.github.com/repos/open-craft/edx-theme","forks_url":"https://api.github.com/repos/open-craft/edx-theme/forks","keys_url":"https://api.github.com/repos/open-craft/edx-theme/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-craft/edx-theme/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-craft/edx-theme/teams","hooks_url":"https://api.github.com/repos/open-craft/edx-theme/hooks","issue_events_url":"https://api.github.com/repos/open-craft/edx-theme/issues/events{/number}","events_url":"https://api.github.com/repos/open-craft/edx-theme/events","assignees_url":"https://api.github.com/repos/open-craft/edx-theme/assignees{/user}","branches_url":"https://api.github.com/repos/open-craft/edx-theme/branches{/branch}","tags_url":"https://api.github.com/repos/open-craft/edx-theme/tags","blobs_url":"https://api.github.com/repos/open-craft/edx-theme/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-craft/edx-theme/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-craft/edx-theme/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-craft/edx-theme/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-craft/edx-theme/statuses/{sha}","languages_url":"https://api.github.com/repos/open-craft/edx-theme/languages","stargazers_url":"https://api.github.com/repos/open-craft/edx-theme/stargazers","contributors_url":"https://api.github.com/repos/open-craft/edx-theme/contributors","subscribers_url":"https://api.github.com/repos/open-craft/edx-theme/subscribers","subscription_url":"https://api.github.com/repos/open-craft/edx-theme/subscription","commits_url":"https://api.github.com/repos/open-craft/edx-theme/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-craft/edx-theme/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-craft/edx-theme/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-craft/edx-theme/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-craft/edx-theme/contents/{+path}","compare_url":"https://api.github.com/repos/open-craft/edx-theme/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-craft/edx-theme/merges","archive_url":"https://api.github.com/repos/open-craft/edx-theme/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-craft/edx-theme/downloads","issues_url":"https://api.github.com/repos/open-craft/edx-theme/issues{/number}","pulls_url":"https://api.github.com/repos/open-craft/edx-theme/pulls{/number}","milestones_url":"https://api.github.com/repos/open-craft/edx-theme/milestones{/number}","notifications_url":"https://api.github.com/repos/open-craft/edx-theme/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-craft/edx-theme/labels{/name}","releases_url":"https://api.github.com/repos/open-craft/edx-theme/releases{/id}","deployments_url":"https://api.github.com/repos/open-craft/edx-theme/deployments","created_at":"2014-11-07T08:38:57Z","updated_at":"2017-07-14T08:50:58Z","pushed_at":"2018-02-26T09:35:45Z","git_url":"git://github.com/open-craft/edx-theme.git","ssh_url":"git@github.com:open-craft/edx-theme.git","clone_url":"https://github.com/open-craft/edx-theme.git","svn_url":"https://github.com/open-craft/edx-theme","homepage":"","size":30452,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-craft/edx-theme/pulls/33"},"html":{"href":"https://github.com/open-craft/edx-theme/pull/33"},"issue":{"href":"https://api.github.com/repos/open-craft/edx-theme/issues/33"},"comments":{"href":"https://api.github.com/repos/open-craft/edx-theme/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/open-craft/edx-theme/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/open-craft/edx-theme/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-craft/edx-theme/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/open-craft/edx-theme/statuses/3277e005dd820700ea1c7ce3ff9c5a182ad02298"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"clemente","id":132703,"avatar_url":"https://avatars3.githubusercontent.com/u/132703?v=4","gravatar_id":"","url":"https://api.github.com/users/clemente","html_url":"https://github.com/clemente","followers_url":"https://api.github.com/users/clemente/followers","following_url":"https://api.github.com/users/clemente/following{/other_user}","gists_url":"https://api.github.com/users/clemente/gists{/gist_id}","starred_url":"https://api.github.com/users/clemente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clemente/subscriptions","organizations_url":"https://api.github.com/users/clemente/orgs","repos_url":"https://api.github.com/users/clemente/repos","events_url":"https://api.github.com/users/clemente/events{/privacy}","received_events_url":"https://api.github.com/users/clemente/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":4,"additions":90,"deletions":44,"changed_files":2}}
{"actor":{"display_login":"clemente"}}