{"action":"closed","number":941,"pull_request":{"url":"https://api.github.com/repos/openstreetmap/Nominatim/pulls/941","id":170907995,"html_url":"https://github.com/openstreetmap/Nominatim/pull/941","diff_url":"https://github.com/openstreetmap/Nominatim/pull/941.diff","patch_url":"https://github.com/openstreetmap/Nominatim/pull/941.patch","issue_url":"https://api.github.com/repos/openstreetmap/Nominatim/issues/941","number":941,"state":"closed","locked":false,"title":"PHP tests for ParameterParser","user":{"login":"mtmail","id":3727288,"avatar_url":"https://avatars1.githubusercontent.com/u/3727288?v=4","gravatar_id":"","url":"https://api.github.com/users/mtmail","html_url":"https://github.com/mtmail","followers_url":"https://api.github.com/users/mtmail/followers","following_url":"https://api.github.com/users/mtmail/following{/other_user}","gists_url":"https://api.github.com/users/mtmail/gists{/gist_id}","starred_url":"https://api.github.com/users/mtmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtmail/subscriptions","organizations_url":"https://api.github.com/users/mtmail/orgs","repos_url":"https://api.github.com/users/mtmail/repos","events_url":"https://api.github.com/users/mtmail/events{/privacy}","received_events_url":"https://api.github.com/users/mtmail/received_events","type":"User","site_admin":false},"body":"In the old PR I also had tests for Geocode.php with more complicated setup (needed either environment variables or mock objects), this PR is more straight forward.\r\n\r\nCan you review the FIXMEs https://github.com/openstreetmap/Nominatim/pull/624#issuecomment-277505651 ?","created_at":"2018-02-23T00:58:28Z","updated_at":"2018-03-06T22:25:21Z","closed_at":"2018-03-06T22:25:21Z","merged_at":"2018-03-06T22:25:21Z","merge_commit_sha":"5c8fbe8186ea0fa06b7c96f08e8afba1744492c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openstreetmap/Nominatim/pulls/941/commits","review_comments_url":"https://api.github.com/repos/openstreetmap/Nominatim/pulls/941/comments","review_comment_url":"https://api.github.com/repos/openstreetmap/Nominatim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openstreetmap/Nominatim/issues/941/comments","statuses_url":"https://api.github.com/repos/openstreetmap/Nominatim/statuses/7fd46dcee923b507d366004148eb3077387560b2","head":{"label":"mtmail:parameter-parser-tests2","ref":"parameter-parser-tests2","sha":"7fd46dcee923b507d366004148eb3077387560b2","user":{"login":"mtmail","id":3727288,"avatar_url":"https://avatars1.githubusercontent.com/u/3727288?v=4","gravatar_id":"","url":"https://api.github.com/users/mtmail","html_url":"https://github.com/mtmail","followers_url":"https://api.github.com/users/mtmail/followers","following_url":"https://api.github.com/users/mtmail/following{/other_user}","gists_url":"https://api.github.com/users/mtmail/gists{/gist_id}","starred_url":"https://api.github.com/users/mtmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtmail/subscriptions","organizations_url":"https://api.github.com/users/mtmail/orgs","repos_url":"https://api.github.com/users/mtmail/repos","events_url":"https://api.github.com/users/mtmail/events{/privacy}","received_events_url":"https://api.github.com/users/mtmail/received_events","type":"User","site_admin":false},"repo":{"id":37550357,"name":"Nominatim","full_name":"mtmail/Nominatim","owner":{"login":"mtmail","id":3727288,"avatar_url":"https://avatars1.githubusercontent.com/u/3727288?v=4","gravatar_id":"","url":"https://api.github.com/users/mtmail","html_url":"https://github.com/mtmail","followers_url":"https://api.github.com/users/mtmail/followers","following_url":"https://api.github.com/users/mtmail/following{/other_user}","gists_url":"https://api.github.com/users/mtmail/gists{/gist_id}","starred_url":"https://api.github.com/users/mtmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtmail/subscriptions","organizations_url":"https://api.github.com/users/mtmail/orgs","repos_url":"https://api.github.com/users/mtmail/repos","events_url":"https://api.github.com/users/mtmail/events{/privacy}","received_events_url":"https://api.github.com/users/mtmail/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mtmail/Nominatim","description":"Open Source search based on OpenStreetMap data","fork":true,"url":"https://api.github.com/repos/mtmail/Nominatim","forks_url":"https://api.github.com/repos/mtmail/Nominatim/forks","keys_url":"https://api.github.com/repos/mtmail/Nominatim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mtmail/Nominatim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mtmail/Nominatim/teams","hooks_url":"https://api.github.com/repos/mtmail/Nominatim/hooks","issue_events_url":"https://api.github.com/repos/mtmail/Nominatim/issues/events{/number}","events_url":"https://api.github.com/repos/mtmail/Nominatim/events","assignees_url":"https://api.github.com/repos/mtmail/Nominatim/assignees{/user}","branches_url":"https://api.github.com/repos/mtmail/Nominatim/branches{/branch}","tags_url":"https://api.github.com/repos/mtmail/Nominatim/tags","blobs_url":"https://api.github.com/repos/mtmail/Nominatim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mtmail/Nominatim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mtmail/Nominatim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mtmail/Nominatim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mtmail/Nominatim/statuses/{sha}","languages_url":"https://api.github.com/repos/mtmail/Nominatim/languages","stargazers_url":"https://api.github.com/repos/mtmail/Nominatim/stargazers","contributors_url":"https://api.github.com/repos/mtmail/Nominatim/contributors","subscribers_url":"https://api.github.com/repos/mtmail/Nominatim/subscribers","subscription_url":"https://api.github.com/repos/mtmail/Nominatim/subscription","commits_url":"https://api.github.com/repos/mtmail/Nominatim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mtmail/Nominatim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mtmail/Nominatim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mtmail/Nominatim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mtmail/Nominatim/contents/{+path}","compare_url":"https://api.github.com/repos/mtmail/Nominatim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mtmail/Nominatim/merges","archive_url":"https://api.github.com/repos/mtmail/Nominatim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mtmail/Nominatim/downloads","issues_url":"https://api.github.com/repos/mtmail/Nominatim/issues{/number}","pulls_url":"https://api.github.com/repos/mtmail/Nominatim/pulls{/number}","milestones_url":"https://api.github.com/repos/mtmail/Nominatim/milestones{/number}","notifications_url":"https://api.github.com/repos/mtmail/Nominatim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mtmail/Nominatim/labels{/name}","releases_url":"https://api.github.com/repos/mtmail/Nominatim/releases{/id}","deployments_url":"https://api.github.com/repos/mtmail/Nominatim/deployments","created_at":"2015-06-16T19:07:23Z","updated_at":"2016-04-26T18:43:20Z","pushed_at":"2018-03-06T16:24:08Z","git_url":"git://github.com/mtmail/Nominatim.git","ssh_url":"git@github.com:mtmail/Nominatim.git","clone_url":"https://github.com/mtmail/Nominatim.git","svn_url":"https://github.com/mtmail/Nominatim","homepage":"http://wiki.openstreetmap.org/wiki/Nominatim","size":148802,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openstreetmap:master","ref":"master","sha":"ff2a40b109f7431c810610c2c350881d07e358e4","user":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars3.githubusercontent.com/u/261431?v=4","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"repo":{"id":3610486,"name":"Nominatim","full_name":"openstreetmap/Nominatim","owner":{"login":"openstreetmap","id":261431,"avatar_url":"https://avatars3.githubusercontent.com/u/261431?v=4","gravatar_id":"","url":"https://api.github.com/users/openstreetmap","html_url":"https://github.com/openstreetmap","followers_url":"https://api.github.com/users/openstreetmap/followers","following_url":"https://api.github.com/users/openstreetmap/following{/other_user}","gists_url":"https://api.github.com/users/openstreetmap/gists{/gist_id}","starred_url":"https://api.github.com/users/openstreetmap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openstreetmap/subscriptions","organizations_url":"https://api.github.com/users/openstreetmap/orgs","repos_url":"https://api.github.com/users/openstreetmap/repos","events_url":"https://api.github.com/users/openstreetmap/events{/privacy}","received_events_url":"https://api.github.com/users/openstreetmap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openstreetmap/Nominatim","description":"Open Source search based on OpenStreetMap data","fork":false,"url":"https://api.github.com/repos/openstreetmap/Nominatim","forks_url":"https://api.github.com/repos/openstreetmap/Nominatim/forks","keys_url":"https://api.github.com/repos/openstreetmap/Nominatim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openstreetmap/Nominatim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openstreetmap/Nominatim/teams","hooks_url":"https://api.github.com/repos/openstreetmap/Nominatim/hooks","issue_events_url":"https://api.github.com/repos/openstreetmap/Nominatim/issues/events{/number}","events_url":"https://api.github.com/repos/openstreetmap/Nominatim/events","assignees_url":"https://api.github.com/repos/openstreetmap/Nominatim/assignees{/user}","branches_url":"https://api.github.com/repos/openstreetmap/Nominatim/branches{/branch}","tags_url":"https://api.github.com/repos/openstreetmap/Nominatim/tags","blobs_url":"https://api.github.com/repos/openstreetmap/Nominatim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openstreetmap/Nominatim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openstreetmap/Nominatim/git/refs{/sha}","trees_url":"https://api.github.com/repos/openstreetmap/Nominatim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openstreetmap/Nominatim/statuses/{sha}","languages_url":"https://api.github.com/repos/openstreetmap/Nominatim/languages","stargazers_url":"https://api.github.com/repos/openstreetmap/Nominatim/stargazers","contributors_url":"https://api.github.com/repos/openstreetmap/Nominatim/contributors","subscribers_url":"https://api.github.com/repos/openstreetmap/Nominatim/subscribers","subscription_url":"https://api.github.com/repos/openstreetmap/Nominatim/subscription","commits_url":"https://api.github.com/repos/openstreetmap/Nominatim/commits{/sha}","git_commits_url":"https://api.github.com/repos/openstreetmap/Nominatim/git/commits{/sha}","comments_url":"https://api.github.com/repos/openstreetmap/Nominatim/comments{/number}","issue_comment_url":"https://api.github.com/repos/openstreetmap/Nominatim/issues/comments{/number}","contents_url":"https://api.github.com/repos/openstreetmap/Nominatim/contents/{+path}","compare_url":"https://api.github.com/repos/openstreetmap/Nominatim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openstreetmap/Nominatim/merges","archive_url":"https://api.github.com/repos/openstreetmap/Nominatim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openstreetmap/Nominatim/downloads","issues_url":"https://api.github.com/repos/openstreetmap/Nominatim/issues{/number}","pulls_url":"https://api.github.com/repos/openstreetmap/Nominatim/pulls{/number}","milestones_url":"https://api.github.com/repos/openstreetmap/Nominatim/milestones{/number}","notifications_url":"https://api.github.com/repos/openstreetmap/Nominatim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openstreetmap/Nominatim/labels{/name}","releases_url":"https://api.github.com/repos/openstreetmap/Nominatim/releases{/id}","deployments_url":"https://api.github.com/repos/openstreetmap/Nominatim/deployments","created_at":"2012-03-03T12:24:39Z","updated_at":"2018-03-05T14:54:29Z","pushed_at":"2018-03-06T22:25:21Z","git_url":"git://github.com/openstreetmap/Nominatim.git","ssh_url":"git@github.com:openstreetmap/Nominatim.git","clone_url":"https://github.com/openstreetmap/Nominatim.git","svn_url":"https://github.com/openstreetmap/Nominatim","homepage":"https://nominatim.org","size":148762,"stargazers_count":792,"watchers_count":792,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":261,"mirror_url":null,"archived":false,"open_issues_count":114,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":261,"open_issues":114,"watchers":792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openstreetmap/Nominatim/pulls/941"},"html":{"href":"https://github.com/openstreetmap/Nominatim/pull/941"},"issue":{"href":"https://api.github.com/repos/openstreetmap/Nominatim/issues/941"},"comments":{"href":"https://api.github.com/repos/openstreetmap/Nominatim/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/openstreetmap/Nominatim/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/openstreetmap/Nominatim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openstreetmap/Nominatim/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/openstreetmap/Nominatim/statuses/7fd46dcee923b507d366004148eb3077387560b2"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"lonvia","id":1447941,"avatar_url":"https://avatars1.githubusercontent.com/u/1447941?v=4","gravatar_id":"","url":"https://api.github.com/users/lonvia","html_url":"https://github.com/lonvia","followers_url":"https://api.github.com/users/lonvia/followers","following_url":"https://api.github.com/users/lonvia/following{/other_user}","gists_url":"https://api.github.com/users/lonvia/gists{/gist_id}","starred_url":"https://api.github.com/users/lonvia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lonvia/subscriptions","organizations_url":"https://api.github.com/users/lonvia/orgs","repos_url":"https://api.github.com/users/lonvia/repos","events_url":"https://api.github.com/users/lonvia/events{/privacy}","received_events_url":"https://api.github.com/users/lonvia/received_events","type":"User","site_admin":false},"comments":5,"review_comments":12,"maintainer_can_modify":false,"commits":7,"additions":221,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"lonvia"}}