{"push_id":2715361743,"size":23,"distinct_size":23,"ref":"refs/heads/heartbeat-and-routing","head":"6afb6a760dd2154c03f7bc4d1ba42a2c58d4aa8a","before":"b5b6d4a459645dff72d0d914c89b4e8117a406c9","commits":[{"sha":"8e11cc65394d2ea1093a3db5ed56b591d52a68d3","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Remove GenieWeb Spring Boot main from genie-web\n\nRemoves the main class from Genie web module which was pulled in to many places including internally and causes confusion and conflicts as to which main to use on the classpath. It's also picked up by classpath scanning of other mains that reside in the com.netflix.genie base package and could have unintended consequences to users (including ourselves internally).\n\nPull out the application.yml properties files into the main executable locations (genie-app, genie-war) and create a re-usable test main in new module genie-test-web that can be used for our integration tests along with default set of properties there. Pulling the application.yml out of the genie-web resources ensures that the properties found in our internal build will be the ones used with no confusion.","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/8e11cc65394d2ea1093a3db5ed56b591d52a68d3"},{"sha":"1cf3c6ee8a6b2a4f19511193b66baf32a9ae3dcf","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Remove usage of @Value for Genie namespace properties. Standardize naming of auto configuration files.\n\nThe usage of @Value has caused considerable time to be wasted hunting down bugs in internal property files and the binding to OSS code. Switching these usages to type safe @ConfigurationProperties bindings will not only improve that experience but also due to the metadata generator for boot properties allow better IDE completion for properties available in the Genie namespace.\n\nRenaming our configuration files from *Config to *AutoConfiguration better reflects what they now are (and were always intended to be) while simultaneously following best practices for Boot libraries/applications.","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/1cf3c6ee8a6b2a4f19511193b66baf32a9ae3dcf"},{"sha":"22fdc64c83e2feee4029a31cbfce5f1589746c19","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Fix resource filtering to only act on the yml files to avoid messing with binary files","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/22fdc64c83e2feee4029a31cbfce5f1589746c19"},{"sha":"337bbe487ffa1a6eff3ba4c693503780852722cb","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Upgrade to Gradle 4.8.1\n\nAlso upgrade the following plugins:\n- nebula.netflixoss (5.0.0 -> 5.1.1)\n- com.github.kt3k.coveralls (2.8.1 -> 2.8.2)\n- asciidoctor-gradle-plugin (1.5.3 -> 1.5.8)\n- protobuf-gradle-plugin (0.8.3 -> 0.8.5)\n\nRemoved Spring Snapshot and Mileston Maven repositories that were only there while Boot 2 was in development. Avoid pulling anything that isn't a release version into builds accidently.\n\nSquash","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/337bbe487ffa1a6eff3ba4c693503780852722cb"},{"sha":"a9eebdacee50f5441dd63a0d0f45f985300f6b1f","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Add groovy files to the .editorconfig file","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/a9eebdacee50f5441dd63a0d0f45f985300f6b1f"},{"sha":"f82efcdab9d3fafa52b5251e8c0d1bec1645cc5b","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Refactor integration test configuration overrides for reuse and clarity\n\nBuried in random packages within both genie-web and genie-client were some actual Spring configuration files that were meant to override the job directory resource bean for integration tests to ensure it was in an OS safe tmp directory location that was cleaned up at the end of tests. This led to a lot of confusion about where this was coming from and what these files were for (as they lived along side actual test files for classes in the config package). This commit moves the configuration to the genie-test-web module which clears up its purpose while also reducing redundant code in multiple modules.","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/f82efcdab9d3fafa52b5251e8c0d1bec1645cc5b"},{"sha":"dacce3bfb251891989b425c9d3a2afeda5f3f1fc","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Ignore integration test which I believe is redundantly testing Spring functionality\n\nThe testing in this class is really testing property binding. We have unit tests for these property classes so this test seems to be just making sure spring boot property binding works. This is already tested by spring in their testing and if it was broken tons of people would complain. I don't feel it's worth it for us to waste time in our build just to bring up an application context to test this functionality. For now I'm leaving it in and just ignored in case someone wants to convince me otherwise. Eventually we can delete this otherwise.","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/dacce3bfb251891989b425c9d3a2afeda5f3f1fc"},{"sha":"1da333b6c2fbe625fb4c2fe3d0c9a95ba2c3e673","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Remove unnecessary auto configuration class","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/1da333b6c2fbe625fb4c2fe3d0c9a95ba2c3e673"},{"sha":"2199d3e58691f7760b53b2bd399d007da799bfed","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Make the system more flexible to replacing business logic beans\n\nIn the past we've marked many of our business logic classes (the service tier if you will) with `@Service`. This is very nice for quickly wiring up the application but it removes flexibility for extension as it forces a bean of that type to be in the context. This commit moves almost all of our service tier to be conditional beans in auto configuration classes. This will allow people that pull the genie-web module into their builds (including Netflix internally) to override these bean definitions easier to either extend existing functionality or replace it completely. Also with the beans in AutoConfiguration we can disable entire swaths of functionality (e.g. JPA) by just ignoring that auto config.","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/2199d3e58691f7760b53b2bd399d007da799bfed"},{"sha":"1490653d29f1ec9369cb77d276b7b1738c77ef0b","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Make auto config excludes an array instead of csv","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/1490653d29f1ec9369cb77d276b7b1738c77ef0b"},{"sha":"4a1c1ed37ff1e68c7350ab65e8655485acb8c65d","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Disable gRPC server for integration tests and provide grpc profile that can be enabled if grpc server is desired during testing","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/4a1c1ed37ff1e68c7350ab65e8655485acb8c65d"},{"sha":"c6d93beabf7b1585cc85373a598de96db772f2dd","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Disable Ping Service bean when gRPC is not enabled","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/c6d93beabf7b1585cc85373a598de96db772f2dd"},{"sha":"e9319732d4a2c03131de895b774b8b842847fad4","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Switch to RestTemplateBuilder for genieRestTemplate bean creation","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/e9319732d4a2c03131de895b774b8b842847fad4"},{"sha":"85b8315873121d28c534e1b8172df445ceb1e70b","author":{"name":"Tom Gianos","email":"8fec05093fd66b29634529409f222232139461af@netflix.com"},"message":"Disable Travis git clone depth to avoid version tags missing up to depth setting and reverting to 1.0.0-SNAPSHOT","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/85b8315873121d28c534e1b8172df445ceb1e70b"},{"sha":"5a7bea292408e748dac48f3a2c2c2fe50c384dc2","author":{"name":"Marco Primi","email":"ef36fba3854aad00f5bfd240d4560c4b3de697aa@netflix.com"},"message":"Define HeartBeat service, implement client and server services\n\nHeartBeat service using bi-directional gRPC streaming to detect connections and disconnections at both ends.","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/5a7bea292408e748dac48f3a2c2c2fe50c384dc2"},{"sha":"791722332f44654e6e2d8d835cb23da98eafc89a","author":{"name":"Marco Primi","email":"ef36fba3854aad00f5bfd240d4560c4b3de697aa@netflix.com"},"message":"Fix possible NPE in SimpleLoggingInterceptor","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/791722332f44654e6e2d8d835cb23da98eafc89a"},{"sha":"d3e6a6427e0a159a6f3259b336d1a81b8aeb9dc1","author":{"name":"Marco Primi","email":"ef36fba3854aad00f5bfd240d4560c4b3de697aa@netflix.com"},"message":"fixup! Define HeartBeat service, implement client and server services","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/d3e6a6427e0a159a6f3259b336d1a81b8aeb9dc1"},{"sha":"b67d9ad6ede3eccee069301642eadcca4c713c90","author":{"name":"Marco Primi","email":"ef36fba3854aad00f5bfd240d4560c4b3de697aa@netflix.com"},"message":"Add HeartBeat CLI command","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/b67d9ad6ede3eccee069301642eadcca4c713c90"},{"sha":"956a199baa52b3e71182b1ba9e321b91f6705b91","author":{"name":"Marco Primi","email":"ef36fba3854aad00f5bfd240d4560c4b3de697aa@netflix.com"},"message":"DB things - WIP","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/956a199baa52b3e71182b1ba9e321b91f6705b91"},{"sha":"244f729997965eb443fa1ebc4cca9946852a2bf2","author":{"name":"Marco Primi","email":"ef36fba3854aad00f5bfd240d4560c4b3de697aa@netflix.com"},"message":"Done with code","distinct":true,"url":"https://api.github.com/repos/mprimi/genie/commits/244f729997965eb443fa1ebc4cca9946852a2bf2"}]}
{"actor":{"display_login":"mprimi"}}