{"action":"created","comment":{"url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/comments/183779809","pull_request_review_id":114842970,"id":183779809,"diff_hunk":"@@ -276,11 +296,11 @@ QVariantMap MlsdbOnlineLocator::fallbackFields()\n     // If no exact cell match can be found, fall back from exact cell position estimates to more\n     // coarse grained cell location area estimates, rather than going directly to an even worse\n     // GeoIP based estimate.\n-    fallbacks[\"lacf\"] = true;\n+    fallbacks[\"lacf\"] = false;\n \n     // If no position can be estimated based on any of the provided data points, fall back to an\n     // estimate based on a GeoIP database based on the senders IP address at the time of the query.\n-    fallbacks[\"ipf\"] = true;\n+    fallbacks[\"ipf\"] = false;","path":"plugin/mlsdbonlinelocator.cpp","position":125,"original_position":125,"commit_id":"3d1ceed9cb3274c9945a5ac11f91f1d0ae596e03","original_commit_id":"3d1ceed9cb3274c9945a5ac11f91f1d0ae596e03","user":{"login":"krnlyng","id":298061,"avatar_url":"https://avatars1.githubusercontent.com/u/298061?v=4","gravatar_id":"","url":"https://api.github.com/users/krnlyng","html_url":"https://github.com/krnlyng","followers_url":"https://api.github.com/users/krnlyng/followers","following_url":"https://api.github.com/users/krnlyng/following{/other_user}","gists_url":"https://api.github.com/users/krnlyng/gists{/gist_id}","starred_url":"https://api.github.com/users/krnlyng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnlyng/subscriptions","organizations_url":"https://api.github.com/users/krnlyng/orgs","repos_url":"https://api.github.com/users/krnlyng/repos","events_url":"https://api.github.com/users/krnlyng/events{/privacy}","received_events_url":"https://api.github.com/users/krnlyng/received_events","type":"User","site_admin":false},"body":"@dmamaevomp is it better to have no location at all than having a coarse location?\r\n\r\nwould it be useful to have something like this:\r\n1) if we don't have any location yet, allow the ipf fallback, otherwise don't allow that fallback.\r\nor\r\n2) keep the ipf fallback AND if the location accuracy parameter is worse than something we acquired shortly before, don't use the inaccurate value\r\n?","created_at":"2018-04-24T15:35:06Z","updated_at":"2018-04-24T15:35:06Z","html_url":"https://github.com/mer-hybris/geoclue-providers-mlsdb/pull/18#discussion_r183779809","pull_request_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/18","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/comments/183779809"},"html":{"href":"https://github.com/mer-hybris/geoclue-providers-mlsdb/pull/18#discussion_r183779809"},"pull_request":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/18"}},"in_reply_to_id":183747051},"pull_request":{"url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/18","id":183739306,"html_url":"https://github.com/mer-hybris/geoclue-providers-mlsdb/pull/18","diff_url":"https://github.com/mer-hybris/geoclue-providers-mlsdb/pull/18.diff","patch_url":"https://github.com/mer-hybris/geoclue-providers-mlsdb/pull/18.patch","issue_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/issues/18","number":18,"state":"open","locked":false,"title":" Changed the algorithm and query parameters in the Mozilla service. Contributes to JB#41766","user":{"login":"dmamaevomp","id":34887072,"avatar_url":"https://avatars3.githubusercontent.com/u/34887072?v=4","gravatar_id":"","url":"https://api.github.com/users/dmamaevomp","html_url":"https://github.com/dmamaevomp","followers_url":"https://api.github.com/users/dmamaevomp/followers","following_url":"https://api.github.com/users/dmamaevomp/following{/other_user}","gists_url":"https://api.github.com/users/dmamaevomp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmamaevomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmamaevomp/subscriptions","organizations_url":"https://api.github.com/users/dmamaevomp/orgs","repos_url":"https://api.github.com/users/dmamaevomp/repos","events_url":"https://api.github.com/users/dmamaevomp/events{/privacy}","received_events_url":"https://api.github.com/users/dmamaevomp/received_events","type":"User","site_admin":false},"body":"https://bz.jollamobile.com/show_bug.cgi?id=41766","created_at":"2018-04-24T13:38:08Z","updated_at":"2018-04-24T15:35:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76c5afc5e00761ea83b1b9c1863897b80e3fd91c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/18/commits","review_comments_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/18/comments","review_comment_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/issues/18/comments","statuses_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/statuses/3d1ceed9cb3274c9945a5ac11f91f1d0ae596e03","head":{"label":"dmamaevomp:master","ref":"master","sha":"3d1ceed9cb3274c9945a5ac11f91f1d0ae596e03","user":{"login":"dmamaevomp","id":34887072,"avatar_url":"https://avatars3.githubusercontent.com/u/34887072?v=4","gravatar_id":"","url":"https://api.github.com/users/dmamaevomp","html_url":"https://github.com/dmamaevomp","followers_url":"https://api.github.com/users/dmamaevomp/followers","following_url":"https://api.github.com/users/dmamaevomp/following{/other_user}","gists_url":"https://api.github.com/users/dmamaevomp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmamaevomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmamaevomp/subscriptions","organizations_url":"https://api.github.com/users/dmamaevomp/orgs","repos_url":"https://api.github.com/users/dmamaevomp/repos","events_url":"https://api.github.com/users/dmamaevomp/events{/privacy}","received_events_url":"https://api.github.com/users/dmamaevomp/received_events","type":"User","site_admin":false},"repo":{"id":130036390,"name":"geoclue-providers-mlsdb","full_name":"dmamaevomp/geoclue-providers-mlsdb","owner":{"login":"dmamaevomp","id":34887072,"avatar_url":"https://avatars3.githubusercontent.com/u/34887072?v=4","gravatar_id":"","url":"https://api.github.com/users/dmamaevomp","html_url":"https://github.com/dmamaevomp","followers_url":"https://api.github.com/users/dmamaevomp/followers","following_url":"https://api.github.com/users/dmamaevomp/following{/other_user}","gists_url":"https://api.github.com/users/dmamaevomp/gists{/gist_id}","starred_url":"https://api.github.com/users/dmamaevomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmamaevomp/subscriptions","organizations_url":"https://api.github.com/users/dmamaevomp/orgs","repos_url":"https://api.github.com/users/dmamaevomp/repos","events_url":"https://api.github.com/users/dmamaevomp/events{/privacy}","received_events_url":"https://api.github.com/users/dmamaevomp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dmamaevomp/geoclue-providers-mlsdb","description":null,"fork":true,"url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb","forks_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/forks","keys_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/teams","hooks_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/hooks","issue_events_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/issues/events{/number}","events_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/events","assignees_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/assignees{/user}","branches_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/branches{/branch}","tags_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/tags","blobs_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/languages","stargazers_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/stargazers","contributors_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/contributors","subscribers_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/subscribers","subscription_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/subscription","commits_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/contents/{+path}","compare_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/merges","archive_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/downloads","issues_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/issues{/number}","pulls_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/labels{/name}","releases_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/releases{/id}","deployments_url":"https://api.github.com/repos/dmamaevomp/geoclue-providers-mlsdb/deployments","created_at":"2018-04-18T09:15:53Z","updated_at":"2018-04-18T10:07:17Z","pushed_at":"2018-04-18T10:07:16Z","git_url":"git://github.com/dmamaevomp/geoclue-providers-mlsdb.git","ssh_url":"git@github.com:dmamaevomp/geoclue-providers-mlsdb.git","clone_url":"https://github.com/dmamaevomp/geoclue-providers-mlsdb.git","svn_url":"https://github.com/dmamaevomp/geoclue-providers-mlsdb","homepage":null,"size":117752,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mer-hybris:master","ref":"master","sha":"77ad5bff1135c6fde6facc7a42418f43cd660232","user":{"login":"mer-hybris","id":5749272,"avatar_url":"https://avatars2.githubusercontent.com/u/5749272?v=4","gravatar_id":"","url":"https://api.github.com/users/mer-hybris","html_url":"https://github.com/mer-hybris","followers_url":"https://api.github.com/users/mer-hybris/followers","following_url":"https://api.github.com/users/mer-hybris/following{/other_user}","gists_url":"https://api.github.com/users/mer-hybris/gists{/gist_id}","starred_url":"https://api.github.com/users/mer-hybris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mer-hybris/subscriptions","organizations_url":"https://api.github.com/users/mer-hybris/orgs","repos_url":"https://api.github.com/users/mer-hybris/repos","events_url":"https://api.github.com/users/mer-hybris/events{/privacy}","received_events_url":"https://api.github.com/users/mer-hybris/received_events","type":"Organization","site_admin":false},"repo":{"id":54623740,"name":"geoclue-providers-mlsdb","full_name":"mer-hybris/geoclue-providers-mlsdb","owner":{"login":"mer-hybris","id":5749272,"avatar_url":"https://avatars2.githubusercontent.com/u/5749272?v=4","gravatar_id":"","url":"https://api.github.com/users/mer-hybris","html_url":"https://github.com/mer-hybris","followers_url":"https://api.github.com/users/mer-hybris/followers","following_url":"https://api.github.com/users/mer-hybris/following{/other_user}","gists_url":"https://api.github.com/users/mer-hybris/gists{/gist_id}","starred_url":"https://api.github.com/users/mer-hybris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mer-hybris/subscriptions","organizations_url":"https://api.github.com/users/mer-hybris/orgs","repos_url":"https://api.github.com/users/mer-hybris/repos","events_url":"https://api.github.com/users/mer-hybris/events{/privacy}","received_events_url":"https://api.github.com/users/mer-hybris/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mer-hybris/geoclue-providers-mlsdb","description":null,"fork":false,"url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb","forks_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/forks","keys_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/teams","hooks_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/hooks","issue_events_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/issues/events{/number}","events_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/events","assignees_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/assignees{/user}","branches_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/branches{/branch}","tags_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/tags","blobs_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/statuses/{sha}","languages_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/languages","stargazers_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/stargazers","contributors_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/contributors","subscribers_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/subscribers","subscription_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/subscription","commits_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/contents/{+path}","compare_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/merges","archive_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/downloads","issues_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/issues{/number}","pulls_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls{/number}","milestones_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/milestones{/number}","notifications_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/labels{/name}","releases_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/releases{/id}","deployments_url":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/deployments","created_at":"2016-03-24T07:42:25Z","updated_at":"2018-03-14T12:52:43Z","pushed_at":"2018-04-24T13:38:10Z","git_url":"git://github.com/mer-hybris/geoclue-providers-mlsdb.git","ssh_url":"git@github.com:mer-hybris/geoclue-providers-mlsdb.git","clone_url":"https://github.com/mer-hybris/geoclue-providers-mlsdb.git","svn_url":"https://github.com/mer-hybris/geoclue-providers-mlsdb","homepage":null,"size":117739,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":6,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/18"},"html":{"href":"https://github.com/mer-hybris/geoclue-providers-mlsdb/pull/18"},"issue":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/issues/18"},"comments":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/mer-hybris/geoclue-providers-mlsdb/statuses/3d1ceed9cb3274c9945a5ac11f91f1d0ae596e03"}},"author_association":"NONE"}}
{"actor":{"display_login":"krnlyng"}}