{"action":"closed","number":350,"pull_request":{"url":"https://api.github.com/repos/thought-machine/please/pulls/350","id":198521834,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTIxODM0","html_url":"https://github.com/thought-machine/please/pull/350","diff_url":"https://github.com/thought-machine/please/pull/350.diff","patch_url":"https://github.com/thought-machine/please/pull/350.patch","issue_url":"https://api.github.com/repos/thought-machine/please/issues/350","number":350,"state":"closed","locked":false,"title":"Distinct treatment of flakes in multiple runs","user":{"login":"agenticarus","id":1618612,"node_id":"MDQ6VXNlcjE2MTg2MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1618612?v=4","gravatar_id":"","url":"https://api.github.com/users/agenticarus","html_url":"https://github.com/agenticarus","followers_url":"https://api.github.com/users/agenticarus/followers","following_url":"https://api.github.com/users/agenticarus/following{/other_user}","gists_url":"https://api.github.com/users/agenticarus/gists{/gist_id}","starred_url":"https://api.github.com/users/agenticarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agenticarus/subscriptions","organizations_url":"https://api.github.com/users/agenticarus/orgs","repos_url":"https://api.github.com/users/agenticarus/repos","events_url":"https://api.github.com/users/agenticarus/events{/privacy}","received_events_url":"https://api.github.com/users/agenticarus/received_events","type":"User","site_admin":false},"body":"Sorry for the size of this diff, it turned out to touch a fair amount of the test code.\r\n\r\nI added a README to the test/ directory, the contents of which serve as the description for this diff:\r\n\r\n```\r\nExecuting `plz test` against a target produces a set of results that are\r\ncollated into one `core.TestSuite` with the package and name matching the\r\ntarget's label (this is a slight departure from the normal package/classname\r\ndecomposition as it does not particularly translate well to non-Java languages).\r\n\r\nIf any tests fail, and the target is marked as `flaky`, it will be run again\r\n(up to `flaky` times). Tests can also be explicitly run multiple times by\r\npassing `--num-runs n` on the command line. We no longer use a default of `0`\r\nas running a test 0 times is (a) not useful and (b) not what actually happened.\r\n\r\nEach executed test during this target becomes a `core.TestExecution` under a\r\n`core.TestCase` in this test suite - so that multiple executions of a test\r\nare put together. We ignore multiple successes or skips as they are not interesting.\r\nIn the case of a flaky test where some runs succeed and some fail, we store at\r\nmost one success but also all of the failures and errors. \r\n\r\nThe `time` of the testsuite is the total time it took to execute all of the\r\ntests (including any re-runs for flakes).\r\n\r\nOnce all of the targets have been executed, these `core.TestSuite`s are\r\ncollected into one `core.TestSuites` object. This is then rendered as XML\r\nto the output file mentioned above.\r\n```\r\n\r\nAll the tests seem to pass locally, but obviously I may not be running all the tests as I'm on a Mac.","created_at":"2018-07-01T12:22:14Z","updated_at":"2018-07-04T10:55:21Z","closed_at":"2018-07-04T10:55:21Z","merged_at":"2018-07-04T10:55:21Z","merge_commit_sha":"3f8691433469da9b708bc0e2961e8fa216b7eeca","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thought-machine/please/pulls/350/commits","review_comments_url":"https://api.github.com/repos/thought-machine/please/pulls/350/comments","review_comment_url":"https://api.github.com/repos/thought-machine/please/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thought-machine/please/issues/350/comments","statuses_url":"https://api.github.com/repos/thought-machine/please/statuses/c09fa8728b4c023680781d0d4eaf6b7916726c58","head":{"label":"agenticarus:feature/test-result-object-meddling","ref":"feature/test-result-object-meddling","sha":"c09fa8728b4c023680781d0d4eaf6b7916726c58","user":{"login":"agenticarus","id":1618612,"node_id":"MDQ6VXNlcjE2MTg2MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1618612?v=4","gravatar_id":"","url":"https://api.github.com/users/agenticarus","html_url":"https://github.com/agenticarus","followers_url":"https://api.github.com/users/agenticarus/followers","following_url":"https://api.github.com/users/agenticarus/following{/other_user}","gists_url":"https://api.github.com/users/agenticarus/gists{/gist_id}","starred_url":"https://api.github.com/users/agenticarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agenticarus/subscriptions","organizations_url":"https://api.github.com/users/agenticarus/orgs","repos_url":"https://api.github.com/users/agenticarus/repos","events_url":"https://api.github.com/users/agenticarus/events{/privacy}","received_events_url":"https://api.github.com/users/agenticarus/received_events","type":"User","site_admin":false},"repo":{"id":134719051,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3MTkwNTE=","name":"please","full_name":"agenticarus/please","owner":{"login":"agenticarus","id":1618612,"node_id":"MDQ6VXNlcjE2MTg2MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1618612?v=4","gravatar_id":"","url":"https://api.github.com/users/agenticarus","html_url":"https://github.com/agenticarus","followers_url":"https://api.github.com/users/agenticarus/followers","following_url":"https://api.github.com/users/agenticarus/following{/other_user}","gists_url":"https://api.github.com/users/agenticarus/gists{/gist_id}","starred_url":"https://api.github.com/users/agenticarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agenticarus/subscriptions","organizations_url":"https://api.github.com/users/agenticarus/orgs","repos_url":"https://api.github.com/users/agenticarus/repos","events_url":"https://api.github.com/users/agenticarus/events{/privacy}","received_events_url":"https://api.github.com/users/agenticarus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agenticarus/please","description":"High-performance extensible build system for reproducible builds.","fork":true,"url":"https://api.github.com/repos/agenticarus/please","forks_url":"https://api.github.com/repos/agenticarus/please/forks","keys_url":"https://api.github.com/repos/agenticarus/please/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agenticarus/please/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agenticarus/please/teams","hooks_url":"https://api.github.com/repos/agenticarus/please/hooks","issue_events_url":"https://api.github.com/repos/agenticarus/please/issues/events{/number}","events_url":"https://api.github.com/repos/agenticarus/please/events","assignees_url":"https://api.github.com/repos/agenticarus/please/assignees{/user}","branches_url":"https://api.github.com/repos/agenticarus/please/branches{/branch}","tags_url":"https://api.github.com/repos/agenticarus/please/tags","blobs_url":"https://api.github.com/repos/agenticarus/please/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agenticarus/please/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agenticarus/please/git/refs{/sha}","trees_url":"https://api.github.com/repos/agenticarus/please/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agenticarus/please/statuses/{sha}","languages_url":"https://api.github.com/repos/agenticarus/please/languages","stargazers_url":"https://api.github.com/repos/agenticarus/please/stargazers","contributors_url":"https://api.github.com/repos/agenticarus/please/contributors","subscribers_url":"https://api.github.com/repos/agenticarus/please/subscribers","subscription_url":"https://api.github.com/repos/agenticarus/please/subscription","commits_url":"https://api.github.com/repos/agenticarus/please/commits{/sha}","git_commits_url":"https://api.github.com/repos/agenticarus/please/git/commits{/sha}","comments_url":"https://api.github.com/repos/agenticarus/please/comments{/number}","issue_comment_url":"https://api.github.com/repos/agenticarus/please/issues/comments{/number}","contents_url":"https://api.github.com/repos/agenticarus/please/contents/{+path}","compare_url":"https://api.github.com/repos/agenticarus/please/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agenticarus/please/merges","archive_url":"https://api.github.com/repos/agenticarus/please/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agenticarus/please/downloads","issues_url":"https://api.github.com/repos/agenticarus/please/issues{/number}","pulls_url":"https://api.github.com/repos/agenticarus/please/pulls{/number}","milestones_url":"https://api.github.com/repos/agenticarus/please/milestones{/number}","notifications_url":"https://api.github.com/repos/agenticarus/please/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agenticarus/please/labels{/name}","releases_url":"https://api.github.com/repos/agenticarus/please/releases{/id}","deployments_url":"https://api.github.com/repos/agenticarus/please/deployments","created_at":"2018-05-24T13:26:42Z","updated_at":"2018-07-01T12:17:54Z","pushed_at":"2018-07-03T20:47:28Z","git_url":"git://github.com/agenticarus/please.git","ssh_url":"git@github.com:agenticarus/please.git","clone_url":"https://github.com/agenticarus/please.git","svn_url":"https://github.com/agenticarus/please","homepage":"https://please.build","size":4724,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thought-machine:master","ref":"master","sha":"1dcc9f245ed5824f28baf9001e5300e3d361a2aa","user":{"login":"thought-machine","id":16104327,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTA0MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/16104327?v=4","gravatar_id":"","url":"https://api.github.com/users/thought-machine","html_url":"https://github.com/thought-machine","followers_url":"https://api.github.com/users/thought-machine/followers","following_url":"https://api.github.com/users/thought-machine/following{/other_user}","gists_url":"https://api.github.com/users/thought-machine/gists{/gist_id}","starred_url":"https://api.github.com/users/thought-machine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thought-machine/subscriptions","organizations_url":"https://api.github.com/users/thought-machine/orgs","repos_url":"https://api.github.com/users/thought-machine/repos","events_url":"https://api.github.com/users/thought-machine/events{/privacy}","received_events_url":"https://api.github.com/users/thought-machine/received_events","type":"Organization","site_admin":false},"repo":{"id":50915867,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkxNTg2Nw==","name":"please","full_name":"thought-machine/please","owner":{"login":"thought-machine","id":16104327,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTA0MzI3","avatar_url":"https://avatars2.githubusercontent.com/u/16104327?v=4","gravatar_id":"","url":"https://api.github.com/users/thought-machine","html_url":"https://github.com/thought-machine","followers_url":"https://api.github.com/users/thought-machine/followers","following_url":"https://api.github.com/users/thought-machine/following{/other_user}","gists_url":"https://api.github.com/users/thought-machine/gists{/gist_id}","starred_url":"https://api.github.com/users/thought-machine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thought-machine/subscriptions","organizations_url":"https://api.github.com/users/thought-machine/orgs","repos_url":"https://api.github.com/users/thought-machine/repos","events_url":"https://api.github.com/users/thought-machine/events{/privacy}","received_events_url":"https://api.github.com/users/thought-machine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thought-machine/please","description":"High-performance extensible build system for reproducible builds.","fork":false,"url":"https://api.github.com/repos/thought-machine/please","forks_url":"https://api.github.com/repos/thought-machine/please/forks","keys_url":"https://api.github.com/repos/thought-machine/please/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thought-machine/please/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thought-machine/please/teams","hooks_url":"https://api.github.com/repos/thought-machine/please/hooks","issue_events_url":"https://api.github.com/repos/thought-machine/please/issues/events{/number}","events_url":"https://api.github.com/repos/thought-machine/please/events","assignees_url":"https://api.github.com/repos/thought-machine/please/assignees{/user}","branches_url":"https://api.github.com/repos/thought-machine/please/branches{/branch}","tags_url":"https://api.github.com/repos/thought-machine/please/tags","blobs_url":"https://api.github.com/repos/thought-machine/please/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thought-machine/please/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thought-machine/please/git/refs{/sha}","trees_url":"https://api.github.com/repos/thought-machine/please/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thought-machine/please/statuses/{sha}","languages_url":"https://api.github.com/repos/thought-machine/please/languages","stargazers_url":"https://api.github.com/repos/thought-machine/please/stargazers","contributors_url":"https://api.github.com/repos/thought-machine/please/contributors","subscribers_url":"https://api.github.com/repos/thought-machine/please/subscribers","subscription_url":"https://api.github.com/repos/thought-machine/please/subscription","commits_url":"https://api.github.com/repos/thought-machine/please/commits{/sha}","git_commits_url":"https://api.github.com/repos/thought-machine/please/git/commits{/sha}","comments_url":"https://api.github.com/repos/thought-machine/please/comments{/number}","issue_comment_url":"https://api.github.com/repos/thought-machine/please/issues/comments{/number}","contents_url":"https://api.github.com/repos/thought-machine/please/contents/{+path}","compare_url":"https://api.github.com/repos/thought-machine/please/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thought-machine/please/merges","archive_url":"https://api.github.com/repos/thought-machine/please/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thought-machine/please/downloads","issues_url":"https://api.github.com/repos/thought-machine/please/issues{/number}","pulls_url":"https://api.github.com/repos/thought-machine/please/pulls{/number}","milestones_url":"https://api.github.com/repos/thought-machine/please/milestones{/number}","notifications_url":"https://api.github.com/repos/thought-machine/please/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thought-machine/please/labels{/name}","releases_url":"https://api.github.com/repos/thought-machine/please/releases{/id}","deployments_url":"https://api.github.com/repos/thought-machine/please/deployments","created_at":"2016-02-02T11:27:05Z","updated_at":"2018-07-03T14:20:07Z","pushed_at":"2018-07-04T10:55:21Z","git_url":"git://github.com/thought-machine/please.git","ssh_url":"git@github.com:thought-machine/please.git","clone_url":"https://github.com/thought-machine/please.git","svn_url":"https://github.com/thought-machine/please","homepage":"https://please.build","size":4635,"stargazers_count":345,"watchers_count":345,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":35,"open_issues":14,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thought-machine/please/pulls/350"},"html":{"href":"https://github.com/thought-machine/please/pull/350"},"issue":{"href":"https://api.github.com/repos/thought-machine/please/issues/350"},"comments":{"href":"https://api.github.com/repos/thought-machine/please/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/thought-machine/please/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/thought-machine/please/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thought-machine/please/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/thought-machine/please/statuses/c09fa8728b4c023680781d0d4eaf6b7916726c58"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"agenticarus","id":1618612,"node_id":"MDQ6VXNlcjE2MTg2MTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1618612?v=4","gravatar_id":"","url":"https://api.github.com/users/agenticarus","html_url":"https://github.com/agenticarus","followers_url":"https://api.github.com/users/agenticarus/followers","following_url":"https://api.github.com/users/agenticarus/following{/other_user}","gists_url":"https://api.github.com/users/agenticarus/gists{/gist_id}","starred_url":"https://api.github.com/users/agenticarus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agenticarus/subscriptions","organizations_url":"https://api.github.com/users/agenticarus/orgs","repos_url":"https://api.github.com/users/agenticarus/repos","events_url":"https://api.github.com/users/agenticarus/events{/privacy}","received_events_url":"https://api.github.com/users/agenticarus/received_events","type":"User","site_admin":false},"comments":1,"review_comments":29,"maintainer_can_modify":false,"commits":33,"additions":1615,"deletions":567,"changed_files":23}}
{"actor":{"display_login":"agenticarus"}}