{"action":"created","comment":{"url":"https://api.github.com/repos/brave/brave-core/pulls/comments/198359114","pull_request_review_id":132276170,"id":198359114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODM1OTExNA==","diff_hunk":"@@ -0,0 +1,34 @@\n+diff --git a/chrome/install_static/install_modes.cc b/chrome/install_static/install_modes.cc\n+index 42d9966254758305e0dc999b186aa7abe1ff762a..147dd51211c889bdcbde29ae0537a6e17d045dd8 100644\n+--- a/chrome/install_static/install_modes.cc\n++++ b/chrome/install_static/install_modes.cc\n+@@ -12,6 +12,21 @@ std::wstring GetUnregisteredKeyPathForProduct(const wchar_t* product) {\n+   return std::wstring(L\"Software\\\\\").append(product);\n+ }\n+ \n++#if defined(BRAVE_CHROMIUM_BUILD)","path":"patches/chrome-install_static-install_modes.cc.patch","position":9,"original_position":9,"commit_id":"0a7baba8509e639881bb3ea5bcd5116a8f230542","original_commit_id":"e1d61ed963208733575af0eadc0b90ed5fe6c323","user":{"login":"simonhong","id":6786187,"node_id":"MDQ6VXNlcjY3ODYxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6786187?v=4","gravatar_id":"","url":"https://api.github.com/users/simonhong","html_url":"https://github.com/simonhong","followers_url":"https://api.github.com/users/simonhong/followers","following_url":"https://api.github.com/users/simonhong/following{/other_user}","gists_url":"https://api.github.com/users/simonhong/gists{/gist_id}","starred_url":"https://api.github.com/users/simonhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonhong/subscriptions","organizations_url":"https://api.github.com/users/simonhong/orgs","repos_url":"https://api.github.com/users/simonhong/repos","events_url":"https://api.github.com/users/simonhong/events{/privacy}","received_events_url":"https://api.github.com/users/simonhong/received_events","type":"User","site_admin":false},"body":"Left some comment for the record.\r\nThis is the reason why patching technique is used instead of overriding.\r\nIn case of `install_modes.cc`, override technique causes modifying all functions in that file and can't reuse upstream functions. It is similar to copying technique.\r\nIMO, patching technique is more better to copying for future rebase.\r\nI thought def/undef technique is *only* useful when we can re-use upstream implementation","created_at":"2018-06-27T03:44:24Z","updated_at":"2018-06-27T03:44:24Z","html_url":"https://github.com/brave/brave-core/pull/109#discussion_r198359114","pull_request_url":"https://api.github.com/repos/brave/brave-core/pulls/109","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments/198359114"},"html":{"href":"https://github.com/brave/brave-core/pull/109#discussion_r198359114"},"pull_request":{"href":"https://api.github.com/repos/brave/brave-core/pulls/109"}},"in_reply_to_id":195574236},"pull_request":{"url":"https://api.github.com/repos/brave/brave-core/pulls/109","id":189396747,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5Mzk2NzQ3","html_url":"https://github.com/brave/brave-core/pull/109","diff_url":"https://github.com/brave/brave-core/pull/109.diff","patch_url":"https://github.com/brave/brave-core/pull/109.patch","issue_url":"https://api.github.com/repos/brave/brave-core/issues/109","number":109,"state":"closed","locked":false,"title":"Integrate Brave omaha","user":{"login":"simonhong","id":6786187,"node_id":"MDQ6VXNlcjY3ODYxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6786187?v=4","gravatar_id":"","url":"https://api.github.com/users/simonhong","html_url":"https://github.com/simonhong","followers_url":"https://api.github.com/users/simonhong/followers","following_url":"https://api.github.com/users/simonhong/following{/other_user}","gists_url":"https://api.github.com/users/simonhong/gists{/gist_id}","starred_url":"https://api.github.com/users/simonhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonhong/subscriptions","organizations_url":"https://api.github.com/users/simonhong/orgs","repos_url":"https://api.github.com/users/simonhong/repos","events_url":"https://api.github.com/users/simonhong/events{/privacy}","received_events_url":"https://api.github.com/users/simonhong/received_events","type":"User","site_admin":false},"body":"Testing with https://github.com/simonhong/omaha/tree/brave_omaha\r\n\r\nWhen refresh `settings/help`, BraveUpdate.exe process runs and terminated.\r\n\r\nWork together with https://github.com/brave/brave-browser/pull/303.\r\n\r\nCloses: https://github.com/brave/brave-browser/issues/179\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/brave-browser/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request as needed.\r\n- [ ] Request a security/privacy review as needed.\r\n\r\n## Test Plan:\r\n\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] New files have MPL-2.0 license header.\r\n- [ ] Request a security/privacy review as needed.\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n","created_at":"2018-05-21T14:34:16Z","updated_at":"2018-06-27T03:44:24Z","closed_at":"2018-06-26T02:21:54Z","merged_at":"2018-06-26T02:21:54Z","merge_commit_sha":"bc58f60b0af24a1d35cafadd49f6ba03e615aa62","assignee":{"login":"simonhong","id":6786187,"node_id":"MDQ6VXNlcjY3ODYxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6786187?v=4","gravatar_id":"","url":"https://api.github.com/users/simonhong","html_url":"https://github.com/simonhong","followers_url":"https://api.github.com/users/simonhong/followers","following_url":"https://api.github.com/users/simonhong/following{/other_user}","gists_url":"https://api.github.com/users/simonhong/gists{/gist_id}","starred_url":"https://api.github.com/users/simonhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonhong/subscriptions","organizations_url":"https://api.github.com/users/simonhong/orgs","repos_url":"https://api.github.com/users/simonhong/repos","events_url":"https://api.github.com/users/simonhong/events{/privacy}","received_events_url":"https://api.github.com/users/simonhong/received_events","type":"User","site_admin":false},"assignees":[{"login":"simonhong","id":6786187,"node_id":"MDQ6VXNlcjY3ODYxODc=","avatar_url":"https://avatars3.githubusercontent.com/u/6786187?v=4","gravatar_id":"","url":"https://api.github.com/users/simonhong","html_url":"https://github.com/simonhong","followers_url":"https://api.github.com/users/simonhong/followers","following_url":"https://api.github.com/users/simonhong/following{/other_user}","gists_url":"https://api.github.com/users/simonhong/gists{/gist_id}","starred_url":"https://api.github.com/users/simonhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonhong/subscriptions","organizations_url":"https://api.github.com/users/simonhong/orgs","repos_url":"https://api.github.com/users/simonhong/repos","events_url":"https://api.github.com/users/simonhong/events{/privacy}","received_events_url":"https://api.github.com/users/simonhong/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brave/brave-core/pulls/109/commits","review_comments_url":"https://api.github.com/repos/brave/brave-core/pulls/109/comments","review_comment_url":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/brave-core/issues/109/comments","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/0a7baba8509e639881bb3ea5bcd5116a8f230542","head":{"label":"brave:integrate_omaha","ref":"integrate_omaha","sha":"0a7baba8509e639881bb3ea5bcd5116a8f230542","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android ","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-06-27T02:17:54Z","pushed_at":"2018-06-27T02:43:47Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":11442,"stargazers_count":70,"watchers_count":70,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":5,"watchers":70,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"66a882da31e8199eb740c1a50799f8151f043dd9","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":110198384,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxOTgzODQ=","name":"brave-core","full_name":"brave/brave-core","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/brave-core","description":"Core engine for the Brave browser for macOS, Windows, Linux, and eventually Android ","fork":false,"url":"https://api.github.com/repos/brave/brave-core","forks_url":"https://api.github.com/repos/brave/brave-core/forks","keys_url":"https://api.github.com/repos/brave/brave-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/brave-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/brave-core/teams","hooks_url":"https://api.github.com/repos/brave/brave-core/hooks","issue_events_url":"https://api.github.com/repos/brave/brave-core/issues/events{/number}","events_url":"https://api.github.com/repos/brave/brave-core/events","assignees_url":"https://api.github.com/repos/brave/brave-core/assignees{/user}","branches_url":"https://api.github.com/repos/brave/brave-core/branches{/branch}","tags_url":"https://api.github.com/repos/brave/brave-core/tags","blobs_url":"https://api.github.com/repos/brave/brave-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/brave-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/brave-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/brave-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/brave-core/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/brave-core/languages","stargazers_url":"https://api.github.com/repos/brave/brave-core/stargazers","contributors_url":"https://api.github.com/repos/brave/brave-core/contributors","subscribers_url":"https://api.github.com/repos/brave/brave-core/subscribers","subscription_url":"https://api.github.com/repos/brave/brave-core/subscription","commits_url":"https://api.github.com/repos/brave/brave-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/brave-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/brave-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/brave-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/brave-core/contents/{+path}","compare_url":"https://api.github.com/repos/brave/brave-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/brave-core/merges","archive_url":"https://api.github.com/repos/brave/brave-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/brave-core/downloads","issues_url":"https://api.github.com/repos/brave/brave-core/issues{/number}","pulls_url":"https://api.github.com/repos/brave/brave-core/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/brave-core/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/brave-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/brave-core/labels{/name}","releases_url":"https://api.github.com/repos/brave/brave-core/releases{/id}","deployments_url":"https://api.github.com/repos/brave/brave-core/deployments","created_at":"2017-11-10T03:33:30Z","updated_at":"2018-06-27T02:17:54Z","pushed_at":"2018-06-27T02:43:47Z","git_url":"git://github.com/brave/brave-core.git","ssh_url":"git@github.com:brave/brave-core.git","clone_url":"https://github.com/brave/brave-core.git","svn_url":"https://github.com/brave/brave-core","homepage":"","size":11442,"stargazers_count":70,"watchers_count":70,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":16,"open_issues":5,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/brave-core/pulls/109"},"html":{"href":"https://github.com/brave/brave-core/pull/109"},"issue":{"href":"https://api.github.com/repos/brave/brave-core/issues/109"},"comments":{"href":"https://api.github.com/repos/brave/brave-core/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/brave-core/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/brave-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/brave-core/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/brave/brave-core/statuses/0a7baba8509e639881bb3ea5bcd5116a8f230542"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"simonhong"}}