{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/resource-timing/pulls/comments/226855463","pull_request_review_id":166777769,"id":226855463,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjg1NTQ2Mw==","diff_hunk":"@@ -893,13 +893,17 @@ <h4><code>Timing-Allow-Origin</code> Response Header</h4>\n </li>\n <li>\n <p>If the <a>Timing-Allow-Origin</a> header value list contains a\n-case-sensitive match for the value of the <code><a data-cite=\n-\"RFC6454#section-4\" data-lt=\"http-origin\">origin</a></code> of the\n-<a>current document</a>, or a wildcard (\"<code>*</code>\"), return\n-<code>pass</code>.</p>\n+value which is byte-for-byte identical to the <a\n+data-cite=\"HTML#ascii-serialisation-of-an-origin\">serialization</a>\n+of the <a>current document</a>'s <a data-cite=\"DOM#concept-document-origin\">origin</a>,\n+or a wildcard (\"<code>*</code>\"), return <code>pass</code>.</p>\n </li>\n <li>Return <code>fail</code>.</li>\n </ol>\n+<p class=\"issue\" data-number=\"152\">Above \"timing allow check\" algorithm should also verify that \n+no cross-origin redirections were involved in the response, as that would \n+leak timing information about those origins.\n+</p>","path":"index.html","position":18,"original_position":18,"commit_id":"23c434b39f5fcd8c0deecc78b60dd066ccd076d1","original_commit_id":"8b20a2f30f31235297ce32c85c9046e468040c16","user":{"login":"yoavweiss","id":786187,"node_id":"MDQ6VXNlcjc4NjE4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/786187?v=4","gravatar_id":"","url":"https://api.github.com/users/yoavweiss","html_url":"https://github.com/yoavweiss","followers_url":"https://api.github.com/users/yoavweiss/followers","following_url":"https://api.github.com/users/yoavweiss/following{/other_user}","gists_url":"https://api.github.com/users/yoavweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavweiss/subscriptions","organizations_url":"https://api.github.com/users/yoavweiss/orgs","repos_url":"https://api.github.com/users/yoavweiss/repos","events_url":"https://api.github.com/users/yoavweiss/events{/privacy}","received_events_url":"https://api.github.com/users/yoavweiss/received_events","type":"User","site_admin":false},"body":"One scenario could be:\r\n* malicious.com redirects a resource to victim.com (which unfortunately exposes a redirection endpoint, which can redirect back to any arbitrary URL). It uses the redirection endpoint to redirect back to malicious.com.\r\n* With current language, that would expose timing information about victim.com, which may be used to conclude's the user's login state, or other personal information.","created_at":"2018-10-21T09:41:51Z","updated_at":"2018-10-21T09:41:51Z","html_url":"https://github.com/w3c/resource-timing/pull/172#discussion_r226855463","pull_request_url":"https://api.github.com/repos/w3c/resource-timing/pulls/172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/resource-timing/pulls/comments/226855463"},"html":{"href":"https://github.com/w3c/resource-timing/pull/172#discussion_r226855463"},"pull_request":{"href":"https://api.github.com/repos/w3c/resource-timing/pulls/172"}},"in_reply_to_id":226074901},"pull_request":{"url":"https://api.github.com/repos/w3c/resource-timing/pulls/172","id":222497035,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNDk3MDM1","html_url":"https://github.com/w3c/resource-timing/pull/172","diff_url":"https://github.com/w3c/resource-timing/pull/172.diff","patch_url":"https://github.com/w3c/resource-timing/pull/172.patch","issue_url":"https://api.github.com/repos/w3c/resource-timing/issues/172","number":172,"state":"open","locked":false,"title":"Use HTML's origin serialization, add note regarding TAO and redirects","user":{"login":"yoavweiss","id":786187,"node_id":"MDQ6VXNlcjc4NjE4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/786187?v=4","gravatar_id":"","url":"https://api.github.com/users/yoavweiss","html_url":"https://github.com/yoavweiss","followers_url":"https://api.github.com/users/yoavweiss/followers","following_url":"https://api.github.com/users/yoavweiss/following{/other_user}","gists_url":"https://api.github.com/users/yoavweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavweiss/subscriptions","organizations_url":"https://api.github.com/users/yoavweiss/orgs","repos_url":"https://api.github.com/users/yoavweiss/repos","events_url":"https://api.github.com/users/yoavweiss/events{/privacy}","received_events_url":"https://api.github.com/users/yoavweiss/received_events","type":"User","site_admin":false},"body":"Addresses some of the concerns for https://github.com/w3c/resource-timing/issues/152\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://pr-preview.s3.amazonaws.com/yoavweiss/resource-timing/pull/172.html\" title=\"Last updated on Oct 21, 2018, 9:36 AM GMT (23c434b)\">Preview</a> | <a href=\"https://pr-preview.s3.amazonaws.com/w3c/resource-timing/172/cd2e3ec...yoavweiss:23c434b.html\" title=\"Last updated on Oct 21, 2018, 9:36 AM GMT (23c434b)\">Diff</a>","created_at":"2018-10-12T15:04:48Z","updated_at":"2018-10-21T09:41:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00f55b57d018d305cc471de0402c4f7c7fd209c4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/resource-timing/pulls/172/commits","review_comments_url":"https://api.github.com/repos/w3c/resource-timing/pulls/172/comments","review_comment_url":"https://api.github.com/repos/w3c/resource-timing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/resource-timing/issues/172/comments","statuses_url":"https://api.github.com/repos/w3c/resource-timing/statuses/23c434b39f5fcd8c0deecc78b60dd066ccd076d1","head":{"label":"yoavweiss:origin_or_null","ref":"origin_or_null","sha":"23c434b39f5fcd8c0deecc78b60dd066ccd076d1","user":{"login":"yoavweiss","id":786187,"node_id":"MDQ6VXNlcjc4NjE4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/786187?v=4","gravatar_id":"","url":"https://api.github.com/users/yoavweiss","html_url":"https://github.com/yoavweiss","followers_url":"https://api.github.com/users/yoavweiss/followers","following_url":"https://api.github.com/users/yoavweiss/following{/other_user}","gists_url":"https://api.github.com/users/yoavweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavweiss/subscriptions","organizations_url":"https://api.github.com/users/yoavweiss/orgs","repos_url":"https://api.github.com/users/yoavweiss/repos","events_url":"https://api.github.com/users/yoavweiss/events{/privacy}","received_events_url":"https://api.github.com/users/yoavweiss/received_events","type":"User","site_admin":false},"repo":{"id":44930670,"node_id":"MDEwOlJlcG9zaXRvcnk0NDkzMDY3MA==","name":"resource-timing","full_name":"yoavweiss/resource-timing","private":false,"owner":{"login":"yoavweiss","id":786187,"node_id":"MDQ6VXNlcjc4NjE4Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/786187?v=4","gravatar_id":"","url":"https://api.github.com/users/yoavweiss","html_url":"https://github.com/yoavweiss","followers_url":"https://api.github.com/users/yoavweiss/followers","following_url":"https://api.github.com/users/yoavweiss/following{/other_user}","gists_url":"https://api.github.com/users/yoavweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/yoavweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yoavweiss/subscriptions","organizations_url":"https://api.github.com/users/yoavweiss/orgs","repos_url":"https://api.github.com/users/yoavweiss/repos","events_url":"https://api.github.com/users/yoavweiss/events{/privacy}","received_events_url":"https://api.github.com/users/yoavweiss/received_events","type":"User","site_admin":false},"html_url":"https://github.com/yoavweiss/resource-timing","description":"Resource Timing draft spec from webperf","fork":true,"url":"https://api.github.com/repos/yoavweiss/resource-timing","forks_url":"https://api.github.com/repos/yoavweiss/resource-timing/forks","keys_url":"https://api.github.com/repos/yoavweiss/resource-timing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yoavweiss/resource-timing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yoavweiss/resource-timing/teams","hooks_url":"https://api.github.com/repos/yoavweiss/resource-timing/hooks","issue_events_url":"https://api.github.com/repos/yoavweiss/resource-timing/issues/events{/number}","events_url":"https://api.github.com/repos/yoavweiss/resource-timing/events","assignees_url":"https://api.github.com/repos/yoavweiss/resource-timing/assignees{/user}","branches_url":"https://api.github.com/repos/yoavweiss/resource-timing/branches{/branch}","tags_url":"https://api.github.com/repos/yoavweiss/resource-timing/tags","blobs_url":"https://api.github.com/repos/yoavweiss/resource-timing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yoavweiss/resource-timing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yoavweiss/resource-timing/git/refs{/sha}","trees_url":"https://api.github.com/repos/yoavweiss/resource-timing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yoavweiss/resource-timing/statuses/{sha}","languages_url":"https://api.github.com/repos/yoavweiss/resource-timing/languages","stargazers_url":"https://api.github.com/repos/yoavweiss/resource-timing/stargazers","contributors_url":"https://api.github.com/repos/yoavweiss/resource-timing/contributors","subscribers_url":"https://api.github.com/repos/yoavweiss/resource-timing/subscribers","subscription_url":"https://api.github.com/repos/yoavweiss/resource-timing/subscription","commits_url":"https://api.github.com/repos/yoavweiss/resource-timing/commits{/sha}","git_commits_url":"https://api.github.com/repos/yoavweiss/resource-timing/git/commits{/sha}","comments_url":"https://api.github.com/repos/yoavweiss/resource-timing/comments{/number}","issue_comment_url":"https://api.github.com/repos/yoavweiss/resource-timing/issues/comments{/number}","contents_url":"https://api.github.com/repos/yoavweiss/resource-timing/contents/{+path}","compare_url":"https://api.github.com/repos/yoavweiss/resource-timing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yoavweiss/resource-timing/merges","archive_url":"https://api.github.com/repos/yoavweiss/resource-timing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yoavweiss/resource-timing/downloads","issues_url":"https://api.github.com/repos/yoavweiss/resource-timing/issues{/number}","pulls_url":"https://api.github.com/repos/yoavweiss/resource-timing/pulls{/number}","milestones_url":"https://api.github.com/repos/yoavweiss/resource-timing/milestones{/number}","notifications_url":"https://api.github.com/repos/yoavweiss/resource-timing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yoavweiss/resource-timing/labels{/name}","releases_url":"https://api.github.com/repos/yoavweiss/resource-timing/releases{/id}","deployments_url":"https://api.github.com/repos/yoavweiss/resource-timing/deployments","created_at":"2015-10-25T21:29:27Z","updated_at":"2018-10-11T10:39:37Z","pushed_at":"2018-10-21T09:36:48Z","git_url":"git://github.com/yoavweiss/resource-timing.git","ssh_url":"git@github.com:yoavweiss/resource-timing.git","clone_url":"https://github.com/yoavweiss/resource-timing.git","svn_url":"https://github.com/yoavweiss/resource-timing","homepage":null,"size":600,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"w3c:gh-pages","ref":"gh-pages","sha":"13dd433772330932c4bdcc89a0be42b1b415a9ff","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":25276748,"node_id":"MDEwOlJlcG9zaXRvcnkyNTI3Njc0OA==","name":"resource-timing","full_name":"w3c/resource-timing","private":false,"owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/w3c/resource-timing","description":"Resource Timing draft spec from webperf","fork":false,"url":"https://api.github.com/repos/w3c/resource-timing","forks_url":"https://api.github.com/repos/w3c/resource-timing/forks","keys_url":"https://api.github.com/repos/w3c/resource-timing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/resource-timing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/resource-timing/teams","hooks_url":"https://api.github.com/repos/w3c/resource-timing/hooks","issue_events_url":"https://api.github.com/repos/w3c/resource-timing/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/resource-timing/events","assignees_url":"https://api.github.com/repos/w3c/resource-timing/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/resource-timing/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/resource-timing/tags","blobs_url":"https://api.github.com/repos/w3c/resource-timing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/resource-timing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/resource-timing/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/resource-timing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/resource-timing/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/resource-timing/languages","stargazers_url":"https://api.github.com/repos/w3c/resource-timing/stargazers","contributors_url":"https://api.github.com/repos/w3c/resource-timing/contributors","subscribers_url":"https://api.github.com/repos/w3c/resource-timing/subscribers","subscription_url":"https://api.github.com/repos/w3c/resource-timing/subscription","commits_url":"https://api.github.com/repos/w3c/resource-timing/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/resource-timing/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/resource-timing/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/resource-timing/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/resource-timing/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/resource-timing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/resource-timing/merges","archive_url":"https://api.github.com/repos/w3c/resource-timing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/resource-timing/downloads","issues_url":"https://api.github.com/repos/w3c/resource-timing/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/resource-timing/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/resource-timing/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/resource-timing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/resource-timing/labels{/name}","releases_url":"https://api.github.com/repos/w3c/resource-timing/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/resource-timing/deployments","created_at":"2014-10-15T22:43:37Z","updated_at":"2018-10-17T13:58:11Z","pushed_at":"2018-10-21T09:36:50Z","git_url":"git://github.com/w3c/resource-timing.git","ssh_url":"git@github.com:w3c/resource-timing.git","clone_url":"https://github.com/w3c/resource-timing.git","svn_url":"https://github.com/w3c/resource-timing","homepage":"https://w3c.github.io/resource-timing/","size":595,"stargazers_count":59,"watchers_count":59,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":21,"open_issues":46,"watchers":59,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/resource-timing/pulls/172"},"html":{"href":"https://github.com/w3c/resource-timing/pull/172"},"issue":{"href":"https://api.github.com/repos/w3c/resource-timing/issues/172"},"comments":{"href":"https://api.github.com/repos/w3c/resource-timing/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/resource-timing/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/resource-timing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/resource-timing/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/resource-timing/statuses/23c434b39f5fcd8c0deecc78b60dd066ccd076d1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yoavweiss"}}