{"action":"created","issue":{"url":"https://api.github.com/repos/aurelia/cli/issues/862","repository_url":"https://api.github.com/repos/aurelia/cli","labels_url":"https://api.github.com/repos/aurelia/cli/issues/862/labels{/name}","comments_url":"https://api.github.com/repos/aurelia/cli/issues/862/comments","events_url":"https://api.github.com/repos/aurelia/cli/issues/862/events","html_url":"https://github.com/aurelia/cli/pull/862","id":310115576,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4NTk2MDYz","number":862,"title":"feat(bundler): auto tracing for requirejs/systemjs","user":{"login":"huochunpeng","id":1188806,"node_id":"MDQ6VXNlcjExODg4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1188806?v=4","gravatar_id":"","url":"https://api.github.com/users/huochunpeng","html_url":"https://github.com/huochunpeng","followers_url":"https://api.github.com/users/huochunpeng/followers","following_url":"https://api.github.com/users/huochunpeng/following{/other_user}","gists_url":"https://api.github.com/users/huochunpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/huochunpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huochunpeng/subscriptions","organizations_url":"https://api.github.com/users/huochunpeng/orgs","repos_url":"https://api.github.com/users/huochunpeng/repos","events_url":"https://api.github.com/users/huochunpeng/events{/privacy}","received_events_url":"https://api.github.com/users/huochunpeng/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":44,"created_at":"2018-03-30T16:58:15Z","updated_at":"2018-09-25T23:52:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aurelia/cli/pulls/862","html_url":"https://github.com/aurelia/cli/pull/862","diff_url":"https://github.com/aurelia/cli/pull/862.diff","patch_url":"https://github.com/aurelia/cli/pull/862.patch"},"body":"remove all lib/importer files.\r\nremove most of amodro-tracing.\r\nmanual efficient js and html tracing for aurelia.\r\nremove irrelevant tracing cache.\r\ncover all aurelia-webpack-plugin covers, plus more edge cases.\r\nmore permissive, usage of PLATFORM.moduleName is NOT required.\r\nalmost zero manual maintenance of aurelia.json dependencies.\r\nfix node id compatibility issue #831 for both requirejs and systemjs.\r\nfix bundles moduleIds format for modules need plugin.\r\nfix compatibility issue with yarn workspaces.\r\nsupport npm package \"main\":\"./lib\" when main file is lib/index.js.\r\nimprove backwards compatibility by ignoring main:false.\r\nsimplify and reduce source code, but increase test coverge.\r\nadd \"au run --watch --auto-install\" for frictionless dev flow.\r\nbest guess on package manager 'yarn' to avoid 'npm i' error on yarn\r\ncontrolled node_modules.\r\novertake webpack on simplicity, usability, compatibility and flexibility,\r\nbut probably not on performance.\r\nperform slightly faster than existing amodro-trace + cache.\r\n\r\nCloses #579, #581, #872\r\nSupersede #853, #842, #831\r\nBREAKING CHANGE: require minor user code change to support non-js main, like \"main\": \"font-awesome.css\"\r\nBREAKING CHANGE: remove support of undocumented \"main\": false, replace with generic \"lazyMain\": true. But this is handled transparently without breaking user's existing app."},"comment":{"url":"https://api.github.com/repos/aurelia/cli/issues/comments/424539056","html_url":"https://github.com/aurelia/cli/pull/862#issuecomment-424539056","issue_url":"https://api.github.com/repos/aurelia/cli/issues/862","id":424539056,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDUzOTA1Ng==","user":{"login":"huochunpeng","id":1188806,"node_id":"MDQ6VXNlcjExODg4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1188806?v=4","gravatar_id":"","url":"https://api.github.com/users/huochunpeng","html_url":"https://github.com/huochunpeng","followers_url":"https://api.github.com/users/huochunpeng/followers","following_url":"https://api.github.com/users/huochunpeng/following{/other_user}","gists_url":"https://api.github.com/users/huochunpeng/gists{/gist_id}","starred_url":"https://api.github.com/users/huochunpeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huochunpeng/subscriptions","organizations_url":"https://api.github.com/users/huochunpeng/orgs","repos_url":"https://api.github.com/users/huochunpeng/repos","events_url":"https://api.github.com/users/huochunpeng/events{/privacy}","received_events_url":"https://api.github.com/users/huochunpeng/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T23:52:53Z","updated_at":"2018-09-25T23:52:53Z","author_association":"CONTRIBUTOR","body":"@simonfox thx!\r\nI checked velocity-animator, the v1 is really messed up. v2 fixed the module deps, but aurelia-animator-velocity doesn't work with v2 right now.\r\n\r\n1. short-term fix with auto-tracing: (I will add this to the doc)\r\n\r\n* Add this to aurelia.json, note this is all you need in aurelia.json.\r\n```\r\n{\r\n  \"name\": \"velocity-animate\",\r\n  \"deps\": [\"jquery\"]\r\n}\r\n```\r\n* modify your `aurelia_project/tasks/build.js`, this bypass the messed up dep in velocity-animate/velocity-ui. Similar to what you got from the ref suggestion, but this one is easier.\r\n```\r\nfunction writeBundles() {\r\n  return buildCLI.dest({\r\n    onRequiringModule: function(moduleName) {\r\n      if (moduleName === 'velocity') return \"define(['velocity-animate'],function(m){return m;});\";\r\n    }\r\n  });\r\n}\r\n```\r\n\r\n2. long-term fix, update aurelia-animator-velocity to velocity-animator v2. Everything will be automatic by then. @EisenbergEffect who is the maintainer?"}}
{"actor":{"display_login":"huochunpeng"}}