{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments/233959726","pull_request_review_id":175495354,"id":233959726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk1OTcyNg==","diff_hunk":"@@ -207,6 +221,18 @@ func (p *podStartupLatencyMeasurement) gather(c clientset.Interface) ([]measurem\n \tvar err error\n \tif successRatio := float32(len(startupLag)) / float32(len(p.createTimes)); successRatio < successfulStartupRatioTreshold {\n \t\terr = fmt.Errorf(\"only %v%% of all pods were scheduled successfully\", successRatio*100)\n+\t\tglog.Errorf(err.Error())","path":"clusterloader2/pkg/measurement/common/slos/pod_startup_latency.go","position":null,"original_position":86,"commit_id":"04f231e28e242ada01101acb45fd24fcdab1e9d5","original_commit_id":"c4aabc5aebd5e4fc8079848534cb84530e62706a","user":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"body":"Fixed.","created_at":"2018-11-15T18:33:01Z","updated_at":"2018-11-15T18:33:02Z","html_url":"https://github.com/kubernetes/perf-tests/pull/299#discussion_r233959726","pull_request_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/299","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments/233959726"},"html":{"href":"https://github.com/kubernetes/perf-tests/pull/299#discussion_r233959726"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/299"}},"in_reply_to_id":233882871},"pull_request":{"url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/299","id":231212811,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjEyODEx","html_url":"https://github.com/kubernetes/perf-tests/pull/299","diff_url":"https://github.com/kubernetes/perf-tests/pull/299.diff","patch_url":"https://github.com/kubernetes/perf-tests/pull/299.patch","issue_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/299","number":299,"state":"open","locked":false,"title":"ClusterLoader - Updating pod startup measurement logs","user":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"body":"Added:\r\n- failing when podStartupLatencyThreshold(5s) is not satisfied.\r\n- logging pod latencies.\r\n\r\nref #293 ","created_at":"2018-11-15T14:26:57Z","updated_at":"2018-11-15T18:33:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe56a38210cd562db17101c433393f2c8f3e9e77","assignee":{"login":"wojtek-t","id":10743879,"node_id":"MDQ6VXNlcjEwNzQzODc5","avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"assignees":[{"login":"wojtek-t","id":10743879,"node_id":"MDQ6VXNlcjEwNzQzODc5","avatar_url":"https://avatars3.githubusercontent.com/u/10743879?v=4","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"gmarek","id":1703842,"node_id":"MDQ6VXNlcjE3MDM4NDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1703842?v=4","gravatar_id":"","url":"https://api.github.com/users/gmarek","html_url":"https://github.com/gmarek","followers_url":"https://api.github.com/users/gmarek/followers","following_url":"https://api.github.com/users/gmarek/following{/other_user}","gists_url":"https://api.github.com/users/gmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarek/subscriptions","organizations_url":"https://api.github.com/users/gmarek/orgs","repos_url":"https://api.github.com/users/gmarek/repos","events_url":"https://api.github.com/users/gmarek/events{/privacy}","received_events_url":"https://api.github.com/users/gmarek/received_events","type":"User","site_admin":false},{"login":"shyamjvs","id":4333971,"node_id":"MDQ6VXNlcjQzMzM5NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/4333971?v=4","gravatar_id":"","url":"https://api.github.com/users/shyamjvs","html_url":"https://github.com/shyamjvs","followers_url":"https://api.github.com/users/shyamjvs/followers","following_url":"https://api.github.com/users/shyamjvs/following{/other_user}","gists_url":"https://api.github.com/users/shyamjvs/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamjvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamjvs/subscriptions","organizations_url":"https://api.github.com/users/shyamjvs/orgs","repos_url":"https://api.github.com/users/shyamjvs/repos","events_url":"https://api.github.com/users/shyamjvs/events{/privacy}","received_events_url":"https://api.github.com/users/shyamjvs/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":492296491,"node_id":"MDU6TGFiZWw0OTIyOTY0OTE=","url":"https://api.github.com/repos/kubernetes/perf-tests/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":764010528,"node_id":"MDU6TGFiZWw3NjQwMTA1Mjg=","url":"https://api.github.com/repos/kubernetes/perf-tests/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/299/commits","review_comments_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/299/comments","review_comment_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/299/comments","statuses_url":"https://api.github.com/repos/kubernetes/perf-tests/statuses/04f231e28e242ada01101acb45fd24fcdab1e9d5","head":{"label":"krzysied:cluster_loader_measurements_pod_startup_log","ref":"cluster_loader_measurements_pod_startup_log","sha":"04f231e28e242ada01101acb45fd24fcdab1e9d5","user":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"repo":{"id":128908558,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5MDg1NTg=","name":"perf-tests","full_name":"krzysied/perf-tests","private":false,"owner":{"login":"krzysied","id":25119199,"node_id":"MDQ6VXNlcjI1MTE5MTk5","avatar_url":"https://avatars2.githubusercontent.com/u/25119199?v=4","gravatar_id":"","url":"https://api.github.com/users/krzysied","html_url":"https://github.com/krzysied","followers_url":"https://api.github.com/users/krzysied/followers","following_url":"https://api.github.com/users/krzysied/following{/other_user}","gists_url":"https://api.github.com/users/krzysied/gists{/gist_id}","starred_url":"https://api.github.com/users/krzysied/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzysied/subscriptions","organizations_url":"https://api.github.com/users/krzysied/orgs","repos_url":"https://api.github.com/users/krzysied/repos","events_url":"https://api.github.com/users/krzysied/events{/privacy}","received_events_url":"https://api.github.com/users/krzysied/received_events","type":"User","site_admin":false},"html_url":"https://github.com/krzysied/perf-tests","description":"Performance tests and benchmarks","fork":true,"url":"https://api.github.com/repos/krzysied/perf-tests","forks_url":"https://api.github.com/repos/krzysied/perf-tests/forks","keys_url":"https://api.github.com/repos/krzysied/perf-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krzysied/perf-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krzysied/perf-tests/teams","hooks_url":"https://api.github.com/repos/krzysied/perf-tests/hooks","issue_events_url":"https://api.github.com/repos/krzysied/perf-tests/issues/events{/number}","events_url":"https://api.github.com/repos/krzysied/perf-tests/events","assignees_url":"https://api.github.com/repos/krzysied/perf-tests/assignees{/user}","branches_url":"https://api.github.com/repos/krzysied/perf-tests/branches{/branch}","tags_url":"https://api.github.com/repos/krzysied/perf-tests/tags","blobs_url":"https://api.github.com/repos/krzysied/perf-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krzysied/perf-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krzysied/perf-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/krzysied/perf-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krzysied/perf-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/krzysied/perf-tests/languages","stargazers_url":"https://api.github.com/repos/krzysied/perf-tests/stargazers","contributors_url":"https://api.github.com/repos/krzysied/perf-tests/contributors","subscribers_url":"https://api.github.com/repos/krzysied/perf-tests/subscribers","subscription_url":"https://api.github.com/repos/krzysied/perf-tests/subscription","commits_url":"https://api.github.com/repos/krzysied/perf-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/krzysied/perf-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/krzysied/perf-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/krzysied/perf-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/krzysied/perf-tests/contents/{+path}","compare_url":"https://api.github.com/repos/krzysied/perf-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krzysied/perf-tests/merges","archive_url":"https://api.github.com/repos/krzysied/perf-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krzysied/perf-tests/downloads","issues_url":"https://api.github.com/repos/krzysied/perf-tests/issues{/number}","pulls_url":"https://api.github.com/repos/krzysied/perf-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/krzysied/perf-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/krzysied/perf-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krzysied/perf-tests/labels{/name}","releases_url":"https://api.github.com/repos/krzysied/perf-tests/releases{/id}","deployments_url":"https://api.github.com/repos/krzysied/perf-tests/deployments","created_at":"2018-04-10T09:33:00Z","updated_at":"2018-04-10T09:33:03Z","pushed_at":"2018-11-15T18:32:49Z","git_url":"git://github.com/krzysied/perf-tests.git","ssh_url":"git@github.com:krzysied/perf-tests.git","clone_url":"https://github.com/krzysied/perf-tests.git","svn_url":"https://github.com/krzysied/perf-tests","homepage":null,"size":69381,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"33ade32d80a056184424f7fd4f4bd360156a61a9","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":68769911,"node_id":"MDEwOlJlcG9zaXRvcnk2ODc2OTkxMQ==","name":"perf-tests","full_name":"kubernetes/perf-tests","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/perf-tests","description":"Performance tests and benchmarks","fork":false,"url":"https://api.github.com/repos/kubernetes/perf-tests","forks_url":"https://api.github.com/repos/kubernetes/perf-tests/forks","keys_url":"https://api.github.com/repos/kubernetes/perf-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/perf-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/perf-tests/teams","hooks_url":"https://api.github.com/repos/kubernetes/perf-tests/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/perf-tests/events","assignees_url":"https://api.github.com/repos/kubernetes/perf-tests/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/perf-tests/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/perf-tests/tags","blobs_url":"https://api.github.com/repos/kubernetes/perf-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/perf-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/perf-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/perf-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/perf-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/perf-tests/languages","stargazers_url":"https://api.github.com/repos/kubernetes/perf-tests/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/perf-tests/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/perf-tests/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/perf-tests/subscription","commits_url":"https://api.github.com/repos/kubernetes/perf-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/perf-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/perf-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/perf-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/perf-tests/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/perf-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/perf-tests/merges","archive_url":"https://api.github.com/repos/kubernetes/perf-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/perf-tests/downloads","issues_url":"https://api.github.com/repos/kubernetes/perf-tests/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/perf-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/perf-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/perf-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/perf-tests/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/perf-tests/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/perf-tests/deployments","created_at":"2016-09-21T01:59:44Z","updated_at":"2018-11-15T13:42:40Z","pushed_at":"2018-11-15T18:32:50Z","git_url":"git://github.com/kubernetes/perf-tests.git","ssh_url":"git@github.com:kubernetes/perf-tests.git","clone_url":"https://github.com/kubernetes/perf-tests.git","svn_url":"https://github.com/kubernetes/perf-tests","homepage":null,"size":61576,"stargazers_count":143,"watchers_count":143,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":83,"open_issues":20,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/299"},"html":{"href":"https://github.com/kubernetes/perf-tests/pull/299"},"issue":{"href":"https://api.github.com/repos/kubernetes/perf-tests/issues/299"},"comments":{"href":"https://api.github.com/repos/kubernetes/perf-tests/issues/299/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/299/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/perf-tests/pulls/299/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/perf-tests/statuses/04f231e28e242ada01101acb45fd24fcdab1e9d5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"krzysied"}}