{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2982","repository_url":"https://api.github.com/repos/input-output-hk/cardano-sl","labels_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2982/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2982/comments","events_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2982/events","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2982","id":325779683,"number":2982,"title":"[CBR-165] Bug Wallet Balance","user":{"login":"KtorZ","id":5680256,"avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"KtorZ","id":5680256,"avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false},"assignees":[{"login":"KtorZ","id":5680256,"avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-05-23T16:19:31Z","updated_at":"2018-05-24T07:46:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/pulls/2982","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2982","diff_url":"https://github.com/input-output-hk/cardano-sl/pull/2982.diff","patch_url":"https://github.com/input-output-hk/cardano-sl/pull/2982.patch"},"body":"## Description\r\n\r\nSome users reported weird money movement on their wallets. It appears that they were using a wallet with a same Id that can be created or restored by submitting an empty mnemonic backup phrase.\r\n\r\nThis PR prevent this and introduce a couple of tests that were written while trying to track down the issue. Note that I am still unsure about the complete impact on wallet that have already been created or restored using an empty backup phrase. They should continue to operate as normal but won't be recoverable anymore. We probably want to warn all those users about this and tell them to stop using the wallets anyway. \r\n\r\n\r\n## Linked issue\r\n\r\n[[CBR-165]](https://iohk.myjetbrains.com/youtrack/issue/CO-256)\r\n\r\n## Type of change\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply and `~` in the ones that do not: -->\r\n- [x] 🐞 Bug fix (non-breaking change which fixes an issue)\r\n- [ ] 🛠 New feature (non-breaking change which adds functionality)\r\n- [ ] ⚠️ Breaking change (fix or feature that would cause existing functionality to change)\r\n- [ ] 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc\r\n- [x] 🔨 New or improved tests for existing code\r\n- [ ] ⛑ git-flow chore (backport, hotfix, etc)\r\n\r\n## Developer checklist\r\n<!--- A mental checklist for the developer submitting the PR. Put an `x` in all the boxes that apply and `~` in the ones that do not: --->\r\n- [x] I have read the [style guide](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/style-guide.md) document, and my code follows the code style of this project.\r\n- [x] If my code deals with exceptions, it follows the [guidelines](https://github.com/input-output-hk/cardano-sl/blob/develop/docs/exceptions.md).\r\n- [x] I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on [cardanodocs.com](https://github.com/input-output-hk/cardanodocs.com), amending the inline [Haddock](https://www.haskell.org/haddock/) comments, any relevant README file or one of the document listed in the [docs](https://github.com/input-output-hk/cardano-sl/tree/develop/docs) directory.\r\n\r\n## Testing checklist\r\n<!-- If you aren't providing any tests as part of this PR, use this section to state clearly why. It needs to be a strong motivation and definitely the exception, not the rule. -->\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n\r\n## QA Steps\r\n<!--- Which are the steps needed to test this feature, if any? -->\r\n\r\n## Screenshots (if available)\r\n<!--- Upload a GIF, an asciinema video or an image demoing the feature -->\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/comments/391621312","html_url":"https://github.com/input-output-hk/cardano-sl/pull/2982#issuecomment-391621312","issue_url":"https://api.github.com/repos/input-output-hk/cardano-sl/issues/2982","id":391621312,"user":{"login":"KtorZ","id":5680256,"avatar_url":"https://avatars0.githubusercontent.com/u/5680256?v=4","gravatar_id":"","url":"https://api.github.com/users/KtorZ","html_url":"https://github.com/KtorZ","followers_url":"https://api.github.com/users/KtorZ/followers","following_url":"https://api.github.com/users/KtorZ/following{/other_user}","gists_url":"https://api.github.com/users/KtorZ/gists{/gist_id}","starred_url":"https://api.github.com/users/KtorZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KtorZ/subscriptions","organizations_url":"https://api.github.com/users/KtorZ/orgs","repos_url":"https://api.github.com/users/KtorZ/repos","events_url":"https://api.github.com/users/KtorZ/events{/privacy}","received_events_url":"https://api.github.com/users/KtorZ/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T07:46:12Z","updated_at":"2018-05-24T07:46:12Z","author_association":"MEMBER","body":"I thought of something yesterday. Should we also _hard-code_ (:scream:) the list of mnemonics we advertise in the doc and reject them with a clear error message: \"Please do not use example mnemonics; rely on trusted implementations to generate your own private words\" ?\r\n\r\n"}}
{"actor":{"display_login":"KtorZ"}}