{"action":"closed","number":627,"pull_request":{"url":"https://api.github.com/repos/AsgardCms/Platform/pulls/627","id":222394012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMzk0MDEy","html_url":"https://github.com/AsgardCms/Platform/pull/627","diff_url":"https://github.com/AsgardCms/Platform/pull/627.diff","patch_url":"https://github.com/AsgardCms/Platform/pull/627.patch","issue_url":"https://api.github.com/repos/AsgardCms/Platform/issues/627","number":627,"state":"closed","locked":false,"title":"Add possibility to define some options on number field","user":{"login":"ChristianGiupponi","id":1614796,"node_id":"MDQ6VXNlcjE2MTQ3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1614796?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianGiupponi","html_url":"https://github.com/ChristianGiupponi","followers_url":"https://api.github.com/users/ChristianGiupponi/followers","following_url":"https://api.github.com/users/ChristianGiupponi/following{/other_user}","gists_url":"https://api.github.com/users/ChristianGiupponi/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianGiupponi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianGiupponi/subscriptions","organizations_url":"https://api.github.com/users/ChristianGiupponi/orgs","repos_url":"https://api.github.com/users/ChristianGiupponi/repos","events_url":"https://api.github.com/users/ChristianGiupponi/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianGiupponi/received_events","type":"User","site_admin":false},"body":"In the number fields there is no possibility to define `min`, `max` or `step` because the options are hard coded.  \r\nI have added default options array that wil lbe merged with the options added by user.  \r\nIn this way the user can add a `options` array to define what he need.\r\n\r\nFor example, lets assume we have this options settings:\r\n\r\n```\r\n 'invoice_default_tax' => [\r\n        'description' => trans('invoice::settings.form.default_tax'),\r\n        'view' => 'number',\r\n        'translatable' => false,\r\n        'options' => [\r\n            'min' => 10,\r\n            'max' => 30,\r\n            'step' => 0.1\r\n        ]\r\n    ],\r\n```\r\n\r\nit will be merged with the default and now in the setting the input is much more useful.\r\n\r\nPlease review if it works, the same logic can be applied to the other fields","created_at":"2018-10-12T08:52:20Z","updated_at":"2018-10-15T14:21:43Z","closed_at":"2018-10-15T14:21:43Z","merged_at":"2018-10-15T14:21:43Z","merge_commit_sha":"b601dd311f90335185f40c9fa0315d2f01b08b43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AsgardCms/Platform/pulls/627/commits","review_comments_url":"https://api.github.com/repos/AsgardCms/Platform/pulls/627/comments","review_comment_url":"https://api.github.com/repos/AsgardCms/Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AsgardCms/Platform/issues/627/comments","statuses_url":"https://api.github.com/repos/AsgardCms/Platform/statuses/2e4c5b95015403a211094d397197651f66417ec5","head":{"label":"ChristianGiupponi:master","ref":"master","sha":"2e4c5b95015403a211094d397197651f66417ec5","user":{"login":"ChristianGiupponi","id":1614796,"node_id":"MDQ6VXNlcjE2MTQ3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1614796?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianGiupponi","html_url":"https://github.com/ChristianGiupponi","followers_url":"https://api.github.com/users/ChristianGiupponi/followers","following_url":"https://api.github.com/users/ChristianGiupponi/following{/other_user}","gists_url":"https://api.github.com/users/ChristianGiupponi/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianGiupponi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianGiupponi/subscriptions","organizations_url":"https://api.github.com/users/ChristianGiupponi/orgs","repos_url":"https://api.github.com/users/ChristianGiupponi/repos","events_url":"https://api.github.com/users/ChristianGiupponi/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianGiupponi/received_events","type":"User","site_admin":false},"repo":{"id":152720650,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI3MjA2NTA=","name":"Platform","full_name":"ChristianGiupponi/Platform","private":false,"owner":{"login":"ChristianGiupponi","id":1614796,"node_id":"MDQ6VXNlcjE2MTQ3OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1614796?v=4","gravatar_id":"","url":"https://api.github.com/users/ChristianGiupponi","html_url":"https://github.com/ChristianGiupponi","followers_url":"https://api.github.com/users/ChristianGiupponi/followers","following_url":"https://api.github.com/users/ChristianGiupponi/following{/other_user}","gists_url":"https://api.github.com/users/ChristianGiupponi/gists{/gist_id}","starred_url":"https://api.github.com/users/ChristianGiupponi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChristianGiupponi/subscriptions","organizations_url":"https://api.github.com/users/ChristianGiupponi/orgs","repos_url":"https://api.github.com/users/ChristianGiupponi/repos","events_url":"https://api.github.com/users/ChristianGiupponi/events{/privacy}","received_events_url":"https://api.github.com/users/ChristianGiupponi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ChristianGiupponi/Platform","description":"A modular multilingual CMS built with Laravel 5.","fork":true,"url":"https://api.github.com/repos/ChristianGiupponi/Platform","forks_url":"https://api.github.com/repos/ChristianGiupponi/Platform/forks","keys_url":"https://api.github.com/repos/ChristianGiupponi/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChristianGiupponi/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChristianGiupponi/Platform/teams","hooks_url":"https://api.github.com/repos/ChristianGiupponi/Platform/hooks","issue_events_url":"https://api.github.com/repos/ChristianGiupponi/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/ChristianGiupponi/Platform/events","assignees_url":"https://api.github.com/repos/ChristianGiupponi/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/ChristianGiupponi/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/ChristianGiupponi/Platform/tags","blobs_url":"https://api.github.com/repos/ChristianGiupponi/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChristianGiupponi/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChristianGiupponi/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChristianGiupponi/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChristianGiupponi/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/ChristianGiupponi/Platform/languages","stargazers_url":"https://api.github.com/repos/ChristianGiupponi/Platform/stargazers","contributors_url":"https://api.github.com/repos/ChristianGiupponi/Platform/contributors","subscribers_url":"https://api.github.com/repos/ChristianGiupponi/Platform/subscribers","subscription_url":"https://api.github.com/repos/ChristianGiupponi/Platform/subscription","commits_url":"https://api.github.com/repos/ChristianGiupponi/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChristianGiupponi/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChristianGiupponi/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChristianGiupponi/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChristianGiupponi/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/ChristianGiupponi/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChristianGiupponi/Platform/merges","archive_url":"https://api.github.com/repos/ChristianGiupponi/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChristianGiupponi/Platform/downloads","issues_url":"https://api.github.com/repos/ChristianGiupponi/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/ChristianGiupponi/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/ChristianGiupponi/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/ChristianGiupponi/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChristianGiupponi/Platform/labels{/name}","releases_url":"https://api.github.com/repos/ChristianGiupponi/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/ChristianGiupponi/Platform/deployments","created_at":"2018-10-12T08:42:56Z","updated_at":"2018-10-12T08:43:02Z","pushed_at":"2018-10-12T08:48:13Z","git_url":"git://github.com/ChristianGiupponi/Platform.git","ssh_url":"git@github.com:ChristianGiupponi/Platform.git","clone_url":"https://github.com/ChristianGiupponi/Platform.git","svn_url":"https://github.com/ChristianGiupponi/Platform","homepage":"https://asgardcms.com/","size":46041,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.0"}},"base":{"label":"AsgardCms:master","ref":"master","sha":"230d6232d24a0d1f71c0a8193a3ce286d9bdfb44","user":{"login":"AsgardCms","id":8859068,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NTkwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8859068?v=4","gravatar_id":"","url":"https://api.github.com/users/AsgardCms","html_url":"https://github.com/AsgardCms","followers_url":"https://api.github.com/users/AsgardCms/followers","following_url":"https://api.github.com/users/AsgardCms/following{/other_user}","gists_url":"https://api.github.com/users/AsgardCms/gists{/gist_id}","starred_url":"https://api.github.com/users/AsgardCms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsgardCms/subscriptions","organizations_url":"https://api.github.com/users/AsgardCms/orgs","repos_url":"https://api.github.com/users/AsgardCms/repos","events_url":"https://api.github.com/users/AsgardCms/events{/privacy}","received_events_url":"https://api.github.com/users/AsgardCms/received_events","type":"Organization","site_admin":false},"repo":{"id":25069680,"node_id":"MDEwOlJlcG9zaXRvcnkyNTA2OTY4MA==","name":"Platform","full_name":"AsgardCms/Platform","private":false,"owner":{"login":"AsgardCms","id":8859068,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg4NTkwNjg=","avatar_url":"https://avatars2.githubusercontent.com/u/8859068?v=4","gravatar_id":"","url":"https://api.github.com/users/AsgardCms","html_url":"https://github.com/AsgardCms","followers_url":"https://api.github.com/users/AsgardCms/followers","following_url":"https://api.github.com/users/AsgardCms/following{/other_user}","gists_url":"https://api.github.com/users/AsgardCms/gists{/gist_id}","starred_url":"https://api.github.com/users/AsgardCms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AsgardCms/subscriptions","organizations_url":"https://api.github.com/users/AsgardCms/orgs","repos_url":"https://api.github.com/users/AsgardCms/repos","events_url":"https://api.github.com/users/AsgardCms/events{/privacy}","received_events_url":"https://api.github.com/users/AsgardCms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AsgardCms/Platform","description":"A modular multilingual CMS built with Laravel 5.","fork":false,"url":"https://api.github.com/repos/AsgardCms/Platform","forks_url":"https://api.github.com/repos/AsgardCms/Platform/forks","keys_url":"https://api.github.com/repos/AsgardCms/Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AsgardCms/Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AsgardCms/Platform/teams","hooks_url":"https://api.github.com/repos/AsgardCms/Platform/hooks","issue_events_url":"https://api.github.com/repos/AsgardCms/Platform/issues/events{/number}","events_url":"https://api.github.com/repos/AsgardCms/Platform/events","assignees_url":"https://api.github.com/repos/AsgardCms/Platform/assignees{/user}","branches_url":"https://api.github.com/repos/AsgardCms/Platform/branches{/branch}","tags_url":"https://api.github.com/repos/AsgardCms/Platform/tags","blobs_url":"https://api.github.com/repos/AsgardCms/Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AsgardCms/Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AsgardCms/Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/AsgardCms/Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AsgardCms/Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/AsgardCms/Platform/languages","stargazers_url":"https://api.github.com/repos/AsgardCms/Platform/stargazers","contributors_url":"https://api.github.com/repos/AsgardCms/Platform/contributors","subscribers_url":"https://api.github.com/repos/AsgardCms/Platform/subscribers","subscription_url":"https://api.github.com/repos/AsgardCms/Platform/subscription","commits_url":"https://api.github.com/repos/AsgardCms/Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/AsgardCms/Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/AsgardCms/Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/AsgardCms/Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/AsgardCms/Platform/contents/{+path}","compare_url":"https://api.github.com/repos/AsgardCms/Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AsgardCms/Platform/merges","archive_url":"https://api.github.com/repos/AsgardCms/Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AsgardCms/Platform/downloads","issues_url":"https://api.github.com/repos/AsgardCms/Platform/issues{/number}","pulls_url":"https://api.github.com/repos/AsgardCms/Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/AsgardCms/Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/AsgardCms/Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AsgardCms/Platform/labels{/name}","releases_url":"https://api.github.com/repos/AsgardCms/Platform/releases{/id}","deployments_url":"https://api.github.com/repos/AsgardCms/Platform/deployments","created_at":"2014-10-11T08:22:27Z","updated_at":"2018-10-13T07:13:15Z","pushed_at":"2018-10-15T14:21:43Z","git_url":"git://github.com/AsgardCms/Platform.git","ssh_url":"git@github.com:AsgardCms/Platform.git","clone_url":"https://github.com/AsgardCms/Platform.git","svn_url":"https://github.com/AsgardCms/Platform","homepage":"https://asgardcms.com/","size":46040,"stargazers_count":566,"watchers_count":566,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":191,"open_issues":11,"watchers":566,"default_branch":"3.0"}},"_links":{"self":{"href":"https://api.github.com/repos/AsgardCms/Platform/pulls/627"},"html":{"href":"https://github.com/AsgardCms/Platform/pull/627"},"issue":{"href":"https://api.github.com/repos/AsgardCms/Platform/issues/627"},"comments":{"href":"https://api.github.com/repos/AsgardCms/Platform/issues/627/comments"},"review_comments":{"href":"https://api.github.com/repos/AsgardCms/Platform/pulls/627/comments"},"review_comment":{"href":"https://api.github.com/repos/AsgardCms/Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AsgardCms/Platform/pulls/627/commits"},"statuses":{"href":"https://api.github.com/repos/AsgardCms/Platform/statuses/2e4c5b95015403a211094d397197651f66417ec5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nWidart","id":882397,"node_id":"MDQ6VXNlcjg4MjM5Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/882397?v=4","gravatar_id":"","url":"https://api.github.com/users/nWidart","html_url":"https://github.com/nWidart","followers_url":"https://api.github.com/users/nWidart/followers","following_url":"https://api.github.com/users/nWidart/following{/other_user}","gists_url":"https://api.github.com/users/nWidart/gists{/gist_id}","starred_url":"https://api.github.com/users/nWidart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nWidart/subscriptions","organizations_url":"https://api.github.com/users/nWidart/orgs","repos_url":"https://api.github.com/users/nWidart/repos","events_url":"https://api.github.com/users/nWidart/events{/privacy}","received_events_url":"https://api.github.com/users/nWidart/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":20,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"nWidart"}}