{"action":"created","comment":{"url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments/235777618","pull_request_review_id":177722751,"id":235777618,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc3NzYxOA==","diff_hunk":"@@ -0,0 +1,47 @@\n+﻿using System.Linq;\r\n+using System.Threading;\r\n+using System.Threading.Tasks;\r\n+using HomesEngland.Domain;\r\n+using HomesEngland.Exception;\r\n+using HomesEngland.Gateway.Assets;\r\n+using HomesEngland.UseCase.GetAsset;\r\n+using HomesEngland.UseCase.GetAsset.Models;\r\n+using HomesEngland.UseCase.SearchAsset.Models;\r\n+using Infrastructure.Api.Exceptions;\r\n+\r\n+namespace HomesEngland.UseCase.SearchAsset.Impl\r\n+{\r\n+    public class SearchAssetUseCase : ISearchAssetUseCase\r","path":"HomesEngland/UseCase/SearchAsset/Impl/SearchAssetUseCase.cs","position":15,"original_position":14,"commit_id":"08c6577bf3d4cfe08dc47f61a1edc78865daf0e7","original_commit_id":"c246af00aae7a4dfe6cda4cc5f28d4dc2662d723","user":{"login":"craigjbass","id":1889973,"node_id":"MDQ6VXNlcjE4ODk5NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1889973?v=4","gravatar_id":"","url":"https://api.github.com/users/craigjbass","html_url":"https://github.com/craigjbass","followers_url":"https://api.github.com/users/craigjbass/followers","following_url":"https://api.github.com/users/craigjbass/following{/other_user}","gists_url":"https://api.github.com/users/craigjbass/gists{/gist_id}","starred_url":"https://api.github.com/users/craigjbass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigjbass/subscriptions","organizations_url":"https://api.github.com/users/craigjbass/orgs","repos_url":"https://api.github.com/users/craigjbass/repos","events_url":"https://api.github.com/users/craigjbass/events{/privacy}","received_events_url":"https://api.github.com/users/craigjbass/received_events","type":"User","site_admin":false},"body":"From slack thread: `AssetSearchQuery`","created_at":"2018-11-22T16:18:00Z","updated_at":"2018-11-22T16:18:00Z","html_url":"https://github.com/homes-england/asset-register-api/pull/67#discussion_r235777618","pull_request_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/67","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments/235777618"},"html":{"href":"https://github.com/homes-england/asset-register-api/pull/67#discussion_r235777618"},"pull_request":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/67"}},"in_reply_to_id":235476257},"pull_request":{"url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/67","id":232730348,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNzMwMzQ4","html_url":"https://github.com/homes-england/asset-register-api/pull/67","diff_url":"https://github.com/homes-england/asset-register-api/pull/67.diff","patch_url":"https://github.com/homes-england/asset-register-api/pull/67.patch","issue_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/67","number":67,"state":"open","locked":false,"title":"Feature/search assets","user":{"login":"PinkhamSoftware","id":5268123,"node_id":"MDQ6VXNlcjUyNjgxMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/5268123?v=4","gravatar_id":"","url":"https://api.github.com/users/PinkhamSoftware","html_url":"https://github.com/PinkhamSoftware","followers_url":"https://api.github.com/users/PinkhamSoftware/followers","following_url":"https://api.github.com/users/PinkhamSoftware/following{/other_user}","gists_url":"https://api.github.com/users/PinkhamSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/PinkhamSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PinkhamSoftware/subscriptions","organizations_url":"https://api.github.com/users/PinkhamSoftware/orgs","repos_url":"https://api.github.com/users/PinkhamSoftware/repos","events_url":"https://api.github.com/users/PinkhamSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/PinkhamSoftware/received_events","type":"User","site_admin":false},"body":"Does:\r\n- Dependency Injection\r\n- Tests + Controller\r\n- Tests + UseCase\r\n- Tests + Gateway\r\n- Tests + SearchRequest Validator\r\n- Migration - drops schemeId column because Postgres doesn't like casting from string to int\r\n\r\nDoes not: \r\n- Seed data, leaving that for another PR.\r\n- Explicitly list column names in sql: I am aware this is a performance optimisation, however speed at which we will be adapting the codebase it may add more friction than required. Will leave with '*' wildcard until the domain model settles down.\r\n\r\n<img width=\"1391\" alt=\"screen shot 2018-11-21 at 16 50 50\" src=\"https://user-images.githubusercontent.com/5268123/48856180-a9e0b080-edad-11e8-98a9-6b79b58a8315.png\">\r\n\r\n<img width=\"1381\" alt=\"screen shot 2018-11-21 at 16 49 35\" src=\"https://user-images.githubusercontent.com/5268123/48856146-91709600-edad-11e8-9131-a4592dff99e3.png\">\r\n","created_at":"2018-11-21T16:39:38Z","updated_at":"2018-11-22T16:18:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4953ad42e12df823bdee4056ba4da7e9757ae6c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/67/commits","review_comments_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/67/comments","review_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/67/comments","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/08c6577bf3d4cfe08dc47f61a1edc78865daf0e7","head":{"label":"homes-england:feature/search-assets","ref":"feature/search-assets","sha":"08c6577bf3d4cfe08dc47f61a1edc78865daf0e7","user":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"repo":{"id":153280886,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyODA4ODY=","name":"asset-register-api","full_name":"homes-england/asset-register-api","private":false,"owner":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/homes-england/asset-register-api","description":"Homes England Asset Register API","fork":false,"url":"https://api.github.com/repos/homes-england/asset-register-api","forks_url":"https://api.github.com/repos/homes-england/asset-register-api/forks","keys_url":"https://api.github.com/repos/homes-england/asset-register-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/homes-england/asset-register-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/homes-england/asset-register-api/teams","hooks_url":"https://api.github.com/repos/homes-england/asset-register-api/hooks","issue_events_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/events{/number}","events_url":"https://api.github.com/repos/homes-england/asset-register-api/events","assignees_url":"https://api.github.com/repos/homes-england/asset-register-api/assignees{/user}","branches_url":"https://api.github.com/repos/homes-england/asset-register-api/branches{/branch}","tags_url":"https://api.github.com/repos/homes-england/asset-register-api/tags","blobs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/homes-england/asset-register-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/homes-england/asset-register-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/{sha}","languages_url":"https://api.github.com/repos/homes-england/asset-register-api/languages","stargazers_url":"https://api.github.com/repos/homes-england/asset-register-api/stargazers","contributors_url":"https://api.github.com/repos/homes-england/asset-register-api/contributors","subscribers_url":"https://api.github.com/repos/homes-england/asset-register-api/subscribers","subscription_url":"https://api.github.com/repos/homes-england/asset-register-api/subscription","commits_url":"https://api.github.com/repos/homes-england/asset-register-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/homes-england/asset-register-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/homes-england/asset-register-api/contents/{+path}","compare_url":"https://api.github.com/repos/homes-england/asset-register-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/homes-england/asset-register-api/merges","archive_url":"https://api.github.com/repos/homes-england/asset-register-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/homes-england/asset-register-api/downloads","issues_url":"https://api.github.com/repos/homes-england/asset-register-api/issues{/number}","pulls_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls{/number}","milestones_url":"https://api.github.com/repos/homes-england/asset-register-api/milestones{/number}","notifications_url":"https://api.github.com/repos/homes-england/asset-register-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/homes-england/asset-register-api/labels{/name}","releases_url":"https://api.github.com/repos/homes-england/asset-register-api/releases{/id}","deployments_url":"https://api.github.com/repos/homes-england/asset-register-api/deployments","created_at":"2018-10-16T12:22:31Z","updated_at":"2018-11-21T08:41:56Z","pushed_at":"2018-11-22T15:53:42Z","git_url":"git://github.com/homes-england/asset-register-api.git","ssh_url":"git@github.com:homes-england/asset-register-api.git","clone_url":"https://github.com/homes-england/asset-register-api.git","svn_url":"https://github.com/homes-england/asset-register-api","homepage":"","size":343,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"homes-england:master","ref":"master","sha":"08ca4afdf4c47e90b5c6e28d853c8e7cbbedab0c","user":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"repo":{"id":153280886,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyODA4ODY=","name":"asset-register-api","full_name":"homes-england/asset-register-api","private":false,"owner":{"login":"homes-england","id":38912533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTEyNTMz","avatar_url":"https://avatars0.githubusercontent.com/u/38912533?v=4","gravatar_id":"","url":"https://api.github.com/users/homes-england","html_url":"https://github.com/homes-england","followers_url":"https://api.github.com/users/homes-england/followers","following_url":"https://api.github.com/users/homes-england/following{/other_user}","gists_url":"https://api.github.com/users/homes-england/gists{/gist_id}","starred_url":"https://api.github.com/users/homes-england/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/homes-england/subscriptions","organizations_url":"https://api.github.com/users/homes-england/orgs","repos_url":"https://api.github.com/users/homes-england/repos","events_url":"https://api.github.com/users/homes-england/events{/privacy}","received_events_url":"https://api.github.com/users/homes-england/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/homes-england/asset-register-api","description":"Homes England Asset Register API","fork":false,"url":"https://api.github.com/repos/homes-england/asset-register-api","forks_url":"https://api.github.com/repos/homes-england/asset-register-api/forks","keys_url":"https://api.github.com/repos/homes-england/asset-register-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/homes-england/asset-register-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/homes-england/asset-register-api/teams","hooks_url":"https://api.github.com/repos/homes-england/asset-register-api/hooks","issue_events_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/events{/number}","events_url":"https://api.github.com/repos/homes-england/asset-register-api/events","assignees_url":"https://api.github.com/repos/homes-england/asset-register-api/assignees{/user}","branches_url":"https://api.github.com/repos/homes-england/asset-register-api/branches{/branch}","tags_url":"https://api.github.com/repos/homes-england/asset-register-api/tags","blobs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/homes-england/asset-register-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/homes-england/asset-register-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/homes-england/asset-register-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/homes-england/asset-register-api/statuses/{sha}","languages_url":"https://api.github.com/repos/homes-england/asset-register-api/languages","stargazers_url":"https://api.github.com/repos/homes-england/asset-register-api/stargazers","contributors_url":"https://api.github.com/repos/homes-england/asset-register-api/contributors","subscribers_url":"https://api.github.com/repos/homes-england/asset-register-api/subscribers","subscription_url":"https://api.github.com/repos/homes-england/asset-register-api/subscription","commits_url":"https://api.github.com/repos/homes-england/asset-register-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/homes-england/asset-register-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/homes-england/asset-register-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/homes-england/asset-register-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/homes-england/asset-register-api/contents/{+path}","compare_url":"https://api.github.com/repos/homes-england/asset-register-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/homes-england/asset-register-api/merges","archive_url":"https://api.github.com/repos/homes-england/asset-register-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/homes-england/asset-register-api/downloads","issues_url":"https://api.github.com/repos/homes-england/asset-register-api/issues{/number}","pulls_url":"https://api.github.com/repos/homes-england/asset-register-api/pulls{/number}","milestones_url":"https://api.github.com/repos/homes-england/asset-register-api/milestones{/number}","notifications_url":"https://api.github.com/repos/homes-england/asset-register-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/homes-england/asset-register-api/labels{/name}","releases_url":"https://api.github.com/repos/homes-england/asset-register-api/releases{/id}","deployments_url":"https://api.github.com/repos/homes-england/asset-register-api/deployments","created_at":"2018-10-16T12:22:31Z","updated_at":"2018-11-21T08:41:56Z","pushed_at":"2018-11-22T15:53:42Z","git_url":"git://github.com/homes-england/asset-register-api.git","ssh_url":"git@github.com:homes-england/asset-register-api.git","clone_url":"https://github.com/homes-england/asset-register-api.git","svn_url":"https://github.com/homes-england/asset-register-api","homepage":"","size":343,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":2,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/67"},"html":{"href":"https://github.com/homes-england/asset-register-api/pull/67"},"issue":{"href":"https://api.github.com/repos/homes-england/asset-register-api/issues/67"},"comments":{"href":"https://api.github.com/repos/homes-england/asset-register-api/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/homes-england/asset-register-api/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/homes-england/asset-register-api/statuses/08c6577bf3d4cfe08dc47f61a1edc78865daf0e7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"craigjbass"}}