{"action":"created","comment":{"url":"https://api.github.com/repos/moq/moq4/pulls/comments/230593347","pull_request_review_id":171367245,"id":230593347,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU5MzM0Nw==","diff_hunk":"@@ -508,42 +508,17 @@ private static VoidSetupPhrase<T> SetupPexProtected<T>(Mock<T> mock, Expression<\n \t\t}\n \n \t\t[DebuggerStepThrough]\n-\t\tinternal static SetterSetupPhrase<T, TProperty> SetupSet<T, TProperty>(\n-\t\t\tMock<T> mock,\n-\t\t\tAction<T> setterExpression,\n-\t\t\tCondition condition)\n-\t\t\twhere T : class\n+\t\tinternal static MethodCall SetupSet(Mock mock, Delegate setterExpression, Condition condition)\n \t\t{\n-\t\t\treturn PexProtector.Invoke(SetupSetPexProtected<T, TProperty>, mock, setterExpression, condition);\n+\t\t\treturn PexProtector.Invoke(SetupSetPexProtected, mock, setterExpression, condition);\n \t\t}\n \n-\t\tprivate static SetterSetupPhrase<T, TProperty> SetupSetPexProtected<T, TProperty>(\n-\t\t\tMock<T> mock,\n-\t\t\tAction<T> setterExpression,\n-\t\t\tCondition condition)\n-\t\t\twhere T : class\n+\t\tprivate static MethodCall SetupSetPexProtected(Mock mock, Delegate setterExpression, Condition condition)\n \t\t{\n \t\t\tvar (m, expr, method, value) = SetupSetImpl(mock, setterExpression);\n-\t\t\tDebug.Assert(value.Length == 1);","path":"src/Moq/Mock.cs","position":null,"original_position":23,"commit_id":"464bc646a8a0604e84395aa4a3e3cd06659a649a","original_commit_id":"de9dad98dc12acf9fae69a509f27b510ca621dfc","user":{"login":"stakx","id":104481,"node_id":"MDQ6VXNlcjEwNDQ4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/104481?v=4","gravatar_id":"","url":"https://api.github.com/users/stakx","html_url":"https://github.com/stakx","followers_url":"https://api.github.com/users/stakx/followers","following_url":"https://api.github.com/users/stakx/following{/other_user}","gists_url":"https://api.github.com/users/stakx/gists{/gist_id}","starred_url":"https://api.github.com/users/stakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stakx/subscriptions","organizations_url":"https://api.github.com/users/stakx/orgs","repos_url":"https://api.github.com/users/stakx/repos","events_url":"https://api.github.com/users/stakx/events{/privacy}","received_events_url":"https://api.github.com/users/stakx/received_events","type":"User","site_admin":false},"body":"If we'd had a unit test calling this method for an indexer set expression, we'd have seen this assertion fail. Let's remove it.","created_at":"2018-11-04T15:37:04Z","updated_at":"2018-11-04T15:37:04Z","html_url":"https://github.com/moq/moq4/pull/716#discussion_r230593347","pull_request_url":"https://api.github.com/repos/moq/moq4/pulls/716","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/moq/moq4/pulls/comments/230593347"},"html":{"href":"https://github.com/moq/moq4/pull/716#discussion_r230593347"},"pull_request":{"href":"https://api.github.com/repos/moq/moq4/pulls/716"}}},"pull_request":{"url":"https://api.github.com/repos/moq/moq4/pulls/716","id":228183586,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTgzNTg2","html_url":"https://github.com/moq/moq4/pull/716","diff_url":"https://github.com/moq/moq4/pull/716.diff","patch_url":"https://github.com/moq/moq4/pull/716.patch","issue_url":"https://api.github.com/repos/moq/moq4/issues/716","number":716,"state":"open","locked":false,"title":"Make internal `Mock` methods non-generic","user":{"login":"stakx","id":104481,"node_id":"MDQ6VXNlcjEwNDQ4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/104481?v=4","gravatar_id":"","url":"https://api.github.com/users/stakx","html_url":"https://github.com/stakx","followers_url":"https://api.github.com/users/stakx/followers","following_url":"https://api.github.com/users/stakx/following{/other_user}","gists_url":"https://api.github.com/users/stakx/gists{/gist_id}","starred_url":"https://api.github.com/users/stakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stakx/subscriptions","organizations_url":"https://api.github.com/users/stakx/orgs","repos_url":"https://api.github.com/users/stakx/repos","events_url":"https://api.github.com/users/stakx/events{/privacy}","received_events_url":"https://api.github.com/users/stakx/received_events","type":"User","site_admin":false},"body":"This is a continuation of #663. Internal worker methods in the `Mock` class are made non-generic. The idea here is to restrict the use of generics exclusively to those places where they are useful: in the methods making up the public API. Underneath that layer, Moq should use generics as little as possible in order to avoid needless code duplication, and to make reflection easier.","created_at":"2018-11-04T15:29:50Z","updated_at":"2018-11-04T15:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca788e021ea5961d63484f1583c9fd3b0bd7605d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/moq/moq4/pulls/716/commits","review_comments_url":"https://api.github.com/repos/moq/moq4/pulls/716/comments","review_comment_url":"https://api.github.com/repos/moq/moq4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moq/moq4/issues/716/comments","statuses_url":"https://api.github.com/repos/moq/moq4/statuses/464bc646a8a0604e84395aa4a3e3cd06659a649a","head":{"label":"stakx:less-generics-in-mock-class","ref":"less-generics-in-mock-class","sha":"464bc646a8a0604e84395aa4a3e3cd06659a649a","user":{"login":"stakx","id":104481,"node_id":"MDQ6VXNlcjEwNDQ4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/104481?v=4","gravatar_id":"","url":"https://api.github.com/users/stakx","html_url":"https://github.com/stakx","followers_url":"https://api.github.com/users/stakx/followers","following_url":"https://api.github.com/users/stakx/following{/other_user}","gists_url":"https://api.github.com/users/stakx/gists{/gist_id}","starred_url":"https://api.github.com/users/stakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stakx/subscriptions","organizations_url":"https://api.github.com/users/stakx/orgs","repos_url":"https://api.github.com/users/stakx/repos","events_url":"https://api.github.com/users/stakx/events{/privacy}","received_events_url":"https://api.github.com/users/stakx/received_events","type":"User","site_admin":false},"repo":{"id":92828802,"node_id":"MDEwOlJlcG9zaXRvcnk5MjgyODgwMg==","name":"moq4","full_name":"stakx/moq4","private":false,"owner":{"login":"stakx","id":104481,"node_id":"MDQ6VXNlcjEwNDQ4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/104481?v=4","gravatar_id":"","url":"https://api.github.com/users/stakx","html_url":"https://github.com/stakx","followers_url":"https://api.github.com/users/stakx/followers","following_url":"https://api.github.com/users/stakx/following{/other_user}","gists_url":"https://api.github.com/users/stakx/gists{/gist_id}","starred_url":"https://api.github.com/users/stakx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stakx/subscriptions","organizations_url":"https://api.github.com/users/stakx/orgs","repos_url":"https://api.github.com/users/stakx/repos","events_url":"https://api.github.com/users/stakx/events{/privacy}","received_events_url":"https://api.github.com/users/stakx/received_events","type":"User","site_admin":false},"html_url":"https://github.com/stakx/moq4","description":"Repo for managing Moq 4.x ","fork":true,"url":"https://api.github.com/repos/stakx/moq4","forks_url":"https://api.github.com/repos/stakx/moq4/forks","keys_url":"https://api.github.com/repos/stakx/moq4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stakx/moq4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stakx/moq4/teams","hooks_url":"https://api.github.com/repos/stakx/moq4/hooks","issue_events_url":"https://api.github.com/repos/stakx/moq4/issues/events{/number}","events_url":"https://api.github.com/repos/stakx/moq4/events","assignees_url":"https://api.github.com/repos/stakx/moq4/assignees{/user}","branches_url":"https://api.github.com/repos/stakx/moq4/branches{/branch}","tags_url":"https://api.github.com/repos/stakx/moq4/tags","blobs_url":"https://api.github.com/repos/stakx/moq4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stakx/moq4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stakx/moq4/git/refs{/sha}","trees_url":"https://api.github.com/repos/stakx/moq4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stakx/moq4/statuses/{sha}","languages_url":"https://api.github.com/repos/stakx/moq4/languages","stargazers_url":"https://api.github.com/repos/stakx/moq4/stargazers","contributors_url":"https://api.github.com/repos/stakx/moq4/contributors","subscribers_url":"https://api.github.com/repos/stakx/moq4/subscribers","subscription_url":"https://api.github.com/repos/stakx/moq4/subscription","commits_url":"https://api.github.com/repos/stakx/moq4/commits{/sha}","git_commits_url":"https://api.github.com/repos/stakx/moq4/git/commits{/sha}","comments_url":"https://api.github.com/repos/stakx/moq4/comments{/number}","issue_comment_url":"https://api.github.com/repos/stakx/moq4/issues/comments{/number}","contents_url":"https://api.github.com/repos/stakx/moq4/contents/{+path}","compare_url":"https://api.github.com/repos/stakx/moq4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stakx/moq4/merges","archive_url":"https://api.github.com/repos/stakx/moq4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stakx/moq4/downloads","issues_url":"https://api.github.com/repos/stakx/moq4/issues{/number}","pulls_url":"https://api.github.com/repos/stakx/moq4/pulls{/number}","milestones_url":"https://api.github.com/repos/stakx/moq4/milestones{/number}","notifications_url":"https://api.github.com/repos/stakx/moq4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stakx/moq4/labels{/name}","releases_url":"https://api.github.com/repos/stakx/moq4/releases{/id}","deployments_url":"https://api.github.com/repos/stakx/moq4/deployments","created_at":"2017-05-30T12:06:09Z","updated_at":"2018-10-28T14:31:12Z","pushed_at":"2018-11-04T15:20:00Z","git_url":"git://github.com/stakx/moq4.git","ssh_url":"git@github.com:stakx/moq4.git","clone_url":"https://github.com/stakx/moq4.git","svn_url":"https://github.com/stakx/moq4","homepage":"","size":20783,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"moq:master","ref":"master","sha":"ac4968f1c4d0d6908bb1690e37a9346eaa02391d","user":{"login":"moq","id":1434934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzQ5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1434934?v=4","gravatar_id":"","url":"https://api.github.com/users/moq","html_url":"https://github.com/moq","followers_url":"https://api.github.com/users/moq/followers","following_url":"https://api.github.com/users/moq/following{/other_user}","gists_url":"https://api.github.com/users/moq/gists{/gist_id}","starred_url":"https://api.github.com/users/moq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moq/subscriptions","organizations_url":"https://api.github.com/users/moq/orgs","repos_url":"https://api.github.com/users/moq/repos","events_url":"https://api.github.com/users/moq/events{/privacy}","received_events_url":"https://api.github.com/users/moq/received_events","type":"Organization","site_admin":false},"repo":{"id":3689718,"node_id":"MDEwOlJlcG9zaXRvcnkzNjg5NzE4","name":"moq4","full_name":"moq/moq4","private":false,"owner":{"login":"moq","id":1434934,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzQ5MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1434934?v=4","gravatar_id":"","url":"https://api.github.com/users/moq","html_url":"https://github.com/moq","followers_url":"https://api.github.com/users/moq/followers","following_url":"https://api.github.com/users/moq/following{/other_user}","gists_url":"https://api.github.com/users/moq/gists{/gist_id}","starred_url":"https://api.github.com/users/moq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moq/subscriptions","organizations_url":"https://api.github.com/users/moq/orgs","repos_url":"https://api.github.com/users/moq/repos","events_url":"https://api.github.com/users/moq/events{/privacy}","received_events_url":"https://api.github.com/users/moq/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/moq/moq4","description":"Repo for managing Moq 4.x ","fork":false,"url":"https://api.github.com/repos/moq/moq4","forks_url":"https://api.github.com/repos/moq/moq4/forks","keys_url":"https://api.github.com/repos/moq/moq4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moq/moq4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moq/moq4/teams","hooks_url":"https://api.github.com/repos/moq/moq4/hooks","issue_events_url":"https://api.github.com/repos/moq/moq4/issues/events{/number}","events_url":"https://api.github.com/repos/moq/moq4/events","assignees_url":"https://api.github.com/repos/moq/moq4/assignees{/user}","branches_url":"https://api.github.com/repos/moq/moq4/branches{/branch}","tags_url":"https://api.github.com/repos/moq/moq4/tags","blobs_url":"https://api.github.com/repos/moq/moq4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moq/moq4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moq/moq4/git/refs{/sha}","trees_url":"https://api.github.com/repos/moq/moq4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moq/moq4/statuses/{sha}","languages_url":"https://api.github.com/repos/moq/moq4/languages","stargazers_url":"https://api.github.com/repos/moq/moq4/stargazers","contributors_url":"https://api.github.com/repos/moq/moq4/contributors","subscribers_url":"https://api.github.com/repos/moq/moq4/subscribers","subscription_url":"https://api.github.com/repos/moq/moq4/subscription","commits_url":"https://api.github.com/repos/moq/moq4/commits{/sha}","git_commits_url":"https://api.github.com/repos/moq/moq4/git/commits{/sha}","comments_url":"https://api.github.com/repos/moq/moq4/comments{/number}","issue_comment_url":"https://api.github.com/repos/moq/moq4/issues/comments{/number}","contents_url":"https://api.github.com/repos/moq/moq4/contents/{+path}","compare_url":"https://api.github.com/repos/moq/moq4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moq/moq4/merges","archive_url":"https://api.github.com/repos/moq/moq4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moq/moq4/downloads","issues_url":"https://api.github.com/repos/moq/moq4/issues{/number}","pulls_url":"https://api.github.com/repos/moq/moq4/pulls{/number}","milestones_url":"https://api.github.com/repos/moq/moq4/milestones{/number}","notifications_url":"https://api.github.com/repos/moq/moq4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moq/moq4/labels{/name}","releases_url":"https://api.github.com/repos/moq/moq4/releases{/id}","deployments_url":"https://api.github.com/repos/moq/moq4/deployments","created_at":"2012-03-11T21:09:02Z","updated_at":"2018-11-04T15:36:21Z","pushed_at":"2018-11-04T15:29:51Z","git_url":"git://github.com/moq/moq4.git","ssh_url":"git@github.com:moq/moq4.git","clone_url":"https://github.com/moq/moq4.git","svn_url":"https://github.com/moq/moq4","homepage":"","size":20772,"stargazers_count":2585,"watchers_count":2585,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":494,"open_issues":21,"watchers":2585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moq/moq4/pulls/716"},"html":{"href":"https://github.com/moq/moq4/pull/716"},"issue":{"href":"https://api.github.com/repos/moq/moq4/issues/716"},"comments":{"href":"https://api.github.com/repos/moq/moq4/issues/716/comments"},"review_comments":{"href":"https://api.github.com/repos/moq/moq4/pulls/716/comments"},"review_comment":{"href":"https://api.github.com/repos/moq/moq4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moq/moq4/pulls/716/commits"},"statuses":{"href":"https://api.github.com/repos/moq/moq4/statuses/464bc646a8a0604e84395aa4a3e3cd06659a649a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"stakx"}}