{"action":"created","issue":{"url":"https://api.github.com/repos/felix-lang/fbuild/issues/36","repository_url":"https://api.github.com/repos/felix-lang/fbuild","labels_url":"https://api.github.com/repos/felix-lang/fbuild/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/felix-lang/fbuild/issues/36/comments","events_url":"https://api.github.com/repos/felix-lang/fbuild/issues/36/events","html_url":"https://github.com/felix-lang/fbuild/issues/36","id":361692846,"node_id":"MDU6SXNzdWUzNjE2OTI4NDY=","number":36,"title":"Embedded NULL failure","user":{"login":"skaller","id":431744,"node_id":"MDQ6VXNlcjQzMTc0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/431744?v=4","gravatar_id":"","url":"https://api.github.com/users/skaller","html_url":"https://github.com/skaller","followers_url":"https://api.github.com/users/skaller/followers","following_url":"https://api.github.com/users/skaller/following{/other_user}","gists_url":"https://api.github.com/users/skaller/gists{/gist_id}","starred_url":"https://api.github.com/users/skaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skaller/subscriptions","organizations_url":"https://api.github.com/users/skaller/orgs","repos_url":"https://api.github.com/users/skaller/repos","events_url":"https://api.github.com/users/skaller/events{/privacy}","received_events_url":"https://api.github.com/users/skaller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-19T10:59:24Z","updated_at":"2018-09-20T05:18:20Z","closed_at":null,"author_association":"MEMBER","body":"Building Felix:\r\n\r\nI haven't seen this before, I have changed the build process a bit.\r\n\r\nIt looks like a bug in Python.. but why didn't it happen before?\r\n\r\nAppveyor  CI:\r\n```\r\nset PATH=C:\\Python35-x64;c:\\ocaml\\bin;%PATH%\r\npython --version\r\nPython 3.5.4\r\n```\r\netermining platform     : {'windows', 'win32'}\r\nlooking for cl.exe       : ok C:\\Program Files (x86)\\Microsoft Visual Studio 14.0\\VC\\BIN\\amd64\\cl.exe\r\nchecking cl.exe          : Traceback (most recent call last):\r\n  File \"fbuild\\fbuild-light\", line 11, in <module>\r\n    main()\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\main.py\", line 179, in main\r\n    result = build(ctx)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\main.py\", line 104, in build\r\n    target.function(ctx)\r\n  File \"C:\\projects\\felix-e3h83\\fbuildroot.py\", line 585, in build\r\n    phases = configure(ctx)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\db\\__init__.py\", line 121, in __call__\r\n    result, srcs, dsts = self.call(*args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\db\\__init__.py\", line 125, in call\r\n    return ctx.db.call(self.function, ctx, *args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\db\\database.py\", line 165, in call\r\n    call_result = function(*args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuildroot.py\", line 558, in configure\r\n    build = config_build(ctx)\r\n  File \"C:\\projects\\felix-e3h83\\fbuildroot.py\", line 328, in config_build\r\n    flags=ctx.options.build_c_flags),\r\n  File \"C:\\projects\\felix-e3h83\\fbuildroot.py\", line 258, in make_c_builder\r\n    static=call('fbuild.builders.c.guess_static', ctx, *args, **kwargs),\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\functools.py\", line 32, in call\r\n    return import_function(function)(*args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\builders\\c\\__init__.py\", line 457, in guess_static\r\n    ), *args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\builders\\c\\__init__.py\", line 394, in _guess_builder\r\n    return fbuild.functools.call(function, ctx, exe, *args, **new_kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\functools.py\", line 32, in call\r\n    return import_function(function)(*args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\builders\\c\\msvc.py\", line 531, in static\r\n    compiler=Compiler(ctx, Cl(ctx, **kwargs),\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\db\\__init__.py\", line 68, in __call__\r\n    *args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\db\\database.py\", line 165, in call\r\n    call_result = function(*args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\db\\__init__.py\", line 64, in __call_super__\r\n    return super().__call__(*args, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\builders\\c\\msvc.py\", line 38, in __init__\r\n    if not self.check_flags(flags):\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\builders\\c\\msvc.py\", line 116, in check_flags\r\n    self([src], flags=flags, quieter=1, cwd=src.parent)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\builders\\c\\msvc.py\", line 103, in __call__\r\n    return self.ctx.execute(cmd, msg2=msg2, **kwargs)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\context.py\", line 214, in execute\r\n    **kwargs)\r\n  File \"C:\\Python35-x64\\lib\\subprocess.py\", line 676, in __init__\r\n    restore_signals, start_new_session)\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\subprocess\\killableprocess.py\", line 182, in _execute_child\r\n    winprocess.EnvironmentBlock(env),\r\n  File \"C:\\projects\\felix-e3h83\\fbuild\\lib\\fbuild\\subprocess\\winprocess.py\", line 129, in __init__\r\n    self._as_parameter_ = LPCWSTR(\"\\0\".join(values))\r\nValueError: embedded null character\r\nNMAKE : fatal error U1077: 'C:\\Python35-x64\\python.EXE' : return code '0x1'\r\nStop.\r\n```"},"comment":{"url":"https://api.github.com/repos/felix-lang/fbuild/issues/comments/423043160","html_url":"https://github.com/felix-lang/fbuild/issues/36#issuecomment-423043160","issue_url":"https://api.github.com/repos/felix-lang/fbuild/issues/36","id":423043160,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzA0MzE2MA==","user":{"login":"kirbyfan64","id":1690697,"node_id":"MDQ6VXNlcjE2OTA2OTc=","avatar_url":"https://avatars1.githubusercontent.com/u/1690697?v=4","gravatar_id":"","url":"https://api.github.com/users/kirbyfan64","html_url":"https://github.com/kirbyfan64","followers_url":"https://api.github.com/users/kirbyfan64/followers","following_url":"https://api.github.com/users/kirbyfan64/following{/other_user}","gists_url":"https://api.github.com/users/kirbyfan64/gists{/gist_id}","starred_url":"https://api.github.com/users/kirbyfan64/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kirbyfan64/subscriptions","organizations_url":"https://api.github.com/users/kirbyfan64/orgs","repos_url":"https://api.github.com/users/kirbyfan64/repos","events_url":"https://api.github.com/users/kirbyfan64/events{/privacy}","received_events_url":"https://api.github.com/users/kirbyfan64/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T05:18:20Z","updated_at":"2018-09-20T05:18:20Z","author_association":"CONTRIBUTOR","body":"    LPCWSTR(\"\\0\".join(values).encode(\"utf-16le\"))\n\nYou mixed up the fix a bit... It should be LPCSTR, not LPCWSTR. \n\nAppVeyor's Python likely got upgraded to a version that has the bug. "}}
{"actor":{"display_login":"kirbyfan64"}}