{"action":"closed","number":2041,"pull_request":{"url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2041","id":208017851,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDE3ODUx","html_url":"https://github.com/DataDog/integrations-core/pull/2041","diff_url":"https://github.com/DataDog/integrations-core/pull/2041.diff","patch_url":"https://github.com/DataDog/integrations-core/pull/2041.patch","issue_url":"https://api.github.com/repos/DataDog/integrations-core/issues/2041","number":2041,"state":"closed","locked":false,"title":"Send correct count values for NGINX ever increasing counters","user":{"login":"zippolyte","id":19330189,"node_id":"MDQ6VXNlcjE5MzMwMTg5","avatar_url":"https://avatars0.githubusercontent.com/u/19330189?v=4","gravatar_id":"","url":"https://api.github.com/users/zippolyte","html_url":"https://github.com/zippolyte","followers_url":"https://api.github.com/users/zippolyte/followers","following_url":"https://api.github.com/users/zippolyte/following{/other_user}","gists_url":"https://api.github.com/users/zippolyte/gists{/gist_id}","starred_url":"https://api.github.com/users/zippolyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zippolyte/subscriptions","organizations_url":"https://api.github.com/users/zippolyte/orgs","repos_url":"https://api.github.com/users/zippolyte/repos","events_url":"https://api.github.com/users/zippolyte/events{/privacy}","received_events_url":"https://api.github.com/users/zippolyte/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nThe check should be using the `monotonic_count` method to send counters for ever increasing values. This PR corrects it.\r\nResolves #2020.\r\n\r\nThis change can trigger monitors since values in the app will change.\r\n\r\n### Motivation\r\n\r\nWith the `count` method, the values are wrong and unusable. This is due to the fact that the `count` method expects a delta of the counter between the last check run and the current one, while the `monotonic_count` method expects the current value of the counter, and deals with computing the delta on its own. More info on the metric methods here: https://docs.datadoghq.com/developers/metrics/counts/ \r\n\r\n### Review checklist\r\n\r\n- [ ] PR has a [meaningful title](https://github.com/DataDog/integrations-core/blob/master/CONTRIBUTING.md#pull-request-title) or PR has the `no-changelog` label attached\r\n- [ ] Feature or bugfix has tests\r\n- [ ] Git history is clean\r\n- [ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the [documentation repo](https://github.com/DataDog/documentation/issues/new)\r\n\r\n### Additional Notes\r\n\r\nAnything else we should know when reviewing?","created_at":"2018-08-13T15:35:18Z","updated_at":"2018-08-14T08:13:15Z","closed_at":"2018-08-14T08:13:15Z","merged_at":"2018-08-14T08:13:15Z","merge_commit_sha":"97ac1715bf2d6c4759ce62127c44fefc65fce6c2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":937215978,"node_id":"MDU6TGFiZWw5MzcyMTU5Nzg=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/changelog/Changed","name":"changelog/Changed","color":"f2983e","default":false},{"id":936574874,"node_id":"MDU6TGFiZWw5MzY1NzQ4NzQ=","url":"https://api.github.com/repos/DataDog/integrations-core/labels/integration/nginx","name":"integration/nginx","color":"bfdadc","default":false}],"milestone":{"url":"https://api.github.com/repos/DataDog/integrations-core/milestones/46","html_url":"https://github.com/DataDog/integrations-core/milestone/46","labels_url":"https://api.github.com/repos/DataDog/integrations-core/milestones/46/labels","id":3567962,"node_id":"MDk6TWlsZXN0b25lMzU2Nzk2Mg==","number":46,"title":"6.5.0","description":null,"creator":{"login":"zippolyte","id":19330189,"node_id":"MDQ6VXNlcjE5MzMwMTg5","avatar_url":"https://avatars0.githubusercontent.com/u/19330189?v=4","gravatar_id":"","url":"https://api.github.com/users/zippolyte","html_url":"https://github.com/zippolyte","followers_url":"https://api.github.com/users/zippolyte/followers","following_url":"https://api.github.com/users/zippolyte/following{/other_user}","gists_url":"https://api.github.com/users/zippolyte/gists{/gist_id}","starred_url":"https://api.github.com/users/zippolyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zippolyte/subscriptions","organizations_url":"https://api.github.com/users/zippolyte/orgs","repos_url":"https://api.github.com/users/zippolyte/repos","events_url":"https://api.github.com/users/zippolyte/events{/privacy}","received_events_url":"https://api.github.com/users/zippolyte/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2018-08-14T08:12:57Z","updated_at":"2018-08-14T08:13:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2041/commits","review_comments_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/2041/comments","review_comment_url":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/issues/2041/comments","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/fc92caedded4013b2dedb2e0a0fa626679c451c0","head":{"label":"DataDog:hippo/nginx_metrics","ref":"hippo/nginx_metrics","sha":"fc92caedded4013b2dedb2e0a0fa626679c451c0","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the datadog agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-08-14T05:16:19Z","pushed_at":"2018-08-14T08:13:16Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":null,"size":27920,"stargazers_count":133,"watchers_count":133,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":295,"open_issues":67,"watchers":133,"default_branch":"master"}},"base":{"label":"DataDog:master","ref":"master","sha":"b9c30ac0a6aaa8f26c623f66808cc0a596ba9f5a","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":47203045,"node_id":"MDEwOlJlcG9zaXRvcnk0NzIwMzA0NQ==","name":"integrations-core","full_name":"DataDog/integrations-core","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/integrations-core","description":"Core integrations of the datadog agent","fork":false,"url":"https://api.github.com/repos/DataDog/integrations-core","forks_url":"https://api.github.com/repos/DataDog/integrations-core/forks","keys_url":"https://api.github.com/repos/DataDog/integrations-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/integrations-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/integrations-core/teams","hooks_url":"https://api.github.com/repos/DataDog/integrations-core/hooks","issue_events_url":"https://api.github.com/repos/DataDog/integrations-core/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/integrations-core/events","assignees_url":"https://api.github.com/repos/DataDog/integrations-core/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/integrations-core/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/integrations-core/tags","blobs_url":"https://api.github.com/repos/DataDog/integrations-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/integrations-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/integrations-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/integrations-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/integrations-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/integrations-core/languages","stargazers_url":"https://api.github.com/repos/DataDog/integrations-core/stargazers","contributors_url":"https://api.github.com/repos/DataDog/integrations-core/contributors","subscribers_url":"https://api.github.com/repos/DataDog/integrations-core/subscribers","subscription_url":"https://api.github.com/repos/DataDog/integrations-core/subscription","commits_url":"https://api.github.com/repos/DataDog/integrations-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/integrations-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/integrations-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/integrations-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/integrations-core/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/integrations-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/integrations-core/merges","archive_url":"https://api.github.com/repos/DataDog/integrations-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/integrations-core/downloads","issues_url":"https://api.github.com/repos/DataDog/integrations-core/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/integrations-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/integrations-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/integrations-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/integrations-core/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/integrations-core/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/integrations-core/deployments","created_at":"2015-12-01T16:41:45Z","updated_at":"2018-08-14T05:16:19Z","pushed_at":"2018-08-14T08:13:16Z","git_url":"git://github.com/DataDog/integrations-core.git","ssh_url":"git@github.com:DataDog/integrations-core.git","clone_url":"https://github.com/DataDog/integrations-core.git","svn_url":"https://github.com/DataDog/integrations-core","homepage":null,"size":27920,"stargazers_count":133,"watchers_count":133,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":67,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":295,"open_issues":67,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2041"},"html":{"href":"https://github.com/DataDog/integrations-core/pull/2041"},"issue":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/2041"},"comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/issues/2041/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2041/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/integrations-core/pulls/2041/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/integrations-core/statuses/fc92caedded4013b2dedb2e0a0fa626679c451c0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"zippolyte","id":19330189,"node_id":"MDQ6VXNlcjE5MzMwMTg5","avatar_url":"https://avatars0.githubusercontent.com/u/19330189?v=4","gravatar_id":"","url":"https://api.github.com/users/zippolyte","html_url":"https://github.com/zippolyte","followers_url":"https://api.github.com/users/zippolyte/followers","following_url":"https://api.github.com/users/zippolyte/following{/other_user}","gists_url":"https://api.github.com/users/zippolyte/gists{/gist_id}","starred_url":"https://api.github.com/users/zippolyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zippolyte/subscriptions","organizations_url":"https://api.github.com/users/zippolyte/orgs","repos_url":"https://api.github.com/users/zippolyte/repos","events_url":"https://api.github.com/users/zippolyte/events{/privacy}","received_events_url":"https://api.github.com/users/zippolyte/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"zippolyte"}}