{"action":"created","comment":{"url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/comments/176873918","pull_request_review_id":106660474,"id":176873918,"diff_hunk":"@@ -17,4 +24,62 @@ public void doGet(HttpServletRequest request, HttpServletResponse response)\n     // Forward request to register.jsp file\n     request.getRequestDispatcher(\"/WEB-INF/view/register.jsp\").forward(request, response);\n   }//doGet\n+","path":"src/main/java/codeu/controller/RegisterServlet.java","position":22,"original_position":22,"commit_id":"b6cb8a5a8629d2eab04748975a2dce7e7124bc38","original_commit_id":"b6cb8a5a8629d2eab04748975a2dce7e7124bc38","user":{"login":"sherryx8","id":19396335,"avatar_url":"https://avatars2.githubusercontent.com/u/19396335?v=4","gravatar_id":"","url":"https://api.github.com/users/sherryx8","html_url":"https://github.com/sherryx8","followers_url":"https://api.github.com/users/sherryx8/followers","following_url":"https://api.github.com/users/sherryx8/following{/other_user}","gists_url":"https://api.github.com/users/sherryx8/gists{/gist_id}","starred_url":"https://api.github.com/users/sherryx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherryx8/subscriptions","organizations_url":"https://api.github.com/users/sherryx8/orgs","repos_url":"https://api.github.com/users/sherryx8/repos","events_url":"https://api.github.com/users/sherryx8/events{/privacy}","received_events_url":"https://api.github.com/users/sherryx8/received_events","type":"User","site_admin":false},"body":"I think the reason things are inconsistent between my code and Tishauna's is because mine contain the changes from 4 (create register.jsp), whereas hers do not. ( in some places they do?) For this file in particular, I needed to make changes to doPost function, which is not created until Tishauna's part 5. I needed to copy-paste it from her pull request (because they are not merged yet) in order to proceed with 9. ","created_at":"2018-03-23T21:57:45Z","updated_at":"2018-03-23T21:57:45Z","html_url":"https://github.com/sherryx8/CodeU-Spring-2018/pull/13#discussion_r176873918","pull_request_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/13","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/comments/176873918"},"html":{"href":"https://github.com/sherryx8/CodeU-Spring-2018/pull/13#discussion_r176873918"},"pull_request":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/13"}},"in_reply_to_id":176872986},"pull_request":{"url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/13","id":177164363,"html_url":"https://github.com/sherryx8/CodeU-Spring-2018/pull/13","diff_url":"https://github.com/sherryx8/CodeU-Spring-2018/pull/13.diff","patch_url":"https://github.com/sherryx8/CodeU-Spring-2018/pull/13.patch","issue_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues/13","number":13,"state":"open","locked":false,"title":"(8 and 9) Add Links to Register and Secure Passwords","user":{"login":"sherryx8","id":19396335,"avatar_url":"https://avatars2.githubusercontent.com/u/19396335?v=4","gravatar_id":"","url":"https://api.github.com/users/sherryx8","html_url":"https://github.com/sherryx8","followers_url":"https://api.github.com/users/sherryx8/followers","following_url":"https://api.github.com/users/sherryx8/following{/other_user}","gists_url":"https://api.github.com/users/sherryx8/gists{/gist_id}","starred_url":"https://api.github.com/users/sherryx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherryx8/subscriptions","organizations_url":"https://api.github.com/users/sherryx8/orgs","repos_url":"https://api.github.com/users/sherryx8/repos","events_url":"https://api.github.com/users/sherryx8/events{/privacy}","received_events_url":"https://api.github.com/users/sherryx8/received_events","type":"User","site_admin":false},"body":"8: added links to register on all jsp pages. \r\n9: secured passwords using BCrypt + added/adjusted password testing.","created_at":"2018-03-23T19:29:12Z","updated_at":"2018-03-23T21:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d390534ffadffef1e855124bff65b6a9ce20ca2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sgoya","id":5958065,"avatar_url":"https://avatars0.githubusercontent.com/u/5958065?v=4","gravatar_id":"","url":"https://api.github.com/users/sgoya","html_url":"https://github.com/sgoya","followers_url":"https://api.github.com/users/sgoya/followers","following_url":"https://api.github.com/users/sgoya/following{/other_user}","gists_url":"https://api.github.com/users/sgoya/gists{/gist_id}","starred_url":"https://api.github.com/users/sgoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgoya/subscriptions","organizations_url":"https://api.github.com/users/sgoya/orgs","repos_url":"https://api.github.com/users/sgoya/repos","events_url":"https://api.github.com/users/sgoya/events{/privacy}","received_events_url":"https://api.github.com/users/sgoya/received_events","type":"User","site_admin":false},{"login":"TWilson2017","id":25163556,"avatar_url":"https://avatars2.githubusercontent.com/u/25163556?v=4","gravatar_id":"","url":"https://api.github.com/users/TWilson2017","html_url":"https://github.com/TWilson2017","followers_url":"https://api.github.com/users/TWilson2017/followers","following_url":"https://api.github.com/users/TWilson2017/following{/other_user}","gists_url":"https://api.github.com/users/TWilson2017/gists{/gist_id}","starred_url":"https://api.github.com/users/TWilson2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TWilson2017/subscriptions","organizations_url":"https://api.github.com/users/TWilson2017/orgs","repos_url":"https://api.github.com/users/TWilson2017/repos","events_url":"https://api.github.com/users/TWilson2017/events{/privacy}","received_events_url":"https://api.github.com/users/TWilson2017/received_events","type":"User","site_admin":false},{"login":"tharminhtet","id":26337722,"avatar_url":"https://avatars2.githubusercontent.com/u/26337722?v=4","gravatar_id":"","url":"https://api.github.com/users/tharminhtet","html_url":"https://github.com/tharminhtet","followers_url":"https://api.github.com/users/tharminhtet/followers","following_url":"https://api.github.com/users/tharminhtet/following{/other_user}","gists_url":"https://api.github.com/users/tharminhtet/gists{/gist_id}","starred_url":"https://api.github.com/users/tharminhtet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tharminhtet/subscriptions","organizations_url":"https://api.github.com/users/tharminhtet/orgs","repos_url":"https://api.github.com/users/tharminhtet/repos","events_url":"https://api.github.com/users/tharminhtet/events{/privacy}","received_events_url":"https://api.github.com/users/tharminhtet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/13/commits","review_comments_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/13/comments","review_comment_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues/13/comments","statuses_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/statuses/b6cb8a5a8629d2eab04748975a2dce7e7124bc38","head":{"label":"sherryx8:sherryDev","ref":"sherryDev","sha":"b6cb8a5a8629d2eab04748975a2dce7e7124bc38","user":{"login":"sherryx8","id":19396335,"avatar_url":"https://avatars2.githubusercontent.com/u/19396335?v=4","gravatar_id":"","url":"https://api.github.com/users/sherryx8","html_url":"https://github.com/sherryx8","followers_url":"https://api.github.com/users/sherryx8/followers","following_url":"https://api.github.com/users/sherryx8/following{/other_user}","gists_url":"https://api.github.com/users/sherryx8/gists{/gist_id}","starred_url":"https://api.github.com/users/sherryx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherryx8/subscriptions","organizations_url":"https://api.github.com/users/sherryx8/orgs","repos_url":"https://api.github.com/users/sherryx8/repos","events_url":"https://api.github.com/users/sherryx8/events{/privacy}","received_events_url":"https://api.github.com/users/sherryx8/received_events","type":"User","site_admin":false},"repo":{"id":123866528,"name":"CodeU-Spring-2018","full_name":"sherryx8/CodeU-Spring-2018","owner":{"login":"sherryx8","id":19396335,"avatar_url":"https://avatars2.githubusercontent.com/u/19396335?v=4","gravatar_id":"","url":"https://api.github.com/users/sherryx8","html_url":"https://github.com/sherryx8","followers_url":"https://api.github.com/users/sherryx8/followers","following_url":"https://api.github.com/users/sherryx8/following{/other_user}","gists_url":"https://api.github.com/users/sherryx8/gists{/gist_id}","starred_url":"https://api.github.com/users/sherryx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherryx8/subscriptions","organizations_url":"https://api.github.com/users/sherryx8/orgs","repos_url":"https://api.github.com/users/sherryx8/repos","events_url":"https://api.github.com/users/sherryx8/events{/privacy}","received_events_url":"https://api.github.com/users/sherryx8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sherryx8/CodeU-Spring-2018","description":"Team Cicada CodeU Spring 2018 Project","fork":false,"url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018","forks_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/forks","keys_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/teams","hooks_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/hooks","issue_events_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues/events{/number}","events_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/events","assignees_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/assignees{/user}","branches_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/branches{/branch}","tags_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/tags","blobs_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/languages","stargazers_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/stargazers","contributors_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/contributors","subscribers_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/subscribers","subscription_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/subscription","commits_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/contents/{+path}","compare_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/merges","archive_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/downloads","issues_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues{/number}","pulls_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/labels{/name}","releases_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/releases{/id}","deployments_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/deployments","created_at":"2018-03-05T04:54:55Z","updated_at":"2018-03-21T14:12:08Z","pushed_at":"2018-03-23T19:37:32Z","git_url":"git://github.com/sherryx8/CodeU-Spring-2018.git","ssh_url":"git@github.com:sherryx8/CodeU-Spring-2018.git","clone_url":"https://github.com/sherryx8/CodeU-Spring-2018.git","svn_url":"https://github.com/sherryx8/CodeU-Spring-2018","homepage":"http://chat-app-197200.appspot.com/","size":112,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"sherryx8:master","ref":"master","sha":"084bb34f76e427e69647751925ead5ee81b7cf2c","user":{"login":"sherryx8","id":19396335,"avatar_url":"https://avatars2.githubusercontent.com/u/19396335?v=4","gravatar_id":"","url":"https://api.github.com/users/sherryx8","html_url":"https://github.com/sherryx8","followers_url":"https://api.github.com/users/sherryx8/followers","following_url":"https://api.github.com/users/sherryx8/following{/other_user}","gists_url":"https://api.github.com/users/sherryx8/gists{/gist_id}","starred_url":"https://api.github.com/users/sherryx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherryx8/subscriptions","organizations_url":"https://api.github.com/users/sherryx8/orgs","repos_url":"https://api.github.com/users/sherryx8/repos","events_url":"https://api.github.com/users/sherryx8/events{/privacy}","received_events_url":"https://api.github.com/users/sherryx8/received_events","type":"User","site_admin":false},"repo":{"id":123866528,"name":"CodeU-Spring-2018","full_name":"sherryx8/CodeU-Spring-2018","owner":{"login":"sherryx8","id":19396335,"avatar_url":"https://avatars2.githubusercontent.com/u/19396335?v=4","gravatar_id":"","url":"https://api.github.com/users/sherryx8","html_url":"https://github.com/sherryx8","followers_url":"https://api.github.com/users/sherryx8/followers","following_url":"https://api.github.com/users/sherryx8/following{/other_user}","gists_url":"https://api.github.com/users/sherryx8/gists{/gist_id}","starred_url":"https://api.github.com/users/sherryx8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sherryx8/subscriptions","organizations_url":"https://api.github.com/users/sherryx8/orgs","repos_url":"https://api.github.com/users/sherryx8/repos","events_url":"https://api.github.com/users/sherryx8/events{/privacy}","received_events_url":"https://api.github.com/users/sherryx8/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sherryx8/CodeU-Spring-2018","description":"Team Cicada CodeU Spring 2018 Project","fork":false,"url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018","forks_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/forks","keys_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/teams","hooks_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/hooks","issue_events_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues/events{/number}","events_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/events","assignees_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/assignees{/user}","branches_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/branches{/branch}","tags_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/tags","blobs_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/languages","stargazers_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/stargazers","contributors_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/contributors","subscribers_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/subscribers","subscription_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/subscription","commits_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/contents/{+path}","compare_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/merges","archive_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/downloads","issues_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues{/number}","pulls_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/labels{/name}","releases_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/releases{/id}","deployments_url":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/deployments","created_at":"2018-03-05T04:54:55Z","updated_at":"2018-03-21T14:12:08Z","pushed_at":"2018-03-23T19:37:32Z","git_url":"git://github.com/sherryx8/CodeU-Spring-2018.git","ssh_url":"git@github.com:sherryx8/CodeU-Spring-2018.git","clone_url":"https://github.com/sherryx8/CodeU-Spring-2018.git","svn_url":"https://github.com/sherryx8/CodeU-Spring-2018","homepage":"http://chat-app-197200.appspot.com/","size":112,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/13"},"html":{"href":"https://github.com/sherryx8/CodeU-Spring-2018/pull/13"},"issue":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues/13"},"comments":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/sherryx8/CodeU-Spring-2018/statuses/b6cb8a5a8629d2eab04748975a2dce7e7124bc38"}},"author_association":"OWNER"}}
{"actor":{"display_login":"sherryx8"}}