{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/201120653","pull_request_review_id":135560359,"id":201120653,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTEyMDY1Mw==","diff_hunk":"@@ -116,13 +120,12 @@ def step(self, postprocess_fn=None):\n                         self.sess,\n                         permutation[batch_index] * self.per_device_batch_size)\n                     for k, v in batch_fetches.items():\n-                        iter_extra_fetches[k] += [v]\n-                for k, v in iter_extra_fetches.items():\n-                    all_extra_fetches[k] += [v]\n+                        iter_extra_fetches[k].append(v)\n+                print(i, _averaged(iter_extra_fetches))","path":"python/ray/rllib/optimizers/multi_gpu_optimizer.py","position":71,"original_position":59,"commit_id":"9bfd1d5cceb6c8c82480840ff7f9fc7717999839","original_commit_id":"dfb76e63a908da423623bb3ef452000b820b3ef3","user":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"Eh, I'm not sure why returning all epoch stats makes sense in any scenario, unless your epochs were very small and the values noisy.","created_at":"2018-07-09T19:30:38Z","updated_at":"2018-07-09T19:30:39Z","html_url":"https://github.com/ray-project/ray/pull/2366#discussion_r201120653","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/2366","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/201120653"},"html":{"href":"https://github.com/ray-project/ray/pull/2366#discussion_r201120653"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2366"}},"in_reply_to_id":200804364},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/2366","id":199883405,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODgzNDA1","html_url":"https://github.com/ray-project/ray/pull/2366","diff_url":"https://github.com/ray-project/ray/pull/2366.diff","patch_url":"https://github.com/ray-project/ray/pull/2366.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/2366","number":2366,"state":"open","locked":false,"title":"[rllib] Add debug info back to PPO and fix optimizer compatibility","user":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"\r\n## What do these changes do?\r\n\r\nMake it work with sync samples optimizer too (this enables LSTM), and add back debug stats.","created_at":"2018-07-07T06:33:52Z","updated_at":"2018-07-09T19:30:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"215deb963d86dbcce2fa5285ed657bf4490dda9e","assignee":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"assignees":[{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/2366/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/2366/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/2366/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/9bfd1d5cceb6c8c82480840ff7f9fc7717999839","head":{"label":"ericl:fix-ppo","ref":"fix-ppo","sha":"9bfd1d5cceb6c8c82480840ff7f9fc7717999839","user":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"repo":{"id":91077004,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA3NzAwNA==","name":"ray","full_name":"ericl/ray","owner":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericl/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/ericl/ray","forks_url":"https://api.github.com/repos/ericl/ray/forks","keys_url":"https://api.github.com/repos/ericl/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericl/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericl/ray/teams","hooks_url":"https://api.github.com/repos/ericl/ray/hooks","issue_events_url":"https://api.github.com/repos/ericl/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ericl/ray/events","assignees_url":"https://api.github.com/repos/ericl/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ericl/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ericl/ray/tags","blobs_url":"https://api.github.com/repos/ericl/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericl/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericl/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericl/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericl/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ericl/ray/languages","stargazers_url":"https://api.github.com/repos/ericl/ray/stargazers","contributors_url":"https://api.github.com/repos/ericl/ray/contributors","subscribers_url":"https://api.github.com/repos/ericl/ray/subscribers","subscription_url":"https://api.github.com/repos/ericl/ray/subscription","commits_url":"https://api.github.com/repos/ericl/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericl/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericl/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericl/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericl/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ericl/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericl/ray/merges","archive_url":"https://api.github.com/repos/ericl/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericl/ray/downloads","issues_url":"https://api.github.com/repos/ericl/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ericl/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ericl/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ericl/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericl/ray/labels{/name}","releases_url":"https://api.github.com/repos/ericl/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ericl/ray/deployments","created_at":"2017-05-12T09:51:04Z","updated_at":"2017-05-12T09:51:06Z","pushed_at":"2018-07-08T22:46:44Z","git_url":"git://github.com/ericl/ray.git","ssh_url":"git@github.com:ericl/ray.git","clone_url":"https://github.com/ericl/ray.git","svn_url":"https://github.com/ericl/ray","homepage":"","size":16627,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"4d7da9f66883d8a42290c9c0521ecabc1f114ac8","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-07-09T18:20:30Z","pushed_at":"2018-07-09T18:20:22Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":12924,"stargazers_count":3630,"watchers_count":3630,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":486,"mirror_url":null,"archived":false,"open_issues_count":345,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":486,"open_issues":345,"watchers":3630,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2366"},"html":{"href":"https://github.com/ray-project/ray/pull/2366"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/2366"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/2366/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2366/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2366/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/9bfd1d5cceb6c8c82480840ff7f9fc7717999839"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ericl"}}