{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/comments/219070997","pull_request_review_id":157152522,"id":219070997,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTA3MDk5Nw==","diff_hunk":"@@ -148,20 +148,22 @@ public final boolean commit() throws LoginException {\n             return false;\n         }\n         try {\n+            principal = new MDMPrincipal(username);\n             if (LocalUser.isAdminUser(username)) {\n-                principal = new MDMPrincipal(username);\n                 principal.addRole(ICoreConstants.ADMIN_PERMISSION);\n+                principal.addRole(ICoreConstants.SYSTEM_ADMIN_ROLE);","path":"org.talend.mdm.core/src/com/amalto/core/server/security/jaas/AbstractLoginModule.java","position":8,"original_position":8,"commit_id":"e16aa4f404b4f1661c940b1d0bfbc2348a322825","original_commit_id":"e16aa4f404b4f1661c940b1d0bfbc2348a322825","user":{"login":"lpw82gf","id":9260627,"node_id":"MDQ6VXNlcjkyNjA2Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9260627?v=4","gravatar_id":"","url":"https://api.github.com/users/lpw82gf","html_url":"https://github.com/lpw82gf","followers_url":"https://api.github.com/users/lpw82gf/followers","following_url":"https://api.github.com/users/lpw82gf/following{/other_user}","gists_url":"https://api.github.com/users/lpw82gf/gists{/gist_id}","starred_url":"https://api.github.com/users/lpw82gf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpw82gf/subscriptions","organizations_url":"https://api.github.com/users/lpw82gf/orgs","repos_url":"https://api.github.com/users/lpw82gf/repos","events_url":"https://api.github.com/users/lpw82gf/events{/privacy}","received_events_url":"https://api.github.com/users/lpw82gf/received_events","type":"User","site_admin":false},"body":"Don't think we should add that back on back-end.\r\nCE should get rid of them totally.","created_at":"2018-09-20T08:11:23Z","updated_at":"2018-09-20T08:11:23Z","html_url":"https://github.com/Talend/tmdm-server-se/pull/635#discussion_r219070997","pull_request_url":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/635","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/comments/219070997"},"html":{"href":"https://github.com/Talend/tmdm-server-se/pull/635#discussion_r219070997"},"pull_request":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/635"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/635","id":216878953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODc4OTUz","html_url":"https://github.com/Talend/tmdm-server-se/pull/635","diff_url":"https://github.com/Talend/tmdm-server-se/pull/635.diff","patch_url":"https://github.com/Talend/tmdm-server-se/pull/635.patch","issue_url":"https://api.github.com/repos/Talend/tmdm-server-se/issues/635","number":635,"state":"open","locked":false,"title":"SE code is based on EE permissions which leads to inability to create…","user":{"login":"VictorLi-talendbj","id":41668097,"node_id":"MDQ6VXNlcjQxNjY4MDk3","avatar_url":"https://avatars3.githubusercontent.com/u/41668097?v=4","gravatar_id":"","url":"https://api.github.com/users/VictorLi-talendbj","html_url":"https://github.com/VictorLi-talendbj","followers_url":"https://api.github.com/users/VictorLi-talendbj/followers","following_url":"https://api.github.com/users/VictorLi-talendbj/following{/other_user}","gists_url":"https://api.github.com/users/VictorLi-talendbj/gists{/gist_id}","starred_url":"https://api.github.com/users/VictorLi-talendbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VictorLi-talendbj/subscriptions","organizations_url":"https://api.github.com/users/VictorLi-talendbj/orgs","repos_url":"https://api.github.com/users/VictorLi-talendbj/repos","events_url":"https://api.github.com/users/VictorLi-talendbj/events{/privacy}","received_events_url":"https://api.github.com/users/VictorLi-talendbj/received_events","type":"User","site_admin":false},"body":"**What is the current behavior?** (You should also link to an open issue here)\r\nCE MDM Server will check user role to create record, however, CE doesn't support the concept of role.\r\nsee details from: \r\nhttps://jira.talendforge.org/browse/TMDM-12549\r\n\r\n**What is the new behavior?**\r\nRemoved role definition from PROVISIONING configuration file.\r\nUsed amalto delegator to have Security Check with different version in CE and EE.\r\n\r\n\r\n**Please check if the PR fulfills these requirements**\r\n\r\n- [X] The commit message follows Talend standard\r\n- [X] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features) ?\r\n\r\n**What kind of change does this PR introduce?**\r\n\r\n- [X] Bugfix\r\n- [ ] Feature\r\n- [ ] Code style update (formatting, local variables)\r\n- [ ] Refactoring (no functional changes, no api changes)\r\n- [ ] Build / CI related changes\r\n- [ ] Other... Please describe:\r\n\r\n**Does this PR introduce a breaking change?**\r\n\r\n- [ ] Yes\r\n- [ ] No\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n","created_at":"2018-09-20T08:04:44Z","updated_at":"2018-09-20T08:11:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d591334b2178a808bd85b24b71dcaedcd832a1f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pbabin","id":7779060,"node_id":"MDQ6VXNlcjc3NzkwNjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7779060?v=4","gravatar_id":"","url":"https://api.github.com/users/pbabin","html_url":"https://github.com/pbabin","followers_url":"https://api.github.com/users/pbabin/followers","following_url":"https://api.github.com/users/pbabin/following{/other_user}","gists_url":"https://api.github.com/users/pbabin/gists{/gist_id}","starred_url":"https://api.github.com/users/pbabin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbabin/subscriptions","organizations_url":"https://api.github.com/users/pbabin/orgs","repos_url":"https://api.github.com/users/pbabin/repos","events_url":"https://api.github.com/users/pbabin/events{/privacy}","received_events_url":"https://api.github.com/users/pbabin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/635/commits","review_comments_url":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/635/comments","review_comment_url":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/tmdm-server-se/issues/635/comments","statuses_url":"https://api.github.com/repos/Talend/tmdm-server-se/statuses/e16aa4f404b4f1661c940b1d0bfbc2348a322825","head":{"label":"Talend:bugfix/7.1/TMDM-12549","ref":"bugfix/7.1/TMDM-12549","sha":"e16aa4f404b4f1661c940b1d0bfbc2348a322825","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":21094730,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA5NDczMA==","name":"tmdm-server-se","full_name":"Talend/tmdm-server-se","private":false,"owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Talend/tmdm-server-se","description":null,"fork":false,"url":"https://api.github.com/repos/Talend/tmdm-server-se","forks_url":"https://api.github.com/repos/Talend/tmdm-server-se/forks","keys_url":"https://api.github.com/repos/Talend/tmdm-server-se/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/tmdm-server-se/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/tmdm-server-se/teams","hooks_url":"https://api.github.com/repos/Talend/tmdm-server-se/hooks","issue_events_url":"https://api.github.com/repos/Talend/tmdm-server-se/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/tmdm-server-se/events","assignees_url":"https://api.github.com/repos/Talend/tmdm-server-se/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/tmdm-server-se/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/tmdm-server-se/tags","blobs_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/tmdm-server-se/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/tmdm-server-se/languages","stargazers_url":"https://api.github.com/repos/Talend/tmdm-server-se/stargazers","contributors_url":"https://api.github.com/repos/Talend/tmdm-server-se/contributors","subscribers_url":"https://api.github.com/repos/Talend/tmdm-server-se/subscribers","subscription_url":"https://api.github.com/repos/Talend/tmdm-server-se/subscription","commits_url":"https://api.github.com/repos/Talend/tmdm-server-se/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/tmdm-server-se/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/tmdm-server-se/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/tmdm-server-se/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/tmdm-server-se/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/tmdm-server-se/merges","archive_url":"https://api.github.com/repos/Talend/tmdm-server-se/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/tmdm-server-se/downloads","issues_url":"https://api.github.com/repos/Talend/tmdm-server-se/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/tmdm-server-se/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/tmdm-server-se/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/tmdm-server-se/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/tmdm-server-se/labels{/name}","releases_url":"https://api.github.com/repos/Talend/tmdm-server-se/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/tmdm-server-se/deployments","created_at":"2014-06-22T13:45:55Z","updated_at":"2018-09-19T08:24:31Z","pushed_at":"2018-09-20T08:04:45Z","git_url":"git://github.com/Talend/tmdm-server-se.git","ssh_url":"git@github.com:Talend/tmdm-server-se.git","clone_url":"https://github.com/Talend/tmdm-server-se.git","svn_url":"https://github.com/Talend/tmdm-server-se","homepage":null,"size":209150,"stargazers_count":15,"watchers_count":15,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":7,"open_issues":5,"watchers":15,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"f39c9d09541b99e39c99027d5677301bab8f362b","user":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":21094730,"node_id":"MDEwOlJlcG9zaXRvcnkyMTA5NDczMA==","name":"tmdm-server-se","full_name":"Talend/tmdm-server-se","private":false,"owner":{"login":"Talend","id":459687,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1OTY4Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Talend/tmdm-server-se","description":null,"fork":false,"url":"https://api.github.com/repos/Talend/tmdm-server-se","forks_url":"https://api.github.com/repos/Talend/tmdm-server-se/forks","keys_url":"https://api.github.com/repos/Talend/tmdm-server-se/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/tmdm-server-se/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/tmdm-server-se/teams","hooks_url":"https://api.github.com/repos/Talend/tmdm-server-se/hooks","issue_events_url":"https://api.github.com/repos/Talend/tmdm-server-se/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/tmdm-server-se/events","assignees_url":"https://api.github.com/repos/Talend/tmdm-server-se/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/tmdm-server-se/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/tmdm-server-se/tags","blobs_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/tmdm-server-se/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/tmdm-server-se/languages","stargazers_url":"https://api.github.com/repos/Talend/tmdm-server-se/stargazers","contributors_url":"https://api.github.com/repos/Talend/tmdm-server-se/contributors","subscribers_url":"https://api.github.com/repos/Talend/tmdm-server-se/subscribers","subscription_url":"https://api.github.com/repos/Talend/tmdm-server-se/subscription","commits_url":"https://api.github.com/repos/Talend/tmdm-server-se/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/tmdm-server-se/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/tmdm-server-se/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/tmdm-server-se/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/tmdm-server-se/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/tmdm-server-se/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/tmdm-server-se/merges","archive_url":"https://api.github.com/repos/Talend/tmdm-server-se/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/tmdm-server-se/downloads","issues_url":"https://api.github.com/repos/Talend/tmdm-server-se/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/tmdm-server-se/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/tmdm-server-se/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/tmdm-server-se/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/tmdm-server-se/labels{/name}","releases_url":"https://api.github.com/repos/Talend/tmdm-server-se/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/tmdm-server-se/deployments","created_at":"2014-06-22T13:45:55Z","updated_at":"2018-09-19T08:24:31Z","pushed_at":"2018-09-20T08:04:45Z","git_url":"git://github.com/Talend/tmdm-server-se.git","ssh_url":"git@github.com:Talend/tmdm-server-se.git","clone_url":"https://github.com/Talend/tmdm-server-se.git","svn_url":"https://github.com/Talend/tmdm-server-se","homepage":null,"size":209150,"stargazers_count":15,"watchers_count":15,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":7,"open_issues":5,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/635"},"html":{"href":"https://github.com/Talend/tmdm-server-se/pull/635"},"issue":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/issues/635"},"comments":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/tmdm-server-se/statuses/e16aa4f404b4f1661c940b1d0bfbc2348a322825"}},"author_association":"NONE"}}
{"actor":{"display_login":"lpw82gf"}}