{"action":"created","comment":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments/208603564","pull_request_review_id":144446248,"id":208603564,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODYwMzU2NA==","diff_hunk":"@@ -1 +1 @@\n-../static/vendor/underscore-standalone.js\n\\ No newline at end of file\n+../../readthedocs/static/vendor/underscore-standalone.js","path":"media/javascript/underscore.js","position":3,"original_position":3,"commit_id":"1e0b3190006a3c0dbf203733bbf3888be6b0f72c","original_commit_id":"1e0b3190006a3c0dbf203733bbf3888be6b0f72c","user":{"login":"humitos","id":244656,"node_id":"MDQ6VXNlcjI0NDY1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/244656?v=4","gravatar_id":"","url":"https://api.github.com/users/humitos","html_url":"https://github.com/humitos","followers_url":"https://api.github.com/users/humitos/followers","following_url":"https://api.github.com/users/humitos/following{/other_user}","gists_url":"https://api.github.com/users/humitos/gists{/gist_id}","starred_url":"https://api.github.com/users/humitos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/humitos/subscriptions","organizations_url":"https://api.github.com/users/humitos/orgs","repos_url":"https://api.github.com/users/humitos/repos","events_url":"https://api.github.com/users/humitos/events{/privacy}","received_events_url":"https://api.github.com/users/humitos/received_events","type":"User","site_admin":false},"body":"I know that you just updated the path of the link, but why we are adding static files from our app into the media directory? Shouldn't this be served from the `STATICFILES_DIRS`?","created_at":"2018-08-08T14:30:38Z","updated_at":"2018-08-08T14:33:17Z","html_url":"https://github.com/rtfd/readthedocs.org/pull/4489#discussion_r208603564","pull_request_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4489","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments/208603564"},"html":{"href":"https://github.com/rtfd/readthedocs.org/pull/4489#discussion_r208603564"},"pull_request":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4489"}}},"pull_request":{"url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4489","id":206853432,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODUzNDMy","html_url":"https://github.com/rtfd/readthedocs.org/pull/4489","diff_url":"https://github.com/rtfd/readthedocs.org/pull/4489.diff","patch_url":"https://github.com/rtfd/readthedocs.org/pull/4489.patch","issue_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/4489","number":4489,"state":"open","locked":false,"title":"All static media is run through \"collectstatic\"","user":{"login":"davidfischer","id":185043,"node_id":"MDQ6VXNlcjE4NTA0Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/185043?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfischer","html_url":"https://github.com/davidfischer","followers_url":"https://api.github.com/users/davidfischer/followers","following_url":"https://api.github.com/users/davidfischer/following{/other_user}","gists_url":"https://api.github.com/users/davidfischer/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfischer/subscriptions","organizations_url":"https://api.github.com/users/davidfischer/orgs","repos_url":"https://api.github.com/users/davidfischer/repos","events_url":"https://api.github.com/users/davidfischer/events{/privacy}","received_events_url":"https://api.github.com/users/davidfischer/received_events","type":"User","site_admin":false},"body":"This changes how our static files are collected. Rather than `media/` being a directory where static files are served from and `collectstatic` writes to `media/static`, this turns the `media/` directory into just another entry in `STATICFILES_DIRS` and all static media is collected into a new directory `static/`.\r\n\r\nThis is a somewhat difficult PR to test thoroughly and it is possible that issues we don't anticipate might arise from it. It makes me a bit nervous to be honest. One challenge is that a lot of built documentation still uses `/media/` (eg. `/media/javascript/jquery/jquery-migrate-1.2.1.min.js`)","created_at":"2018-08-07T23:25:38Z","updated_at":"2018-08-08T14:33:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d0e08021bbae245bc34366bd1cdcd7d11849435","assignee":null,"assignees":[],"requested_reviewers":[{"login":"agjohnson","id":1140183,"node_id":"MDQ6VXNlcjExNDAxODM=","avatar_url":"https://avatars0.githubusercontent.com/u/1140183?v=4","gravatar_id":"","url":"https://api.github.com/users/agjohnson","html_url":"https://github.com/agjohnson","followers_url":"https://api.github.com/users/agjohnson/followers","following_url":"https://api.github.com/users/agjohnson/following{/other_user}","gists_url":"https://api.github.com/users/agjohnson/gists{/gist_id}","starred_url":"https://api.github.com/users/agjohnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agjohnson/subscriptions","organizations_url":"https://api.github.com/users/agjohnson/orgs","repos_url":"https://api.github.com/users/agjohnson/repos","events_url":"https://api.github.com/users/agjohnson/events{/privacy}","received_events_url":"https://api.github.com/users/agjohnson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4489/commits","review_comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4489/comments","review_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/4489/comments","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/1e0b3190006a3c0dbf203733bbf3888be6b0f72c","head":{"label":"rtfd:davidfischer/all-static-collectstatic","ref":"davidfischer/all-static-collectstatic","sha":"1e0b3190006a3c0dbf203733bbf3888be6b0f72c","user":{"login":"rtfd","id":366329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"repo":{"id":841835,"node_id":"MDEwOlJlcG9zaXRvcnk4NDE4MzU=","name":"readthedocs.org","full_name":"rtfd/readthedocs.org","owner":{"login":"rtfd","id":366329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtfd/readthedocs.org","description":"The source code that powers readthedocs.org","fork":false,"url":"https://api.github.com/repos/rtfd/readthedocs.org","forks_url":"https://api.github.com/repos/rtfd/readthedocs.org/forks","keys_url":"https://api.github.com/repos/rtfd/readthedocs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfd/readthedocs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfd/readthedocs.org/teams","hooks_url":"https://api.github.com/repos/rtfd/readthedocs.org/hooks","issue_events_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/events{/number}","events_url":"https://api.github.com/repos/rtfd/readthedocs.org/events","assignees_url":"https://api.github.com/repos/rtfd/readthedocs.org/assignees{/user}","branches_url":"https://api.github.com/repos/rtfd/readthedocs.org/branches{/branch}","tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/tags","blobs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfd/readthedocs.org/languages","stargazers_url":"https://api.github.com/repos/rtfd/readthedocs.org/stargazers","contributors_url":"https://api.github.com/repos/rtfd/readthedocs.org/contributors","subscribers_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscribers","subscription_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscription","commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfd/readthedocs.org/contents/{+path}","compare_url":"https://api.github.com/repos/rtfd/readthedocs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfd/readthedocs.org/merges","archive_url":"https://api.github.com/repos/rtfd/readthedocs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfd/readthedocs.org/downloads","issues_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues{/number}","pulls_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfd/readthedocs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfd/readthedocs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfd/readthedocs.org/labels{/name}","releases_url":"https://api.github.com/repos/rtfd/readthedocs.org/releases{/id}","deployments_url":"https://api.github.com/repos/rtfd/readthedocs.org/deployments","created_at":"2010-08-16T19:18:06Z","updated_at":"2018-08-08T13:02:17Z","pushed_at":"2018-08-08T13:27:49Z","git_url":"git://github.com/rtfd/readthedocs.org.git","ssh_url":"git@github.com:rtfd/readthedocs.org.git","clone_url":"https://github.com/rtfd/readthedocs.org.git","svn_url":"https://github.com/rtfd/readthedocs.org","homepage":"https://readthedocs.org/","size":51440,"stargazers_count":4538,"watchers_count":4538,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2444,"mirror_url":null,"archived":false,"open_issues_count":509,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2444,"open_issues":509,"watchers":4538,"default_branch":"master"}},"base":{"label":"rtfd:master","ref":"master","sha":"ae9a6d3c5a4a8844d8c743188258fb633bded96b","user":{"login":"rtfd","id":366329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"repo":{"id":841835,"node_id":"MDEwOlJlcG9zaXRvcnk4NDE4MzU=","name":"readthedocs.org","full_name":"rtfd/readthedocs.org","owner":{"login":"rtfd","id":366329,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjMyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/366329?v=4","gravatar_id":"","url":"https://api.github.com/users/rtfd","html_url":"https://github.com/rtfd","followers_url":"https://api.github.com/users/rtfd/followers","following_url":"https://api.github.com/users/rtfd/following{/other_user}","gists_url":"https://api.github.com/users/rtfd/gists{/gist_id}","starred_url":"https://api.github.com/users/rtfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtfd/subscriptions","organizations_url":"https://api.github.com/users/rtfd/orgs","repos_url":"https://api.github.com/users/rtfd/repos","events_url":"https://api.github.com/users/rtfd/events{/privacy}","received_events_url":"https://api.github.com/users/rtfd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rtfd/readthedocs.org","description":"The source code that powers readthedocs.org","fork":false,"url":"https://api.github.com/repos/rtfd/readthedocs.org","forks_url":"https://api.github.com/repos/rtfd/readthedocs.org/forks","keys_url":"https://api.github.com/repos/rtfd/readthedocs.org/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtfd/readthedocs.org/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtfd/readthedocs.org/teams","hooks_url":"https://api.github.com/repos/rtfd/readthedocs.org/hooks","issue_events_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/events{/number}","events_url":"https://api.github.com/repos/rtfd/readthedocs.org/events","assignees_url":"https://api.github.com/repos/rtfd/readthedocs.org/assignees{/user}","branches_url":"https://api.github.com/repos/rtfd/readthedocs.org/branches{/branch}","tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/tags","blobs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/{sha}","languages_url":"https://api.github.com/repos/rtfd/readthedocs.org/languages","stargazers_url":"https://api.github.com/repos/rtfd/readthedocs.org/stargazers","contributors_url":"https://api.github.com/repos/rtfd/readthedocs.org/contributors","subscribers_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscribers","subscription_url":"https://api.github.com/repos/rtfd/readthedocs.org/subscription","commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtfd/readthedocs.org/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtfd/readthedocs.org/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtfd/readthedocs.org/contents/{+path}","compare_url":"https://api.github.com/repos/rtfd/readthedocs.org/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtfd/readthedocs.org/merges","archive_url":"https://api.github.com/repos/rtfd/readthedocs.org/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtfd/readthedocs.org/downloads","issues_url":"https://api.github.com/repos/rtfd/readthedocs.org/issues{/number}","pulls_url":"https://api.github.com/repos/rtfd/readthedocs.org/pulls{/number}","milestones_url":"https://api.github.com/repos/rtfd/readthedocs.org/milestones{/number}","notifications_url":"https://api.github.com/repos/rtfd/readthedocs.org/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtfd/readthedocs.org/labels{/name}","releases_url":"https://api.github.com/repos/rtfd/readthedocs.org/releases{/id}","deployments_url":"https://api.github.com/repos/rtfd/readthedocs.org/deployments","created_at":"2010-08-16T19:18:06Z","updated_at":"2018-08-08T13:02:17Z","pushed_at":"2018-08-08T13:27:49Z","git_url":"git://github.com/rtfd/readthedocs.org.git","ssh_url":"git@github.com:rtfd/readthedocs.org.git","clone_url":"https://github.com/rtfd/readthedocs.org.git","svn_url":"https://github.com/rtfd/readthedocs.org","homepage":"https://readthedocs.org/","size":51440,"stargazers_count":4538,"watchers_count":4538,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2444,"mirror_url":null,"archived":false,"open_issues_count":509,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2444,"open_issues":509,"watchers":4538,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4489"},"html":{"href":"https://github.com/rtfd/readthedocs.org/pull/4489"},"issue":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/issues/4489"},"comments":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/issues/4489/comments"},"review_comments":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4489/comments"},"review_comment":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/pulls/4489/commits"},"statuses":{"href":"https://api.github.com/repos/rtfd/readthedocs.org/statuses/1e0b3190006a3c0dbf203733bbf3888be6b0f72c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"humitos"}}