{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/5351","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5351/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5351/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5351/events","html_url":"https://github.com/WordPress/gutenberg/issues/5351","id":301726687,"number":5351,"title":"Grid empty space issue in Columns block","user":{"login":"samikeijonen","id":1820415,"avatar_url":"https://avatars3.githubusercontent.com/u/1820415?v=4","gravatar_id":"","url":"https://api.github.com/users/samikeijonen","html_url":"https://github.com/samikeijonen","followers_url":"https://api.github.com/users/samikeijonen/followers","following_url":"https://api.github.com/users/samikeijonen/following{/other_user}","gists_url":"https://api.github.com/users/samikeijonen/gists{/gist_id}","starred_url":"https://api.github.com/users/samikeijonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samikeijonen/subscriptions","organizations_url":"https://api.github.com/users/samikeijonen/orgs","repos_url":"https://api.github.com/users/samikeijonen/repos","events_url":"https://api.github.com/users/samikeijonen/events{/privacy}","received_events_url":"https://api.github.com/users/samikeijonen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-02T10:49:40Z","updated_at":"2018-03-02T11:07:59Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"## Issue Overview\r\nColumns block have this CSS Grid:\r\n\r\n```css\r\n.wp-block-columns {\r\n\tdisplay: grid;\r\n\tgrid-auto-flow: dense;\r\n\r\n\t@for $i from 2 through 6 {\r\n\t\t&.has-#{ $i }-columns {\r\n\t\t\tgrid-auto-columns: #{ 100% / $i };\r\n\t\t}\r\n\t}\r\n\r\n\t@for $i from 1 through 6 {\r\n\t\t.layout-column-#{ $i } {\r\n\t\t\tgrid-column: #{ $i };\r\n\t\t}\r\n\t}\r\n}\r\n```\r\n\r\nThis can result to this kind of layout with lot's of empty spaces:\r\n\r\n<img width=\"711\" alt=\"Grid layout have empty space here and there\" src=\"https://user-images.githubusercontent.com/1820415/36895320-2f5be836-1e17-11e8-9083-e8756c9cc881.png\">\r\n\r\nI'm all for using CSS Grid but we might need add extra `<div>` wrapper around columns."},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/369893043","html_url":"https://github.com/WordPress/gutenberg/issues/5351#issuecomment-369893043","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/5351","id":369893043,"user":{"login":"samikeijonen","id":1820415,"avatar_url":"https://avatars3.githubusercontent.com/u/1820415?v=4","gravatar_id":"","url":"https://api.github.com/users/samikeijonen","html_url":"https://github.com/samikeijonen","followers_url":"https://api.github.com/users/samikeijonen/followers","following_url":"https://api.github.com/users/samikeijonen/following{/other_user}","gists_url":"https://api.github.com/users/samikeijonen/gists{/gist_id}","starred_url":"https://api.github.com/users/samikeijonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samikeijonen/subscriptions","organizations_url":"https://api.github.com/users/samikeijonen/orgs","repos_url":"https://api.github.com/users/samikeijonen/repos","events_url":"https://api.github.com/users/samikeijonen/events{/privacy}","received_events_url":"https://api.github.com/users/samikeijonen/received_events","type":"User","site_admin":false},"created_at":"2018-03-02T11:07:59Z","updated_at":"2018-03-02T11:07:59Z","author_association":"CONTRIBUTOR","body":"Two columns block with three blocks inside each column. \r\n\r\nIn the editor markup is like this:\r\n\r\n```html\r\n<div class=\"wp-block-columns has-2-columns\">\r\n   <div class=\"layout-column-1\">...</div>\r\n   <div class=\"layout-column-2\">...</div>\r\n</div>\r\n```\r\nBut in the front-end columns are not wrapper in their own `<div>`."}}
{"actor":{"display_login":"samikeijonen"}}