{"action":"created","issue":{"url":"https://api.github.com/repos/pnpm/pnpm/issues/1132","repository_url":"https://api.github.com/repos/pnpm/pnpm","labels_url":"https://api.github.com/repos/pnpm/pnpm/issues/1132/labels{/name}","comments_url":"https://api.github.com/repos/pnpm/pnpm/issues/1132/comments","events_url":"https://api.github.com/repos/pnpm/pnpm/issues/1132/events","html_url":"https://github.com/pnpm/pnpm/issues/1132","id":319764957,"number":1132,"title":"If the pnpm install gets corrupted, it should be an error not a warning","user":{"login":"pgonzal","id":4673363,"avatar_url":"https://avatars0.githubusercontent.com/u/4673363?v=4","gravatar_id":"","url":"https://api.github.com/users/pgonzal","html_url":"https://github.com/pgonzal","followers_url":"https://api.github.com/users/pgonzal/followers","following_url":"https://api.github.com/users/pgonzal/following{/other_user}","gists_url":"https://api.github.com/users/pgonzal/gists{/gist_id}","starred_url":"https://api.github.com/users/pgonzal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgonzal/subscriptions","organizations_url":"https://api.github.com/users/pgonzal/orgs","repos_url":"https://api.github.com/users/pgonzal/repos","events_url":"https://api.github.com/users/pgonzal/events{/privacy}","received_events_url":"https://api.github.com/users/pgonzal/received_events","type":"User","site_admin":false},"labels":[{"id":317843349,"url":"https://api.github.com/repos/pnpm/pnpm/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-03T01:45:26Z","updated_at":"2018-05-03T18:59:55Z","closed_at":null,"author_association":"NONE","body":"<!--\r\n**Please only file bugs/feature requests for pnpm here.**\r\n\r\nIf you have a question that is not answered in the FAQ section of the README\r\nthen it is best to post your question on StackOverflow under the pnpm tag:\r\nhttps://stackoverflow.com/questions/tagged/pnpm\r\nor ask it in our Gitter chatroom:\r\nhttps://gitter.im/pnpm/pnpm\r\n\r\nIf your issue is a bug, please follow the format below:\r\n-->\r\n\r\n### pnpm version: 1.41.2\r\n\r\n### Code to reproduce the issue:\r\n\r\nOn our CI machines we've been seeing occasional errors like this:\r\n\r\n```\r\n2018-04-30T22:22:10.5694107Z Resolving: total 2303, reused 2171, downloaded 131\r\n2018-04-30T22:22:11.5688415Z Resolving: total 2303, reused 2171, downloaded 131\r\n2018-04-30T22:22:12.5694198Z Resolving: total 2303, reused 2171, downloaded 132\r\n2018-04-30T22:22:13.1194664Z WARN  There's a directory in node_modules without package.json: C:\\agent\\2\\_work\\14\\s\\common\\temp\\node_modules\\.onedrive.pkgs.visualstudio.com\\react-slick\\0.23.1\\react-dom@15.6.2+react@15.6.2\\node_modules\\react-dom\r\n2018-04-30T22:22:13.3256519Z WARN  There's a directory in node_modules without package.json: C:\\agent\\2\\_work\\14\\s\\common\\temp\\node_modules\\.onedrive.pkgs.visualstudio.com\\react-addons-test-utils\\15.4.2\\react-dom@15.6.2\\node_modules\\react-dom\r\n```\r\n\r\nThis error happens even after deleting the `node_modules` folder, but seems to go away if we delete the PNPM store folder.  I suspect it may occur when the installation is forcibly terminated, e.g. because a PR build was canceled because an update was pushed to the Git branch.  (So far I haven't proven that this is actually PNPM's fault; if I do I will open a separate GitHub issue.)\r\n\r\n\r\n<!--\r\nIf there was a fatal error also include a gist of your pnpm-debug.log file.\r\n-->\r\n\r\n### Expected behavior:\r\n\r\nWhen this corruption is detected, the PNPM install should fail with a nonzero exit code.\r\n\r\n### Actual behavior:\r\n\r\nPNPM prints a warning and appears to succeed.  The resulting node_modules folder has broken symlinks.\r\n\r\n### Additional information:\r\n\r\n - `node -v` prints: 8.9.4\r\n - Windows, OS X, or Linux?: Windows\r\n"},"comment":{"url":"https://api.github.com/repos/pnpm/pnpm/issues/comments/386401913","html_url":"https://github.com/pnpm/pnpm/issues/1132#issuecomment-386401913","issue_url":"https://api.github.com/repos/pnpm/pnpm/issues/1132","id":386401913,"user":{"login":"pgonzal","id":4673363,"avatar_url":"https://avatars0.githubusercontent.com/u/4673363?v=4","gravatar_id":"","url":"https://api.github.com/users/pgonzal","html_url":"https://github.com/pgonzal","followers_url":"https://api.github.com/users/pgonzal/followers","following_url":"https://api.github.com/users/pgonzal/following{/other_user}","gists_url":"https://api.github.com/users/pgonzal/gists{/gist_id}","starred_url":"https://api.github.com/users/pgonzal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgonzal/subscriptions","organizations_url":"https://api.github.com/users/pgonzal/orgs","repos_url":"https://api.github.com/users/pgonzal/repos","events_url":"https://api.github.com/users/pgonzal/events{/privacy}","received_events_url":"https://api.github.com/users/pgonzal/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T18:59:55Z","updated_at":"2018-05-03T18:59:55Z","author_association":"NONE","body":"I found a deterministic repro for the `There's a directory in node_modules without package.json` error.  I've opened  [issue 1133](https://github.com/pnpm/pnpm/issues/1133)."}}
{"actor":{"display_login":"pgonzal"}}