{"action":"created","comment":{"url":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/comments/217255283","pull_request_review_id":154922849,"id":217255283,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzI1NTI4Mw==","diff_hunk":"@@ -38,6 +38,6 @@ <h1>CreateDataPropertyOnObject Functions</h1>\n     1. Assert: Type(_O_) is Object.\n     1. Assert: _O_ is an extensible ordinary object.\n     1. Let _propertyKey_ be ? ToPropertyKey(_key_).\n-    1. Perform ? CreateDataPropertyOrThrow(_O_, _propertyKey_, _value_).\n+    1. Perform ! CreateDataPropertyOrThrow(_O_, _propertyKey_, _value_).","path":"spec.html","position":5,"original_position":5,"commit_id":"61b5682e26e5cf832822397af7ae5816fb792a97","original_commit_id":"61b5682e26e5cf832822397af7ae5816fb792a97","user":{"login":"ljharb","id":45469,"node_id":"MDQ6VXNlcjQ1NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/45469?v=4","gravatar_id":"","url":"https://api.github.com/users/ljharb","html_url":"https://github.com/ljharb","followers_url":"https://api.github.com/users/ljharb/followers","following_url":"https://api.github.com/users/ljharb/following{/other_user}","gists_url":"https://api.github.com/users/ljharb/gists{/gist_id}","starred_url":"https://api.github.com/users/ljharb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljharb/subscriptions","organizations_url":"https://api.github.com/users/ljharb/orgs","repos_url":"https://api.github.com/users/ljharb/repos","events_url":"https://api.github.com/users/ljharb/events{/privacy}","received_events_url":"https://api.github.com/users/ljharb/received_events","type":"User","site_admin":false},"body":"Yes, that can return false - the combo of OrThrow and ! ensures it can never throw; otherwise we’d have to assert that the operation result was true.","created_at":"2018-09-13T04:10:16Z","updated_at":"2018-09-13T04:10:16Z","html_url":"https://github.com/tc39/proposal-object-from-entries/pull/25#discussion_r217255283","pull_request_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/comments/217255283"},"html":{"href":"https://github.com/tc39/proposal-object-from-entries/pull/25#discussion_r217255283"},"pull_request":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/25"}},"in_reply_to_id":217254972},"pull_request":{"url":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/25","id":215090218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDkwMjE4","html_url":"https://github.com/tc39/proposal-object-from-entries/pull/25","diff_url":"https://github.com/tc39/proposal-object-from-entries/pull/25.diff","patch_url":"https://github.com/tc39/proposal-object-from-entries/pull/25.patch","issue_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues/25","number":25,"state":"closed","locked":false,"title":"Editorial: ? -> !","user":{"login":"bakkot","id":1653598,"node_id":"MDQ6VXNlcjE2NTM1OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1653598?v=4","gravatar_id":"","url":"https://api.github.com/users/bakkot","html_url":"https://github.com/bakkot","followers_url":"https://api.github.com/users/bakkot/followers","following_url":"https://api.github.com/users/bakkot/following{/other_user}","gists_url":"https://api.github.com/users/bakkot/gists{/gist_id}","starred_url":"https://api.github.com/users/bakkot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakkot/subscriptions","organizations_url":"https://api.github.com/users/bakkot/orgs","repos_url":"https://api.github.com/users/bakkot/repos","events_url":"https://api.github.com/users/bakkot/events{/privacy}","received_events_url":"https://api.github.com/users/bakkot/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-12T20:43:46Z","updated_at":"2018-09-13T04:10:16Z","closed_at":"2018-09-12T20:57:32Z","merged_at":"2018-09-12T20:57:32Z","merge_commit_sha":"0ea28e788dffea10f261fa4d4c9dfa9911f3a462","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/25/commits","review_comments_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/25/comments","review_comment_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues/25/comments","statuses_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/statuses/61b5682e26e5cf832822397af7ae5816fb792a97","head":{"label":"tc39:bang","ref":"bang","sha":"61b5682e26e5cf832822397af7ae5816fb792a97","user":{"login":"tc39","id":1725583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjU1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":99521747,"node_id":"MDEwOlJlcG9zaXRvcnk5OTUyMTc0Nw==","name":"proposal-object-from-entries","full_name":"tc39/proposal-object-from-entries","owner":{"login":"tc39","id":1725583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjU1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/proposal-object-from-entries","description":"TC39 proposal for Object.fromEntries","fork":false,"url":"https://api.github.com/repos/tc39/proposal-object-from-entries","forks_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/forks","keys_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/teams","hooks_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/hooks","issue_events_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/events","assignees_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/tags","blobs_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/languages","stargazers_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/stargazers","contributors_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/contributors","subscribers_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/subscribers","subscription_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/subscription","commits_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/merges","archive_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/downloads","issues_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/labels{/name}","releases_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/deployments","created_at":"2017-08-07T00:35:30Z","updated_at":"2018-09-12T20:57:34Z","pushed_at":"2018-09-12T20:57:36Z","git_url":"git://github.com/tc39/proposal-object-from-entries.git","ssh_url":"git@github.com:tc39/proposal-object-from-entries.git","clone_url":"https://github.com/tc39/proposal-object-from-entries.git","svn_url":"https://github.com/tc39/proposal-object-from-entries","homepage":"https://tc39.github.io/proposal-object-from-entries/","size":69,"stargazers_count":252,"watchers_count":252,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":1,"watchers":252,"default_branch":"master"}},"base":{"label":"tc39:master","ref":"master","sha":"629c00870d6b456c351866b5bbcb47b9b51037ac","user":{"login":"tc39","id":1725583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjU1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"repo":{"id":99521747,"node_id":"MDEwOlJlcG9zaXRvcnk5OTUyMTc0Nw==","name":"proposal-object-from-entries","full_name":"tc39/proposal-object-from-entries","owner":{"login":"tc39","id":1725583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjU1ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1725583?v=4","gravatar_id":"","url":"https://api.github.com/users/tc39","html_url":"https://github.com/tc39","followers_url":"https://api.github.com/users/tc39/followers","following_url":"https://api.github.com/users/tc39/following{/other_user}","gists_url":"https://api.github.com/users/tc39/gists{/gist_id}","starred_url":"https://api.github.com/users/tc39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tc39/subscriptions","organizations_url":"https://api.github.com/users/tc39/orgs","repos_url":"https://api.github.com/users/tc39/repos","events_url":"https://api.github.com/users/tc39/events{/privacy}","received_events_url":"https://api.github.com/users/tc39/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tc39/proposal-object-from-entries","description":"TC39 proposal for Object.fromEntries","fork":false,"url":"https://api.github.com/repos/tc39/proposal-object-from-entries","forks_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/forks","keys_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/teams","hooks_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/hooks","issue_events_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues/events{/number}","events_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/events","assignees_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/assignees{/user}","branches_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/branches{/branch}","tags_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/tags","blobs_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/refs{/sha}","trees_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/statuses/{sha}","languages_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/languages","stargazers_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/stargazers","contributors_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/contributors","subscribers_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/subscribers","subscription_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/subscription","commits_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/commits{/sha}","git_commits_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/git/commits{/sha}","comments_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/comments{/number}","issue_comment_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues/comments{/number}","contents_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/contents/{+path}","compare_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/merges","archive_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/downloads","issues_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues{/number}","pulls_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls{/number}","milestones_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/milestones{/number}","notifications_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/labels{/name}","releases_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/releases{/id}","deployments_url":"https://api.github.com/repos/tc39/proposal-object-from-entries/deployments","created_at":"2017-08-07T00:35:30Z","updated_at":"2018-09-12T20:57:34Z","pushed_at":"2018-09-12T20:57:36Z","git_url":"git://github.com/tc39/proposal-object-from-entries.git","ssh_url":"git@github.com:tc39/proposal-object-from-entries.git","clone_url":"https://github.com/tc39/proposal-object-from-entries.git","svn_url":"https://github.com/tc39/proposal-object-from-entries","homepage":"https://tc39.github.io/proposal-object-from-entries/","size":69,"stargazers_count":252,"watchers_count":252,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":1,"watchers":252,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/25"},"html":{"href":"https://github.com/tc39/proposal-object-from-entries/pull/25"},"issue":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues/25"},"comments":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/tc39/proposal-object-from-entries/statuses/61b5682e26e5cf832822397af7ae5816fb792a97"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ljharb"}}