{"action":"created","comment":{"url":"https://api.github.com/repos/ca-cwds/intake/pulls/comments/196502912","pull_request_review_id":130067931,"id":196502912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjUwMjkxMg==","diff_hunk":"@@ -205,9 +205,9 @@ export const getAllPersonFormattedAddressesSelector = (state, personId) => (\n         city: address.get('city'),\n         state: formattedState(address.get('state')),\n         zip: address.get('zip'),\n-        zipError: address.get('legacy_id') ? null : getZIPErrors(address.get('zip')),\n+        zipError: address.get(['legacy_descriptor', 'legacy_id']) ? null : getZIPErrors(address.get('zip')),\n         type: address.get('type'),\n-        legacy_id: address.get('legacy_id'),\n+        legacy_id: address.getIn(['legacy_descriptor', 'legacy_id']),","path":"app/javascript/selectors/screening/personShowSelectors.js","position":8,"original_position":8,"commit_id":"a308101b2de07777f221da204ee827aef709b7b1","original_commit_id":"1f4d27676010b76d22b98795904d5635600f32ca","user":{"login":"NagaPradeepGajula-osi","id":30534102,"node_id":"MDQ6VXNlcjMwNTM0MTAy","avatar_url":"https://avatars3.githubusercontent.com/u/30534102?v=4","gravatar_id":"","url":"https://api.github.com/users/NagaPradeepGajula-osi","html_url":"https://github.com/NagaPradeepGajula-osi","followers_url":"https://api.github.com/users/NagaPradeepGajula-osi/followers","following_url":"https://api.github.com/users/NagaPradeepGajula-osi/following{/other_user}","gists_url":"https://api.github.com/users/NagaPradeepGajula-osi/gists{/gist_id}","starred_url":"https://api.github.com/users/NagaPradeepGajula-osi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NagaPradeepGajula-osi/subscriptions","organizations_url":"https://api.github.com/users/NagaPradeepGajula-osi/orgs","repos_url":"https://api.github.com/users/NagaPradeepGajula-osi/repos","events_url":"https://api.github.com/users/NagaPradeepGajula-osi/events{/privacy}","received_events_url":"https://api.github.com/users/NagaPradeepGajula-osi/received_events","type":"User","site_admin":false},"body":"can we use the get() here as of others as its much cheaper than getIn().","created_at":"2018-06-19T16:55:41Z","updated_at":"2018-06-19T16:59:21Z","html_url":"https://github.com/ca-cwds/intake/pull/725#discussion_r196502912","pull_request_url":"https://api.github.com/repos/ca-cwds/intake/pulls/725","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ca-cwds/intake/pulls/comments/196502912"},"html":{"href":"https://github.com/ca-cwds/intake/pull/725#discussion_r196502912"},"pull_request":{"href":"https://api.github.com/repos/ca-cwds/intake/pulls/725"}}},"pull_request":{"url":"https://api.github.com/repos/ca-cwds/intake/pulls/725","id":195667649,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjY3NjQ5","html_url":"https://github.com/ca-cwds/intake/pull/725","diff_url":"https://github.com/ca-cwds/intake/pull/725.diff","patch_url":"https://github.com/ca-cwds/intake/pull/725.patch","issue_url":"https://api.github.com/repos/ca-cwds/intake/issues/725","number":725,"state":"open","locked":false,"title":"HOT 2035 Point Intake to Ferb Participants Create","user":{"login":"TylerOSI","id":33132169,"node_id":"MDQ6VXNlcjMzMTMyMTY5","avatar_url":"https://avatars3.githubusercontent.com/u/33132169?v=4","gravatar_id":"","url":"https://api.github.com/users/TylerOSI","html_url":"https://github.com/TylerOSI","followers_url":"https://api.github.com/users/TylerOSI/followers","following_url":"https://api.github.com/users/TylerOSI/following{/other_user}","gists_url":"https://api.github.com/users/TylerOSI/gists{/gist_id}","starred_url":"https://api.github.com/users/TylerOSI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TylerOSI/subscriptions","organizations_url":"https://api.github.com/users/TylerOSI/orgs","repos_url":"https://api.github.com/users/TylerOSI/repos","events_url":"https://api.github.com/users/TylerOSI/events{/privacy}","received_events_url":"https://api.github.com/users/TylerOSI/received_events","type":"User","site_admin":false},"body":"### Jira Story\r\n\r\n- [Point Intake to Ferb for Participants Create HOT-2035](https://osi-cwds.atlassian.net/browse/HOT-2035)\r\n\r\n## Description\r\nIn our effort to move off of Intake API we are switching Intake to use Ferb for creating new participants and adding them based on legacy ID.\r\n\r\n## Tests\r\n- [x] I have included unit tests \r\n- [x] I have included feature tests \r\n- [ ] I have included other tests \r\n- [ ] I have NOT included tests \r\n<!--- Please indicate why tests were not added. -->\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Refactoring (No behavioral changes)\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] I have ran all tests for the project.\r\n- [x] I have ran lint/rubocop check for the changed/new files.\r\n- [x] My code is in a stable state ready to be deployable, but not necessarily complete.\r\n- [x] I promise on my honor as a CWDS developer to ensure I don't break the build, to check Lint/Rubocop, use best practices, to leave the code in better shape than I found it, and to have a good day.\r\n\r\n","created_at":"2018-06-18T22:39:05Z","updated_at":"2018-06-19T16:59:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5f0fd6ba0a6bf2715d76ff771a4430e14c6b6a0c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ca-cwds/intake/pulls/725/commits","review_comments_url":"https://api.github.com/repos/ca-cwds/intake/pulls/725/comments","review_comment_url":"https://api.github.com/repos/ca-cwds/intake/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ca-cwds/intake/issues/725/comments","statuses_url":"https://api.github.com/repos/ca-cwds/intake/statuses/a308101b2de07777f221da204ee827aef709b7b1","head":{"label":"ca-cwds:HOT-2035-point-intake-to-ferb-participants-create","ref":"HOT-2035-point-intake-to-ferb-participants-create","sha":"a308101b2de07777f221da204ee827aef709b7b1","user":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"repo":{"id":69582220,"node_id":"MDEwOlJlcG9zaXRvcnk2OTU4MjIyMA==","name":"intake","full_name":"ca-cwds/intake","owner":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ca-cwds/intake","description":"CWDS Intake Digital Service","fork":false,"url":"https://api.github.com/repos/ca-cwds/intake","forks_url":"https://api.github.com/repos/ca-cwds/intake/forks","keys_url":"https://api.github.com/repos/ca-cwds/intake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ca-cwds/intake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ca-cwds/intake/teams","hooks_url":"https://api.github.com/repos/ca-cwds/intake/hooks","issue_events_url":"https://api.github.com/repos/ca-cwds/intake/issues/events{/number}","events_url":"https://api.github.com/repos/ca-cwds/intake/events","assignees_url":"https://api.github.com/repos/ca-cwds/intake/assignees{/user}","branches_url":"https://api.github.com/repos/ca-cwds/intake/branches{/branch}","tags_url":"https://api.github.com/repos/ca-cwds/intake/tags","blobs_url":"https://api.github.com/repos/ca-cwds/intake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ca-cwds/intake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ca-cwds/intake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ca-cwds/intake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ca-cwds/intake/statuses/{sha}","languages_url":"https://api.github.com/repos/ca-cwds/intake/languages","stargazers_url":"https://api.github.com/repos/ca-cwds/intake/stargazers","contributors_url":"https://api.github.com/repos/ca-cwds/intake/contributors","subscribers_url":"https://api.github.com/repos/ca-cwds/intake/subscribers","subscription_url":"https://api.github.com/repos/ca-cwds/intake/subscription","commits_url":"https://api.github.com/repos/ca-cwds/intake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ca-cwds/intake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ca-cwds/intake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ca-cwds/intake/issues/comments{/number}","contents_url":"https://api.github.com/repos/ca-cwds/intake/contents/{+path}","compare_url":"https://api.github.com/repos/ca-cwds/intake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ca-cwds/intake/merges","archive_url":"https://api.github.com/repos/ca-cwds/intake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ca-cwds/intake/downloads","issues_url":"https://api.github.com/repos/ca-cwds/intake/issues{/number}","pulls_url":"https://api.github.com/repos/ca-cwds/intake/pulls{/number}","milestones_url":"https://api.github.com/repos/ca-cwds/intake/milestones{/number}","notifications_url":"https://api.github.com/repos/ca-cwds/intake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ca-cwds/intake/labels{/name}","releases_url":"https://api.github.com/repos/ca-cwds/intake/releases{/id}","deployments_url":"https://api.github.com/repos/ca-cwds/intake/deployments","created_at":"2016-09-29T15:42:09Z","updated_at":"2018-06-18T20:28:59Z","pushed_at":"2018-06-19T16:20:49Z","git_url":"git://github.com/ca-cwds/intake.git","ssh_url":"git@github.com:ca-cwds/intake.git","clone_url":"https://github.com/ca-cwds/intake.git","svn_url":"https://github.com/ca-cwds/intake","homepage":"","size":8076,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":2,"open_issues":6,"watchers":22,"default_branch":"master"}},"base":{"label":"ca-cwds:master","ref":"master","sha":"dc9b75280a4018baedb227ab3b0deb1eeb7ebed6","user":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"repo":{"id":69582220,"node_id":"MDEwOlJlcG9zaXRvcnk2OTU4MjIyMA==","name":"intake","full_name":"ca-cwds/intake","owner":{"login":"ca-cwds","id":16274270,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjc0Mjcw","avatar_url":"https://avatars3.githubusercontent.com/u/16274270?v=4","gravatar_id":"","url":"https://api.github.com/users/ca-cwds","html_url":"https://github.com/ca-cwds","followers_url":"https://api.github.com/users/ca-cwds/followers","following_url":"https://api.github.com/users/ca-cwds/following{/other_user}","gists_url":"https://api.github.com/users/ca-cwds/gists{/gist_id}","starred_url":"https://api.github.com/users/ca-cwds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ca-cwds/subscriptions","organizations_url":"https://api.github.com/users/ca-cwds/orgs","repos_url":"https://api.github.com/users/ca-cwds/repos","events_url":"https://api.github.com/users/ca-cwds/events{/privacy}","received_events_url":"https://api.github.com/users/ca-cwds/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ca-cwds/intake","description":"CWDS Intake Digital Service","fork":false,"url":"https://api.github.com/repos/ca-cwds/intake","forks_url":"https://api.github.com/repos/ca-cwds/intake/forks","keys_url":"https://api.github.com/repos/ca-cwds/intake/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ca-cwds/intake/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ca-cwds/intake/teams","hooks_url":"https://api.github.com/repos/ca-cwds/intake/hooks","issue_events_url":"https://api.github.com/repos/ca-cwds/intake/issues/events{/number}","events_url":"https://api.github.com/repos/ca-cwds/intake/events","assignees_url":"https://api.github.com/repos/ca-cwds/intake/assignees{/user}","branches_url":"https://api.github.com/repos/ca-cwds/intake/branches{/branch}","tags_url":"https://api.github.com/repos/ca-cwds/intake/tags","blobs_url":"https://api.github.com/repos/ca-cwds/intake/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ca-cwds/intake/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ca-cwds/intake/git/refs{/sha}","trees_url":"https://api.github.com/repos/ca-cwds/intake/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ca-cwds/intake/statuses/{sha}","languages_url":"https://api.github.com/repos/ca-cwds/intake/languages","stargazers_url":"https://api.github.com/repos/ca-cwds/intake/stargazers","contributors_url":"https://api.github.com/repos/ca-cwds/intake/contributors","subscribers_url":"https://api.github.com/repos/ca-cwds/intake/subscribers","subscription_url":"https://api.github.com/repos/ca-cwds/intake/subscription","commits_url":"https://api.github.com/repos/ca-cwds/intake/commits{/sha}","git_commits_url":"https://api.github.com/repos/ca-cwds/intake/git/commits{/sha}","comments_url":"https://api.github.com/repos/ca-cwds/intake/comments{/number}","issue_comment_url":"https://api.github.com/repos/ca-cwds/intake/issues/comments{/number}","contents_url":"https://api.github.com/repos/ca-cwds/intake/contents/{+path}","compare_url":"https://api.github.com/repos/ca-cwds/intake/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ca-cwds/intake/merges","archive_url":"https://api.github.com/repos/ca-cwds/intake/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ca-cwds/intake/downloads","issues_url":"https://api.github.com/repos/ca-cwds/intake/issues{/number}","pulls_url":"https://api.github.com/repos/ca-cwds/intake/pulls{/number}","milestones_url":"https://api.github.com/repos/ca-cwds/intake/milestones{/number}","notifications_url":"https://api.github.com/repos/ca-cwds/intake/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ca-cwds/intake/labels{/name}","releases_url":"https://api.github.com/repos/ca-cwds/intake/releases{/id}","deployments_url":"https://api.github.com/repos/ca-cwds/intake/deployments","created_at":"2016-09-29T15:42:09Z","updated_at":"2018-06-18T20:28:59Z","pushed_at":"2018-06-19T16:20:49Z","git_url":"git://github.com/ca-cwds/intake.git","ssh_url":"git@github.com:ca-cwds/intake.git","clone_url":"https://github.com/ca-cwds/intake.git","svn_url":"https://github.com/ca-cwds/intake","homepage":"","size":8076,"stargazers_count":22,"watchers_count":22,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":2,"open_issues":6,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ca-cwds/intake/pulls/725"},"html":{"href":"https://github.com/ca-cwds/intake/pull/725"},"issue":{"href":"https://api.github.com/repos/ca-cwds/intake/issues/725"},"comments":{"href":"https://api.github.com/repos/ca-cwds/intake/issues/725/comments"},"review_comments":{"href":"https://api.github.com/repos/ca-cwds/intake/pulls/725/comments"},"review_comment":{"href":"https://api.github.com/repos/ca-cwds/intake/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ca-cwds/intake/pulls/725/commits"},"statuses":{"href":"https://api.github.com/repos/ca-cwds/intake/statuses/a308101b2de07777f221da204ee827aef709b7b1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"NagaPradeepGajula-osi"}}