{"action":"created","comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/241598277","pull_request_review_id":184914340,"id":241598277,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTU5ODI3Nw==","diff_hunk":"@@ -139,25 +139,29 @@\n   </Target>\n \n   <Target Name=\"CreatePackNupkg\">\n+    <PropertyGroup>\n+      <!-- Build from source can't use ILMerge. -->\n+      <ILMergeSubpath Condition=\"'$(DotNetBuildFromSource)' != 'true'\">ilmerge\\</ILMergeSubpath>\n+    </PropertyGroup>\n     <ItemGroup Condition=\"'$(TargetFramework)' == '$(NETFXTargetFramework)' AND '$(IsBuildOnlyXPLATProjects)' != 'true'\">\n-      <TfmSpecificPackageFile Include=\"$(OutputPath)\\ilmerge\\NuGet.Build.Tasks.Pack.dll\">\n+      <TfmSpecificPackageFile Include=\"$(OutputPath)\\$(ILMergeSubpath)NuGet.Build.Tasks.Pack.dll\">\n         <PackagePath>Desktop/</PackagePath>\n       </TfmSpecificPackageFile>\n-      <TfmSpecificPackageFile Include=\"$(OutputPath)\\ilmerge\\NuGet.Build.Tasks.Pack.xml\">\n+      <TfmSpecificPackageFile Include=\"$(OutputPath)\\$(ILMergeSubpath)NuGet.Build.Tasks.Pack.xml\">\n         <PackagePath>Desktop/</PackagePath>\n       </TfmSpecificPackageFile>\n-      <TfmSpecificPackageFile Include=\"$(OutputPath)\\ilmerge\\**\\NuGet*.resources.dll\">\n+      <TfmSpecificPackageFile Include=\"$(OutputPath)\\$(ILMergeSubpath)**\\NuGet*.resources.dll\">\n         <PackagePath>Desktop/</PackagePath>\n       </TfmSpecificPackageFile>\n     </ItemGroup>\n     <ItemGroup Condition=\"'$(TargetFramework)' == '$(NetStandardVersion)'\">\n-      <TfmSpecificPackageFile Include=\"$(OutputPath)\\ilmerge\\NuGet.Build.Tasks.Pack.dll\">\n+      <TfmSpecificPackageFile Include=\"$(OutputPath)\\$(ILMergeSubpath)NuGet.Build.Tasks.Pack.dll\">\n         <PackagePath>CoreCLR/</PackagePath>\n       </TfmSpecificPackageFile>\n-      <TfmSpecificPackageFile Include=\"$(OutputPath)\\ilmerge\\NuGet.Build.Tasks.Pack.xml\">\n+      <TfmSpecificPackageFile Include=\"$(OutputPath)\\$(ILMergeSubpath)NuGet.Build.Tasks.Pack.xml\">\n         <PackagePath>CoreCLR/</PackagePath>\n       </TfmSpecificPackageFile>\n-      <TfmSpecificPackageFile Include=\"$(OutputPath)\\ilmerge\\**\\NuGet*.resources.dll\">\n+      <TfmSpecificPackageFile Include=\"$(OutputPath)\\$(ILMergeSubpath)**\\NuGet*.resources.dll\">","path":"src/NuGet.Core/NuGet.Build.Tasks.Pack/NuGet.Build.Tasks.Pack.csproj","position":32,"original_position":32,"commit_id":"381457376cd4409ef6a6b923649dd412284cad79","original_commit_id":"f5a1c06f8627c19b2fb44c0e7255ae557bc8b3fa","user":{"login":"nkolev92","id":2878341,"node_id":"MDQ6VXNlcjI4NzgzNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/2878341?v=4","gravatar_id":"","url":"https://api.github.com/users/nkolev92","html_url":"https://github.com/nkolev92","followers_url":"https://api.github.com/users/nkolev92/followers","following_url":"https://api.github.com/users/nkolev92/following{/other_user}","gists_url":"https://api.github.com/users/nkolev92/gists{/gist_id}","starred_url":"https://api.github.com/users/nkolev92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkolev92/subscriptions","organizations_url":"https://api.github.com/users/nkolev92/orgs","repos_url":"https://api.github.com/users/nkolev92/repos","events_url":"https://api.github.com/users/nkolev92/events{/privacy}","received_events_url":"https://api.github.com/users/nkolev92/received_events","type":"User","site_admin":false},"body":"@dagood\r\nI don't have a problem with either fixing it in this or a separate PR, it's just something that needs done to call NuGet source-build happy again :) ","created_at":"2018-12-13T23:23:15Z","updated_at":"2018-12-13T23:23:15Z","html_url":"https://github.com/NuGet/NuGet.Client/pull/2560#discussion_r241598277","pull_request_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2560","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments/241598277"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/2560#discussion_r241598277"},"pull_request":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2560"}},"in_reply_to_id":241231855},"pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2560","id":237755049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NzU1MDQ5","html_url":"https://github.com/NuGet/NuGet.Client/pull/2560","diff_url":"https://github.com/NuGet/NuGet.Client/pull/2560.diff","patch_url":"https://github.com/NuGet/NuGet.Client/pull/2560.patch","issue_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2560","number":2560,"state":"open","locked":false,"title":"Fix xplat build from source: don't assume ILMerge was used","user":{"login":"dagood","id":12819531,"node_id":"MDQ6VXNlcjEyODE5NTMx","avatar_url":"https://avatars3.githubusercontent.com/u/12819531?v=4","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"body":"## Bug\r\nFixes: N/A\r\nRegression: Yes\r\nIf Regression then when did it last work: 25225bb1b55bc17e52cb6fa02335d559c12ccd18\r\nIf Regression then how are we preventing it in future: Not feasible yet, but source-build CI leg described in https://github.com/dotnet/source-build/issues/379 will probably do it.\r\n\r\nThe issue is that PR https://github.com/NuGet/NuGet.Client/pull/2405 didn't carry over the right xplat build behavior. Build from source can't use ILMerge, but the paths in `NuGet.Build.Tasks.Pack.csproj` assume the output is ILMerged. When xplat pack happens, the build fails.\r\n\r\nEncountered when I tried to update the source-build nuget-client submodule to the commit used in the .NET Core 3.0 preview build.\r\n\r\n## Fix\r\nOnly use ILMerge paths when `DotNetBuildFromSource != true`. It would also be fine to use `IsBuildOnlyXPLATProjects`. `DotNetBuildFromSource` seems more precise (in theory someone could build only xplat projects but still use ILMerge?), but let me know.\r\n\r\nThis fix is going in a source-build patch to make this repo work at the specific commit used for .NET Core 3.0 preview. But as usual, removing patches is a priority for us. @rrelyea as the NuGet source-build champion can you make sure this PR gets traction?\r\n\r\n## Testing/Validation\r\nTests Added: No\r\nReason for not adding tests: Don't know if this is testable.\r\nValidation done: Ran in source-build context. I haven't checked non-source-build behavior.","created_at":"2018-12-11T16:58:08Z","updated_at":"2018-12-13T23:23:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9a54fea5f8c0e57d4e432a131a4bf548ff43fd3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2560/commits","review_comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2560/comments","review_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2560/comments","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/381457376cd4409ef6a6b923649dd412284cad79","head":{"label":"dagood:fix-xplat-no-ilmerge","ref":"fix-xplat-no-ilmerge","sha":"381457376cd4409ef6a6b923649dd412284cad79","user":{"login":"dagood","id":12819531,"node_id":"MDQ6VXNlcjEyODE5NTMx","avatar_url":"https://avatars3.githubusercontent.com/u/12819531?v=4","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"repo":{"id":49969555,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk2OTU1NQ==","name":"NuGet.Client","full_name":"dagood/NuGet.Client","private":false,"owner":{"login":"dagood","id":12819531,"node_id":"MDQ6VXNlcjEyODE5NTMx","avatar_url":"https://avatars3.githubusercontent.com/u/12819531?v=4","gravatar_id":"","url":"https://api.github.com/users/dagood","html_url":"https://github.com/dagood","followers_url":"https://api.github.com/users/dagood/followers","following_url":"https://api.github.com/users/dagood/following{/other_user}","gists_url":"https://api.github.com/users/dagood/gists{/gist_id}","starred_url":"https://api.github.com/users/dagood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagood/subscriptions","organizations_url":"https://api.github.com/users/dagood/orgs","repos_url":"https://api.github.com/users/dagood/repos","events_url":"https://api.github.com/users/dagood/events{/privacy}","received_events_url":"https://api.github.com/users/dagood/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dagood/NuGet.Client","description":"Core client libraries for NuGet Services","fork":true,"url":"https://api.github.com/repos/dagood/NuGet.Client","forks_url":"https://api.github.com/repos/dagood/NuGet.Client/forks","keys_url":"https://api.github.com/repos/dagood/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dagood/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dagood/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/dagood/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/dagood/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/dagood/NuGet.Client/events","assignees_url":"https://api.github.com/repos/dagood/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/dagood/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/dagood/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/dagood/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dagood/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dagood/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/dagood/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dagood/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/dagood/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/dagood/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/dagood/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/dagood/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/dagood/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/dagood/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/dagood/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/dagood/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/dagood/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/dagood/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/dagood/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dagood/NuGet.Client/merges","archive_url":"https://api.github.com/repos/dagood/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dagood/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/dagood/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/dagood/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/dagood/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/dagood/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dagood/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/dagood/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/dagood/NuGet.Client/deployments","created_at":"2016-01-19T17:21:48Z","updated_at":"2016-01-19T17:21:55Z","pushed_at":"2018-12-13T01:24:46Z","git_url":"git://github.com/dagood/NuGet.Client.git","ssh_url":"git@github.com:dagood/NuGet.Client.git","clone_url":"https://github.com/dagood/NuGet.Client.git","svn_url":"https://github.com/dagood/NuGet.Client","homepage":null,"size":35647,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"placeholder"}},"base":{"label":"NuGet:dev","ref":"dev","sha":"b2cda868db0f7e7fa7d8932b5900eae17472e43a","user":{"login":"NuGet","id":968310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"repo":{"id":19330736,"node_id":"MDEwOlJlcG9zaXRvcnkxOTMzMDczNg==","name":"NuGet.Client","full_name":"NuGet/NuGet.Client","private":false,"owner":{"login":"NuGet","id":968310,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk2ODMxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/968310?v=4","gravatar_id":"","url":"https://api.github.com/users/NuGet","html_url":"https://github.com/NuGet","followers_url":"https://api.github.com/users/NuGet/followers","following_url":"https://api.github.com/users/NuGet/following{/other_user}","gists_url":"https://api.github.com/users/NuGet/gists{/gist_id}","starred_url":"https://api.github.com/users/NuGet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NuGet/subscriptions","organizations_url":"https://api.github.com/users/NuGet/orgs","repos_url":"https://api.github.com/users/NuGet/repos","events_url":"https://api.github.com/users/NuGet/events{/privacy}","received_events_url":"https://api.github.com/users/NuGet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NuGet/NuGet.Client","description":"Core client libraries for NuGet Services","fork":false,"url":"https://api.github.com/repos/NuGet/NuGet.Client","forks_url":"https://api.github.com/repos/NuGet/NuGet.Client/forks","keys_url":"https://api.github.com/repos/NuGet/NuGet.Client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NuGet/NuGet.Client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NuGet/NuGet.Client/teams","hooks_url":"https://api.github.com/repos/NuGet/NuGet.Client/hooks","issue_events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/events{/number}","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/events","assignees_url":"https://api.github.com/repos/NuGet/NuGet.Client/assignees{/user}","branches_url":"https://api.github.com/repos/NuGet/NuGet.Client/branches{/branch}","tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/tags","blobs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/refs{/sha}","trees_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/{sha}","languages_url":"https://api.github.com/repos/NuGet/NuGet.Client/languages","stargazers_url":"https://api.github.com/repos/NuGet/NuGet.Client/stargazers","contributors_url":"https://api.github.com/repos/NuGet/NuGet.Client/contributors","subscribers_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscribers","subscription_url":"https://api.github.com/repos/NuGet/NuGet.Client/subscription","commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/commits{/sha}","git_commits_url":"https://api.github.com/repos/NuGet/NuGet.Client/git/commits{/sha}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/comments{/number}","issue_comment_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments{/number}","contents_url":"https://api.github.com/repos/NuGet/NuGet.Client/contents/{+path}","compare_url":"https://api.github.com/repos/NuGet/NuGet.Client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NuGet/NuGet.Client/merges","archive_url":"https://api.github.com/repos/NuGet/NuGet.Client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NuGet/NuGet.Client/downloads","issues_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues{/number}","pulls_url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls{/number}","milestones_url":"https://api.github.com/repos/NuGet/NuGet.Client/milestones{/number}","notifications_url":"https://api.github.com/repos/NuGet/NuGet.Client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/labels{/name}","releases_url":"https://api.github.com/repos/NuGet/NuGet.Client/releases{/id}","deployments_url":"https://api.github.com/repos/NuGet/NuGet.Client/deployments","created_at":"2014-04-30T23:46:11Z","updated_at":"2018-12-13T08:54:39Z","pushed_at":"2018-12-13T22:06:59Z","git_url":"git://github.com/NuGet/NuGet.Client.git","ssh_url":"git@github.com:NuGet/NuGet.Client.git","clone_url":"https://github.com/NuGet/NuGet.Client.git","svn_url":"https://github.com/NuGet/NuGet.Client","homepage":null,"size":69657,"stargazers_count":314,"watchers_count":314,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":366,"mirror_url":null,"archived":false,"open_issues_count":26,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":366,"open_issues":26,"watchers":314,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2560"},"html":{"href":"https://github.com/NuGet/NuGet.Client/pull/2560"},"issue":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2560"},"comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2560/comments"},"review_comments":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2560/comments"},"review_comment":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2560/commits"},"statuses":{"href":"https://api.github.com/repos/NuGet/NuGet.Client/statuses/381457376cd4409ef6a6b923649dd412284cad79"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nkolev92"}}