{"action":"created","comment":{"url":"https://api.github.com/repos/klarna/supervisor3/pulls/comments/182072853","pull_request_review_id":112810057,"id":182072853,"diff_hunk":"@@ -1009,7 +1019,7 @@ do_restart_delay({RestartType, Delay}, Reason, Child, State) ->\n             %% will fail to find the child in ?restarting state,\n             %% hence ignore the restart, which will in turn\n             %% cause it to enter a permanent zombie state.\n-            State\n+            replace_child(Child#child{pid = ?delayed_restart(TRef)}, State)","path":"src/supervisor3.erl","position":79,"original_position":79,"commit_id":"4e12248c358f174fe3bf9e395b2ef220a20b426a","original_commit_id":"4e12248c358f174fe3bf9e395b2ef220a20b426a","user":{"login":"zmstone","id":164324,"avatar_url":"https://avatars3.githubusercontent.com/u/164324?v=4","gravatar_id":"","url":"https://api.github.com/users/zmstone","html_url":"https://github.com/zmstone","followers_url":"https://api.github.com/users/zmstone/followers","following_url":"https://api.github.com/users/zmstone/following{/other_user}","gists_url":"https://api.github.com/users/zmstone/gists{/gist_id}","starred_url":"https://api.github.com/users/zmstone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmstone/subscriptions","organizations_url":"https://api.github.com/users/zmstone/orgs","repos_url":"https://api.github.com/users/zmstone/repos","events_url":"https://api.github.com/users/zmstone/events{/privacy}","received_events_url":"https://api.github.com/users/zmstone/received_events","type":"User","site_admin":false},"body":"ah, for `simple_one_for_one` children, it may get added back.\r\nbut I'm not sure why would anyone use `simple_one_for_one` with a delayed restart, we should perhaps drop it.","created_at":"2018-04-17T13:31:39Z","updated_at":"2018-04-17T13:31:39Z","html_url":"https://github.com/klarna/supervisor3/pull/14#discussion_r182072853","pull_request_url":"https://api.github.com/repos/klarna/supervisor3/pulls/14","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/klarna/supervisor3/pulls/comments/182072853"},"html":{"href":"https://github.com/klarna/supervisor3/pull/14#discussion_r182072853"},"pull_request":{"href":"https://api.github.com/repos/klarna/supervisor3/pulls/14"}},"in_reply_to_id":182071666},"pull_request":{"url":"https://api.github.com/repos/klarna/supervisor3/pulls/14","id":182085964,"html_url":"https://github.com/klarna/supervisor3/pull/14","diff_url":"https://github.com/klarna/supervisor3/pull/14.diff","patch_url":"https://github.com/klarna/supervisor3/pull/14.patch","issue_url":"https://api.github.com/repos/klarna/supervisor3/issues/14","number":14,"state":"open","locked":false,"title":"Bugfix: made it possible to remove restarting persistent children","user":{"login":"k32","id":10274441,"avatar_url":"https://avatars0.githubusercontent.com/u/10274441?v=4","gravatar_id":"","url":"https://api.github.com/users/k32","html_url":"https://github.com/k32","followers_url":"https://api.github.com/users/k32/followers","following_url":"https://api.github.com/users/k32/following{/other_user}","gists_url":"https://api.github.com/users/k32/gists{/gist_id}","starred_url":"https://api.github.com/users/k32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k32/subscriptions","organizations_url":"https://api.github.com/users/k32/orgs","repos_url":"https://api.github.com/users/k32/repos","events_url":"https://api.github.com/users/k32/events{/privacy}","received_events_url":"https://api.github.com/users/k32/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-17T08:19:46Z","updated_at":"2018-04-17T13:31:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"757ff5483fa3b331d90001447a743db399da2bec","assignee":null,"assignees":[],"requested_reviewers":[{"login":"id","id":138221,"avatar_url":"https://avatars3.githubusercontent.com/u/138221?v=4","gravatar_id":"","url":"https://api.github.com/users/id","html_url":"https://github.com/id","followers_url":"https://api.github.com/users/id/followers","following_url":"https://api.github.com/users/id/following{/other_user}","gists_url":"https://api.github.com/users/id/gists{/gist_id}","starred_url":"https://api.github.com/users/id/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/id/subscriptions","organizations_url":"https://api.github.com/users/id/orgs","repos_url":"https://api.github.com/users/id/repos","events_url":"https://api.github.com/users/id/events{/privacy}","received_events_url":"https://api.github.com/users/id/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/klarna/supervisor3/pulls/14/commits","review_comments_url":"https://api.github.com/repos/klarna/supervisor3/pulls/14/comments","review_comment_url":"https://api.github.com/repos/klarna/supervisor3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/klarna/supervisor3/issues/14/comments","statuses_url":"https://api.github.com/repos/klarna/supervisor3/statuses/4e12248c358f174fe3bf9e395b2ef220a20b426a","head":{"label":"k32:master","ref":"master","sha":"4e12248c358f174fe3bf9e395b2ef220a20b426a","user":{"login":"k32","id":10274441,"avatar_url":"https://avatars0.githubusercontent.com/u/10274441?v=4","gravatar_id":"","url":"https://api.github.com/users/k32","html_url":"https://github.com/k32","followers_url":"https://api.github.com/users/k32/followers","following_url":"https://api.github.com/users/k32/following{/other_user}","gists_url":"https://api.github.com/users/k32/gists{/gist_id}","starred_url":"https://api.github.com/users/k32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k32/subscriptions","organizations_url":"https://api.github.com/users/k32/orgs","repos_url":"https://api.github.com/users/k32/repos","events_url":"https://api.github.com/users/k32/events{/privacy}","received_events_url":"https://api.github.com/users/k32/received_events","type":"User","site_admin":false},"repo":{"id":129775267,"name":"supervisor3","full_name":"k32/supervisor3","owner":{"login":"k32","id":10274441,"avatar_url":"https://avatars0.githubusercontent.com/u/10274441?v=4","gravatar_id":"","url":"https://api.github.com/users/k32","html_url":"https://github.com/k32","followers_url":"https://api.github.com/users/k32/followers","following_url":"https://api.github.com/users/k32/following{/other_user}","gists_url":"https://api.github.com/users/k32/gists{/gist_id}","starred_url":"https://api.github.com/users/k32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k32/subscriptions","organizations_url":"https://api.github.com/users/k32/orgs","repos_url":"https://api.github.com/users/k32/repos","events_url":"https://api.github.com/users/k32/events{/privacy}","received_events_url":"https://api.github.com/users/k32/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/k32/supervisor3","description":"Library to abstract supervisor2.erl from rabbitmq/rabbitmq-common","fork":true,"url":"https://api.github.com/repos/k32/supervisor3","forks_url":"https://api.github.com/repos/k32/supervisor3/forks","keys_url":"https://api.github.com/repos/k32/supervisor3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/k32/supervisor3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/k32/supervisor3/teams","hooks_url":"https://api.github.com/repos/k32/supervisor3/hooks","issue_events_url":"https://api.github.com/repos/k32/supervisor3/issues/events{/number}","events_url":"https://api.github.com/repos/k32/supervisor3/events","assignees_url":"https://api.github.com/repos/k32/supervisor3/assignees{/user}","branches_url":"https://api.github.com/repos/k32/supervisor3/branches{/branch}","tags_url":"https://api.github.com/repos/k32/supervisor3/tags","blobs_url":"https://api.github.com/repos/k32/supervisor3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/k32/supervisor3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/k32/supervisor3/git/refs{/sha}","trees_url":"https://api.github.com/repos/k32/supervisor3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/k32/supervisor3/statuses/{sha}","languages_url":"https://api.github.com/repos/k32/supervisor3/languages","stargazers_url":"https://api.github.com/repos/k32/supervisor3/stargazers","contributors_url":"https://api.github.com/repos/k32/supervisor3/contributors","subscribers_url":"https://api.github.com/repos/k32/supervisor3/subscribers","subscription_url":"https://api.github.com/repos/k32/supervisor3/subscription","commits_url":"https://api.github.com/repos/k32/supervisor3/commits{/sha}","git_commits_url":"https://api.github.com/repos/k32/supervisor3/git/commits{/sha}","comments_url":"https://api.github.com/repos/k32/supervisor3/comments{/number}","issue_comment_url":"https://api.github.com/repos/k32/supervisor3/issues/comments{/number}","contents_url":"https://api.github.com/repos/k32/supervisor3/contents/{+path}","compare_url":"https://api.github.com/repos/k32/supervisor3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/k32/supervisor3/merges","archive_url":"https://api.github.com/repos/k32/supervisor3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/k32/supervisor3/downloads","issues_url":"https://api.github.com/repos/k32/supervisor3/issues{/number}","pulls_url":"https://api.github.com/repos/k32/supervisor3/pulls{/number}","milestones_url":"https://api.github.com/repos/k32/supervisor3/milestones{/number}","notifications_url":"https://api.github.com/repos/k32/supervisor3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/k32/supervisor3/labels{/name}","releases_url":"https://api.github.com/repos/k32/supervisor3/releases{/id}","deployments_url":"https://api.github.com/repos/k32/supervisor3/deployments","created_at":"2018-04-16T16:41:00Z","updated_at":"2018-04-17T09:22:31Z","pushed_at":"2018-04-17T09:22:30Z","git_url":"git://github.com/k32/supervisor3.git","ssh_url":"git@github.com:k32/supervisor3.git","clone_url":"https://github.com/k32/supervisor3.git","svn_url":"https://github.com/k32/supervisor3","homepage":"","size":469,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"klarna:master","ref":"master","sha":"b601c90070d2663903c8568c2e4bb1a06a195443","user":{"login":"klarna","id":394540,"avatar_url":"https://avatars0.githubusercontent.com/u/394540?v=4","gravatar_id":"","url":"https://api.github.com/users/klarna","html_url":"https://github.com/klarna","followers_url":"https://api.github.com/users/klarna/followers","following_url":"https://api.github.com/users/klarna/following{/other_user}","gists_url":"https://api.github.com/users/klarna/gists{/gist_id}","starred_url":"https://api.github.com/users/klarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klarna/subscriptions","organizations_url":"https://api.github.com/users/klarna/orgs","repos_url":"https://api.github.com/users/klarna/repos","events_url":"https://api.github.com/users/klarna/events{/privacy}","received_events_url":"https://api.github.com/users/klarna/received_events","type":"Organization","site_admin":false},"repo":{"id":48103453,"name":"supervisor3","full_name":"klarna/supervisor3","owner":{"login":"klarna","id":394540,"avatar_url":"https://avatars0.githubusercontent.com/u/394540?v=4","gravatar_id":"","url":"https://api.github.com/users/klarna","html_url":"https://github.com/klarna","followers_url":"https://api.github.com/users/klarna/followers","following_url":"https://api.github.com/users/klarna/following{/other_user}","gists_url":"https://api.github.com/users/klarna/gists{/gist_id}","starred_url":"https://api.github.com/users/klarna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klarna/subscriptions","organizations_url":"https://api.github.com/users/klarna/orgs","repos_url":"https://api.github.com/users/klarna/repos","events_url":"https://api.github.com/users/klarna/events{/privacy}","received_events_url":"https://api.github.com/users/klarna/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/klarna/supervisor3","description":"Library to abstract supervisor2.erl from rabbitmq/rabbitmq-common","fork":true,"url":"https://api.github.com/repos/klarna/supervisor3","forks_url":"https://api.github.com/repos/klarna/supervisor3/forks","keys_url":"https://api.github.com/repos/klarna/supervisor3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klarna/supervisor3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klarna/supervisor3/teams","hooks_url":"https://api.github.com/repos/klarna/supervisor3/hooks","issue_events_url":"https://api.github.com/repos/klarna/supervisor3/issues/events{/number}","events_url":"https://api.github.com/repos/klarna/supervisor3/events","assignees_url":"https://api.github.com/repos/klarna/supervisor3/assignees{/user}","branches_url":"https://api.github.com/repos/klarna/supervisor3/branches{/branch}","tags_url":"https://api.github.com/repos/klarna/supervisor3/tags","blobs_url":"https://api.github.com/repos/klarna/supervisor3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klarna/supervisor3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klarna/supervisor3/git/refs{/sha}","trees_url":"https://api.github.com/repos/klarna/supervisor3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klarna/supervisor3/statuses/{sha}","languages_url":"https://api.github.com/repos/klarna/supervisor3/languages","stargazers_url":"https://api.github.com/repos/klarna/supervisor3/stargazers","contributors_url":"https://api.github.com/repos/klarna/supervisor3/contributors","subscribers_url":"https://api.github.com/repos/klarna/supervisor3/subscribers","subscription_url":"https://api.github.com/repos/klarna/supervisor3/subscription","commits_url":"https://api.github.com/repos/klarna/supervisor3/commits{/sha}","git_commits_url":"https://api.github.com/repos/klarna/supervisor3/git/commits{/sha}","comments_url":"https://api.github.com/repos/klarna/supervisor3/comments{/number}","issue_comment_url":"https://api.github.com/repos/klarna/supervisor3/issues/comments{/number}","contents_url":"https://api.github.com/repos/klarna/supervisor3/contents/{+path}","compare_url":"https://api.github.com/repos/klarna/supervisor3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klarna/supervisor3/merges","archive_url":"https://api.github.com/repos/klarna/supervisor3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klarna/supervisor3/downloads","issues_url":"https://api.github.com/repos/klarna/supervisor3/issues{/number}","pulls_url":"https://api.github.com/repos/klarna/supervisor3/pulls{/number}","milestones_url":"https://api.github.com/repos/klarna/supervisor3/milestones{/number}","notifications_url":"https://api.github.com/repos/klarna/supervisor3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klarna/supervisor3/labels{/name}","releases_url":"https://api.github.com/repos/klarna/supervisor3/releases{/id}","deployments_url":"https://api.github.com/repos/klarna/supervisor3/deployments","created_at":"2015-12-16T10:24:26Z","updated_at":"2018-04-04T14:14:12Z","pushed_at":"2018-04-17T09:22:31Z","git_url":"git://github.com/klarna/supervisor3.git","ssh_url":"git@github.com:klarna/supervisor3.git","clone_url":"https://github.com/klarna/supervisor3.git","svn_url":"https://github.com/klarna/supervisor3","homepage":"","size":468,"stargazers_count":16,"watchers_count":16,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/klarna/supervisor3/pulls/14"},"html":{"href":"https://github.com/klarna/supervisor3/pull/14"},"issue":{"href":"https://api.github.com/repos/klarna/supervisor3/issues/14"},"comments":{"href":"https://api.github.com/repos/klarna/supervisor3/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/klarna/supervisor3/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/klarna/supervisor3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/klarna/supervisor3/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/klarna/supervisor3/statuses/4e12248c358f174fe3bf9e395b2ef220a20b426a"}},"author_association":"NONE"}}
{"actor":{"display_login":"zmstone"}}