{"action":"created","comment":{"url":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/comments/214308627","pull_request_review_id":151333600,"id":214308627,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDMwODYyNw==","diff_hunk":"@@ -0,0 +1,243 @@\n+#ifndef RecoPixelVertexing_PixelVertexFinding_clusterTracks_H\n+#define RecoPixelVertexing_PixelVertexFinding_clusterTracks_H\n+\n+#include<cstdint>\n+#include<cmath>\n+#include<cassert>\n+\n+#include \"HeterogeneousCore/CUDAUtilities/interface/HistoContainer.h\"\n+\n+#include \"gpuVertexFinder.h\"\n+\n+namespace gpuVertexFinder {\n+  \n+  // this algo does not really scale as it works in a single block...\n+  // enough for <10K tracks we have\n+  __global__ \n+  void clusterTracks(int nt,\n+\t\t     OnGPU * pdata,\n+\t\t     int minT,  // min number of neighbours to be \"core\"\n+\t\t     float eps, // max absolute distance to cluster\n+\t\t     float errmax, // max error to be \"seed\"\n+\t\t     float chi2max   // max normalized distance to cluster\n+\t\t     )  {\n+\n+    constexpr bool verbose = false;\n+    \n+    auto er2mx = errmax*errmax;\n+    \n+    auto & data = *pdata;\n+    float const * zt = data.zt;\n+    float const * ezt2 = data.ezt2;\n+    float * zv = data.zv;\n+    float * wv = data.wv;\n+    float * chi2 = data.chi2;\n+    uint32_t & nv = *data.nv;\n+    \n+    int8_t  * izt = data.izt;\n+    int32_t * nn = data.nn;\n+    int32_t * iv = data.iv;\n+    \n+    assert(pdata);\n+    assert(zt);\n+    \n+    __shared__ HistoContainer<int8_t,8,5,8,uint16_t> hist;\n+    \n+    //  if(0==threadIdx.x) printf(\"params %d %f\\n\",minT,eps);    \n+    //  if(0==threadIdx.x) printf(\"booked hist with %d bins, size %d for %d tracks\\n\",hist.nbins(),hist.binSize(),nt);\n+    \n+    // zero hist\n+    hist.nspills = 0;","path":"RecoPixelVertexing/PixelVertexFinding/src/gpuClusterTracks.h","position":50,"original_position":50,"commit_id":"10ad7e954b012eb2c8f5ec2f5c81466380348e3d","original_commit_id":"fc770d6191c8319e3f10da8530afd132c7e9e135","user":{"login":"fwyzard","id":4069793,"node_id":"MDQ6VXNlcjQwNjk3OTM=","avatar_url":"https://avatars2.githubusercontent.com/u/4069793?v=4","gravatar_id":"","url":"https://api.github.com/users/fwyzard","html_url":"https://github.com/fwyzard","followers_url":"https://api.github.com/users/fwyzard/followers","following_url":"https://api.github.com/users/fwyzard/following{/other_user}","gists_url":"https://api.github.com/users/fwyzard/gists{/gist_id}","starred_url":"https://api.github.com/users/fwyzard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwyzard/subscriptions","organizations_url":"https://api.github.com/users/fwyzard/orgs","repos_url":"https://api.github.com/users/fwyzard/repos","events_url":"https://api.github.com/users/fwyzard/events{/privacy}","received_events_url":"https://api.github.com/users/fwyzard/received_events","type":"User","site_admin":false},"body":"can this be wrapped in some member function ?\r\nand, shouldn't it be done by a single thread (or spreading the bins through the threads) ?","created_at":"2018-08-31T10:18:22Z","updated_at":"2018-08-31T10:34:41Z","html_url":"https://github.com/cms-patatrack/cmssw/pull/149#discussion_r214308627","pull_request_url":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/149","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/comments/214308627"},"html":{"href":"https://github.com/cms-patatrack/cmssw/pull/149#discussion_r214308627"},"pull_request":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/149"}}},"pull_request":{"url":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/149","id":212015845,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMDE1ODQ1","html_url":"https://github.com/cms-patatrack/cmssw/pull/149","diff_url":"https://github.com/cms-patatrack/cmssw/pull/149.diff","patch_url":"https://github.com/cms-patatrack/cmssw/pull/149.patch","issue_url":"https://api.github.com/repos/cms-patatrack/cmssw/issues/149","number":149,"state":"open","locked":false,"title":"Doublet tuning and new vertex algo","user":{"login":"VinInn","id":4143702,"node_id":"MDQ6VXNlcjQxNDM3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4143702?v=4","gravatar_id":"","url":"https://api.github.com/users/VinInn","html_url":"https://github.com/VinInn","followers_url":"https://api.github.com/users/VinInn/followers","following_url":"https://api.github.com/users/VinInn/following{/other_user}","gists_url":"https://api.github.com/users/VinInn/gists{/gist_id}","starred_url":"https://api.github.com/users/VinInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VinInn/subscriptions","organizations_url":"https://api.github.com/users/VinInn/orgs","repos_url":"https://api.github.com/users/VinInn/repos","events_url":"https://api.github.com/users/VinInn/events{/privacy}","received_events_url":"https://api.github.com/users/VinInn/received_events","type":"User","site_admin":false},"body":"This PR contains two independent components\r\n1) tuning and speed up of the doublet algorithm\r\n2) a new concurrent vertex algorithm based on DBSCAN\r\n(it reuses pieces of pixel cluster algo...)\r\n\r\nthe vertex algorithm will require tuning (to say the least) even to reach the performance of current DivisiveClustering algo used at HLT\r\n\r\nMTV\r\nhttp://innocent.home.cern.ch/innocent/RelVal/gpuverI/\r\ncurrent DivisiveClustering algo in\r\nhttps://innocent.web.cern.ch/innocent/RelVal/divverI/\r\n(baseline is offline doublets and DA vertexing)\r\n","created_at":"2018-08-30T09:37:12Z","updated_at":"2018-08-31T10:34:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"247bb01c19cfb1633fbd42447fc4ea26d24bfdec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":841624267,"node_id":"MDU6TGFiZWw4NDE2MjQyNjc=","url":"https://api.github.com/repos/cms-patatrack/cmssw/labels/comparison-pending","name":"comparison-pending","color":"ededed","default":false},{"id":841624263,"node_id":"MDU6TGFiZWw4NDE2MjQyNjM=","url":"https://api.github.com/repos/cms-patatrack/cmssw/labels/new-package-pending","name":"new-package-pending","color":"ededed","default":false},{"id":841624265,"node_id":"MDU6TGFiZWw4NDE2MjQyNjU=","url":"https://api.github.com/repos/cms-patatrack/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ededed","default":false},{"id":841919978,"node_id":"MDU6TGFiZWw4NDE5MTk5Nzg=","url":"https://api.github.com/repos/cms-patatrack/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"ededed","default":false},{"id":841624266,"node_id":"MDU6TGFiZWw4NDE2MjQyNjY=","url":"https://api.github.com/repos/cms-patatrack/cmssw/labels/tests-pending","name":"tests-pending","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/149/commits","review_comments_url":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/149/comments","review_comment_url":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-patatrack/cmssw/issues/149/comments","statuses_url":"https://api.github.com/repos/cms-patatrack/cmssw/statuses/10ad7e954b012eb2c8f5ec2f5c81466380348e3d","head":{"label":"VinInn:DoubletTuning","ref":"DoubletTuning","sha":"10ad7e954b012eb2c8f5ec2f5c81466380348e3d","user":{"login":"VinInn","id":4143702,"node_id":"MDQ6VXNlcjQxNDM3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4143702?v=4","gravatar_id":"","url":"https://api.github.com/users/VinInn","html_url":"https://github.com/VinInn","followers_url":"https://api.github.com/users/VinInn/followers","following_url":"https://api.github.com/users/VinInn/following{/other_user}","gists_url":"https://api.github.com/users/VinInn/gists{/gist_id}","starred_url":"https://api.github.com/users/VinInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VinInn/subscriptions","organizations_url":"https://api.github.com/users/VinInn/orgs","repos_url":"https://api.github.com/users/VinInn/repos","events_url":"https://api.github.com/users/VinInn/events{/privacy}","received_events_url":"https://api.github.com/users/VinInn/received_events","type":"User","site_admin":false},"repo":{"id":11128341,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyODM0MQ==","name":"cmssw","full_name":"VinInn/cmssw","owner":{"login":"VinInn","id":4143702,"node_id":"MDQ6VXNlcjQxNDM3MDI=","avatar_url":"https://avatars2.githubusercontent.com/u/4143702?v=4","gravatar_id":"","url":"https://api.github.com/users/VinInn","html_url":"https://github.com/VinInn","followers_url":"https://api.github.com/users/VinInn/followers","following_url":"https://api.github.com/users/VinInn/following{/other_user}","gists_url":"https://api.github.com/users/VinInn/gists{/gist_id}","starred_url":"https://api.github.com/users/VinInn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VinInn/subscriptions","organizations_url":"https://api.github.com/users/VinInn/orgs","repos_url":"https://api.github.com/users/VinInn/repos","events_url":"https://api.github.com/users/VinInn/events{/privacy}","received_events_url":"https://api.github.com/users/VinInn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VinInn/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/VinInn/cmssw","forks_url":"https://api.github.com/repos/VinInn/cmssw/forks","keys_url":"https://api.github.com/repos/VinInn/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VinInn/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VinInn/cmssw/teams","hooks_url":"https://api.github.com/repos/VinInn/cmssw/hooks","issue_events_url":"https://api.github.com/repos/VinInn/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/VinInn/cmssw/events","assignees_url":"https://api.github.com/repos/VinInn/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/VinInn/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/VinInn/cmssw/tags","blobs_url":"https://api.github.com/repos/VinInn/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VinInn/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VinInn/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/VinInn/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VinInn/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/VinInn/cmssw/languages","stargazers_url":"https://api.github.com/repos/VinInn/cmssw/stargazers","contributors_url":"https://api.github.com/repos/VinInn/cmssw/contributors","subscribers_url":"https://api.github.com/repos/VinInn/cmssw/subscribers","subscription_url":"https://api.github.com/repos/VinInn/cmssw/subscription","commits_url":"https://api.github.com/repos/VinInn/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/VinInn/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/VinInn/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/VinInn/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/VinInn/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/VinInn/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VinInn/cmssw/merges","archive_url":"https://api.github.com/repos/VinInn/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VinInn/cmssw/downloads","issues_url":"https://api.github.com/repos/VinInn/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/VinInn/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/VinInn/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/VinInn/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VinInn/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/VinInn/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/VinInn/cmssw/deployments","created_at":"2013-07-02T15:43:52Z","updated_at":"2014-06-25T05:11:32Z","pushed_at":"2018-08-31T10:18:46Z","git_url":"git://github.com/VinInn/cmssw.git","ssh_url":"git@github.com:VinInn/cmssw.git","clone_url":"https://github.com/VinInn/cmssw.git","svn_url":"https://github.com/VinInn/cmssw","homepage":"cms-sw.github.io/cmssw","size":934957,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_9_0_X"}},"base":{"label":"cms-patatrack:CMSSW_10_2_X_Patatrack","ref":"CMSSW_10_2_X_Patatrack","sha":"cf2d1bb0f920451b13209219065feb1daf621cea","user":{"login":"cms-patatrack","id":34309138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA5MTM4","avatar_url":"https://avatars1.githubusercontent.com/u/34309138?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-patatrack","html_url":"https://github.com/cms-patatrack","followers_url":"https://api.github.com/users/cms-patatrack/followers","following_url":"https://api.github.com/users/cms-patatrack/following{/other_user}","gists_url":"https://api.github.com/users/cms-patatrack/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-patatrack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-patatrack/subscriptions","organizations_url":"https://api.github.com/users/cms-patatrack/orgs","repos_url":"https://api.github.com/users/cms-patatrack/repos","events_url":"https://api.github.com/users/cms-patatrack/events{/privacy}","received_events_url":"https://api.github.com/users/cms-patatrack/received_events","type":"Organization","site_admin":false},"repo":{"id":113325755,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzMjU3NTU=","name":"cmssw","full_name":"cms-patatrack/cmssw","owner":{"login":"cms-patatrack","id":34309138,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzA5MTM4","avatar_url":"https://avatars1.githubusercontent.com/u/34309138?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-patatrack","html_url":"https://github.com/cms-patatrack","followers_url":"https://api.github.com/users/cms-patatrack/followers","following_url":"https://api.github.com/users/cms-patatrack/following{/other_user}","gists_url":"https://api.github.com/users/cms-patatrack/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-patatrack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-patatrack/subscriptions","organizations_url":"https://api.github.com/users/cms-patatrack/orgs","repos_url":"https://api.github.com/users/cms-patatrack/repos","events_url":"https://api.github.com/users/cms-patatrack/events{/privacy}","received_events_url":"https://api.github.com/users/cms-patatrack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-patatrack/cmssw","description":"CMSSW fork of the Patatrack project","fork":true,"url":"https://api.github.com/repos/cms-patatrack/cmssw","forks_url":"https://api.github.com/repos/cms-patatrack/cmssw/forks","keys_url":"https://api.github.com/repos/cms-patatrack/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-patatrack/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-patatrack/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-patatrack/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-patatrack/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-patatrack/cmssw/events","assignees_url":"https://api.github.com/repos/cms-patatrack/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-patatrack/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-patatrack/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-patatrack/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-patatrack/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-patatrack/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-patatrack/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-patatrack/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-patatrack/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-patatrack/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-patatrack/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-patatrack/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-patatrack/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-patatrack/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-patatrack/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-patatrack/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-patatrack/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-patatrack/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-patatrack/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-patatrack/cmssw/merges","archive_url":"https://api.github.com/repos/cms-patatrack/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-patatrack/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-patatrack/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-patatrack/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-patatrack/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-patatrack/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-patatrack/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-patatrack/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-patatrack/cmssw/deployments","created_at":"2017-12-06T14:20:07Z","updated_at":"2018-08-30T13:23:39Z","pushed_at":"2018-08-31T10:18:51Z","git_url":"git://github.com/cms-patatrack/cmssw.git","ssh_url":"git@github.com:cms-patatrack/cmssw.git","clone_url":"https://github.com/cms-patatrack/cmssw.git","svn_url":"https://github.com/cms-patatrack/cmssw","homepage":"https://patatrack.web.cern.ch/patatrack/index.html","size":895950,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":2,"open_issues":24,"watchers":0,"default_branch":"CMSSW_10_2_X_Patatrack"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/149"},"html":{"href":"https://github.com/cms-patatrack/cmssw/pull/149"},"issue":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/issues/149"},"comments":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/cms-patatrack/cmssw/statuses/10ad7e954b012eb2c8f5ec2f5c81466380348e3d"}},"author_association":"NONE"}}
{"actor":{"display_login":"fwyzard"}}