{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/22020","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/22020/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22020/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/22020/events","html_url":"https://github.com/nodejs/node/pull/22020","id":345564993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NjYyNzc3","number":22020,"title":"fs: readdir optionally returning type information","user":{"login":"bengl","id":110455,"node_id":"MDQ6VXNlcjExMDQ1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/110455?v=4","gravatar_id":"","url":"https://api.github.com/users/bengl","html_url":"https://github.com/bengl","followers_url":"https://api.github.com/users/bengl/followers","following_url":"https://api.github.com/users/bengl/following{/other_user}","gists_url":"https://api.github.com/users/bengl/gists{/gist_id}","starred_url":"https://api.github.com/users/bengl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengl/subscriptions","organizations_url":"https://api.github.com/users/bengl/orgs","repos_url":"https://api.github.com/users/bengl/repos","events_url":"https://api.github.com/users/bengl/events{/privacy}","received_events_url":"https://api.github.com/users/bengl/received_events","type":"User","site_admin":false},"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":155435785,"node_id":"MDU6TGFiZWwxNTU0MzU3ODU=","url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":169485478,"node_id":"MDU6TGFiZWwxNjk0ODU0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-07-29T21:40:48Z","updated_at":"2018-08-09T04:37:18Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22020","html_url":"https://github.com/nodejs/node/pull/22020","diff_url":"https://github.com/nodejs/node/pull/22020.diff","patch_url":"https://github.com/nodejs/node/pull/22020.patch"},"body":"readdir and readdirSync now have a \"withTypes\" option, which, when enabled,\r\nprovides an array of DirectoryEntry objects, similar to Stats bjects,\r\nwhich have the filename and the type information.\r\n\r\nFixes: https://github.com/nodejs/node/issues/15699\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/411634084","html_url":"https://github.com/nodejs/node/pull/22020#issuecomment-411634084","issue_url":"https://api.github.com/repos/nodejs/node/issues/22020","id":411634084,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTYzNDA4NA==","user":{"login":"bengl","id":110455,"node_id":"MDQ6VXNlcjExMDQ1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/110455?v=4","gravatar_id":"","url":"https://api.github.com/users/bengl","html_url":"https://github.com/bengl","followers_url":"https://api.github.com/users/bengl/followers","following_url":"https://api.github.com/users/bengl/following{/other_user}","gists_url":"https://api.github.com/users/bengl/gists{/gist_id}","starred_url":"https://api.github.com/users/bengl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bengl/subscriptions","organizations_url":"https://api.github.com/users/bengl/orgs","repos_url":"https://api.github.com/users/bengl/repos","events_url":"https://api.github.com/users/bengl/events{/privacy}","received_events_url":"https://api.github.com/users/bengl/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T04:37:18Z","updated_at":"2018-08-09T04:37:18Z","author_association":"MEMBER","body":"@silverwind \r\n\r\n> 1. Would it be costly to add a path property with the full path to each entry? I assume it would be useful in many cases and if we already have it available, I'd say provide it to the user.\r\n\r\nConcatenating strings per entry does some like something that could add up, cost-wise, and doesn't really seem in scope for this PR, whose purposes is just to get types at the same time as entry names. Maybe this can be done as a future addition? Maybe it should be optional?\r\n\r\n> 2. Would you know if syscall-less stats on Windows are possible?\r\n\r\nIf I'm reading the python doc you linked correctly, then that may also be possible, yes. That being said, I don't know much about Windows APIs."}}
{"actor":{"display_login":"bengl"}}