{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/6150","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/6150/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/6150/comments","events_url":"https://api.github.com/repos/istio/istio/issues/6150/events","html_url":"https://github.com/istio/istio/pull/6150","id":331322356,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDgyMDAw","number":6150,"title":"Create CRs for dynamic templates","user":{"login":"guptasu","id":11448595,"node_id":"MDQ6VXNlcjExNDQ4NTk1","avatar_url":"https://avatars3.githubusercontent.com/u/11448595?v=4","gravatar_id":"","url":"https://api.github.com/users/guptasu","html_url":"https://github.com/guptasu","followers_url":"https://api.github.com/users/guptasu/followers","following_url":"https://api.github.com/users/guptasu/following{/other_user}","gists_url":"https://api.github.com/users/guptasu/gists{/gist_id}","starred_url":"https://api.github.com/users/guptasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guptasu/subscriptions","organizations_url":"https://api.github.com/users/guptasu/orgs","repos_url":"https://api.github.com/users/guptasu/repos","events_url":"https://api.github.com/users/guptasu/events{/privacy}","received_events_url":"https://api.github.com/users/guptasu/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-11T19:39:29Z","updated_at":"2018-06-11T20:50:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/6150","html_url":"https://github.com/istio/istio/pull/6150","diff_url":"https://github.com/istio/istio/pull/6150.diff","patch_url":"https://github.com/istio/istio/pull/6150.patch"},"body":"the CR names are now `<shortName>-template`. example `metric-template`. Which mean when writing instance spec, user would write with stutter `template: metric-template.` The reason we cannot call the CR `metric` because we already have a compiled in template called `metric`, which causes confusion in our snapshot building code. When decoding an `instance` CR that refers to a `template` with name `metric`. Our code will have to do additional checks to figure out is the name referring to compiled in or not, and I think it will be error prone too. Given that, I think not having conflicting name is safe and therefore I have named template's CR it with suffix `template`.\r\n\r\nOne way to solve this is to create a separate field in the instance spec, may be `template_compiled_in` and then our code can clearly distinguish the two categories (is the instance referring to compiled in template or dynamic descriptor based template) and both can be called `metric`.\r\n\r\nBTW, the same issue is for adapters too. **I would like to checkin this PR to unblock our E2E testing work on OOP adapter. We can decide to add new field `template_compiled_in` or something else in the following PR and regenerate these templates CRs as part of the followup work.**\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/396382871","html_url":"https://github.com/istio/istio/pull/6150#issuecomment-396382871","issue_url":"https://api.github.com/repos/istio/istio/issues/6150","id":396382871,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjM4Mjg3MQ==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T20:50:51Z","updated_at":"2018-06-11T20:50:51Z","author_association":"COLLABORATOR","body":"@guptasu: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/istio-pilot-e2e.sh | bc2811f593d5f5f1e03232643b238b3842f08377 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/6150/istio-pilot-e2e/8026/) | `/test istio-pilot-e2e`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}