{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments/169510037","pull_request_review_id":98047556,"id":169510037,"diff_hunk":"@@ -688,6 +692,12 @@ func (w *legacyLayerWriter) AddLink(name string, target string) error {\n \t\tTarget: filepath.Join(selectedRoot, target),\n \t})\n \tw.addedFiles[name] = true\n+\n+\tkey := relativePathToKey(name)\n+\tif _, ok := w.utilityVMPendingLinks[key]; ok {","path":"legacy.go","position":138,"original_position":138,"commit_id":"17609bd542312d7b4adde84ae717bfd7ddeffe46","original_commit_id":"17609bd542312d7b4adde84ae717bfd7ddeffe46","user":{"login":"jstarks","id":9548354,"avatar_url":"https://avatars1.githubusercontent.com/u/9548354?v=4","gravatar_id":"","url":"https://api.github.com/users/jstarks","html_url":"https://github.com/jstarks","followers_url":"https://api.github.com/users/jstarks/followers","following_url":"https://api.github.com/users/jstarks/following{/other_user}","gists_url":"https://api.github.com/users/jstarks/gists{/gist_id}","starred_url":"https://api.github.com/users/jstarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jstarks/subscriptions","organizations_url":"https://api.github.com/users/jstarks/orgs","repos_url":"https://api.github.com/users/jstarks/repos","events_url":"https://api.github.com/users/jstarks/events{/privacy}","received_events_url":"https://api.github.com/users/jstarks/received_events","type":"User","site_admin":false},"body":"Unnecessary condition (delete is a no-op if the key doesn't exist).","created_at":"2018-02-21T01:07:15Z","updated_at":"2018-02-21T01:15:01Z","html_url":"https://github.com/Microsoft/hcsshim/pull/160#discussion_r169510037","pull_request_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/160","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments/169510037"},"html":{"href":"https://github.com/Microsoft/hcsshim/pull/160#discussion_r169510037"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/160","id":168730325,"html_url":"https://github.com/Microsoft/hcsshim/pull/160","diff_url":"https://github.com/Microsoft/hcsshim/pull/160.diff","patch_url":"https://github.com/Microsoft/hcsshim/pull/160.patch","issue_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/160","number":160,"state":"open","locked":false,"title":"Delay creating UVM hardlinks","user":{"login":"darrenstahlmsft","id":14114019,"avatar_url":"https://avatars2.githubusercontent.com/u/14114019?v=4","gravatar_id":"","url":"https://api.github.com/users/darrenstahlmsft","html_url":"https://github.com/darrenstahlmsft","followers_url":"https://api.github.com/users/darrenstahlmsft/followers","following_url":"https://api.github.com/users/darrenstahlmsft/following{/other_user}","gists_url":"https://api.github.com/users/darrenstahlmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/darrenstahlmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrenstahlmsft/subscriptions","organizations_url":"https://api.github.com/users/darrenstahlmsft/orgs","repos_url":"https://api.github.com/users/darrenstahlmsft/repos","events_url":"https://api.github.com/users/darrenstahlmsft/events{/privacy}","received_events_url":"https://api.github.com/users/darrenstahlmsft/received_events","type":"User","site_admin":false},"body":"fixes https://github.com/Microsoft/hcsshim/issues/155\r\n\r\nDelay the creation of hard links until the entire layer is expanded. This works around a Window bug that prevents deletion of hard links if the target is currently in use, which was preventing layer expansion on RS3 hosts.\r\n\r\n@jstarks @jhowardmsft PTAL\r\n\r\nSigned-off-by: Darren Stahl <darst@microsoft.com>","created_at":"2018-02-13T01:10:56Z","updated_at":"2018-02-21T01:15:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"983421a92d1ef746f2e458f23e19bd764a4e09ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/160/commits","review_comments_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/160/comments","review_comment_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/160/comments","statuses_url":"https://api.github.com/repos/Microsoft/hcsshim/statuses/17609bd542312d7b4adde84ae717bfd7ddeffe46","head":{"label":"darrenstahlmsft:DelayHardlinks","ref":"DelayHardlinks","sha":"17609bd542312d7b4adde84ae717bfd7ddeffe46","user":{"login":"darrenstahlmsft","id":14114019,"avatar_url":"https://avatars2.githubusercontent.com/u/14114019?v=4","gravatar_id":"","url":"https://api.github.com/users/darrenstahlmsft","html_url":"https://github.com/darrenstahlmsft","followers_url":"https://api.github.com/users/darrenstahlmsft/followers","following_url":"https://api.github.com/users/darrenstahlmsft/following{/other_user}","gists_url":"https://api.github.com/users/darrenstahlmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/darrenstahlmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrenstahlmsft/subscriptions","organizations_url":"https://api.github.com/users/darrenstahlmsft/orgs","repos_url":"https://api.github.com/users/darrenstahlmsft/repos","events_url":"https://api.github.com/users/darrenstahlmsft/events{/privacy}","received_events_url":"https://api.github.com/users/darrenstahlmsft/received_events","type":"User","site_admin":false},"repo":{"id":63733941,"name":"hcsshim","full_name":"darrenstahlmsft/hcsshim","owner":{"login":"darrenstahlmsft","id":14114019,"avatar_url":"https://avatars2.githubusercontent.com/u/14114019?v=4","gravatar_id":"","url":"https://api.github.com/users/darrenstahlmsft","html_url":"https://github.com/darrenstahlmsft","followers_url":"https://api.github.com/users/darrenstahlmsft/followers","following_url":"https://api.github.com/users/darrenstahlmsft/following{/other_user}","gists_url":"https://api.github.com/users/darrenstahlmsft/gists{/gist_id}","starred_url":"https://api.github.com/users/darrenstahlmsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darrenstahlmsft/subscriptions","organizations_url":"https://api.github.com/users/darrenstahlmsft/orgs","repos_url":"https://api.github.com/users/darrenstahlmsft/repos","events_url":"https://api.github.com/users/darrenstahlmsft/events{/privacy}","received_events_url":"https://api.github.com/users/darrenstahlmsft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darrenstahlmsft/hcsshim","description":"Windows - Host Compute Service Shim","fork":true,"url":"https://api.github.com/repos/darrenstahlmsft/hcsshim","forks_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/forks","keys_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/teams","hooks_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/hooks","issue_events_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/issues/events{/number}","events_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/events","assignees_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/assignees{/user}","branches_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/branches{/branch}","tags_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/tags","blobs_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/git/refs{/sha}","trees_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/statuses/{sha}","languages_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/languages","stargazers_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/stargazers","contributors_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/contributors","subscribers_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/subscribers","subscription_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/subscription","commits_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/commits{/sha}","git_commits_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/git/commits{/sha}","comments_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/comments{/number}","issue_comment_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/issues/comments{/number}","contents_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/contents/{+path}","compare_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/merges","archive_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/downloads","issues_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/issues{/number}","pulls_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/pulls{/number}","milestones_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/milestones{/number}","notifications_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/labels{/name}","releases_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/releases{/id}","deployments_url":"https://api.github.com/repos/darrenstahlmsft/hcsshim/deployments","created_at":"2016-07-19T23:14:49Z","updated_at":"2016-07-19T23:14:49Z","pushed_at":"2018-02-13T01:08:58Z","git_url":"git://github.com/darrenstahlmsft/hcsshim.git","ssh_url":"git@github.com:darrenstahlmsft/hcsshim.git","clone_url":"https://github.com/darrenstahlmsft/hcsshim.git","svn_url":"https://github.com/darrenstahlmsft/hcsshim","homepage":null,"size":414,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"216772e344403bb9fa8b04be64e6f64fa934b492","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":38258831,"name":"hcsshim","full_name":"Microsoft/hcsshim","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/hcsshim","description":"Windows - Host Compute Service Shim","fork":false,"url":"https://api.github.com/repos/Microsoft/hcsshim","forks_url":"https://api.github.com/repos/Microsoft/hcsshim/forks","keys_url":"https://api.github.com/repos/Microsoft/hcsshim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/hcsshim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/hcsshim/teams","hooks_url":"https://api.github.com/repos/Microsoft/hcsshim/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/hcsshim/events","assignees_url":"https://api.github.com/repos/Microsoft/hcsshim/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/hcsshim/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/hcsshim/tags","blobs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/hcsshim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/hcsshim/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/hcsshim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/hcsshim/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/hcsshim/languages","stargazers_url":"https://api.github.com/repos/Microsoft/hcsshim/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/hcsshim/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/hcsshim/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/hcsshim/subscription","commits_url":"https://api.github.com/repos/Microsoft/hcsshim/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/hcsshim/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/hcsshim/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/hcsshim/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/hcsshim/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/hcsshim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/hcsshim/merges","archive_url":"https://api.github.com/repos/Microsoft/hcsshim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/hcsshim/downloads","issues_url":"https://api.github.com/repos/Microsoft/hcsshim/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/hcsshim/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/hcsshim/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/hcsshim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/hcsshim/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/hcsshim/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/hcsshim/deployments","created_at":"2015-06-29T16:44:26Z","updated_at":"2018-02-13T22:52:05Z","pushed_at":"2018-02-13T20:02:59Z","git_url":"git://github.com/Microsoft/hcsshim.git","ssh_url":"git@github.com:Microsoft/hcsshim.git","clone_url":"https://github.com/Microsoft/hcsshim.git","svn_url":"https://github.com/Microsoft/hcsshim","homepage":null,"size":394,"stargazers_count":101,"watchers_count":101,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":35,"open_issues":17,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/160"},"html":{"href":"https://github.com/Microsoft/hcsshim/pull/160"},"issue":{"href":"https://api.github.com/repos/Microsoft/hcsshim/issues/160"},"comments":{"href":"https://api.github.com/repos/Microsoft/hcsshim/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/hcsshim/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/hcsshim/statuses/17609bd542312d7b4adde84ae717bfd7ddeffe46"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jstarks"}}