{"action":"closed","number":74,"pull_request":{"url":"https://api.github.com/repos/edx/edx-lint/pulls/74","id":231782739,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzgyNzM5","html_url":"https://github.com/edx/edx-lint/pull/74","diff_url":"https://github.com/edx/edx-lint/pull/74.diff","patch_url":"https://github.com/edx/edx-lint/pull/74.patch","issue_url":"https://api.github.com/repos/edx/edx-lint/issues/74","number":74,"state":"closed","locked":false,"title":"Convert tests to integration tests","user":{"login":"nedbat","id":23789,"node_id":"MDQ6VXNlcjIzNzg5","avatar_url":"https://avatars1.githubusercontent.com/u/23789?v=4","gravatar_id":"","url":"https://api.github.com/users/nedbat","html_url":"https://github.com/nedbat","followers_url":"https://api.github.com/users/nedbat/followers","following_url":"https://api.github.com/users/nedbat/following{/other_user}","gists_url":"https://api.github.com/users/nedbat/gists{/gist_id}","starred_url":"https://api.github.com/users/nedbat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedbat/subscriptions","organizations_url":"https://api.github.com/users/nedbat/orgs","repos_url":"https://api.github.com/users/nedbat/repos","events_url":"https://api.github.com/users/nedbat/events{/privacy}","received_events_url":"https://api.github.com/users/nedbat/received_events","type":"User","site_admin":false},"body":"1. Create a helper, `run_pylint` that runs all of pylint for a test.  This has a few benefits:\r\n    - Removes the coupling of our tests to internal details like `visit_call`.\r\n    - Lets us test ITokenCheckers. The pylint docs have no examples of how to test those.\r\n    - Lets us test all aspects of our checkers, including whether they can be disabled with pragmas.\r\n1. Use tox to run on Python 2.7 and Python 3.6, and also on differing pylint versions, so we'll have better advance warning if the internals change out from under us.\r\n1. Remove required_base_class checker: I forget why we wrote it, but nothing in the edx organization is using it.\r\n1. Add a missing check to simplifiable-range.","created_at":"2018-11-18T11:32:58Z","updated_at":"2018-11-20T20:49:22Z","closed_at":"2018-11-20T20:49:21Z","merged_at":"2018-11-20T20:49:21Z","merge_commit_sha":"29cac522d3d5b35175f48a73b6065c4752c679f4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-lint/pulls/74/commits","review_comments_url":"https://api.github.com/repos/edx/edx-lint/pulls/74/comments","review_comment_url":"https://api.github.com/repos/edx/edx-lint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-lint/issues/74/comments","statuses_url":"https://api.github.com/repos/edx/edx-lint/statuses/ef148f561127e6378f30edffdac372ebaa83bbf8","head":{"label":"edx:nedbat/integration-tests","ref":"nedbat/integration-tests","sha":"ef148f561127e6378f30edffdac372ebaa83bbf8","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30004785,"node_id":"MDEwOlJlcG9zaXRvcnkzMDAwNDc4NQ==","name":"edx-lint","full_name":"edx/edx-lint","private":false,"owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edx/edx-lint","description":"repo to contain any/all pylint checkers","fork":false,"url":"https://api.github.com/repos/edx/edx-lint","forks_url":"https://api.github.com/repos/edx/edx-lint/forks","keys_url":"https://api.github.com/repos/edx/edx-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-lint/teams","hooks_url":"https://api.github.com/repos/edx/edx-lint/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-lint/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-lint/events","assignees_url":"https://api.github.com/repos/edx/edx-lint/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-lint/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-lint/tags","blobs_url":"https://api.github.com/repos/edx/edx-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-lint/languages","stargazers_url":"https://api.github.com/repos/edx/edx-lint/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-lint/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-lint/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-lint/subscription","commits_url":"https://api.github.com/repos/edx/edx-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-lint/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-lint/merges","archive_url":"https://api.github.com/repos/edx/edx-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-lint/downloads","issues_url":"https://api.github.com/repos/edx/edx-lint/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-lint/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-lint/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-lint/deployments","created_at":"2015-01-29T05:14:33Z","updated_at":"2018-11-15T16:36:26Z","pushed_at":"2018-11-20T20:49:21Z","git_url":"git://github.com/edx/edx-lint.git","ssh_url":"git@github.com:edx/edx-lint.git","clone_url":"https://github.com/edx/edx-lint.git","svn_url":"https://github.com/edx/edx-lint","homepage":null,"size":186,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":6,"watchers":21,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"8d6581d91f163e938d694795b367633f7da0b455","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":30004785,"node_id":"MDEwOlJlcG9zaXRvcnkzMDAwNDc4NQ==","name":"edx-lint","full_name":"edx/edx-lint","private":false,"owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/edx/edx-lint","description":"repo to contain any/all pylint checkers","fork":false,"url":"https://api.github.com/repos/edx/edx-lint","forks_url":"https://api.github.com/repos/edx/edx-lint/forks","keys_url":"https://api.github.com/repos/edx/edx-lint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-lint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-lint/teams","hooks_url":"https://api.github.com/repos/edx/edx-lint/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-lint/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-lint/events","assignees_url":"https://api.github.com/repos/edx/edx-lint/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-lint/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-lint/tags","blobs_url":"https://api.github.com/repos/edx/edx-lint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-lint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-lint/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-lint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-lint/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-lint/languages","stargazers_url":"https://api.github.com/repos/edx/edx-lint/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-lint/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-lint/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-lint/subscription","commits_url":"https://api.github.com/repos/edx/edx-lint/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-lint/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-lint/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-lint/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-lint/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-lint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-lint/merges","archive_url":"https://api.github.com/repos/edx/edx-lint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-lint/downloads","issues_url":"https://api.github.com/repos/edx/edx-lint/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-lint/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-lint/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-lint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-lint/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-lint/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-lint/deployments","created_at":"2015-01-29T05:14:33Z","updated_at":"2018-11-15T16:36:26Z","pushed_at":"2018-11-20T20:49:21Z","git_url":"git://github.com/edx/edx-lint.git","ssh_url":"git@github.com:edx/edx-lint.git","clone_url":"https://github.com/edx/edx-lint.git","svn_url":"https://github.com/edx/edx-lint","homepage":null,"size":186,"stargazers_count":21,"watchers_count":21,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":6,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/74"},"html":{"href":"https://github.com/edx/edx-lint/pull/74"},"issue":{"href":"https://api.github.com/repos/edx/edx-lint/issues/74"},"comments":{"href":"https://api.github.com/repos/edx/edx-lint/issues/74/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/74/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-lint/pulls/74/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-lint/statuses/ef148f561127e6378f30edffdac372ebaa83bbf8"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nedbat","id":23789,"node_id":"MDQ6VXNlcjIzNzg5","avatar_url":"https://avatars1.githubusercontent.com/u/23789?v=4","gravatar_id":"","url":"https://api.github.com/users/nedbat","html_url":"https://github.com/nedbat","followers_url":"https://api.github.com/users/nedbat/followers","following_url":"https://api.github.com/users/nedbat/following{/other_user}","gists_url":"https://api.github.com/users/nedbat/gists{/gist_id}","starred_url":"https://api.github.com/users/nedbat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nedbat/subscriptions","organizations_url":"https://api.github.com/users/nedbat/orgs","repos_url":"https://api.github.com/users/nedbat/repos","events_url":"https://api.github.com/users/nedbat/events{/privacy}","received_events_url":"https://api.github.com/users/nedbat/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":477,"deletions":525,"changed_files":15}}
{"actor":{"display_login":"nedbat"}}