{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/51672","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/51672/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/51672/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/51672/events","html_url":"https://github.com/NixOS/nixpkgs/pull/51672","id":388764021,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTU0MDgz","number":51672,"title":"vulkan-validation-layers: 1.1.82.0 -> 1.1.85.0","user":{"login":"acowley","id":124545,"node_id":"MDQ6VXNlcjEyNDU0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/124545?v=4","gravatar_id":"","url":"https://api.github.com/users/acowley","html_url":"https://github.com/acowley","followers_url":"https://api.github.com/users/acowley/followers","following_url":"https://api.github.com/users/acowley/following{/other_user}","gists_url":"https://api.github.com/users/acowley/gists{/gist_id}","starred_url":"https://api.github.com/users/acowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acowley/subscriptions","organizations_url":"https://api.github.com/users/acowley/orgs","repos_url":"https://api.github.com/users/acowley/repos","events_url":"https://api.github.com/users/acowley/events{/privacy}","received_events_url":"https://api.github.com/users/acowley/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-07T18:24:42Z","updated_at":"2018-12-15T20:06:24Z","closed_at":"2018-12-15T20:06:24Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/51672","html_url":"https://github.com/NixOS/nixpkgs/pull/51672","diff_url":"https://github.com/NixOS/nixpkgs/pull/51672.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/51672.patch"},"body":"This requires knock-on upgrades for glslang and spirv-tools.\r\n\r\nI have also made the validation layers easier to use:\r\n- library files identified by layer definitions now use absolute paths\r\n- a VK_LAYER_PATH environment variable is set\r\n\r\nPreviously, one would have to modify LD_LIBRARY_PATH or install the\r\nderivation in a known location for vulkan-loader to find relevant\r\nfiles. These changes make using validation layers in a nix-shell work automatically.\r\n\r\n###### Motivation for this change\r\n\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Assured whether relevant documentation is up to date\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/447594442","html_url":"https://github.com/NixOS/nixpkgs/pull/51672#issuecomment-447594442","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/51672","id":447594442,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzU5NDQ0Mg==","user":{"login":"acowley","id":124545,"node_id":"MDQ6VXNlcjEyNDU0NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/124545?v=4","gravatar_id":"","url":"https://api.github.com/users/acowley","html_url":"https://github.com/acowley","followers_url":"https://api.github.com/users/acowley/followers","following_url":"https://api.github.com/users/acowley/following{/other_user}","gists_url":"https://api.github.com/users/acowley/gists{/gist_id}","starred_url":"https://api.github.com/users/acowley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acowley/subscriptions","organizations_url":"https://api.github.com/users/acowley/orgs","repos_url":"https://api.github.com/users/acowley/repos","events_url":"https://api.github.com/users/acowley/events{/privacy}","received_events_url":"https://api.github.com/users/acowley/received_events","type":"User","site_admin":false},"created_at":"2018-12-15T20:06:24Z","updated_at":"2018-12-15T20:06:24Z","author_association":"CONTRIBUTOR","body":"I'm not sure how to advance this as it was intended primarily as a usability improvement since I had trouble making the existing packaging work. There is a reasonable argument that this constellation of packages -- vulkan-loader, vulkan-headers, glslang, spirv-tools, spirv-headers, and probably others -- should be reconsidered given the way upstream cuts releases. Namely, upstream effectively treats everything as a submodule, but doesn't use the native git mechanisms for doing so. \r\n\r\nIt might make sense, then, for nixpkgs to move dependencies into the packages that require them (either as `let` bindings or separate `.nix` files in, e.g., the `vulkan-validation-layers` directory) rather than placing particular revisions into the `nixpkgs` name space. We would probably want to take care that things like `vulkan-headers` and `vulkan-loader` not exist at multiple distinct revisions across nixpkgs, but we can hope that the relevant `known_good.json` won't demand that.\r\n\r\nI'm not going to make a sweeping change as I don't know if there is a broader willingness to do so, and everything other than the validation layers was already working fine. But it seems that this PR is stuck on the derivation naming objection until someone does the necessary refactoring.\r\n\r\nI'll try to find a home for the usability changes on NUR or somewhere so anyone else wanting to use the validation layers can have an easier time."}}
{"actor":{"display_login":"acowley"}}