{"action":"created","comment":{"url":"https://api.github.com/repos/yodaos-project/yodart/pulls/comments/244006766","pull_request_review_id":187909700,"id":244006766,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDAwNjc2Ng==","diff_hunk":"@@ -169,7 +169,7 @@ BluetoothA2dp.prototype.handleEvent = function (data, mode) {\n       var results = msg.results\r\n       var nbr = results.deviceList != null ? results.deviceList.length : 0\r\n       logger.debug(`Found ${nbr} devices, is_comp: ${results.is_completed}, currentDevice: ${results.currentDevice}`)\r\n-      for (var i = 0; i < nbr; i++) {\r\n+      for (i = 0; i < nbr; i++) {\r","path":"packages/@yoda/bluetooth/a2dp.js","position":5,"original_position":5,"commit_id":"e9b6b02edacc7c2ab426441243e289ae2267989a","original_commit_id":"e9b6b02edacc7c2ab426441243e289ae2267989a","user":{"login":"yorkie","id":1935767,"node_id":"MDQ6VXNlcjE5MzU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1935767?v=4","gravatar_id":"","url":"https://api.github.com/users/yorkie","html_url":"https://github.com/yorkie","followers_url":"https://api.github.com/users/yorkie/followers","following_url":"https://api.github.com/users/yorkie/following{/other_user}","gists_url":"https://api.github.com/users/yorkie/gists{/gist_id}","starred_url":"https://api.github.com/users/yorkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yorkie/subscriptions","organizations_url":"https://api.github.com/users/yorkie/orgs","repos_url":"https://api.github.com/users/yorkie/repos","events_url":"https://api.github.com/users/yorkie/events{/privacy}","received_events_url":"https://api.github.com/users/yorkie/received_events","type":"User","site_admin":false},"body":"`var` statement is function scoped, then you declare a variable `i`, so that the CI reports that you redeclaration here. Remove the `var` is not the right way, I think creating scope by wrapping function is the only way to do.","created_at":"2018-12-26T15:02:28Z","updated_at":"2018-12-26T15:03:16Z","html_url":"https://github.com/yodaos-project/yodart/pull/165#discussion_r244006766","pull_request_url":"https://api.github.com/repos/yodaos-project/yodart/pulls/165","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/yodaos-project/yodart/pulls/comments/244006766"},"html":{"href":"https://github.com/yodaos-project/yodart/pull/165#discussion_r244006766"},"pull_request":{"href":"https://api.github.com/repos/yodaos-project/yodart/pulls/165"}}},"pull_request":{"url":"https://api.github.com/repos/yodaos-project/yodart/pulls/165","id":240990083,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwOTkwMDgz","html_url":"https://github.com/yodaos-project/yodart/pull/165","diff_url":"https://github.com/yodaos-project/yodart/pull/165.diff","patch_url":"https://github.com/yodaos-project/yodart/pull/165.patch","issue_url":"https://api.github.com/repos/yodaos-project/yodart/issues/165","number":165,"state":"open","locked":false,"title":"bluetooth: fix lint error.","user":{"login":"morrowind","id":3897197,"node_id":"MDQ6VXNlcjM4OTcxOTc=","avatar_url":"https://avatars0.githubusercontent.com/u/3897197?v=4","gravatar_id":"","url":"https://api.github.com/users/morrowind","html_url":"https://github.com/morrowind","followers_url":"https://api.github.com/users/morrowind/followers","following_url":"https://api.github.com/users/morrowind/following{/other_user}","gists_url":"https://api.github.com/users/morrowind/gists{/gist_id}","starred_url":"https://api.github.com/users/morrowind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrowind/subscriptions","organizations_url":"https://api.github.com/users/morrowind/orgs","repos_url":"https://api.github.com/users/morrowind/repos","events_url":"https://api.github.com/users/morrowind/events{/privacy}","received_events_url":"https://api.github.com/users/morrowind/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `npm test` passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n","created_at":"2018-12-26T14:34:48Z","updated_at":"2018-12-26T15:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2204e2ac0b3af29b719935bd18527375130059da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yodaos-project/yodart/pulls/165/commits","review_comments_url":"https://api.github.com/repos/yodaos-project/yodart/pulls/165/comments","review_comment_url":"https://api.github.com/repos/yodaos-project/yodart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yodaos-project/yodart/issues/165/comments","statuses_url":"https://api.github.com/repos/yodaos-project/yodart/statuses/e9b6b02edacc7c2ab426441243e289ae2267989a","head":{"label":"yodaos-project:bt-a2dp","ref":"bt-a2dp","sha":"e9b6b02edacc7c2ab426441243e289ae2267989a","user":{"login":"yodaos-project","id":44940191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTQwMTkx","avatar_url":"https://avatars3.githubusercontent.com/u/44940191?v=4","gravatar_id":"","url":"https://api.github.com/users/yodaos-project","html_url":"https://github.com/yodaos-project","followers_url":"https://api.github.com/users/yodaos-project/followers","following_url":"https://api.github.com/users/yodaos-project/following{/other_user}","gists_url":"https://api.github.com/users/yodaos-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yodaos-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodaos-project/subscriptions","organizations_url":"https://api.github.com/users/yodaos-project/orgs","repos_url":"https://api.github.com/users/yodaos-project/repos","events_url":"https://api.github.com/users/yodaos-project/events{/privacy}","received_events_url":"https://api.github.com/users/yodaos-project/received_events","type":"Organization","site_admin":false},"repo":{"id":107176160,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxNzYxNjA=","name":"yodart","full_name":"yodaos-project/yodart","private":false,"owner":{"login":"yodaos-project","id":44940191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTQwMTkx","avatar_url":"https://avatars3.githubusercontent.com/u/44940191?v=4","gravatar_id":"","url":"https://api.github.com/users/yodaos-project","html_url":"https://github.com/yodaos-project","followers_url":"https://api.github.com/users/yodaos-project/followers","following_url":"https://api.github.com/users/yodaos-project/following{/other_user}","gists_url":"https://api.github.com/users/yodaos-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yodaos-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodaos-project/subscriptions","organizations_url":"https://api.github.com/users/yodaos-project/orgs","repos_url":"https://api.github.com/users/yodaos-project/repos","events_url":"https://api.github.com/users/yodaos-project/events{/privacy}","received_events_url":"https://api.github.com/users/yodaos-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yodaos-project/yodart","description":"JavaScript VUI Framework 👽🚀","fork":false,"url":"https://api.github.com/repos/yodaos-project/yodart","forks_url":"https://api.github.com/repos/yodaos-project/yodart/forks","keys_url":"https://api.github.com/repos/yodaos-project/yodart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yodaos-project/yodart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yodaos-project/yodart/teams","hooks_url":"https://api.github.com/repos/yodaos-project/yodart/hooks","issue_events_url":"https://api.github.com/repos/yodaos-project/yodart/issues/events{/number}","events_url":"https://api.github.com/repos/yodaos-project/yodart/events","assignees_url":"https://api.github.com/repos/yodaos-project/yodart/assignees{/user}","branches_url":"https://api.github.com/repos/yodaos-project/yodart/branches{/branch}","tags_url":"https://api.github.com/repos/yodaos-project/yodart/tags","blobs_url":"https://api.github.com/repos/yodaos-project/yodart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yodaos-project/yodart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yodaos-project/yodart/git/refs{/sha}","trees_url":"https://api.github.com/repos/yodaos-project/yodart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yodaos-project/yodart/statuses/{sha}","languages_url":"https://api.github.com/repos/yodaos-project/yodart/languages","stargazers_url":"https://api.github.com/repos/yodaos-project/yodart/stargazers","contributors_url":"https://api.github.com/repos/yodaos-project/yodart/contributors","subscribers_url":"https://api.github.com/repos/yodaos-project/yodart/subscribers","subscription_url":"https://api.github.com/repos/yodaos-project/yodart/subscription","commits_url":"https://api.github.com/repos/yodaos-project/yodart/commits{/sha}","git_commits_url":"https://api.github.com/repos/yodaos-project/yodart/git/commits{/sha}","comments_url":"https://api.github.com/repos/yodaos-project/yodart/comments{/number}","issue_comment_url":"https://api.github.com/repos/yodaos-project/yodart/issues/comments{/number}","contents_url":"https://api.github.com/repos/yodaos-project/yodart/contents/{+path}","compare_url":"https://api.github.com/repos/yodaos-project/yodart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yodaos-project/yodart/merges","archive_url":"https://api.github.com/repos/yodaos-project/yodart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yodaos-project/yodart/downloads","issues_url":"https://api.github.com/repos/yodaos-project/yodart/issues{/number}","pulls_url":"https://api.github.com/repos/yodaos-project/yodart/pulls{/number}","milestones_url":"https://api.github.com/repos/yodaos-project/yodart/milestones{/number}","notifications_url":"https://api.github.com/repos/yodaos-project/yodart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yodaos-project/yodart/labels{/name}","releases_url":"https://api.github.com/repos/yodaos-project/yodart/releases{/id}","deployments_url":"https://api.github.com/repos/yodaos-project/yodart/deployments","created_at":"2017-10-16T19:54:23Z","updated_at":"2018-12-26T11:46:03Z","pushed_at":"2018-12-26T14:46:13Z","git_url":"git://github.com/yodaos-project/yodart.git","ssh_url":"git@github.com:yodaos-project/yodart.git","clone_url":"https://github.com/yodaos-project/yodart.git","svn_url":"https://github.com/yodaos-project/yodart","homepage":"https://yodaos.rokid.com","size":6697,"stargazers_count":130,"watchers_count":130,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":49,"watchers":130,"default_branch":"master"}},"base":{"label":"yodaos-project:master","ref":"master","sha":"175a296686da3d32d2c3be1ba7f70b027c0b5d68","user":{"login":"yodaos-project","id":44940191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTQwMTkx","avatar_url":"https://avatars3.githubusercontent.com/u/44940191?v=4","gravatar_id":"","url":"https://api.github.com/users/yodaos-project","html_url":"https://github.com/yodaos-project","followers_url":"https://api.github.com/users/yodaos-project/followers","following_url":"https://api.github.com/users/yodaos-project/following{/other_user}","gists_url":"https://api.github.com/users/yodaos-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yodaos-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodaos-project/subscriptions","organizations_url":"https://api.github.com/users/yodaos-project/orgs","repos_url":"https://api.github.com/users/yodaos-project/repos","events_url":"https://api.github.com/users/yodaos-project/events{/privacy}","received_events_url":"https://api.github.com/users/yodaos-project/received_events","type":"Organization","site_admin":false},"repo":{"id":107176160,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcxNzYxNjA=","name":"yodart","full_name":"yodaos-project/yodart","private":false,"owner":{"login":"yodaos-project","id":44940191,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ0OTQwMTkx","avatar_url":"https://avatars3.githubusercontent.com/u/44940191?v=4","gravatar_id":"","url":"https://api.github.com/users/yodaos-project","html_url":"https://github.com/yodaos-project","followers_url":"https://api.github.com/users/yodaos-project/followers","following_url":"https://api.github.com/users/yodaos-project/following{/other_user}","gists_url":"https://api.github.com/users/yodaos-project/gists{/gist_id}","starred_url":"https://api.github.com/users/yodaos-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yodaos-project/subscriptions","organizations_url":"https://api.github.com/users/yodaos-project/orgs","repos_url":"https://api.github.com/users/yodaos-project/repos","events_url":"https://api.github.com/users/yodaos-project/events{/privacy}","received_events_url":"https://api.github.com/users/yodaos-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/yodaos-project/yodart","description":"JavaScript VUI Framework 👽🚀","fork":false,"url":"https://api.github.com/repos/yodaos-project/yodart","forks_url":"https://api.github.com/repos/yodaos-project/yodart/forks","keys_url":"https://api.github.com/repos/yodaos-project/yodart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yodaos-project/yodart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yodaos-project/yodart/teams","hooks_url":"https://api.github.com/repos/yodaos-project/yodart/hooks","issue_events_url":"https://api.github.com/repos/yodaos-project/yodart/issues/events{/number}","events_url":"https://api.github.com/repos/yodaos-project/yodart/events","assignees_url":"https://api.github.com/repos/yodaos-project/yodart/assignees{/user}","branches_url":"https://api.github.com/repos/yodaos-project/yodart/branches{/branch}","tags_url":"https://api.github.com/repos/yodaos-project/yodart/tags","blobs_url":"https://api.github.com/repos/yodaos-project/yodart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yodaos-project/yodart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yodaos-project/yodart/git/refs{/sha}","trees_url":"https://api.github.com/repos/yodaos-project/yodart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yodaos-project/yodart/statuses/{sha}","languages_url":"https://api.github.com/repos/yodaos-project/yodart/languages","stargazers_url":"https://api.github.com/repos/yodaos-project/yodart/stargazers","contributors_url":"https://api.github.com/repos/yodaos-project/yodart/contributors","subscribers_url":"https://api.github.com/repos/yodaos-project/yodart/subscribers","subscription_url":"https://api.github.com/repos/yodaos-project/yodart/subscription","commits_url":"https://api.github.com/repos/yodaos-project/yodart/commits{/sha}","git_commits_url":"https://api.github.com/repos/yodaos-project/yodart/git/commits{/sha}","comments_url":"https://api.github.com/repos/yodaos-project/yodart/comments{/number}","issue_comment_url":"https://api.github.com/repos/yodaos-project/yodart/issues/comments{/number}","contents_url":"https://api.github.com/repos/yodaos-project/yodart/contents/{+path}","compare_url":"https://api.github.com/repos/yodaos-project/yodart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yodaos-project/yodart/merges","archive_url":"https://api.github.com/repos/yodaos-project/yodart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yodaos-project/yodart/downloads","issues_url":"https://api.github.com/repos/yodaos-project/yodart/issues{/number}","pulls_url":"https://api.github.com/repos/yodaos-project/yodart/pulls{/number}","milestones_url":"https://api.github.com/repos/yodaos-project/yodart/milestones{/number}","notifications_url":"https://api.github.com/repos/yodaos-project/yodart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yodaos-project/yodart/labels{/name}","releases_url":"https://api.github.com/repos/yodaos-project/yodart/releases{/id}","deployments_url":"https://api.github.com/repos/yodaos-project/yodart/deployments","created_at":"2017-10-16T19:54:23Z","updated_at":"2018-12-26T11:46:03Z","pushed_at":"2018-12-26T14:46:13Z","git_url":"git://github.com/yodaos-project/yodart.git","ssh_url":"git@github.com:yodaos-project/yodart.git","clone_url":"https://github.com/yodaos-project/yodart.git","svn_url":"https://github.com/yodaos-project/yodart","homepage":"https://yodaos.rokid.com","size":6697,"stargazers_count":130,"watchers_count":130,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":49,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yodaos-project/yodart/pulls/165"},"html":{"href":"https://github.com/yodaos-project/yodart/pull/165"},"issue":{"href":"https://api.github.com/repos/yodaos-project/yodart/issues/165"},"comments":{"href":"https://api.github.com/repos/yodaos-project/yodart/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/yodaos-project/yodart/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/yodaos-project/yodart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yodaos-project/yodart/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/yodaos-project/yodart/statuses/e9b6b02edacc7c2ab426441243e289ae2267989a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"yorkie"}}