{"action":"opened","number":180,"pull_request":{"url":"https://api.github.com/repos/Microsoft/thrifty/pulls/180","id":203948084,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzOTQ4MDg0","html_url":"https://github.com/Microsoft/thrifty/pull/180","diff_url":"https://github.com/Microsoft/thrifty/pull/180.diff","patch_url":"https://github.com/Microsoft/thrifty/pull/180.patch","issue_url":"https://api.github.com/repos/Microsoft/thrifty/issues/180","number":180,"state":"open","locked":false,"title":"Port the remainder of thrifty-schema to Kotlin","user":{"login":"benjamin-bader","id":512212,"node_id":"MDQ6VXNlcjUxMjIxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/512212?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamin-bader","html_url":"https://github.com/benjamin-bader","followers_url":"https://api.github.com/users/benjamin-bader/followers","following_url":"https://api.github.com/users/benjamin-bader/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-bader/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-bader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-bader/subscriptions","organizations_url":"https://api.github.com/users/benjamin-bader/orgs","repos_url":"https://api.github.com/users/benjamin-bader/repos","events_url":"https://api.github.com/users/benjamin-bader/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-bader/received_events","type":"User","site_admin":false},"body":"This PR represents a series of smaller commits, each one porting a piece of the ThriftType hierarchy, roughly from the leaves down to the root, culminating with the port of ThriftType itself.  It's a massive change - we will have to trust the integration tests to confirm that things are still working as intended.\r\n\r\nThis does _not_ represent the end of our efforts - we can make much more idiomatic use of Kotlin than this.  In particular, the porting effort has thrown a spotlight on a latent design flaw - the UserTypes are invalid when created, which makes fine-grained unit testing extraordinarily difficult without reflection or mocks.  We may decide to live with it, or we might also decide to split up ThriftType into pre- and post-linking immutable representations.\r\n\r\nFinally, we haven't begun to explore using sealed classes or data classes, which promise to eliminate a good amount of boilerplate and infrastructure code.","created_at":"2018-07-25T20:05:28Z","updated_at":"2018-07-25T20:05:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/thrifty/pulls/180/commits","review_comments_url":"https://api.github.com/repos/Microsoft/thrifty/pulls/180/comments","review_comment_url":"https://api.github.com/repos/Microsoft/thrifty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/thrifty/issues/180/comments","statuses_url":"https://api.github.com/repos/Microsoft/thrifty/statuses/6096cfc5e3743ac12c24febfa858e0c11ae94121","head":{"label":"benjamin-bader:kotlin/thrift-type","ref":"kotlin/thrift-type","sha":"6096cfc5e3743ac12c24febfa858e0c11ae94121","user":{"login":"benjamin-bader","id":512212,"node_id":"MDQ6VXNlcjUxMjIxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/512212?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamin-bader","html_url":"https://github.com/benjamin-bader","followers_url":"https://api.github.com/users/benjamin-bader/followers","following_url":"https://api.github.com/users/benjamin-bader/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-bader/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-bader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-bader/subscriptions","organizations_url":"https://api.github.com/users/benjamin-bader/orgs","repos_url":"https://api.github.com/users/benjamin-bader/repos","events_url":"https://api.github.com/users/benjamin-bader/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-bader/received_events","type":"User","site_admin":false},"repo":{"id":52393048,"node_id":"MDEwOlJlcG9zaXRvcnk1MjM5MzA0OA==","name":"thrifty","full_name":"benjamin-bader/thrifty","owner":{"login":"benjamin-bader","id":512212,"node_id":"MDQ6VXNlcjUxMjIxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/512212?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamin-bader","html_url":"https://github.com/benjamin-bader","followers_url":"https://api.github.com/users/benjamin-bader/followers","following_url":"https://api.github.com/users/benjamin-bader/following{/other_user}","gists_url":"https://api.github.com/users/benjamin-bader/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamin-bader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamin-bader/subscriptions","organizations_url":"https://api.github.com/users/benjamin-bader/orgs","repos_url":"https://api.github.com/users/benjamin-bader/repos","events_url":"https://api.github.com/users/benjamin-bader/events{/privacy}","received_events_url":"https://api.github.com/users/benjamin-bader/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjamin-bader/thrifty","description":"Thrift for Android that saves you methods","fork":true,"url":"https://api.github.com/repos/benjamin-bader/thrifty","forks_url":"https://api.github.com/repos/benjamin-bader/thrifty/forks","keys_url":"https://api.github.com/repos/benjamin-bader/thrifty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjamin-bader/thrifty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjamin-bader/thrifty/teams","hooks_url":"https://api.github.com/repos/benjamin-bader/thrifty/hooks","issue_events_url":"https://api.github.com/repos/benjamin-bader/thrifty/issues/events{/number}","events_url":"https://api.github.com/repos/benjamin-bader/thrifty/events","assignees_url":"https://api.github.com/repos/benjamin-bader/thrifty/assignees{/user}","branches_url":"https://api.github.com/repos/benjamin-bader/thrifty/branches{/branch}","tags_url":"https://api.github.com/repos/benjamin-bader/thrifty/tags","blobs_url":"https://api.github.com/repos/benjamin-bader/thrifty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjamin-bader/thrifty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjamin-bader/thrifty/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjamin-bader/thrifty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjamin-bader/thrifty/statuses/{sha}","languages_url":"https://api.github.com/repos/benjamin-bader/thrifty/languages","stargazers_url":"https://api.github.com/repos/benjamin-bader/thrifty/stargazers","contributors_url":"https://api.github.com/repos/benjamin-bader/thrifty/contributors","subscribers_url":"https://api.github.com/repos/benjamin-bader/thrifty/subscribers","subscription_url":"https://api.github.com/repos/benjamin-bader/thrifty/subscription","commits_url":"https://api.github.com/repos/benjamin-bader/thrifty/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjamin-bader/thrifty/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjamin-bader/thrifty/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjamin-bader/thrifty/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjamin-bader/thrifty/contents/{+path}","compare_url":"https://api.github.com/repos/benjamin-bader/thrifty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjamin-bader/thrifty/merges","archive_url":"https://api.github.com/repos/benjamin-bader/thrifty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjamin-bader/thrifty/downloads","issues_url":"https://api.github.com/repos/benjamin-bader/thrifty/issues{/number}","pulls_url":"https://api.github.com/repos/benjamin-bader/thrifty/pulls{/number}","milestones_url":"https://api.github.com/repos/benjamin-bader/thrifty/milestones{/number}","notifications_url":"https://api.github.com/repos/benjamin-bader/thrifty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjamin-bader/thrifty/labels{/name}","releases_url":"https://api.github.com/repos/benjamin-bader/thrifty/releases{/id}","deployments_url":"https://api.github.com/repos/benjamin-bader/thrifty/deployments","created_at":"2016-02-23T21:30:44Z","updated_at":"2018-07-18T22:00:14Z","pushed_at":"2018-07-25T20:00:52Z","git_url":"git://github.com/benjamin-bader/thrifty.git","ssh_url":"git@github.com:benjamin-bader/thrifty.git","clone_url":"https://github.com/benjamin-bader/thrifty.git","svn_url":"https://github.com/benjamin-bader/thrifty","homepage":"","size":1413,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"7eb82dd7597e8faee670df3e66ee451006476681","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":52308103,"node_id":"MDEwOlJlcG9zaXRvcnk1MjMwODEwMw==","name":"thrifty","full_name":"Microsoft/thrifty","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/thrifty","description":"Thrift for Android that saves you methods","fork":false,"url":"https://api.github.com/repos/Microsoft/thrifty","forks_url":"https://api.github.com/repos/Microsoft/thrifty/forks","keys_url":"https://api.github.com/repos/Microsoft/thrifty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/thrifty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/thrifty/teams","hooks_url":"https://api.github.com/repos/Microsoft/thrifty/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/thrifty/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/thrifty/events","assignees_url":"https://api.github.com/repos/Microsoft/thrifty/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/thrifty/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/thrifty/tags","blobs_url":"https://api.github.com/repos/Microsoft/thrifty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/thrifty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/thrifty/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/thrifty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/thrifty/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/thrifty/languages","stargazers_url":"https://api.github.com/repos/Microsoft/thrifty/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/thrifty/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/thrifty/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/thrifty/subscription","commits_url":"https://api.github.com/repos/Microsoft/thrifty/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/thrifty/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/thrifty/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/thrifty/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/thrifty/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/thrifty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/thrifty/merges","archive_url":"https://api.github.com/repos/Microsoft/thrifty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/thrifty/downloads","issues_url":"https://api.github.com/repos/Microsoft/thrifty/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/thrifty/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/thrifty/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/thrifty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/thrifty/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/thrifty/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/thrifty/deployments","created_at":"2016-02-22T21:42:55Z","updated_at":"2018-07-23T00:40:00Z","pushed_at":"2018-07-18T21:59:49Z","git_url":"git://github.com/Microsoft/thrifty.git","ssh_url":"git@github.com:Microsoft/thrifty.git","clone_url":"https://github.com/Microsoft/thrifty.git","svn_url":"https://github.com/Microsoft/thrifty","homepage":"","size":1395,"stargazers_count":302,"watchers_count":302,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":49,"open_issues":13,"watchers":302,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/thrifty/pulls/180"},"html":{"href":"https://github.com/Microsoft/thrifty/pull/180"},"issue":{"href":"https://api.github.com/repos/Microsoft/thrifty/issues/180"},"comments":{"href":"https://api.github.com/repos/Microsoft/thrifty/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/thrifty/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/thrifty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/thrifty/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/thrifty/statuses/6096cfc5e3743ac12c24febfa858e0c11ae94121"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":11,"additions":2685,"deletions":3535,"changed_files":53}}
{"actor":{"display_login":"benjamin-bader"}}