{"push_id":2660594386,"size":3,"distinct_size":3,"ref":"refs/heads/staging","head":"9ca0e2b60f26b67cee7550f913a2d2e0f7cc2814","before":"3ede858f749cc025b6ffb434d883117ce38b092c","commits":[{"sha":"d6d01dc25c027d7659f109fe845451f114d38af2","author":{"name":"Justin Jaffray","email":"0ce7911e6479995d6c346d6f03eb723b5135309e@cockroachlabs.com"},"message":"opt: add cluster setting for experimental_opt\n\nThis commit adds the `sql.defaults.optimizer` cluster setting, which\nsets the default value of the `experimental_opt` session variable. It\nalso fixes a bug in which the value of `experimental_opt` would be\nincorrectly reported as the value of the DistSQL cluster setting and\nfixes some related tests.\n\nThis cluster setting will make benchmarking the cost-based optimizer\nmuch simpler, as a single cluster can easily be used to benchmark both\nwith and without the optimizer.\n\nRelease note (sql change): Added a cluster setting to enable the\nexperimental cost-based optimizer.","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/d6d01dc25c027d7659f109fe845451f114d38af2"},{"sha":"1ab062bd487d6a53364108538045e1551f8929e4","author":{"name":"Radu Berinde","email":"8cd32adbfdfb986a6f0d684f7a16030a20d97029@cockroachlabs.com"},"message":"opt: fix GroupBy ordering issue\n\nThere is a special fast path in `buildChildProps` where we exit early\nif we don't have any required properties and the operator can't \"add\"\nany. I've been bit by this special path in `buildChildProps` a bunch\nof times: if you forget to add an exception, the errors can be subtle:\nthey only show up when there is no required property (in particular,\ntop-level expressions always have a presentation so they wouldn't be\naffected).\n\nThis time I noticed we are missing an exception for `GroupBy`. Fixing,\nadding some relevant tests, and adding a big warning comment to help\nprevent this from happening in the future.\n\nRelease note: None","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/1ab062bd487d6a53364108538045e1551f8929e4"},{"sha":"9ca0e2b60f26b67cee7550f913a2d2e0f7cc2814","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #26299 #26863\n\n26299: opt: add cluster setting for experimental_opt r=justinj a=justinj\n\nThis commit adds the `sql.defaults.optimizer` cluster setting, which\r\nsets the default value of the `experimental_opt` session variable. It\r\nalso fixes a bug in which the value of `experimental_opt` would be\r\nincorrectly reported as the value of the DistSQL cluster setting and\r\nfixes some related tests.\r\n\r\nThis cluster setting will make benchmarking the cost-based optimizer\r\nmuch simpler, as a single cluster can easily be used to benchmark both\r\nwith and without the optimizer.\r\n\r\nNot sure if there's a nice way to test a cluster setting like this, so I just tested it manually for the time being.\r\n\r\nRelease note (sql change): Added a cluster setting to enable the\r\nexperimental cost-based optimizer.\n\n26863: opt: fix GroupBy ordering issue r=RaduBerinde a=RaduBerinde\n\nThere is a special fast path in `buildChildProps` where we exit early\r\nif we don't have any required properties and the operator can't \"add\"\r\nany. I've been bit by this special path in `buildChildProps` a bunch\r\nof times: if you forget to add an exception, the errors can be subtle:\r\nthey only show up when there is no required property (in particular,\r\ntop-level expressions always have a presentation so they wouldn't be\r\naffected).\r\n\r\nThis time I noticed we are missing an exception for `GroupBy`. Fixing,\r\nadding some relevant tests, and adding a big warning comment to help\r\nprevent this from happening in the future.\r\n\r\nRelease note: None\n\nCo-authored-by: Justin Jaffray <justin@cockroachlabs.com>\nCo-authored-by: Radu Berinde <radu@cockroachlabs.com>","distinct":true,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/9ca0e2b60f26b67cee7550f913a2d2e0f7cc2814"}]}
{"actor":{"display_login":"craig"}}