{"action":"created","issue":{"url":"https://api.github.com/repos/bkimminich/juice-shop/issues/649","repository_url":"https://api.github.com/repos/bkimminich/juice-shop","labels_url":"https://api.github.com/repos/bkimminich/juice-shop/issues/649/labels{/name}","comments_url":"https://api.github.com/repos/bkimminich/juice-shop/issues/649/comments","events_url":"https://api.github.com/repos/bkimminich/juice-shop/issues/649/events","html_url":"https://github.com/bkimminich/juice-shop/pull/649","id":343711235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjc5MTIy","number":649,"title":"Ensure OpenShift compatibility.","user":{"login":"J12934","id":13718901,"node_id":"MDQ6VXNlcjEzNzE4OTAx","avatar_url":"https://avatars2.githubusercontent.com/u/13718901?v=4","gravatar_id":"","url":"https://api.github.com/users/J12934","html_url":"https://github.com/J12934","followers_url":"https://api.github.com/users/J12934/followers","following_url":"https://api.github.com/users/J12934/following{/other_user}","gists_url":"https://api.github.com/users/J12934/gists{/gist_id}","starred_url":"https://api.github.com/users/J12934/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J12934/subscriptions","organizations_url":"https://api.github.com/users/J12934/orgs","repos_url":"https://api.github.com/users/J12934/repos","events_url":"https://api.github.com/users/J12934/events{/privacy}","received_events_url":"https://api.github.com/users/J12934/received_events","type":"User","site_admin":false},"labels":[{"id":612209716,"node_id":"MDU6TGFiZWw2MTIyMDk3MTY=","url":"https://api.github.com/repos/bkimminich/juice-shop/labels/in%20progress","name":"in progress","color":"6699ff","default":false}],"state":"open","locked":false,"assignee":{"login":"J12934","id":13718901,"node_id":"MDQ6VXNlcjEzNzE4OTAx","avatar_url":"https://avatars2.githubusercontent.com/u/13718901?v=4","gravatar_id":"","url":"https://api.github.com/users/J12934","html_url":"https://github.com/J12934","followers_url":"https://api.github.com/users/J12934/followers","following_url":"https://api.github.com/users/J12934/following{/other_user}","gists_url":"https://api.github.com/users/J12934/gists{/gist_id}","starred_url":"https://api.github.com/users/J12934/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J12934/subscriptions","organizations_url":"https://api.github.com/users/J12934/orgs","repos_url":"https://api.github.com/users/J12934/repos","events_url":"https://api.github.com/users/J12934/events{/privacy}","received_events_url":"https://api.github.com/users/J12934/received_events","type":"User","site_admin":false},"assignees":[{"login":"J12934","id":13718901,"node_id":"MDQ6VXNlcjEzNzE4OTAx","avatar_url":"https://avatars2.githubusercontent.com/u/13718901?v=4","gravatar_id":"","url":"https://api.github.com/users/J12934","html_url":"https://github.com/J12934","followers_url":"https://api.github.com/users/J12934/followers","following_url":"https://api.github.com/users/J12934/following{/other_user}","gists_url":"https://api.github.com/users/J12934/gists{/gist_id}","starred_url":"https://api.github.com/users/J12934/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J12934/subscriptions","organizations_url":"https://api.github.com/users/J12934/orgs","repos_url":"https://api.github.com/users/J12934/repos","events_url":"https://api.github.com/users/J12934/events{/privacy}","received_events_url":"https://api.github.com/users/J12934/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-07-23T16:45:49Z","updated_at":"2018-07-23T16:49:36Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/bkimminich/juice-shop/pulls/649","html_url":"https://github.com/bkimminich/juice-shop/pull/649","diff_url":"https://github.com/bkimminich/juice-shop/pull/649.diff","patch_url":"https://github.com/bkimminich/juice-shop/pull/649.patch"},"body":"This adds extends the rights in the dockerfile to the root group.\r\nOpenShift has some interesting security mechanisms including ignoring the user set in the dockerfile and just creating a new one which is member of the root group.\r\n\r\nThis should (to the best of my very limited unix rights management knowledge 😅) have no impact on the normal usage of the docker container.\r\n\r\nIf anybody is interested more about the details of this here's the OpenShift documentation for it: https://docs.openshift.org/latest/creating_images/guidelines.html#openshift-specific-guidelines"},"comment":{"url":"https://api.github.com/repos/bkimminich/juice-shop/issues/comments/407125200","html_url":"https://github.com/bkimminich/juice-shop/pull/649#issuecomment-407125200","issue_url":"https://api.github.com/repos/bkimminich/juice-shop/issues/649","id":407125200,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzEyNTIwMA==","user":{"login":"J12934","id":13718901,"node_id":"MDQ6VXNlcjEzNzE4OTAx","avatar_url":"https://avatars2.githubusercontent.com/u/13718901?v=4","gravatar_id":"","url":"https://api.github.com/users/J12934","html_url":"https://github.com/J12934","followers_url":"https://api.github.com/users/J12934/followers","following_url":"https://api.github.com/users/J12934/following{/other_user}","gists_url":"https://api.github.com/users/J12934/gists{/gist_id}","starred_url":"https://api.github.com/users/J12934/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/J12934/subscriptions","organizations_url":"https://api.github.com/users/J12934/orgs","repos_url":"https://api.github.com/users/J12934/repos","events_url":"https://api.github.com/users/J12934/events{/privacy}","received_events_url":"https://api.github.com/users/J12934/received_events","type":"User","site_admin":false},"created_at":"2018-07-23T16:49:36Z","updated_at":"2018-07-23T16:49:36Z","author_association":"COLLABORATOR","body":"Short addition without this the container crashes because it cannot write to its log file:\r\n\r\n```\r\n> juice-shop@7.4.0 start /juice-shop\r\n> node app\r\n2018-07-23T16:47:26.259Z '[FileStreamRotator] Failed to store log audit at:' './.audit.json' 'Error:' { Error: EACCES: permission denied, open './.audit.json'\r\n    at Object.fs.openSync (fs.js:660:18)\r\n    at Object.fs.writeFileSync (fs.js:1319:33)\r\n    at Object.FileStreamRotator.writeAuditLog (/juice-shop/node_modules/file-stream-rotator/FileStreamRotator.js:241:12)\r\n    at Object.FileStreamRotator.addLogToAudit (/juice-shop/node_modules/file-stream-rotator/FileStreamRotator.js:305:27)\r\n    at EventEmitter.<anonymous> (/juice-shop/node_modules/file-stream-rotator/FileStreamRotator.js:408:34)\r\n    at EventEmitter.emit (events.js:180:13)\r\n    at /juice-shop/node_modules/file-stream-rotator/FileStreamRotator.js:448:20\r\n    at process._tickCallback (internal/process/next_tick.js:176:11)\r\n    at Function.Module.runMain (internal/modules/cjs/loader.js:697:11)\r\n    at startup (internal/bootstrap/node.js:201:19)\r\n    at bootstrapNodeJSCore (internal/bootstrap/node.js:516:3)\r\n  errno: -13,\r\n  code: 'EACCES',\r\n  syscall: 'open',\r\n  path: './.audit.json' }\r\nevents.js:165\r\n      throw er; // Unhandled 'error' event\r\n      ^\r\nError: EACCES: permission denied, open './access.log.2018-07-23'\r\nEmitted 'error' event at:\r\n    at WriteStream.<anonymous> (/juice-shop/node_modules/file-stream-rotator/FileStreamRotator.js:503:15)\r\n    at WriteStream.emit (events.js:180:13)\r\n    at fs.open (fs.js:2225:12)\r\n    at FSReqWrap.oncomplete (fs.js:153:20)\r\nnpm ERR! code ELIFECYCLE\r\nnpm ERR! errno 1\r\nnpm ERR! juice-shop@7.4.0 start: `node app`\r\nnpm ERR! Exit status 1\r\nnpm ERR! \r\nnpm ERR! Failed at the juice-shop@7.4.0 start script.\r\nnpm ERR! This is probably not a problem with npm. There is likely additional logging output above.\r\n┌──────────────────────────────────────────────┐\r\n│           npm update check failed            │\r\n│     Try running with sudo or get access      │\r\n│     to the local update config store via     │\r\n│ sudo chown -R $USER:$(id -gn $USER) /.config │\r\n└──────────────────────────────────────────────┘\r\n\r\n```"}}
{"actor":{"display_login":"J12934"}}