{"action":"opened","issue":{"url":"https://api.github.com/repos/SquareBoot/Arduino-MoonLite-focuser/issues/3","repository_url":"https://api.github.com/repos/SquareBoot/Arduino-MoonLite-focuser","labels_url":"https://api.github.com/repos/SquareBoot/Arduino-MoonLite-focuser/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/SquareBoot/Arduino-MoonLite-focuser/issues/3/comments","events_url":"https://api.github.com/repos/SquareBoot/Arduino-MoonLite-focuser/issues/3/events","html_url":"https://github.com/SquareBoot/Arduino-MoonLite-focuser/issues/3","id":310328744,"number":3,"title":":AVxxxxx# command interpreter enhancement","user":{"login":"SquareBoot","id":20319029,"avatar_url":"https://avatars2.githubusercontent.com/u/20319029?v=4","gravatar_id":"","url":"https://api.github.com/users/SquareBoot","html_url":"https://github.com/SquareBoot","followers_url":"https://api.github.com/users/SquareBoot/followers","following_url":"https://api.github.com/users/SquareBoot/following{/other_user}","gists_url":"https://api.github.com/users/SquareBoot/gists{/gist_id}","starred_url":"https://api.github.com/users/SquareBoot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SquareBoot/subscriptions","organizations_url":"https://api.github.com/users/SquareBoot/orgs","repos_url":"https://api.github.com/users/SquareBoot/repos","events_url":"https://api.github.com/users/SquareBoot/events{/privacy}","received_events_url":"https://api.github.com/users/SquareBoot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-01T14:45:02Z","updated_at":"2018-04-01T14:45:02Z","closed_at":null,"author_association":"OWNER","body":"Line 147→157:\r\n\r\n    // Set the value of a pin\r\n    if ((line[0] == 'A') && (line[1] == 'V')) {\r\n      String pin = \"\";\r\n      pin.concat(line[2]);\r\n      pin.concat(line[3]);\r\n      String value = \"\";\r\n      value.concat(line[4]);\r\n      value.concat(line[5]);\r\n      value.concat(line[6]);\r\n      analogWrite(pin.toInt(), value.toInt());\r\n    }\r\n\r\nShould be modified to be similar to all the other commands interpretation. For example:\r\n\r\n    if (!strcasecmp(cmd, \"AV\")) {\r\n      ...\r\n      analogWrite(pin, value);\r\n    }\r\n\r\nJust because `string.concat(line[4]).concat(line[5])...` is ugly"}}
{"actor":{"display_login":"SquareBoot"}}