{"action":"created","issue":{"url":"https://api.github.com/repos/apache/pulsar/issues/2969","repository_url":"https://api.github.com/repos/apache/pulsar","labels_url":"https://api.github.com/repos/apache/pulsar/issues/2969/labels{/name}","comments_url":"https://api.github.com/repos/apache/pulsar/issues/2969/comments","events_url":"https://api.github.com/repos/apache/pulsar/issues/2969/events","html_url":"https://github.com/apache/pulsar/pull/2969","id":379148679,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NjgzNTUz","number":2969,"title":"JSONSchema fails to serialise fields on objects that are nested in a collection","user":{"login":"chrismiller","id":328751,"node_id":"MDQ6VXNlcjMyODc1MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/328751?v=4","gravatar_id":"","url":"https://api.github.com/users/chrismiller","html_url":"https://github.com/chrismiller","followers_url":"https://api.github.com/users/chrismiller/followers","following_url":"https://api.github.com/users/chrismiller/following{/other_user}","gists_url":"https://api.github.com/users/chrismiller/gists{/gist_id}","starred_url":"https://api.github.com/users/chrismiller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrismiller/subscriptions","organizations_url":"https://api.github.com/users/chrismiller/orgs","repos_url":"https://api.github.com/users/chrismiller/repos","events_url":"https://api.github.com/users/chrismiller/events{/privacy}","received_events_url":"https://api.github.com/users/chrismiller/received_events","type":"User","site_admin":false},"labels":[{"id":899300998,"node_id":"MDU6TGFiZWw4OTkzMDA5OTg=","url":"https://api.github.com/repos/apache/pulsar/labels/component/schemaregistry","name":"component/schemaregistry","color":"1d76db","default":false},{"id":399568949,"node_id":"MDU6TGFiZWwzOTk1Njg5NDk=","url":"https://api.github.com/repos/apache/pulsar/labels/type/bug","name":"type/bug","color":"ee0701","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/apache/pulsar/milestones/18","html_url":"https://github.com/apache/pulsar/milestone/18","labels_url":"https://api.github.com/repos/apache/pulsar/milestones/18/labels","id":3603038,"node_id":"MDk6TWlsZXN0b25lMzYwMzAzOA==","number":18,"title":"2.3.0","description":"","creator":{"login":"merlimat","id":62500,"node_id":"MDQ6VXNlcjYyNTAw","avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":169,"state":"open","created_at":"2018-08-28T07:03:59Z","updated_at":"2018-11-25T19:42:59Z","due_on":"2018-11-30T08:00:00Z","closed_at":null},"comments":4,"created_at":"2018-11-09T12:46:55Z","updated_at":"2018-11-25T19:43:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/pulsar/pulls/2969","html_url":"https://github.com/apache/pulsar/pull/2969","diff_url":"https://github.com/apache/pulsar/pull/2969.diff","patch_url":"https://github.com/apache/pulsar/pull/2969.patch"},"body":"### Motivation\r\n\r\nThe fix for #2577 (https://github.com/apache/pulsar/commit/701f3ea7e3541f61f064167043de04e8a2db5c0f#diff-576ea6c408d757d9f4a0de5ae27a88fc) introduced a new bug when serialising classes that contain collections of other classes. In this situation, objects in the collection do not have any of their fields serialised because they fail the shouldSkipField() test in JSONSchema.java\r\n\r\n### Modifications\r\n\r\nAdded new unit tests that highlight the problem. I haven't fixed the bug as it is not so clear to me what the correct solution should be.\r\n\r\n### Result\r\n\r\nThe new JSONSchemaTest.testNestedClasses() test will fail, showing the bug in JSONSchema.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/pulsar/issues/comments/441466813","html_url":"https://github.com/apache/pulsar/pull/2969#issuecomment-441466813","issue_url":"https://api.github.com/repos/apache/pulsar/issues/2969","id":441466813,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTQ2NjgxMw==","user":{"login":"sijie","id":1217863,"node_id":"MDQ6VXNlcjEyMTc4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"created_at":"2018-11-25T19:43:50Z","updated_at":"2018-11-25T19:43:50Z","author_association":"CONTRIBUTOR","body":"run integration tests"}}
{"actor":{"display_login":"sijie"}}