{"action":"created","comment":{"url":"https://api.github.com/repos/Cyber4All/clark-client/pulls/comments/243423042","pull_request_review_id":187190199,"id":243423042,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQyMzA0Mg==","diff_hunk":"@@ -220,29 +200,16 @@ export class AuthService {\n     );\n   }\n \n-  identifiersInUse(username: string) {\n-    return this.http\n-      .get(\n-        environment.apiURL + '/users/identifiers/active?username=' + username,\n-        {\n-          headers: this.httpHeaders,\n-          withCredentials: true\n-          // responseType: 'text'\n-        }\n-      )\n-      .toPromise()\n-      .then(val => {\n-        this.inUse = val;\n-        return this.inUse;\n-      });\n-  }\n-\n-  makeRedirectURL(url: string) {\n-    if (!url.match(/https?:\\/\\/.+/i)) {\n-      return `http://${url}`;\n-    } else {\n-      return url;\n-    }\n+  async identifiersInUse(username: string) {\n+    const val = await this.http\n+      .get(environment.apiURL + '/users/identifiers/active?username=' + username, {\n+        headers: this.httpHeaders,\n+        withCredentials: true\n+        // responseType: 'text'","path":"src/app/core/auth.service.ts","position":264,"original_position":264,"commit_id":"b1a50823008f3d42bfbe27fd9b22ceb625e16961","original_commit_id":"b1a50823008f3d42bfbe27fd9b22ceb625e16961","user":{"login":"nrwinner","id":7431390,"node_id":"MDQ6VXNlcjc0MzEzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7431390?v=4","gravatar_id":"","url":"https://api.github.com/users/nrwinner","html_url":"https://github.com/nrwinner","followers_url":"https://api.github.com/users/nrwinner/followers","following_url":"https://api.github.com/users/nrwinner/following{/other_user}","gists_url":"https://api.github.com/users/nrwinner/gists{/gist_id}","starred_url":"https://api.github.com/users/nrwinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrwinner/subscriptions","organizations_url":"https://api.github.com/users/nrwinner/orgs","repos_url":"https://api.github.com/users/nrwinner/repos","events_url":"https://api.github.com/users/nrwinner/events{/privacy}","received_events_url":"https://api.github.com/users/nrwinner/received_events","type":"User","site_admin":false},"body":"I assume this isn't being used anymore? Can we remove it?\r\n```suggestion\r\n\r\n```","created_at":"2018-12-20T21:27:12Z","updated_at":"2018-12-20T21:30:10Z","html_url":"https://github.com/Cyber4All/clark-client/pull/519#discussion_r243423042","pull_request_url":"https://api.github.com/repos/Cyber4All/clark-client/pulls/519","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Cyber4All/clark-client/pulls/comments/243423042"},"html":{"href":"https://github.com/Cyber4All/clark-client/pull/519#discussion_r243423042"},"pull_request":{"href":"https://api.github.com/repos/Cyber4All/clark-client/pulls/519"}}},"pull_request":{"url":"https://api.github.com/repos/Cyber4All/clark-client/pulls/519","id":240032479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMDMyNDc5","html_url":"https://github.com/Cyber4All/clark-client/pull/519","diff_url":"https://github.com/Cyber4All/clark-client/pull/519.diff","patch_url":"https://github.com/Cyber4All/clark-client/pull/519.patch","issue_url":"https://api.github.com/repos/Cyber4All/clark-client/issues/519","number":519,"state":"open","locked":false,"title":"Use Access Groups instead of the Whitelist","user":{"login":"DonSeannelly","id":14933100,"node_id":"MDQ6VXNlcjE0OTMzMTAw","avatar_url":"https://avatars1.githubusercontent.com/u/14933100?v=4","gravatar_id":"","url":"https://api.github.com/users/DonSeannelly","html_url":"https://github.com/DonSeannelly","followers_url":"https://api.github.com/users/DonSeannelly/followers","following_url":"https://api.github.com/users/DonSeannelly/following{/other_user}","gists_url":"https://api.github.com/users/DonSeannelly/gists{/gist_id}","starred_url":"https://api.github.com/users/DonSeannelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DonSeannelly/subscriptions","organizations_url":"https://api.github.com/users/DonSeannelly/orgs","repos_url":"https://api.github.com/users/DonSeannelly/repos","events_url":"https://api.github.com/users/DonSeannelly/events{/privacy}","received_events_url":"https://api.github.com/users/DonSeannelly/received_events","type":"User","site_admin":false},"body":"This PR eliminates the use of the whitelist in favor if the access groups that are listed on each user. All previously whitelisted users are now considered to be \"reviewers.\"","created_at":"2018-12-20T02:19:20Z","updated_at":"2018-12-20T21:30:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"94647050e8f8948e5975cfcd48f9b517153910b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cyber4All/clark-client/pulls/519/commits","review_comments_url":"https://api.github.com/repos/Cyber4All/clark-client/pulls/519/comments","review_comment_url":"https://api.github.com/repos/Cyber4All/clark-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cyber4All/clark-client/issues/519/comments","statuses_url":"https://api.github.com/repos/Cyber4All/clark-client/statuses/b1a50823008f3d42bfbe27fd9b22ceb625e16961","head":{"label":"Cyber4All:hotfix/remove-whitelist","ref":"hotfix/remove-whitelist","sha":"b1a50823008f3d42bfbe27fd9b22ceb625e16961","user":{"login":"Cyber4All","id":32777226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc3MjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32777226?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyber4All","html_url":"https://github.com/Cyber4All","followers_url":"https://api.github.com/users/Cyber4All/followers","following_url":"https://api.github.com/users/Cyber4All/following{/other_user}","gists_url":"https://api.github.com/users/Cyber4All/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyber4All/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyber4All/subscriptions","organizations_url":"https://api.github.com/users/Cyber4All/orgs","repos_url":"https://api.github.com/users/Cyber4All/repos","events_url":"https://api.github.com/users/Cyber4All/events{/privacy}","received_events_url":"https://api.github.com/users/Cyber4All/received_events","type":"Organization","site_admin":false},"repo":{"id":107224134,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyMjQxMzQ=","name":"clark-client","full_name":"Cyber4All/clark-client","private":false,"owner":{"login":"Cyber4All","id":32777226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc3MjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32777226?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyber4All","html_url":"https://github.com/Cyber4All","followers_url":"https://api.github.com/users/Cyber4All/followers","following_url":"https://api.github.com/users/Cyber4All/following{/other_user}","gists_url":"https://api.github.com/users/Cyber4All/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyber4All/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyber4All/subscriptions","organizations_url":"https://api.github.com/users/Cyber4All/orgs","repos_url":"https://api.github.com/users/Cyber4All/repos","events_url":"https://api.github.com/users/Cyber4All/events{/privacy}","received_events_url":"https://api.github.com/users/Cyber4All/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Cyber4All/clark-client","description":null,"fork":false,"url":"https://api.github.com/repos/Cyber4All/clark-client","forks_url":"https://api.github.com/repos/Cyber4All/clark-client/forks","keys_url":"https://api.github.com/repos/Cyber4All/clark-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cyber4All/clark-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cyber4All/clark-client/teams","hooks_url":"https://api.github.com/repos/Cyber4All/clark-client/hooks","issue_events_url":"https://api.github.com/repos/Cyber4All/clark-client/issues/events{/number}","events_url":"https://api.github.com/repos/Cyber4All/clark-client/events","assignees_url":"https://api.github.com/repos/Cyber4All/clark-client/assignees{/user}","branches_url":"https://api.github.com/repos/Cyber4All/clark-client/branches{/branch}","tags_url":"https://api.github.com/repos/Cyber4All/clark-client/tags","blobs_url":"https://api.github.com/repos/Cyber4All/clark-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cyber4All/clark-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cyber4All/clark-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cyber4All/clark-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cyber4All/clark-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Cyber4All/clark-client/languages","stargazers_url":"https://api.github.com/repos/Cyber4All/clark-client/stargazers","contributors_url":"https://api.github.com/repos/Cyber4All/clark-client/contributors","subscribers_url":"https://api.github.com/repos/Cyber4All/clark-client/subscribers","subscription_url":"https://api.github.com/repos/Cyber4All/clark-client/subscription","commits_url":"https://api.github.com/repos/Cyber4All/clark-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cyber4All/clark-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cyber4All/clark-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cyber4All/clark-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cyber4All/clark-client/contents/{+path}","compare_url":"https://api.github.com/repos/Cyber4All/clark-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cyber4All/clark-client/merges","archive_url":"https://api.github.com/repos/Cyber4All/clark-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cyber4All/clark-client/downloads","issues_url":"https://api.github.com/repos/Cyber4All/clark-client/issues{/number}","pulls_url":"https://api.github.com/repos/Cyber4All/clark-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Cyber4All/clark-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Cyber4All/clark-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cyber4All/clark-client/labels{/name}","releases_url":"https://api.github.com/repos/Cyber4All/clark-client/releases{/id}","deployments_url":"https://api.github.com/repos/Cyber4All/clark-client/deployments","created_at":"2017-10-17T05:56:54Z","updated_at":"2018-12-18T21:15:23Z","pushed_at":"2018-12-20T21:12:27Z","git_url":"git://github.com/Cyber4All/clark-client.git","ssh_url":"git@github.com:Cyber4All/clark-client.git","clone_url":"https://github.com/Cyber4All/clark-client.git","svn_url":"https://github.com/Cyber4All/clark-client","homepage":null,"size":32593,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":26,"license":null,"forks":0,"open_issues":26,"watchers":2,"default_branch":"master"}},"base":{"label":"Cyber4All:master","ref":"master","sha":"0ddcbad6cf12365d439f806a6de73dadf7915d87","user":{"login":"Cyber4All","id":32777226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc3MjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32777226?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyber4All","html_url":"https://github.com/Cyber4All","followers_url":"https://api.github.com/users/Cyber4All/followers","following_url":"https://api.github.com/users/Cyber4All/following{/other_user}","gists_url":"https://api.github.com/users/Cyber4All/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyber4All/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyber4All/subscriptions","organizations_url":"https://api.github.com/users/Cyber4All/orgs","repos_url":"https://api.github.com/users/Cyber4All/repos","events_url":"https://api.github.com/users/Cyber4All/events{/privacy}","received_events_url":"https://api.github.com/users/Cyber4All/received_events","type":"Organization","site_admin":false},"repo":{"id":107224134,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcyMjQxMzQ=","name":"clark-client","full_name":"Cyber4All/clark-client","private":false,"owner":{"login":"Cyber4All","id":32777226,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzc3MjI2","avatar_url":"https://avatars2.githubusercontent.com/u/32777226?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyber4All","html_url":"https://github.com/Cyber4All","followers_url":"https://api.github.com/users/Cyber4All/followers","following_url":"https://api.github.com/users/Cyber4All/following{/other_user}","gists_url":"https://api.github.com/users/Cyber4All/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyber4All/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyber4All/subscriptions","organizations_url":"https://api.github.com/users/Cyber4All/orgs","repos_url":"https://api.github.com/users/Cyber4All/repos","events_url":"https://api.github.com/users/Cyber4All/events{/privacy}","received_events_url":"https://api.github.com/users/Cyber4All/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Cyber4All/clark-client","description":null,"fork":false,"url":"https://api.github.com/repos/Cyber4All/clark-client","forks_url":"https://api.github.com/repos/Cyber4All/clark-client/forks","keys_url":"https://api.github.com/repos/Cyber4All/clark-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cyber4All/clark-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cyber4All/clark-client/teams","hooks_url":"https://api.github.com/repos/Cyber4All/clark-client/hooks","issue_events_url":"https://api.github.com/repos/Cyber4All/clark-client/issues/events{/number}","events_url":"https://api.github.com/repos/Cyber4All/clark-client/events","assignees_url":"https://api.github.com/repos/Cyber4All/clark-client/assignees{/user}","branches_url":"https://api.github.com/repos/Cyber4All/clark-client/branches{/branch}","tags_url":"https://api.github.com/repos/Cyber4All/clark-client/tags","blobs_url":"https://api.github.com/repos/Cyber4All/clark-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cyber4All/clark-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cyber4All/clark-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cyber4All/clark-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cyber4All/clark-client/statuses/{sha}","languages_url":"https://api.github.com/repos/Cyber4All/clark-client/languages","stargazers_url":"https://api.github.com/repos/Cyber4All/clark-client/stargazers","contributors_url":"https://api.github.com/repos/Cyber4All/clark-client/contributors","subscribers_url":"https://api.github.com/repos/Cyber4All/clark-client/subscribers","subscription_url":"https://api.github.com/repos/Cyber4All/clark-client/subscription","commits_url":"https://api.github.com/repos/Cyber4All/clark-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cyber4All/clark-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cyber4All/clark-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cyber4All/clark-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cyber4All/clark-client/contents/{+path}","compare_url":"https://api.github.com/repos/Cyber4All/clark-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cyber4All/clark-client/merges","archive_url":"https://api.github.com/repos/Cyber4All/clark-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cyber4All/clark-client/downloads","issues_url":"https://api.github.com/repos/Cyber4All/clark-client/issues{/number}","pulls_url":"https://api.github.com/repos/Cyber4All/clark-client/pulls{/number}","milestones_url":"https://api.github.com/repos/Cyber4All/clark-client/milestones{/number}","notifications_url":"https://api.github.com/repos/Cyber4All/clark-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cyber4All/clark-client/labels{/name}","releases_url":"https://api.github.com/repos/Cyber4All/clark-client/releases{/id}","deployments_url":"https://api.github.com/repos/Cyber4All/clark-client/deployments","created_at":"2017-10-17T05:56:54Z","updated_at":"2018-12-18T21:15:23Z","pushed_at":"2018-12-20T21:12:27Z","git_url":"git://github.com/Cyber4All/clark-client.git","ssh_url":"git@github.com:Cyber4All/clark-client.git","clone_url":"https://github.com/Cyber4All/clark-client.git","svn_url":"https://github.com/Cyber4All/clark-client","homepage":null,"size":32593,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":26,"license":null,"forks":0,"open_issues":26,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cyber4All/clark-client/pulls/519"},"html":{"href":"https://github.com/Cyber4All/clark-client/pull/519"},"issue":{"href":"https://api.github.com/repos/Cyber4All/clark-client/issues/519"},"comments":{"href":"https://api.github.com/repos/Cyber4All/clark-client/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/Cyber4All/clark-client/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/Cyber4All/clark-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cyber4All/clark-client/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/Cyber4All/clark-client/statuses/b1a50823008f3d42bfbe27fd9b22ceb625e16961"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nrwinner"}}