{"action":"created","comment":{"url":"https://api.github.com/repos/convox/rack/pulls/comments/206230681","pull_request_review_id":141602687,"id":206230681,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjIzMDY4MQ==","diff_hunk":"@@ -6,6 +6,49 @@ import (\n )\n \n func (d *DNS) setupResolver(domain string, ip net.IP) error {\n+\tversion, err := linuxRelease()\n+\n+\tif err != nil {\n+\t\treturn err\n+\t}\n+\n+\tswitch version {\n+\tcase \"ubuntu-18.04\":\n+\t\tif err := installUbuntu1804(domain, ip); err != nil {\n+\t\t\treturn err\n+\t\t}\n+\tdefault:\n+\t\tif err := installGenericLinux(domain, ip); err != nil {\n+\t\t\treturn err\n+\t\t}\n+\t}\n+\treturn nil\n+}\n+\n+func installUbuntu1804(domain string, ip net.IP) error {\n+","path":"router/dns_linux.go","position":24,"original_position":24,"commit_id":"a52a397ece83ae3a2ab09ae2da46d4d1d72218cd","original_commit_id":"a52a397ece83ae3a2ab09ae2da46d4d1d72218cd","user":{"login":"ddollar","id":3308,"node_id":"MDQ6VXNlcjMzMDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3308?v=4","gravatar_id":"","url":"https://api.github.com/users/ddollar","html_url":"https://github.com/ddollar","followers_url":"https://api.github.com/users/ddollar/followers","following_url":"https://api.github.com/users/ddollar/following{/other_user}","gists_url":"https://api.github.com/users/ddollar/gists{/gist_id}","starred_url":"https://api.github.com/users/ddollar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddollar/subscriptions","organizations_url":"https://api.github.com/users/ddollar/orgs","repos_url":"https://api.github.com/users/ddollar/repos","events_url":"https://api.github.com/users/ddollar/events{/privacy}","received_events_url":"https://api.github.com/users/ddollar/received_events","type":"User","site_admin":false},"body":"dont need the extra space at the beginning of functions","created_at":"2018-07-30T16:07:21Z","updated_at":"2018-07-30T16:08:13Z","html_url":"https://github.com/convox/rack/pull/2813#discussion_r206230681","pull_request_url":"https://api.github.com/repos/convox/rack/pulls/2813","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/comments/206230681"},"html":{"href":"https://github.com/convox/rack/pull/2813#discussion_r206230681"},"pull_request":{"href":"https://api.github.com/repos/convox/rack/pulls/2813"}}},"pull_request":{"url":"https://api.github.com/repos/convox/rack/pulls/2813","id":204852312,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODUyMzEy","html_url":"https://github.com/convox/rack/pull/2813","diff_url":"https://github.com/convox/rack/pull/2813.diff","patch_url":"https://github.com/convox/rack/pull/2813.patch","issue_url":"https://api.github.com/repos/convox/rack/issues/2813","number":2813,"state":"open","locked":false,"title":"Ubuntu 18 compatibility fixes for Local rack installation.","user":{"login":"ectrimble20","id":1400382,"node_id":"MDQ6VXNlcjE0MDAzODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1400382?v=4","gravatar_id":"","url":"https://api.github.com/users/ectrimble20","html_url":"https://github.com/ectrimble20","followers_url":"https://api.github.com/users/ectrimble20/followers","following_url":"https://api.github.com/users/ectrimble20/following{/other_user}","gists_url":"https://api.github.com/users/ectrimble20/gists{/gist_id}","starred_url":"https://api.github.com/users/ectrimble20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ectrimble20/subscriptions","organizations_url":"https://api.github.com/users/ectrimble20/orgs","repos_url":"https://api.github.com/users/ectrimble20/repos","events_url":"https://api.github.com/users/ectrimble20/events{/privacy}","received_events_url":"https://api.github.com/users/ectrimble20/received_events","type":"User","site_admin":false},"body":"Adds in an OS check and breaks Linux installation of the local rack's router into two functions, one specific to Ubuntu 18.04 and one as a generic Linux installation.  Ubuntu 18 no longer uses NetworkManager as it's default networking platform.  This fix installs a configuration file for systemd-resolv/resolved which allows the convox router to act as a pass through DNS server which in turn handles .convox address resolution without effecting existing external DNS resolution.","created_at":"2018-07-30T15:59:45Z","updated_at":"2018-07-30T16:08:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"15790756417dd73fb4d52a9c6031ac08524e9fb1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/convox/rack/pulls/2813/commits","review_comments_url":"https://api.github.com/repos/convox/rack/pulls/2813/comments","review_comment_url":"https://api.github.com/repos/convox/rack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/convox/rack/issues/2813/comments","statuses_url":"https://api.github.com/repos/convox/rack/statuses/a52a397ece83ae3a2ab09ae2da46d4d1d72218cd","head":{"label":"ectrimble20:u18-dns-fixes","ref":"u18-dns-fixes","sha":"a52a397ece83ae3a2ab09ae2da46d4d1d72218cd","user":{"login":"ectrimble20","id":1400382,"node_id":"MDQ6VXNlcjE0MDAzODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1400382?v=4","gravatar_id":"","url":"https://api.github.com/users/ectrimble20","html_url":"https://github.com/ectrimble20","followers_url":"https://api.github.com/users/ectrimble20/followers","following_url":"https://api.github.com/users/ectrimble20/following{/other_user}","gists_url":"https://api.github.com/users/ectrimble20/gists{/gist_id}","starred_url":"https://api.github.com/users/ectrimble20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ectrimble20/subscriptions","organizations_url":"https://api.github.com/users/ectrimble20/orgs","repos_url":"https://api.github.com/users/ectrimble20/repos","events_url":"https://api.github.com/users/ectrimble20/events{/privacy}","received_events_url":"https://api.github.com/users/ectrimble20/received_events","type":"User","site_admin":false},"repo":{"id":142332943,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMzI5NDM=","name":"rack","full_name":"ectrimble20/rack","owner":{"login":"ectrimble20","id":1400382,"node_id":"MDQ6VXNlcjE0MDAzODI=","avatar_url":"https://avatars1.githubusercontent.com/u/1400382?v=4","gravatar_id":"","url":"https://api.github.com/users/ectrimble20","html_url":"https://github.com/ectrimble20","followers_url":"https://api.github.com/users/ectrimble20/followers","following_url":"https://api.github.com/users/ectrimble20/following{/other_user}","gists_url":"https://api.github.com/users/ectrimble20/gists{/gist_id}","starred_url":"https://api.github.com/users/ectrimble20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ectrimble20/subscriptions","organizations_url":"https://api.github.com/users/ectrimble20/orgs","repos_url":"https://api.github.com/users/ectrimble20/repos","events_url":"https://api.github.com/users/ectrimble20/events{/privacy}","received_events_url":"https://api.github.com/users/ectrimble20/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ectrimble20/rack","description":"Open-source PaaS. Built entirely on AWS cloud services for maximum privacy and minimum upkeep.","fork":true,"url":"https://api.github.com/repos/ectrimble20/rack","forks_url":"https://api.github.com/repos/ectrimble20/rack/forks","keys_url":"https://api.github.com/repos/ectrimble20/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ectrimble20/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ectrimble20/rack/teams","hooks_url":"https://api.github.com/repos/ectrimble20/rack/hooks","issue_events_url":"https://api.github.com/repos/ectrimble20/rack/issues/events{/number}","events_url":"https://api.github.com/repos/ectrimble20/rack/events","assignees_url":"https://api.github.com/repos/ectrimble20/rack/assignees{/user}","branches_url":"https://api.github.com/repos/ectrimble20/rack/branches{/branch}","tags_url":"https://api.github.com/repos/ectrimble20/rack/tags","blobs_url":"https://api.github.com/repos/ectrimble20/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ectrimble20/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ectrimble20/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ectrimble20/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ectrimble20/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/ectrimble20/rack/languages","stargazers_url":"https://api.github.com/repos/ectrimble20/rack/stargazers","contributors_url":"https://api.github.com/repos/ectrimble20/rack/contributors","subscribers_url":"https://api.github.com/repos/ectrimble20/rack/subscribers","subscription_url":"https://api.github.com/repos/ectrimble20/rack/subscription","commits_url":"https://api.github.com/repos/ectrimble20/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ectrimble20/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ectrimble20/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ectrimble20/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ectrimble20/rack/contents/{+path}","compare_url":"https://api.github.com/repos/ectrimble20/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ectrimble20/rack/merges","archive_url":"https://api.github.com/repos/ectrimble20/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ectrimble20/rack/downloads","issues_url":"https://api.github.com/repos/ectrimble20/rack/issues{/number}","pulls_url":"https://api.github.com/repos/ectrimble20/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/ectrimble20/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/ectrimble20/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ectrimble20/rack/labels{/name}","releases_url":"https://api.github.com/repos/ectrimble20/rack/releases{/id}","deployments_url":"https://api.github.com/repos/ectrimble20/rack/deployments","created_at":"2018-07-25T17:32:11Z","updated_at":"2018-07-25T17:32:14Z","pushed_at":"2018-07-30T15:21:08Z","git_url":"git://github.com/ectrimble20/rack.git","ssh_url":"git@github.com:ectrimble20/rack.git","clone_url":"https://github.com/ectrimble20/rack.git","svn_url":"https://github.com/ectrimble20/rack","homepage":"https://convox.com","size":118734,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"convox:master","ref":"master","sha":"4f391ad0f46a51f3ad3b2da4a294e1644d4cac23","user":{"login":"convox","id":10547780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTQ3Nzgw","avatar_url":"https://avatars1.githubusercontent.com/u/10547780?v=4","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"repo":{"id":42454540,"node_id":"MDEwOlJlcG9zaXRvcnk0MjQ1NDU0MA==","name":"rack","full_name":"convox/rack","owner":{"login":"convox","id":10547780,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTQ3Nzgw","avatar_url":"https://avatars1.githubusercontent.com/u/10547780?v=4","gravatar_id":"","url":"https://api.github.com/users/convox","html_url":"https://github.com/convox","followers_url":"https://api.github.com/users/convox/followers","following_url":"https://api.github.com/users/convox/following{/other_user}","gists_url":"https://api.github.com/users/convox/gists{/gist_id}","starred_url":"https://api.github.com/users/convox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/convox/subscriptions","organizations_url":"https://api.github.com/users/convox/orgs","repos_url":"https://api.github.com/users/convox/repos","events_url":"https://api.github.com/users/convox/events{/privacy}","received_events_url":"https://api.github.com/users/convox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/convox/rack","description":"Open-source PaaS. Built entirely on AWS cloud services for maximum privacy and minimum upkeep.","fork":false,"url":"https://api.github.com/repos/convox/rack","forks_url":"https://api.github.com/repos/convox/rack/forks","keys_url":"https://api.github.com/repos/convox/rack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/convox/rack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/convox/rack/teams","hooks_url":"https://api.github.com/repos/convox/rack/hooks","issue_events_url":"https://api.github.com/repos/convox/rack/issues/events{/number}","events_url":"https://api.github.com/repos/convox/rack/events","assignees_url":"https://api.github.com/repos/convox/rack/assignees{/user}","branches_url":"https://api.github.com/repos/convox/rack/branches{/branch}","tags_url":"https://api.github.com/repos/convox/rack/tags","blobs_url":"https://api.github.com/repos/convox/rack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/convox/rack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/convox/rack/git/refs{/sha}","trees_url":"https://api.github.com/repos/convox/rack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/convox/rack/statuses/{sha}","languages_url":"https://api.github.com/repos/convox/rack/languages","stargazers_url":"https://api.github.com/repos/convox/rack/stargazers","contributors_url":"https://api.github.com/repos/convox/rack/contributors","subscribers_url":"https://api.github.com/repos/convox/rack/subscribers","subscription_url":"https://api.github.com/repos/convox/rack/subscription","commits_url":"https://api.github.com/repos/convox/rack/commits{/sha}","git_commits_url":"https://api.github.com/repos/convox/rack/git/commits{/sha}","comments_url":"https://api.github.com/repos/convox/rack/comments{/number}","issue_comment_url":"https://api.github.com/repos/convox/rack/issues/comments{/number}","contents_url":"https://api.github.com/repos/convox/rack/contents/{+path}","compare_url":"https://api.github.com/repos/convox/rack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/convox/rack/merges","archive_url":"https://api.github.com/repos/convox/rack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/convox/rack/downloads","issues_url":"https://api.github.com/repos/convox/rack/issues{/number}","pulls_url":"https://api.github.com/repos/convox/rack/pulls{/number}","milestones_url":"https://api.github.com/repos/convox/rack/milestones{/number}","notifications_url":"https://api.github.com/repos/convox/rack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/convox/rack/labels{/name}","releases_url":"https://api.github.com/repos/convox/rack/releases{/id}","deployments_url":"https://api.github.com/repos/convox/rack/deployments","created_at":"2015-09-14T14:41:30Z","updated_at":"2018-07-28T17:40:39Z","pushed_at":"2018-07-30T15:59:46Z","git_url":"git://github.com/convox/rack.git","ssh_url":"git@github.com:convox/rack.git","clone_url":"https://github.com/convox/rack.git","svn_url":"https://github.com/convox/rack","homepage":"https://convox.com","size":118727,"stargazers_count":1688,"watchers_count":1688,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":150,"open_issues":35,"watchers":1688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/convox/rack/pulls/2813"},"html":{"href":"https://github.com/convox/rack/pull/2813"},"issue":{"href":"https://api.github.com/repos/convox/rack/issues/2813"},"comments":{"href":"https://api.github.com/repos/convox/rack/issues/2813/comments"},"review_comments":{"href":"https://api.github.com/repos/convox/rack/pulls/2813/comments"},"review_comment":{"href":"https://api.github.com/repos/convox/rack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/convox/rack/pulls/2813/commits"},"statuses":{"href":"https://api.github.com/repos/convox/rack/statuses/a52a397ece83ae3a2ab09ae2da46d4d1d72218cd"}},"author_association":"NONE"}}
{"actor":{"display_login":"ddollar"}}