{"action":"created","issue":{"url":"https://api.github.com/repos/freeipa/freeipa/issues/2385","repository_url":"https://api.github.com/repos/freeipa/freeipa","labels_url":"https://api.github.com/repos/freeipa/freeipa/issues/2385/labels{/name}","comments_url":"https://api.github.com/repos/freeipa/freeipa/issues/2385/comments","events_url":"https://api.github.com/repos/freeipa/freeipa/issues/2385/events","html_url":"https://github.com/freeipa/freeipa/pull/2385","id":363300382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzcyNTg3","number":2385,"title":"Fix translation of 'Add dialog for 'association' facet","user":{"login":"stanislavlevin","id":31205609,"node_id":"MDQ6VXNlcjMxMjA1NjA5","avatar_url":"https://avatars2.githubusercontent.com/u/31205609?v=4","gravatar_id":"","url":"https://api.github.com/users/stanislavlevin","html_url":"https://github.com/stanislavlevin","followers_url":"https://api.github.com/users/stanislavlevin/followers","following_url":"https://api.github.com/users/stanislavlevin/following{/other_user}","gists_url":"https://api.github.com/users/stanislavlevin/gists{/gist_id}","starred_url":"https://api.github.com/users/stanislavlevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stanislavlevin/subscriptions","organizations_url":"https://api.github.com/users/stanislavlevin/orgs","repos_url":"https://api.github.com/users/stanislavlevin/repos","events_url":"https://api.github.com/users/stanislavlevin/events{/privacy}","received_events_url":"https://api.github.com/users/stanislavlevin/received_events","type":"User","site_admin":false},"labels":[{"id":1013717178,"node_id":"MDU6TGFiZWwxMDEzNzE3MTc4","url":"https://api.github.com/repos/freeipa/freeipa/labels/WebUI","name":"WebUI","color":"963232","default":false},{"id":427471125,"node_id":"MDU6TGFiZWw0Mjc0NzExMjU=","url":"https://api.github.com/repos/freeipa/freeipa/labels/ack","name":"ack","color":"0e8a16","default":false},{"id":969297832,"node_id":"MDU6TGFiZWw5NjkyOTc4MzI=","url":"https://api.github.com/repos/freeipa/freeipa/labels/ipa-4-7","name":"ipa-4-7","color":"c8f438","default":false},{"id":861772418,"node_id":"MDU6TGFiZWw4NjE3NzI0MTg=","url":"https://api.github.com/repos/freeipa/freeipa/labels/needs%20rebase","name":"needs rebase","color":"ededed","default":false},{"id":427484529,"node_id":"MDU6TGFiZWw0Mjc0ODQ1Mjk=","url":"https://api.github.com/repos/freeipa/freeipa/labels/pushed","name":"pushed","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-09-24T20:06:56Z","updated_at":"2018-10-02T14:39:06Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/freeipa/freeipa/pulls/2385","html_url":"https://github.com/freeipa/freeipa/pull/2385","diff_url":"https://github.com/freeipa/freeipa/pull/2385.diff","patch_url":"https://github.com/freeipa/freeipa/pull/2385.patch"},"body":"As for now the 'Add' dialog title, which is initialized within the details of the entity, contains translatable concatenated texts, like:\r\n```\r\n'Add ${other_entity} into ${entity} ${primary_key}'\r\n```\r\nwhere 'other_entity' and 'entity' are also translatable texts.\r\n\r\nThis construction is used via method 'show_add_dialog' of association_facet as well as 'create_add_dialog' method of 'association_table' widget for the all 'Add' actions within the details of entities.\r\n\r\nThe concatenation leads to a bad quality translation and should be changed to an entire sentence.\r\n    \r\nFrom now a mentioned title is taken from a spec and should be specified explicitly.\r\n    \r\nFixes: https://pagure.io/freeipa/issue/7712\r\nFixes: https://pagure.io/freeipa/issue/7714"},"comment":{"url":"https://api.github.com/repos/freeipa/freeipa/issues/comments/426299126","html_url":"https://github.com/freeipa/freeipa/pull/2385#issuecomment-426299126","issue_url":"https://api.github.com/repos/freeipa/freeipa/issues/2385","id":426299126,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjI5OTEyNg==","user":{"login":"serg-cymbaluk","id":18536600,"node_id":"MDQ6VXNlcjE4NTM2NjAw","avatar_url":"https://avatars2.githubusercontent.com/u/18536600?v=4","gravatar_id":"","url":"https://api.github.com/users/serg-cymbaluk","html_url":"https://github.com/serg-cymbaluk","followers_url":"https://api.github.com/users/serg-cymbaluk/followers","following_url":"https://api.github.com/users/serg-cymbaluk/following{/other_user}","gists_url":"https://api.github.com/users/serg-cymbaluk/gists{/gist_id}","starred_url":"https://api.github.com/users/serg-cymbaluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serg-cymbaluk/subscriptions","organizations_url":"https://api.github.com/users/serg-cymbaluk/orgs","repos_url":"https://api.github.com/users/serg-cymbaluk/repos","events_url":"https://api.github.com/users/serg-cymbaluk/events{/privacy}","received_events_url":"https://api.github.com/users/serg-cymbaluk/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T14:39:06Z","updated_at":"2018-10-02T14:39:06Z","author_association":"CONTRIBUTOR","body":"master:\n\n* a502fa939f7e0bc9212ac102202a0ba23a7ff75c Drop concatenated title of 'Add' dialog for details of entity\n* dda488efc26aa10718b751852deb87b4478d0ca9 Add title to 'add' dialog for details of 'Certificate' entity\n* d588d3e9e4494e0750c4dd05b3195954ca5bf149 Add title to 'add' dialog for details of 'Users' entity\n* dc9e5c57d575e215afba42078c662ccfe9dd0f0b Add title to 'add' dialog for details of 'Hosts' entity\n* ac52facac26f466e3997661a84f527454ad68f33 Add title to 'add' dialog for details of 'Services' entity\n* 9e4de506cb4403da9c556f77487b72eb6d01fb30 Add title to 'add' dialog for details of 'Groups' entity\n* 01eba53c80d9b1cf8a10057b5665c00cba752698 Add title to 'add' dialog for details of 'ID Views' entity\n* 30094d8212e1a8159916fffb62172f3a660246e1 Add title to 'add' dialog for details of 'HBAC' entity\n* 35b1b65a542e62c763d68eea60684c3a0cc35957 Add title to 'add' dialog for details of 'Sudo' entity\n* 958b10576172d2a73c491fcd97a51f7c46960375 Add title to 'add' dialog for details of 'OTP Tokens' entity\n* b3ac23041814213d50db646c37079f4f9dd54d4e Add title to 'add' dialog for details of 'RBAC' entity\n* 171c6a01d8a7be0960fe76cd9a6bd67f41506f2e Drop concatenated title of add dialog for association_table widget\n* 3c81e170f9117fc9b18e953d3f51b4e67edd942d Add title to 'add' dialog for 'association_table' widget of Hosts entity\n* 20688f0fa717cf1613e09c30dc848289c39ce290 Add title to 'add' dialog for 'association_table' widget of Services entity\n* c14ef57307da188d57ec9ea0dda5f6ea3f93ed62 Add title to 'add' dialog for 'association_table' widget of Groups entity\n* 1ccafd487039e97ee9498bbe972d298dcbf960a4 Add title to 'add' dialog for 'association_table' widget of HBAC entity\n* 2ea8f088ba59bdb232e75d21fa3d210c18d7723c Add title to 'add' dialog for 'association_table' widget of Sudo entity\n* 0e1accdab4e3fe29bec4085ee4a2a87d545d9c96 Add title to 'add' dialog for 'association_table' widget of SELinux User Maps entity\n* 073eac085a17fd4d80d476bb6b1f383dd69ed78b Add title to 'add' dialog for 'association_table' widget of Certificates entity\n* 29ca7bf30886e80e682bb7fc0ccdd2be0d226d4a Add title to 'add' dialog for 'association_table' widget of Vaults entity\n* 0f30fd834576ab6e83247b1c2741e21e5ebeb8a5 Add title to 'add' dialog for 'association_table' widget of Topology entity\n\n"}}
{"actor":{"display_login":"serg-cymbaluk"}}