{"action":"created","issue":{"url":"https://api.github.com/repos/paolosalvatori/ServiceBusExplorer/issues/247","repository_url":"https://api.github.com/repos/paolosalvatori/ServiceBusExplorer","labels_url":"https://api.github.com/repos/paolosalvatori/ServiceBusExplorer/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/paolosalvatori/ServiceBusExplorer/issues/247/comments","events_url":"https://api.github.com/repos/paolosalvatori/ServiceBusExplorer/issues/247/events","html_url":"https://github.com/paolosalvatori/ServiceBusExplorer/pull/247","id":355648374,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTI4MjQx","number":247,"title":"fixed cloning by utilizing Service Bus .Clone(stream) instead of .Clone(string)","user":{"login":"c-lombardi","id":4417133,"node_id":"MDQ6VXNlcjQ0MTcxMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4417133?v=4","gravatar_id":"","url":"https://api.github.com/users/c-lombardi","html_url":"https://github.com/c-lombardi","followers_url":"https://api.github.com/users/c-lombardi/followers","following_url":"https://api.github.com/users/c-lombardi/following{/other_user}","gists_url":"https://api.github.com/users/c-lombardi/gists{/gist_id}","starred_url":"https://api.github.com/users/c-lombardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-lombardi/subscriptions","organizations_url":"https://api.github.com/users/c-lombardi/orgs","repos_url":"https://api.github.com/users/c-lombardi/repos","events_url":"https://api.github.com/users/c-lombardi/events{/privacy}","received_events_url":"https://api.github.com/users/c-lombardi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-08-30T15:52:33Z","updated_at":"2018-08-30T20:11:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/paolosalvatori/ServiceBusExplorer/pulls/247","html_url":"https://github.com/paolosalvatori/ServiceBusExplorer/pull/247","diff_url":"https://github.com/paolosalvatori/ServiceBusExplorer/pull/247.diff","patch_url":"https://github.com/paolosalvatori/ServiceBusExplorer/pull/247.patch"},"body":"…one() for Streams\r\n\r\n\r\nRegarding:\r\nhttps://github.com/paolosalvatori/ServiceBusExplorer/issues/245\r\n\r\nThis appears to be everything necessary in order to resolve the issue I was having.\r\n\r\nI am uncertain of all functionality of ServiceBusExplorer to QA this change, but this is basically what I found will meet the needs of properly cloning a stream."},"comment":{"url":"https://api.github.com/repos/paolosalvatori/ServiceBusExplorer/issues/comments/417451648","html_url":"https://github.com/paolosalvatori/ServiceBusExplorer/pull/247#issuecomment-417451648","issue_url":"https://api.github.com/repos/paolosalvatori/ServiceBusExplorer/issues/247","id":417451648,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzQ1MTY0OA==","user":{"login":"c-lombardi","id":4417133,"node_id":"MDQ6VXNlcjQ0MTcxMzM=","avatar_url":"https://avatars3.githubusercontent.com/u/4417133?v=4","gravatar_id":"","url":"https://api.github.com/users/c-lombardi","html_url":"https://github.com/c-lombardi","followers_url":"https://api.github.com/users/c-lombardi/followers","following_url":"https://api.github.com/users/c-lombardi/following{/other_user}","gists_url":"https://api.github.com/users/c-lombardi/gists{/gist_id}","starred_url":"https://api.github.com/users/c-lombardi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-lombardi/subscriptions","organizations_url":"https://api.github.com/users/c-lombardi/orgs","repos_url":"https://api.github.com/users/c-lombardi/repos","events_url":"https://api.github.com/users/c-lombardi/events{/privacy}","received_events_url":"https://api.github.com/users/c-lombardi/received_events","type":"User","site_admin":false},"created_at":"2018-08-30T20:11:41Z","updated_at":"2018-08-30T20:11:41Z","author_association":"NONE","body":"I was itching to write some tests.\r\n\r\nI'd be happy to write a few to lock-down these changes when I can find some more time. It took me almost a week to get back to this for just the few lines of changes I have made.\r\n\r\nThere is a lot of mutability going on in this class, including 7 tiers deep of inheritance and a 62 cyclomatic complexity rating (metrics calculated by Visual Studio).\r\n\r\nI'm not certain about the non-WCF, ByteArray or String implementations. The application that I develop at my day-job utilizes ServiceBus only with Streams and that's where this became a problem for us to re-queue dead-lettered messages.\r\n\r\nYour tool is great by the way. It was really what our Devs, QAs, and Operations teams needed to gain valuable insight into our use of Service Bus. \r\n\r\nUntil now, it's been more of a theoretical black-box.\r\n\r\nThanks for developing it and for responding so quickly to all of my comments and concerns!"}}
{"actor":{"display_login":"c-lombardi"}}