{"action":"created","issue":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/22884","repository_url":"https://api.github.com/repos/pandas-dev/pandas","labels_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22884/labels{/name}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22884/comments","events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22884/events","html_url":"https://github.com/pandas-dev/pandas/issues/22884","id":365128398,"node_id":"MDU6SXNzdWUzNjUxMjgzOTg=","number":22884,"title":"STYLE: Fix linting of benchmarks","user":{"login":"datapythonista","id":10058240,"node_id":"MDQ6VXNlcjEwMDU4MjQw","avatar_url":"https://avatars2.githubusercontent.com/u/10058240?v=4","gravatar_id":"","url":"https://api.github.com/users/datapythonista","html_url":"https://github.com/datapythonista","followers_url":"https://api.github.com/users/datapythonista/followers","following_url":"https://api.github.com/users/datapythonista/following{/other_user}","gists_url":"https://api.github.com/users/datapythonista/gists{/gist_id}","starred_url":"https://api.github.com/users/datapythonista/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datapythonista/subscriptions","organizations_url":"https://api.github.com/users/datapythonista/orgs","repos_url":"https://api.github.com/users/datapythonista/repos","events_url":"https://api.github.com/users/datapythonista/events{/privacy}","received_events_url":"https://api.github.com/users/datapythonista/received_events","type":"User","site_admin":false},"labels":[{"id":48070600,"node_id":"MDU6TGFiZWw0ODA3MDYwMA==","url":"https://api.github.com/repos/pandas-dev/pandas/labels/CI","name":"CI","color":"a2bca7","default":false},{"id":195648009,"node_id":"MDU6TGFiZWwxOTU2NDgwMDk=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Effort%20Low","name":"Effort Low","color":"006b75","default":false},{"id":106935113,"node_id":"MDU6TGFiZWwxMDY5MzUxMTM=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/Style","name":"Style","color":"eb6420","default":false},{"id":717120670,"node_id":"MDU6TGFiZWw3MTcxMjA2NzA=","url":"https://api.github.com/repos/pandas-dev/pandas/labels/good%20first%20issue","name":"good first issue","color":"0e8a16","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-09-29T12:33:03Z","updated_at":"2018-09-29T16:33:05Z","closed_at":null,"author_association":"MEMBER","body":"We are currently not linting (validating PEP-8) of the benchmarks in `asv_bench/benchmarks`. But it'd be good to start doing it as with the rest of the code.\r\n\r\nBefore starting the automatic validation, we need to fix all the style problems. Those can be obtained by executing `flake8 --config=none asv_bench/benchmarks --ignore=F811,E731`\r\n\r\nThis is currently returning:\r\n```\r\nasv_bench/benchmarks/algorithms.py:12:5: E722 do not use bare except'\r\nasv_bench/benchmarks/timeseries.py:1:1: F401 'warnings' imported but unused\r\nasv_bench/benchmarks/stat_ops.py:21:9: E722 do not use bare except'\r\nasv_bench/benchmarks/stat_ops.py:59:9: E722 do not use bare except'\r\nasv_bench/benchmarks/pandas_vb_common.py:5:1: F401 'pandas.Panel' imported but unused\r\nasv_bench/benchmarks/pandas_vb_common.py:12:5: E722 do not use bare except'\r\nasv_bench/benchmarks/pandas_vb_common.py:37:9: E722 do not use bare except'\r\nasv_bench/benchmarks/join_merge.py:32:9: E722 do not use bare except'\r\nasv_bench/benchmarks/io/csv.py:2:1: F401 'timeit' imported but unused\r\nasv_bench/benchmarks/io/csv.py:8:1: F401 'pandas.compat.PY2' imported but unused\r\nasv_bench/benchmarks/io/csv.py:184:80: E501 line too long (87 > 79 characters)\r\n```\r\n\r\nAll them should be fixed. Most of them should be immediate to fix, but for `E722 do not use bare except` make sure the specific exception is captured, and don't simply use `except Exception:`."},"comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments/425657882","html_url":"https://github.com/pandas-dev/pandas/issues/22884#issuecomment-425657882","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/22884","id":425657882,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTY1Nzg4Mg==","user":{"login":"jbrockmendel","id":8078968,"node_id":"MDQ6VXNlcjgwNzg5Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"created_at":"2018-09-29T16:33:05Z","updated_at":"2018-09-29T16:33:05Z","author_association":"MEMBER","body":"lint-adjacent for the benchmarks: I think some of the directives being used are deprecated in asv.  e.g. in `algorithms` each of the benchmark classes defines `goal_time`, but it looks like asv just ignores that: https://asv.readthedocs.io/en/stable/benchmarks.html#benchmark-attributes\r\n\r\nSo the pertinent suggestion: linting for valid asv directives"}}
{"actor":{"display_login":"jbrockmendel"}}