{"action":"created","comment":{"url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/comments/234569272","pull_request_review_id":176234462,"id":234569272,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDU2OTI3Mg==","diff_hunk":"@@ -267,6 +267,7 @@ public void required_spec208_mustBePreparedToReceiveOnNextSignalsAfterHavingCall\n       public void run(WhiteboxTestStage stage) throws InterruptedException {\n         stage.puppet().triggerRequest(1);\n         stage.puppet().signalCancel();\n+        stage.expectRequest();","path":"tck/src/main/java/org/reactivestreams/tck/SubscriberWhiteboxVerification.java","position":4,"original_position":4,"commit_id":"18f3532f0cb25a8ec69c8ef65447d3aeb6d3010b","original_commit_id":"18f3532f0cb25a8ec69c8ef65447d3aeb6d3010b","user":{"login":"viktorklang","id":10871,"node_id":"MDQ6VXNlcjEwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/10871?v=4","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"body":"Thinking about this some more, shouldn't the `expectRequest` be before the `signalCancel`?","created_at":"2018-11-19T10:39:52Z","updated_at":"2018-11-19T10:39:52Z","html_url":"https://github.com/reactive-streams/reactive-streams-jvm/pull/441#discussion_r234569272","pull_request_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/441","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/comments/234569272"},"html":{"href":"https://github.com/reactive-streams/reactive-streams-jvm/pull/441#discussion_r234569272"},"pull_request":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/441"}},"in_reply_to_id":234568341},"pull_request":{"url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/441","id":231823633,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODIzNjMz","html_url":"https://github.com/reactive-streams/reactive-streams-jvm/pull/441","diff_url":"https://github.com/reactive-streams/reactive-streams-jvm/pull/441.diff","patch_url":"https://github.com/reactive-streams/reactive-streams-jvm/pull/441.patch","issue_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/441","number":441,"state":"open","locked":false,"title":"Wait for demand before signaling onNext","user":{"login":"jroper","id":105833,"node_id":"MDQ6VXNlcjEwNTgzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/105833?v=4","gravatar_id":"","url":"https://api.github.com/users/jroper","html_url":"https://github.com/jroper","followers_url":"https://api.github.com/users/jroper/followers","following_url":"https://api.github.com/users/jroper/following{/other_user}","gists_url":"https://api.github.com/users/jroper/gists{/gist_id}","starred_url":"https://api.github.com/users/jroper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroper/subscriptions","organizations_url":"https://api.github.com/users/jroper/orgs","repos_url":"https://api.github.com/users/jroper/repos","events_url":"https://api.github.com/users/jroper/events{/privacy}","received_events_url":"https://api.github.com/users/jroper/received_events","type":"User","site_admin":false},"body":"Fixes #277.\n\nFixes two whitebox subscriber tests where they weren't waiting for demand before signaling onNext.","created_at":"2018-11-18T23:45:07Z","updated_at":"2018-11-19T10:39:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c77f429e3c2d17bec4fcd352db7ad01ddaf36c19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/milestones/12","html_url":"https://github.com/reactive-streams/reactive-streams-jvm/milestone/12","labels_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/milestones/12/labels","id":3080883,"node_id":"MDk6TWlsZXN0b25lMzA4MDg4Mw==","number":12,"title":"1.0.3","description":"Release TBD","creator":{"login":"viktorklang","id":10871,"node_id":"MDQ6VXNlcjEwODcx","avatar_url":"https://avatars2.githubusercontent.com/u/10871?v=4","gravatar_id":"","url":"https://api.github.com/users/viktorklang","html_url":"https://github.com/viktorklang","followers_url":"https://api.github.com/users/viktorklang/followers","following_url":"https://api.github.com/users/viktorklang/following{/other_user}","gists_url":"https://api.github.com/users/viktorklang/gists{/gist_id}","starred_url":"https://api.github.com/users/viktorklang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viktorklang/subscriptions","organizations_url":"https://api.github.com/users/viktorklang/orgs","repos_url":"https://api.github.com/users/viktorklang/repos","events_url":"https://api.github.com/users/viktorklang/events{/privacy}","received_events_url":"https://api.github.com/users/viktorklang/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":9,"state":"open","created_at":"2018-02-01T12:20:03Z","updated_at":"2018-11-19T08:13:45Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/441/commits","review_comments_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/441/comments","review_comment_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/441/comments","statuses_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/statuses/18f3532f0cb25a8ec69c8ef65447d3aeb6d3010b","head":{"label":"jroper:fix-277-expect-request-before-signal-next","ref":"fix-277-expect-request-before-signal-next","sha":"18f3532f0cb25a8ec69c8ef65447d3aeb6d3010b","user":{"login":"jroper","id":105833,"node_id":"MDQ6VXNlcjEwNTgzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/105833?v=4","gravatar_id":"","url":"https://api.github.com/users/jroper","html_url":"https://github.com/jroper","followers_url":"https://api.github.com/users/jroper/followers","following_url":"https://api.github.com/users/jroper/following{/other_user}","gists_url":"https://api.github.com/users/jroper/gists{/gist_id}","starred_url":"https://api.github.com/users/jroper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroper/subscriptions","organizations_url":"https://api.github.com/users/jroper/orgs","repos_url":"https://api.github.com/users/jroper/repos","events_url":"https://api.github.com/users/jroper/events{/privacy}","received_events_url":"https://api.github.com/users/jroper/received_events","type":"User","site_admin":false},"repo":{"id":115959687,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU5NTk2ODc=","name":"reactive-streams-jvm","full_name":"jroper/reactive-streams-jvm","private":false,"owner":{"login":"jroper","id":105833,"node_id":"MDQ6VXNlcjEwNTgzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/105833?v=4","gravatar_id":"","url":"https://api.github.com/users/jroper","html_url":"https://github.com/jroper","followers_url":"https://api.github.com/users/jroper/followers","following_url":"https://api.github.com/users/jroper/following{/other_user}","gists_url":"https://api.github.com/users/jroper/gists{/gist_id}","starred_url":"https://api.github.com/users/jroper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jroper/subscriptions","organizations_url":"https://api.github.com/users/jroper/orgs","repos_url":"https://api.github.com/users/jroper/repos","events_url":"https://api.github.com/users/jroper/events{/privacy}","received_events_url":"https://api.github.com/users/jroper/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jroper/reactive-streams-jvm","description":"Reactive Streams Specification for the JVM","fork":true,"url":"https://api.github.com/repos/jroper/reactive-streams-jvm","forks_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/forks","keys_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/teams","hooks_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/hooks","issue_events_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/events","assignees_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/tags","blobs_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/languages","stargazers_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/stargazers","contributors_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/contributors","subscribers_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/subscribers","subscription_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/subscription","commits_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/merges","archive_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/downloads","issues_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/labels{/name}","releases_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/releases{/id}","deployments_url":"https://api.github.com/repos/jroper/reactive-streams-jvm/deployments","created_at":"2018-01-02T00:57:49Z","updated_at":"2018-01-02T00:57:51Z","pushed_at":"2018-11-19T02:03:59Z","git_url":"git://github.com/jroper/reactive-streams-jvm.git","ssh_url":"git@github.com:jroper/reactive-streams-jvm.git","clone_url":"https://github.com/jroper/reactive-streams-jvm.git","svn_url":"https://github.com/jroper/reactive-streams-jvm","homepage":"http://www.reactive-streams.org/","size":1668,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactive-streams:master","ref":"master","sha":"9464664fb98011e0d1cf976ce22951fe08963469","user":{"login":"reactive-streams","id":7080130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwODAxMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7080130?v=4","gravatar_id":"","url":"https://api.github.com/users/reactive-streams","html_url":"https://github.com/reactive-streams","followers_url":"https://api.github.com/users/reactive-streams/followers","following_url":"https://api.github.com/users/reactive-streams/following{/other_user}","gists_url":"https://api.github.com/users/reactive-streams/gists{/gist_id}","starred_url":"https://api.github.com/users/reactive-streams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactive-streams/subscriptions","organizations_url":"https://api.github.com/users/reactive-streams/orgs","repos_url":"https://api.github.com/users/reactive-streams/repos","events_url":"https://api.github.com/users/reactive-streams/events{/privacy}","received_events_url":"https://api.github.com/users/reactive-streams/received_events","type":"Organization","site_admin":false},"repo":{"id":17286587,"node_id":"MDEwOlJlcG9zaXRvcnkxNzI4NjU4Nw==","name":"reactive-streams-jvm","full_name":"reactive-streams/reactive-streams-jvm","private":false,"owner":{"login":"reactive-streams","id":7080130,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwODAxMzA=","avatar_url":"https://avatars2.githubusercontent.com/u/7080130?v=4","gravatar_id":"","url":"https://api.github.com/users/reactive-streams","html_url":"https://github.com/reactive-streams","followers_url":"https://api.github.com/users/reactive-streams/followers","following_url":"https://api.github.com/users/reactive-streams/following{/other_user}","gists_url":"https://api.github.com/users/reactive-streams/gists{/gist_id}","starred_url":"https://api.github.com/users/reactive-streams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactive-streams/subscriptions","organizations_url":"https://api.github.com/users/reactive-streams/orgs","repos_url":"https://api.github.com/users/reactive-streams/repos","events_url":"https://api.github.com/users/reactive-streams/events{/privacy}","received_events_url":"https://api.github.com/users/reactive-streams/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactive-streams/reactive-streams-jvm","description":"Reactive Streams Specification for the JVM","fork":false,"url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm","forks_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/forks","keys_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/teams","hooks_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/hooks","issue_events_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/events","assignees_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/tags","blobs_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/languages","stargazers_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/stargazers","contributors_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/contributors","subscribers_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/subscribers","subscription_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/subscription","commits_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/merges","archive_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/downloads","issues_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/labels{/name}","releases_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/releases{/id}","deployments_url":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/deployments","created_at":"2014-02-28T13:16:15Z","updated_at":"2018-11-19T08:13:47Z","pushed_at":"2018-11-19T08:13:45Z","git_url":"git://github.com/reactive-streams/reactive-streams-jvm.git","ssh_url":"git@github.com:reactive-streams/reactive-streams-jvm.git","clone_url":"https://github.com/reactive-streams/reactive-streams-jvm.git","svn_url":"https://github.com/reactive-streams/reactive-streams-jvm","homepage":"http://www.reactive-streams.org/","size":1662,"stargazers_count":2714,"watchers_count":2714,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":263,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":263,"open_issues":12,"watchers":2714,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/441"},"html":{"href":"https://github.com/reactive-streams/reactive-streams-jvm/pull/441"},"issue":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/441"},"comments":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/issues/441/comments"},"review_comments":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/441/comments"},"review_comment":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/pulls/441/commits"},"statuses":{"href":"https://api.github.com/repos/reactive-streams/reactive-streams-jvm/statuses/18f3532f0cb25a8ec69c8ef65447d3aeb6d3010b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"viktorklang"}}