{"action":"closed","number":359,"pull_request":{"url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/359","id":168924822,"html_url":"https://github.com/cloudviz/agentless-system-crawler/pull/359","diff_url":"https://github.com/cloudviz/agentless-system-crawler/pull/359.diff","patch_url":"https://github.com/cloudviz/agentless-system-crawler/pull/359.patch","issue_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/359","number":359,"state":"closed","locked":false,"title":"disabling docker events","user":{"login":"nadgowdas","id":8685412,"avatar_url":"https://avatars3.githubusercontent.com/u/8685412?v=4","gravatar_id":"","url":"https://api.github.com/users/nadgowdas","html_url":"https://github.com/nadgowdas","followers_url":"https://api.github.com/users/nadgowdas/followers","following_url":"https://api.github.com/users/nadgowdas/following{/other_user}","gists_url":"https://api.github.com/users/nadgowdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nadgowdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadgowdas/subscriptions","organizations_url":"https://api.github.com/users/nadgowdas/orgs","repos_url":"https://api.github.com/users/nadgowdas/repos","events_url":"https://api.github.com/users/nadgowdas/events{/privacy}","received_events_url":"https://api.github.com/users/nadgowdas/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Shripad Nadgowda <nadgowda@us.ibm.com>\r\n\r\nThis change is to disable docker event support in crawler currently.\r\n\r\nThere were couple of concerns regarding docker-event behavior for live containers in k8s environment:\r\n\r\n1. if some pod is restarted multiple times, or stuck in the crashloopback then crawler crawls them repeatedly and there is lot of redundancy in terms of space consumption at Kafka, execution by annotators and results in ES\r\n2. Usage of sas-apis becomes difficult, since many redundant namespaces gets shown up in /get-namespaces APIs.\r\n\r\nGoing forward as suggested by @canturkisci : \r\n-----------\r\nStep 2: Make Docker events as config option\r\nStep 3: Explore options:\r\n--- Option 1. Run only periodic crawler; Check “uptime” of containers and only scan those that are old enough\r\n--- Option 2. Handle events at the wrapper and do similar kind of checks on whether to actually scan a container when an even comes","created_at":"2018-02-13T18:43:19Z","updated_at":"2018-02-13T20:13:24Z","closed_at":"2018-02-13T20:13:23Z","merged_at":"2018-02-13T20:13:23Z","merge_commit_sha":"35e6dd7a52fa6162d1daaae52ce27b7c0d200a0c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/359/commits","review_comments_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/359/comments","review_comment_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/359/comments","statuses_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/statuses/c9c68b9367acb5232988c07b3641617275bbdf4b","head":{"label":"nadgowdas:issue#5891","ref":"issue#5891","sha":"c9c68b9367acb5232988c07b3641617275bbdf4b","user":{"login":"nadgowdas","id":8685412,"avatar_url":"https://avatars3.githubusercontent.com/u/8685412?v=4","gravatar_id":"","url":"https://api.github.com/users/nadgowdas","html_url":"https://github.com/nadgowdas","followers_url":"https://api.github.com/users/nadgowdas/followers","following_url":"https://api.github.com/users/nadgowdas/following{/other_user}","gists_url":"https://api.github.com/users/nadgowdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nadgowdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadgowdas/subscriptions","organizations_url":"https://api.github.com/users/nadgowdas/orgs","repos_url":"https://api.github.com/users/nadgowdas/repos","events_url":"https://api.github.com/users/nadgowdas/events{/privacy}","received_events_url":"https://api.github.com/users/nadgowdas/received_events","type":"User","site_admin":false},"repo":{"id":88876776,"name":"agentless-system-crawler","full_name":"nadgowdas/agentless-system-crawler","owner":{"login":"nadgowdas","id":8685412,"avatar_url":"https://avatars3.githubusercontent.com/u/8685412?v=4","gravatar_id":"","url":"https://api.github.com/users/nadgowdas","html_url":"https://github.com/nadgowdas","followers_url":"https://api.github.com/users/nadgowdas/followers","following_url":"https://api.github.com/users/nadgowdas/following{/other_user}","gists_url":"https://api.github.com/users/nadgowdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nadgowdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadgowdas/subscriptions","organizations_url":"https://api.github.com/users/nadgowdas/orgs","repos_url":"https://api.github.com/users/nadgowdas/repos","events_url":"https://api.github.com/users/nadgowdas/events{/privacy}","received_events_url":"https://api.github.com/users/nadgowdas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nadgowdas/agentless-system-crawler","description":"A tool to crawl systems like crawlers for the web","fork":true,"url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler","forks_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/forks","keys_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/teams","hooks_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/hooks","issue_events_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/events","assignees_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/tags","blobs_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/languages","stargazers_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/stargazers","contributors_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/contributors","subscribers_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/subscribers","subscription_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/subscription","commits_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/merges","archive_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/downloads","issues_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/labels{/name}","releases_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/releases{/id}","deployments_url":"https://api.github.com/repos/nadgowdas/agentless-system-crawler/deployments","created_at":"2017-04-20T14:43:59Z","updated_at":"2017-07-26T15:00:03Z","pushed_at":"2018-02-13T19:48:12Z","git_url":"git://github.com/nadgowdas/agentless-system-crawler.git","ssh_url":"git@github.com:nadgowdas/agentless-system-crawler.git","clone_url":"https://github.com/nadgowdas/agentless-system-crawler.git","svn_url":"https://github.com/nadgowdas/agentless-system-crawler","homepage":"","size":2125,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudviz:master","ref":"master","sha":"a0ec321baf50f5e2f7ac087a71b429a82a5a139c","user":{"login":"cloudviz","id":13337905,"avatar_url":"https://avatars2.githubusercontent.com/u/13337905?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudviz","html_url":"https://github.com/cloudviz","followers_url":"https://api.github.com/users/cloudviz/followers","following_url":"https://api.github.com/users/cloudviz/following{/other_user}","gists_url":"https://api.github.com/users/cloudviz/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudviz/subscriptions","organizations_url":"https://api.github.com/users/cloudviz/orgs","repos_url":"https://api.github.com/users/cloudviz/repos","events_url":"https://api.github.com/users/cloudviz/events{/privacy}","received_events_url":"https://api.github.com/users/cloudviz/received_events","type":"Organization","site_admin":false},"repo":{"id":39209164,"name":"agentless-system-crawler","full_name":"cloudviz/agentless-system-crawler","owner":{"login":"cloudviz","id":13337905,"avatar_url":"https://avatars2.githubusercontent.com/u/13337905?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudviz","html_url":"https://github.com/cloudviz","followers_url":"https://api.github.com/users/cloudviz/followers","following_url":"https://api.github.com/users/cloudviz/following{/other_user}","gists_url":"https://api.github.com/users/cloudviz/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudviz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudviz/subscriptions","organizations_url":"https://api.github.com/users/cloudviz/orgs","repos_url":"https://api.github.com/users/cloudviz/repos","events_url":"https://api.github.com/users/cloudviz/events{/privacy}","received_events_url":"https://api.github.com/users/cloudviz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudviz/agentless-system-crawler","description":"A tool to crawl systems like crawlers for the web","fork":false,"url":"https://api.github.com/repos/cloudviz/agentless-system-crawler","forks_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/forks","keys_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/teams","hooks_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/hooks","issue_events_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/events{/number}","events_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/events","assignees_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/assignees{/user}","branches_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/branches{/branch}","tags_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/tags","blobs_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/languages","stargazers_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/stargazers","contributors_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/contributors","subscribers_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/subscribers","subscription_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/subscription","commits_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/contents/{+path}","compare_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/merges","archive_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/downloads","issues_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues{/number}","pulls_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/labels{/name}","releases_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/releases{/id}","deployments_url":"https://api.github.com/repos/cloudviz/agentless-system-crawler/deployments","created_at":"2015-07-16T16:51:58Z","updated_at":"2018-02-01T15:15:27Z","pushed_at":"2018-02-13T20:13:23Z","git_url":"git://github.com/cloudviz/agentless-system-crawler.git","ssh_url":"git@github.com:cloudviz/agentless-system-crawler.git","clone_url":"https://github.com/cloudviz/agentless-system-crawler.git","svn_url":"https://github.com/cloudviz/agentless-system-crawler","homepage":"","size":2122,"stargazers_count":73,"watchers_count":73,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":37,"open_issues":42,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/359"},"html":{"href":"https://github.com/cloudviz/agentless-system-crawler/pull/359"},"issue":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/359"},"comments":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/cloudviz/agentless-system-crawler/statuses/c9c68b9367acb5232988c07b3641617275bbdf4b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sahilsuneja1","id":6835847,"avatar_url":"https://avatars0.githubusercontent.com/u/6835847?v=4","gravatar_id":"","url":"https://api.github.com/users/sahilsuneja1","html_url":"https://github.com/sahilsuneja1","followers_url":"https://api.github.com/users/sahilsuneja1/followers","following_url":"https://api.github.com/users/sahilsuneja1/following{/other_user}","gists_url":"https://api.github.com/users/sahilsuneja1/gists{/gist_id}","starred_url":"https://api.github.com/users/sahilsuneja1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sahilsuneja1/subscriptions","organizations_url":"https://api.github.com/users/sahilsuneja1/orgs","repos_url":"https://api.github.com/users/sahilsuneja1/repos","events_url":"https://api.github.com/users/sahilsuneja1/events{/privacy}","received_events_url":"https://api.github.com/users/sahilsuneja1/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":16,"deletions":13,"changed_files":2}}
{"actor":{"display_login":"sahilsuneja1"}}