{"action":"created","comment":{"url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/comments/203884984","pull_request_review_id":138866760,"id":203884984,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzg4NDk4NA==","diff_hunk":"@@ -0,0 +1,8 @@\n+#include \"concurrencyUtil.h\"\n+\n+void initLock(pthread_mutex_t* lock) {\n+    pthread_mutexattr_t attr;\n+    pthread_mutexattr_init(&attr);\n+    pthread_mutexattr_settype(&attr, PTHREAD_MUTEX_RECURSIVE);\n+    pthread_mutex_init(lock, &attr);\n+}","path":"src/concurrencyUtil.cpp","position":8,"original_position":8,"commit_id":"d7b66cb632e2eee47dff3d15f1dbe0ae9138f52a","original_commit_id":"d7b66cb632e2eee47dff3d15f1dbe0ae9138f52a","user":{"login":"KirillTim","id":7231087,"node_id":"MDQ6VXNlcjcyMzEwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7231087?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillTim","html_url":"https://github.com/KirillTim","followers_url":"https://api.github.com/users/KirillTim/followers","following_url":"https://api.github.com/users/KirillTim/following{/other_user}","gists_url":"https://api.github.com/users/KirillTim/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillTim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillTim/subscriptions","organizations_url":"https://api.github.com/users/KirillTim/orgs","repos_url":"https://api.github.com/users/KirillTim/repos","events_url":"https://api.github.com/users/KirillTim/events{/privacy}","received_events_url":"https://api.github.com/users/KirillTim/received_events","type":"User","site_admin":false},"body":"My bad. I personally prefer top level function (being a Kotlin fan). Will fix.\r\nThe question is: should I just put two classes `Mutex` (with one static method) and `MutexLocker` in one `mutex.h/cpp` ?","created_at":"2018-07-19T21:55:05Z","updated_at":"2018-07-19T21:55:05Z","html_url":"https://github.com/jvm-profiling-tools/async-profiler/pull/142#discussion_r203884984","pull_request_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/142","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/comments/203884984"},"html":{"href":"https://github.com/jvm-profiling-tools/async-profiler/pull/142#discussion_r203884984"},"pull_request":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/142"}},"in_reply_to_id":203874721},"pull_request":{"url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/142","id":201293292,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjkzMjky","html_url":"https://github.com/jvm-profiling-tools/async-profiler/pull/142","diff_url":"https://github.com/jvm-profiling-tools/async-profiler/pull/142.diff","patch_url":"https://github.com/jvm-profiling-tools/async-profiler/pull/142.patch","issue_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/issues/142","number":142,"state":"open","locked":false,"title":"Improve JVM thread names support","user":{"login":"KirillTim","id":7231087,"node_id":"MDQ6VXNlcjcyMzEwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7231087?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillTim","html_url":"https://github.com/KirillTim","followers_url":"https://api.github.com/users/KirillTim/followers","following_url":"https://api.github.com/users/KirillTim/following{/other_user}","gists_url":"https://api.github.com/users/KirillTim/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillTim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillTim/subscriptions","organizations_url":"https://api.github.com/users/KirillTim/orgs","repos_url":"https://api.github.com/users/KirillTim/repos","events_url":"https://api.github.com/users/KirillTim/events{/privacy}","received_events_url":"https://api.github.com/users/KirillTim/received_events","type":"User","site_admin":false},"body":"This PR brings better JVM thread names reporting.\r\n- VMStructs symbols are loaded at the same time when AGCT symbols do: it fix bug when no thread names was reported by perf engine.\r\n- Thread names storage is updated on every thread start and thread end: we can get names not only for active at the moment of dump threads , but also for all threads that had already stopped.\r\n- I slightly changed thread output format to `[<thread Name> tid=<thread id>]`, because we need to distinguish different threads with the same name and to understand if dump contains thread labels or not.","created_at":"2018-07-13T13:35:51Z","updated_at":"2018-07-19T21:55:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af3da5524b6ccb6ce933a6a57b8fae3983b79dda","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/142/commits","review_comments_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/142/comments","review_comment_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/issues/142/comments","statuses_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/statuses/d7b66cb632e2eee47dff3d15f1dbe0ae9138f52a","head":{"label":"KirillTim:thread-names","ref":"thread-names","sha":"d7b66cb632e2eee47dff3d15f1dbe0ae9138f52a","user":{"login":"KirillTim","id":7231087,"node_id":"MDQ6VXNlcjcyMzEwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7231087?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillTim","html_url":"https://github.com/KirillTim","followers_url":"https://api.github.com/users/KirillTim/followers","following_url":"https://api.github.com/users/KirillTim/following{/other_user}","gists_url":"https://api.github.com/users/KirillTim/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillTim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillTim/subscriptions","organizations_url":"https://api.github.com/users/KirillTim/orgs","repos_url":"https://api.github.com/users/KirillTim/repos","events_url":"https://api.github.com/users/KirillTim/events{/privacy}","received_events_url":"https://api.github.com/users/KirillTim/received_events","type":"User","site_admin":false},"repo":{"id":139257413,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyNTc0MTM=","name":"async-profiler","full_name":"KirillTim/async-profiler","owner":{"login":"KirillTim","id":7231087,"node_id":"MDQ6VXNlcjcyMzEwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/7231087?v=4","gravatar_id":"","url":"https://api.github.com/users/KirillTim","html_url":"https://github.com/KirillTim","followers_url":"https://api.github.com/users/KirillTim/followers","following_url":"https://api.github.com/users/KirillTim/following{/other_user}","gists_url":"https://api.github.com/users/KirillTim/gists{/gist_id}","starred_url":"https://api.github.com/users/KirillTim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KirillTim/subscriptions","organizations_url":"https://api.github.com/users/KirillTim/orgs","repos_url":"https://api.github.com/users/KirillTim/repos","events_url":"https://api.github.com/users/KirillTim/events{/privacy}","received_events_url":"https://api.github.com/users/KirillTim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KirillTim/async-profiler","description":"Sampling CPU and HEAP profiler for Java featuring AsyncGetCallTrace + perf_events","fork":true,"url":"https://api.github.com/repos/KirillTim/async-profiler","forks_url":"https://api.github.com/repos/KirillTim/async-profiler/forks","keys_url":"https://api.github.com/repos/KirillTim/async-profiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KirillTim/async-profiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KirillTim/async-profiler/teams","hooks_url":"https://api.github.com/repos/KirillTim/async-profiler/hooks","issue_events_url":"https://api.github.com/repos/KirillTim/async-profiler/issues/events{/number}","events_url":"https://api.github.com/repos/KirillTim/async-profiler/events","assignees_url":"https://api.github.com/repos/KirillTim/async-profiler/assignees{/user}","branches_url":"https://api.github.com/repos/KirillTim/async-profiler/branches{/branch}","tags_url":"https://api.github.com/repos/KirillTim/async-profiler/tags","blobs_url":"https://api.github.com/repos/KirillTim/async-profiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KirillTim/async-profiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KirillTim/async-profiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/KirillTim/async-profiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KirillTim/async-profiler/statuses/{sha}","languages_url":"https://api.github.com/repos/KirillTim/async-profiler/languages","stargazers_url":"https://api.github.com/repos/KirillTim/async-profiler/stargazers","contributors_url":"https://api.github.com/repos/KirillTim/async-profiler/contributors","subscribers_url":"https://api.github.com/repos/KirillTim/async-profiler/subscribers","subscription_url":"https://api.github.com/repos/KirillTim/async-profiler/subscription","commits_url":"https://api.github.com/repos/KirillTim/async-profiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/KirillTim/async-profiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/KirillTim/async-profiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/KirillTim/async-profiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/KirillTim/async-profiler/contents/{+path}","compare_url":"https://api.github.com/repos/KirillTim/async-profiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KirillTim/async-profiler/merges","archive_url":"https://api.github.com/repos/KirillTim/async-profiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KirillTim/async-profiler/downloads","issues_url":"https://api.github.com/repos/KirillTim/async-profiler/issues{/number}","pulls_url":"https://api.github.com/repos/KirillTim/async-profiler/pulls{/number}","milestones_url":"https://api.github.com/repos/KirillTim/async-profiler/milestones{/number}","notifications_url":"https://api.github.com/repos/KirillTim/async-profiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KirillTim/async-profiler/labels{/name}","releases_url":"https://api.github.com/repos/KirillTim/async-profiler/releases{/id}","deployments_url":"https://api.github.com/repos/KirillTim/async-profiler/deployments","created_at":"2018-06-30T14:54:07Z","updated_at":"2018-07-04T17:38:10Z","pushed_at":"2018-07-19T17:46:48Z","git_url":"git://github.com/KirillTim/async-profiler.git","ssh_url":"git@github.com:KirillTim/async-profiler.git","clone_url":"https://github.com/KirillTim/async-profiler.git","svn_url":"https://github.com/KirillTim/async-profiler","homepage":"https://github.com/jvm-profiling-tools/async-profiler/releases","size":438,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jvm-profiling-tools:master","ref":"master","sha":"152bf8c64d2ec5408313facc27fe492e182324d6","user":{"login":"jvm-profiling-tools","id":26695883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Njk1ODgz","avatar_url":"https://avatars2.githubusercontent.com/u/26695883?v=4","gravatar_id":"","url":"https://api.github.com/users/jvm-profiling-tools","html_url":"https://github.com/jvm-profiling-tools","followers_url":"https://api.github.com/users/jvm-profiling-tools/followers","following_url":"https://api.github.com/users/jvm-profiling-tools/following{/other_user}","gists_url":"https://api.github.com/users/jvm-profiling-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/jvm-profiling-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvm-profiling-tools/subscriptions","organizations_url":"https://api.github.com/users/jvm-profiling-tools/orgs","repos_url":"https://api.github.com/users/jvm-profiling-tools/repos","events_url":"https://api.github.com/users/jvm-profiling-tools/events{/privacy}","received_events_url":"https://api.github.com/users/jvm-profiling-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":56894212,"node_id":"MDEwOlJlcG9zaXRvcnk1Njg5NDIxMg==","name":"async-profiler","full_name":"jvm-profiling-tools/async-profiler","owner":{"login":"jvm-profiling-tools","id":26695883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Njk1ODgz","avatar_url":"https://avatars2.githubusercontent.com/u/26695883?v=4","gravatar_id":"","url":"https://api.github.com/users/jvm-profiling-tools","html_url":"https://github.com/jvm-profiling-tools","followers_url":"https://api.github.com/users/jvm-profiling-tools/followers","following_url":"https://api.github.com/users/jvm-profiling-tools/following{/other_user}","gists_url":"https://api.github.com/users/jvm-profiling-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/jvm-profiling-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvm-profiling-tools/subscriptions","organizations_url":"https://api.github.com/users/jvm-profiling-tools/orgs","repos_url":"https://api.github.com/users/jvm-profiling-tools/repos","events_url":"https://api.github.com/users/jvm-profiling-tools/events{/privacy}","received_events_url":"https://api.github.com/users/jvm-profiling-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jvm-profiling-tools/async-profiler","description":"Sampling CPU and HEAP profiler for Java featuring AsyncGetCallTrace + perf_events","fork":false,"url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler","forks_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/forks","keys_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/teams","hooks_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/hooks","issue_events_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/issues/events{/number}","events_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/events","assignees_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/assignees{/user}","branches_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/branches{/branch}","tags_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/tags","blobs_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/statuses/{sha}","languages_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/languages","stargazers_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/stargazers","contributors_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/contributors","subscribers_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/subscribers","subscription_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/subscription","commits_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/contents/{+path}","compare_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/merges","archive_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/downloads","issues_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/issues{/number}","pulls_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls{/number}","milestones_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/milestones{/number}","notifications_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/labels{/name}","releases_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/releases{/id}","deployments_url":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/deployments","created_at":"2016-04-23T01:27:15Z","updated_at":"2018-07-18T09:31:49Z","pushed_at":"2018-07-19T17:46:49Z","git_url":"git://github.com/jvm-profiling-tools/async-profiler.git","ssh_url":"git@github.com:jvm-profiling-tools/async-profiler.git","clone_url":"https://github.com/jvm-profiling-tools/async-profiler.git","svn_url":"https://github.com/jvm-profiling-tools/async-profiler","homepage":"https://github.com/jvm-profiling-tools/async-profiler/releases","size":392,"stargazers_count":1021,"watchers_count":1021,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":111,"open_issues":15,"watchers":1021,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/142"},"html":{"href":"https://github.com/jvm-profiling-tools/async-profiler/pull/142"},"issue":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/issues/142"},"comments":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/jvm-profiling-tools/async-profiler/statuses/d7b66cb632e2eee47dff3d15f1dbe0ae9138f52a"}},"author_association":"NONE"}}
{"actor":{"display_login":"KirillTim"}}