{"action":"created","comment":{"url":"https://api.github.com/repos/bazelbuild/skydoc/pulls/comments/212090085","pull_request_review_id":148649250,"id":212090085,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjA5MDA4NQ==","diff_hunk":"@@ -11,6 +11,16 @@ git_repository(\n     remote = \"https://github.com/bazelbuild/bazel-skylib.git\",\n     tag = \"0.2.0\",\n )\n+git_repository(\n+    name = \"io_bazel\",\n+    remote = \"https://github.com/bazelbuild/bazel.git\",\n+    commit = \"b749ab1f8549cdad0a574c356a57fe7181b07851\",","path":"WORKSPACE","position":7,"original_position":7,"commit_id":"b349e800c76a338b50d3119de8b376319ed30df7","original_commit_id":"317cc20d0c1adff18c791f697f2cddd0e0024e53","user":{"login":"brandjon","id":1308070,"node_id":"MDQ6VXNlcjEzMDgwNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1308070?v=4","gravatar_id":"","url":"https://api.github.com/users/brandjon","html_url":"https://github.com/brandjon","followers_url":"https://api.github.com/users/brandjon/followers","following_url":"https://api.github.com/users/brandjon/following{/other_user}","gists_url":"https://api.github.com/users/brandjon/gists{/gist_id}","starred_url":"https://api.github.com/users/brandjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandjon/subscriptions","organizations_url":"https://api.github.com/users/brandjon/orgs","repos_url":"https://api.github.com/users/brandjon/repos","events_url":"https://api.github.com/users/brandjon/events{/privacy}","received_events_url":"https://api.github.com/users/brandjon/received_events","type":"User","site_admin":false},"body":"Hopefully release tags are reproducible and the upstream isn't reusing tags. That sounds as bad as force pushing commits that've already made it into circulation.\r\n\r\nBut even if it's a hash, it could still be a release hash annotated with the release name:\r\n\r\n    commit = \"...\"   # release 0.1.2\r\n\r\nAnyway, for this PR it's up to you whether to make a new branch or publish these changes to all users immediately.","created_at":"2018-08-22T20:06:00Z","updated_at":"2018-08-22T20:06:00Z","html_url":"https://github.com/bazelbuild/skydoc/pull/105#discussion_r212090085","pull_request_url":"https://api.github.com/repos/bazelbuild/skydoc/pulls/105","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/skydoc/pulls/comments/212090085"},"html":{"href":"https://github.com/bazelbuild/skydoc/pull/105#discussion_r212090085"},"pull_request":{"href":"https://api.github.com/repos/bazelbuild/skydoc/pulls/105"}},"in_reply_to_id":212009050},"pull_request":{"url":"https://api.github.com/repos/bazelbuild/skydoc/pulls/105","id":209651986,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjUxOTg2","html_url":"https://github.com/bazelbuild/skydoc/pull/105","diff_url":"https://github.com/bazelbuild/skydoc/pull/105.diff","patch_url":"https://github.com/bazelbuild/skydoc/pull/105.patch","issue_url":"https://api.github.com/repos/bazelbuild/skydoc/issues/105","number":105,"state":"open","locked":false,"title":"Initial checkin of skydoc.bzl: a rewrite of skydoc","user":{"login":"c-parsons","id":13687552,"node_id":"MDQ6VXNlcjEzNjg3NTUy","avatar_url":"https://avatars0.githubusercontent.com/u/13687552?v=4","gravatar_id":"","url":"https://api.github.com/users/c-parsons","html_url":"https://github.com/c-parsons","followers_url":"https://api.github.com/users/c-parsons/followers","following_url":"https://api.github.com/users/c-parsons/following{/other_user}","gists_url":"https://api.github.com/users/c-parsons/gists{/gist_id}","starred_url":"https://api.github.com/users/c-parsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c-parsons/subscriptions","organizations_url":"https://api.github.com/users/c-parsons/orgs","repos_url":"https://api.github.com/users/c-parsons/repos","events_url":"https://api.github.com/users/c-parsons/events{/privacy}","received_events_url":"https://api.github.com/users/c-parsons/received_events","type":"User","site_admin":false},"body":"My primary concern with this review is I'm having a tough time with naming. I hope we can soon deprecate and kill the old skydoc, so I'm hoping we can just call this new thing \"Skydoc\". I'm resistant to calling this experimental_skydoc or new_skydoc.\r\n\r\nMaybe.. huh. Stardoc? >_>\r\n\r\nPlease give me your feedback :)","created_at":"2018-08-20T21:42:28Z","updated_at":"2018-08-22T20:06:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46a45b3fb05e2828fbde2532c663a9b5008ad1b9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"laurentlb","id":485572,"node_id":"MDQ6VXNlcjQ4NTU3Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/485572?v=4","gravatar_id":"","url":"https://api.github.com/users/laurentlb","html_url":"https://github.com/laurentlb","followers_url":"https://api.github.com/users/laurentlb/followers","following_url":"https://api.github.com/users/laurentlb/following{/other_user}","gists_url":"https://api.github.com/users/laurentlb/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentlb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentlb/subscriptions","organizations_url":"https://api.github.com/users/laurentlb/orgs","repos_url":"https://api.github.com/users/laurentlb/repos","events_url":"https://api.github.com/users/laurentlb/events{/privacy}","received_events_url":"https://api.github.com/users/laurentlb/received_events","type":"User","site_admin":false},{"login":"dkelmer","id":7478131,"node_id":"MDQ6VXNlcjc0NzgxMzE=","avatar_url":"https://avatars0.githubusercontent.com/u/7478131?v=4","gravatar_id":"","url":"https://api.github.com/users/dkelmer","html_url":"https://github.com/dkelmer","followers_url":"https://api.github.com/users/dkelmer/followers","following_url":"https://api.github.com/users/dkelmer/following{/other_user}","gists_url":"https://api.github.com/users/dkelmer/gists{/gist_id}","starred_url":"https://api.github.com/users/dkelmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkelmer/subscriptions","organizations_url":"https://api.github.com/users/dkelmer/orgs","repos_url":"https://api.github.com/users/dkelmer/repos","events_url":"https://api.github.com/users/dkelmer/events{/privacy}","received_events_url":"https://api.github.com/users/dkelmer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":350147962,"node_id":"MDU6TGFiZWwzNTAxNDc5NjI=","url":"https://api.github.com/repos/bazelbuild/skydoc/labels/cla:%20yes","name":"cla: yes","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bazelbuild/skydoc/pulls/105/commits","review_comments_url":"https://api.github.com/repos/bazelbuild/skydoc/pulls/105/comments","review_comment_url":"https://api.github.com/repos/bazelbuild/skydoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazelbuild/skydoc/issues/105/comments","statuses_url":"https://api.github.com/repos/bazelbuild/skydoc/statuses/b349e800c76a338b50d3119de8b376319ed30df7","head":{"label":"bazelbuild:java-skydoc-checkin","ref":"java-skydoc-checkin","sha":"b349e800c76a338b50d3119de8b376319ed30df7","user":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":55097513,"node_id":"MDEwOlJlcG9zaXRvcnk1NTA5NzUxMw==","name":"skydoc","full_name":"bazelbuild/skydoc","owner":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazelbuild/skydoc","description":"Documentation generator for Skylark","fork":false,"url":"https://api.github.com/repos/bazelbuild/skydoc","forks_url":"https://api.github.com/repos/bazelbuild/skydoc/forks","keys_url":"https://api.github.com/repos/bazelbuild/skydoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/skydoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/skydoc/teams","hooks_url":"https://api.github.com/repos/bazelbuild/skydoc/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/skydoc/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/skydoc/events","assignees_url":"https://api.github.com/repos/bazelbuild/skydoc/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/skydoc/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/skydoc/tags","blobs_url":"https://api.github.com/repos/bazelbuild/skydoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/skydoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/skydoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/skydoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/skydoc/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/skydoc/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/skydoc/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/skydoc/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/skydoc/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/skydoc/subscription","commits_url":"https://api.github.com/repos/bazelbuild/skydoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/skydoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/skydoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/skydoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/skydoc/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/skydoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/skydoc/merges","archive_url":"https://api.github.com/repos/bazelbuild/skydoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/skydoc/downloads","issues_url":"https://api.github.com/repos/bazelbuild/skydoc/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/skydoc/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/skydoc/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/skydoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/skydoc/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/skydoc/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/skydoc/deployments","created_at":"2016-03-30T21:00:57Z","updated_at":"2018-08-20T19:02:06Z","pushed_at":"2018-08-22T19:31:22Z","git_url":"git://github.com/bazelbuild/skydoc.git","ssh_url":"git@github.com:bazelbuild/skydoc.git","clone_url":"https://github.com/bazelbuild/skydoc.git","svn_url":"https://github.com/bazelbuild/skydoc","homepage":"https://skydoc.bazel.build/","size":302,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":27,"watchers":24,"default_branch":"master"}},"base":{"label":"bazelbuild:master","ref":"master","sha":"9d01af0f902740ceb7b425150238e1169e1c2c06","user":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"repo":{"id":55097513,"node_id":"MDEwOlJlcG9zaXRvcnk1NTA5NzUxMw==","name":"skydoc","full_name":"bazelbuild/skydoc","owner":{"login":"bazelbuild","id":11684617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjg0NjE3","avatar_url":"https://avatars1.githubusercontent.com/u/11684617?v=4","gravatar_id":"","url":"https://api.github.com/users/bazelbuild","html_url":"https://github.com/bazelbuild","followers_url":"https://api.github.com/users/bazelbuild/followers","following_url":"https://api.github.com/users/bazelbuild/following{/other_user}","gists_url":"https://api.github.com/users/bazelbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/bazelbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazelbuild/subscriptions","organizations_url":"https://api.github.com/users/bazelbuild/orgs","repos_url":"https://api.github.com/users/bazelbuild/repos","events_url":"https://api.github.com/users/bazelbuild/events{/privacy}","received_events_url":"https://api.github.com/users/bazelbuild/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazelbuild/skydoc","description":"Documentation generator for Skylark","fork":false,"url":"https://api.github.com/repos/bazelbuild/skydoc","forks_url":"https://api.github.com/repos/bazelbuild/skydoc/forks","keys_url":"https://api.github.com/repos/bazelbuild/skydoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazelbuild/skydoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazelbuild/skydoc/teams","hooks_url":"https://api.github.com/repos/bazelbuild/skydoc/hooks","issue_events_url":"https://api.github.com/repos/bazelbuild/skydoc/issues/events{/number}","events_url":"https://api.github.com/repos/bazelbuild/skydoc/events","assignees_url":"https://api.github.com/repos/bazelbuild/skydoc/assignees{/user}","branches_url":"https://api.github.com/repos/bazelbuild/skydoc/branches{/branch}","tags_url":"https://api.github.com/repos/bazelbuild/skydoc/tags","blobs_url":"https://api.github.com/repos/bazelbuild/skydoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazelbuild/skydoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazelbuild/skydoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazelbuild/skydoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazelbuild/skydoc/statuses/{sha}","languages_url":"https://api.github.com/repos/bazelbuild/skydoc/languages","stargazers_url":"https://api.github.com/repos/bazelbuild/skydoc/stargazers","contributors_url":"https://api.github.com/repos/bazelbuild/skydoc/contributors","subscribers_url":"https://api.github.com/repos/bazelbuild/skydoc/subscribers","subscription_url":"https://api.github.com/repos/bazelbuild/skydoc/subscription","commits_url":"https://api.github.com/repos/bazelbuild/skydoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazelbuild/skydoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazelbuild/skydoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazelbuild/skydoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazelbuild/skydoc/contents/{+path}","compare_url":"https://api.github.com/repos/bazelbuild/skydoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazelbuild/skydoc/merges","archive_url":"https://api.github.com/repos/bazelbuild/skydoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazelbuild/skydoc/downloads","issues_url":"https://api.github.com/repos/bazelbuild/skydoc/issues{/number}","pulls_url":"https://api.github.com/repos/bazelbuild/skydoc/pulls{/number}","milestones_url":"https://api.github.com/repos/bazelbuild/skydoc/milestones{/number}","notifications_url":"https://api.github.com/repos/bazelbuild/skydoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazelbuild/skydoc/labels{/name}","releases_url":"https://api.github.com/repos/bazelbuild/skydoc/releases{/id}","deployments_url":"https://api.github.com/repos/bazelbuild/skydoc/deployments","created_at":"2016-03-30T21:00:57Z","updated_at":"2018-08-20T19:02:06Z","pushed_at":"2018-08-22T19:31:22Z","git_url":"git://github.com/bazelbuild/skydoc.git","ssh_url":"git@github.com:bazelbuild/skydoc.git","clone_url":"https://github.com/bazelbuild/skydoc.git","svn_url":"https://github.com/bazelbuild/skydoc","homepage":"https://skydoc.bazel.build/","size":302,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":27,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazelbuild/skydoc/pulls/105"},"html":{"href":"https://github.com/bazelbuild/skydoc/pull/105"},"issue":{"href":"https://api.github.com/repos/bazelbuild/skydoc/issues/105"},"comments":{"href":"https://api.github.com/repos/bazelbuild/skydoc/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/bazelbuild/skydoc/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/bazelbuild/skydoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazelbuild/skydoc/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/bazelbuild/skydoc/statuses/b349e800c76a338b50d3119de8b376319ed30df7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brandjon"}}