{"action":"created","issue":{"url":"https://api.github.com/repos/kripken/emscripten/issues/7658","repository_url":"https://api.github.com/repos/kripken/emscripten","labels_url":"https://api.github.com/repos/kripken/emscripten/issues/7658/labels{/name}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/7658/comments","events_url":"https://api.github.com/repos/kripken/emscripten/issues/7658/events","html_url":"https://github.com/kripken/emscripten/pull/7658","id":390867686,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTM4MzUy","number":7658,"title":"Simplify handling of temporary test files. NFC.","user":{"login":"sbc100","id":515813,"node_id":"MDQ6VXNlcjUxNTgxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/515813?v=4","gravatar_id":"","url":"https://api.github.com/users/sbc100","html_url":"https://github.com/sbc100","followers_url":"https://api.github.com/users/sbc100/followers","following_url":"https://api.github.com/users/sbc100/following{/other_user}","gists_url":"https://api.github.com/users/sbc100/gists{/gist_id}","starred_url":"https://api.github.com/users/sbc100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbc100/subscriptions","organizations_url":"https://api.github.com/users/sbc100/orgs","repos_url":"https://api.github.com/users/sbc100/repos","events_url":"https://api.github.com/users/sbc100/events{/privacy}","received_events_url":"https://api.github.com/users/sbc100/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-13T21:29:38Z","updated_at":"2018-12-13T21:51:22Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/7658","html_url":"https://github.com/kripken/emscripten/pull/7658","diff_url":"https://github.com/kripken/emscripten/pull/7658.diff","patch_url":"https://github.com/kripken/emscripten/pull/7658.patch"},"body":"- Remove single argument use of `self.in_dir()`.\r\n  All tests run in their own directory, so `self.in_dir('foo')` is\r\n  normally equivialent to just `'foo'`\r\n- Same for os.path.join(self.get_dir(), ...)\r\n- Use new utility function `create_test_file` in place of open('w')\r\n  for consistency."},"comment":{"url":"https://api.github.com/repos/kripken/emscripten/issues/comments/447133586","html_url":"https://github.com/kripken/emscripten/pull/7658#issuecomment-447133586","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/7658","id":447133586,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzEzMzU4Ng==","user":{"login":"sbc100","id":515813,"node_id":"MDQ6VXNlcjUxNTgxMw==","avatar_url":"https://avatars2.githubusercontent.com/u/515813?v=4","gravatar_id":"","url":"https://api.github.com/users/sbc100","html_url":"https://github.com/sbc100","followers_url":"https://api.github.com/users/sbc100/followers","following_url":"https://api.github.com/users/sbc100/following{/other_user}","gists_url":"https://api.github.com/users/sbc100/gists{/gist_id}","starred_url":"https://api.github.com/users/sbc100/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbc100/subscriptions","organizations_url":"https://api.github.com/users/sbc100/orgs","repos_url":"https://api.github.com/users/sbc100/repos","events_url":"https://api.github.com/users/sbc100/events{/privacy}","received_events_url":"https://api.github.com/users/sbc100/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T21:51:22Z","updated_at":"2018-12-13T21:51:22Z","author_association":"COLLABORATOR","body":"This change large largely mechanical created using these regexes:\r\n```\r\n%s/self.in_dir(\\('[^']*'\\))/\\1/c\r\n%s/with open(\\('.*'\\), 'w') as f:\\n.*f.write(/create_test_file(\\1, /c\r\n%s/open(\\(.*\\), 'w').write(/create_test_file(\\1, /c\r\n```"}}
{"actor":{"display_login":"sbc100"}}