{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-nio/issues/447","repository_url":"https://api.github.com/repos/apple/swift-nio","labels_url":"https://api.github.com/repos/apple/swift-nio/issues/447/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-nio/issues/447/comments","events_url":"https://api.github.com/repos/apple/swift-nio/issues/447/events","html_url":"https://github.com/apple/swift-nio/pull/447","id":326832919,"number":447,"title":"fix threading in testUpgradeWithUpgradePayloadInlineWithRequestWorks","user":{"login":"weissi","id":624238,"avatar_url":"https://avatars2.githubusercontent.com/u/624238?v=4","gravatar_id":"","url":"https://api.github.com/users/weissi","html_url":"https://github.com/weissi","followers_url":"https://api.github.com/users/weissi/followers","following_url":"https://api.github.com/users/weissi/following{/other_user}","gists_url":"https://api.github.com/users/weissi/gists{/gist_id}","starred_url":"https://api.github.com/users/weissi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weissi/subscriptions","organizations_url":"https://api.github.com/users/weissi/orgs","repos_url":"https://api.github.com/users/weissi/repos","events_url":"https://api.github.com/users/weissi/events{/privacy}","received_events_url":"https://api.github.com/users/weissi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-27T17:09:05Z","updated_at":"2018-05-27T17:37:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apple/swift-nio/pulls/447","html_url":"https://github.com/apple/swift-nio/pull/447","diff_url":"https://github.com/apple/swift-nio/pull/447.diff","patch_url":"https://github.com/apple/swift-nio/pull/447.patch"},"body":"Motivation:\r\n\r\ntestUpgradeWithUpgradePayloadInlineWithRequestWorks used the\r\nEmbeddedEventLoop to allocate some futures but setUpTestWithAutoremoval\r\nspawns a MultiThreadedEventLoopGroup. Hence, threading was broken in the\r\ntest and this PR fixes it.\r\n\r\nModifications:\r\n\r\nuse a MultiThreadedEventLoopGroup instead of an EmbeddedEventLoop\r\n\r\nResult:\r\n\r\ntests pass in TSan again\r\n"},"comment":{"url":"https://api.github.com/repos/apple/swift-nio/issues/comments/392349900","html_url":"https://github.com/apple/swift-nio/pull/447#issuecomment-392349900","issue_url":"https://api.github.com/repos/apple/swift-nio/issues/447","id":392349900,"user":{"login":"weissi","id":624238,"avatar_url":"https://avatars2.githubusercontent.com/u/624238?v=4","gravatar_id":"","url":"https://api.github.com/users/weissi","html_url":"https://github.com/weissi","followers_url":"https://api.github.com/users/weissi/followers","following_url":"https://api.github.com/users/weissi/following{/other_user}","gists_url":"https://api.github.com/users/weissi/gists{/gist_id}","starred_url":"https://api.github.com/users/weissi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weissi/subscriptions","organizations_url":"https://api.github.com/users/weissi/orgs","repos_url":"https://api.github.com/users/weissi/repos","events_url":"https://api.github.com/users/weissi/events{/privacy}","received_events_url":"https://api.github.com/users/weissi/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T17:37:23Z","updated_at":"2018-05-27T17:37:23Z","author_association":"CONTRIBUTOR","body":"@Lukasa sorry I'll merge this as Norman approved and it's blocking my `while true` test runs :P"}}
{"actor":{"display_login":"weissi"}}