{"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/214411468","pull_request_review_id":151470057,"id":214411468,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQxMTQ2OA==","diff_hunk":"@@ -322,7 +332,7 @@ func aggregateManifests(newManifests []*Manifest, newMoM *Manifest, version uint\n }\n \n // CreateManifests creates update manifests for changed and added bundles for <version>\n-func CreateManifests(version uint32, minVersion uint32, format uint, statedir string) (*MoM, error) {\n+func CreateManifests(version uint32, minVersion uint32, format uint, statedir string, numWorkers int) (*MoM, error) {","path":"swupd/create_manifests.go","position":116,"original_position":116,"commit_id":"219aa634ec28d26174e82b76d835b1cbe1f3921d","original_commit_id":"219aa634ec28d26174e82b76d835b1cbe1f3921d","user":{"login":"matthewrsj","id":12090084,"node_id":"MDQ6VXNlcjEyMDkwMDg0","avatar_url":"https://avatars0.githubusercontent.com/u/12090084?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrsj","html_url":"https://github.com/matthewrsj","followers_url":"https://api.github.com/users/matthewrsj/followers","following_url":"https://api.github.com/users/matthewrsj/following{/other_user}","gists_url":"https://api.github.com/users/matthewrsj/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrsj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrsj/subscriptions","organizations_url":"https://api.github.com/users/matthewrsj/orgs","repos_url":"https://api.github.com/users/matthewrsj/repos","events_url":"https://api.github.com/users/matthewrsj/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrsj/received_events","type":"User","site_admin":false},"body":"I wouldn't use the `build` subpackage as a good example of a package that follows good API practices. I think it is more intended as an internal package than an external one 😕 \r\n\r\nThe swupd subpackage on the other hand should try to follow good practices for a useful API. I'm sure it **never** violates that principle. 😜 ","created_at":"2018-08-31T16:41:25Z","updated_at":"2018-08-31T16:41:25Z","html_url":"https://github.com/clearlinux/mixer-tools/pull/417#discussion_r214411468","pull_request_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/417","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/214411468"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/417#discussion_r214411468"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/417"}},"in_reply_to_id":214409468},"pull_request":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/417","id":212132289,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTMyMjg5","html_url":"https://github.com/clearlinux/mixer-tools/pull/417","diff_url":"https://github.com/clearlinux/mixer-tools/pull/417.diff","patch_url":"https://github.com/clearlinux/mixer-tools/pull/417.patch","issue_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/417","number":417,"state":"open","locked":false,"title":"Manifest error","user":{"login":"rchiossi","id":232189,"node_id":"MDQ6VXNlcjIzMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/232189?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiossi","html_url":"https://github.com/rchiossi","followers_url":"https://api.github.com/users/rchiossi/followers","following_url":"https://api.github.com/users/rchiossi/following{/other_user}","gists_url":"https://api.github.com/users/rchiossi/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiossi/subscriptions","organizations_url":"https://api.github.com/users/rchiossi/orgs","repos_url":"https://api.github.com/users/rchiossi/repos","events_url":"https://api.github.com/users/rchiossi/events{/privacy}","received_events_url":"https://api.github.com/users/rchiossi/received_events","type":"User","site_admin":false},"body":"This patch fix the error handling issue in manifest creation and change it so the number of worker threads matches the one defined by --bundle-workers option. See commit message for detailed description on the issue.","created_at":"2018-08-30T16:05:10Z","updated_at":"2018-08-31T16:41:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f8e90d0cf863e79c6b9934d0845e71dea0396809","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/417/commits","review_comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/417/comments","review_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/417/comments","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/219aa634ec28d26174e82b76d835b1cbe1f3921d","head":{"label":"rchiossi:manifest_error","ref":"manifest_error","sha":"219aa634ec28d26174e82b76d835b1cbe1f3921d","user":{"login":"rchiossi","id":232189,"node_id":"MDQ6VXNlcjIzMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/232189?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiossi","html_url":"https://github.com/rchiossi","followers_url":"https://api.github.com/users/rchiossi/followers","following_url":"https://api.github.com/users/rchiossi/following{/other_user}","gists_url":"https://api.github.com/users/rchiossi/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiossi/subscriptions","organizations_url":"https://api.github.com/users/rchiossi/orgs","repos_url":"https://api.github.com/users/rchiossi/repos","events_url":"https://api.github.com/users/rchiossi/events{/privacy}","received_events_url":"https://api.github.com/users/rchiossi/received_events","type":"User","site_admin":false},"repo":{"id":113222146,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMyMjIxNDY=","name":"mixer-tools","full_name":"rchiossi/mixer-tools","owner":{"login":"rchiossi","id":232189,"node_id":"MDQ6VXNlcjIzMjE4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/232189?v=4","gravatar_id":"","url":"https://api.github.com/users/rchiossi","html_url":"https://github.com/rchiossi","followers_url":"https://api.github.com/users/rchiossi/followers","following_url":"https://api.github.com/users/rchiossi/following{/other_user}","gists_url":"https://api.github.com/users/rchiossi/gists{/gist_id}","starred_url":"https://api.github.com/users/rchiossi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rchiossi/subscriptions","organizations_url":"https://api.github.com/users/rchiossi/orgs","repos_url":"https://api.github.com/users/rchiossi/repos","events_url":"https://api.github.com/users/rchiossi/events{/privacy}","received_events_url":"https://api.github.com/users/rchiossi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rchiossi/mixer-tools","description":null,"fork":true,"url":"https://api.github.com/repos/rchiossi/mixer-tools","forks_url":"https://api.github.com/repos/rchiossi/mixer-tools/forks","keys_url":"https://api.github.com/repos/rchiossi/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rchiossi/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rchiossi/mixer-tools/teams","hooks_url":"https://api.github.com/repos/rchiossi/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/rchiossi/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/rchiossi/mixer-tools/events","assignees_url":"https://api.github.com/repos/rchiossi/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/rchiossi/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/rchiossi/mixer-tools/tags","blobs_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rchiossi/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/rchiossi/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/rchiossi/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/rchiossi/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/rchiossi/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/rchiossi/mixer-tools/subscription","commits_url":"https://api.github.com/repos/rchiossi/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/rchiossi/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/rchiossi/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/rchiossi/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/rchiossi/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/rchiossi/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rchiossi/mixer-tools/merges","archive_url":"https://api.github.com/repos/rchiossi/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rchiossi/mixer-tools/downloads","issues_url":"https://api.github.com/repos/rchiossi/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/rchiossi/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/rchiossi/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/rchiossi/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rchiossi/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/rchiossi/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/rchiossi/mixer-tools/deployments","created_at":"2017-12-05T19:09:03Z","updated_at":"2017-12-05T19:09:04Z","pushed_at":"2018-08-30T23:45:16Z","git_url":"git://github.com/rchiossi/mixer-tools.git","ssh_url":"git@github.com:rchiossi/mixer-tools.git","clone_url":"https://github.com/rchiossi/mixer-tools.git","svn_url":"https://github.com/rchiossi/mixer-tools","homepage":null,"size":1493,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"d29cc443409c9562cb3ef92a8b7b36c1fe3e1bbf","user":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"node_id":"MDEwOlJlcG9zaXRvcnk1NDQzOTQ3NA==","name":"mixer-tools","full_name":"clearlinux/mixer-tools","owner":{"login":"clearlinux","id":12545216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTQ1MjE2","avatar_url":"https://avatars2.githubusercontent.com/u/12545216?v=4","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2018-08-30T20:02:56Z","pushed_at":"2018-08-31T00:42:58Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":1412,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":39,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/417"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/417"},"issue":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/417"},"comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/417/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/417/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/417/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/219aa634ec28d26174e82b76d835b1cbe1f3921d"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"matthewrsj"}}