{"action":"created","issue":{"url":"https://api.github.com/repos/kata-containers/agent/issues/333","repository_url":"https://api.github.com/repos/kata-containers/agent","labels_url":"https://api.github.com/repos/kata-containers/agent/issues/333/labels{/name}","comments_url":"https://api.github.com/repos/kata-containers/agent/issues/333/comments","events_url":"https://api.github.com/repos/kata-containers/agent/issues/333/events","html_url":"https://github.com/kata-containers/agent/issues/333","id":353825672,"node_id":"MDU6SXNzdWUzNTM4MjU2NzI=","number":333,"title":"wait a bit in RemoveContainer","user":{"login":"bergwolf","id":88972,"node_id":"MDQ6VXNlcjg4OTcy","avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-24T15:17:34Z","updated_at":"2018-08-25T04:10:33Z","closed_at":null,"author_association":"MEMBER","body":"@lifupan hit an issue that if RemoveContainer is called right after SignalProcess(SIGKILL), the container process might be still running and container `Destroy()` will fail."},"comment":{"url":"https://api.github.com/repos/kata-containers/agent/issues/comments/415933523","html_url":"https://github.com/kata-containers/agent/issues/333#issuecomment-415933523","issue_url":"https://api.github.com/repos/kata-containers/agent/issues/333","id":415933523,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTkzMzUyMw==","user":{"login":"bergwolf","id":88972,"node_id":"MDQ6VXNlcjg4OTcy","avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"created_at":"2018-08-25T04:10:33Z","updated_at":"2018-08-25T04:10:33Z","author_association":"MEMBER","body":"@sboeuf The problem is kata runtime `container.stop()`. It kills the container process and then removes the container w/o waiting. OTOH, we cannot wait there either because otherwise if there is another waiter, it cannot get the container exit status.\r\n\r\n@lifupan I agree that we should move container cleanup codes to `container.delete()` but it won't help solving this issue, unless you require `container.wait()` being always called before `container.delete()` in which case `container.stop()` become meaningless since it does the same thing as `container.kill()`. And container state machine becomes complicated because `wait()` is required to get a container to transit to STOPPED state."}}
{"actor":{"display_login":"bergwolf"}}