{"action":"created","issue":{"url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/98","repository_url":"https://api.github.com/repos/conveyal/gtfs-lib","labels_url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/98/labels{/name}","comments_url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/98/comments","events_url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/98/events","html_url":"https://github.com/conveyal/gtfs-lib/pull/98","id":295733941,"number":98,"title":"Mapdb feed to sql","user":{"login":"landonreed","id":2370911,"avatar_url":"https://avatars2.githubusercontent.com/u/2370911?v=4","gravatar_id":"","url":"https://api.github.com/users/landonreed","html_url":"https://github.com/landonreed","followers_url":"https://api.github.com/users/landonreed/followers","following_url":"https://api.github.com/users/landonreed/following{/other_user}","gists_url":"https://api.github.com/users/landonreed/gists{/gist_id}","starred_url":"https://api.github.com/users/landonreed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/landonreed/subscriptions","organizations_url":"https://api.github.com/users/landonreed/orgs","repos_url":"https://api.github.com/users/landonreed/repos","events_url":"https://api.github.com/users/landonreed/events{/privacy}","received_events_url":"https://api.github.com/users/landonreed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-09T02:24:13Z","updated_at":"2018-02-09T02:25:44Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/conveyal/gtfs-lib/pulls/98","html_url":"https://github.com/conveyal/gtfs-lib/pull/98","diff_url":"https://github.com/conveyal/gtfs-lib/pull/98.diff","patch_url":"https://github.com/conveyal/gtfs-lib/pull/98.patch"},"body":"This PR adds a converter from the MapDB-based GTFSFeed to SQL database.  Among the changes are:\r\n\r\n- Adds `ScheduleException` entity type (for the GTFS editor).\r\n- Adds `setParameters` abstract method for `Entity` and its subtypes that sets the parameters on a SQL prepared statement.\r\n- Fixes SQL insertion of ints with the `Entity.INT_MISSING` value.\r\n- Adds `autoCommit` flag to `JdbcTableWriter` to allow for multiple writes in a single transaction."},"comment":{"url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/comments/364315919","html_url":"https://github.com/conveyal/gtfs-lib/pull/98#issuecomment-364315919","issue_url":"https://api.github.com/repos/conveyal/gtfs-lib/issues/98","id":364315919,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-02-09T02:25:44Z","updated_at":"2018-02-09T02:25:44Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/conveyal/gtfs-lib/pull/98?src=pr&el=h1) Report\n> Merging [#98](https://codecov.io/gh/conveyal/gtfs-lib/pull/98?src=pr&el=desc) into [dev](https://codecov.io/gh/conveyal/gtfs-lib/commit/de9fad78b9763c0c2afad2ef376558d9a55c5f83?src=pr&el=desc) will **decrease** coverage by `2.49%`.\n> The diff coverage is `8.18%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/graphs/tree.svg?width=650&src=pr&token=zpfAvEwGmQ&height=150)](https://codecov.io/gh/conveyal/gtfs-lib/pull/98?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff             @@\n##                dev      #98     +/-   ##\n===========================================\n- Coverage     35.52%   33.02%   -2.5%     \n- Complexity      389      394      +5     \n===========================================\n  Files           137      141      +4     \n  Lines          5723     6247    +524     \n  Branches        613      685     +72     \n===========================================\n+ Hits           2033     2063     +30     \n- Misses         3480     3970    +490     \n- Partials        210      214      +4\n```\n\n\n| [Impacted Files](https://codecov.io/gh/conveyal/gtfs-lib/pull/98?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [.../com/conveyal/gtfs/validator/ValidationResult.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy92YWxpZGF0b3IvVmFsaWRhdGlvblJlc3VsdC5qYXZh) | `85.71% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |\n| [src/main/java/com/conveyal/gtfs/loader/Field.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy9sb2FkZXIvRmllbGQuamF2YQ==) | `68.18% <ø> (ø)` | `11 <0> (ø)` | :arrow_down: |\n| [.../com/conveyal/gtfs/validator/ServiceValidator.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy92YWxpZGF0b3IvU2VydmljZVZhbGlkYXRvci5qYXZh) | `54.34% <ø> (ø)` | `17 <0> (ø)` | :arrow_down: |\n| [...main/java/com/conveyal/gtfs/model/PatternStop.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy9tb2RlbC9QYXR0ZXJuU3RvcC5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...ava/com/conveyal/gtfs/loader/JdbcGtfsExporter.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy9sb2FkZXIvSmRiY0d0ZnNFeHBvcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [...java/com/conveyal/gtfs/loader/JdbcTableWriter.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy9sb2FkZXIvSmRiY1RhYmxlV3JpdGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |\n| [.../main/java/com/conveyal/gtfs/model/ShapePoint.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy9tb2RlbC9TaGFwZVBvaW50LmphdmE=) | `70.45% <0%> (-18.12%)` | `1 <0> (ø)` | |\n| [...conveyal/gtfs/validator/NewTripTimesValidator.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy92YWxpZGF0b3IvTmV3VHJpcFRpbWVzVmFsaWRhdG9yLmphdmE=) | `60% <0%> (-1.43%)` | `18 <0> (ø)` | |\n| [.../main/java/com/conveyal/gtfs/loader/DateField.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy9sb2FkZXIvRGF0ZUZpZWxkLmphdmE=) | `37.5% <0%> (-12.5%)` | `5 <0> (ø)` | |\n| [src/main/java/com/conveyal/gtfs/model/Trip.java](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9jb20vY29udmV5YWwvZ3Rmcy9tb2RlbC9UcmlwLmphdmE=) | `70.37% <0%> (-24.63%)` | `1 <0> (ø)` | |\n| ... and [30 more](https://codecov.io/gh/conveyal/gtfs-lib/pull/98/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/conveyal/gtfs-lib/pull/98?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/conveyal/gtfs-lib/pull/98?src=pr&el=footer). Last update [de9fad7...583e83e](https://codecov.io/gh/conveyal/gtfs-lib/pull/98?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}