{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/comments/235882789","pull_request_review_id":177852349,"id":235882789,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTg4Mjc4OQ==","diff_hunk":"@@ -473,10 +480,8 @@ struct default_validator\n     using value_type = option_value_type;\n \n     //!\\brief Value cmp always passes validation.\n-    bool operator()(option_value_type const & /*cmp*/) const noexcept\n-    {\n-        return true;\n-    }\n+    void operator()(option_value_type const & /*cmp*/) const noexcept\n+    {}","path":"include/seqan3/argument_parser/validators.hpp","position":82,"original_position":82,"commit_id":"061ccaa079a5f624b271c25e59e500afd829a629","original_commit_id":"061ccaa079a5f624b271c25e59e500afd829a629","user":{"login":"rrahn","id":1529364,"node_id":"MDQ6VXNlcjE1MjkzNjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"body":"Is the comment above still acurate with the change?","created_at":"2018-11-23T09:31:10Z","updated_at":"2018-11-23T09:45:56Z","html_url":"https://github.com/seqan/seqan3/pull/537#discussion_r235882789","pull_request_url":"https://api.github.com/repos/seqan/seqan3/pulls/537","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments/235882789"},"html":{"href":"https://github.com/seqan/seqan3/pull/537#discussion_r235882789"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/537"}}},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan3/pulls/537","id":227926469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTI2NDY5","html_url":"https://github.com/seqan/seqan3/pull/537","diff_url":"https://github.com/seqan/seqan3/pull/537.diff","patch_url":"https://github.com/seqan/seqan3/pull/537.patch","issue_url":"https://api.github.com/repos/seqan/seqan3/issues/537","number":537,"state":"open","locked":false,"title":"[FEATURE] Enable chaining of validators.","user":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"body":"You can now do this\r\n\r\n```\r\nparser.add_option(..., validator1 | validator2);\r\n```","created_at":"2018-11-02T12:47:42Z","updated_at":"2018-11-23T09:45:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5c1de17c709a3a35ef3bba24b970792da044cee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"h-2","id":2996863,"node_id":"MDQ6VXNlcjI5OTY4NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":568314043,"node_id":"MDU6TGFiZWw1NjgzMTQwNDM=","url":"https://api.github.com/repos/seqan/seqan3/labels/feature/proposal","name":"feature/proposal","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan3/pulls/537/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan3/pulls/537/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan3/issues/537/comments","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/061ccaa079a5f624b271c25e59e500afd829a629","head":{"label":"smehringer:fix_me","ref":"fix_me","sha":"061ccaa079a5f624b271c25e59e500afd829a629","user":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"repo":{"id":85708703,"node_id":"MDEwOlJlcG9zaXRvcnk4NTcwODcwMw==","name":"seqan3","full_name":"smehringer/seqan3","private":false,"owner":{"login":"smehringer","id":7955878,"node_id":"MDQ6VXNlcjc5NTU4Nzg=","avatar_url":"https://avatars3.githubusercontent.com/u/7955878?v=4","gravatar_id":"","url":"https://api.github.com/users/smehringer","html_url":"https://github.com/smehringer","followers_url":"https://api.github.com/users/smehringer/followers","following_url":"https://api.github.com/users/smehringer/following{/other_user}","gists_url":"https://api.github.com/users/smehringer/gists{/gist_id}","starred_url":"https://api.github.com/users/smehringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smehringer/subscriptions","organizations_url":"https://api.github.com/users/smehringer/orgs","repos_url":"https://api.github.com/users/smehringer/repos","events_url":"https://api.github.com/users/smehringer/events{/privacy}","received_events_url":"https://api.github.com/users/smehringer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/smehringer/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":true,"url":"https://api.github.com/repos/smehringer/seqan3","forks_url":"https://api.github.com/repos/smehringer/seqan3/forks","keys_url":"https://api.github.com/repos/smehringer/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smehringer/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smehringer/seqan3/teams","hooks_url":"https://api.github.com/repos/smehringer/seqan3/hooks","issue_events_url":"https://api.github.com/repos/smehringer/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/smehringer/seqan3/events","assignees_url":"https://api.github.com/repos/smehringer/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/smehringer/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/smehringer/seqan3/tags","blobs_url":"https://api.github.com/repos/smehringer/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smehringer/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smehringer/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/smehringer/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smehringer/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/smehringer/seqan3/languages","stargazers_url":"https://api.github.com/repos/smehringer/seqan3/stargazers","contributors_url":"https://api.github.com/repos/smehringer/seqan3/contributors","subscribers_url":"https://api.github.com/repos/smehringer/seqan3/subscribers","subscription_url":"https://api.github.com/repos/smehringer/seqan3/subscription","commits_url":"https://api.github.com/repos/smehringer/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/smehringer/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/smehringer/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/smehringer/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/smehringer/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/smehringer/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smehringer/seqan3/merges","archive_url":"https://api.github.com/repos/smehringer/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smehringer/seqan3/downloads","issues_url":"https://api.github.com/repos/smehringer/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/smehringer/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/smehringer/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/smehringer/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smehringer/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/smehringer/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/smehringer/seqan3/deployments","created_at":"2017-03-21T14:00:28Z","updated_at":"2018-10-28T13:02:52Z","pushed_at":"2018-11-22T13:13:33Z","git_url":"git://github.com/smehringer/seqan3.git","ssh_url":"git@github.com:smehringer/seqan3.git","clone_url":"https://github.com/smehringer/seqan3.git","svn_url":"https://github.com/smehringer/seqan3","homepage":"http://www.seqan.de","size":2020,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"seqan:master","ref":"master","sha":"c14ce2f2f50c4413cad693edfbca4885e4baa782","user":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":55410078,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQxMDA3OA==","name":"seqan3","full_name":"seqan/seqan3","private":false,"owner":{"login":"seqan","id":1752144,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NTIxNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/seqan/seqan3","description":"The modern C++ library for sequence analysis. Contains version 3 of the library and API docs.","fork":false,"url":"https://api.github.com/repos/seqan/seqan3","forks_url":"https://api.github.com/repos/seqan/seqan3/forks","keys_url":"https://api.github.com/repos/seqan/seqan3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan3/teams","hooks_url":"https://api.github.com/repos/seqan/seqan3/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan3/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan3/events","assignees_url":"https://api.github.com/repos/seqan/seqan3/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan3/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan3/tags","blobs_url":"https://api.github.com/repos/seqan/seqan3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan3/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan3/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan3/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan3/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan3/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan3/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan3/subscription","commits_url":"https://api.github.com/repos/seqan/seqan3/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan3/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan3/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan3/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan3/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan3/merges","archive_url":"https://api.github.com/repos/seqan/seqan3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan3/downloads","issues_url":"https://api.github.com/repos/seqan/seqan3/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan3/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan3/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan3/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan3/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan3/deployments","created_at":"2016-04-04T12:39:15Z","updated_at":"2018-11-22T21:54:57Z","pushed_at":"2018-11-23T09:43:46Z","git_url":"git://github.com/seqan/seqan3.git","ssh_url":"git@github.com:seqan/seqan3.git","clone_url":"https://github.com/seqan/seqan3.git","svn_url":"https://github.com/seqan/seqan3","homepage":"http://www.seqan.de","size":2086,"stargazers_count":39,"watchers_count":39,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":140,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":26,"open_issues":140,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/537"},"html":{"href":"https://github.com/seqan/seqan3/pull/537"},"issue":{"href":"https://api.github.com/repos/seqan/seqan3/issues/537"},"comments":{"href":"https://api.github.com/repos/seqan/seqan3/issues/537/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/537/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan3/pulls/537/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan3/statuses/061ccaa079a5f624b271c25e59e500afd829a629"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rrahn"}}