{"action":"created","comment":{"url":"https://api.github.com/repos/apollographql/apollo-server/pulls/comments/184482722","pull_request_review_id":115314946,"id":184482722,"diff_hunk":"@@ -0,0 +1,99 @@\n+import { GraphQLSchema } from 'graphql';\n+import { CorsOptions } from 'cors';\n+import { SchemaDirectiveVisitor, IResolvers } from 'graphql-tools';\n+import { ConnectionContext } from 'subscriptions-transport-ws';\n+import { GraphQLOptions } from 'apollo-server-core';\n+export { CacheControlExtensionOptions } from 'apollo-cache-control';\n+\n+export type Context<T = any> = T;\n+export type ContextFunction<T = any> = (\n+  context: Context<T>,\n+) => Promise<Context<T>>;\n+\n+export interface SubscriptionServerOptions {\n+  path?: string;\n+  onConnect?: Function;\n+  onDisconnect?: Function;\n+  keepAlive?: number;\n+}\n+\n+export interface Config<Server, ContextShape = any, Cors = CorsOptions>\n+  extends Pick<\n+      GraphQLOptions<Context<ContextShape>>,\n+      | 'formatError'\n+      | 'debug'\n+      | 'rootValue'\n+      | 'logFunction'\n+      | 'formatParams'\n+      | 'validationRules'\n+      | 'formatResponse'\n+      | 'fieldResolver'\n+      | 'debug'\n+      | 'cacheControl'\n+      | 'tracing'\n+    > {\n+  app?: Server;\n+  typeDefs?: string | [string];\n+  resolvers?: IResolvers;\n+  schema?: GraphQLSchema;\n+  schemaDirectives: Record<string, typeof SchemaDirectiveVisitor>;\n+  context?: Context<ContextShape> | ContextFunction<ContextShape>;\n+  cors?: Cors;\n+  subscriptions?: SubscriptionServerOptions | string | false;\n+  engineInRequestPath?: boolean;\n+  engine?: boolean | Object;\n+  enableIntrospection?: boolean;","path":"packages/apollo-server/src/utils/types.ts","position":45,"original_position":45,"commit_id":"33ea0c92a1e4e76c8915ff08806f15dae391e1f0","original_commit_id":"33ea0c92a1e4e76c8915ff08806f15dae391e1f0","user":{"login":"abernix","id":841294,"avatar_url":"https://avatars0.githubusercontent.com/u/841294?v=4","gravatar_id":"","url":"https://api.github.com/users/abernix","html_url":"https://github.com/abernix","followers_url":"https://api.github.com/users/abernix/followers","following_url":"https://api.github.com/users/abernix/following{/other_user}","gists_url":"https://api.github.com/users/abernix/gists{/gist_id}","starred_url":"https://api.github.com/users/abernix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abernix/subscriptions","organizations_url":"https://api.github.com/users/abernix/orgs","repos_url":"https://api.github.com/users/abernix/repos","events_url":"https://api.github.com/users/abernix/events{/privacy}","received_events_url":"https://api.github.com/users/abernix/received_events","type":"User","site_admin":false},"body":"Would `introspection` be unreasonable here?  Having `engine` accept a boolean, but using the `enable` prefix for this seems slightly incongruent (though I realize they can be different).  I wonder if a future pattern could introduce passing an `Object` for the introspection, and removing `enable` could help support that with less friction.","created_at":"2018-04-26T18:08:34Z","updated_at":"2018-04-26T18:17:23Z","html_url":"https://github.com/apollographql/apollo-server/pull/979#discussion_r184482722","pull_request_url":"https://api.github.com/repos/apollographql/apollo-server/pulls/979","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/comments/184482722"},"html":{"href":"https://github.com/apollographql/apollo-server/pull/979#discussion_r184482722"},"pull_request":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/979"}}},"pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-server/pulls/979","id":183469859,"html_url":"https://github.com/apollographql/apollo-server/pull/979","diff_url":"https://github.com/apollographql/apollo-server/pull/979.diff","patch_url":"https://github.com/apollographql/apollo-server/pull/979.patch","issue_url":"https://api.github.com/repos/apollographql/apollo-server/issues/979","number":979,"state":"open","locked":false,"title":"Apollo Server 2.0","user":{"login":"jbaxleyiii","id":4967600,"avatar_url":"https://avatars2.githubusercontent.com/u/4967600?v=4","gravatar_id":"","url":"https://api.github.com/users/jbaxleyiii","html_url":"https://github.com/jbaxleyiii","followers_url":"https://api.github.com/users/jbaxleyiii/followers","following_url":"https://api.github.com/users/jbaxleyiii/following{/other_user}","gists_url":"https://api.github.com/users/jbaxleyiii/gists{/gist_id}","starred_url":"https://api.github.com/users/jbaxleyiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbaxleyiii/subscriptions","organizations_url":"https://api.github.com/users/jbaxleyiii/orgs","repos_url":"https://api.github.com/users/jbaxleyiii/repos","events_url":"https://api.github.com/users/jbaxleyiii/events{/privacy}","received_events_url":"https://api.github.com/users/jbaxleyiii/received_events","type":"User","site_admin":false},"body":"This PR intends to land the revival of the `apollo-server` package as a new entry point for building GraphQL servers. Unlike `apollo-server-framework`, which provides http related utilities for working with a prexisting schema, `apollo-server` seeks to take an opinionated approach to building GraphQL services.\r\n\r\nIt provides the tooling from graphql-tools and graphql-subscriptions, includes custom schema and service runtime additions (initially production validation rules for turning off introspection and more guidance around error handling).\r\n\r\nThis is the kickoff of a new generation of work on building production ready GraphQL services ♥️ ","created_at":"2018-04-23T15:20:25Z","updated_at":"2018-04-26T18:17:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b11b5f2bed3c45dea94f462552af60f0b5f643a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apollographql/apollo-server/pulls/979/commits","review_comments_url":"https://api.github.com/repos/apollographql/apollo-server/pulls/979/comments","review_comment_url":"https://api.github.com/repos/apollographql/apollo-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/issues/979/comments","statuses_url":"https://api.github.com/repos/apollographql/apollo-server/statuses/33ea0c92a1e4e76c8915ff08806f15dae391e1f0","head":{"label":"apollographql:new-apollo-server","ref":"new-apollo-server","sha":"33ea0c92a1e4e76c8915ff08806f15dae391e1f0","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":56760633,"name":"apollo-server","full_name":"apollographql/apollo-server","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-server","description":":earth_africa: GraphQL server for Express, Connect, Hapi, Koa and more","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-server","forks_url":"https://api.github.com/repos/apollographql/apollo-server/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-server/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-server/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-server/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-server/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-server/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-server/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-server/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-server/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-server/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-server/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-server/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-server/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-server/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-server/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-server/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-server/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-server/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-server/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-server/deployments","created_at":"2016-04-21T09:26:01Z","updated_at":"2018-04-26T17:20:45Z","pushed_at":"2018-04-26T16:08:30Z","git_url":"git://github.com/apollographql/apollo-server.git","ssh_url":"git@github.com:apollographql/apollo-server.git","clone_url":"https://github.com/apollographql/apollo-server.git","svn_url":"https://github.com/apollographql/apollo-server","homepage":"https://www.apollographql.com/docs/apollo-server/","size":1884,"stargazers_count":3729,"watchers_count":3729,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":384,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":384,"open_issues":113,"watchers":3729,"default_branch":"master"}},"base":{"label":"apollographql:version-2","ref":"version-2","sha":"c43d9bda0452d8600a0e56863a73e161b9566449","user":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"repo":{"id":56760633,"name":"apollo-server","full_name":"apollographql/apollo-server","owner":{"login":"apollographql","id":17189275,"avatar_url":"https://avatars0.githubusercontent.com/u/17189275?v=4","gravatar_id":"","url":"https://api.github.com/users/apollographql","html_url":"https://github.com/apollographql","followers_url":"https://api.github.com/users/apollographql/followers","following_url":"https://api.github.com/users/apollographql/following{/other_user}","gists_url":"https://api.github.com/users/apollographql/gists{/gist_id}","starred_url":"https://api.github.com/users/apollographql/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apollographql/subscriptions","organizations_url":"https://api.github.com/users/apollographql/orgs","repos_url":"https://api.github.com/users/apollographql/repos","events_url":"https://api.github.com/users/apollographql/events{/privacy}","received_events_url":"https://api.github.com/users/apollographql/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apollographql/apollo-server","description":":earth_africa: GraphQL server for Express, Connect, Hapi, Koa and more","fork":false,"url":"https://api.github.com/repos/apollographql/apollo-server","forks_url":"https://api.github.com/repos/apollographql/apollo-server/forks","keys_url":"https://api.github.com/repos/apollographql/apollo-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apollographql/apollo-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apollographql/apollo-server/teams","hooks_url":"https://api.github.com/repos/apollographql/apollo-server/hooks","issue_events_url":"https://api.github.com/repos/apollographql/apollo-server/issues/events{/number}","events_url":"https://api.github.com/repos/apollographql/apollo-server/events","assignees_url":"https://api.github.com/repos/apollographql/apollo-server/assignees{/user}","branches_url":"https://api.github.com/repos/apollographql/apollo-server/branches{/branch}","tags_url":"https://api.github.com/repos/apollographql/apollo-server/tags","blobs_url":"https://api.github.com/repos/apollographql/apollo-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apollographql/apollo-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apollographql/apollo-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apollographql/apollo-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apollographql/apollo-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apollographql/apollo-server/languages","stargazers_url":"https://api.github.com/repos/apollographql/apollo-server/stargazers","contributors_url":"https://api.github.com/repos/apollographql/apollo-server/contributors","subscribers_url":"https://api.github.com/repos/apollographql/apollo-server/subscribers","subscription_url":"https://api.github.com/repos/apollographql/apollo-server/subscription","commits_url":"https://api.github.com/repos/apollographql/apollo-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apollographql/apollo-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apollographql/apollo-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apollographql/apollo-server/contents/{+path}","compare_url":"https://api.github.com/repos/apollographql/apollo-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apollographql/apollo-server/merges","archive_url":"https://api.github.com/repos/apollographql/apollo-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apollographql/apollo-server/downloads","issues_url":"https://api.github.com/repos/apollographql/apollo-server/issues{/number}","pulls_url":"https://api.github.com/repos/apollographql/apollo-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apollographql/apollo-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apollographql/apollo-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apollographql/apollo-server/labels{/name}","releases_url":"https://api.github.com/repos/apollographql/apollo-server/releases{/id}","deployments_url":"https://api.github.com/repos/apollographql/apollo-server/deployments","created_at":"2016-04-21T09:26:01Z","updated_at":"2018-04-26T17:20:45Z","pushed_at":"2018-04-26T16:08:30Z","git_url":"git://github.com/apollographql/apollo-server.git","ssh_url":"git@github.com:apollographql/apollo-server.git","clone_url":"https://github.com/apollographql/apollo-server.git","svn_url":"https://github.com/apollographql/apollo-server","homepage":"https://www.apollographql.com/docs/apollo-server/","size":1884,"stargazers_count":3729,"watchers_count":3729,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":384,"mirror_url":null,"archived":false,"open_issues_count":113,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":384,"open_issues":113,"watchers":3729,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/979"},"html":{"href":"https://github.com/apollographql/apollo-server/pull/979"},"issue":{"href":"https://api.github.com/repos/apollographql/apollo-server/issues/979"},"comments":{"href":"https://api.github.com/repos/apollographql/apollo-server/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apollographql/apollo-server/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/apollographql/apollo-server/statuses/33ea0c92a1e4e76c8915ff08806f15dae391e1f0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"abernix"}}