{"action":"created","issue":{"url":"https://api.github.com/repos/Ada-C10/ride-share/issues/10","repository_url":"https://api.github.com/repos/Ada-C10/ride-share","labels_url":"https://api.github.com/repos/Ada-C10/ride-share/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/Ada-C10/ride-share/issues/10/comments","events_url":"https://api.github.com/repos/Ada-C10/ride-share/issues/10/events","html_url":"https://github.com/Ada-C10/ride-share/pull/10","id":349842243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODM5Mzkz","number":10,"title":"Alice's Ride Share","user":{"login":"alicehsiao","id":9450062,"node_id":"MDQ6VXNlcjk0NTAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/9450062?v=4","gravatar_id":"","url":"https://api.github.com/users/alicehsiao","html_url":"https://github.com/alicehsiao","followers_url":"https://api.github.com/users/alicehsiao/followers","following_url":"https://api.github.com/users/alicehsiao/following{/other_user}","gists_url":"https://api.github.com/users/alicehsiao/gists{/gist_id}","starred_url":"https://api.github.com/users/alicehsiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicehsiao/subscriptions","organizations_url":"https://api.github.com/users/alicehsiao/orgs","repos_url":"https://api.github.com/users/alicehsiao/repos","events_url":"https://api.github.com/users/alicehsiao/events{/privacy}","received_events_url":"https://api.github.com/users/alicehsiao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-12T20:40:57Z","updated_at":"2018-08-16T16:42:57Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Ada-C10/ride-share/pulls/10","html_url":"https://github.com/Ada-C10/ride-share/pull/10","diff_url":"https://github.com/Ada-C10/ride-share/pull/10.diff","patch_url":"https://github.com/Ada-C10/ride-share/pull/10.patch"},"body":"# ride share\r\nCongratulations! You're submitting your assignment.\r\n\r\n## Comprehension Questions\r\n\r\n|  Question \t|  Answer \t|\r\n|---\t|---\t|\r\n|  What did your data structure look like at first? Did this structure evolve over time? Why?\t|   I thought a lot about whether or not I wanted to use an array (ordered) or a hash (unordered) to store all of the data, and decided to use an array in case I wanted to access any individual driver. The structure I used did not evolve after I finished building it.\t|\r\n|  What was your strategy for going through the data structure and gathering information?\t|   I used a variety of loops and methods to access information. I used the each method and tried to use some of the other enumerable methods we learned in class on Friday.\t|\r\n|  What was an example of something that was necessary to store in a variable? What was the scope of each of that variables? Why? \t|   I stored objects related to amount of money made and ratings in variables. I initialized these outside of my each loops so that I could access them outside of the loop. All the variables I used are considered local variables and have scope where they are defined. For example, variables created in methods are not accessed anywhere else. |\r\n|  What kinds of iteration did you use? Did you use `.map`? \t|   I did not use map, since I could not figure out where I could have used it/or might have needed it. I mostly wanted to sum items, not return an array or hash with modified data. I did use each, select, group_by, and max_by.\t|\r\n|  Were some calculations easier than others? Why? \t|   Yes, most of the calculations were straightforward. I spent more time on the optional piece in trying to figure out how to sum the costs on same-day rides, and in dealing with instances of ties (multiple days of max profit, multiple high earners, etc.)\t|\r\n"},"comment":{"url":"https://api.github.com/repos/Ada-C10/ride-share/issues/comments/413609924","html_url":"https://github.com/Ada-C10/ride-share/pull/10#issuecomment-413609924","issue_url":"https://api.github.com/repos/Ada-C10/ride-share/issues/10","id":413609924,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzYwOTkyNA==","user":{"login":"dHelmgren","id":5455308,"node_id":"MDQ6VXNlcjU0NTUzMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5455308?v=4","gravatar_id":"","url":"https://api.github.com/users/dHelmgren","html_url":"https://github.com/dHelmgren","followers_url":"https://api.github.com/users/dHelmgren/followers","following_url":"https://api.github.com/users/dHelmgren/following{/other_user}","gists_url":"https://api.github.com/users/dHelmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/dHelmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dHelmgren/subscriptions","organizations_url":"https://api.github.com/users/dHelmgren/orgs","repos_url":"https://api.github.com/users/dHelmgren/repos","events_url":"https://api.github.com/users/dHelmgren/events{/privacy}","received_events_url":"https://api.github.com/users/dHelmgren/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T16:42:57Z","updated_at":"2018-08-16T16:42:57Z","author_association":"NONE","body":"Great work! It was easy to follow along with your code, and I appreciate your use of various enumerator methods. Keep in mind, you need to write code that Future Alice will be able to glance at and explain, so work on naming things clearly (there's room for fun so long as it's Descriptive Fun)."}}
{"actor":{"display_login":"dHelmgren"}}