{"action":"created","issue":{"url":"https://api.github.com/repos/scionproto/scion/issues/1571","repository_url":"https://api.github.com/repos/scionproto/scion","labels_url":"https://api.github.com/repos/scionproto/scion/issues/1571/labels{/name}","comments_url":"https://api.github.com/repos/scionproto/scion/issues/1571/comments","events_url":"https://api.github.com/repos/scionproto/scion/issues/1571/events","html_url":"https://github.com/scionproto/scion/pull/1571","id":326518363,"number":1571,"title":"standardize sciond socket selection process","user":{"login":"jinankjain","id":3854904,"avatar_url":"https://avatars0.githubusercontent.com/u/3854904?v=4","gravatar_id":"","url":"https://api.github.com/users/jinankjain","html_url":"https://github.com/jinankjain","followers_url":"https://api.github.com/users/jinankjain/followers","following_url":"https://api.github.com/users/jinankjain/following{/other_user}","gists_url":"https://api.github.com/users/jinankjain/gists{/gist_id}","starred_url":"https://api.github.com/users/jinankjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinankjain/subscriptions","organizations_url":"https://api.github.com/users/jinankjain/orgs","repos_url":"https://api.github.com/users/jinankjain/repos","events_url":"https://api.github.com/users/jinankjain/events{/privacy}","received_events_url":"https://api.github.com/users/jinankjain/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-25T13:11:49Z","updated_at":"2018-05-28T20:09:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/scionproto/scion/pulls/1571","html_url":"https://github.com/scionproto/scion/pull/1571","diff_url":"https://github.com/scionproto/scion/pull/1571.diff","patch_url":"https://github.com/scionproto/scion/pull/1571.patch"},"body":"In order to obtain sciond socket for a given IA a new API is exposed\r\n\r\n`GetSCIONDPathFromIA` which takes an IA and returns the corresponding\r\nsocket string.\r\n\r\nFixes #1543\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/scionproto/scion/1571)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/scionproto/scion/issues/comments/392596321","html_url":"https://github.com/scionproto/scion/pull/1571#issuecomment-392596321","issue_url":"https://api.github.com/repos/scionproto/scion/issues/1571","id":392596321,"user":{"login":"jinankjain","id":3854904,"avatar_url":"https://avatars0.githubusercontent.com/u/3854904?v=4","gravatar_id":"","url":"https://api.github.com/users/jinankjain","html_url":"https://github.com/jinankjain","followers_url":"https://api.github.com/users/jinankjain/followers","following_url":"https://api.github.com/users/jinankjain/following{/other_user}","gists_url":"https://api.github.com/users/jinankjain/gists{/gist_id}","starred_url":"https://api.github.com/users/jinankjain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinankjain/subscriptions","organizations_url":"https://api.github.com/users/jinankjain/orgs","repos_url":"https://api.github.com/users/jinankjain/repos","events_url":"https://api.github.com/users/jinankjain/events{/privacy}","received_events_url":"https://api.github.com/users/jinankjain/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T20:09:53Z","updated_at":"2018-05-28T20:09:53Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 0 of 8 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.\n\n---\n\n*[go/lib/addr/isdas.go, line 259 at r1](https://reviewable.io/reviews/scionproto/scion/1571#-LDbY-uO8VBWfWigEF9R:-LDcMkDxAFwZyQtPSuYr:b-896fix) ([raw file](https://github.com/scionproto/scion/blob/79fffc4d089348e1f5d9012b9cba8fa6021853bc/go/lib/addr/isdas.go#L259)):*\n<details><summary><i>Previously, shitz wrote…</i></summary><blockquote>\n\nThis doesn't belong here. I propose you add the following method to `go/lib/sciond/sciond.go`:\n```\nfunc GetDefaultSCIONDSocket(ia *addr.IA) string {\n    if ia == nil {\n        return \"/run/shm/sciond/default.sock\"\n    }\n    return fmt.Sprintf(\"/run/shm/sciond/sd%s.sock\", ia.FileFmt(false))\n}\n```\nand then call it accordingly. An equivalent method should be added to `python/lib/app/python/sciond.py`\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/scionproto/scion/1571)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"jinankjain"}}