{"action":"created","comment":{"url":"https://api.github.com/repos/google/nxt-standalone/pulls/comments/197212034","pull_request_review_id":130909149,"id":197212034,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzIxMjAzNA==","diff_hunk":"@@ -49,9 +49,13 @@ class PushConstantTest: public NXTTest {\n                 .SetBindingsType(kAllStages, nxt::BindingType::StorageBuffer, 0, extraBuffer ? 2 : 1)\n                 .GetResult();\n \n-            nxt::PipelineLayout pl = device.CreatePipelineLayoutBuilder()\n-                .SetBindGroupLayout(0, bgl)\n-                .GetResult();\n+            nxt::PipelineLayout pl;","path":"src/tests/end2end/PushConstantTests.cpp","position":7,"original_position":7,"commit_id":"1616b5775f651c57e7e7efd40ba64efd2df731c2","original_commit_id":"1616b5775f651c57e7e7efd40ba64efd2df731c2","user":{"login":"Kangz","id":472810,"node_id":"MDQ6VXNlcjQ3MjgxMA==","avatar_url":"https://avatars3.githubusercontent.com/u/472810?v=4","gravatar_id":"","url":"https://api.github.com/users/Kangz","html_url":"https://github.com/Kangz","followers_url":"https://api.github.com/users/Kangz/followers","following_url":"https://api.github.com/users/Kangz/following{/other_user}","gists_url":"https://api.github.com/users/Kangz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kangz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kangz/subscriptions","organizations_url":"https://api.github.com/users/Kangz/orgs","repos_url":"https://api.github.com/users/Kangz/repos","events_url":"https://api.github.com/users/Kangz/events{/privacy}","received_events_url":"https://api.github.com/users/Kangz/received_events","type":"User","site_admin":false},"body":"I think this can use MakeBasicPipelineLayout too.","created_at":"2018-06-21T17:15:22Z","updated_at":"2018-06-21T17:24:30Z","html_url":"https://github.com/google/nxt-standalone/pull/206#discussion_r197212034","pull_request_url":"https://api.github.com/repos/google/nxt-standalone/pulls/206","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/comments/197212034"},"html":{"href":"https://github.com/google/nxt-standalone/pull/206#discussion_r197212034"},"pull_request":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/206"}}},"pull_request":{"url":"https://api.github.com/repos/google/nxt-standalone/pulls/206","id":196315317,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzE1MzE3","html_url":"https://github.com/google/nxt-standalone/pull/206","diff_url":"https://github.com/google/nxt-standalone/pull/206.diff","patch_url":"https://github.com/google/nxt-standalone/pull/206.patch","issue_url":"https://api.github.com/repos/google/nxt-standalone/issues/206","number":206,"state":"open","locked":false,"title":"Use a descriptor for PipelineLayout","user":{"login":"kainino0x","id":606355,"node_id":"MDQ6VXNlcjYwNjM1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/606355?v=4","gravatar_id":"","url":"https://api.github.com/users/kainino0x","html_url":"https://github.com/kainino0x","followers_url":"https://api.github.com/users/kainino0x/followers","following_url":"https://api.github.com/users/kainino0x/following{/other_user}","gists_url":"https://api.github.com/users/kainino0x/gists{/gist_id}","starred_url":"https://api.github.com/users/kainino0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kainino0x/subscriptions","organizations_url":"https://api.github.com/users/kainino0x/orgs","repos_url":"https://api.github.com/users/kainino0x/repos","events_url":"https://api.github.com/users/kainino0x/events{/privacy}","received_events_url":"https://api.github.com/users/kainino0x/received_events","type":"User","site_admin":false},"body":"Adds support for structures inside descriptors.","created_at":"2018-06-21T01:45:09Z","updated_at":"2018-06-21T17:24:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54525a2a12ac225f40af8842905a6c689e48c69e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/nxt-standalone/pulls/206/commits","review_comments_url":"https://api.github.com/repos/google/nxt-standalone/pulls/206/comments","review_comment_url":"https://api.github.com/repos/google/nxt-standalone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/nxt-standalone/issues/206/comments","statuses_url":"https://api.github.com/repos/google/nxt-standalone/statuses/1616b5775f651c57e7e7efd40ba64efd2df731c2","head":{"label":"kainino0x:desc-pipelinelayout","ref":"desc-pipelinelayout","sha":"1616b5775f651c57e7e7efd40ba64efd2df731c2","user":{"login":"kainino0x","id":606355,"node_id":"MDQ6VXNlcjYwNjM1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/606355?v=4","gravatar_id":"","url":"https://api.github.com/users/kainino0x","html_url":"https://github.com/kainino0x","followers_url":"https://api.github.com/users/kainino0x/followers","following_url":"https://api.github.com/users/kainino0x/following{/other_user}","gists_url":"https://api.github.com/users/kainino0x/gists{/gist_id}","starred_url":"https://api.github.com/users/kainino0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kainino0x/subscriptions","organizations_url":"https://api.github.com/users/kainino0x/orgs","repos_url":"https://api.github.com/users/kainino0x/repos","events_url":"https://api.github.com/users/kainino0x/events{/privacy}","received_events_url":"https://api.github.com/users/kainino0x/received_events","type":"User","site_admin":false},"repo":{"id":88913892,"node_id":"MDEwOlJlcG9zaXRvcnk4ODkxMzg5Mg==","name":"nxt-standalone","full_name":"kainino0x/nxt-standalone","owner":{"login":"kainino0x","id":606355,"node_id":"MDQ6VXNlcjYwNjM1NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/606355?v=4","gravatar_id":"","url":"https://api.github.com/users/kainino0x","html_url":"https://github.com/kainino0x","followers_url":"https://api.github.com/users/kainino0x/followers","following_url":"https://api.github.com/users/kainino0x/following{/other_user}","gists_url":"https://api.github.com/users/kainino0x/gists{/gist_id}","starred_url":"https://api.github.com/users/kainino0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kainino0x/subscriptions","organizations_url":"https://api.github.com/users/kainino0x/orgs","repos_url":"https://api.github.com/users/kainino0x/repos","events_url":"https://api.github.com/users/kainino0x/events{/privacy}","received_events_url":"https://api.github.com/users/kainino0x/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kainino0x/nxt-standalone","description":"ANGLE-like library for Chromium's next-generation Web graphics API prototype.","fork":true,"url":"https://api.github.com/repos/kainino0x/nxt-standalone","forks_url":"https://api.github.com/repos/kainino0x/nxt-standalone/forks","keys_url":"https://api.github.com/repos/kainino0x/nxt-standalone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kainino0x/nxt-standalone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kainino0x/nxt-standalone/teams","hooks_url":"https://api.github.com/repos/kainino0x/nxt-standalone/hooks","issue_events_url":"https://api.github.com/repos/kainino0x/nxt-standalone/issues/events{/number}","events_url":"https://api.github.com/repos/kainino0x/nxt-standalone/events","assignees_url":"https://api.github.com/repos/kainino0x/nxt-standalone/assignees{/user}","branches_url":"https://api.github.com/repos/kainino0x/nxt-standalone/branches{/branch}","tags_url":"https://api.github.com/repos/kainino0x/nxt-standalone/tags","blobs_url":"https://api.github.com/repos/kainino0x/nxt-standalone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kainino0x/nxt-standalone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kainino0x/nxt-standalone/git/refs{/sha}","trees_url":"https://api.github.com/repos/kainino0x/nxt-standalone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kainino0x/nxt-standalone/statuses/{sha}","languages_url":"https://api.github.com/repos/kainino0x/nxt-standalone/languages","stargazers_url":"https://api.github.com/repos/kainino0x/nxt-standalone/stargazers","contributors_url":"https://api.github.com/repos/kainino0x/nxt-standalone/contributors","subscribers_url":"https://api.github.com/repos/kainino0x/nxt-standalone/subscribers","subscription_url":"https://api.github.com/repos/kainino0x/nxt-standalone/subscription","commits_url":"https://api.github.com/repos/kainino0x/nxt-standalone/commits{/sha}","git_commits_url":"https://api.github.com/repos/kainino0x/nxt-standalone/git/commits{/sha}","comments_url":"https://api.github.com/repos/kainino0x/nxt-standalone/comments{/number}","issue_comment_url":"https://api.github.com/repos/kainino0x/nxt-standalone/issues/comments{/number}","contents_url":"https://api.github.com/repos/kainino0x/nxt-standalone/contents/{+path}","compare_url":"https://api.github.com/repos/kainino0x/nxt-standalone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kainino0x/nxt-standalone/merges","archive_url":"https://api.github.com/repos/kainino0x/nxt-standalone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kainino0x/nxt-standalone/downloads","issues_url":"https://api.github.com/repos/kainino0x/nxt-standalone/issues{/number}","pulls_url":"https://api.github.com/repos/kainino0x/nxt-standalone/pulls{/number}","milestones_url":"https://api.github.com/repos/kainino0x/nxt-standalone/milestones{/number}","notifications_url":"https://api.github.com/repos/kainino0x/nxt-standalone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kainino0x/nxt-standalone/labels{/name}","releases_url":"https://api.github.com/repos/kainino0x/nxt-standalone/releases{/id}","deployments_url":"https://api.github.com/repos/kainino0x/nxt-standalone/deployments","created_at":"2017-04-20T21:56:02Z","updated_at":"2017-04-20T21:56:04Z","pushed_at":"2018-06-21T01:54:26Z","git_url":"git://github.com/kainino0x/nxt-standalone.git","ssh_url":"git@github.com:kainino0x/nxt-standalone.git","clone_url":"https://github.com/kainino0x/nxt-standalone.git","svn_url":"https://github.com/kainino0x/nxt-standalone","homepage":"","size":1946,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"a2f9277dac29b5a6b2b3915493bd24f7cff28eb9","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":88893060,"node_id":"MDEwOlJlcG9zaXRvcnk4ODg5MzA2MA==","name":"nxt-standalone","full_name":"google/nxt-standalone","owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/nxt-standalone","description":"ANGLE-like library for Chromium's next-generation Web graphics API prototype.","fork":false,"url":"https://api.github.com/repos/google/nxt-standalone","forks_url":"https://api.github.com/repos/google/nxt-standalone/forks","keys_url":"https://api.github.com/repos/google/nxt-standalone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/nxt-standalone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/nxt-standalone/teams","hooks_url":"https://api.github.com/repos/google/nxt-standalone/hooks","issue_events_url":"https://api.github.com/repos/google/nxt-standalone/issues/events{/number}","events_url":"https://api.github.com/repos/google/nxt-standalone/events","assignees_url":"https://api.github.com/repos/google/nxt-standalone/assignees{/user}","branches_url":"https://api.github.com/repos/google/nxt-standalone/branches{/branch}","tags_url":"https://api.github.com/repos/google/nxt-standalone/tags","blobs_url":"https://api.github.com/repos/google/nxt-standalone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/nxt-standalone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/nxt-standalone/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/nxt-standalone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/nxt-standalone/statuses/{sha}","languages_url":"https://api.github.com/repos/google/nxt-standalone/languages","stargazers_url":"https://api.github.com/repos/google/nxt-standalone/stargazers","contributors_url":"https://api.github.com/repos/google/nxt-standalone/contributors","subscribers_url":"https://api.github.com/repos/google/nxt-standalone/subscribers","subscription_url":"https://api.github.com/repos/google/nxt-standalone/subscription","commits_url":"https://api.github.com/repos/google/nxt-standalone/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/nxt-standalone/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/nxt-standalone/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/nxt-standalone/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/nxt-standalone/contents/{+path}","compare_url":"https://api.github.com/repos/google/nxt-standalone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/nxt-standalone/merges","archive_url":"https://api.github.com/repos/google/nxt-standalone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/nxt-standalone/downloads","issues_url":"https://api.github.com/repos/google/nxt-standalone/issues{/number}","pulls_url":"https://api.github.com/repos/google/nxt-standalone/pulls{/number}","milestones_url":"https://api.github.com/repos/google/nxt-standalone/milestones{/number}","notifications_url":"https://api.github.com/repos/google/nxt-standalone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/nxt-standalone/labels{/name}","releases_url":"https://api.github.com/repos/google/nxt-standalone/releases{/id}","deployments_url":"https://api.github.com/repos/google/nxt-standalone/deployments","created_at":"2017-04-20T17:33:32Z","updated_at":"2018-06-19T17:51:30Z","pushed_at":"2018-06-21T01:54:27Z","git_url":"git://github.com/google/nxt-standalone.git","ssh_url":"git@github.com:google/nxt-standalone.git","clone_url":"https://github.com/google/nxt-standalone.git","svn_url":"https://github.com/google/nxt-standalone","homepage":"","size":1939,"stargazers_count":104,"watchers_count":104,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":16,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/206"},"html":{"href":"https://github.com/google/nxt-standalone/pull/206"},"issue":{"href":"https://api.github.com/repos/google/nxt-standalone/issues/206"},"comments":{"href":"https://api.github.com/repos/google/nxt-standalone/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/nxt-standalone/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/google/nxt-standalone/statuses/1616b5775f651c57e7e7efd40ba64efd2df731c2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Kangz"}}