{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/166779563","pull_request_review_id":94897868,"id":166779563,"diff_hunk":"@@ -261,16 +285,40 @@ def main(args):\n     config_args = '-Release -os:%s -buildArch:%s' % (clr_os, arch)\n \n     # Run the primary (non-test) corefx build\n+    # We used to pass the argument:\n+    #    -- /p:CoreCLROverridePath=<path-to-core_root>\n+    # which causes the corefx build to overwrite its built core_root with the binaries from\n+    # the coreclr build. However, this often causes build failures which breaking changes are","path":"tests/scripts/run-corefx-tests.py","position":56,"original_position":56,"commit_id":"e2518099a8e8352cd150a72b4ac11c8215493f2a","original_commit_id":"e2518099a8e8352cd150a72b4ac11c8215493f2a","user":{"login":"RussKeldorph","id":15160879,"avatar_url":"https://avatars3.githubusercontent.com/u/15160879?v=4","gravatar_id":"","url":"https://api.github.com/users/RussKeldorph","html_url":"https://github.com/RussKeldorph","followers_url":"https://api.github.com/users/RussKeldorph/followers","following_url":"https://api.github.com/users/RussKeldorph/following{/other_user}","gists_url":"https://api.github.com/users/RussKeldorph/gists{/gist_id}","starred_url":"https://api.github.com/users/RussKeldorph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RussKeldorph/subscriptions","organizations_url":"https://api.github.com/users/RussKeldorph/orgs","repos_url":"https://api.github.com/users/RussKeldorph/repos","events_url":"https://api.github.com/users/RussKeldorph/events{/privacy}","received_events_url":"https://api.github.com/users/RussKeldorph/received_events","type":"User","site_admin":false},"body":"which->when","created_at":"2018-02-07T22:39:11Z","updated_at":"2018-02-07T22:39:11Z","html_url":"https://github.com/dotnet/coreclr/pull/16263#discussion_r166779563","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/16263","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/166779563"},"html":{"href":"https://github.com/dotnet/coreclr/pull/16263#discussion_r166779563"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/16263"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/16263","id":167828009,"html_url":"https://github.com/dotnet/coreclr/pull/16263","diff_url":"https://github.com/dotnet/coreclr/pull/16263.diff","patch_url":"https://github.com/dotnet/coreclr/pull/16263.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/16263","number":16263,"state":"open","locked":false,"title":"Change corefx test process","user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars3.githubusercontent.com/u/10901265?v=4","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"body":"Instead of using the `/p:CoreCLROverridePath` switch when building\r\ncorefx, to bring in coreclr, build corefx normally. This builds\r\nagainst the coreclr packages that corefx has already been validated\r\nagainst in the CI, so the build should always work. Then, copy\r\nover our built coreclr bits before testing. This method is expected\r\nto have better behavior in most breaking change scenarios.","created_at":"2018-02-07T22:33:15Z","updated_at":"2018-02-07T22:39:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81772747b93f50f4ddddd2f707e8e6721cedca74","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/16263/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/16263/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/16263/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/e2518099a8e8352cd150a72b4ac11c8215493f2a","head":{"label":"BruceForstall:ChangeCoreFxTesting","ref":"ChangeCoreFxTesting","sha":"e2518099a8e8352cd150a72b4ac11c8215493f2a","user":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars3.githubusercontent.com/u/10901265?v=4","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"repo":{"id":30471921,"name":"coreclr","full_name":"BruceForstall/coreclr","owner":{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars3.githubusercontent.com/u/10901265?v=4","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BruceForstall/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/BruceForstall/coreclr","forks_url":"https://api.github.com/repos/BruceForstall/coreclr/forks","keys_url":"https://api.github.com/repos/BruceForstall/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BruceForstall/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BruceForstall/coreclr/teams","hooks_url":"https://api.github.com/repos/BruceForstall/coreclr/hooks","issue_events_url":"https://api.github.com/repos/BruceForstall/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/BruceForstall/coreclr/events","assignees_url":"https://api.github.com/repos/BruceForstall/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/BruceForstall/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/BruceForstall/coreclr/tags","blobs_url":"https://api.github.com/repos/BruceForstall/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BruceForstall/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BruceForstall/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/BruceForstall/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BruceForstall/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/BruceForstall/coreclr/languages","stargazers_url":"https://api.github.com/repos/BruceForstall/coreclr/stargazers","contributors_url":"https://api.github.com/repos/BruceForstall/coreclr/contributors","subscribers_url":"https://api.github.com/repos/BruceForstall/coreclr/subscribers","subscription_url":"https://api.github.com/repos/BruceForstall/coreclr/subscription","commits_url":"https://api.github.com/repos/BruceForstall/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/BruceForstall/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/BruceForstall/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/BruceForstall/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/BruceForstall/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/BruceForstall/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BruceForstall/coreclr/merges","archive_url":"https://api.github.com/repos/BruceForstall/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BruceForstall/coreclr/downloads","issues_url":"https://api.github.com/repos/BruceForstall/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/BruceForstall/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/BruceForstall/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/BruceForstall/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BruceForstall/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/BruceForstall/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/BruceForstall/coreclr/deployments","created_at":"2015-02-07T22:04:54Z","updated_at":"2017-07-14T07:39:06Z","pushed_at":"2018-02-07T22:32:23Z","git_url":"git://github.com/BruceForstall/coreclr.git","ssh_url":"git@github.com:BruceForstall/coreclr.git","clone_url":"https://github.com/BruceForstall/coreclr.git","svn_url":"https://github.com/BruceForstall/coreclr","homepage":"","size":203573,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"9c84d123bdb87ac034970e13db07361c88ace3fa","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-02-07T19:29:05Z","pushed_at":"2018-02-07T22:33:16Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":205685,"stargazers_count":8912,"watchers_count":8912,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2242,"mirror_url":null,"archived":false,"open_issues_count":1517,"license":null,"forks":2242,"open_issues":1517,"watchers":8912,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/16263"},"html":{"href":"https://github.com/dotnet/coreclr/pull/16263"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/16263"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/16263/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/16263/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/16263/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/e2518099a8e8352cd150a72b4ac11c8215493f2a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RussKeldorph"}}