{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/Mackis/NetworkLayer/pulls/2","id":222607940,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjA3OTQw","html_url":"https://github.com/Mackis/NetworkLayer/pull/2","diff_url":"https://github.com/Mackis/NetworkLayer/pull/2.diff","patch_url":"https://github.com/Mackis/NetworkLayer/pull/2.patch","issue_url":"https://api.github.com/repos/Mackis/NetworkLayer/issues/2","number":2,"state":"closed","locked":false,"title":"Fixing the unit test method testURLEncoding","user":{"login":"khawajafarooq","id":5780749,"node_id":"MDQ6VXNlcjU3ODA3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5780749?v=4","gravatar_id":"","url":"https://api.github.com/users/khawajafarooq","html_url":"https://github.com/khawajafarooq","followers_url":"https://api.github.com/users/khawajafarooq/followers","following_url":"https://api.github.com/users/khawajafarooq/following{/other_user}","gists_url":"https://api.github.com/users/khawajafarooq/gists{/gist_id}","starred_url":"https://api.github.com/users/khawajafarooq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khawajafarooq/subscriptions","organizations_url":"https://api.github.com/users/khawajafarooq/orgs","repos_url":"https://api.github.com/users/khawajafarooq/repos","events_url":"https://api.github.com/users/khawajafarooq/events{/privacy}","received_events_url":"https://api.github.com/users/khawajafarooq/received_events","type":"User","site_admin":false},"body":"- `URLParameterEncoder` init notation\r\n- Fixed assert `XCTAssertEqual(fullURL.absoluteString.sorted(), expectedURL.sorted())`","created_at":"2018-10-12T23:15:14Z","updated_at":"2018-10-13T05:58:22Z","closed_at":"2018-10-13T05:58:22Z","merged_at":"2018-10-13T05:58:22Z","merge_commit_sha":"554b0d15e9b0bea9a88b10546826f4d2f7653ae3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Mackis/NetworkLayer/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Mackis/NetworkLayer/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Mackis/NetworkLayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mackis/NetworkLayer/issues/2/comments","statuses_url":"https://api.github.com/repos/Mackis/NetworkLayer/statuses/93284ffbf7172f49ec3a579bb57951c37293c994","head":{"label":"khawajafarooq:network-test-fix","ref":"network-test-fix","sha":"93284ffbf7172f49ec3a579bb57951c37293c994","user":{"login":"khawajafarooq","id":5780749,"node_id":"MDQ6VXNlcjU3ODA3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5780749?v=4","gravatar_id":"","url":"https://api.github.com/users/khawajafarooq","html_url":"https://github.com/khawajafarooq","followers_url":"https://api.github.com/users/khawajafarooq/followers","following_url":"https://api.github.com/users/khawajafarooq/following{/other_user}","gists_url":"https://api.github.com/users/khawajafarooq/gists{/gist_id}","starred_url":"https://api.github.com/users/khawajafarooq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khawajafarooq/subscriptions","organizations_url":"https://api.github.com/users/khawajafarooq/orgs","repos_url":"https://api.github.com/users/khawajafarooq/repos","events_url":"https://api.github.com/users/khawajafarooq/events{/privacy}","received_events_url":"https://api.github.com/users/khawajafarooq/received_events","type":"User","site_admin":false},"repo":{"id":152813906,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MTM5MDY=","name":"NetworkLayer","full_name":"khawajafarooq/NetworkLayer","private":false,"owner":{"login":"khawajafarooq","id":5780749,"node_id":"MDQ6VXNlcjU3ODA3NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5780749?v=4","gravatar_id":"","url":"https://api.github.com/users/khawajafarooq","html_url":"https://github.com/khawajafarooq","followers_url":"https://api.github.com/users/khawajafarooq/followers","following_url":"https://api.github.com/users/khawajafarooq/following{/other_user}","gists_url":"https://api.github.com/users/khawajafarooq/gists{/gist_id}","starred_url":"https://api.github.com/users/khawajafarooq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khawajafarooq/subscriptions","organizations_url":"https://api.github.com/users/khawajafarooq/orgs","repos_url":"https://api.github.com/users/khawajafarooq/repos","events_url":"https://api.github.com/users/khawajafarooq/events{/privacy}","received_events_url":"https://api.github.com/users/khawajafarooq/received_events","type":"User","site_admin":false},"html_url":"https://github.com/khawajafarooq/NetworkLayer","description":"Writing my own Network Layer in Swift. Heavily influenced by Moya.","fork":true,"url":"https://api.github.com/repos/khawajafarooq/NetworkLayer","forks_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/forks","keys_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/teams","hooks_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/hooks","issue_events_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/issues/events{/number}","events_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/events","assignees_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/assignees{/user}","branches_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/branches{/branch}","tags_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/tags","blobs_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/statuses/{sha}","languages_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/languages","stargazers_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/stargazers","contributors_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/contributors","subscribers_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/subscribers","subscription_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/subscription","commits_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/contents/{+path}","compare_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/merges","archive_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/downloads","issues_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/issues{/number}","pulls_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/pulls{/number}","milestones_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/milestones{/number}","notifications_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/labels{/name}","releases_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/releases{/id}","deployments_url":"https://api.github.com/repos/khawajafarooq/NetworkLayer/deployments","created_at":"2018-10-12T22:29:44Z","updated_at":"2018-10-12T22:29:46Z","pushed_at":"2018-10-12T23:12:37Z","git_url":"git://github.com/khawajafarooq/NetworkLayer.git","ssh_url":"git@github.com:khawajafarooq/NetworkLayer.git","clone_url":"https://github.com/khawajafarooq/NetworkLayer.git","svn_url":"https://github.com/khawajafarooq/NetworkLayer","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mackis:master","ref":"master","sha":"4eb1a2c46fb641c1ebe467d2d92081dd07ecb9a7","user":{"login":"Mackis","id":17141987,"node_id":"MDQ6VXNlcjE3MTQxOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/17141987?v=4","gravatar_id":"","url":"https://api.github.com/users/Mackis","html_url":"https://github.com/Mackis","followers_url":"https://api.github.com/users/Mackis/followers","following_url":"https://api.github.com/users/Mackis/following{/other_user}","gists_url":"https://api.github.com/users/Mackis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mackis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mackis/subscriptions","organizations_url":"https://api.github.com/users/Mackis/orgs","repos_url":"https://api.github.com/users/Mackis/repos","events_url":"https://api.github.com/users/Mackis/events{/privacy}","received_events_url":"https://api.github.com/users/Mackis/received_events","type":"User","site_admin":false},"repo":{"id":123968986,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM5Njg5ODY=","name":"NetworkLayer","full_name":"Mackis/NetworkLayer","private":false,"owner":{"login":"Mackis","id":17141987,"node_id":"MDQ6VXNlcjE3MTQxOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/17141987?v=4","gravatar_id":"","url":"https://api.github.com/users/Mackis","html_url":"https://github.com/Mackis","followers_url":"https://api.github.com/users/Mackis/followers","following_url":"https://api.github.com/users/Mackis/following{/other_user}","gists_url":"https://api.github.com/users/Mackis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mackis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mackis/subscriptions","organizations_url":"https://api.github.com/users/Mackis/orgs","repos_url":"https://api.github.com/users/Mackis/repos","events_url":"https://api.github.com/users/Mackis/events{/privacy}","received_events_url":"https://api.github.com/users/Mackis/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Mackis/NetworkLayer","description":"Writing my own Network Layer in Swift. Heavily influenced by Moya.","fork":false,"url":"https://api.github.com/repos/Mackis/NetworkLayer","forks_url":"https://api.github.com/repos/Mackis/NetworkLayer/forks","keys_url":"https://api.github.com/repos/Mackis/NetworkLayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mackis/NetworkLayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mackis/NetworkLayer/teams","hooks_url":"https://api.github.com/repos/Mackis/NetworkLayer/hooks","issue_events_url":"https://api.github.com/repos/Mackis/NetworkLayer/issues/events{/number}","events_url":"https://api.github.com/repos/Mackis/NetworkLayer/events","assignees_url":"https://api.github.com/repos/Mackis/NetworkLayer/assignees{/user}","branches_url":"https://api.github.com/repos/Mackis/NetworkLayer/branches{/branch}","tags_url":"https://api.github.com/repos/Mackis/NetworkLayer/tags","blobs_url":"https://api.github.com/repos/Mackis/NetworkLayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mackis/NetworkLayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mackis/NetworkLayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mackis/NetworkLayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mackis/NetworkLayer/statuses/{sha}","languages_url":"https://api.github.com/repos/Mackis/NetworkLayer/languages","stargazers_url":"https://api.github.com/repos/Mackis/NetworkLayer/stargazers","contributors_url":"https://api.github.com/repos/Mackis/NetworkLayer/contributors","subscribers_url":"https://api.github.com/repos/Mackis/NetworkLayer/subscribers","subscription_url":"https://api.github.com/repos/Mackis/NetworkLayer/subscription","commits_url":"https://api.github.com/repos/Mackis/NetworkLayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mackis/NetworkLayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mackis/NetworkLayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mackis/NetworkLayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mackis/NetworkLayer/contents/{+path}","compare_url":"https://api.github.com/repos/Mackis/NetworkLayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mackis/NetworkLayer/merges","archive_url":"https://api.github.com/repos/Mackis/NetworkLayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mackis/NetworkLayer/downloads","issues_url":"https://api.github.com/repos/Mackis/NetworkLayer/issues{/number}","pulls_url":"https://api.github.com/repos/Mackis/NetworkLayer/pulls{/number}","milestones_url":"https://api.github.com/repos/Mackis/NetworkLayer/milestones{/number}","notifications_url":"https://api.github.com/repos/Mackis/NetworkLayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mackis/NetworkLayer/labels{/name}","releases_url":"https://api.github.com/repos/Mackis/NetworkLayer/releases{/id}","deployments_url":"https://api.github.com/repos/Mackis/NetworkLayer/deployments","created_at":"2018-03-05T19:36:09Z","updated_at":"2018-10-11T03:44:56Z","pushed_at":"2018-10-13T05:58:22Z","git_url":"git://github.com/Mackis/NetworkLayer.git","ssh_url":"git@github.com:Mackis/NetworkLayer.git","clone_url":"https://github.com/Mackis/NetworkLayer.git","svn_url":"https://github.com/Mackis/NetworkLayer","homepage":null,"size":20,"stargazers_count":85,"watchers_count":85,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":32,"open_issues":1,"watchers":85,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mackis/NetworkLayer/pulls/2"},"html":{"href":"https://github.com/Mackis/NetworkLayer/pull/2"},"issue":{"href":"https://api.github.com/repos/Mackis/NetworkLayer/issues/2"},"comments":{"href":"https://api.github.com/repos/Mackis/NetworkLayer/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Mackis/NetworkLayer/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Mackis/NetworkLayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mackis/NetworkLayer/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Mackis/NetworkLayer/statuses/93284ffbf7172f49ec3a579bb57951c37293c994"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Mackis","id":17141987,"node_id":"MDQ6VXNlcjE3MTQxOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/17141987?v=4","gravatar_id":"","url":"https://api.github.com/users/Mackis","html_url":"https://github.com/Mackis","followers_url":"https://api.github.com/users/Mackis/followers","following_url":"https://api.github.com/users/Mackis/following{/other_user}","gists_url":"https://api.github.com/users/Mackis/gists{/gist_id}","starred_url":"https://api.github.com/users/Mackis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mackis/subscriptions","organizations_url":"https://api.github.com/users/Mackis/orgs","repos_url":"https://api.github.com/users/Mackis/repos","events_url":"https://api.github.com/users/Mackis/events{/privacy}","received_events_url":"https://api.github.com/users/Mackis/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"Mackis"}}