{"action":"created","issue":{"url":"https://api.github.com/repos/graphite-ng/carbon-relay-ng/issues/288","repository_url":"https://api.github.com/repos/graphite-ng/carbon-relay-ng","labels_url":"https://api.github.com/repos/graphite-ng/carbon-relay-ng/issues/288/labels{/name}","comments_url":"https://api.github.com/repos/graphite-ng/carbon-relay-ng/issues/288/comments","events_url":"https://api.github.com/repos/graphite-ng/carbon-relay-ng/issues/288/events","html_url":"https://github.com/graphite-ng/carbon-relay-ng/pull/288","id":342434832,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzM1NjEw","number":288,"title":"response body must be read","user":{"login":"replay","id":195371,"node_id":"MDQ6VXNlcjE5NTM3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/195371?v=4","gravatar_id":"","url":"https://api.github.com/users/replay","html_url":"https://github.com/replay","followers_url":"https://api.github.com/users/replay/followers","following_url":"https://api.github.com/users/replay/following{/other_user}","gists_url":"https://api.github.com/users/replay/gists{/gist_id}","starred_url":"https://api.github.com/users/replay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replay/subscriptions","organizations_url":"https://api.github.com/users/replay/orgs","repos_url":"https://api.github.com/users/replay/repos","events_url":"https://api.github.com/users/replay/events{/privacy}","received_events_url":"https://api.github.com/users/replay/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-18T18:06:58Z","updated_at":"2018-07-18T18:08:25Z","closed_at":"2018-07-18T18:07:55Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/graphite-ng/carbon-relay-ng/pulls/288","html_url":"https://github.com/graphite-ng/carbon-relay-ng/pull/288","diff_url":"https://github.com/graphite-ng/carbon-relay-ng/pull/288.diff","patch_url":"https://github.com/graphite-ng/carbon-relay-ng/pull/288.patch"},"body":"a user asked why crng is not reusing the conns. when reading through the http client lib i saw this:\r\n\r\n```\r\n\t// Body represents the response body.\r\n\t//\r\n\t// The response body is streamed on demand as the Body field\r\n\t// is read. If the network connection fails or the server\r\n\t// terminates the response, Body.Read calls return an error.\r\n\t//\r\n\t// The http Client and Transport guarantee that Body is always\r\n\t// non-nil, even on responses without a body or responses with\r\n\t// a zero-length body. It is the caller's responsibility to\r\n\t// close Body. The default HTTP client's Transport may not\r\n\t// reuse HTTP/1.x \"keep-alive\" TCP connections if the Body is\r\n\t// not read to completion and closed.\r\n\t//\r\n\t// The Body is automatically dechunked if the server replied\r\n\t// with a \"chunked\" Transfer-Encoding.\r\n\tBody io.ReadCloser\r\n```\r\n\r\nWe currently do not seem to read that body before closing it"},"comment":{"url":"https://api.github.com/repos/graphite-ng/carbon-relay-ng/issues/comments/406023502","html_url":"https://github.com/graphite-ng/carbon-relay-ng/pull/288#issuecomment-406023502","issue_url":"https://api.github.com/repos/graphite-ng/carbon-relay-ng/issues/288","id":406023502,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjAyMzUwMg==","user":{"login":"replay","id":195371,"node_id":"MDQ6VXNlcjE5NTM3MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/195371?v=4","gravatar_id":"","url":"https://api.github.com/users/replay","html_url":"https://github.com/replay","followers_url":"https://api.github.com/users/replay/followers","following_url":"https://api.github.com/users/replay/following{/other_user}","gists_url":"https://api.github.com/users/replay/gists{/gist_id}","starred_url":"https://api.github.com/users/replay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/replay/subscriptions","organizations_url":"https://api.github.com/users/replay/orgs","repos_url":"https://api.github.com/users/replay/repos","events_url":"https://api.github.com/users/replay/events{/privacy}","received_events_url":"https://api.github.com/users/replay/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T18:08:25Z","updated_at":"2018-07-18T18:08:25Z","author_association":"CONTRIBUTOR","body":"closed that because I realized i was looking at an old version and this has already been fixed"}}
{"actor":{"display_login":"replay"}}