{"action":"created","issue":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22080","repository_url":"https://api.github.com/repos/tensorflow/tensorflow","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22080/labels{/name}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22080/comments","events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22080/events","html_url":"https://github.com/tensorflow/tensorflow/issues/22080","id":357093776,"node_id":"MDU6SXNzdWUzNTcwOTM3NzY=","number":22080,"title":"The performance of FusedBatchNormGradGrad is very low","user":{"login":"mpjlu","id":13826327,"node_id":"MDQ6VXNlcjEzODI2MzI3","avatar_url":"https://avatars1.githubusercontent.com/u/13826327?v=4","gravatar_id":"","url":"https://api.github.com/users/mpjlu","html_url":"https://github.com/mpjlu","followers_url":"https://api.github.com/users/mpjlu/followers","following_url":"https://api.github.com/users/mpjlu/following{/other_user}","gists_url":"https://api.github.com/users/mpjlu/gists{/gist_id}","starred_url":"https://api.github.com/users/mpjlu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpjlu/subscriptions","organizations_url":"https://api.github.com/users/mpjlu/orgs","repos_url":"https://api.github.com/users/mpjlu/repos","events_url":"https://api.github.com/users/mpjlu/events{/privacy}","received_events_url":"https://api.github.com/users/mpjlu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"joel-shor","id":6020988,"node_id":"MDQ6VXNlcjYwMjA5ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/6020988?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-shor","html_url":"https://github.com/joel-shor","followers_url":"https://api.github.com/users/joel-shor/followers","following_url":"https://api.github.com/users/joel-shor/following{/other_user}","gists_url":"https://api.github.com/users/joel-shor/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-shor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-shor/subscriptions","organizations_url":"https://api.github.com/users/joel-shor/orgs","repos_url":"https://api.github.com/users/joel-shor/repos","events_url":"https://api.github.com/users/joel-shor/events{/privacy}","received_events_url":"https://api.github.com/users/joel-shor/received_events","type":"User","site_admin":false},"assignees":[{"login":"joel-shor","id":6020988,"node_id":"MDQ6VXNlcjYwMjA5ODg=","avatar_url":"https://avatars1.githubusercontent.com/u/6020988?v=4","gravatar_id":"","url":"https://api.github.com/users/joel-shor","html_url":"https://github.com/joel-shor","followers_url":"https://api.github.com/users/joel-shor/followers","following_url":"https://api.github.com/users/joel-shor/following{/other_user}","gists_url":"https://api.github.com/users/joel-shor/gists{/gist_id}","starred_url":"https://api.github.com/users/joel-shor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joel-shor/subscriptions","organizations_url":"https://api.github.com/users/joel-shor/orgs","repos_url":"https://api.github.com/users/joel-shor/repos","events_url":"https://api.github.com/users/joel-shor/events{/privacy}","received_events_url":"https://api.github.com/users/joel-shor/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-09-05T07:10:30Z","updated_at":"2018-10-05T19:09:45Z","closed_at":null,"author_association":"NONE","body":"When I test the performance of GAN model (https://github.com/tensorflow/models/tree/master/research/gan), I find to use FusedBatchNorm can boost the performance by 20% to 30% (https://github.com/tensorflow/models/issues/5206).\r\n\r\nHowever, when use gan_loss with gradient_penalty, there is no performance improvement with FusedBatchNorm.  I find the root cause is FusedBatchNormGradGrad is very low performance.\r\n\r\nI propose to set fused_batch_norm to false on (https://github.com/tensorflow/tensorflow/blob/master/tensorflow/contrib/gan/python/losses/python/losses_impl.py#L367) to use BatchNormGradGrad to replace FusedBatchNormGradGrad. There is about 20% performance improvement with this change. \r\nChange\r\n`disc_interpolates = discriminator_fn(interpolates, generator_inputs)`\r\nto \r\n`disc_interpolates = discriminator_fn(interpolates, generator_inputs, fused_batch_norm=false)`\r\n   \r\n"},"comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments/427469772","html_url":"https://github.com/tensorflow/tensorflow/issues/22080#issuecomment-427469772","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/22080","id":427469772,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzQ2OTc3Mg==","user":{"login":"tensorflowbutler","id":28546240,"node_id":"MDQ6VXNlcjI4NTQ2MjQw","avatar_url":"https://avatars2.githubusercontent.com/u/28546240?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflowbutler","html_url":"https://github.com/tensorflowbutler","followers_url":"https://api.github.com/users/tensorflowbutler/followers","following_url":"https://api.github.com/users/tensorflowbutler/following{/other_user}","gists_url":"https://api.github.com/users/tensorflowbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflowbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflowbutler/subscriptions","organizations_url":"https://api.github.com/users/tensorflowbutler/orgs","repos_url":"https://api.github.com/users/tensorflowbutler/repos","events_url":"https://api.github.com/users/tensorflowbutler/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflowbutler/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T19:09:45Z","updated_at":"2018-10-05T19:09:45Z","author_association":"MEMBER","body":"Nagging Assignee @joel-shor: It has been 30 days with no activity and this issue has an assignee. Please update the label and/or status accordingly."}}
{"actor":{"display_login":"tensorflowbutler"}}