{"action":"created","issue":{"url":"https://api.github.com/repos/hashicorp/go-retryablehttp/issues/22","repository_url":"https://api.github.com/repos/hashicorp/go-retryablehttp","labels_url":"https://api.github.com/repos/hashicorp/go-retryablehttp/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/hashicorp/go-retryablehttp/issues/22/comments","events_url":"https://api.github.com/repos/hashicorp/go-retryablehttp/issues/22/events","html_url":"https://github.com/hashicorp/go-retryablehttp/issues/22","id":314537821,"node_id":"MDU6SXNzdWUzMTQ1Mzc4MjE=","number":22,"title":"Request with context","user":{"login":"vbauerster","id":2206533,"node_id":"MDQ6VXNlcjIyMDY1MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/2206533?v=4","gravatar_id":"","url":"https://api.github.com/users/vbauerster","html_url":"https://github.com/vbauerster","followers_url":"https://api.github.com/users/vbauerster/followers","following_url":"https://api.github.com/users/vbauerster/following{/other_user}","gists_url":"https://api.github.com/users/vbauerster/gists{/gist_id}","starred_url":"https://api.github.com/users/vbauerster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbauerster/subscriptions","organizations_url":"https://api.github.com/users/vbauerster/orgs","repos_url":"https://api.github.com/users/vbauerster/repos","events_url":"https://api.github.com/users/vbauerster/events{/privacy}","received_events_url":"https://api.github.com/users/vbauerster/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-16T07:54:13Z","updated_at":"2018-07-13T19:14:35Z","closed_at":null,"author_association":"NONE","body":"Calling WithContext on wrapped [Request](https://godoc.org/github.com/hashicorp/go-retryablehttp#Request), would return *http.Request, so user cannot do:\r\n\r\n```go\r\nreq, err := NewRequest(http.MethodGet, ts.URL, nil)\r\nif err != nil { /* handle error */ }\r\nctx, cancel := context.WithCancel(req.Request.Context())\r\nreq = req.WithContext(ctx) // compile time error here\r\n```\r\n\r\nAlso the lib would start retrying on context error, i.e. cancel called. Which is imo wrong. If user calls cancel, the intention is cancel, not retry.\r\n"},"comment":{"url":"https://api.github.com/repos/hashicorp/go-retryablehttp/issues/comments/404927474","html_url":"https://github.com/hashicorp/go-retryablehttp/issues/22#issuecomment-404927474","issue_url":"https://api.github.com/repos/hashicorp/go-retryablehttp/issues/22","id":404927474,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDkyNzQ3NA==","user":{"login":"tkanos","id":5888407,"node_id":"MDQ6VXNlcjU4ODg0MDc=","avatar_url":"https://avatars3.githubusercontent.com/u/5888407?v=4","gravatar_id":"","url":"https://api.github.com/users/tkanos","html_url":"https://github.com/tkanos","followers_url":"https://api.github.com/users/tkanos/followers","following_url":"https://api.github.com/users/tkanos/following{/other_user}","gists_url":"https://api.github.com/users/tkanos/gists{/gist_id}","starred_url":"https://api.github.com/users/tkanos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkanos/subscriptions","organizations_url":"https://api.github.com/users/tkanos/orgs","repos_url":"https://api.github.com/users/tkanos/repos","events_url":"https://api.github.com/users/tkanos/events{/privacy}","received_events_url":"https://api.github.com/users/tkanos/received_events","type":"User","site_admin":false},"created_at":"2018-07-13T19:14:35Z","updated_at":"2018-07-13T19:14:35Z","author_association":"CONTRIBUTOR","body":"Hey dudes,\r\n\r\nIt's something that the community are waiting since April, when will it be released ?\r\n\r\n"}}
{"actor":{"display_login":"tkanos"}}