{"action":"created","issue":{"url":"https://api.github.com/repos/ifmeorg/ifme/issues/1113","repository_url":"https://api.github.com/repos/ifmeorg/ifme","labels_url":"https://api.github.com/repos/ifmeorg/ifme/issues/1113/labels{/name}","comments_url":"https://api.github.com/repos/ifmeorg/ifme/issues/1113/comments","events_url":"https://api.github.com/repos/ifmeorg/ifme/issues/1113/events","html_url":"https://github.com/ifmeorg/ifme/pull/1113","id":367758925,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDkzMDQ3","number":1113,"title":"Rescue from specific errors","user":{"login":"hmasila","id":20906768,"node_id":"MDQ6VXNlcjIwOTA2NzY4","avatar_url":"https://avatars0.githubusercontent.com/u/20906768?v=4","gravatar_id":"","url":"https://api.github.com/users/hmasila","html_url":"https://github.com/hmasila","followers_url":"https://api.github.com/users/hmasila/followers","following_url":"https://api.github.com/users/hmasila/following{/other_user}","gists_url":"https://api.github.com/users/hmasila/gists{/gist_id}","starred_url":"https://api.github.com/users/hmasila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmasila/subscriptions","organizations_url":"https://api.github.com/users/hmasila/orgs","repos_url":"https://api.github.com/users/hmasila/repos","events_url":"https://api.github.com/users/hmasila/events{/privacy}","received_events_url":"https://api.github.com/users/hmasila/received_events","type":"User","site_admin":false},"labels":[{"id":676644506,"node_id":"MDU6TGFiZWw2NzY2NDQ1MDY=","url":"https://api.github.com/repos/ifmeorg/ifme/labels/refactoring","name":"refactoring","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":{"login":"hmasila","id":20906768,"node_id":"MDQ6VXNlcjIwOTA2NzY4","avatar_url":"https://avatars0.githubusercontent.com/u/20906768?v=4","gravatar_id":"","url":"https://api.github.com/users/hmasila","html_url":"https://github.com/hmasila","followers_url":"https://api.github.com/users/hmasila/followers","following_url":"https://api.github.com/users/hmasila/following{/other_user}","gists_url":"https://api.github.com/users/hmasila/gists{/gist_id}","starred_url":"https://api.github.com/users/hmasila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmasila/subscriptions","organizations_url":"https://api.github.com/users/hmasila/orgs","repos_url":"https://api.github.com/users/hmasila/repos","events_url":"https://api.github.com/users/hmasila/events{/privacy}","received_events_url":"https://api.github.com/users/hmasila/received_events","type":"User","site_admin":false},"assignees":[{"login":"hmasila","id":20906768,"node_id":"MDQ6VXNlcjIwOTA2NzY4","avatar_url":"https://avatars0.githubusercontent.com/u/20906768?v=4","gravatar_id":"","url":"https://api.github.com/users/hmasila","html_url":"https://github.com/hmasila","followers_url":"https://api.github.com/users/hmasila/followers","following_url":"https://api.github.com/users/hmasila/following{/other_user}","gists_url":"https://api.github.com/users/hmasila/gists{/gist_id}","starred_url":"https://api.github.com/users/hmasila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmasila/subscriptions","organizations_url":"https://api.github.com/users/hmasila/orgs","repos_url":"https://api.github.com/users/hmasila/repos","events_url":"https://api.github.com/users/hmasila/events{/privacy}","received_events_url":"https://api.github.com/users/hmasila/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-10-08T12:06:35Z","updated_at":"2018-10-12T18:37:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ifmeorg/ifme/pulls/1113","html_url":"https://github.com/ifmeorg/ifme/pull/1113","diff_url":"https://github.com/ifmeorg/ifme/pull/1113.diff","patch_url":"https://github.com/ifmeorg/ifme/pull/1113.patch"},"body":"<!--[\r\n  Thank you for contributing! Please use this pull request (PR) template.\r\n\r\n  Contributor Blurb: https://github.com/ifmeorg/ifme/wiki/Contributor-Blurb\r\n  Join Our Slack: https://github.com/ifmeorg/ifme/wiki/Join-Our-Slack\r\n\r\n  Need help? Post in the #dev channel on Slack\r\n  Use the \"wip\" label if this PR is not ready for review\r\n]-->\r\n# Description \r\n\r\n<!--[A few sentences describing your changes]-->\r\nRescuing Exception can cause very unexpected behaviour.\r\n\r\nStandardError is the parent of most Ruby and Rails errors. If you catch StandardError you’re not introducing the problems of rescuing Exception, but it is not a great idea.\r\n## More Details\r\n\r\n<!--[More details on your changes, remove if not applicable]-->\r\nRescuing all application-level errors might cover up unrelated bugs you don’t know about.\r\n\r\nThe safest approach is to rescue the error (or errors) you are expecting and deal with the consequences of that error inside the rescue block.\r\n\r\nIn the event of an unexpected error in your application you want to know that a new error has occurred and deal with the consequences of that new error inside its own rescue block.\r\n\r\nBeing specific with rescue means your code doesn’t accidentally swallow new errors. You avoid subtle hidden errors that lead to unexpected behaviour for your users and bug hunting for you.\r\n\r\n## Corresponding Issue\r\n\r\n<!--[Link to GitHub issue related to this PR here, remove if not applicable]-->\r\nhttps://github.com/ifmeorg/ifme/issues/840\r\n# Screenshots\r\n\r\n<!--[\r\n  Screenshots (required for user interface work), remove if not applicable\r\n  Create a GIF: https://www.cockos.com/licecap\r\n]-->\r\n\r\n# Test Coverage\r\n\r\n✅ <!--[YES, remove line if not applicable]-->\r\n🚫 <!--[NO, remove line if not applicable]-->\r\n\r\n<!--[Must be YES, if NO explain why]-->\r\n"},"comment":{"url":"https://api.github.com/repos/ifmeorg/ifme/issues/comments/429420415","html_url":"https://github.com/ifmeorg/ifme/pull/1113#issuecomment-429420415","issue_url":"https://api.github.com/repos/ifmeorg/ifme/issues/1113","id":429420415,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTQyMDQxNQ==","user":{"login":"julianguyen","id":3010728,"node_id":"MDQ6VXNlcjMwMTA3Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/3010728?v=4","gravatar_id":"","url":"https://api.github.com/users/julianguyen","html_url":"https://github.com/julianguyen","followers_url":"https://api.github.com/users/julianguyen/followers","following_url":"https://api.github.com/users/julianguyen/following{/other_user}","gists_url":"https://api.github.com/users/julianguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/julianguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianguyen/subscriptions","organizations_url":"https://api.github.com/users/julianguyen/orgs","repos_url":"https://api.github.com/users/julianguyen/repos","events_url":"https://api.github.com/users/julianguyen/events{/privacy}","received_events_url":"https://api.github.com/users/julianguyen/received_events","type":"User","site_admin":false},"created_at":"2018-10-12T18:37:55Z","updated_at":"2018-10-12T18:37:55Z","author_association":"MEMBER","body":"Is this ready to merge? :)"}}
{"actor":{"display_login":"julianguyen"}}