{"action":"created","issue":{"url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/562","repository_url":"https://api.github.com/repos/ESMValGroup/ESMValTool","labels_url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/562/labels{/name}","comments_url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/562/comments","events_url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/562/events","html_url":"https://github.com/ESMValGroup/ESMValTool/pull/562","id":348800595,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MDY1OTY4","number":562,"title":"Version2 validation","user":{"login":"valeriupredoi","id":28983971,"node_id":"MDQ6VXNlcjI4OTgzOTcx","avatar_url":"https://avatars0.githubusercontent.com/u/28983971?v=4","gravatar_id":"","url":"https://api.github.com/users/valeriupredoi","html_url":"https://github.com/valeriupredoi","followers_url":"https://api.github.com/users/valeriupredoi/followers","following_url":"https://api.github.com/users/valeriupredoi/following{/other_user}","gists_url":"https://api.github.com/users/valeriupredoi/gists{/gist_id}","starred_url":"https://api.github.com/users/valeriupredoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valeriupredoi/subscriptions","organizations_url":"https://api.github.com/users/valeriupredoi/orgs","repos_url":"https://api.github.com/users/valeriupredoi/repos","events_url":"https://api.github.com/users/valeriupredoi/events{/privacy}","received_events_url":"https://api.github.com/users/valeriupredoi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-08T16:28:26Z","updated_at":"2018-08-10T13:38:27Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ESMValGroup/ESMValTool/pulls/562","html_url":"https://github.com/ESMValGroup/ESMValTool/pull/562","diff_url":"https://github.com/ESMValGroup/ESMValTool/pull/562.diff","patch_url":"https://github.com/ESMValGroup/ESMValTool/pull/562.patch"},"body":"This is a basic but rather useful diagnostic that compares two datasets (control and experiment) for any number of variables (derived or not) and can use any number of OBS/obs4mips etc etc files; it does lat-lon (2d) differences, zonal mean on lat, zonal mean on lon, and I will put in seasons as well -- I am doing some work for a few UKESM guys and realized we actually need one diag like this - basic but that actually plots the comparison between two models with obs in as well. I still need to put the seasons and then ask you guys for a review (prob tomorrow) :grin: "},"comment":{"url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/comments/412084888","html_url":"https://github.com/ESMValGroup/ESMValTool/pull/562#issuecomment-412084888","issue_url":"https://api.github.com/repos/ESMValGroup/ESMValTool/issues/562","id":412084888,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjA4NDg4OA==","user":{"login":"bouweandela","id":5430937,"node_id":"MDQ6VXNlcjU0MzA5Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5430937?v=4","gravatar_id":"","url":"https://api.github.com/users/bouweandela","html_url":"https://github.com/bouweandela","followers_url":"https://api.github.com/users/bouweandela/followers","following_url":"https://api.github.com/users/bouweandela/following{/other_user}","gists_url":"https://api.github.com/users/bouweandela/gists{/gist_id}","starred_url":"https://api.github.com/users/bouweandela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bouweandela/subscriptions","organizations_url":"https://api.github.com/users/bouweandela/orgs","repos_url":"https://api.github.com/users/bouweandela/repos","events_url":"https://api.github.com/users/bouweandela/events{/privacy}","received_events_url":"https://api.github.com/users/bouweandela/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T13:38:27Z","updated_at":"2018-08-10T13:38:27Z","author_association":"CONTRIBUTOR","body":"Hi V.,\r\n\r\nThanks for removing the duplication. It would be better if you put those two functions in a new file esmvaltool/diag_scripts/shared/validation.py though. That way we keep the files small and relevant.\r\n\r\nIt should be possible to use preprocessor functions from a recipe,  but `apply_supermeans` would need quite a bit of work before that is possible, so I think it should not be in the `_time_area` preprocessor module at this stage, unless you believe it is worth it to do that work.\r\n\r\nThe function `get_control_exper_obs` is not quite as generic as the other functions in the esmvaltool/diag_scripts/shared._base.py file, so I think it would be better to put it in it's own file in the shared directory."}}
{"actor":{"display_login":"bouweandela"}}