{"action":"closed","number":18436,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/18436","id":196453665,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDUzNjY1","html_url":"https://github.com/edx/edx-platform/pull/18436","diff_url":"https://github.com/edx/edx-platform/pull/18436.diff","patch_url":"https://github.com/edx/edx-platform/pull/18436.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/18436","number":18436,"state":"closed","locked":false,"title":"add delay in score recalculation on enrollment update","user":{"login":"noraiz-anwar","id":22347092,"node_id":"MDQ6VXNlcjIyMzQ3MDky","avatar_url":"https://avatars0.githubusercontent.com/u/22347092?v=4","gravatar_id":"","url":"https://api.github.com/users/noraiz-anwar","html_url":"https://github.com/noraiz-anwar","followers_url":"https://api.github.com/users/noraiz-anwar/followers","following_url":"https://api.github.com/users/noraiz-anwar/following{/other_user}","gists_url":"https://api.github.com/users/noraiz-anwar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraiz-anwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraiz-anwar/subscriptions","organizations_url":"https://api.github.com/users/noraiz-anwar/orgs","repos_url":"https://api.github.com/users/noraiz-anwar/repos","events_url":"https://api.github.com/users/noraiz-anwar/events{/privacy}","received_events_url":"https://api.github.com/users/noraiz-anwar/received_events","type":"User","site_admin":false},"body":"## [EDUCATOR-2773](https://openedx.atlassian.net/browse/EDUCATOR-2773)\r\n\r\n### Description\r\n\r\nScore is recalculated when enrollment of learner is changed. For courses which use verified track cohorting, we need to make sure that cohort is duly updated before recalculating learner's score. \r\n\r\n**An impact example:**\r\nOne know impact of recalculating score (on enrollment update from audit to verified) with previous cohort is firing of `COURSE_GRADE_CHANGED` signal (learner is passing course while being in Audit cohort, cohort is not updated to Verified yet) which eventually generates certificate (certificate auto generated as learner is in verified track) unexpectedly.\r\n\r\nA 30 second delay is added in recalculation task to achieve purpose.\r\n\r\n### Sandbox\r\n- [ ] https://certificate.sandbox.edx.org/\r\n\r\n\r\nI have created a test course https://certificate.sandbox.edx.org/courses/course-v1:arbisoft+c100+2018/course/ which is \r\n\r\n- Have audit and verified mode.\r\n- Verified track cohorted.\r\n- Auto certificate generation is enabled.\r\n- Content is divided in audit and verified cohorts\r\n\r\nUser 'verified' is photo verified in this sandbox.\r\n\r\nSuper user credentials are (to check admin if needed) :\r\nusername : noraiz\r\npassword : edx\r\n\r\n### Reviewers\r\n- [ ] @sanfordstudent \r\n- [ ] @awaisdar001 \r\n \r\n### Post-review\r\n- [ ] Rebase and squash commits","created_at":"2018-06-21T13:32:57Z","updated_at":"2018-06-25T17:06:31Z","closed_at":"2018-06-25T17:06:31Z","merged_at":"2018-06-25T17:06:31Z","merge_commit_sha":"18f0c59f1ae8764d43fd0b86dab3cc4dc7be1cb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/18436/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/18436/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/18436/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/06780b2ded8358d77d7dac5452758b895b4af4f6","head":{"label":"edx:noraiz/EDUCATOR-2773","ref":"noraiz/EDUCATOR-2773","sha":"06780b2ded8358d77d7dac5452758b895b4af4f6","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MTA3Mw==","name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2018-06-25T15:44:16Z","pushed_at":"2018-06-25T17:06:31Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":941295,"stargazers_count":3735,"watchers_count":3735,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2100,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2100,"open_issues":219,"watchers":3735,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"b0fc37cfe3f7de1c734440fc45b4d10f86b914bd","user":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"node_id":"MDEwOlJlcG9zaXRvcnkxMDM5MTA3Mw==","name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzk4NDE=","avatar_url":"https://avatars3.githubusercontent.com/u/3179841?v=4","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","deployments_url":"https://api.github.com/repos/edx/edx-platform/deployments","created_at":"2013-05-30T20:20:38Z","updated_at":"2018-06-25T15:44:16Z","pushed_at":"2018-06-25T17:06:31Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":941295,"stargazers_count":3735,"watchers_count":3735,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2100,"mirror_url":null,"archived":false,"open_issues_count":219,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2100,"open_issues":219,"watchers":3735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/18436"},"html":{"href":"https://github.com/edx/edx-platform/pull/18436"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/18436"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/18436/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/18436/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/18436/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/06780b2ded8358d77d7dac5452758b895b4af4f6"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"noraiz-anwar","id":22347092,"node_id":"MDQ6VXNlcjIyMzQ3MDky","avatar_url":"https://avatars0.githubusercontent.com/u/22347092?v=4","gravatar_id":"","url":"https://api.github.com/users/noraiz-anwar","html_url":"https://github.com/noraiz-anwar","followers_url":"https://api.github.com/users/noraiz-anwar/followers","following_url":"https://api.github.com/users/noraiz-anwar/following{/other_user}","gists_url":"https://api.github.com/users/noraiz-anwar/gists{/gist_id}","starred_url":"https://api.github.com/users/noraiz-anwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noraiz-anwar/subscriptions","organizations_url":"https://api.github.com/users/noraiz-anwar/orgs","repos_url":"https://api.github.com/users/noraiz-anwar/repos","events_url":"https://api.github.com/users/noraiz-anwar/events{/privacy}","received_events_url":"https://api.github.com/users/noraiz-anwar/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":50,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"noraiz-anwar"}}