{"action":"created","issue":{"url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/379","repository_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine","labels_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/379/labels{/name}","comments_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/379/comments","events_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/379/events","html_url":"https://github.com/STORM-IRIT/Radium-Engine/pull/379","id":370250779,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTcyOTcx","number":379,"title":"Fix dirty bits in Mesh ;","user":{"login":"hoshiryu","id":460844,"node_id":"MDQ6VXNlcjQ2MDg0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/460844?v=4","gravatar_id":"","url":"https://api.github.com/users/hoshiryu","html_url":"https://github.com/hoshiryu","followers_url":"https://api.github.com/users/hoshiryu/followers","following_url":"https://api.github.com/users/hoshiryu/following{/other_user}","gists_url":"https://api.github.com/users/hoshiryu/gists{/gist_id}","starred_url":"https://api.github.com/users/hoshiryu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoshiryu/subscriptions","organizations_url":"https://api.github.com/users/hoshiryu/orgs","repos_url":"https://api.github.com/users/hoshiryu/repos","events_url":"https://api.github.com/users/hoshiryu/events{/privacy}","received_events_url":"https://api.github.com/users/hoshiryu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-15T16:48:00Z","updated_at":"2018-10-16T07:35:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/pulls/379","html_url":"https://github.com/STORM-IRIT/Radium-Engine/pull/379","diff_url":"https://github.com/STORM-IRIT/Radium-Engine/pull/379.diff","patch_url":"https://github.com/STORM-IRIT/Radium-Engine/pull/379.patch"},"body":"* **Please check if the PR fulfills these requirements**\r\n- [ ] Is the Pull-Request done against the right branch:\r\n  - `master`: for hotfixes not impacting the API\r\n  - `master-v1`: for changes related to the Radium Stable Release V1.\r\n- [ ] The commit message follows our guidelines\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\nBe aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.\r\n\r\n\r\n* **What kind of change does this PR introduce?** (Bug fix, feature, docs update, ...)\r\nFix `Engine::Mesh::m_dataDirty` when loading `TriangleMesh`\r\n\r\n\r\n* **What is the current behavior?** (You can also link to an open issue here)\r\nWhen loading a `Core::TriangleMesh` into an `Engine::Mesh`, the dirty bits for the attributes are not set, thus the attributes are not loaded on the GPU.\r\n\r\n\r\n* **What is the new behavior (if this is a feature change)?**\r\nThe dirty bits are now set for all data.\r\n\r\n\r\n* **Does this PR introduce a breaking change?** (What changes might users need to make in their application due to this PR?)\r\n\r\n\r\n\r\n* **Other information**:\r\n"},"comment":{"url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/comments/430132827","html_url":"https://github.com/STORM-IRIT/Radium-Engine/pull/379#issuecomment-430132827","issue_url":"https://api.github.com/repos/STORM-IRIT/Radium-Engine/issues/379","id":430132827,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDEzMjgyNw==","user":{"login":"nmellado","id":6310221,"node_id":"MDQ6VXNlcjYzMTAyMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/6310221?v=4","gravatar_id":"","url":"https://api.github.com/users/nmellado","html_url":"https://github.com/nmellado","followers_url":"https://api.github.com/users/nmellado/followers","following_url":"https://api.github.com/users/nmellado/following{/other_user}","gists_url":"https://api.github.com/users/nmellado/gists{/gist_id}","starred_url":"https://api.github.com/users/nmellado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmellado/subscriptions","organizations_url":"https://api.github.com/users/nmellado/orgs","repos_url":"https://api.github.com/users/nmellado/repos","events_url":"https://api.github.com/users/nmellado/events{/privacy}","received_events_url":"https://api.github.com/users/nmellado/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T07:35:58Z","updated_at":"2018-10-16T07:35:58Z","author_association":"CONTRIBUTOR","body":"It is true that `updateMeshGeometry` might lead to inconsistent state. On the other hand it doesn't seems to be used anywhere. Shall we remove it ?\r\n`loadGeometry` sets the dirty flags, what's wrong with it ?\r\nThe non-const version of `getData` is maybe too intrusive, + I cannot find any use in the main project. Shall we also remove it ?"}}
{"actor":{"display_login":"nmellado"}}