{"action":"created","comment":{"url":"https://api.github.com/repos/blevesearch/bleve/pulls/comments/183142698","pull_request_review_id":114091811,"id":183142698,"diff_hunk":"@@ -274,19 +273,20 @@ type segmentMerge struct {\n // into the root\n func (s *Scorch) mergeSegmentBases(snapshot *IndexSnapshot,\n \tsbs []*zap.SegmentBase, sbsDrops []*roaring.Bitmap, sbsIndexes []int,\n-\tchunkFactor uint32) (uint64, *IndexSnapshot, uint64, error) {\n+\tchunkFactor uint32) (*IndexSnapshot, uint64, error) {\n \tatomic.AddUint64(&s.stats.TotMemMergeBeg, 1)\n \n-\tvar br bytes.Buffer\n-\n-\tcr := zap.NewCountHashWriter(&br)\n-\n \tmemMergeZapStartTime := time.Now()\n \n \tatomic.AddUint64(&s.stats.TotMemMergeZapBeg, 1)","path":"index/scorch/merge.go","position":31,"original_position":31,"commit_id":"4bf27cb44d758427a24a9851afdd78aa60820264","original_commit_id":"4bf27cb44d758427a24a9851afdd78aa60820264","user":{"login":"abhinavdangeti","id":1863456,"avatar_url":"https://avatars2.githubusercontent.com/u/1863456?v=4","gravatar_id":"","url":"https://api.github.com/users/abhinavdangeti","html_url":"https://github.com/abhinavdangeti","followers_url":"https://api.github.com/users/abhinavdangeti/followers","following_url":"https://api.github.com/users/abhinavdangeti/following{/other_user}","gists_url":"https://api.github.com/users/abhinavdangeti/gists{/gist_id}","starred_url":"https://api.github.com/users/abhinavdangeti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abhinavdangeti/subscriptions","organizations_url":"https://api.github.com/users/abhinavdangeti/orgs","repos_url":"https://api.github.com/users/abhinavdangeti/repos","events_url":"https://api.github.com/users/abhinavdangeti/events{/privacy}","received_events_url":"https://api.github.com/users/abhinavdangeti/received_events","type":"User","site_admin":false},"body":"Should we perhaps edit these stat names as well now?","created_at":"2018-04-20T19:02:38Z","updated_at":"2018-04-20T19:04:12Z","html_url":"https://github.com/blevesearch/bleve/pull/904#discussion_r183142698","pull_request_url":"https://api.github.com/repos/blevesearch/bleve/pulls/904","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/comments/183142698"},"html":{"href":"https://github.com/blevesearch/bleve/pull/904#discussion_r183142698"},"pull_request":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/904"}}},"pull_request":{"url":"https://api.github.com/repos/blevesearch/bleve/pulls/904","id":183143192,"html_url":"https://github.com/blevesearch/bleve/pull/904","diff_url":"https://github.com/blevesearch/bleve/pull/904.diff","patch_url":"https://github.com/blevesearch/bleve/pull/904.patch","issue_url":"https://api.github.com/repos/blevesearch/bleve/issues/904","number":904,"state":"open","locked":false,"title":"persistSnapshotMaybeMerge() merges to directly to file","user":{"login":"steveyen","id":30640,"avatar_url":"https://avatars3.githubusercontent.com/u/30640?v=4","gravatar_id":"","url":"https://api.github.com/users/steveyen","html_url":"https://github.com/steveyen","followers_url":"https://api.github.com/users/steveyen/followers","following_url":"https://api.github.com/users/steveyen/following{/other_user}","gists_url":"https://api.github.com/users/steveyen/gists{/gist_id}","starred_url":"https://api.github.com/users/steveyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveyen/subscriptions","organizations_url":"https://api.github.com/users/steveyen/orgs","repos_url":"https://api.github.com/users/steveyen/repos","events_url":"https://api.github.com/users/steveyen/events{/privacy}","received_events_url":"https://api.github.com/users/steveyen/received_events","type":"User","site_admin":false},"body":"The persister goroutine can decide to merge its incoming input\r\nsegments before persistence... and before this commit, that merging\r\nwould have been entirely in-memory, leading to a lot of memory usage.\r\n\r\nAfter this change, the persistSnapshotMaybeMerge(), which calls\r\nmergeSegmentBases(), performs the merging directly to file.","created_at":"2018-04-20T18:54:49Z","updated_at":"2018-04-20T19:04:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f82902322a9c7a5d32a493e0273e8be585dde98c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mschoch","id":298143,"avatar_url":"https://avatars2.githubusercontent.com/u/298143?v=4","gravatar_id":"","url":"https://api.github.com/users/mschoch","html_url":"https://github.com/mschoch","followers_url":"https://api.github.com/users/mschoch/followers","following_url":"https://api.github.com/users/mschoch/following{/other_user}","gists_url":"https://api.github.com/users/mschoch/gists{/gist_id}","starred_url":"https://api.github.com/users/mschoch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mschoch/subscriptions","organizations_url":"https://api.github.com/users/mschoch/orgs","repos_url":"https://api.github.com/users/mschoch/repos","events_url":"https://api.github.com/users/mschoch/events{/privacy}","received_events_url":"https://api.github.com/users/mschoch/received_events","type":"User","site_admin":false},{"login":"sreekanth-cb","id":25240115,"avatar_url":"https://avatars1.githubusercontent.com/u/25240115?v=4","gravatar_id":"","url":"https://api.github.com/users/sreekanth-cb","html_url":"https://github.com/sreekanth-cb","followers_url":"https://api.github.com/users/sreekanth-cb/followers","following_url":"https://api.github.com/users/sreekanth-cb/following{/other_user}","gists_url":"https://api.github.com/users/sreekanth-cb/gists{/gist_id}","starred_url":"https://api.github.com/users/sreekanth-cb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sreekanth-cb/subscriptions","organizations_url":"https://api.github.com/users/sreekanth-cb/orgs","repos_url":"https://api.github.com/users/sreekanth-cb/repos","events_url":"https://api.github.com/users/sreekanth-cb/events{/privacy}","received_events_url":"https://api.github.com/users/sreekanth-cb/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blevesearch/bleve/pulls/904/commits","review_comments_url":"https://api.github.com/repos/blevesearch/bleve/pulls/904/comments","review_comment_url":"https://api.github.com/repos/blevesearch/bleve/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blevesearch/bleve/issues/904/comments","statuses_url":"https://api.github.com/repos/blevesearch/bleve/statuses/4bf27cb44d758427a24a9851afdd78aa60820264","head":{"label":"steveyen:persistSnapshotMaybeMerge-direct-to-file","ref":"persistSnapshotMaybeMerge-direct-to-file","sha":"4bf27cb44d758427a24a9851afdd78aa60820264","user":{"login":"steveyen","id":30640,"avatar_url":"https://avatars3.githubusercontent.com/u/30640?v=4","gravatar_id":"","url":"https://api.github.com/users/steveyen","html_url":"https://github.com/steveyen","followers_url":"https://api.github.com/users/steveyen/followers","following_url":"https://api.github.com/users/steveyen/following{/other_user}","gists_url":"https://api.github.com/users/steveyen/gists{/gist_id}","starred_url":"https://api.github.com/users/steveyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveyen/subscriptions","organizations_url":"https://api.github.com/users/steveyen/orgs","repos_url":"https://api.github.com/users/steveyen/repos","events_url":"https://api.github.com/users/steveyen/events{/privacy}","received_events_url":"https://api.github.com/users/steveyen/received_events","type":"User","site_admin":false},"repo":{"id":48817605,"name":"bleve","full_name":"steveyen/bleve","owner":{"login":"steveyen","id":30640,"avatar_url":"https://avatars3.githubusercontent.com/u/30640?v=4","gravatar_id":"","url":"https://api.github.com/users/steveyen","html_url":"https://github.com/steveyen","followers_url":"https://api.github.com/users/steveyen/followers","following_url":"https://api.github.com/users/steveyen/following{/other_user}","gists_url":"https://api.github.com/users/steveyen/gists{/gist_id}","starred_url":"https://api.github.com/users/steveyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveyen/subscriptions","organizations_url":"https://api.github.com/users/steveyen/orgs","repos_url":"https://api.github.com/users/steveyen/repos","events_url":"https://api.github.com/users/steveyen/events{/privacy}","received_events_url":"https://api.github.com/users/steveyen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveyen/bleve","description":"A modern text indexing library for go","fork":true,"url":"https://api.github.com/repos/steveyen/bleve","forks_url":"https://api.github.com/repos/steveyen/bleve/forks","keys_url":"https://api.github.com/repos/steveyen/bleve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveyen/bleve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveyen/bleve/teams","hooks_url":"https://api.github.com/repos/steveyen/bleve/hooks","issue_events_url":"https://api.github.com/repos/steveyen/bleve/issues/events{/number}","events_url":"https://api.github.com/repos/steveyen/bleve/events","assignees_url":"https://api.github.com/repos/steveyen/bleve/assignees{/user}","branches_url":"https://api.github.com/repos/steveyen/bleve/branches{/branch}","tags_url":"https://api.github.com/repos/steveyen/bleve/tags","blobs_url":"https://api.github.com/repos/steveyen/bleve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveyen/bleve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveyen/bleve/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveyen/bleve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveyen/bleve/statuses/{sha}","languages_url":"https://api.github.com/repos/steveyen/bleve/languages","stargazers_url":"https://api.github.com/repos/steveyen/bleve/stargazers","contributors_url":"https://api.github.com/repos/steveyen/bleve/contributors","subscribers_url":"https://api.github.com/repos/steveyen/bleve/subscribers","subscription_url":"https://api.github.com/repos/steveyen/bleve/subscription","commits_url":"https://api.github.com/repos/steveyen/bleve/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveyen/bleve/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveyen/bleve/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveyen/bleve/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveyen/bleve/contents/{+path}","compare_url":"https://api.github.com/repos/steveyen/bleve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveyen/bleve/merges","archive_url":"https://api.github.com/repos/steveyen/bleve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveyen/bleve/downloads","issues_url":"https://api.github.com/repos/steveyen/bleve/issues{/number}","pulls_url":"https://api.github.com/repos/steveyen/bleve/pulls{/number}","milestones_url":"https://api.github.com/repos/steveyen/bleve/milestones{/number}","notifications_url":"https://api.github.com/repos/steveyen/bleve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveyen/bleve/labels{/name}","releases_url":"https://api.github.com/repos/steveyen/bleve/releases{/id}","deployments_url":"https://api.github.com/repos/steveyen/bleve/deployments","created_at":"2015-12-30T20:08:00Z","updated_at":"2016-03-11T23:49:05Z","pushed_at":"2018-04-20T18:53:42Z","git_url":"git://github.com/steveyen/bleve.git","ssh_url":"git@github.com:steveyen/bleve.git","clone_url":"https://github.com/steveyen/bleve.git","svn_url":"https://github.com/steveyen/bleve","homepage":null,"size":12163,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"blevesearch:master","ref":"master","sha":"5f4358c34a8e0446553e2a48fa4f11902d196929","user":{"login":"blevesearch","id":8562608,"avatar_url":"https://avatars2.githubusercontent.com/u/8562608?v=4","gravatar_id":"","url":"https://api.github.com/users/blevesearch","html_url":"https://github.com/blevesearch","followers_url":"https://api.github.com/users/blevesearch/followers","following_url":"https://api.github.com/users/blevesearch/following{/other_user}","gists_url":"https://api.github.com/users/blevesearch/gists{/gist_id}","starred_url":"https://api.github.com/users/blevesearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blevesearch/subscriptions","organizations_url":"https://api.github.com/users/blevesearch/orgs","repos_url":"https://api.github.com/users/blevesearch/repos","events_url":"https://api.github.com/users/blevesearch/events{/privacy}","received_events_url":"https://api.github.com/users/blevesearch/received_events","type":"Organization","site_admin":false},"repo":{"id":18893367,"name":"bleve","full_name":"blevesearch/bleve","owner":{"login":"blevesearch","id":8562608,"avatar_url":"https://avatars2.githubusercontent.com/u/8562608?v=4","gravatar_id":"","url":"https://api.github.com/users/blevesearch","html_url":"https://github.com/blevesearch","followers_url":"https://api.github.com/users/blevesearch/followers","following_url":"https://api.github.com/users/blevesearch/following{/other_user}","gists_url":"https://api.github.com/users/blevesearch/gists{/gist_id}","starred_url":"https://api.github.com/users/blevesearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blevesearch/subscriptions","organizations_url":"https://api.github.com/users/blevesearch/orgs","repos_url":"https://api.github.com/users/blevesearch/repos","events_url":"https://api.github.com/users/blevesearch/events{/privacy}","received_events_url":"https://api.github.com/users/blevesearch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blevesearch/bleve","description":"A modern text indexing library for go","fork":false,"url":"https://api.github.com/repos/blevesearch/bleve","forks_url":"https://api.github.com/repos/blevesearch/bleve/forks","keys_url":"https://api.github.com/repos/blevesearch/bleve/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blevesearch/bleve/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blevesearch/bleve/teams","hooks_url":"https://api.github.com/repos/blevesearch/bleve/hooks","issue_events_url":"https://api.github.com/repos/blevesearch/bleve/issues/events{/number}","events_url":"https://api.github.com/repos/blevesearch/bleve/events","assignees_url":"https://api.github.com/repos/blevesearch/bleve/assignees{/user}","branches_url":"https://api.github.com/repos/blevesearch/bleve/branches{/branch}","tags_url":"https://api.github.com/repos/blevesearch/bleve/tags","blobs_url":"https://api.github.com/repos/blevesearch/bleve/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blevesearch/bleve/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blevesearch/bleve/git/refs{/sha}","trees_url":"https://api.github.com/repos/blevesearch/bleve/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blevesearch/bleve/statuses/{sha}","languages_url":"https://api.github.com/repos/blevesearch/bleve/languages","stargazers_url":"https://api.github.com/repos/blevesearch/bleve/stargazers","contributors_url":"https://api.github.com/repos/blevesearch/bleve/contributors","subscribers_url":"https://api.github.com/repos/blevesearch/bleve/subscribers","subscription_url":"https://api.github.com/repos/blevesearch/bleve/subscription","commits_url":"https://api.github.com/repos/blevesearch/bleve/commits{/sha}","git_commits_url":"https://api.github.com/repos/blevesearch/bleve/git/commits{/sha}","comments_url":"https://api.github.com/repos/blevesearch/bleve/comments{/number}","issue_comment_url":"https://api.github.com/repos/blevesearch/bleve/issues/comments{/number}","contents_url":"https://api.github.com/repos/blevesearch/bleve/contents/{+path}","compare_url":"https://api.github.com/repos/blevesearch/bleve/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blevesearch/bleve/merges","archive_url":"https://api.github.com/repos/blevesearch/bleve/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blevesearch/bleve/downloads","issues_url":"https://api.github.com/repos/blevesearch/bleve/issues{/number}","pulls_url":"https://api.github.com/repos/blevesearch/bleve/pulls{/number}","milestones_url":"https://api.github.com/repos/blevesearch/bleve/milestones{/number}","notifications_url":"https://api.github.com/repos/blevesearch/bleve/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blevesearch/bleve/labels{/name}","releases_url":"https://api.github.com/repos/blevesearch/bleve/releases{/id}","deployments_url":"https://api.github.com/repos/blevesearch/bleve/deployments","created_at":"2014-04-17T21:02:18Z","updated_at":"2018-04-19T21:25:01Z","pushed_at":"2018-04-20T18:54:50Z","git_url":"git://github.com/blevesearch/bleve.git","ssh_url":"git@github.com:blevesearch/bleve.git","clone_url":"https://github.com/blevesearch/bleve.git","svn_url":"https://github.com/blevesearch/bleve","homepage":null,"size":12132,"stargazers_count":4276,"watchers_count":4276,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":343,"mirror_url":null,"archived":false,"open_issues_count":118,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":343,"open_issues":118,"watchers":4276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/904"},"html":{"href":"https://github.com/blevesearch/bleve/pull/904"},"issue":{"href":"https://api.github.com/repos/blevesearch/bleve/issues/904"},"comments":{"href":"https://api.github.com/repos/blevesearch/bleve/issues/904/comments"},"review_comments":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/904/comments"},"review_comment":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blevesearch/bleve/pulls/904/commits"},"statuses":{"href":"https://api.github.com/repos/blevesearch/bleve/statuses/4bf27cb44d758427a24a9851afdd78aa60820264"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"abhinavdangeti"}}