{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8694","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8694/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8694/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8694/events","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/8694","id":385386896,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzY5NjM3","number":8694,"title":"Issue/8661 crash notifications settings","user":{"login":"theck13","id":3827611,"node_id":"MDQ6VXNlcjM4Mjc2MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3827611?v=4","gravatar_id":"","url":"https://api.github.com/users/theck13","html_url":"https://github.com/theck13","followers_url":"https://api.github.com/users/theck13/followers","following_url":"https://api.github.com/users/theck13/following{/other_user}","gists_url":"https://api.github.com/users/theck13/gists{/gist_id}","starred_url":"https://api.github.com/users/theck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theck13/subscriptions","organizations_url":"https://api.github.com/users/theck13/orgs","repos_url":"https://api.github.com/users/theck13/repos","events_url":"https://api.github.com/users/theck13/events{/privacy}","received_events_url":"https://api.github.com/users/theck13/received_events","type":"User","site_admin":false},"labels":[{"id":90791782,"node_id":"MDU6TGFiZWw5MDc5MTc4Mg==","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Notifications","name":"Notifications","color":"006b75","default":false},{"id":88251544,"node_id":"MDU6TGFiZWw4ODI1MTU0NA==","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Reader","name":"Reader","color":"006b75","default":false},{"id":349463323,"node_id":"MDU6TGFiZWwzNDk0NjMzMjM=","url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/[Type]%20Crash","name":"[Type] Crash","color":"000000","default":false}],"state":"open","locked":false,"assignee":{"login":"khaykov","id":728822,"node_id":"MDQ6VXNlcjcyODgyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/728822?v=4","gravatar_id":"","url":"https://api.github.com/users/khaykov","html_url":"https://github.com/khaykov","followers_url":"https://api.github.com/users/khaykov/followers","following_url":"https://api.github.com/users/khaykov/following{/other_user}","gists_url":"https://api.github.com/users/khaykov/gists{/gist_id}","starred_url":"https://api.github.com/users/khaykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaykov/subscriptions","organizations_url":"https://api.github.com/users/khaykov/orgs","repos_url":"https://api.github.com/users/khaykov/repos","events_url":"https://api.github.com/users/khaykov/events{/privacy}","received_events_url":"https://api.github.com/users/khaykov/received_events","type":"User","site_admin":false},"assignees":[{"login":"khaykov","id":728822,"node_id":"MDQ6VXNlcjcyODgyMg==","avatar_url":"https://avatars1.githubusercontent.com/u/728822?v=4","gravatar_id":"","url":"https://api.github.com/users/khaykov","html_url":"https://github.com/khaykov","followers_url":"https://api.github.com/users/khaykov/followers","following_url":"https://api.github.com/users/khaykov/following{/other_user}","gists_url":"https://api.github.com/users/khaykov/gists{/gist_id}","starred_url":"https://api.github.com/users/khaykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khaykov/subscriptions","organizations_url":"https://api.github.com/users/khaykov/orgs","repos_url":"https://api.github.com/users/khaykov/repos","events_url":"https://api.github.com/users/khaykov/events{/privacy}","received_events_url":"https://api.github.com/users/khaykov/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/134","html_url":"https://github.com/wordpress-mobile/WordPress-Android/milestone/134","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/milestones/134/labels","id":3772070,"node_id":"MDk6TWlsZXN0b25lMzc3MjA3MA==","number":134,"title":"11.4","description":"Code freeze: Dec 3rd, 2018 App Store submission: Dec 17th, 2018 Release: Dec 17th, 2018","creator":{"login":"loremattei","id":4836764,"node_id":"MDQ6VXNlcjQ4MzY3NjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4836764?v=4","gravatar_id":"","url":"https://api.github.com/users/loremattei","html_url":"https://github.com/loremattei","followers_url":"https://api.github.com/users/loremattei/followers","following_url":"https://api.github.com/users/loremattei/following{/other_user}","gists_url":"https://api.github.com/users/loremattei/gists{/gist_id}","starred_url":"https://api.github.com/users/loremattei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loremattei/subscriptions","organizations_url":"https://api.github.com/users/loremattei/orgs","repos_url":"https://api.github.com/users/loremattei/repos","events_url":"https://api.github.com/users/loremattei/events{/privacy}","received_events_url":"https://api.github.com/users/loremattei/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":23,"state":"open","created_at":"2018-10-26T16:46:54Z","updated_at":"2018-11-30T16:41:20Z","due_on":"2018-12-03T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-11-28T17:50:08Z","updated_at":"2018-12-02T23:44:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/8694","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/8694","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/8694.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/8694.patch"},"body":"### Fix\r\nAdd excluding feeds from the ***Followed Sites*** list on the ***Notification Settings*** screen and including the ***Turn on site notifications*** or ***Turn off site notifications*** option only for non-feed posts in the ***Reader*** to avoid the `NumberFormatException` crash described in https://github.com/wordpress-mobile/WordPress-Android/issues/8661.\r\n\r\nSince this crash is affecting a small percentage of users, there doesn't need to be a hotfix and these changes can be included in the next release.\r\n\r\n### Test\r\nA feed must be followed in order to test these changes.  In order to follow a feed from the web, go to https://wordpress.com/following/manage, enter ***nytimes.com*** into the ***Search or enter URL to follow...*** field, and click the ***Follow nytimes.com*** button.\r\n\r\n#### Notification Settings\r\n1. Go to ***Me*** tab.\r\n2. Tap ***Notification Settings*** item.\r\n3. Notice ***Followed Sites*** section.\r\n4. Notice feed is not shown in ***Followed Sites*** list.\r\n5. Tap ***Search*** action in toolbar.\r\n6. Notice feed is not shown in ***Followed Sites*** list.\r\n7. Enter name or URL of feed.\r\n8. Notice feed is not shown in ***Followed Sites*** list.\r\n\r\n#### Reader\r\n1. Go to ***Reader*** tab.\r\n2. Tap overflow menu button of followed site without notifications.\r\n3. Notice ***Turn on site notifications*** item.\r\n4. Tap overflow menu button of followed site with notifications.\r\n5. Notice ***Turn off site notifications*** item.\r\n6. Tap overflow menu button of followed feed.\r\n7. Notice neither ***Turn on site notifications*** nor ***Turn off site notifications*** item.\r\n\r\n### Review\r\nOnly one developer is required to review these changes, but anyone can perform the review."},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments/443553696","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/8694#issuecomment-443553696","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/8694","id":443553696,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzU1MzY5Ng==","user":{"login":"theck13","id":3827611,"node_id":"MDQ6VXNlcjM4Mjc2MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/3827611?v=4","gravatar_id":"","url":"https://api.github.com/users/theck13","html_url":"https://github.com/theck13","followers_url":"https://api.github.com/users/theck13/followers","following_url":"https://api.github.com/users/theck13/following{/other_user}","gists_url":"https://api.github.com/users/theck13/gists{/gist_id}","starred_url":"https://api.github.com/users/theck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theck13/subscriptions","organizations_url":"https://api.github.com/users/theck13/orgs","repos_url":"https://api.github.com/users/theck13/repos","events_url":"https://api.github.com/users/theck13/events{/privacy}","received_events_url":"https://api.github.com/users/theck13/received_events","type":"User","site_admin":false},"created_at":"2018-12-02T23:44:57Z","updated_at":"2018-12-02T23:44:57Z","author_association":"CONTRIBUTOR","body":"You might not have enough sites or followed enough sites to show the ***Search*** action.  The [`updateSearchMenuVisibility`](https://github.com/wordpress-mobile/WordPress-Android/blob/3b57dc1d77064120192ffbb5e048648d57684103/WordPress/src/main/java/org/wordpress/android/ui/prefs/notifications/NotificationsSettingsFragment.java#L670-L676) handles the visibility of that action.  Either your sites or follow sites must be more than [`SITE_SEARCH_VISIBILITY_COUNT`](https://github.com/wordpress-mobile/WordPress-Android/blob/3b57dc1d77064120192ffbb5e048648d57684103/WordPress/src/main/java/org/wordpress/android/ui/prefs/notifications/NotificationsSettingsFragment.java#L81), which is `15`, for the ***Search*** action to be visible."}}
{"actor":{"display_login":"theck13"}}