{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/10361","repository_url":"https://api.github.com/repos/Automattic/jetpack","labels_url":"https://api.github.com/repos/Automattic/jetpack/issues/10361/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/jetpack/issues/10361/comments","events_url":"https://api.github.com/repos/Automattic/jetpack/issues/10361/events","html_url":"https://github.com/Automattic/jetpack/pull/10361","id":372090312,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MzkwMjc5","number":10361,"title":"Map Block Dependencies, Second Try","user":{"login":"jeffersonrabb","id":1477002,"node_id":"MDQ6VXNlcjE0NzcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1477002?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffersonrabb","html_url":"https://github.com/jeffersonrabb","followers_url":"https://api.github.com/users/jeffersonrabb/followers","following_url":"https://api.github.com/users/jeffersonrabb/following{/other_user}","gists_url":"https://api.github.com/users/jeffersonrabb/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffersonrabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffersonrabb/subscriptions","organizations_url":"https://api.github.com/users/jeffersonrabb/orgs","repos_url":"https://api.github.com/users/jeffersonrabb/repos","events_url":"https://api.github.com/users/jeffersonrabb/events{/privacy}","received_events_url":"https://api.github.com/users/jeffersonrabb/received_events","type":"User","site_admin":false},"labels":[{"id":846192489,"node_id":"MDU6TGFiZWw4NDYxOTI0ODk=","url":"https://api.github.com/repos/Automattic/jetpack/labels/Gutenberg","name":"Gutenberg","color":"d4c5f9","default":false},{"id":199076921,"node_id":"MDU6TGFiZWwxOTkwNzY5MjE=","url":"https://api.github.com/repos/Automattic/jetpack/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false},{"id":70896534,"node_id":"MDU6TGFiZWw3MDg5NjUzNA==","url":"https://api.github.com/repos/Automattic/jetpack/labels/[Type]%20Enhancement","name":"[Type] Enhancement","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":{"login":"jeffersonrabb","id":1477002,"node_id":"MDQ6VXNlcjE0NzcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1477002?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffersonrabb","html_url":"https://github.com/jeffersonrabb","followers_url":"https://api.github.com/users/jeffersonrabb/followers","following_url":"https://api.github.com/users/jeffersonrabb/following{/other_user}","gists_url":"https://api.github.com/users/jeffersonrabb/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffersonrabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffersonrabb/subscriptions","organizations_url":"https://api.github.com/users/jeffersonrabb/orgs","repos_url":"https://api.github.com/users/jeffersonrabb/repos","events_url":"https://api.github.com/users/jeffersonrabb/events{/privacy}","received_events_url":"https://api.github.com/users/jeffersonrabb/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeffersonrabb","id":1477002,"node_id":"MDQ6VXNlcjE0NzcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1477002?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffersonrabb","html_url":"https://github.com/jeffersonrabb","followers_url":"https://api.github.com/users/jeffersonrabb/followers","following_url":"https://api.github.com/users/jeffersonrabb/following{/other_user}","gists_url":"https://api.github.com/users/jeffersonrabb/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffersonrabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffersonrabb/subscriptions","organizations_url":"https://api.github.com/users/jeffersonrabb/orgs","repos_url":"https://api.github.com/users/jeffersonrabb/repos","events_url":"https://api.github.com/users/jeffersonrabb/events{/privacy}","received_events_url":"https://api.github.com/users/jeffersonrabb/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/jetpack/milestones/112","html_url":"https://github.com/Automattic/jetpack/milestone/112","labels_url":"https://api.github.com/repos/Automattic/jetpack/milestones/112/labels","id":3684249,"node_id":"MDk6TWlsZXN0b25lMzY4NDI0OQ==","number":112,"title":"6.7","description":"","creator":{"login":"kraftbj","id":88897,"node_id":"MDQ6VXNlcjg4ODk3","avatar_url":"https://avatars0.githubusercontent.com/u/88897?v=4","gravatar_id":"","url":"https://api.github.com/users/kraftbj","html_url":"https://github.com/kraftbj","followers_url":"https://api.github.com/users/kraftbj/followers","following_url":"https://api.github.com/users/kraftbj/following{/other_user}","gists_url":"https://api.github.com/users/kraftbj/gists{/gist_id}","starred_url":"https://api.github.com/users/kraftbj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kraftbj/subscriptions","organizations_url":"https://api.github.com/users/kraftbj/orgs","repos_url":"https://api.github.com/users/kraftbj/repos","events_url":"https://api.github.com/users/kraftbj/events{/privacy}","received_events_url":"https://api.github.com/users/kraftbj/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":59,"state":"open","created_at":"2018-09-24T19:48:36Z","updated_at":"2018-10-19T19:46:31Z","due_on":"2018-11-06T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-10-19T19:39:34Z","updated_at":"2018-10-19T19:52:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Automattic/jetpack/pulls/10361","html_url":"https://github.com/Automattic/jetpack/pull/10361","diff_url":"https://github.com/Automattic/jetpack/pull/10361.diff","patch_url":"https://github.com/Automattic/jetpack/pull/10361.patch"},"body":"This PR replaces https://github.com/Automattic/jetpack/pull/10319. It simply enqueues Localization and `wp-element` scripts on the view side, which enables Map block's React component to render.\r\n\r\n*\r\n\r\n#### Testing instructions:\r\n\r\nSee https://github.com/Automattic/wp-calypso/pull/27836"},"comment":{"url":"https://api.github.com/repos/Automattic/jetpack/issues/comments/431480325","html_url":"https://github.com/Automattic/jetpack/pull/10361#issuecomment-431480325","issue_url":"https://api.github.com/repos/Automattic/jetpack/issues/10361","id":431480325,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTQ4MDMyNQ==","user":{"login":"jeffersonrabb","id":1477002,"node_id":"MDQ6VXNlcjE0NzcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1477002?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffersonrabb","html_url":"https://github.com/jeffersonrabb","followers_url":"https://api.github.com/users/jeffersonrabb/followers","following_url":"https://api.github.com/users/jeffersonrabb/following{/other_user}","gists_url":"https://api.github.com/users/jeffersonrabb/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffersonrabb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffersonrabb/subscriptions","organizations_url":"https://api.github.com/users/jeffersonrabb/orgs","repos_url":"https://api.github.com/users/jeffersonrabb/repos","events_url":"https://api.github.com/users/jeffersonrabb/events{/privacy}","received_events_url":"https://api.github.com/users/jeffersonrabb/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T19:52:48Z","updated_at":"2018-10-19T19:52:48Z","author_association":"NONE","body":"> This works for me, although given the low number of dependencies, I think you could just add them to the wp_enqueue_script as is, like we do for the other call here:\r\n\r\nSure I'd be happy to simplify. I made the separate array only thinking that one day we might want to dynamically build the dependencies list based on which Gutenberg blocks are enabled, but that's pretty theoretical and unnecessary. I'll make the change momentarily."}}
{"actor":{"display_login":"jeffersonrabb"}}