{"action":"created","issue":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/894","repository_url":"https://api.github.com/repos/mattermost/mattermost-webapp","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/894/labels{/name}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/894/comments","events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/894/events","html_url":"https://github.com/mattermost/mattermost-webapp/pull/894","id":302261041,"number":894,"title":"GH-8402: Invalid latex code, break the entire app (Fixed)","user":{"login":"jespino","id":290303,"avatar_url":"https://avatars0.githubusercontent.com/u/290303?v=4","gravatar_id":"","url":"https://api.github.com/users/jespino","html_url":"https://github.com/jespino","followers_url":"https://api.github.com/users/jespino/followers","following_url":"https://api.github.com/users/jespino/following{/other_user}","gists_url":"https://api.github.com/users/jespino/gists{/gist_id}","starred_url":"https://api.github.com/users/jespino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jespino/subscriptions","organizations_url":"https://api.github.com/users/jespino/orgs","repos_url":"https://api.github.com/users/jespino/repos","events_url":"https://api.github.com/users/jespino/events{/privacy}","received_events_url":"https://api.github.com/users/jespino/received_events","type":"User","site_admin":false},"labels":[{"id":685999052,"url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/1:%20PM%20Review","name":"1: PM Review","color":"006b75","default":false},{"id":685999255,"url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-05T11:16:16Z","updated_at":"2018-03-06T11:07:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/894","html_url":"https://github.com/mattermost/mattermost-webapp/pull/894","diff_url":"https://github.com/mattermost/mattermost-webapp/pull/894.diff","patch_url":"https://github.com/mattermost/mattermost-webapp/pull/894.patch"},"body":"#### Summary\r\nWhen you introduce invalid latex code in mattermost, the Katex library throws\r\nan exception, so the entire webapp is broken. This PR manage that. The expected\r\nbehavior is that `throwOnError = false` prevent the exceptions, but it only\r\nworks for certain type of error managed by Katex, other parse errors are thrown\r\nanyway.\r\n\r\n#### Ticket Link\r\nGH ticket mattermost/mattermost-server#8402\r\n[MM-9718](https://mattermost.atlassian.net/browse/MM-9718)\r\n\r\n#### Checklist\r\n- [x] Ran `make check-style` to check for style errors (required for all pull requests)\r\n- [x] Ran `make test` to ensure unit and component tests passed\r\n- [X] Includes text changes and localization file ([.../i18n/en.json](https://github.com/mattermost/mattermost-webapp/blob/master/i18n/en.json)) updates"},"comment":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/comments/370746607","html_url":"https://github.com/mattermost/mattermost-webapp/pull/894#issuecomment-370746607","issue_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/894","id":370746607,"user":{"login":"jespino","id":290303,"avatar_url":"https://avatars0.githubusercontent.com/u/290303?v=4","gravatar_id":"","url":"https://api.github.com/users/jespino","html_url":"https://github.com/jespino","followers_url":"https://api.github.com/users/jespino/followers","following_url":"https://api.github.com/users/jespino/following{/other_user}","gists_url":"https://api.github.com/users/jespino/gists{/gist_id}","starred_url":"https://api.github.com/users/jespino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jespino/subscriptions","organizations_url":"https://api.github.com/users/jespino/orgs","repos_url":"https://api.github.com/users/jespino/repos","events_url":"https://api.github.com/users/jespino/events{/privacy}","received_events_url":"https://api.github.com/users/jespino/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T11:07:56Z","updated_at":"2018-03-06T11:07:56Z","author_association":"CONTRIBUTOR","body":"@jasonblais no problem, I add a new PR :)"}}
{"actor":{"display_login":"jespino"}}