{"action":"created","comment":{"url":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/comments/234567359","pull_request_review_id":176232028,"id":234567359,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDU2NzM1OQ==","diff_hunk":"@@ -73,6 +95,8 @@ export function publishScoped() {\n       publishToRegistry(pkg, 'http://npm.dev.wixpress.com/');\n       if (!isScoped(bkp.name)) {\n         publishToRegistry(pkg, 'https://registry.npmjs.org/');\n+      } else {\n+        publishUnscopedPackage(bkp);","path":"src/publish-scoped.js","position":41,"original_position":41,"commit_id":"9ba9ea45f9f5a3bad9971b68cb1a8d925d16c944","original_commit_id":"9ba9ea45f9f5a3bad9971b68cb1a8d925d16c944","user":{"login":"mastertheblaster","id":10008149,"node_id":"MDQ6VXNlcjEwMDA4MTQ5","avatar_url":"https://avatars1.githubusercontent.com/u/10008149?v=4","gravatar_id":"","url":"https://api.github.com/users/mastertheblaster","html_url":"https://github.com/mastertheblaster","followers_url":"https://api.github.com/users/mastertheblaster/followers","following_url":"https://api.github.com/users/mastertheblaster/following{/other_user}","gists_url":"https://api.github.com/users/mastertheblaster/gists{/gist_id}","starred_url":"https://api.github.com/users/mastertheblaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mastertheblaster/subscriptions","organizations_url":"https://api.github.com/users/mastertheblaster/orgs","repos_url":"https://api.github.com/users/mastertheblaster/repos","events_url":"https://api.github.com/users/mastertheblaster/events{/privacy}","received_events_url":"https://api.github.com/users/mastertheblaster/received_events","type":"User","site_admin":false},"body":"Maybe you would also like to update the package-lock files if they do exist.\r\n`updateLockFiles(...name...)`","created_at":"2018-11-19T10:33:48Z","updated_at":"2018-11-19T10:33:48Z","html_url":"https://github.com/wix/npm-ci-scripts/pull/11#discussion_r234567359","pull_request_url":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/11","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/comments/234567359"},"html":{"href":"https://github.com/wix/npm-ci-scripts/pull/11#discussion_r234567359"},"pull_request":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/11","id":231779549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzc5NTQ5","html_url":"https://github.com/wix/npm-ci-scripts/pull/11","diff_url":"https://github.com/wix/npm-ci-scripts/pull/11.diff","patch_url":"https://github.com/wix/npm-ci-scripts/pull/11.patch","issue_url":"https://api.github.com/repos/wix/npm-ci-scripts/issues/11","number":11,"state":"open","locked":false,"title":"Try to publish unscoped packages too","user":{"login":"Schniz","id":2054772,"node_id":"MDQ6VXNlcjIwNTQ3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2054772?v=4","gravatar_id":"","url":"https://api.github.com/users/Schniz","html_url":"https://github.com/Schniz","followers_url":"https://api.github.com/users/Schniz/followers","following_url":"https://api.github.com/users/Schniz/following{/other_user}","gists_url":"https://api.github.com/users/Schniz/gists{/gist_id}","starred_url":"https://api.github.com/users/Schniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schniz/subscriptions","organizations_url":"https://api.github.com/users/Schniz/orgs","repos_url":"https://api.github.com/users/Schniz/repos","events_url":"https://api.github.com/users/Schniz/events{/privacy}","received_events_url":"https://api.github.com/users/Schniz/received_events","type":"User","site_admin":false},"body":"This is a part of the movement towards scoped packages in all of Wix, to support a gradual conversion of packages.\r\ntl;dr: right now, when we publish `package-a`, we also publish `@wix/package-a`. Let's do the opposite too: `@wix/package-a -> package-a`. We should be careful, so `@wix/draft-js` won't be published internally as `draft-js`.\r\nThis way, we could convert infra packages first.\r\n\r\n## 🌮 Current Behavior\r\n\r\n* package name (in `package.json`) is `package-a`\r\n  * Wix internal registry will publish:\r\n    * `package-a`\r\n    * `@wix/package-a`\r\n  * Public npm registry will publish:\r\n    * `@wix/package-a`\r\n* package name (in `package.json`) is `@wix/package-a`\r\n  * Wix internal registry will publish:\r\n    * `@wix/package-a`\r\n  * Public npm registry will publish:\r\n    * `@wix/package-a`\r\n\r\n## 🤝 New, expected behavior:\r\n\r\n* package name (in `package.json`) is `package-a`\r\n  * *stays the same as before*\r\n* package name (in `package.json`) is `@wix/package-a`\r\n  * Wix internal registry will publish:\r\n    * `package-a`\r\n    * `@wix/package-a`\r\n  * Public npm registry will publish:\r\n    * `@wix/package-a`\r\n* a package that doesn't have wix internal registry as the publish config registry (like `@wix/draft-js`, `yoshi`):\r\n  * Wix internal registry will publish:\r\n    * `@wix/draft-js`\r\n  * Public npm registry will publish:\r\n    * `@wix/draft-js`","created_at":"2018-11-18T10:10:34Z","updated_at":"2018-11-19T10:33:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4723834ffd9f7fbb2fcd6e85488084dc4b496061","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/11/commits","review_comments_url":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/11/comments","review_comment_url":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wix/npm-ci-scripts/issues/11/comments","statuses_url":"https://api.github.com/repos/wix/npm-ci-scripts/statuses/9ba9ea45f9f5a3bad9971b68cb1a8d925d16c944","head":{"label":"Schniz:publish-unscoped-packages","ref":"publish-unscoped-packages","sha":"9ba9ea45f9f5a3bad9971b68cb1a8d925d16c944","user":{"login":"Schniz","id":2054772,"node_id":"MDQ6VXNlcjIwNTQ3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2054772?v=4","gravatar_id":"","url":"https://api.github.com/users/Schniz","html_url":"https://github.com/Schniz","followers_url":"https://api.github.com/users/Schniz/followers","following_url":"https://api.github.com/users/Schniz/following{/other_user}","gists_url":"https://api.github.com/users/Schniz/gists{/gist_id}","starred_url":"https://api.github.com/users/Schniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schniz/subscriptions","organizations_url":"https://api.github.com/users/Schniz/orgs","repos_url":"https://api.github.com/users/Schniz/repos","events_url":"https://api.github.com/users/Schniz/events{/privacy}","received_events_url":"https://api.github.com/users/Schniz/received_events","type":"User","site_admin":false},"repo":{"id":158070081,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgwNzAwODE=","name":"npm-ci-scripts","full_name":"Schniz/npm-ci-scripts","private":false,"owner":{"login":"Schniz","id":2054772,"node_id":"MDQ6VXNlcjIwNTQ3NzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2054772?v=4","gravatar_id":"","url":"https://api.github.com/users/Schniz","html_url":"https://github.com/Schniz","followers_url":"https://api.github.com/users/Schniz/followers","following_url":"https://api.github.com/users/Schniz/following{/other_user}","gists_url":"https://api.github.com/users/Schniz/gists{/gist_id}","starred_url":"https://api.github.com/users/Schniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Schniz/subscriptions","organizations_url":"https://api.github.com/users/Schniz/orgs","repos_url":"https://api.github.com/users/Schniz/repos","events_url":"https://api.github.com/users/Schniz/events{/privacy}","received_events_url":"https://api.github.com/users/Schniz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Schniz/npm-ci-scripts","description":null,"fork":true,"url":"https://api.github.com/repos/Schniz/npm-ci-scripts","forks_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/forks","keys_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/teams","hooks_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/hooks","issue_events_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/events","assignees_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/tags","blobs_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/languages","stargazers_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/stargazers","contributors_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/contributors","subscribers_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/subscribers","subscription_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/subscription","commits_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/merges","archive_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/downloads","issues_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/labels{/name}","releases_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/Schniz/npm-ci-scripts/deployments","created_at":"2018-11-18T09:59:46Z","updated_at":"2018-11-18T09:59:48Z","pushed_at":"2018-11-18T10:00:12Z","git_url":"git://github.com/Schniz/npm-ci-scripts.git","ssh_url":"git@github.com:Schniz/npm-ci-scripts.git","clone_url":"https://github.com/Schniz/npm-ci-scripts.git","svn_url":"https://github.com/Schniz/npm-ci-scripts","homepage":null,"size":162,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wix:master","ref":"master","sha":"fb72b809f05ce0f105f1ed711f45833558bf5b80","user":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"repo":{"id":131441068,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE0NDEwNjg=","name":"npm-ci-scripts","full_name":"wix/npm-ci-scripts","private":false,"owner":{"login":"wix","id":686511,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/686511?v=4","gravatar_id":"","url":"https://api.github.com/users/wix","html_url":"https://github.com/wix","followers_url":"https://api.github.com/users/wix/followers","following_url":"https://api.github.com/users/wix/following{/other_user}","gists_url":"https://api.github.com/users/wix/gists{/gist_id}","starred_url":"https://api.github.com/users/wix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wix/subscriptions","organizations_url":"https://api.github.com/users/wix/orgs","repos_url":"https://api.github.com/users/wix/repos","events_url":"https://api.github.com/users/wix/events{/privacy}","received_events_url":"https://api.github.com/users/wix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wix/npm-ci-scripts","description":null,"fork":false,"url":"https://api.github.com/repos/wix/npm-ci-scripts","forks_url":"https://api.github.com/repos/wix/npm-ci-scripts/forks","keys_url":"https://api.github.com/repos/wix/npm-ci-scripts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wix/npm-ci-scripts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wix/npm-ci-scripts/teams","hooks_url":"https://api.github.com/repos/wix/npm-ci-scripts/hooks","issue_events_url":"https://api.github.com/repos/wix/npm-ci-scripts/issues/events{/number}","events_url":"https://api.github.com/repos/wix/npm-ci-scripts/events","assignees_url":"https://api.github.com/repos/wix/npm-ci-scripts/assignees{/user}","branches_url":"https://api.github.com/repos/wix/npm-ci-scripts/branches{/branch}","tags_url":"https://api.github.com/repos/wix/npm-ci-scripts/tags","blobs_url":"https://api.github.com/repos/wix/npm-ci-scripts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wix/npm-ci-scripts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wix/npm-ci-scripts/git/refs{/sha}","trees_url":"https://api.github.com/repos/wix/npm-ci-scripts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wix/npm-ci-scripts/statuses/{sha}","languages_url":"https://api.github.com/repos/wix/npm-ci-scripts/languages","stargazers_url":"https://api.github.com/repos/wix/npm-ci-scripts/stargazers","contributors_url":"https://api.github.com/repos/wix/npm-ci-scripts/contributors","subscribers_url":"https://api.github.com/repos/wix/npm-ci-scripts/subscribers","subscription_url":"https://api.github.com/repos/wix/npm-ci-scripts/subscription","commits_url":"https://api.github.com/repos/wix/npm-ci-scripts/commits{/sha}","git_commits_url":"https://api.github.com/repos/wix/npm-ci-scripts/git/commits{/sha}","comments_url":"https://api.github.com/repos/wix/npm-ci-scripts/comments{/number}","issue_comment_url":"https://api.github.com/repos/wix/npm-ci-scripts/issues/comments{/number}","contents_url":"https://api.github.com/repos/wix/npm-ci-scripts/contents/{+path}","compare_url":"https://api.github.com/repos/wix/npm-ci-scripts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wix/npm-ci-scripts/merges","archive_url":"https://api.github.com/repos/wix/npm-ci-scripts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wix/npm-ci-scripts/downloads","issues_url":"https://api.github.com/repos/wix/npm-ci-scripts/issues{/number}","pulls_url":"https://api.github.com/repos/wix/npm-ci-scripts/pulls{/number}","milestones_url":"https://api.github.com/repos/wix/npm-ci-scripts/milestones{/number}","notifications_url":"https://api.github.com/repos/wix/npm-ci-scripts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wix/npm-ci-scripts/labels{/name}","releases_url":"https://api.github.com/repos/wix/npm-ci-scripts/releases{/id}","deployments_url":"https://api.github.com/repos/wix/npm-ci-scripts/deployments","created_at":"2018-04-28T20:14:05Z","updated_at":"2018-11-16T11:36:58Z","pushed_at":"2018-11-18T10:10:35Z","git_url":"git://github.com/wix/npm-ci-scripts.git","ssh_url":"git@github.com:wix/npm-ci-scripts.git","clone_url":"https://github.com/wix/npm-ci-scripts.git","svn_url":"https://github.com/wix/npm-ci-scripts","homepage":null,"size":161,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/11"},"html":{"href":"https://github.com/wix/npm-ci-scripts/pull/11"},"issue":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/issues/11"},"comments":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/wix/npm-ci-scripts/statuses/9ba9ea45f9f5a3bad9971b68cb1a8d925d16c944"}},"author_association":"NONE"}}
{"actor":{"display_login":"mastertheblaster"}}