{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/2080","repository_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio","labels_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/2080/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/2080/comments","events_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/2080/events","html_url":"https://github.com/Microsoft/WindowsTemplateStudio/issues/2080","id":306678392,"number":2080,"title":"Using datatemplate with NavigationView breaks expected navigation.","user":{"login":"DLBrowne","id":10768448,"avatar_url":"https://avatars1.githubusercontent.com/u/10768448?v=4","gravatar_id":"","url":"https://api.github.com/users/DLBrowne","html_url":"https://github.com/DLBrowne","followers_url":"https://api.github.com/users/DLBrowne/followers","following_url":"https://api.github.com/users/DLBrowne/following{/other_user}","gists_url":"https://api.github.com/users/DLBrowne/gists{/gist_id}","starred_url":"https://api.github.com/users/DLBrowne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DLBrowne/subscriptions","organizations_url":"https://api.github.com/users/DLBrowne/orgs","repos_url":"https://api.github.com/users/DLBrowne/repos","events_url":"https://api.github.com/users/DLBrowne/events{/privacy}","received_events_url":"https://api.github.com/users/DLBrowne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-19T23:47:31Z","updated_at":"2018-03-20T14:26:17Z","closed_at":null,"author_association":"NONE","body":"## For new Features:\r\n\r\n* **Overview:** What you'd think should be added with scenarios\r\n* **Links:**\r\n\r\n## For Bugs:\r\nReplacing Hamburger menu with Navigation View using data templates breaks NavigationViewItem. \r\n\r\n### Repro steps\r\n\r\nWhat did you do? How can someone else reproduce this?\r\nReplaced template generated Hamburger Menu with Navigation View:\r\n\r\n```\r\n<Page.Resources>\r\n        <DataTemplate x:Key=\"NavigationMenuItemDataTemplate\" x:DataType=\"vm:ShellNavigationItem\">\r\n            <NavigationViewItem Content=\"{x:Bind Path=Label}\"\r\n                                Icon=\"{x:Bind Path=Icon}\"\r\n                                ToolTipService.ToolTip=\"{x:Bind Path=Label}\">\r\n            </NavigationViewItem>\r\n        </DataTemplate>\r\n</Page.Resources>\r\n<NavigationView x:Name=\"NavigationMenu\"\r\n                    MenuItemTemplate=\"{StaticResource NavigationMenuItemDataTemplate}\"\r\n                    MenuItemsSource=\"{x:Bind Path=ViewModel.PrimaryItems}\"\r\n                    SelectedItem=\"{x:Bind ViewModel.Selected, Mode=OneWay}\"\r\n                    IsPaneOpen=\"{x:Bind Mode=TwoWay, Path=ViewModel.IsPaneOpen}\"\r\n                    AlwaysShowHeader=\"False\"\r\n                    OpenPaneLength=\"130\">\r\n        <i:Interaction.Behaviors>\r\n            <ic:EventTriggerBehavior EventName=\"ItemInvoked\">\r\n                <ic:InvokeCommandAction Command=\"{x:Bind ViewModel.ItemSelectedCommand}\" />\r\n            </ic:EventTriggerBehavior>\r\n        </i:Interaction.Behaviors>\r\n        <Grid Background=\"{ThemeResource SystemControlBackgroundAltHighBrush}\">\r\n            <Frame x:Name=\"shellFrame\"/>\r\n        </Grid>\r\n        <VisualStateManager.VisualStateGroups>\r\n            <VisualStateGroup x:Name=\"WindowStates\">\r\n                <i:Interaction.Behaviors>\r\n                    <ic:EventTriggerBehavior EventName=\"CurrentStateChanged\">\r\n                        <ic:InvokeCommandAction Command=\"{x:Bind ViewModel.StateChangedCommand}\"/>\r\n                    </ic:EventTriggerBehavior>\r\n                </i:Interaction.Behaviors>\r\n                <VisualState x:Name=\"PanoramicState\">\r\n                    <VisualState.StateTriggers>\r\n                        <AdaptiveTrigger MinWindowWidth=\"1024\"/>\r\n                    </VisualState.StateTriggers>\r\n                </VisualState>\r\n                <VisualState x:Name=\"WideState\">\r\n                    <VisualState.StateTriggers>\r\n                        <AdaptiveTrigger MinWindowWidth=\"640\"/>\r\n                    </VisualState.StateTriggers>\r\n                </VisualState>\r\n                <VisualState x:Name=\"NarrowState\">\r\n                    <VisualState.StateTriggers>\r\n                        <AdaptiveTrigger MinWindowWidth=\"0\"/>\r\n                    </VisualState.StateTriggers>\r\n                </VisualState>\r\n            </VisualStateGroup>\r\n        </VisualStateManager.VisualStateGroups>\r\n</NavigationView>\r\n```\r\n\r\n### Expected Behavior\r\nMenu items should work whereever the user clicks.\r\n\r\n### Actual Behavior\r\nMenu items no longer act as one 'button'.\r\n![datatemplates](https://user-images.githubusercontent.com/10768448/37627545-8a2ed008-2b9a-11e8-926a-1897461a495e.png)\r\n\r\nThis behavior replicates this issue using either 'Navigation Pane + Code Behind', 'Navigation Pan + MVVMLight' and 'Navigation Pan + Prism.'\r\n## System\r\n\r\n* **VS Version:** Microsoft Visual Studio Community 2017 Version 15.6.2\r\n* **WTS Wizard Version:** 1.7.18030.1\r\n* **WTS Template Version:** 1.7.18037.1\r\n* **Windows Build:** Windows 10 Education Version 10.0.16299 Build 16299\r\n"},"comment":{"url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/comments/374617048","html_url":"https://github.com/Microsoft/WindowsTemplateStudio/issues/2080#issuecomment-374617048","issue_url":"https://api.github.com/repos/Microsoft/WindowsTemplateStudio/issues/2080","id":374617048,"user":{"login":"mvegaca","id":5556784,"avatar_url":"https://avatars2.githubusercontent.com/u/5556784?v=4","gravatar_id":"","url":"https://api.github.com/users/mvegaca","html_url":"https://github.com/mvegaca","followers_url":"https://api.github.com/users/mvegaca/followers","following_url":"https://api.github.com/users/mvegaca/following{/other_user}","gists_url":"https://api.github.com/users/mvegaca/gists{/gist_id}","starred_url":"https://api.github.com/users/mvegaca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvegaca/subscriptions","organizations_url":"https://api.github.com/users/mvegaca/orgs","repos_url":"https://api.github.com/users/mvegaca/repos","events_url":"https://api.github.com/users/mvegaca/events{/privacy}","received_events_url":"https://api.github.com/users/mvegaca/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T14:26:17Z","updated_at":"2018-03-20T14:26:17Z","author_association":"MEMBER","body":"I've added a PR with a documentation to explain that.\r\n[Add doc: Update from HamburgerMenu to NavigationView](https://github.com/Microsoft/WindowsTemplateStudio/pull/2084)\r\n\r\nI hope it can help you @DLBrowne "}}
{"actor":{"display_login":"mvegaca"}}