{"action":"created","comment":{"url":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/comments/240019218","pull_request_review_id":182959939,"id":240019218,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDAxOTIxOA==","diff_hunk":"@@ -546,16 +546,12 @@ def fill_empty(df, columns, value):\n         for col in columns:\n             assert (\n                 col in df.columns\n-            ), \"{col} missing from dataframe columns!\".format(\n-                col=col\n-            )\n+            ), \"{col} missing from dataframe columns!\".format(col=col)","path":"janitor/functions.py","position":7,"original_position":7,"commit_id":"2d80777abf825afc7d57908736a40f4ee24b2577","original_commit_id":"2d80777abf825afc7d57908736a40f4ee24b2577","user":{"login":"zbarry","id":4762711,"node_id":"MDQ6VXNlcjQ3NjI3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4762711?v=4","gravatar_id":"","url":"https://api.github.com/users/zbarry","html_url":"https://github.com/zbarry","followers_url":"https://api.github.com/users/zbarry/followers","following_url":"https://api.github.com/users/zbarry/following{/other_user}","gists_url":"https://api.github.com/users/zbarry/gists{/gist_id}","starred_url":"https://api.github.com/users/zbarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbarry/subscriptions","organizations_url":"https://api.github.com/users/zbarry/orgs","repos_url":"https://api.github.com/users/zbarry/repos","events_url":"https://api.github.com/users/zbarry/events{/privacy}","received_events_url":"https://api.github.com/users/zbarry/received_events","type":"User","site_admin":false},"body":"Just purely running `make check` which runs `black -l 79 .`","created_at":"2018-12-08T23:13:00Z","updated_at":"2018-12-08T23:13:01Z","html_url":"https://github.com/ericmjl/pyjanitor/pull/82#discussion_r240019218","pull_request_url":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/82","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/comments/240019218"},"html":{"href":"https://github.com/ericmjl/pyjanitor/pull/82#discussion_r240019218"},"pull_request":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/82"}},"in_reply_to_id":240019177},"pull_request":{"url":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/82","id":237079646,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDc5NjQ2","html_url":"https://github.com/ericmjl/pyjanitor/pull/82","diff_url":"https://github.com/ericmjl/pyjanitor/pull/82.diff","patch_url":"https://github.com/ericmjl/pyjanitor/pull/82.patch","issue_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/82","number":82,"state":"open","locked":false,"title":"48-reset_index_inplace","user":{"login":"zbarry","id":4762711,"node_id":"MDQ6VXNlcjQ3NjI3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4762711?v=4","gravatar_id":"","url":"https://api.github.com/users/zbarry","html_url":"https://github.com/zbarry","followers_url":"https://api.github.com/users/zbarry/followers","following_url":"https://api.github.com/users/zbarry/following{/other_user}","gists_url":"https://api.github.com/users/zbarry/gists{/gist_id}","starred_url":"https://api.github.com/users/zbarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbarry/subscriptions","organizations_url":"https://api.github.com/users/zbarry/orgs","repos_url":"https://api.github.com/users/zbarry/repos","events_url":"https://api.github.com/users/zbarry/events{/privacy}","received_events_url":"https://api.github.com/users/zbarry/received_events","type":"User","site_admin":false},"body":"This PR resolves #48 .\r\n\r\n# PR Checklist\r\n\r\nPlease ensure that you have done the following:\r\n\r\n1. [x] PR in from a fork off your branch. Do not PR from <your_username>:master, but rather from <your_username>:<branch_name>.\r\n2. [x] If you're not on the contributors list, add yourself to `AUTHORS.rst`.\r\n\r\n## Quick Check\r\n\r\nTo do a very quick check that everything is correct, follow these steps below:\r\n\r\n- [x] Run the command `make check` from pyjanitor's top-level directory. This will automatically run:\r\n    - black formatting\r\n    - pycodestyle checkin\r\n    - running the test suite\r\n    - docs build\r\n\r\n## Code Changes\r\n\r\nIf you are adding code changes, please ensure the following:\r\n\r\n- [x] Ensure that you have added tests.\r\n- [x] Run all tests (`$ pytest .`) locally on your machine.\r\n    - [x] Check to ensure that test coverage covers the lines of code that you have added.\r\n    - [x] Ensure that all tests pass.\r\n\r\n## Documentation Changes\r\n\r\nIf you are adding documentation changes, please ensure the following:\r\n\r\n- [x] Build the docs locally.\r\n- [x] View the docs to check that it renders correctly.\r\n\r\n# PR Description\r\n\r\nPlease describe the changes proposed in the pull request:\r\n\r\nreset_index_inplace\r\n\r\n# Relevant Reviewers\r\n\r\nPlease tag maintainers to review.\r\n\r\n- @ericmjl\r\n","created_at":"2018-12-08T17:18:36Z","updated_at":"2018-12-08T23:13:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4a0e7fe7c63c8e27dff4a8b20635f9386706f30","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/82/commits","review_comments_url":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/82/comments","review_comment_url":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/82/comments","statuses_url":"https://api.github.com/repos/ericmjl/pyjanitor/statuses/2d80777abf825afc7d57908736a40f4ee24b2577","head":{"label":"zbarry:48-reset_index_inplace","ref":"48-reset_index_inplace","sha":"2d80777abf825afc7d57908736a40f4ee24b2577","user":{"login":"zbarry","id":4762711,"node_id":"MDQ6VXNlcjQ3NjI3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4762711?v=4","gravatar_id":"","url":"https://api.github.com/users/zbarry","html_url":"https://github.com/zbarry","followers_url":"https://api.github.com/users/zbarry/followers","following_url":"https://api.github.com/users/zbarry/following{/other_user}","gists_url":"https://api.github.com/users/zbarry/gists{/gist_id}","starred_url":"https://api.github.com/users/zbarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbarry/subscriptions","organizations_url":"https://api.github.com/users/zbarry/orgs","repos_url":"https://api.github.com/users/zbarry/repos","events_url":"https://api.github.com/users/zbarry/events{/privacy}","received_events_url":"https://api.github.com/users/zbarry/received_events","type":"User","site_admin":false},"repo":{"id":156016197,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYwMTYxOTc=","name":"pyjanitor","full_name":"zbarry/pyjanitor","private":false,"owner":{"login":"zbarry","id":4762711,"node_id":"MDQ6VXNlcjQ3NjI3MTE=","avatar_url":"https://avatars0.githubusercontent.com/u/4762711?v=4","gravatar_id":"","url":"https://api.github.com/users/zbarry","html_url":"https://github.com/zbarry","followers_url":"https://api.github.com/users/zbarry/followers","following_url":"https://api.github.com/users/zbarry/following{/other_user}","gists_url":"https://api.github.com/users/zbarry/gists{/gist_id}","starred_url":"https://api.github.com/users/zbarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zbarry/subscriptions","organizations_url":"https://api.github.com/users/zbarry/orgs","repos_url":"https://api.github.com/users/zbarry/repos","events_url":"https://api.github.com/users/zbarry/events{/privacy}","received_events_url":"https://api.github.com/users/zbarry/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zbarry/pyjanitor","description":"Python implementation of R package Janitor","fork":true,"url":"https://api.github.com/repos/zbarry/pyjanitor","forks_url":"https://api.github.com/repos/zbarry/pyjanitor/forks","keys_url":"https://api.github.com/repos/zbarry/pyjanitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zbarry/pyjanitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zbarry/pyjanitor/teams","hooks_url":"https://api.github.com/repos/zbarry/pyjanitor/hooks","issue_events_url":"https://api.github.com/repos/zbarry/pyjanitor/issues/events{/number}","events_url":"https://api.github.com/repos/zbarry/pyjanitor/events","assignees_url":"https://api.github.com/repos/zbarry/pyjanitor/assignees{/user}","branches_url":"https://api.github.com/repos/zbarry/pyjanitor/branches{/branch}","tags_url":"https://api.github.com/repos/zbarry/pyjanitor/tags","blobs_url":"https://api.github.com/repos/zbarry/pyjanitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zbarry/pyjanitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zbarry/pyjanitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/zbarry/pyjanitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zbarry/pyjanitor/statuses/{sha}","languages_url":"https://api.github.com/repos/zbarry/pyjanitor/languages","stargazers_url":"https://api.github.com/repos/zbarry/pyjanitor/stargazers","contributors_url":"https://api.github.com/repos/zbarry/pyjanitor/contributors","subscribers_url":"https://api.github.com/repos/zbarry/pyjanitor/subscribers","subscription_url":"https://api.github.com/repos/zbarry/pyjanitor/subscription","commits_url":"https://api.github.com/repos/zbarry/pyjanitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/zbarry/pyjanitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/zbarry/pyjanitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/zbarry/pyjanitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/zbarry/pyjanitor/contents/{+path}","compare_url":"https://api.github.com/repos/zbarry/pyjanitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zbarry/pyjanitor/merges","archive_url":"https://api.github.com/repos/zbarry/pyjanitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zbarry/pyjanitor/downloads","issues_url":"https://api.github.com/repos/zbarry/pyjanitor/issues{/number}","pulls_url":"https://api.github.com/repos/zbarry/pyjanitor/pulls{/number}","milestones_url":"https://api.github.com/repos/zbarry/pyjanitor/milestones{/number}","notifications_url":"https://api.github.com/repos/zbarry/pyjanitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zbarry/pyjanitor/labels{/name}","releases_url":"https://api.github.com/repos/zbarry/pyjanitor/releases{/id}","deployments_url":"https://api.github.com/repos/zbarry/pyjanitor/deployments","created_at":"2018-11-03T19:21:19Z","updated_at":"2018-12-08T16:12:57Z","pushed_at":"2018-12-08T17:17:13Z","git_url":"git://github.com/zbarry/pyjanitor.git","ssh_url":"git@github.com:zbarry/pyjanitor.git","clone_url":"https://github.com/zbarry/pyjanitor.git","svn_url":"https://github.com/zbarry/pyjanitor","homepage":"http://pyjanitor.readthedocs.io","size":724,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ericmjl:master","ref":"master","sha":"3acba2ddcb3b701097395de23a6f76b67c06fd0d","user":{"login":"ericmjl","id":2631566,"node_id":"MDQ6VXNlcjI2MzE1NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2631566?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmjl","html_url":"https://github.com/ericmjl","followers_url":"https://api.github.com/users/ericmjl/followers","following_url":"https://api.github.com/users/ericmjl/following{/other_user}","gists_url":"https://api.github.com/users/ericmjl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmjl/subscriptions","organizations_url":"https://api.github.com/users/ericmjl/orgs","repos_url":"https://api.github.com/users/ericmjl/repos","events_url":"https://api.github.com/users/ericmjl/events{/privacy}","received_events_url":"https://api.github.com/users/ericmjl/received_events","type":"User","site_admin":false},"repo":{"id":123836190,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM4MzYxOTA=","name":"pyjanitor","full_name":"ericmjl/pyjanitor","private":false,"owner":{"login":"ericmjl","id":2631566,"node_id":"MDQ6VXNlcjI2MzE1NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2631566?v=4","gravatar_id":"","url":"https://api.github.com/users/ericmjl","html_url":"https://github.com/ericmjl","followers_url":"https://api.github.com/users/ericmjl/followers","following_url":"https://api.github.com/users/ericmjl/following{/other_user}","gists_url":"https://api.github.com/users/ericmjl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmjl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmjl/subscriptions","organizations_url":"https://api.github.com/users/ericmjl/orgs","repos_url":"https://api.github.com/users/ericmjl/repos","events_url":"https://api.github.com/users/ericmjl/events{/privacy}","received_events_url":"https://api.github.com/users/ericmjl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ericmjl/pyjanitor","description":"Clean APIs for data cleaning. Python implementation of R package Janitor","fork":false,"url":"https://api.github.com/repos/ericmjl/pyjanitor","forks_url":"https://api.github.com/repos/ericmjl/pyjanitor/forks","keys_url":"https://api.github.com/repos/ericmjl/pyjanitor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericmjl/pyjanitor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericmjl/pyjanitor/teams","hooks_url":"https://api.github.com/repos/ericmjl/pyjanitor/hooks","issue_events_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/events{/number}","events_url":"https://api.github.com/repos/ericmjl/pyjanitor/events","assignees_url":"https://api.github.com/repos/ericmjl/pyjanitor/assignees{/user}","branches_url":"https://api.github.com/repos/ericmjl/pyjanitor/branches{/branch}","tags_url":"https://api.github.com/repos/ericmjl/pyjanitor/tags","blobs_url":"https://api.github.com/repos/ericmjl/pyjanitor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericmjl/pyjanitor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericmjl/pyjanitor/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericmjl/pyjanitor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericmjl/pyjanitor/statuses/{sha}","languages_url":"https://api.github.com/repos/ericmjl/pyjanitor/languages","stargazers_url":"https://api.github.com/repos/ericmjl/pyjanitor/stargazers","contributors_url":"https://api.github.com/repos/ericmjl/pyjanitor/contributors","subscribers_url":"https://api.github.com/repos/ericmjl/pyjanitor/subscribers","subscription_url":"https://api.github.com/repos/ericmjl/pyjanitor/subscription","commits_url":"https://api.github.com/repos/ericmjl/pyjanitor/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericmjl/pyjanitor/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericmjl/pyjanitor/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericmjl/pyjanitor/contents/{+path}","compare_url":"https://api.github.com/repos/ericmjl/pyjanitor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericmjl/pyjanitor/merges","archive_url":"https://api.github.com/repos/ericmjl/pyjanitor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericmjl/pyjanitor/downloads","issues_url":"https://api.github.com/repos/ericmjl/pyjanitor/issues{/number}","pulls_url":"https://api.github.com/repos/ericmjl/pyjanitor/pulls{/number}","milestones_url":"https://api.github.com/repos/ericmjl/pyjanitor/milestones{/number}","notifications_url":"https://api.github.com/repos/ericmjl/pyjanitor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericmjl/pyjanitor/labels{/name}","releases_url":"https://api.github.com/repos/ericmjl/pyjanitor/releases{/id}","deployments_url":"https://api.github.com/repos/ericmjl/pyjanitor/deployments","created_at":"2018-03-04T22:43:33Z","updated_at":"2018-12-08T18:53:08Z","pushed_at":"2018-12-08T17:18:37Z","git_url":"git://github.com/ericmjl/pyjanitor.git","ssh_url":"git@github.com:ericmjl/pyjanitor.git","clone_url":"https://github.com/ericmjl/pyjanitor.git","svn_url":"https://github.com/ericmjl/pyjanitor","homepage":"http://pyjanitor.readthedocs.io","size":754,"stargazers_count":99,"watchers_count":99,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":12,"open_issues":16,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/82"},"html":{"href":"https://github.com/ericmjl/pyjanitor/pull/82"},"issue":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/issues/82"},"comments":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/ericmjl/pyjanitor/statuses/2d80777abf825afc7d57908736a40f4ee24b2577"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zbarry"}}