{"action":"closed","number":16860,"pull_request":{"url":"https://api.github.com/repos/emberjs/ember.js/pulls/16860","id":206011691,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDExNjkx","html_url":"https://github.com/emberjs/ember.js/pull/16860","diff_url":"https://github.com/emberjs/ember.js/pull/16860.diff","patch_url":"https://github.com/emberjs/ember.js/pull/16860.patch","issue_url":"https://api.github.com/repos/emberjs/ember.js/issues/16860","number":16860,"state":"closed","locked":false,"title":"[BUGFIX release] Clear chains in ProxyMixin when destroyed","user":{"login":"pieter-v","id":7090162,"node_id":"MDQ6VXNlcjcwOTAxNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7090162?v=4","gravatar_id":"","url":"https://api.github.com/users/pieter-v","html_url":"https://github.com/pieter-v","followers_url":"https://api.github.com/users/pieter-v/followers","following_url":"https://api.github.com/users/pieter-v/following{/other_user}","gists_url":"https://api.github.com/users/pieter-v/gists{/gist_id}","starred_url":"https://api.github.com/users/pieter-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieter-v/subscriptions","organizations_url":"https://api.github.com/users/pieter-v/orgs","repos_url":"https://api.github.com/users/pieter-v/repos","events_url":"https://api.github.com/users/pieter-v/events{/privacy}","received_events_url":"https://api.github.com/users/pieter-v/received_events","type":"User","site_admin":false},"body":"When a ObjectProxy is destroyed while the proxied object is still alive, then the ObjectProxy is leaked because the chains attached to the proxied object retains the ObjectProxy.\r\nThis is an issue for us, as ember-data uses proxies for their belongsTo relationships. (See https://github.com/emberjs/data/pull/5554 for more information)\r\n\r\nA sample program that demonstrates this can be found at https://github.com/pieter-v/ember-proxy-leak\r\n\r\nA memory snapshot before this fix:\r\n![before](https://user-images.githubusercontent.com/7090162/43642178-c8a9d2fe-9726-11e8-83b5-e6715755bdce.png)\r\n\r\nA memory snapshot after this fix:\r\n![after](https://user-images.githubusercontent.com/7090162/43642183-d2c6596a-9726-11e8-9f84-a3b0d84dae47.png)\r\n","created_at":"2018-08-03T12:10:52Z","updated_at":"2018-09-05T14:09:20Z","closed_at":"2018-09-05T14:09:20Z","merged_at":"2018-09-05T14:09:20Z","merge_commit_sha":"fa43958a8dc166336e0b44f2e29e505a4bc5bcb8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/emberjs/ember.js/pulls/16860/commits","review_comments_url":"https://api.github.com/repos/emberjs/ember.js/pulls/16860/comments","review_comment_url":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emberjs/ember.js/issues/16860/comments","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/aca371cb177d504cf844fb81b7de70578e29e611","head":{"label":"pieter-v:proxy-leak","ref":"proxy-leak","sha":"aca371cb177d504cf844fb81b7de70578e29e611","user":{"login":"pieter-v","id":7090162,"node_id":"MDQ6VXNlcjcwOTAxNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7090162?v=4","gravatar_id":"","url":"https://api.github.com/users/pieter-v","html_url":"https://github.com/pieter-v","followers_url":"https://api.github.com/users/pieter-v/followers","following_url":"https://api.github.com/users/pieter-v/following{/other_user}","gists_url":"https://api.github.com/users/pieter-v/gists{/gist_id}","starred_url":"https://api.github.com/users/pieter-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieter-v/subscriptions","organizations_url":"https://api.github.com/users/pieter-v/orgs","repos_url":"https://api.github.com/users/pieter-v/repos","events_url":"https://api.github.com/users/pieter-v/events{/privacy}","received_events_url":"https://api.github.com/users/pieter-v/received_events","type":"User","site_admin":false},"repo":{"id":81200027,"node_id":"MDEwOlJlcG9zaXRvcnk4MTIwMDAyNw==","name":"ember.js","full_name":"pieter-v/ember.js","owner":{"login":"pieter-v","id":7090162,"node_id":"MDQ6VXNlcjcwOTAxNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/7090162?v=4","gravatar_id":"","url":"https://api.github.com/users/pieter-v","html_url":"https://github.com/pieter-v","followers_url":"https://api.github.com/users/pieter-v/followers","following_url":"https://api.github.com/users/pieter-v/following{/other_user}","gists_url":"https://api.github.com/users/pieter-v/gists{/gist_id}","starred_url":"https://api.github.com/users/pieter-v/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieter-v/subscriptions","organizations_url":"https://api.github.com/users/pieter-v/orgs","repos_url":"https://api.github.com/users/pieter-v/repos","events_url":"https://api.github.com/users/pieter-v/events{/privacy}","received_events_url":"https://api.github.com/users/pieter-v/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pieter-v/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":true,"url":"https://api.github.com/repos/pieter-v/ember.js","forks_url":"https://api.github.com/repos/pieter-v/ember.js/forks","keys_url":"https://api.github.com/repos/pieter-v/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pieter-v/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pieter-v/ember.js/teams","hooks_url":"https://api.github.com/repos/pieter-v/ember.js/hooks","issue_events_url":"https://api.github.com/repos/pieter-v/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/pieter-v/ember.js/events","assignees_url":"https://api.github.com/repos/pieter-v/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/pieter-v/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/pieter-v/ember.js/tags","blobs_url":"https://api.github.com/repos/pieter-v/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pieter-v/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pieter-v/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/pieter-v/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pieter-v/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/pieter-v/ember.js/languages","stargazers_url":"https://api.github.com/repos/pieter-v/ember.js/stargazers","contributors_url":"https://api.github.com/repos/pieter-v/ember.js/contributors","subscribers_url":"https://api.github.com/repos/pieter-v/ember.js/subscribers","subscription_url":"https://api.github.com/repos/pieter-v/ember.js/subscription","commits_url":"https://api.github.com/repos/pieter-v/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/pieter-v/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/pieter-v/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/pieter-v/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/pieter-v/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/pieter-v/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pieter-v/ember.js/merges","archive_url":"https://api.github.com/repos/pieter-v/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pieter-v/ember.js/downloads","issues_url":"https://api.github.com/repos/pieter-v/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/pieter-v/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/pieter-v/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/pieter-v/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pieter-v/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/pieter-v/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/pieter-v/ember.js/deployments","created_at":"2017-02-07T11:17:05Z","updated_at":"2018-09-05T07:20:46Z","pushed_at":"2018-09-05T07:45:12Z","git_url":"git://github.com/pieter-v/ember.js.git","ssh_url":"git@github.com:pieter-v/ember.js.git","clone_url":"https://github.com/pieter-v/ember.js.git","svn_url":"https://github.com/pieter-v/ember.js","homepage":"http://www.emberjs.com","size":49624,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emberjs:master","ref":"master","sha":"8d059ab275bf7544a49be91ceac816f6ffb56bce","user":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"repo":{"id":1801829,"node_id":"MDEwOlJlcG9zaXRvcnkxODAxODI5","name":"ember.js","full_name":"emberjs/ember.js","owner":{"login":"emberjs","id":1253363,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNTMzNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1253363?v=4","gravatar_id":"","url":"https://api.github.com/users/emberjs","html_url":"https://github.com/emberjs","followers_url":"https://api.github.com/users/emberjs/followers","following_url":"https://api.github.com/users/emberjs/following{/other_user}","gists_url":"https://api.github.com/users/emberjs/gists{/gist_id}","starred_url":"https://api.github.com/users/emberjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emberjs/subscriptions","organizations_url":"https://api.github.com/users/emberjs/orgs","repos_url":"https://api.github.com/users/emberjs/repos","events_url":"https://api.github.com/users/emberjs/events{/privacy}","received_events_url":"https://api.github.com/users/emberjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emberjs/ember.js","description":"Ember.js - A JavaScript framework for creating ambitious web applications","fork":false,"url":"https://api.github.com/repos/emberjs/ember.js","forks_url":"https://api.github.com/repos/emberjs/ember.js/forks","keys_url":"https://api.github.com/repos/emberjs/ember.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emberjs/ember.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emberjs/ember.js/teams","hooks_url":"https://api.github.com/repos/emberjs/ember.js/hooks","issue_events_url":"https://api.github.com/repos/emberjs/ember.js/issues/events{/number}","events_url":"https://api.github.com/repos/emberjs/ember.js/events","assignees_url":"https://api.github.com/repos/emberjs/ember.js/assignees{/user}","branches_url":"https://api.github.com/repos/emberjs/ember.js/branches{/branch}","tags_url":"https://api.github.com/repos/emberjs/ember.js/tags","blobs_url":"https://api.github.com/repos/emberjs/ember.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emberjs/ember.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emberjs/ember.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/emberjs/ember.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emberjs/ember.js/statuses/{sha}","languages_url":"https://api.github.com/repos/emberjs/ember.js/languages","stargazers_url":"https://api.github.com/repos/emberjs/ember.js/stargazers","contributors_url":"https://api.github.com/repos/emberjs/ember.js/contributors","subscribers_url":"https://api.github.com/repos/emberjs/ember.js/subscribers","subscription_url":"https://api.github.com/repos/emberjs/ember.js/subscription","commits_url":"https://api.github.com/repos/emberjs/ember.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/emberjs/ember.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/emberjs/ember.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/emberjs/ember.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/emberjs/ember.js/contents/{+path}","compare_url":"https://api.github.com/repos/emberjs/ember.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emberjs/ember.js/merges","archive_url":"https://api.github.com/repos/emberjs/ember.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emberjs/ember.js/downloads","issues_url":"https://api.github.com/repos/emberjs/ember.js/issues{/number}","pulls_url":"https://api.github.com/repos/emberjs/ember.js/pulls{/number}","milestones_url":"https://api.github.com/repos/emberjs/ember.js/milestones{/number}","notifications_url":"https://api.github.com/repos/emberjs/ember.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emberjs/ember.js/labels{/name}","releases_url":"https://api.github.com/repos/emberjs/ember.js/releases{/id}","deployments_url":"https://api.github.com/repos/emberjs/ember.js/deployments","created_at":"2011-05-25T23:39:40Z","updated_at":"2018-09-05T03:57:29Z","pushed_at":"2018-09-05T14:09:20Z","git_url":"git://github.com/emberjs/ember.js.git","ssh_url":"git@github.com:emberjs/ember.js.git","clone_url":"https://github.com/emberjs/ember.js.git","svn_url":"https://github.com/emberjs/ember.js","homepage":"http://www.emberjs.com","size":68815,"stargazers_count":19966,"watchers_count":19966,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4027,"mirror_url":null,"archived":false,"open_issues_count":387,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4027,"open_issues":387,"watchers":19966,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16860"},"html":{"href":"https://github.com/emberjs/ember.js/pull/16860"},"issue":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/16860"},"comments":{"href":"https://api.github.com/repos/emberjs/ember.js/issues/16860/comments"},"review_comments":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16860/comments"},"review_comment":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emberjs/ember.js/pulls/16860/commits"},"statuses":{"href":"https://api.github.com/repos/emberjs/ember.js/statuses/aca371cb177d504cf844fb81b7de70578e29e611"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"rwjblue","id":12637,"node_id":"MDQ6VXNlcjEyNjM3","avatar_url":"https://avatars0.githubusercontent.com/u/12637?v=4","gravatar_id":"","url":"https://api.github.com/users/rwjblue","html_url":"https://github.com/rwjblue","followers_url":"https://api.github.com/users/rwjblue/followers","following_url":"https://api.github.com/users/rwjblue/following{/other_user}","gists_url":"https://api.github.com/users/rwjblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rwjblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwjblue/subscriptions","organizations_url":"https://api.github.com/users/rwjblue/orgs","repos_url":"https://api.github.com/users/rwjblue/repos","events_url":"https://api.github.com/users/rwjblue/events{/privacy}","received_events_url":"https://api.github.com/users/rwjblue/received_events","type":"User","site_admin":false},"comments":4,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":5,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"rwjblue"}}