{"action":"created","comment":{"url":"https://api.github.com/repos/apple/foundationdb/pulls/comments/187237825","pull_request_review_id":118974119,"id":187237825,"diff_hunk":"@@ -1,6 +1,14 @@\n+\n+ifeq ($(PLATFORM),freebsd)\n+FDBLibTLS_CFLAGS := -fPIC -I/usr/local/include -I$(BOOSTDIR)\n+FDBLibTLS_LIBS := -lssl -lcrypto\n+FDBLibTLS_LDFLAGS := -lc++","path":"FDBLibTLS/local.mk","position":5,"original_position":5,"commit_id":"ae0cf3e81e570f06a17e16ea3128c7163e9ab9fc","original_commit_id":"ae0cf3e81e570f06a17e16ea3128c7163e9ab9fc","user":{"login":"alexmiller-apple","id":35046903,"avatar_url":"https://avatars2.githubusercontent.com/u/35046903?v=4","gravatar_id":"","url":"https://api.github.com/users/alexmiller-apple","html_url":"https://github.com/alexmiller-apple","followers_url":"https://api.github.com/users/alexmiller-apple/followers","following_url":"https://api.github.com/users/alexmiller-apple/following{/other_user}","gists_url":"https://api.github.com/users/alexmiller-apple/gists{/gist_id}","starred_url":"https://api.github.com/users/alexmiller-apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexmiller-apple/subscriptions","organizations_url":"https://api.github.com/users/alexmiller-apple/orgs","repos_url":"https://api.github.com/users/alexmiller-apple/repos","events_url":"https://api.github.com/users/alexmiller-apple/events{/privacy}","received_events_url":"https://api.github.com/users/alexmiller-apple/received_events","type":"User","site_admin":false},"body":"I believe link-wrapper re-writes -static-libstdc++ to something else in the command line anyway to manage glibc version dependency issues.\r\n\r\nPutting no thought yet into libc version dependency issues, could you drop all your local.mk edits by adding an `if freebsd` there, or doing something similar that looks more platform-agnostic?  The next time we add a folder, we're likely to accidentally break FreeBSD by forgetting to have a separate `if freebsd` block for it, or not being able to test it even if we remember.","created_at":"2018-05-10T04:34:46Z","updated_at":"2018-05-10T04:43:32Z","html_url":"https://github.com/apple/foundationdb/pull/309#discussion_r187237825","pull_request_url":"https://api.github.com/repos/apple/foundationdb/pulls/309","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/comments/187237825"},"html":{"href":"https://github.com/apple/foundationdb/pull/309#discussion_r187237825"},"pull_request":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/apple/foundationdb/pulls/309","id":186429913,"html_url":"https://github.com/apple/foundationdb/pull/309","diff_url":"https://github.com/apple/foundationdb/pull/309.diff","patch_url":"https://github.com/apple/foundationdb/pull/309.patch","issue_url":"https://api.github.com/repos/apple/foundationdb/issues/309","number":309,"state":"open","locked":false,"title":"Initial FreeBSD Support for Foundation DB","user":{"login":"wolfspider","id":4861700,"avatar_url":"https://avatars3.githubusercontent.com/u/4861700?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfspider","html_url":"https://github.com/wolfspider","followers_url":"https://api.github.com/users/wolfspider/followers","following_url":"https://api.github.com/users/wolfspider/following{/other_user}","gists_url":"https://api.github.com/users/wolfspider/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfspider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfspider/subscriptions","organizations_url":"https://api.github.com/users/wolfspider/orgs","repos_url":"https://api.github.com/users/wolfspider/repos","events_url":"https://api.github.com/users/wolfspider/events{/privacy}","received_events_url":"https://api.github.com/users/wolfspider/received_events","type":"User","site_admin":false},"body":"I've opened a discussion in the forums here for this PR: https://forums.foundationdb.org/t/freebsd-support-for-foundationdb/357/3 as per the contributor guidelines. Thanks again.\r\n\r\n","created_at":"2018-05-07T18:40:42Z","updated_at":"2018-05-10T04:43:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8510fa96073e1eee0e18c5085e51c243f4077e91","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/foundationdb/pulls/309/commits","review_comments_url":"https://api.github.com/repos/apple/foundationdb/pulls/309/comments","review_comment_url":"https://api.github.com/repos/apple/foundationdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/foundationdb/issues/309/comments","statuses_url":"https://api.github.com/repos/apple/foundationdb/statuses/ae0cf3e81e570f06a17e16ea3128c7163e9ab9fc","head":{"label":"wolfspider:master","ref":"master","sha":"ae0cf3e81e570f06a17e16ea3128c7163e9ab9fc","user":{"login":"wolfspider","id":4861700,"avatar_url":"https://avatars3.githubusercontent.com/u/4861700?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfspider","html_url":"https://github.com/wolfspider","followers_url":"https://api.github.com/users/wolfspider/followers","following_url":"https://api.github.com/users/wolfspider/following{/other_user}","gists_url":"https://api.github.com/users/wolfspider/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfspider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfspider/subscriptions","organizations_url":"https://api.github.com/users/wolfspider/orgs","repos_url":"https://api.github.com/users/wolfspider/repos","events_url":"https://api.github.com/users/wolfspider/events{/privacy}","received_events_url":"https://api.github.com/users/wolfspider/received_events","type":"User","site_admin":false},"repo":{"id":131672084,"name":"foundationdb","full_name":"wolfspider/foundationdb","owner":{"login":"wolfspider","id":4861700,"avatar_url":"https://avatars3.githubusercontent.com/u/4861700?v=4","gravatar_id":"","url":"https://api.github.com/users/wolfspider","html_url":"https://github.com/wolfspider","followers_url":"https://api.github.com/users/wolfspider/followers","following_url":"https://api.github.com/users/wolfspider/following{/other_user}","gists_url":"https://api.github.com/users/wolfspider/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfspider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfspider/subscriptions","organizations_url":"https://api.github.com/users/wolfspider/orgs","repos_url":"https://api.github.com/users/wolfspider/repos","events_url":"https://api.github.com/users/wolfspider/events{/privacy}","received_events_url":"https://api.github.com/users/wolfspider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wolfspider/foundationdb","description":"FoundationDB - the open source, distributed, transactional key-value store","fork":true,"url":"https://api.github.com/repos/wolfspider/foundationdb","forks_url":"https://api.github.com/repos/wolfspider/foundationdb/forks","keys_url":"https://api.github.com/repos/wolfspider/foundationdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolfspider/foundationdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolfspider/foundationdb/teams","hooks_url":"https://api.github.com/repos/wolfspider/foundationdb/hooks","issue_events_url":"https://api.github.com/repos/wolfspider/foundationdb/issues/events{/number}","events_url":"https://api.github.com/repos/wolfspider/foundationdb/events","assignees_url":"https://api.github.com/repos/wolfspider/foundationdb/assignees{/user}","branches_url":"https://api.github.com/repos/wolfspider/foundationdb/branches{/branch}","tags_url":"https://api.github.com/repos/wolfspider/foundationdb/tags","blobs_url":"https://api.github.com/repos/wolfspider/foundationdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolfspider/foundationdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolfspider/foundationdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolfspider/foundationdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolfspider/foundationdb/statuses/{sha}","languages_url":"https://api.github.com/repos/wolfspider/foundationdb/languages","stargazers_url":"https://api.github.com/repos/wolfspider/foundationdb/stargazers","contributors_url":"https://api.github.com/repos/wolfspider/foundationdb/contributors","subscribers_url":"https://api.github.com/repos/wolfspider/foundationdb/subscribers","subscription_url":"https://api.github.com/repos/wolfspider/foundationdb/subscription","commits_url":"https://api.github.com/repos/wolfspider/foundationdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolfspider/foundationdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolfspider/foundationdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolfspider/foundationdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolfspider/foundationdb/contents/{+path}","compare_url":"https://api.github.com/repos/wolfspider/foundationdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolfspider/foundationdb/merges","archive_url":"https://api.github.com/repos/wolfspider/foundationdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolfspider/foundationdb/downloads","issues_url":"https://api.github.com/repos/wolfspider/foundationdb/issues{/number}","pulls_url":"https://api.github.com/repos/wolfspider/foundationdb/pulls{/number}","milestones_url":"https://api.github.com/repos/wolfspider/foundationdb/milestones{/number}","notifications_url":"https://api.github.com/repos/wolfspider/foundationdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolfspider/foundationdb/labels{/name}","releases_url":"https://api.github.com/repos/wolfspider/foundationdb/releases{/id}","deployments_url":"https://api.github.com/repos/wolfspider/foundationdb/deployments","created_at":"2018-05-01T03:23:06Z","updated_at":"2018-05-07T20:44:28Z","pushed_at":"2018-05-07T20:44:22Z","git_url":"git://github.com/wolfspider/foundationdb.git","ssh_url":"git@github.com:wolfspider/foundationdb.git","clone_url":"https://github.com/wolfspider/foundationdb.git","svn_url":"https://github.com/wolfspider/foundationdb","homepage":"https://www.foundationdb.org","size":8584,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"27fab38b876db16e7d12d9b0cdf14d53f6ce6459","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":114187903,"name":"foundationdb","full_name":"apple/foundationdb","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/foundationdb","description":"FoundationDB - the open source, distributed, transactional key-value store","fork":false,"url":"https://api.github.com/repos/apple/foundationdb","forks_url":"https://api.github.com/repos/apple/foundationdb/forks","keys_url":"https://api.github.com/repos/apple/foundationdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/foundationdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/foundationdb/teams","hooks_url":"https://api.github.com/repos/apple/foundationdb/hooks","issue_events_url":"https://api.github.com/repos/apple/foundationdb/issues/events{/number}","events_url":"https://api.github.com/repos/apple/foundationdb/events","assignees_url":"https://api.github.com/repos/apple/foundationdb/assignees{/user}","branches_url":"https://api.github.com/repos/apple/foundationdb/branches{/branch}","tags_url":"https://api.github.com/repos/apple/foundationdb/tags","blobs_url":"https://api.github.com/repos/apple/foundationdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/foundationdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/foundationdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/foundationdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/foundationdb/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/foundationdb/languages","stargazers_url":"https://api.github.com/repos/apple/foundationdb/stargazers","contributors_url":"https://api.github.com/repos/apple/foundationdb/contributors","subscribers_url":"https://api.github.com/repos/apple/foundationdb/subscribers","subscription_url":"https://api.github.com/repos/apple/foundationdb/subscription","commits_url":"https://api.github.com/repos/apple/foundationdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/foundationdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/foundationdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/foundationdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/foundationdb/contents/{+path}","compare_url":"https://api.github.com/repos/apple/foundationdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/foundationdb/merges","archive_url":"https://api.github.com/repos/apple/foundationdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/foundationdb/downloads","issues_url":"https://api.github.com/repos/apple/foundationdb/issues{/number}","pulls_url":"https://api.github.com/repos/apple/foundationdb/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/foundationdb/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/foundationdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/foundationdb/labels{/name}","releases_url":"https://api.github.com/repos/apple/foundationdb/releases{/id}","deployments_url":"https://api.github.com/repos/apple/foundationdb/deployments","created_at":"2017-12-14T01:40:42Z","updated_at":"2018-05-10T04:14:32Z","pushed_at":"2018-05-10T04:05:12Z","git_url":"git://github.com/apple/foundationdb.git","ssh_url":"git@github.com:apple/foundationdb.git","clone_url":"https://github.com/apple/foundationdb.git","svn_url":"https://github.com/apple/foundationdb","homepage":"https://www.foundationdb.org","size":8731,"stargazers_count":7708,"watchers_count":7708,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":476,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":476,"open_issues":68,"watchers":7708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/309"},"html":{"href":"https://github.com/apple/foundationdb/pull/309"},"issue":{"href":"https://api.github.com/repos/apple/foundationdb/issues/309"},"comments":{"href":"https://api.github.com/repos/apple/foundationdb/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/foundationdb/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/apple/foundationdb/statuses/ae0cf3e81e570f06a17e16ea3128c7163e9ab9fc"}},"author_association":"NONE"}}
{"actor":{"display_login":"alexmiller-apple"}}