{"action":"closed","number":42,"pull_request":{"url":"https://api.github.com/repos/JiscRDSS/archivematica/pulls/42","id":151182644,"html_url":"https://github.com/JiscRDSS/archivematica/pull/42","diff_url":"https://github.com/JiscRDSS/archivematica/pull/42.diff","patch_url":"https://github.com/JiscRDSS/archivematica/pull/42.patch","issue_url":"https://api.github.com/repos/JiscRDSS/archivematica/issues/42","number":42,"state":"closed","locked":false,"title":"MCPClient: disable capture of output for compressAIP client script","user":{"login":"lower29","id":386260,"avatar_url":"https://avatars3.githubusercontent.com/u/386260?v=4","gravatar_id":"","url":"https://api.github.com/users/lower29","html_url":"https://github.com/lower29","followers_url":"https://api.github.com/users/lower29/followers","following_url":"https://api.github.com/users/lower29/following{/other_user}","gists_url":"https://api.github.com/users/lower29/gists{/gist_id}","starred_url":"https://api.github.com/users/lower29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lower29/subscriptions","organizations_url":"https://api.github.com/users/lower29/orgs","repos_url":"https://api.github.com/users/lower29/repos","events_url":"https://api.github.com/users/lower29/events{/privacy}","received_events_url":"https://api.github.com/users/lower29/received_events","type":"User","site_admin":false},"body":"The task in #39 is to disable the capture of output specifically for the `compressAIP` function in `compressAIP.py` in the MCP client scripts. However, in looking at the code it became apparent that the best place to do this is actually in the `executeOrRunSubprocess.py` library in `archivematicaCommon`.\r\n\r\nI've therefore added a `capture_output` parameter to the functions in `executeOrRunSubprocess.py`. This is set to True by default so existing behaviour is maintained. However the compressAIP script sets `capture_output` to `False`, thereby disabling the capture of stdout and stderr for this specific task.\r\n\r\nI've also included a `py.test` unit test to demonstrate and prove the expected functionality.\r\n\r\n@jhsimpson and @sevein I'd appreciate your feedback on this approach, in light of the work that is in progress or planned upstream.","created_at":"2017-11-07T17:47:50Z","updated_at":"2018-05-29T06:46:10Z","closed_at":"2018-05-29T06:46:10Z","merged_at":null,"merge_commit_sha":"d238aea2ae864a316d1591474213fd5087e0d20d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jrwdunham","id":2504271,"avatar_url":"https://avatars1.githubusercontent.com/u/2504271?v=4","gravatar_id":"","url":"https://api.github.com/users/jrwdunham","html_url":"https://github.com/jrwdunham","followers_url":"https://api.github.com/users/jrwdunham/followers","following_url":"https://api.github.com/users/jrwdunham/following{/other_user}","gists_url":"https://api.github.com/users/jrwdunham/gists{/gist_id}","starred_url":"https://api.github.com/users/jrwdunham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrwdunham/subscriptions","organizations_url":"https://api.github.com/users/jrwdunham/orgs","repos_url":"https://api.github.com/users/jrwdunham/repos","events_url":"https://api.github.com/users/jrwdunham/events{/privacy}","received_events_url":"https://api.github.com/users/jrwdunham/received_events","type":"User","site_admin":false},{"login":"jhsimpson","id":3083997,"avatar_url":"https://avatars2.githubusercontent.com/u/3083997?v=4","gravatar_id":"","url":"https://api.github.com/users/jhsimpson","html_url":"https://github.com/jhsimpson","followers_url":"https://api.github.com/users/jhsimpson/followers","following_url":"https://api.github.com/users/jhsimpson/following{/other_user}","gists_url":"https://api.github.com/users/jhsimpson/gists{/gist_id}","starred_url":"https://api.github.com/users/jhsimpson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhsimpson/subscriptions","organizations_url":"https://api.github.com/users/jhsimpson/orgs","repos_url":"https://api.github.com/users/jhsimpson/repos","events_url":"https://api.github.com/users/jhsimpson/events{/privacy}","received_events_url":"https://api.github.com/users/jhsimpson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JiscRDSS/archivematica/pulls/42/commits","review_comments_url":"https://api.github.com/repos/JiscRDSS/archivematica/pulls/42/comments","review_comment_url":"https://api.github.com/repos/JiscRDSS/archivematica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JiscRDSS/archivematica/issues/42/comments","statuses_url":"https://api.github.com/repos/JiscRDSS/archivematica/statuses/60ae55df27e158fe36c58a55f2f06e3d43216aee","head":{"label":"JiscRDSS:dev/jisc-issue-39","ref":"dev/jisc-issue-39","sha":"60ae55df27e158fe36c58a55f2f06e3d43216aee","user":{"login":"JiscRDSS","id":22818449,"avatar_url":"https://avatars0.githubusercontent.com/u/22818449?v=4","gravatar_id":"","url":"https://api.github.com/users/JiscRDSS","html_url":"https://github.com/JiscRDSS","followers_url":"https://api.github.com/users/JiscRDSS/followers","following_url":"https://api.github.com/users/JiscRDSS/following{/other_user}","gists_url":"https://api.github.com/users/JiscRDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/JiscRDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiscRDSS/subscriptions","organizations_url":"https://api.github.com/users/JiscRDSS/orgs","repos_url":"https://api.github.com/users/JiscRDSS/repos","events_url":"https://api.github.com/users/JiscRDSS/events{/privacy}","received_events_url":"https://api.github.com/users/JiscRDSS/received_events","type":"Organization","site_admin":false},"repo":{"id":86759422,"name":"archivematica","full_name":"JiscRDSS/archivematica","owner":{"login":"JiscRDSS","id":22818449,"avatar_url":"https://avatars0.githubusercontent.com/u/22818449?v=4","gravatar_id":"","url":"https://api.github.com/users/JiscRDSS","html_url":"https://github.com/JiscRDSS","followers_url":"https://api.github.com/users/JiscRDSS/followers","following_url":"https://api.github.com/users/JiscRDSS/following{/other_user}","gists_url":"https://api.github.com/users/JiscRDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/JiscRDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiscRDSS/subscriptions","organizations_url":"https://api.github.com/users/JiscRDSS/orgs","repos_url":"https://api.github.com/users/JiscRDSS/repos","events_url":"https://api.github.com/users/JiscRDSS/events{/privacy}","received_events_url":"https://api.github.com/users/JiscRDSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JiscRDSS/archivematica","description":"Free and open-source digital preservation system designed to maintain standards-based, long-term access to collections of digital objects.","fork":true,"url":"https://api.github.com/repos/JiscRDSS/archivematica","forks_url":"https://api.github.com/repos/JiscRDSS/archivematica/forks","keys_url":"https://api.github.com/repos/JiscRDSS/archivematica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiscRDSS/archivematica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiscRDSS/archivematica/teams","hooks_url":"https://api.github.com/repos/JiscRDSS/archivematica/hooks","issue_events_url":"https://api.github.com/repos/JiscRDSS/archivematica/issues/events{/number}","events_url":"https://api.github.com/repos/JiscRDSS/archivematica/events","assignees_url":"https://api.github.com/repos/JiscRDSS/archivematica/assignees{/user}","branches_url":"https://api.github.com/repos/JiscRDSS/archivematica/branches{/branch}","tags_url":"https://api.github.com/repos/JiscRDSS/archivematica/tags","blobs_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiscRDSS/archivematica/statuses/{sha}","languages_url":"https://api.github.com/repos/JiscRDSS/archivematica/languages","stargazers_url":"https://api.github.com/repos/JiscRDSS/archivematica/stargazers","contributors_url":"https://api.github.com/repos/JiscRDSS/archivematica/contributors","subscribers_url":"https://api.github.com/repos/JiscRDSS/archivematica/subscribers","subscription_url":"https://api.github.com/repos/JiscRDSS/archivematica/subscription","commits_url":"https://api.github.com/repos/JiscRDSS/archivematica/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiscRDSS/archivematica/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiscRDSS/archivematica/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiscRDSS/archivematica/contents/{+path}","compare_url":"https://api.github.com/repos/JiscRDSS/archivematica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiscRDSS/archivematica/merges","archive_url":"https://api.github.com/repos/JiscRDSS/archivematica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiscRDSS/archivematica/downloads","issues_url":"https://api.github.com/repos/JiscRDSS/archivematica/issues{/number}","pulls_url":"https://api.github.com/repos/JiscRDSS/archivematica/pulls{/number}","milestones_url":"https://api.github.com/repos/JiscRDSS/archivematica/milestones{/number}","notifications_url":"https://api.github.com/repos/JiscRDSS/archivematica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiscRDSS/archivematica/labels{/name}","releases_url":"https://api.github.com/repos/JiscRDSS/archivematica/releases{/id}","deployments_url":"https://api.github.com/repos/JiscRDSS/archivematica/deployments","created_at":"2017-03-30T23:51:05Z","updated_at":"2018-05-24T19:53:54Z","pushed_at":"2018-05-24T19:55:47Z","git_url":"git://github.com/JiscRDSS/archivematica.git","ssh_url":"git@github.com:JiscRDSS/archivematica.git","clone_url":"https://github.com/JiscRDSS/archivematica.git","svn_url":"https://github.com/JiscRDSS/archivematica","homepage":"http://www.archivematica.org","size":31118,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":11,"watchers":0,"default_branch":"qa/jisc"}},"base":{"label":"JiscRDSS:qa/jisc","ref":"qa/jisc","sha":"38a28ef8c1612e3869065fee132069a3d418d80e","user":{"login":"JiscRDSS","id":22818449,"avatar_url":"https://avatars0.githubusercontent.com/u/22818449?v=4","gravatar_id":"","url":"https://api.github.com/users/JiscRDSS","html_url":"https://github.com/JiscRDSS","followers_url":"https://api.github.com/users/JiscRDSS/followers","following_url":"https://api.github.com/users/JiscRDSS/following{/other_user}","gists_url":"https://api.github.com/users/JiscRDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/JiscRDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiscRDSS/subscriptions","organizations_url":"https://api.github.com/users/JiscRDSS/orgs","repos_url":"https://api.github.com/users/JiscRDSS/repos","events_url":"https://api.github.com/users/JiscRDSS/events{/privacy}","received_events_url":"https://api.github.com/users/JiscRDSS/received_events","type":"Organization","site_admin":false},"repo":{"id":86759422,"name":"archivematica","full_name":"JiscRDSS/archivematica","owner":{"login":"JiscRDSS","id":22818449,"avatar_url":"https://avatars0.githubusercontent.com/u/22818449?v=4","gravatar_id":"","url":"https://api.github.com/users/JiscRDSS","html_url":"https://github.com/JiscRDSS","followers_url":"https://api.github.com/users/JiscRDSS/followers","following_url":"https://api.github.com/users/JiscRDSS/following{/other_user}","gists_url":"https://api.github.com/users/JiscRDSS/gists{/gist_id}","starred_url":"https://api.github.com/users/JiscRDSS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JiscRDSS/subscriptions","organizations_url":"https://api.github.com/users/JiscRDSS/orgs","repos_url":"https://api.github.com/users/JiscRDSS/repos","events_url":"https://api.github.com/users/JiscRDSS/events{/privacy}","received_events_url":"https://api.github.com/users/JiscRDSS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JiscRDSS/archivematica","description":"Free and open-source digital preservation system designed to maintain standards-based, long-term access to collections of digital objects.","fork":true,"url":"https://api.github.com/repos/JiscRDSS/archivematica","forks_url":"https://api.github.com/repos/JiscRDSS/archivematica/forks","keys_url":"https://api.github.com/repos/JiscRDSS/archivematica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JiscRDSS/archivematica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JiscRDSS/archivematica/teams","hooks_url":"https://api.github.com/repos/JiscRDSS/archivematica/hooks","issue_events_url":"https://api.github.com/repos/JiscRDSS/archivematica/issues/events{/number}","events_url":"https://api.github.com/repos/JiscRDSS/archivematica/events","assignees_url":"https://api.github.com/repos/JiscRDSS/archivematica/assignees{/user}","branches_url":"https://api.github.com/repos/JiscRDSS/archivematica/branches{/branch}","tags_url":"https://api.github.com/repos/JiscRDSS/archivematica/tags","blobs_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/refs{/sha}","trees_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JiscRDSS/archivematica/statuses/{sha}","languages_url":"https://api.github.com/repos/JiscRDSS/archivematica/languages","stargazers_url":"https://api.github.com/repos/JiscRDSS/archivematica/stargazers","contributors_url":"https://api.github.com/repos/JiscRDSS/archivematica/contributors","subscribers_url":"https://api.github.com/repos/JiscRDSS/archivematica/subscribers","subscription_url":"https://api.github.com/repos/JiscRDSS/archivematica/subscription","commits_url":"https://api.github.com/repos/JiscRDSS/archivematica/commits{/sha}","git_commits_url":"https://api.github.com/repos/JiscRDSS/archivematica/git/commits{/sha}","comments_url":"https://api.github.com/repos/JiscRDSS/archivematica/comments{/number}","issue_comment_url":"https://api.github.com/repos/JiscRDSS/archivematica/issues/comments{/number}","contents_url":"https://api.github.com/repos/JiscRDSS/archivematica/contents/{+path}","compare_url":"https://api.github.com/repos/JiscRDSS/archivematica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JiscRDSS/archivematica/merges","archive_url":"https://api.github.com/repos/JiscRDSS/archivematica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JiscRDSS/archivematica/downloads","issues_url":"https://api.github.com/repos/JiscRDSS/archivematica/issues{/number}","pulls_url":"https://api.github.com/repos/JiscRDSS/archivematica/pulls{/number}","milestones_url":"https://api.github.com/repos/JiscRDSS/archivematica/milestones{/number}","notifications_url":"https://api.github.com/repos/JiscRDSS/archivematica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JiscRDSS/archivematica/labels{/name}","releases_url":"https://api.github.com/repos/JiscRDSS/archivematica/releases{/id}","deployments_url":"https://api.github.com/repos/JiscRDSS/archivematica/deployments","created_at":"2017-03-30T23:51:05Z","updated_at":"2018-05-24T19:53:54Z","pushed_at":"2018-05-24T19:55:47Z","git_url":"git://github.com/JiscRDSS/archivematica.git","ssh_url":"git@github.com:JiscRDSS/archivematica.git","clone_url":"https://github.com/JiscRDSS/archivematica.git","svn_url":"https://github.com/JiscRDSS/archivematica","homepage":"http://www.archivematica.org","size":31118,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":11,"watchers":0,"default_branch":"qa/jisc"}},"_links":{"self":{"href":"https://api.github.com/repos/JiscRDSS/archivematica/pulls/42"},"html":{"href":"https://github.com/JiscRDSS/archivematica/pull/42"},"issue":{"href":"https://api.github.com/repos/JiscRDSS/archivematica/issues/42"},"comments":{"href":"https://api.github.com/repos/JiscRDSS/archivematica/issues/42/comments"},"review_comments":{"href":"https://api.github.com/repos/JiscRDSS/archivematica/pulls/42/comments"},"review_comment":{"href":"https://api.github.com/repos/JiscRDSS/archivematica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JiscRDSS/archivematica/pulls/42/commits"},"statuses":{"href":"https://api.github.com/repos/JiscRDSS/archivematica/statuses/60ae55df27e158fe36c58a55f2f06e3d43216aee"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":5,"maintainer_can_modify":false,"commits":7,"additions":68,"deletions":13,"changed_files":5}}
{"actor":{"display_login":"sevein"}}