{"action":"created","issue":{"url":"https://api.github.com/repos/spotify/luigi/issues/2278","repository_url":"https://api.github.com/repos/spotify/luigi","labels_url":"https://api.github.com/repos/spotify/luigi/issues/2278/labels{/name}","comments_url":"https://api.github.com/repos/spotify/luigi/issues/2278/comments","events_url":"https://api.github.com/repos/spotify/luigi/issues/2278/events","html_url":"https://github.com/spotify/luigi/pull/2278","id":271907787,"node_id":"MDExOlB1bGxSZXF1ZXN0MTUxMTcwODc1","number":2278,"title":"Visible parameter for luigi.Parameters","user":{"login":"Gr1f0n6x","id":19765449,"node_id":"MDQ6VXNlcjE5NzY1NDQ5","avatar_url":"https://avatars1.githubusercontent.com/u/19765449?v=4","gravatar_id":"","url":"https://api.github.com/users/Gr1f0n6x","html_url":"https://github.com/Gr1f0n6x","followers_url":"https://api.github.com/users/Gr1f0n6x/followers","following_url":"https://api.github.com/users/Gr1f0n6x/following{/other_user}","gists_url":"https://api.github.com/users/Gr1f0n6x/gists{/gist_id}","starred_url":"https://api.github.com/users/Gr1f0n6x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gr1f0n6x/subscriptions","organizations_url":"https://api.github.com/users/Gr1f0n6x/orgs","repos_url":"https://api.github.com/users/Gr1f0n6x/repos","events_url":"https://api.github.com/users/Gr1f0n6x/events{/privacy}","received_events_url":"https://api.github.com/users/Gr1f0n6x/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":22,"created_at":"2017-11-07T16:58:46Z","updated_at":"2018-07-18T19:41:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spotify/luigi/pulls/2278","html_url":"https://github.com/spotify/luigi/pull/2278","diff_url":"https://github.com/spotify/luigi/pull/2278.diff","patch_url":"https://github.com/spotify/luigi/pull/2278.patch"},"body":"<!--- This template is optional. Please use it as a starting point to help guide PRs -->\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes -->\r\nVisible parameter for luigi.Parameter class which is needed to show/hide some parameters from WEB page such as passwords to database \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue -->\r\n\r\nWell, in my case this change is crucial because of some of my tasks connect to database and contain passwords for it which i don't want to show it from web page to all. \r\n\r\nIn code it will look like this:\r\n\r\n```\r\nclass MyTask(luigi.Task):\r\n    secret = luigi.Parameter(visible=False)    # default value for visible - True\r\n    public = luigi.Parameter()\r\n```\r\n\r\n## Have you tested this? If so, how?\r\n<!--- Valid responses are \"I have included unit tests.\" or --> \r\n<!--- \"I ran my jobs with this code and it works for me.\" -->\r\nI tested it on my tasks and it works fine. It just removes this parameters from node represents current task, so it shouldn't break any compatibility\r\n\r\n(Below images are just examples)\r\n**Before:**\r\n![image](https://user-images.githubusercontent.com/19765449/32505865-42cdf15c-c3f4-11e7-9ec4-762b09257b83.png)\r\n**After**:\r\n![image](https://user-images.githubusercontent.com/19765449/32506507-cf28d3aa-c3f5-11e7-963f-48d80ee1f2a9.png)\r\n\r\nMaybe, it will be helpful for others too in similar case\r\n<!---\r\nfor more information on how to submit valuable contributions,\r\nsee https://opensource.guide/how-to-contribute/#how-to-submit-a-contribution\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/spotify/luigi/issues/comments/406050375","html_url":"https://github.com/spotify/luigi/pull/2278#issuecomment-406050375","issue_url":"https://api.github.com/repos/spotify/luigi/issues/2278","id":406050375,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjA1MDM3NQ==","user":{"login":"Tarrasch","id":294349,"node_id":"MDQ6VXNlcjI5NDM0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/294349?v=4","gravatar_id":"","url":"https://api.github.com/users/Tarrasch","html_url":"https://github.com/Tarrasch","followers_url":"https://api.github.com/users/Tarrasch/followers","following_url":"https://api.github.com/users/Tarrasch/following{/other_user}","gists_url":"https://api.github.com/users/Tarrasch/gists{/gist_id}","starred_url":"https://api.github.com/users/Tarrasch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tarrasch/subscriptions","organizations_url":"https://api.github.com/users/Tarrasch/orgs","repos_url":"https://api.github.com/users/Tarrasch/repos","events_url":"https://api.github.com/users/Tarrasch/events{/privacy}","received_events_url":"https://api.github.com/users/Tarrasch/received_events","type":"User","site_admin":false},"created_at":"2018-07-18T19:41:18Z","updated_at":"2018-07-18T19:41:18Z","author_association":"COLLABORATOR","body":"Let me know when you've figured out the test failure."}}
{"actor":{"display_login":"Tarrasch"}}