{"action":"created","issue":{"url":"https://api.github.com/repos/tsgrp/HPI/issues/1625","repository_url":"https://api.github.com/repos/tsgrp/HPI","labels_url":"https://api.github.com/repos/tsgrp/HPI/issues/1625/labels{/name}","comments_url":"https://api.github.com/repos/tsgrp/HPI/issues/1625/comments","events_url":"https://api.github.com/repos/tsgrp/HPI/issues/1625/events","html_url":"https://github.com/tsgrp/HPI/issues/1625","id":297608897,"number":1625,"title":"Open in New Tab Fails in anything but Alfresco","user":{"login":"gsteimer","id":1377228,"avatar_url":"https://avatars3.githubusercontent.com/u/1377228?v=4","gravatar_id":"","url":"https://api.github.com/users/gsteimer","html_url":"https://github.com/gsteimer","followers_url":"https://api.github.com/users/gsteimer/followers","following_url":"https://api.github.com/users/gsteimer/following{/other_user}","gists_url":"https://api.github.com/users/gsteimer/gists{/gist_id}","starred_url":"https://api.github.com/users/gsteimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsteimer/subscriptions","organizations_url":"https://api.github.com/users/gsteimer/orgs","repos_url":"https://api.github.com/users/gsteimer/repos","events_url":"https://api.github.com/users/gsteimer/events{/privacy}","received_events_url":"https://api.github.com/users/gsteimer/received_events","type":"User","site_admin":false},"labels":[{"id":65515040,"url":"https://api.github.com/repos/tsgrp/HPI/labels/Documentum","name":"Documentum","color":"207de5","default":false},{"id":272482027,"url":"https://api.github.com/repos/tsgrp/HPI/labels/HBase","name":"HBase","color":"bfdadc","default":false},{"id":308319827,"url":"https://api.github.com/repos/tsgrp/HPI/labels/Solr","name":"Solr","color":"bfd4f2","default":false},{"id":45245432,"url":"https://api.github.com/repos/tsgrp/HPI/labels/issue","name":"issue","color":"fc2929","default":false},{"id":45245436,"url":"https://api.github.com/repos/tsgrp/HPI/labels/question","name":"question","color":"cc317c","default":true}],"state":"closed","locked":false,"assignee":{"login":"ZachGerth","id":14186924,"avatar_url":"https://avatars0.githubusercontent.com/u/14186924?v=4","gravatar_id":"","url":"https://api.github.com/users/ZachGerth","html_url":"https://github.com/ZachGerth","followers_url":"https://api.github.com/users/ZachGerth/followers","following_url":"https://api.github.com/users/ZachGerth/following{/other_user}","gists_url":"https://api.github.com/users/ZachGerth/gists{/gist_id}","starred_url":"https://api.github.com/users/ZachGerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZachGerth/subscriptions","organizations_url":"https://api.github.com/users/ZachGerth/orgs","repos_url":"https://api.github.com/users/ZachGerth/repos","events_url":"https://api.github.com/users/ZachGerth/events{/privacy}","received_events_url":"https://api.github.com/users/ZachGerth/received_events","type":"User","site_admin":false},"assignees":[{"login":"ZachGerth","id":14186924,"avatar_url":"https://avatars0.githubusercontent.com/u/14186924?v=4","gravatar_id":"","url":"https://api.github.com/users/ZachGerth","html_url":"https://github.com/ZachGerth","followers_url":"https://api.github.com/users/ZachGerth/followers","following_url":"https://api.github.com/users/ZachGerth/following{/other_user}","gists_url":"https://api.github.com/users/ZachGerth/gists{/gist_id}","starred_url":"https://api.github.com/users/ZachGerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZachGerth/subscriptions","organizations_url":"https://api.github.com/users/ZachGerth/orgs","repos_url":"https://api.github.com/users/ZachGerth/repos","events_url":"https://api.github.com/users/ZachGerth/events{/privacy}","received_events_url":"https://api.github.com/users/ZachGerth/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tsgrp/HPI/milestones/9","html_url":"https://github.com/tsgrp/HPI/milestone/9","labels_url":"https://api.github.com/repos/tsgrp/HPI/milestones/9/labels","id":2464517,"number":9,"title":"HPI 2.6","description":"Items tagged with the HPI 2.6 milestone are targeted to be fixed for the HPI 2.6 release","creator":{"login":"gsteimer","id":1377228,"avatar_url":"https://avatars3.githubusercontent.com/u/1377228?v=4","gravatar_id":"","url":"https://api.github.com/users/gsteimer","html_url":"https://github.com/gsteimer","followers_url":"https://api.github.com/users/gsteimer/followers","following_url":"https://api.github.com/users/gsteimer/following{/other_user}","gists_url":"https://api.github.com/users/gsteimer/gists{/gist_id}","starred_url":"https://api.github.com/users/gsteimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsteimer/subscriptions","organizations_url":"https://api.github.com/users/gsteimer/orgs","repos_url":"https://api.github.com/users/gsteimer/repos","events_url":"https://api.github.com/users/gsteimer/events{/privacy}","received_events_url":"https://api.github.com/users/gsteimer/received_events","type":"User","site_admin":false},"open_issues":108,"closed_issues":181,"state":"open","created_at":"2017-04-18T16:31:51Z","updated_at":"2018-02-16T21:49:42Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-02-15T21:50:42Z","updated_at":"2018-02-16T21:49:42Z","closed_at":"2018-02-16T21:49:42Z","author_association":"CONTRIBUTOR","body":"If you execute the open in new tab action in alfresco, the HPI and OC content URLs generated looks great:\r\n\r\nHPI URL: `/hpi/View/workspace://SpacesStore/fe63cdfb-e2ec-4b20-a830-ea490d655552/Fake%20Check%201.pdf`\r\n\r\nOC URL: `/alfresco/OpenContent/content/content/Fake%20Check%201.pdf?id=workspace%3A%2F%2FSpacesStore%2Ffe63cdfb-e2ec-4b20-a830-ea490d655552&overlay=true&contentType[]=pdf,txt,png,jpg,.*`\r\n\r\nHowever, when executing in Documentum, the HPI URL looks the same, but the OC URL completely misses the document ID, causing the view to fail:\r\n\r\nHPI URL: `/hpi/View/090000028002fb0f/2013%20Annual%20Report`\r\n\r\nOC URL: `/OpenContent/rest/content/content/090000028002fb0f_2013%20Annual%20Report?id=&overlay=true&contentType[]=pdf,txt,png,jpg,.*`\r\n\r\nNotice how the ID of the document is placed in the URL path and not in the `id` param.  There's also a `_` after the ID rather than `/`\r\n\r\nFrom looking at the code with @b-k-white it seems the problem is in this code in `router.js` which is Alfresco specific:\r\n\r\n```javascript\r\n        var indexToSplit = nthIndex(idAndName,'/',4);\r\n        var contentId = idAndName.substring(0,indexToSplit);\r\n        var name = idAndName.substring(indexToSplit + 1);\r\n```\r\n\r\nQuestion - why are we including the ID as a path param in the first place?  Wouldn't it be much easier to make it a query param on the URL?  Then we wouldn't need to care that there are slashes in the ID for Alfresco URLs...\r\n"},"comment":{"url":"https://api.github.com/repos/tsgrp/HPI/issues/comments/366368152","html_url":"https://github.com/tsgrp/HPI/issues/1625#issuecomment-366368152","issue_url":"https://api.github.com/repos/tsgrp/HPI/issues/1625","id":366368152,"user":{"login":"ZachGerth","id":14186924,"avatar_url":"https://avatars0.githubusercontent.com/u/14186924?v=4","gravatar_id":"","url":"https://api.github.com/users/ZachGerth","html_url":"https://github.com/ZachGerth","followers_url":"https://api.github.com/users/ZachGerth/followers","following_url":"https://api.github.com/users/ZachGerth/following{/other_user}","gists_url":"https://api.github.com/users/ZachGerth/gists{/gist_id}","starred_url":"https://api.github.com/users/ZachGerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZachGerth/subscriptions","organizations_url":"https://api.github.com/users/ZachGerth/orgs","repos_url":"https://api.github.com/users/ZachGerth/repos","events_url":"https://api.github.com/users/ZachGerth/events{/privacy}","received_events_url":"https://api.github.com/users/ZachGerth/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T21:49:42Z","updated_at":"2018-02-16T21:49:42Z","author_association":"NONE","body":"Resolved with Commit # 19897. IDs are now a query parameter and we encode them when necessary.\r\nCR - bwhite. "}}
{"actor":{"display_login":"ZachGerth"}}