{"action":"created","issue":{"url":"https://api.github.com/repos/coreshop/CoreShop/issues/580","repository_url":"https://api.github.com/repos/coreshop/CoreShop","labels_url":"https://api.github.com/repos/coreshop/CoreShop/issues/580/labels{/name}","comments_url":"https://api.github.com/repos/coreshop/CoreShop/issues/580/comments","events_url":"https://api.github.com/repos/coreshop/CoreShop/issues/580/events","html_url":"https://github.com/coreshop/CoreShop/issues/580","id":350162439,"node_id":"MDU6SXNzdWUzNTAxNjI0Mzk=","number":580,"title":"Rounding issue in Cart Overview","user":{"login":"solverat","id":700119,"node_id":"MDQ6VXNlcjcwMDExOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/700119?v=4","gravatar_id":"","url":"https://api.github.com/users/solverat","html_url":"https://github.com/solverat","followers_url":"https://api.github.com/users/solverat/followers","following_url":"https://api.github.com/users/solverat/following{/other_user}","gists_url":"https://api.github.com/users/solverat/gists{/gist_id}","starred_url":"https://api.github.com/users/solverat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solverat/subscriptions","organizations_url":"https://api.github.com/users/solverat/orgs","repos_url":"https://api.github.com/users/solverat/repos","events_url":"https://api.github.com/users/solverat/events{/privacy}","received_events_url":"https://api.github.com/users/solverat/received_events","type":"User","site_admin":false},"labels":[{"id":188368611,"node_id":"MDU6TGFiZWwxODgzNjg2MTE=","url":"https://api.github.com/repos/coreshop/CoreShop/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-13T19:31:54Z","updated_at":"2018-08-14T08:39:47Z","closed_at":null,"author_association":"COLLABORATOR","body":"| Q                | A\r\n| ---------------- | -----\r\n| Bug report?      | unknown / yes\r\n| Feature request? | no\r\n| BC Break report? | no\r\n| RFC?             | no\r\n\r\nCondition: All prices are without taxes\r\n\r\n- add product with price `15.90` and taxes of `7.7%`.\r\n- add product to cart\r\n- change amount to `2` eg. `4`\r\n\r\n## Current Result\r\n\r\n### List with 2 pieces\r\n![bildschirmfoto 2018-08-13 um 21 23 27](https://user-images.githubusercontent.com/700119/44053274-751bd3f0-9f3f-11e8-9723-6ee8390ad234.png)\r\n\r\n### List with 4 pieces\r\n![bildschirmfoto 2018-08-13 um 21 30 16](https://user-images.githubusercontent.com/700119/44053517-2f47c41e-9f40-11e8-8abb-d0aa2535345d.png)\r\n\r\n## Expected Result\r\n- Missmatch between subtotal and total taxes\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/coreshop/CoreShop/issues/comments/412798260","html_url":"https://github.com/coreshop/CoreShop/issues/580#issuecomment-412798260","issue_url":"https://api.github.com/repos/coreshop/CoreShop/issues/580","id":412798260,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjc5ODI2MA==","user":{"login":"dpfaffenbauer","id":5981845,"node_id":"MDQ6VXNlcjU5ODE4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5981845?v=4","gravatar_id":"","url":"https://api.github.com/users/dpfaffenbauer","html_url":"https://github.com/dpfaffenbauer","followers_url":"https://api.github.com/users/dpfaffenbauer/followers","following_url":"https://api.github.com/users/dpfaffenbauer/following{/other_user}","gists_url":"https://api.github.com/users/dpfaffenbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/dpfaffenbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpfaffenbauer/subscriptions","organizations_url":"https://api.github.com/users/dpfaffenbauer/orgs","repos_url":"https://api.github.com/users/dpfaffenbauer/repos","events_url":"https://api.github.com/users/dpfaffenbauer/events{/privacy}","received_events_url":"https://api.github.com/users/dpfaffenbauer/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T08:39:47Z","updated_at":"2018-08-14T08:39:47Z","author_association":"MEMBER","body":"Ok, its quite obvious why that happens. The reason is how CoreShop currently calculates taxes.\r\n\r\nExample for you to easier understand the problem:\r\n\r\nItem Price: `15.90`\r\nItem Price with tax: `17.12`\r\nTax: `1.22`\r\n\r\nTwo Items: `31,8`\r\nTwo items with tax: 34.248` => and that is where the issue happens.\r\n\r\nCoreShop doesn't currently calculate the total item price based on its whole tax value, it does it on multiplying the Item Price * Quantity. => 34,24 where the actual price should be 34.25\r\n\r\nI'll prepare a WIP PR for this."}}
{"actor":{"display_login":"dpfaffenbauer"}}