{"action":"created","comment":{"url":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/comments/192239621","pull_request_review_id":124978737,"id":192239621,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjIzOTYyMQ==","diff_hunk":"@@ -35,7 +35,7 @@\n ASCII_HEX_CHAR_REGEX = r'[0-9A-Fa-f]'\n \n # A regex used to match a date in the format YYYY/MM/DD\n-DATE_YYYY_MM_DD_REGEX = r'(\\d{4})/(\\d{2})/(\\d{2})'\n+DATE_YYYY_MM_DD_REGEX = r'(\\d{4})\\/(\\d{2})\\/(\\d{2})'","path":"mi/dataset/parser/common_regexes.py","position":5,"original_position":5,"commit_id":"bd1f809a020f897ca2217fe9d43e950da1b8bd97","original_commit_id":"bd1f809a020f897ca2217fe9d43e950da1b8bd97","user":{"login":"renegelinas","id":13528715,"node_id":"MDQ6VXNlcjEzNTI4NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/13528715?v=4","gravatar_id":"","url":"https://api.github.com/users/renegelinas","html_url":"https://github.com/renegelinas","followers_url":"https://api.github.com/users/renegelinas/followers","following_url":"https://api.github.com/users/renegelinas/following{/other_user}","gists_url":"https://api.github.com/users/renegelinas/gists{/gist_id}","starred_url":"https://api.github.com/users/renegelinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renegelinas/subscriptions","organizations_url":"https://api.github.com/users/renegelinas/orgs","repos_url":"https://api.github.com/users/renegelinas/repos","events_url":"https://api.github.com/users/renegelinas/events{/privacy}","received_events_url":"https://api.github.com/users/renegelinas/received_events","type":"User","site_admin":false},"body":"That's a good question.  I believe it's the difference between the python re package and the regex testers I was using online.  I believe it worked because re took the '/' as literals as it should have, but the tools saw that the '/' was an error in the regex that it was used.  The tool said it needed to be escaped.  Since the '/' are supposed to be taken literally, I saw no harm in adding the '\\' escape character.  This was not needed to fix this issue, but it was obvious that it was safer to escape those '/''s.","created_at":"2018-05-31T21:14:20Z","updated_at":"2018-05-31T21:14:20Z","html_url":"https://github.com/oceanobservatories/mi-instrument/pull/52#discussion_r192239621","pull_request_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/52","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/comments/192239621"},"html":{"href":"https://github.com/oceanobservatories/mi-instrument/pull/52#discussion_r192239621"},"pull_request":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/52"}},"in_reply_to_id":192234659},"pull_request":{"url":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/52","id":191868410,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxODY4NDEw","html_url":"https://github.com/oceanobservatories/mi-instrument/pull/52","diff_url":"https://github.com/oceanobservatories/mi-instrument/pull/52.diff","patch_url":"https://github.com/oceanobservatories/mi-instrument/pull/52.patch","issue_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/issues/52","number":52,"state":"open","locked":false,"title":"Issue #13245 - Fixed REGEX in the flort_dj_dcl parser.","user":{"login":"renegelinas","id":13528715,"node_id":"MDQ6VXNlcjEzNTI4NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/13528715?v=4","gravatar_id":"","url":"https://api.github.com/users/renegelinas","html_url":"https://github.com/renegelinas","followers_url":"https://api.github.com/users/renegelinas/followers","following_url":"https://api.github.com/users/renegelinas/following{/other_user}","gists_url":"https://api.github.com/users/renegelinas/gists{/gist_id}","starred_url":"https://api.github.com/users/renegelinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renegelinas/subscriptions","organizations_url":"https://api.github.com/users/renegelinas/orgs","repos_url":"https://api.github.com/users/renegelinas/repos","events_url":"https://api.github.com/users/renegelinas/events{/privacy}","received_events_url":"https://api.github.com/users/renegelinas/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-31T20:43:26Z","updated_at":"2018-05-31T21:14:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e2e06bfd6de4ccd29fc9fdcc0997ede3f0b7aff","assignee":null,"assignees":[],"requested_reviewers":[{"login":"PhilTran01","id":1438814,"node_id":"MDQ6VXNlcjE0Mzg4MTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1438814?v=4","gravatar_id":"","url":"https://api.github.com/users/PhilTran01","html_url":"https://github.com/PhilTran01","followers_url":"https://api.github.com/users/PhilTran01/followers","following_url":"https://api.github.com/users/PhilTran01/following{/other_user}","gists_url":"https://api.github.com/users/PhilTran01/gists{/gist_id}","starred_url":"https://api.github.com/users/PhilTran01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhilTran01/subscriptions","organizations_url":"https://api.github.com/users/PhilTran01/orgs","repos_url":"https://api.github.com/users/PhilTran01/repos","events_url":"https://api.github.com/users/PhilTran01/events{/privacy}","received_events_url":"https://api.github.com/users/PhilTran01/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/52/commits","review_comments_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/52/comments","review_comment_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/issues/52/comments","statuses_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/statuses/bd1f809a020f897ca2217fe9d43e950da1b8bd97","head":{"label":"renegelinas:rm13245","ref":"rm13245","sha":"bd1f809a020f897ca2217fe9d43e950da1b8bd97","user":{"login":"renegelinas","id":13528715,"node_id":"MDQ6VXNlcjEzNTI4NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/13528715?v=4","gravatar_id":"","url":"https://api.github.com/users/renegelinas","html_url":"https://github.com/renegelinas","followers_url":"https://api.github.com/users/renegelinas/followers","following_url":"https://api.github.com/users/renegelinas/following{/other_user}","gists_url":"https://api.github.com/users/renegelinas/gists{/gist_id}","starred_url":"https://api.github.com/users/renegelinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renegelinas/subscriptions","organizations_url":"https://api.github.com/users/renegelinas/orgs","repos_url":"https://api.github.com/users/renegelinas/repos","events_url":"https://api.github.com/users/renegelinas/events{/privacy}","received_events_url":"https://api.github.com/users/renegelinas/received_events","type":"User","site_admin":false},"repo":{"id":40263087,"node_id":"MDEwOlJlcG9zaXRvcnk0MDI2MzA4Nw==","name":"mi-instrument","full_name":"renegelinas/mi-instrument","owner":{"login":"renegelinas","id":13528715,"node_id":"MDQ6VXNlcjEzNTI4NzE1","avatar_url":"https://avatars2.githubusercontent.com/u/13528715?v=4","gravatar_id":"","url":"https://api.github.com/users/renegelinas","html_url":"https://github.com/renegelinas","followers_url":"https://api.github.com/users/renegelinas/followers","following_url":"https://api.github.com/users/renegelinas/following{/other_user}","gists_url":"https://api.github.com/users/renegelinas/gists{/gist_id}","starred_url":"https://api.github.com/users/renegelinas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renegelinas/subscriptions","organizations_url":"https://api.github.com/users/renegelinas/orgs","repos_url":"https://api.github.com/users/renegelinas/repos","events_url":"https://api.github.com/users/renegelinas/events{/privacy}","received_events_url":"https://api.github.com/users/renegelinas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renegelinas/mi-instrument","description":null,"fork":true,"url":"https://api.github.com/repos/renegelinas/mi-instrument","forks_url":"https://api.github.com/repos/renegelinas/mi-instrument/forks","keys_url":"https://api.github.com/repos/renegelinas/mi-instrument/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renegelinas/mi-instrument/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renegelinas/mi-instrument/teams","hooks_url":"https://api.github.com/repos/renegelinas/mi-instrument/hooks","issue_events_url":"https://api.github.com/repos/renegelinas/mi-instrument/issues/events{/number}","events_url":"https://api.github.com/repos/renegelinas/mi-instrument/events","assignees_url":"https://api.github.com/repos/renegelinas/mi-instrument/assignees{/user}","branches_url":"https://api.github.com/repos/renegelinas/mi-instrument/branches{/branch}","tags_url":"https://api.github.com/repos/renegelinas/mi-instrument/tags","blobs_url":"https://api.github.com/repos/renegelinas/mi-instrument/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renegelinas/mi-instrument/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renegelinas/mi-instrument/git/refs{/sha}","trees_url":"https://api.github.com/repos/renegelinas/mi-instrument/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renegelinas/mi-instrument/statuses/{sha}","languages_url":"https://api.github.com/repos/renegelinas/mi-instrument/languages","stargazers_url":"https://api.github.com/repos/renegelinas/mi-instrument/stargazers","contributors_url":"https://api.github.com/repos/renegelinas/mi-instrument/contributors","subscribers_url":"https://api.github.com/repos/renegelinas/mi-instrument/subscribers","subscription_url":"https://api.github.com/repos/renegelinas/mi-instrument/subscription","commits_url":"https://api.github.com/repos/renegelinas/mi-instrument/commits{/sha}","git_commits_url":"https://api.github.com/repos/renegelinas/mi-instrument/git/commits{/sha}","comments_url":"https://api.github.com/repos/renegelinas/mi-instrument/comments{/number}","issue_comment_url":"https://api.github.com/repos/renegelinas/mi-instrument/issues/comments{/number}","contents_url":"https://api.github.com/repos/renegelinas/mi-instrument/contents/{+path}","compare_url":"https://api.github.com/repos/renegelinas/mi-instrument/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renegelinas/mi-instrument/merges","archive_url":"https://api.github.com/repos/renegelinas/mi-instrument/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renegelinas/mi-instrument/downloads","issues_url":"https://api.github.com/repos/renegelinas/mi-instrument/issues{/number}","pulls_url":"https://api.github.com/repos/renegelinas/mi-instrument/pulls{/number}","milestones_url":"https://api.github.com/repos/renegelinas/mi-instrument/milestones{/number}","notifications_url":"https://api.github.com/repos/renegelinas/mi-instrument/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renegelinas/mi-instrument/labels{/name}","releases_url":"https://api.github.com/repos/renegelinas/mi-instrument/releases{/id}","deployments_url":"https://api.github.com/repos/renegelinas/mi-instrument/deployments","created_at":"2015-08-05T18:48:45Z","updated_at":"2018-05-31T20:10:20Z","pushed_at":"2018-05-31T20:39:09Z","git_url":"git://github.com/renegelinas/mi-instrument.git","ssh_url":"git@github.com:renegelinas/mi-instrument.git","clone_url":"https://github.com/renegelinas/mi-instrument.git","svn_url":"https://github.com/renegelinas/mi-instrument","homepage":null,"size":151101,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oceanobservatories:master","ref":"master","sha":"392de8654cb070825a354a8e586342fed9f8f2b0","user":{"login":"oceanobservatories","id":8750280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NTAyODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8750280?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanobservatories","html_url":"https://github.com/oceanobservatories","followers_url":"https://api.github.com/users/oceanobservatories/followers","following_url":"https://api.github.com/users/oceanobservatories/following{/other_user}","gists_url":"https://api.github.com/users/oceanobservatories/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanobservatories/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanobservatories/subscriptions","organizations_url":"https://api.github.com/users/oceanobservatories/orgs","repos_url":"https://api.github.com/users/oceanobservatories/repos","events_url":"https://api.github.com/users/oceanobservatories/events{/privacy}","received_events_url":"https://api.github.com/users/oceanobservatories/received_events","type":"Organization","site_admin":false},"repo":{"id":24165325,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE2NTMyNQ==","name":"mi-instrument","full_name":"oceanobservatories/mi-instrument","owner":{"login":"oceanobservatories","id":8750280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg3NTAyODA=","avatar_url":"https://avatars0.githubusercontent.com/u/8750280?v=4","gravatar_id":"","url":"https://api.github.com/users/oceanobservatories","html_url":"https://github.com/oceanobservatories","followers_url":"https://api.github.com/users/oceanobservatories/followers","following_url":"https://api.github.com/users/oceanobservatories/following{/other_user}","gists_url":"https://api.github.com/users/oceanobservatories/gists{/gist_id}","starred_url":"https://api.github.com/users/oceanobservatories/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oceanobservatories/subscriptions","organizations_url":"https://api.github.com/users/oceanobservatories/orgs","repos_url":"https://api.github.com/users/oceanobservatories/repos","events_url":"https://api.github.com/users/oceanobservatories/events{/privacy}","received_events_url":"https://api.github.com/users/oceanobservatories/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oceanobservatories/mi-instrument","description":null,"fork":false,"url":"https://api.github.com/repos/oceanobservatories/mi-instrument","forks_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/forks","keys_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/teams","hooks_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/hooks","issue_events_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/issues/events{/number}","events_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/events","assignees_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/assignees{/user}","branches_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/branches{/branch}","tags_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/tags","blobs_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/git/refs{/sha}","trees_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/statuses/{sha}","languages_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/languages","stargazers_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/stargazers","contributors_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/contributors","subscribers_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/subscribers","subscription_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/subscription","commits_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/commits{/sha}","git_commits_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/git/commits{/sha}","comments_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/comments{/number}","issue_comment_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/issues/comments{/number}","contents_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/contents/{+path}","compare_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/merges","archive_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/downloads","issues_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/issues{/number}","pulls_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls{/number}","milestones_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/milestones{/number}","notifications_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/labels{/name}","releases_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/releases{/id}","deployments_url":"https://api.github.com/repos/oceanobservatories/mi-instrument/deployments","created_at":"2014-09-17T22:53:22Z","updated_at":"2018-05-21T19:00:23Z","pushed_at":"2018-05-31T20:43:27Z","git_url":"git://github.com/oceanobservatories/mi-instrument.git","ssh_url":"git@github.com:oceanobservatories/mi-instrument.git","clone_url":"https://github.com/oceanobservatories/mi-instrument.git","svn_url":"https://github.com/oceanobservatories/mi-instrument","homepage":null,"size":155539,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":26,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/52"},"html":{"href":"https://github.com/oceanobservatories/mi-instrument/pull/52"},"issue":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/issues/52"},"comments":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/oceanobservatories/mi-instrument/statuses/bd1f809a020f897ca2217fe9d43e950da1b8bd97"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"renegelinas"}}