{"action":"closed","number":58,"pull_request":{"url":"https://api.github.com/repos/awslabs/certlint/pulls/58","id":171794702,"html_url":"https://github.com/awslabs/certlint/pull/58","diff_url":"https://github.com/awslabs/certlint/pull/58.diff","patch_url":"https://github.com/awslabs/certlint/pull/58.patch","issue_url":"https://api.github.com/repos/awslabs/certlint/issues/58","number":58,"state":"closed","locked":false,"title":"The MONTHS_39 and DAYS_365 constants are off-by-one","user":{"login":"robstradling","id":958624,"avatar_url":"https://avatars2.githubusercontent.com/u/958624?v=4","gravatar_id":"","url":"https://api.github.com/users/robstradling","html_url":"https://github.com/robstradling","followers_url":"https://api.github.com/users/robstradling/followers","following_url":"https://api.github.com/users/robstradling/following{/other_user}","gists_url":"https://api.github.com/users/robstradling/gists{/gist_id}","starred_url":"https://api.github.com/users/robstradling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstradling/subscriptions","organizations_url":"https://api.github.com/users/robstradling/orgs","repos_url":"https://api.github.com/users/robstradling/repos","events_url":"https://api.github.com/users/robstradling/events{/privacy}","received_events_url":"https://api.github.com/users/robstradling/received_events","type":"User","site_admin":false},"body":"BR v1.5.6 section 6.3.2 says...\r\n- \"Subscriber Certificates issued **after 1 July 2016** ... MUST have a Validity Period no greater than 39 months\", which means that the effective date is 2nd July 2016.  But previously, BR v1.4.3 section 6.3.2 said \"Except as provided for below, Subscriber Certificates issued **after 1 April 2015** MUST have a Validity Period no greater than 39 months\", which means that the effective date was 2nd April 2015.\t\r\n- \"Subscriber Certificates issued **after 1 March 2018** MUST have a Validity Period no greater than 825 days\", which means that the effective date is 2nd March 2018.","created_at":"2018-02-27T21:49:53Z","updated_at":"2018-03-01T20:12:09Z","closed_at":"2018-03-01T20:12:09Z","merged_at":"2018-03-01T20:12:09Z","merge_commit_sha":"0a057bdd01c964c8b1874eb20df4dc5bb8bc46bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awslabs/certlint/pulls/58/commits","review_comments_url":"https://api.github.com/repos/awslabs/certlint/pulls/58/comments","review_comment_url":"https://api.github.com/repos/awslabs/certlint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awslabs/certlint/issues/58/comments","statuses_url":"https://api.github.com/repos/awslabs/certlint/statuses/cef18967242f27578e067d00f96622f485d06dc0","head":{"label":"robstradling:effective_dates_off_by_one","ref":"effective_dates_off_by_one","sha":"cef18967242f27578e067d00f96622f485d06dc0","user":{"login":"robstradling","id":958624,"avatar_url":"https://avatars2.githubusercontent.com/u/958624?v=4","gravatar_id":"","url":"https://api.github.com/users/robstradling","html_url":"https://github.com/robstradling","followers_url":"https://api.github.com/users/robstradling/followers","following_url":"https://api.github.com/users/robstradling/following{/other_user}","gists_url":"https://api.github.com/users/robstradling/gists{/gist_id}","starred_url":"https://api.github.com/users/robstradling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstradling/subscriptions","organizations_url":"https://api.github.com/users/robstradling/orgs","repos_url":"https://api.github.com/users/robstradling/repos","events_url":"https://api.github.com/users/robstradling/events{/privacy}","received_events_url":"https://api.github.com/users/robstradling/received_events","type":"User","site_admin":false},"repo":{"id":50577484,"name":"certlint","full_name":"robstradling/certlint","owner":{"login":"robstradling","id":958624,"avatar_url":"https://avatars2.githubusercontent.com/u/958624?v=4","gravatar_id":"","url":"https://api.github.com/users/robstradling","html_url":"https://github.com/robstradling","followers_url":"https://api.github.com/users/robstradling/followers","following_url":"https://api.github.com/users/robstradling/following{/other_user}","gists_url":"https://api.github.com/users/robstradling/gists{/gist_id}","starred_url":"https://api.github.com/users/robstradling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstradling/subscriptions","organizations_url":"https://api.github.com/users/robstradling/orgs","repos_url":"https://api.github.com/users/robstradling/repos","events_url":"https://api.github.com/users/robstradling/events{/privacy}","received_events_url":"https://api.github.com/users/robstradling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robstradling/certlint","description":"X.509 certificate linter","fork":true,"url":"https://api.github.com/repos/robstradling/certlint","forks_url":"https://api.github.com/repos/robstradling/certlint/forks","keys_url":"https://api.github.com/repos/robstradling/certlint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robstradling/certlint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robstradling/certlint/teams","hooks_url":"https://api.github.com/repos/robstradling/certlint/hooks","issue_events_url":"https://api.github.com/repos/robstradling/certlint/issues/events{/number}","events_url":"https://api.github.com/repos/robstradling/certlint/events","assignees_url":"https://api.github.com/repos/robstradling/certlint/assignees{/user}","branches_url":"https://api.github.com/repos/robstradling/certlint/branches{/branch}","tags_url":"https://api.github.com/repos/robstradling/certlint/tags","blobs_url":"https://api.github.com/repos/robstradling/certlint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robstradling/certlint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robstradling/certlint/git/refs{/sha}","trees_url":"https://api.github.com/repos/robstradling/certlint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robstradling/certlint/statuses/{sha}","languages_url":"https://api.github.com/repos/robstradling/certlint/languages","stargazers_url":"https://api.github.com/repos/robstradling/certlint/stargazers","contributors_url":"https://api.github.com/repos/robstradling/certlint/contributors","subscribers_url":"https://api.github.com/repos/robstradling/certlint/subscribers","subscription_url":"https://api.github.com/repos/robstradling/certlint/subscription","commits_url":"https://api.github.com/repos/robstradling/certlint/commits{/sha}","git_commits_url":"https://api.github.com/repos/robstradling/certlint/git/commits{/sha}","comments_url":"https://api.github.com/repos/robstradling/certlint/comments{/number}","issue_comment_url":"https://api.github.com/repos/robstradling/certlint/issues/comments{/number}","contents_url":"https://api.github.com/repos/robstradling/certlint/contents/{+path}","compare_url":"https://api.github.com/repos/robstradling/certlint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robstradling/certlint/merges","archive_url":"https://api.github.com/repos/robstradling/certlint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robstradling/certlint/downloads","issues_url":"https://api.github.com/repos/robstradling/certlint/issues{/number}","pulls_url":"https://api.github.com/repos/robstradling/certlint/pulls{/number}","milestones_url":"https://api.github.com/repos/robstradling/certlint/milestones{/number}","notifications_url":"https://api.github.com/repos/robstradling/certlint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robstradling/certlint/labels{/name}","releases_url":"https://api.github.com/repos/robstradling/certlint/releases{/id}","deployments_url":"https://api.github.com/repos/robstradling/certlint/deployments","created_at":"2016-01-28T11:10:35Z","updated_at":"2017-08-07T13:23:45Z","pushed_at":"2018-02-27T21:34:40Z","git_url":"git://github.com/robstradling/certlint.git","ssh_url":"git@github.com:robstradling/certlint.git","clone_url":"https://github.com/robstradling/certlint.git","svn_url":"https://github.com/robstradling/certlint","homepage":null,"size":6690,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awslabs:master","ref":"master","sha":"47738278f1959a3e0ad0089cf7452ba953888155","user":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"repo":{"id":49677306,"name":"certlint","full_name":"awslabs/certlint","owner":{"login":"awslabs","id":3299148,"avatar_url":"https://avatars0.githubusercontent.com/u/3299148?v=4","gravatar_id":"","url":"https://api.github.com/users/awslabs","html_url":"https://github.com/awslabs","followers_url":"https://api.github.com/users/awslabs/followers","following_url":"https://api.github.com/users/awslabs/following{/other_user}","gists_url":"https://api.github.com/users/awslabs/gists{/gist_id}","starred_url":"https://api.github.com/users/awslabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awslabs/subscriptions","organizations_url":"https://api.github.com/users/awslabs/orgs","repos_url":"https://api.github.com/users/awslabs/repos","events_url":"https://api.github.com/users/awslabs/events{/privacy}","received_events_url":"https://api.github.com/users/awslabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/awslabs/certlint","description":"X.509 certificate linter","fork":false,"url":"https://api.github.com/repos/awslabs/certlint","forks_url":"https://api.github.com/repos/awslabs/certlint/forks","keys_url":"https://api.github.com/repos/awslabs/certlint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awslabs/certlint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awslabs/certlint/teams","hooks_url":"https://api.github.com/repos/awslabs/certlint/hooks","issue_events_url":"https://api.github.com/repos/awslabs/certlint/issues/events{/number}","events_url":"https://api.github.com/repos/awslabs/certlint/events","assignees_url":"https://api.github.com/repos/awslabs/certlint/assignees{/user}","branches_url":"https://api.github.com/repos/awslabs/certlint/branches{/branch}","tags_url":"https://api.github.com/repos/awslabs/certlint/tags","blobs_url":"https://api.github.com/repos/awslabs/certlint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awslabs/certlint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awslabs/certlint/git/refs{/sha}","trees_url":"https://api.github.com/repos/awslabs/certlint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awslabs/certlint/statuses/{sha}","languages_url":"https://api.github.com/repos/awslabs/certlint/languages","stargazers_url":"https://api.github.com/repos/awslabs/certlint/stargazers","contributors_url":"https://api.github.com/repos/awslabs/certlint/contributors","subscribers_url":"https://api.github.com/repos/awslabs/certlint/subscribers","subscription_url":"https://api.github.com/repos/awslabs/certlint/subscription","commits_url":"https://api.github.com/repos/awslabs/certlint/commits{/sha}","git_commits_url":"https://api.github.com/repos/awslabs/certlint/git/commits{/sha}","comments_url":"https://api.github.com/repos/awslabs/certlint/comments{/number}","issue_comment_url":"https://api.github.com/repos/awslabs/certlint/issues/comments{/number}","contents_url":"https://api.github.com/repos/awslabs/certlint/contents/{+path}","compare_url":"https://api.github.com/repos/awslabs/certlint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awslabs/certlint/merges","archive_url":"https://api.github.com/repos/awslabs/certlint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awslabs/certlint/downloads","issues_url":"https://api.github.com/repos/awslabs/certlint/issues{/number}","pulls_url":"https://api.github.com/repos/awslabs/certlint/pulls{/number}","milestones_url":"https://api.github.com/repos/awslabs/certlint/milestones{/number}","notifications_url":"https://api.github.com/repos/awslabs/certlint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awslabs/certlint/labels{/name}","releases_url":"https://api.github.com/repos/awslabs/certlint/releases{/id}","deployments_url":"https://api.github.com/repos/awslabs/certlint/deployments","created_at":"2016-01-14T21:46:01Z","updated_at":"2018-02-22T09:42:27Z","pushed_at":"2018-03-01T20:12:09Z","git_url":"git://github.com/awslabs/certlint.git","ssh_url":"git@github.com:awslabs/certlint.git","clone_url":"https://github.com/awslabs/certlint.git","svn_url":"https://github.com/awslabs/certlint","homepage":null,"size":6697,"stargazers_count":103,"watchers_count":103,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":24,"open_issues":9,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awslabs/certlint/pulls/58"},"html":{"href":"https://github.com/awslabs/certlint/pull/58"},"issue":{"href":"https://api.github.com/repos/awslabs/certlint/issues/58"},"comments":{"href":"https://api.github.com/repos/awslabs/certlint/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/awslabs/certlint/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/awslabs/certlint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awslabs/certlint/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/awslabs/certlint/statuses/cef18967242f27578e067d00f96622f485d06dc0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pzb","id":217247,"avatar_url":"https://avatars3.githubusercontent.com/u/217247?v=4","gravatar_id":"","url":"https://api.github.com/users/pzb","html_url":"https://github.com/pzb","followers_url":"https://api.github.com/users/pzb/followers","following_url":"https://api.github.com/users/pzb/following{/other_user}","gists_url":"https://api.github.com/users/pzb/gists{/gist_id}","starred_url":"https://api.github.com/users/pzb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pzb/subscriptions","organizations_url":"https://api.github.com/users/pzb/orgs","repos_url":"https://api.github.com/users/pzb/repos","events_url":"https://api.github.com/users/pzb/events{/privacy}","received_events_url":"https://api.github.com/users/pzb/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"pzb"}}