{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/joinhandshake/seira/pulls/36","id":172697050,"html_url":"https://github.com/joinhandshake/seira/pull/36","diff_url":"https://github.com/joinhandshake/seira/pull/36.diff","patch_url":"https://github.com/joinhandshake/seira/pull/36.patch","issue_url":"https://api.github.com/repos/joinhandshake/seira/issues/36","number":36,"state":"closed","locked":false,"title":"more granular control over node pools","user":{"login":"sgringwe","id":2362370,"avatar_url":"https://avatars3.githubusercontent.com/u/2362370?v=4","gravatar_id":"","url":"https://api.github.com/users/sgringwe","html_url":"https://github.com/sgringwe","followers_url":"https://api.github.com/users/sgringwe/followers","following_url":"https://api.github.com/users/sgringwe/following{/other_user}","gists_url":"https://api.github.com/users/sgringwe/gists{/gist_id}","starred_url":"https://api.github.com/users/sgringwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgringwe/subscriptions","organizations_url":"https://api.github.com/users/sgringwe/orgs","repos_url":"https://api.github.com/users/sgringwe/repos","events_url":"https://api.github.com/users/sgringwe/events{/privacy}","received_events_url":"https://api.github.com/users/sgringwe/received_events","type":"User","site_admin":false},"body":"The goal here is more granular control over cluster upgrades, node pool changes, and generally managing node pools.\r\n\r\nA few advantages:\r\n\r\n- easier to do node pool changes such as instance size\r\n- can be more careful during upgrades, which is already generally scary\r\n- can build up more micro functionality on top of these smaller actions\r\n\r\nMostly this was moving code from your original method into this new file :)","created_at":"2018-03-04T01:28:35Z","updated_at":"2018-03-05T18:32:17Z","closed_at":"2018-03-05T18:32:17Z","merged_at":"2018-03-05T18:32:17Z","merge_commit_sha":"4171ae7167219baa23c241749a90dab2f248e878","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joinhandshake/seira/pulls/36/commits","review_comments_url":"https://api.github.com/repos/joinhandshake/seira/pulls/36/comments","review_comment_url":"https://api.github.com/repos/joinhandshake/seira/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joinhandshake/seira/issues/36/comments","statuses_url":"https://api.github.com/repos/joinhandshake/seira/statuses/ead105293d1505a0959c04dd259b6709f43c8a33","head":{"label":"joinhandshake:more-node-pool-control","ref":"more-node-pool-control","sha":"ead105293d1505a0959c04dd259b6709f43c8a33","user":{"login":"joinhandshake","id":2332267,"avatar_url":"https://avatars1.githubusercontent.com/u/2332267?v=4","gravatar_id":"","url":"https://api.github.com/users/joinhandshake","html_url":"https://github.com/joinhandshake","followers_url":"https://api.github.com/users/joinhandshake/followers","following_url":"https://api.github.com/users/joinhandshake/following{/other_user}","gists_url":"https://api.github.com/users/joinhandshake/gists{/gist_id}","starred_url":"https://api.github.com/users/joinhandshake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joinhandshake/subscriptions","organizations_url":"https://api.github.com/users/joinhandshake/orgs","repos_url":"https://api.github.com/users/joinhandshake/repos","events_url":"https://api.github.com/users/joinhandshake/events{/privacy}","received_events_url":"https://api.github.com/users/joinhandshake/received_events","type":"Organization","site_admin":false},"repo":{"id":112038127,"name":"seira","full_name":"joinhandshake/seira","owner":{"login":"joinhandshake","id":2332267,"avatar_url":"https://avatars1.githubusercontent.com/u/2332267?v=4","gravatar_id":"","url":"https://api.github.com/users/joinhandshake","html_url":"https://github.com/joinhandshake","followers_url":"https://api.github.com/users/joinhandshake/followers","following_url":"https://api.github.com/users/joinhandshake/following{/other_user}","gists_url":"https://api.github.com/users/joinhandshake/gists{/gist_id}","starred_url":"https://api.github.com/users/joinhandshake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joinhandshake/subscriptions","organizations_url":"https://api.github.com/users/joinhandshake/orgs","repos_url":"https://api.github.com/users/joinhandshake/repos","events_url":"https://api.github.com/users/joinhandshake/events{/privacy}","received_events_url":"https://api.github.com/users/joinhandshake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joinhandshake/seira","description":"An opinionated library for using Kubernetes","fork":false,"url":"https://api.github.com/repos/joinhandshake/seira","forks_url":"https://api.github.com/repos/joinhandshake/seira/forks","keys_url":"https://api.github.com/repos/joinhandshake/seira/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joinhandshake/seira/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joinhandshake/seira/teams","hooks_url":"https://api.github.com/repos/joinhandshake/seira/hooks","issue_events_url":"https://api.github.com/repos/joinhandshake/seira/issues/events{/number}","events_url":"https://api.github.com/repos/joinhandshake/seira/events","assignees_url":"https://api.github.com/repos/joinhandshake/seira/assignees{/user}","branches_url":"https://api.github.com/repos/joinhandshake/seira/branches{/branch}","tags_url":"https://api.github.com/repos/joinhandshake/seira/tags","blobs_url":"https://api.github.com/repos/joinhandshake/seira/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joinhandshake/seira/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joinhandshake/seira/git/refs{/sha}","trees_url":"https://api.github.com/repos/joinhandshake/seira/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joinhandshake/seira/statuses/{sha}","languages_url":"https://api.github.com/repos/joinhandshake/seira/languages","stargazers_url":"https://api.github.com/repos/joinhandshake/seira/stargazers","contributors_url":"https://api.github.com/repos/joinhandshake/seira/contributors","subscribers_url":"https://api.github.com/repos/joinhandshake/seira/subscribers","subscription_url":"https://api.github.com/repos/joinhandshake/seira/subscription","commits_url":"https://api.github.com/repos/joinhandshake/seira/commits{/sha}","git_commits_url":"https://api.github.com/repos/joinhandshake/seira/git/commits{/sha}","comments_url":"https://api.github.com/repos/joinhandshake/seira/comments{/number}","issue_comment_url":"https://api.github.com/repos/joinhandshake/seira/issues/comments{/number}","contents_url":"https://api.github.com/repos/joinhandshake/seira/contents/{+path}","compare_url":"https://api.github.com/repos/joinhandshake/seira/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joinhandshake/seira/merges","archive_url":"https://api.github.com/repos/joinhandshake/seira/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joinhandshake/seira/downloads","issues_url":"https://api.github.com/repos/joinhandshake/seira/issues{/number}","pulls_url":"https://api.github.com/repos/joinhandshake/seira/pulls{/number}","milestones_url":"https://api.github.com/repos/joinhandshake/seira/milestones{/number}","notifications_url":"https://api.github.com/repos/joinhandshake/seira/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joinhandshake/seira/labels{/name}","releases_url":"https://api.github.com/repos/joinhandshake/seira/releases{/id}","deployments_url":"https://api.github.com/repos/joinhandshake/seira/deployments","created_at":"2017-11-25T22:16:14Z","updated_at":"2017-11-26T22:59:23Z","pushed_at":"2018-03-05T18:32:17Z","git_url":"git://github.com/joinhandshake/seira.git","ssh_url":"git@github.com:joinhandshake/seira.git","clone_url":"https://github.com/joinhandshake/seira.git","svn_url":"https://github.com/joinhandshake/seira","homepage":null,"size":156,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joinhandshake:master","ref":"master","sha":"b6189ce7f05303ace6d3fbfeea79e4b708ba28a2","user":{"login":"joinhandshake","id":2332267,"avatar_url":"https://avatars1.githubusercontent.com/u/2332267?v=4","gravatar_id":"","url":"https://api.github.com/users/joinhandshake","html_url":"https://github.com/joinhandshake","followers_url":"https://api.github.com/users/joinhandshake/followers","following_url":"https://api.github.com/users/joinhandshake/following{/other_user}","gists_url":"https://api.github.com/users/joinhandshake/gists{/gist_id}","starred_url":"https://api.github.com/users/joinhandshake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joinhandshake/subscriptions","organizations_url":"https://api.github.com/users/joinhandshake/orgs","repos_url":"https://api.github.com/users/joinhandshake/repos","events_url":"https://api.github.com/users/joinhandshake/events{/privacy}","received_events_url":"https://api.github.com/users/joinhandshake/received_events","type":"Organization","site_admin":false},"repo":{"id":112038127,"name":"seira","full_name":"joinhandshake/seira","owner":{"login":"joinhandshake","id":2332267,"avatar_url":"https://avatars1.githubusercontent.com/u/2332267?v=4","gravatar_id":"","url":"https://api.github.com/users/joinhandshake","html_url":"https://github.com/joinhandshake","followers_url":"https://api.github.com/users/joinhandshake/followers","following_url":"https://api.github.com/users/joinhandshake/following{/other_user}","gists_url":"https://api.github.com/users/joinhandshake/gists{/gist_id}","starred_url":"https://api.github.com/users/joinhandshake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joinhandshake/subscriptions","organizations_url":"https://api.github.com/users/joinhandshake/orgs","repos_url":"https://api.github.com/users/joinhandshake/repos","events_url":"https://api.github.com/users/joinhandshake/events{/privacy}","received_events_url":"https://api.github.com/users/joinhandshake/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joinhandshake/seira","description":"An opinionated library for using Kubernetes","fork":false,"url":"https://api.github.com/repos/joinhandshake/seira","forks_url":"https://api.github.com/repos/joinhandshake/seira/forks","keys_url":"https://api.github.com/repos/joinhandshake/seira/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joinhandshake/seira/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joinhandshake/seira/teams","hooks_url":"https://api.github.com/repos/joinhandshake/seira/hooks","issue_events_url":"https://api.github.com/repos/joinhandshake/seira/issues/events{/number}","events_url":"https://api.github.com/repos/joinhandshake/seira/events","assignees_url":"https://api.github.com/repos/joinhandshake/seira/assignees{/user}","branches_url":"https://api.github.com/repos/joinhandshake/seira/branches{/branch}","tags_url":"https://api.github.com/repos/joinhandshake/seira/tags","blobs_url":"https://api.github.com/repos/joinhandshake/seira/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joinhandshake/seira/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joinhandshake/seira/git/refs{/sha}","trees_url":"https://api.github.com/repos/joinhandshake/seira/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joinhandshake/seira/statuses/{sha}","languages_url":"https://api.github.com/repos/joinhandshake/seira/languages","stargazers_url":"https://api.github.com/repos/joinhandshake/seira/stargazers","contributors_url":"https://api.github.com/repos/joinhandshake/seira/contributors","subscribers_url":"https://api.github.com/repos/joinhandshake/seira/subscribers","subscription_url":"https://api.github.com/repos/joinhandshake/seira/subscription","commits_url":"https://api.github.com/repos/joinhandshake/seira/commits{/sha}","git_commits_url":"https://api.github.com/repos/joinhandshake/seira/git/commits{/sha}","comments_url":"https://api.github.com/repos/joinhandshake/seira/comments{/number}","issue_comment_url":"https://api.github.com/repos/joinhandshake/seira/issues/comments{/number}","contents_url":"https://api.github.com/repos/joinhandshake/seira/contents/{+path}","compare_url":"https://api.github.com/repos/joinhandshake/seira/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joinhandshake/seira/merges","archive_url":"https://api.github.com/repos/joinhandshake/seira/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joinhandshake/seira/downloads","issues_url":"https://api.github.com/repos/joinhandshake/seira/issues{/number}","pulls_url":"https://api.github.com/repos/joinhandshake/seira/pulls{/number}","milestones_url":"https://api.github.com/repos/joinhandshake/seira/milestones{/number}","notifications_url":"https://api.github.com/repos/joinhandshake/seira/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joinhandshake/seira/labels{/name}","releases_url":"https://api.github.com/repos/joinhandshake/seira/releases{/id}","deployments_url":"https://api.github.com/repos/joinhandshake/seira/deployments","created_at":"2017-11-25T22:16:14Z","updated_at":"2017-11-26T22:59:23Z","pushed_at":"2018-03-05T18:32:17Z","git_url":"git://github.com/joinhandshake/seira.git","ssh_url":"git@github.com:joinhandshake/seira.git","clone_url":"https://github.com/joinhandshake/seira.git","svn_url":"https://github.com/joinhandshake/seira","homepage":null,"size":156,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joinhandshake/seira/pulls/36"},"html":{"href":"https://github.com/joinhandshake/seira/pull/36"},"issue":{"href":"https://api.github.com/repos/joinhandshake/seira/issues/36"},"comments":{"href":"https://api.github.com/repos/joinhandshake/seira/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/joinhandshake/seira/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/joinhandshake/seira/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joinhandshake/seira/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/joinhandshake/seira/statuses/ead105293d1505a0959c04dd259b6709f43c8a33"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"sgringwe","id":2362370,"avatar_url":"https://avatars3.githubusercontent.com/u/2362370?v=4","gravatar_id":"","url":"https://api.github.com/users/sgringwe","html_url":"https://github.com/sgringwe","followers_url":"https://api.github.com/users/sgringwe/followers","following_url":"https://api.github.com/users/sgringwe/following{/other_user}","gists_url":"https://api.github.com/users/sgringwe/gists{/gist_id}","starred_url":"https://api.github.com/users/sgringwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgringwe/subscriptions","organizations_url":"https://api.github.com/users/sgringwe/orgs","repos_url":"https://api.github.com/users/sgringwe/repos","events_url":"https://api.github.com/users/sgringwe/events{/privacy}","received_events_url":"https://api.github.com/users/sgringwe/received_events","type":"User","site_admin":false},"comments":0,"review_comments":4,"maintainer_can_modify":false,"commits":2,"additions":219,"deletions":105,"changed_files":4}}
{"actor":{"display_login":"sgringwe"}}