{"action":"closed","number":2881,"pull_request":{"url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2881","id":172761954,"html_url":"https://github.com/TerriaJS/terriajs/pull/2881","diff_url":"https://github.com/TerriaJS/terriajs/pull/2881.diff","patch_url":"https://github.com/TerriaJS/terriajs/pull/2881.patch","issue_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2881","number":2881,"state":"closed","locked":false,"title":"Fix issue #2818: column names with white space break featureInfoTpl","user":{"login":"t83714","id":674387,"avatar_url":"https://avatars3.githubusercontent.com/u/674387?v=4","gravatar_id":"","url":"https://api.github.com/users/t83714","html_url":"https://github.com/t83714","followers_url":"https://api.github.com/users/t83714/followers","following_url":"https://api.github.com/users/t83714/following{/other_user}","gists_url":"https://api.github.com/users/t83714/gists{/gist_id}","starred_url":"https://api.github.com/users/t83714/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t83714/subscriptions","organizations_url":"https://api.github.com/users/t83714/orgs","repos_url":"https://api.github.com/users/t83714/repos","events_url":"https://api.github.com/users/t83714/events{/privacy}","received_events_url":"https://api.github.com/users/t83714/received_events","type":"User","site_admin":false},"body":"Fix issue #2818 \r\n\r\nThis issue can be reproduced by the following catalog config:\r\n```\r\n{\r\n    \"version\": \"0.0.05\",\r\n    \"initSources\": [\r\n        {\r\n            \"catalog\": [\r\n                {\r\n                    \"name\": \"Bird Migration\",\r\n                    \"type\": \"csv\",\r\n                    \"url\": \"https://gist.githubusercontent.com/RacingTadpole/f308c8d01630b3d0b15d946e259b0cff/raw/266b62cab3716d76fe4c24f9788489ebfd8c7efa/bird_migration.csv\",\r\n                    \"isEnabled\": true,\r\n                    \"zoomOnEnable\": true,\r\n                    \"tableStyle\": {\r\n                        \"columns\": {\r\n                            \"speed\": {\r\n                                \"name\": \"super velocity\",\r\n                                \"format\": {\r\n                                    \"maximumFractionDigits\": 0\r\n                                }\r\n                            },\r\n                            \"bad\": {\r\n                                \"type\": \"hidden\"\r\n                            }\r\n                        }\r\n                    },\r\n                    \"featureInfoTemplate\": {\r\n                        \"template\": \"<h2>{{terria.timeSeries.title}}<h2><chart x-column={{terria.timeSeries.xName}} y-column={{terria.timeSeries.yName}} id={{terria.timeSeries.id}} column-units={{terria.timeSeries.units}}>{{terria.timeSeries.data}}</chart>\"\r\n                    }\r\n                }\r\n            ]\r\n        }\r\n    ]\r\n}\r\n```\r\n ** And [this URL] **(http://nationalmap.gov.au/#start=%7B%22version%22%3A%220.0.05%22%2C%22initSources%22%3A%5B%7B%22catalog%22%3A%5B%7B%22name%22%3A%22Bird%20Migration%22%2C%22type%22%3A%22csv%22%2C%22url%22%3A%22https%3A%2F%2Fgist.githubusercontent.com%2FRacingTadpole%2Ff308c8d01630b3d0b15d946e259b0cff%2Fraw%2F266b62cab3716d76fe4c24f9788489ebfd8c7efa%2Fbird_migration.csv%22%2C%22isEnabled%22%3Atrue%2C%22zoomOnEnable%22%3Atrue%2C%22tableStyle%22%3A%7B%22columns%22%3A%7B%22speed%22%3A%7B%22name%22%3A%22super%20velocity%22%2C%22format%22%3A%7B%22maximumFractionDigits%22%3A0%7D%7D%2C%22bad%22%3A%7B%22type%22%3A%22hidden%22%7D%7D%7D%2C%22featureInfoTemplate%22%3A%7B%22template%22%3A%22%3Ch2%3E%7B%7Bterria.timeSeries.title%7D%7D%3Ch2%3E%3Cchart%20x-column%3D%7B%7Bterria.timeSeries.xName%7D%7D%20y-column%3D%7B%7Bterria.timeSeries.yName%7D%7D%20id%3D%7B%7Bterria.timeSeries.id%7D%7D%20column-units%3D%7B%7Bterria.timeSeries.units%7D%7D%3E%7B%7Bterria.timeSeries.data%7D%7D%3C%2Fchart%3E%22%7D%7D%5D%7D%5D%7D)\r\n\r\n","created_at":"2018-03-05T02:41:10Z","updated_at":"2018-03-05T03:12:04Z","closed_at":"2018-03-05T03:12:04Z","merged_at":null,"merge_commit_sha":"0a29303c0cf71e277a96f838b0880549366f7a92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2881/commits","review_comments_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2881/comments","review_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/2881/comments","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/01d14cb18bee1620a984b123f630624bd6a0a020","head":{"label":"TerriaJS:issue/2818-tpl-space-issue","ref":"issue/2818-tpl-space-issue","sha":"01d14cb18bee1620a984b123f630624bd6a0a020","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars3.githubusercontent.com/u/12078432?v=4","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"terriajs","full_name":"TerriaJS/terriajs","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars3.githubusercontent.com/u/12078432?v=4","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/terriajs","description":"A library for building rich, web-based geospatial data explorers.","fork":false,"url":"https://api.github.com/repos/TerriaJS/terriajs","forks_url":"https://api.github.com/repos/TerriaJS/terriajs/forks","keys_url":"https://api.github.com/repos/TerriaJS/terriajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/terriajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/terriajs/teams","hooks_url":"https://api.github.com/repos/TerriaJS/terriajs/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/terriajs/events","assignees_url":"https://api.github.com/repos/TerriaJS/terriajs/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/terriajs/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/terriajs/tags","blobs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/terriajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/terriajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/terriajs/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/terriajs/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/terriajs/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/terriajs/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/terriajs/subscription","commits_url":"https://api.github.com/repos/TerriaJS/terriajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/terriajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/terriajs/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/terriajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/terriajs/merges","archive_url":"https://api.github.com/repos/TerriaJS/terriajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/terriajs/downloads","issues_url":"https://api.github.com/repos/TerriaJS/terriajs/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/terriajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/terriajs/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/terriajs/deployments","created_at":"2014-02-25T06:30:13Z","updated_at":"2018-03-02T19:19:41Z","pushed_at":"2018-03-05T02:52:40Z","git_url":"git://github.com/TerriaJS/terriajs.git","ssh_url":"git@github.com:TerriaJS/terriajs.git","clone_url":"https://github.com/TerriaJS/terriajs.git","svn_url":"https://github.com/TerriaJS/terriajs","homepage":"http://terria.io","size":34599,"stargazers_count":290,"watchers_count":290,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":267,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":114,"open_issues":267,"watchers":290,"default_branch":"master"}},"base":{"label":"TerriaJS:master","ref":"master","sha":"64befa4a68a8805816567a18797c88e145a0a7ae","user":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars3.githubusercontent.com/u/12078432?v=4","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17163720,"name":"terriajs","full_name":"TerriaJS/terriajs","owner":{"login":"TerriaJS","id":12078432,"avatar_url":"https://avatars3.githubusercontent.com/u/12078432?v=4","gravatar_id":"","url":"https://api.github.com/users/TerriaJS","html_url":"https://github.com/TerriaJS","followers_url":"https://api.github.com/users/TerriaJS/followers","following_url":"https://api.github.com/users/TerriaJS/following{/other_user}","gists_url":"https://api.github.com/users/TerriaJS/gists{/gist_id}","starred_url":"https://api.github.com/users/TerriaJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TerriaJS/subscriptions","organizations_url":"https://api.github.com/users/TerriaJS/orgs","repos_url":"https://api.github.com/users/TerriaJS/repos","events_url":"https://api.github.com/users/TerriaJS/events{/privacy}","received_events_url":"https://api.github.com/users/TerriaJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TerriaJS/terriajs","description":"A library for building rich, web-based geospatial data explorers.","fork":false,"url":"https://api.github.com/repos/TerriaJS/terriajs","forks_url":"https://api.github.com/repos/TerriaJS/terriajs/forks","keys_url":"https://api.github.com/repos/TerriaJS/terriajs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TerriaJS/terriajs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TerriaJS/terriajs/teams","hooks_url":"https://api.github.com/repos/TerriaJS/terriajs/hooks","issue_events_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/events{/number}","events_url":"https://api.github.com/repos/TerriaJS/terriajs/events","assignees_url":"https://api.github.com/repos/TerriaJS/terriajs/assignees{/user}","branches_url":"https://api.github.com/repos/TerriaJS/terriajs/branches{/branch}","tags_url":"https://api.github.com/repos/TerriaJS/terriajs/tags","blobs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TerriaJS/terriajs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TerriaJS/terriajs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TerriaJS/terriajs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TerriaJS/terriajs/statuses/{sha}","languages_url":"https://api.github.com/repos/TerriaJS/terriajs/languages","stargazers_url":"https://api.github.com/repos/TerriaJS/terriajs/stargazers","contributors_url":"https://api.github.com/repos/TerriaJS/terriajs/contributors","subscribers_url":"https://api.github.com/repos/TerriaJS/terriajs/subscribers","subscription_url":"https://api.github.com/repos/TerriaJS/terriajs/subscription","commits_url":"https://api.github.com/repos/TerriaJS/terriajs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TerriaJS/terriajs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TerriaJS/terriajs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TerriaJS/terriajs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TerriaJS/terriajs/contents/{+path}","compare_url":"https://api.github.com/repos/TerriaJS/terriajs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TerriaJS/terriajs/merges","archive_url":"https://api.github.com/repos/TerriaJS/terriajs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TerriaJS/terriajs/downloads","issues_url":"https://api.github.com/repos/TerriaJS/terriajs/issues{/number}","pulls_url":"https://api.github.com/repos/TerriaJS/terriajs/pulls{/number}","milestones_url":"https://api.github.com/repos/TerriaJS/terriajs/milestones{/number}","notifications_url":"https://api.github.com/repos/TerriaJS/terriajs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TerriaJS/terriajs/labels{/name}","releases_url":"https://api.github.com/repos/TerriaJS/terriajs/releases{/id}","deployments_url":"https://api.github.com/repos/TerriaJS/terriajs/deployments","created_at":"2014-02-25T06:30:13Z","updated_at":"2018-03-02T19:19:41Z","pushed_at":"2018-03-05T02:52:40Z","git_url":"git://github.com/TerriaJS/terriajs.git","ssh_url":"git@github.com:TerriaJS/terriajs.git","clone_url":"https://github.com/TerriaJS/terriajs.git","svn_url":"https://github.com/TerriaJS/terriajs","homepage":"http://terria.io","size":34599,"stargazers_count":290,"watchers_count":290,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":114,"mirror_url":null,"archived":false,"open_issues_count":267,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":114,"open_issues":267,"watchers":290,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2881"},"html":{"href":"https://github.com/TerriaJS/terriajs/pull/2881"},"issue":{"href":"https://api.github.com/repos/TerriaJS/terriajs/issues/2881"},"comments":{"href":"https://api.github.com/repos/TerriaJS/terriajs/issues/2881/comments"},"review_comments":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2881/comments"},"review_comment":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TerriaJS/terriajs/pulls/2881/commits"},"statuses":{"href":"https://api.github.com/repos/TerriaJS/terriajs/statuses/01d14cb18bee1620a984b123f630624bd6a0a020"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"t83714"}}