{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/comments/177050327","pull_request_review_id":106854642,"id":177050327,"diff_hunk":"@@ -213,6 +213,66 @@ resource \"aws_cloudwatch_metric_alarm\" \"db_storagealarm\" {\n   treat_missing_data = \"breaching\"\n }\n \n+resource \"aws_cloudwatch_metric_alarm\" \"db_burstbalancealarm\" {\n+  count               = \"${var.db-instance-count}\"\n+  alarm_name          = \"${var.Env-Name}-db-burstbalanace-alarm\"\n+  comparison_operator = \"LessThanOrEqualToThreshold\"\n+  evaluation_periods  = \"1\"\n+  metric_name         = \"BurstBalance\"\n+  namespace           = \"AWS/RDS\"\n+  period              = \"60\"\n+  statistic           = \"Minimum\"\n+  threshold           = \"45\"\n+\n+  dimensions {\n+    DBInstanceIdentifier = \"${aws_db_instance.db.identifier}\"\n+  }\n+\n+  alarm_description  = \"This metric monitors the IOPS burst balance available for the DB.\"\n+  alarm_actions      = [\"${var.critical-notifications-arn}\"]\n+  treat_missing_data = \"breaching\"\n+}\n+\n+resource \"aws_cloudwatch_metric_alarm\" \"rr_burstbalancealarm\" {\n+  count               = \"${var.db-replica-count}\"\n+  alarm_name          = \"${var.Env-Name}-rr-burstbalanace-alarm\"\n+  comparison_operator = \"LessThanOrEqualToThreshold\"\n+  evaluation_periods  = \"1\"\n+  metric_name         = \"BurstBalance\"\n+  namespace           = \"AWS/RDS\"\n+  period              = \"60\"\n+  statistic           = \"Minimum\"\n+  threshold           = \"45\"\n+\n+  dimensions {\n+    DBInstanceIdentifier = \"${aws_db_instance.read_replica.identifier}\"\n+  }\n+\n+  alarm_description  = \"This metric monitors the IOPS burst balance available for the DB read replica.\"\n+  alarm_actions      = [\"${var.capacity-notifications-arn}\"]\n+  treat_missing_data = \"breaching\"\n+}\n+\n+resource \"aws_cloudwatch_metric_alarm\" \"rr_laggingalarm\" {\n+  count               = \"${var.db-replica-count}\"\n+  alarm_name          = \"${var.Env-Name}-rr-lagging-alarm\"\n+  comparison_operator = \"GreaterThanOrEqualToThreshold\"\n+  evaluation_periods  = \"1\"\n+  metric_name         = \"ReplicaLag\"\n+  namespace           = \"AWS/RDS\"\n+  period              = \"60\"\n+  statistic           = \"Minimum\"\n+  threshold           = \"300\"\n+\n+  dimensions {\n+    DBInstanceIdentifier = \"${aws_db_instance.read_replica.identifier}\"\n+  }\n+\n+  alarm_description  = \"This metric monitors the IOPS burst balance available for the DB read replica.\"","path":"govwifi-backend/db.tf","position":39,"original_position":59,"commit_id":"d4595d1b3f013ff16f653bdd4849fdae6fa42eb2","original_commit_id":"86314ffbf6323b70d21102b719077875aa4eb68d","user":{"login":"adrianclay","id":976274,"avatar_url":"https://avatars2.githubusercontent.com/u/976274?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianclay","html_url":"https://github.com/adrianclay","followers_url":"https://api.github.com/users/adrianclay/followers","following_url":"https://api.github.com/users/adrianclay/following{/other_user}","gists_url":"https://api.github.com/users/adrianclay/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianclay/subscriptions","organizations_url":"https://api.github.com/users/adrianclay/orgs","repos_url":"https://api.github.com/users/adrianclay/repos","events_url":"https://api.github.com/users/adrianclay/events{/privacy}","received_events_url":"https://api.github.com/users/adrianclay/received_events","type":"User","site_admin":false},"body":"GitHub rendered the diff poorly, you've already fixed the one it should be showing again.","created_at":"2018-03-26T10:54:21Z","updated_at":"2018-03-26T10:54:22Z","html_url":"https://github.com/alphagov/govwifi-terraform/pull/25#discussion_r177050327","pull_request_url":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/25","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/comments/177050327"},"html":{"href":"https://github.com/alphagov/govwifi-terraform/pull/25#discussion_r177050327"},"pull_request":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/25"}},"in_reply_to_id":177035172},"pull_request":{"url":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/25","id":177393295,"html_url":"https://github.com/alphagov/govwifi-terraform/pull/25","diff_url":"https://github.com/alphagov/govwifi-terraform/pull/25.diff","patch_url":"https://github.com/alphagov/govwifi-terraform/pull/25.patch","issue_url":"https://api.github.com/repos/alphagov/govwifi-terraform/issues/25","number":25,"state":"closed","locked":false,"title":"Add new alarms for BurstBalance and ReplicaLag on RDS","user":{"login":"RyanMacG","id":341231,"avatar_url":"https://avatars1.githubusercontent.com/u/341231?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanMacG","html_url":"https://github.com/RyanMacG","followers_url":"https://api.github.com/users/RyanMacG/followers","following_url":"https://api.github.com/users/RyanMacG/following{/other_user}","gists_url":"https://api.github.com/users/RyanMacG/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanMacG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanMacG/subscriptions","organizations_url":"https://api.github.com/users/RyanMacG/orgs","repos_url":"https://api.github.com/users/RyanMacG/repos","events_url":"https://api.github.com/users/RyanMacG/events{/privacy}","received_events_url":"https://api.github.com/users/RyanMacG/received_events","type":"User","site_admin":false},"body":"We have encountered issues recently with the BurstBalance being heavily depleted\nwhich in turn causes the Read Replica to lag behind. To highlight when\nthese situations occur we want to add better reporting around these metrics.","created_at":"2018-03-26T09:47:53Z","updated_at":"2018-03-26T10:54:22Z","closed_at":"2018-03-26T10:22:49Z","merged_at":"2018-03-26T10:22:49Z","merge_commit_sha":"c09de4272928138de1d84dc4919af06d63e4413a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/25/commits","review_comments_url":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/25/comments","review_comment_url":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govwifi-terraform/issues/25/comments","statuses_url":"https://api.github.com/repos/alphagov/govwifi-terraform/statuses/d4595d1b3f013ff16f653bdd4849fdae6fa42eb2","head":{"label":"alphagov:add-rds-alarms","ref":"add-rds-alarms","sha":"d4595d1b3f013ff16f653bdd4849fdae6fa42eb2","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":83412971,"name":"govwifi-terraform","full_name":"alphagov/govwifi-terraform","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govwifi-terraform","description":"Terraform scripts to provision the GovWifi infrastructure on AWS","fork":false,"url":"https://api.github.com/repos/alphagov/govwifi-terraform","forks_url":"https://api.github.com/repos/alphagov/govwifi-terraform/forks","keys_url":"https://api.github.com/repos/alphagov/govwifi-terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govwifi-terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govwifi-terraform/teams","hooks_url":"https://api.github.com/repos/alphagov/govwifi-terraform/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govwifi-terraform/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govwifi-terraform/events","assignees_url":"https://api.github.com/repos/alphagov/govwifi-terraform/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govwifi-terraform/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govwifi-terraform/tags","blobs_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govwifi-terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govwifi-terraform/languages","stargazers_url":"https://api.github.com/repos/alphagov/govwifi-terraform/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govwifi-terraform/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govwifi-terraform/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govwifi-terraform/subscription","commits_url":"https://api.github.com/repos/alphagov/govwifi-terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govwifi-terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govwifi-terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govwifi-terraform/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govwifi-terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govwifi-terraform/merges","archive_url":"https://api.github.com/repos/alphagov/govwifi-terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govwifi-terraform/downloads","issues_url":"https://api.github.com/repos/alphagov/govwifi-terraform/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govwifi-terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govwifi-terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govwifi-terraform/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govwifi-terraform/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govwifi-terraform/deployments","created_at":"2017-02-28T09:16:12Z","updated_at":"2018-03-26T10:22:51Z","pushed_at":"2018-03-26T10:22:55Z","git_url":"git://github.com/alphagov/govwifi-terraform.git","ssh_url":"git@github.com:alphagov/govwifi-terraform.git","clone_url":"https://github.com/alphagov/govwifi-terraform.git","svn_url":"https://github.com/alphagov/govwifi-terraform","homepage":null,"size":63,"stargazers_count":1,"watchers_count":1,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"6d756b324120a808589f33affd0228e30980b5b6","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":83412971,"name":"govwifi-terraform","full_name":"alphagov/govwifi-terraform","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars0.githubusercontent.com/u/596977?v=4","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govwifi-terraform","description":"Terraform scripts to provision the GovWifi infrastructure on AWS","fork":false,"url":"https://api.github.com/repos/alphagov/govwifi-terraform","forks_url":"https://api.github.com/repos/alphagov/govwifi-terraform/forks","keys_url":"https://api.github.com/repos/alphagov/govwifi-terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govwifi-terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govwifi-terraform/teams","hooks_url":"https://api.github.com/repos/alphagov/govwifi-terraform/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govwifi-terraform/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govwifi-terraform/events","assignees_url":"https://api.github.com/repos/alphagov/govwifi-terraform/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govwifi-terraform/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govwifi-terraform/tags","blobs_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govwifi-terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govwifi-terraform/languages","stargazers_url":"https://api.github.com/repos/alphagov/govwifi-terraform/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govwifi-terraform/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govwifi-terraform/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govwifi-terraform/subscription","commits_url":"https://api.github.com/repos/alphagov/govwifi-terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govwifi-terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govwifi-terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govwifi-terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govwifi-terraform/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govwifi-terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govwifi-terraform/merges","archive_url":"https://api.github.com/repos/alphagov/govwifi-terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govwifi-terraform/downloads","issues_url":"https://api.github.com/repos/alphagov/govwifi-terraform/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govwifi-terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govwifi-terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govwifi-terraform/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govwifi-terraform/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govwifi-terraform/deployments","created_at":"2017-02-28T09:16:12Z","updated_at":"2018-03-26T10:22:51Z","pushed_at":"2018-03-26T10:22:55Z","git_url":"git://github.com/alphagov/govwifi-terraform.git","ssh_url":"git@github.com:alphagov/govwifi-terraform.git","clone_url":"https://github.com/alphagov/govwifi-terraform.git","svn_url":"https://github.com/alphagov/govwifi-terraform","homepage":null,"size":63,"stargazers_count":1,"watchers_count":1,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/25"},"html":{"href":"https://github.com/alphagov/govwifi-terraform/pull/25"},"issue":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/issues/25"},"comments":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govwifi-terraform/statuses/d4595d1b3f013ff16f653bdd4849fdae6fa42eb2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"adrianclay"}}