{"action":"created","comment":{"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments/173599986","pull_request_review_id":102827283,"id":173599986,"diff_hunk":"@@ -150,26 +149,38 @@ public NextAction apply(Packet packet) {\n       V1VolumeMount volumeMountSecret = new V1VolumeMount();\n       volumeMountSecret.setName(\"secrets\");\n       volumeMountSecret.setMountPath(\"/weblogic-operator/secrets\");\n+      volumeMountSecret.setReadOnly(true);\n       container.addVolumeMountsItem(volumeMountSecret);\n \n+      V1VolumeMount volumeMountScripts = new V1VolumeMount();\n+      volumeMountScripts.setName(\"scripts\");\n+      volumeMountScripts.setMountPath(\"/weblogic-operator/scripts\");\n+      volumeMountScripts.setReadOnly(true);\n+      container.addVolumeMountsItem(volumeMountScripts);\n+\n       container.addCommandItem(\"/shared/domain/\" + weblogicDomainName + \"/servers/\" + spec.getAsName() + \"/nodemgr_home/startServer.sh\");\n \n       V1Probe readinessProbe = new V1Probe();\n-      V1HTTPGetAction httpGet = new V1HTTPGetAction();\n-      httpGet.setPath(\"/weblogic/ready\");\n-      httpGet.setPort(new IntOrString(spec.getAsPort()));\n-      readinessProbe.setHttpGet(httpGet);\n-      readinessProbe.setInitialDelaySeconds(15);\n+      V1ExecAction readinessAction = new V1ExecAction();\n+      readinessAction.addCommandItem(\"/weblogic-operator/scripts/readinessProbe.sh\");\n+      readinessAction.addCommandItem(weblogicDomainName);\n+      readinessAction.addCommandItem(spec.getAsName());\n+      readinessProbe.exec(readinessAction);\n+      readinessProbe.setInitialDelaySeconds(2);\n       readinessProbe.setTimeoutSeconds(5);\n-      readinessProbe.setPeriodSeconds(15);\n+      readinessProbe.setPeriodSeconds(10);","path":"src/main/java/oracle/kubernetes/operator/helpers/PodHelper.java","position":53,"original_position":53,"commit_id":"40e3b1903f68c68e2ab8de70f0631c3d345c5eeb","original_commit_id":"40e3b1903f68c68e2ab8de70f0631c3d345c5eeb","user":{"login":"tbarnes-us","id":28605968,"avatar_url":"https://avatars2.githubusercontent.com/u/28605968?v=4","gravatar_id":"","url":"https://api.github.com/users/tbarnes-us","html_url":"https://github.com/tbarnes-us","followers_url":"https://api.github.com/users/tbarnes-us/followers","following_url":"https://api.github.com/users/tbarnes-us/following{/other_user}","gists_url":"https://api.github.com/users/tbarnes-us/gists{/gist_id}","starred_url":"https://api.github.com/users/tbarnes-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbarnes-us/subscriptions","organizations_url":"https://api.github.com/users/tbarnes-us/orgs","repos_url":"https://api.github.com/users/tbarnes-us/repos","events_url":"https://api.github.com/users/tbarnes-us/events{/privacy}","received_events_url":"https://api.github.com/users/tbarnes-us/received_events","type":"User","site_admin":false},"body":"Would an even lower period seconds be possible?   The lower the interval, the faster the lifecycle...","created_at":"2018-03-10T00:18:04Z","updated_at":"2018-03-10T00:18:04Z","html_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/145#discussion_r173599986","pull_request_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/145","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments/173599986"},"html":{"href":"https://github.com/oracle/weblogic-kubernetes-operator/pull/145#discussion_r173599986"},"pull_request":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/145"}}},"pull_request":{"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/145","id":174117373,"html_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/145","diff_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/145.diff","patch_url":"https://github.com/oracle/weblogic-kubernetes-operator/pull/145.patch","issue_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/145","number":145,"state":"open","locked":false,"title":"Create shared domain scripts config map and use for liveness and readiness probes","user":{"login":"rjeberhard","id":27861489,"avatar_url":"https://avatars3.githubusercontent.com/u/27861489?v=4","gravatar_id":"","url":"https://api.github.com/users/rjeberhard","html_url":"https://github.com/rjeberhard","followers_url":"https://api.github.com/users/rjeberhard/followers","following_url":"https://api.github.com/users/rjeberhard/following{/other_user}","gists_url":"https://api.github.com/users/rjeberhard/gists{/gist_id}","starred_url":"https://api.github.com/users/rjeberhard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjeberhard/subscriptions","organizations_url":"https://api.github.com/users/rjeberhard/orgs","repos_url":"https://api.github.com/users/rjeberhard/repos","events_url":"https://api.github.com/users/rjeberhard/events{/privacy}","received_events_url":"https://api.github.com/users/rjeberhard/received_events","type":"User","site_admin":false},"body":"This functionality is moved from the domain creation job to this config map created by the operator.\r\n\r\nThe readiness probe is modified from being an HTTP request to the ready app. to being a check of the server's state in the NM's state file.  This was done because a server in ADMIN mode should not be included in load balancing, which means that we need this server to show as not ready.\r\n\r\n","created_at":"2018-03-09T21:50:53Z","updated_at":"2018-03-10T00:18:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0af7bf007836613f284d146ed403fcd27401284b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"doxiao","id":32496275,"avatar_url":"https://avatars2.githubusercontent.com/u/32496275?v=4","gravatar_id":"","url":"https://api.github.com/users/doxiao","html_url":"https://github.com/doxiao","followers_url":"https://api.github.com/users/doxiao/followers","following_url":"https://api.github.com/users/doxiao/following{/other_user}","gists_url":"https://api.github.com/users/doxiao/gists{/gist_id}","starred_url":"https://api.github.com/users/doxiao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doxiao/subscriptions","organizations_url":"https://api.github.com/users/doxiao/orgs","repos_url":"https://api.github.com/users/doxiao/repos","events_url":"https://api.github.com/users/doxiao/events{/privacy}","received_events_url":"https://api.github.com/users/doxiao/received_events","type":"User","site_admin":false},{"login":"lennyphan","id":33355669,"avatar_url":"https://avatars3.githubusercontent.com/u/33355669?v=4","gravatar_id":"","url":"https://api.github.com/users/lennyphan","html_url":"https://github.com/lennyphan","followers_url":"https://api.github.com/users/lennyphan/followers","following_url":"https://api.github.com/users/lennyphan/following{/other_user}","gists_url":"https://api.github.com/users/lennyphan/gists{/gist_id}","starred_url":"https://api.github.com/users/lennyphan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lennyphan/subscriptions","organizations_url":"https://api.github.com/users/lennyphan/orgs","repos_url":"https://api.github.com/users/lennyphan/repos","events_url":"https://api.github.com/users/lennyphan/events{/privacy}","received_events_url":"https://api.github.com/users/lennyphan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/145/commits","review_comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/145/comments","review_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/145/comments","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/40e3b1903f68c68e2ab8de70f0631c3d345c5eeb","head":{"label":"oracle:probes-and-scripts","ref":"probes-and-scripts","sha":"40e3b1903f68c68e2ab8de70f0631c3d345c5eeb","user":{"login":"oracle","id":4430336,"avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":113222463,"name":"weblogic-kubernetes-operator","full_name":"oracle/weblogic-kubernetes-operator","owner":{"login":"oracle","id":4430336,"avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/weblogic-kubernetes-operator","description":"Oracle Weblogic Server Kubernetes Operator","fork":false,"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator","forks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/forks","keys_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/teams","hooks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/hooks","issue_events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/events","assignees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/tags","blobs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/languages","stargazers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/stargazers","contributors_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contributors","subscribers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscribers","subscription_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscription","commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/merges","archive_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/downloads","issues_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/labels{/name}","releases_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/deployments","created_at":"2017-12-05T19:11:06Z","updated_at":"2018-03-09T18:09:56Z","pushed_at":"2018-03-09T23:33:22Z","git_url":"git://github.com/oracle/weblogic-kubernetes-operator.git","ssh_url":"git@github.com:oracle/weblogic-kubernetes-operator.git","clone_url":"https://github.com/oracle/weblogic-kubernetes-operator.git","svn_url":"https://github.com/oracle/weblogic-kubernetes-operator","homepage":"","size":7575,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10,"open_issues":23,"watchers":16,"default_branch":"master"}},"base":{"label":"oracle:master","ref":"master","sha":"382fa6326adb0bcc2c02f40cfe5410634c7213a5","user":{"login":"oracle","id":4430336,"avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"repo":{"id":113222463,"name":"weblogic-kubernetes-operator","full_name":"oracle/weblogic-kubernetes-operator","owner":{"login":"oracle","id":4430336,"avatar_url":"https://avatars1.githubusercontent.com/u/4430336?v=4","gravatar_id":"","url":"https://api.github.com/users/oracle","html_url":"https://github.com/oracle","followers_url":"https://api.github.com/users/oracle/followers","following_url":"https://api.github.com/users/oracle/following{/other_user}","gists_url":"https://api.github.com/users/oracle/gists{/gist_id}","starred_url":"https://api.github.com/users/oracle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oracle/subscriptions","organizations_url":"https://api.github.com/users/oracle/orgs","repos_url":"https://api.github.com/users/oracle/repos","events_url":"https://api.github.com/users/oracle/events{/privacy}","received_events_url":"https://api.github.com/users/oracle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/oracle/weblogic-kubernetes-operator","description":"Oracle Weblogic Server Kubernetes Operator","fork":false,"url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator","forks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/forks","keys_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/teams","hooks_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/hooks","issue_events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/events{/number}","events_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/events","assignees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/assignees{/user}","branches_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/branches{/branch}","tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/tags","blobs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/languages","stargazers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/stargazers","contributors_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contributors","subscribers_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscribers","subscription_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/subscription","commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/contents/{+path}","compare_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/merges","archive_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/downloads","issues_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues{/number}","pulls_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/labels{/name}","releases_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/releases{/id}","deployments_url":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/deployments","created_at":"2017-12-05T19:11:06Z","updated_at":"2018-03-09T18:09:56Z","pushed_at":"2018-03-09T23:33:22Z","git_url":"git://github.com/oracle/weblogic-kubernetes-operator.git","ssh_url":"git@github.com:oracle/weblogic-kubernetes-operator.git","clone_url":"https://github.com/oracle/weblogic-kubernetes-operator.git","svn_url":"https://github.com/oracle/weblogic-kubernetes-operator","homepage":"","size":7575,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":10,"open_issues":23,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/145"},"html":{"href":"https://github.com/oracle/weblogic-kubernetes-operator/pull/145"},"issue":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/145"},"comments":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/issues/145/comments"},"review_comments":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/145/comments"},"review_comment":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/pulls/145/commits"},"statuses":{"href":"https://api.github.com/repos/oracle/weblogic-kubernetes-operator/statuses/40e3b1903f68c68e2ab8de70f0631c3d345c5eeb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tbarnes-us"}}