{"action":"created","issue":{"url":"https://api.github.com/repos/niieani/bash-oo-framework/issues/72","repository_url":"https://api.github.com/repos/niieani/bash-oo-framework","labels_url":"https://api.github.com/repos/niieani/bash-oo-framework/issues/72/labels{/name}","comments_url":"https://api.github.com/repos/niieani/bash-oo-framework/issues/72/comments","events_url":"https://api.github.com/repos/niieani/bash-oo-framework/issues/72/events","html_url":"https://github.com/niieani/bash-oo-framework/pull/72","id":376260873,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTE4NjE5","number":72,"title":"Remove 'i/s' options from __oo__presetShellOpts in try command","user":{"login":"Cj-bc","id":16875061,"node_id":"MDQ6VXNlcjE2ODc1MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/16875061?v=4","gravatar_id":"","url":"https://api.github.com/users/Cj-bc","html_url":"https://github.com/Cj-bc","followers_url":"https://api.github.com/users/Cj-bc/followers","following_url":"https://api.github.com/users/Cj-bc/following{/other_user}","gists_url":"https://api.github.com/users/Cj-bc/gists{/gist_id}","starred_url":"https://api.github.com/users/Cj-bc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cj-bc/subscriptions","organizations_url":"https://api.github.com/users/Cj-bc/orgs","repos_url":"https://api.github.com/users/Cj-bc/repos","events_url":"https://api.github.com/users/Cj-bc/events{/privacy}","received_events_url":"https://api.github.com/users/Cj-bc/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-01T05:40:41Z","updated_at":"2018-11-12T13:45:43Z","closed_at":"2018-11-12T13:44:11Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/niieani/bash-oo-framework/pulls/72","html_url":"https://github.com/niieani/bash-oo-framework/pull/72","diff_url":"https://github.com/niieani/bash-oo-framework/pull/72.diff","patch_url":"https://github.com/niieani/bash-oo-framework/pull/72.patch"},"body":"`set -i`/`set -s` are no longer valid so that I delete them.\r\nWhen I use my script which use tryCatch by sourcing, an error has occured because of this.\r\nI'm sure this way of executing (by sourcing scripts) is not common. I do while testing and developing.\r\nAnyway, as we don't need those two options, I decided to delete them.\r\n\r\n\r\nThis is what I've got before this change(`blib::install` is my command defined in blib.oo.sh):\r\n\r\n```bash\r\n<X_X>:blib$ source ./blib.oo.sh\r\n$?is0\r\n<X_X>:blib$ blib::install Cj-bc/libtar\r\nbash: set: -i: invalid option\r\nset: usage: set [-abefhkmnptuvxBCHP] [-o option-name] [--] [arg ...]\r\n```"},"comment":{"url":"https://api.github.com/repos/niieani/bash-oo-framework/issues/comments/437885967","html_url":"https://github.com/niieani/bash-oo-framework/pull/72#issuecomment-437885967","issue_url":"https://api.github.com/repos/niieani/bash-oo-framework/issues/72","id":437885967,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzg4NTk2Nw==","user":{"login":"niieani","id":563469,"node_id":"MDQ6VXNlcjU2MzQ2OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/563469?v=4","gravatar_id":"","url":"https://api.github.com/users/niieani","html_url":"https://github.com/niieani","followers_url":"https://api.github.com/users/niieani/followers","following_url":"https://api.github.com/users/niieani/following{/other_user}","gists_url":"https://api.github.com/users/niieani/gists{/gist_id}","starred_url":"https://api.github.com/users/niieani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niieani/subscriptions","organizations_url":"https://api.github.com/users/niieani/orgs","repos_url":"https://api.github.com/users/niieani/repos","events_url":"https://api.github.com/users/niieani/events{/privacy}","received_events_url":"https://api.github.com/users/niieani/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T13:45:43Z","updated_at":"2018-11-12T13:45:43Z","author_association":"OWNER","body":"Thanks @Cj-bc "}}
{"actor":{"display_login":"niieani"}}