{"action":"created","comment":{"url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/comments/214751820","pull_request_review_id":151869735,"id":214751820,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDc1MTgyMA==","diff_hunk":"@@ -0,0 +1,58 @@\n+% setup\n+rng(0); % for reproducibility\n+\n+% tuning variable: linear increase\n+tuning_dt = 1/30; \n+tuning_var_tvec = 0:tuning_dt:100;\n+tuning_var_data = linspace(80, 400, length(tuning_var_tvec));\n+\n+% spike train (logical)\n+spike_dt = 0.001;\n+spike_rate = 0.5;\n+spike_tvec = 0:spike_dt:100;\n+spike_data_binary = rand(size(spike_tvec)) > spike_rate;\n+\n+% spike train (continuous)\n+spike_data_cont = rand(size(spike_tvec));\n+\n+cfg.bins = 0:10:640;\n+cfg.interp = 'nearest';\n+\n+%% test that outputs have the expected size\n+cfg_acf = [];\n+cfg_acf.binsize = mean(diff(cfg.bins));\n+\n+[acf,tvec] = ComputeACF(cfg_acf,spike_data_binary); \n+assert(mean(diff(tvec)) == cfg_acf.binsize); % cfg.binsive should be the same as the tvec dt\n+assert(tvec(ceil(end/2))==0) % tvec centered on 0\n+assert(acf(ceil(end/2))==0) % acf centered on 0\n+\n+\n+cfg_acf = [];\n+cfg_acf.binsize = mean(diff(cfg.bins));","path":"tests/proc/TEST_ComputeACF.m","position":32,"original_position":32,"commit_id":"4cda589c5bff5a6fbee7a9696add3464aa1dd766","original_commit_id":"4cda589c5bff5a6fbee7a9696add3464aa1dd766","user":{"login":"ecarmichael","id":5436929,"node_id":"MDQ6VXNlcjU0MzY5Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/5436929?v=4","gravatar_id":"","url":"https://api.github.com/users/ecarmichael","html_url":"https://github.com/ecarmichael","followers_url":"https://api.github.com/users/ecarmichael/followers","following_url":"https://api.github.com/users/ecarmichael/following{/other_user}","gists_url":"https://api.github.com/users/ecarmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/ecarmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecarmichael/subscriptions","organizations_url":"https://api.github.com/users/ecarmichael/orgs","repos_url":"https://api.github.com/users/ecarmichael/repos","events_url":"https://api.github.com/users/ecarmichael/events{/privacy}","received_events_url":"https://api.github.com/users/ecarmichael/received_events","type":"User","site_admin":false},"body":"Will continue to clear cfg_cfg but will use constants for fields.  \r\n","created_at":"2018-09-03T20:14:32Z","updated_at":"2018-09-03T20:14:32Z","html_url":"https://github.com/vandermeerlab/striatal-spike-rhythms/pull/8#discussion_r214751820","pull_request_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/comments/214751820"},"html":{"href":"https://github.com/vandermeerlab/striatal-spike-rhythms/pull/8#discussion_r214751820"},"pull_request":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/8"}},"in_reply_to_id":214751460},"pull_request":{"url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/8","id":212812418,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyODEyNDE4","html_url":"https://github.com/vandermeerlab/striatal-spike-rhythms/pull/8","diff_url":"https://github.com/vandermeerlab/striatal-spike-rhythms/pull/8.diff","patch_url":"https://github.com/vandermeerlab/striatal-spike-rhythms/pull/8.patch","issue_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues/8","number":8,"state":"open","locked":false,"title":"new TEST for ComputeACF","user":{"login":"ecarmichael","id":5436929,"node_id":"MDQ6VXNlcjU0MzY5Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/5436929?v=4","gravatar_id":"","url":"https://api.github.com/users/ecarmichael","html_url":"https://github.com/ecarmichael","followers_url":"https://api.github.com/users/ecarmichael/followers","following_url":"https://api.github.com/users/ecarmichael/following{/other_user}","gists_url":"https://api.github.com/users/ecarmichael/gists{/gist_id}","starred_url":"https://api.github.com/users/ecarmichael/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecarmichael/subscriptions","organizations_url":"https://api.github.com/users/ecarmichael/orgs","repos_url":"https://api.github.com/users/ecarmichael/repos","events_url":"https://api.github.com/users/ecarmichael/events{/privacy}","received_events_url":"https://api.github.com/users/ecarmichael/received_events","type":"User","site_admin":false},"body":"TEST for ComputeACF that uses all of the possible cfg input options.  Tests for data centering and bin sizes.  \r\n\r\nadditional: \r\n- minor annotations to ComputeACF","created_at":"2018-09-03T19:57:48Z","updated_at":"2018-09-03T20:14:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2eda1bfeb25e8ea434f13ed652850f41729cdb5a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/8/commits","review_comments_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/8/comments","review_comment_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues/8/comments","statuses_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/statuses/4cda589c5bff5a6fbee7a9696add3464aa1dd766","head":{"label":"vandermeerlab:EC_tests","ref":"EC_tests","sha":"4cda589c5bff5a6fbee7a9696add3464aa1dd766","user":{"login":"vandermeerlab","id":20644447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQ0NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/20644447?v=4","gravatar_id":"","url":"https://api.github.com/users/vandermeerlab","html_url":"https://github.com/vandermeerlab","followers_url":"https://api.github.com/users/vandermeerlab/followers","following_url":"https://api.github.com/users/vandermeerlab/following{/other_user}","gists_url":"https://api.github.com/users/vandermeerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/vandermeerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vandermeerlab/subscriptions","organizations_url":"https://api.github.com/users/vandermeerlab/orgs","repos_url":"https://api.github.com/users/vandermeerlab/repos","events_url":"https://api.github.com/users/vandermeerlab/events{/privacy}","received_events_url":"https://api.github.com/users/vandermeerlab/received_events","type":"Organization","site_admin":false},"repo":{"id":144598499,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1OTg0OTk=","name":"striatal-spike-rhythms","full_name":"vandermeerlab/striatal-spike-rhythms","owner":{"login":"vandermeerlab","id":20644447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQ0NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/20644447?v=4","gravatar_id":"","url":"https://api.github.com/users/vandermeerlab","html_url":"https://github.com/vandermeerlab","followers_url":"https://api.github.com/users/vandermeerlab/followers","following_url":"https://api.github.com/users/vandermeerlab/following{/other_user}","gists_url":"https://api.github.com/users/vandermeerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/vandermeerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vandermeerlab/subscriptions","organizations_url":"https://api.github.com/users/vandermeerlab/orgs","repos_url":"https://api.github.com/users/vandermeerlab/repos","events_url":"https://api.github.com/users/vandermeerlab/events{/privacy}","received_events_url":"https://api.github.com/users/vandermeerlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vandermeerlab/striatal-spike-rhythms","description":"Code to explore spike train rhythmicity in striatal data","fork":false,"url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms","forks_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/forks","keys_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/teams","hooks_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/hooks","issue_events_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues/events{/number}","events_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/events","assignees_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/assignees{/user}","branches_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/branches{/branch}","tags_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/tags","blobs_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/refs{/sha}","trees_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/statuses/{sha}","languages_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/languages","stargazers_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/stargazers","contributors_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/contributors","subscribers_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/subscribers","subscription_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/subscription","commits_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/commits{/sha}","git_commits_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/commits{/sha}","comments_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/comments{/number}","issue_comment_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues/comments{/number}","contents_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/contents/{+path}","compare_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/merges","archive_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/downloads","issues_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues{/number}","pulls_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls{/number}","milestones_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/milestones{/number}","notifications_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/labels{/name}","releases_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/releases{/id}","deployments_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/deployments","created_at":"2018-08-13T15:26:25Z","updated_at":"2018-09-03T19:00:50Z","pushed_at":"2018-09-03T20:13:17Z","git_url":"git://github.com/vandermeerlab/striatal-spike-rhythms.git","ssh_url":"git@github.com:vandermeerlab/striatal-spike-rhythms.git","clone_url":"https://github.com/vandermeerlab/striatal-spike-rhythms.git","svn_url":"https://github.com/vandermeerlab/striatal-spike-rhythms","homepage":null,"size":12468,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"vandermeerlab:master","ref":"master","sha":"c25b554013f0ef92f2a28c2bbb01d649be5e0284","user":{"login":"vandermeerlab","id":20644447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQ0NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/20644447?v=4","gravatar_id":"","url":"https://api.github.com/users/vandermeerlab","html_url":"https://github.com/vandermeerlab","followers_url":"https://api.github.com/users/vandermeerlab/followers","following_url":"https://api.github.com/users/vandermeerlab/following{/other_user}","gists_url":"https://api.github.com/users/vandermeerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/vandermeerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vandermeerlab/subscriptions","organizations_url":"https://api.github.com/users/vandermeerlab/orgs","repos_url":"https://api.github.com/users/vandermeerlab/repos","events_url":"https://api.github.com/users/vandermeerlab/events{/privacy}","received_events_url":"https://api.github.com/users/vandermeerlab/received_events","type":"Organization","site_admin":false},"repo":{"id":144598499,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ1OTg0OTk=","name":"striatal-spike-rhythms","full_name":"vandermeerlab/striatal-spike-rhythms","owner":{"login":"vandermeerlab","id":20644447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjQ0NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/20644447?v=4","gravatar_id":"","url":"https://api.github.com/users/vandermeerlab","html_url":"https://github.com/vandermeerlab","followers_url":"https://api.github.com/users/vandermeerlab/followers","following_url":"https://api.github.com/users/vandermeerlab/following{/other_user}","gists_url":"https://api.github.com/users/vandermeerlab/gists{/gist_id}","starred_url":"https://api.github.com/users/vandermeerlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vandermeerlab/subscriptions","organizations_url":"https://api.github.com/users/vandermeerlab/orgs","repos_url":"https://api.github.com/users/vandermeerlab/repos","events_url":"https://api.github.com/users/vandermeerlab/events{/privacy}","received_events_url":"https://api.github.com/users/vandermeerlab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vandermeerlab/striatal-spike-rhythms","description":"Code to explore spike train rhythmicity in striatal data","fork":false,"url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms","forks_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/forks","keys_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/teams","hooks_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/hooks","issue_events_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues/events{/number}","events_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/events","assignees_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/assignees{/user}","branches_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/branches{/branch}","tags_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/tags","blobs_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/refs{/sha}","trees_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/statuses/{sha}","languages_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/languages","stargazers_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/stargazers","contributors_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/contributors","subscribers_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/subscribers","subscription_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/subscription","commits_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/commits{/sha}","git_commits_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/git/commits{/sha}","comments_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/comments{/number}","issue_comment_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues/comments{/number}","contents_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/contents/{+path}","compare_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/merges","archive_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/downloads","issues_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues{/number}","pulls_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls{/number}","milestones_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/milestones{/number}","notifications_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/labels{/name}","releases_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/releases{/id}","deployments_url":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/deployments","created_at":"2018-08-13T15:26:25Z","updated_at":"2018-09-03T19:00:50Z","pushed_at":"2018-09-03T20:13:17Z","git_url":"git://github.com/vandermeerlab/striatal-spike-rhythms.git","ssh_url":"git@github.com:vandermeerlab/striatal-spike-rhythms.git","clone_url":"https://github.com/vandermeerlab/striatal-spike-rhythms.git","svn_url":"https://github.com/vandermeerlab/striatal-spike-rhythms","homepage":null,"size":12468,"stargazers_count":0,"watchers_count":0,"language":"Matlab","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/8"},"html":{"href":"https://github.com/vandermeerlab/striatal-spike-rhythms/pull/8"},"issue":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues/8"},"comments":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/vandermeerlab/striatal-spike-rhythms/statuses/4cda589c5bff5a6fbee7a9696add3464aa1dd766"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ecarmichael"}}