{"action":"created","issue":{"url":"https://api.github.com/repos/hshoff/vx/issues/56","repository_url":"https://api.github.com/repos/hshoff/vx","labels_url":"https://api.github.com/repos/hshoff/vx/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/hshoff/vx/issues/56/comments","events_url":"https://api.github.com/repos/hshoff/vx/issues/56/events","html_url":"https://github.com/hshoff/vx/issues/56","id":234525211,"node_id":"MDU6SXNzdWUyMzQ1MjUyMTE=","number":56,"title":"typescript typings","user":{"login":"rd-dev-ukraine","id":10695934,"node_id":"MDQ6VXNlcjEwNjk1OTM0","avatar_url":"https://avatars2.githubusercontent.com/u/10695934?v=4","gravatar_id":"","url":"https://api.github.com/users/rd-dev-ukraine","html_url":"https://github.com/rd-dev-ukraine","followers_url":"https://api.github.com/users/rd-dev-ukraine/followers","following_url":"https://api.github.com/users/rd-dev-ukraine/following{/other_user}","gists_url":"https://api.github.com/users/rd-dev-ukraine/gists{/gist_id}","starred_url":"https://api.github.com/users/rd-dev-ukraine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rd-dev-ukraine/subscriptions","organizations_url":"https://api.github.com/users/rd-dev-ukraine/orgs","repos_url":"https://api.github.com/users/rd-dev-ukraine/repos","events_url":"https://api.github.com/users/rd-dev-ukraine/events{/privacy}","received_events_url":"https://api.github.com/users/rd-dev-ukraine/received_events","type":"User","site_admin":false},"labels":[{"id":561499211,"node_id":"MDU6TGFiZWw1NjE0OTkyMTE=","url":"https://api.github.com/repos/hshoff/vx/labels/%F0%9F%91%8Bhelp%20wanted","name":"👋help wanted","color":"6bf9e9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2017-06-08T13:21:07Z","updated_at":"2018-12-30T14:02:50Z","closed_at":null,"author_association":"NONE","body":"It will be nice to have typings. It will be little easier to understand how to use your package. :)"},"comment":{"url":"https://api.github.com/repos/hshoff/vx/issues/comments/450562782","html_url":"https://github.com/hshoff/vx/issues/56#issuecomment-450562782","issue_url":"https://api.github.com/repos/hshoff/vx/issues/56","id":450562782,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU2Mjc4Mg==","user":{"login":"jackdbd","id":5048090,"node_id":"MDQ6VXNlcjUwNDgwOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/5048090?v=4","gravatar_id":"","url":"https://api.github.com/users/jackdbd","html_url":"https://github.com/jackdbd","followers_url":"https://api.github.com/users/jackdbd/followers","following_url":"https://api.github.com/users/jackdbd/following{/other_user}","gists_url":"https://api.github.com/users/jackdbd/gists{/gist_id}","starred_url":"https://api.github.com/users/jackdbd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackdbd/subscriptions","organizations_url":"https://api.github.com/users/jackdbd/orgs","repos_url":"https://api.github.com/users/jackdbd/repos","events_url":"https://api.github.com/users/jackdbd/events{/privacy}","received_events_url":"https://api.github.com/users/jackdbd/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T14:02:50Z","updated_at":"2018-12-30T14:02:50Z","author_association":"NONE","body":"Since `vx` is a Javascript project, I think it makes sense to have no Typescript files in this repo.\r\n\r\nAs @madprog said, Typescript type definitions for all `vx` packages could be hosted on [DefinitelyTyped](https://github.com/DefinitelyTyped/DefinitelyTyped). Type definitions are specific for a given version range, but there are already best practices to support different versions. See for example the type definitions for [d3-scale](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/d3-scale).\r\n\r\n@hshoff, any tips on which vx packages to start with? I guess it should be easier to start with \"leaf\" packages. I have just started writing type definitions for `@vx/mock-data`, `@vx/scale` and `@vx/axis`. I'll make a PR on DefinitelyTyped when I'm ready.\r\n\r\nMeanwhile, for anyone who wants to use `vx` in a Typescript project, the quick and dirty approach is to set this flag in the `compilerOptions` of your `tsconfig.json`:\r\n\r\n```json\r\n{\r\n  \"compilerOptions\": {\r\n    \"noImplicitAny\": false\r\n  }\r\n}\r\n```"}}
{"actor":{"display_login":"jackdbd"}}