{"action":"created","issue":{"url":"https://api.github.com/repos/gwpy/gwpy/issues/905","repository_url":"https://api.github.com/repos/gwpy/gwpy","labels_url":"https://api.github.com/repos/gwpy/gwpy/issues/905/labels{/name}","comments_url":"https://api.github.com/repos/gwpy/gwpy/issues/905/comments","events_url":"https://api.github.com/repos/gwpy/gwpy/issues/905/events","html_url":"https://github.com/gwpy/gwpy/pull/905","id":359712228,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MTQyMjQ0","number":905,"title":"WIP: Introducing a TimeSeries.matched_filter() method","user":{"login":"alurban","id":5273800,"node_id":"MDQ6VXNlcjUyNzM4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/5273800?v=4","gravatar_id":"","url":"https://api.github.com/users/alurban","html_url":"https://github.com/alurban","followers_url":"https://api.github.com/users/alurban/followers","following_url":"https://api.github.com/users/alurban/following{/other_user}","gists_url":"https://api.github.com/users/alurban/gists{/gist_id}","starred_url":"https://api.github.com/users/alurban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alurban/subscriptions","organizations_url":"https://api.github.com/users/alurban/orgs","repos_url":"https://api.github.com/users/alurban/repos","events_url":"https://api.github.com/users/alurban/events{/privacy}","received_events_url":"https://api.github.com/users/alurban/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-13T01:48:35Z","updated_at":"2018-09-13T01:48:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/gwpy/gwpy/pulls/905","html_url":"https://github.com/gwpy/gwpy/pull/905","diff_url":"https://github.com/gwpy/gwpy/pull/905.diff","patch_url":"https://github.com/gwpy/gwpy/pull/905.patch"},"body":"@duncanmmacleod, this pull request introduces a method, `TimeSeries.matched_filter()`, which convolves the input timeseries with the phase reverse of a given signal template, giving the matched filter SNR. The new method also performs overwhitening if requested, computing a PSD with given arguments and then passing this to `TimeSeries.whiten()`. Finally, this PR also includes a unit test for the new method, and updates the SNR example in the documentation.\r\n\r\nNote, the SNR timeseries returned by `TimeSeries.matched_filter()` has the same length and timestamps as the input timeseries. It is also detrended (to give zero mean), normalized (to give unit variance), and absolute-value'd (to produce a positive-definite data array).\r\n\r\n**This PR should not be merged until #883 is ready.** It should be considered a target for gwpy 0.13.0/1.0.0.\r\n\r\nThis fixes #892."},"comment":{"url":"https://api.github.com/repos/gwpy/gwpy/issues/comments/420855618","html_url":"https://github.com/gwpy/gwpy/pull/905#issuecomment-420855618","issue_url":"https://api.github.com/repos/gwpy/gwpy/issues/905","id":420855618,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDg1NTYxOA==","user":{"login":"pep8speaks","id":24736507,"node_id":"MDQ6VXNlcjI0NzM2NTA3","avatar_url":"https://avatars1.githubusercontent.com/u/24736507?v=4","gravatar_id":"","url":"https://api.github.com/users/pep8speaks","html_url":"https://github.com/pep8speaks","followers_url":"https://api.github.com/users/pep8speaks/followers","following_url":"https://api.github.com/users/pep8speaks/following{/other_user}","gists_url":"https://api.github.com/users/pep8speaks/gists{/gist_id}","starred_url":"https://api.github.com/users/pep8speaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pep8speaks/subscriptions","organizations_url":"https://api.github.com/users/pep8speaks/orgs","repos_url":"https://api.github.com/users/pep8speaks/repos","events_url":"https://api.github.com/users/pep8speaks/events{/privacy}","received_events_url":"https://api.github.com/users/pep8speaks/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T01:48:38Z","updated_at":"2018-09-13T01:48:38Z","author_association":"NONE","body":"Hello @alurban! Thanks for submitting the PR.\n\n - In the file [`examples/timeseries/snr.py`](https://github.com/alurban/gwpy/blob/6948376f3d7e76efaeaa089f78fba09bf1ddeb8f/examples/timeseries/snr.py), following                are the PEP8 issues :\n> [Line 58:1](https://github.com/alurban/gwpy/blob/6948376f3d7e76efaeaa089f78fba09bf1ddeb8f/examples/timeseries/snr.py#L58): [E402](https://duckduckgo.com/?q=pep8%20E402) module level import not at top of file\n\n\n - There are no PEP8 issues in the file [`gwpy/timeseries/tests/test_timeseries.py`](https://github.com/alurban/gwpy/blob/6948376f3d7e76efaeaa089f78fba09bf1ddeb8f/gwpy/timeseries/tests/test_timeseries.py) !\n\n - There are no PEP8 issues in the file [`gwpy/timeseries/timeseries.py`](https://github.com/alurban/gwpy/blob/6948376f3d7e76efaeaa089f78fba09bf1ddeb8f/gwpy/timeseries/timeseries.py) !\n\n"}}
{"actor":{"display_login":"pep8speaks"}}