{"action":"created","issue":{"url":"https://api.github.com/repos/blockstack/blockstack.js/issues/494","repository_url":"https://api.github.com/repos/blockstack/blockstack.js","labels_url":"https://api.github.com/repos/blockstack/blockstack.js/issues/494/labels{/name}","comments_url":"https://api.github.com/repos/blockstack/blockstack.js/issues/494/comments","events_url":"https://api.github.com/repos/blockstack/blockstack.js/issues/494/events","html_url":"https://github.com/blockstack/blockstack.js/pull/494","id":339574991,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTk0OTMx","number":494,"title":"Feature/pass name lookup url","user":{"login":"jcnelson","id":459947,"node_id":"MDQ6VXNlcjQ1OTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/459947?v=4","gravatar_id":"","url":"https://api.github.com/users/jcnelson","html_url":"https://github.com/jcnelson","followers_url":"https://api.github.com/users/jcnelson/followers","following_url":"https://api.github.com/users/jcnelson/following{/other_user}","gists_url":"https://api.github.com/users/jcnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/jcnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcnelson/subscriptions","organizations_url":"https://api.github.com/users/jcnelson/orgs","repos_url":"https://api.github.com/users/jcnelson/repos","events_url":"https://api.github.com/users/jcnelson/events{/privacy}","received_events_url":"https://api.github.com/users/jcnelson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-09T19:20:28Z","updated_at":"2018-07-09T19:57:54Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/blockstack/blockstack.js/pulls/494","html_url":"https://github.com/blockstack/blockstack.js/pull/494","diff_url":"https://github.com/blockstack/blockstack.js/pull/494.diff","patch_url":"https://github.com/blockstack/blockstack.js/pull/494.patch"},"body":"This PR makes it so `handlePendingSign()` will take the `nameLookupUrl` from the `authResponse` token, if none is given by the caller.  This is useful because the Browser (or whatever process is handling the sign-in) will then be able to direct the application to the name lookup API endpoint of the user's choice.  We should not be setting a hard-coded default to `core.blockstack.org`."},"comment":{"url":"https://api.github.com/repos/blockstack/blockstack.js/issues/comments/403601106","html_url":"https://github.com/blockstack/blockstack.js/pull/494#issuecomment-403601106","issue_url":"https://api.github.com/repos/blockstack/blockstack.js/issues/494","id":403601106,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzYwMTEwNg==","user":{"login":"jcnelson","id":459947,"node_id":"MDQ6VXNlcjQ1OTk0Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/459947?v=4","gravatar_id":"","url":"https://api.github.com/users/jcnelson","html_url":"https://github.com/jcnelson","followers_url":"https://api.github.com/users/jcnelson/followers","following_url":"https://api.github.com/users/jcnelson/following{/other_user}","gists_url":"https://api.github.com/users/jcnelson/gists{/gist_id}","starred_url":"https://api.github.com/users/jcnelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcnelson/subscriptions","organizations_url":"https://api.github.com/users/jcnelson/orgs","repos_url":"https://api.github.com/users/jcnelson/repos","events_url":"https://api.github.com/users/jcnelson/events{/privacy}","received_events_url":"https://api.github.com/users/jcnelson/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T19:57:54Z","updated_at":"2018-07-09T19:57:54Z","author_association":"MEMBER","body":"> The Core API endpoint is used in a couple of places in blockstack.js, so it's probably better to pass the API endpoint itself, rather than the name lookup URL, e.g., (https://core.blockstack.org, http://localhost:16270).\r\n\r\nWhere is it used?  I don't see `core.blockstack.org` hard-coded anywhere besides `blockstack.config.network`.\r\n\r\nAlso, isn't `config.network.blockstackAPIUrl` already global?\r\n\r\n```\r\n> require('blockstack').config.network.blockstackAPIUrl\r\n'https://core.blockstack.org'\r\n```"}}
{"actor":{"display_login":"jcnelson"}}