{"action":"created","comment":{"url":"https://api.github.com/repos/certbot/certbot/pulls/comments/170135629","pull_request_review_id":98778254,"id":170135629,"diff_hunk":"@@ -100,10 +100,16 @@ def _choose_challenges(self, domains):\n         \"\"\"Retrieve necessary challenges to satisfy server.\"\"\"\n         logger.info(\"Performing the following challenges:\")\n         for dom in domains:\n+            dom_challenges = self.authzr[dom].body.challenges\n+            if self.acme.acme_version == 1:\n+                combinations = self.authzr[dom].body.combinations\n+            else:\n+                combinations = tuple((i,) for i in range(len(dom_challenges)))","path":"certbot/auth_handler.py","position":17,"original_position":17,"commit_id":"c53a1cfa342903f2f77bb5c0f6a3bf64f421aa1c","original_commit_id":"aafb7861cb2526cff15a1dfeebf30a1af83d2578","user":{"login":"bmw","id":6504915,"avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"body":"Manually checking against the V1 endpoint. It was a tuple of tuples.","created_at":"2018-02-23T00:27:26Z","updated_at":"2018-02-23T00:27:27Z","html_url":"https://github.com/certbot/certbot/pull/5612#discussion_r170135629","pull_request_url":"https://api.github.com/repos/certbot/certbot/pulls/5612","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments/170135629"},"html":{"href":"https://github.com/certbot/certbot/pull/5612#discussion_r170135629"},"pull_request":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5612"}},"in_reply_to_id":170135020},"pull_request":{"url":"https://api.github.com/repos/certbot/certbot/pulls/5612","id":170898790,"html_url":"https://github.com/certbot/certbot/pull/5612","diff_url":"https://github.com/certbot/certbot/pull/5612.diff","patch_url":"https://github.com/certbot/certbot/pull/5612.patch","issue_url":"https://api.github.com/repos/certbot/certbot/issues/5612","number":5612,"state":"open","locked":false,"title":"Fix ACMEv2 issues","user":{"login":"bmw","id":6504915,"avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"body":"I think most of the changes in this PR are pretty self explanatory with the help of comments and commit messages, however, I should probably expand on the thought process for handling the lack of combinations in ACMEv2 authorizations.\r\n\r\nI talked about this a bit with Erica and I think our only options are either to not try and handle this problem in our ACME shim (the approach I took) or complicate and/or muddle the shim's otherwise clean interface. If we wanted to try and handle this difference, we'd need to either do something like always add combinations to the authz (which deviates from the idea of it being a backwards compatible V2 client) or push the logic of choosing challenges based on plugins and user preferences into ACME (which significantly complicates the interface and makes what users of the class can do less flexible).\r\n\r\nWe're only talking about ACME servers based on the protocol from over a year and a half ago and we're not even sure any of these exist. Rather than complicating the interface that we have to live with going forward, let's keep this clean and deal with this in Certbot for the sake of preserving our current behavior. If anyone else really needs or wants to support this, I tried to make this limitation clear and they should be able to do so with minimal changes like those I made in Certbot's `auth_handler.py`.","created_at":"2018-02-22T23:50:39Z","updated_at":"2018-02-23T00:27:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14fc665c90d8010035bdbeb9c6b25fecf33ed965","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/certbot/certbot/milestones/48","html_url":"https://github.com/certbot/certbot/milestone/48","labels_url":"https://api.github.com/repos/certbot/certbot/milestones/48/labels","id":2967509,"number":48,"title":"0.22.0","description":"","creator":{"login":"bmw","id":6504915,"avatar_url":"https://avatars0.githubusercontent.com/u/6504915?v=4","gravatar_id":"","url":"https://api.github.com/users/bmw","html_url":"https://github.com/bmw","followers_url":"https://api.github.com/users/bmw/followers","following_url":"https://api.github.com/users/bmw/following{/other_user}","gists_url":"https://api.github.com/users/bmw/gists{/gist_id}","starred_url":"https://api.github.com/users/bmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmw/subscriptions","organizations_url":"https://api.github.com/users/bmw/orgs","repos_url":"https://api.github.com/users/bmw/repos","events_url":"https://api.github.com/users/bmw/events{/privacy}","received_events_url":"https://api.github.com/users/bmw/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":26,"state":"open","created_at":"2017-12-08T18:07:42Z","updated_at":"2018-02-22T23:50:39Z","due_on":"2018-02-07T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/certbot/certbot/pulls/5612/commits","review_comments_url":"https://api.github.com/repos/certbot/certbot/pulls/5612/comments","review_comment_url":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/certbot/certbot/issues/5612/comments","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/c53a1cfa342903f2f77bb5c0f6a3bf64f421aa1c","head":{"label":"certbot:fix-acmev2-real","ref":"fix-acmev2-real","sha":"c53a1cfa342903f2f77bb5c0f6a3bf64f421aa1c","user":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"certbot","full_name":"certbot/certbot","owner":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/certbot/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server.  It can also act as a client for any other CA that uses the ACME protocol.","fork":false,"url":"https://api.github.com/repos/certbot/certbot","forks_url":"https://api.github.com/repos/certbot/certbot/forks","keys_url":"https://api.github.com/repos/certbot/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certbot/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certbot/certbot/teams","hooks_url":"https://api.github.com/repos/certbot/certbot/hooks","issue_events_url":"https://api.github.com/repos/certbot/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/certbot/certbot/events","assignees_url":"https://api.github.com/repos/certbot/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/certbot/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/certbot/certbot/tags","blobs_url":"https://api.github.com/repos/certbot/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certbot/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certbot/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/certbot/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/certbot/certbot/languages","stargazers_url":"https://api.github.com/repos/certbot/certbot/stargazers","contributors_url":"https://api.github.com/repos/certbot/certbot/contributors","subscribers_url":"https://api.github.com/repos/certbot/certbot/subscribers","subscription_url":"https://api.github.com/repos/certbot/certbot/subscription","commits_url":"https://api.github.com/repos/certbot/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/certbot/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/certbot/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/certbot/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/certbot/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/certbot/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certbot/certbot/merges","archive_url":"https://api.github.com/repos/certbot/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certbot/certbot/downloads","issues_url":"https://api.github.com/repos/certbot/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/certbot/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/certbot/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/certbot/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certbot/certbot/labels{/name}","releases_url":"https://api.github.com/repos/certbot/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/certbot/certbot/deployments","created_at":"2014-11-12T02:52:20Z","updated_at":"2018-02-23T00:01:39Z","pushed_at":"2018-02-22T23:50:40Z","git_url":"git://github.com/certbot/certbot.git","ssh_url":"git@github.com:certbot/certbot.git","clone_url":"https://github.com/certbot/certbot.git","svn_url":"https://github.com/certbot/certbot","homepage":"","size":17513,"stargazers_count":21134,"watchers_count":21134,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1974,"mirror_url":null,"archived":false,"open_issues_count":932,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1974,"open_issues":932,"watchers":21134,"default_branch":"master"}},"base":{"label":"certbot:master","ref":"master","sha":"990b211a76efb5a376cc4076bbbc2c2f0a2b3f2b","user":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"certbot","full_name":"certbot/certbot","owner":{"login":"certbot","id":17889013,"avatar_url":"https://avatars2.githubusercontent.com/u/17889013?v=4","gravatar_id":"","url":"https://api.github.com/users/certbot","html_url":"https://github.com/certbot","followers_url":"https://api.github.com/users/certbot/followers","following_url":"https://api.github.com/users/certbot/following{/other_user}","gists_url":"https://api.github.com/users/certbot/gists{/gist_id}","starred_url":"https://api.github.com/users/certbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/certbot/subscriptions","organizations_url":"https://api.github.com/users/certbot/orgs","repos_url":"https://api.github.com/users/certbot/repos","events_url":"https://api.github.com/users/certbot/events{/privacy}","received_events_url":"https://api.github.com/users/certbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/certbot/certbot","description":"Certbot is EFF's tool to obtain certs from Let's Encrypt and (optionally) auto-enable HTTPS on your server.  It can also act as a client for any other CA that uses the ACME protocol.","fork":false,"url":"https://api.github.com/repos/certbot/certbot","forks_url":"https://api.github.com/repos/certbot/certbot/forks","keys_url":"https://api.github.com/repos/certbot/certbot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/certbot/certbot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/certbot/certbot/teams","hooks_url":"https://api.github.com/repos/certbot/certbot/hooks","issue_events_url":"https://api.github.com/repos/certbot/certbot/issues/events{/number}","events_url":"https://api.github.com/repos/certbot/certbot/events","assignees_url":"https://api.github.com/repos/certbot/certbot/assignees{/user}","branches_url":"https://api.github.com/repos/certbot/certbot/branches{/branch}","tags_url":"https://api.github.com/repos/certbot/certbot/tags","blobs_url":"https://api.github.com/repos/certbot/certbot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/certbot/certbot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/certbot/certbot/git/refs{/sha}","trees_url":"https://api.github.com/repos/certbot/certbot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/certbot/certbot/statuses/{sha}","languages_url":"https://api.github.com/repos/certbot/certbot/languages","stargazers_url":"https://api.github.com/repos/certbot/certbot/stargazers","contributors_url":"https://api.github.com/repos/certbot/certbot/contributors","subscribers_url":"https://api.github.com/repos/certbot/certbot/subscribers","subscription_url":"https://api.github.com/repos/certbot/certbot/subscription","commits_url":"https://api.github.com/repos/certbot/certbot/commits{/sha}","git_commits_url":"https://api.github.com/repos/certbot/certbot/git/commits{/sha}","comments_url":"https://api.github.com/repos/certbot/certbot/comments{/number}","issue_comment_url":"https://api.github.com/repos/certbot/certbot/issues/comments{/number}","contents_url":"https://api.github.com/repos/certbot/certbot/contents/{+path}","compare_url":"https://api.github.com/repos/certbot/certbot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/certbot/certbot/merges","archive_url":"https://api.github.com/repos/certbot/certbot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/certbot/certbot/downloads","issues_url":"https://api.github.com/repos/certbot/certbot/issues{/number}","pulls_url":"https://api.github.com/repos/certbot/certbot/pulls{/number}","milestones_url":"https://api.github.com/repos/certbot/certbot/milestones{/number}","notifications_url":"https://api.github.com/repos/certbot/certbot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/certbot/certbot/labels{/name}","releases_url":"https://api.github.com/repos/certbot/certbot/releases{/id}","deployments_url":"https://api.github.com/repos/certbot/certbot/deployments","created_at":"2014-11-12T02:52:20Z","updated_at":"2018-02-23T00:01:39Z","pushed_at":"2018-02-22T23:50:40Z","git_url":"git://github.com/certbot/certbot.git","ssh_url":"git@github.com:certbot/certbot.git","clone_url":"https://github.com/certbot/certbot.git","svn_url":"https://github.com/certbot/certbot","homepage":"","size":17513,"stargazers_count":21134,"watchers_count":21134,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1974,"mirror_url":null,"archived":false,"open_issues_count":932,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1974,"open_issues":932,"watchers":21134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5612"},"html":{"href":"https://github.com/certbot/certbot/pull/5612"},"issue":{"href":"https://api.github.com/repos/certbot/certbot/issues/5612"},"comments":{"href":"https://api.github.com/repos/certbot/certbot/issues/5612/comments"},"review_comments":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5612/comments"},"review_comment":{"href":"https://api.github.com/repos/certbot/certbot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/certbot/certbot/pulls/5612/commits"},"statuses":{"href":"https://api.github.com/repos/certbot/certbot/statuses/c53a1cfa342903f2f77bb5c0f6a3bf64f421aa1c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bmw"}}