{"action":"created","issue":{"url":"https://api.github.com/repos/collectiveaccess/providence/issues/322","repository_url":"https://api.github.com/repos/collectiveaccess/providence","labels_url":"https://api.github.com/repos/collectiveaccess/providence/issues/322/labels{/name}","comments_url":"https://api.github.com/repos/collectiveaccess/providence/issues/322/comments","events_url":"https://api.github.com/repos/collectiveaccess/providence/issues/322/events","html_url":"https://github.com/collectiveaccess/providence/issues/322","id":296414089,"number":322,"title":"composer.lock does not match vendor directory","user":{"login":"axelvnk","id":6803540,"avatar_url":"https://avatars2.githubusercontent.com/u/6803540?v=4","gravatar_id":"","url":"https://api.github.com/users/axelvnk","html_url":"https://github.com/axelvnk","followers_url":"https://api.github.com/users/axelvnk/followers","following_url":"https://api.github.com/users/axelvnk/following{/other_user}","gists_url":"https://api.github.com/users/axelvnk/gists{/gist_id}","starred_url":"https://api.github.com/users/axelvnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axelvnk/subscriptions","organizations_url":"https://api.github.com/users/axelvnk/orgs","repos_url":"https://api.github.com/users/axelvnk/repos","events_url":"https://api.github.com/users/axelvnk/events{/privacy}","received_events_url":"https://api.github.com/users/axelvnk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-02-12T15:25:26Z","updated_at":"2018-02-12T16:42:08Z","closed_at":null,"author_association":"NONE","body":"example : \r\nelasticsearch/elasticsearch\r\n - composer.lock : version 2.1.5\r\n - actual version in vendor dir : 2.3.0\r\n\r\nMe as a developer just executes composer install when I see a lock file, not really noticed the vendor directory. Had me looking for hours why I had certain errors.\r\n\r\nWe have to fix the composer.lock file. But I would also really like to completely remove the vendor directory. But I guess the reason why it's here in the first place is for sitebuilders. We can also just add a composer.phar and run php composer.phar install from the install script. \r\n\r\nI'll open up a PR for the lock file."},"comment":{"url":"https://api.github.com/repos/collectiveaccess/providence/issues/comments/364982516","html_url":"https://github.com/collectiveaccess/providence/issues/322#issuecomment-364982516","issue_url":"https://api.github.com/repos/collectiveaccess/providence/issues/322","id":364982516,"user":{"login":"inquisite","id":7827800,"avatar_url":"https://avatars0.githubusercontent.com/u/7827800?v=4","gravatar_id":"","url":"https://api.github.com/users/inquisite","html_url":"https://github.com/inquisite","followers_url":"https://api.github.com/users/inquisite/followers","following_url":"https://api.github.com/users/inquisite/following{/other_user}","gists_url":"https://api.github.com/users/inquisite/gists{/gist_id}","starred_url":"https://api.github.com/users/inquisite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inquisite/subscriptions","organizations_url":"https://api.github.com/users/inquisite/orgs","repos_url":"https://api.github.com/users/inquisite/repos","events_url":"https://api.github.com/users/inquisite/events{/privacy}","received_events_url":"https://api.github.com/users/inquisite/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T16:42:08Z","updated_at":"2018-02-12T16:42:08Z","author_association":"NONE","body":"Yeah, i know it needs to be there. I mean the incorrect one needs to go.\r\n\r\nKehan: I fully agree that having vendor/ in Git is ugly and annoying and just plain stupid. So long as you don't run composer on your install you won't have conflicts, but of course that's not really a solution. The issue for us is that a whole lot of people are running off of GitHub and are not inclined to, or capable of, dealing with composer. Our response to the resultant support headaches was simply to bring in copies of dependencies, first in app/lib/ and later in vendor/. This creates support headaches from people like you, but you are fewer in number :-)\r\n\r\nIn the short term this will have to remain as it is. In the medium term we will get rid of vendor/ and require composer use. We can hopefully mitigate some of the support issues with a simple script to do the composer install and initial run. This will dovetail with removal of most assets/ and replacement with NPM. Work on that is supposed to start this week."}}
{"actor":{"display_login":"inquisite"}}