{"action":"opened","number":54,"pull_request":{"url":"https://api.github.com/repos/softdevteam/lrpar/pulls/54","id":172202662,"html_url":"https://github.com/softdevteam/lrpar/pull/54","diff_url":"https://github.com/softdevteam/lrpar/pull/54.diff","patch_url":"https://github.com/softdevteam/lrpar/pull/54.patch","issue_url":"https://api.github.com/repos/softdevteam/lrpar/issues/54","number":54,"state":"open","locked":false,"title":"Reimplement Corchuelo in the style of MF, and also fix the shift() function","user":{"login":"ltratt","id":20318,"avatar_url":"https://avatars1.githubusercontent.com/u/20318?v=4","gravatar_id":"","url":"https://api.github.com/users/ltratt","html_url":"https://github.com/ltratt","followers_url":"https://api.github.com/users/ltratt/followers","following_url":"https://api.github.com/users/ltratt/following{/other_user}","gists_url":"https://api.github.com/users/ltratt/gists{/gist_id}","starred_url":"https://api.github.com/users/ltratt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltratt/subscriptions","organizations_url":"https://api.github.com/users/ltratt/orgs","repos_url":"https://api.github.com/users/ltratt/repos","events_url":"https://api.github.com/users/ltratt/events{/privacy}","received_events_url":"https://api.github.com/users/ltratt/received_events","type":"User","site_admin":false},"body":"Reimplement Corchuelo in the style of MF, and also fix the shift() function.\r\n\r\nOur implementation of the Corchuelo recoverer was in a much different (and worse) style to the MF recoverer. This commit homogenises the styles, generally by copying code from MF with the minimal necessary changes.\r\n\r\nThis also seems the right time to finally bite the bullet and fix one of Corchuelo's most glaring errors: the forward move (what we call the \"insert\") rule is broken. Because it always tries to generate the maximum possible number of shifts, it misses out some minimal repairs (as KimYi state, but don't explain). This commit thus changes the shift rule to only find one shift at a time. This means that the Corchuelo recoverer can now find all of the same repairs as the MF recoverer.\r\n\r\nBecause the Corchuelo recoverer creates duplicate nodes in its search, the astar_all function isn't quite what we want. For what of a better term, I've implemented a Dijkstra function. This weeds out duplicates in the todo list. This is clearly less powerful than remembering all previously seen nodes, but implementing that was about 10% slower (possibly just because of the extra memory needed).","created_at":"2018-03-01T10:51:23Z","updated_at":"2018-03-01T10:51:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"ptersilie","id":375552,"avatar_url":"https://avatars1.githubusercontent.com/u/375552?v=4","gravatar_id":"","url":"https://api.github.com/users/ptersilie","html_url":"https://github.com/ptersilie","followers_url":"https://api.github.com/users/ptersilie/followers","following_url":"https://api.github.com/users/ptersilie/following{/other_user}","gists_url":"https://api.github.com/users/ptersilie/gists{/gist_id}","starred_url":"https://api.github.com/users/ptersilie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptersilie/subscriptions","organizations_url":"https://api.github.com/users/ptersilie/orgs","repos_url":"https://api.github.com/users/ptersilie/repos","events_url":"https://api.github.com/users/ptersilie/events{/privacy}","received_events_url":"https://api.github.com/users/ptersilie/received_events","type":"User","site_admin":false},"assignees":[{"login":"ptersilie","id":375552,"avatar_url":"https://avatars1.githubusercontent.com/u/375552?v=4","gravatar_id":"","url":"https://api.github.com/users/ptersilie","html_url":"https://github.com/ptersilie","followers_url":"https://api.github.com/users/ptersilie/followers","following_url":"https://api.github.com/users/ptersilie/following{/other_user}","gists_url":"https://api.github.com/users/ptersilie/gists{/gist_id}","starred_url":"https://api.github.com/users/ptersilie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptersilie/subscriptions","organizations_url":"https://api.github.com/users/ptersilie/orgs","repos_url":"https://api.github.com/users/ptersilie/repos","events_url":"https://api.github.com/users/ptersilie/events{/privacy}","received_events_url":"https://api.github.com/users/ptersilie/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/softdevteam/lrpar/pulls/54/commits","review_comments_url":"https://api.github.com/repos/softdevteam/lrpar/pulls/54/comments","review_comment_url":"https://api.github.com/repos/softdevteam/lrpar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/softdevteam/lrpar/issues/54/comments","statuses_url":"https://api.github.com/repos/softdevteam/lrpar/statuses/0368c95b59863e8ef391841b30cc2567d55cbcbe","head":{"label":"softdevteam:homogenise_corchuelo","ref":"homogenise_corchuelo","sha":"0368c95b59863e8ef391841b30cc2567d55cbcbe","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":50364866,"name":"lrpar","full_name":"softdevteam/lrpar","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/lrpar","description":"Rust LR parser","fork":false,"url":"https://api.github.com/repos/softdevteam/lrpar","forks_url":"https://api.github.com/repos/softdevteam/lrpar/forks","keys_url":"https://api.github.com/repos/softdevteam/lrpar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/lrpar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/lrpar/teams","hooks_url":"https://api.github.com/repos/softdevteam/lrpar/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/lrpar/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/lrpar/events","assignees_url":"https://api.github.com/repos/softdevteam/lrpar/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/lrpar/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/lrpar/tags","blobs_url":"https://api.github.com/repos/softdevteam/lrpar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/lrpar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/lrpar/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/lrpar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/lrpar/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/lrpar/languages","stargazers_url":"https://api.github.com/repos/softdevteam/lrpar/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/lrpar/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/lrpar/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/lrpar/subscription","commits_url":"https://api.github.com/repos/softdevteam/lrpar/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/lrpar/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/lrpar/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/lrpar/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/lrpar/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/lrpar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/lrpar/merges","archive_url":"https://api.github.com/repos/softdevteam/lrpar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/lrpar/downloads","issues_url":"https://api.github.com/repos/softdevteam/lrpar/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/lrpar/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/lrpar/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/lrpar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/lrpar/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/lrpar/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/lrpar/deployments","created_at":"2016-01-25T16:40:56Z","updated_at":"2017-02-14T14:17:06Z","pushed_at":"2018-02-28T23:48:48Z","git_url":"git://github.com/softdevteam/lrpar.git","ssh_url":"git@github.com:softdevteam/lrpar.git","clone_url":"https://github.com/softdevteam/lrpar.git","svn_url":"https://github.com/softdevteam/lrpar","homepage":null,"size":337,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"softdevteam:master","ref":"master","sha":"e53b1a37b1652a6de43e46df337c12520b8e8759","user":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"repo":{"id":50364866,"name":"lrpar","full_name":"softdevteam/lrpar","owner":{"login":"softdevteam","id":10271085,"avatar_url":"https://avatars0.githubusercontent.com/u/10271085?v=4","gravatar_id":"","url":"https://api.github.com/users/softdevteam","html_url":"https://github.com/softdevteam","followers_url":"https://api.github.com/users/softdevteam/followers","following_url":"https://api.github.com/users/softdevteam/following{/other_user}","gists_url":"https://api.github.com/users/softdevteam/gists{/gist_id}","starred_url":"https://api.github.com/users/softdevteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/softdevteam/subscriptions","organizations_url":"https://api.github.com/users/softdevteam/orgs","repos_url":"https://api.github.com/users/softdevteam/repos","events_url":"https://api.github.com/users/softdevteam/events{/privacy}","received_events_url":"https://api.github.com/users/softdevteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/softdevteam/lrpar","description":"Rust LR parser","fork":false,"url":"https://api.github.com/repos/softdevteam/lrpar","forks_url":"https://api.github.com/repos/softdevteam/lrpar/forks","keys_url":"https://api.github.com/repos/softdevteam/lrpar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/softdevteam/lrpar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/softdevteam/lrpar/teams","hooks_url":"https://api.github.com/repos/softdevteam/lrpar/hooks","issue_events_url":"https://api.github.com/repos/softdevteam/lrpar/issues/events{/number}","events_url":"https://api.github.com/repos/softdevteam/lrpar/events","assignees_url":"https://api.github.com/repos/softdevteam/lrpar/assignees{/user}","branches_url":"https://api.github.com/repos/softdevteam/lrpar/branches{/branch}","tags_url":"https://api.github.com/repos/softdevteam/lrpar/tags","blobs_url":"https://api.github.com/repos/softdevteam/lrpar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/softdevteam/lrpar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/softdevteam/lrpar/git/refs{/sha}","trees_url":"https://api.github.com/repos/softdevteam/lrpar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/softdevteam/lrpar/statuses/{sha}","languages_url":"https://api.github.com/repos/softdevteam/lrpar/languages","stargazers_url":"https://api.github.com/repos/softdevteam/lrpar/stargazers","contributors_url":"https://api.github.com/repos/softdevteam/lrpar/contributors","subscribers_url":"https://api.github.com/repos/softdevteam/lrpar/subscribers","subscription_url":"https://api.github.com/repos/softdevteam/lrpar/subscription","commits_url":"https://api.github.com/repos/softdevteam/lrpar/commits{/sha}","git_commits_url":"https://api.github.com/repos/softdevteam/lrpar/git/commits{/sha}","comments_url":"https://api.github.com/repos/softdevteam/lrpar/comments{/number}","issue_comment_url":"https://api.github.com/repos/softdevteam/lrpar/issues/comments{/number}","contents_url":"https://api.github.com/repos/softdevteam/lrpar/contents/{+path}","compare_url":"https://api.github.com/repos/softdevteam/lrpar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/softdevteam/lrpar/merges","archive_url":"https://api.github.com/repos/softdevteam/lrpar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/softdevteam/lrpar/downloads","issues_url":"https://api.github.com/repos/softdevteam/lrpar/issues{/number}","pulls_url":"https://api.github.com/repos/softdevteam/lrpar/pulls{/number}","milestones_url":"https://api.github.com/repos/softdevteam/lrpar/milestones{/number}","notifications_url":"https://api.github.com/repos/softdevteam/lrpar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/softdevteam/lrpar/labels{/name}","releases_url":"https://api.github.com/repos/softdevteam/lrpar/releases{/id}","deployments_url":"https://api.github.com/repos/softdevteam/lrpar/deployments","created_at":"2016-01-25T16:40:56Z","updated_at":"2017-02-14T14:17:06Z","pushed_at":"2018-02-28T23:48:48Z","git_url":"git://github.com/softdevteam/lrpar.git","ssh_url":"git@github.com:softdevteam/lrpar.git","clone_url":"https://github.com/softdevteam/lrpar.git","svn_url":"https://github.com/softdevteam/lrpar","homepage":null,"size":337,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/softdevteam/lrpar/pulls/54"},"html":{"href":"https://github.com/softdevteam/lrpar/pull/54"},"issue":{"href":"https://api.github.com/repos/softdevteam/lrpar/issues/54"},"comments":{"href":"https://api.github.com/repos/softdevteam/lrpar/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/softdevteam/lrpar/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/softdevteam/lrpar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/softdevteam/lrpar/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/softdevteam/lrpar/statuses/0368c95b59863e8ef391841b30cc2567d55cbcbe"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":509,"deletions":249,"changed_files":6}}
{"actor":{"display_login":"ltratt"}}