{"action":"created","comment":{"url":"https://api.github.com/repos/aurelia/aurelia/pulls/comments/244592015","pull_request_review_id":188504910,"id":244592015,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU5MjAxNQ==","diff_hunk":"@@ -144,7 +147,14 @@ export class HistoryBrowser {\n     });\n   }\n \n-  public replacePath(path: string, fullStatePath: string): void {\n+  public replacePath(path: string, fullStatePath: string, entry: INavigationInstruction): void {\n+    if (entry.index !== this.currentEntry.index) {\n+      // TODO: Store unresolved in localStorage to set if we should ever navigate back to it","path":"packages/router/src/history-browser.ts","position":35,"original_position":35,"commit_id":"54cb98ab223e0dc4b78a3c9c910f7bec98f6c4f7","original_commit_id":"54cb98ab223e0dc4b78a3c9c910f7bec98f6c4f7","user":{"login":"jwx","id":3307996,"node_id":"MDQ6VXNlcjMzMDc5OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3307996?v=4","gravatar_id":"","url":"https://api.github.com/users/jwx","html_url":"https://github.com/jwx","followers_url":"https://api.github.com/users/jwx/followers","following_url":"https://api.github.com/users/jwx/following{/other_user}","gists_url":"https://api.github.com/users/jwx/gists{/gist_id}","starred_url":"https://api.github.com/users/jwx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwx/subscriptions","organizations_url":"https://api.github.com/users/jwx/orgs","repos_url":"https://api.github.com/users/jwx/repos","events_url":"https://api.github.com/users/jwx/events{/privacy}","received_events_url":"https://api.github.com/users/jwx/received_events","type":"User","site_admin":false},"body":"Yeah, but certain scenarios (for example where the browser is stressed with multiple navigations through browser buttons) might suffer without it. It's rare, so it should definitely be possible to turn off/clear out.","created_at":"2018-12-31T15:00:54Z","updated_at":"2018-12-31T15:00:54Z","html_url":"https://github.com/aurelia/aurelia/pull/354#discussion_r244592015","pull_request_url":"https://api.github.com/repos/aurelia/aurelia/pulls/354","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aurelia/aurelia/pulls/comments/244592015"},"html":{"href":"https://github.com/aurelia/aurelia/pull/354#discussion_r244592015"},"pull_request":{"href":"https://api.github.com/repos/aurelia/aurelia/pulls/354"}},"in_reply_to_id":244583518},"pull_request":{"url":"https://api.github.com/repos/aurelia/aurelia/pulls/354","id":241545281,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTQ1Mjgx","html_url":"https://github.com/aurelia/aurelia/pull/354","diff_url":"https://github.com/aurelia/aurelia/pull/354.diff","patch_url":"https://github.com/aurelia/aurelia/pull/354.patch","issue_url":"https://api.github.com/repos/aurelia/aurelia/issues/354","number":354,"state":"open","locked":false,"title":"[WIP] Router parameters","user":{"login":"jwx","id":3307996,"node_id":"MDQ6VXNlcjMzMDc5OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3307996?v=4","gravatar_id":"","url":"https://api.github.com/users/jwx","html_url":"https://github.com/jwx","followers_url":"https://api.github.com/users/jwx/followers","following_url":"https://api.github.com/users/jwx/following{/other_user}","gists_url":"https://api.github.com/users/jwx/gists{/gist_id}","starred_url":"https://api.github.com/users/jwx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwx/subscriptions","organizations_url":"https://api.github.com/users/jwx/orgs","repos_url":"https://api.github.com/users/jwx/repos","events_url":"https://api.github.com/users/jwx/events{/privacy}","received_events_url":"https://api.github.com/users/jwx/received_events","type":"User","site_admin":false},"body":"<!---\r\nThanks for filing a pull request 😄 ! Before you submit, please read the following:\r\n\r\nSearch open/closed issues before submitting since someone might have pushed the same thing before!\r\n-->\r\n\r\n# Pull Request\r\n\r\n## 📖 Description\r\n\r\nWIP of parameters for the convention-based router. Test application can be found in packages/router/test/e2e/layouts. (Select Lobby followed by Contacts.)\r\n\r\n### 🎫 Issues\r\n\r\n<!---\r\n* List and link relevant issues here.\r\n-->\r\n\r\n## 👩‍💻 Reviewer Notes\r\n\r\n<!---\r\nProvide some notes for reviewers to help them provide targeted feedback.\r\n-->\r\n\r\n## 📑 Test Plan\r\n\r\n<!---\r\nPlease provide a summary of the tests affected by this work and any unique strategies employed in testing the features/fixes.\r\n-->\r\n\r\n## ⏭ Next Steps\r\n\r\n<!---\r\nIf there is relevant follow-up work to this PR, please list any existing issues or provide brief descriptions of what you would like to do next.\r\n-->\r\n\r\n<!--\r\nLove Aurelia? Please consider supporting our collective:\r\n👉  https://opencollective.com/aurelia\r\n-->\r\n","created_at":"2018-12-31T09:55:19Z","updated_at":"2018-12-31T15:00:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6052d43d7a500a1abc6731f89552d097edd1ea1d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/aurelia/pulls/354/commits","review_comments_url":"https://api.github.com/repos/aurelia/aurelia/pulls/354/comments","review_comment_url":"https://api.github.com/repos/aurelia/aurelia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/aurelia/issues/354/comments","statuses_url":"https://api.github.com/repos/aurelia/aurelia/statuses/54cb98ab223e0dc4b78a3c9c910f7bec98f6c4f7","head":{"label":"aurelia:jwx-router-nav","ref":"jwx-router-nav","sha":"54cb98ab223e0dc4b78a3c9c910f7bec98f6c4f7","user":{"login":"aurelia","id":9808864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":121594173,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1OTQxNzM=","name":"aurelia","full_name":"aurelia/aurelia","private":false,"owner":{"login":"aurelia","id":9808864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aurelia/aurelia","description":"Aurelia vNext","fork":false,"url":"https://api.github.com/repos/aurelia/aurelia","forks_url":"https://api.github.com/repos/aurelia/aurelia/forks","keys_url":"https://api.github.com/repos/aurelia/aurelia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/aurelia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/aurelia/teams","hooks_url":"https://api.github.com/repos/aurelia/aurelia/hooks","issue_events_url":"https://api.github.com/repos/aurelia/aurelia/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/aurelia/events","assignees_url":"https://api.github.com/repos/aurelia/aurelia/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/aurelia/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/aurelia/tags","blobs_url":"https://api.github.com/repos/aurelia/aurelia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/aurelia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/aurelia/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/aurelia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/aurelia/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/aurelia/languages","stargazers_url":"https://api.github.com/repos/aurelia/aurelia/stargazers","contributors_url":"https://api.github.com/repos/aurelia/aurelia/contributors","subscribers_url":"https://api.github.com/repos/aurelia/aurelia/subscribers","subscription_url":"https://api.github.com/repos/aurelia/aurelia/subscription","commits_url":"https://api.github.com/repos/aurelia/aurelia/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/aurelia/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/aurelia/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/aurelia/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/aurelia/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/aurelia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/aurelia/merges","archive_url":"https://api.github.com/repos/aurelia/aurelia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/aurelia/downloads","issues_url":"https://api.github.com/repos/aurelia/aurelia/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/aurelia/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/aurelia/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/aurelia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/aurelia/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/aurelia/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/aurelia/deployments","created_at":"2018-02-15T05:22:58Z","updated_at":"2018-12-31T05:19:10Z","pushed_at":"2018-12-31T12:26:22Z","git_url":"git://github.com/aurelia/aurelia.git","ssh_url":"git@github.com:aurelia/aurelia.git","clone_url":"https://github.com/aurelia/aurelia.git","svn_url":"https://github.com/aurelia/aurelia","homepage":"","size":19663,"stargazers_count":407,"watchers_count":407,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":22,"open_issues":50,"watchers":407,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"22eb3cb484b1505a3eed37be99a45dcad839b225","user":{"login":"aurelia","id":9808864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":121594173,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE1OTQxNzM=","name":"aurelia","full_name":"aurelia/aurelia","private":false,"owner":{"login":"aurelia","id":9808864,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MDg4NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aurelia/aurelia","description":"Aurelia vNext","fork":false,"url":"https://api.github.com/repos/aurelia/aurelia","forks_url":"https://api.github.com/repos/aurelia/aurelia/forks","keys_url":"https://api.github.com/repos/aurelia/aurelia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/aurelia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/aurelia/teams","hooks_url":"https://api.github.com/repos/aurelia/aurelia/hooks","issue_events_url":"https://api.github.com/repos/aurelia/aurelia/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/aurelia/events","assignees_url":"https://api.github.com/repos/aurelia/aurelia/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/aurelia/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/aurelia/tags","blobs_url":"https://api.github.com/repos/aurelia/aurelia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/aurelia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/aurelia/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/aurelia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/aurelia/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/aurelia/languages","stargazers_url":"https://api.github.com/repos/aurelia/aurelia/stargazers","contributors_url":"https://api.github.com/repos/aurelia/aurelia/contributors","subscribers_url":"https://api.github.com/repos/aurelia/aurelia/subscribers","subscription_url":"https://api.github.com/repos/aurelia/aurelia/subscription","commits_url":"https://api.github.com/repos/aurelia/aurelia/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/aurelia/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/aurelia/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/aurelia/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/aurelia/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/aurelia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/aurelia/merges","archive_url":"https://api.github.com/repos/aurelia/aurelia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/aurelia/downloads","issues_url":"https://api.github.com/repos/aurelia/aurelia/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/aurelia/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/aurelia/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/aurelia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/aurelia/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/aurelia/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/aurelia/deployments","created_at":"2018-02-15T05:22:58Z","updated_at":"2018-12-31T05:19:10Z","pushed_at":"2018-12-31T12:26:22Z","git_url":"git://github.com/aurelia/aurelia.git","ssh_url":"git@github.com:aurelia/aurelia.git","clone_url":"https://github.com/aurelia/aurelia.git","svn_url":"https://github.com/aurelia/aurelia","homepage":"","size":19663,"stargazers_count":407,"watchers_count":407,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":22,"open_issues":50,"watchers":407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/aurelia/pulls/354"},"html":{"href":"https://github.com/aurelia/aurelia/pull/354"},"issue":{"href":"https://api.github.com/repos/aurelia/aurelia/issues/354"},"comments":{"href":"https://api.github.com/repos/aurelia/aurelia/issues/354/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/aurelia/pulls/354/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/aurelia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/aurelia/pulls/354/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/aurelia/statuses/54cb98ab223e0dc4b78a3c9c910f7bec98f6c4f7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jwx"}}