{"action":"opened","number":10229,"pull_request":{"url":"https://api.github.com/repos/ant-design/ant-design/pulls/10229","id":183677522,"html_url":"https://github.com/ant-design/ant-design/pull/10229","diff_url":"https://github.com/ant-design/ant-design/pull/10229.diff","patch_url":"https://github.com/ant-design/ant-design/pull/10229.patch","issue_url":"https://api.github.com/repos/ant-design/ant-design/issues/10229","number":10229,"state":"open","locked":false,"title":"fix(button): use React.HTMLProps for button's props","user":{"login":"whtsky","id":876694,"avatar_url":"https://avatars3.githubusercontent.com/u/876694?v=4","gravatar_id":"","url":"https://api.github.com/users/whtsky","html_url":"https://github.com/whtsky","followers_url":"https://api.github.com/users/whtsky/followers","following_url":"https://api.github.com/users/whtsky/following{/other_user}","gists_url":"https://api.github.com/users/whtsky/gists{/gist_id}","starred_url":"https://api.github.com/users/whtsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whtsky/subscriptions","organizations_url":"https://api.github.com/users/whtsky/orgs","repos_url":"https://api.github.com/users/whtsky/repos","events_url":"https://api.github.com/users/whtsky/events{/privacy}","received_events_url":"https://api.github.com/users/whtsky/received_events","type":"User","site_admin":false},"body":"First of all, thank you for your contribution! :-)\r\n\r\nPlease makes sure that these checkboxes are checked before submitting your PR, thank you!\r\n\r\n* [x] Make sure that you propose PR to right branch: bugfix for `master`, feature for latest active branch `feature-x.x`.\r\n* [x] Make sure that you follow antd's [code convention](https://github.com/ant-design/ant-design/wiki/Code-convention-for-antd).\r\n* [x] Run `npm run lint` and fix those errors before submitting in order to keep consistent code style.\r\n* [x] Rebase before creating a PR to keep commit history clear.\r\n* [x] Add some descriptions and refer relative issues for you PR.\r\n\r\n\r\nThe old props of `Button` component lacks a lot of prop, like `onMouseOver` etc. \r\n\r\nExtra checklist:\r\n\r\n**if** *isBugFix* **:**\r\n\r\n  * [ ] Make sure that you add at least one unit test for the bug which you had fixed. ( Not possible since it's a typing fix and test are written in JavaScript )\r\n\r\n","created_at":"2018-04-24T09:42:20Z","updated_at":"2018-04-24T09:42:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ant-design/ant-design/pulls/10229/commits","review_comments_url":"https://api.github.com/repos/ant-design/ant-design/pulls/10229/comments","review_comment_url":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ant-design/ant-design/issues/10229/comments","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/93d54e4979996ff99544d6bba8906730a3c4e878","head":{"label":"whtsky:fix-button-typing","ref":"fix-button-typing","sha":"93d54e4979996ff99544d6bba8906730a3c4e878","user":{"login":"whtsky","id":876694,"avatar_url":"https://avatars3.githubusercontent.com/u/876694?v=4","gravatar_id":"","url":"https://api.github.com/users/whtsky","html_url":"https://github.com/whtsky","followers_url":"https://api.github.com/users/whtsky/followers","following_url":"https://api.github.com/users/whtsky/following{/other_user}","gists_url":"https://api.github.com/users/whtsky/gists{/gist_id}","starred_url":"https://api.github.com/users/whtsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whtsky/subscriptions","organizations_url":"https://api.github.com/users/whtsky/orgs","repos_url":"https://api.github.com/users/whtsky/repos","events_url":"https://api.github.com/users/whtsky/events{/privacy}","received_events_url":"https://api.github.com/users/whtsky/received_events","type":"User","site_admin":false},"repo":{"id":124492625,"name":"ant-design","full_name":"whtsky/ant-design","owner":{"login":"whtsky","id":876694,"avatar_url":"https://avatars3.githubusercontent.com/u/876694?v=4","gravatar_id":"","url":"https://api.github.com/users/whtsky","html_url":"https://github.com/whtsky","followers_url":"https://api.github.com/users/whtsky/followers","following_url":"https://api.github.com/users/whtsky/following{/other_user}","gists_url":"https://api.github.com/users/whtsky/gists{/gist_id}","starred_url":"https://api.github.com/users/whtsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whtsky/subscriptions","organizations_url":"https://api.github.com/users/whtsky/orgs","repos_url":"https://api.github.com/users/whtsky/repos","events_url":"https://api.github.com/users/whtsky/events{/privacy}","received_events_url":"https://api.github.com/users/whtsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whtsky/ant-design","description":"🐜 A UI Design Language","fork":true,"url":"https://api.github.com/repos/whtsky/ant-design","forks_url":"https://api.github.com/repos/whtsky/ant-design/forks","keys_url":"https://api.github.com/repos/whtsky/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whtsky/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whtsky/ant-design/teams","hooks_url":"https://api.github.com/repos/whtsky/ant-design/hooks","issue_events_url":"https://api.github.com/repos/whtsky/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/whtsky/ant-design/events","assignees_url":"https://api.github.com/repos/whtsky/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/whtsky/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/whtsky/ant-design/tags","blobs_url":"https://api.github.com/repos/whtsky/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whtsky/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whtsky/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/whtsky/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whtsky/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/whtsky/ant-design/languages","stargazers_url":"https://api.github.com/repos/whtsky/ant-design/stargazers","contributors_url":"https://api.github.com/repos/whtsky/ant-design/contributors","subscribers_url":"https://api.github.com/repos/whtsky/ant-design/subscribers","subscription_url":"https://api.github.com/repos/whtsky/ant-design/subscription","commits_url":"https://api.github.com/repos/whtsky/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/whtsky/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/whtsky/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/whtsky/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/whtsky/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/whtsky/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whtsky/ant-design/merges","archive_url":"https://api.github.com/repos/whtsky/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whtsky/ant-design/downloads","issues_url":"https://api.github.com/repos/whtsky/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/whtsky/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/whtsky/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/whtsky/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whtsky/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/whtsky/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/whtsky/ant-design/deployments","created_at":"2018-03-09T05:35:43Z","updated_at":"2018-04-15T13:44:17Z","pushed_at":"2018-04-24T09:39:56Z","git_url":"git://github.com/whtsky/ant-design.git","ssh_url":"git@github.com:whtsky/ant-design.git","clone_url":"https://github.com/whtsky/ant-design.git","svn_url":"https://github.com/whtsky/ant-design","homepage":"http://ant.design","size":230853,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ant-design:master","ref":"master","sha":"262ed8eec3c0401731c0d5d1289e46774e51cb25","user":{"login":"ant-design","id":12101536,"avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"repo":{"id":34526884,"name":"ant-design","full_name":"ant-design/ant-design","owner":{"login":"ant-design","id":12101536,"avatar_url":"https://avatars3.githubusercontent.com/u/12101536?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-design","html_url":"https://github.com/ant-design","followers_url":"https://api.github.com/users/ant-design/followers","following_url":"https://api.github.com/users/ant-design/following{/other_user}","gists_url":"https://api.github.com/users/ant-design/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-design/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-design/subscriptions","organizations_url":"https://api.github.com/users/ant-design/orgs","repos_url":"https://api.github.com/users/ant-design/repos","events_url":"https://api.github.com/users/ant-design/events{/privacy}","received_events_url":"https://api.github.com/users/ant-design/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ant-design/ant-design","description":"🐜 A UI Design Language","fork":false,"url":"https://api.github.com/repos/ant-design/ant-design","forks_url":"https://api.github.com/repos/ant-design/ant-design/forks","keys_url":"https://api.github.com/repos/ant-design/ant-design/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-design/ant-design/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-design/ant-design/teams","hooks_url":"https://api.github.com/repos/ant-design/ant-design/hooks","issue_events_url":"https://api.github.com/repos/ant-design/ant-design/issues/events{/number}","events_url":"https://api.github.com/repos/ant-design/ant-design/events","assignees_url":"https://api.github.com/repos/ant-design/ant-design/assignees{/user}","branches_url":"https://api.github.com/repos/ant-design/ant-design/branches{/branch}","tags_url":"https://api.github.com/repos/ant-design/ant-design/tags","blobs_url":"https://api.github.com/repos/ant-design/ant-design/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-design/ant-design/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-design/ant-design/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-design/ant-design/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-design/ant-design/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-design/ant-design/languages","stargazers_url":"https://api.github.com/repos/ant-design/ant-design/stargazers","contributors_url":"https://api.github.com/repos/ant-design/ant-design/contributors","subscribers_url":"https://api.github.com/repos/ant-design/ant-design/subscribers","subscription_url":"https://api.github.com/repos/ant-design/ant-design/subscription","commits_url":"https://api.github.com/repos/ant-design/ant-design/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-design/ant-design/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-design/ant-design/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-design/ant-design/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-design/ant-design/contents/{+path}","compare_url":"https://api.github.com/repos/ant-design/ant-design/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-design/ant-design/merges","archive_url":"https://api.github.com/repos/ant-design/ant-design/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-design/ant-design/downloads","issues_url":"https://api.github.com/repos/ant-design/ant-design/issues{/number}","pulls_url":"https://api.github.com/repos/ant-design/ant-design/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-design/ant-design/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-design/ant-design/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-design/ant-design/labels{/name}","releases_url":"https://api.github.com/repos/ant-design/ant-design/releases{/id}","deployments_url":"https://api.github.com/repos/ant-design/ant-design/deployments","created_at":"2015-04-24T15:37:24Z","updated_at":"2018-04-24T09:35:04Z","pushed_at":"2018-04-24T08:52:39Z","git_url":"git://github.com/ant-design/ant-design.git","ssh_url":"git@github.com:ant-design/ant-design.git","clone_url":"https://github.com/ant-design/ant-design.git","svn_url":"https://github.com/ant-design/ant-design","homepage":"http://ant.design","size":238730,"stargazers_count":27375,"watchers_count":27375,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8084,"mirror_url":null,"archived":false,"open_issues_count":197,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8084,"open_issues":197,"watchers":27375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/10229"},"html":{"href":"https://github.com/ant-design/ant-design/pull/10229"},"issue":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/10229"},"comments":{"href":"https://api.github.com/repos/ant-design/ant-design/issues/10229/comments"},"review_comments":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/10229/comments"},"review_comment":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ant-design/ant-design/pulls/10229/commits"},"statuses":{"href":"https://api.github.com/repos/ant-design/ant-design/statuses/93d54e4979996ff99544d6bba8906730a3c4e878"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":17,"deletions":19,"changed_files":3}}
{"actor":{"display_login":"whtsky"}}