{"action":"opened","number":111,"pull_request":{"url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls/111","id":238375388,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4Mzc1Mzg4","html_url":"https://github.com/borisdj/EFCore.BulkExtensions/pull/111","diff_url":"https://github.com/borisdj/EFCore.BulkExtensions/pull/111.diff","patch_url":"https://github.com/borisdj/EFCore.BulkExtensions/pull/111.patch","issue_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/issues/111","number":111,"state":"open","locked":false,"title":"fixed evaluation of timestamp properties","user":{"login":"Bierhals","id":21099345,"node_id":"MDQ6VXNlcjIxMDk5MzQ1","avatar_url":"https://avatars0.githubusercontent.com/u/21099345?v=4","gravatar_id":"","url":"https://api.github.com/users/Bierhals","html_url":"https://github.com/Bierhals","followers_url":"https://api.github.com/users/Bierhals/followers","following_url":"https://api.github.com/users/Bierhals/following{/other_user}","gists_url":"https://api.github.com/users/Bierhals/gists{/gist_id}","starred_url":"https://api.github.com/users/Bierhals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bierhals/subscriptions","organizations_url":"https://api.github.com/users/Bierhals/orgs","repos_url":"https://api.github.com/users/Bierhals/repos","events_url":"https://api.github.com/users/Bierhals/events{/privacy}","received_events_url":"https://api.github.com/users/Bierhals/received_events","type":"User","site_admin":false},"body":"This fixes a problem that we had with properties which are marked with [ConcurrencyCheck].\r\n\r\nFor example\r\n```\r\npublic class MyEntity\r\n{\r\n        [Key]\r\n        public int Id { get; set; }\r\n        [Required]\r\n        public DateTime CreatedDate { get; set; }\r\n        [Required]\r\n        public int CreatedBy { get; set; }\r\n        [Required]\r\n        [ConcurrencyCheck]\r\n        public DateTime UpdatedDate { get; set; }\r\n        [Required]\r\n        public int UpdatedBy { get; set; }\r\n}\r\n```\r\nor\r\n```\r\npublic class Person\r\n{\r\n    public int PersonId { get; set; }\r\n\r\n    [ConcurrencyCheck]\r\n    public string LastName { get; set; }\r\n\r\n    public string FirstName { get; set; }\r\n}\r\n```\r\nIn the original code the properties with the [ConcurrencyCheck] attribute were treated as \"timestamps\". On BulkInsert these properties then were excluded from the column-list and no values have been transfered.\r\n\r\nI have extended the check for \"timestamp\". It's now similar to the implementation of the ef-core team.\r\n[EF Core internal method IsRowVersion](https://github.com/aspnet/EntityFrameworkCore/blob/779d43731773d59ecd5f899a6330105879263cf3/src/EFCore.Design/Scaffolding/Metadata/Internal/DatabaseColumnExtensions.cs#L51)","created_at":"2018-12-13T12:40:12Z","updated_at":"2018-12-13T12:40:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls/111/commits","review_comments_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls/111/comments","review_comment_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/issues/111/comments","statuses_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/statuses/d0b2f0dd50ff280732039a3ff6f1b966147c92f7","head":{"label":"Bierhals:fix/timestamp","ref":"fix/timestamp","sha":"d0b2f0dd50ff280732039a3ff6f1b966147c92f7","user":{"login":"Bierhals","id":21099345,"node_id":"MDQ6VXNlcjIxMDk5MzQ1","avatar_url":"https://avatars0.githubusercontent.com/u/21099345?v=4","gravatar_id":"","url":"https://api.github.com/users/Bierhals","html_url":"https://github.com/Bierhals","followers_url":"https://api.github.com/users/Bierhals/followers","following_url":"https://api.github.com/users/Bierhals/following{/other_user}","gists_url":"https://api.github.com/users/Bierhals/gists{/gist_id}","starred_url":"https://api.github.com/users/Bierhals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bierhals/subscriptions","organizations_url":"https://api.github.com/users/Bierhals/orgs","repos_url":"https://api.github.com/users/Bierhals/repos","events_url":"https://api.github.com/users/Bierhals/events{/privacy}","received_events_url":"https://api.github.com/users/Bierhals/received_events","type":"User","site_admin":false},"repo":{"id":161610164,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE2MTAxNjQ=","name":"EFCore.BulkExtensions","full_name":"Bierhals/EFCore.BulkExtensions","private":false,"owner":{"login":"Bierhals","id":21099345,"node_id":"MDQ6VXNlcjIxMDk5MzQ1","avatar_url":"https://avatars0.githubusercontent.com/u/21099345?v=4","gravatar_id":"","url":"https://api.github.com/users/Bierhals","html_url":"https://github.com/Bierhals","followers_url":"https://api.github.com/users/Bierhals/followers","following_url":"https://api.github.com/users/Bierhals/following{/other_user}","gists_url":"https://api.github.com/users/Bierhals/gists{/gist_id}","starred_url":"https://api.github.com/users/Bierhals/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bierhals/subscriptions","organizations_url":"https://api.github.com/users/Bierhals/orgs","repos_url":"https://api.github.com/users/Bierhals/repos","events_url":"https://api.github.com/users/Bierhals/events{/privacy}","received_events_url":"https://api.github.com/users/Bierhals/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Bierhals/EFCore.BulkExtensions","description":"Entity Framework Core Bulk Batch Extensions for Insert Update Delete and Read (CRUD) operations on SQL Server","fork":true,"url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions","forks_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/forks","keys_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/teams","hooks_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/hooks","issue_events_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/issues/events{/number}","events_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/events","assignees_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/assignees{/user}","branches_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/branches{/branch}","tags_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/tags","blobs_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/statuses/{sha}","languages_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/languages","stargazers_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/stargazers","contributors_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/contributors","subscribers_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/subscribers","subscription_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/subscription","commits_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/contents/{+path}","compare_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/merges","archive_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/downloads","issues_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/issues{/number}","pulls_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/pulls{/number}","milestones_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/milestones{/number}","notifications_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/labels{/name}","releases_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/releases{/id}","deployments_url":"https://api.github.com/repos/Bierhals/EFCore.BulkExtensions/deployments","created_at":"2018-12-13T08:49:37Z","updated_at":"2018-12-13T08:49:39Z","pushed_at":"2018-12-13T12:12:50Z","git_url":"git://github.com/Bierhals/EFCore.BulkExtensions.git","ssh_url":"git@github.com:Bierhals/EFCore.BulkExtensions.git","clone_url":"https://github.com/Bierhals/EFCore.BulkExtensions.git","svn_url":"https://github.com/Bierhals/EFCore.BulkExtensions","homepage":"","size":487,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"borisdj:master","ref":"master","sha":"916aa54b010203ee4de983e1e0b36109142176c9","user":{"login":"borisdj","id":1279604,"node_id":"MDQ6VXNlcjEyNzk2MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1279604?v=4","gravatar_id":"","url":"https://api.github.com/users/borisdj","html_url":"https://github.com/borisdj","followers_url":"https://api.github.com/users/borisdj/followers","following_url":"https://api.github.com/users/borisdj/following{/other_user}","gists_url":"https://api.github.com/users/borisdj/gists{/gist_id}","starred_url":"https://api.github.com/users/borisdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisdj/subscriptions","organizations_url":"https://api.github.com/users/borisdj/orgs","repos_url":"https://api.github.com/users/borisdj/repos","events_url":"https://api.github.com/users/borisdj/events{/privacy}","received_events_url":"https://api.github.com/users/borisdj/received_events","type":"User","site_admin":false},"repo":{"id":91096213,"node_id":"MDEwOlJlcG9zaXRvcnk5MTA5NjIxMw==","name":"EFCore.BulkExtensions","full_name":"borisdj/EFCore.BulkExtensions","private":false,"owner":{"login":"borisdj","id":1279604,"node_id":"MDQ6VXNlcjEyNzk2MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1279604?v=4","gravatar_id":"","url":"https://api.github.com/users/borisdj","html_url":"https://github.com/borisdj","followers_url":"https://api.github.com/users/borisdj/followers","following_url":"https://api.github.com/users/borisdj/following{/other_user}","gists_url":"https://api.github.com/users/borisdj/gists{/gist_id}","starred_url":"https://api.github.com/users/borisdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisdj/subscriptions","organizations_url":"https://api.github.com/users/borisdj/orgs","repos_url":"https://api.github.com/users/borisdj/repos","events_url":"https://api.github.com/users/borisdj/events{/privacy}","received_events_url":"https://api.github.com/users/borisdj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/borisdj/EFCore.BulkExtensions","description":"Entity Framework Core Bulk Batch Extensions for Insert Update Delete and Read (CRUD) operations on SQL Server","fork":false,"url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions","forks_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/forks","keys_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/teams","hooks_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/hooks","issue_events_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/issues/events{/number}","events_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/events","assignees_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/assignees{/user}","branches_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/branches{/branch}","tags_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/tags","blobs_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/statuses/{sha}","languages_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/languages","stargazers_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/stargazers","contributors_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/contributors","subscribers_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/subscribers","subscription_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/subscription","commits_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/contents/{+path}","compare_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/merges","archive_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/downloads","issues_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/issues{/number}","pulls_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls{/number}","milestones_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/milestones{/number}","notifications_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/labels{/name}","releases_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/releases{/id}","deployments_url":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/deployments","created_at":"2017-05-12T13:50:07Z","updated_at":"2018-12-11T23:28:07Z","pushed_at":"2018-12-10T22:54:17Z","git_url":"git://github.com/borisdj/EFCore.BulkExtensions.git","ssh_url":"git@github.com:borisdj/EFCore.BulkExtensions.git","clone_url":"https://github.com/borisdj/EFCore.BulkExtensions.git","svn_url":"https://github.com/borisdj/EFCore.BulkExtensions","homepage":"","size":485,"stargazers_count":353,"watchers_count":353,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":57,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":57,"open_issues":2,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls/111"},"html":{"href":"https://github.com/borisdj/EFCore.BulkExtensions/pull/111"},"issue":{"href":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/issues/111"},"comments":{"href":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/borisdj/EFCore.BulkExtensions/statuses/d0b2f0dd50ff280732039a3ff6f1b966147c92f7"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"Bierhals"}}