{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments/239530472","pull_request_review_id":182341496,"id":239530472,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTUzMDQ3Mg==","diff_hunk":"@@ -207,6 +222,8 @@ export default class Sidebar extends React.PureComponent {\n         this.updateTitle();\n         this.setBadgesActiveAndFavicon();\n         this.setFirstAndLastUnreadChannels();\n+\n+        this.setChannelIds(snapshot, this.props, prevState);","path":"components/sidebar/sidebar.jsx","position":60,"original_position":60,"commit_id":"46796dcc977e39d767d11510abc6e138ce58d6ff","original_commit_id":"457089aa801f09c46e1b2cb7170cddc7fdc0fbce","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"body":"You're right.  I'm updating this with `getDerivedStateFromProps`, will submit shortly.","created_at":"2018-12-06T16:53:56Z","updated_at":"2018-12-06T16:53:56Z","html_url":"https://github.com/mattermost/mattermost-webapp/pull/2133#discussion_r239530472","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/2133","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments/239530472"},"html":{"href":"https://github.com/mattermost/mattermost-webapp/pull/2133#discussion_r239530472"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/2133"}},"in_reply_to_id":239034863},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/2133","id":235930795,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTMwNzk1","html_url":"https://github.com/mattermost/mattermost-webapp/pull/2133","diff_url":"https://github.com/mattermost/mattermost-webapp/pull/2133.diff","patch_url":"https://github.com/mattermost/mattermost-webapp/pull/2133.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/2133","number":2133,"state":"open","locked":false,"title":"[MM-13249] Fix jumping down of channel with mention in Unread section","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nFix jumping down of channel with mention in Unread section:\r\n- by tracking the previous values of `unreadChannelIds` and `orderedChannelIds` and keeping its values or order whenever the (new) currentChannelId is included in the list of unread channels.\r\n\r\n#### Ticket Link\r\nJira ticket: [MM-13249](https://mattermost.atlassian.net/browse/MM-13249)\r\n\r\n#### Checklist\r\n- [x] Ran `make check-style` to check for style errors (required for all pull requests)\r\n- [x] Ran `make test` to ensure unit and component tests passed\r\n- [x] Added or updated unit tests (required for all new features)\r\n","created_at":"2018-12-04T19:27:14Z","updated_at":"2018-12-06T16:53:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ee10b35b5d353c7e93a2b1a5e62a53d598b7375","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sudheerDev","id":4973621,"node_id":"MDQ6VXNlcjQ5NzM2MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4973621?v=4","gravatar_id":"","url":"https://api.github.com/users/sudheerDev","html_url":"https://github.com/sudheerDev","followers_url":"https://api.github.com/users/sudheerDev/followers","following_url":"https://api.github.com/users/sudheerDev/following{/other_user}","gists_url":"https://api.github.com/users/sudheerDev/gists{/gist_id}","starred_url":"https://api.github.com/users/sudheerDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sudheerDev/subscriptions","organizations_url":"https://api.github.com/users/sudheerDev/orgs","repos_url":"https://api.github.com/users/sudheerDev/repos","events_url":"https://api.github.com/users/sudheerDev/events{/privacy}","received_events_url":"https://api.github.com/users/sudheerDev/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":685999255,"node_id":"MDU6TGFiZWw2ODU5OTkyNTU=","url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones/17","html_url":"https://github.com/mattermost/mattermost-webapp/milestone/17","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones/17/labels","id":3696306,"node_id":"MDk6TWlsZXN0b25lMzY5NjMwNg==","number":17,"title":"v5.6.0","description":"","creator":{"login":"jespino","id":290303,"node_id":"MDQ6VXNlcjI5MDMwMw==","avatar_url":"https://avatars0.githubusercontent.com/u/290303?v=4","gravatar_id":"","url":"https://api.github.com/users/jespino","html_url":"https://github.com/jespino","followers_url":"https://api.github.com/users/jespino/followers","following_url":"https://api.github.com/users/jespino/following{/other_user}","gists_url":"https://api.github.com/users/jespino/gists{/gist_id}","starred_url":"https://api.github.com/users/jespino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jespino/subscriptions","organizations_url":"https://api.github.com/users/jespino/orgs","repos_url":"https://api.github.com/users/jespino/repos","events_url":"https://api.github.com/users/jespino/events{/privacy}","received_events_url":"https://api.github.com/users/jespino/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":151,"state":"open","created_at":"2018-09-28T10:51:29Z","updated_at":"2018-12-06T16:13:49Z","due_on":"2018-12-16T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/2133/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/2133/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/2133/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/46796dcc977e39d767d11510abc6e138ce58d6ff","head":{"label":"saturninoabril:MM-13249","ref":"MM-13249","sha":"46796dcc977e39d767d11510abc6e138ce58d6ff","user":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"repo":{"id":102709140,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3MDkxNDA=","name":"mattermost-webapp","full_name":"saturninoabril/mattermost-webapp","private":false,"owner":{"login":"saturninoabril","id":5334504,"node_id":"MDQ6VXNlcjUzMzQ1MDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"html_url":"https://github.com/saturninoabril/mattermost-webapp","description":"Webapp of Mattermost server: https://github.com/mattermost/mattermost-server","fork":true,"url":"https://api.github.com/repos/saturninoabril/mattermost-webapp","forks_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/forks","keys_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/teams","hooks_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/hooks","issue_events_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/events","assignees_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/tags","blobs_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/languages","stargazers_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/stargazers","contributors_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/contributors","subscribers_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/subscribers","subscription_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/subscription","commits_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/merges","archive_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/downloads","issues_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/labels{/name}","releases_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/saturninoabril/mattermost-webapp/deployments","created_at":"2017-09-07T08:03:14Z","updated_at":"2018-12-06T08:44:36Z","pushed_at":"2018-12-06T09:47:30Z","git_url":"git://github.com/saturninoabril/mattermost-webapp.git","ssh_url":"git@github.com:saturninoabril/mattermost-webapp.git","clone_url":"https://github.com/saturninoabril/mattermost-webapp.git","svn_url":"https://github.com/saturninoabril/mattermost-webapp","homepage":null,"size":110984,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"9b4789297e40a22c9b8edf8911e8dd8998179edc","user":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":102689445,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2ODk0NDU=","name":"mattermost-webapp","full_name":"mattermost/mattermost-webapp","private":false,"owner":{"login":"mattermost","id":9828093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk4MjgwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mattermost/mattermost-webapp","description":"Webapp of Mattermost server: https://github.com/mattermost/mattermost-server","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-webapp","forks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-webapp/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-webapp/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-webapp/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-webapp/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/deployments","created_at":"2017-09-07T04:00:02Z","updated_at":"2018-12-06T16:13:57Z","pushed_at":"2018-12-06T16:51:52Z","git_url":"git://github.com/mattermost/mattermost-webapp.git","ssh_url":"git@github.com:mattermost/mattermost-webapp.git","clone_url":"https://github.com/mattermost/mattermost-webapp.git","svn_url":"https://github.com/mattermost/mattermost-webapp","homepage":null,"size":112901,"stargazers_count":297,"watchers_count":297,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":606,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":606,"open_issues":29,"watchers":297,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/2133"},"html":{"href":"https://github.com/mattermost/mattermost-webapp/pull/2133"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/2133"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/2133/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/2133/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/2133/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/46796dcc977e39d767d11510abc6e138ce58d6ff"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"saturninoabril"}}