{"action":"created","comment":{"url":"https://api.github.com/repos/ehmatthes/pcc/pulls/comments/210026058","pull_request_review_id":146156459,"id":210026058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDAyNjA1OA==","diff_hunk":"@@ -19,9 +20,12 @@\n     names.append(repo_dict['name'])\n \n     # Get the project description, if one is available.\n+    non_bmp_map = dict.fromkeys(range(0x10000, sys.maxunicode + 1), 0xfffd)\n     description = repo_dict['description']\n     if not description:\n         description = \"No description provided.\"\n+    else:\n+        good_description = description.translate(non_bmp_map)","path":"chapter_17/python_repos_updated.py","position":14,"original_position":14,"commit_id":"c848606cdd54fb0c51c682434e89e359253aeb2d","original_commit_id":"c848606cdd54fb0c51c682434e89e359253aeb2d","user":{"login":"mare-astrorum","id":42090865,"node_id":"MDQ6VXNlcjQyMDkwODY1","avatar_url":"https://avatars3.githubusercontent.com/u/42090865?v=4","gravatar_id":"","url":"https://api.github.com/users/mare-astrorum","html_url":"https://github.com/mare-astrorum","followers_url":"https://api.github.com/users/mare-astrorum/followers","following_url":"https://api.github.com/users/mare-astrorum/following{/other_user}","gists_url":"https://api.github.com/users/mare-astrorum/gists{/gist_id}","starred_url":"https://api.github.com/users/mare-astrorum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mare-astrorum/subscriptions","organizations_url":"https://api.github.com/users/mare-astrorum/orgs","repos_url":"https://api.github.com/users/mare-astrorum/repos","events_url":"https://api.github.com/users/mare-astrorum/events{/privacy}","received_events_url":"https://api.github.com/users/mare-astrorum/received_events","type":"User","site_admin":false},"body":"I apologize, it should be just 'description' and not 'good_description' here","created_at":"2018-08-14T16:51:55Z","updated_at":"2018-08-14T16:51:55Z","html_url":"https://github.com/ehmatthes/pcc/pull/64#discussion_r210026058","pull_request_url":"https://api.github.com/repos/ehmatthes/pcc/pulls/64","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ehmatthes/pcc/pulls/comments/210026058"},"html":{"href":"https://github.com/ehmatthes/pcc/pull/64#discussion_r210026058"},"pull_request":{"href":"https://api.github.com/repos/ehmatthes/pcc/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/ehmatthes/pcc/pulls/64","id":208344961,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzQ0OTYx","html_url":"https://github.com/ehmatthes/pcc/pull/64","diff_url":"https://github.com/ehmatthes/pcc/pull/64.diff","patch_url":"https://github.com/ehmatthes/pcc/pull/64.patch","issue_url":"https://api.github.com/repos/ehmatthes/pcc/issues/64","number":64,"state":"open","locked":false,"title":"Fixed emoji display bug.","user":{"login":"mare-astrorum","id":42090865,"node_id":"MDQ6VXNlcjQyMDkwODY1","avatar_url":"https://avatars3.githubusercontent.com/u/42090865?v=4","gravatar_id":"","url":"https://api.github.com/users/mare-astrorum","html_url":"https://github.com/mare-astrorum","followers_url":"https://api.github.com/users/mare-astrorum/followers","following_url":"https://api.github.com/users/mare-astrorum/following{/other_user}","gists_url":"https://api.github.com/users/mare-astrorum/gists{/gist_id}","starred_url":"https://api.github.com/users/mare-astrorum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mare-astrorum/subscriptions","organizations_url":"https://api.github.com/users/mare-astrorum/orgs","repos_url":"https://api.github.com/users/mare-astrorum/repos","events_url":"https://api.github.com/users/mare-astrorum/events{/privacy}","received_events_url":"https://api.github.com/users/mare-astrorum/received_events","type":"User","site_admin":false},"body":"(This is my first ever pull request so I apologize if I'm doing something wrong.)\r\n\r\nI think I found a bug in the python-repos code in Chapter 17. I got an error message whenever there were emojis in the repo description (e.g. repo 'requests' have a number of them). So I added some code that fixes it.\r\n\r\n(Great book BTW!) ","created_at":"2018-08-14T16:47:02Z","updated_at":"2018-08-14T16:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef490ac39aff590debae8d18e9255ce35292c5a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ehmatthes/pcc/pulls/64/commits","review_comments_url":"https://api.github.com/repos/ehmatthes/pcc/pulls/64/comments","review_comment_url":"https://api.github.com/repos/ehmatthes/pcc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ehmatthes/pcc/issues/64/comments","statuses_url":"https://api.github.com/repos/ehmatthes/pcc/statuses/c848606cdd54fb0c51c682434e89e359253aeb2d","head":{"label":"mare-astrorum:emoji-display","ref":"emoji-display","sha":"c848606cdd54fb0c51c682434e89e359253aeb2d","user":{"login":"mare-astrorum","id":42090865,"node_id":"MDQ6VXNlcjQyMDkwODY1","avatar_url":"https://avatars3.githubusercontent.com/u/42090865?v=4","gravatar_id":"","url":"https://api.github.com/users/mare-astrorum","html_url":"https://github.com/mare-astrorum","followers_url":"https://api.github.com/users/mare-astrorum/followers","following_url":"https://api.github.com/users/mare-astrorum/following{/other_user}","gists_url":"https://api.github.com/users/mare-astrorum/gists{/gist_id}","starred_url":"https://api.github.com/users/mare-astrorum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mare-astrorum/subscriptions","organizations_url":"https://api.github.com/users/mare-astrorum/orgs","repos_url":"https://api.github.com/users/mare-astrorum/repos","events_url":"https://api.github.com/users/mare-astrorum/events{/privacy}","received_events_url":"https://api.github.com/users/mare-astrorum/received_events","type":"User","site_admin":false},"repo":{"id":144744061,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3NDQwNjE=","name":"pcc","full_name":"mare-astrorum/pcc","owner":{"login":"mare-astrorum","id":42090865,"node_id":"MDQ6VXNlcjQyMDkwODY1","avatar_url":"https://avatars3.githubusercontent.com/u/42090865?v=4","gravatar_id":"","url":"https://api.github.com/users/mare-astrorum","html_url":"https://github.com/mare-astrorum","followers_url":"https://api.github.com/users/mare-astrorum/followers","following_url":"https://api.github.com/users/mare-astrorum/following{/other_user}","gists_url":"https://api.github.com/users/mare-astrorum/gists{/gist_id}","starred_url":"https://api.github.com/users/mare-astrorum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mare-astrorum/subscriptions","organizations_url":"https://api.github.com/users/mare-astrorum/orgs","repos_url":"https://api.github.com/users/mare-astrorum/repos","events_url":"https://api.github.com/users/mare-astrorum/events{/privacy}","received_events_url":"https://api.github.com/users/mare-astrorum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mare-astrorum/pcc","description":"Resources for Python Crash Course, from No Starch Press.","fork":true,"url":"https://api.github.com/repos/mare-astrorum/pcc","forks_url":"https://api.github.com/repos/mare-astrorum/pcc/forks","keys_url":"https://api.github.com/repos/mare-astrorum/pcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mare-astrorum/pcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mare-astrorum/pcc/teams","hooks_url":"https://api.github.com/repos/mare-astrorum/pcc/hooks","issue_events_url":"https://api.github.com/repos/mare-astrorum/pcc/issues/events{/number}","events_url":"https://api.github.com/repos/mare-astrorum/pcc/events","assignees_url":"https://api.github.com/repos/mare-astrorum/pcc/assignees{/user}","branches_url":"https://api.github.com/repos/mare-astrorum/pcc/branches{/branch}","tags_url":"https://api.github.com/repos/mare-astrorum/pcc/tags","blobs_url":"https://api.github.com/repos/mare-astrorum/pcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mare-astrorum/pcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mare-astrorum/pcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/mare-astrorum/pcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mare-astrorum/pcc/statuses/{sha}","languages_url":"https://api.github.com/repos/mare-astrorum/pcc/languages","stargazers_url":"https://api.github.com/repos/mare-astrorum/pcc/stargazers","contributors_url":"https://api.github.com/repos/mare-astrorum/pcc/contributors","subscribers_url":"https://api.github.com/repos/mare-astrorum/pcc/subscribers","subscription_url":"https://api.github.com/repos/mare-astrorum/pcc/subscription","commits_url":"https://api.github.com/repos/mare-astrorum/pcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/mare-astrorum/pcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/mare-astrorum/pcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/mare-astrorum/pcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/mare-astrorum/pcc/contents/{+path}","compare_url":"https://api.github.com/repos/mare-astrorum/pcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mare-astrorum/pcc/merges","archive_url":"https://api.github.com/repos/mare-astrorum/pcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mare-astrorum/pcc/downloads","issues_url":"https://api.github.com/repos/mare-astrorum/pcc/issues{/number}","pulls_url":"https://api.github.com/repos/mare-astrorum/pcc/pulls{/number}","milestones_url":"https://api.github.com/repos/mare-astrorum/pcc/milestones{/number}","notifications_url":"https://api.github.com/repos/mare-astrorum/pcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mare-astrorum/pcc/labels{/name}","releases_url":"https://api.github.com/repos/mare-astrorum/pcc/releases{/id}","deployments_url":"https://api.github.com/repos/mare-astrorum/pcc/deployments","created_at":"2018-08-14T16:12:52Z","updated_at":"2018-08-14T16:12:54Z","pushed_at":"2018-08-14T16:41:39Z","git_url":"git://github.com/mare-astrorum/pcc.git","ssh_url":"git@github.com:mare-astrorum/pcc.git","clone_url":"https://github.com/mare-astrorum/pcc.git","svn_url":"https://github.com/mare-astrorum/pcc","homepage":null,"size":20676,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ehmatthes:master","ref":"master","sha":"f555082df0f8268b8f269e59a99da8ed5013f749","user":{"login":"ehmatthes","id":1886842,"node_id":"MDQ6VXNlcjE4ODY4NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1886842?v=4","gravatar_id":"","url":"https://api.github.com/users/ehmatthes","html_url":"https://github.com/ehmatthes","followers_url":"https://api.github.com/users/ehmatthes/followers","following_url":"https://api.github.com/users/ehmatthes/following{/other_user}","gists_url":"https://api.github.com/users/ehmatthes/gists{/gist_id}","starred_url":"https://api.github.com/users/ehmatthes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehmatthes/subscriptions","organizations_url":"https://api.github.com/users/ehmatthes/orgs","repos_url":"https://api.github.com/users/ehmatthes/repos","events_url":"https://api.github.com/users/ehmatthes/events{/privacy}","received_events_url":"https://api.github.com/users/ehmatthes/received_events","type":"User","site_admin":false},"repo":{"id":29447438,"node_id":"MDEwOlJlcG9zaXRvcnkyOTQ0NzQzOA==","name":"pcc","full_name":"ehmatthes/pcc","owner":{"login":"ehmatthes","id":1886842,"node_id":"MDQ6VXNlcjE4ODY4NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1886842?v=4","gravatar_id":"","url":"https://api.github.com/users/ehmatthes","html_url":"https://github.com/ehmatthes","followers_url":"https://api.github.com/users/ehmatthes/followers","following_url":"https://api.github.com/users/ehmatthes/following{/other_user}","gists_url":"https://api.github.com/users/ehmatthes/gists{/gist_id}","starred_url":"https://api.github.com/users/ehmatthes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehmatthes/subscriptions","organizations_url":"https://api.github.com/users/ehmatthes/orgs","repos_url":"https://api.github.com/users/ehmatthes/repos","events_url":"https://api.github.com/users/ehmatthes/events{/privacy}","received_events_url":"https://api.github.com/users/ehmatthes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehmatthes/pcc","description":"Resources for Python Crash Course, from No Starch Press.","fork":false,"url":"https://api.github.com/repos/ehmatthes/pcc","forks_url":"https://api.github.com/repos/ehmatthes/pcc/forks","keys_url":"https://api.github.com/repos/ehmatthes/pcc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehmatthes/pcc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehmatthes/pcc/teams","hooks_url":"https://api.github.com/repos/ehmatthes/pcc/hooks","issue_events_url":"https://api.github.com/repos/ehmatthes/pcc/issues/events{/number}","events_url":"https://api.github.com/repos/ehmatthes/pcc/events","assignees_url":"https://api.github.com/repos/ehmatthes/pcc/assignees{/user}","branches_url":"https://api.github.com/repos/ehmatthes/pcc/branches{/branch}","tags_url":"https://api.github.com/repos/ehmatthes/pcc/tags","blobs_url":"https://api.github.com/repos/ehmatthes/pcc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehmatthes/pcc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehmatthes/pcc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehmatthes/pcc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehmatthes/pcc/statuses/{sha}","languages_url":"https://api.github.com/repos/ehmatthes/pcc/languages","stargazers_url":"https://api.github.com/repos/ehmatthes/pcc/stargazers","contributors_url":"https://api.github.com/repos/ehmatthes/pcc/contributors","subscribers_url":"https://api.github.com/repos/ehmatthes/pcc/subscribers","subscription_url":"https://api.github.com/repos/ehmatthes/pcc/subscription","commits_url":"https://api.github.com/repos/ehmatthes/pcc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehmatthes/pcc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehmatthes/pcc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehmatthes/pcc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehmatthes/pcc/contents/{+path}","compare_url":"https://api.github.com/repos/ehmatthes/pcc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehmatthes/pcc/merges","archive_url":"https://api.github.com/repos/ehmatthes/pcc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehmatthes/pcc/downloads","issues_url":"https://api.github.com/repos/ehmatthes/pcc/issues{/number}","pulls_url":"https://api.github.com/repos/ehmatthes/pcc/pulls{/number}","milestones_url":"https://api.github.com/repos/ehmatthes/pcc/milestones{/number}","notifications_url":"https://api.github.com/repos/ehmatthes/pcc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehmatthes/pcc/labels{/name}","releases_url":"https://api.github.com/repos/ehmatthes/pcc/releases{/id}","deployments_url":"https://api.github.com/repos/ehmatthes/pcc/deployments","created_at":"2015-01-19T01:06:41Z","updated_at":"2018-08-14T09:24:52Z","pushed_at":"2018-08-14T16:47:03Z","git_url":"git://github.com/ehmatthes/pcc.git","ssh_url":"git@github.com:ehmatthes/pcc.git","clone_url":"https://github.com/ehmatthes/pcc.git","svn_url":"https://github.com/ehmatthes/pcc","homepage":null,"size":20676,"stargazers_count":843,"watchers_count":843,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":630,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":630,"open_issues":13,"watchers":843,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ehmatthes/pcc/pulls/64"},"html":{"href":"https://github.com/ehmatthes/pcc/pull/64"},"issue":{"href":"https://api.github.com/repos/ehmatthes/pcc/issues/64"},"comments":{"href":"https://api.github.com/repos/ehmatthes/pcc/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/ehmatthes/pcc/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/ehmatthes/pcc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ehmatthes/pcc/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/ehmatthes/pcc/statuses/c848606cdd54fb0c51c682434e89e359253aeb2d"}},"author_association":"NONE"}}
{"actor":{"display_login":"mare-astrorum"}}