{"action":"created","comment":{"url":"https://api.github.com/repos/S2E/libs2ecore/pulls/comments/188899416","pull_request_review_id":120968170,"id":188899416,"diff_hunk":"@@ -362,7 +362,7 @@ std::vector<ref<Expr>> S2EExecutionState::createConcolicArray(const std::string\n     return result;\n }\n \n-std::vector<ref<Expr>> S2EExecutionState::createSymbolicArray(const std::string &name, unsigned size,\n+std::vector<ref<Expr>> S2EExecutionState::createSymbolicArray(const std::string &name, uintptr_t address, unsigned size,","path":"src/S2EExecutionState.cpp","position":23,"original_position":23,"commit_id":"55e26e33cb15f40c485345faef550ae0ee92dd76","original_commit_id":"55e26e33cb15f40c485345faef550ae0ee92dd76","user":{"login":"vitalych","id":2332715,"avatar_url":"https://avatars2.githubusercontent.com/u/2332715?v=4","gravatar_id":"","url":"https://api.github.com/users/vitalych","html_url":"https://github.com/vitalych","followers_url":"https://api.github.com/users/vitalych/followers","following_url":"https://api.github.com/users/vitalych/following{/other_user}","gists_url":"https://api.github.com/users/vitalych/gists{/gist_id}","starred_url":"https://api.github.com/users/vitalych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitalych/subscriptions","organizations_url":"https://api.github.com/users/vitalych/orgs","repos_url":"https://api.github.com/users/vitalych/repos","events_url":"https://api.github.com/users/vitalych/events{/privacy}","received_events_url":"https://api.github.com/users/vitalych/received_events","type":"User","site_admin":false},"body":"I would also pass the type of address here, similar to mem()->read()/write() apis which take an enum (virtual/physical/host).","created_at":"2018-05-17T09:47:05Z","updated_at":"2018-05-17T09:47:05Z","html_url":"https://github.com/S2E/libs2ecore/pull/11#discussion_r188899416","pull_request_url":"https://api.github.com/repos/S2E/libs2ecore/pulls/11","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/S2E/libs2ecore/pulls/comments/188899416"},"html":{"href":"https://github.com/S2E/libs2ecore/pull/11#discussion_r188899416"},"pull_request":{"href":"https://api.github.com/repos/S2E/libs2ecore/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/S2E/libs2ecore/pulls/11","id":188646645,"html_url":"https://github.com/S2E/libs2ecore/pull/11","diff_url":"https://github.com/S2E/libs2ecore/pull/11.diff","patch_url":"https://github.com/S2E/libs2ecore/pull/11.patch","issue_url":"https://api.github.com/repos/S2E/libs2ecore/issues/11","number":11,"state":"open","locked":false,"title":"S2EExecutionState: set address in onSymbolicVariableCreation's MemoryObject","user":{"login":"adrianherrera","id":8626578,"avatar_url":"https://avatars2.githubusercontent.com/u/8626578?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianherrera","html_url":"https://github.com/adrianherrera","followers_url":"https://api.github.com/users/adrianherrera/followers","following_url":"https://api.github.com/users/adrianherrera/following{/other_user}","gists_url":"https://api.github.com/users/adrianherrera/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianherrera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianherrera/subscriptions","organizations_url":"https://api.github.com/users/adrianherrera/orgs","repos_url":"https://api.github.com/users/adrianherrera/repos","events_url":"https://api.github.com/users/adrianherrera/events{/privacy}","received_events_url":"https://api.github.com/users/adrianherrera/received_events","type":"User","site_admin":false},"body":"Currently the `MemoryObject` that is emitted with the `onSymbolicVariableCreation` signal has an address of `0`. Many times this address is known (e.g. in `BaseInstructions::makeSymbolic`) so we can set it to an appropriate value.","created_at":"2018-05-17T07:33:49Z","updated_at":"2018-05-17T09:47:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0ea72f5d71b06698782ed6085aad40f9c307671","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/S2E/libs2ecore/pulls/11/commits","review_comments_url":"https://api.github.com/repos/S2E/libs2ecore/pulls/11/comments","review_comment_url":"https://api.github.com/repos/S2E/libs2ecore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/S2E/libs2ecore/issues/11/comments","statuses_url":"https://api.github.com/repos/S2E/libs2ecore/statuses/55e26e33cb15f40c485345faef550ae0ee92dd76","head":{"label":"S2E:improvement/add-address-to-onsymbolicvariablecreation","ref":"improvement/add-address-to-onsymbolicvariablecreation","sha":"55e26e33cb15f40c485345faef550ae0ee92dd76","user":{"login":"S2E","id":7384376,"avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"repo":{"id":87203939,"name":"libs2ecore","full_name":"S2E/libs2ecore","owner":{"login":"S2E","id":7384376,"avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/S2E/libs2ecore","description":"S2E Core Engine Library","fork":false,"url":"https://api.github.com/repos/S2E/libs2ecore","forks_url":"https://api.github.com/repos/S2E/libs2ecore/forks","keys_url":"https://api.github.com/repos/S2E/libs2ecore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/S2E/libs2ecore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/S2E/libs2ecore/teams","hooks_url":"https://api.github.com/repos/S2E/libs2ecore/hooks","issue_events_url":"https://api.github.com/repos/S2E/libs2ecore/issues/events{/number}","events_url":"https://api.github.com/repos/S2E/libs2ecore/events","assignees_url":"https://api.github.com/repos/S2E/libs2ecore/assignees{/user}","branches_url":"https://api.github.com/repos/S2E/libs2ecore/branches{/branch}","tags_url":"https://api.github.com/repos/S2E/libs2ecore/tags","blobs_url":"https://api.github.com/repos/S2E/libs2ecore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/S2E/libs2ecore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/S2E/libs2ecore/git/refs{/sha}","trees_url":"https://api.github.com/repos/S2E/libs2ecore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/S2E/libs2ecore/statuses/{sha}","languages_url":"https://api.github.com/repos/S2E/libs2ecore/languages","stargazers_url":"https://api.github.com/repos/S2E/libs2ecore/stargazers","contributors_url":"https://api.github.com/repos/S2E/libs2ecore/contributors","subscribers_url":"https://api.github.com/repos/S2E/libs2ecore/subscribers","subscription_url":"https://api.github.com/repos/S2E/libs2ecore/subscription","commits_url":"https://api.github.com/repos/S2E/libs2ecore/commits{/sha}","git_commits_url":"https://api.github.com/repos/S2E/libs2ecore/git/commits{/sha}","comments_url":"https://api.github.com/repos/S2E/libs2ecore/comments{/number}","issue_comment_url":"https://api.github.com/repos/S2E/libs2ecore/issues/comments{/number}","contents_url":"https://api.github.com/repos/S2E/libs2ecore/contents/{+path}","compare_url":"https://api.github.com/repos/S2E/libs2ecore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/S2E/libs2ecore/merges","archive_url":"https://api.github.com/repos/S2E/libs2ecore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/S2E/libs2ecore/downloads","issues_url":"https://api.github.com/repos/S2E/libs2ecore/issues{/number}","pulls_url":"https://api.github.com/repos/S2E/libs2ecore/pulls{/number}","milestones_url":"https://api.github.com/repos/S2E/libs2ecore/milestones{/number}","notifications_url":"https://api.github.com/repos/S2E/libs2ecore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/S2E/libs2ecore/labels{/name}","releases_url":"https://api.github.com/repos/S2E/libs2ecore/releases{/id}","deployments_url":"https://api.github.com/repos/S2E/libs2ecore/deployments","created_at":"2017-04-04T15:31:54Z","updated_at":"2018-05-14T18:16:11Z","pushed_at":"2018-05-17T07:33:50Z","git_url":"git://github.com/S2E/libs2ecore.git","ssh_url":"git@github.com:S2E/libs2ecore.git","clone_url":"https://github.com/S2E/libs2ecore.git","svn_url":"https://github.com/S2E/libs2ecore","homepage":null,"size":206,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":1,"watchers":11,"default_branch":"master"}},"base":{"label":"S2E:master","ref":"master","sha":"265f6d22767087f512241f39f0d3b72e81e8fcfc","user":{"login":"S2E","id":7384376,"avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"repo":{"id":87203939,"name":"libs2ecore","full_name":"S2E/libs2ecore","owner":{"login":"S2E","id":7384376,"avatar_url":"https://avatars0.githubusercontent.com/u/7384376?v=4","gravatar_id":"","url":"https://api.github.com/users/S2E","html_url":"https://github.com/S2E","followers_url":"https://api.github.com/users/S2E/followers","following_url":"https://api.github.com/users/S2E/following{/other_user}","gists_url":"https://api.github.com/users/S2E/gists{/gist_id}","starred_url":"https://api.github.com/users/S2E/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/S2E/subscriptions","organizations_url":"https://api.github.com/users/S2E/orgs","repos_url":"https://api.github.com/users/S2E/repos","events_url":"https://api.github.com/users/S2E/events{/privacy}","received_events_url":"https://api.github.com/users/S2E/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/S2E/libs2ecore","description":"S2E Core Engine Library","fork":false,"url":"https://api.github.com/repos/S2E/libs2ecore","forks_url":"https://api.github.com/repos/S2E/libs2ecore/forks","keys_url":"https://api.github.com/repos/S2E/libs2ecore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/S2E/libs2ecore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/S2E/libs2ecore/teams","hooks_url":"https://api.github.com/repos/S2E/libs2ecore/hooks","issue_events_url":"https://api.github.com/repos/S2E/libs2ecore/issues/events{/number}","events_url":"https://api.github.com/repos/S2E/libs2ecore/events","assignees_url":"https://api.github.com/repos/S2E/libs2ecore/assignees{/user}","branches_url":"https://api.github.com/repos/S2E/libs2ecore/branches{/branch}","tags_url":"https://api.github.com/repos/S2E/libs2ecore/tags","blobs_url":"https://api.github.com/repos/S2E/libs2ecore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/S2E/libs2ecore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/S2E/libs2ecore/git/refs{/sha}","trees_url":"https://api.github.com/repos/S2E/libs2ecore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/S2E/libs2ecore/statuses/{sha}","languages_url":"https://api.github.com/repos/S2E/libs2ecore/languages","stargazers_url":"https://api.github.com/repos/S2E/libs2ecore/stargazers","contributors_url":"https://api.github.com/repos/S2E/libs2ecore/contributors","subscribers_url":"https://api.github.com/repos/S2E/libs2ecore/subscribers","subscription_url":"https://api.github.com/repos/S2E/libs2ecore/subscription","commits_url":"https://api.github.com/repos/S2E/libs2ecore/commits{/sha}","git_commits_url":"https://api.github.com/repos/S2E/libs2ecore/git/commits{/sha}","comments_url":"https://api.github.com/repos/S2E/libs2ecore/comments{/number}","issue_comment_url":"https://api.github.com/repos/S2E/libs2ecore/issues/comments{/number}","contents_url":"https://api.github.com/repos/S2E/libs2ecore/contents/{+path}","compare_url":"https://api.github.com/repos/S2E/libs2ecore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/S2E/libs2ecore/merges","archive_url":"https://api.github.com/repos/S2E/libs2ecore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/S2E/libs2ecore/downloads","issues_url":"https://api.github.com/repos/S2E/libs2ecore/issues{/number}","pulls_url":"https://api.github.com/repos/S2E/libs2ecore/pulls{/number}","milestones_url":"https://api.github.com/repos/S2E/libs2ecore/milestones{/number}","notifications_url":"https://api.github.com/repos/S2E/libs2ecore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/S2E/libs2ecore/labels{/name}","releases_url":"https://api.github.com/repos/S2E/libs2ecore/releases{/id}","deployments_url":"https://api.github.com/repos/S2E/libs2ecore/deployments","created_at":"2017-04-04T15:31:54Z","updated_at":"2018-05-14T18:16:11Z","pushed_at":"2018-05-17T07:33:50Z","git_url":"git://github.com/S2E/libs2ecore.git","ssh_url":"git@github.com:S2E/libs2ecore.git","clone_url":"https://github.com/S2E/libs2ecore.git","svn_url":"https://github.com/S2E/libs2ecore","homepage":null,"size":206,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3,"open_issues":1,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/S2E/libs2ecore/pulls/11"},"html":{"href":"https://github.com/S2E/libs2ecore/pull/11"},"issue":{"href":"https://api.github.com/repos/S2E/libs2ecore/issues/11"},"comments":{"href":"https://api.github.com/repos/S2E/libs2ecore/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/S2E/libs2ecore/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/S2E/libs2ecore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/S2E/libs2ecore/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/S2E/libs2ecore/statuses/55e26e33cb15f40c485345faef550ae0ee92dd76"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vitalych"}}