{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/512","repository_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui","labels_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/512/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/512/comments","events_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/512/events","html_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/512","id":333022380,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzUzNjA1","number":512,"title":"EZP-29275 As a QA I want to cover scenarios of testing fields editing in content management","user":{"login":"m-tyrala","id":23000531,"node_id":"MDQ6VXNlcjIzMDAwNTMx","avatar_url":"https://avatars3.githubusercontent.com/u/23000531?v=4","gravatar_id":"","url":"https://api.github.com/users/m-tyrala","html_url":"https://github.com/m-tyrala","followers_url":"https://api.github.com/users/m-tyrala/followers","following_url":"https://api.github.com/users/m-tyrala/following{/other_user}","gists_url":"https://api.github.com/users/m-tyrala/gists{/gist_id}","starred_url":"https://api.github.com/users/m-tyrala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-tyrala/subscriptions","organizations_url":"https://api.github.com/users/m-tyrala/orgs","repos_url":"https://api.github.com/users/m-tyrala/repos","events_url":"https://api.github.com/users/m-tyrala/events{/privacy}","received_events_url":"https://api.github.com/users/m-tyrala/received_events","type":"User","site_admin":false},"labels":[{"id":750166707,"node_id":"MDU6TGFiZWw3NTAxNjY3MDc=","url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/labels/ready%20for%20review","name":"ready for review","color":"F6A22E","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-16T23:29:07Z","updated_at":"2018-07-10T07:39:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/pulls/512","html_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/512","diff_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/512.diff","patch_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/512.patch"},"body":"| Question      | Answer\r\n| ------------- | ---\r\n| Tickets       | <!-- URLs to GitHub or JIRA issue(s) (or N/A) -->\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Tests pass?   | no\r\n| Doc needed?   | no\r\n| License       | [GPL-2.0](https://github.com/ezsystems/ezplatform-admin-ui/blob/master/LICENSE)\r\n\r\nAs a QA\r\nI want to cover with tests ez-fields (all usable except of media, binary and image) within the area of basic management of content edition\r\nTo increase the detection of errors in this area\r\n\r\n\r\n#### Checklist:\r\n- [ ] Coding standards (`$ composer fix-cs`)\r\n- [ ] Ready for Code Review\r\n"},"comment":{"url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/comments/403730322","html_url":"https://github.com/ezsystems/ezplatform-admin-ui/pull/512#issuecomment-403730322","issue_url":"https://api.github.com/repos/ezsystems/ezplatform-admin-ui/issues/512","id":403730322,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzczMDMyMg==","user":{"login":"ezrobot","id":681611,"node_id":"MDQ6VXNlcjY4MTYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/681611?v=4","gravatar_id":"","url":"https://api.github.com/users/ezrobot","html_url":"https://github.com/ezrobot","followers_url":"https://api.github.com/users/ezrobot/followers","following_url":"https://api.github.com/users/ezrobot/following{/other_user}","gists_url":"https://api.github.com/users/ezrobot/gists{/gist_id}","starred_url":"https://api.github.com/users/ezrobot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezrobot/subscriptions","organizations_url":"https://api.github.com/users/ezrobot/orgs","repos_url":"https://api.github.com/users/ezrobot/repos","events_url":"https://api.github.com/users/ezrobot/events{/privacy}","received_events_url":"https://api.github.com/users/ezrobot/received_events","type":"User","site_admin":false},"created_at":"2018-07-10T07:39:07Z","updated_at":"2018-07-10T07:39:07Z","author_association":"NONE","body":"Tool version : PHP CS Fixer 2.7.1 Sandy Pool by Fabien Potencier and Dariusz Ruminski\nCommand executed ```php-cs-fixer --dry-run -v fix ```\nThis Pull Request does not respect [PSR-2 Coding Standards](http://www.php-fig.org/psr/psr-2/), please, see the suggested diff below:\n\n```diff\ndiff --git a/src/lib/Behat/PageElement/Fields/DateAndTime.php b/src/lib/Behat/PageElement/Fields/DateAndTime.php\nindex 4933a53..6fdc667 100644\n--- a/src/lib/Behat/PageElement/Fields/DateAndTime.php\n+++ b/src/lib/Behat/PageElement/Fields/DateAndTime.php\n@@ -48,6 +48,7 @@ class DateAndTime extends EzFieldElement\n         $this->context->waitUntil($this->defaultTimeout, function () use ($expectedDateAndTimeValue) {\n             $actualDate = date_create($this->context->findElement(sprintf('%s %s', $this->fields['fieldContainer'], $this->fields['fieldInput']))->getValue());\n             printf('actual time value = [%s]', date_create($this->context->findElement(sprintf('%s %s', $this->fields['fieldContainer'], $this->fields['fieldInput']))->getValue())->format('Y-m-d H:i:s A'));\n+\n             return $actualDate == $expectedDateAndTimeValue;\n         });\n \ndiff --git a/src/lib/Behat/PageElement/Fields/Time.php b/src/lib/Behat/PageElement/Fields/Time.php\nindex e685d59..41594d8 100644\n--- a/src/lib/Behat/PageElement/Fields/Time.php\n+++ b/src/lib/Behat/PageElement/Fields/Time.php\n@@ -46,6 +46,7 @@ class Time extends EzFieldElement\n         $this->context->waitUntil($this->defaultTimeout, function () use ($expectedTimeValue) {\n             printf('actual time value = [%s]', date_create($this->context->findElement(sprintf('%s %s', $this->fields['fieldContainer'], $this->fields['fieldInput']))->getValue())->format('Y-m-d H:i:s A'));\n             $actualDate = date_create($this->context->findElement(sprintf('%s %s', $this->fields['fieldContainer'], $this->fields['fieldInput']))->getValue());\n+\n             return $actualDate == $expectedTimeValue;\n         });\n \n```\n"}}
{"actor":{"display_login":"ezrobot"}}