{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/216467369","pull_request_review_id":153956261,"id":216467369,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ2NzM2OQ==","diff_hunk":"@@ -0,0 +1,81 @@\n+\"use strict\";\n+\n+import RFB from '@novnc/novnc/core/rfb'\n+\n+let rfb;\n+\n+function sendCtrlAltDel() {\n+  rfb.sendCtrlAltDel();\n+  return false;\n+}\n+\n+function showStatus(state, message) {\n+  let level,\n+      status = $('#noVNC_status'),\n+      ctrlAltDeleteButton = $('#ctrlAltDelButton');\n+\n+  switch (state) {\n+    case 'failed':       level = 'danger';  break;\n+    case 'fatal':        level = 'danger';  break;\n+    case 'normal':       level = 'success'; break;\n+    case 'disconnected': level = 'default'; break;\n+    default:             level = 'warning'; break;\n+  }\n+\n+  ctrlAltDeleteButton.prop('disabled', state !== 'normal');\n+\n+  if (typeof(message) !== 'undefined') {","path":"webpack/assets/javascripts/bundle_novnc.js","position":27,"original_position":27,"commit_id":"4a0b0068939bad56d88d9fc8ead8049108940467","original_commit_id":"4a0b0068939bad56d88d9fc8ead8049108940467","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Unary word operator 'typeof' must be followed by whitespace     space-unary-ops","created_at":"2018-09-10T20:48:12Z","updated_at":"2018-09-10T20:48:13Z","html_url":"https://github.com/theforeman/foreman/pull/6056#discussion_r216467369","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/6056","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/216467369"},"html":{"href":"https://github.com/theforeman/foreman/pull/6056#discussion_r216467369"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/6056"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/6056","id":214437763,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDM3NzYz","html_url":"https://github.com/theforeman/foreman/pull/6056","diff_url":"https://github.com/theforeman/foreman/pull/6056.diff","patch_url":"https://github.com/theforeman/foreman/pull/6056.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/6056","number":6056,"state":"open","locked":false,"title":"Fixes #16294 - Remove noVNC from vendors","user":{"login":"UXabre","id":15357734,"node_id":"MDQ6VXNlcjE1MzU3NzM0","avatar_url":"https://avatars0.githubusercontent.com/u/15357734?v=4","gravatar_id":"","url":"https://api.github.com/users/UXabre","html_url":"https://github.com/UXabre","followers_url":"https://api.github.com/users/UXabre/followers","following_url":"https://api.github.com/users/UXabre/following{/other_user}","gists_url":"https://api.github.com/users/UXabre/gists{/gist_id}","starred_url":"https://api.github.com/users/UXabre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UXabre/subscriptions","organizations_url":"https://api.github.com/users/UXabre/orgs","repos_url":"https://api.github.com/users/UXabre/repos","events_url":"https://api.github.com/users/UXabre/events{/privacy}","received_events_url":"https://api.github.com/users/UXabre/received_events","type":"User","site_admin":false},"body":"Things to consider while reviewing:\r\n - By default, the background of an RFB instance is a fashionable shade of gray; however, when my other PR would be merged, this background will be automatically removed and thus look like discussed/approvded... however\r\n - There's a consideration to make (probably by the UX team): by default, the new RFB instance automatically clips to the containing borders, meaning a scrollbar is shown inside the canvas area, as soon as the remote desktop would bleed out. Currently, the scrollbar is \"placed\" on the content; which also moves the statusbar around. My preference goes the scrollbar inside the canvast, because it leaves the rest of the page untouched. In that case, I'd make a different class for VNC UI, which only removes the background and adds the backdrop shadow to the canvas instead. + there are scaling modes available as well, so, again, might be good to involve the UX team to consider the new possibilities?\r\n\r\nTested with oVirt as VNC provider, with two sources (VMs):\r\n - CentOS 7.5\r\n - Windows 2012R2\r\n\r\nSeems to be working fine on my end\r\n\r\n<!---\r\n\r\nThank you for contributing to The Foreman, please read the\r\n[following guide](https://www.theforeman.org/contribute.html), in short:\r\n\r\n* [Create an issue](https://projects.theforeman.org/projects/foreman/issues)\r\n* Reference the issue via `Fixes #1234` in the commit message\r\n* Prefer present-tense, imperative-style commit messages\r\n* Mark all strings for translation, see [Translating section in the guide]\r\n(https://projects.theforeman.org/projects/foreman/wiki/Translating)\r\n* Prepend `[WIP]` for work in progress to prevent bots from triggering actions\r\n* Be patient, we will do our best to take a look as soon as we can\r\n* Explain the purpose of the PR, attach screenshots if applicable\r\n* Be nice and respectful\r\n\r\nWe are running bots that will poke you if you miss an item from the list :-)\r\n\r\n--->\r\n","created_at":"2018-09-10T20:41:38Z","updated_at":"2018-09-10T20:48:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd4facd539943e139b903092d6820914fc5b157b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":79040689,"node_id":"MDU6TGFiZWw3OTA0MDY4OQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":79040085,"node_id":"MDU6TGFiZWw3OTA0MDA4NQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"0e8a16","default":false},{"id":778856900,"node_id":"MDU6TGFiZWw3Nzg4NTY5MDA=","url":"https://api.github.com/repos/theforeman/foreman/labels/UI","name":"UI","color":"f7f29b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/6056/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/6056/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/6056/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/4a0b0068939bad56d88d9fc8ead8049108940467","head":{"label":"UXabre:refactor/16294","ref":"refactor/16294","sha":"4a0b0068939bad56d88d9fc8ead8049108940467","user":{"login":"UXabre","id":15357734,"node_id":"MDQ6VXNlcjE1MzU3NzM0","avatar_url":"https://avatars0.githubusercontent.com/u/15357734?v=4","gravatar_id":"","url":"https://api.github.com/users/UXabre","html_url":"https://github.com/UXabre","followers_url":"https://api.github.com/users/UXabre/followers","following_url":"https://api.github.com/users/UXabre/following{/other_user}","gists_url":"https://api.github.com/users/UXabre/gists{/gist_id}","starred_url":"https://api.github.com/users/UXabre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UXabre/subscriptions","organizations_url":"https://api.github.com/users/UXabre/orgs","repos_url":"https://api.github.com/users/UXabre/repos","events_url":"https://api.github.com/users/UXabre/events{/privacy}","received_events_url":"https://api.github.com/users/UXabre/received_events","type":"User","site_admin":false},"repo":{"id":140207066,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyMDcwNjY=","name":"foreman","full_name":"UXabre/foreman","owner":{"login":"UXabre","id":15357734,"node_id":"MDQ6VXNlcjE1MzU3NzM0","avatar_url":"https://avatars0.githubusercontent.com/u/15357734?v=4","gravatar_id":"","url":"https://api.github.com/users/UXabre","html_url":"https://github.com/UXabre","followers_url":"https://api.github.com/users/UXabre/followers","following_url":"https://api.github.com/users/UXabre/following{/other_user}","gists_url":"https://api.github.com/users/UXabre/gists{/gist_id}","starred_url":"https://api.github.com/users/UXabre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UXabre/subscriptions","organizations_url":"https://api.github.com/users/UXabre/orgs","repos_url":"https://api.github.com/users/UXabre/repos","events_url":"https://api.github.com/users/UXabre/events{/privacy}","received_events_url":"https://api.github.com/users/UXabre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UXabre/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/UXabre/foreman","forks_url":"https://api.github.com/repos/UXabre/foreman/forks","keys_url":"https://api.github.com/repos/UXabre/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UXabre/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UXabre/foreman/teams","hooks_url":"https://api.github.com/repos/UXabre/foreman/hooks","issue_events_url":"https://api.github.com/repos/UXabre/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/UXabre/foreman/events","assignees_url":"https://api.github.com/repos/UXabre/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/UXabre/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/UXabre/foreman/tags","blobs_url":"https://api.github.com/repos/UXabre/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UXabre/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UXabre/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/UXabre/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UXabre/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/UXabre/foreman/languages","stargazers_url":"https://api.github.com/repos/UXabre/foreman/stargazers","contributors_url":"https://api.github.com/repos/UXabre/foreman/contributors","subscribers_url":"https://api.github.com/repos/UXabre/foreman/subscribers","subscription_url":"https://api.github.com/repos/UXabre/foreman/subscription","commits_url":"https://api.github.com/repos/UXabre/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/UXabre/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/UXabre/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/UXabre/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/UXabre/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/UXabre/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UXabre/foreman/merges","archive_url":"https://api.github.com/repos/UXabre/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UXabre/foreman/downloads","issues_url":"https://api.github.com/repos/UXabre/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/UXabre/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/UXabre/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/UXabre/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UXabre/foreman/labels{/name}","releases_url":"https://api.github.com/repos/UXabre/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/UXabre/foreman/deployments","created_at":"2018-07-08T22:31:15Z","updated_at":"2018-08-22T08:12:18Z","pushed_at":"2018-09-10T20:47:58Z","git_url":"git://github.com/UXabre/foreman.git","ssh_url":"git@github.com:UXabre/foreman.git","clone_url":"https://github.com/UXabre/foreman.git","svn_url":"https://github.com/UXabre/foreman","homepage":"http://theforeman.org","size":77995,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"b958ae5a68ef9d7afbd1607232d9f28f64dbd252","user":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"node_id":"MDEwOlJlcG9zaXRvcnkyNTg3NTA=","name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2018-09-09T21:51:43Z","pushed_at":"2018-09-10T20:48:00Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":80529,"stargazers_count":1498,"watchers_count":1498,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":756,"mirror_url":null,"archived":false,"open_issues_count":138,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":756,"open_issues":138,"watchers":1498,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/6056"},"html":{"href":"https://github.com/theforeman/foreman/pull/6056"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/6056"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/6056/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/6056/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/6056/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/4a0b0068939bad56d88d9fc8ead8049108940467"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"houndci-bot"}}