{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1086","repository_url":"https://api.github.com/repos/input-output-hk/daedalus","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1086/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1086/comments","events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1086/events","html_url":"https://github.com/input-output-hk/daedalus/pull/1086","id":357796953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNzI3OTAx","number":1086,"title":"[DDW-275] Improve NTP check handling","user":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"labels":[{"id":465480669,"node_id":"MDU6TGFiZWw0NjU0ODA2Njk=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/WIP","name":"WIP","color":"fbca04","default":false},{"id":455603673,"node_id":"MDU6TGFiZWw0NTU2MDM2NzM=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/feature","name":"feature","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},"assignees":[{"login":"daniloprates","id":1504716,"node_id":"MDQ6VXNlcjE1MDQ3MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1504716?v=4","gravatar_id":"","url":"https://api.github.com/users/daniloprates","html_url":"https://github.com/daniloprates","followers_url":"https://api.github.com/users/daniloprates/followers","following_url":"https://api.github.com/users/daniloprates/following{/other_user}","gists_url":"https://api.github.com/users/daniloprates/gists{/gist_id}","starred_url":"https://api.github.com/users/daniloprates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniloprates/subscriptions","organizations_url":"https://api.github.com/users/daniloprates/orgs","repos_url":"https://api.github.com/users/daniloprates/repos","events_url":"https://api.github.com/users/daniloprates/events{/privacy}","received_events_url":"https://api.github.com/users/daniloprates/received_events","type":"User","site_admin":false},{"login":"darko-mijic","id":4280521,"node_id":"MDQ6VXNlcjQyODA1MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4280521?v=4","gravatar_id":"","url":"https://api.github.com/users/darko-mijic","html_url":"https://github.com/darko-mijic","followers_url":"https://api.github.com/users/darko-mijic/followers","following_url":"https://api.github.com/users/darko-mijic/following{/other_user}","gists_url":"https://api.github.com/users/darko-mijic/gists{/gist_id}","starred_url":"https://api.github.com/users/darko-mijic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darko-mijic/subscriptions","organizations_url":"https://api.github.com/users/darko-mijic/orgs","repos_url":"https://api.github.com/users/darko-mijic/repos","events_url":"https://api.github.com/users/darko-mijic/events{/privacy}","received_events_url":"https://api.github.com/users/darko-mijic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-09-06T19:39:14Z","updated_at":"2018-09-07T11:32:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/1086","html_url":"https://github.com/input-output-hk/daedalus/pull/1086","diff_url":"https://github.com/input-output-hk/daedalus/pull/1086.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/1086.patch"},"body":"This PR improves NTP check handling, allowing the user to re-trigger this check without restarting Daedalus.\r\n\r\n## Todo:\r\n\r\n- [x] Implement the link to check the time again in the NTP error screen\r\n- [x] Implement the node info call with the `force-check` parameter\r\n- [ ] Provide translations - cc: @darko-mijic \r\n- [ ] Prevent click on time-check link while we are executing the request\r\n- [ ] During submission we should change the way \"Check time again\" link looks like -> let's change the text to \"Checking time...\", remove the underline style, prevent clicking and animate the 3 dots at the end in the same way we do on the \"Connecting to network...\" screen\r\n![dots](https://user-images.githubusercontent.com/376611/45214820-cdf72000-b29b-11e8-94c2-e45986fa9522.gif)\r\n\r\n\r\n## Screenshots:\r\n\r\n![image](https://user-images.githubusercontent.com/1504716/45180899-376f2400-b1f3-11e8-8c80-a5f80dfd57d2.png)\r\n\r\n---\r\n\r\n## Review Checklist:\r\n\r\n### Basics\r\n\r\n- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)\r\n- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance tests are passing (`yarn run test`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds)\r\n- [ ] There are no *flow* errors or warnings (`yarn run flow:test`)\r\n- [ ] There are no *lint* errors or warnings (`yarn run lint`)\r\n- [ ] Text changes are proofread and approved (Jane Wild)\r\n- [ ] There are no missing translations (running `yarn run manage:translations` produces no changes)\r\n- [ ] UI changes look good in all themes (Alexander Rukin)\r\n- [ ] Storybook works and no stories are broken (`yarn run storybook`)\r\n- [ ] In case of dependency changes `yarn.lock` file is updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly documented and commented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-rendering\r\n- [ ] Any code that only works in Electron is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature / change is covered by acceptance tests\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature / change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review:\r\n- [ ] Merge PR\r\n- [ ] Delete source branch\r\n- [ ] Move ticket to `done` on the Youtrack board\r\n"},"comment":{"url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments/419411947","html_url":"https://github.com/input-output-hk/daedalus/pull/1086#issuecomment-419411947","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/1086","id":419411947,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTQxMTk0Nw==","user":{"login":"nikolaglumac","id":376611,"node_id":"MDQ6VXNlcjM3NjYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/376611?v=4","gravatar_id":"","url":"https://api.github.com/users/nikolaglumac","html_url":"https://github.com/nikolaglumac","followers_url":"https://api.github.com/users/nikolaglumac/followers","following_url":"https://api.github.com/users/nikolaglumac/following{/other_user}","gists_url":"https://api.github.com/users/nikolaglumac/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolaglumac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolaglumac/subscriptions","organizations_url":"https://api.github.com/users/nikolaglumac/orgs","repos_url":"https://api.github.com/users/nikolaglumac/repos","events_url":"https://api.github.com/users/nikolaglumac/events{/privacy}","received_events_url":"https://api.github.com/users/nikolaglumac/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T11:32:25Z","updated_at":"2018-09-07T11:32:25Z","author_association":"CONTRIBUTOR","body":"@daniloprates I have refactored the request logic: https://github.com/input-output-hk/daedalus/pull/1086/commits/323421eb07afec6fc4d3f2981ebe2c172d8afb69\r\n...now you will be able to use `isExecuting` to change the button text and prevent 2nd click when we have a running request..."}}
{"actor":{"display_login":"nikolaglumac"}}