{"action":"created","comment":{"url":"https://api.github.com/repos/halide/Halide/pulls/comments/234822662","pull_request_review_id":176547624,"id":234822662,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDgyMjY2Mg==","diff_hunk":"@@ -1,11 +1,32 @@\n #include \"Error.h\"\n \n+#include <signal.h>\n+\n+#ifdef _WIN32\n+#include <windows.h>\n+#endif\n+\n namespace Halide {\n \n namespace {\n \n CompileTimeErrorReporter* custom_error_reporter = nullptr;\n \n+void error_abort() {\n+#if defined(_MSC_VER) && defined(_DEBUG)\n+    if (!IsDebuggerPresent()) {","path":"src/Error.cpp","position":17,"original_position":17,"commit_id":"1e5c6cf6714efd1e02e5a9e611238b6ed88c0798","original_commit_id":"1e5c6cf6714efd1e02e5a9e611238b6ed88c0798","user":{"login":"steven-johnson","id":328955,"node_id":"MDQ6VXNlcjMyODk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/328955?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-johnson","html_url":"https://github.com/steven-johnson","followers_url":"https://api.github.com/users/steven-johnson/followers","following_url":"https://api.github.com/users/steven-johnson/following{/other_user}","gists_url":"https://api.github.com/users/steven-johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-johnson/subscriptions","organizations_url":"https://api.github.com/users/steven-johnson/orgs","repos_url":"https://api.github.com/users/steven-johnson/repos","events_url":"https://api.github.com/users/steven-johnson/events{/privacy}","received_events_url":"https://api.github.com/users/steven-johnson/received_events","type":"User","site_admin":false},"body":"Sigh. Yeap. You're right.","created_at":"2018-11-19T23:38:15Z","updated_at":"2018-11-19T23:38:15Z","html_url":"https://github.com/halide/Halide/pull/3446#discussion_r234822662","pull_request_url":"https://api.github.com/repos/halide/Halide/pulls/3446","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments/234822662"},"html":{"href":"https://github.com/halide/Halide/pull/3446#discussion_r234822662"},"pull_request":{"href":"https://api.github.com/repos/halide/Halide/pulls/3446"}},"in_reply_to_id":234821930},"pull_request":{"url":"https://api.github.com/repos/halide/Halide/pulls/3446","id":232140012,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTQwMDEy","html_url":"https://github.com/halide/Halide/pull/3446","diff_url":"https://github.com/halide/Halide/pull/3446.diff","patch_url":"https://github.com/halide/Halide/pull/3446.patch","issue_url":"https://api.github.com/repos/halide/Halide/issues/3446","number":3446,"state":"open","locked":false,"title":"Add runtime wrapper for abort()","user":{"login":"steven-johnson","id":328955,"node_id":"MDQ6VXNlcjMyODk1NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/328955?v=4","gravatar_id":"","url":"https://api.github.com/users/steven-johnson","html_url":"https://github.com/steven-johnson","followers_url":"https://api.github.com/users/steven-johnson/followers","following_url":"https://api.github.com/users/steven-johnson/following{/other_user}","gists_url":"https://api.github.com/users/steven-johnson/gists{/gist_id}","starred_url":"https://api.github.com/users/steven-johnson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steven-johnson/subscriptions","organizations_url":"https://api.github.com/users/steven-johnson/orgs","repos_url":"https://api.github.com/users/steven-johnson/repos","events_url":"https://api.github.com/users/steven-johnson/events{/privacy}","received_events_url":"https://api.github.com/users/steven-johnson/received_events","type":"User","site_admin":false},"body":"Windows Debug runtimes stall the `abort()` call by presenting a modal dialog. Add a runtime overload for windows that does the equivalent raise/exit combination as documented by MSFT instead and use it instead of raw abort(). Ditto for the compile-time Error.cpp in the compiler. (Note: this makes no attempt to convert apps or tests that explicitly call abort; this is just for the Halide compiler and runtime itself.)","created_at":"2018-11-19T23:02:01Z","updated_at":"2018-11-19T23:38:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02b84e08b2e38455d6e01091b5be01a586ddd27a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"abadams","id":515398,"node_id":"MDQ6VXNlcjUxNTM5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/515398?v=4","gravatar_id":"","url":"https://api.github.com/users/abadams","html_url":"https://github.com/abadams","followers_url":"https://api.github.com/users/abadams/followers","following_url":"https://api.github.com/users/abadams/following{/other_user}","gists_url":"https://api.github.com/users/abadams/gists{/gist_id}","starred_url":"https://api.github.com/users/abadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abadams/subscriptions","organizations_url":"https://api.github.com/users/abadams/orgs","repos_url":"https://api.github.com/users/abadams/repos","events_url":"https://api.github.com/users/abadams/events{/privacy}","received_events_url":"https://api.github.com/users/abadams/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/halide/Halide/pulls/3446/commits","review_comments_url":"https://api.github.com/repos/halide/Halide/pulls/3446/comments","review_comment_url":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}","comments_url":"https://api.github.com/repos/halide/Halide/issues/3446/comments","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/1e5c6cf6714efd1e02e5a9e611238b6ed88c0798","head":{"label":"halide:srj-abort","ref":"srj-abort","sha":"1e5c6cf6714efd1e02e5a9e611238b6ed88c0798","user":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQxMzEy","name":"Halide","full_name":"halide/Halide","private":false,"owner":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/halide/Halide","description":"a language for fast, portable data-parallel computation","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2018-11-19T05:31:33Z","pushed_at":"2018-11-19T23:32:42Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":254577,"stargazers_count":2622,"watchers_count":2622,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":547,"mirror_url":null,"archived":false,"open_issues_count":518,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":547,"open_issues":518,"watchers":2622,"default_branch":"master"}},"base":{"label":"halide:master","ref":"master","sha":"d61cfe3532d253bfc9e4dc583fc83f6c93ca8405","user":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"repo":{"id":5241312,"node_id":"MDEwOlJlcG9zaXRvcnk1MjQxMzEy","name":"Halide","full_name":"halide/Halide","private":false,"owner":{"login":"halide","id":1548551,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NDg1NTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1548551?v=4","gravatar_id":"","url":"https://api.github.com/users/halide","html_url":"https://github.com/halide","followers_url":"https://api.github.com/users/halide/followers","following_url":"https://api.github.com/users/halide/following{/other_user}","gists_url":"https://api.github.com/users/halide/gists{/gist_id}","starred_url":"https://api.github.com/users/halide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halide/subscriptions","organizations_url":"https://api.github.com/users/halide/orgs","repos_url":"https://api.github.com/users/halide/repos","events_url":"https://api.github.com/users/halide/events{/privacy}","received_events_url":"https://api.github.com/users/halide/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/halide/Halide","description":"a language for fast, portable data-parallel computation","fork":false,"url":"https://api.github.com/repos/halide/Halide","forks_url":"https://api.github.com/repos/halide/Halide/forks","keys_url":"https://api.github.com/repos/halide/Halide/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halide/Halide/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halide/Halide/teams","hooks_url":"https://api.github.com/repos/halide/Halide/hooks","issue_events_url":"https://api.github.com/repos/halide/Halide/issues/events{/number}","events_url":"https://api.github.com/repos/halide/Halide/events","assignees_url":"https://api.github.com/repos/halide/Halide/assignees{/user}","branches_url":"https://api.github.com/repos/halide/Halide/branches{/branch}","tags_url":"https://api.github.com/repos/halide/Halide/tags","blobs_url":"https://api.github.com/repos/halide/Halide/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halide/Halide/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halide/Halide/git/refs{/sha}","trees_url":"https://api.github.com/repos/halide/Halide/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halide/Halide/statuses/{sha}","languages_url":"https://api.github.com/repos/halide/Halide/languages","stargazers_url":"https://api.github.com/repos/halide/Halide/stargazers","contributors_url":"https://api.github.com/repos/halide/Halide/contributors","subscribers_url":"https://api.github.com/repos/halide/Halide/subscribers","subscription_url":"https://api.github.com/repos/halide/Halide/subscription","commits_url":"https://api.github.com/repos/halide/Halide/commits{/sha}","git_commits_url":"https://api.github.com/repos/halide/Halide/git/commits{/sha}","comments_url":"https://api.github.com/repos/halide/Halide/comments{/number}","issue_comment_url":"https://api.github.com/repos/halide/Halide/issues/comments{/number}","contents_url":"https://api.github.com/repos/halide/Halide/contents/{+path}","compare_url":"https://api.github.com/repos/halide/Halide/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halide/Halide/merges","archive_url":"https://api.github.com/repos/halide/Halide/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halide/Halide/downloads","issues_url":"https://api.github.com/repos/halide/Halide/issues{/number}","pulls_url":"https://api.github.com/repos/halide/Halide/pulls{/number}","milestones_url":"https://api.github.com/repos/halide/Halide/milestones{/number}","notifications_url":"https://api.github.com/repos/halide/Halide/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halide/Halide/labels{/name}","releases_url":"https://api.github.com/repos/halide/Halide/releases{/id}","deployments_url":"https://api.github.com/repos/halide/Halide/deployments","created_at":"2012-07-31T04:05:25Z","updated_at":"2018-11-19T05:31:33Z","pushed_at":"2018-11-19T23:32:42Z","git_url":"git://github.com/halide/Halide.git","ssh_url":"git@github.com:halide/Halide.git","clone_url":"https://github.com/halide/Halide.git","svn_url":"https://github.com/halide/Halide","homepage":"http://halide-lang.org","size":254577,"stargazers_count":2622,"watchers_count":2622,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":547,"mirror_url":null,"archived":false,"open_issues_count":518,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":547,"open_issues":518,"watchers":2622,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/halide/Halide/pulls/3446"},"html":{"href":"https://github.com/halide/Halide/pull/3446"},"issue":{"href":"https://api.github.com/repos/halide/Halide/issues/3446"},"comments":{"href":"https://api.github.com/repos/halide/Halide/issues/3446/comments"},"review_comments":{"href":"https://api.github.com/repos/halide/Halide/pulls/3446/comments"},"review_comment":{"href":"https://api.github.com/repos/halide/Halide/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/halide/Halide/pulls/3446/commits"},"statuses":{"href":"https://api.github.com/repos/halide/Halide/statuses/1e5c6cf6714efd1e02e5a9e611238b6ed88c0798"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"steven-johnson"}}