{"action":"created","issue":{"url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/193","repository_url":"https://api.github.com/repos/ashtuchkin/iconv-lite","labels_url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/193/comments","events_url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/193/events","html_url":"https://github.com/ashtuchkin/iconv-lite/issues/193","id":332824842,"node_id":"MDU6SXNzdWUzMzI4MjQ4NDI=","number":193,"title":"Breaking change released as patch version 0.4.20","user":{"login":"cif","id":389657,"node_id":"MDQ6VXNlcjM4OTY1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/389657?v=4","gravatar_id":"","url":"https://api.github.com/users/cif","html_url":"https://github.com/cif","followers_url":"https://api.github.com/users/cif/followers","following_url":"https://api.github.com/users/cif/following{/other_user}","gists_url":"https://api.github.com/users/cif/gists{/gist_id}","starred_url":"https://api.github.com/users/cif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cif/subscriptions","organizations_url":"https://api.github.com/users/cif/orgs","repos_url":"https://api.github.com/users/cif/repos","events_url":"https://api.github.com/users/cif/events{/privacy}","received_events_url":"https://api.github.com/users/cif/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-06-15T15:44:47Z","updated_at":"2018-06-15T17:56:23Z","closed_at":null,"author_association":"NONE","body":"This is a breaking change released as a patch version: \r\nhttps://github.com/ashtuchkin/iconv-lite/blob/master/Changelog.md#0420--2018-04-06\r\n\r\nUnfortunately, since iconv-lite was a third party depencency, this change took out our lambdas for half a day. The solution (not the easiest to find or deploy) was to pin this module to the version before it in our top level package.json\r\n\r\nI realize this lib is still is not at version 1 and exempt from semver but... I need to say something because we, as a community of NodeJS developers absolutely get the most heat from the broader developer community for releasing breaking changes in minor versions with an unfortunate ^ syntax defaulted into our package manager : ) \r\n\r\nAt this time, iconv-lite has 6.6 million downloads per day, perhaps it's time to make version 1 now that it has that kind of reach?\r\n\r\nThank you for your consideration!"},"comment":{"url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/comments/397697528","html_url":"https://github.com/ashtuchkin/iconv-lite/issues/193#issuecomment-397697528","issue_url":"https://api.github.com/repos/ashtuchkin/iconv-lite/issues/193","id":397697528,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NzY5NzUyOA==","user":{"login":"ashtuchkin","id":627997,"node_id":"MDQ6VXNlcjYyNzk5Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/627997?v=4","gravatar_id":"","url":"https://api.github.com/users/ashtuchkin","html_url":"https://github.com/ashtuchkin","followers_url":"https://api.github.com/users/ashtuchkin/followers","following_url":"https://api.github.com/users/ashtuchkin/following{/other_user}","gists_url":"https://api.github.com/users/ashtuchkin/gists{/gist_id}","starred_url":"https://api.github.com/users/ashtuchkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashtuchkin/subscriptions","organizations_url":"https://api.github.com/users/ashtuchkin/orgs","repos_url":"https://api.github.com/users/ashtuchkin/repos","events_url":"https://api.github.com/users/ashtuchkin/events{/privacy}","received_events_url":"https://api.github.com/users/ashtuchkin/received_events","type":"User","site_admin":false},"created_at":"2018-06-15T17:56:23Z","updated_at":"2018-06-15T17:56:23Z","author_association":"OWNER","body":"Thanks for the feedback, Ben!\n\nI do agree with you in general, but I don't see how in this particular case\nit would've helped.. it wasn't an API change, the problem was in adding a\ndependency that didn't work in some environments. I might be missing\nsomething, but I'd classify this change as patch-level change in semver\ntoo. Am I wrong about this?\n\nAlex\n\nOn Fri, Jun 15, 2018, 09:13 Ben Ipsen <notifications@github.com> wrote:\n\n> Looks like someone else suggested this as well #132\n> <https://github.com/ashtuchkin/iconv-lite/issues/132>\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/ashtuchkin/iconv-lite/issues/193#issuecomment-397670000>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AAmVHd4VXgtbvsKMzh0OfBoS21GBcrCBks5t891DgaJpZM4UpxlT>\n> .\n>\n"}}
{"actor":{"display_login":"ashtuchkin"}}