{"action":"created","comment":{"url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/comments/237511480","pull_request_review_id":179826337,"id":237511480,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzUxMTQ4MA==","diff_hunk":"@@ -176,7 +176,7 @@ static int pppd_run(struct tunnel *tunnel)\n \t\t\t\tofv_append_varr(&pppd_args, v[i]);\n \t\t}\n \n-\t\tif (tunnel->config->pppd_use_peerdns)\n+\t\tif (tunnel->config->set_dns && tunnel->config->pppd_use_peerdns)","path":"src/tunnel.c","position":23,"original_position":23,"commit_id":"7e3773104b5d6dc32269b89c2efb2bb94a0e3f17","original_commit_id":"7e3773104b5d6dc32269b89c2efb2bb94a0e3f17","user":{"login":"mrbaseman","id":11367971,"node_id":"MDQ6VXNlcjExMzY3OTcx","avatar_url":"https://avatars0.githubusercontent.com/u/11367971?v=4","gravatar_id":"","url":"https://api.github.com/users/mrbaseman","html_url":"https://github.com/mrbaseman","followers_url":"https://api.github.com/users/mrbaseman/followers","following_url":"https://api.github.com/users/mrbaseman/following{/other_user}","gists_url":"https://api.github.com/users/mrbaseman/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbaseman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbaseman/subscriptions","organizations_url":"https://api.github.com/users/mrbaseman/orgs","repos_url":"https://api.github.com/users/mrbaseman/repos","events_url":"https://api.github.com/users/mrbaseman/events{/privacy}","received_events_url":"https://api.github.com/users/mrbaseman/received_events","type":"User","site_admin":false},"body":"maybe we should just change this to `if (tunnel->config->set_dns)` to address #349","created_at":"2018-11-29T14:38:42Z","updated_at":"2018-11-29T14:38:42Z","html_url":"https://github.com/adrienverge/openfortivpn/pull/330#discussion_r237511480","pull_request_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/330","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/comments/237511480"},"html":{"href":"https://github.com/adrienverge/openfortivpn/pull/330#discussion_r237511480"},"pull_request":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/330"}}},"pull_request":{"url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/330","id":193774115,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNzc0MTE1","html_url":"https://github.com/adrienverge/openfortivpn/pull/330","diff_url":"https://github.com/adrienverge/openfortivpn/pull/330.diff","patch_url":"https://github.com/adrienverge/openfortivpn/pull/330.patch","issue_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues/330","number":330,"state":"closed","locked":false,"title":"Rationalize DNS options","user":{"login":"DimitriPapadopoulos","id":3234522,"node_id":"MDQ6VXNlcjMyMzQ1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3234522?v=4","gravatar_id":"","url":"https://api.github.com/users/DimitriPapadopoulos","html_url":"https://github.com/DimitriPapadopoulos","followers_url":"https://api.github.com/users/DimitriPapadopoulos/followers","following_url":"https://api.github.com/users/DimitriPapadopoulos/following{/other_user}","gists_url":"https://api.github.com/users/DimitriPapadopoulos/gists{/gist_id}","starred_url":"https://api.github.com/users/DimitriPapadopoulos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimitriPapadopoulos/subscriptions","organizations_url":"https://api.github.com/users/DimitriPapadopoulos/orgs","repos_url":"https://api.github.com/users/DimitriPapadopoulos/repos","events_url":"https://api.github.com/users/DimitriPapadopoulos/events{/privacy}","received_events_url":"https://api.github.com/users/DimitriPapadopoulos/received_events","type":"User","site_admin":false},"body":"* The `--set-dns`/`set-dns` option enables either of _pppd_/_openfortivpn_ to get DNS settings from peer _ppp_/FortiGate server and rewrite `/etc/resolv.conf`.\r\n* The `--pppd-no-peerdns`/`pppd-use-peerdns` option switches the above functionality from _pppd_ to _openfortivpn_. This option is not documented any more.\r\n\r\nThe difference with the previous behaviour is that:\r\n* `--set-dns=0`/`set-dns=0` disables DNS handling in both _pppd_ and _openfortivpn_ instead of _openfortivpn_ only. A single option is now sufficient to avoid messing with `/etc/resolv.conf`.\r\n* `--pppd-no-peerdns`/`pppd-use-peerdns=0` switches DNS handling from _pppd_ to _openfortivpn_. It didn't make sense to have both programs compete to modify `/etc/resolv.conf`, did it? Feels much better this way.\r\n\r\nFixes #328.\r\n\r\nThis is also a first step towards entirely getting rid of one of the DNS options as suggested in #230, #101 and #326. Future steps might include:\r\n* Remove code that handles DNS changes and modifies `/etc/resolv.conf` directly in _openfortivpn_.\r\n* Instead always delegate DNS handling to _pppd_.\r\n* Remove `--pppd-no-peerdns`/`pppd-use-peerdns` options.","created_at":"2018-06-09T11:58:33Z","updated_at":"2018-11-29T14:38:42Z","closed_at":"2018-07-04T13:33:19Z","merged_at":"2018-07-04T13:33:19Z","merge_commit_sha":"f3830844090d9107112fb83dd93089da4961add1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adrienverge","id":5244945,"node_id":"MDQ6VXNlcjUyNDQ5NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5244945?v=4","gravatar_id":"","url":"https://api.github.com/users/adrienverge","html_url":"https://github.com/adrienverge","followers_url":"https://api.github.com/users/adrienverge/followers","following_url":"https://api.github.com/users/adrienverge/following{/other_user}","gists_url":"https://api.github.com/users/adrienverge/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienverge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienverge/subscriptions","organizations_url":"https://api.github.com/users/adrienverge/orgs","repos_url":"https://api.github.com/users/adrienverge/repos","events_url":"https://api.github.com/users/adrienverge/events{/privacy}","received_events_url":"https://api.github.com/users/adrienverge/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/330/commits","review_comments_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/330/comments","review_comment_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues/330/comments","statuses_url":"https://api.github.com/repos/adrienverge/openfortivpn/statuses/7e3773104b5d6dc32269b89c2efb2bb94a0e3f17","head":{"label":"DimitriPapadopoulos:dns","ref":"dns","sha":"7e3773104b5d6dc32269b89c2efb2bb94a0e3f17","user":{"login":"DimitriPapadopoulos","id":3234522,"node_id":"MDQ6VXNlcjMyMzQ1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3234522?v=4","gravatar_id":"","url":"https://api.github.com/users/DimitriPapadopoulos","html_url":"https://github.com/DimitriPapadopoulos","followers_url":"https://api.github.com/users/DimitriPapadopoulos/followers","following_url":"https://api.github.com/users/DimitriPapadopoulos/following{/other_user}","gists_url":"https://api.github.com/users/DimitriPapadopoulos/gists{/gist_id}","starred_url":"https://api.github.com/users/DimitriPapadopoulos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimitriPapadopoulos/subscriptions","organizations_url":"https://api.github.com/users/DimitriPapadopoulos/orgs","repos_url":"https://api.github.com/users/DimitriPapadopoulos/repos","events_url":"https://api.github.com/users/DimitriPapadopoulos/events{/privacy}","received_events_url":"https://api.github.com/users/DimitriPapadopoulos/received_events","type":"User","site_admin":false},"repo":{"id":105985235,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU5ODUyMzU=","name":"openfortivpn","full_name":"DimitriPapadopoulos/openfortivpn","private":false,"owner":{"login":"DimitriPapadopoulos","id":3234522,"node_id":"MDQ6VXNlcjMyMzQ1MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3234522?v=4","gravatar_id":"","url":"https://api.github.com/users/DimitriPapadopoulos","html_url":"https://github.com/DimitriPapadopoulos","followers_url":"https://api.github.com/users/DimitriPapadopoulos/followers","following_url":"https://api.github.com/users/DimitriPapadopoulos/following{/other_user}","gists_url":"https://api.github.com/users/DimitriPapadopoulos/gists{/gist_id}","starred_url":"https://api.github.com/users/DimitriPapadopoulos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DimitriPapadopoulos/subscriptions","organizations_url":"https://api.github.com/users/DimitriPapadopoulos/orgs","repos_url":"https://api.github.com/users/DimitriPapadopoulos/repos","events_url":"https://api.github.com/users/DimitriPapadopoulos/events{/privacy}","received_events_url":"https://api.github.com/users/DimitriPapadopoulos/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DimitriPapadopoulos/openfortivpn","description":"Client for PPP+SSL VPN tunnel services","fork":true,"url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn","forks_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/forks","keys_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/teams","hooks_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/hooks","issue_events_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/issues/events{/number}","events_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/events","assignees_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/assignees{/user}","branches_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/branches{/branch}","tags_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/tags","blobs_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/git/refs{/sha}","trees_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/statuses/{sha}","languages_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/languages","stargazers_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/stargazers","contributors_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/contributors","subscribers_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/subscribers","subscription_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/subscription","commits_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/commits{/sha}","git_commits_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/git/commits{/sha}","comments_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/comments{/number}","issue_comment_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/issues/comments{/number}","contents_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/contents/{+path}","compare_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/merges","archive_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/downloads","issues_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/issues{/number}","pulls_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/pulls{/number}","milestones_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/milestones{/number}","notifications_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/labels{/name}","releases_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/releases{/id}","deployments_url":"https://api.github.com/repos/DimitriPapadopoulos/openfortivpn/deployments","created_at":"2017-10-06T08:58:50Z","updated_at":"2018-11-22T08:22:02Z","pushed_at":"2018-11-22T08:28:59Z","git_url":"git://github.com/DimitriPapadopoulos/openfortivpn.git","ssh_url":"git@github.com:DimitriPapadopoulos/openfortivpn.git","clone_url":"https://github.com/DimitriPapadopoulos/openfortivpn.git","svn_url":"https://github.com/DimitriPapadopoulos/openfortivpn","homepage":"","size":538,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"adrienverge:master","ref":"master","sha":"97347d5689f45dfefed36af507a06d25b52a60ae","user":{"login":"adrienverge","id":5244945,"node_id":"MDQ6VXNlcjUyNDQ5NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5244945?v=4","gravatar_id":"","url":"https://api.github.com/users/adrienverge","html_url":"https://github.com/adrienverge","followers_url":"https://api.github.com/users/adrienverge/followers","following_url":"https://api.github.com/users/adrienverge/following{/other_user}","gists_url":"https://api.github.com/users/adrienverge/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienverge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienverge/subscriptions","organizations_url":"https://api.github.com/users/adrienverge/orgs","repos_url":"https://api.github.com/users/adrienverge/repos","events_url":"https://api.github.com/users/adrienverge/events{/privacy}","received_events_url":"https://api.github.com/users/adrienverge/received_events","type":"User","site_admin":false},"repo":{"id":29872502,"node_id":"MDEwOlJlcG9zaXRvcnkyOTg3MjUwMg==","name":"openfortivpn","full_name":"adrienverge/openfortivpn","private":false,"owner":{"login":"adrienverge","id":5244945,"node_id":"MDQ6VXNlcjUyNDQ5NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/5244945?v=4","gravatar_id":"","url":"https://api.github.com/users/adrienverge","html_url":"https://github.com/adrienverge","followers_url":"https://api.github.com/users/adrienverge/followers","following_url":"https://api.github.com/users/adrienverge/following{/other_user}","gists_url":"https://api.github.com/users/adrienverge/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienverge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienverge/subscriptions","organizations_url":"https://api.github.com/users/adrienverge/orgs","repos_url":"https://api.github.com/users/adrienverge/repos","events_url":"https://api.github.com/users/adrienverge/events{/privacy}","received_events_url":"https://api.github.com/users/adrienverge/received_events","type":"User","site_admin":false},"html_url":"https://github.com/adrienverge/openfortivpn","description":"Client for PPP+SSL VPN tunnel services","fork":false,"url":"https://api.github.com/repos/adrienverge/openfortivpn","forks_url":"https://api.github.com/repos/adrienverge/openfortivpn/forks","keys_url":"https://api.github.com/repos/adrienverge/openfortivpn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrienverge/openfortivpn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrienverge/openfortivpn/teams","hooks_url":"https://api.github.com/repos/adrienverge/openfortivpn/hooks","issue_events_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues/events{/number}","events_url":"https://api.github.com/repos/adrienverge/openfortivpn/events","assignees_url":"https://api.github.com/repos/adrienverge/openfortivpn/assignees{/user}","branches_url":"https://api.github.com/repos/adrienverge/openfortivpn/branches{/branch}","tags_url":"https://api.github.com/repos/adrienverge/openfortivpn/tags","blobs_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrienverge/openfortivpn/statuses/{sha}","languages_url":"https://api.github.com/repos/adrienverge/openfortivpn/languages","stargazers_url":"https://api.github.com/repos/adrienverge/openfortivpn/stargazers","contributors_url":"https://api.github.com/repos/adrienverge/openfortivpn/contributors","subscribers_url":"https://api.github.com/repos/adrienverge/openfortivpn/subscribers","subscription_url":"https://api.github.com/repos/adrienverge/openfortivpn/subscription","commits_url":"https://api.github.com/repos/adrienverge/openfortivpn/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrienverge/openfortivpn/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrienverge/openfortivpn/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrienverge/openfortivpn/contents/{+path}","compare_url":"https://api.github.com/repos/adrienverge/openfortivpn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrienverge/openfortivpn/merges","archive_url":"https://api.github.com/repos/adrienverge/openfortivpn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrienverge/openfortivpn/downloads","issues_url":"https://api.github.com/repos/adrienverge/openfortivpn/issues{/number}","pulls_url":"https://api.github.com/repos/adrienverge/openfortivpn/pulls{/number}","milestones_url":"https://api.github.com/repos/adrienverge/openfortivpn/milestones{/number}","notifications_url":"https://api.github.com/repos/adrienverge/openfortivpn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrienverge/openfortivpn/labels{/name}","releases_url":"https://api.github.com/repos/adrienverge/openfortivpn/releases{/id}","deployments_url":"https://api.github.com/repos/adrienverge/openfortivpn/deployments","created_at":"2015-01-26T17:25:00Z","updated_at":"2018-11-29T13:44:49Z","pushed_at":"2018-11-28T22:22:05Z","git_url":"git://github.com/adrienverge/openfortivpn.git","ssh_url":"git@github.com:adrienverge/openfortivpn.git","clone_url":"https://github.com/adrienverge/openfortivpn.git","svn_url":"https://github.com/adrienverge/openfortivpn","homepage":"","size":540,"stargazers_count":445,"watchers_count":445,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":101,"open_issues":29,"watchers":445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/330"},"html":{"href":"https://github.com/adrienverge/openfortivpn/pull/330"},"issue":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/issues/330"},"comments":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/issues/330/comments"},"review_comments":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/330/comments"},"review_comment":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/pulls/330/commits"},"statuses":{"href":"https://api.github.com/repos/adrienverge/openfortivpn/statuses/7e3773104b5d6dc32269b89c2efb2bb94a0e3f17"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mrbaseman"}}