{"action":"created","comment":{"url":"https://api.github.com/repos/apache/libcloud/pulls/comments/227331905","pull_request_review_id":167346380,"id":227331905,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzMzMTkwNQ==","diff_hunk":"@@ -2196,20 +2218,27 @@ def _to_volume(self, api_node):\n \n         return StorageVolume(\n             id=api_node['id'],\n-            name=api_node['displayName'],\n+            name=api_node.get('name', api_node.get('displayName', None)),\n             size=api_node['size'],\n             state=state,\n             driver=self,\n             extra={\n-                'description': api_node['displayDescription'],\n+                'description': api_node.get('description',\n+                                            api_node.get('displayDescription',\n+                                                         None)),","path":"libcloud/compute/drivers/openstack.py","position":103,"original_position":103,"commit_id":"7e1ccd5e6eeb8dac3060bc4fb10e45ed781738ed","original_commit_id":"7e1ccd5e6eeb8dac3060bc4fb10e45ed781738ed","user":{"login":"micafer","id":4972699,"node_id":"MDQ6VXNlcjQ5NzI2OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4972699?v=4","gravatar_id":"","url":"https://api.github.com/users/micafer","html_url":"https://github.com/micafer","followers_url":"https://api.github.com/users/micafer/followers","following_url":"https://api.github.com/users/micafer/following{/other_user}","gists_url":"https://api.github.com/users/micafer/gists{/gist_id}","starred_url":"https://api.github.com/users/micafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micafer/subscriptions","organizations_url":"https://api.github.com/users/micafer/orgs","repos_url":"https://api.github.com/users/micafer/repos","events_url":"https://api.github.com/users/micafer/events{/privacy}","received_events_url":"https://api.github.com/users/micafer/received_events","type":"User","site_admin":false},"body":"I will remove it.","created_at":"2018-10-23T10:42:23Z","updated_at":"2018-10-23T10:42:23Z","html_url":"https://github.com/apache/libcloud/pull/1242#discussion_r227331905","pull_request_url":"https://api.github.com/repos/apache/libcloud/pulls/1242","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/libcloud/pulls/comments/227331905"},"html":{"href":"https://github.com/apache/libcloud/pull/1242#discussion_r227331905"},"pull_request":{"href":"https://api.github.com/repos/apache/libcloud/pulls/1242"}},"in_reply_to_id":227274448},"pull_request":{"url":"https://api.github.com/repos/apache/libcloud/pulls/1242","id":218206692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MjA2Njky","html_url":"https://github.com/apache/libcloud/pull/1242","diff_url":"https://github.com/apache/libcloud/pull/1242.diff","patch_url":"https://github.com/apache/libcloud/pull/1242.patch","issue_url":"https://api.github.com/repos/apache/libcloud/issues/1242","number":1242,"state":"open","locked":false,"title":"Implement new versions of OpenStack API calls [LIBCLOUD-874]","user":{"login":"micafer","id":4972699,"node_id":"MDQ6VXNlcjQ5NzI2OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4972699?v=4","gravatar_id":"","url":"https://api.github.com/users/micafer","html_url":"https://github.com/micafer","followers_url":"https://api.github.com/users/micafer/followers","following_url":"https://api.github.com/users/micafer/following{/other_user}","gists_url":"https://api.github.com/users/micafer/gists{/gist_id}","starred_url":"https://api.github.com/users/micafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micafer/subscriptions","organizations_url":"https://api.github.com/users/micafer/orgs","repos_url":"https://api.github.com/users/micafer/repos","events_url":"https://api.github.com/users/micafer/events{/privacy}","received_events_url":"https://api.github.com/users/micafer/received_events","type":"User","site_admin":false},"body":"## Implement new versions of OpenStack API calls [LIBCLOUD-874]\r\n\r\n### Description\r\n\r\nThis PR overwrite the usage of the deprecated nova API methods:\r\n- /os-volumes\r\n- /os-snapshots\r\n- /os-security-groups\r\n- /os-security-group-rules\r\n- /os-floating-ips\r\n- /os-floating-ip-pools\r\n\r\nReplacing them with corresponding calls to neutron and cinder.\r\n\r\nAlso other minor fixes has been made as fixing the function parse_error to avoid error if \"code\" is not in the response message or fixing _to_port function to make it work with old OpenStack versions where some fields as: port_security_enabled or project_id are not returned by the API.\r\n\r\n### Status\r\n\r\n- done, ready for review\r\n\r\n### Checklist (tick everything that applies)\r\n\r\n- [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)\r\n- [x] Documentation\r\n- [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)\r\n- [ ] [ICLA](http://libcloud.readthedocs.org/en/latest/development.html#contributing-bigger-changes) (required for bigger changes)\r\n","created_at":"2018-09-26T06:53:51Z","updated_at":"2018-10-23T10:42:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed1d48248ab2e55e98bd470c75091be8b1c82dbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/libcloud/pulls/1242/commits","review_comments_url":"https://api.github.com/repos/apache/libcloud/pulls/1242/comments","review_comment_url":"https://api.github.com/repos/apache/libcloud/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/libcloud/issues/1242/comments","statuses_url":"https://api.github.com/repos/apache/libcloud/statuses/7e1ccd5e6eeb8dac3060bc4fb10e45ed781738ed","head":{"label":"micafer:sec_groups","ref":"sec_groups","sha":"7e1ccd5e6eeb8dac3060bc4fb10e45ed781738ed","user":{"login":"micafer","id":4972699,"node_id":"MDQ6VXNlcjQ5NzI2OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4972699?v=4","gravatar_id":"","url":"https://api.github.com/users/micafer","html_url":"https://github.com/micafer","followers_url":"https://api.github.com/users/micafer/followers","following_url":"https://api.github.com/users/micafer/following{/other_user}","gists_url":"https://api.github.com/users/micafer/gists{/gist_id}","starred_url":"https://api.github.com/users/micafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micafer/subscriptions","organizations_url":"https://api.github.com/users/micafer/orgs","repos_url":"https://api.github.com/users/micafer/repos","events_url":"https://api.github.com/users/micafer/events{/privacy}","received_events_url":"https://api.github.com/users/micafer/received_events","type":"User","site_admin":false},"repo":{"id":47826497,"node_id":"MDEwOlJlcG9zaXRvcnk0NzgyNjQ5Nw==","name":"libcloud","full_name":"micafer/libcloud","private":false,"owner":{"login":"micafer","id":4972699,"node_id":"MDQ6VXNlcjQ5NzI2OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/4972699?v=4","gravatar_id":"","url":"https://api.github.com/users/micafer","html_url":"https://github.com/micafer","followers_url":"https://api.github.com/users/micafer/followers","following_url":"https://api.github.com/users/micafer/following{/other_user}","gists_url":"https://api.github.com/users/micafer/gists{/gist_id}","starred_url":"https://api.github.com/users/micafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micafer/subscriptions","organizations_url":"https://api.github.com/users/micafer/orgs","repos_url":"https://api.github.com/users/micafer/repos","events_url":"https://api.github.com/users/micafer/events{/privacy}","received_events_url":"https://api.github.com/users/micafer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/micafer/libcloud","description":"Apache Libcloud is a Python library which hides differences between different cloud provider APIs and allows you to manage different cloud resources through a unified and easy to use API","fork":true,"url":"https://api.github.com/repos/micafer/libcloud","forks_url":"https://api.github.com/repos/micafer/libcloud/forks","keys_url":"https://api.github.com/repos/micafer/libcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/micafer/libcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/micafer/libcloud/teams","hooks_url":"https://api.github.com/repos/micafer/libcloud/hooks","issue_events_url":"https://api.github.com/repos/micafer/libcloud/issues/events{/number}","events_url":"https://api.github.com/repos/micafer/libcloud/events","assignees_url":"https://api.github.com/repos/micafer/libcloud/assignees{/user}","branches_url":"https://api.github.com/repos/micafer/libcloud/branches{/branch}","tags_url":"https://api.github.com/repos/micafer/libcloud/tags","blobs_url":"https://api.github.com/repos/micafer/libcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/micafer/libcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/micafer/libcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/micafer/libcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/micafer/libcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/micafer/libcloud/languages","stargazers_url":"https://api.github.com/repos/micafer/libcloud/stargazers","contributors_url":"https://api.github.com/repos/micafer/libcloud/contributors","subscribers_url":"https://api.github.com/repos/micafer/libcloud/subscribers","subscription_url":"https://api.github.com/repos/micafer/libcloud/subscription","commits_url":"https://api.github.com/repos/micafer/libcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/micafer/libcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/micafer/libcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/micafer/libcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/micafer/libcloud/contents/{+path}","compare_url":"https://api.github.com/repos/micafer/libcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/micafer/libcloud/merges","archive_url":"https://api.github.com/repos/micafer/libcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/micafer/libcloud/downloads","issues_url":"https://api.github.com/repos/micafer/libcloud/issues{/number}","pulls_url":"https://api.github.com/repos/micafer/libcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/micafer/libcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/micafer/libcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/micafer/libcloud/labels{/name}","releases_url":"https://api.github.com/repos/micafer/libcloud/releases{/id}","deployments_url":"https://api.github.com/repos/micafer/libcloud/deployments","created_at":"2015-12-11T12:51:21Z","updated_at":"2018-09-24T15:16:31Z","pushed_at":"2018-09-28T06:44:56Z","git_url":"git://github.com/micafer/libcloud.git","ssh_url":"git@github.com:micafer/libcloud.git","clone_url":"https://github.com/micafer/libcloud.git","svn_url":"https://github.com/micafer/libcloud","homepage":"http://libcloud.apache.org","size":19001,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"f54cd847d1d22e948311dff257bc8b4b1001e818","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":419555,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk1NTU=","name":"libcloud","full_name":"apache/libcloud","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/libcloud","description":"Apache Libcloud is a Python library which hides differences between different cloud provider APIs and allows you to manage different cloud resources through a unified and easy to use API","fork":false,"url":"https://api.github.com/repos/apache/libcloud","forks_url":"https://api.github.com/repos/apache/libcloud/forks","keys_url":"https://api.github.com/repos/apache/libcloud/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/libcloud/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/libcloud/teams","hooks_url":"https://api.github.com/repos/apache/libcloud/hooks","issue_events_url":"https://api.github.com/repos/apache/libcloud/issues/events{/number}","events_url":"https://api.github.com/repos/apache/libcloud/events","assignees_url":"https://api.github.com/repos/apache/libcloud/assignees{/user}","branches_url":"https://api.github.com/repos/apache/libcloud/branches{/branch}","tags_url":"https://api.github.com/repos/apache/libcloud/tags","blobs_url":"https://api.github.com/repos/apache/libcloud/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/libcloud/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/libcloud/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/libcloud/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/libcloud/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/libcloud/languages","stargazers_url":"https://api.github.com/repos/apache/libcloud/stargazers","contributors_url":"https://api.github.com/repos/apache/libcloud/contributors","subscribers_url":"https://api.github.com/repos/apache/libcloud/subscribers","subscription_url":"https://api.github.com/repos/apache/libcloud/subscription","commits_url":"https://api.github.com/repos/apache/libcloud/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/libcloud/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/libcloud/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/libcloud/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/libcloud/contents/{+path}","compare_url":"https://api.github.com/repos/apache/libcloud/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/libcloud/merges","archive_url":"https://api.github.com/repos/apache/libcloud/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/libcloud/downloads","issues_url":"https://api.github.com/repos/apache/libcloud/issues{/number}","pulls_url":"https://api.github.com/repos/apache/libcloud/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/libcloud/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/libcloud/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/libcloud/labels{/name}","releases_url":"https://api.github.com/repos/apache/libcloud/releases{/id}","deployments_url":"https://api.github.com/repos/apache/libcloud/deployments","created_at":"2009-12-11T09:00:14Z","updated_at":"2018-10-22T17:45:42Z","pushed_at":"2018-10-22T17:43:29Z","git_url":"git://github.com/apache/libcloud.git","ssh_url":"git@github.com:apache/libcloud.git","clone_url":"https://github.com/apache/libcloud.git","svn_url":"https://github.com/apache/libcloud","homepage":"http://libcloud.apache.org","size":18993,"stargazers_count":1380,"watchers_count":1380,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":789,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":789,"open_issues":48,"watchers":1380,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/libcloud/pulls/1242"},"html":{"href":"https://github.com/apache/libcloud/pull/1242"},"issue":{"href":"https://api.github.com/repos/apache/libcloud/issues/1242"},"comments":{"href":"https://api.github.com/repos/apache/libcloud/issues/1242/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/libcloud/pulls/1242/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/libcloud/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/libcloud/pulls/1242/commits"},"statuses":{"href":"https://api.github.com/repos/apache/libcloud/statuses/7e1ccd5e6eeb8dac3060bc4fb10e45ed781738ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"micafer"}}