{"action":"created","comment":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/244559885","pull_request_review_id":188467362,"id":244559885,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU1OTg4NQ==","diff_hunk":"@@ -665,7 +665,7 @@ fn can_send_and_receive() {\n     assert!(result.is_ok(), \"result = {:?}\", result);\n     let agent_id = result.unwrap().to_string();\n \n-    let (mut hc2, _) = start_holochain_instance(\"can_remove_modified_entry\", \"bob\");\n+    let (mut hc2, _) = start_holochain_instance(\"can_send_and_receive\", \"bob\");","path":"hdk-rust/tests/integration_test.rs","position":5,"original_position":5,"commit_id":"7b57b55021b3c23e357e90d5b735a288c4c8b397","original_commit_id":"7b57b55021b3c23e357e90d5b735a288c4c8b397","user":{"login":"maackle","id":896230,"node_id":"MDQ6VXNlcjg5NjIzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/896230?v=4","gravatar_id":"","url":"https://api.github.com/users/maackle","html_url":"https://github.com/maackle","followers_url":"https://api.github.com/users/maackle/followers","following_url":"https://api.github.com/users/maackle/following{/other_user}","gists_url":"https://api.github.com/users/maackle/gists{/gist_id}","starred_url":"https://api.github.com/users/maackle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maackle/subscriptions","organizations_url":"https://api.github.com/users/maackle/orgs","repos_url":"https://api.github.com/users/maackle/repos","events_url":"https://api.github.com/users/maackle/events{/privacy}","received_events_url":"https://api.github.com/users/maackle/received_events","type":"User","site_admin":false},"body":"Wasn't sure about this one, seemed like the test shouldn't even pass without this change, can someone explain if it was actually supposed to be the other way?","created_at":"2018-12-31T07:35:53Z","updated_at":"2018-12-31T07:35:53Z","html_url":"https://github.com/holochain/holochain-rust/pull/803#discussion_r244559885","pull_request_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/803","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/244559885"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/803#discussion_r244559885"},"pull_request":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/803"}}},"pull_request":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/803","id":241406810,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDA2ODEw","html_url":"https://github.com/holochain/holochain-rust/pull/803","diff_url":"https://github.com/holochain/holochain-rust/pull/803.diff","patch_url":"https://github.com/holochain/holochain-rust/pull/803.patch","issue_url":"https://api.github.com/repos/holochain/holochain-rust/issues/803","number":803,"state":"open","locked":false,"title":"WIP: Proper shutdown of network and instances when stopping Container","user":{"login":"maackle","id":896230,"node_id":"MDQ6VXNlcjg5NjIzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/896230?v=4","gravatar_id":"","url":"https://api.github.com/users/maackle","html_url":"https://github.com/maackle","followers_url":"https://api.github.com/users/maackle/followers","following_url":"https://api.github.com/users/maackle/following{/other_user}","gists_url":"https://api.github.com/users/maackle/gists{/gist_id}","starred_url":"https://api.github.com/users/maackle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maackle/subscriptions","organizations_url":"https://api.github.com/users/maackle/orgs","repos_url":"https://api.github.com/users/maackle/repos","events_url":"https://api.github.com/users/maackle/events{/privacy}","received_events_url":"https://api.github.com/users/maackle/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-28T22:51:56Z","updated_at":"2018-12-31T07:35:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b3aa528201b53ee2d9e5d9066cb69cb4309003c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zippy","id":3563,"node_id":"MDQ6VXNlcjM1NjM=","avatar_url":"https://avatars0.githubusercontent.com/u/3563?v=4","gravatar_id":"","url":"https://api.github.com/users/zippy","html_url":"https://github.com/zippy","followers_url":"https://api.github.com/users/zippy/followers","following_url":"https://api.github.com/users/zippy/following{/other_user}","gists_url":"https://api.github.com/users/zippy/gists{/gist_id}","starred_url":"https://api.github.com/users/zippy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zippy/subscriptions","organizations_url":"https://api.github.com/users/zippy/orgs","repos_url":"https://api.github.com/users/zippy/repos","events_url":"https://api.github.com/users/zippy/events{/privacy}","received_events_url":"https://api.github.com/users/zippy/received_events","type":"User","site_admin":false},{"login":"lucksus","id":311749,"node_id":"MDQ6VXNlcjMxMTc0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311749?v=4","gravatar_id":"","url":"https://api.github.com/users/lucksus","html_url":"https://github.com/lucksus","followers_url":"https://api.github.com/users/lucksus/followers","following_url":"https://api.github.com/users/lucksus/following{/other_user}","gists_url":"https://api.github.com/users/lucksus/gists{/gist_id}","starred_url":"https://api.github.com/users/lucksus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucksus/subscriptions","organizations_url":"https://api.github.com/users/lucksus/orgs","repos_url":"https://api.github.com/users/lucksus/repos","events_url":"https://api.github.com/users/lucksus/events{/privacy}","received_events_url":"https://api.github.com/users/lucksus/received_events","type":"User","site_admin":false},{"login":"thedavidmeister","id":629710,"node_id":"MDQ6VXNlcjYyOTcxMA==","avatar_url":"https://avatars2.githubusercontent.com/u/629710?v=4","gravatar_id":"","url":"https://api.github.com/users/thedavidmeister","html_url":"https://github.com/thedavidmeister","followers_url":"https://api.github.com/users/thedavidmeister/followers","following_url":"https://api.github.com/users/thedavidmeister/following{/other_user}","gists_url":"https://api.github.com/users/thedavidmeister/gists{/gist_id}","starred_url":"https://api.github.com/users/thedavidmeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thedavidmeister/subscriptions","organizations_url":"https://api.github.com/users/thedavidmeister/orgs","repos_url":"https://api.github.com/users/thedavidmeister/repos","events_url":"https://api.github.com/users/thedavidmeister/events{/privacy}","received_events_url":"https://api.github.com/users/thedavidmeister/received_events","type":"User","site_admin":false},{"login":"neonphog","id":796339,"node_id":"MDQ6VXNlcjc5NjMzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/796339?v=4","gravatar_id":"","url":"https://api.github.com/users/neonphog","html_url":"https://github.com/neonphog","followers_url":"https://api.github.com/users/neonphog/followers","following_url":"https://api.github.com/users/neonphog/following{/other_user}","gists_url":"https://api.github.com/users/neonphog/gists{/gist_id}","starred_url":"https://api.github.com/users/neonphog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neonphog/subscriptions","organizations_url":"https://api.github.com/users/neonphog/orgs","repos_url":"https://api.github.com/users/neonphog/repos","events_url":"https://api.github.com/users/neonphog/events{/privacy}","received_events_url":"https://api.github.com/users/neonphog/received_events","type":"User","site_admin":false},{"login":"Connoropolous","id":1409121,"node_id":"MDQ6VXNlcjE0MDkxMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1409121?v=4","gravatar_id":"","url":"https://api.github.com/users/Connoropolous","html_url":"https://github.com/Connoropolous","followers_url":"https://api.github.com/users/Connoropolous/followers","following_url":"https://api.github.com/users/Connoropolous/following{/other_user}","gists_url":"https://api.github.com/users/Connoropolous/gists{/gist_id}","starred_url":"https://api.github.com/users/Connoropolous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connoropolous/subscriptions","organizations_url":"https://api.github.com/users/Connoropolous/orgs","repos_url":"https://api.github.com/users/Connoropolous/repos","events_url":"https://api.github.com/users/Connoropolous/events{/privacy}","received_events_url":"https://api.github.com/users/Connoropolous/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":937673517,"node_id":"MDU6TGFiZWw5Mzc2NzM1MTc=","url":"https://api.github.com/repos/holochain/holochain-rust/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/803/commits","review_comments_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/803/comments","review_comment_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/issues/803/comments","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/7b57b55021b3c23e357e90d5b735a288c4c8b397","head":{"label":"holochain:shutdown-action","ref":"shutdown-action","sha":"7b57b55021b3c23e357e90d5b735a288c4c8b397","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"The core Holochain framework written in Rust, a container API for that, and hdk-rust library for Zomes","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2018-12-30T14:40:23Z","pushed_at":"2018-12-31T07:24:08Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":"","size":170809,"stargazers_count":277,"watchers_count":277,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":63,"open_issues":218,"watchers":277,"default_branch":"develop"}},"base":{"label":"holochain:develop","ref":"develop","sha":"595ca17f6637b85acd8502445b4eb87de9b4de6a","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"The core Holochain framework written in Rust, a container API for that, and hdk-rust library for Zomes","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2018-12-30T14:40:23Z","pushed_at":"2018-12-31T07:24:08Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":"","size":170809,"stargazers_count":277,"watchers_count":277,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":218,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":63,"open_issues":218,"watchers":277,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/803"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/803"},"issue":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/803"},"comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/803/comments"},"review_comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/803/comments"},"review_comment":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/803/commits"},"statuses":{"href":"https://api.github.com/repos/holochain/holochain-rust/statuses/7b57b55021b3c23e357e90d5b735a288c4c8b397"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"maackle"}}