{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12359","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12359/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12359/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12359/events","html_url":"https://github.com/civicrm/civicrm-core/pull/12359","id":335111754,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTA4OTY3","number":12359,"title":"dev/core#153: Pending Pay Later /w Custom payment method","user":{"login":"monishdeb","id":3735621,"node_id":"MDQ6VXNlcjM3MzU2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3735621?v=4","gravatar_id":"","url":"https://api.github.com/users/monishdeb","html_url":"https://github.com/monishdeb","followers_url":"https://api.github.com/users/monishdeb/followers","following_url":"https://api.github.com/users/monishdeb/following{/other_user}","gists_url":"https://api.github.com/users/monishdeb/gists{/gist_id}","starred_url":"https://api.github.com/users/monishdeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monishdeb/subscriptions","organizations_url":"https://api.github.com/users/monishdeb/orgs","repos_url":"https://api.github.com/users/monishdeb/repos","events_url":"https://api.github.com/users/monishdeb/events{/privacy}","received_events_url":"https://api.github.com/users/monishdeb/received_events","type":"User","site_admin":false},"labels":[{"id":858629627,"node_id":"MDU6TGFiZWw4NTg2Mjk2Mjc=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/has-test","name":"has-test","color":"f4a6ea","default":false},{"id":246037889,"node_id":"MDU6TGFiZWwyNDYwMzc4ODk=","url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-06-23T16:06:55Z","updated_at":"2018-06-24T22:38:07Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/12359","html_url":"https://github.com/civicrm/civicrm-core/pull/12359","diff_url":"https://github.com/civicrm/civicrm-core/pull/12359.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/12359.patch"},"body":"Overview\r\n----------------------------------------\r\nSteps to replicate the issue:\r\n1. Create a payment instrument 'Undetermined' linked to 'Account Receivable'\r\n2. Do a pending backoffice Event registration.\r\n3. Then on Contribution tab, complete the payment using 'Record Payment' form.\r\n\r\nCheck the Before/After screencast to find the current and expected behaviour.\r\n\r\nBefore\r\n----------------------------------------\r\n![test-multiple-before](https://user-images.githubusercontent.com/3735621/41811365-eff8422a-772b-11e8-8e4f-3b50cb319a7b.gif)\r\n\r\nAfter\r\n----------------------------------------\r\n![test-multiple-after](https://user-images.githubusercontent.com/3735621/41811337-656024a2-772b-11e8-9889-767382bfa1af.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/399793626","html_url":"https://github.com/civicrm/civicrm-core/pull/12359#issuecomment-399793626","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/12359","id":399793626,"node_id":"MDEyOklzc3VlQ29tbWVudDM5OTc5MzYyNg==","user":{"login":"pradpnayak","id":2053075,"node_id":"MDQ6VXNlcjIwNTMwNzU=","avatar_url":"https://avatars2.githubusercontent.com/u/2053075?v=4","gravatar_id":"","url":"https://api.github.com/users/pradpnayak","html_url":"https://github.com/pradpnayak","followers_url":"https://api.github.com/users/pradpnayak/followers","following_url":"https://api.github.com/users/pradpnayak/following{/other_user}","gists_url":"https://api.github.com/users/pradpnayak/gists{/gist_id}","starred_url":"https://api.github.com/users/pradpnayak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pradpnayak/subscriptions","organizations_url":"https://api.github.com/users/pradpnayak/orgs","repos_url":"https://api.github.com/users/pradpnayak/repos","events_url":"https://api.github.com/users/pradpnayak/events{/privacy}","received_events_url":"https://api.github.com/users/pradpnayak/received_events","type":"User","site_admin":false},"created_at":"2018-06-24T22:38:07Z","updated_at":"2018-06-24T22:38:07Z","author_association":"CONTRIBUTOR","body":"Agreed, You will need to add validation at form level for Record payment. \r\n\r\n> You are right, it points to AR account of FT as derived here. Now the issue is what about the existing PM which is linked to AR, although we can stop such incorrect PM to be created by omitting the AR option from the financial account element, but to avoid invalid transaction to get created we need the 2 validation checks mentioned in first point.\r\n\r\nFor existing PM we can have warning message under Admin status console for all invalid FA i.e AR a/c assigned to PM. Removing AR option from drop down is an good idea as per user prospective as it won't make sense if you show option and then don't allow to save the form when selected. I am worried about people trying to using API to create/update PM(don't remember if it does allow).\r\n\r\n"}}
{"actor":{"display_login":"pradpnayak"}}