{"action":"closed","number":716,"pull_request":{"url":"https://api.github.com/repos/theupdateframework/tuf/pulls/716","id":184704564,"html_url":"https://github.com/theupdateframework/tuf/pull/716","diff_url":"https://github.com/theupdateframework/tuf/pull/716.diff","patch_url":"https://github.com/theupdateframework/tuf/pull/716.patch","issue_url":"https://api.github.com/repos/theupdateframework/tuf/issues/716","number":716,"state":"closed","locked":false,"title":"Replace `os.stat(...).st_ino` calls made in unit test","user":{"login":"vladimir-v-diaz","id":3520883,"avatar_url":"https://avatars2.githubusercontent.com/u/3520883?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-v-diaz","html_url":"https://github.com/vladimir-v-diaz","followers_url":"https://api.github.com/users/vladimir-v-diaz/followers","following_url":"https://api.github.com/users/vladimir-v-diaz/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-v-diaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-v-diaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-v-diaz/subscriptions","organizations_url":"https://api.github.com/users/vladimir-v-diaz/orgs","repos_url":"https://api.github.com/users/vladimir-v-diaz/repos","events_url":"https://api.github.com/users/vladimir-v-diaz/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-v-diaz/received_events","type":"User","site_admin":false},"body":"**Fixes issue #**:\r\n\r\nAddress #690.\r\n\r\n**Description of the changes being introduced by the pull request**:\r\n\r\nThis pull request replaces the `os.stat(...).st_ino` calls in `test_repository_lib.py` with an alternative approach that works across all supported environments.  `os.stat(...).st_ino` yields junk values in FAT, NTFS, etc. file systems.  The alternative introduced by this pull request is to verify the actual content of the written files.\r\n\r\n**Please verify and check that the pull request fulfills the following\r\nrequirements**:\r\n\r\n- [ ] The code follows the [Code Style Guidelines](https://github.com/secure-systems-lab/code-style-guidelines#code-style-guidelines)\r\n- [ ] Tests have been added for the bug fix or new feature\r\n- [ ] Docs have been added for the bug fix or new feature\r\n\r\nSigned-off-by: Vladimir Diaz \\<vladimir.v.diaz@gmail.com>","created_at":"2018-04-27T19:12:51Z","updated_at":"2018-04-27T19:17:42Z","closed_at":"2018-04-27T19:17:42Z","merged_at":"2018-04-27T19:17:41Z","merge_commit_sha":"908919d4e99799a8285bb048c0c30e2135f69e55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/theupdateframework/tuf/pulls/716/commits","review_comments_url":"https://api.github.com/repos/theupdateframework/tuf/pulls/716/comments","review_comment_url":"https://api.github.com/repos/theupdateframework/tuf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theupdateframework/tuf/issues/716/comments","statuses_url":"https://api.github.com/repos/theupdateframework/tuf/statuses/6c0007d84586c5de0b471116ee094884a9048940","head":{"label":"vladimir-v-diaz:replace_os.stat.st_ino","ref":"replace_os.stat.st_ino","sha":"6c0007d84586c5de0b471116ee094884a9048940","user":{"login":"vladimir-v-diaz","id":3520883,"avatar_url":"https://avatars2.githubusercontent.com/u/3520883?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-v-diaz","html_url":"https://github.com/vladimir-v-diaz","followers_url":"https://api.github.com/users/vladimir-v-diaz/followers","following_url":"https://api.github.com/users/vladimir-v-diaz/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-v-diaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-v-diaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-v-diaz/subscriptions","organizations_url":"https://api.github.com/users/vladimir-v-diaz/orgs","repos_url":"https://api.github.com/users/vladimir-v-diaz/repos","events_url":"https://api.github.com/users/vladimir-v-diaz/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-v-diaz/received_events","type":"User","site_admin":false},"repo":{"id":17477810,"name":"tuf","full_name":"vladimir-v-diaz/tuf","owner":{"login":"vladimir-v-diaz","id":3520883,"avatar_url":"https://avatars2.githubusercontent.com/u/3520883?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-v-diaz","html_url":"https://github.com/vladimir-v-diaz","followers_url":"https://api.github.com/users/vladimir-v-diaz/followers","following_url":"https://api.github.com/users/vladimir-v-diaz/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-v-diaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-v-diaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-v-diaz/subscriptions","organizations_url":"https://api.github.com/users/vladimir-v-diaz/orgs","repos_url":"https://api.github.com/users/vladimir-v-diaz/repos","events_url":"https://api.github.com/users/vladimir-v-diaz/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-v-diaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vladimir-v-diaz/tuf","description":"Like the S in HTTPS, a plug-and-play secure updater for your software","fork":true,"url":"https://api.github.com/repos/vladimir-v-diaz/tuf","forks_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/forks","keys_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/teams","hooks_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/hooks","issue_events_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/issues/events{/number}","events_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/events","assignees_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/assignees{/user}","branches_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/branches{/branch}","tags_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/tags","blobs_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/statuses/{sha}","languages_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/languages","stargazers_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/stargazers","contributors_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/contributors","subscribers_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/subscribers","subscription_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/subscription","commits_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/contents/{+path}","compare_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/merges","archive_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/downloads","issues_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/issues{/number}","pulls_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/pulls{/number}","milestones_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/milestones{/number}","notifications_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/labels{/name}","releases_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/releases{/id}","deployments_url":"https://api.github.com/repos/vladimir-v-diaz/tuf/deployments","created_at":"2014-03-06T13:03:12Z","updated_at":"2018-03-19T21:02:59Z","pushed_at":"2018-04-27T19:05:01Z","git_url":"git://github.com/vladimir-v-diaz/tuf.git","ssh_url":"git@github.com:vladimir-v-diaz/tuf.git","clone_url":"https://github.com/vladimir-v-diaz/tuf.git","svn_url":"https://github.com/vladimir-v-diaz/tuf","homepage":"http://theupdateframework.com/","size":13258,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theupdateframework:develop","ref":"develop","sha":"644fe1e63b4cf8494596a885977b810158134e3a","user":{"login":"theupdateframework","id":4633028,"avatar_url":"https://avatars2.githubusercontent.com/u/4633028?v=4","gravatar_id":"","url":"https://api.github.com/users/theupdateframework","html_url":"https://github.com/theupdateframework","followers_url":"https://api.github.com/users/theupdateframework/followers","following_url":"https://api.github.com/users/theupdateframework/following{/other_user}","gists_url":"https://api.github.com/users/theupdateframework/gists{/gist_id}","starred_url":"https://api.github.com/users/theupdateframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theupdateframework/subscriptions","organizations_url":"https://api.github.com/users/theupdateframework/orgs","repos_url":"https://api.github.com/users/theupdateframework/repos","events_url":"https://api.github.com/users/theupdateframework/events{/privacy}","received_events_url":"https://api.github.com/users/theupdateframework/received_events","type":"Organization","site_admin":false},"repo":{"id":7942805,"name":"tuf","full_name":"theupdateframework/tuf","owner":{"login":"theupdateframework","id":4633028,"avatar_url":"https://avatars2.githubusercontent.com/u/4633028?v=4","gravatar_id":"","url":"https://api.github.com/users/theupdateframework","html_url":"https://github.com/theupdateframework","followers_url":"https://api.github.com/users/theupdateframework/followers","following_url":"https://api.github.com/users/theupdateframework/following{/other_user}","gists_url":"https://api.github.com/users/theupdateframework/gists{/gist_id}","starred_url":"https://api.github.com/users/theupdateframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theupdateframework/subscriptions","organizations_url":"https://api.github.com/users/theupdateframework/orgs","repos_url":"https://api.github.com/users/theupdateframework/repos","events_url":"https://api.github.com/users/theupdateframework/events{/privacy}","received_events_url":"https://api.github.com/users/theupdateframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theupdateframework/tuf","description":"A framework for securing software update systems","fork":false,"url":"https://api.github.com/repos/theupdateframework/tuf","forks_url":"https://api.github.com/repos/theupdateframework/tuf/forks","keys_url":"https://api.github.com/repos/theupdateframework/tuf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theupdateframework/tuf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theupdateframework/tuf/teams","hooks_url":"https://api.github.com/repos/theupdateframework/tuf/hooks","issue_events_url":"https://api.github.com/repos/theupdateframework/tuf/issues/events{/number}","events_url":"https://api.github.com/repos/theupdateframework/tuf/events","assignees_url":"https://api.github.com/repos/theupdateframework/tuf/assignees{/user}","branches_url":"https://api.github.com/repos/theupdateframework/tuf/branches{/branch}","tags_url":"https://api.github.com/repos/theupdateframework/tuf/tags","blobs_url":"https://api.github.com/repos/theupdateframework/tuf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theupdateframework/tuf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theupdateframework/tuf/git/refs{/sha}","trees_url":"https://api.github.com/repos/theupdateframework/tuf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theupdateframework/tuf/statuses/{sha}","languages_url":"https://api.github.com/repos/theupdateframework/tuf/languages","stargazers_url":"https://api.github.com/repos/theupdateframework/tuf/stargazers","contributors_url":"https://api.github.com/repos/theupdateframework/tuf/contributors","subscribers_url":"https://api.github.com/repos/theupdateframework/tuf/subscribers","subscription_url":"https://api.github.com/repos/theupdateframework/tuf/subscription","commits_url":"https://api.github.com/repos/theupdateframework/tuf/commits{/sha}","git_commits_url":"https://api.github.com/repos/theupdateframework/tuf/git/commits{/sha}","comments_url":"https://api.github.com/repos/theupdateframework/tuf/comments{/number}","issue_comment_url":"https://api.github.com/repos/theupdateframework/tuf/issues/comments{/number}","contents_url":"https://api.github.com/repos/theupdateframework/tuf/contents/{+path}","compare_url":"https://api.github.com/repos/theupdateframework/tuf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theupdateframework/tuf/merges","archive_url":"https://api.github.com/repos/theupdateframework/tuf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theupdateframework/tuf/downloads","issues_url":"https://api.github.com/repos/theupdateframework/tuf/issues{/number}","pulls_url":"https://api.github.com/repos/theupdateframework/tuf/pulls{/number}","milestones_url":"https://api.github.com/repos/theupdateframework/tuf/milestones{/number}","notifications_url":"https://api.github.com/repos/theupdateframework/tuf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theupdateframework/tuf/labels{/name}","releases_url":"https://api.github.com/repos/theupdateframework/tuf/releases{/id}","deployments_url":"https://api.github.com/repos/theupdateframework/tuf/deployments","created_at":"2013-01-31T18:36:34Z","updated_at":"2018-04-27T17:42:13Z","pushed_at":"2018-04-27T19:17:41Z","git_url":"git://github.com/theupdateframework/tuf.git","ssh_url":"git@github.com:theupdateframework/tuf.git","clone_url":"https://github.com/theupdateframework/tuf.git","svn_url":"https://github.com/theupdateframework/tuf","homepage":"https://theupdateframework.com/","size":13309,"stargazers_count":729,"watchers_count":729,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":101,"open_issues":109,"watchers":729,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theupdateframework/tuf/pulls/716"},"html":{"href":"https://github.com/theupdateframework/tuf/pull/716"},"issue":{"href":"https://api.github.com/repos/theupdateframework/tuf/issues/716"},"comments":{"href":"https://api.github.com/repos/theupdateframework/tuf/issues/716/comments"},"review_comments":{"href":"https://api.github.com/repos/theupdateframework/tuf/pulls/716/comments"},"review_comment":{"href":"https://api.github.com/repos/theupdateframework/tuf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theupdateframework/tuf/pulls/716/commits"},"statuses":{"href":"https://api.github.com/repos/theupdateframework/tuf/statuses/6c0007d84586c5de0b471116ee094884a9048940"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"vladimir-v-diaz","id":3520883,"avatar_url":"https://avatars2.githubusercontent.com/u/3520883?v=4","gravatar_id":"","url":"https://api.github.com/users/vladimir-v-diaz","html_url":"https://github.com/vladimir-v-diaz","followers_url":"https://api.github.com/users/vladimir-v-diaz/followers","following_url":"https://api.github.com/users/vladimir-v-diaz/following{/other_user}","gists_url":"https://api.github.com/users/vladimir-v-diaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vladimir-v-diaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladimir-v-diaz/subscriptions","organizations_url":"https://api.github.com/users/vladimir-v-diaz/orgs","repos_url":"https://api.github.com/users/vladimir-v-diaz/repos","events_url":"https://api.github.com/users/vladimir-v-diaz/events{/privacy}","received_events_url":"https://api.github.com/users/vladimir-v-diaz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"vladimir-v-diaz"}}