{"action":"created","comment":{"url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/comments/189388830","pull_request_review_id":121567041,"id":189388830,"diff_hunk":"@@ -81,6 +81,29 @@ class VisualRecognitionTests: XCTestCase {\n         instantiateVisualRecognition()\n     }\n \n+    /** Teardown logic to cleanup dangling resources after all the tests have run */\n+    override func tearDown() {\n+        let teardownExpectation = self.expectation(description: \"Teardown processing after all tests.\")\n+        visualRecognition.listClassifiers(verbose: true, failure: failWithError) { classifiers in\n+            let classifiersToDelete = classifiers.classifiers.filter { $0.name.starts(with: \"swift-sdk-unit-test-\") }\n+            if classifiersToDelete.count > 0 {\n+                // allow zip files to propagate through object storage, so that\n+                // they will be deleted when the service deletes the classifier\n+                // (otherwise they remain and dramatically slow down the tests)\n+                sleep(15) // wait 15 seconds","path":"Tests/VisualRecognitionV3Tests/VisualRecognitionTests.swift","position":24,"original_position":24,"commit_id":"ca0f987d29c8017903c4cc8d7874bd7f25266435","original_commit_id":"ca0f987d29c8017903c4cc8d7874bd7f25266435","user":{"login":"mediumTaj","id":4381558,"avatar_url":"https://avatars1.githubusercontent.com/u/4381558?v=4","gravatar_id":"","url":"https://api.github.com/users/mediumTaj","html_url":"https://github.com/mediumTaj","followers_url":"https://api.github.com/users/mediumTaj/followers","following_url":"https://api.github.com/users/mediumTaj/following{/other_user}","gists_url":"https://api.github.com/users/mediumTaj/gists{/gist_id}","starred_url":"https://api.github.com/users/mediumTaj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mediumTaj/subscriptions","organizations_url":"https://api.github.com/users/mediumTaj/orgs","repos_url":"https://api.github.com/users/mediumTaj/repos","events_url":"https://api.github.com/users/mediumTaj/events{/privacy}","received_events_url":"https://api.github.com/users/mediumTaj/received_events","type":"User","site_admin":false},"body":"Are we waiting for the classifier to be `ready` or `failed` (a short time after, hah)? I think you might be right when you said we should move away from deleting in the tests and do a purge every week or so.","created_at":"2018-05-18T20:45:40Z","updated_at":"2018-05-18T20:47:19Z","html_url":"https://github.com/watson-developer-cloud/swift-sdk/pull/825#discussion_r189388830","pull_request_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/825","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/comments/189388830"},"html":{"href":"https://github.com/watson-developer-cloud/swift-sdk/pull/825#discussion_r189388830"},"pull_request":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/825"}}},"pull_request":{"url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/825","id":189129547,"html_url":"https://github.com/watson-developer-cloud/swift-sdk/pull/825","diff_url":"https://github.com/watson-developer-cloud/swift-sdk/pull/825.diff","patch_url":"https://github.com/watson-developer-cloud/swift-sdk/pull/825.patch","issue_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/825","number":825,"state":"open","locked":false,"title":"Fix SDK tests to build & run properly on Linux","user":{"login":"mkistler","id":800728,"avatar_url":"https://avatars3.githubusercontent.com/u/800728?v=4","gravatar_id":"","url":"https://api.github.com/users/mkistler","html_url":"https://github.com/mkistler","followers_url":"https://api.github.com/users/mkistler/followers","following_url":"https://api.github.com/users/mkistler/following{/other_user}","gists_url":"https://api.github.com/users/mkistler/gists{/gist_id}","starred_url":"https://api.github.com/users/mkistler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkistler/subscriptions","organizations_url":"https://api.github.com/users/mkistler/orgs","repos_url":"https://api.github.com/users/mkistler/repos","events_url":"https://api.github.com/users/mkistler/events{/privacy}","received_events_url":"https://api.github.com/users/mkistler/received_events","type":"User","site_admin":false},"body":"This PR replaces some test logic that uses features/capabilities that are not available on Linux.\r\n\r\nSpecifically:\r\n- Remove all uses of `addTeardownBlock`, which is not available on Linux.  The new logic reuses existing resources in subsequent test runs, so leaving \"dangling\" resources after test completion is not an issue.\r\n- Replace `wait(for:` with `waitForExpectations` because the former is not supported on Linux.  This required some rework to prevent overlap in the scopes of expectations.\r\n\r\nI also updated the Dockerfile to use the new Swift 4.1 docker image.\r\n\r\nWith these changes, the SDK again builds and runs on Linux.  The results of my last full test run were:\r\n```\r\nTest Suite 'All tests' failed at 2018-05-18 20:08:11.982\r\n\t Executed 219 tests, with 5 failures (0 unexpected) in 1555.428 (1555.428) seconds\r\n```\r\n\r\nTwo of these failures were VR tests that were disabled in Xcode, so I also disabled them in Linux, two were timeouts in VR tests, and one was just an intermittent failure.","created_at":"2018-05-18T20:39:23Z","updated_at":"2018-05-18T20:47:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae3cbea63ebf65cceef862621e4f2cee3ffc1f0f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/825/commits","review_comments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/825/comments","review_comment_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/825/comments","statuses_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/statuses/ca0f987d29c8017903c4cc8d7874bd7f25266435","head":{"label":"watson-developer-cloud:mdk/fix-linux-tests","ref":"mdk/fix-linux-tests","sha":"ca0f987d29c8017903c4cc8d7874bd7f25266435","user":{"login":"watson-developer-cloud","id":10017763,"avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":42934262,"name":"swift-sdk","full_name":"watson-developer-cloud/swift-sdk","owner":{"login":"watson-developer-cloud","id":10017763,"avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/watson-developer-cloud/swift-sdk","description":":iphone: The Watson Swift SDK enables developers to quickly add Watson Cognitive Computing services to their Swift applications.","fork":false,"url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk","forks_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/forks","keys_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/teams","hooks_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/hooks","issue_events_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/events","assignees_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/tags","blobs_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/languages","stargazers_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/stargazers","contributors_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/contributors","subscribers_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/subscribers","subscription_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/subscription","commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/merges","archive_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/downloads","issues_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/labels{/name}","releases_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/deployments","created_at":"2015-09-22T13:07:37Z","updated_at":"2018-05-18T00:04:11Z","pushed_at":"2018-05-18T20:39:24Z","git_url":"git://github.com/watson-developer-cloud/swift-sdk.git","ssh_url":"git@github.com:watson-developer-cloud/swift-sdk.git","clone_url":"https://github.com/watson-developer-cloud/swift-sdk.git","svn_url":"https://github.com/watson-developer-cloud/swift-sdk","homepage":"https://watson-developer-cloud.github.io/swift-sdk/","size":78274,"stargazers_count":735,"watchers_count":735,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":187,"open_issues":45,"watchers":735,"default_branch":"master"}},"base":{"label":"watson-developer-cloud:master","ref":"master","sha":"f4050bf1325c45575fcf1b19aab09771d9eb26cb","user":{"login":"watson-developer-cloud","id":10017763,"avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":42934262,"name":"swift-sdk","full_name":"watson-developer-cloud/swift-sdk","owner":{"login":"watson-developer-cloud","id":10017763,"avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/watson-developer-cloud/swift-sdk","description":":iphone: The Watson Swift SDK enables developers to quickly add Watson Cognitive Computing services to their Swift applications.","fork":false,"url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk","forks_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/forks","keys_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/teams","hooks_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/hooks","issue_events_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/events","assignees_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/tags","blobs_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/languages","stargazers_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/stargazers","contributors_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/contributors","subscribers_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/subscribers","subscription_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/subscription","commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/merges","archive_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/downloads","issues_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/labels{/name}","releases_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/deployments","created_at":"2015-09-22T13:07:37Z","updated_at":"2018-05-18T00:04:11Z","pushed_at":"2018-05-18T20:39:24Z","git_url":"git://github.com/watson-developer-cloud/swift-sdk.git","ssh_url":"git@github.com:watson-developer-cloud/swift-sdk.git","clone_url":"https://github.com/watson-developer-cloud/swift-sdk.git","svn_url":"https://github.com/watson-developer-cloud/swift-sdk","homepage":"https://watson-developer-cloud.github.io/swift-sdk/","size":78274,"stargazers_count":735,"watchers_count":735,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":187,"open_issues":45,"watchers":735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/825"},"html":{"href":"https://github.com/watson-developer-cloud/swift-sdk/pull/825"},"issue":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/825"},"comments":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/825/comments"},"review_comments":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/825/comments"},"review_comment":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/825/commits"},"statuses":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/statuses/ca0f987d29c8017903c4cc8d7874bd7f25266435"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mediumTaj"}}