{"action":"closed","number":2036,"pull_request":{"url":"https://api.github.com/repos/dcos/dcos/pulls/2036","id":148101985,"html_url":"https://github.com/dcos/dcos/pull/2036","diff_url":"https://github.com/dcos/dcos/pull/2036.diff","patch_url":"https://github.com/dcos/dcos/pull/2036.patch","issue_url":"https://api.github.com/repos/dcos/dcos/issues/2036","number":2036,"state":"closed","locked":false,"title":"Adds installation of DC/OS build specific python-gdb.py file","user":{"login":"MrMarvin","id":100136,"avatar_url":"https://avatars3.githubusercontent.com/u/100136?v=4","gravatar_id":"","url":"https://api.github.com/users/MrMarvin","html_url":"https://github.com/MrMarvin","followers_url":"https://api.github.com/users/MrMarvin/followers","following_url":"https://api.github.com/users/MrMarvin/following{/other_user}","gists_url":"https://api.github.com/users/MrMarvin/gists{/gist_id}","starred_url":"https://api.github.com/users/MrMarvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrMarvin/subscriptions","organizations_url":"https://api.github.com/users/MrMarvin/orgs","repos_url":"https://api.github.com/users/MrMarvin/repos","events_url":"https://api.github.com/users/MrMarvin/events{/privacy}","received_events_url":"https://api.github.com/users/MrMarvin/received_events","type":"User","site_admin":false},"body":"## High Level Description\r\n\r\nWith this change our DC/OS installations will include the python build specific gdb helper script `python-gdb.py`. This will allow us to interact and debug python based components of DC/OS.\r\n\r\nMost Linux distributions bundle this file in a dedicated python-dbg (or similar) package, so it is understandable that it is not part of what `make install` installs into $prefix. As we do however bundle our own build of python and do not currently provide a debug build and or additional debug package, there is no usable python-gdb.py file available.\r\n\r\nPlease note that the path the file usually goes to is somewhere in '/usr/share/gdb/[...]', so I decided to put in in `$PKG_PATH/share/` as well, although the gdb autoloader wont pick it up automatically from there. This seems to be the most sane solution here, without cluttering `bin/`.\r\n\r\n## Related Issues\r\n  - [SOAK-22](https://jira.mesosphere.com/browse/SOAK-22) Debugging DC/OS components that use our bundled python interpreter\r\n\r\n## Checklist for all PR's\r\n\r\n  - [x] *Included a test which will fail if code is reverted but test is not. If there is no test please explain here*:\r\nI am not sure how infrastructural changes like this should be tested. If we do have a test framework for things like this, please point me in the right direction and I will make sure to add a test case!","created_at":"2017-10-23T11:13:08Z","updated_at":"2018-02-23T18:38:10Z","closed_at":"2018-02-23T18:38:09Z","merged_at":"2018-02-23T18:38:09Z","merge_commit_sha":"f7104f29b8770b01a862fe7808c29de6d130ae16","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":528929763,"url":"https://api.github.com/repos/dcos/dcos/labels/Ship%20It","name":"Ship It","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos/pulls/2036/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos/pulls/2036/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos/issues/2036/comments","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/f7104f29b8770b01a862fe7808c29de6d130ae16","head":{"label":"MrMarvin:python_gdb_bundled","ref":"python_gdb_bundled","sha":"f7104f29b8770b01a862fe7808c29de6d130ae16","user":{"login":"MrMarvin","id":100136,"avatar_url":"https://avatars3.githubusercontent.com/u/100136?v=4","gravatar_id":"","url":"https://api.github.com/users/MrMarvin","html_url":"https://github.com/MrMarvin","followers_url":"https://api.github.com/users/MrMarvin/followers","following_url":"https://api.github.com/users/MrMarvin/following{/other_user}","gists_url":"https://api.github.com/users/MrMarvin/gists{/gist_id}","starred_url":"https://api.github.com/users/MrMarvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrMarvin/subscriptions","organizations_url":"https://api.github.com/users/MrMarvin/orgs","repos_url":"https://api.github.com/users/MrMarvin/repos","events_url":"https://api.github.com/users/MrMarvin/events{/privacy}","received_events_url":"https://api.github.com/users/MrMarvin/received_events","type":"User","site_admin":false},"repo":{"id":107967989,"name":"dcos","full_name":"MrMarvin/dcos","owner":{"login":"MrMarvin","id":100136,"avatar_url":"https://avatars3.githubusercontent.com/u/100136?v=4","gravatar_id":"","url":"https://api.github.com/users/MrMarvin","html_url":"https://github.com/MrMarvin","followers_url":"https://api.github.com/users/MrMarvin/followers","following_url":"https://api.github.com/users/MrMarvin/following{/other_user}","gists_url":"https://api.github.com/users/MrMarvin/gists{/gist_id}","starred_url":"https://api.github.com/users/MrMarvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrMarvin/subscriptions","organizations_url":"https://api.github.com/users/MrMarvin/orgs","repos_url":"https://api.github.com/users/MrMarvin/repos","events_url":"https://api.github.com/users/MrMarvin/events{/privacy}","received_events_url":"https://api.github.com/users/MrMarvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrMarvin/dcos","description":"DC/OS Build and Release tools","fork":true,"url":"https://api.github.com/repos/MrMarvin/dcos","forks_url":"https://api.github.com/repos/MrMarvin/dcos/forks","keys_url":"https://api.github.com/repos/MrMarvin/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrMarvin/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrMarvin/dcos/teams","hooks_url":"https://api.github.com/repos/MrMarvin/dcos/hooks","issue_events_url":"https://api.github.com/repos/MrMarvin/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/MrMarvin/dcos/events","assignees_url":"https://api.github.com/repos/MrMarvin/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/MrMarvin/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/MrMarvin/dcos/tags","blobs_url":"https://api.github.com/repos/MrMarvin/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrMarvin/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrMarvin/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrMarvin/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrMarvin/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/MrMarvin/dcos/languages","stargazers_url":"https://api.github.com/repos/MrMarvin/dcos/stargazers","contributors_url":"https://api.github.com/repos/MrMarvin/dcos/contributors","subscribers_url":"https://api.github.com/repos/MrMarvin/dcos/subscribers","subscription_url":"https://api.github.com/repos/MrMarvin/dcos/subscription","commits_url":"https://api.github.com/repos/MrMarvin/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrMarvin/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrMarvin/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrMarvin/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrMarvin/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/MrMarvin/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrMarvin/dcos/merges","archive_url":"https://api.github.com/repos/MrMarvin/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrMarvin/dcos/downloads","issues_url":"https://api.github.com/repos/MrMarvin/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/MrMarvin/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/MrMarvin/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/MrMarvin/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrMarvin/dcos/labels{/name}","releases_url":"https://api.github.com/repos/MrMarvin/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/MrMarvin/dcos/deployments","created_at":"2017-10-23T10:40:26Z","updated_at":"2017-10-23T10:40:28Z","pushed_at":"2017-12-18T17:14:50Z","git_url":"git://github.com/MrMarvin/dcos.git","ssh_url":"git@github.com:MrMarvin/dcos.git","clone_url":"https://github.com/MrMarvin/dcos.git","svn_url":"https://github.com/MrMarvin/dcos","homepage":"https://dcos.io","size":5263,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"98d0ac1f34737540a1f9b60fe9d4db2aeffc20db","user":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":56184050,"name":"dcos","full_name":"dcos/dcos","owner":{"login":"dcos","id":17648048,"avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos","description":"DC/OS - The Datacenter Operating System ","fork":false,"url":"https://api.github.com/repos/dcos/dcos","forks_url":"https://api.github.com/repos/dcos/dcos/forks","keys_url":"https://api.github.com/repos/dcos/dcos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos/teams","hooks_url":"https://api.github.com/repos/dcos/dcos/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos/events","assignees_url":"https://api.github.com/repos/dcos/dcos/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos/tags","blobs_url":"https://api.github.com/repos/dcos/dcos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos/subscription","commits_url":"https://api.github.com/repos/dcos/dcos/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos/merges","archive_url":"https://api.github.com/repos/dcos/dcos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos/downloads","issues_url":"https://api.github.com/repos/dcos/dcos/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos/deployments","created_at":"2016-04-13T20:31:58Z","updated_at":"2018-02-22T20:48:32Z","pushed_at":"2018-02-23T18:38:04Z","git_url":"git://github.com/dcos/dcos.git","ssh_url":"git@github.com:dcos/dcos.git","clone_url":"https://github.com/dcos/dcos.git","svn_url":"https://github.com/dcos/dcos","homepage":"https://dcos.io","size":5716,"stargazers_count":1901,"watchers_count":1901,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":377,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":377,"open_issues":96,"watchers":1901,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2036"},"html":{"href":"https://github.com/dcos/dcos/pull/2036"},"issue":{"href":"https://api.github.com/repos/dcos/dcos/issues/2036"},"comments":{"href":"https://api.github.com/repos/dcos/dcos/issues/2036/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2036/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos/pulls/2036/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos/statuses/f7104f29b8770b01a862fe7808c29de6d130ae16"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mesosphere-mergebot","id":22822961,"avatar_url":"https://avatars3.githubusercontent.com/u/22822961?v=4","gravatar_id":"","url":"https://api.github.com/users/mesosphere-mergebot","html_url":"https://github.com/mesosphere-mergebot","followers_url":"https://api.github.com/users/mesosphere-mergebot/followers","following_url":"https://api.github.com/users/mesosphere-mergebot/following{/other_user}","gists_url":"https://api.github.com/users/mesosphere-mergebot/gists{/gist_id}","starred_url":"https://api.github.com/users/mesosphere-mergebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesosphere-mergebot/subscriptions","organizations_url":"https://api.github.com/users/mesosphere-mergebot/orgs","repos_url":"https://api.github.com/users/mesosphere-mergebot/repos","events_url":"https://api.github.com/users/mesosphere-mergebot/events{/privacy}","received_events_url":"https://api.github.com/users/mesosphere-mergebot/received_events","type":"User","site_admin":false},"comments":50,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"mesosphere-mergebot"}}