{"action":"created","issue":{"url":"https://api.github.com/repos/merge/skulls/issues/38","repository_url":"https://api.github.com/repos/merge/skulls","labels_url":"https://api.github.com/repos/merge/skulls/issues/38/labels{/name}","comments_url":"https://api.github.com/repos/merge/skulls/issues/38/comments","events_url":"https://api.github.com/repos/merge/skulls/issues/38/events","html_url":"https://github.com/merge/skulls/issues/38","id":363723877,"node_id":"MDU6SXNzdWUzNjM3MjM4Nzc=","number":38,"title":"Skip RAM voltage check?","user":{"login":"oida","id":7249506,"node_id":"MDQ6VXNlcjcyNDk1MDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7249506?v=4","gravatar_id":"","url":"https://api.github.com/users/oida","html_url":"https://github.com/oida","followers_url":"https://api.github.com/users/oida/followers","following_url":"https://api.github.com/users/oida/following{/other_user}","gists_url":"https://api.github.com/users/oida/gists{/gist_id}","starred_url":"https://api.github.com/users/oida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oida/subscriptions","organizations_url":"https://api.github.com/users/oida/orgs","repos_url":"https://api.github.com/users/oida/repos","events_url":"https://api.github.com/users/oida/events{/privacy}","received_events_url":"https://api.github.com/users/oida/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-25T19:04:34Z","updated_at":"2018-09-26T06:36:57Z","closed_at":null,"author_association":"NONE","body":"Hey, I was wondering what this is actually about: https://github.com/merge/skulls/blob/master/x230/x230_before_first_install.sh#L70\r\nSince I was having a quite intense discussion with a friend about that, and if this may be needed at all.\r\nFrom what we found in the wiki page which is linked in x230/README.md: https://www.coreboot.org/Intel_Native_Raminit#Sandybridge.2FIvybridge\r\nI understood that the RAM voltage can only be adjusted on some Sandybridge/Ivybridge boards, but support for that is not implemented within coreboot, so RAM voltage is always fixed to 1,5V on the X230 and all Sandybridge/Ivybridge boards.\r\nWe also did a lookup and understood that PC3 is always 1,5V and all PC3L modules can run with either 1,35V or 1,50V: https://en.wikipedia.org/wiki/DDR3_SDRAM#DDR3L_and_DDR3U_extensions\r\nso both PC3 and PC3L must work in the X230, which will always run with 1,5V.\r\nAm I missing something or can this check be removed alltogether, or at least for the X230? Thanks"},"comment":{"url":"https://api.github.com/repos/merge/skulls/issues/comments/424601841","html_url":"https://github.com/merge/skulls/issues/38#issuecomment-424601841","issue_url":"https://api.github.com/repos/merge/skulls/issues/38","id":424601841,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDYwMTg0MQ==","user":{"login":"merge","id":503356,"node_id":"MDQ6VXNlcjUwMzM1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/503356?v=4","gravatar_id":"","url":"https://api.github.com/users/merge","html_url":"https://github.com/merge","followers_url":"https://api.github.com/users/merge/followers","following_url":"https://api.github.com/users/merge/following{/other_user}","gists_url":"https://api.github.com/users/merge/gists{/gist_id}","starred_url":"https://api.github.com/users/merge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merge/subscriptions","organizations_url":"https://api.github.com/users/merge/orgs","repos_url":"https://api.github.com/users/merge/repos","events_url":"https://api.github.com/users/merge/events{/privacy}","received_events_url":"https://api.github.com/users/merge/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T06:36:57Z","updated_at":"2018-09-26T06:36:57Z","author_association":"OWNER","body":"All I know is that I've once plugged in a module specified with 1,35V and coreboot wouldn't start. So to me it made sense to add this in order to be safe. If you test this I'll do tests again and we'll see. But as long as it __could__ prevent failure it doesn't hurt to have this check in there I guess.\r\n\r\nthanks for reviewing!"}}
{"actor":{"display_login":"merge"}}