{"action":"created","comment":{"url":"https://api.github.com/repos/spesmilo/electrum/pulls/comments/188880593","pull_request_review_id":120945254,"id":188880593,"diff_hunk":"@@ -657,10 +657,23 @@ def is_synchronized(self):\n         return self.wallet.is_up_to_date()\n \n     @command('n')\n-    def getfeerate(self):\n-        \"\"\"Return current optimal fee rate per kilobyte, according\n-        to config settings (static/dynamic)\"\"\"\n-        return self.config.fee_per_kb()\n+    def getfeerate(self, fee_method=None, fee_level=None):","path":"lib/commands.py","position":8,"original_position":8,"commit_id":"4cffa0c0f8c175421d337089cc380590d9cb2339","original_commit_id":"4cffa0c0f8c175421d337089cc380590d9cb2339","user":{"login":"haarts","id":10660,"avatar_url":"https://avatars2.githubusercontent.com/u/10660?v=4","gravatar_id":"","url":"https://api.github.com/users/haarts","html_url":"https://github.com/haarts","followers_url":"https://api.github.com/users/haarts/followers","following_url":"https://api.github.com/users/haarts/following{/other_user}","gists_url":"https://api.github.com/users/haarts/gists{/gist_id}","starred_url":"https://api.github.com/users/haarts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haarts/subscriptions","organizations_url":"https://api.github.com/users/haarts/orgs","repos_url":"https://api.github.com/users/haarts/repos","events_url":"https://api.github.com/users/haarts/events{/privacy}","received_events_url":"https://api.github.com/users/haarts/received_events","type":"User","site_admin":false},"body":"Does it make sense to have `fee_level` default to `None`. Doing so complicates the code with several if statements. Also passing a default signals the argument is optional which it does seem to be.","created_at":"2018-05-17T08:44:16Z","updated_at":"2018-05-17T08:44:16Z","html_url":"https://github.com/spesmilo/electrum/pull/4264#discussion_r188880593","pull_request_url":"https://api.github.com/repos/spesmilo/electrum/pulls/4264","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spesmilo/electrum/pulls/comments/188880593"},"html":{"href":"https://github.com/spesmilo/electrum/pull/4264#discussion_r188880593"},"pull_request":{"href":"https://api.github.com/repos/spesmilo/electrum/pulls/4264"}}},"pull_request":{"url":"https://api.github.com/repos/spesmilo/electrum/pulls/4264","id":181700861,"html_url":"https://github.com/spesmilo/electrum/pull/4264","diff_url":"https://github.com/spesmilo/electrum/pull/4264.diff","patch_url":"https://github.com/spesmilo/electrum/pull/4264.patch","issue_url":"https://api.github.com/repos/spesmilo/electrum/issues/4264","number":4264,"state":"open","locked":false,"title":"Getfeerate cmd options","user":{"login":"SomberNight","id":29142493,"avatar_url":"https://avatars2.githubusercontent.com/u/29142493?v=4","gravatar_id":"","url":"https://api.github.com/users/SomberNight","html_url":"https://github.com/SomberNight","followers_url":"https://api.github.com/users/SomberNight/followers","following_url":"https://api.github.com/users/SomberNight/following{/other_user}","gists_url":"https://api.github.com/users/SomberNight/gists{/gist_id}","starred_url":"https://api.github.com/users/SomberNight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SomberNight/subscriptions","organizations_url":"https://api.github.com/users/SomberNight/orgs","repos_url":"https://api.github.com/users/SomberNight/repos","events_url":"https://api.github.com/users/SomberNight/events{/privacy}","received_events_url":"https://api.github.com/users/SomberNight/received_events","type":"User","site_admin":false},"body":"closes https://github.com/spesmilo/electrum/issues/2447#issuecomment-381360086\r\n\r\n```\r\n$ ./electrum getfeerate --fee_method 2 --fee_level 0.25\r\n1000\r\n$ ./electrum getfeerate --fee_method 2 --fee_level 0.98\r\n12000\r\n$ ./electrum getfeerate --fee_method 1 --fee_level 0.8\r\n24336\r\n```","created_at":"2018-04-15T14:09:46Z","updated_at":"2018-05-17T08:44:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a5b1c3998866b7c5fe6c92d4f6b970b412183da4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spesmilo/electrum/pulls/4264/commits","review_comments_url":"https://api.github.com/repos/spesmilo/electrum/pulls/4264/comments","review_comment_url":"https://api.github.com/repos/spesmilo/electrum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spesmilo/electrum/issues/4264/comments","statuses_url":"https://api.github.com/repos/spesmilo/electrum/statuses/4cffa0c0f8c175421d337089cc380590d9cb2339","head":{"label":"SomberNight:getfeerate_cmd_options","ref":"getfeerate_cmd_options","sha":"4cffa0c0f8c175421d337089cc380590d9cb2339","user":{"login":"SomberNight","id":29142493,"avatar_url":"https://avatars2.githubusercontent.com/u/29142493?v=4","gravatar_id":"","url":"https://api.github.com/users/SomberNight","html_url":"https://github.com/SomberNight","followers_url":"https://api.github.com/users/SomberNight/followers","following_url":"https://api.github.com/users/SomberNight/following{/other_user}","gists_url":"https://api.github.com/users/SomberNight/gists{/gist_id}","starred_url":"https://api.github.com/users/SomberNight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SomberNight/subscriptions","organizations_url":"https://api.github.com/users/SomberNight/orgs","repos_url":"https://api.github.com/users/SomberNight/repos","events_url":"https://api.github.com/users/SomberNight/events{/privacy}","received_events_url":"https://api.github.com/users/SomberNight/received_events","type":"User","site_admin":false},"repo":{"id":100324547,"name":"electrum","full_name":"SomberNight/electrum","owner":{"login":"SomberNight","id":29142493,"avatar_url":"https://avatars2.githubusercontent.com/u/29142493?v=4","gravatar_id":"","url":"https://api.github.com/users/SomberNight","html_url":"https://github.com/SomberNight","followers_url":"https://api.github.com/users/SomberNight/followers","following_url":"https://api.github.com/users/SomberNight/following{/other_user}","gists_url":"https://api.github.com/users/SomberNight/gists{/gist_id}","starred_url":"https://api.github.com/users/SomberNight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SomberNight/subscriptions","organizations_url":"https://api.github.com/users/SomberNight/orgs","repos_url":"https://api.github.com/users/SomberNight/repos","events_url":"https://api.github.com/users/SomberNight/events{/privacy}","received_events_url":"https://api.github.com/users/SomberNight/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SomberNight/electrum","description":"Electrum; Bitcoin thin client","fork":true,"url":"https://api.github.com/repos/SomberNight/electrum","forks_url":"https://api.github.com/repos/SomberNight/electrum/forks","keys_url":"https://api.github.com/repos/SomberNight/electrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SomberNight/electrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SomberNight/electrum/teams","hooks_url":"https://api.github.com/repos/SomberNight/electrum/hooks","issue_events_url":"https://api.github.com/repos/SomberNight/electrum/issues/events{/number}","events_url":"https://api.github.com/repos/SomberNight/electrum/events","assignees_url":"https://api.github.com/repos/SomberNight/electrum/assignees{/user}","branches_url":"https://api.github.com/repos/SomberNight/electrum/branches{/branch}","tags_url":"https://api.github.com/repos/SomberNight/electrum/tags","blobs_url":"https://api.github.com/repos/SomberNight/electrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SomberNight/electrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SomberNight/electrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/SomberNight/electrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SomberNight/electrum/statuses/{sha}","languages_url":"https://api.github.com/repos/SomberNight/electrum/languages","stargazers_url":"https://api.github.com/repos/SomberNight/electrum/stargazers","contributors_url":"https://api.github.com/repos/SomberNight/electrum/contributors","subscribers_url":"https://api.github.com/repos/SomberNight/electrum/subscribers","subscription_url":"https://api.github.com/repos/SomberNight/electrum/subscription","commits_url":"https://api.github.com/repos/SomberNight/electrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/SomberNight/electrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/SomberNight/electrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/SomberNight/electrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/SomberNight/electrum/contents/{+path}","compare_url":"https://api.github.com/repos/SomberNight/electrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SomberNight/electrum/merges","archive_url":"https://api.github.com/repos/SomberNight/electrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SomberNight/electrum/downloads","issues_url":"https://api.github.com/repos/SomberNight/electrum/issues{/number}","pulls_url":"https://api.github.com/repos/SomberNight/electrum/pulls{/number}","milestones_url":"https://api.github.com/repos/SomberNight/electrum/milestones{/number}","notifications_url":"https://api.github.com/repos/SomberNight/electrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SomberNight/electrum/labels{/name}","releases_url":"https://api.github.com/repos/SomberNight/electrum/releases{/id}","deployments_url":"https://api.github.com/repos/SomberNight/electrum/deployments","created_at":"2017-08-15T01:23:01Z","updated_at":"2018-05-16T22:48:45Z","pushed_at":"2018-05-16T22:48:44Z","git_url":"git://github.com/SomberNight/electrum.git","ssh_url":"git@github.com:SomberNight/electrum.git","clone_url":"https://github.com/SomberNight/electrum.git","svn_url":"https://github.com/SomberNight/electrum","homepage":null,"size":24384,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spesmilo:master","ref":"master","sha":"44bb1e9993bbfe996bf4263e787da184f9f5bc87","user":{"login":"spesmilo","id":2084673,"avatar_url":"https://avatars2.githubusercontent.com/u/2084673?v=4","gravatar_id":"","url":"https://api.github.com/users/spesmilo","html_url":"https://github.com/spesmilo","followers_url":"https://api.github.com/users/spesmilo/followers","following_url":"https://api.github.com/users/spesmilo/following{/other_user}","gists_url":"https://api.github.com/users/spesmilo/gists{/gist_id}","starred_url":"https://api.github.com/users/spesmilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spesmilo/subscriptions","organizations_url":"https://api.github.com/users/spesmilo/orgs","repos_url":"https://api.github.com/users/spesmilo/repos","events_url":"https://api.github.com/users/spesmilo/events{/privacy}","received_events_url":"https://api.github.com/users/spesmilo/received_events","type":"Organization","site_admin":false},"repo":{"id":5274894,"name":"electrum","full_name":"spesmilo/electrum","owner":{"login":"spesmilo","id":2084673,"avatar_url":"https://avatars2.githubusercontent.com/u/2084673?v=4","gravatar_id":"","url":"https://api.github.com/users/spesmilo","html_url":"https://github.com/spesmilo","followers_url":"https://api.github.com/users/spesmilo/followers","following_url":"https://api.github.com/users/spesmilo/following{/other_user}","gists_url":"https://api.github.com/users/spesmilo/gists{/gist_id}","starred_url":"https://api.github.com/users/spesmilo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spesmilo/subscriptions","organizations_url":"https://api.github.com/users/spesmilo/orgs","repos_url":"https://api.github.com/users/spesmilo/repos","events_url":"https://api.github.com/users/spesmilo/events{/privacy}","received_events_url":"https://api.github.com/users/spesmilo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spesmilo/electrum","description":"Electrum; Bitcoin thin client","fork":false,"url":"https://api.github.com/repos/spesmilo/electrum","forks_url":"https://api.github.com/repos/spesmilo/electrum/forks","keys_url":"https://api.github.com/repos/spesmilo/electrum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spesmilo/electrum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spesmilo/electrum/teams","hooks_url":"https://api.github.com/repos/spesmilo/electrum/hooks","issue_events_url":"https://api.github.com/repos/spesmilo/electrum/issues/events{/number}","events_url":"https://api.github.com/repos/spesmilo/electrum/events","assignees_url":"https://api.github.com/repos/spesmilo/electrum/assignees{/user}","branches_url":"https://api.github.com/repos/spesmilo/electrum/branches{/branch}","tags_url":"https://api.github.com/repos/spesmilo/electrum/tags","blobs_url":"https://api.github.com/repos/spesmilo/electrum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spesmilo/electrum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spesmilo/electrum/git/refs{/sha}","trees_url":"https://api.github.com/repos/spesmilo/electrum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spesmilo/electrum/statuses/{sha}","languages_url":"https://api.github.com/repos/spesmilo/electrum/languages","stargazers_url":"https://api.github.com/repos/spesmilo/electrum/stargazers","contributors_url":"https://api.github.com/repos/spesmilo/electrum/contributors","subscribers_url":"https://api.github.com/repos/spesmilo/electrum/subscribers","subscription_url":"https://api.github.com/repos/spesmilo/electrum/subscription","commits_url":"https://api.github.com/repos/spesmilo/electrum/commits{/sha}","git_commits_url":"https://api.github.com/repos/spesmilo/electrum/git/commits{/sha}","comments_url":"https://api.github.com/repos/spesmilo/electrum/comments{/number}","issue_comment_url":"https://api.github.com/repos/spesmilo/electrum/issues/comments{/number}","contents_url":"https://api.github.com/repos/spesmilo/electrum/contents/{+path}","compare_url":"https://api.github.com/repos/spesmilo/electrum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spesmilo/electrum/merges","archive_url":"https://api.github.com/repos/spesmilo/electrum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spesmilo/electrum/downloads","issues_url":"https://api.github.com/repos/spesmilo/electrum/issues{/number}","pulls_url":"https://api.github.com/repos/spesmilo/electrum/pulls{/number}","milestones_url":"https://api.github.com/repos/spesmilo/electrum/milestones{/number}","notifications_url":"https://api.github.com/repos/spesmilo/electrum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spesmilo/electrum/labels{/name}","releases_url":"https://api.github.com/repos/spesmilo/electrum/releases{/id}","deployments_url":"https://api.github.com/repos/spesmilo/electrum/deployments","created_at":"2012-08-02T16:24:30Z","updated_at":"2018-05-17T06:11:06Z","pushed_at":"2018-05-16T22:48:29Z","git_url":"git://github.com/spesmilo/electrum.git","ssh_url":"git@github.com:spesmilo/electrum.git","clone_url":"https://github.com/spesmilo/electrum.git","svn_url":"https://github.com/spesmilo/electrum","homepage":null,"size":22914,"stargazers_count":2576,"watchers_count":2576,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1365,"mirror_url":null,"archived":false,"open_issues_count":330,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1365,"open_issues":330,"watchers":2576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spesmilo/electrum/pulls/4264"},"html":{"href":"https://github.com/spesmilo/electrum/pull/4264"},"issue":{"href":"https://api.github.com/repos/spesmilo/electrum/issues/4264"},"comments":{"href":"https://api.github.com/repos/spesmilo/electrum/issues/4264/comments"},"review_comments":{"href":"https://api.github.com/repos/spesmilo/electrum/pulls/4264/comments"},"review_comment":{"href":"https://api.github.com/repos/spesmilo/electrum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spesmilo/electrum/pulls/4264/commits"},"statuses":{"href":"https://api.github.com/repos/spesmilo/electrum/statuses/4cffa0c0f8c175421d337089cc380590d9cb2339"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"haarts"}}