{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/Hystrix/issues/1897","repository_url":"https://api.github.com/repos/Netflix/Hystrix","labels_url":"https://api.github.com/repos/Netflix/Hystrix/issues/1897/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/Hystrix/issues/1897/comments","events_url":"https://api.github.com/repos/Netflix/Hystrix/issues/1897/events","html_url":"https://github.com/Netflix/Hystrix/issues/1897","id":380909536,"node_id":"MDU6SXNzdWUzODA5MDk1MzY=","number":1897,"title":"hystrix.threadpool.<POOL>.coreSize configuration does not work when increasing","user":{"login":"jogoussard","id":8582241,"node_id":"MDQ6VXNlcjg1ODIyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8582241?v=4","gravatar_id":"","url":"https://api.github.com/users/jogoussard","html_url":"https://github.com/jogoussard","followers_url":"https://api.github.com/users/jogoussard/followers","following_url":"https://api.github.com/users/jogoussard/following{/other_user}","gists_url":"https://api.github.com/users/jogoussard/gists{/gist_id}","starred_url":"https://api.github.com/users/jogoussard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jogoussard/subscriptions","organizations_url":"https://api.github.com/users/jogoussard/orgs","repos_url":"https://api.github.com/users/jogoussard/repos","events_url":"https://api.github.com/users/jogoussard/events{/privacy}","received_events_url":"https://api.github.com/users/jogoussard/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-14T22:11:27Z","updated_at":"2018-11-15T14:15:45Z","closed_at":null,"author_association":"NONE","body":"Hi\r\nStarting with a configuration as\r\nhystrix.threadpool.MyPool.coreSize=30\r\nand increasing afterwards dynamically to above 30 does not work because HystrixThreadPool sets *first* the core size and *second* the max size (line 230/231). So as the core size we are trying to set is above the current max size, the JVM rejects the call to setCorePoolSize.\r\nThe fix seems simply to use:\r\n```\r\n\t\tif (dynamicMaximumSize < dynamicCoreSize) {\r\n\t\t\t\tdynamicMaximumSize = dynamicCoreSize;\r\n\t\t}\r\n                threadPool.setMaximumPoolSize(dynamicMaximumSize);\r\n                threadPool.setCorePoolSize(dynamicCoreSize);\r\n```\r\nException seen:\r\n```\r\njava.lang.IllegalArgumentException: null\r\n\tat java.base/java.util.concurrent.ThreadPoolExecutor.setCorePoolSize(ThreadPoolExecutor.java:1560)\r\n\tat com.netflix.hystrix.HystrixThreadPool$HystrixThreadPoolDefault.touchConfig(HystrixThreadPool.java:230)\r\n\tat com.netflix.hystrix.HystrixThreadPool$HystrixThreadPoolDefault.getScheduler(HystrixThreadPool.java:205)\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Netflix/Hystrix/issues/comments/439054167","html_url":"https://github.com/Netflix/Hystrix/issues/1897#issuecomment-439054167","issue_url":"https://api.github.com/repos/Netflix/Hystrix/issues/1897","id":439054167,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTA1NDE2Nw==","user":{"login":"jogoussard","id":8582241,"node_id":"MDQ6VXNlcjg1ODIyNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8582241?v=4","gravatar_id":"","url":"https://api.github.com/users/jogoussard","html_url":"https://github.com/jogoussard","followers_url":"https://api.github.com/users/jogoussard/followers","following_url":"https://api.github.com/users/jogoussard/following{/other_user}","gists_url":"https://api.github.com/users/jogoussard/gists{/gist_id}","starred_url":"https://api.github.com/users/jogoussard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jogoussard/subscriptions","organizations_url":"https://api.github.com/users/jogoussard/orgs","repos_url":"https://api.github.com/users/jogoussard/repos","events_url":"https://api.github.com/users/jogoussard/events{/privacy}","received_events_url":"https://api.github.com/users/jogoussard/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T14:15:45Z","updated_at":"2018-11-15T14:15:45Z","author_association":"NONE","body":"Of course, if you agree with the fix, I can take care of the PR."}}
{"actor":{"display_login":"jogoussard"}}