{"action":"created","comment":{"url":"https://api.github.com/repos/dg/dibi/pulls/comments/200690449","pull_request_review_id":135060539,"id":200690449,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDY5MDQ0OQ==","diff_hunk":"@@ -89,31 +89,44 @@ public function disconnect(): void\n \t */\n \tpublic function query(string $sql): ?Dibi\\ResultDriver\n \t{\n-\t\t$res = $this->connection->query($sql);\n-\t\tif ($res) {\n-\t\t\t$this->affectedRows = $res->rowCount();\n-\t\t\treturn $res->columnCount() ? $this->createResultDriver($res) : null;\n+\t\ttry {\n+\t\t\t$res = $this->connection->query($sql);\n+\n+\t\t\tif ($res) {\n+\t\t\t\t$this->affectedRows = $res->rowCount();\n+\t\t\t\treturn $res->columnCount() ? $this->createResultDriver($res) : null;\n+\t\t\t}\n+\n+\t\t} catch (\\PDOException $pdoException) {\n+\t\t\t$this->affectedRows = null;\n+\t\t\tthrow $this->createException($pdoException->errorInfo, $sql, $pdoException);","path":"src/Dibi/Drivers/PdoDriver.php","position":18,"original_position":18,"commit_id":"1472f06d1198860755b0bb258e3bea8528669f34","original_commit_id":"411ce51cf27f0afe647c1564564baf2e29e59753","user":{"login":"jkuchar","id":133822,"node_id":"MDQ6VXNlcjEzMzgyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/133822?v=4","gravatar_id":"","url":"https://api.github.com/users/jkuchar","html_url":"https://github.com/jkuchar","followers_url":"https://api.github.com/users/jkuchar/followers","following_url":"https://api.github.com/users/jkuchar/following{/other_user}","gists_url":"https://api.github.com/users/jkuchar/gists{/gist_id}","starred_url":"https://api.github.com/users/jkuchar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkuchar/subscriptions","organizations_url":"https://api.github.com/users/jkuchar/orgs","repos_url":"https://api.github.com/users/jkuchar/repos","events_url":"https://api.github.com/users/jkuchar/events{/privacy}","received_events_url":"https://api.github.com/users/jkuchar/received_events","type":"User","site_admin":false},"body":"Hmm, as it is implementation detail, no code ever should depend on that. Gonna remove that","created_at":"2018-07-06T15:33:41Z","updated_at":"2018-07-06T15:33:42Z","html_url":"https://github.com/dg/dibi/pull/293#discussion_r200690449","pull_request_url":"https://api.github.com/repos/dg/dibi/pulls/293","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dg/dibi/pulls/comments/200690449"},"html":{"href":"https://github.com/dg/dibi/pull/293#discussion_r200690449"},"pull_request":{"href":"https://api.github.com/repos/dg/dibi/pulls/293"}},"in_reply_to_id":194397241},"pull_request":{"url":"https://api.github.com/repos/dg/dibi/pulls/293","id":193972817,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzOTcyODE3","html_url":"https://github.com/dg/dibi/pull/293","diff_url":"https://github.com/dg/dibi/pull/293.diff","patch_url":"https://github.com/dg/dibi/pull/293.patch","issue_url":"https://api.github.com/repos/dg/dibi/issues/293","number":293,"state":"open","locked":false,"title":"PdoDriver: fix pdo connection in exception mode (target >=4.1.0)","user":{"login":"jkuchar","id":133822,"node_id":"MDQ6VXNlcjEzMzgyMg==","avatar_url":"https://avatars3.githubusercontent.com/u/133822?v=4","gravatar_id":"","url":"https://api.github.com/users/jkuchar","html_url":"https://github.com/jkuchar","followers_url":"https://api.github.com/users/jkuchar/followers","following_url":"https://api.github.com/users/jkuchar/following{/other_user}","gists_url":"https://api.github.com/users/jkuchar/gists{/gist_id}","starred_url":"https://api.github.com/users/jkuchar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkuchar/subscriptions","organizations_url":"https://api.github.com/users/jkuchar/orgs","repos_url":"https://api.github.com/users/jkuchar/repos","events_url":"https://api.github.com/users/jkuchar/events{/privacy}","received_events_url":"https://api.github.com/users/jkuchar/received_events","type":"User","site_admin":false},"body":"- new feature\r\n- BC break? no (as original behaviour should be considered as broken)\r\n\r\nsee #292 ","created_at":"2018-06-11T12:57:13Z","updated_at":"2018-07-06T15:33:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e54e8390e050815f4be8a17636dc3c02e536d1b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dg/dibi/pulls/293/commits","review_comments_url":"https://api.github.com/repos/dg/dibi/pulls/293/comments","review_comment_url":"https://api.github.com/repos/dg/dibi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dg/dibi/issues/293/comments","statuses_url":"https://api.github.com/repos/dg/dibi/statuses/1472f06d1198860755b0bb258e3bea8528669f34","head":{"label":"grifart:fix-pdo-connection-in-exception-mode","ref":"fix-pdo-connection-in-exception-mode","sha":"1472f06d1198860755b0bb258e3bea8528669f34","user":{"login":"grifart","id":11387879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg3ODc5","avatar_url":"https://avatars3.githubusercontent.com/u/11387879?v=4","gravatar_id":"","url":"https://api.github.com/users/grifart","html_url":"https://github.com/grifart","followers_url":"https://api.github.com/users/grifart/followers","following_url":"https://api.github.com/users/grifart/following{/other_user}","gists_url":"https://api.github.com/users/grifart/gists{/gist_id}","starred_url":"https://api.github.com/users/grifart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grifart/subscriptions","organizations_url":"https://api.github.com/users/grifart/orgs","repos_url":"https://api.github.com/users/grifart/repos","events_url":"https://api.github.com/users/grifart/events{/privacy}","received_events_url":"https://api.github.com/users/grifart/received_events","type":"Organization","site_admin":false},"repo":{"id":136924491,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MjQ0OTE=","name":"dibi","full_name":"grifart/dibi","owner":{"login":"grifart","id":11387879,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzg3ODc5","avatar_url":"https://avatars3.githubusercontent.com/u/11387879?v=4","gravatar_id":"","url":"https://api.github.com/users/grifart","html_url":"https://github.com/grifart","followers_url":"https://api.github.com/users/grifart/followers","following_url":"https://api.github.com/users/grifart/following{/other_user}","gists_url":"https://api.github.com/users/grifart/gists{/gist_id}","starred_url":"https://api.github.com/users/grifart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grifart/subscriptions","organizations_url":"https://api.github.com/users/grifart/orgs","repos_url":"https://api.github.com/users/grifart/repos","events_url":"https://api.github.com/users/grifart/events{/privacy}","received_events_url":"https://api.github.com/users/grifart/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grifart/dibi","description":"Dibi - smart database abstraction layer","fork":true,"url":"https://api.github.com/repos/grifart/dibi","forks_url":"https://api.github.com/repos/grifart/dibi/forks","keys_url":"https://api.github.com/repos/grifart/dibi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grifart/dibi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grifart/dibi/teams","hooks_url":"https://api.github.com/repos/grifart/dibi/hooks","issue_events_url":"https://api.github.com/repos/grifart/dibi/issues/events{/number}","events_url":"https://api.github.com/repos/grifart/dibi/events","assignees_url":"https://api.github.com/repos/grifart/dibi/assignees{/user}","branches_url":"https://api.github.com/repos/grifart/dibi/branches{/branch}","tags_url":"https://api.github.com/repos/grifart/dibi/tags","blobs_url":"https://api.github.com/repos/grifart/dibi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grifart/dibi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grifart/dibi/git/refs{/sha}","trees_url":"https://api.github.com/repos/grifart/dibi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grifart/dibi/statuses/{sha}","languages_url":"https://api.github.com/repos/grifart/dibi/languages","stargazers_url":"https://api.github.com/repos/grifart/dibi/stargazers","contributors_url":"https://api.github.com/repos/grifart/dibi/contributors","subscribers_url":"https://api.github.com/repos/grifart/dibi/subscribers","subscription_url":"https://api.github.com/repos/grifart/dibi/subscription","commits_url":"https://api.github.com/repos/grifart/dibi/commits{/sha}","git_commits_url":"https://api.github.com/repos/grifart/dibi/git/commits{/sha}","comments_url":"https://api.github.com/repos/grifart/dibi/comments{/number}","issue_comment_url":"https://api.github.com/repos/grifart/dibi/issues/comments{/number}","contents_url":"https://api.github.com/repos/grifart/dibi/contents/{+path}","compare_url":"https://api.github.com/repos/grifart/dibi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grifart/dibi/merges","archive_url":"https://api.github.com/repos/grifart/dibi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grifart/dibi/downloads","issues_url":"https://api.github.com/repos/grifart/dibi/issues{/number}","pulls_url":"https://api.github.com/repos/grifart/dibi/pulls{/number}","milestones_url":"https://api.github.com/repos/grifart/dibi/milestones{/number}","notifications_url":"https://api.github.com/repos/grifart/dibi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grifart/dibi/labels{/name}","releases_url":"https://api.github.com/repos/grifart/dibi/releases{/id}","deployments_url":"https://api.github.com/repos/grifart/dibi/deployments","created_at":"2018-06-11T12:39:44Z","updated_at":"2018-06-11T12:39:47Z","pushed_at":"2018-06-11T13:14:08Z","git_url":"git://github.com/grifart/dibi.git","ssh_url":"git@github.com:grifart/dibi.git","clone_url":"https://github.com/grifart/dibi.git","svn_url":"https://github.com/grifart/dibi","homepage":"https://dibiphp.com","size":3019,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dg:master","ref":"master","sha":"9840c319959ae1d0459152b0d7ae7d1450ed7061","user":{"login":"dg","id":194960,"node_id":"MDQ6VXNlcjE5NDk2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/194960?v=4","gravatar_id":"","url":"https://api.github.com/users/dg","html_url":"https://github.com/dg","followers_url":"https://api.github.com/users/dg/followers","following_url":"https://api.github.com/users/dg/following{/other_user}","gists_url":"https://api.github.com/users/dg/gists{/gist_id}","starred_url":"https://api.github.com/users/dg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg/subscriptions","organizations_url":"https://api.github.com/users/dg/orgs","repos_url":"https://api.github.com/users/dg/repos","events_url":"https://api.github.com/users/dg/events{/privacy}","received_events_url":"https://api.github.com/users/dg/received_events","type":"User","site_admin":false},"repo":{"id":277297,"node_id":"MDEwOlJlcG9zaXRvcnkyNzcyOTc=","name":"dibi","full_name":"dg/dibi","owner":{"login":"dg","id":194960,"node_id":"MDQ6VXNlcjE5NDk2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/194960?v=4","gravatar_id":"","url":"https://api.github.com/users/dg","html_url":"https://github.com/dg","followers_url":"https://api.github.com/users/dg/followers","following_url":"https://api.github.com/users/dg/following{/other_user}","gists_url":"https://api.github.com/users/dg/gists{/gist_id}","starred_url":"https://api.github.com/users/dg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dg/subscriptions","organizations_url":"https://api.github.com/users/dg/orgs","repos_url":"https://api.github.com/users/dg/repos","events_url":"https://api.github.com/users/dg/events{/privacy}","received_events_url":"https://api.github.com/users/dg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dg/dibi","description":"Dibi - smart database abstraction layer","fork":false,"url":"https://api.github.com/repos/dg/dibi","forks_url":"https://api.github.com/repos/dg/dibi/forks","keys_url":"https://api.github.com/repos/dg/dibi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dg/dibi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dg/dibi/teams","hooks_url":"https://api.github.com/repos/dg/dibi/hooks","issue_events_url":"https://api.github.com/repos/dg/dibi/issues/events{/number}","events_url":"https://api.github.com/repos/dg/dibi/events","assignees_url":"https://api.github.com/repos/dg/dibi/assignees{/user}","branches_url":"https://api.github.com/repos/dg/dibi/branches{/branch}","tags_url":"https://api.github.com/repos/dg/dibi/tags","blobs_url":"https://api.github.com/repos/dg/dibi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dg/dibi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dg/dibi/git/refs{/sha}","trees_url":"https://api.github.com/repos/dg/dibi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dg/dibi/statuses/{sha}","languages_url":"https://api.github.com/repos/dg/dibi/languages","stargazers_url":"https://api.github.com/repos/dg/dibi/stargazers","contributors_url":"https://api.github.com/repos/dg/dibi/contributors","subscribers_url":"https://api.github.com/repos/dg/dibi/subscribers","subscription_url":"https://api.github.com/repos/dg/dibi/subscription","commits_url":"https://api.github.com/repos/dg/dibi/commits{/sha}","git_commits_url":"https://api.github.com/repos/dg/dibi/git/commits{/sha}","comments_url":"https://api.github.com/repos/dg/dibi/comments{/number}","issue_comment_url":"https://api.github.com/repos/dg/dibi/issues/comments{/number}","contents_url":"https://api.github.com/repos/dg/dibi/contents/{+path}","compare_url":"https://api.github.com/repos/dg/dibi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dg/dibi/merges","archive_url":"https://api.github.com/repos/dg/dibi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dg/dibi/downloads","issues_url":"https://api.github.com/repos/dg/dibi/issues{/number}","pulls_url":"https://api.github.com/repos/dg/dibi/pulls{/number}","milestones_url":"https://api.github.com/repos/dg/dibi/milestones{/number}","notifications_url":"https://api.github.com/repos/dg/dibi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dg/dibi/labels{/name}","releases_url":"https://api.github.com/repos/dg/dibi/releases{/id}","deployments_url":"https://api.github.com/repos/dg/dibi/deployments","created_at":"2009-08-13T20:17:06Z","updated_at":"2018-06-28T12:25:23Z","pushed_at":"2018-06-28T12:25:21Z","git_url":"git://github.com/dg/dibi.git","ssh_url":"git@github.com:dg/dibi.git","clone_url":"https://github.com/dg/dibi.git","svn_url":"https://github.com/dg/dibi","homepage":"https://dibiphp.com","size":3017,"stargazers_count":279,"watchers_count":279,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":104,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":104,"open_issues":12,"watchers":279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dg/dibi/pulls/293"},"html":{"href":"https://github.com/dg/dibi/pull/293"},"issue":{"href":"https://api.github.com/repos/dg/dibi/issues/293"},"comments":{"href":"https://api.github.com/repos/dg/dibi/issues/293/comments"},"review_comments":{"href":"https://api.github.com/repos/dg/dibi/pulls/293/comments"},"review_comment":{"href":"https://api.github.com/repos/dg/dibi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dg/dibi/pulls/293/commits"},"statuses":{"href":"https://api.github.com/repos/dg/dibi/statuses/1472f06d1198860755b0bb258e3bea8528669f34"}},"author_association":"NONE"}}
{"actor":{"display_login":"jkuchar"}}