{"action":"created","comment":{"url":"https://api.github.com/repos/snowleopard/alga/pulls/comments/219704591","pull_request_review_id":157944928,"id":219704591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTcwNDU5MQ==","diff_hunk":"@@ -1000,8 +986,9 @@ simple op x y\n box :: Graph a -> Graph b -> Graph (a, b)\n box x y = overlays $ xs ++ ys\n   where\n-    xs = map (\\b -> fmap (,b) x) $ toList y\n-    ys = map (\\a -> fmap (a,) y) $ toList x\n+    xs = map (\\b -> fmap (,b) x) $ toListGr y\n+    ys = map (\\a -> fmap (a,) y) $ toListGr x\n+    toListGr = foldg [] pure (++) (++)","path":"src/Algebra/Graph.hs","position":64,"original_position":64,"commit_id":"20182fb104104dae38728aac08d2f7ba94176687","original_commit_id":"20182fb104104dae38728aac08d2f7ba94176687","user":{"login":"snowleopard","id":675286,"node_id":"MDQ6VXNlcjY3NTI4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/675286?v=4","gravatar_id":"","url":"https://api.github.com/users/snowleopard","html_url":"https://github.com/snowleopard","followers_url":"https://api.github.com/users/snowleopard/followers","following_url":"https://api.github.com/users/snowleopard/following{/other_user}","gists_url":"https://api.github.com/users/snowleopard/gists{/gist_id}","starred_url":"https://api.github.com/users/snowleopard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowleopard/subscriptions","organizations_url":"https://api.github.com/users/snowleopard/orgs","repos_url":"https://api.github.com/users/snowleopard/repos","events_url":"https://api.github.com/users/snowleopard/events{/privacy}","received_events_url":"https://api.github.com/users/snowleopard/received_events","type":"User","site_admin":false},"body":"I suggest to use the name `toList` since the function is equivalent to the standard `toList`.\r\n\r\nBy the way, are you sure this is fast enough? Do we need to worry about potential quadratic list concatenation?\r\n\r\nYou might want to use `Algebra.Graph.Internal.List` instead to achieve constant-time list concatenation.\r\n\r\n","created_at":"2018-09-23T16:51:40Z","updated_at":"2018-09-23T16:51:40Z","html_url":"https://github.com/snowleopard/alga/pull/121#discussion_r219704591","pull_request_url":"https://api.github.com/repos/snowleopard/alga/pulls/121","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/snowleopard/alga/pulls/comments/219704591"},"html":{"href":"https://github.com/snowleopard/alga/pull/121#discussion_r219704591"},"pull_request":{"href":"https://api.github.com/repos/snowleopard/alga/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/snowleopard/alga/pulls/121","id":217510728,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTEwNzI4","html_url":"https://github.com/snowleopard/alga/pull/121","diff_url":"https://github.com/snowleopard/alga/pull/121.diff","patch_url":"https://github.com/snowleopard/alga/pull/121.patch","issue_url":"https://api.github.com/repos/snowleopard/alga/issues/121","number":121,"state":"open","locked":false,"title":"Remove foldable","user":{"login":"nobrakal","id":6417395,"node_id":"MDQ6VXNlcjY0MTczOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6417395?v=4","gravatar_id":"","url":"https://api.github.com/users/nobrakal","html_url":"https://github.com/nobrakal","followers_url":"https://api.github.com/users/nobrakal/followers","following_url":"https://api.github.com/users/nobrakal/following{/other_user}","gists_url":"https://api.github.com/users/nobrakal/gists{/gist_id}","starred_url":"https://api.github.com/users/nobrakal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobrakal/subscriptions","organizations_url":"https://api.github.com/users/nobrakal/orgs","repos_url":"https://api.github.com/users/nobrakal/repos","events_url":"https://api.github.com/users/nobrakal/events{/privacy}","received_events_url":"https://api.github.com/users/nobrakal/received_events","type":"User","site_admin":false},"body":"This is related to #95 \r\n\r\nSo:\r\n\r\n* It removes `Foldable` and `Traversable` instance from concerned Graph data-types.\r\n* It removes comments related to `Foldable` instances.\r\n* It drops `isEmpty`, `hasVertex`, `vertexCount`, `vertexList`, `vertexSet`, `vertexIntSet` and `box` from `Algebra.Graph.HigherKinded.Class` because of the removal of the `Foldable` constraint. `mesh` and ` torus` were rewrited without `box`.\r\n* I don't really know what is happening in `Algebra.Graph.Labelled` but I had to add a `foldgUnDiff` and a real `hasVertex` (because `elem` was used previously).\r\n* I added a comment related to the `Foldable` instance in `Algebra.Graph.ToGraph` (I don't know if it is in the right module).\r\n","created_at":"2018-09-23T13:47:53Z","updated_at":"2018-09-23T16:51:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"030f39f553ec1b732d4309407ddba17ee7f7e699","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snowleopard/alga/pulls/121/commits","review_comments_url":"https://api.github.com/repos/snowleopard/alga/pulls/121/comments","review_comment_url":"https://api.github.com/repos/snowleopard/alga/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snowleopard/alga/issues/121/comments","statuses_url":"https://api.github.com/repos/snowleopard/alga/statuses/20182fb104104dae38728aac08d2f7ba94176687","head":{"label":"nobrakal:removeFoldable","ref":"removeFoldable","sha":"20182fb104104dae38728aac08d2f7ba94176687","user":{"login":"nobrakal","id":6417395,"node_id":"MDQ6VXNlcjY0MTczOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6417395?v=4","gravatar_id":"","url":"https://api.github.com/users/nobrakal","html_url":"https://github.com/nobrakal","followers_url":"https://api.github.com/users/nobrakal/followers","following_url":"https://api.github.com/users/nobrakal/following{/other_user}","gists_url":"https://api.github.com/users/nobrakal/gists{/gist_id}","starred_url":"https://api.github.com/users/nobrakal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobrakal/subscriptions","organizations_url":"https://api.github.com/users/nobrakal/orgs","repos_url":"https://api.github.com/users/nobrakal/repos","events_url":"https://api.github.com/users/nobrakal/events{/privacy}","received_events_url":"https://api.github.com/users/nobrakal/received_events","type":"User","site_admin":false},"repo":{"id":132659096,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI2NTkwOTY=","name":"alga","full_name":"nobrakal/alga","private":false,"owner":{"login":"nobrakal","id":6417395,"node_id":"MDQ6VXNlcjY0MTczOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6417395?v=4","gravatar_id":"","url":"https://api.github.com/users/nobrakal","html_url":"https://github.com/nobrakal","followers_url":"https://api.github.com/users/nobrakal/followers","following_url":"https://api.github.com/users/nobrakal/following{/other_user}","gists_url":"https://api.github.com/users/nobrakal/gists{/gist_id}","starred_url":"https://api.github.com/users/nobrakal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nobrakal/subscriptions","organizations_url":"https://api.github.com/users/nobrakal/orgs","repos_url":"https://api.github.com/users/nobrakal/repos","events_url":"https://api.github.com/users/nobrakal/events{/privacy}","received_events_url":"https://api.github.com/users/nobrakal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nobrakal/alga","description":"Algebraic graphs","fork":true,"url":"https://api.github.com/repos/nobrakal/alga","forks_url":"https://api.github.com/repos/nobrakal/alga/forks","keys_url":"https://api.github.com/repos/nobrakal/alga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nobrakal/alga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nobrakal/alga/teams","hooks_url":"https://api.github.com/repos/nobrakal/alga/hooks","issue_events_url":"https://api.github.com/repos/nobrakal/alga/issues/events{/number}","events_url":"https://api.github.com/repos/nobrakal/alga/events","assignees_url":"https://api.github.com/repos/nobrakal/alga/assignees{/user}","branches_url":"https://api.github.com/repos/nobrakal/alga/branches{/branch}","tags_url":"https://api.github.com/repos/nobrakal/alga/tags","blobs_url":"https://api.github.com/repos/nobrakal/alga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nobrakal/alga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nobrakal/alga/git/refs{/sha}","trees_url":"https://api.github.com/repos/nobrakal/alga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nobrakal/alga/statuses/{sha}","languages_url":"https://api.github.com/repos/nobrakal/alga/languages","stargazers_url":"https://api.github.com/repos/nobrakal/alga/stargazers","contributors_url":"https://api.github.com/repos/nobrakal/alga/contributors","subscribers_url":"https://api.github.com/repos/nobrakal/alga/subscribers","subscription_url":"https://api.github.com/repos/nobrakal/alga/subscription","commits_url":"https://api.github.com/repos/nobrakal/alga/commits{/sha}","git_commits_url":"https://api.github.com/repos/nobrakal/alga/git/commits{/sha}","comments_url":"https://api.github.com/repos/nobrakal/alga/comments{/number}","issue_comment_url":"https://api.github.com/repos/nobrakal/alga/issues/comments{/number}","contents_url":"https://api.github.com/repos/nobrakal/alga/contents/{+path}","compare_url":"https://api.github.com/repos/nobrakal/alga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nobrakal/alga/merges","archive_url":"https://api.github.com/repos/nobrakal/alga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nobrakal/alga/downloads","issues_url":"https://api.github.com/repos/nobrakal/alga/issues{/number}","pulls_url":"https://api.github.com/repos/nobrakal/alga/pulls{/number}","milestones_url":"https://api.github.com/repos/nobrakal/alga/milestones{/number}","notifications_url":"https://api.github.com/repos/nobrakal/alga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nobrakal/alga/labels{/name}","releases_url":"https://api.github.com/repos/nobrakal/alga/releases{/id}","deployments_url":"https://api.github.com/repos/nobrakal/alga/deployments","created_at":"2018-05-08T20:06:59Z","updated_at":"2018-05-08T20:16:08Z","pushed_at":"2018-09-23T13:50:24Z","git_url":"git://github.com/nobrakal/alga.git","ssh_url":"git@github.com:nobrakal/alga.git","clone_url":"https://github.com/nobrakal/alga.git","svn_url":"https://github.com/nobrakal/alga","homepage":"","size":972,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snowleopard:master","ref":"master","sha":"891c88a96f4e075ac6ce9e3c6ffd4c4685f95666","user":{"login":"snowleopard","id":675286,"node_id":"MDQ6VXNlcjY3NTI4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/675286?v=4","gravatar_id":"","url":"https://api.github.com/users/snowleopard","html_url":"https://github.com/snowleopard","followers_url":"https://api.github.com/users/snowleopard/followers","following_url":"https://api.github.com/users/snowleopard/following{/other_user}","gists_url":"https://api.github.com/users/snowleopard/gists{/gist_id}","starred_url":"https://api.github.com/users/snowleopard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowleopard/subscriptions","organizations_url":"https://api.github.com/users/snowleopard/orgs","repos_url":"https://api.github.com/users/snowleopard/repos","events_url":"https://api.github.com/users/snowleopard/events{/privacy}","received_events_url":"https://api.github.com/users/snowleopard/received_events","type":"User","site_admin":false},"repo":{"id":75574031,"node_id":"MDEwOlJlcG9zaXRvcnk3NTU3NDAzMQ==","name":"alga","full_name":"snowleopard/alga","private":false,"owner":{"login":"snowleopard","id":675286,"node_id":"MDQ6VXNlcjY3NTI4Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/675286?v=4","gravatar_id":"","url":"https://api.github.com/users/snowleopard","html_url":"https://github.com/snowleopard","followers_url":"https://api.github.com/users/snowleopard/followers","following_url":"https://api.github.com/users/snowleopard/following{/other_user}","gists_url":"https://api.github.com/users/snowleopard/gists{/gist_id}","starred_url":"https://api.github.com/users/snowleopard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowleopard/subscriptions","organizations_url":"https://api.github.com/users/snowleopard/orgs","repos_url":"https://api.github.com/users/snowleopard/repos","events_url":"https://api.github.com/users/snowleopard/events{/privacy}","received_events_url":"https://api.github.com/users/snowleopard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/snowleopard/alga","description":"Algebraic graphs","fork":false,"url":"https://api.github.com/repos/snowleopard/alga","forks_url":"https://api.github.com/repos/snowleopard/alga/forks","keys_url":"https://api.github.com/repos/snowleopard/alga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snowleopard/alga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snowleopard/alga/teams","hooks_url":"https://api.github.com/repos/snowleopard/alga/hooks","issue_events_url":"https://api.github.com/repos/snowleopard/alga/issues/events{/number}","events_url":"https://api.github.com/repos/snowleopard/alga/events","assignees_url":"https://api.github.com/repos/snowleopard/alga/assignees{/user}","branches_url":"https://api.github.com/repos/snowleopard/alga/branches{/branch}","tags_url":"https://api.github.com/repos/snowleopard/alga/tags","blobs_url":"https://api.github.com/repos/snowleopard/alga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snowleopard/alga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snowleopard/alga/git/refs{/sha}","trees_url":"https://api.github.com/repos/snowleopard/alga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snowleopard/alga/statuses/{sha}","languages_url":"https://api.github.com/repos/snowleopard/alga/languages","stargazers_url":"https://api.github.com/repos/snowleopard/alga/stargazers","contributors_url":"https://api.github.com/repos/snowleopard/alga/contributors","subscribers_url":"https://api.github.com/repos/snowleopard/alga/subscribers","subscription_url":"https://api.github.com/repos/snowleopard/alga/subscription","commits_url":"https://api.github.com/repos/snowleopard/alga/commits{/sha}","git_commits_url":"https://api.github.com/repos/snowleopard/alga/git/commits{/sha}","comments_url":"https://api.github.com/repos/snowleopard/alga/comments{/number}","issue_comment_url":"https://api.github.com/repos/snowleopard/alga/issues/comments{/number}","contents_url":"https://api.github.com/repos/snowleopard/alga/contents/{+path}","compare_url":"https://api.github.com/repos/snowleopard/alga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snowleopard/alga/merges","archive_url":"https://api.github.com/repos/snowleopard/alga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snowleopard/alga/downloads","issues_url":"https://api.github.com/repos/snowleopard/alga/issues{/number}","pulls_url":"https://api.github.com/repos/snowleopard/alga/pulls{/number}","milestones_url":"https://api.github.com/repos/snowleopard/alga/milestones{/number}","notifications_url":"https://api.github.com/repos/snowleopard/alga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snowleopard/alga/labels{/name}","releases_url":"https://api.github.com/repos/snowleopard/alga/releases{/id}","deployments_url":"https://api.github.com/repos/snowleopard/alga/deployments","created_at":"2016-12-05T00:30:03Z","updated_at":"2018-09-22T02:20:22Z","pushed_at":"2018-09-23T13:50:26Z","git_url":"git://github.com/snowleopard/alga.git","ssh_url":"git@github.com:snowleopard/alga.git","clone_url":"https://github.com/snowleopard/alga.git","svn_url":"https://github.com/snowleopard/alga","homepage":"","size":862,"stargazers_count":327,"watchers_count":327,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":27,"watchers":327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snowleopard/alga/pulls/121"},"html":{"href":"https://github.com/snowleopard/alga/pull/121"},"issue":{"href":"https://api.github.com/repos/snowleopard/alga/issues/121"},"comments":{"href":"https://api.github.com/repos/snowleopard/alga/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/snowleopard/alga/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/snowleopard/alga/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snowleopard/alga/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/snowleopard/alga/statuses/20182fb104104dae38728aac08d2f7ba94176687"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"snowleopard"}}