{"action":"opened","number":35861,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/35861","id":233227042,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjI3MDQy","html_url":"https://github.com/elastic/elasticsearch/pull/35861","diff_url":"https://github.com/elastic/elasticsearch/pull/35861.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/35861.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/35861","number":35861,"state":"open","locked":false,"title":"Introducing testing conventions task","user":{"login":"atorok","id":2565652,"node_id":"MDQ6VXNlcjI1NjU2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2565652?v=4","gravatar_id":"","url":"https://api.github.com/users/atorok","html_url":"https://github.com/atorok","followers_url":"https://api.github.com/users/atorok/followers","following_url":"https://api.github.com/users/atorok/following{/other_user}","gists_url":"https://api.github.com/users/atorok/gists{/gist_id}","starred_url":"https://api.github.com/users/atorok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atorok/subscriptions","organizations_url":"https://api.github.com/users/atorok/orgs","repos_url":"https://api.github.com/users/atorok/repos","events_url":"https://api.github.com/users/atorok/events{/privacy}","received_events_url":"https://api.github.com/users/atorok/received_events","type":"User","site_admin":false},"body":"This is in the context of #33524 and #34820 and an annoyance I had with running these checks as a separate process. \r\n\r\nThis PR introduces a new task meant to replace  `NamingConventionsCheck` and `NamingConventionsTask`. \r\nIn the interest of keeping the PR small it does not do so yet, but the goal is to have all the checks implemented here. \r\nThese checks will be added as follow ups and we will eventually replace the old tasks with the new porting the existing tests to the new task.\r\n\r\nThere are small changes in the way the checks are done, like looking for method naming connections and methods annotated with `@Test`.  \r\n\r\nThe advantage of doing this in Gradle is speed and the ability to gather insights. \r\nThis will allow us to do things like  auto disable testing tasks if all tests are muted. \r\n\r\nWe call the same reflection methods multiple times, like getting the methods of a class multiple times to keep what's being checked for more readable.","created_at":"2018-11-23T15:13:29Z","updated_at":"2018-11-23T15:13:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":106454670,"node_id":"MDU6TGFiZWwxMDY0NTQ2NzA=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Core/Infra/Build","name":":Core/Infra/Build","color":"0e8a16","default":false},{"id":73544,"node_id":"MDU6TGFiZWw3MzU0NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Enon-issue","name":">non-issue","color":"cfcfcf","default":false},{"id":1102494662,"node_id":"MDU6TGFiZWwxMTAyNDk0NjYy","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.6.0","name":"v6.6.0","color":"dddddd","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/35861/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/35861/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/35861/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/5e64218fc32f9ec2fe969c83faacfe6436c0d0b5","head":{"label":"atorok:testing-conventions-task","ref":"testing-conventions-task","sha":"5e64218fc32f9ec2fe969c83faacfe6436c0d0b5","user":{"login":"atorok","id":2565652,"node_id":"MDQ6VXNlcjI1NjU2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2565652?v=4","gravatar_id":"","url":"https://api.github.com/users/atorok","html_url":"https://github.com/atorok","followers_url":"https://api.github.com/users/atorok/followers","following_url":"https://api.github.com/users/atorok/following{/other_user}","gists_url":"https://api.github.com/users/atorok/gists{/gist_id}","starred_url":"https://api.github.com/users/atorok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atorok/subscriptions","organizations_url":"https://api.github.com/users/atorok/orgs","repos_url":"https://api.github.com/users/atorok/repos","events_url":"https://api.github.com/users/atorok/events{/privacy}","received_events_url":"https://api.github.com/users/atorok/received_events","type":"User","site_admin":false},"repo":{"id":131942558,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5NDI1NTg=","name":"elasticsearch","full_name":"atorok/elasticsearch","private":false,"owner":{"login":"atorok","id":2565652,"node_id":"MDQ6VXNlcjI1NjU2NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/2565652?v=4","gravatar_id":"","url":"https://api.github.com/users/atorok","html_url":"https://github.com/atorok","followers_url":"https://api.github.com/users/atorok/followers","following_url":"https://api.github.com/users/atorok/following{/other_user}","gists_url":"https://api.github.com/users/atorok/gists{/gist_id}","starred_url":"https://api.github.com/users/atorok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atorok/subscriptions","organizations_url":"https://api.github.com/users/atorok/orgs","repos_url":"https://api.github.com/users/atorok/repos","events_url":"https://api.github.com/users/atorok/events{/privacy}","received_events_url":"https://api.github.com/users/atorok/received_events","type":"User","site_admin":false},"html_url":"https://github.com/atorok/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/atorok/elasticsearch","forks_url":"https://api.github.com/repos/atorok/elasticsearch/forks","keys_url":"https://api.github.com/repos/atorok/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atorok/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atorok/elasticsearch/teams","hooks_url":"https://api.github.com/repos/atorok/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/atorok/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/atorok/elasticsearch/events","assignees_url":"https://api.github.com/repos/atorok/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/atorok/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/atorok/elasticsearch/tags","blobs_url":"https://api.github.com/repos/atorok/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atorok/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atorok/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/atorok/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atorok/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/atorok/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/atorok/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/atorok/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/atorok/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/atorok/elasticsearch/subscription","commits_url":"https://api.github.com/repos/atorok/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/atorok/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/atorok/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/atorok/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/atorok/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/atorok/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atorok/elasticsearch/merges","archive_url":"https://api.github.com/repos/atorok/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atorok/elasticsearch/downloads","issues_url":"https://api.github.com/repos/atorok/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/atorok/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/atorok/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/atorok/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atorok/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/atorok/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/atorok/elasticsearch/deployments","created_at":"2018-05-03T04:41:40Z","updated_at":"2018-05-03T04:42:22Z","pushed_at":"2018-11-23T15:01:12Z","git_url":"git://github.com/atorok/elasticsearch.git","ssh_url":"git@github.com:atorok/elasticsearch.git","clone_url":"https://github.com/atorok/elasticsearch.git","svn_url":"https://github.com/atorok/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":521816,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"a204d1cdff3503d23e4e1f04ed1fc67cd919378a","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2018-11-23T14:18:06Z","pushed_at":"2018-11-23T15:06:58Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":533584,"stargazers_count":36246,"watchers_count":36246,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12250,"mirror_url":null,"archived":false,"open_issues_count":1818,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12250,"open_issues":1818,"watchers":36246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/35861"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/35861"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/35861"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/35861/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/35861/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/35861/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/5e64218fc32f9ec2fe969c83faacfe6436c0d0b5"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":301,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"atorok"}}