{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico/pulls/comments/221241616","pull_request_review_id":159844908,"id":221241616,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTI0MTYxNg==","diff_hunk":"@@ -335,3 +335,36 @@ There are two annotations to request a specific IP address:\n > - You can only specify one IPv4/IPv6 or one IPv4 and one IPv6 address with these annotations.\n > - When `ipAddrs` or `ipAddrsNoIpam` is used with `ipv4pools` or `ipv6pools`, `ipAddrs` / `ipAddrsNoIpam` take priority.\n {: .alert .alert-info}\n+\n+#### Requesting a floating IP\n+\n+You can request a floating IP address for a pod through [Kubernetes annotations](https://kubernetes.io/docs/user-guide/annotations/) with {{site.prodname}}.\n+\n+- `cni.projectcalico.org/floatingIPs`: A list of floating IPs which will be assigned to the pod's workload endpoint.\n+\n+  Example:\n+\n+   ```yaml\n+   annotations:\n+        \"cni.projectcalico.org/floatingIPs\": \"[\\\"10.0.0.1\\\"]\"","path":"master/reference/cni-plugin/configuration.md","position":24,"original_position":24,"commit_id":"4b9562a194eed4fc2facbcc329d261452e0c8b61","original_commit_id":"4b9562a194eed4fc2facbcc329d261452e0c8b61","user":{"login":"neiljerram","id":2089263,"node_id":"MDQ6VXNlcjIwODkyNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2089263?v=4","gravatar_id":"","url":"https://api.github.com/users/neiljerram","html_url":"https://github.com/neiljerram","followers_url":"https://api.github.com/users/neiljerram/followers","following_url":"https://api.github.com/users/neiljerram/following{/other_user}","gists_url":"https://api.github.com/users/neiljerram/gists{/gist_id}","starred_url":"https://api.github.com/users/neiljerram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neiljerram/subscriptions","organizations_url":"https://api.github.com/users/neiljerram/orgs","repos_url":"https://api.github.com/users/neiljerram/repos","events_url":"https://api.github.com/users/neiljerram/events{/privacy}","received_events_url":"https://api.github.com/users/neiljerram/received_events","type":"User","site_admin":false},"body":"The quoting and escaping here looks surprisingly complex for YAML.  Are you sure that it is correct?","created_at":"2018-09-28T12:51:28Z","updated_at":"2018-09-28T12:52:58Z","html_url":"https://github.com/projectcalico/calico/pull/2213#discussion_r221241616","pull_request_url":"https://api.github.com/repos/projectcalico/calico/pulls/2213","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/comments/221241616"},"html":{"href":"https://github.com/projectcalico/calico/pull/2213#discussion_r221241616"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/2213"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico/pulls/2213","id":218806588,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODA2NTg4","html_url":"https://github.com/projectcalico/calico/pull/2213","diff_url":"https://github.com/projectcalico/calico/pull/2213.diff","patch_url":"https://github.com/projectcalico/calico/pull/2213.patch","issue_url":"https://api.github.com/repos/projectcalico/calico/issues/2213","number":2213,"state":"open","locked":false,"title":"Add docs for k8s floating IP support","user":{"login":"caseydavenport","id":1944093,"node_id":"MDQ6VXNlcjE5NDQwOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1944093?v=4","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n<!-- A few sentences describing the overall goals of the pull request's commits.\r\nPlease include\r\n- the type of fix - (e.g. bug fix, new feature, documentation)\r\n- some details on _why_ this PR should be merged\r\n- the details of the testing you've done on it (both manual and automated)\r\n- which components are affected by this PR\r\n- links to issues that this PR addresses\r\n-->\r\n\r\nAdds docs for https://github.com/projectcalico/cni-plugin/pull/605 and https://github.com/projectcalico/cni-plugin/pull/605\r\n\r\n\r\n## Todos\r\n\r\n- [ ] Tests\r\n- [ ] Documentation\r\n- [ ] Release note\r\n\r\n## Release Note\r\n\r\n<!-- Writing a release note:\r\n- By default, no release note action is required.\r\n- If you're unsure whether or not your PR needs a note, ask your reviewer for guidance.\r\n- If this PR requires a release note, update the block below to include a concise note describing\r\n  the change and any important impacts this PR may have.\r\n-->\r\n\r\n```release-note\r\nNone required\r\n```\r\n","created_at":"2018-09-27T22:28:38Z","updated_at":"2018-09-28T12:52:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa63f9cc135dea1531260ba13dc5e9ba296f5005","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/projectcalico/calico/milestones/48","html_url":"https://github.com/projectcalico/calico/milestone/48","labels_url":"https://api.github.com/repos/projectcalico/calico/milestones/48/labels","id":3561293,"node_id":"MDk6TWlsZXN0b25lMzU2MTI5Mw==","number":48,"title":"Calico v3.3.0","description":"Issues and PRs being considered for Calico v3.3.0","creator":{"login":"fasaxc","id":469264,"node_id":"MDQ6VXNlcjQ2OTI2NA==","avatar_url":"https://avatars0.githubusercontent.com/u/469264?v=4","gravatar_id":"","url":"https://api.github.com/users/fasaxc","html_url":"https://github.com/fasaxc","followers_url":"https://api.github.com/users/fasaxc/followers","following_url":"https://api.github.com/users/fasaxc/following{/other_user}","gists_url":"https://api.github.com/users/fasaxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fasaxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fasaxc/subscriptions","organizations_url":"https://api.github.com/users/fasaxc/orgs","repos_url":"https://api.github.com/users/fasaxc/repos","events_url":"https://api.github.com/users/fasaxc/events{/privacy}","received_events_url":"https://api.github.com/users/fasaxc/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2018-08-10T15:55:50Z","updated_at":"2018-09-27T22:28:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/projectcalico/calico/pulls/2213/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico/pulls/2213/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico/issues/2213/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico/statuses/4b9562a194eed4fc2facbcc329d261452e0c8b61","head":{"label":"caseydavenport:floating-ips","ref":"floating-ips","sha":"4b9562a194eed4fc2facbcc329d261452e0c8b61","user":{"login":"caseydavenport","id":1944093,"node_id":"MDQ6VXNlcjE5NDQwOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1944093?v=4","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"repo":{"id":70421342,"node_id":"MDEwOlJlcG9zaXRvcnk3MDQyMTM0Mg==","name":"calico","full_name":"caseydavenport/calico","private":false,"owner":{"login":"caseydavenport","id":1944093,"node_id":"MDQ6VXNlcjE5NDQwOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1944093?v=4","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"html_url":"https://github.com/caseydavenport/calico","description":"Documentation and guides for Calico","fork":true,"url":"https://api.github.com/repos/caseydavenport/calico","forks_url":"https://api.github.com/repos/caseydavenport/calico/forks","keys_url":"https://api.github.com/repos/caseydavenport/calico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caseydavenport/calico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caseydavenport/calico/teams","hooks_url":"https://api.github.com/repos/caseydavenport/calico/hooks","issue_events_url":"https://api.github.com/repos/caseydavenport/calico/issues/events{/number}","events_url":"https://api.github.com/repos/caseydavenport/calico/events","assignees_url":"https://api.github.com/repos/caseydavenport/calico/assignees{/user}","branches_url":"https://api.github.com/repos/caseydavenport/calico/branches{/branch}","tags_url":"https://api.github.com/repos/caseydavenport/calico/tags","blobs_url":"https://api.github.com/repos/caseydavenport/calico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caseydavenport/calico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caseydavenport/calico/git/refs{/sha}","trees_url":"https://api.github.com/repos/caseydavenport/calico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caseydavenport/calico/statuses/{sha}","languages_url":"https://api.github.com/repos/caseydavenport/calico/languages","stargazers_url":"https://api.github.com/repos/caseydavenport/calico/stargazers","contributors_url":"https://api.github.com/repos/caseydavenport/calico/contributors","subscribers_url":"https://api.github.com/repos/caseydavenport/calico/subscribers","subscription_url":"https://api.github.com/repos/caseydavenport/calico/subscription","commits_url":"https://api.github.com/repos/caseydavenport/calico/commits{/sha}","git_commits_url":"https://api.github.com/repos/caseydavenport/calico/git/commits{/sha}","comments_url":"https://api.github.com/repos/caseydavenport/calico/comments{/number}","issue_comment_url":"https://api.github.com/repos/caseydavenport/calico/issues/comments{/number}","contents_url":"https://api.github.com/repos/caseydavenport/calico/contents/{+path}","compare_url":"https://api.github.com/repos/caseydavenport/calico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caseydavenport/calico/merges","archive_url":"https://api.github.com/repos/caseydavenport/calico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caseydavenport/calico/downloads","issues_url":"https://api.github.com/repos/caseydavenport/calico/issues{/number}","pulls_url":"https://api.github.com/repos/caseydavenport/calico/pulls{/number}","milestones_url":"https://api.github.com/repos/caseydavenport/calico/milestones{/number}","notifications_url":"https://api.github.com/repos/caseydavenport/calico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caseydavenport/calico/labels{/name}","releases_url":"https://api.github.com/repos/caseydavenport/calico/releases{/id}","deployments_url":"https://api.github.com/repos/caseydavenport/calico/deployments","created_at":"2016-10-09T18:07:04Z","updated_at":"2018-02-20T14:25:30Z","pushed_at":"2018-09-27T22:30:01Z","git_url":"git://github.com/caseydavenport/calico.git","ssh_url":"git@github.com:caseydavenport/calico.git","clone_url":"https://github.com/caseydavenport/calico.git","svn_url":"https://github.com/caseydavenport/calico","homepage":null,"size":22379,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"3981e135a7e62de9b9c1f2203fafdac5f0aa261f","user":{"login":"projectcalico","id":12304728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzA0NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":63882194,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg4MjE5NA==","name":"calico","full_name":"projectcalico/calico","private":false,"owner":{"login":"projectcalico","id":12304728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzA0NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/projectcalico/calico","description":"Cloud native connectivity and network policy","fork":false,"url":"https://api.github.com/repos/projectcalico/calico","forks_url":"https://api.github.com/repos/projectcalico/calico/forks","keys_url":"https://api.github.com/repos/projectcalico/calico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico/events","assignees_url":"https://api.github.com/repos/projectcalico/calico/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico/merges","archive_url":"https://api.github.com/repos/projectcalico/calico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/calico/deployments","created_at":"2016-07-21T15:45:54Z","updated_at":"2018-09-28T12:44:33Z","pushed_at":"2018-09-27T22:30:03Z","git_url":"git://github.com/projectcalico/calico.git","ssh_url":"git@github.com:projectcalico/calico.git","clone_url":"https://github.com/projectcalico/calico.git","svn_url":"https://github.com/projectcalico/calico","homepage":"http://docs.projectcalico.org","size":22520,"stargazers_count":684,"watchers_count":684,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":248,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":248,"open_issues":168,"watchers":684,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/2213"},"html":{"href":"https://github.com/projectcalico/calico/pull/2213"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico/issues/2213"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico/issues/2213/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/2213/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/2213/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico/statuses/4b9562a194eed4fc2facbcc329d261452e0c8b61"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"neiljerram"}}