{"action":"created","issue":{"url":"https://api.github.com/repos/joaotavora/sly/issues/193","repository_url":"https://api.github.com/repos/joaotavora/sly","labels_url":"https://api.github.com/repos/joaotavora/sly/issues/193/labels{/name}","comments_url":"https://api.github.com/repos/joaotavora/sly/issues/193/comments","events_url":"https://api.github.com/repos/joaotavora/sly/issues/193/events","html_url":"https://github.com/joaotavora/sly/pull/193","id":374240489,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTg2NjA4","number":193,"title":"During completion show symbols from the same primary system first","user":{"login":"svetlyak40wt","id":24827,"node_id":"MDQ6VXNlcjI0ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/24827?v=4","gravatar_id":"","url":"https://api.github.com/users/svetlyak40wt","html_url":"https://github.com/svetlyak40wt","followers_url":"https://api.github.com/users/svetlyak40wt/followers","following_url":"https://api.github.com/users/svetlyak40wt/following{/other_user}","gists_url":"https://api.github.com/users/svetlyak40wt/gists{/gist_id}","starred_url":"https://api.github.com/users/svetlyak40wt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svetlyak40wt/subscriptions","organizations_url":"https://api.github.com/users/svetlyak40wt/orgs","repos_url":"https://api.github.com/users/svetlyak40wt/repos","events_url":"https://api.github.com/users/svetlyak40wt/events{/privacy}","received_events_url":"https://api.github.com/users/svetlyak40wt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-10-26T06:12:21Z","updated_at":"2018-10-27T17:46:41Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/joaotavora/sly/pulls/193","html_url":"https://github.com/joaotavora/sly/pull/193","diff_url":"https://github.com/joaotavora/sly/pull/193.diff","patch_url":"https://github.com/joaotavora/sly/pull/193.patch"},"body":"This is extremely useful when you are working on `package-inferred` system\r\nwith large number of packages. For example, working on package `ultralisp/widgets/landing`\r\nI want to complete `get-name` function which is in the `ultralisp/models/user` package.\r\nBefore this commit, autocomplete showed me the relevant result `ultralisp/models/user:get-name`\r\non a `37` position in the list. After this commit, it will be shown on first position,\r\nbecause the symbol is in the same primary system as I'm working on.\r\n\r\nThis change caused a performace degradation on a first call, because now sly has to\r\ncache a mapping `package -> primary system` for every known package."},"comment":{"url":"https://api.github.com/repos/joaotavora/sly/issues/comments/433641081","html_url":"https://github.com/joaotavora/sly/pull/193#issuecomment-433641081","issue_url":"https://api.github.com/repos/joaotavora/sly/issues/193","id":433641081,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzY0MTA4MQ==","user":{"login":"svetlyak40wt","id":24827,"node_id":"MDQ6VXNlcjI0ODI3","avatar_url":"https://avatars2.githubusercontent.com/u/24827?v=4","gravatar_id":"","url":"https://api.github.com/users/svetlyak40wt","html_url":"https://github.com/svetlyak40wt","followers_url":"https://api.github.com/users/svetlyak40wt/followers","following_url":"https://api.github.com/users/svetlyak40wt/following{/other_user}","gists_url":"https://api.github.com/users/svetlyak40wt/gists{/gist_id}","starred_url":"https://api.github.com/users/svetlyak40wt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svetlyak40wt/subscriptions","organizations_url":"https://api.github.com/users/svetlyak40wt/orgs","repos_url":"https://api.github.com/users/svetlyak40wt/repos","events_url":"https://api.github.com/users/svetlyak40wt/events{/privacy}","received_events_url":"https://api.github.com/users/svetlyak40wt/received_events","type":"User","site_admin":false},"created_at":"2018-10-27T17:46:41Z","updated_at":"2018-10-27T17:46:41Z","author_association":"CONTRIBUTOR","body":"Oh, finally, I found the problem! Emacs hangs when it is unable to load lisp part of the contrib.\r\n\r\nYesterday, I've created two files – `sly-package-inferred.el` and `slynk-package-inferred.lisp` in the `contrib` folder. But to make SLY to load lisp part, I needed to add a section into the `slynk.asd` file:\r\n\r\n```\r\n(defsystem :slynk/package-inferred\r\n  :depends-on (:slynk)\r\n  :components ((:file \"../contrib/slynk-package-inferred\")))\r\n```\r\n\r\nMay be it will be good idea somehow catch error on lisp contrib loading and prevent complete hanging of the Emacs.\r\n\r\nAnyway, I'll create a separate repository for the system which make preference for symbols in package inferred systems."}}
{"actor":{"display_login":"svetlyak40wt"}}