{"action":"created","comment":{"url":"https://api.github.com/repos/swaponline/swap.react/pulls/comments/207590696","pull_request_review_id":143239040,"id":207590696,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzU5MDY5Ng==","diff_hunk":"@@ -16,26 +16,19 @@ const Table = ({ titles, rows, rowRender, textIfEmpty }) => (\n       </tr>\n     </thead>\n     <tbody>\n-      {\n-        rows.length > 0 ? (\n-          rows.map((row, rowIndex) => {\n-            if (typeof rowRender === 'function') {\n-              return rowRender(row, rowIndex)\n-            }\n-          })\n-        ) : (\n-          <tr>\n-            <td styleName=\"color\">{textIfEmpty}</td>\n-          </tr>\n-        )\n-      }\n+      { isLoading && <tr><td styleName=\"color\">{loadingText}</td></tr> }\n+      { !isLoading && !rows.length && <tr><td styleName=\"color\">{textIfEmpty}</td></tr> }\n+      { !isLoading && !!rows.length && rows.map((row, rowIndex) => {\n+        return typeof rowRender === 'function' && rowRender(row, rowIndex)\n+      }) }","path":"shared/components/Table/Table.js","position":30,"original_position":30,"commit_id":"8c413c07ecd922c5faf514f54887f4607399747d","original_commit_id":"e74d40cd02750e7343c6f29329d6212d9d4aa036","user":{"login":"nikdementev","id":17093843,"node_id":"MDQ6VXNlcjE3MDkzODQz","avatar_url":"https://avatars1.githubusercontent.com/u/17093843?v=4","gravatar_id":"","url":"https://api.github.com/users/nikdementev","html_url":"https://github.com/nikdementev","followers_url":"https://api.github.com/users/nikdementev/followers","following_url":"https://api.github.com/users/nikdementev/following{/other_user}","gists_url":"https://api.github.com/users/nikdementev/gists{/gist_id}","starred_url":"https://api.github.com/users/nikdementev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikdementev/subscriptions","organizations_url":"https://api.github.com/users/nikdementev/orgs","repos_url":"https://api.github.com/users/nikdementev/repos","events_url":"https://api.github.com/users/nikdementev/events{/privacy}","received_events_url":"https://api.github.com/users/nikdementev/received_events","type":"User","site_admin":false},"body":"1. (https://github.com/airbnb/javascript)[airbnb] я сделаю правила для PR\r\n2. Потому что надо писать хорошо.","created_at":"2018-08-03T15:55:46Z","updated_at":"2018-08-03T15:55:46Z","html_url":"https://github.com/swaponline/swap.react/pull/225#discussion_r207590696","pull_request_url":"https://api.github.com/repos/swaponline/swap.react/pulls/225","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/comments/207590696"},"html":{"href":"https://github.com/swaponline/swap.react/pull/225#discussion_r207590696"},"pull_request":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/225"}},"in_reply_to_id":207477979},"pull_request":{"url":"https://api.github.com/repos/swaponline/swap.react/pulls/225","id":205936586,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1OTM2NTg2","html_url":"https://github.com/swaponline/swap.react/pull/225","diff_url":"https://github.com/swaponline/swap.react/pull/225.diff","patch_url":"https://github.com/swaponline/swap.react/pull/225.patch","issue_url":"https://api.github.com/repos/swaponline/swap.react/issues/225","number":225,"state":"open","locked":false,"title":"не показывать table is empty пока идет загрузка","user":{"login":"indapublic","id":856260,"node_id":"MDQ6VXNlcjg1NjI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/856260?v=4","gravatar_id":"","url":"https://api.github.com/users/indapublic","html_url":"https://github.com/indapublic","followers_url":"https://api.github.com/users/indapublic/followers","following_url":"https://api.github.com/users/indapublic/following{/other_user}","gists_url":"https://api.github.com/users/indapublic/gists{/gist_id}","starred_url":"https://api.github.com/users/indapublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indapublic/subscriptions","organizations_url":"https://api.github.com/users/indapublic/orgs","repos_url":"https://api.github.com/users/indapublic/repos","events_url":"https://api.github.com/users/indapublic/events{/privacy}","received_events_url":"https://api.github.com/users/indapublic/received_events","type":"User","site_admin":false},"body":"Фикс для #164 \r\n\r\n* Был создан отдельный редюсер и экшн для `ipfs` вместо использования `state` от `Footer` (логика соединения осталась в футере как было, с одной стороны не мешает, с другой стороны, может вынести его в другое место)\r\n* Добавлен флаг `isLoading` для `Table`, чтобы показывать плашку загрузки. Пока используется только в `Orders` (добавлена задержка в 1 секунду, потому что пользователь соединяется чуть раньше, чем приходят ордера)\r\n* Небольшой рефакторинг в компоненте `Info`, чтобы имена свойств соответствовали редюсеру","created_at":"2018-08-03T06:26:32Z","updated_at":"2018-08-03T15:55:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7df50bec9006ec6fe706831709e1bbe894702cd8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/swaponline/swap.react/pulls/225/commits","review_comments_url":"https://api.github.com/repos/swaponline/swap.react/pulls/225/comments","review_comment_url":"https://api.github.com/repos/swaponline/swap.react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/swaponline/swap.react/issues/225/comments","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/8c413c07ecd922c5faf514f54887f4607399747d","head":{"label":"indapublic:master","ref":"master","sha":"8c413c07ecd922c5faf514f54887f4607399747d","user":{"login":"indapublic","id":856260,"node_id":"MDQ6VXNlcjg1NjI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/856260?v=4","gravatar_id":"","url":"https://api.github.com/users/indapublic","html_url":"https://github.com/indapublic","followers_url":"https://api.github.com/users/indapublic/followers","following_url":"https://api.github.com/users/indapublic/following{/other_user}","gists_url":"https://api.github.com/users/indapublic/gists{/gist_id}","starred_url":"https://api.github.com/users/indapublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indapublic/subscriptions","organizations_url":"https://api.github.com/users/indapublic/orgs","repos_url":"https://api.github.com/users/indapublic/repos","events_url":"https://api.github.com/users/indapublic/events{/privacy}","received_events_url":"https://api.github.com/users/indapublic/received_events","type":"User","site_admin":false},"repo":{"id":142777712,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3Nzc3MTI=","name":"swap.react","full_name":"indapublic/swap.react","owner":{"login":"indapublic","id":856260,"node_id":"MDQ6VXNlcjg1NjI2MA==","avatar_url":"https://avatars3.githubusercontent.com/u/856260?v=4","gravatar_id":"","url":"https://api.github.com/users/indapublic","html_url":"https://github.com/indapublic","followers_url":"https://api.github.com/users/indapublic/followers","following_url":"https://api.github.com/users/indapublic/following{/other_user}","gists_url":"https://api.github.com/users/indapublic/gists{/gist_id}","starred_url":"https://api.github.com/users/indapublic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indapublic/subscriptions","organizations_url":"https://api.github.com/users/indapublic/orgs","repos_url":"https://api.github.com/users/indapublic/repos","events_url":"https://api.github.com/users/indapublic/events{/privacy}","received_events_url":"https://api.github.com/users/indapublic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indapublic/swap.react","description":"In-browser atomic swap exchange based on swap.core library. It is an implementation of Swap DEP crosschain protocol. Hosted at https://swap.online","fork":true,"url":"https://api.github.com/repos/indapublic/swap.react","forks_url":"https://api.github.com/repos/indapublic/swap.react/forks","keys_url":"https://api.github.com/repos/indapublic/swap.react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indapublic/swap.react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indapublic/swap.react/teams","hooks_url":"https://api.github.com/repos/indapublic/swap.react/hooks","issue_events_url":"https://api.github.com/repos/indapublic/swap.react/issues/events{/number}","events_url":"https://api.github.com/repos/indapublic/swap.react/events","assignees_url":"https://api.github.com/repos/indapublic/swap.react/assignees{/user}","branches_url":"https://api.github.com/repos/indapublic/swap.react/branches{/branch}","tags_url":"https://api.github.com/repos/indapublic/swap.react/tags","blobs_url":"https://api.github.com/repos/indapublic/swap.react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indapublic/swap.react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indapublic/swap.react/git/refs{/sha}","trees_url":"https://api.github.com/repos/indapublic/swap.react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indapublic/swap.react/statuses/{sha}","languages_url":"https://api.github.com/repos/indapublic/swap.react/languages","stargazers_url":"https://api.github.com/repos/indapublic/swap.react/stargazers","contributors_url":"https://api.github.com/repos/indapublic/swap.react/contributors","subscribers_url":"https://api.github.com/repos/indapublic/swap.react/subscribers","subscription_url":"https://api.github.com/repos/indapublic/swap.react/subscription","commits_url":"https://api.github.com/repos/indapublic/swap.react/commits{/sha}","git_commits_url":"https://api.github.com/repos/indapublic/swap.react/git/commits{/sha}","comments_url":"https://api.github.com/repos/indapublic/swap.react/comments{/number}","issue_comment_url":"https://api.github.com/repos/indapublic/swap.react/issues/comments{/number}","contents_url":"https://api.github.com/repos/indapublic/swap.react/contents/{+path}","compare_url":"https://api.github.com/repos/indapublic/swap.react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indapublic/swap.react/merges","archive_url":"https://api.github.com/repos/indapublic/swap.react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indapublic/swap.react/downloads","issues_url":"https://api.github.com/repos/indapublic/swap.react/issues{/number}","pulls_url":"https://api.github.com/repos/indapublic/swap.react/pulls{/number}","milestones_url":"https://api.github.com/repos/indapublic/swap.react/milestones{/number}","notifications_url":"https://api.github.com/repos/indapublic/swap.react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indapublic/swap.react/labels{/name}","releases_url":"https://api.github.com/repos/indapublic/swap.react/releases{/id}","deployments_url":"https://api.github.com/repos/indapublic/swap.react/deployments","created_at":"2018-07-29T16:41:20Z","updated_at":"2018-08-03T06:20:05Z","pushed_at":"2018-08-03T10:51:01Z","git_url":"git://github.com/indapublic/swap.react.git","ssh_url":"git@github.com:indapublic/swap.react.git","clone_url":"https://github.com/indapublic/swap.react.git","svn_url":"https://github.com/indapublic/swap.react","homepage":"https://swap.online","size":9988,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"swaponline:master","ref":"master","sha":"a257a1bfaa36eb2a5a446681113420e022913b4e","user":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"repo":{"id":130675402,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA2NzU0MDI=","name":"swap.react","full_name":"swaponline/swap.react","owner":{"login":"swaponline","id":38111297,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MTExMjk3","avatar_url":"https://avatars3.githubusercontent.com/u/38111297?v=4","gravatar_id":"","url":"https://api.github.com/users/swaponline","html_url":"https://github.com/swaponline","followers_url":"https://api.github.com/users/swaponline/followers","following_url":"https://api.github.com/users/swaponline/following{/other_user}","gists_url":"https://api.github.com/users/swaponline/gists{/gist_id}","starred_url":"https://api.github.com/users/swaponline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swaponline/subscriptions","organizations_url":"https://api.github.com/users/swaponline/orgs","repos_url":"https://api.github.com/users/swaponline/repos","events_url":"https://api.github.com/users/swaponline/events{/privacy}","received_events_url":"https://api.github.com/users/swaponline/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/swaponline/swap.react","description":"In-browser atomic swap exchange based on swap.core library. It is an implementation of Swap DEP crosschain protocol. Hosted at https://swap.online","fork":false,"url":"https://api.github.com/repos/swaponline/swap.react","forks_url":"https://api.github.com/repos/swaponline/swap.react/forks","keys_url":"https://api.github.com/repos/swaponline/swap.react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swaponline/swap.react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swaponline/swap.react/teams","hooks_url":"https://api.github.com/repos/swaponline/swap.react/hooks","issue_events_url":"https://api.github.com/repos/swaponline/swap.react/issues/events{/number}","events_url":"https://api.github.com/repos/swaponline/swap.react/events","assignees_url":"https://api.github.com/repos/swaponline/swap.react/assignees{/user}","branches_url":"https://api.github.com/repos/swaponline/swap.react/branches{/branch}","tags_url":"https://api.github.com/repos/swaponline/swap.react/tags","blobs_url":"https://api.github.com/repos/swaponline/swap.react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swaponline/swap.react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swaponline/swap.react/git/refs{/sha}","trees_url":"https://api.github.com/repos/swaponline/swap.react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swaponline/swap.react/statuses/{sha}","languages_url":"https://api.github.com/repos/swaponline/swap.react/languages","stargazers_url":"https://api.github.com/repos/swaponline/swap.react/stargazers","contributors_url":"https://api.github.com/repos/swaponline/swap.react/contributors","subscribers_url":"https://api.github.com/repos/swaponline/swap.react/subscribers","subscription_url":"https://api.github.com/repos/swaponline/swap.react/subscription","commits_url":"https://api.github.com/repos/swaponline/swap.react/commits{/sha}","git_commits_url":"https://api.github.com/repos/swaponline/swap.react/git/commits{/sha}","comments_url":"https://api.github.com/repos/swaponline/swap.react/comments{/number}","issue_comment_url":"https://api.github.com/repos/swaponline/swap.react/issues/comments{/number}","contents_url":"https://api.github.com/repos/swaponline/swap.react/contents/{+path}","compare_url":"https://api.github.com/repos/swaponline/swap.react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swaponline/swap.react/merges","archive_url":"https://api.github.com/repos/swaponline/swap.react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swaponline/swap.react/downloads","issues_url":"https://api.github.com/repos/swaponline/swap.react/issues{/number}","pulls_url":"https://api.github.com/repos/swaponline/swap.react/pulls{/number}","milestones_url":"https://api.github.com/repos/swaponline/swap.react/milestones{/number}","notifications_url":"https://api.github.com/repos/swaponline/swap.react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swaponline/swap.react/labels{/name}","releases_url":"https://api.github.com/repos/swaponline/swap.react/releases{/id}","deployments_url":"https://api.github.com/repos/swaponline/swap.react/deployments","created_at":"2018-04-23T09:48:44Z","updated_at":"2018-08-03T08:39:53Z","pushed_at":"2018-08-03T12:31:35Z","git_url":"git://github.com/swaponline/swap.react.git","ssh_url":"git@github.com:swaponline/swap.react.git","clone_url":"https://github.com/swaponline/swap.react.git","svn_url":"https://github.com/swaponline/swap.react","homepage":"https://swap.online","size":9986,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":17,"open_issues":39,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/225"},"html":{"href":"https://github.com/swaponline/swap.react/pull/225"},"issue":{"href":"https://api.github.com/repos/swaponline/swap.react/issues/225"},"comments":{"href":"https://api.github.com/repos/swaponline/swap.react/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/swaponline/swap.react/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/swaponline/swap.react/statuses/8c413c07ecd922c5faf514f54887f4607399747d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nikdementev"}}