{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/comments/177915251","pull_request_review_id":107880770,"id":177915251,"diff_hunk":"@@ -12,6 +12,18 @@ import { IIntentProps, IProps } from \"../../common/props\";\n import { clamp } from \"../../common/utils\";\n \n export interface IProgressBarProps extends IProps, IIntentProps {\n+    /**\n+     * Whether the background should animate.\n+     * @default true\n+     */\n+    animate?: boolean;\n+\n+    /**\n+     * Whether the background should be striped.\n+     * @default true\n+     */\n+    stripes?: boolean;","path":"packages/core/src/components/progress/progressBar.tsx","position":14,"original_position":14,"commit_id":"fa1cb91ffb4fc446425e663b055cf7f70757daa5","original_commit_id":"fa1cb91ffb4fc446425e663b055cf7f70757daa5","user":{"login":"llorca","id":199754,"avatar_url":"https://avatars0.githubusercontent.com/u/199754?v=4","gravatar_id":"","url":"https://api.github.com/users/llorca","html_url":"https://github.com/llorca","followers_url":"https://api.github.com/users/llorca/followers","following_url":"https://api.github.com/users/llorca/following{/other_user}","gists_url":"https://api.github.com/users/llorca/gists{/gist_id}","starred_url":"https://api.github.com/users/llorca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llorca/subscriptions","organizations_url":"https://api.github.com/users/llorca/orgs","repos_url":"https://api.github.com/users/llorca/repos","events_url":"https://api.github.com/users/llorca/events{/privacy}","received_events_url":"https://api.github.com/users/llorca/received_events","type":"User","site_admin":false},"body":"what's the new pattern? any modifier class (even non generic) should be mirrored as a prop?","created_at":"2018-03-28T23:05:30Z","updated_at":"2018-03-28T23:05:31Z","html_url":"https://github.com/palantir/blueprint/pull/2329#discussion_r177915251","pull_request_url":"https://api.github.com/repos/palantir/blueprint/pulls/2329","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments/177915251"},"html":{"href":"https://github.com/palantir/blueprint/pull/2329#discussion_r177915251"},"pull_request":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2329"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/2329","id":178187249,"html_url":"https://github.com/palantir/blueprint/pull/2329","diff_url":"https://github.com/palantir/blueprint/pull/2329.diff","patch_url":"https://github.com/palantir/blueprint/pull/2329.patch","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/2329","number":2329,"state":"open","locked":false,"title":"add props for common modifier classes","user":{"login":"giladgray","id":464822,"avatar_url":"https://avatars1.githubusercontent.com/u/464822?v=4","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"body":"reduce reliance on `Classes` constants and `classNames()` library by providing props for supported modifiers on components.","created_at":"2018-03-28T23:00:10Z","updated_at":"2018-03-28T23:05:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd2a2176df4cc6d0b0455f63471d3a7e08bc4bda","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cmslewis","id":443450,"avatar_url":"https://avatars2.githubusercontent.com/u/443450?v=4","gravatar_id":"","url":"https://api.github.com/users/cmslewis","html_url":"https://github.com/cmslewis","followers_url":"https://api.github.com/users/cmslewis/followers","following_url":"https://api.github.com/users/cmslewis/following{/other_user}","gists_url":"https://api.github.com/users/cmslewis/gists{/gist_id}","starred_url":"https://api.github.com/users/cmslewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmslewis/subscriptions","organizations_url":"https://api.github.com/users/cmslewis/orgs","repos_url":"https://api.github.com/users/cmslewis/repos","events_url":"https://api.github.com/users/cmslewis/events{/privacy}","received_events_url":"https://api.github.com/users/cmslewis/received_events","type":"User","site_admin":false},{"login":"themadcreator","id":569364,"avatar_url":"https://avatars2.githubusercontent.com/u/569364?v=4","gravatar_id":"","url":"https://api.github.com/users/themadcreator","html_url":"https://github.com/themadcreator","followers_url":"https://api.github.com/users/themadcreator/followers","following_url":"https://api.github.com/users/themadcreator/following{/other_user}","gists_url":"https://api.github.com/users/themadcreator/gists{/gist_id}","starred_url":"https://api.github.com/users/themadcreator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themadcreator/subscriptions","organizations_url":"https://api.github.com/users/themadcreator/orgs","repos_url":"https://api.github.com/users/themadcreator/repos","events_url":"https://api.github.com/users/themadcreator/events{/privacy}","received_events_url":"https://api.github.com/users/themadcreator/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/blueprint/pulls/2329/commits","review_comments_url":"https://api.github.com/repos/palantir/blueprint/pulls/2329/comments","review_comment_url":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/2329/comments","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/fa1cb91ffb4fc446425e663b055cf7f70757daa5","head":{"label":"palantir:gg/modifier-props","ref":"gg/modifier-props","sha":"fa1cb91ffb4fc446425e663b055cf7f70757daa5","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2018-03-28T20:24:12Z","pushed_at":"2018-03-28T23:00:10Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":63343,"stargazers_count":8743,"watchers_count":8743,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":575,"mirror_url":null,"archived":false,"open_issues_count":244,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":575,"open_issues":244,"watchers":8743,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"970e6d8765bc9adc3db35e45d245dd43b7df85d4","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2018-03-28T20:24:12Z","pushed_at":"2018-03-28T23:00:10Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":63343,"stargazers_count":8743,"watchers_count":8743,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":575,"mirror_url":null,"archived":false,"open_issues_count":244,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":575,"open_issues":244,"watchers":8743,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2329"},"html":{"href":"https://github.com/palantir/blueprint/pull/2329"},"issue":{"href":"https://api.github.com/repos/palantir/blueprint/issues/2329"},"comments":{"href":"https://api.github.com/repos/palantir/blueprint/issues/2329/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2329/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/2329/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/blueprint/statuses/fa1cb91ffb4fc446425e663b055cf7f70757daa5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"llorca"}}