{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16617","repository_url":"https://api.github.com/repos/ethereum/go-ethereum","labels_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16617/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16617/comments","events_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16617/events","html_url":"https://github.com/ethereum/go-ethereum/issues/16617","id":319060426,"number":16617,"title":"Long tx broadcasting delays on geth 1.8.6","user":{"login":"vogelito","id":1325863,"avatar_url":"https://avatars0.githubusercontent.com/u/1325863?v=4","gravatar_id":"","url":"https://api.github.com/users/vogelito","html_url":"https://github.com/vogelito","followers_url":"https://api.github.com/users/vogelito/followers","following_url":"https://api.github.com/users/vogelito/following{/other_user}","gists_url":"https://api.github.com/users/vogelito/gists{/gist_id}","starred_url":"https://api.github.com/users/vogelito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogelito/subscriptions","organizations_url":"https://api.github.com/users/vogelito/orgs","repos_url":"https://api.github.com/users/vogelito/repos","events_url":"https://api.github.com/users/vogelito/events{/privacy}","received_events_url":"https://api.github.com/users/vogelito/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-30T22:41:48Z","updated_at":"2018-05-03T20:26:31Z","closed_at":null,"author_association":"NONE","body":"#### System information\r\n\r\nGeth version:\r\n```\r\nGeth\r\nVersion: 1.8.6-stable\r\nGit Commit: 12683feca7483f0b0bf425c3c520e2724f69f2aa\r\nArchitecture: amd64\r\nProtocol Versions: [63 62]\r\nNetwork Id: 1\r\nGo Version: go1.10\r\nOperating System: linux\r\nGOPATH=\r\nGOROOT=/usr/local/go\r\n```\r\nOS & Version: OSX\r\n\r\n#### Expected behaviour\r\n\r\nAfter calling `eth.sendTransaction`, the local node should immediately broadcast the transaction to other nodes in the network.\r\n\r\n#### Actual behaviour\r\n\r\nAfter upgrading to 1.8.6 (from 1.8.3) we see that our transactions (sent by calling `eth.sendTransaction`) are not seen by other nodes for 15-30 minutes. Our node has peers and it is fully synced.\r\n\r\n#### Steps to reproduce the behaviour\r\n\r\nUnsure, we just upgraded to 1.8.6 and noticed the issue about 32 hours afterwards. We don't have active monitoring for this, so unsure whether the condition degraded or if started happening since the upgrade.\r\n\r\n#### Backtrace\r\nAttaching `debug.stack()` output: [2018.04.30_geth_1.8.6_debug_stacks.log](https://github.com/ethereum/go-ethereum/files/1962393/2018.04.30_geth_1.8.6_debug_stacks.log)\r\n"},"comment":{"url":"https://api.github.com/repos/ethereum/go-ethereum/issues/comments/386425474","html_url":"https://github.com/ethereum/go-ethereum/issues/16617#issuecomment-386425474","issue_url":"https://api.github.com/repos/ethereum/go-ethereum/issues/16617","id":386425474,"user":{"login":"ryanschneider","id":53520,"avatar_url":"https://avatars2.githubusercontent.com/u/53520?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanschneider","html_url":"https://github.com/ryanschneider","followers_url":"https://api.github.com/users/ryanschneider/followers","following_url":"https://api.github.com/users/ryanschneider/following{/other_user}","gists_url":"https://api.github.com/users/ryanschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanschneider/subscriptions","organizations_url":"https://api.github.com/users/ryanschneider/orgs","repos_url":"https://api.github.com/users/ryanschneider/repos","events_url":"https://api.github.com/users/ryanschneider/events{/privacy}","received_events_url":"https://api.github.com/users/ryanschneider/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T20:26:31Z","updated_at":"2018-05-03T20:26:31Z","author_association":"CONTRIBUTOR","body":"Related to #14669.\r\n\r\nI have a code change here https://github.com/ryanschneider/go-ethereum/commit/7b4f6c04dc08bf729e13cbd59c2e398586f3bc5f that we've been running that seems to help.  \r\n\r\nNotice in the debug.stack the large number of `promoteTx` calls with a very long times blocked on `chan receive`.  We were seeing the same issue until we started running with the above commit (and the other changes I mentioned in #14669).\r\n\r\nHowever, of the 3 changes, the one above is definitely the safest, so I'll go ahead and send it as PR and reference this issue."}}
{"actor":{"display_login":"ryanschneider"}}