{"action":"created","issue":{"url":"https://api.github.com/repos/diffblue/cbmc/issues/1914","repository_url":"https://api.github.com/repos/diffblue/cbmc","labels_url":"https://api.github.com/repos/diffblue/cbmc/issues/1914/labels{/name}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1914/comments","events_url":"https://api.github.com/repos/diffblue/cbmc/issues/1914/events","html_url":"https://github.com/diffblue/cbmc/pull/1914","id":302797238,"number":1914,"title":"BMC: support lazy goto model","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars3.githubusercontent.com/u/283483?v=4","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-03-06T17:37:02Z","updated_at":"2018-03-15T10:22:12Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1914","html_url":"https://github.com/diffblue/cbmc/pull/1914","diff_url":"https://github.com/diffblue/cbmc/pull/1914.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1914.patch"},"body":"This introduces `goto_functions_providert`, which an interface that gets function bodies by name (perhaps converting them on demand), then gives a const view of the function map created so far, intended for reporting. It enables us to hide from `bmct` whether we're using plain old `goto_functionst` or `lazy_goto_modelt`.\r\n\r\nAlternative to https://github.com/diffblue/cbmc/pull/1904, which tried harder to avoid use of `goto_functionst`, with the risk that users would store references to it or iterators pointing into it which could be invalidated upon converting more methods and so adding to the function map. However, test-gen would have required a **lot** of code to be changed, so it was necessary to expose a `const goto_functionst &` in the end regardless."},"comment":{"url":"https://api.github.com/repos/diffblue/cbmc/issues/comments/373328440","html_url":"https://github.com/diffblue/cbmc/pull/1914#issuecomment-373328440","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1914","id":373328440,"user":{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false},"created_at":"2018-03-15T10:22:12Z","updated_at":"2018-03-15T10:22:12Z","author_association":"OWNER","body":"@smowton, this will require a TG bump once there is general consensus to go ahead with this solution."}}
{"actor":{"display_login":"peterschrammel"}}