{"action":"created","comment":{"url":"https://api.github.com/repos/cc65/cc65/pulls/comments/171034944","pull_request_review_id":99817277,"id":171034944,"diff_hunk":"@@ -27,20 +29,39 @@ _getcpu:\n         cmp     #1\n         bcc     @L9\n \n-; This is at least a 65C02, check for a 4510\n+; This is at least a 65C02, check for a 65ce02/4510\n \n-        .byte   $42,$ea         ; neg on 4510, nop #$ea on 65c02, wdm $ea on 65816\n+        .byte   $42,$ea         ; neg on 65ce02/4510, nop #$ea on 65c02, wdm $ea on 65816\n         cmp     #1\n-        bne     @L8\n+        beq     @L6\n+\n+; check for 4510\n+\n+        lda     #5              ; CPU_65CE02 constant\n+        .byte   $5c             ; map on 4510, aug on 65ce02 (acts like 4 byte nop)\n+        lda     #3              ; CPU_4510 constant\n+        nop\n+        bne     @L9\n+\n+; check for 65sc02\n+\n+@L6:    ldy     $f7\n+        ldx     #$00\n+        stx     $f7\n+        .byte   $f7,$f7         ; nop nop on 65sc02, smb7 $f7 on 65c02 and 65816","path":"libsrc/common/getcpu.s","position":39,"original_position":39,"commit_id":"e79e779aba9aa463b7d4c5fa1f0beaf6016d5793","original_commit_id":"e79e779aba9aa463b7d4c5fa1f0beaf6016d5793","user":{"login":"blackystardust","id":12174585,"avatar_url":"https://avatars1.githubusercontent.com/u/12174585?v=4","gravatar_id":"","url":"https://api.github.com/users/blackystardust","html_url":"https://github.com/blackystardust","followers_url":"https://api.github.com/users/blackystardust/followers","following_url":"https://api.github.com/users/blackystardust/following{/other_user}","gists_url":"https://api.github.com/users/blackystardust/gists{/gist_id}","starred_url":"https://api.github.com/users/blackystardust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackystardust/subscriptions","organizations_url":"https://api.github.com/users/blackystardust/orgs","repos_url":"https://api.github.com/users/blackystardust/repos","events_url":"https://api.github.com/users/blackystardust/events{/privacy}","received_events_url":"https://api.github.com/users/blackystardust/received_events","type":"User","site_admin":false},"body":"You're right, I'll need to fix that check, thank you for pointing it out.","created_at":"2018-02-27T19:14:45Z","updated_at":"2018-02-27T19:14:45Z","html_url":"https://github.com/cc65/cc65/pull/598#discussion_r171034944","pull_request_url":"https://api.github.com/repos/cc65/cc65/pulls/598","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cc65/cc65/pulls/comments/171034944"},"html":{"href":"https://github.com/cc65/cc65/pull/598#discussion_r171034944"},"pull_request":{"href":"https://api.github.com/repos/cc65/cc65/pulls/598"}},"in_reply_to_id":171031590},"pull_request":{"url":"https://api.github.com/repos/cc65/cc65/pulls/598","id":171731667,"html_url":"https://github.com/cc65/cc65/pull/598","diff_url":"https://github.com/cc65/cc65/pull/598.diff","patch_url":"https://github.com/cc65/cc65/pull/598.patch","issue_url":"https://api.github.com/repos/cc65/cc65/issues/598","number":598,"state":"open","locked":false,"title":"Added proper 65sc02, 65ce02 and 4510 detection.","user":{"login":"blackystardust","id":12174585,"avatar_url":"https://avatars1.githubusercontent.com/u/12174585?v=4","gravatar_id":"","url":"https://api.github.com/users/blackystardust","html_url":"https://github.com/blackystardust","followers_url":"https://api.github.com/users/blackystardust/followers","following_url":"https://api.github.com/users/blackystardust/following{/other_user}","gists_url":"https://api.github.com/users/blackystardust/gists{/gist_id}","starred_url":"https://api.github.com/users/blackystardust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackystardust/subscriptions","organizations_url":"https://api.github.com/users/blackystardust/orgs","repos_url":"https://api.github.com/users/blackystardust/repos","events_url":"https://api.github.com/users/blackystardust/events{/privacy}","received_events_url":"https://api.github.com/users/blackystardust/received_events","type":"User","site_admin":false},"body":"Added proper 65sc02, 65ce02 and 4510 detection.","created_at":"2018-02-27T17:27:53Z","updated_at":"2018-02-27T19:14:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7b66cf6d995c3eb759cccc710c836da17b1d6c6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cc65/cc65/pulls/598/commits","review_comments_url":"https://api.github.com/repos/cc65/cc65/pulls/598/comments","review_comment_url":"https://api.github.com/repos/cc65/cc65/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cc65/cc65/issues/598/comments","statuses_url":"https://api.github.com/repos/cc65/cc65/statuses/e79e779aba9aa463b7d4c5fa1f0beaf6016d5793","head":{"label":"blackystardust:master","ref":"master","sha":"e79e779aba9aa463b7d4c5fa1f0beaf6016d5793","user":{"login":"blackystardust","id":12174585,"avatar_url":"https://avatars1.githubusercontent.com/u/12174585?v=4","gravatar_id":"","url":"https://api.github.com/users/blackystardust","html_url":"https://github.com/blackystardust","followers_url":"https://api.github.com/users/blackystardust/followers","following_url":"https://api.github.com/users/blackystardust/following{/other_user}","gists_url":"https://api.github.com/users/blackystardust/gists{/gist_id}","starred_url":"https://api.github.com/users/blackystardust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackystardust/subscriptions","organizations_url":"https://api.github.com/users/blackystardust/orgs","repos_url":"https://api.github.com/users/blackystardust/repos","events_url":"https://api.github.com/users/blackystardust/events{/privacy}","received_events_url":"https://api.github.com/users/blackystardust/received_events","type":"User","site_admin":false},"repo":{"id":47045760,"name":"cc65","full_name":"blackystardust/cc65","owner":{"login":"blackystardust","id":12174585,"avatar_url":"https://avatars1.githubusercontent.com/u/12174585?v=4","gravatar_id":"","url":"https://api.github.com/users/blackystardust","html_url":"https://github.com/blackystardust","followers_url":"https://api.github.com/users/blackystardust/followers","following_url":"https://api.github.com/users/blackystardust/following{/other_user}","gists_url":"https://api.github.com/users/blackystardust/gists{/gist_id}","starred_url":"https://api.github.com/users/blackystardust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackystardust/subscriptions","organizations_url":"https://api.github.com/users/blackystardust/orgs","repos_url":"https://api.github.com/users/blackystardust/repos","events_url":"https://api.github.com/users/blackystardust/events{/privacy}","received_events_url":"https://api.github.com/users/blackystardust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blackystardust/cc65","description":"cc65 - a freeware C compiler for 6502 based systems -","fork":true,"url":"https://api.github.com/repos/blackystardust/cc65","forks_url":"https://api.github.com/repos/blackystardust/cc65/forks","keys_url":"https://api.github.com/repos/blackystardust/cc65/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blackystardust/cc65/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blackystardust/cc65/teams","hooks_url":"https://api.github.com/repos/blackystardust/cc65/hooks","issue_events_url":"https://api.github.com/repos/blackystardust/cc65/issues/events{/number}","events_url":"https://api.github.com/repos/blackystardust/cc65/events","assignees_url":"https://api.github.com/repos/blackystardust/cc65/assignees{/user}","branches_url":"https://api.github.com/repos/blackystardust/cc65/branches{/branch}","tags_url":"https://api.github.com/repos/blackystardust/cc65/tags","blobs_url":"https://api.github.com/repos/blackystardust/cc65/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blackystardust/cc65/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blackystardust/cc65/git/refs{/sha}","trees_url":"https://api.github.com/repos/blackystardust/cc65/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blackystardust/cc65/statuses/{sha}","languages_url":"https://api.github.com/repos/blackystardust/cc65/languages","stargazers_url":"https://api.github.com/repos/blackystardust/cc65/stargazers","contributors_url":"https://api.github.com/repos/blackystardust/cc65/contributors","subscribers_url":"https://api.github.com/repos/blackystardust/cc65/subscribers","subscription_url":"https://api.github.com/repos/blackystardust/cc65/subscription","commits_url":"https://api.github.com/repos/blackystardust/cc65/commits{/sha}","git_commits_url":"https://api.github.com/repos/blackystardust/cc65/git/commits{/sha}","comments_url":"https://api.github.com/repos/blackystardust/cc65/comments{/number}","issue_comment_url":"https://api.github.com/repos/blackystardust/cc65/issues/comments{/number}","contents_url":"https://api.github.com/repos/blackystardust/cc65/contents/{+path}","compare_url":"https://api.github.com/repos/blackystardust/cc65/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blackystardust/cc65/merges","archive_url":"https://api.github.com/repos/blackystardust/cc65/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blackystardust/cc65/downloads","issues_url":"https://api.github.com/repos/blackystardust/cc65/issues{/number}","pulls_url":"https://api.github.com/repos/blackystardust/cc65/pulls{/number}","milestones_url":"https://api.github.com/repos/blackystardust/cc65/milestones{/number}","notifications_url":"https://api.github.com/repos/blackystardust/cc65/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blackystardust/cc65/labels{/name}","releases_url":"https://api.github.com/repos/blackystardust/cc65/releases{/id}","deployments_url":"https://api.github.com/repos/blackystardust/cc65/deployments","created_at":"2015-11-29T01:30:27Z","updated_at":"2018-02-14T03:18:43Z","pushed_at":"2018-02-27T03:30:43Z","git_url":"git://github.com/blackystardust/cc65.git","ssh_url":"git@github.com:blackystardust/cc65.git","clone_url":"https://github.com/blackystardust/cc65.git","svn_url":"https://github.com/blackystardust/cc65","homepage":"http://cc65.github.io/cc65","size":21096,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"zlib","name":"zlib License","spdx_id":"Zlib","url":"https://api.github.com/licenses/zlib"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cc65:master","ref":"master","sha":"33f602f9ad5582e8df7e1c0bd89433301f35b79f","user":{"login":"cc65","id":6959645,"avatar_url":"https://avatars2.githubusercontent.com/u/6959645?v=4","gravatar_id":"","url":"https://api.github.com/users/cc65","html_url":"https://github.com/cc65","followers_url":"https://api.github.com/users/cc65/followers","following_url":"https://api.github.com/users/cc65/following{/other_user}","gists_url":"https://api.github.com/users/cc65/gists{/gist_id}","starred_url":"https://api.github.com/users/cc65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc65/subscriptions","organizations_url":"https://api.github.com/users/cc65/orgs","repos_url":"https://api.github.com/users/cc65/repos","events_url":"https://api.github.com/users/cc65/events{/privacy}","received_events_url":"https://api.github.com/users/cc65/received_events","type":"Organization","site_admin":false},"repo":{"id":8932489,"name":"cc65","full_name":"cc65/cc65","owner":{"login":"cc65","id":6959645,"avatar_url":"https://avatars2.githubusercontent.com/u/6959645?v=4","gravatar_id":"","url":"https://api.github.com/users/cc65","html_url":"https://github.com/cc65","followers_url":"https://api.github.com/users/cc65/followers","following_url":"https://api.github.com/users/cc65/following{/other_user}","gists_url":"https://api.github.com/users/cc65/gists{/gist_id}","starred_url":"https://api.github.com/users/cc65/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc65/subscriptions","organizations_url":"https://api.github.com/users/cc65/orgs","repos_url":"https://api.github.com/users/cc65/repos","events_url":"https://api.github.com/users/cc65/events{/privacy}","received_events_url":"https://api.github.com/users/cc65/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cc65/cc65","description":"cc65 - a freeware C compiler for 6502 based systems —","fork":false,"url":"https://api.github.com/repos/cc65/cc65","forks_url":"https://api.github.com/repos/cc65/cc65/forks","keys_url":"https://api.github.com/repos/cc65/cc65/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cc65/cc65/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cc65/cc65/teams","hooks_url":"https://api.github.com/repos/cc65/cc65/hooks","issue_events_url":"https://api.github.com/repos/cc65/cc65/issues/events{/number}","events_url":"https://api.github.com/repos/cc65/cc65/events","assignees_url":"https://api.github.com/repos/cc65/cc65/assignees{/user}","branches_url":"https://api.github.com/repos/cc65/cc65/branches{/branch}","tags_url":"https://api.github.com/repos/cc65/cc65/tags","blobs_url":"https://api.github.com/repos/cc65/cc65/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cc65/cc65/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cc65/cc65/git/refs{/sha}","trees_url":"https://api.github.com/repos/cc65/cc65/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cc65/cc65/statuses/{sha}","languages_url":"https://api.github.com/repos/cc65/cc65/languages","stargazers_url":"https://api.github.com/repos/cc65/cc65/stargazers","contributors_url":"https://api.github.com/repos/cc65/cc65/contributors","subscribers_url":"https://api.github.com/repos/cc65/cc65/subscribers","subscription_url":"https://api.github.com/repos/cc65/cc65/subscription","commits_url":"https://api.github.com/repos/cc65/cc65/commits{/sha}","git_commits_url":"https://api.github.com/repos/cc65/cc65/git/commits{/sha}","comments_url":"https://api.github.com/repos/cc65/cc65/comments{/number}","issue_comment_url":"https://api.github.com/repos/cc65/cc65/issues/comments{/number}","contents_url":"https://api.github.com/repos/cc65/cc65/contents/{+path}","compare_url":"https://api.github.com/repos/cc65/cc65/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cc65/cc65/merges","archive_url":"https://api.github.com/repos/cc65/cc65/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cc65/cc65/downloads","issues_url":"https://api.github.com/repos/cc65/cc65/issues{/number}","pulls_url":"https://api.github.com/repos/cc65/cc65/pulls{/number}","milestones_url":"https://api.github.com/repos/cc65/cc65/milestones{/number}","notifications_url":"https://api.github.com/repos/cc65/cc65/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cc65/cc65/labels{/name}","releases_url":"https://api.github.com/repos/cc65/cc65/releases{/id}","deployments_url":"https://api.github.com/repos/cc65/cc65/deployments","created_at":"2013-03-21T15:56:48Z","updated_at":"2018-02-25T20:41:25Z","pushed_at":"2018-02-27T17:27:54Z","git_url":"git://github.com/cc65/cc65.git","ssh_url":"git@github.com:cc65/cc65.git","clone_url":"https://github.com/cc65/cc65.git","svn_url":"https://github.com/cc65/cc65","homepage":"http://cc65.github.io/cc65","size":21088,"stargazers_count":562,"watchers_count":562,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":130,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"zlib","name":"zlib License","spdx_id":"Zlib","url":"https://api.github.com/licenses/zlib"},"forks":130,"open_issues":58,"watchers":562,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cc65/cc65/pulls/598"},"html":{"href":"https://github.com/cc65/cc65/pull/598"},"issue":{"href":"https://api.github.com/repos/cc65/cc65/issues/598"},"comments":{"href":"https://api.github.com/repos/cc65/cc65/issues/598/comments"},"review_comments":{"href":"https://api.github.com/repos/cc65/cc65/pulls/598/comments"},"review_comment":{"href":"https://api.github.com/repos/cc65/cc65/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cc65/cc65/pulls/598/commits"},"statuses":{"href":"https://api.github.com/repos/cc65/cc65/statuses/e79e779aba9aa463b7d4c5fa1f0beaf6016d5793"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blackystardust"}}