{"action":"created","comment":{"url":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/comments/191042328","pull_request_review_id":123550035,"id":191042328,"diff_hunk":"@@ -254,6 +252,28 @@ namespace KCL_rosplan {\n \t/* goal */\n \t/*------*/\n \n+    void PDDLProblemGenerator::parseInequalityExpression(rosplan_knowledge_msgs::ExprComposite exprComposite, int size, std::ofstream &pFile){\n+        for(size_t i = 0; i < size; i++) {\n+\n+            switch(exprComposite.tokens[i].expr_type){\n+                case 0: pFile << \" \"<< exprComposite.tokens[i].constant << \" \"; break;\n+                case 1:\n+                {\n+                    pFile << \"(\";\n+                    pFile << exprComposite.tokens[i].function.name;\n+                    for(size_t j = 0; i < exprComposite.tokens[j].function.typed_parameters.size(); j++) {\n+                        pFile << exprComposite.tokens[j].function.typed_parameters[j].key+\" \"+exprComposite.tokens[j].function.typed_parameters[j].value;\n+                    }\n+                    pFile << \")\";\n+                } break;\n+\n+                case 2: pFile << \" \" << exprComposite.tokens[i].op << \" \"; break;\n+                case 3: pFile << pFile << \"(\";exprComposite.tokens[i].special_type; pFile << \")\";break;\n+\n+            }\n+        }\n+    }\n+","path":"rosplan_planning_system/src/ProblemGeneration/PDDLProblemGenerator.cpp","position":41,"original_position":41,"commit_id":"70f222d76f19a4fd16d8fa76ed86ab01bd78ef59","original_commit_id":"70f222d76f19a4fd16d8fa76ed86ab01bd78ef59","user":{"login":"m312z","id":7440567,"avatar_url":"https://avatars0.githubusercontent.com/u/7440567?v=4","gravatar_id":"","url":"https://api.github.com/users/m312z","html_url":"https://github.com/m312z","followers_url":"https://api.github.com/users/m312z/followers","following_url":"https://api.github.com/users/m312z/following{/other_user}","gists_url":"https://api.github.com/users/m312z/gists{/gist_id}","starred_url":"https://api.github.com/users/m312z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m312z/subscriptions","organizations_url":"https://api.github.com/users/m312z/orgs","repos_url":"https://api.github.com/users/m312z/repos","events_url":"https://api.github.com/users/m312z/events{/privacy}","received_events_url":"https://api.github.com/users/m312z/received_events","type":"User","site_admin":false},"body":"There is already a function to print expressions below (printExpression).\r\nNote that the op needs to be converted from the short int to a string, e.g., 0 -> \"(<=\"\r\nAlso that closing braces for operators need printed, to get output such as:\r\n\"(* (- (+ w x) y) (- 0 z))\"","created_at":"2018-05-26T07:27:38Z","updated_at":"2018-05-26T07:30:53Z","html_url":"https://github.com/KCL-Planning/ROSPlan/pull/99#discussion_r191042328","pull_request_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/99","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/comments/191042328"},"html":{"href":"https://github.com/KCL-Planning/ROSPlan/pull/99#discussion_r191042328"},"pull_request":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/99"}}},"pull_request":{"url":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/99","id":190578129,"html_url":"https://github.com/KCL-Planning/ROSPlan/pull/99","diff_url":"https://github.com/KCL-Planning/ROSPlan/pull/99.diff","patch_url":"https://github.com/KCL-Planning/ROSPlan/pull/99.patch","issue_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/issues/99","number":99,"state":"open","locked":false,"title":"Devel","user":{"login":"b-dorian","id":10816436,"avatar_url":"https://avatars2.githubusercontent.com/u/10816436?v=4","gravatar_id":"","url":"https://api.github.com/users/b-dorian","html_url":"https://github.com/b-dorian","followers_url":"https://api.github.com/users/b-dorian/followers","following_url":"https://api.github.com/users/b-dorian/following{/other_user}","gists_url":"https://api.github.com/users/b-dorian/gists{/gist_id}","starred_url":"https://api.github.com/users/b-dorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-dorian/subscriptions","organizations_url":"https://api.github.com/users/b-dorian/orgs","repos_url":"https://api.github.com/users/b-dorian/repos","events_url":"https://api.github.com/users/b-dorian/events{/privacy}","received_events_url":"https://api.github.com/users/b-dorian/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-25T12:48:26Z","updated_at":"2018-05-26T07:30:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fadab4076322cd95309a44465b7774e2306521bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/99/commits","review_comments_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/99/comments","review_comment_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/issues/99/comments","statuses_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/statuses/70f222d76f19a4fd16d8fa76ed86ab01bd78ef59","head":{"label":"b-dorian:devel","ref":"devel","sha":"70f222d76f19a4fd16d8fa76ed86ab01bd78ef59","user":{"login":"b-dorian","id":10816436,"avatar_url":"https://avatars2.githubusercontent.com/u/10816436?v=4","gravatar_id":"","url":"https://api.github.com/users/b-dorian","html_url":"https://github.com/b-dorian","followers_url":"https://api.github.com/users/b-dorian/followers","following_url":"https://api.github.com/users/b-dorian/following{/other_user}","gists_url":"https://api.github.com/users/b-dorian/gists{/gist_id}","starred_url":"https://api.github.com/users/b-dorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-dorian/subscriptions","organizations_url":"https://api.github.com/users/b-dorian/orgs","repos_url":"https://api.github.com/users/b-dorian/repos","events_url":"https://api.github.com/users/b-dorian/events{/privacy}","received_events_url":"https://api.github.com/users/b-dorian/received_events","type":"User","site_admin":false},"repo":{"id":119999473,"name":"ROSPlan","full_name":"b-dorian/ROSPlan","owner":{"login":"b-dorian","id":10816436,"avatar_url":"https://avatars2.githubusercontent.com/u/10816436?v=4","gravatar_id":"","url":"https://api.github.com/users/b-dorian","html_url":"https://github.com/b-dorian","followers_url":"https://api.github.com/users/b-dorian/followers","following_url":"https://api.github.com/users/b-dorian/following{/other_user}","gists_url":"https://api.github.com/users/b-dorian/gists{/gist_id}","starred_url":"https://api.github.com/users/b-dorian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-dorian/subscriptions","organizations_url":"https://api.github.com/users/b-dorian/orgs","repos_url":"https://api.github.com/users/b-dorian/repos","events_url":"https://api.github.com/users/b-dorian/events{/privacy}","received_events_url":"https://api.github.com/users/b-dorian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/b-dorian/ROSPlan","description":"The ROSPlan framework provides a generic method for task planning in a ROS system.","fork":true,"url":"https://api.github.com/repos/b-dorian/ROSPlan","forks_url":"https://api.github.com/repos/b-dorian/ROSPlan/forks","keys_url":"https://api.github.com/repos/b-dorian/ROSPlan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b-dorian/ROSPlan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b-dorian/ROSPlan/teams","hooks_url":"https://api.github.com/repos/b-dorian/ROSPlan/hooks","issue_events_url":"https://api.github.com/repos/b-dorian/ROSPlan/issues/events{/number}","events_url":"https://api.github.com/repos/b-dorian/ROSPlan/events","assignees_url":"https://api.github.com/repos/b-dorian/ROSPlan/assignees{/user}","branches_url":"https://api.github.com/repos/b-dorian/ROSPlan/branches{/branch}","tags_url":"https://api.github.com/repos/b-dorian/ROSPlan/tags","blobs_url":"https://api.github.com/repos/b-dorian/ROSPlan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b-dorian/ROSPlan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b-dorian/ROSPlan/git/refs{/sha}","trees_url":"https://api.github.com/repos/b-dorian/ROSPlan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b-dorian/ROSPlan/statuses/{sha}","languages_url":"https://api.github.com/repos/b-dorian/ROSPlan/languages","stargazers_url":"https://api.github.com/repos/b-dorian/ROSPlan/stargazers","contributors_url":"https://api.github.com/repos/b-dorian/ROSPlan/contributors","subscribers_url":"https://api.github.com/repos/b-dorian/ROSPlan/subscribers","subscription_url":"https://api.github.com/repos/b-dorian/ROSPlan/subscription","commits_url":"https://api.github.com/repos/b-dorian/ROSPlan/commits{/sha}","git_commits_url":"https://api.github.com/repos/b-dorian/ROSPlan/git/commits{/sha}","comments_url":"https://api.github.com/repos/b-dorian/ROSPlan/comments{/number}","issue_comment_url":"https://api.github.com/repos/b-dorian/ROSPlan/issues/comments{/number}","contents_url":"https://api.github.com/repos/b-dorian/ROSPlan/contents/{+path}","compare_url":"https://api.github.com/repos/b-dorian/ROSPlan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b-dorian/ROSPlan/merges","archive_url":"https://api.github.com/repos/b-dorian/ROSPlan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b-dorian/ROSPlan/downloads","issues_url":"https://api.github.com/repos/b-dorian/ROSPlan/issues{/number}","pulls_url":"https://api.github.com/repos/b-dorian/ROSPlan/pulls{/number}","milestones_url":"https://api.github.com/repos/b-dorian/ROSPlan/milestones{/number}","notifications_url":"https://api.github.com/repos/b-dorian/ROSPlan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b-dorian/ROSPlan/labels{/name}","releases_url":"https://api.github.com/repos/b-dorian/ROSPlan/releases{/id}","deployments_url":"https://api.github.com/repos/b-dorian/ROSPlan/deployments","created_at":"2018-02-02T15:41:53Z","updated_at":"2018-02-02T15:41:56Z","pushed_at":"2018-05-25T23:54:14Z","git_url":"git://github.com/b-dorian/ROSPlan.git","ssh_url":"git@github.com:b-dorian/ROSPlan.git","clone_url":"https://github.com/b-dorian/ROSPlan.git","svn_url":"https://github.com/b-dorian/ROSPlan","homepage":null,"size":108725,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KCL-Planning:devel","ref":"devel","sha":"03f842d8ec9a56172d2c290e10b36ce2fdcb0aed","user":{"login":"KCL-Planning","id":8046554,"avatar_url":"https://avatars1.githubusercontent.com/u/8046554?v=4","gravatar_id":"","url":"https://api.github.com/users/KCL-Planning","html_url":"https://github.com/KCL-Planning","followers_url":"https://api.github.com/users/KCL-Planning/followers","following_url":"https://api.github.com/users/KCL-Planning/following{/other_user}","gists_url":"https://api.github.com/users/KCL-Planning/gists{/gist_id}","starred_url":"https://api.github.com/users/KCL-Planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KCL-Planning/subscriptions","organizations_url":"https://api.github.com/users/KCL-Planning/orgs","repos_url":"https://api.github.com/users/KCL-Planning/repos","events_url":"https://api.github.com/users/KCL-Planning/events{/privacy}","received_events_url":"https://api.github.com/users/KCL-Planning/received_events","type":"Organization","site_admin":false},"repo":{"id":21421114,"name":"ROSPlan","full_name":"KCL-Planning/ROSPlan","owner":{"login":"KCL-Planning","id":8046554,"avatar_url":"https://avatars1.githubusercontent.com/u/8046554?v=4","gravatar_id":"","url":"https://api.github.com/users/KCL-Planning","html_url":"https://github.com/KCL-Planning","followers_url":"https://api.github.com/users/KCL-Planning/followers","following_url":"https://api.github.com/users/KCL-Planning/following{/other_user}","gists_url":"https://api.github.com/users/KCL-Planning/gists{/gist_id}","starred_url":"https://api.github.com/users/KCL-Planning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KCL-Planning/subscriptions","organizations_url":"https://api.github.com/users/KCL-Planning/orgs","repos_url":"https://api.github.com/users/KCL-Planning/repos","events_url":"https://api.github.com/users/KCL-Planning/events{/privacy}","received_events_url":"https://api.github.com/users/KCL-Planning/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KCL-Planning/ROSPlan","description":"The ROSPlan framework provides a generic method for task planning in a ROS system.","fork":false,"url":"https://api.github.com/repos/KCL-Planning/ROSPlan","forks_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/forks","keys_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/teams","hooks_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/hooks","issue_events_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/issues/events{/number}","events_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/events","assignees_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/assignees{/user}","branches_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/branches{/branch}","tags_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/tags","blobs_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/git/refs{/sha}","trees_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/statuses/{sha}","languages_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/languages","stargazers_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/stargazers","contributors_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/contributors","subscribers_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/subscribers","subscription_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/subscription","commits_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/commits{/sha}","git_commits_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/git/commits{/sha}","comments_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/comments{/number}","issue_comment_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/issues/comments{/number}","contents_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/contents/{+path}","compare_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/merges","archive_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/downloads","issues_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/issues{/number}","pulls_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls{/number}","milestones_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/milestones{/number}","notifications_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/labels{/name}","releases_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/releases{/id}","deployments_url":"https://api.github.com/repos/KCL-Planning/ROSPlan/deployments","created_at":"2014-07-02T11:04:22Z","updated_at":"2018-05-05T16:54:55Z","pushed_at":"2018-05-25T23:54:15Z","git_url":"git://github.com/KCL-Planning/ROSPlan.git","ssh_url":"git@github.com:KCL-Planning/ROSPlan.git","clone_url":"https://github.com/KCL-Planning/ROSPlan.git","svn_url":"https://github.com/KCL-Planning/ROSPlan","homepage":null,"size":108725,"stargazers_count":62,"watchers_count":62,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":48,"open_issues":23,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/99"},"html":{"href":"https://github.com/KCL-Planning/ROSPlan/pull/99"},"issue":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/issues/99"},"comments":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/issues/99/comments"},"review_comments":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/99/comments"},"review_comment":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/pulls/99/commits"},"statuses":{"href":"https://api.github.com/repos/KCL-Planning/ROSPlan/statuses/70f222d76f19a4fd16d8fa76ed86ab01bd78ef59"}},"author_association":"NONE"}}
{"actor":{"display_login":"m312z"}}