{"action":"created","issue":{"url":"https://api.github.com/repos/batfish/batfish/issues/2167","repository_url":"https://api.github.com/repos/batfish/batfish","labels_url":"https://api.github.com/repos/batfish/batfish/issues/2167/labels{/name}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/2167/comments","events_url":"https://api.github.com/repos/batfish/batfish/issues/2167/events","html_url":"https://github.com/batfish/batfish/pull/2167","id":354503684,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjUxNDQ5","number":2167,"title":"Specifier flexible dst ip","user":{"login":"dhalperi","id":526415,"node_id":"MDQ6VXNlcjUyNjQxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-27T22:38:08Z","updated_at":"2018-08-27T22:46:11Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/2167","html_url":"https://github.com/batfish/batfish/pull/2167","diff_url":"https://github.com/batfish/batfish/pull/2167.diff","patch_url":"https://github.com/batfish/batfish/pull/2167.patch"},"body":"Four small changes, in separate commits. Happy to separate as you see fit.\r\n\r\n* FlexibleIpSpaceSpecifierFactory: add ofLocation() for flexible locati…\r\n* ConstantIpSpaceSpecifier: add toString\r\n* FlexibleLocationSpecifierTest: add javadoc and annotation\r\n* SpecifiersReachabilityQuestion: use FlexibleUniverseIpSpaceSpecifierF…\r\n\r\ncc: @saparikh try this out."},"comment":{"url":"https://api.github.com/repos/batfish/batfish/issues/comments/416393345","html_url":"https://github.com/batfish/batfish/pull/2167#issuecomment-416393345","issue_url":"https://api.github.com/repos/batfish/batfish/issues/2167","id":416393345,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjM5MzM0NQ==","user":{"login":"dhalperi","id":526415,"node_id":"MDQ6VXNlcjUyNjQxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T22:46:11Z","updated_at":"2018-08-27T22:46:11Z","author_association":"MEMBER","body":"\n\n\n\n___\n*[projects/question/src/test/java/org/batfish/question/specifiers/SpecifiersReachabilityQuestionTest.java, line 46 at r2](https://reviewable.io/reviews/batfish/batfish/2167#-LKxZ3x2CsTE3KumBk18:-LKxZ3x2CsTE3KumBk19:b-dv25l4) ([raw file](https://github.com/batfish/batfish/blob/de5ab0f4441d4c90b85a0f96d43d6fb4e383e762/projects/question/src/test/java/org/batfish/question/specifiers/SpecifiersReachabilityQuestionTest.java#L46)):*\n> ```Java\n>     exception.expectMessage(\n>         \"NodeNameRegexConnectedHostsIpSpaceSpecifierFactory requires input of type String\");\n>     question.getDestinationIpSpaceSpecifier();\n> ```\n\nNote this behavior change. The original behavior didn't seem wonderful to me, but I wasn't certain.\n\n\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"dhalperi"}}