{"action":"created","comment":{"url":"https://api.github.com/repos/cilium/cilium/pulls/comments/198305624","pull_request_review_id":132214540,"id":198305624,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODMwNTYyNA==","diff_hunk":"@@ -87,6 +86,42 @@ var _ = Describe(\"K8sValidatedPolicyTest\", func() {\n \t\t\tappPods   map[string]string\n \t\t)\n \n+\t\tvalidateNoPolicyEnabled := func() {\n+\t\t\t// Validates that the `apps` pods do not have any policy\n+\t\t\t// enforcement enabled.\n+\t\t\tExpectWithOffset(1, kubectl.WaitCEPReady()).To(BeNil(), \"Cep is not ready after a specified timeout\")\n+\t\t\tfor _, app := range apps {\n+\t\t\t\tpod := appPods[app]\n+\t\t\t\tcep := kubectl.CepGet(helpers.DefaultNamespace, pod)\n+\t\t\t\tExpectWithOffset(1, cep).NotTo(BeNil(), \"Endpoint %q does not exit\", pod)","path":"test/k8sT/Policies.go","position":21,"original_position":21,"commit_id":"56ea98ecac71fbf58db8fe86fe2a9bd49af5de51","original_commit_id":"56ea98ecac71fbf58db8fe86fe2a9bd49af5de51","user":{"login":"ianvernon","id":3858271,"node_id":"MDQ6VXNlcjM4NTgyNzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3858271?v=4","gravatar_id":"","url":"https://api.github.com/users/ianvernon","html_url":"https://github.com/ianvernon","followers_url":"https://api.github.com/users/ianvernon/followers","following_url":"https://api.github.com/users/ianvernon/following{/other_user}","gists_url":"https://api.github.com/users/ianvernon/gists{/gist_id}","starred_url":"https://api.github.com/users/ianvernon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianvernon/subscriptions","organizations_url":"https://api.github.com/users/ianvernon/orgs","repos_url":"https://api.github.com/users/ianvernon/repos","events_url":"https://api.github.com/users/ianvernon/events{/privacy}","received_events_url":"https://api.github.com/users/ianvernon/received_events","type":"User","site_admin":false},"body":"exist","created_at":"2018-06-26T21:35:59Z","updated_at":"2018-06-26T21:37:22Z","html_url":"https://github.com/cilium/cilium/pull/4640#discussion_r198305624","pull_request_url":"https://api.github.com/repos/cilium/cilium/pulls/4640","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments/198305624"},"html":{"href":"https://github.com/cilium/cilium/pull/4640#discussion_r198305624"},"pull_request":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4640"}}},"pull_request":{"url":"https://api.github.com/repos/cilium/cilium/pulls/4640","id":197333496,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MzMzNDk2","html_url":"https://github.com/cilium/cilium/pull/4640","diff_url":"https://github.com/cilium/cilium/pull/4640.diff","patch_url":"https://github.com/cilium/cilium/pull/4640.patch","issue_url":"https://api.github.com/repos/cilium/cilium/issues/4640","number":4640,"state":"open","locked":false,"title":"CI: Refactor K8s test to use `kubectl get cep` ","user":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"body":"I made a refactor on test: \r\n\r\n- Use always `kubectl get cep` instead of executing commands on cilium pods. \r\n- Remove old functions that are not longer needed. \r\n\r\nEach commit explain what I did.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cilium/cilium/4640)\n<!-- Reviewable:end -->\n","created_at":"2018-06-26T07:58:42Z","updated_at":"2018-06-26T21:37:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"140642f3ad0876eb61717e097c0b130ea5712bfd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":709779088,"node_id":"MDU6TGFiZWw3MDk3NzkwODg=","url":"https://api.github.com/repos/cilium/cilium/labels/area/CI","name":"area/CI","color":"bfd4f2","default":false},{"id":403149902,"node_id":"MDU6TGFiZWw0MDMxNDk5MDI=","url":"https://api.github.com/repos/cilium/cilium/labels/pending-review","name":"pending-review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cilium/cilium/pulls/4640/commits","review_comments_url":"https://api.github.com/repos/cilium/cilium/pulls/4640/comments","review_comment_url":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cilium/cilium/issues/4640/comments","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/56ea98ecac71fbf58db8fe86fe2a9bd49af5de51","head":{"label":"eloycoto:CEPRewrite","ref":"CEPRewrite","sha":"56ea98ecac71fbf58db8fe86fe2a9bd49af5de51","user":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"repo":{"id":93093102,"node_id":"MDEwOlJlcG9zaXRvcnk5MzA5MzEwMg==","name":"cilium","full_name":"eloycoto/cilium","owner":{"login":"eloycoto","id":868013,"node_id":"MDQ6VXNlcjg2ODAxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/868013?v=4","gravatar_id":"","url":"https://api.github.com/users/eloycoto","html_url":"https://github.com/eloycoto","followers_url":"https://api.github.com/users/eloycoto/followers","following_url":"https://api.github.com/users/eloycoto/following{/other_user}","gists_url":"https://api.github.com/users/eloycoto/gists{/gist_id}","starred_url":"https://api.github.com/users/eloycoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eloycoto/subscriptions","organizations_url":"https://api.github.com/users/eloycoto/orgs","repos_url":"https://api.github.com/users/eloycoto/repos","events_url":"https://api.github.com/users/eloycoto/events{/privacy}","received_events_url":"https://api.github.com/users/eloycoto/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eloycoto/cilium","description":"Linux Native, HTTP Aware Networking and Security for Containers","fork":true,"url":"https://api.github.com/repos/eloycoto/cilium","forks_url":"https://api.github.com/repos/eloycoto/cilium/forks","keys_url":"https://api.github.com/repos/eloycoto/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eloycoto/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eloycoto/cilium/teams","hooks_url":"https://api.github.com/repos/eloycoto/cilium/hooks","issue_events_url":"https://api.github.com/repos/eloycoto/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/eloycoto/cilium/events","assignees_url":"https://api.github.com/repos/eloycoto/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/eloycoto/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/eloycoto/cilium/tags","blobs_url":"https://api.github.com/repos/eloycoto/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eloycoto/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eloycoto/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/eloycoto/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eloycoto/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/eloycoto/cilium/languages","stargazers_url":"https://api.github.com/repos/eloycoto/cilium/stargazers","contributors_url":"https://api.github.com/repos/eloycoto/cilium/contributors","subscribers_url":"https://api.github.com/repos/eloycoto/cilium/subscribers","subscription_url":"https://api.github.com/repos/eloycoto/cilium/subscription","commits_url":"https://api.github.com/repos/eloycoto/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/eloycoto/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/eloycoto/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/eloycoto/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/eloycoto/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/eloycoto/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eloycoto/cilium/merges","archive_url":"https://api.github.com/repos/eloycoto/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eloycoto/cilium/downloads","issues_url":"https://api.github.com/repos/eloycoto/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/eloycoto/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/eloycoto/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/eloycoto/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eloycoto/cilium/labels{/name}","releases_url":"https://api.github.com/repos/eloycoto/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/eloycoto/cilium/deployments","created_at":"2017-06-01T19:40:10Z","updated_at":"2018-06-10T11:07:53Z","pushed_at":"2018-06-26T17:02:59Z","git_url":"git://github.com/eloycoto/cilium.git","ssh_url":"git@github.com:eloycoto/cilium.git","clone_url":"https://github.com/eloycoto/cilium.git","svn_url":"https://github.com/eloycoto/cilium","homepage":"","size":74957,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cilium:master","ref":"master","sha":"878ad4d06426f3ec1294fea80fddd36d06b5e3c0","user":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"repo":{"id":48109239,"node_id":"MDEwOlJlcG9zaXRvcnk0ODEwOTIzOQ==","name":"cilium","full_name":"cilium/cilium","owner":{"login":"cilium","id":21054566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDU0NTY2","avatar_url":"https://avatars0.githubusercontent.com/u/21054566?v=4","gravatar_id":"","url":"https://api.github.com/users/cilium","html_url":"https://github.com/cilium","followers_url":"https://api.github.com/users/cilium/followers","following_url":"https://api.github.com/users/cilium/following{/other_user}","gists_url":"https://api.github.com/users/cilium/gists{/gist_id}","starred_url":"https://api.github.com/users/cilium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cilium/subscriptions","organizations_url":"https://api.github.com/users/cilium/orgs","repos_url":"https://api.github.com/users/cilium/repos","events_url":"https://api.github.com/users/cilium/events{/privacy}","received_events_url":"https://api.github.com/users/cilium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cilium/cilium","description":"HTTP, gRPC, and Kafka Aware Security and Networking for Containers with BPF and XDP","fork":false,"url":"https://api.github.com/repos/cilium/cilium","forks_url":"https://api.github.com/repos/cilium/cilium/forks","keys_url":"https://api.github.com/repos/cilium/cilium/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cilium/cilium/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cilium/cilium/teams","hooks_url":"https://api.github.com/repos/cilium/cilium/hooks","issue_events_url":"https://api.github.com/repos/cilium/cilium/issues/events{/number}","events_url":"https://api.github.com/repos/cilium/cilium/events","assignees_url":"https://api.github.com/repos/cilium/cilium/assignees{/user}","branches_url":"https://api.github.com/repos/cilium/cilium/branches{/branch}","tags_url":"https://api.github.com/repos/cilium/cilium/tags","blobs_url":"https://api.github.com/repos/cilium/cilium/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cilium/cilium/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cilium/cilium/git/refs{/sha}","trees_url":"https://api.github.com/repos/cilium/cilium/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cilium/cilium/statuses/{sha}","languages_url":"https://api.github.com/repos/cilium/cilium/languages","stargazers_url":"https://api.github.com/repos/cilium/cilium/stargazers","contributors_url":"https://api.github.com/repos/cilium/cilium/contributors","subscribers_url":"https://api.github.com/repos/cilium/cilium/subscribers","subscription_url":"https://api.github.com/repos/cilium/cilium/subscription","commits_url":"https://api.github.com/repos/cilium/cilium/commits{/sha}","git_commits_url":"https://api.github.com/repos/cilium/cilium/git/commits{/sha}","comments_url":"https://api.github.com/repos/cilium/cilium/comments{/number}","issue_comment_url":"https://api.github.com/repos/cilium/cilium/issues/comments{/number}","contents_url":"https://api.github.com/repos/cilium/cilium/contents/{+path}","compare_url":"https://api.github.com/repos/cilium/cilium/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cilium/cilium/merges","archive_url":"https://api.github.com/repos/cilium/cilium/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cilium/cilium/downloads","issues_url":"https://api.github.com/repos/cilium/cilium/issues{/number}","pulls_url":"https://api.github.com/repos/cilium/cilium/pulls{/number}","milestones_url":"https://api.github.com/repos/cilium/cilium/milestones{/number}","notifications_url":"https://api.github.com/repos/cilium/cilium/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cilium/cilium/labels{/name}","releases_url":"https://api.github.com/repos/cilium/cilium/releases{/id}","deployments_url":"https://api.github.com/repos/cilium/cilium/deployments","created_at":"2015-12-16T12:33:31Z","updated_at":"2018-06-26T21:33:55Z","pushed_at":"2018-06-26T21:33:46Z","git_url":"git://github.com/cilium/cilium.git","ssh_url":"git@github.com:cilium/cilium.git","clone_url":"https://github.com/cilium/cilium.git","svn_url":"https://github.com/cilium/cilium","homepage":"","size":52930,"stargazers_count":2445,"watchers_count":2445,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":213,"mirror_url":null,"archived":false,"open_issues_count":525,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":213,"open_issues":525,"watchers":2445,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4640"},"html":{"href":"https://github.com/cilium/cilium/pull/4640"},"issue":{"href":"https://api.github.com/repos/cilium/cilium/issues/4640"},"comments":{"href":"https://api.github.com/repos/cilium/cilium/issues/4640/comments"},"review_comments":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4640/comments"},"review_comment":{"href":"https://api.github.com/repos/cilium/cilium/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cilium/cilium/pulls/4640/commits"},"statuses":{"href":"https://api.github.com/repos/cilium/cilium/statuses/56ea98ecac71fbf58db8fe86fe2a9bd49af5de51"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ianvernon"}}