{"action":"closed","issue":{"url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2541","repository_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork","labels_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2541/labels{/name}","comments_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2541/comments","events_url":"https://api.github.com/repos/openfoodfoundation/openfoodnetwork/issues/2541/events","html_url":"https://github.com/openfoodfoundation/openfoodnetwork/issues/2541","id":349802501,"node_id":"MDU6SXNzdWUzNDk4MDI1MDE=","number":2541,"title":"[Spree Build] Spree Controller specs: undefined method `[]` for nil:NilClass","user":{"login":"HugsDaniel","id":28786869,"node_id":"MDQ6VXNlcjI4Nzg2ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/28786869?v=4","gravatar_id":"","url":"https://api.github.com/users/HugsDaniel","html_url":"https://github.com/HugsDaniel","followers_url":"https://api.github.com/users/HugsDaniel/followers","following_url":"https://api.github.com/users/HugsDaniel/following{/other_user}","gists_url":"https://api.github.com/users/HugsDaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugsDaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugsDaniel/subscriptions","organizations_url":"https://api.github.com/users/HugsDaniel/orgs","repos_url":"https://api.github.com/users/HugsDaniel/repos","events_url":"https://api.github.com/users/HugsDaniel/events{/privacy}","received_events_url":"https://api.github.com/users/HugsDaniel/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"HugsDaniel","id":28786869,"node_id":"MDQ6VXNlcjI4Nzg2ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/28786869?v=4","gravatar_id":"","url":"https://api.github.com/users/HugsDaniel","html_url":"https://github.com/HugsDaniel","followers_url":"https://api.github.com/users/HugsDaniel/followers","following_url":"https://api.github.com/users/HugsDaniel/following{/other_user}","gists_url":"https://api.github.com/users/HugsDaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugsDaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugsDaniel/subscriptions","organizations_url":"https://api.github.com/users/HugsDaniel/orgs","repos_url":"https://api.github.com/users/HugsDaniel/repos","events_url":"https://api.github.com/users/HugsDaniel/events{/privacy}","received_events_url":"https://api.github.com/users/HugsDaniel/received_events","type":"User","site_admin":false},"assignees":[{"login":"HugsDaniel","id":28786869,"node_id":"MDQ6VXNlcjI4Nzg2ODY5","avatar_url":"https://avatars3.githubusercontent.com/u/28786869?v=4","gravatar_id":"","url":"https://api.github.com/users/HugsDaniel","html_url":"https://github.com/HugsDaniel","followers_url":"https://api.github.com/users/HugsDaniel/followers","following_url":"https://api.github.com/users/HugsDaniel/following{/other_user}","gists_url":"https://api.github.com/users/HugsDaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/HugsDaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HugsDaniel/subscriptions","organizations_url":"https://api.github.com/users/HugsDaniel/orgs","repos_url":"https://api.github.com/users/HugsDaniel/repos","events_url":"https://api.github.com/users/HugsDaniel/events{/privacy}","received_events_url":"https://api.github.com/users/HugsDaniel/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-12T10:45:27Z","updated_at":"2018-08-22T08:30:17Z","closed_at":"2018-08-22T08:30:17Z","author_association":"CONTRIBUTOR","body":"<!-- Provide a general summary of the issue in the Title above.\r\n\r\nIf your issue is not a bug, please use the Feature template instead:\r\nhttps://github.com/openfoodfoundation/openfoodnetwork/wiki/Feature-template\r\n\r\n-->\r\n## Description\r\n<!-- Provide a more detailed introduction to the issue itself, and why you consider it to be a bug -->\r\nWhen running specs for `frontend`, errors occur with ` undefined method '[]' for nil:NilClass`. \r\n\r\nThis comes from `/home/hugs/code/Waldenn/OFN/spree/core/lib/spree/core/controller_helpers/common.rb:57` in :\r\n\r\n```type.html { render :status => :not_found, :file    => \"#{::Rails.root}/public/404\", :formats => [:html], :layout => nil}```\r\n\r\nand after investigation it seems to come specifically from `:file => \"#{::Rails.root}/public/404` which RSpec doesn't seem to find. When I removed this path and replace with `:nothing => true`, the tests passed.\r\n\r\n\r\n## Expected Behavior\r\n<!-- Tell us what should happen -->\r\nThe tests should find 404.html at the given path and pass.\r\n\r\n\r\n## Actual Behavior\r\n<!-- Tell us what happens instead -->\r\nThe tests fail.\r\n\r\n\r\n## Steps to Reproduce\r\n<!-- Provide an unambiguous set of steps to reproduce this bug -->\r\n<!-- Include code to reproduce if relevant -->\r\n\r\n1. `bash build.sh`\r\n\r\n\r\n## Animated Gif/Screenshot\r\n<!-- Provide a screenshot or brief animated gif reproducing the bug. Linux users can use\r\n[Peek](https://github.com/phw/peek#ubuntu) while Mac users can use [Recordit](http://recordit.co/) -->\r\n![screenshot from 2018-08-10 13-51-57](https://user-images.githubusercontent.com/28786869/44001164-dcb36410-9e2c-11e8-813b-df200e3b6b8e.png)\r\n\r\n\r\n## Context\r\n<!-- How has this bug affected you? What were you trying to accomplish? -->\r\nThis affects our Spree build and prevents us from having a passing test suite on branch 2-0-4-stable.\r\n\r\n\r\n\r\n## Your Environment\r\n<!-- Include relevant details about the environment you experienced the bug in -->\r\n\r\n* Version used: Spree `2-0-4-stable`\r\n* Browser name and version: Firefox 61\r\n* Operating System and version (desktop or mobile): Ubuntu 16.04"}}
{"actor":{"display_login":"mkllnk"}}