{"action":"created","issue":{"url":"https://api.github.com/repos/ShapeNet/shapenet-viewer/issues/22","repository_url":"https://api.github.com/repos/ShapeNet/shapenet-viewer","labels_url":"https://api.github.com/repos/ShapeNet/shapenet-viewer/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/ShapeNet/shapenet-viewer/issues/22/comments","events_url":"https://api.github.com/repos/ShapeNet/shapenet-viewer/issues/22/events","html_url":"https://github.com/ShapeNet/shapenet-viewer/pull/22","id":294091890,"number":22,"title":"Fix PNG transparency (Fixes #2)","user":{"login":"baudm","id":1025433,"avatar_url":"https://avatars0.githubusercontent.com/u/1025433?v=4","gravatar_id":"","url":"https://api.github.com/users/baudm","html_url":"https://github.com/baudm","followers_url":"https://api.github.com/users/baudm/followers","following_url":"https://api.github.com/users/baudm/following{/other_user}","gists_url":"https://api.github.com/users/baudm/gists{/gist_id}","starred_url":"https://api.github.com/users/baudm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baudm/subscriptions","organizations_url":"https://api.github.com/users/baudm/orgs","repos_url":"https://api.github.com/users/baudm/repos","events_url":"https://api.github.com/users/baudm/events{/privacy}","received_events_url":"https://api.github.com/users/baudm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-03T07:33:21Z","updated_at":"2018-03-06T09:59:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ShapeNet/shapenet-viewer/pulls/22","html_url":"https://github.com/ShapeNet/shapenet-viewer/pull/22","diff_url":"https://github.com/ShapeNet/shapenet-viewer/pull/22.diff","patch_url":"https://github.com/ShapeNet/shapenet-viewer/pull/22.patch"},"body":"This is a JME issue. Since the modified code is internal to JME, a new\r\nclass with the same interface is created instead.\r\n\r\nThere are two problems:\r\n1. Renderer.readFrameBuffer() fills the output ByteBuffer with the wrong transparency information. Instead of setting the background to be fully transparent (0x00), the alpha channel bits are set to 0xff, or fully opaque.\r\n2. When an image of type BufferedImage.TYPE_INT_BGR is written, the alpha channel information is lost and is never written. Hence, we end up with 3-channel PNGs instead of 4.\r\n\r\nThis is a quick fix which should address the issue without waiting for JME to fix the issue on their end."},"comment":{"url":"https://api.github.com/repos/ShapeNet/shapenet-viewer/issues/comments/370727415","html_url":"https://github.com/ShapeNet/shapenet-viewer/pull/22#issuecomment-370727415","issue_url":"https://api.github.com/repos/ShapeNet/shapenet-viewer/issues/22","id":370727415,"user":{"login":"baudm","id":1025433,"avatar_url":"https://avatars0.githubusercontent.com/u/1025433?v=4","gravatar_id":"","url":"https://api.github.com/users/baudm","html_url":"https://github.com/baudm","followers_url":"https://api.github.com/users/baudm/followers","following_url":"https://api.github.com/users/baudm/following{/other_user}","gists_url":"https://api.github.com/users/baudm/gists{/gist_id}","starred_url":"https://api.github.com/users/baudm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baudm/subscriptions","organizations_url":"https://api.github.com/users/baudm/orgs","repos_url":"https://api.github.com/users/baudm/repos","events_url":"https://api.github.com/users/baudm/events{/privacy}","received_events_url":"https://api.github.com/users/baudm/received_events","type":"User","site_admin":false},"created_at":"2018-03-06T09:59:06Z","updated_at":"2018-03-06T09:59:06Z","author_association":"NONE","body":"Is this the result from my branch?"}}
{"actor":{"display_login":"baudm"}}