{"comment":{"url":"https://api.github.com/repos/annot8/core/comments/27501410","html_url":"https://github.com/annot8/core/commit/b5b3006c91f6cedc12e10f990dc22ddc67166bc4#commitcomment-27501410","id":27501410,"user":{"login":"chrisflatley","id":8419367,"avatar_url":"https://avatars0.githubusercontent.com/u/8419367?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisflatley","html_url":"https://github.com/chrisflatley","followers_url":"https://api.github.com/users/chrisflatley/followers","following_url":"https://api.github.com/users/chrisflatley/following{/other_user}","gists_url":"https://api.github.com/users/chrisflatley/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisflatley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisflatley/subscriptions","organizations_url":"https://api.github.com/users/chrisflatley/orgs","repos_url":"https://api.github.com/users/chrisflatley/repos","events_url":"https://api.github.com/users/chrisflatley/events{/privacy}","received_events_url":"https://api.github.com/users/chrisflatley/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"b5b3006c91f6cedc12e10f990dc22ddc67166bc4","created_at":"2018-02-12T09:12:13Z","updated_at":"2018-02-12T09:12:13Z","author_association":"NONE","body":"Think we should come up with a plan for this. There are so many meaning of\nequals I think we need to be clearer on which is we want and the naming.\n\nI raised an issue for this\n\nOn Mon, 12 Feb 2018 at 09:58, jamesdbaker <notifications@github.com> wrote:\n\n> Should sameX be named something a bit clearer (i.e. sameId) so that it's\n> obvious it's only checking the ID and not other properties?\n>\n> Naming is also inconsistent between, say, Annotation and\n> AnnotationReference: sameAnnotation() checks ID, whereas sameReference()\n> checks that objects are equal. The latter should be called equalsReference,\n> and should do a deep check of properties?\n>\n> What does the standard equals() mean in these instances? We should\n> override that where possible to be meaningful.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/annot8/core/commit/b5b3006c91f6cedc12e10f990dc22ddc67166bc4#commitcomment-27501095>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AIB4J7KJTQf1W9APM4kYBgzhGb4CXOfhks5tT_0ggaJpZM4SB2gI>\n> .\n>\n-- \n*Chris Flatley*\n*m* 075 38 38 28 68 | *e* chrisflatley@tenode.com\n\nThis message is private and confidential. If you have received this message\nin error, please notify us and remove it from your system.\nTenode is a trading style of Committed Research Ltd. Committed Research Ltd is\nregistered in England and Wales, company registration number 7747673.\nRegistered Office: 20 Prestbury Road, Cheltenham, GL52 2PW.\n"}}
{"actor":{"display_login":"chrisflatley"}}