{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/comments/191557238","pull_request_review_id":124152834,"id":191557238,"diff_hunk":"@@ -0,0 +1,53 @@\n+/**********************************************************************\n+ * Copyright (c) 2017 Tomas van der Wansem                            *\n+ * Distributed under the MIT software license, see the accompanying   *\n+ * file COPYING or http://www.opensource.org/licenses/mit-license.php.*\n+ **********************************************************************/\n+\n+#include \"include/secp256k1.h\"\n+#include \"include/secp256k1_multiset.h\"\n+#include \"util.h\"\n+#include \"bench.h\"\n+\n+secp256k1_context *ctx;\n+\n+#define UNUSED(x) (void)(x)\n+\n+void bench_multiset(void* arg) {\n+    int it=0;\n+    unsigned n,m;\n+    unsigned char result[32];\n+    secp256k1_multiset multiset;\n+\n+    UNUSED(arg);\n+    secp256k1_multiset_init(ctx, &multiset);\n+\n+    for (m=0; m < 300000; m++)\n+    {\n+        unsigned char buf[32*3];\n+        secp256k1_multiset x;\n+\n+        for(n = 0; n < sizeof(buf); n++)\n+        {\n+            buf[n] = it++;\n+        }\n+\n+        secp256k1_multiset_add(ctx, &x, buf, sizeof(buf));\n+    }\n+\n+    secp256k1_multiset_finalize(ctx, result, &multiset);\n+}\n+\n+void bench_multiset_setup(void* arg) {\n+    UNUSED(arg);\n+}\n+","path":"src/secp256k1/src/bench_multiset.c","position":43,"original_position":44,"commit_id":"f74a8a7794a962a9d9e9d63b1c5341d0bc3350cd","original_commit_id":"97ad8c3b76d56f753dd413f0e4fc4c76eeba281b","user":{"login":"dagurval","id":92707,"avatar_url":"https://avatars2.githubusercontent.com/u/92707?v=4","gravatar_id":"","url":"https://api.github.com/users/dagurval","html_url":"https://github.com/dagurval","followers_url":"https://api.github.com/users/dagurval/followers","following_url":"https://api.github.com/users/dagurval/following{/other_user}","gists_url":"https://api.github.com/users/dagurval/gists{/gist_id}","starred_url":"https://api.github.com/users/dagurval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dagurval/subscriptions","organizations_url":"https://api.github.com/users/dagurval/orgs","repos_url":"https://api.github.com/users/dagurval/repos","events_url":"https://api.github.com/users/dagurval/events{/privacy}","received_events_url":"https://api.github.com/users/dagurval/received_events","type":"User","site_admin":false},"body":"Good practice to undef temporary macro definitions I thought, but that may just be a personal preference. Nevermind.","created_at":"2018-05-29T20:08:44Z","updated_at":"2018-05-29T20:14:14Z","html_url":"https://github.com/bitcoinxt/bitcoinxt/pull/425#discussion_r191557238","pull_request_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/425","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/comments/191557238"},"html":{"href":"https://github.com/bitcoinxt/bitcoinxt/pull/425#discussion_r191557238"},"pull_request":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/425"}},"in_reply_to_id":191145024},"pull_request":{"url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/425","id":188721246,"html_url":"https://github.com/bitcoinxt/bitcoinxt/pull/425","diff_url":"https://github.com/bitcoinxt/bitcoinxt/pull/425.diff","patch_url":"https://github.com/bitcoinxt/bitcoinxt/pull/425.patch","issue_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/425","number":425,"state":"open","locked":false,"title":"Add ECMH UTXO commitments (WIP)","user":{"login":"tomasvdw","id":534388,"avatar_url":"https://avatars1.githubusercontent.com/u/534388?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasvdw","html_url":"https://github.com/tomasvdw","followers_url":"https://api.github.com/users/tomasvdw/followers","following_url":"https://api.github.com/users/tomasvdw/following{/other_user}","gists_url":"https://api.github.com/users/tomasvdw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasvdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasvdw/subscriptions","organizations_url":"https://api.github.com/users/tomasvdw/orgs","repos_url":"https://api.github.com/users/tomasvdw/repos","events_url":"https://api.github.com/users/tomasvdw/events{/privacy}","received_events_url":"https://api.github.com/users/tomasvdw/received_events","type":"User","site_admin":false},"body":"Ported from: https://reviews.bitcoinabc.org/D1072\r\n\r\nReviewed by Amaury Sechet, Shammah Chancellor, Matias Garcia\r\n\r\nThis is preparational for the implementation of UTXO commitments.\r\nSpecification: https://github.com/tomasvdw/bips/blob/master/ecmh.mediawiki","created_at":"2018-05-17T12:31:48Z","updated_at":"2018-05-29T20:14:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dd2f3eb9747670585393857d8a372c44a14cd42","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/425/commits","review_comments_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/425/comments","review_comment_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/425/comments","statuses_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/statuses/f74a8a7794a962a9d9e9d63b1c5341d0bc3350cd","head":{"label":"tomasvdw:ecmh","ref":"ecmh","sha":"f74a8a7794a962a9d9e9d63b1c5341d0bc3350cd","user":{"login":"tomasvdw","id":534388,"avatar_url":"https://avatars1.githubusercontent.com/u/534388?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasvdw","html_url":"https://github.com/tomasvdw","followers_url":"https://api.github.com/users/tomasvdw/followers","following_url":"https://api.github.com/users/tomasvdw/following{/other_user}","gists_url":"https://api.github.com/users/tomasvdw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasvdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasvdw/subscriptions","organizations_url":"https://api.github.com/users/tomasvdw/orgs","repos_url":"https://api.github.com/users/tomasvdw/repos","events_url":"https://api.github.com/users/tomasvdw/events{/privacy}","received_events_url":"https://api.github.com/users/tomasvdw/received_events","type":"User","site_admin":false},"repo":{"id":131142736,"name":"bitcoinxt","full_name":"tomasvdw/bitcoinxt","owner":{"login":"tomasvdw","id":534388,"avatar_url":"https://avatars1.githubusercontent.com/u/534388?v=4","gravatar_id":"","url":"https://api.github.com/users/tomasvdw","html_url":"https://github.com/tomasvdw","followers_url":"https://api.github.com/users/tomasvdw/followers","following_url":"https://api.github.com/users/tomasvdw/following{/other_user}","gists_url":"https://api.github.com/users/tomasvdw/gists{/gist_id}","starred_url":"https://api.github.com/users/tomasvdw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomasvdw/subscriptions","organizations_url":"https://api.github.com/users/tomasvdw/orgs","repos_url":"https://api.github.com/users/tomasvdw/repos","events_url":"https://api.github.com/users/tomasvdw/events{/privacy}","received_events_url":"https://api.github.com/users/tomasvdw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomasvdw/bitcoinxt","description":"Bitcoin XT. Most recent release is H - Bitcoin Cash 2017 Nov Fork","fork":true,"url":"https://api.github.com/repos/tomasvdw/bitcoinxt","forks_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/forks","keys_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/teams","hooks_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/hooks","issue_events_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/issues/events{/number}","events_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/events","assignees_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/assignees{/user}","branches_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/branches{/branch}","tags_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/tags","blobs_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/statuses/{sha}","languages_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/languages","stargazers_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/stargazers","contributors_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/contributors","subscribers_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/subscribers","subscription_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/subscription","commits_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/contents/{+path}","compare_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/merges","archive_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/downloads","issues_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/issues{/number}","pulls_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/pulls{/number}","milestones_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/milestones{/number}","notifications_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/labels{/name}","releases_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/releases{/id}","deployments_url":"https://api.github.com/repos/tomasvdw/bitcoinxt/deployments","created_at":"2018-04-26T10:58:53Z","updated_at":"2018-04-26T10:58:59Z","pushed_at":"2018-05-29T13:49:32Z","git_url":"git://github.com/tomasvdw/bitcoinxt.git","ssh_url":"git@github.com:tomasvdw/bitcoinxt.git","clone_url":"https://github.com/tomasvdw/bitcoinxt.git","svn_url":"https://github.com/tomasvdw/bitcoinxt","homepage":"","size":43713,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoinxt:master","ref":"master","sha":"e4ef63d0d45c9baa258caac784901e8c7d4f2d2c","user":{"login":"bitcoinxt","id":10281400,"avatar_url":"https://avatars3.githubusercontent.com/u/10281400?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinxt","html_url":"https://github.com/bitcoinxt","followers_url":"https://api.github.com/users/bitcoinxt/followers","following_url":"https://api.github.com/users/bitcoinxt/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinxt/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinxt/subscriptions","organizations_url":"https://api.github.com/users/bitcoinxt/orgs","repos_url":"https://api.github.com/users/bitcoinxt/repos","events_url":"https://api.github.com/users/bitcoinxt/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinxt/received_events","type":"Organization","site_admin":false},"repo":{"id":28404361,"name":"bitcoinxt","full_name":"bitcoinxt/bitcoinxt","owner":{"login":"bitcoinxt","id":10281400,"avatar_url":"https://avatars3.githubusercontent.com/u/10281400?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoinxt","html_url":"https://github.com/bitcoinxt","followers_url":"https://api.github.com/users/bitcoinxt/followers","following_url":"https://api.github.com/users/bitcoinxt/following{/other_user}","gists_url":"https://api.github.com/users/bitcoinxt/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoinxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoinxt/subscriptions","organizations_url":"https://api.github.com/users/bitcoinxt/orgs","repos_url":"https://api.github.com/users/bitcoinxt/repos","events_url":"https://api.github.com/users/bitcoinxt/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoinxt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoinxt/bitcoinxt","description":"Bitcoin XT. Most recent release is I - Bitcoin Cash 2018 May Upgrade","fork":false,"url":"https://api.github.com/repos/bitcoinxt/bitcoinxt","forks_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/forks","keys_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/teams","hooks_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/hooks","issue_events_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/events","assignees_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/tags","blobs_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/languages","stargazers_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/stargazers","contributors_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/contributors","subscribers_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/subscribers","subscription_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/subscription","commits_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/merges","archive_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/downloads","issues_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/labels{/name}","releases_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoinxt/bitcoinxt/deployments","created_at":"2014-12-23T15:14:51Z","updated_at":"2018-05-28T20:24:27Z","pushed_at":"2018-05-29T13:49:35Z","git_url":"git://github.com/bitcoinxt/bitcoinxt.git","ssh_url":"git@github.com:bitcoinxt/bitcoinxt.git","clone_url":"https://github.com/bitcoinxt/bitcoinxt.git","svn_url":"https://github.com/bitcoinxt/bitcoinxt","homepage":"","size":43723,"stargazers_count":413,"watchers_count":413,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":142,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":142,"open_issues":22,"watchers":413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/425"},"html":{"href":"https://github.com/bitcoinxt/bitcoinxt/pull/425"},"issue":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/425"},"comments":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoinxt/bitcoinxt/statuses/f74a8a7794a962a9d9e9d63b1c5341d0bc3350cd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dagurval"}}