{"action":"created","issue":{"url":"https://api.github.com/repos/nunit/nunit/issues/2268","repository_url":"https://api.github.com/repos/nunit/nunit","labels_url":"https://api.github.com/repos/nunit/nunit/issues/2268/labels{/name}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/2268/comments","events_url":"https://api.github.com/repos/nunit/nunit/issues/2268/events","html_url":"https://github.com/nunit/nunit/issues/2268","id":236968199,"node_id":"MDU6SXNzdWUyMzY5NjgxOTk=","number":2268,"title":"Standardise behaviour of params and optional arguments across parameterised attributes","user":{"login":"ChrisMaddock","id":4837132,"node_id":"MDQ6VXNlcjQ4MzcxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/4837132?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisMaddock","html_url":"https://github.com/ChrisMaddock","followers_url":"https://api.github.com/users/ChrisMaddock/followers","following_url":"https://api.github.com/users/ChrisMaddock/following{/other_user}","gists_url":"https://api.github.com/users/ChrisMaddock/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisMaddock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisMaddock/subscriptions","organizations_url":"https://api.github.com/users/ChrisMaddock/orgs","repos_url":"https://api.github.com/users/ChrisMaddock/repos","events_url":"https://api.github.com/users/ChrisMaddock/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisMaddock/received_events","type":"User","site_admin":false},"labels":[{"id":61608516,"node_id":"MDU6TGFiZWw2MTYwODUxNg==","url":"https://api.github.com/repos/nunit/nunit/labels/is:enhancement","name":"is:enhancement","color":"84b6eb","default":false},{"id":61616865,"node_id":"MDU6TGFiZWw2MTYxNjg2NQ==","url":"https://api.github.com/repos/nunit/nunit/labels/pri:normal","name":"pri:normal","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"StanEgo","id":1964984,"node_id":"MDQ6VXNlcjE5NjQ5ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1964984?v=4","gravatar_id":"","url":"https://api.github.com/users/StanEgo","html_url":"https://github.com/StanEgo","followers_url":"https://api.github.com/users/StanEgo/followers","following_url":"https://api.github.com/users/StanEgo/following{/other_user}","gists_url":"https://api.github.com/users/StanEgo/gists{/gist_id}","starred_url":"https://api.github.com/users/StanEgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanEgo/subscriptions","organizations_url":"https://api.github.com/users/StanEgo/orgs","repos_url":"https://api.github.com/users/StanEgo/repos","events_url":"https://api.github.com/users/StanEgo/events{/privacy}","received_events_url":"https://api.github.com/users/StanEgo/received_events","type":"User","site_admin":false},"assignees":[{"login":"StanEgo","id":1964984,"node_id":"MDQ6VXNlcjE5NjQ5ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1964984?v=4","gravatar_id":"","url":"https://api.github.com/users/StanEgo","html_url":"https://github.com/StanEgo","followers_url":"https://api.github.com/users/StanEgo/followers","following_url":"https://api.github.com/users/StanEgo/following{/other_user}","gists_url":"https://api.github.com/users/StanEgo/gists{/gist_id}","starred_url":"https://api.github.com/users/StanEgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StanEgo/subscriptions","organizations_url":"https://api.github.com/users/StanEgo/orgs","repos_url":"https://api.github.com/users/StanEgo/repos","events_url":"https://api.github.com/users/StanEgo/events{/privacy}","received_events_url":"https://api.github.com/users/StanEgo/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-06-19T17:45:49Z","updated_at":"2018-08-25T23:39:13Z","closed_at":null,"author_association":"MEMBER","body":"NUnit has various parameterised arguments, which make various special conversions to adjust parameters to match method signatures, to allow invocation via reflection. The key ones I'm thinking of are `[TestCase()]`, `[TestCaseSource()]`, `[TestFixture()]` and `[TestFixtureSource()]`.\r\n\r\nSupport for params and optional arguments between these attributes is inconsistent. Over the years, this has raised various issues:\r\nhttps://github.com/nunit/nunit/issues/1281 (open)\r\nhttps://github.com/nunit/nunit/issues/1883 (open)\r\nhttps://github.com/nunit/nunit/issues/1459 (open)\r\nhttps://github.com/nunit/nunit/issues/1640\r\nhttps://github.com/nunit/nunit/issues/1278\r\nhttps://github.com/nunit/nunit/issues/1282\r\nhttps://github.com/nunit/nunit/issues/257\r\n\r\nWe've talked in a couple of places ([link 1](https://github.com/nunit/nunit/pull/2104), [link 2](https://github.com/nunit/nunit/issues/1281), [link 3](https://github.com/nunit/nunit/pull/1850)) about harmonising this functionality, and having a single utility class, which resolves parameters passed to attributes, and ensures they are handled in a standard manner across all attributes. As I remember - this was something we agreed to go ahead with - @Yarmonov started on a PR in https://github.com/nunit/nunit/pull/2104. (This seems to have gone stale, unfortunately. Will check in on it shortly.) This would mean that the params keyword and optional arguments would be handled in a standard fashion across all of these attributes, meaning no unexpected surprises for the end-user. \r\n\r\nI wanted to create a master issue for this whole idea - as some of the existing open issues are tagged easyfix - and I didn't want anyone to end up implementing any more solutions individually, when we actually want to be sharing the existing functionality between attributes. If @nunit/framework-team agree - I'd like to close the open issues above, and use this as a single issue to reflect the overall plan."},"comment":{"url":"https://api.github.com/repos/nunit/nunit/issues/comments/416003361","html_url":"https://github.com/nunit/nunit/issues/2268#issuecomment-416003361","issue_url":"https://api.github.com/repos/nunit/nunit/issues/2268","id":416003361,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjAwMzM2MQ==","user":{"login":"CharliePoole","id":2678661,"node_id":"MDQ6VXNlcjI2Nzg2NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/2678661?v=4","gravatar_id":"","url":"https://api.github.com/users/CharliePoole","html_url":"https://github.com/CharliePoole","followers_url":"https://api.github.com/users/CharliePoole/followers","following_url":"https://api.github.com/users/CharliePoole/following{/other_user}","gists_url":"https://api.github.com/users/CharliePoole/gists{/gist_id}","starred_url":"https://api.github.com/users/CharliePoole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CharliePoole/subscriptions","organizations_url":"https://api.github.com/users/CharliePoole/orgs","repos_url":"https://api.github.com/users/CharliePoole/repos","events_url":"https://api.github.com/users/CharliePoole/events{/privacy}","received_events_url":"https://api.github.com/users/CharliePoole/received_events","type":"User","site_admin":false},"created_at":"2018-08-25T23:39:13Z","updated_at":"2018-08-25T23:39:13Z","author_association":"MEMBER","body":"I just ran into this WRT `TestCaseSoureAttribute` it turns out I cannot leave the final argument in `TestCaseData`. Looks like I have to provide an empty array, whereas I can just leave it out for `TestCaseAttribute`. \r\n\r\nThis feels like a regression, but it may be a very old one - perhaps from day 1 of NUnit 3. \r\n\r\nSince I don't work on two things at the same time, I'm working around this for now."}}
{"actor":{"display_login":"CharliePoole"}}