{"action":"closed","number":3925,"pull_request":{"url":"https://api.github.com/repos/Homebrew/brew/pulls/3925","id":175094321,"html_url":"https://github.com/Homebrew/brew/pull/3925","diff_url":"https://github.com/Homebrew/brew/pull/3925.diff","patch_url":"https://github.com/Homebrew/brew/pull/3925.patch","issue_url":"https://api.github.com/repos/Homebrew/brew/issues/3925","number":3925,"state":"closed","locked":false,"title":"append ? to git_remote_exists","user":{"login":"maxim-belkin","id":13123663,"avatar_url":"https://avatars2.githubusercontent.com/u/13123663?v=4","gravatar_id":"","url":"https://api.github.com/users/maxim-belkin","html_url":"https://github.com/maxim-belkin","followers_url":"https://api.github.com/users/maxim-belkin/followers","following_url":"https://api.github.com/users/maxim-belkin/following{/other_user}","gists_url":"https://api.github.com/users/maxim-belkin/gists{/gist_id}","starred_url":"https://api.github.com/users/maxim-belkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxim-belkin/subscriptions","organizations_url":"https://api.github.com/users/maxim-belkin/orgs","repos_url":"https://api.github.com/users/maxim-belkin/repos","events_url":"https://api.github.com/users/maxim-belkin/events{/privacy}","received_events_url":"https://api.github.com/users/maxim-belkin/received_events","type":"User","site_admin":false},"body":"- [x] Have you followed the guidelines in our [Contributing](https://github.com/Homebrew/brew/blob/master/CONTRIBUTING.md) document?\r\n- [x] Have you checked to ensure there aren't other open [Pull Requests](https://github.com/Homebrew/brew/pulls) for the same change?\r\n- [x] Have you added an explanation of what your changes do and why you'd like us to include them?\r\n- [ ] Have you written new tests for your changes? [Here's an example](https://github.com/Homebrew/homebrew/pull/49031).\r\n- [x] Have you successfully run `brew style` with your changes locally?\r\n- [x] Have you successfully run `brew tests` with your changes locally?\r\n\r\n-----\r\n\r\n`git_remote_exists` returns boolean, so appending `?` to its name makes a lot of sense.\r\n\r\nPossible additional change: remove parentheses here:   https://github.com/Homebrew/brew/blob/96fd1a8c2a7a5680c1ce611415018a2c642ba3e4/Library/Homebrew/utils/git.rb#L70","created_at":"2018-03-14T21:46:18Z","updated_at":"2018-03-15T08:20:16Z","closed_at":"2018-03-15T08:20:15Z","merged_at":"2018-03-15T08:20:15Z","merge_commit_sha":"cb6828dbe60763dee8c15efdb672575c0f8028f7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Homebrew/brew/pulls/3925/commits","review_comments_url":"https://api.github.com/repos/Homebrew/brew/pulls/3925/comments","review_comment_url":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Homebrew/brew/issues/3925/comments","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/f984701c2981984f387ff5d6622afa5fefb3317a","head":{"label":"maxim-belkin:git_remote_exists_bool","ref":"git_remote_exists_bool","sha":"f984701c2981984f387ff5d6622afa5fefb3317a","user":{"login":"maxim-belkin","id":13123663,"avatar_url":"https://avatars2.githubusercontent.com/u/13123663?v=4","gravatar_id":"","url":"https://api.github.com/users/maxim-belkin","html_url":"https://github.com/maxim-belkin","followers_url":"https://api.github.com/users/maxim-belkin/followers","following_url":"https://api.github.com/users/maxim-belkin/following{/other_user}","gists_url":"https://api.github.com/users/maxim-belkin/gists{/gist_id}","starred_url":"https://api.github.com/users/maxim-belkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxim-belkin/subscriptions","organizations_url":"https://api.github.com/users/maxim-belkin/orgs","repos_url":"https://api.github.com/users/maxim-belkin/repos","events_url":"https://api.github.com/users/maxim-belkin/events{/privacy}","received_events_url":"https://api.github.com/users/maxim-belkin/received_events","type":"User","site_admin":false},"repo":{"id":101780676,"name":"homebrew","full_name":"maxim-belkin/homebrew","owner":{"login":"maxim-belkin","id":13123663,"avatar_url":"https://avatars2.githubusercontent.com/u/13123663?v=4","gravatar_id":"","url":"https://api.github.com/users/maxim-belkin","html_url":"https://github.com/maxim-belkin","followers_url":"https://api.github.com/users/maxim-belkin/followers","following_url":"https://api.github.com/users/maxim-belkin/following{/other_user}","gists_url":"https://api.github.com/users/maxim-belkin/gists{/gist_id}","starred_url":"https://api.github.com/users/maxim-belkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxim-belkin/subscriptions","organizations_url":"https://api.github.com/users/maxim-belkin/orgs","repos_url":"https://api.github.com/users/maxim-belkin/repos","events_url":"https://api.github.com/users/maxim-belkin/events{/privacy}","received_events_url":"https://api.github.com/users/maxim-belkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxim-belkin/homebrew","description":"🍺 The missing package manager for macOS","fork":true,"url":"https://api.github.com/repos/maxim-belkin/homebrew","forks_url":"https://api.github.com/repos/maxim-belkin/homebrew/forks","keys_url":"https://api.github.com/repos/maxim-belkin/homebrew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxim-belkin/homebrew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxim-belkin/homebrew/teams","hooks_url":"https://api.github.com/repos/maxim-belkin/homebrew/hooks","issue_events_url":"https://api.github.com/repos/maxim-belkin/homebrew/issues/events{/number}","events_url":"https://api.github.com/repos/maxim-belkin/homebrew/events","assignees_url":"https://api.github.com/repos/maxim-belkin/homebrew/assignees{/user}","branches_url":"https://api.github.com/repos/maxim-belkin/homebrew/branches{/branch}","tags_url":"https://api.github.com/repos/maxim-belkin/homebrew/tags","blobs_url":"https://api.github.com/repos/maxim-belkin/homebrew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxim-belkin/homebrew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxim-belkin/homebrew/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxim-belkin/homebrew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxim-belkin/homebrew/statuses/{sha}","languages_url":"https://api.github.com/repos/maxim-belkin/homebrew/languages","stargazers_url":"https://api.github.com/repos/maxim-belkin/homebrew/stargazers","contributors_url":"https://api.github.com/repos/maxim-belkin/homebrew/contributors","subscribers_url":"https://api.github.com/repos/maxim-belkin/homebrew/subscribers","subscription_url":"https://api.github.com/repos/maxim-belkin/homebrew/subscription","commits_url":"https://api.github.com/repos/maxim-belkin/homebrew/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxim-belkin/homebrew/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxim-belkin/homebrew/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxim-belkin/homebrew/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxim-belkin/homebrew/contents/{+path}","compare_url":"https://api.github.com/repos/maxim-belkin/homebrew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxim-belkin/homebrew/merges","archive_url":"https://api.github.com/repos/maxim-belkin/homebrew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxim-belkin/homebrew/downloads","issues_url":"https://api.github.com/repos/maxim-belkin/homebrew/issues{/number}","pulls_url":"https://api.github.com/repos/maxim-belkin/homebrew/pulls{/number}","milestones_url":"https://api.github.com/repos/maxim-belkin/homebrew/milestones{/number}","notifications_url":"https://api.github.com/repos/maxim-belkin/homebrew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxim-belkin/homebrew/labels{/name}","releases_url":"https://api.github.com/repos/maxim-belkin/homebrew/releases{/id}","deployments_url":"https://api.github.com/repos/maxim-belkin/homebrew/deployments","created_at":"2017-08-29T16:06:48Z","updated_at":"2018-03-14T21:31:53Z","pushed_at":"2018-03-15T08:07:02Z","git_url":"git://github.com/maxim-belkin/homebrew.git","ssh_url":"git@github.com:maxim-belkin/homebrew.git","clone_url":"https://github.com/maxim-belkin/homebrew.git","svn_url":"https://github.com/maxim-belkin/homebrew","homepage":"https://brew.sh","size":23028,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Homebrew:master","ref":"master","sha":"96fd1a8c2a7a5680c1ce611415018a2c642ba3e4","user":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"repo":{"id":53238813,"name":"brew","full_name":"Homebrew/brew","owner":{"login":"Homebrew","id":1503512,"avatar_url":"https://avatars2.githubusercontent.com/u/1503512?v=4","gravatar_id":"","url":"https://api.github.com/users/Homebrew","html_url":"https://github.com/Homebrew","followers_url":"https://api.github.com/users/Homebrew/followers","following_url":"https://api.github.com/users/Homebrew/following{/other_user}","gists_url":"https://api.github.com/users/Homebrew/gists{/gist_id}","starred_url":"https://api.github.com/users/Homebrew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Homebrew/subscriptions","organizations_url":"https://api.github.com/users/Homebrew/orgs","repos_url":"https://api.github.com/users/Homebrew/repos","events_url":"https://api.github.com/users/Homebrew/events{/privacy}","received_events_url":"https://api.github.com/users/Homebrew/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Homebrew/brew","description":"🍺 The missing package manager for macOS","fork":false,"url":"https://api.github.com/repos/Homebrew/brew","forks_url":"https://api.github.com/repos/Homebrew/brew/forks","keys_url":"https://api.github.com/repos/Homebrew/brew/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Homebrew/brew/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Homebrew/brew/teams","hooks_url":"https://api.github.com/repos/Homebrew/brew/hooks","issue_events_url":"https://api.github.com/repos/Homebrew/brew/issues/events{/number}","events_url":"https://api.github.com/repos/Homebrew/brew/events","assignees_url":"https://api.github.com/repos/Homebrew/brew/assignees{/user}","branches_url":"https://api.github.com/repos/Homebrew/brew/branches{/branch}","tags_url":"https://api.github.com/repos/Homebrew/brew/tags","blobs_url":"https://api.github.com/repos/Homebrew/brew/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Homebrew/brew/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Homebrew/brew/git/refs{/sha}","trees_url":"https://api.github.com/repos/Homebrew/brew/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Homebrew/brew/statuses/{sha}","languages_url":"https://api.github.com/repos/Homebrew/brew/languages","stargazers_url":"https://api.github.com/repos/Homebrew/brew/stargazers","contributors_url":"https://api.github.com/repos/Homebrew/brew/contributors","subscribers_url":"https://api.github.com/repos/Homebrew/brew/subscribers","subscription_url":"https://api.github.com/repos/Homebrew/brew/subscription","commits_url":"https://api.github.com/repos/Homebrew/brew/commits{/sha}","git_commits_url":"https://api.github.com/repos/Homebrew/brew/git/commits{/sha}","comments_url":"https://api.github.com/repos/Homebrew/brew/comments{/number}","issue_comment_url":"https://api.github.com/repos/Homebrew/brew/issues/comments{/number}","contents_url":"https://api.github.com/repos/Homebrew/brew/contents/{+path}","compare_url":"https://api.github.com/repos/Homebrew/brew/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Homebrew/brew/merges","archive_url":"https://api.github.com/repos/Homebrew/brew/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Homebrew/brew/downloads","issues_url":"https://api.github.com/repos/Homebrew/brew/issues{/number}","pulls_url":"https://api.github.com/repos/Homebrew/brew/pulls{/number}","milestones_url":"https://api.github.com/repos/Homebrew/brew/milestones{/number}","notifications_url":"https://api.github.com/repos/Homebrew/brew/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Homebrew/brew/labels{/name}","releases_url":"https://api.github.com/repos/Homebrew/brew/releases{/id}","deployments_url":"https://api.github.com/repos/Homebrew/brew/deployments","created_at":"2016-03-06T05:08:38Z","updated_at":"2018-03-15T08:19:59Z","pushed_at":"2018-03-15T08:20:15Z","git_url":"git://github.com/Homebrew/brew.git","ssh_url":"git@github.com:Homebrew/brew.git","clone_url":"https://github.com/Homebrew/brew.git","svn_url":"https://github.com/Homebrew/brew","homepage":"https://brew.sh","size":23012,"stargazers_count":11432,"watchers_count":11432,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2710,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":2710,"open_issues":30,"watchers":11432,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3925"},"html":{"href":"https://github.com/Homebrew/brew/pull/3925"},"issue":{"href":"https://api.github.com/repos/Homebrew/brew/issues/3925"},"comments":{"href":"https://api.github.com/repos/Homebrew/brew/issues/3925/comments"},"review_comments":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3925/comments"},"review_comment":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Homebrew/brew/pulls/3925/commits"},"statuses":{"href":"https://api.github.com/repos/Homebrew/brew/statuses/f984701c2981984f387ff5d6622afa5fefb3317a"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MikeMcQuaid","id":125011,"avatar_url":"https://avatars2.githubusercontent.com/u/125011?v=4","gravatar_id":"","url":"https://api.github.com/users/MikeMcQuaid","html_url":"https://github.com/MikeMcQuaid","followers_url":"https://api.github.com/users/MikeMcQuaid/followers","following_url":"https://api.github.com/users/MikeMcQuaid/following{/other_user}","gists_url":"https://api.github.com/users/MikeMcQuaid/gists{/gist_id}","starred_url":"https://api.github.com/users/MikeMcQuaid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikeMcQuaid/subscriptions","organizations_url":"https://api.github.com/users/MikeMcQuaid/orgs","repos_url":"https://api.github.com/users/MikeMcQuaid/repos","events_url":"https://api.github.com/users/MikeMcQuaid/events{/privacy}","received_events_url":"https://api.github.com/users/MikeMcQuaid/received_events","type":"User","site_admin":true},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"MikeMcQuaid"}}