{"action":"created","comment":{"url":"https://api.github.com/repos/square/misk/pulls/comments/170143829","pull_request_review_id":98787588,"id":170143829,"diff_hunk":"@@ -18,9 +15,10 @@ import javax.inject.Named\n \n @MiskTest\n class ConfigTest {\n+    val config = MiskConfig.load<TestConfig>(TestConfig::class.java, \"test_app\", TESTING)","path":"misk/src/test/kotlin/misk/config/ConfigTest.kt","position":16,"original_position":16,"commit_id":"a358e98862c444afc9cde8b5bf546ef5be351035","original_commit_id":"a358e98862c444afc9cde8b5bf546ef5be351035","user":{"login":"mmihic","id":392793,"avatar_url":"https://avatars0.githubusercontent.com/u/392793?v=4","gravatar_id":"","url":"https://api.github.com/users/mmihic","html_url":"https://github.com/mmihic","followers_url":"https://api.github.com/users/mmihic/followers","following_url":"https://api.github.com/users/mmihic/following{/other_user}","gists_url":"https://api.github.com/users/mmihic/gists{/gist_id}","starred_url":"https://api.github.com/users/mmihic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmihic/subscriptions","organizations_url":"https://api.github.com/users/mmihic/orgs","repos_url":"https://api.github.com/users/mmihic/repos","events_url":"https://api.github.com/users/mmihic/events{/privacy}","received_events_url":"https://api.github.com/users/mmihic/received_events","type":"User","site_admin":false},"body":"It should. But also, see above comments on using an inlined reified version for this.","created_at":"2018-02-23T01:25:02Z","updated_at":"2018-02-23T01:28:58Z","html_url":"https://github.com/square/misk/pull/110#discussion_r170143829","pull_request_url":"https://api.github.com/repos/square/misk/pulls/110","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/square/misk/pulls/comments/170143829"},"html":{"href":"https://github.com/square/misk/pull/110#discussion_r170143829"},"pull_request":{"href":"https://api.github.com/repos/square/misk/pulls/110"}},"in_reply_to_id":170133609},"pull_request":{"url":"https://api.github.com/repos/square/misk/pulls/110","id":170892650,"html_url":"https://github.com/square/misk/pull/110","diff_url":"https://github.com/square/misk/pull/110.diff","patch_url":"https://github.com/square/misk/pull/110.patch","issue_url":"https://api.github.com/repos/square/misk/issues/110","number":110,"state":"open","locked":false,"title":"Pass app config to interested modules instead of injecting","user":{"login":"nbroyles","id":177053,"avatar_url":"https://avatars2.githubusercontent.com/u/177053?v=4","gravatar_id":"","url":"https://api.github.com/users/nbroyles","html_url":"https://github.com/nbroyles","followers_url":"https://api.github.com/users/nbroyles/followers","following_url":"https://api.github.com/users/nbroyles/following{/other_user}","gists_url":"https://api.github.com/users/nbroyles/gists{/gist_id}","starred_url":"https://api.github.com/users/nbroyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbroyles/subscriptions","organizations_url":"https://api.github.com/users/nbroyles/orgs","repos_url":"https://api.github.com/users/nbroyles/repos","events_url":"https://api.github.com/users/nbroyles/events{/privacy}","received_events_url":"https://api.github.com/users/nbroyles/received_events","type":"User","site_admin":false},"body":"This will allow us to install Modules based on configuration values without needing to do two-phase/bootstrapping injection.","created_at":"2018-02-22T23:12:11Z","updated_at":"2018-02-23T01:28:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe530955feb7c3f40471b6dc15f9ddd5188b801e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"swankjesse","id":133019,"avatar_url":"https://avatars3.githubusercontent.com/u/133019?v=4","gravatar_id":"","url":"https://api.github.com/users/swankjesse","html_url":"https://github.com/swankjesse","followers_url":"https://api.github.com/users/swankjesse/followers","following_url":"https://api.github.com/users/swankjesse/following{/other_user}","gists_url":"https://api.github.com/users/swankjesse/gists{/gist_id}","starred_url":"https://api.github.com/users/swankjesse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swankjesse/subscriptions","organizations_url":"https://api.github.com/users/swankjesse/orgs","repos_url":"https://api.github.com/users/swankjesse/repos","events_url":"https://api.github.com/users/swankjesse/events{/privacy}","received_events_url":"https://api.github.com/users/swankjesse/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/square/misk/pulls/110/commits","review_comments_url":"https://api.github.com/repos/square/misk/pulls/110/comments","review_comment_url":"https://api.github.com/repos/square/misk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/misk/issues/110/comments","statuses_url":"https://api.github.com/repos/square/misk/statuses/a358e98862c444afc9cde8b5bf546ef5be351035","head":{"label":"square:nb/simply-config-loading","ref":"nb/simply-config-loading","sha":"a358e98862c444afc9cde8b5bf546ef5be351035","user":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":113107217,"name":"misk","full_name":"square/misk","owner":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/misk","description":null,"fork":false,"url":"https://api.github.com/repos/square/misk","forks_url":"https://api.github.com/repos/square/misk/forks","keys_url":"https://api.github.com/repos/square/misk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/misk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/misk/teams","hooks_url":"https://api.github.com/repos/square/misk/hooks","issue_events_url":"https://api.github.com/repos/square/misk/issues/events{/number}","events_url":"https://api.github.com/repos/square/misk/events","assignees_url":"https://api.github.com/repos/square/misk/assignees{/user}","branches_url":"https://api.github.com/repos/square/misk/branches{/branch}","tags_url":"https://api.github.com/repos/square/misk/tags","blobs_url":"https://api.github.com/repos/square/misk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/misk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/misk/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/misk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/misk/statuses/{sha}","languages_url":"https://api.github.com/repos/square/misk/languages","stargazers_url":"https://api.github.com/repos/square/misk/stargazers","contributors_url":"https://api.github.com/repos/square/misk/contributors","subscribers_url":"https://api.github.com/repos/square/misk/subscribers","subscription_url":"https://api.github.com/repos/square/misk/subscription","commits_url":"https://api.github.com/repos/square/misk/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/misk/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/misk/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/misk/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/misk/contents/{+path}","compare_url":"https://api.github.com/repos/square/misk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/misk/merges","archive_url":"https://api.github.com/repos/square/misk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/misk/downloads","issues_url":"https://api.github.com/repos/square/misk/issues{/number}","pulls_url":"https://api.github.com/repos/square/misk/pulls{/number}","milestones_url":"https://api.github.com/repos/square/misk/milestones{/number}","notifications_url":"https://api.github.com/repos/square/misk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/misk/labels{/name}","releases_url":"https://api.github.com/repos/square/misk/releases{/id}","deployments_url":"https://api.github.com/repos/square/misk/deployments","created_at":"2017-12-04T23:31:52Z","updated_at":"2018-02-21T01:54:49Z","pushed_at":"2018-02-22T23:12:12Z","git_url":"git://github.com/square/misk.git","ssh_url":"git@github.com:square/misk.git","clone_url":"https://github.com/square/misk.git","svn_url":"https://github.com/square/misk","homepage":null,"size":628,"stargazers_count":34,"watchers_count":34,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":27,"license":null,"forks":5,"open_issues":27,"watchers":34,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"06534c647b764e7ebfba05e93cf13b6a0c5bd33f","user":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":113107217,"name":"misk","full_name":"square/misk","owner":{"login":"square","id":82592,"avatar_url":"https://avatars0.githubusercontent.com/u/82592?v=4","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/misk","description":null,"fork":false,"url":"https://api.github.com/repos/square/misk","forks_url":"https://api.github.com/repos/square/misk/forks","keys_url":"https://api.github.com/repos/square/misk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/misk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/misk/teams","hooks_url":"https://api.github.com/repos/square/misk/hooks","issue_events_url":"https://api.github.com/repos/square/misk/issues/events{/number}","events_url":"https://api.github.com/repos/square/misk/events","assignees_url":"https://api.github.com/repos/square/misk/assignees{/user}","branches_url":"https://api.github.com/repos/square/misk/branches{/branch}","tags_url":"https://api.github.com/repos/square/misk/tags","blobs_url":"https://api.github.com/repos/square/misk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/misk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/misk/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/misk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/misk/statuses/{sha}","languages_url":"https://api.github.com/repos/square/misk/languages","stargazers_url":"https://api.github.com/repos/square/misk/stargazers","contributors_url":"https://api.github.com/repos/square/misk/contributors","subscribers_url":"https://api.github.com/repos/square/misk/subscribers","subscription_url":"https://api.github.com/repos/square/misk/subscription","commits_url":"https://api.github.com/repos/square/misk/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/misk/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/misk/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/misk/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/misk/contents/{+path}","compare_url":"https://api.github.com/repos/square/misk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/misk/merges","archive_url":"https://api.github.com/repos/square/misk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/misk/downloads","issues_url":"https://api.github.com/repos/square/misk/issues{/number}","pulls_url":"https://api.github.com/repos/square/misk/pulls{/number}","milestones_url":"https://api.github.com/repos/square/misk/milestones{/number}","notifications_url":"https://api.github.com/repos/square/misk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/misk/labels{/name}","releases_url":"https://api.github.com/repos/square/misk/releases{/id}","deployments_url":"https://api.github.com/repos/square/misk/deployments","created_at":"2017-12-04T23:31:52Z","updated_at":"2018-02-21T01:54:49Z","pushed_at":"2018-02-22T23:12:12Z","git_url":"git://github.com/square/misk.git","ssh_url":"git@github.com:square/misk.git","clone_url":"https://github.com/square/misk.git","svn_url":"https://github.com/square/misk","homepage":null,"size":628,"stargazers_count":34,"watchers_count":34,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":27,"license":null,"forks":5,"open_issues":27,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/misk/pulls/110"},"html":{"href":"https://github.com/square/misk/pull/110"},"issue":{"href":"https://api.github.com/repos/square/misk/issues/110"},"comments":{"href":"https://api.github.com/repos/square/misk/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/square/misk/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/square/misk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/misk/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/square/misk/statuses/a358e98862c444afc9cde8b5bf546ef5be351035"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mmihic"}}