{"action":"closed","number":14429,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/14429","id":195063110,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDYzMTEw","html_url":"https://github.com/brave/browser-laptop/pull/14429","diff_url":"https://github.com/brave/browser-laptop/pull/14429.diff","patch_url":"https://github.com/brave/browser-laptop/pull/14429.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/14429","number":14429,"state":"closed","locked":false,"title":"Avoid depending on requests module in python unittests","user":{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false},"body":"Git push will fail if the python requests module isn't installed on the local machine. This mocks that import since it isn't needed for the tests.\r\n\r\n## Submitter Checklist:\r\n\r\n- [ ] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [ ] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review). (Ask a Brave employee to help if you cannot access this document.)\r\n\r\n## Test Plan:\r\n\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review) if one was not already requested.\r\n\r\nTests\r\n\r\n\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n- [ ] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\n\r\n","created_at":"2018-06-15T02:22:44Z","updated_at":"2018-06-15T06:57:13Z","closed_at":"2018-06-15T06:57:13Z","merged_at":"2018-06-15T06:57:13Z","merge_commit_sha":"dfe01d9d5c6293a9e927a1c4f7000516f28de6e1","assignee":{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false},"assignees":[{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"petemill","id":741836,"node_id":"MDQ6VXNlcjc0MTgzNg==","avatar_url":"https://avatars1.githubusercontent.com/u/741836?v=4","gravatar_id":"","url":"https://api.github.com/users/petemill","html_url":"https://github.com/petemill","followers_url":"https://api.github.com/users/petemill/followers","following_url":"https://api.github.com/users/petemill/following{/other_user}","gists_url":"https://api.github.com/users/petemill/gists{/gist_id}","starred_url":"https://api.github.com/users/petemill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petemill/subscriptions","organizations_url":"https://api.github.com/users/petemill/orgs","repos_url":"https://api.github.com/users/petemill/repos","events_url":"https://api.github.com/users/petemill/events{/privacy}","received_events_url":"https://api.github.com/users/petemill/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/101","html_url":"https://github.com/brave/browser-laptop/milestone/101","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/101/labels","id":3075051,"node_id":"MDk6TWlsZXN0b25lMzA3NTA1MQ==","number":101,"title":"0.23.x (Beta Channel)","description":"Tor private tabs","creator":{"login":"bbondy","id":831718,"node_id":"MDQ6VXNlcjgzMTcxOA==","avatar_url":"https://avatars2.githubusercontent.com/u/831718?v=4","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":186,"state":"open","created_at":"2018-01-30T14:27:04Z","updated_at":"2018-06-15T06:57:13Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/14429/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/14429/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/14429/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/e95b60f96661481624339b04bdae539205bf5d24","head":{"label":"RyanJarv:fix/cibuild-draft-upload","ref":"fix/cibuild-draft-upload","sha":"e95b60f96661481624339b04bdae539205bf5d24","user":{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false},"repo":{"id":127033207,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwMzMyMDc=","name":"browser-laptop","full_name":"RyanJarv/browser-laptop","owner":{"login":"RyanJarv","id":4079939,"node_id":"MDQ6VXNlcjQwNzk5Mzk=","avatar_url":"https://avatars3.githubusercontent.com/u/4079939?v=4","gravatar_id":"","url":"https://api.github.com/users/RyanJarv","html_url":"https://github.com/RyanJarv","followers_url":"https://api.github.com/users/RyanJarv/followers","following_url":"https://api.github.com/users/RyanJarv/following{/other_user}","gists_url":"https://api.github.com/users/RyanJarv/gists{/gist_id}","starred_url":"https://api.github.com/users/RyanJarv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RyanJarv/subscriptions","organizations_url":"https://api.github.com/users/RyanJarv/orgs","repos_url":"https://api.github.com/users/RyanJarv/repos","events_url":"https://api.github.com/users/RyanJarv/events{/privacy}","received_events_url":"https://api.github.com/users/RyanJarv/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RyanJarv/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/RyanJarv/browser-laptop","forks_url":"https://api.github.com/repos/RyanJarv/browser-laptop/forks","keys_url":"https://api.github.com/repos/RyanJarv/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RyanJarv/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RyanJarv/browser-laptop/teams","hooks_url":"https://api.github.com/repos/RyanJarv/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/RyanJarv/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/RyanJarv/browser-laptop/events","assignees_url":"https://api.github.com/repos/RyanJarv/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/RyanJarv/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/RyanJarv/browser-laptop/tags","blobs_url":"https://api.github.com/repos/RyanJarv/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RyanJarv/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RyanJarv/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/RyanJarv/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RyanJarv/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/RyanJarv/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/RyanJarv/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/RyanJarv/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/RyanJarv/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/RyanJarv/browser-laptop/subscription","commits_url":"https://api.github.com/repos/RyanJarv/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/RyanJarv/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/RyanJarv/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/RyanJarv/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/RyanJarv/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/RyanJarv/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RyanJarv/browser-laptop/merges","archive_url":"https://api.github.com/repos/RyanJarv/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RyanJarv/browser-laptop/downloads","issues_url":"https://api.github.com/repos/RyanJarv/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/RyanJarv/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/RyanJarv/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/RyanJarv/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RyanJarv/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/RyanJarv/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/RyanJarv/browser-laptop/deployments","created_at":"2018-03-27T19:02:19Z","updated_at":"2018-03-27T19:02:25Z","pushed_at":"2018-06-15T02:29:17Z","git_url":"git://github.com/RyanJarv/browser-laptop.git","ssh_url":"git@github.com:RyanJarv/browser-laptop.git","clone_url":"https://github.com/RyanJarv/browser-laptop.git","svn_url":"https://github.com/RyanJarv/browser-laptop","homepage":"https://www.brave.com","size":86035,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"5824d73c60c710b8c67560dd2610d1d8be7c9731","user":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"node_id":"MDEwOlJlcG9zaXRvcnk0Njg5MTk5Nw==","name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzAxNjE5","avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2018-06-15T03:52:23Z","pushed_at":"2018-06-15T06:57:13Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":90329,"stargazers_count":7637,"watchers_count":7637,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1010,"mirror_url":null,"archived":false,"open_issues_count":2751,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1010,"open_issues":2751,"watchers":7637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/14429"},"html":{"href":"https://github.com/brave/browser-laptop/pull/14429"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/14429"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/14429/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/14429/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/14429/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/e95b60f96661481624339b04bdae539205bf5d24"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bsclifton","id":4733304,"node_id":"MDQ6VXNlcjQ3MzMzMDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":9,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"bsclifton"}}