{"action":"created","issue":{"url":"https://api.github.com/repos/loot/loot-api/issues/22","repository_url":"https://api.github.com/repos/loot/loot-api","labels_url":"https://api.github.com/repos/loot/loot-api/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/loot/loot-api/issues/22/comments","events_url":"https://api.github.com/repos/loot/loot-api/issues/22/events","html_url":"https://github.com/loot/loot-api/issues/22","id":316157862,"number":22,"title":"Avoid adding group metadata for plugins that load after other plugins that are in groups","user":{"login":"WrinklyNinja","id":2430738,"avatar_url":"https://avatars0.githubusercontent.com/u/2430738?v=4","gravatar_id":"","url":"https://api.github.com/users/WrinklyNinja","html_url":"https://github.com/WrinklyNinja","followers_url":"https://api.github.com/users/WrinklyNinja/followers","following_url":"https://api.github.com/users/WrinklyNinja/following{/other_user}","gists_url":"https://api.github.com/users/WrinklyNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/WrinklyNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WrinklyNinja/subscriptions","organizations_url":"https://api.github.com/users/WrinklyNinja/orgs","repos_url":"https://api.github.com/users/WrinklyNinja/repos","events_url":"https://api.github.com/users/WrinklyNinja/events{/privacy}","received_events_url":"https://api.github.com/users/WrinklyNinja/received_events","type":"User","site_admin":false},"labels":[{"id":536806264,"url":"https://api.github.com/repos/loot/loot-api/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":{"login":"WrinklyNinja","id":2430738,"avatar_url":"https://avatars0.githubusercontent.com/u/2430738?v=4","gravatar_id":"","url":"https://api.github.com/users/WrinklyNinja","html_url":"https://github.com/WrinklyNinja","followers_url":"https://api.github.com/users/WrinklyNinja/followers","following_url":"https://api.github.com/users/WrinklyNinja/following{/other_user}","gists_url":"https://api.github.com/users/WrinklyNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/WrinklyNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WrinklyNinja/subscriptions","organizations_url":"https://api.github.com/users/WrinklyNinja/orgs","repos_url":"https://api.github.com/users/WrinklyNinja/repos","events_url":"https://api.github.com/users/WrinklyNinja/events{/privacy}","received_events_url":"https://api.github.com/users/WrinklyNinja/received_events","type":"User","site_admin":false},"assignees":[{"login":"WrinklyNinja","id":2430738,"avatar_url":"https://avatars0.githubusercontent.com/u/2430738?v=4","gravatar_id":"","url":"https://api.github.com/users/WrinklyNinja","html_url":"https://github.com/WrinklyNinja","followers_url":"https://api.github.com/users/WrinklyNinja/followers","following_url":"https://api.github.com/users/WrinklyNinja/following{/other_user}","gists_url":"https://api.github.com/users/WrinklyNinja/gists{/gist_id}","starred_url":"https://api.github.com/users/WrinklyNinja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WrinklyNinja/subscriptions","organizations_url":"https://api.github.com/users/WrinklyNinja/orgs","repos_url":"https://api.github.com/users/WrinklyNinja/repos","events_url":"https://api.github.com/users/WrinklyNinja/events{/privacy}","received_events_url":"https://api.github.com/users/WrinklyNinja/received_events","type":"User","site_admin":false}],"milestone":null,"comments":24,"created_at":"2018-04-20T07:31:29Z","updated_at":"2018-05-15T09:07:04Z","closed_at":null,"author_association":"MEMBER","body":"Consider the situation with plugins `A.esp`, `B.esp`, `C.esp` and `A - B patch.esp`, where:\r\n\r\n- `A` and `A - B patch.esp` are in the `default` group.\r\n- `C.esp` is in the `mid` group.\r\n- `B.esp` is in the `late` group.\r\n- The `mid` group loads after the `default` group.\r\n- The `late` group loads after the `mid` group.\r\n- `A - B patch.esp` has `B.esp` as a master.\r\n\r\nThis causes a cycle that LOOT won't break because the group metadata is valid in group-isolation (i.e. with no other group metadata applied).\r\n\r\nThe intuitive solution is to ignore `A - B patch.esp`'s group because it has higher-priority metadata causing it to load after a later group, but that is basically the same as priority inheritance was, and in practice that was generally confusing and unintuitive. You can end up with a chain of inherited groups/priorities (say something had metadata to load after the patch) that cause the resulting derived metadata to bear little resemblance to the input metadata.\r\n\r\nThere may be a better way to generally implement the intuitive solution, or it may be better just to decide that `A - B patch.esp` needs to have metadata adding it to the `late` group (or any group that `mid` doesn't load after)."},"comment":{"url":"https://api.github.com/repos/loot/loot-api/issues/comments/389097554","html_url":"https://github.com/loot/loot-api/issues/22#issuecomment-389097554","issue_url":"https://api.github.com/repos/loot/loot-api/issues/22","id":389097554,"user":{"login":"ArtaiosGreybark","id":24878945,"avatar_url":"https://avatars0.githubusercontent.com/u/24878945?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtaiosGreybark","html_url":"https://github.com/ArtaiosGreybark","followers_url":"https://api.github.com/users/ArtaiosGreybark/followers","following_url":"https://api.github.com/users/ArtaiosGreybark/following{/other_user}","gists_url":"https://api.github.com/users/ArtaiosGreybark/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtaiosGreybark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtaiosGreybark/subscriptions","organizations_url":"https://api.github.com/users/ArtaiosGreybark/orgs","repos_url":"https://api.github.com/users/ArtaiosGreybark/repos","events_url":"https://api.github.com/users/ArtaiosGreybark/events{/privacy}","received_events_url":"https://api.github.com/users/ArtaiosGreybark/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T09:07:04Z","updated_at":"2018-05-15T09:07:04Z","author_association":"NONE","body":"Bummer. This stops the groups version from working at all for me now that I installed MLU."}}
{"actor":{"display_login":"ArtaiosGreybark"}}