{"action":"created","issue":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5924","repository_url":"https://api.github.com/repos/MetaMask/metamask-extension","labels_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5924/labels{/name}","comments_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5924/comments","events_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5924/events","html_url":"https://github.com/MetaMask/metamask-extension/pull/5924","id":390466977,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjI3NjY2","number":5924,"title":"Disallow loading as metamaskNetworkId","user":{"login":"frankiebee","id":11225267,"node_id":"MDQ6VXNlcjExMjI1MjY3","avatar_url":"https://avatars0.githubusercontent.com/u/11225267?v=4","gravatar_id":"","url":"https://api.github.com/users/frankiebee","html_url":"https://github.com/frankiebee","followers_url":"https://api.github.com/users/frankiebee/followers","following_url":"https://api.github.com/users/frankiebee/following{/other_user}","gists_url":"https://api.github.com/users/frankiebee/gists{/gist_id}","starred_url":"https://api.github.com/users/frankiebee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankiebee/subscriptions","organizations_url":"https://api.github.com/users/frankiebee/orgs","repos_url":"https://api.github.com/users/frankiebee/repos","events_url":"https://api.github.com/users/frankiebee/events{/privacy}","received_events_url":"https://api.github.com/users/frankiebee/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-13T00:27:07Z","updated_at":"2018-12-13T15:56:44Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/pulls/5924","html_url":"https://github.com/MetaMask/metamask-extension/pull/5924","diff_url":"https://github.com/MetaMask/metamask-extension/pull/5924.diff","patch_url":"https://github.com/MetaMask/metamask-extension/pull/5924.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/comments/447019928","html_url":"https://github.com/MetaMask/metamask-extension/pull/5924#issuecomment-447019928","issue_url":"https://api.github.com/repos/MetaMask/metamask-extension/issues/5924","id":447019928,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzAxOTkyOA==","user":{"login":"danjm","id":7499938,"node_id":"MDQ6VXNlcjc0OTk5Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7499938?v=4","gravatar_id":"","url":"https://api.github.com/users/danjm","html_url":"https://github.com/danjm","followers_url":"https://api.github.com/users/danjm/followers","following_url":"https://api.github.com/users/danjm/following{/other_user}","gists_url":"https://api.github.com/users/danjm/gists{/gist_id}","starred_url":"https://api.github.com/users/danjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danjm/subscriptions","organizations_url":"https://api.github.com/users/danjm/orgs","repos_url":"https://api.github.com/users/danjm/repos","events_url":"https://api.github.com/users/danjm/events{/privacy}","received_events_url":"https://api.github.com/users/danjm/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T15:56:44Z","updated_at":"2018-12-13T15:56:44Z","author_association":"CONTRIBUTOR","body":"I think this works as an immediate solution to the bug.\r\n\r\nHowever, it seems that there is a broader architectural issue with the network controller. The network state can either be an id of a network, or \"loading\". Then, we handle `getNetworkState ()` returns of \"loading\" in various ad hoc ways throughout the controller and even in the UI.\r\n\r\nWe may be able to make the code clearer and less fragile if we store two different values in the network controller state: `selectedNetwork` for storing an id of the network that the user has most recently selected, and a boolean `isNetworkLoading` to indicate whether or not we are connected to the `selectedNetwork`\r\n\r\nSomething like this may also be required if we want to provide better offline support.\r\n\r\nOf course, this is beyond the scope of this PR and should be treated as a separate issue."}}
{"actor":{"display_login":"danjm"}}