{"action":"closed","number":90,"pull_request":{"url":"https://api.github.com/repos/ridi/react-viewer/pulls/90","id":237223458,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MjIzNDU4","html_url":"https://github.com/ridi/react-viewer/pull/90","diff_url":"https://github.com/ridi/react-viewer/pull/90.diff","patch_url":"https://github.com/ridi/react-viewer/pull/90.patch","issue_url":"https://api.github.com/repos/ridi/react-viewer/issues/90","number":90,"state":"closed","locked":false,"title":"Lifecycle management with RxJS","user":{"login":"kyungmi","id":8926395,"node_id":"MDQ6VXNlcjg5MjYzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/8926395?v=4","gravatar_id":"","url":"https://api.github.com/users/kyungmi","html_url":"https://github.com/kyungmi","followers_url":"https://api.github.com/users/kyungmi/followers","following_url":"https://api.github.com/users/kyungmi/following{/other_user}","gists_url":"https://api.github.com/users/kyungmi/gists{/gist_id}","starred_url":"https://api.github.com/users/kyungmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyungmi/subscriptions","organizations_url":"https://api.github.com/users/kyungmi/orgs","repos_url":"https://api.github.com/users/kyungmi/repos","events_url":"https://api.github.com/users/kyungmi/events{/privacy}","received_events_url":"https://api.github.com/users/kyungmi/received_events","type":"User","site_admin":false},"body":"### Changes \r\n\r\n* RxJS 기반으로 동작하는 `EventBus`, `Events` 작성\r\n    * 기존 `Connector`를 기반으로 노출되었던 react-viewer의 API를 모두 이벤트 방식으로 변경함\r\n    * `LoadService`: 기존 데이터 복구 및 콘텐츠 로드를 담당\r\n    * `CalculationService`: 페이지 계산 담당\r\n    * `CurrentService`: 이전 위치 복구 및 현재 위치 계산 (+ 형광펜 위치 계산 -> `CalculationService`가 더 적합할듯)\r\n* 일부 데이터(`annotation`)를 시범적으로 RxJS로 관리하도록 함\r\n* `react-redux`의 `connect`와 비슷하게 동작하는 `withStore` HOC 작성\r\n\r\n### Remain issues\r\n\r\n* 스크롤보기일때 형광펜 위치가 왼쪽으로 약간 어긋나게 계산됨\r\n* 스크롤보기일때 터치를 시작한 지점의 콘텐트 인덱스 값을 바탕으로 reader.js를 불러와야 함 (현재는 `current.contentIndex` 값을 참조)\r\n* 스크롤보기일때 footer 영역은 `SelectionLayer`로 덮지 않아야 함\r\n* 페이지보기일때 양 옆 페이지의 형광펜이 나타남\r\n* 어색한 Service 이름 변경\r\n\r\n### Future Release\r\n\r\n* Redux를 RxJS로 대체","created_at":"2018-12-10T07:37:54Z","updated_at":"2018-12-10T23:30:01Z","closed_at":"2018-12-10T23:30:01Z","merged_at":"2018-12-10T23:30:01Z","merge_commit_sha":"d4718c059de18851dc274b602820069e232b13da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ridi/react-viewer/pulls/90/commits","review_comments_url":"https://api.github.com/repos/ridi/react-viewer/pulls/90/comments","review_comment_url":"https://api.github.com/repos/ridi/react-viewer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ridi/react-viewer/issues/90/comments","statuses_url":"https://api.github.com/repos/ridi/react-viewer/statuses/d56774a7d4e12cdf9221c91f081a95a8f38da9f1","head":{"label":"ridi:feature/lifecycle-management-with-rxjs","ref":"feature/lifecycle-management-with-rxjs","sha":"d56774a7d4e12cdf9221c91f081a95a8f38da9f1","user":{"login":"ridi","id":24955411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU1NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/24955411?v=4","gravatar_id":"","url":"https://api.github.com/users/ridi","html_url":"https://github.com/ridi","followers_url":"https://api.github.com/users/ridi/followers","following_url":"https://api.github.com/users/ridi/following{/other_user}","gists_url":"https://api.github.com/users/ridi/gists{/gist_id}","starred_url":"https://api.github.com/users/ridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridi/subscriptions","organizations_url":"https://api.github.com/users/ridi/orgs","repos_url":"https://api.github.com/users/ridi/repos","events_url":"https://api.github.com/users/ridi/events{/privacy}","received_events_url":"https://api.github.com/users/ridi/received_events","type":"Organization","site_admin":false},"repo":{"id":98161945,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE2MTk0NQ==","name":"react-viewer","full_name":"ridi/react-viewer","private":false,"owner":{"login":"ridi","id":24955411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU1NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/24955411?v=4","gravatar_id":"","url":"https://api.github.com/users/ridi","html_url":"https://github.com/ridi","followers_url":"https://api.github.com/users/ridi/followers","following_url":"https://api.github.com/users/ridi/following{/other_user}","gists_url":"https://api.github.com/users/ridi/gists{/gist_id}","starred_url":"https://api.github.com/users/ridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridi/subscriptions","organizations_url":"https://api.github.com/users/ridi/orgs","repos_url":"https://api.github.com/users/ridi/repos","events_url":"https://api.github.com/users/ridi/events{/privacy}","received_events_url":"https://api.github.com/users/ridi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ridi/react-viewer","description":"Online EPUB/Comics viewer","fork":false,"url":"https://api.github.com/repos/ridi/react-viewer","forks_url":"https://api.github.com/repos/ridi/react-viewer/forks","keys_url":"https://api.github.com/repos/ridi/react-viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ridi/react-viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ridi/react-viewer/teams","hooks_url":"https://api.github.com/repos/ridi/react-viewer/hooks","issue_events_url":"https://api.github.com/repos/ridi/react-viewer/issues/events{/number}","events_url":"https://api.github.com/repos/ridi/react-viewer/events","assignees_url":"https://api.github.com/repos/ridi/react-viewer/assignees{/user}","branches_url":"https://api.github.com/repos/ridi/react-viewer/branches{/branch}","tags_url":"https://api.github.com/repos/ridi/react-viewer/tags","blobs_url":"https://api.github.com/repos/ridi/react-viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ridi/react-viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ridi/react-viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ridi/react-viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ridi/react-viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/ridi/react-viewer/languages","stargazers_url":"https://api.github.com/repos/ridi/react-viewer/stargazers","contributors_url":"https://api.github.com/repos/ridi/react-viewer/contributors","subscribers_url":"https://api.github.com/repos/ridi/react-viewer/subscribers","subscription_url":"https://api.github.com/repos/ridi/react-viewer/subscription","commits_url":"https://api.github.com/repos/ridi/react-viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ridi/react-viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ridi/react-viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ridi/react-viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ridi/react-viewer/contents/{+path}","compare_url":"https://api.github.com/repos/ridi/react-viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ridi/react-viewer/merges","archive_url":"https://api.github.com/repos/ridi/react-viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ridi/react-viewer/downloads","issues_url":"https://api.github.com/repos/ridi/react-viewer/issues{/number}","pulls_url":"https://api.github.com/repos/ridi/react-viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/ridi/react-viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/ridi/react-viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ridi/react-viewer/labels{/name}","releases_url":"https://api.github.com/repos/ridi/react-viewer/releases{/id}","deployments_url":"https://api.github.com/repos/ridi/react-viewer/deployments","created_at":"2017-07-24T07:27:30Z","updated_at":"2018-11-22T02:32:40Z","pushed_at":"2018-12-10T23:30:02Z","git_url":"git://github.com/ridi/react-viewer.git","ssh_url":"git@github.com:ridi/react-viewer.git","clone_url":"https://github.com/ridi/react-viewer.git","svn_url":"https://github.com/ridi/react-viewer","homepage":"https://ridi.github.io/react-viewer/demo/","size":53494,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":3,"open_issues":7,"watchers":17,"default_branch":"master"}},"base":{"label":"ridi:master","ref":"master","sha":"3d1db4a042a293f2aac28e90038f2bc90989ea64","user":{"login":"ridi","id":24955411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU1NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/24955411?v=4","gravatar_id":"","url":"https://api.github.com/users/ridi","html_url":"https://github.com/ridi","followers_url":"https://api.github.com/users/ridi/followers","following_url":"https://api.github.com/users/ridi/following{/other_user}","gists_url":"https://api.github.com/users/ridi/gists{/gist_id}","starred_url":"https://api.github.com/users/ridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridi/subscriptions","organizations_url":"https://api.github.com/users/ridi/orgs","repos_url":"https://api.github.com/users/ridi/repos","events_url":"https://api.github.com/users/ridi/events{/privacy}","received_events_url":"https://api.github.com/users/ridi/received_events","type":"Organization","site_admin":false},"repo":{"id":98161945,"node_id":"MDEwOlJlcG9zaXRvcnk5ODE2MTk0NQ==","name":"react-viewer","full_name":"ridi/react-viewer","private":false,"owner":{"login":"ridi","id":24955411,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0OTU1NDEx","avatar_url":"https://avatars2.githubusercontent.com/u/24955411?v=4","gravatar_id":"","url":"https://api.github.com/users/ridi","html_url":"https://github.com/ridi","followers_url":"https://api.github.com/users/ridi/followers","following_url":"https://api.github.com/users/ridi/following{/other_user}","gists_url":"https://api.github.com/users/ridi/gists{/gist_id}","starred_url":"https://api.github.com/users/ridi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ridi/subscriptions","organizations_url":"https://api.github.com/users/ridi/orgs","repos_url":"https://api.github.com/users/ridi/repos","events_url":"https://api.github.com/users/ridi/events{/privacy}","received_events_url":"https://api.github.com/users/ridi/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ridi/react-viewer","description":"Online EPUB/Comics viewer","fork":false,"url":"https://api.github.com/repos/ridi/react-viewer","forks_url":"https://api.github.com/repos/ridi/react-viewer/forks","keys_url":"https://api.github.com/repos/ridi/react-viewer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ridi/react-viewer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ridi/react-viewer/teams","hooks_url":"https://api.github.com/repos/ridi/react-viewer/hooks","issue_events_url":"https://api.github.com/repos/ridi/react-viewer/issues/events{/number}","events_url":"https://api.github.com/repos/ridi/react-viewer/events","assignees_url":"https://api.github.com/repos/ridi/react-viewer/assignees{/user}","branches_url":"https://api.github.com/repos/ridi/react-viewer/branches{/branch}","tags_url":"https://api.github.com/repos/ridi/react-viewer/tags","blobs_url":"https://api.github.com/repos/ridi/react-viewer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ridi/react-viewer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ridi/react-viewer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ridi/react-viewer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ridi/react-viewer/statuses/{sha}","languages_url":"https://api.github.com/repos/ridi/react-viewer/languages","stargazers_url":"https://api.github.com/repos/ridi/react-viewer/stargazers","contributors_url":"https://api.github.com/repos/ridi/react-viewer/contributors","subscribers_url":"https://api.github.com/repos/ridi/react-viewer/subscribers","subscription_url":"https://api.github.com/repos/ridi/react-viewer/subscription","commits_url":"https://api.github.com/repos/ridi/react-viewer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ridi/react-viewer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ridi/react-viewer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ridi/react-viewer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ridi/react-viewer/contents/{+path}","compare_url":"https://api.github.com/repos/ridi/react-viewer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ridi/react-viewer/merges","archive_url":"https://api.github.com/repos/ridi/react-viewer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ridi/react-viewer/downloads","issues_url":"https://api.github.com/repos/ridi/react-viewer/issues{/number}","pulls_url":"https://api.github.com/repos/ridi/react-viewer/pulls{/number}","milestones_url":"https://api.github.com/repos/ridi/react-viewer/milestones{/number}","notifications_url":"https://api.github.com/repos/ridi/react-viewer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ridi/react-viewer/labels{/name}","releases_url":"https://api.github.com/repos/ridi/react-viewer/releases{/id}","deployments_url":"https://api.github.com/repos/ridi/react-viewer/deployments","created_at":"2017-07-24T07:27:30Z","updated_at":"2018-11-22T02:32:40Z","pushed_at":"2018-12-10T23:30:02Z","git_url":"git://github.com/ridi/react-viewer.git","ssh_url":"git@github.com:ridi/react-viewer.git","clone_url":"https://github.com/ridi/react-viewer.git","svn_url":"https://github.com/ridi/react-viewer","homepage":"https://ridi.github.io/react-viewer/demo/","size":53494,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":3,"open_issues":7,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ridi/react-viewer/pulls/90"},"html":{"href":"https://github.com/ridi/react-viewer/pull/90"},"issue":{"href":"https://api.github.com/repos/ridi/react-viewer/issues/90"},"comments":{"href":"https://api.github.com/repos/ridi/react-viewer/issues/90/comments"},"review_comments":{"href":"https://api.github.com/repos/ridi/react-viewer/pulls/90/comments"},"review_comment":{"href":"https://api.github.com/repos/ridi/react-viewer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ridi/react-viewer/pulls/90/commits"},"statuses":{"href":"https://api.github.com/repos/ridi/react-viewer/statuses/d56774a7d4e12cdf9221c91f081a95a8f38da9f1"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kyungmi","id":8926395,"node_id":"MDQ6VXNlcjg5MjYzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/8926395?v=4","gravatar_id":"","url":"https://api.github.com/users/kyungmi","html_url":"https://github.com/kyungmi","followers_url":"https://api.github.com/users/kyungmi/followers","following_url":"https://api.github.com/users/kyungmi/following{/other_user}","gists_url":"https://api.github.com/users/kyungmi/gists{/gist_id}","starred_url":"https://api.github.com/users/kyungmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyungmi/subscriptions","organizations_url":"https://api.github.com/users/kyungmi/orgs","repos_url":"https://api.github.com/users/kyungmi/repos","events_url":"https://api.github.com/users/kyungmi/events{/privacy}","received_events_url":"https://api.github.com/users/kyungmi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":27,"additions":6952,"deletions":2760,"changed_files":55}}
{"actor":{"display_login":"kyungmi"}}