{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node-addon-api/pulls/comments/191615702","pull_request_review_id":124219605,"id":191615702,"diff_hunk":"@@ -1,5 +1,151 @@\n # Error handling\n \n-You are reading a draft of the next documentation and it's in continuos update so\n-if you don't find what you need please refer to:\n-[C++ wrapper classes for the ABI-stable C APIs for Node.js](https://nodejs.github.io/node-addon-api/)\n\\ No newline at end of file\n+Error handling represents one of the most important considerations when","path":"doc/error_handling.md","position":7,"original_position":7,"commit_id":"92e6e899f1d6026d52cf9ff833f70e3656b33115","original_commit_id":"92e6e899f1d6026d52cf9ff833f70e3656b33115","user":{"login":"mhdawson","id":9373002,"avatar_url":"https://avatars3.githubusercontent.com/u/9373002?v=4","gravatar_id":"","url":"https://api.github.com/users/mhdawson","html_url":"https://github.com/mhdawson","followers_url":"https://api.github.com/users/mhdawson/followers","following_url":"https://api.github.com/users/mhdawson/following{/other_user}","gists_url":"https://api.github.com/users/mhdawson/gists{/gist_id}","starred_url":"https://api.github.com/users/mhdawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhdawson/subscriptions","organizations_url":"https://api.github.com/users/mhdawson/orgs","repos_url":"https://api.github.com/users/mhdawson/repos","events_url":"https://api.github.com/users/mhdawson/events{/privacy}","received_events_url":"https://api.github.com/users/mhdawson/received_events","type":"User","site_admin":false},"body":"Should this file b e updated in this PR?","created_at":"2018-05-30T00:46:45Z","updated_at":"2018-05-30T00:46:45Z","html_url":"https://github.com/nodejs/node-addon-api/pull/270#discussion_r191615702","pull_request_url":"https://api.github.com/repos/nodejs/node-addon-api/pulls/270","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-addon-api/pulls/comments/191615702"},"html":{"href":"https://github.com/nodejs/node-addon-api/pull/270#discussion_r191615702"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node-addon-api/pulls/270"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node-addon-api/pulls/270","id":187981989,"html_url":"https://github.com/nodejs/node-addon-api/pull/270","diff_url":"https://github.com/nodejs/node-addon-api/pull/270.diff","patch_url":"https://github.com/nodejs/node-addon-api/pull/270.patch","issue_url":"https://api.github.com/repos/nodejs/node-addon-api/issues/270","number":270,"state":"open","locked":false,"title":"External memory management","user":{"login":"NickNaso","id":387506,"avatar_url":"https://avatars2.githubusercontent.com/u/387506?v=4","gravatar_id":"","url":"https://api.github.com/users/NickNaso","html_url":"https://github.com/NickNaso","followers_url":"https://api.github.com/users/NickNaso/followers","following_url":"https://api.github.com/users/NickNaso/following{/other_user}","gists_url":"https://api.github.com/users/NickNaso/gists{/gist_id}","starred_url":"https://api.github.com/users/NickNaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickNaso/subscriptions","organizations_url":"https://api.github.com/users/NickNaso/orgs","repos_url":"https://api.github.com/users/NickNaso/repos","events_url":"https://api.github.com/users/NickNaso/events{/privacy}","received_events_url":"https://api.github.com/users/NickNaso/received_events","type":"User","site_admin":false},"body":"Added utility function `AdjustExternalMemory` like discussed in the following issue:\r\n[https://github.com/nodejs/node-addon-api/issues/260](https://github.com/nodejs/node-addon-api/issues/260)\r\nI added the function `AdjustExternalMemory` with corresponding tests and documentation. Please give a review of my work.","created_at":"2018-05-15T00:03:38Z","updated_at":"2018-05-30T00:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6682ad2bea71692ee026552d29fe8f7fd0fe00c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node-addon-api/pulls/270/commits","review_comments_url":"https://api.github.com/repos/nodejs/node-addon-api/pulls/270/comments","review_comment_url":"https://api.github.com/repos/nodejs/node-addon-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node-addon-api/issues/270/comments","statuses_url":"https://api.github.com/repos/nodejs/node-addon-api/statuses/92e6e899f1d6026d52cf9ff833f70e3656b33115","head":{"label":"NickNaso:external-memory-management","ref":"external-memory-management","sha":"92e6e899f1d6026d52cf9ff833f70e3656b33115","user":{"login":"NickNaso","id":387506,"avatar_url":"https://avatars2.githubusercontent.com/u/387506?v=4","gravatar_id":"","url":"https://api.github.com/users/NickNaso","html_url":"https://github.com/NickNaso","followers_url":"https://api.github.com/users/NickNaso/followers","following_url":"https://api.github.com/users/NickNaso/following{/other_user}","gists_url":"https://api.github.com/users/NickNaso/gists{/gist_id}","starred_url":"https://api.github.com/users/NickNaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickNaso/subscriptions","organizations_url":"https://api.github.com/users/NickNaso/orgs","repos_url":"https://api.github.com/users/NickNaso/repos","events_url":"https://api.github.com/users/NickNaso/events{/privacy}","received_events_url":"https://api.github.com/users/NickNaso/received_events","type":"User","site_admin":false},"repo":{"id":102976873,"name":"node-addon-api","full_name":"NickNaso/node-addon-api","owner":{"login":"NickNaso","id":387506,"avatar_url":"https://avatars2.githubusercontent.com/u/387506?v=4","gravatar_id":"","url":"https://api.github.com/users/NickNaso","html_url":"https://github.com/NickNaso","followers_url":"https://api.github.com/users/NickNaso/followers","following_url":"https://api.github.com/users/NickNaso/following{/other_user}","gists_url":"https://api.github.com/users/NickNaso/gists{/gist_id}","starred_url":"https://api.github.com/users/NickNaso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickNaso/subscriptions","organizations_url":"https://api.github.com/users/NickNaso/orgs","repos_url":"https://api.github.com/users/NickNaso/repos","events_url":"https://api.github.com/users/NickNaso/events{/privacy}","received_events_url":"https://api.github.com/users/NickNaso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NickNaso/node-addon-api","description":null,"fork":true,"url":"https://api.github.com/repos/NickNaso/node-addon-api","forks_url":"https://api.github.com/repos/NickNaso/node-addon-api/forks","keys_url":"https://api.github.com/repos/NickNaso/node-addon-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NickNaso/node-addon-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NickNaso/node-addon-api/teams","hooks_url":"https://api.github.com/repos/NickNaso/node-addon-api/hooks","issue_events_url":"https://api.github.com/repos/NickNaso/node-addon-api/issues/events{/number}","events_url":"https://api.github.com/repos/NickNaso/node-addon-api/events","assignees_url":"https://api.github.com/repos/NickNaso/node-addon-api/assignees{/user}","branches_url":"https://api.github.com/repos/NickNaso/node-addon-api/branches{/branch}","tags_url":"https://api.github.com/repos/NickNaso/node-addon-api/tags","blobs_url":"https://api.github.com/repos/NickNaso/node-addon-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NickNaso/node-addon-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NickNaso/node-addon-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/NickNaso/node-addon-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NickNaso/node-addon-api/statuses/{sha}","languages_url":"https://api.github.com/repos/NickNaso/node-addon-api/languages","stargazers_url":"https://api.github.com/repos/NickNaso/node-addon-api/stargazers","contributors_url":"https://api.github.com/repos/NickNaso/node-addon-api/contributors","subscribers_url":"https://api.github.com/repos/NickNaso/node-addon-api/subscribers","subscription_url":"https://api.github.com/repos/NickNaso/node-addon-api/subscription","commits_url":"https://api.github.com/repos/NickNaso/node-addon-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/NickNaso/node-addon-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/NickNaso/node-addon-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/NickNaso/node-addon-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/NickNaso/node-addon-api/contents/{+path}","compare_url":"https://api.github.com/repos/NickNaso/node-addon-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NickNaso/node-addon-api/merges","archive_url":"https://api.github.com/repos/NickNaso/node-addon-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NickNaso/node-addon-api/downloads","issues_url":"https://api.github.com/repos/NickNaso/node-addon-api/issues{/number}","pulls_url":"https://api.github.com/repos/NickNaso/node-addon-api/pulls{/number}","milestones_url":"https://api.github.com/repos/NickNaso/node-addon-api/milestones{/number}","notifications_url":"https://api.github.com/repos/NickNaso/node-addon-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NickNaso/node-addon-api/labels{/name}","releases_url":"https://api.github.com/repos/NickNaso/node-addon-api/releases{/id}","deployments_url":"https://api.github.com/repos/NickNaso/node-addon-api/deployments","created_at":"2017-09-09T18:35:57Z","updated_at":"2018-05-10T12:48:01Z","pushed_at":"2018-05-22T21:17:19Z","git_url":"git://github.com/NickNaso/node-addon-api.git","ssh_url":"git@github.com:NickNaso/node-addon-api.git","clone_url":"https://github.com/NickNaso/node-addon-api.git","svn_url":"https://github.com/NickNaso/node-addon-api","homepage":null,"size":957,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"a750ed1932e4b03c457b7b93e08cb07ec3ae8201","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":81384578,"name":"node-addon-api","full_name":"nodejs/node-addon-api","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node-addon-api","description":null,"fork":false,"url":"https://api.github.com/repos/nodejs/node-addon-api","forks_url":"https://api.github.com/repos/nodejs/node-addon-api/forks","keys_url":"https://api.github.com/repos/nodejs/node-addon-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node-addon-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node-addon-api/teams","hooks_url":"https://api.github.com/repos/nodejs/node-addon-api/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node-addon-api/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node-addon-api/events","assignees_url":"https://api.github.com/repos/nodejs/node-addon-api/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node-addon-api/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node-addon-api/tags","blobs_url":"https://api.github.com/repos/nodejs/node-addon-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node-addon-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node-addon-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node-addon-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node-addon-api/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node-addon-api/languages","stargazers_url":"https://api.github.com/repos/nodejs/node-addon-api/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node-addon-api/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node-addon-api/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node-addon-api/subscription","commits_url":"https://api.github.com/repos/nodejs/node-addon-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node-addon-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node-addon-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node-addon-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node-addon-api/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node-addon-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node-addon-api/merges","archive_url":"https://api.github.com/repos/nodejs/node-addon-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node-addon-api/downloads","issues_url":"https://api.github.com/repos/nodejs/node-addon-api/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node-addon-api/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node-addon-api/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node-addon-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node-addon-api/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node-addon-api/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node-addon-api/deployments","created_at":"2017-02-08T22:54:19Z","updated_at":"2018-05-30T00:33:42Z","pushed_at":"2018-05-30T00:33:38Z","git_url":"git://github.com/nodejs/node-addon-api.git","ssh_url":"git@github.com:nodejs/node-addon-api.git","clone_url":"https://github.com/nodejs/node-addon-api.git","svn_url":"https://github.com/nodejs/node-addon-api","homepage":null,"size":895,"stargazers_count":212,"watchers_count":212,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":59,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":44,"open_issues":59,"watchers":212,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node-addon-api/pulls/270"},"html":{"href":"https://github.com/nodejs/node-addon-api/pull/270"},"issue":{"href":"https://api.github.com/repos/nodejs/node-addon-api/issues/270"},"comments":{"href":"https://api.github.com/repos/nodejs/node-addon-api/issues/270/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node-addon-api/pulls/270/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node-addon-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node-addon-api/pulls/270/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node-addon-api/statuses/92e6e899f1d6026d52cf9ff833f70e3656b33115"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mhdawson"}}