{"action":"created","issue":{"url":"https://api.github.com/repos/zurb/foundation-sites/issues/10921","repository_url":"https://api.github.com/repos/zurb/foundation-sites","labels_url":"https://api.github.com/repos/zurb/foundation-sites/issues/10921/labels{/name}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/issues/10921/comments","events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/10921/events","html_url":"https://github.com/zurb/foundation-sites/pull/10921","id":294797341,"number":10921,"title":"fix: fix DropdownMenu closing when touching to scroll #9823","user":{"login":"abdullahsalem","id":177020,"avatar_url":"https://avatars2.githubusercontent.com/u/177020?v=4","gravatar_id":"","url":"https://api.github.com/users/abdullahsalem","html_url":"https://github.com/abdullahsalem","followers_url":"https://api.github.com/users/abdullahsalem/followers","following_url":"https://api.github.com/users/abdullahsalem/following{/other_user}","gists_url":"https://api.github.com/users/abdullahsalem/gists{/gist_id}","starred_url":"https://api.github.com/users/abdullahsalem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abdullahsalem/subscriptions","organizations_url":"https://api.github.com/users/abdullahsalem/orgs","repos_url":"https://api.github.com/users/abdullahsalem/repos","events_url":"https://api.github.com/users/abdullahsalem/events{/privacy}","received_events_url":"https://api.github.com/users/abdullahsalem/received_events","type":"User","site_admin":false},"labels":[{"id":425263577,"url":"https://api.github.com/repos/zurb/foundation-sites/labels/Dropdown%20Menu","name":"Dropdown Menu","color":"1197eb","default":false},{"id":501771078,"url":"https://api.github.com/repos/zurb/foundation-sites/labels/bug%20fix","name":"bug fix","color":"13c600","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-06T15:19:12Z","updated_at":"2018-02-18T16:46:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/zurb/foundation-sites/pulls/10921","html_url":"https://github.com/zurb/foundation-sites/pull/10921","diff_url":"https://github.com/zurb/foundation-sites/pull/10921.diff","patch_url":"https://github.com/zurb/foundation-sites/pull/10921.patch"},"body":"This solution fixes this issue #9823.\r\n\r\n**Issue:**\r\nOn a touchable screen, when you open up a long dropdown menu that goes beyond the viewport boundary -i.e., #9823-, then attempts to **move down/up** to keep interacting with the menu, the menu will disappear! That happens because the current attached events `mouseup.zf.dropdownmenu touchend.zf.dropdownmenu` on the body object cannot figure out if that `touchend` comes after the user **moved down/up** or the user just tapped on the screen, once.\r\n\r\n**Solution:**\r\nI added the flag `this.isTouchMove` to help `touchend`'s callback function to figure out if the user was **moving down/up** or just tapped once."},"comment":{"url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments/366528998","html_url":"https://github.com/zurb/foundation-sites/pull/10921#issuecomment-366528998","issue_url":"https://api.github.com/repos/zurb/foundation-sites/issues/10921","id":366528998,"user":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"created_at":"2018-02-18T16:46:32Z","updated_at":"2018-02-18T16:46:32Z","author_association":"MEMBER","body":"So `touchend` was introduced in https://github.com/zurb/foundation-sites/pull/7344/files. I have troubles to understand why as nothing is commented..."}}
{"actor":{"display_login":"ncoden"}}