{"action":"closed","number":1762,"pull_request":{"url":"https://api.github.com/repos/coralproject/talk/pulls/1762","id":204454145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDU0MTQ1","html_url":"https://github.com/coralproject/talk/pull/1762","diff_url":"https://github.com/coralproject/talk/pull/1762.diff","patch_url":"https://github.com/coralproject/talk/pull/1762.patch","issue_url":"https://api.github.com/repos/coralproject/talk/issues/1762","number":1762,"state":"closed","locked":false,"title":"[next] Add support for embed","user":{"login":"cvle","id":14221600,"node_id":"MDQ6VXNlcjE0MjIxNjAw","avatar_url":"https://avatars2.githubusercontent.com/u/14221600?v=4","gravatar_id":"","url":"https://api.github.com/users/cvle","html_url":"https://github.com/cvle","followers_url":"https://api.github.com/users/cvle/followers","following_url":"https://api.github.com/users/cvle/following{/other_user}","gists_url":"https://api.github.com/users/cvle/gists{/gist_id}","starred_url":"https://api.github.com/users/cvle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvle/subscriptions","organizations_url":"https://api.github.com/users/cvle/orgs","repos_url":"https://api.github.com/users/cvle/repos","events_url":"https://api.github.com/users/cvle/events{/privacy}","received_events_url":"https://api.github.com/users/cvle/received_events","type":"User","site_admin":false},"body":"## What does this PR do?\r\n- Refactor webpack build scripts into `src/core/build`\r\n- Harmonize server and client configuration into `src/core/common/config.ts` \r\n- Added `npm run tscheck` that runs type checking \r\n- Added `embed` build configuration\r\n- Implement `embed`\r\n- Added `eventEmitter` to `TalkContext`\r\n- Support detecting clicks outside of iframe and other v4 embed features\r\n","created_at":"2018-07-27T14:48:43Z","updated_at":"2018-08-02T15:29:22Z","closed_at":"2018-08-02T15:29:19Z","merged_at":"2018-08-02T15:29:19Z","merge_commit_sha":"6d7056d831a29510599ce3cccf19ffcc01829475","assignee":null,"assignees":[],"requested_reviewers":[{"login":"okbel","id":1401559,"node_id":"MDQ6VXNlcjE0MDE1NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/1401559?v=4","gravatar_id":"","url":"https://api.github.com/users/okbel","html_url":"https://github.com/okbel","followers_url":"https://api.github.com/users/okbel/followers","following_url":"https://api.github.com/users/okbel/following{/other_user}","gists_url":"https://api.github.com/users/okbel/gists{/gist_id}","starred_url":"https://api.github.com/users/okbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okbel/subscriptions","organizations_url":"https://api.github.com/users/okbel/orgs","repos_url":"https://api.github.com/users/okbel/repos","events_url":"https://api.github.com/users/okbel/events{/privacy}","received_events_url":"https://api.github.com/users/okbel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/coralproject/talk/milestones/8","html_url":"https://github.com/coralproject/talk/milestone/8","labels_url":"https://api.github.com/repos/coralproject/talk/milestones/8/labels","id":3454156,"node_id":"MDk6TWlsZXN0b25lMzQ1NDE1Ng==","number":8,"title":"v5.0.0","description":"","creator":{"login":"kgardnr","id":1077300,"node_id":"MDQ6VXNlcjEwNzczMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1077300?v=4","gravatar_id":"","url":"https://api.github.com/users/kgardnr","html_url":"https://github.com/kgardnr","followers_url":"https://api.github.com/users/kgardnr/followers","following_url":"https://api.github.com/users/kgardnr/following{/other_user}","gists_url":"https://api.github.com/users/kgardnr/gists{/gist_id}","starred_url":"https://api.github.com/users/kgardnr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kgardnr/subscriptions","organizations_url":"https://api.github.com/users/kgardnr/orgs","repos_url":"https://api.github.com/users/kgardnr/repos","events_url":"https://api.github.com/users/kgardnr/events{/privacy}","received_events_url":"https://api.github.com/users/kgardnr/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":25,"state":"open","created_at":"2018-06-26T19:25:29Z","updated_at":"2018-08-02T15:29:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/coralproject/talk/pulls/1762/commits","review_comments_url":"https://api.github.com/repos/coralproject/talk/pulls/1762/comments","review_comment_url":"https://api.github.com/repos/coralproject/talk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coralproject/talk/issues/1762/comments","statuses_url":"https://api.github.com/repos/coralproject/talk/statuses/66a3b71b1ce6760943748c1c47f2013f3a5ea18c","head":{"label":"coralproject:iframe-config","ref":"iframe-config","sha":"66a3b71b1ce6760943748c1c47f2013f3a5ea18c","user":{"login":"coralproject","id":9255912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNTU5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9255912?v=4","gravatar_id":"","url":"https://api.github.com/users/coralproject","html_url":"https://github.com/coralproject","followers_url":"https://api.github.com/users/coralproject/followers","following_url":"https://api.github.com/users/coralproject/following{/other_user}","gists_url":"https://api.github.com/users/coralproject/gists{/gist_id}","starred_url":"https://api.github.com/users/coralproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coralproject/subscriptions","organizations_url":"https://api.github.com/users/coralproject/orgs","repos_url":"https://api.github.com/users/coralproject/repos","events_url":"https://api.github.com/users/coralproject/events{/privacy}","received_events_url":"https://api.github.com/users/coralproject/received_events","type":"Organization","site_admin":false},"repo":{"id":72454242,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ1NDI0Mg==","name":"talk","full_name":"coralproject/talk","owner":{"login":"coralproject","id":9255912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNTU5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9255912?v=4","gravatar_id":"","url":"https://api.github.com/users/coralproject","html_url":"https://github.com/coralproject","followers_url":"https://api.github.com/users/coralproject/followers","following_url":"https://api.github.com/users/coralproject/following{/other_user}","gists_url":"https://api.github.com/users/coralproject/gists{/gist_id}","starred_url":"https://api.github.com/users/coralproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coralproject/subscriptions","organizations_url":"https://api.github.com/users/coralproject/orgs","repos_url":"https://api.github.com/users/coralproject/repos","events_url":"https://api.github.com/users/coralproject/events{/privacy}","received_events_url":"https://api.github.com/users/coralproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coralproject/talk","description":"A better commenting experience from Mozilla, The Washington Post, and The New York Times.","fork":false,"url":"https://api.github.com/repos/coralproject/talk","forks_url":"https://api.github.com/repos/coralproject/talk/forks","keys_url":"https://api.github.com/repos/coralproject/talk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coralproject/talk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coralproject/talk/teams","hooks_url":"https://api.github.com/repos/coralproject/talk/hooks","issue_events_url":"https://api.github.com/repos/coralproject/talk/issues/events{/number}","events_url":"https://api.github.com/repos/coralproject/talk/events","assignees_url":"https://api.github.com/repos/coralproject/talk/assignees{/user}","branches_url":"https://api.github.com/repos/coralproject/talk/branches{/branch}","tags_url":"https://api.github.com/repos/coralproject/talk/tags","blobs_url":"https://api.github.com/repos/coralproject/talk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coralproject/talk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coralproject/talk/git/refs{/sha}","trees_url":"https://api.github.com/repos/coralproject/talk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coralproject/talk/statuses/{sha}","languages_url":"https://api.github.com/repos/coralproject/talk/languages","stargazers_url":"https://api.github.com/repos/coralproject/talk/stargazers","contributors_url":"https://api.github.com/repos/coralproject/talk/contributors","subscribers_url":"https://api.github.com/repos/coralproject/talk/subscribers","subscription_url":"https://api.github.com/repos/coralproject/talk/subscription","commits_url":"https://api.github.com/repos/coralproject/talk/commits{/sha}","git_commits_url":"https://api.github.com/repos/coralproject/talk/git/commits{/sha}","comments_url":"https://api.github.com/repos/coralproject/talk/comments{/number}","issue_comment_url":"https://api.github.com/repos/coralproject/talk/issues/comments{/number}","contents_url":"https://api.github.com/repos/coralproject/talk/contents/{+path}","compare_url":"https://api.github.com/repos/coralproject/talk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coralproject/talk/merges","archive_url":"https://api.github.com/repos/coralproject/talk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coralproject/talk/downloads","issues_url":"https://api.github.com/repos/coralproject/talk/issues{/number}","pulls_url":"https://api.github.com/repos/coralproject/talk/pulls{/number}","milestones_url":"https://api.github.com/repos/coralproject/talk/milestones{/number}","notifications_url":"https://api.github.com/repos/coralproject/talk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coralproject/talk/labels{/name}","releases_url":"https://api.github.com/repos/coralproject/talk/releases{/id}","deployments_url":"https://api.github.com/repos/coralproject/talk/deployments","created_at":"2016-10-31T16:14:05Z","updated_at":"2018-08-01T21:48:14Z","pushed_at":"2018-08-02T15:29:22Z","git_url":"git://github.com/coralproject/talk.git","ssh_url":"git@github.com:coralproject/talk.git","clone_url":"https://github.com/coralproject/talk.git","svn_url":"https://github.com/coralproject/talk","homepage":"https://coralproject.net/","size":19429,"stargazers_count":969,"watchers_count":969,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":154,"open_issues":24,"watchers":969,"default_branch":"master"}},"base":{"label":"coralproject:next","ref":"next","sha":"cf3b706bbce5e0a2ca2c38c2f42fb931ae28e08a","user":{"login":"coralproject","id":9255912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNTU5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9255912?v=4","gravatar_id":"","url":"https://api.github.com/users/coralproject","html_url":"https://github.com/coralproject","followers_url":"https://api.github.com/users/coralproject/followers","following_url":"https://api.github.com/users/coralproject/following{/other_user}","gists_url":"https://api.github.com/users/coralproject/gists{/gist_id}","starred_url":"https://api.github.com/users/coralproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coralproject/subscriptions","organizations_url":"https://api.github.com/users/coralproject/orgs","repos_url":"https://api.github.com/users/coralproject/repos","events_url":"https://api.github.com/users/coralproject/events{/privacy}","received_events_url":"https://api.github.com/users/coralproject/received_events","type":"Organization","site_admin":false},"repo":{"id":72454242,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ1NDI0Mg==","name":"talk","full_name":"coralproject/talk","owner":{"login":"coralproject","id":9255912,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNTU5MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/9255912?v=4","gravatar_id":"","url":"https://api.github.com/users/coralproject","html_url":"https://github.com/coralproject","followers_url":"https://api.github.com/users/coralproject/followers","following_url":"https://api.github.com/users/coralproject/following{/other_user}","gists_url":"https://api.github.com/users/coralproject/gists{/gist_id}","starred_url":"https://api.github.com/users/coralproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coralproject/subscriptions","organizations_url":"https://api.github.com/users/coralproject/orgs","repos_url":"https://api.github.com/users/coralproject/repos","events_url":"https://api.github.com/users/coralproject/events{/privacy}","received_events_url":"https://api.github.com/users/coralproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coralproject/talk","description":"A better commenting experience from Mozilla, The Washington Post, and The New York Times.","fork":false,"url":"https://api.github.com/repos/coralproject/talk","forks_url":"https://api.github.com/repos/coralproject/talk/forks","keys_url":"https://api.github.com/repos/coralproject/talk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coralproject/talk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coralproject/talk/teams","hooks_url":"https://api.github.com/repos/coralproject/talk/hooks","issue_events_url":"https://api.github.com/repos/coralproject/talk/issues/events{/number}","events_url":"https://api.github.com/repos/coralproject/talk/events","assignees_url":"https://api.github.com/repos/coralproject/talk/assignees{/user}","branches_url":"https://api.github.com/repos/coralproject/talk/branches{/branch}","tags_url":"https://api.github.com/repos/coralproject/talk/tags","blobs_url":"https://api.github.com/repos/coralproject/talk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coralproject/talk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coralproject/talk/git/refs{/sha}","trees_url":"https://api.github.com/repos/coralproject/talk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coralproject/talk/statuses/{sha}","languages_url":"https://api.github.com/repos/coralproject/talk/languages","stargazers_url":"https://api.github.com/repos/coralproject/talk/stargazers","contributors_url":"https://api.github.com/repos/coralproject/talk/contributors","subscribers_url":"https://api.github.com/repos/coralproject/talk/subscribers","subscription_url":"https://api.github.com/repos/coralproject/talk/subscription","commits_url":"https://api.github.com/repos/coralproject/talk/commits{/sha}","git_commits_url":"https://api.github.com/repos/coralproject/talk/git/commits{/sha}","comments_url":"https://api.github.com/repos/coralproject/talk/comments{/number}","issue_comment_url":"https://api.github.com/repos/coralproject/talk/issues/comments{/number}","contents_url":"https://api.github.com/repos/coralproject/talk/contents/{+path}","compare_url":"https://api.github.com/repos/coralproject/talk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coralproject/talk/merges","archive_url":"https://api.github.com/repos/coralproject/talk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coralproject/talk/downloads","issues_url":"https://api.github.com/repos/coralproject/talk/issues{/number}","pulls_url":"https://api.github.com/repos/coralproject/talk/pulls{/number}","milestones_url":"https://api.github.com/repos/coralproject/talk/milestones{/number}","notifications_url":"https://api.github.com/repos/coralproject/talk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coralproject/talk/labels{/name}","releases_url":"https://api.github.com/repos/coralproject/talk/releases{/id}","deployments_url":"https://api.github.com/repos/coralproject/talk/deployments","created_at":"2016-10-31T16:14:05Z","updated_at":"2018-08-01T21:48:14Z","pushed_at":"2018-08-02T15:29:22Z","git_url":"git://github.com/coralproject/talk.git","ssh_url":"git@github.com:coralproject/talk.git","clone_url":"https://github.com/coralproject/talk.git","svn_url":"https://github.com/coralproject/talk","homepage":"https://coralproject.net/","size":19429,"stargazers_count":969,"watchers_count":969,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":154,"open_issues":24,"watchers":969,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coralproject/talk/pulls/1762"},"html":{"href":"https://github.com/coralproject/talk/pull/1762"},"issue":{"href":"https://api.github.com/repos/coralproject/talk/issues/1762"},"comments":{"href":"https://api.github.com/repos/coralproject/talk/issues/1762/comments"},"review_comments":{"href":"https://api.github.com/repos/coralproject/talk/pulls/1762/comments"},"review_comment":{"href":"https://api.github.com/repos/coralproject/talk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coralproject/talk/pulls/1762/commits"},"statuses":{"href":"https://api.github.com/repos/coralproject/talk/statuses/66a3b71b1ce6760943748c1c47f2013f3a5ea18c"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"wyattjoh","id":633002,"node_id":"MDQ6VXNlcjYzMzAwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/633002?v=4","gravatar_id":"","url":"https://api.github.com/users/wyattjoh","html_url":"https://github.com/wyattjoh","followers_url":"https://api.github.com/users/wyattjoh/followers","following_url":"https://api.github.com/users/wyattjoh/following{/other_user}","gists_url":"https://api.github.com/users/wyattjoh/gists{/gist_id}","starred_url":"https://api.github.com/users/wyattjoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyattjoh/subscriptions","organizations_url":"https://api.github.com/users/wyattjoh/orgs","repos_url":"https://api.github.com/users/wyattjoh/repos","events_url":"https://api.github.com/users/wyattjoh/events{/privacy}","received_events_url":"https://api.github.com/users/wyattjoh/received_events","type":"User","site_admin":false},"comments":0,"review_comments":12,"maintainer_can_modify":false,"commits":14,"additions":1994,"deletions":1045,"changed_files":72}}
{"actor":{"display_login":"wyattjoh"}}