{"action":"created","comment":{"url":"https://api.github.com/repos/Dorokhov/buffer/pulls/comments/195781905","pull_request_review_id":129219879,"id":195781905,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTc4MTkwNQ==","diff_hunk":"@@ -384,7 +385,13 @@ func (b *Buffer) Read(data []byte, c Cursor) (n int, next Cursor, err error) {\n \t\treturn b.readFirst(data)\n \t}\n \n-\treturn b.readOffset(data, offset)\n+\tn1, c1, err := b.readOffset(data, offset)","path":"buffer.go","position":22,"original_position":22,"commit_id":"bb034b518e3da837c7f8f7418cb6fe3a5e788743","original_commit_id":"bb034b518e3da837c7f8f7418cb6fe3a5e788743","user":{"login":"kvap","id":663660,"node_id":"MDQ6VXNlcjY2MzY2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/663660?v=4","gravatar_id":"","url":"https://api.github.com/users/kvap","html_url":"https://github.com/kvap","followers_url":"https://api.github.com/users/kvap/followers","following_url":"https://api.github.com/users/kvap/following{/other_user}","gists_url":"https://api.github.com/users/kvap/gists{/gist_id}","starred_url":"https://api.github.com/users/kvap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvap/subscriptions","organizations_url":"https://api.github.com/users/kvap/orgs","repos_url":"https://api.github.com/users/kvap/repos","events_url":"https://api.github.com/users/kvap/events{/privacy}","received_events_url":"https://api.github.com/users/kvap/received_events","type":"User","site_admin":false},"body":"@Dorokhov I wonder where the fix is. If it is the panic, then how do you test it?","created_at":"2018-06-15T15:45:00Z","updated_at":"2018-06-15T15:45:00Z","html_url":"https://github.com/Dorokhov/buffer/pull/1#discussion_r195781905","pull_request_url":"https://api.github.com/repos/Dorokhov/buffer/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Dorokhov/buffer/pulls/comments/195781905"},"html":{"href":"https://github.com/Dorokhov/buffer/pull/1#discussion_r195781905"},"pull_request":{"href":"https://api.github.com/repos/Dorokhov/buffer/pulls/1"}},"in_reply_to_id":195779300},"pull_request":{"url":"https://api.github.com/repos/Dorokhov/buffer/pulls/1","id":195210319,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjEwMzE5","html_url":"https://github.com/Dorokhov/buffer/pull/1","diff_url":"https://github.com/Dorokhov/buffer/pull/1.diff","patch_url":"https://github.com/Dorokhov/buffer/pull/1.patch","issue_url":"https://api.github.com/repos/Dorokhov/buffer/issues/1","number":1,"state":"open","locked":false,"title":"fixed buffer lapping","user":{"login":"Dorokhov","id":1944245,"node_id":"MDQ6VXNlcjE5NDQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1944245?v=4","gravatar_id":"","url":"https://api.github.com/users/Dorokhov","html_url":"https://github.com/Dorokhov","followers_url":"https://api.github.com/users/Dorokhov/followers","following_url":"https://api.github.com/users/Dorokhov/following{/other_user}","gists_url":"https://api.github.com/users/Dorokhov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorokhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorokhov/subscriptions","organizations_url":"https://api.github.com/users/Dorokhov/orgs","repos_url":"https://api.github.com/users/Dorokhov/repos","events_url":"https://api.github.com/users/Dorokhov/events{/privacy}","received_events_url":"https://api.github.com/users/Dorokhov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-15T15:31:21Z","updated_at":"2018-06-15T15:45:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f432e4a254b3887473a5849ff470d000afaf0ef3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Dorokhov/buffer/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Dorokhov/buffer/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Dorokhov/buffer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dorokhov/buffer/issues/1/comments","statuses_url":"https://api.github.com/repos/Dorokhov/buffer/statuses/bb034b518e3da837c7f8f7418cb6fe3a5e788743","head":{"label":"Dorokhov:bug-cursor-before-first-record","ref":"bug-cursor-before-first-record","sha":"bb034b518e3da837c7f8f7418cb6fe3a5e788743","user":{"login":"Dorokhov","id":1944245,"node_id":"MDQ6VXNlcjE5NDQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1944245?v=4","gravatar_id":"","url":"https://api.github.com/users/Dorokhov","html_url":"https://github.com/Dorokhov","followers_url":"https://api.github.com/users/Dorokhov/followers","following_url":"https://api.github.com/users/Dorokhov/following{/other_user}","gists_url":"https://api.github.com/users/Dorokhov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorokhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorokhov/subscriptions","organizations_url":"https://api.github.com/users/Dorokhov/orgs","repos_url":"https://api.github.com/users/Dorokhov/repos","events_url":"https://api.github.com/users/Dorokhov/events{/privacy}","received_events_url":"https://api.github.com/users/Dorokhov/received_events","type":"User","site_admin":false},"repo":{"id":137356958,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczNTY5NTg=","name":"buffer","full_name":"Dorokhov/buffer","owner":{"login":"Dorokhov","id":1944245,"node_id":"MDQ6VXNlcjE5NDQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1944245?v=4","gravatar_id":"","url":"https://api.github.com/users/Dorokhov","html_url":"https://github.com/Dorokhov","followers_url":"https://api.github.com/users/Dorokhov/followers","following_url":"https://api.github.com/users/Dorokhov/following{/other_user}","gists_url":"https://api.github.com/users/Dorokhov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorokhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorokhov/subscriptions","organizations_url":"https://api.github.com/users/Dorokhov/orgs","repos_url":"https://api.github.com/users/Dorokhov/repos","events_url":"https://api.github.com/users/Dorokhov/events{/privacy}","received_events_url":"https://api.github.com/users/Dorokhov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dorokhov/buffer","description":"A file backed circular buffer for Go. Mmap file into memory. Madvise to lower memory footprint.","fork":true,"url":"https://api.github.com/repos/Dorokhov/buffer","forks_url":"https://api.github.com/repos/Dorokhov/buffer/forks","keys_url":"https://api.github.com/repos/Dorokhov/buffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dorokhov/buffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dorokhov/buffer/teams","hooks_url":"https://api.github.com/repos/Dorokhov/buffer/hooks","issue_events_url":"https://api.github.com/repos/Dorokhov/buffer/issues/events{/number}","events_url":"https://api.github.com/repos/Dorokhov/buffer/events","assignees_url":"https://api.github.com/repos/Dorokhov/buffer/assignees{/user}","branches_url":"https://api.github.com/repos/Dorokhov/buffer/branches{/branch}","tags_url":"https://api.github.com/repos/Dorokhov/buffer/tags","blobs_url":"https://api.github.com/repos/Dorokhov/buffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dorokhov/buffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dorokhov/buffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dorokhov/buffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dorokhov/buffer/statuses/{sha}","languages_url":"https://api.github.com/repos/Dorokhov/buffer/languages","stargazers_url":"https://api.github.com/repos/Dorokhov/buffer/stargazers","contributors_url":"https://api.github.com/repos/Dorokhov/buffer/contributors","subscribers_url":"https://api.github.com/repos/Dorokhov/buffer/subscribers","subscription_url":"https://api.github.com/repos/Dorokhov/buffer/subscription","commits_url":"https://api.github.com/repos/Dorokhov/buffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dorokhov/buffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dorokhov/buffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dorokhov/buffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dorokhov/buffer/contents/{+path}","compare_url":"https://api.github.com/repos/Dorokhov/buffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dorokhov/buffer/merges","archive_url":"https://api.github.com/repos/Dorokhov/buffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dorokhov/buffer/downloads","issues_url":"https://api.github.com/repos/Dorokhov/buffer/issues{/number}","pulls_url":"https://api.github.com/repos/Dorokhov/buffer/pulls{/number}","milestones_url":"https://api.github.com/repos/Dorokhov/buffer/milestones{/number}","notifications_url":"https://api.github.com/repos/Dorokhov/buffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dorokhov/buffer/labels{/name}","releases_url":"https://api.github.com/repos/Dorokhov/buffer/releases{/id}","deployments_url":"https://api.github.com/repos/Dorokhov/buffer/deployments","created_at":"2018-06-14T12:43:50Z","updated_at":"2018-06-14T12:50:23Z","pushed_at":"2018-06-15T15:31:22Z","git_url":"git://github.com/Dorokhov/buffer.git","ssh_url":"git@github.com:Dorokhov/buffer.git","clone_url":"https://github.com/Dorokhov/buffer.git","svn_url":"https://github.com/Dorokhov/buffer","homepage":"","size":15,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Dorokhov:master","ref":"master","sha":"1af494ccd5d84ae85228ee7a2e5eb790dd293d81","user":{"login":"Dorokhov","id":1944245,"node_id":"MDQ6VXNlcjE5NDQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1944245?v=4","gravatar_id":"","url":"https://api.github.com/users/Dorokhov","html_url":"https://github.com/Dorokhov","followers_url":"https://api.github.com/users/Dorokhov/followers","following_url":"https://api.github.com/users/Dorokhov/following{/other_user}","gists_url":"https://api.github.com/users/Dorokhov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorokhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorokhov/subscriptions","organizations_url":"https://api.github.com/users/Dorokhov/orgs","repos_url":"https://api.github.com/users/Dorokhov/repos","events_url":"https://api.github.com/users/Dorokhov/events{/privacy}","received_events_url":"https://api.github.com/users/Dorokhov/received_events","type":"User","site_admin":false},"repo":{"id":137356958,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczNTY5NTg=","name":"buffer","full_name":"Dorokhov/buffer","owner":{"login":"Dorokhov","id":1944245,"node_id":"MDQ6VXNlcjE5NDQyNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1944245?v=4","gravatar_id":"","url":"https://api.github.com/users/Dorokhov","html_url":"https://github.com/Dorokhov","followers_url":"https://api.github.com/users/Dorokhov/followers","following_url":"https://api.github.com/users/Dorokhov/following{/other_user}","gists_url":"https://api.github.com/users/Dorokhov/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorokhov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorokhov/subscriptions","organizations_url":"https://api.github.com/users/Dorokhov/orgs","repos_url":"https://api.github.com/users/Dorokhov/repos","events_url":"https://api.github.com/users/Dorokhov/events{/privacy}","received_events_url":"https://api.github.com/users/Dorokhov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dorokhov/buffer","description":"A file backed circular buffer for Go. Mmap file into memory. Madvise to lower memory footprint.","fork":true,"url":"https://api.github.com/repos/Dorokhov/buffer","forks_url":"https://api.github.com/repos/Dorokhov/buffer/forks","keys_url":"https://api.github.com/repos/Dorokhov/buffer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dorokhov/buffer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dorokhov/buffer/teams","hooks_url":"https://api.github.com/repos/Dorokhov/buffer/hooks","issue_events_url":"https://api.github.com/repos/Dorokhov/buffer/issues/events{/number}","events_url":"https://api.github.com/repos/Dorokhov/buffer/events","assignees_url":"https://api.github.com/repos/Dorokhov/buffer/assignees{/user}","branches_url":"https://api.github.com/repos/Dorokhov/buffer/branches{/branch}","tags_url":"https://api.github.com/repos/Dorokhov/buffer/tags","blobs_url":"https://api.github.com/repos/Dorokhov/buffer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dorokhov/buffer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dorokhov/buffer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dorokhov/buffer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dorokhov/buffer/statuses/{sha}","languages_url":"https://api.github.com/repos/Dorokhov/buffer/languages","stargazers_url":"https://api.github.com/repos/Dorokhov/buffer/stargazers","contributors_url":"https://api.github.com/repos/Dorokhov/buffer/contributors","subscribers_url":"https://api.github.com/repos/Dorokhov/buffer/subscribers","subscription_url":"https://api.github.com/repos/Dorokhov/buffer/subscription","commits_url":"https://api.github.com/repos/Dorokhov/buffer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dorokhov/buffer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dorokhov/buffer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dorokhov/buffer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dorokhov/buffer/contents/{+path}","compare_url":"https://api.github.com/repos/Dorokhov/buffer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dorokhov/buffer/merges","archive_url":"https://api.github.com/repos/Dorokhov/buffer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dorokhov/buffer/downloads","issues_url":"https://api.github.com/repos/Dorokhov/buffer/issues{/number}","pulls_url":"https://api.github.com/repos/Dorokhov/buffer/pulls{/number}","milestones_url":"https://api.github.com/repos/Dorokhov/buffer/milestones{/number}","notifications_url":"https://api.github.com/repos/Dorokhov/buffer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dorokhov/buffer/labels{/name}","releases_url":"https://api.github.com/repos/Dorokhov/buffer/releases{/id}","deployments_url":"https://api.github.com/repos/Dorokhov/buffer/deployments","created_at":"2018-06-14T12:43:50Z","updated_at":"2018-06-14T12:50:23Z","pushed_at":"2018-06-15T15:31:22Z","git_url":"git://github.com/Dorokhov/buffer.git","ssh_url":"git@github.com:Dorokhov/buffer.git","clone_url":"https://github.com/Dorokhov/buffer.git","svn_url":"https://github.com/Dorokhov/buffer","homepage":"","size":15,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Dorokhov/buffer/pulls/1"},"html":{"href":"https://github.com/Dorokhov/buffer/pull/1"},"issue":{"href":"https://api.github.com/repos/Dorokhov/buffer/issues/1"},"comments":{"href":"https://api.github.com/repos/Dorokhov/buffer/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Dorokhov/buffer/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Dorokhov/buffer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dorokhov/buffer/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Dorokhov/buffer/statuses/bb034b518e3da837c7f8f7418cb6fe3a5e788743"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kvap"}}