{"action":"created","issue":{"url":"https://api.github.com/repos/linux-nvme/nvme-cli/issues/320","repository_url":"https://api.github.com/repos/linux-nvme/nvme-cli","labels_url":"https://api.github.com/repos/linux-nvme/nvme-cli/issues/320/labels{/name}","comments_url":"https://api.github.com/repos/linux-nvme/nvme-cli/issues/320/comments","events_url":"https://api.github.com/repos/linux-nvme/nvme-cli/issues/320/events","html_url":"https://github.com/linux-nvme/nvme-cli/pull/320","id":306048703,"number":320,"title":"Change default value for log_id","user":{"login":"rrosatti","id":16086636,"avatar_url":"https://avatars3.githubusercontent.com/u/16086636?v=4","gravatar_id":"","url":"https://api.github.com/users/rrosatti","html_url":"https://github.com/rrosatti","followers_url":"https://api.github.com/users/rrosatti/followers","following_url":"https://api.github.com/users/rrosatti/following{/other_user}","gists_url":"https://api.github.com/users/rrosatti/gists{/gist_id}","starred_url":"https://api.github.com/users/rrosatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrosatti/subscriptions","organizations_url":"https://api.github.com/users/rrosatti/orgs","repos_url":"https://api.github.com/users/rrosatti/repos","events_url":"https://api.github.com/users/rrosatti/events{/privacy}","received_events_url":"https://api.github.com/users/rrosatti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-16T19:22:11Z","updated_at":"2018-03-16T19:49:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/linux-nvme/nvme-cli/pulls/320","html_url":"https://github.com/linux-nvme/nvme-cli/pull/320","diff_url":"https://github.com/linux-nvme/nvme-cli/pull/320.diff","patch_url":"https://github.com/linux-nvme/nvme-cli/pull/320.patch"},"body":"Currently the log_id is being set as 0 for default, if no value is\r\npassed with the '-i' parameter. In this situation, we get the error:\r\nNVMe Status:INVALID_LOG_PAGE(2109). It happens because 00h is Reserved\r\naccording to the NVM Express Spec 1.3.\r\n\r\nSigned-off-by: Rodrigo R. Galvao <rosattig@linux.vnet.ibm.com>"},"comment":{"url":"https://api.github.com/repos/linux-nvme/nvme-cli/issues/comments/373825906","html_url":"https://github.com/linux-nvme/nvme-cli/pull/320#issuecomment-373825906","issue_url":"https://api.github.com/repos/linux-nvme/nvme-cli/issues/320","id":373825906,"user":{"login":"rrosatti","id":16086636,"avatar_url":"https://avatars3.githubusercontent.com/u/16086636?v=4","gravatar_id":"","url":"https://api.github.com/users/rrosatti","html_url":"https://github.com/rrosatti","followers_url":"https://api.github.com/users/rrosatti/followers","following_url":"https://api.github.com/users/rrosatti/following{/other_user}","gists_url":"https://api.github.com/users/rrosatti/gists{/gist_id}","starred_url":"https://api.github.com/users/rrosatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrosatti/subscriptions","organizations_url":"https://api.github.com/users/rrosatti/orgs","repos_url":"https://api.github.com/users/rrosatti/repos","events_url":"https://api.github.com/users/rrosatti/events{/privacy}","received_events_url":"https://api.github.com/users/rrosatti/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T19:49:14Z","updated_at":"2018-03-16T19:49:14Z","author_association":"CONTRIBUTOR","body":"So, maybe we could use something like that:\r\nif (!cfg.log_id) {\r\n        fprintf(stderr, \"log-id is required param\\n\");\r\n        err = EINVAL;\r\n} \r\nThe same thing we are doing with the log_len parameter."}}
{"actor":{"display_login":"rrosatti"}}