{"action":"created","issue":{"url":"https://api.github.com/repos/neo4j/neo4j/issues/12118","repository_url":"https://api.github.com/repos/neo4j/neo4j","labels_url":"https://api.github.com/repos/neo4j/neo4j/issues/12118/labels{/name}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/12118/comments","events_url":"https://api.github.com/repos/neo4j/neo4j/issues/12118/events","html_url":"https://github.com/neo4j/neo4j/issues/12118","id":394484353,"node_id":"MDU6SXNzdWUzOTQ0ODQzNTM=","number":12118,"title":"TestGraphDatabaseFactory is not available in 3.5","user":{"login":"jcornaz","id":2535178,"node_id":"MDQ6VXNlcjI1MzUxNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/2535178?v=4","gravatar_id":"","url":"https://api.github.com/users/jcornaz","html_url":"https://github.com/jcornaz","followers_url":"https://api.github.com/users/jcornaz/followers","following_url":"https://api.github.com/users/jcornaz/following{/other_user}","gists_url":"https://api.github.com/users/jcornaz/gists{/gist_id}","starred_url":"https://api.github.com/users/jcornaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcornaz/subscriptions","organizations_url":"https://api.github.com/users/jcornaz/orgs","repos_url":"https://api.github.com/users/jcornaz/repos","events_url":"https://api.github.com/users/jcornaz/events{/privacy}","received_events_url":"https://api.github.com/users/jcornaz/received_events","type":"User","site_admin":false},"labels":[{"id":647068085,"node_id":"MDU6TGFiZWw2NDcwNjgwODU=","url":"https://api.github.com/repos/neo4j/neo4j/labels/team-kernel","name":"team-kernel","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-27T20:43:22Z","updated_at":"2019-01-02T16:21:54Z","closed_at":null,"author_association":"NONE","body":"Since Version 3.5 of neo4j-kernel (test-jar) the class `org.neo4j.test.TestGraphDatabaseFactory` is no longer available.\r\n\r\n### Environment\r\n- Neo4j version: 3.5.1\r\n- Operating system: Windows 10\r\n- API/Driver: Java API\r\n\r\n### Steps to reproduce\r\n  1.  Create a project with the dependency: `org.neo4j:neo4j-kernel:3.5.1:tests`\r\n  2. Write a simple (empty) class and the following import: `import org.neo4j.test.TestGraphDatabaseFactory`\r\n  3. Try to compile (`gradlew classes`)\r\n\r\n### Expected behavior\r\nSince `TestGraphDatabase` was available (and not deprecated) in version `3.4.10`. It should still be accessible. `import org.neo4j.test.TestGraphDatabaseFactory` should not cause any compilation issue.\r\n\r\n### Actual behavior\r\n  * Compilation fails with `Unresolved reference: TestGraphDatabaseFactory`\r\n"},"comment":{"url":"https://api.github.com/repos/neo4j/neo4j/issues/comments/450908816","html_url":"https://github.com/neo4j/neo4j/issues/12118#issuecomment-450908816","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/12118","id":450908816,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDkwODgxNg==","user":{"login":"MishaDemianenko","id":12656787,"node_id":"MDQ6VXNlcjEyNjU2Nzg3","avatar_url":"https://avatars2.githubusercontent.com/u/12656787?v=4","gravatar_id":"","url":"https://api.github.com/users/MishaDemianenko","html_url":"https://github.com/MishaDemianenko","followers_url":"https://api.github.com/users/MishaDemianenko/followers","following_url":"https://api.github.com/users/MishaDemianenko/following{/other_user}","gists_url":"https://api.github.com/users/MishaDemianenko/gists{/gist_id}","starred_url":"https://api.github.com/users/MishaDemianenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MishaDemianenko/subscriptions","organizations_url":"https://api.github.com/users/MishaDemianenko/orgs","repos_url":"https://api.github.com/users/MishaDemianenko/repos","events_url":"https://api.github.com/users/MishaDemianenko/events{/privacy}","received_events_url":"https://api.github.com/users/MishaDemianenko/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T16:21:54Z","updated_at":"2019-01-02T16:21:54Z","author_association":"CONTRIBUTOR","body":"@jcornaz provided javadoc is neo4j global public java doc. For example, it includes `org.neo4j.jmx` which is not part of kernel artifact, but still, its included.\r\n\r\nLet me answer point by point as well:\r\n1. Valid point.\r\n2. The fact that some class is public does not mean that its part of public API of any sort. Only classes that included into javadoc is part of public API. Class is public for our own internal purposes. End users can still use that for sure but public visibility does not make it publically supported API.\r\n3-4. We have quite a large codebase that survived quite some time and not all of the parts following any naming conventions or follows different conventions to make it even better. You should not rely on that at all. Only classes covered by javadoc are part of public API.\r\n\r\nAnd yep that was not intended to be exposed in a first place, as you can see its originaly as part of `test-jar` only but point taken and documentation will be updated accordinly. Thx!\r\n"}}
{"actor":{"display_login":"MishaDemianenko"}}