{"action":"closed","number":12627,"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12627","id":175596578,"html_url":"https://github.com/hazelcast/hazelcast/pull/12627","diff_url":"https://github.com/hazelcast/hazelcast/pull/12627.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/12627.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/12627","number":12627,"state":"closed","locked":false,"title":"Fixed merge policy check in ConfigValidator","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars3.githubusercontent.com/u/4196298?v=4","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"`ConfigValidator.checkMergePolicySupportsInMemoryFormat()` used a simple `Class.for()` to create a merge policy instance, which didn't work with simple class names (the default for 3.10 merge policies):\r\n\r\n> java.lang.ClassNotFoundException: PutIfAbsentMergePolicy\r\n\r\nThis PR makes use of the existing merge policy providers to retrieve an instance of the configured merge policy.\r\n\r\nIt also replaced `CacheProxyUtil.validateCacheConfig()` calls with `ConfigValidator.checkCacheConfig()`, to prepare the upcoming changes.","created_at":"2018-03-16T17:19:49Z","updated_at":"2018-03-20T11:58:10Z","closed_at":"2018-03-20T11:58:10Z","merged_at":"2018-03-20T11:58:10Z","merge_commit_sha":"e64a25d14662d1f0577e5b4162ded5466f4bb51b","assignee":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars3.githubusercontent.com/u/4196298?v=4","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"assignees":[{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars3.githubusercontent.com/u/4196298?v=4","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mmedenjak","id":17194871,"avatar_url":"https://avatars0.githubusercontent.com/u/17194871?v=4","gravatar_id":"","url":"https://api.github.com/users/mmedenjak","html_url":"https://github.com/mmedenjak","followers_url":"https://api.github.com/users/mmedenjak/followers","following_url":"https://api.github.com/users/mmedenjak/following{/other_user}","gists_url":"https://api.github.com/users/mmedenjak/gists{/gist_id}","starred_url":"https://api.github.com/users/mmedenjak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmedenjak/subscriptions","organizations_url":"https://api.github.com/users/mmedenjak/orgs","repos_url":"https://api.github.com/users/mmedenjak/repos","events_url":"https://api.github.com/users/mmedenjak/events{/privacy}","received_events_url":"https://api.github.com/users/mmedenjak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":137752575,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Team:%20Core","name":"Team: Core","color":"109def","default":false},{"id":1740690,"url":"https://api.github.com/repos/hazelcast/hazelcast/labels/Type:%20Defect","name":"Type: Defect","color":"eb6420","default":false}],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/98","html_url":"https://github.com/hazelcast/hazelcast/milestone/98","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/98/labels","id":2624978,"number":98,"title":"3.10","description":null,"creator":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars1.githubusercontent.com/u/158619?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"open_issues":69,"closed_issues":686,"state":"open","created_at":"2017-07-06T10:25:45Z","updated_at":"2018-03-20T11:58:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12627/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12627/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/12627/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/86157570b4e0ff5627a4f0085ea1ff81f09e98ef","head":{"label":"Donnerbart:fixedConfigValidatorCheckMergePolicySupportsInMemoryFormat","ref":"fixedConfigValidatorCheckMergePolicySupportsInMemoryFormat","sha":"86157570b4e0ff5627a4f0085ea1ff81f09e98ef","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars3.githubusercontent.com/u/4196298?v=4","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"repo":{"id":13138412,"name":"hazelcast","full_name":"Donnerbart/hazelcast","owner":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars3.githubusercontent.com/u/4196298?v=4","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Donnerbart/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/Donnerbart/hazelcast","forks_url":"https://api.github.com/repos/Donnerbart/hazelcast/forks","keys_url":"https://api.github.com/repos/Donnerbart/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Donnerbart/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Donnerbart/hazelcast/teams","hooks_url":"https://api.github.com/repos/Donnerbart/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/Donnerbart/hazelcast/events","assignees_url":"https://api.github.com/repos/Donnerbart/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/Donnerbart/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/Donnerbart/hazelcast/tags","blobs_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Donnerbart/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/Donnerbart/hazelcast/languages","stargazers_url":"https://api.github.com/repos/Donnerbart/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/Donnerbart/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/Donnerbart/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/Donnerbart/hazelcast/subscription","commits_url":"https://api.github.com/repos/Donnerbart/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/Donnerbart/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/Donnerbart/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/Donnerbart/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Donnerbart/hazelcast/merges","archive_url":"https://api.github.com/repos/Donnerbart/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Donnerbart/hazelcast/downloads","issues_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/Donnerbart/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/Donnerbart/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/Donnerbart/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Donnerbart/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/Donnerbart/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/Donnerbart/hazelcast/deployments","created_at":"2013-09-27T01:15:56Z","updated_at":"2018-03-20T09:48:20Z","pushed_at":"2018-03-20T09:48:19Z","git_url":"git://github.com/Donnerbart/hazelcast.git","ssh_url":"git@github.com:Donnerbart/hazelcast.git","clone_url":"https://github.com/Donnerbart/hazelcast.git","svn_url":"https://github.com/Donnerbart/hazelcast","homepage":"www.hazelcast.com","size":127623,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"622d32d86f77b858300f63010959997de897b083","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2018-03-20T10:58:19Z","pushed_at":"2018-03-20T11:58:10Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"http://www.hazelcast.org","size":127505,"stargazers_count":2500,"watchers_count":2500,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":996,"mirror_url":null,"archived":false,"open_issues_count":648,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":996,"open_issues":648,"watchers":2500,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12627"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/12627"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/12627"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/12627/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12627/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/12627/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/86157570b4e0ff5627a4f0085ea1ff81f09e98ef"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars3.githubusercontent.com/u/4196298?v=4","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":183,"deletions":82,"changed_files":8}}
{"actor":{"display_login":"Donnerbart"}}