{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/172170193","pull_request_review_id":101140622,"id":172170193,"diff_hunk":"@@ -670,11 +669,10 @@ void c_typecheck_baset::typecheck_return(codet &code)\n        return_type.id()!=ID_destructor)\n     {\n       // gcc doesn't actually complain, it just warns!\n-      // We'll put a zero here, which is dubious.\n-      exprt zero=\n-        zero_initializer(\n-          return_type, code.source_location(), *this, get_message_handler());\n-      code.copy_to_operands(zero);\n+      warning().source_location=code.source_location();\n+      warning() << \"non-void function should return a value\" << eom;\n+\n+      code.copy_to_operands(side_effect_expr_nondett(return_type));","path":"src/ansi-c/c_typecheck_code.cpp","position":20,"original_position":20,"commit_id":"333a8900059ea5ad2d18c5c2ff9f81fba496f566","original_commit_id":"333a8900059ea5ad2d18c5c2ff9f81fba496f566","user":{"login":"hannes-steffenhagen-diffblue","id":34235469,"avatar_url":"https://avatars1.githubusercontent.com/u/34235469?v=4","gravatar_id":"","url":"https://api.github.com/users/hannes-steffenhagen-diffblue","html_url":"https://github.com/hannes-steffenhagen-diffblue","followers_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/followers","following_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/following{/other_user}","gists_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/subscriptions","organizations_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/orgs","repos_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/repos","events_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/hannes-steffenhagen-diffblue/received_events","type":"User","site_admin":false},"body":"Would `to_code_return(code).return_value() = side_effect_expr_nondett(return_type)` be clearer?","created_at":"2018-03-05T12:23:33Z","updated_at":"2018-03-05T12:23:33Z","html_url":"https://github.com/diffblue/cbmc/pull/1906#discussion_r172170193","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1906","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/172170193"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1906#discussion_r172170193"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1906"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1906","id":172559649,"html_url":"https://github.com/diffblue/cbmc/pull/1906","diff_url":"https://github.com/diffblue/cbmc/pull/1906.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1906.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1906","number":1906,"state":"open","locked":false,"title":"Replace a missing return value by nondet","user":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars3.githubusercontent.com/u/1144736?v=4","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"body":"A missing return value is undefined behaviour. Previously the code would return\r\n0, which is unsound, and wouldn't even yield a warning.","created_at":"2018-03-02T17:27:21Z","updated_at":"2018-03-05T12:23:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a975b47f59d38848b259e8dd6e6f55c35fe87181","assignee":{"login":"kroening","id":1830565,"avatar_url":"https://avatars0.githubusercontent.com/u/1830565?v=4","gravatar_id":"","url":"https://api.github.com/users/kroening","html_url":"https://github.com/kroening","followers_url":"https://api.github.com/users/kroening/followers","following_url":"https://api.github.com/users/kroening/following{/other_user}","gists_url":"https://api.github.com/users/kroening/gists{/gist_id}","starred_url":"https://api.github.com/users/kroening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroening/subscriptions","organizations_url":"https://api.github.com/users/kroening/orgs","repos_url":"https://api.github.com/users/kroening/repos","events_url":"https://api.github.com/users/kroening/events{/privacy}","received_events_url":"https://api.github.com/users/kroening/received_events","type":"User","site_admin":false},"assignees":[{"login":"kroening","id":1830565,"avatar_url":"https://avatars0.githubusercontent.com/u/1830565?v=4","gravatar_id":"","url":"https://api.github.com/users/kroening","html_url":"https://github.com/kroening","followers_url":"https://api.github.com/users/kroening/followers","following_url":"https://api.github.com/users/kroening/following{/other_user}","gists_url":"https://api.github.com/users/kroening/gists{/gist_id}","starred_url":"https://api.github.com/users/kroening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroening/subscriptions","organizations_url":"https://api.github.com/users/kroening/orgs","repos_url":"https://api.github.com/users/kroening/repos","events_url":"https://api.github.com/users/kroening/events{/privacy}","received_events_url":"https://api.github.com/users/kroening/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kroening","id":1830565,"avatar_url":"https://avatars0.githubusercontent.com/u/1830565?v=4","gravatar_id":"","url":"https://api.github.com/users/kroening","html_url":"https://github.com/kroening","followers_url":"https://api.github.com/users/kroening/followers","following_url":"https://api.github.com/users/kroening/following{/other_user}","gists_url":"https://api.github.com/users/kroening/gists{/gist_id}","starred_url":"https://api.github.com/users/kroening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroening/subscriptions","organizations_url":"https://api.github.com/users/kroening/orgs","repos_url":"https://api.github.com/users/kroening/repos","events_url":"https://api.github.com/users/kroening/events{/privacy}","received_events_url":"https://api.github.com/users/kroening/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":394812358,"url":"https://api.github.com/repos/diffblue/cbmc/labels/C%20Front%20End","name":"C Front End","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1906/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1906/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1906/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/333a8900059ea5ad2d18c5c2ff9f81fba496f566","head":{"label":"tautschnig:missing-return-semantics","ref":"missing-return-semantics","sha":"333a8900059ea5ad2d18c5c2ff9f81fba496f566","user":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars3.githubusercontent.com/u/1144736?v=4","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"repo":{"id":52358391,"name":"cbmc","full_name":"tautschnig/cbmc","owner":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars3.githubusercontent.com/u/1144736?v=4","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tautschnig/cbmc","description":null,"fork":true,"url":"https://api.github.com/repos/tautschnig/cbmc","forks_url":"https://api.github.com/repos/tautschnig/cbmc/forks","keys_url":"https://api.github.com/repos/tautschnig/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tautschnig/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tautschnig/cbmc/teams","hooks_url":"https://api.github.com/repos/tautschnig/cbmc/hooks","issue_events_url":"https://api.github.com/repos/tautschnig/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/tautschnig/cbmc/events","assignees_url":"https://api.github.com/repos/tautschnig/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/tautschnig/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/tautschnig/cbmc/tags","blobs_url":"https://api.github.com/repos/tautschnig/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tautschnig/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tautschnig/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/tautschnig/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tautschnig/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/tautschnig/cbmc/languages","stargazers_url":"https://api.github.com/repos/tautschnig/cbmc/stargazers","contributors_url":"https://api.github.com/repos/tautschnig/cbmc/contributors","subscribers_url":"https://api.github.com/repos/tautschnig/cbmc/subscribers","subscription_url":"https://api.github.com/repos/tautschnig/cbmc/subscription","commits_url":"https://api.github.com/repos/tautschnig/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/tautschnig/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/tautschnig/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/tautschnig/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/tautschnig/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/tautschnig/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tautschnig/cbmc/merges","archive_url":"https://api.github.com/repos/tautschnig/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tautschnig/cbmc/downloads","issues_url":"https://api.github.com/repos/tautschnig/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/tautschnig/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/tautschnig/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/tautschnig/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tautschnig/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/tautschnig/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/tautschnig/cbmc/deployments","created_at":"2016-02-23T12:48:00Z","updated_at":"2016-02-23T12:48:14Z","pushed_at":"2018-03-04T16:40:46Z","git_url":"git://github.com/tautschnig/cbmc.git","ssh_url":"git@github.com:tautschnig/cbmc.git","clone_url":"https://github.com/tautschnig/cbmc.git","svn_url":"https://github.com/tautschnig/cbmc","homepage":null,"size":48368,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"diffblue:develop","ref":"develop","sha":"37a11f90af1a6476f3d6f4015bde21c29177d088","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2018-02-26T12:21:45Z","pushed_at":"2018-03-05T11:49:59Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":28653,"stargazers_count":102,"watchers_count":102,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":311,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":89,"open_issues":311,"watchers":102,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1906"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1906"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1906"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1906/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1906/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1906/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/333a8900059ea5ad2d18c5c2ff9f81fba496f566"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hannes-steffenhagen-diffblue"}}