{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/238826374","pull_request_review_id":181464270,"id":238826374,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODgyNjM3NA==","diff_hunk":"@@ -359,9 +359,12 @@ export class InaboxMessagingHost {\n  * @private\n  */\n function canInspectWindow_(win) {\n+  // TODO: this is not reliable.  The compiler assumes that property reads are\n+  // side-effect free.  The recommended fix is to use goog.reflect.sinkValue\n+  // but since we're not using the closure library I'm not sure how to do this.\n+  // See https://github.com/google/closure-compiler/issues/3156\n   try {\n-    const unused = !!win.location.href && win['test']; // eslint-disable-line no-unused-vars\n-    return true;\n+    return !!win.location.href && win['test'];","path":"ads/inabox/inabox-messaging-host.js","position":11,"original_position":11,"commit_id":"fa37428ab3681b8ddf815a8c03d42aa50bd4139a","original_commit_id":"fa37428ab3681b8ddf815a8c03d42aa50bd4139a","user":{"login":"jridgewell","id":112982,"node_id":"MDQ6VXNlcjExMjk4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/112982?v=4","gravatar_id":"","url":"https://api.github.com/users/jridgewell","html_url":"https://github.com/jridgewell","followers_url":"https://api.github.com/users/jridgewell/followers","following_url":"https://api.github.com/users/jridgewell/following{/other_user}","gists_url":"https://api.github.com/users/jridgewell/gists{/gist_id}","starred_url":"https://api.github.com/users/jridgewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jridgewell/subscriptions","organizations_url":"https://api.github.com/users/jridgewell/orgs","repos_url":"https://api.github.com/users/jridgewell/repos","events_url":"https://api.github.com/users/jridgewell/events{/privacy}","received_events_url":"https://api.github.com/users/jridgewell/received_events","type":"User","site_admin":false},"body":"I wonder: `win.Object() !== win.Object()`.","created_at":"2018-12-04T20:29:49Z","updated_at":"2018-12-04T20:29:52Z","html_url":"https://github.com/ampproject/amphtml/pull/19632#discussion_r238826374","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19632","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/238826374"},"html":{"href":"https://github.com/ampproject/amphtml/pull/19632#discussion_r238826374"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19632"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/19632","id":235938848,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTM4ODQ4","html_url":"https://github.com/ampproject/amphtml/pull/19632","diff_url":"https://github.com/ampproject/amphtml/pull/19632.diff","patch_url":"https://github.com/ampproject/amphtml/pull/19632.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/19632","number":19632,"state":"open","locked":false,"title":"🐛inabox: workaround to keep compiler from removing cross-domain check","user":{"login":"jeffkaufman","id":262566,"node_id":"MDQ6VXNlcjI2MjU2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/262566?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffkaufman","html_url":"https://github.com/jeffkaufman","followers_url":"https://api.github.com/users/jeffkaufman/followers","following_url":"https://api.github.com/users/jeffkaufman/following{/other_user}","gists_url":"https://api.github.com/users/jeffkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkaufman/subscriptions","organizations_url":"https://api.github.com/users/jeffkaufman/orgs","repos_url":"https://api.github.com/users/jeffkaufman/repos","events_url":"https://api.github.com/users/jeffkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkaufman/received_events","type":"User","site_admin":false},"body":"The compiler assumes that property reads are side-effect free, and so is removing our check for whether a window is cross domain.  As a workaround, rewrite the function to confuse the compiler into keeping our code.  This could easily get broken again, though, if the compiler got smarter.","created_at":"2018-12-04T19:54:05Z","updated_at":"2018-12-04T20:29:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b5f012ce8c40d4f970db192d9d960083bacb0bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19632/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/19632/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/19632/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/fa37428ab3681b8ddf815a8c03d42aa50bd4139a","head":{"label":"jeffkaufman:compiler-skip","ref":"compiler-skip","sha":"fa37428ab3681b8ddf815a8c03d42aa50bd4139a","user":{"login":"jeffkaufman","id":262566,"node_id":"MDQ6VXNlcjI2MjU2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/262566?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffkaufman","html_url":"https://github.com/jeffkaufman","followers_url":"https://api.github.com/users/jeffkaufman/followers","following_url":"https://api.github.com/users/jeffkaufman/following{/other_user}","gists_url":"https://api.github.com/users/jeffkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkaufman/subscriptions","organizations_url":"https://api.github.com/users/jeffkaufman/orgs","repos_url":"https://api.github.com/users/jeffkaufman/repos","events_url":"https://api.github.com/users/jeffkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkaufman/received_events","type":"User","site_admin":false},"repo":{"id":119404856,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MDQ4NTY=","name":"amphtml","full_name":"jeffkaufman/amphtml","private":false,"owner":{"login":"jeffkaufman","id":262566,"node_id":"MDQ6VXNlcjI2MjU2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/262566?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffkaufman","html_url":"https://github.com/jeffkaufman","followers_url":"https://api.github.com/users/jeffkaufman/followers","following_url":"https://api.github.com/users/jeffkaufman/following{/other_user}","gists_url":"https://api.github.com/users/jeffkaufman/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffkaufman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffkaufman/subscriptions","organizations_url":"https://api.github.com/users/jeffkaufman/orgs","repos_url":"https://api.github.com/users/jeffkaufman/repos","events_url":"https://api.github.com/users/jeffkaufman/events{/privacy}","received_events_url":"https://api.github.com/users/jeffkaufman/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jeffkaufman/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/jeffkaufman/amphtml","forks_url":"https://api.github.com/repos/jeffkaufman/amphtml/forks","keys_url":"https://api.github.com/repos/jeffkaufman/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffkaufman/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffkaufman/amphtml/teams","hooks_url":"https://api.github.com/repos/jeffkaufman/amphtml/hooks","issue_events_url":"https://api.github.com/repos/jeffkaufman/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/jeffkaufman/amphtml/events","assignees_url":"https://api.github.com/repos/jeffkaufman/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/jeffkaufman/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/jeffkaufman/amphtml/tags","blobs_url":"https://api.github.com/repos/jeffkaufman/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffkaufman/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffkaufman/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffkaufman/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffkaufman/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffkaufman/amphtml/languages","stargazers_url":"https://api.github.com/repos/jeffkaufman/amphtml/stargazers","contributors_url":"https://api.github.com/repos/jeffkaufman/amphtml/contributors","subscribers_url":"https://api.github.com/repos/jeffkaufman/amphtml/subscribers","subscription_url":"https://api.github.com/repos/jeffkaufman/amphtml/subscription","commits_url":"https://api.github.com/repos/jeffkaufman/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffkaufman/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffkaufman/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffkaufman/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffkaufman/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/jeffkaufman/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffkaufman/amphtml/merges","archive_url":"https://api.github.com/repos/jeffkaufman/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffkaufman/amphtml/downloads","issues_url":"https://api.github.com/repos/jeffkaufman/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/jeffkaufman/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffkaufman/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffkaufman/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffkaufman/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/jeffkaufman/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/jeffkaufman/amphtml/deployments","created_at":"2018-01-29T15:57:21Z","updated_at":"2018-01-29T15:57:31Z","pushed_at":"2018-12-04T19:51:14Z","git_url":"git://github.com/jeffkaufman/amphtml.git","ssh_url":"git@github.com:jeffkaufman/amphtml.git","clone_url":"https://github.com/jeffkaufman/amphtml.git","svn_url":"https://github.com/jeffkaufman/amphtml","homepage":"https://www.ampproject.org","size":564754,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"689589dc19adf8dc3fcbfc8e6b84ec6a20f9d309","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-12-04T19:13:08Z","pushed_at":"2018-12-04T20:27:57Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":565154,"stargazers_count":12223,"watchers_count":12223,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2721,"mirror_url":null,"archived":false,"open_issues_count":1561,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2721,"open_issues":1561,"watchers":12223,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19632"},"html":{"href":"https://github.com/ampproject/amphtml/pull/19632"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/19632"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/19632/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19632/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/19632/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/fa37428ab3681b8ddf815a8c03d42aa50bd4139a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jridgewell"}}