{"action":"created","comment":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/240925512","pull_request_review_id":184066153,"id":240925512,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDkyNTUxMg==","diff_hunk":"@@ -194,9 +194,9 @@ private bool TryGetCpuUsage(BlittableJsonReaderObject blittable, string property\n                 HandleError($\"Can't read {propertyName} property from : {Environment.NewLine + blittable}.\");\n                 return false;\n             }\n-            if (cpuUsage < 0 || cpuUsage > 100)\n+            if (cpuUsage < 0)\n             {\n-                HandleError($\"{nameof(ExtensionPointData.MachineCpuUsage)} should be between 0 to 100 : {Environment.NewLine + blittable}.\");\n+                HandleError($\"{nameof(ExtensionPointData.MachineCpuUsage)} can't be negative : {Environment.NewLine + blittable}.\");\n                 return false;\n             }","path":"src/Raven.Server/Utils/Cpu/CpuUsageExtensionPoint.cs","position":10,"original_position":10,"commit_id":"b76c55b854a8ba8be4821535fdaa12c76211304f","original_commit_id":"a0cbb5818c65050cc1d442322b064b2a119f0711","user":{"login":"haludi","id":37696258,"node_id":"MDQ6VXNlcjM3Njk2MjU4","avatar_url":"https://avatars3.githubusercontent.com/u/37696258?v=4","gravatar_id":"","url":"https://api.github.com/users/haludi","html_url":"https://github.com/haludi","followers_url":"https://api.github.com/users/haludi/followers","following_url":"https://api.github.com/users/haludi/following{/other_user}","gists_url":"https://api.github.com/users/haludi/gists{/gist_id}","starred_url":"https://api.github.com/users/haludi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haludi/subscriptions","organizations_url":"https://api.github.com/users/haludi/orgs","repos_url":"https://api.github.com/users/haludi/repos","events_url":"https://api.github.com/users/haludi/events{/privacy}","received_events_url":"https://api.github.com/users/haludi/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-12-12T08:54:31Z","updated_at":"2018-12-12T08:54:32Z","html_url":"https://github.com/ravendb/ravendb/pull/8204#discussion_r240925512","pull_request_url":"https://api.github.com/repos/ravendb/ravendb/pulls/8204","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments/240925512"},"html":{"href":"https://github.com/ravendb/ravendb/pull/8204#discussion_r240925512"},"pull_request":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/8204"}},"in_reply_to_id":240570861},"pull_request":{"url":"https://api.github.com/repos/ravendb/ravendb/pulls/8204","id":237635695,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NjM1Njk1","html_url":"https://github.com/ravendb/ravendb/pull/8204","diff_url":"https://github.com/ravendb/ravendb/pull/8204.diff","patch_url":"https://github.com/ravendb/ravendb/pull/8204.patch","issue_url":"https://api.github.com/repos/ravendb/ravendb/issues/8204","number":8204,"state":"open","locked":false,"title":"RavenDB-12470 Allow CPU usage to be greater than 100%","user":{"login":"haludi","id":37696258,"node_id":"MDQ6VXNlcjM3Njk2MjU4","avatar_url":"https://avatars3.githubusercontent.com/u/37696258?v=4","gravatar_id":"","url":"https://api.github.com/users/haludi","html_url":"https://github.com/haludi","followers_url":"https://api.github.com/users/haludi/followers","following_url":"https://api.github.com/users/haludi/following{/other_user}","gists_url":"https://api.github.com/users/haludi/gists{/gist_id}","starred_url":"https://api.github.com/users/haludi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haludi/subscriptions","organizations_url":"https://api.github.com/users/haludi/orgs","repos_url":"https://api.github.com/users/haludi/repos","events_url":"https://api.github.com/users/haludi/events{/privacy}","received_events_url":"https://api.github.com/users/haludi/received_events","type":"User","site_admin":false},"body":"http://issues.hibernatingrhinos.com/issue/RavenDB-12470\r\nIn Kubernetes the CPU usage that comes from metrics server can be more than 100%\r\nso the `CpuUsageExtensionPoint` modified to accept it as a valid value","created_at":"2018-12-11T11:02:08Z","updated_at":"2018-12-12T08:54:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"334b6cc0417bd268247c9e07c626fee5d9c01a6b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1029659226,"node_id":"MDU6TGFiZWwxMDI5NjU5MjI2","url":"https://api.github.com/repos/ravendb/ravendb/labels/v4.1","name":"v4.1","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ravendb/ravendb/pulls/8204/commits","review_comments_url":"https://api.github.com/repos/ravendb/ravendb/pulls/8204/comments","review_comment_url":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ravendb/ravendb/issues/8204/comments","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/b76c55b854a8ba8be4821535fdaa12c76211304f","head":{"label":"haludi:RavenDB-12470","ref":"RavenDB-12470","sha":"b76c55b854a8ba8be4821535fdaa12c76211304f","user":{"login":"haludi","id":37696258,"node_id":"MDQ6VXNlcjM3Njk2MjU4","avatar_url":"https://avatars3.githubusercontent.com/u/37696258?v=4","gravatar_id":"","url":"https://api.github.com/users/haludi","html_url":"https://github.com/haludi","followers_url":"https://api.github.com/users/haludi/followers","following_url":"https://api.github.com/users/haludi/following{/other_user}","gists_url":"https://api.github.com/users/haludi/gists{/gist_id}","starred_url":"https://api.github.com/users/haludi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haludi/subscriptions","organizations_url":"https://api.github.com/users/haludi/orgs","repos_url":"https://api.github.com/users/haludi/repos","events_url":"https://api.github.com/users/haludi/events{/privacy}","received_events_url":"https://api.github.com/users/haludi/received_events","type":"User","site_admin":false},"repo":{"id":135031119,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwMzExMTk=","name":"ravendb","full_name":"haludi/ravendb","private":false,"owner":{"login":"haludi","id":37696258,"node_id":"MDQ6VXNlcjM3Njk2MjU4","avatar_url":"https://avatars3.githubusercontent.com/u/37696258?v=4","gravatar_id":"","url":"https://api.github.com/users/haludi","html_url":"https://github.com/haludi","followers_url":"https://api.github.com/users/haludi/followers","following_url":"https://api.github.com/users/haludi/following{/other_user}","gists_url":"https://api.github.com/users/haludi/gists{/gist_id}","starred_url":"https://api.github.com/users/haludi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haludi/subscriptions","organizations_url":"https://api.github.com/users/haludi/orgs","repos_url":"https://api.github.com/users/haludi/repos","events_url":"https://api.github.com/users/haludi/events{/privacy}","received_events_url":"https://api.github.com/users/haludi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/haludi/ravendb","description":"ACID Document Database","fork":true,"url":"https://api.github.com/repos/haludi/ravendb","forks_url":"https://api.github.com/repos/haludi/ravendb/forks","keys_url":"https://api.github.com/repos/haludi/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haludi/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haludi/ravendb/teams","hooks_url":"https://api.github.com/repos/haludi/ravendb/hooks","issue_events_url":"https://api.github.com/repos/haludi/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/haludi/ravendb/events","assignees_url":"https://api.github.com/repos/haludi/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/haludi/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/haludi/ravendb/tags","blobs_url":"https://api.github.com/repos/haludi/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haludi/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haludi/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/haludi/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haludi/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/haludi/ravendb/languages","stargazers_url":"https://api.github.com/repos/haludi/ravendb/stargazers","contributors_url":"https://api.github.com/repos/haludi/ravendb/contributors","subscribers_url":"https://api.github.com/repos/haludi/ravendb/subscribers","subscription_url":"https://api.github.com/repos/haludi/ravendb/subscription","commits_url":"https://api.github.com/repos/haludi/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/haludi/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/haludi/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/haludi/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/haludi/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/haludi/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haludi/ravendb/merges","archive_url":"https://api.github.com/repos/haludi/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haludi/ravendb/downloads","issues_url":"https://api.github.com/repos/haludi/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/haludi/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/haludi/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/haludi/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haludi/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/haludi/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/haludi/ravendb/deployments","created_at":"2018-05-27T09:03:26Z","updated_at":"2018-11-20T08:17:57Z","pushed_at":"2018-12-12T08:53:07Z","git_url":"git://github.com/haludi/ravendb.git","ssh_url":"git@github.com:haludi/ravendb.git","clone_url":"https://github.com/haludi/ravendb.git","svn_url":"https://github.com/haludi/ravendb","homepage":"https://ravendb.net","size":455226,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"v4.0"}},"base":{"label":"ravendb:v4.1","ref":"v4.1","sha":"7496c3f657f875096cc25200392e49f744fd9667","user":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"repo":{"id":542714,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI3MTQ=","name":"ravendb","full_name":"ravendb/ravendb","private":false,"owner":{"login":"ravendb","id":213792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMzc5Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/213792?v=4","gravatar_id":"","url":"https://api.github.com/users/ravendb","html_url":"https://github.com/ravendb","followers_url":"https://api.github.com/users/ravendb/followers","following_url":"https://api.github.com/users/ravendb/following{/other_user}","gists_url":"https://api.github.com/users/ravendb/gists{/gist_id}","starred_url":"https://api.github.com/users/ravendb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravendb/subscriptions","organizations_url":"https://api.github.com/users/ravendb/orgs","repos_url":"https://api.github.com/users/ravendb/repos","events_url":"https://api.github.com/users/ravendb/events{/privacy}","received_events_url":"https://api.github.com/users/ravendb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ravendb/ravendb","description":"ACID Document Database","fork":false,"url":"https://api.github.com/repos/ravendb/ravendb","forks_url":"https://api.github.com/repos/ravendb/ravendb/forks","keys_url":"https://api.github.com/repos/ravendb/ravendb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravendb/ravendb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravendb/ravendb/teams","hooks_url":"https://api.github.com/repos/ravendb/ravendb/hooks","issue_events_url":"https://api.github.com/repos/ravendb/ravendb/issues/events{/number}","events_url":"https://api.github.com/repos/ravendb/ravendb/events","assignees_url":"https://api.github.com/repos/ravendb/ravendb/assignees{/user}","branches_url":"https://api.github.com/repos/ravendb/ravendb/branches{/branch}","tags_url":"https://api.github.com/repos/ravendb/ravendb/tags","blobs_url":"https://api.github.com/repos/ravendb/ravendb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravendb/ravendb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravendb/ravendb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravendb/ravendb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravendb/ravendb/statuses/{sha}","languages_url":"https://api.github.com/repos/ravendb/ravendb/languages","stargazers_url":"https://api.github.com/repos/ravendb/ravendb/stargazers","contributors_url":"https://api.github.com/repos/ravendb/ravendb/contributors","subscribers_url":"https://api.github.com/repos/ravendb/ravendb/subscribers","subscription_url":"https://api.github.com/repos/ravendb/ravendb/subscription","commits_url":"https://api.github.com/repos/ravendb/ravendb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravendb/ravendb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravendb/ravendb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravendb/ravendb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravendb/ravendb/contents/{+path}","compare_url":"https://api.github.com/repos/ravendb/ravendb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravendb/ravendb/merges","archive_url":"https://api.github.com/repos/ravendb/ravendb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravendb/ravendb/downloads","issues_url":"https://api.github.com/repos/ravendb/ravendb/issues{/number}","pulls_url":"https://api.github.com/repos/ravendb/ravendb/pulls{/number}","milestones_url":"https://api.github.com/repos/ravendb/ravendb/milestones{/number}","notifications_url":"https://api.github.com/repos/ravendb/ravendb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravendb/ravendb/labels{/name}","releases_url":"https://api.github.com/repos/ravendb/ravendb/releases{/id}","deployments_url":"https://api.github.com/repos/ravendb/ravendb/deployments","created_at":"2010-03-02T11:05:30Z","updated_at":"2018-12-12T08:31:25Z","pushed_at":"2018-12-12T08:53:09Z","git_url":"git://github.com/ravendb/ravendb.git","ssh_url":"git@github.com:ravendb/ravendb.git","clone_url":"https://github.com/ravendb/ravendb.git","svn_url":"https://github.com/ravendb/ravendb","homepage":"https://ravendb.net","size":455656,"stargazers_count":2067,"watchers_count":2067,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":706,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":706,"open_issues":10,"watchers":2067,"default_branch":"v4.1"}},"_links":{"self":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/8204"},"html":{"href":"https://github.com/ravendb/ravendb/pull/8204"},"issue":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/8204"},"comments":{"href":"https://api.github.com/repos/ravendb/ravendb/issues/8204/comments"},"review_comments":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/8204/comments"},"review_comment":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ravendb/ravendb/pulls/8204/commits"},"statuses":{"href":"https://api.github.com/repos/ravendb/ravendb/statuses/b76c55b854a8ba8be4821535fdaa12c76211304f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"haludi"}}