{"action":"closed","number":747,"pull_request":{"url":"https://api.github.com/repos/paypal/paypal-checkout/pulls/747","id":201366549,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzY2NTQ5","html_url":"https://github.com/paypal/paypal-checkout/pull/747","diff_url":"https://github.com/paypal/paypal-checkout/pull/747.diff","patch_url":"https://github.com/paypal/paypal-checkout/pull/747.patch","issue_url":"https://api.github.com/repos/paypal/paypal-checkout/issues/747","number":747,"state":"closed","locked":false,"title":"fix(iframe): Use the iFrame for all standalone apps","user":{"login":"mcntsh","id":1314484,"node_id":"MDQ6VXNlcjEzMTQ0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1314484?v=4","gravatar_id":"","url":"https://api.github.com/users/mcntsh","html_url":"https://github.com/mcntsh","followers_url":"https://api.github.com/users/mcntsh/followers","following_url":"https://api.github.com/users/mcntsh/following{/other_user}","gists_url":"https://api.github.com/users/mcntsh/gists{/gist_id}","starred_url":"https://api.github.com/users/mcntsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcntsh/subscriptions","organizations_url":"https://api.github.com/users/mcntsh/orgs","repos_url":"https://api.github.com/users/mcntsh/repos","events_url":"https://api.github.com/users/mcntsh/events{/privacy}","received_events_url":"https://api.github.com/users/mcntsh/received_events","type":"User","site_admin":false},"body":"REF: https://github.com/paypal/paypal-checkout/issues/699\r\n\r\nBefore, we were using the user-agent to detect whether or not the app was being rendered in an iOS\r\nnative web-view. The problem is that PWA's saved to the iOS homescreen were not being treated like\r\nweb-views and were still trying to open a pop-up.\r\n\r\nHere's the documentation I used to detect \"Home Screen\" apps: https://developers.google.com/web/fundamentals/app-install-banners/#detect-mode\r\n\r\nThe caveat is that chrome windows opened using `window.open('...', '_blank');` will also be detected as standalone apps using this logic. ","created_at":"2018-07-13T18:27:11Z","updated_at":"2018-07-16T17:02:49Z","closed_at":"2018-07-16T17:02:49Z","merged_at":"2018-07-16T17:02:49Z","merge_commit_sha":"ed97181805fdb9bb2e095e86bbb2064ed1ce7355","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/paypal-checkout/pulls/747/commits","review_comments_url":"https://api.github.com/repos/paypal/paypal-checkout/pulls/747/comments","review_comment_url":"https://api.github.com/repos/paypal/paypal-checkout/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/paypal-checkout/issues/747/comments","statuses_url":"https://api.github.com/repos/paypal/paypal-checkout/statuses/737a488e8e160adde93527e24056c0dd23f1fc81","head":{"label":"mcntsh:fix/standalone-pwa-iframe","ref":"fix/standalone-pwa-iframe","sha":"737a488e8e160adde93527e24056c0dd23f1fc81","user":{"login":"mcntsh","id":1314484,"node_id":"MDQ6VXNlcjEzMTQ0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1314484?v=4","gravatar_id":"","url":"https://api.github.com/users/mcntsh","html_url":"https://github.com/mcntsh","followers_url":"https://api.github.com/users/mcntsh/followers","following_url":"https://api.github.com/users/mcntsh/following{/other_user}","gists_url":"https://api.github.com/users/mcntsh/gists{/gist_id}","starred_url":"https://api.github.com/users/mcntsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcntsh/subscriptions","organizations_url":"https://api.github.com/users/mcntsh/orgs","repos_url":"https://api.github.com/users/mcntsh/repos","events_url":"https://api.github.com/users/mcntsh/events{/privacy}","received_events_url":"https://api.github.com/users/mcntsh/received_events","type":"User","site_admin":false},"repo":{"id":134297324,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQyOTczMjQ=","name":"paypal-checkout","full_name":"mcntsh/paypal-checkout","owner":{"login":"mcntsh","id":1314484,"node_id":"MDQ6VXNlcjEzMTQ0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1314484?v=4","gravatar_id":"","url":"https://api.github.com/users/mcntsh","html_url":"https://github.com/mcntsh","followers_url":"https://api.github.com/users/mcntsh/followers","following_url":"https://api.github.com/users/mcntsh/following{/other_user}","gists_url":"https://api.github.com/users/mcntsh/gists{/gist_id}","starred_url":"https://api.github.com/users/mcntsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcntsh/subscriptions","organizations_url":"https://api.github.com/users/mcntsh/orgs","repos_url":"https://api.github.com/users/mcntsh/repos","events_url":"https://api.github.com/users/mcntsh/events{/privacy}","received_events_url":"https://api.github.com/users/mcntsh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcntsh/paypal-checkout","description":"Javascript Integration for PayPal Button and PayPal Checkout","fork":true,"url":"https://api.github.com/repos/mcntsh/paypal-checkout","forks_url":"https://api.github.com/repos/mcntsh/paypal-checkout/forks","keys_url":"https://api.github.com/repos/mcntsh/paypal-checkout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcntsh/paypal-checkout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcntsh/paypal-checkout/teams","hooks_url":"https://api.github.com/repos/mcntsh/paypal-checkout/hooks","issue_events_url":"https://api.github.com/repos/mcntsh/paypal-checkout/issues/events{/number}","events_url":"https://api.github.com/repos/mcntsh/paypal-checkout/events","assignees_url":"https://api.github.com/repos/mcntsh/paypal-checkout/assignees{/user}","branches_url":"https://api.github.com/repos/mcntsh/paypal-checkout/branches{/branch}","tags_url":"https://api.github.com/repos/mcntsh/paypal-checkout/tags","blobs_url":"https://api.github.com/repos/mcntsh/paypal-checkout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcntsh/paypal-checkout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcntsh/paypal-checkout/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcntsh/paypal-checkout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcntsh/paypal-checkout/statuses/{sha}","languages_url":"https://api.github.com/repos/mcntsh/paypal-checkout/languages","stargazers_url":"https://api.github.com/repos/mcntsh/paypal-checkout/stargazers","contributors_url":"https://api.github.com/repos/mcntsh/paypal-checkout/contributors","subscribers_url":"https://api.github.com/repos/mcntsh/paypal-checkout/subscribers","subscription_url":"https://api.github.com/repos/mcntsh/paypal-checkout/subscription","commits_url":"https://api.github.com/repos/mcntsh/paypal-checkout/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcntsh/paypal-checkout/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcntsh/paypal-checkout/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcntsh/paypal-checkout/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcntsh/paypal-checkout/contents/{+path}","compare_url":"https://api.github.com/repos/mcntsh/paypal-checkout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcntsh/paypal-checkout/merges","archive_url":"https://api.github.com/repos/mcntsh/paypal-checkout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcntsh/paypal-checkout/downloads","issues_url":"https://api.github.com/repos/mcntsh/paypal-checkout/issues{/number}","pulls_url":"https://api.github.com/repos/mcntsh/paypal-checkout/pulls{/number}","milestones_url":"https://api.github.com/repos/mcntsh/paypal-checkout/milestones{/number}","notifications_url":"https://api.github.com/repos/mcntsh/paypal-checkout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcntsh/paypal-checkout/labels{/name}","releases_url":"https://api.github.com/repos/mcntsh/paypal-checkout/releases{/id}","deployments_url":"https://api.github.com/repos/mcntsh/paypal-checkout/deployments","created_at":"2018-05-21T16:44:13Z","updated_at":"2018-05-21T16:44:16Z","pushed_at":"2018-07-13T18:23:43Z","git_url":"git://github.com/mcntsh/paypal-checkout.git","ssh_url":"git@github.com:mcntsh/paypal-checkout.git","clone_url":"https://github.com/mcntsh/paypal-checkout.git","svn_url":"https://github.com/mcntsh/paypal-checkout","homepage":"","size":79209,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"7d0cef7a8b2de2d3c93cde191df7b9f9f780a5fa","user":{"login":"paypal","id":476675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjY3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":64877453,"node_id":"MDEwOlJlcG9zaXRvcnk2NDg3NzQ1Mw==","name":"paypal-checkout","full_name":"paypal/paypal-checkout","owner":{"login":"paypal","id":476675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3NjY3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/paypal-checkout","description":"Javascript Integration for PayPal Button and PayPal Checkout","fork":false,"url":"https://api.github.com/repos/paypal/paypal-checkout","forks_url":"https://api.github.com/repos/paypal/paypal-checkout/forks","keys_url":"https://api.github.com/repos/paypal/paypal-checkout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/paypal-checkout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/paypal-checkout/teams","hooks_url":"https://api.github.com/repos/paypal/paypal-checkout/hooks","issue_events_url":"https://api.github.com/repos/paypal/paypal-checkout/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/paypal-checkout/events","assignees_url":"https://api.github.com/repos/paypal/paypal-checkout/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/paypal-checkout/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/paypal-checkout/tags","blobs_url":"https://api.github.com/repos/paypal/paypal-checkout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/paypal-checkout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/paypal-checkout/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/paypal-checkout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/paypal-checkout/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/paypal-checkout/languages","stargazers_url":"https://api.github.com/repos/paypal/paypal-checkout/stargazers","contributors_url":"https://api.github.com/repos/paypal/paypal-checkout/contributors","subscribers_url":"https://api.github.com/repos/paypal/paypal-checkout/subscribers","subscription_url":"https://api.github.com/repos/paypal/paypal-checkout/subscription","commits_url":"https://api.github.com/repos/paypal/paypal-checkout/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/paypal-checkout/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/paypal-checkout/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/paypal-checkout/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/paypal-checkout/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/paypal-checkout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/paypal-checkout/merges","archive_url":"https://api.github.com/repos/paypal/paypal-checkout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/paypal-checkout/downloads","issues_url":"https://api.github.com/repos/paypal/paypal-checkout/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/paypal-checkout/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/paypal-checkout/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/paypal-checkout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/paypal-checkout/labels{/name}","releases_url":"https://api.github.com/repos/paypal/paypal-checkout/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/paypal-checkout/deployments","created_at":"2016-08-03T20:34:03Z","updated_at":"2018-07-16T16:14:11Z","pushed_at":"2018-07-16T17:02:49Z","git_url":"git://github.com/paypal/paypal-checkout.git","ssh_url":"git@github.com:paypal/paypal-checkout.git","clone_url":"https://github.com/paypal/paypal-checkout.git","svn_url":"https://github.com/paypal/paypal-checkout","homepage":"","size":80106,"stargazers_count":402,"watchers_count":402,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":81,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":137,"open_issues":81,"watchers":402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/paypal-checkout/pulls/747"},"html":{"href":"https://github.com/paypal/paypal-checkout/pull/747"},"issue":{"href":"https://api.github.com/repos/paypal/paypal-checkout/issues/747"},"comments":{"href":"https://api.github.com/repos/paypal/paypal-checkout/issues/747/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/paypal-checkout/pulls/747/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/paypal-checkout/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/paypal-checkout/pulls/747/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/paypal-checkout/statuses/737a488e8e160adde93527e24056c0dd23f1fc81"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mcntsh","id":1314484,"node_id":"MDQ6VXNlcjEzMTQ0ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1314484?v=4","gravatar_id":"","url":"https://api.github.com/users/mcntsh","html_url":"https://github.com/mcntsh","followers_url":"https://api.github.com/users/mcntsh/followers","following_url":"https://api.github.com/users/mcntsh/following{/other_user}","gists_url":"https://api.github.com/users/mcntsh/gists{/gist_id}","starred_url":"https://api.github.com/users/mcntsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcntsh/subscriptions","organizations_url":"https://api.github.com/users/mcntsh/orgs","repos_url":"https://api.github.com/users/mcntsh/repos","events_url":"https://api.github.com/users/mcntsh/events{/privacy}","received_events_url":"https://api.github.com/users/mcntsh/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":5,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"mcntsh"}}