{"action":"created","comment":{"url":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/comments/173643327","pull_request_review_id":102870900,"id":173643327,"diff_hunk":"@@ -90,6 +90,50 @@ def load_trips\n       trips\n     end\n \n+    def available_driver\n+      @drivers.each do |driver|\n+        if driver.status == :AVAILABLE\n+          driver.driver_status_change(driver.status)\n+          return driver\n+        # else\n+        #   raise ArgumentError(\"No Driver is available!\")\n+        end\n+      end\n+    end\n+\n+    def request_trip(passenger_id)\n+      passenger = find_passenger(passenger_id)\n+      trip = {}\n+\n+      trip[:driver] = available_driver\n+      trip[:id] = @trips.length + 2\n+      trip[:passenger] = passenger\n+      trip[:start_time] = Time.now\n+      trip[:end_time]= nil\n+      trip[:cost] = nil\n+      trip[:rating] = nil\n+\n+      # pass = :passenger\n+      new_trip = Trip.new(trip)\n+\n+      available_driver.add_trip(new_trip)\n+\n+      passenger.add_trip(new_trip)\n+\n+\n+      return new_trip\n+\n+    end\n+\n+    def add_requested_trip\n+      trips << request_trip\n+      return trips","path":"lib/trip_dispatcher.rb","position":52,"original_position":52,"commit_id":"7030e19313ea2852ab1840cf261bf382a3ab6a89","original_commit_id":"7030e19313ea2852ab1840cf261bf382a3ab6a89","user":{"login":"droberts-ada","id":21064499,"avatar_url":"https://avatars1.githubusercontent.com/u/21064499?v=4","gravatar_id":"","url":"https://api.github.com/users/droberts-ada","html_url":"https://github.com/droberts-ada","followers_url":"https://api.github.com/users/droberts-ada/followers","following_url":"https://api.github.com/users/droberts-ada/following{/other_user}","gists_url":"https://api.github.com/users/droberts-ada/gists{/gist_id}","starred_url":"https://api.github.com/users/droberts-ada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/droberts-ada/subscriptions","organizations_url":"https://api.github.com/users/droberts-ada/orgs","repos_url":"https://api.github.com/users/droberts-ada/repos","events_url":"https://api.github.com/users/droberts-ada/events{/privacy}","received_events_url":"https://api.github.com/users/droberts-ada/received_events","type":"User","site_admin":false},"body":"You define this method here, but it's never called by `request_trip`. That means the new trip doesn't get recorded!","created_at":"2018-03-11T05:00:04Z","updated_at":"2018-03-11T05:17:40Z","html_url":"https://github.com/Ada-C9/oo-ride-share/pull/44#discussion_r173643327","pull_request_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/44","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/comments/173643327"},"html":{"href":"https://github.com/Ada-C9/oo-ride-share/pull/44#discussion_r173643327"},"pull_request":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/44","id":172928060,"html_url":"https://github.com/Ada-C9/oo-ride-share/pull/44","diff_url":"https://github.com/Ada-C9/oo-ride-share/pull/44.diff","patch_url":"https://github.com/Ada-C9/oo-ride-share/pull/44.patch","issue_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/issues/44","number":44,"state":"open","locked":false,"title":"Jamila Cornick/ C9/ Octos","user":{"login":"Jcornick21","id":25395718,"avatar_url":"https://avatars3.githubusercontent.com/u/25395718?v=4","gravatar_id":"","url":"https://api.github.com/users/Jcornick21","html_url":"https://github.com/Jcornick21","followers_url":"https://api.github.com/users/Jcornick21/followers","following_url":"https://api.github.com/users/Jcornick21/following{/other_user}","gists_url":"https://api.github.com/users/Jcornick21/gists{/gist_id}","starred_url":"https://api.github.com/users/Jcornick21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jcornick21/subscriptions","organizations_url":"https://api.github.com/users/Jcornick21/orgs","repos_url":"https://api.github.com/users/Jcornick21/repos","events_url":"https://api.github.com/users/Jcornick21/events{/privacy}","received_events_url":"https://api.github.com/users/Jcornick21/received_events","type":"User","site_admin":false},"body":"# Ride Share\r\nCongratulations! You're submitting your assignment!\r\n\r\n## Comprehension Questions\r\nQuestion | Answer\r\n:------------- | :-------------\r\nDescribe a design decision you had to make when working on this project. What options were you considering? What helped you make your final decision? | A design decision I made was when I had to  decide where to put methods to call behavior for adding trips to the passenger and driver\r\nDescribe any examples of composition that you encountered in this project, if any | I am not sure what the difference between composition and design is...\r\nDescribe a _nominal test_ that you wrote for this assignment. | testing if my status change method actually changed the drivers status\r\nDescribe an _edge case test_ that you wrote for this assignment. | did not do edge cases\r\nDescribe a concept that you gained more clarity on as you worked on this assignment. |gained more clarity on how different classes communicate and how dependencies impact code\r\n","created_at":"2018-03-05T17:04:33Z","updated_at":"2018-03-11T05:17:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"094cb8d2ce222a39d75f2bb48a690f661a583a21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/44/commits","review_comments_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/44/comments","review_comment_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/issues/44/comments","statuses_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/statuses/7030e19313ea2852ab1840cf261bf382a3ab6a89","head":{"label":"Jcornick21:master","ref":"master","sha":"7030e19313ea2852ab1840cf261bf382a3ab6a89","user":{"login":"Jcornick21","id":25395718,"avatar_url":"https://avatars3.githubusercontent.com/u/25395718?v=4","gravatar_id":"","url":"https://api.github.com/users/Jcornick21","html_url":"https://github.com/Jcornick21","followers_url":"https://api.github.com/users/Jcornick21/followers","following_url":"https://api.github.com/users/Jcornick21/following{/other_user}","gists_url":"https://api.github.com/users/Jcornick21/gists{/gist_id}","starred_url":"https://api.github.com/users/Jcornick21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jcornick21/subscriptions","organizations_url":"https://api.github.com/users/Jcornick21/orgs","repos_url":"https://api.github.com/users/Jcornick21/repos","events_url":"https://api.github.com/users/Jcornick21/events{/privacy}","received_events_url":"https://api.github.com/users/Jcornick21/received_events","type":"User","site_admin":false},"repo":{"id":123195403,"name":"oo-ride-share","full_name":"Jcornick21/oo-ride-share","owner":{"login":"Jcornick21","id":25395718,"avatar_url":"https://avatars3.githubusercontent.com/u/25395718?v=4","gravatar_id":"","url":"https://api.github.com/users/Jcornick21","html_url":"https://github.com/Jcornick21","followers_url":"https://api.github.com/users/Jcornick21/followers","following_url":"https://api.github.com/users/Jcornick21/following{/other_user}","gists_url":"https://api.github.com/users/Jcornick21/gists{/gist_id}","starred_url":"https://api.github.com/users/Jcornick21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jcornick21/subscriptions","organizations_url":"https://api.github.com/users/Jcornick21/orgs","repos_url":"https://api.github.com/users/Jcornick21/repos","events_url":"https://api.github.com/users/Jcornick21/events{/privacy}","received_events_url":"https://api.github.com/users/Jcornick21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Jcornick21/oo-ride-share","description":null,"fork":true,"url":"https://api.github.com/repos/Jcornick21/oo-ride-share","forks_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/forks","keys_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/teams","hooks_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/hooks","issue_events_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/issues/events{/number}","events_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/events","assignees_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/assignees{/user}","branches_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/branches{/branch}","tags_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/tags","blobs_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/git/refs{/sha}","trees_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/statuses/{sha}","languages_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/languages","stargazers_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/stargazers","contributors_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/contributors","subscribers_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/subscribers","subscription_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/subscription","commits_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/commits{/sha}","git_commits_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/git/commits{/sha}","comments_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/comments{/number}","issue_comment_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/issues/comments{/number}","contents_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/contents/{+path}","compare_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/merges","archive_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/downloads","issues_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/issues{/number}","pulls_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/pulls{/number}","milestones_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/milestones{/number}","notifications_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/labels{/name}","releases_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/releases{/id}","deployments_url":"https://api.github.com/repos/Jcornick21/oo-ride-share/deployments","created_at":"2018-02-27T22:15:27Z","updated_at":"2018-02-27T22:15:29Z","pushed_at":"2018-03-02T23:39:44Z","git_url":"git://github.com/Jcornick21/oo-ride-share.git","ssh_url":"git@github.com:Jcornick21/oo-ride-share.git","clone_url":"https://github.com/Jcornick21/oo-ride-share.git","svn_url":"https://github.com/Jcornick21/oo-ride-share","homepage":null,"size":116,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C9:master","ref":"master","sha":"60170b0d9b811eee3901b66f03dbf70fc1795e22","user":{"login":"Ada-C9","id":35278806,"avatar_url":"https://avatars0.githubusercontent.com/u/35278806?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C9","html_url":"https://github.com/Ada-C9","followers_url":"https://api.github.com/users/Ada-C9/followers","following_url":"https://api.github.com/users/Ada-C9/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C9/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C9/subscriptions","organizations_url":"https://api.github.com/users/Ada-C9/orgs","repos_url":"https://api.github.com/users/Ada-C9/repos","events_url":"https://api.github.com/users/Ada-C9/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C9/received_events","type":"Organization","site_admin":false},"repo":{"id":122921722,"name":"oo-ride-share","full_name":"Ada-C9/oo-ride-share","owner":{"login":"Ada-C9","id":35278806,"avatar_url":"https://avatars0.githubusercontent.com/u/35278806?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C9","html_url":"https://github.com/Ada-C9","followers_url":"https://api.github.com/users/Ada-C9/followers","following_url":"https://api.github.com/users/Ada-C9/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C9/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C9/subscriptions","organizations_url":"https://api.github.com/users/Ada-C9/orgs","repos_url":"https://api.github.com/users/Ada-C9/repos","events_url":"https://api.github.com/users/Ada-C9/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C9/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ada-C9/oo-ride-share","description":null,"fork":true,"url":"https://api.github.com/repos/Ada-C9/oo-ride-share","forks_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/forks","keys_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/teams","hooks_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/hooks","issue_events_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/events","assignees_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/tags","blobs_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/languages","stargazers_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/stargazers","contributors_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/contributors","subscribers_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/subscribers","subscription_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/subscription","commits_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/merges","archive_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/downloads","issues_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C9/oo-ride-share/deployments","created_at":"2018-02-26T06:08:58Z","updated_at":"2018-02-26T06:08:59Z","pushed_at":"2018-03-08T17:16:37Z","git_url":"git://github.com/Ada-C9/oo-ride-share.git","ssh_url":"git@github.com:Ada-C9/oo-ride-share.git","clone_url":"https://github.com/Ada-C9/oo-ride-share.git","svn_url":"https://github.com/Ada-C9/oo-ride-share","homepage":null,"size":119,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":49,"license":null,"forks":49,"open_issues":49,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/44"},"html":{"href":"https://github.com/Ada-C9/oo-ride-share/pull/44"},"issue":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/issues/44"},"comments":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C9/oo-ride-share/statuses/7030e19313ea2852ab1840cf261bf382a3ab6a89"}},"author_association":"NONE"}}
{"actor":{"display_login":"droberts-ada"}}