{"action":"created","comment":{"url":"https://api.github.com/repos/styled-components/styled-components/pulls/comments/214481925","pull_request_review_id":151556417,"id":214481925,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQ4MTkyNQ==","diff_hunk":"@@ -236,7 +238,27 @@ export default (ComponentStyle: Function) => {\n         ? `${escape(options.displayName)}-${options.componentId}`\n         : options.componentId || componentId\n \n-    const componentStyle = new ComponentStyle(rules, attrs, styledComponentId)\n+    let finalAttrs = attrs\n+\n+    // fold the underlying StyledComponent attrs up (implicit extend)\n+    // $FlowFixMe\n+    if (targetIsSC && target.attrs) finalAttrs = { ...target.attrs, ...attrs }","path":"src/models/StyledComponent.js","position":45,"original_position":45,"commit_id":"1188463ef27366af5de07197e999ea2080bbb703","original_commit_id":"1188463ef27366af5de07197e999ea2080bbb703","user":{"login":"kitten","id":2041385,"node_id":"MDQ6VXNlcjIwNDEzODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2041385?v=4","gravatar_id":"","url":"https://api.github.com/users/kitten","html_url":"https://github.com/kitten","followers_url":"https://api.github.com/users/kitten/followers","following_url":"https://api.github.com/users/kitten/following{/other_user}","gists_url":"https://api.github.com/users/kitten/gists{/gist_id}","starred_url":"https://api.github.com/users/kitten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kitten/subscriptions","organizations_url":"https://api.github.com/users/kitten/orgs","repos_url":"https://api.github.com/users/kitten/repos","events_url":"https://api.github.com/users/kitten/events{/privacy}","received_events_url":"https://api.github.com/users/kitten/received_events","type":"User","site_admin":false},"body":"I'm starting to think it'd make sense to abstract `attrs` into a shareable set of utilities or sth... Maybe a future thing.\r\n\r\nnit: Btw, I don't think having the `let`s here makes sense since a ternary would also do the trick and would imply that it won't change later in this fn","created_at":"2018-08-31T21:43:34Z","updated_at":"2018-08-31T21:47:36Z","html_url":"https://github.com/styled-components/styled-components/pull/1962#discussion_r214481925","pull_request_url":"https://api.github.com/repos/styled-components/styled-components/pulls/1962","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/styled-components/styled-components/pulls/comments/214481925"},"html":{"href":"https://github.com/styled-components/styled-components/pull/1962#discussion_r214481925"},"pull_request":{"href":"https://api.github.com/repos/styled-components/styled-components/pulls/1962"}}},"pull_request":{"url":"https://api.github.com/repos/styled-components/styled-components/pulls/1962","id":212452638,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDUyNjM4","html_url":"https://github.com/styled-components/styled-components/pull/1962","diff_url":"https://github.com/styled-components/styled-components/pull/1962.diff","patch_url":"https://github.com/styled-components/styled-components/pull/1962.patch","issue_url":"https://api.github.com/repos/styled-components/styled-components/issues/1962","number":1962,"state":"open","locked":false,"title":"implement implicit element folding, \"as\" polymorphic prop","user":{"login":"probablyup","id":570070,"node_id":"MDQ6VXNlcjU3MDA3MA==","avatar_url":"https://avatars2.githubusercontent.com/u/570070?v=4","gravatar_id":"","url":"https://api.github.com/users/probablyup","html_url":"https://github.com/probablyup","followers_url":"https://api.github.com/users/probablyup/followers","following_url":"https://api.github.com/users/probablyup/following{/other_user}","gists_url":"https://api.github.com/users/probablyup/gists{/gist_id}","starred_url":"https://api.github.com/users/probablyup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/probablyup/subscriptions","organizations_url":"https://api.github.com/users/probablyup/orgs","repos_url":"https://api.github.com/users/probablyup/repos","events_url":"https://api.github.com/users/probablyup/events{/privacy}","received_events_url":"https://api.github.com/users/probablyup/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-31T17:48:08Z","updated_at":"2018-08-31T21:47:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb16e3c5d1f4300e1cd4124221546a8f380ee7a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/styled-components/styled-components/pulls/1962/commits","review_comments_url":"https://api.github.com/repos/styled-components/styled-components/pulls/1962/comments","review_comment_url":"https://api.github.com/repos/styled-components/styled-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/styled-components/styled-components/issues/1962/comments","statuses_url":"https://api.github.com/repos/styled-components/styled-components/statuses/1188463ef27366af5de07197e999ea2080bbb703","head":{"label":"styled-components:as-prop","ref":"as-prop","sha":"1188463ef27366af5de07197e999ea2080bbb703","user":{"login":"styled-components","id":20658825,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjU4ODI1","avatar_url":"https://avatars2.githubusercontent.com/u/20658825?v=4","gravatar_id":"","url":"https://api.github.com/users/styled-components","html_url":"https://github.com/styled-components","followers_url":"https://api.github.com/users/styled-components/followers","following_url":"https://api.github.com/users/styled-components/following{/other_user}","gists_url":"https://api.github.com/users/styled-components/gists{/gist_id}","starred_url":"https://api.github.com/users/styled-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styled-components/subscriptions","organizations_url":"https://api.github.com/users/styled-components/orgs","repos_url":"https://api.github.com/users/styled-components/repos","events_url":"https://api.github.com/users/styled-components/events{/privacy}","received_events_url":"https://api.github.com/users/styled-components/received_events","type":"Organization","site_admin":false},"repo":{"id":65794292,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc5NDI5Mg==","name":"styled-components","full_name":"styled-components/styled-components","owner":{"login":"styled-components","id":20658825,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjU4ODI1","avatar_url":"https://avatars2.githubusercontent.com/u/20658825?v=4","gravatar_id":"","url":"https://api.github.com/users/styled-components","html_url":"https://github.com/styled-components","followers_url":"https://api.github.com/users/styled-components/followers","following_url":"https://api.github.com/users/styled-components/following{/other_user}","gists_url":"https://api.github.com/users/styled-components/gists{/gist_id}","starred_url":"https://api.github.com/users/styled-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styled-components/subscriptions","organizations_url":"https://api.github.com/users/styled-components/orgs","repos_url":"https://api.github.com/users/styled-components/repos","events_url":"https://api.github.com/users/styled-components/events{/privacy}","received_events_url":"https://api.github.com/users/styled-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/styled-components/styled-components","description":"Visual primitives for the component age. Use the best bits of ES6 and CSS to style your apps without stress 💅","fork":false,"url":"https://api.github.com/repos/styled-components/styled-components","forks_url":"https://api.github.com/repos/styled-components/styled-components/forks","keys_url":"https://api.github.com/repos/styled-components/styled-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/styled-components/styled-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/styled-components/styled-components/teams","hooks_url":"https://api.github.com/repos/styled-components/styled-components/hooks","issue_events_url":"https://api.github.com/repos/styled-components/styled-components/issues/events{/number}","events_url":"https://api.github.com/repos/styled-components/styled-components/events","assignees_url":"https://api.github.com/repos/styled-components/styled-components/assignees{/user}","branches_url":"https://api.github.com/repos/styled-components/styled-components/branches{/branch}","tags_url":"https://api.github.com/repos/styled-components/styled-components/tags","blobs_url":"https://api.github.com/repos/styled-components/styled-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/styled-components/styled-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/styled-components/styled-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/styled-components/styled-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/styled-components/styled-components/statuses/{sha}","languages_url":"https://api.github.com/repos/styled-components/styled-components/languages","stargazers_url":"https://api.github.com/repos/styled-components/styled-components/stargazers","contributors_url":"https://api.github.com/repos/styled-components/styled-components/contributors","subscribers_url":"https://api.github.com/repos/styled-components/styled-components/subscribers","subscription_url":"https://api.github.com/repos/styled-components/styled-components/subscription","commits_url":"https://api.github.com/repos/styled-components/styled-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/styled-components/styled-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/styled-components/styled-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/styled-components/styled-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/styled-components/styled-components/contents/{+path}","compare_url":"https://api.github.com/repos/styled-components/styled-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/styled-components/styled-components/merges","archive_url":"https://api.github.com/repos/styled-components/styled-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/styled-components/styled-components/downloads","issues_url":"https://api.github.com/repos/styled-components/styled-components/issues{/number}","pulls_url":"https://api.github.com/repos/styled-components/styled-components/pulls{/number}","milestones_url":"https://api.github.com/repos/styled-components/styled-components/milestones{/number}","notifications_url":"https://api.github.com/repos/styled-components/styled-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/styled-components/styled-components/labels{/name}","releases_url":"https://api.github.com/repos/styled-components/styled-components/releases{/id}","deployments_url":"https://api.github.com/repos/styled-components/styled-components/deployments","created_at":"2016-08-16T06:41:32Z","updated_at":"2018-08-31T21:05:06Z","pushed_at":"2018-08-31T18:16:19Z","git_url":"git://github.com/styled-components/styled-components.git","ssh_url":"git@github.com:styled-components/styled-components.git","clone_url":"https://github.com/styled-components/styled-components.git","svn_url":"https://github.com/styled-components/styled-components","homepage":"https://styled-components.com","size":4761,"stargazers_count":18697,"watchers_count":18697,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1104,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1104,"open_issues":102,"watchers":18697,"default_branch":"master"}},"base":{"label":"styled-components:develop","ref":"develop","sha":"6aceb3ed3a0bf663ff15dfa80620da10a4e14af8","user":{"login":"styled-components","id":20658825,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjU4ODI1","avatar_url":"https://avatars2.githubusercontent.com/u/20658825?v=4","gravatar_id":"","url":"https://api.github.com/users/styled-components","html_url":"https://github.com/styled-components","followers_url":"https://api.github.com/users/styled-components/followers","following_url":"https://api.github.com/users/styled-components/following{/other_user}","gists_url":"https://api.github.com/users/styled-components/gists{/gist_id}","starred_url":"https://api.github.com/users/styled-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styled-components/subscriptions","organizations_url":"https://api.github.com/users/styled-components/orgs","repos_url":"https://api.github.com/users/styled-components/repos","events_url":"https://api.github.com/users/styled-components/events{/privacy}","received_events_url":"https://api.github.com/users/styled-components/received_events","type":"Organization","site_admin":false},"repo":{"id":65794292,"node_id":"MDEwOlJlcG9zaXRvcnk2NTc5NDI5Mg==","name":"styled-components","full_name":"styled-components/styled-components","owner":{"login":"styled-components","id":20658825,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNjU4ODI1","avatar_url":"https://avatars2.githubusercontent.com/u/20658825?v=4","gravatar_id":"","url":"https://api.github.com/users/styled-components","html_url":"https://github.com/styled-components","followers_url":"https://api.github.com/users/styled-components/followers","following_url":"https://api.github.com/users/styled-components/following{/other_user}","gists_url":"https://api.github.com/users/styled-components/gists{/gist_id}","starred_url":"https://api.github.com/users/styled-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styled-components/subscriptions","organizations_url":"https://api.github.com/users/styled-components/orgs","repos_url":"https://api.github.com/users/styled-components/repos","events_url":"https://api.github.com/users/styled-components/events{/privacy}","received_events_url":"https://api.github.com/users/styled-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/styled-components/styled-components","description":"Visual primitives for the component age. Use the best bits of ES6 and CSS to style your apps without stress 💅","fork":false,"url":"https://api.github.com/repos/styled-components/styled-components","forks_url":"https://api.github.com/repos/styled-components/styled-components/forks","keys_url":"https://api.github.com/repos/styled-components/styled-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/styled-components/styled-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/styled-components/styled-components/teams","hooks_url":"https://api.github.com/repos/styled-components/styled-components/hooks","issue_events_url":"https://api.github.com/repos/styled-components/styled-components/issues/events{/number}","events_url":"https://api.github.com/repos/styled-components/styled-components/events","assignees_url":"https://api.github.com/repos/styled-components/styled-components/assignees{/user}","branches_url":"https://api.github.com/repos/styled-components/styled-components/branches{/branch}","tags_url":"https://api.github.com/repos/styled-components/styled-components/tags","blobs_url":"https://api.github.com/repos/styled-components/styled-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/styled-components/styled-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/styled-components/styled-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/styled-components/styled-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/styled-components/styled-components/statuses/{sha}","languages_url":"https://api.github.com/repos/styled-components/styled-components/languages","stargazers_url":"https://api.github.com/repos/styled-components/styled-components/stargazers","contributors_url":"https://api.github.com/repos/styled-components/styled-components/contributors","subscribers_url":"https://api.github.com/repos/styled-components/styled-components/subscribers","subscription_url":"https://api.github.com/repos/styled-components/styled-components/subscription","commits_url":"https://api.github.com/repos/styled-components/styled-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/styled-components/styled-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/styled-components/styled-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/styled-components/styled-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/styled-components/styled-components/contents/{+path}","compare_url":"https://api.github.com/repos/styled-components/styled-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/styled-components/styled-components/merges","archive_url":"https://api.github.com/repos/styled-components/styled-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/styled-components/styled-components/downloads","issues_url":"https://api.github.com/repos/styled-components/styled-components/issues{/number}","pulls_url":"https://api.github.com/repos/styled-components/styled-components/pulls{/number}","milestones_url":"https://api.github.com/repos/styled-components/styled-components/milestones{/number}","notifications_url":"https://api.github.com/repos/styled-components/styled-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/styled-components/styled-components/labels{/name}","releases_url":"https://api.github.com/repos/styled-components/styled-components/releases{/id}","deployments_url":"https://api.github.com/repos/styled-components/styled-components/deployments","created_at":"2016-08-16T06:41:32Z","updated_at":"2018-08-31T21:05:06Z","pushed_at":"2018-08-31T18:16:19Z","git_url":"git://github.com/styled-components/styled-components.git","ssh_url":"git@github.com:styled-components/styled-components.git","clone_url":"https://github.com/styled-components/styled-components.git","svn_url":"https://github.com/styled-components/styled-components","homepage":"https://styled-components.com","size":4761,"stargazers_count":18697,"watchers_count":18697,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1104,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1104,"open_issues":102,"watchers":18697,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/styled-components/styled-components/pulls/1962"},"html":{"href":"https://github.com/styled-components/styled-components/pull/1962"},"issue":{"href":"https://api.github.com/repos/styled-components/styled-components/issues/1962"},"comments":{"href":"https://api.github.com/repos/styled-components/styled-components/issues/1962/comments"},"review_comments":{"href":"https://api.github.com/repos/styled-components/styled-components/pulls/1962/comments"},"review_comment":{"href":"https://api.github.com/repos/styled-components/styled-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/styled-components/styled-components/pulls/1962/commits"},"statuses":{"href":"https://api.github.com/repos/styled-components/styled-components/statuses/1188463ef27366af5de07197e999ea2080bbb703"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kitten"}}