{"action":"created","comment":{"url":"https://api.github.com/repos/nens/gwswlib/pulls/comments/244699407","pull_request_review_id":188631659,"id":244699407,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDY5OTQwNw==","diff_hunk":"@@ -8,6 +8,39 @@\n class Hydx:\n     def __init__(self):\n         self.connection_nodes = []\n+        self.connections = []\n+        self.structures = []\n+\n+    def import_csvline(self, line, csvfilename):","path":"gwswlib/hydx.py","position":7,"original_position":7,"commit_id":"20a04be97dd596b04f244375ea2be92077108f83","original_commit_id":"20a04be97dd596b04f244375ea2be92077108f83","user":{"login":"reinout","id":121433,"node_id":"MDQ6VXNlcjEyMTQzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/121433?v=4","gravatar_id":"","url":"https://api.github.com/users/reinout","html_url":"https://github.com/reinout","followers_url":"https://api.github.com/users/reinout/followers","following_url":"https://api.github.com/users/reinout/following{/other_user}","gists_url":"https://api.github.com/users/reinout/gists{/gist_id}","starred_url":"https://api.github.com/users/reinout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reinout/subscriptions","organizations_url":"https://api.github.com/users/reinout/orgs","repos_url":"https://api.github.com/users/reinout/repos","events_url":"https://api.github.com/users/reinout/events{/privacy}","received_events_url":"https://api.github.com/users/reinout/received_events","type":"User","site_admin":false},"body":"Dit lijkt me op een verkeerde plek te zitten?\r\nDe keus wat je met een csv file moet doen hoef je maar één keer te maken: aan het begin v/h inlezen. Niet bij elke losse regel opnieuw.\r\n\r\nWat je zou kunnen doen is een `import_csvfile()` maken. Die kijkt wat het `hydxelement` moet zijn, importeert de regels en voegt ze toe aan connection_nodes/connections/structures/etc.","created_at":"2019-01-02T10:17:35Z","updated_at":"2019-01-02T10:17:35Z","html_url":"https://github.com/nens/gwswlib/pull/8#discussion_r244699407","pull_request_url":"https://api.github.com/repos/nens/gwswlib/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nens/gwswlib/pulls/comments/244699407"},"html":{"href":"https://github.com/nens/gwswlib/pull/8#discussion_r244699407"},"pull_request":{"href":"https://api.github.com/repos/nens/gwswlib/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/nens/gwswlib/pulls/8","id":240504879,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTA0ODc5","html_url":"https://github.com/nens/gwswlib/pull/8","diff_url":"https://github.com/nens/gwswlib/pull/8.diff","patch_url":"https://github.com/nens/gwswlib/pull/8.patch","issue_url":"https://api.github.com/repos/nens/gwswlib/issues/8","number":8,"state":"open","locked":false,"title":"[WIP] add connection and get structures in db","user":{"login":"arnoldvantveld","id":11178198,"node_id":"MDQ6VXNlcjExMTc4MTk4","avatar_url":"https://avatars0.githubusercontent.com/u/11178198?v=4","gravatar_id":"","url":"https://api.github.com/users/arnoldvantveld","html_url":"https://github.com/arnoldvantveld","followers_url":"https://api.github.com/users/arnoldvantveld/followers","following_url":"https://api.github.com/users/arnoldvantveld/following{/other_user}","gists_url":"https://api.github.com/users/arnoldvantveld/gists{/gist_id}","starred_url":"https://api.github.com/users/arnoldvantveld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arnoldvantveld/subscriptions","organizations_url":"https://api.github.com/users/arnoldvantveld/orgs","repos_url":"https://api.github.com/users/arnoldvantveld/repos","events_url":"https://api.github.com/users/arnoldvantveld/events{/privacy}","received_events_url":"https://api.github.com/users/arnoldvantveld/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-21T15:31:22Z","updated_at":"2019-01-02T10:17:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f69e906c156190c06cd95c95e0414afe98cdf94","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nens/gwswlib/pulls/8/commits","review_comments_url":"https://api.github.com/repos/nens/gwswlib/pulls/8/comments","review_comment_url":"https://api.github.com/repos/nens/gwswlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nens/gwswlib/issues/8/comments","statuses_url":"https://api.github.com/repos/nens/gwswlib/statuses/20a04be97dd596b04f244375ea2be92077108f83","head":{"label":"nens:arnold-add-connection-and-structure-to-db","ref":"arnold-add-connection-and-structure-to-db","sha":"20a04be97dd596b04f244375ea2be92077108f83","user":{"login":"nens","id":826981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNjk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/826981?v=4","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"repo":{"id":160505120,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1MDUxMjA=","name":"gwswlib","full_name":"nens/gwswlib","private":false,"owner":{"login":"nens","id":826981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNjk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/826981?v=4","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nens/gwswlib","description":"An importer/exporter for GWSW","fork":false,"url":"https://api.github.com/repos/nens/gwswlib","forks_url":"https://api.github.com/repos/nens/gwswlib/forks","keys_url":"https://api.github.com/repos/nens/gwswlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nens/gwswlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nens/gwswlib/teams","hooks_url":"https://api.github.com/repos/nens/gwswlib/hooks","issue_events_url":"https://api.github.com/repos/nens/gwswlib/issues/events{/number}","events_url":"https://api.github.com/repos/nens/gwswlib/events","assignees_url":"https://api.github.com/repos/nens/gwswlib/assignees{/user}","branches_url":"https://api.github.com/repos/nens/gwswlib/branches{/branch}","tags_url":"https://api.github.com/repos/nens/gwswlib/tags","blobs_url":"https://api.github.com/repos/nens/gwswlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nens/gwswlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nens/gwswlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/nens/gwswlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nens/gwswlib/statuses/{sha}","languages_url":"https://api.github.com/repos/nens/gwswlib/languages","stargazers_url":"https://api.github.com/repos/nens/gwswlib/stargazers","contributors_url":"https://api.github.com/repos/nens/gwswlib/contributors","subscribers_url":"https://api.github.com/repos/nens/gwswlib/subscribers","subscription_url":"https://api.github.com/repos/nens/gwswlib/subscription","commits_url":"https://api.github.com/repos/nens/gwswlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/nens/gwswlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/nens/gwswlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/nens/gwswlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/nens/gwswlib/contents/{+path}","compare_url":"https://api.github.com/repos/nens/gwswlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nens/gwswlib/merges","archive_url":"https://api.github.com/repos/nens/gwswlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nens/gwswlib/downloads","issues_url":"https://api.github.com/repos/nens/gwswlib/issues{/number}","pulls_url":"https://api.github.com/repos/nens/gwswlib/pulls{/number}","milestones_url":"https://api.github.com/repos/nens/gwswlib/milestones{/number}","notifications_url":"https://api.github.com/repos/nens/gwswlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nens/gwswlib/labels{/name}","releases_url":"https://api.github.com/repos/nens/gwswlib/releases{/id}","deployments_url":"https://api.github.com/repos/nens/gwswlib/deployments","created_at":"2018-12-05T11:00:55Z","updated_at":"2018-12-21T15:04:30Z","pushed_at":"2019-01-02T09:45:15Z","git_url":"git://github.com/nens/gwswlib.git","ssh_url":"git@github.com:nens/gwswlib.git","clone_url":"https://github.com/nens/gwswlib.git","svn_url":"https://github.com/nens/gwswlib","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nens:master","ref":"master","sha":"1c3e384cb364693a09f72a41acbdd1ba9f62cf32","user":{"login":"nens","id":826981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNjk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/826981?v=4","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"repo":{"id":160505120,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA1MDUxMjA=","name":"gwswlib","full_name":"nens/gwswlib","private":false,"owner":{"login":"nens","id":826981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNjk4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/826981?v=4","gravatar_id":"","url":"https://api.github.com/users/nens","html_url":"https://github.com/nens","followers_url":"https://api.github.com/users/nens/followers","following_url":"https://api.github.com/users/nens/following{/other_user}","gists_url":"https://api.github.com/users/nens/gists{/gist_id}","starred_url":"https://api.github.com/users/nens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nens/subscriptions","organizations_url":"https://api.github.com/users/nens/orgs","repos_url":"https://api.github.com/users/nens/repos","events_url":"https://api.github.com/users/nens/events{/privacy}","received_events_url":"https://api.github.com/users/nens/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nens/gwswlib","description":"An importer/exporter for GWSW","fork":false,"url":"https://api.github.com/repos/nens/gwswlib","forks_url":"https://api.github.com/repos/nens/gwswlib/forks","keys_url":"https://api.github.com/repos/nens/gwswlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nens/gwswlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nens/gwswlib/teams","hooks_url":"https://api.github.com/repos/nens/gwswlib/hooks","issue_events_url":"https://api.github.com/repos/nens/gwswlib/issues/events{/number}","events_url":"https://api.github.com/repos/nens/gwswlib/events","assignees_url":"https://api.github.com/repos/nens/gwswlib/assignees{/user}","branches_url":"https://api.github.com/repos/nens/gwswlib/branches{/branch}","tags_url":"https://api.github.com/repos/nens/gwswlib/tags","blobs_url":"https://api.github.com/repos/nens/gwswlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nens/gwswlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nens/gwswlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/nens/gwswlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nens/gwswlib/statuses/{sha}","languages_url":"https://api.github.com/repos/nens/gwswlib/languages","stargazers_url":"https://api.github.com/repos/nens/gwswlib/stargazers","contributors_url":"https://api.github.com/repos/nens/gwswlib/contributors","subscribers_url":"https://api.github.com/repos/nens/gwswlib/subscribers","subscription_url":"https://api.github.com/repos/nens/gwswlib/subscription","commits_url":"https://api.github.com/repos/nens/gwswlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/nens/gwswlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/nens/gwswlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/nens/gwswlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/nens/gwswlib/contents/{+path}","compare_url":"https://api.github.com/repos/nens/gwswlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nens/gwswlib/merges","archive_url":"https://api.github.com/repos/nens/gwswlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nens/gwswlib/downloads","issues_url":"https://api.github.com/repos/nens/gwswlib/issues{/number}","pulls_url":"https://api.github.com/repos/nens/gwswlib/pulls{/number}","milestones_url":"https://api.github.com/repos/nens/gwswlib/milestones{/number}","notifications_url":"https://api.github.com/repos/nens/gwswlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nens/gwswlib/labels{/name}","releases_url":"https://api.github.com/repos/nens/gwswlib/releases{/id}","deployments_url":"https://api.github.com/repos/nens/gwswlib/deployments","created_at":"2018-12-05T11:00:55Z","updated_at":"2018-12-21T15:04:30Z","pushed_at":"2019-01-02T09:45:15Z","git_url":"git://github.com/nens/gwswlib.git","ssh_url":"git@github.com:nens/gwswlib.git","clone_url":"https://github.com/nens/gwswlib.git","svn_url":"https://github.com/nens/gwswlib","homepage":null,"size":98,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nens/gwswlib/pulls/8"},"html":{"href":"https://github.com/nens/gwswlib/pull/8"},"issue":{"href":"https://api.github.com/repos/nens/gwswlib/issues/8"},"comments":{"href":"https://api.github.com/repos/nens/gwswlib/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/nens/gwswlib/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/nens/gwswlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nens/gwswlib/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/nens/gwswlib/statuses/20a04be97dd596b04f244375ea2be92077108f83"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"reinout"}}