{"action":"created","issue":{"url":"https://api.github.com/repos/fission/fission/issues/655","repository_url":"https://api.github.com/repos/fission/fission","labels_url":"https://api.github.com/repos/fission/fission/issues/655/labels{/name}","comments_url":"https://api.github.com/repos/fission/fission/issues/655/comments","events_url":"https://api.github.com/repos/fission/fission/issues/655/events","html_url":"https://github.com/fission/fission/pull/655","id":318819890,"number":655,"title":"Enabling multi-tenancy for fission objects.","user":{"login":"smruthi2187","id":34555664,"avatar_url":"https://avatars2.githubusercontent.com/u/34555664?v=4","gravatar_id":"","url":"https://api.github.com/users/smruthi2187","html_url":"https://github.com/smruthi2187","followers_url":"https://api.github.com/users/smruthi2187/followers","following_url":"https://api.github.com/users/smruthi2187/following{/other_user}","gists_url":"https://api.github.com/users/smruthi2187/gists{/gist_id}","starred_url":"https://api.github.com/users/smruthi2187/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smruthi2187/subscriptions","organizations_url":"https://api.github.com/users/smruthi2187/orgs","repos_url":"https://api.github.com/users/smruthi2187/repos","events_url":"https://api.github.com/users/smruthi2187/events{/privacy}","received_events_url":"https://api.github.com/users/smruthi2187/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/fission/fission/milestones/11","html_url":"https://github.com/fission/fission/milestone/11","labels_url":"https://api.github.com/repos/fission/fission/milestones/11/labels","id":3315975,"number":11,"title":"0.8.0","description":"","creator":{"login":"soamvasani","id":16418446,"avatar_url":"https://avatars1.githubusercontent.com/u/16418446?v=4","gravatar_id":"","url":"https://api.github.com/users/soamvasani","html_url":"https://github.com/soamvasani","followers_url":"https://api.github.com/users/soamvasani/followers","following_url":"https://api.github.com/users/soamvasani/following{/other_user}","gists_url":"https://api.github.com/users/soamvasani/gists{/gist_id}","starred_url":"https://api.github.com/users/soamvasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soamvasani/subscriptions","organizations_url":"https://api.github.com/users/soamvasani/orgs","repos_url":"https://api.github.com/users/soamvasani/repos","events_url":"https://api.github.com/users/soamvasani/events{/privacy}","received_events_url":"https://api.github.com/users/soamvasani/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":3,"state":"open","created_at":"2018-05-02T20:59:47Z","updated_at":"2018-05-21T20:57:19Z","due_on":"2018-05-29T07:00:00Z","closed_at":null},"comments":11,"created_at":"2018-04-30T08:40:48Z","updated_at":"2018-05-22T09:11:00Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/fission/fission/pulls/655","html_url":"https://github.com/fission/fission/pull/655","diff_url":"https://github.com/fission/fission/pull/655.diff","patch_url":"https://github.com/fission/fission/pull/655.patch"},"body":"I've added a summary of changes in Multi-tenancy.md under Documentation/wip directory. I'd recommend going through that first before reviewing the change.\r\n\r\nI have one TODO remaining - with this change, we dont permit users to reference secrets and configMaps in namespaces other than the function namespace. So, I have to write a Job that can be run during `helm install` that checks all functions' secret/configmap references and fail the installation if there are any cross references.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fission/fission/655)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/fission/fission/issues/comments/390919494","html_url":"https://github.com/fission/fission/pull/655#issuecomment-390919494","issue_url":"https://api.github.com/repos/fission/fission/issues/655","id":390919494,"user":{"login":"life1347","id":202578,"avatar_url":"https://avatars1.githubusercontent.com/u/202578?v=4","gravatar_id":"","url":"https://api.github.com/users/life1347","html_url":"https://github.com/life1347","followers_url":"https://api.github.com/users/life1347/followers","following_url":"https://api.github.com/users/life1347/following{/other_user}","gists_url":"https://api.github.com/users/life1347/gists{/gist_id}","starred_url":"https://api.github.com/users/life1347/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/life1347/subscriptions","organizations_url":"https://api.github.com/users/life1347/orgs","repos_url":"https://api.github.com/users/life1347/repos","events_url":"https://api.github.com/users/life1347/events{/privacy}","received_events_url":"https://api.github.com/users/life1347/received_events","type":"User","site_admin":false},"created_at":"2018-05-22T09:11:00Z","updated_at":"2018-05-22T09:11:00Z","author_association":"MEMBER","body":"\n\n\n\nReviewed 11 of 11 files at r7.\nReview status: all files reviewed at latest revision, all discussions resolved, some commit checks failed.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/fission/fission/655)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"life1347"}}