{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/170042408","pull_request_review_id":98667664,"id":170042408,"diff_hunk":"@@ -159,9 +195,30 @@ void THNN_(MultiMarginCriterion_updateGradInput)(\n     input_data += dim;\n     gradInput_data += dim;\n   }\n+  gradInput_data = THTensor_(data)(gradInput);\n+","path":"aten/src/THNN/generic/MultiMarginCriterion.c","position":139,"original_position":139,"commit_id":"a83021661289221b832a6e19ba377d52e8264045","original_commit_id":"a83021661289221b832a6e19ba377d52e8264045","user":{"login":"SsnL","id":5674597,"avatar_url":"https://avatars2.githubusercontent.com/u/5674597?v=4","gravatar_id":"","url":"https://api.github.com/users/SsnL","html_url":"https://github.com/SsnL","followers_url":"https://api.github.com/users/SsnL/followers","following_url":"https://api.github.com/users/SsnL/following{/other_user}","gists_url":"https://api.github.com/users/SsnL/gists{/gist_id}","starred_url":"https://api.github.com/users/SsnL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SsnL/subscriptions","organizations_url":"https://api.github.com/users/SsnL/orgs","repos_url":"https://api.github.com/users/SsnL/repos","events_url":"https://api.github.com/users/SsnL/events{/privacy}","received_events_url":"https://api.github.com/users/SsnL/received_events","type":"User","site_admin":false},"body":"Makes sense. Thanks for explanation. ","created_at":"2018-02-22T17:57:06Z","updated_at":"2018-02-22T17:57:06Z","html_url":"https://github.com/pytorch/pytorch/pull/5150#discussion_r170042408","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/5150","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/170042408"},"html":{"href":"https://github.com/pytorch/pytorch/pull/5150#discussion_r170042408"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/5150"}},"in_reply_to_id":169860719},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/5150","id":168150340,"html_url":"https://github.com/pytorch/pytorch/pull/5150","diff_url":"https://github.com/pytorch/pytorch/pull/5150.diff","patch_url":"https://github.com/pytorch/pytorch/pull/5150.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/5150","number":5150,"state":"open","locked":false,"title":"add reduce=True arg to MultiMarginLoss","user":{"login":"li-roy","id":8813817,"avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"body":"As per #264. When reduce is False, MultiMarginLoss outputs a loss per sample in minibatch. When reduce is True (default), the current behavior is kept.\r\n\r\nTest Plan\r\ntest/run_test.sh\r\nAdded unit tests for the reduce=False case as well as unit tests for optional parameters. Added a reference function.","created_at":"2018-02-09T04:18:38Z","updated_at":"2018-02-22T17:57:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"91d545a48a9aee6c25028269742d7310d8798937","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/5150/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/5150/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/5150/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/a83021661289221b832a6e19ba377d52e8264045","head":{"label":"li-roy:multimargin","ref":"multimargin","sha":"a83021661289221b832a6e19ba377d52e8264045","user":{"login":"li-roy","id":8813817,"avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"repo":{"id":119106720,"name":"pytorch","full_name":"li-roy/pytorch","owner":{"login":"li-roy","id":8813817,"avatar_url":"https://avatars0.githubusercontent.com/u/8813817?v=4","gravatar_id":"","url":"https://api.github.com/users/li-roy","html_url":"https://github.com/li-roy","followers_url":"https://api.github.com/users/li-roy/followers","following_url":"https://api.github.com/users/li-roy/following{/other_user}","gists_url":"https://api.github.com/users/li-roy/gists{/gist_id}","starred_url":"https://api.github.com/users/li-roy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/li-roy/subscriptions","organizations_url":"https://api.github.com/users/li-roy/orgs","repos_url":"https://api.github.com/users/li-roy/repos","events_url":"https://api.github.com/users/li-roy/events{/privacy}","received_events_url":"https://api.github.com/users/li-roy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/li-roy/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/li-roy/pytorch","forks_url":"https://api.github.com/repos/li-roy/pytorch/forks","keys_url":"https://api.github.com/repos/li-roy/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/li-roy/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/li-roy/pytorch/teams","hooks_url":"https://api.github.com/repos/li-roy/pytorch/hooks","issue_events_url":"https://api.github.com/repos/li-roy/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/li-roy/pytorch/events","assignees_url":"https://api.github.com/repos/li-roy/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/li-roy/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/li-roy/pytorch/tags","blobs_url":"https://api.github.com/repos/li-roy/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/li-roy/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/li-roy/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/li-roy/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/li-roy/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/li-roy/pytorch/languages","stargazers_url":"https://api.github.com/repos/li-roy/pytorch/stargazers","contributors_url":"https://api.github.com/repos/li-roy/pytorch/contributors","subscribers_url":"https://api.github.com/repos/li-roy/pytorch/subscribers","subscription_url":"https://api.github.com/repos/li-roy/pytorch/subscription","commits_url":"https://api.github.com/repos/li-roy/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/li-roy/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/li-roy/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/li-roy/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/li-roy/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/li-roy/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/li-roy/pytorch/merges","archive_url":"https://api.github.com/repos/li-roy/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/li-roy/pytorch/downloads","issues_url":"https://api.github.com/repos/li-roy/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/li-roy/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/li-roy/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/li-roy/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/li-roy/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/li-roy/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/li-roy/pytorch/deployments","created_at":"2018-01-26T21:46:02Z","updated_at":"2018-01-26T21:46:07Z","pushed_at":"2018-02-22T03:53:11Z","git_url":"git://github.com/li-roy/pytorch.git","ssh_url":"git@github.com:li-roy/pytorch.git","clone_url":"https://github.com/li-roy/pytorch.git","svn_url":"https://github.com/li-roy/pytorch","homepage":"http://pytorch.org","size":22956,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"70e71391d2c39cae115940af52530cc3fb053507","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-02-22T17:23:48Z","pushed_at":"2018-02-22T17:35:41Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":23183,"stargazers_count":12409,"watchers_count":12409,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2600,"mirror_url":null,"archived":false,"open_issues_count":723,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2600,"open_issues":723,"watchers":12409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/5150"},"html":{"href":"https://github.com/pytorch/pytorch/pull/5150"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/5150"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/5150/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/5150/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/5150/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/a83021661289221b832a6e19ba377d52e8264045"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"SsnL"}}