{"action":"created","issue":{"url":"https://api.github.com/repos/BRCAChallenge/brca-exchange/issues/894","repository_url":"https://api.github.com/repos/BRCAChallenge/brca-exchange","labels_url":"https://api.github.com/repos/BRCAChallenge/brca-exchange/issues/894/labels{/name}","comments_url":"https://api.github.com/repos/BRCAChallenge/brca-exchange/issues/894/comments","events_url":"https://api.github.com/repos/BRCAChallenge/brca-exchange/issues/894/events","html_url":"https://github.com/BRCAChallenge/brca-exchange/pull/894","id":362565009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MjQ3NzY3","number":894,"title":"Fixes empty transcript viz. legend boxes on Firefox","user":{"login":"falquaddoomi","id":312923,"node_id":"MDQ6VXNlcjMxMjkyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/312923?v=4","gravatar_id":"","url":"https://api.github.com/users/falquaddoomi","html_url":"https://github.com/falquaddoomi","followers_url":"https://api.github.com/users/falquaddoomi/followers","following_url":"https://api.github.com/users/falquaddoomi/following{/other_user}","gists_url":"https://api.github.com/users/falquaddoomi/gists{/gist_id}","starred_url":"https://api.github.com/users/falquaddoomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falquaddoomi/subscriptions","organizations_url":"https://api.github.com/users/falquaddoomi/orgs","repos_url":"https://api.github.com/users/falquaddoomi/repos","events_url":"https://api.github.com/users/falquaddoomi/events{/privacy}","received_events_url":"https://api.github.com/users/falquaddoomi/received_events","type":"User","site_admin":false},"labels":[{"id":381903814,"node_id":"MDU6TGFiZWwzODE5MDM4MTQ=","url":"https://api.github.com/repos/BRCAChallenge/brca-exchange/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-21T11:01:39Z","updated_at":"2018-09-24T11:48:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/BRCAChallenge/brca-exchange/pulls/894","html_url":"https://github.com/BRCAChallenge/brca-exchange/pull/894","diff_url":"https://github.com/BRCAChallenge/brca-exchange/pull/894.diff","patch_url":"https://github.com/BRCAChallenge/brca-exchange/pull/894.patch"},"body":"Firefox doesn't allow SVG elements' widths and heights to be specified via CSS, unlike most other browsers. This causes the legend boxes to display with width and height 0, rendering as an unfilled box.\r\n\r\nThe fix is simply to specify the width and height as properties on the `<rect>` elements."},"comment":{"url":"https://api.github.com/repos/BRCAChallenge/brca-exchange/issues/comments/423948310","html_url":"https://github.com/BRCAChallenge/brca-exchange/pull/894#issuecomment-423948310","issue_url":"https://api.github.com/repos/BRCAChallenge/brca-exchange/issues/894","id":423948310,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzk0ODMxMA==","user":{"login":"falquaddoomi","id":312923,"node_id":"MDQ6VXNlcjMxMjkyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/312923?v=4","gravatar_id":"","url":"https://api.github.com/users/falquaddoomi","html_url":"https://github.com/falquaddoomi","followers_url":"https://api.github.com/users/falquaddoomi/followers","following_url":"https://api.github.com/users/falquaddoomi/following{/other_user}","gists_url":"https://api.github.com/users/falquaddoomi/gists{/gist_id}","starred_url":"https://api.github.com/users/falquaddoomi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/falquaddoomi/subscriptions","organizations_url":"https://api.github.com/users/falquaddoomi/orgs","repos_url":"https://api.github.com/users/falquaddoomi/repos","events_url":"https://api.github.com/users/falquaddoomi/events{/privacy}","received_events_url":"https://api.github.com/users/falquaddoomi/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T11:48:17Z","updated_at":"2018-09-24T11:48:17Z","author_association":"CONTRIBUTOR","body":"That's a good idea. I don't know what our priorities are for browser support, but maybe reviewing the access logs to see what people are using would be a good start.\r\n\r\nI can also resume our conversation with BrowserStack on getting a free account for their browser-testing services. I'm thinking we can start with manually reviewing screenshots of the website in our supported browsers, then think about how to automate that process later on. On a separate note, I've been looking into automated front-end testing, but that wouldn't catch these kinds of browser inconsistencies."}}
{"actor":{"display_login":"falquaddoomi"}}