{"action":"created","comment":{"url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/comments/189262575","pull_request_review_id":121411436,"id":189262575,"diff_hunk":"@@ -6056,16 +6042,21 @@ public function setInstall()\n \r\n \tpublic function setUninstall()\r\n \t{\r\n+\t\t$db = '';\r\n \t\tif (isset($this->queryBuilder) && ComponentbuilderHelper::checkArray($this->queryBuilder))\r\n \t\t{\r\n-\t\t\t$bd = '';\r\n \t\t\tforeach ($this->uninstallBuilder as $line)\r\n \t\t\t{\r\n-\t\t\t\t$bd .= $line . PHP_EOL;\r\n+\t\t\t\t$db .= $line . PHP_EOL;\r\n \t\t\t}\r\n-\t\t\treturn $bd;\r\n \t\t}\r\n-\t\treturn '';\r\n+\t\t// add custom sql uninstall dump to the file\r\n+\t\tif (isset($this->customScriptBuilder['sql_uninstall']) && ComponentbuilderHelper::checkString($this->customScriptBuilder['sql_uninstall']))\r\n+\t\t{\r\n+\t\t\t$db .= $this->setPlaceholders($this->customScriptBuilder['sql_uninstall'], $this->placeholders) . PHP_EOL;\r","path":"admin/helpers/compiler/e_Interpretation.php","position":193,"original_position":193,"commit_id":"8488392fac20453c608a31e44c522df739381e12","original_commit_id":"8488392fac20453c608a31e44c522df739381e12","user":{"login":"ro-ot","id":2594383,"avatar_url":"https://avatars3.githubusercontent.com/u/2594383?v=4","gravatar_id":"","url":"https://api.github.com/users/ro-ot","html_url":"https://github.com/ro-ot","followers_url":"https://api.github.com/users/ro-ot/followers","following_url":"https://api.github.com/users/ro-ot/following{/other_user}","gists_url":"https://api.github.com/users/ro-ot/gists{/gist_id}","starred_url":"https://api.github.com/users/ro-ot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro-ot/subscriptions","organizations_url":"https://api.github.com/users/ro-ot/orgs","repos_url":"https://api.github.com/users/ro-ot/repos","events_url":"https://api.github.com/users/ro-ot/events{/privacy}","received_events_url":"https://api.github.com/users/ro-ot/received_events","type":"User","site_admin":false},"body":":+1: ","created_at":"2018-05-18T13:10:03Z","updated_at":"2018-05-18T13:10:04Z","html_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/286#discussion_r189262575","pull_request_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/286","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/comments/189262575"},"html":{"href":"https://github.com/vdm-io/Joomla-Component-Builder/pull/286#discussion_r189262575"},"pull_request":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/286"}}},"pull_request":{"url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/286","id":188929979,"html_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/286","diff_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/286.diff","patch_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/286.patch","issue_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/286","number":286,"state":"open","locked":false,"title":"Minor improvments and bug fixes","user":{"login":"Llewellynvdm","id":5607939,"avatar_url":"https://avatars3.githubusercontent.com/u/5607939?v=4","gravatar_id":"","url":"https://api.github.com/users/Llewellynvdm","html_url":"https://github.com/Llewellynvdm","followers_url":"https://api.github.com/users/Llewellynvdm/followers","following_url":"https://api.github.com/users/Llewellynvdm/following{/other_user}","gists_url":"https://api.github.com/users/Llewellynvdm/gists{/gist_id}","starred_url":"https://api.github.com/users/Llewellynvdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Llewellynvdm/subscriptions","organizations_url":"https://api.github.com/users/Llewellynvdm/orgs","repos_url":"https://api.github.com/users/Llewellynvdm/repos","events_url":"https://api.github.com/users/Llewellynvdm/events{/privacy}","received_events_url":"https://api.github.com/users/Llewellynvdm/received_events","type":"User","site_admin":false},"body":"Pull Request for Issue gh-285, gh-283, gh-278.\r\n\r\n### Summary of Changes\r\n- Decoupling JCB even more from vdm.io in preparation of the launch of the joomlacomponentbuilder.com website\r\n- Fixed gh-285 the validation rule error, by removing the namespace\r\n- Fixed the email helper class to match the custom global field value.\r\n- Removed the spinner from export data option in the language translation area.\r\n- Fixed the dynamic dashboard to be able to check if the view was found in the component.\r\n- Updated the readme to reflect the new terms of gaining access to demo content.\r\n- Added the email field type to resolve gh-283.\r\n- Fixed the CSS inclusion error to resolve gh-278.\r\n- Added the option to add sql_uninstall dump value to a component.\r\n- Did some class formatting on the compiler.\r\n\r\n### Testing Instructions\r\nValidation rule use\r\nEmail helper fields should work\r\nUse the new email field\r\nAdd CSS to the listview via admin view\r\nAdd custom sql uninstall dump values\r\nJCB works stable with import and export and compiling of all components.\r\n\r\n### Expected result\r\nThat all works correctly with no errors.\r\n\r\n### Actual result\r\nFixed a few bugs and added some new features.","created_at":"2018-05-18T06:10:42Z","updated_at":"2018-05-18T13:10:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed1e06431c09925b3317d4234748889fed472de2","assignee":{"login":"Llewellynvdm","id":5607939,"avatar_url":"https://avatars3.githubusercontent.com/u/5607939?v=4","gravatar_id":"","url":"https://api.github.com/users/Llewellynvdm","html_url":"https://github.com/Llewellynvdm","followers_url":"https://api.github.com/users/Llewellynvdm/followers","following_url":"https://api.github.com/users/Llewellynvdm/following{/other_user}","gists_url":"https://api.github.com/users/Llewellynvdm/gists{/gist_id}","starred_url":"https://api.github.com/users/Llewellynvdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Llewellynvdm/subscriptions","organizations_url":"https://api.github.com/users/Llewellynvdm/orgs","repos_url":"https://api.github.com/users/Llewellynvdm/repos","events_url":"https://api.github.com/users/Llewellynvdm/events{/privacy}","received_events_url":"https://api.github.com/users/Llewellynvdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"Llewellynvdm","id":5607939,"avatar_url":"https://avatars3.githubusercontent.com/u/5607939?v=4","gravatar_id":"","url":"https://api.github.com/users/Llewellynvdm","html_url":"https://github.com/Llewellynvdm","followers_url":"https://api.github.com/users/Llewellynvdm/followers","following_url":"https://api.github.com/users/Llewellynvdm/following{/other_user}","gists_url":"https://api.github.com/users/Llewellynvdm/gists{/gist_id}","starred_url":"https://api.github.com/users/Llewellynvdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Llewellynvdm/subscriptions","organizations_url":"https://api.github.com/users/Llewellynvdm/orgs","repos_url":"https://api.github.com/users/Llewellynvdm/repos","events_url":"https://api.github.com/users/Llewellynvdm/events{/privacy}","received_events_url":"https://api.github.com/users/Llewellynvdm/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Rolinevdm","id":34938702,"avatar_url":"https://avatars2.githubusercontent.com/u/34938702?v=4","gravatar_id":"","url":"https://api.github.com/users/Rolinevdm","html_url":"https://github.com/Rolinevdm","followers_url":"https://api.github.com/users/Rolinevdm/followers","following_url":"https://api.github.com/users/Rolinevdm/following{/other_user}","gists_url":"https://api.github.com/users/Rolinevdm/gists{/gist_id}","starred_url":"https://api.github.com/users/Rolinevdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rolinevdm/subscriptions","organizations_url":"https://api.github.com/users/Rolinevdm/orgs","repos_url":"https://api.github.com/users/Rolinevdm/repos","events_url":"https://api.github.com/users/Rolinevdm/events{/privacy}","received_events_url":"https://api.github.com/users/Rolinevdm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/286/commits","review_comments_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/286/comments","review_comment_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/286/comments","statuses_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/statuses/8488392fac20453c608a31e44c522df739381e12","head":{"label":"vdm-io:staging","ref":"staging","sha":"8488392fac20453c608a31e44c522df739381e12","user":{"login":"vdm-io","id":16954784,"avatar_url":"https://avatars0.githubusercontent.com/u/16954784?v=4","gravatar_id":"","url":"https://api.github.com/users/vdm-io","html_url":"https://github.com/vdm-io","followers_url":"https://api.github.com/users/vdm-io/followers","following_url":"https://api.github.com/users/vdm-io/following{/other_user}","gists_url":"https://api.github.com/users/vdm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vdm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdm-io/subscriptions","organizations_url":"https://api.github.com/users/vdm-io/orgs","repos_url":"https://api.github.com/users/vdm-io/repos","events_url":"https://api.github.com/users/vdm-io/events{/privacy}","received_events_url":"https://api.github.com/users/vdm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":50740730,"name":"Joomla-Component-Builder","full_name":"vdm-io/Joomla-Component-Builder","owner":{"login":"vdm-io","id":16954784,"avatar_url":"https://avatars0.githubusercontent.com/u/16954784?v=4","gravatar_id":"","url":"https://api.github.com/users/vdm-io","html_url":"https://github.com/vdm-io","followers_url":"https://api.github.com/users/vdm-io/followers","following_url":"https://api.github.com/users/vdm-io/following{/other_user}","gists_url":"https://api.github.com/users/vdm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vdm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdm-io/subscriptions","organizations_url":"https://api.github.com/users/vdm-io/orgs","repos_url":"https://api.github.com/users/vdm-io/repos","events_url":"https://api.github.com/users/vdm-io/events{/privacy}","received_events_url":"https://api.github.com/users/vdm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vdm-io/Joomla-Component-Builder","description":"Builds Complex Joomla Components","fork":false,"url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder","forks_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/forks","keys_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/teams","hooks_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/hooks","issue_events_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/events{/number}","events_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/events","assignees_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/assignees{/user}","branches_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/branches{/branch}","tags_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/tags","blobs_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/statuses/{sha}","languages_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/languages","stargazers_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/stargazers","contributors_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/contributors","subscribers_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/subscribers","subscription_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/subscription","commits_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/contents/{+path}","compare_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/merges","archive_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/downloads","issues_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues{/number}","pulls_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls{/number}","milestones_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/milestones{/number}","notifications_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/labels{/name}","releases_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/releases{/id}","deployments_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/deployments","created_at":"2016-01-30T19:21:54Z","updated_at":"2018-05-18T09:09:13Z","pushed_at":"2018-05-18T06:41:39Z","git_url":"git://github.com/vdm-io/Joomla-Component-Builder.git","ssh_url":"git@github.com:vdm-io/Joomla-Component-Builder.git","clone_url":"https://github.com/vdm-io/Joomla-Component-Builder.git","svn_url":"https://github.com/vdm-io/Joomla-Component-Builder","homepage":"http://joomlacomponentbuilder.com","size":36218,"stargazers_count":67,"watchers_count":67,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":41,"open_issues":4,"watchers":67,"default_branch":"staging"}},"base":{"label":"vdm-io:master","ref":"master","sha":"476a0c525ada99e632595d75d4f2a6bc4650b1a2","user":{"login":"vdm-io","id":16954784,"avatar_url":"https://avatars0.githubusercontent.com/u/16954784?v=4","gravatar_id":"","url":"https://api.github.com/users/vdm-io","html_url":"https://github.com/vdm-io","followers_url":"https://api.github.com/users/vdm-io/followers","following_url":"https://api.github.com/users/vdm-io/following{/other_user}","gists_url":"https://api.github.com/users/vdm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vdm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdm-io/subscriptions","organizations_url":"https://api.github.com/users/vdm-io/orgs","repos_url":"https://api.github.com/users/vdm-io/repos","events_url":"https://api.github.com/users/vdm-io/events{/privacy}","received_events_url":"https://api.github.com/users/vdm-io/received_events","type":"Organization","site_admin":false},"repo":{"id":50740730,"name":"Joomla-Component-Builder","full_name":"vdm-io/Joomla-Component-Builder","owner":{"login":"vdm-io","id":16954784,"avatar_url":"https://avatars0.githubusercontent.com/u/16954784?v=4","gravatar_id":"","url":"https://api.github.com/users/vdm-io","html_url":"https://github.com/vdm-io","followers_url":"https://api.github.com/users/vdm-io/followers","following_url":"https://api.github.com/users/vdm-io/following{/other_user}","gists_url":"https://api.github.com/users/vdm-io/gists{/gist_id}","starred_url":"https://api.github.com/users/vdm-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdm-io/subscriptions","organizations_url":"https://api.github.com/users/vdm-io/orgs","repos_url":"https://api.github.com/users/vdm-io/repos","events_url":"https://api.github.com/users/vdm-io/events{/privacy}","received_events_url":"https://api.github.com/users/vdm-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vdm-io/Joomla-Component-Builder","description":"Builds Complex Joomla Components","fork":false,"url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder","forks_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/forks","keys_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/teams","hooks_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/hooks","issue_events_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/events{/number}","events_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/events","assignees_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/assignees{/user}","branches_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/branches{/branch}","tags_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/tags","blobs_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/statuses/{sha}","languages_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/languages","stargazers_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/stargazers","contributors_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/contributors","subscribers_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/subscribers","subscription_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/subscription","commits_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/contents/{+path}","compare_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/merges","archive_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/downloads","issues_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues{/number}","pulls_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls{/number}","milestones_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/milestones{/number}","notifications_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/labels{/name}","releases_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/releases{/id}","deployments_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/deployments","created_at":"2016-01-30T19:21:54Z","updated_at":"2018-05-18T09:09:13Z","pushed_at":"2018-05-18T06:41:39Z","git_url":"git://github.com/vdm-io/Joomla-Component-Builder.git","ssh_url":"git@github.com:vdm-io/Joomla-Component-Builder.git","clone_url":"https://github.com/vdm-io/Joomla-Component-Builder.git","svn_url":"https://github.com/vdm-io/Joomla-Component-Builder","homepage":"http://joomlacomponentbuilder.com","size":36218,"stargazers_count":67,"watchers_count":67,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":41,"open_issues":4,"watchers":67,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/286"},"html":{"href":"https://github.com/vdm-io/Joomla-Component-Builder/pull/286"},"issue":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/286"},"comments":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/286/comments"},"review_comments":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/286/comments"},"review_comment":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/286/commits"},"statuses":{"href":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/statuses/8488392fac20453c608a31e44c522df739381e12"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ro-ot"}}