{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/173399709","pull_request_review_id":102585131,"id":173399709,"diff_hunk":"@@ -156,10 +156,13 @@ func Test_ClusterOrganization(t *testing.T) {\n }\n \n func Test_ClusterTags(t *testing.T) {\n+\tinstallName := \"test-install\"\n+\n \texpectedID := \"test-cluster\"\n \texpectedTags := map[string]string{\n \t\t\"kubernetes.io/cluster/test-cluster\": \"owned\",\n \t\t\"giantswarm.io/cluster\":              \"test-cluster\",\n+\t\t\"giantswarm.io/installation\":         \"test-install\",","path":"service/awsconfig/v8/key/key_test.go","position":10,"original_position":10,"commit_id":"f05198b51d31dc55ece91eb5ba9f270a17b23776","original_commit_id":"f05198b51d31dc55ece91eb5ba9f270a17b23776","user":{"login":"kopiczko","id":4608994,"avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"body":"opsctl is 100% internal tool. It's fine to use whatever term there.","created_at":"2018-03-09T09:22:25Z","updated_at":"2018-03-09T09:22:25Z","html_url":"https://github.com/giantswarm/aws-operator/pull/826#discussion_r173399709","pull_request_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/826","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/173399709"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/826#discussion_r173399709"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/826"}},"in_reply_to_id":173395521},"pull_request":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/826","id":173831625,"html_url":"https://github.com/giantswarm/aws-operator/pull/826","diff_url":"https://github.com/giantswarm/aws-operator/pull/826.diff","patch_url":"https://github.com/giantswarm/aws-operator/pull/826.patch","issue_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/826","number":826,"state":"open","locked":false,"title":"Add AWS resource tag with the Giant Swarm Installation","user":{"login":"rossf7","id":311527,"avatar_url":"https://avatars1.githubusercontent.com/u/311527?v=4","gravatar_id":"","url":"https://api.github.com/users/rossf7","html_url":"https://github.com/rossf7","followers_url":"https://api.github.com/users/rossf7/followers","following_url":"https://api.github.com/users/rossf7/following{/other_user}","gists_url":"https://api.github.com/users/rossf7/gists{/gist_id}","starred_url":"https://api.github.com/users/rossf7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossf7/subscriptions","organizations_url":"https://api.github.com/users/rossf7/orgs","repos_url":"https://api.github.com/users/rossf7/repos","events_url":"https://api.github.com/users/rossf7/events{/privacy}","received_events_url":"https://api.github.com/users/rossf7/received_events","type":"User","site_admin":false},"body":"Towards giantswarm/giantswarm#2775\r\n\r\nAdds the installation tag which we want to use for cost tracking. This is configured via a flag so it needed to be added to the `kmskey` and `s3bucket` resources. \r\n\r\nMaybe we should add the installation name to the provider CRDs as IMO it's useful metadata. I've added to the cluster object refactoring issue.\r\n\r\nhttps://github.com/giantswarm/giantswarm/issues/2383#issuecomment-371749665","created_at":"2018-03-08T19:44:56Z","updated_at":"2018-03-09T09:22:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4418bc99f93d1270fde2e276c599c7fd64ef7c27","assignee":{"login":"rossf7","id":311527,"avatar_url":"https://avatars1.githubusercontent.com/u/311527?v=4","gravatar_id":"","url":"https://api.github.com/users/rossf7","html_url":"https://github.com/rossf7","followers_url":"https://api.github.com/users/rossf7/followers","following_url":"https://api.github.com/users/rossf7/following{/other_user}","gists_url":"https://api.github.com/users/rossf7/gists{/gist_id}","starred_url":"https://api.github.com/users/rossf7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossf7/subscriptions","organizations_url":"https://api.github.com/users/rossf7/orgs","repos_url":"https://api.github.com/users/rossf7/repos","events_url":"https://api.github.com/users/rossf7/events{/privacy}","received_events_url":"https://api.github.com/users/rossf7/received_events","type":"User","site_admin":false},"assignees":[{"login":"rossf7","id":311527,"avatar_url":"https://avatars1.githubusercontent.com/u/311527?v=4","gravatar_id":"","url":"https://api.github.com/users/rossf7","html_url":"https://github.com/rossf7","followers_url":"https://api.github.com/users/rossf7/followers","following_url":"https://api.github.com/users/rossf7/following{/other_user}","gists_url":"https://api.github.com/users/rossf7/gists{/gist_id}","starred_url":"https://api.github.com/users/rossf7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossf7/subscriptions","organizations_url":"https://api.github.com/users/rossf7/orgs","repos_url":"https://api.github.com/users/rossf7/repos","events_url":"https://api.github.com/users/rossf7/events{/privacy}","received_events_url":"https://api.github.com/users/rossf7/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/826/commits","review_comments_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/826/comments","review_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/826/comments","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/f05198b51d31dc55ece91eb5ba9f270a17b23776","head":{"label":"giantswarm:install-tag","ref":"install-tag","sha":"f05198b51d31dc55ece91eb5ba9f270a17b23776","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"name":"aws-operator","full_name":"giantswarm/aws-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/aws-operator","description":"AWS operator creates/configure/manages Kubernetes clusters on AWS by using Giantnetes.","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-03-05T13:09:21Z","pushed_at":"2018-03-09T08:38:10Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":null,"size":57202,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":5,"watchers":36,"default_branch":"master"}},"base":{"label":"giantswarm:master","ref":"master","sha":"6edb1aed17207ebaa89de711ae971938e8af8e73","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"name":"aws-operator","full_name":"giantswarm/aws-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/aws-operator","description":"AWS operator creates/configure/manages Kubernetes clusters on AWS by using Giantnetes.","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-03-05T13:09:21Z","pushed_at":"2018-03-09T08:38:10Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":null,"size":57202,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":13,"open_issues":5,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/826"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/826"},"issue":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/826"},"comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/826/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/826/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/826/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/aws-operator/statuses/f05198b51d31dc55ece91eb5ba9f270a17b23776"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kopiczko"}}