{"action":"created","comment":{"url":"https://api.github.com/repos/cloudevents/sdk-java/pulls/comments/228984033","pull_request_review_id":169374547,"id":228984033,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODk4NDAzMw==","diff_hunk":"@@ -0,0 +1,77 @@\n+/**\n+ * Copyright 2018 The CloudEvents Authors\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+package io.cloudevents;\n+\n+import java.net.URI;\n+import java.time.ZonedDateTime;\n+import java.util.Map;\n+import java.util.Optional;\n+\n+/**\n+ * An abstract event envelope, representing the 0.1 version of the <a href=\"https://github.com/cloudevents/spec/blob/master/spec.md\">CNCF CloudEvent spec</a>.\n+ *\n+ */\n+public interface CloudEvent<T> {\n+    /**\n+     * Type of occurrence which has happened. Often this property is used for routing, observability, policy enforcement, etc.\n+     */\n+    String getEventType();\n+\n+    /**\n+     * The version of the CloudEvents specification which the event uses. This enables the interpretation of the context.\n+     */\n+    String getCloudEventsVersion();\n+\n+    /**\n+     * This describes the event producer. Often this will include information such as the type of the event source, the organization publishing the event, and some unique identifiers.\n+     * The exact syntax and semantics behind the data encoded in the URI is event producer defined.\n+     */\n+    URI getSource();\n+\n+    /**\n+     * ID of the event. The semantics of this string are explicitly undefined to ease the implementation of producers. Enables deduplication.\n+     */\n+    String getEventID();\n+\n+    /**\n+     * The version of the eventType. This enables the interpretation of data by eventual consumers, requires the consumer to be knowledgeable about the producer.\n+     */\n+    Optional<String> getEventTypeVersion();\n+    /**\n+     * Timestamp of when the event happened.\n+     */\n+    Optional<ZonedDateTime> getEventTime();","path":"api/src/main/java/io/cloudevents/CloudEvent.java","position":56,"original_position":56,"commit_id":"fbe2bbfa61653f41f9d67bed2b1954b32a8cb780","original_commit_id":"fbe2bbfa61653f41f9d67bed2b1954b32a8cb780","user":{"login":"joschi","id":43951,"node_id":"MDQ6VXNlcjQzOTUx","avatar_url":"https://avatars1.githubusercontent.com/u/43951?v=4","gravatar_id":"","url":"https://api.github.com/users/joschi","html_url":"https://github.com/joschi","followers_url":"https://api.github.com/users/joschi/followers","following_url":"https://api.github.com/users/joschi/following{/other_user}","gists_url":"https://api.github.com/users/joschi/gists{/gist_id}","starred_url":"https://api.github.com/users/joschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joschi/subscriptions","organizations_url":"https://api.github.com/users/joschi/orgs","repos_url":"https://api.github.com/users/joschi/repos","events_url":"https://api.github.com/users/joschi/events{/privacy}","received_events_url":"https://api.github.com/users/joschi/received_events","type":"User","site_admin":false},"body":"Shouldn't this be an `Instant` instead of `ZonedDateTime`?\r\n\r\n> This class models a single instantaneous point on the time-line. This might be used to record event time-stamps in the application.\r\n\r\n➡️ https://docs.oracle.com/javase/8/docs/api/java/time/Instant.html","created_at":"2018-10-29T15:47:32Z","updated_at":"2018-10-29T15:47:33Z","html_url":"https://github.com/cloudevents/sdk-java/pull/1#discussion_r228984033","pull_request_url":"https://api.github.com/repos/cloudevents/sdk-java/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cloudevents/sdk-java/pulls/comments/228984033"},"html":{"href":"https://github.com/cloudevents/sdk-java/pull/1#discussion_r228984033"},"pull_request":{"href":"https://api.github.com/repos/cloudevents/sdk-java/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/cloudevents/sdk-java/pulls/1","id":220870045,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODcwMDQ1","html_url":"https://github.com/cloudevents/sdk-java/pull/1","diff_url":"https://github.com/cloudevents/sdk-java/pull/1.diff","patch_url":"https://github.com/cloudevents/sdk-java/pull/1.patch","issue_url":"https://api.github.com/repos/cloudevents/sdk-java/issues/1","number":1,"state":"open","locked":false,"title":"Proposal for JAva SDK","user":{"login":"matzew","id":157646,"node_id":"MDQ6VXNlcjE1NzY0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/157646?v=4","gravatar_id":"","url":"https://api.github.com/users/matzew","html_url":"https://github.com/matzew","followers_url":"https://api.github.com/users/matzew/followers","following_url":"https://api.github.com/users/matzew/following{/other_user}","gists_url":"https://api.github.com/users/matzew/gists{/gist_id}","starred_url":"https://api.github.com/users/matzew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matzew/subscriptions","organizations_url":"https://api.github.com/users/matzew/orgs","repos_url":"https://api.github.com/users/matzew/repos","events_url":"https://api.github.com/users/matzew/events{/privacy}","received_events_url":"https://api.github.com/users/matzew/received_events","type":"User","site_admin":false},"body":"Simple SDK for a Java API","created_at":"2018-10-06T07:12:25Z","updated_at":"2018-10-29T15:47:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b964f65d968b65bb56b60ee46c03539fc5ac3bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudevents/sdk-java/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cloudevents/sdk-java/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cloudevents/sdk-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudevents/sdk-java/issues/1/comments","statuses_url":"https://api.github.com/repos/cloudevents/sdk-java/statuses/fbe2bbfa61653f41f9d67bed2b1954b32a8cb780","head":{"label":"matzew:Proposal","ref":"Proposal","sha":"fbe2bbfa61653f41f9d67bed2b1954b32a8cb780","user":{"login":"matzew","id":157646,"node_id":"MDQ6VXNlcjE1NzY0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/157646?v=4","gravatar_id":"","url":"https://api.github.com/users/matzew","html_url":"https://github.com/matzew","followers_url":"https://api.github.com/users/matzew/followers","following_url":"https://api.github.com/users/matzew/following{/other_user}","gists_url":"https://api.github.com/users/matzew/gists{/gist_id}","starred_url":"https://api.github.com/users/matzew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matzew/subscriptions","organizations_url":"https://api.github.com/users/matzew/orgs","repos_url":"https://api.github.com/users/matzew/repos","events_url":"https://api.github.com/users/matzew/events{/privacy}","received_events_url":"https://api.github.com/users/matzew/received_events","type":"User","site_admin":false},"repo":{"id":151813469,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE4MTM0Njk=","name":"sdk-java","full_name":"matzew/sdk-java","private":false,"owner":{"login":"matzew","id":157646,"node_id":"MDQ6VXNlcjE1NzY0Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/157646?v=4","gravatar_id":"","url":"https://api.github.com/users/matzew","html_url":"https://github.com/matzew","followers_url":"https://api.github.com/users/matzew/followers","following_url":"https://api.github.com/users/matzew/following{/other_user}","gists_url":"https://api.github.com/users/matzew/gists{/gist_id}","starred_url":"https://api.github.com/users/matzew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matzew/subscriptions","organizations_url":"https://api.github.com/users/matzew/orgs","repos_url":"https://api.github.com/users/matzew/repos","events_url":"https://api.github.com/users/matzew/events{/privacy}","received_events_url":"https://api.github.com/users/matzew/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matzew/sdk-java","description":"Javascript SDK for CloudEvents","fork":true,"url":"https://api.github.com/repos/matzew/sdk-java","forks_url":"https://api.github.com/repos/matzew/sdk-java/forks","keys_url":"https://api.github.com/repos/matzew/sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matzew/sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matzew/sdk-java/teams","hooks_url":"https://api.github.com/repos/matzew/sdk-java/hooks","issue_events_url":"https://api.github.com/repos/matzew/sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/matzew/sdk-java/events","assignees_url":"https://api.github.com/repos/matzew/sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/matzew/sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/matzew/sdk-java/tags","blobs_url":"https://api.github.com/repos/matzew/sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matzew/sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matzew/sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/matzew/sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matzew/sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/matzew/sdk-java/languages","stargazers_url":"https://api.github.com/repos/matzew/sdk-java/stargazers","contributors_url":"https://api.github.com/repos/matzew/sdk-java/contributors","subscribers_url":"https://api.github.com/repos/matzew/sdk-java/subscribers","subscription_url":"https://api.github.com/repos/matzew/sdk-java/subscription","commits_url":"https://api.github.com/repos/matzew/sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/matzew/sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/matzew/sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/matzew/sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/matzew/sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/matzew/sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matzew/sdk-java/merges","archive_url":"https://api.github.com/repos/matzew/sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matzew/sdk-java/downloads","issues_url":"https://api.github.com/repos/matzew/sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/matzew/sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/matzew/sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/matzew/sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matzew/sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/matzew/sdk-java/releases{/id}","deployments_url":"https://api.github.com/repos/matzew/sdk-java/deployments","created_at":"2018-10-06T06:58:09Z","updated_at":"2018-10-06T06:58:11Z","pushed_at":"2018-10-06T07:14:10Z","git_url":"git://github.com/matzew/sdk-java.git","ssh_url":"git@github.com:matzew/sdk-java.git","clone_url":"https://github.com/matzew/sdk-java.git","svn_url":"https://github.com/matzew/sdk-java","homepage":null,"size":17,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudevents:master","ref":"master","sha":"23d2d452e938d126c866fa1b391c617b2f64194e","user":{"login":"cloudevents","id":32076828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDc2ODI4","avatar_url":"https://avatars2.githubusercontent.com/u/32076828?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudevents","html_url":"https://github.com/cloudevents","followers_url":"https://api.github.com/users/cloudevents/followers","following_url":"https://api.github.com/users/cloudevents/following{/other_user}","gists_url":"https://api.github.com/users/cloudevents/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudevents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudevents/subscriptions","organizations_url":"https://api.github.com/users/cloudevents/orgs","repos_url":"https://api.github.com/users/cloudevents/repos","events_url":"https://api.github.com/users/cloudevents/events{/privacy}","received_events_url":"https://api.github.com/users/cloudevents/received_events","type":"Organization","site_admin":false},"repo":{"id":149663208,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NjMyMDg=","name":"sdk-java","full_name":"cloudevents/sdk-java","private":false,"owner":{"login":"cloudevents","id":32076828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDc2ODI4","avatar_url":"https://avatars2.githubusercontent.com/u/32076828?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudevents","html_url":"https://github.com/cloudevents","followers_url":"https://api.github.com/users/cloudevents/followers","following_url":"https://api.github.com/users/cloudevents/following{/other_user}","gists_url":"https://api.github.com/users/cloudevents/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudevents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudevents/subscriptions","organizations_url":"https://api.github.com/users/cloudevents/orgs","repos_url":"https://api.github.com/users/cloudevents/repos","events_url":"https://api.github.com/users/cloudevents/events{/privacy}","received_events_url":"https://api.github.com/users/cloudevents/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cloudevents/sdk-java","description":"Javascript SDK for CloudEvents","fork":false,"url":"https://api.github.com/repos/cloudevents/sdk-java","forks_url":"https://api.github.com/repos/cloudevents/sdk-java/forks","keys_url":"https://api.github.com/repos/cloudevents/sdk-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudevents/sdk-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudevents/sdk-java/teams","hooks_url":"https://api.github.com/repos/cloudevents/sdk-java/hooks","issue_events_url":"https://api.github.com/repos/cloudevents/sdk-java/issues/events{/number}","events_url":"https://api.github.com/repos/cloudevents/sdk-java/events","assignees_url":"https://api.github.com/repos/cloudevents/sdk-java/assignees{/user}","branches_url":"https://api.github.com/repos/cloudevents/sdk-java/branches{/branch}","tags_url":"https://api.github.com/repos/cloudevents/sdk-java/tags","blobs_url":"https://api.github.com/repos/cloudevents/sdk-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudevents/sdk-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudevents/sdk-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudevents/sdk-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudevents/sdk-java/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudevents/sdk-java/languages","stargazers_url":"https://api.github.com/repos/cloudevents/sdk-java/stargazers","contributors_url":"https://api.github.com/repos/cloudevents/sdk-java/contributors","subscribers_url":"https://api.github.com/repos/cloudevents/sdk-java/subscribers","subscription_url":"https://api.github.com/repos/cloudevents/sdk-java/subscription","commits_url":"https://api.github.com/repos/cloudevents/sdk-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudevents/sdk-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudevents/sdk-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudevents/sdk-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudevents/sdk-java/contents/{+path}","compare_url":"https://api.github.com/repos/cloudevents/sdk-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudevents/sdk-java/merges","archive_url":"https://api.github.com/repos/cloudevents/sdk-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudevents/sdk-java/downloads","issues_url":"https://api.github.com/repos/cloudevents/sdk-java/issues{/number}","pulls_url":"https://api.github.com/repos/cloudevents/sdk-java/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudevents/sdk-java/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudevents/sdk-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudevents/sdk-java/labels{/name}","releases_url":"https://api.github.com/repos/cloudevents/sdk-java/releases{/id}","deployments_url":"https://api.github.com/repos/cloudevents/sdk-java/deployments","created_at":"2018-09-20T19:56:36Z","updated_at":"2018-09-20T19:56:39Z","pushed_at":"2018-10-06T07:14:12Z","git_url":"git://github.com/cloudevents/sdk-java.git","ssh_url":"git@github.com:cloudevents/sdk-java.git","clone_url":"https://github.com/cloudevents/sdk-java.git","svn_url":"https://github.com/cloudevents/sdk-java","homepage":null,"size":4,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudevents/sdk-java/pulls/1"},"html":{"href":"https://github.com/cloudevents/sdk-java/pull/1"},"issue":{"href":"https://api.github.com/repos/cloudevents/sdk-java/issues/1"},"comments":{"href":"https://api.github.com/repos/cloudevents/sdk-java/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudevents/sdk-java/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudevents/sdk-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudevents/sdk-java/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cloudevents/sdk-java/statuses/fbe2bbfa61653f41f9d67bed2b1954b32a8cb780"}},"author_association":"NONE"}}
{"actor":{"display_login":"joschi"}}