{"action":"created","comment":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/231424905","pull_request_review_id":172390884,"id":231424905,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQyNDkwNQ==","diff_hunk":"@@ -1,54 +1,73 @@\n-# ${license-info}\n-# ${developer-info}\n-# ${author-info}\n-\n-############################################################\n-#\n-# type definition components/symlink\n-#\n-#\n-#\n-#\n-############################################################\n-\n-declaration template components/symlink/schema;\n-\n-include 'quattor/schema';\n+${componentschema}\n+include 'quattor/types/component';\n \n type structure_symlink_replace_option_entry = {\n+    @{Use when renaming a given object type or to enable replacement for a specific object type.}\n     \"all\" ? string\n+    @{Any directory}\n     \"dir\" ? string\n+    @{An empty directory only}\n     \"dirempty\" ? string\n     \"file\" ? string\n     \"link\" ? string\n+    @{Use when renaming a given object type or to prevent replacement for a specific object type}\n     \"none\" ? string\n };\n \n type structure_symlink_entry = {\n-        \"name\" : string\n-        \"target\" : string\n-        \"exists\" ? boolean\n-        \"delete\" ? boolean\n+    @{symbolic link name (path).}\n+    \"name\" : string\n+    @{The target path can be built using a command output with the command string\n+    (can include valid command options) to execute between a pair of '@@' or a\n+    contextual variable (variables are defined in \"/software/components/symlinks/context\").\n+    Unless the shell command between '@@' must be reevaluated for each link, it is\n+    better to associate the shell command with a contextual variable and use the\n+    variable in the target definition, as a contextual variable is evaluated once (global).}\n+    \"target\" : string\n+    @{Check that the target exists when creating it or check that the symlink\n+    name exists when deleting it.}\n+    \"exists\" ? boolean\n+    @{Delete the symlink (not its target) rather than creating it. \"target\" can be\n+    ommitted in this case and if present, it is not checked to be this value before\n+    deletion. If \"exists\" is true, raise an error, if the link is not found else\n+    just silently ignore it. }\n+    \"delete\" ? boolean\n+    @{Option used to specify the action to take when an object with the same\n+    name as the symlink already exists, depending on the object type.\n+    Possible actions are: do not define the symlink, replace the\n+    object by the symlink or define the symlink after renaming the object.}\n     \"replace\" ? structure_symlink_replace_option_entry\n };\n \n type structure_symlink_context_entry = {\n-        \"name\" : string\n-        \"value\" : string\n+    \"name\" : string\n+    \"value\" : string\n };\n \n type structure_symlink_option_entry = {\n-        \"exists\" ? boolean\n+    @{Action applying to the object type. Can be \"yes\" (replacement of the object","path":"ncm-symlink/src/main/pan/components/symlink/schema.pan","position":71,"original_position":71,"commit_id":"418a39264be19c569cf231ab97200ebb61967c0e","original_commit_id":"418a39264be19c569cf231ab97200ebb61967c0e","user":{"login":"stdweird","id":1517606,"node_id":"MDQ6VXNlcjE1MTc2MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1517606?v=4","gravatar_id":"","url":"https://api.github.com/users/stdweird","html_url":"https://github.com/stdweird","followers_url":"https://api.github.com/users/stdweird/followers","following_url":"https://api.github.com/users/stdweird/following{/other_user}","gists_url":"https://api.github.com/users/stdweird/gists{/gist_id}","starred_url":"https://api.github.com/users/stdweird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stdweird/subscriptions","organizations_url":"https://api.github.com/users/stdweird/orgs","repos_url":"https://api.github.com/users/stdweird/repos","events_url":"https://api.github.com/users/stdweird/events{/privacy}","received_events_url":"https://api.github.com/users/stdweird/received_events","type":"User","site_admin":false},"body":"it's `true` or `'false', not yes/no","created_at":"2018-11-07T09:02:27Z","updated_at":"2018-11-07T09:02:27Z","html_url":"https://github.com/quattor/configuration-modules-core/pull/1346#discussion_r231424905","pull_request_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/1346","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments/231424905"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/1346#discussion_r231424905"},"pull_request":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/1346"}}},"pull_request":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/1346","id":228419254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDE5MjU0","html_url":"https://github.com/quattor/configuration-modules-core/pull/1346","diff_url":"https://github.com/quattor/configuration-modules-core/pull/1346.diff","patch_url":"https://github.com/quattor/configuration-modules-core/pull/1346.patch","issue_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/1346","number":1346,"state":"open","locked":false,"title":"ncm-symlink: cleanup and documentation restructuring","user":{"login":"wdpypere","id":5476755,"node_id":"MDQ6VXNlcjU0NzY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5476755?v=4","gravatar_id":"","url":"https://api.github.com/users/wdpypere","html_url":"https://github.com/wdpypere","followers_url":"https://api.github.com/users/wdpypere/followers","following_url":"https://api.github.com/users/wdpypere/following{/other_user}","gists_url":"https://api.github.com/users/wdpypere/gists{/gist_id}","starred_url":"https://api.github.com/users/wdpypere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdpypere/subscriptions","organizations_url":"https://api.github.com/users/wdpypere/orgs","repos_url":"https://api.github.com/users/wdpypere/repos","events_url":"https://api.github.com/users/wdpypere/events{/privacy}","received_events_url":"https://api.github.com/users/wdpypere/received_events","type":"User","site_admin":false},"body":" - Move schema documentation into the schema\r\n - clean the pan code up to spring 2017 cleanup style\r\n","created_at":"2018-11-05T16:49:37Z","updated_at":"2018-11-07T09:02:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c02221706f39e8204aaa896d1133e3bc2a48132","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/23","html_url":"https://github.com/quattor/configuration-modules-core/milestone/23","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones/23/labels","id":2864816,"node_id":"MDk6TWlsZXN0b25lMjg2NDgxNg==","number":23,"title":"18.12","description":null,"creator":{"login":"jrha","id":323309,"node_id":"MDQ6VXNlcjMyMzMwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/323309?v=4","gravatar_id":"","url":"https://api.github.com/users/jrha","html_url":"https://github.com/jrha","followers_url":"https://api.github.com/users/jrha/followers","following_url":"https://api.github.com/users/jrha/following{/other_user}","gists_url":"https://api.github.com/users/jrha/gists{/gist_id}","starred_url":"https://api.github.com/users/jrha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrha/subscriptions","organizations_url":"https://api.github.com/users/jrha/orgs","repos_url":"https://api.github.com/users/jrha/repos","events_url":"https://api.github.com/users/jrha/events{/privacy}","received_events_url":"https://api.github.com/users/jrha/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":27,"state":"open","created_at":"2017-10-25T13:57:12Z","updated_at":"2018-11-06T12:48:53Z","due_on":"2018-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/1346/commits","review_comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/1346/comments","review_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/1346/comments","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/418a39264be19c569cf231ab97200ebb61967c0e","head":{"label":"wdpypere:symlink","ref":"symlink","sha":"418a39264be19c569cf231ab97200ebb61967c0e","user":{"login":"wdpypere","id":5476755,"node_id":"MDQ6VXNlcjU0NzY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5476755?v=4","gravatar_id":"","url":"https://api.github.com/users/wdpypere","html_url":"https://github.com/wdpypere","followers_url":"https://api.github.com/users/wdpypere/followers","following_url":"https://api.github.com/users/wdpypere/following{/other_user}","gists_url":"https://api.github.com/users/wdpypere/gists{/gist_id}","starred_url":"https://api.github.com/users/wdpypere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdpypere/subscriptions","organizations_url":"https://api.github.com/users/wdpypere/orgs","repos_url":"https://api.github.com/users/wdpypere/repos","events_url":"https://api.github.com/users/wdpypere/events{/privacy}","received_events_url":"https://api.github.com/users/wdpypere/received_events","type":"User","site_admin":false},"repo":{"id":19947899,"node_id":"MDEwOlJlcG9zaXRvcnkxOTk0Nzg5OQ==","name":"configuration-modules-core","full_name":"wdpypere/configuration-modules-core","private":false,"owner":{"login":"wdpypere","id":5476755,"node_id":"MDQ6VXNlcjU0NzY3NTU=","avatar_url":"https://avatars0.githubusercontent.com/u/5476755?v=4","gravatar_id":"","url":"https://api.github.com/users/wdpypere","html_url":"https://github.com/wdpypere","followers_url":"https://api.github.com/users/wdpypere/followers","following_url":"https://api.github.com/users/wdpypere/following{/other_user}","gists_url":"https://api.github.com/users/wdpypere/gists{/gist_id}","starred_url":"https://api.github.com/users/wdpypere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wdpypere/subscriptions","organizations_url":"https://api.github.com/users/wdpypere/orgs","repos_url":"https://api.github.com/users/wdpypere/repos","events_url":"https://api.github.com/users/wdpypere/events{/privacy}","received_events_url":"https://api.github.com/users/wdpypere/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wdpypere/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":true,"url":"https://api.github.com/repos/wdpypere/configuration-modules-core","forks_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/releases{/id}","deployments_url":"https://api.github.com/repos/wdpypere/configuration-modules-core/deployments","created_at":"2014-05-19T15:48:24Z","updated_at":"2018-11-05T14:29:27Z","pushed_at":"2018-11-07T08:38:38Z","git_url":"git://github.com/wdpypere/configuration-modules-core.git","ssh_url":"git@github.com:wdpypere/configuration-modules-core.git","clone_url":"https://github.com/wdpypere/configuration-modules-core.git","svn_url":"https://github.com/wdpypere/configuration-modules-core","homepage":"www.quattor.org","size":13413,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"quattor:master","ref":"master","sha":"ac3020a8d8eccce55eef81547b69187621bf330c","user":{"login":"quattor","id":1557169,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NTcxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1557169?v=4","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"repo":{"id":6471233,"node_id":"MDEwOlJlcG9zaXRvcnk2NDcxMjMz","name":"configuration-modules-core","full_name":"quattor/configuration-modules-core","private":false,"owner":{"login":"quattor","id":1557169,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NTcxNjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1557169?v=4","gravatar_id":"","url":"https://api.github.com/users/quattor","html_url":"https://github.com/quattor","followers_url":"https://api.github.com/users/quattor/followers","following_url":"https://api.github.com/users/quattor/following{/other_user}","gists_url":"https://api.github.com/users/quattor/gists{/gist_id}","starred_url":"https://api.github.com/users/quattor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quattor/subscriptions","organizations_url":"https://api.github.com/users/quattor/orgs","repos_url":"https://api.github.com/users/quattor/repos","events_url":"https://api.github.com/users/quattor/events{/privacy}","received_events_url":"https://api.github.com/users/quattor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/quattor/configuration-modules-core","description":"Node Configuration Manager Components for Everyone","fork":false,"url":"https://api.github.com/repos/quattor/configuration-modules-core","forks_url":"https://api.github.com/repos/quattor/configuration-modules-core/forks","keys_url":"https://api.github.com/repos/quattor/configuration-modules-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quattor/configuration-modules-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quattor/configuration-modules-core/teams","hooks_url":"https://api.github.com/repos/quattor/configuration-modules-core/hooks","issue_events_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/events{/number}","events_url":"https://api.github.com/repos/quattor/configuration-modules-core/events","assignees_url":"https://api.github.com/repos/quattor/configuration-modules-core/assignees{/user}","branches_url":"https://api.github.com/repos/quattor/configuration-modules-core/branches{/branch}","tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/tags","blobs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/{sha}","languages_url":"https://api.github.com/repos/quattor/configuration-modules-core/languages","stargazers_url":"https://api.github.com/repos/quattor/configuration-modules-core/stargazers","contributors_url":"https://api.github.com/repos/quattor/configuration-modules-core/contributors","subscribers_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscribers","subscription_url":"https://api.github.com/repos/quattor/configuration-modules-core/subscription","commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/quattor/configuration-modules-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/quattor/configuration-modules-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/quattor/configuration-modules-core/contents/{+path}","compare_url":"https://api.github.com/repos/quattor/configuration-modules-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quattor/configuration-modules-core/merges","archive_url":"https://api.github.com/repos/quattor/configuration-modules-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quattor/configuration-modules-core/downloads","issues_url":"https://api.github.com/repos/quattor/configuration-modules-core/issues{/number}","pulls_url":"https://api.github.com/repos/quattor/configuration-modules-core/pulls{/number}","milestones_url":"https://api.github.com/repos/quattor/configuration-modules-core/milestones{/number}","notifications_url":"https://api.github.com/repos/quattor/configuration-modules-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quattor/configuration-modules-core/labels{/name}","releases_url":"https://api.github.com/repos/quattor/configuration-modules-core/releases{/id}","deployments_url":"https://api.github.com/repos/quattor/configuration-modules-core/deployments","created_at":"2012-10-31T09:08:07Z","updated_at":"2018-11-05T13:51:07Z","pushed_at":"2018-11-07T08:38:39Z","git_url":"git://github.com/quattor/configuration-modules-core.git","ssh_url":"git@github.com:quattor/configuration-modules-core.git","clone_url":"https://github.com/quattor/configuration-modules-core.git","svn_url":"https://github.com/quattor/configuration-modules-core","homepage":"www.quattor.org","size":13604,"stargazers_count":7,"watchers_count":7,"language":"Perl","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":165,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":41,"open_issues":165,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/1346"},"html":{"href":"https://github.com/quattor/configuration-modules-core/pull/1346"},"issue":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/1346"},"comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/issues/1346/comments"},"review_comments":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/1346/comments"},"review_comment":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/pulls/1346/commits"},"statuses":{"href":"https://api.github.com/repos/quattor/configuration-modules-core/statuses/418a39264be19c569cf231ab97200ebb61967c0e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"stdweird"}}