{"action":"created","comment":{"url":"https://api.github.com/repos/odoo/odoo/pulls/comments/208554086","pull_request_review_id":144325808,"id":208554086,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODU1NDA4Ng==","diff_hunk":"@@ -82,9 +82,9 @@ def get_mail_values(self, res_ids):\n                 }\n                 if mail_values.get('body_html') and mass_mail_layout:\n                     mail_values['body_html'] = mass_mail_layout.render({'body': mail_values['body_html']}, engine='ir.qweb', minimal_qcontext=True)\n-                # propagate exception state to stat when still-born\n-                if mail_values.get('state') == 'cancel':\n-                    stat_vals['exception'] = fields.Datetime.now()\n+                # propagate ignored state to stat when still-born\n+                if mail_values.get('state', None) == 'cancel':","path":"addons/mass_mailing/wizard/mail_compose_message.py","position":38,"original_position":8,"commit_id":"5f115c572ff7aef9ec2d4b6b3f68993b3010e02b","original_commit_id":"91e40dccc023ffa939226c82f59985b8d4903ef8","user":{"login":"tde-banana-odoo","id":7501424,"node_id":"MDQ6VXNlcjc1MDE0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7501424?v=4","gravatar_id":"","url":"https://api.github.com/users/tde-banana-odoo","html_url":"https://github.com/tde-banana-odoo","followers_url":"https://api.github.com/users/tde-banana-odoo/followers","following_url":"https://api.github.com/users/tde-banana-odoo/following{/other_user}","gists_url":"https://api.github.com/users/tde-banana-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/tde-banana-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tde-banana-odoo/subscriptions","organizations_url":"https://api.github.com/users/tde-banana-odoo/orgs","repos_url":"https://api.github.com/users/tde-banana-odoo/repos","events_url":"https://api.github.com/users/tde-banana-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/tde-banana-odoo/received_events","type":"User","site_admin":false},"body":"As dict.get() returns None by default you don't have to give a default value here.","created_at":"2018-08-08T12:03:04Z","updated_at":"2018-08-08T12:49:47Z","html_url":"https://github.com/odoo/odoo/pull/25966#discussion_r208554086","pull_request_url":"https://api.github.com/repos/odoo/odoo/pulls/25966","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments/208554086"},"html":{"href":"https://github.com/odoo/odoo/pull/25966#discussion_r208554086"},"pull_request":{"href":"https://api.github.com/repos/odoo/odoo/pulls/25966"}}},"pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/25966","id":203802286,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzODAyMjg2","html_url":"https://github.com/odoo/odoo/pull/25966","diff_url":"https://github.com/odoo/odoo/pull/25966.diff","patch_url":"https://github.com/odoo/odoo/pull/25966.patch","issue_url":"https://api.github.com/repos/odoo/odoo/issues/25966","number":25966,"state":"open","locked":false,"title":"Master mass mail blacklist opt out dbe","user":{"login":"dbeguin","id":38424442,"node_id":"MDQ6VXNlcjM4NDI0NDQy","avatar_url":"https://avatars2.githubusercontent.com/u/38424442?v=4","gravatar_id":"","url":"https://api.github.com/users/dbeguin","html_url":"https://github.com/dbeguin","followers_url":"https://api.github.com/users/dbeguin/followers","following_url":"https://api.github.com/users/dbeguin/following{/other_user}","gists_url":"https://api.github.com/users/dbeguin/gists{/gist_id}","starred_url":"https://api.github.com/users/dbeguin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbeguin/subscriptions","organizations_url":"https://api.github.com/users/dbeguin/orgs","repos_url":"https://api.github.com/users/dbeguin/repos","events_url":"https://api.github.com/users/dbeguin/events{/privacy}","received_events_url":"https://api.github.com/users/dbeguin/received_events","type":"User","site_admin":false},"body":"Task : https://www.odoo.com/web#id=33224&action=333&active_id=965&model=project.task&view_type=form&menu_id=4720\r\n\r\nThis PR is regrouping some main changes on mass mailing.\r\n- Added blacklist : Avoid sending mass mailing to blacklisted recipient \r\n  (blacklisted = email address that doens't want to receive mass mailing anymore)\r\n  Applies for following models through blacklist.mixin : \r\n    - crm.lead\r\n    - res.partner\r\n    - mail.mass_mailing.contact\r\n    - mail.channel.partner\r\n- Opt_out per mailing list instead of per mailing contact.\r\n- Replace opt_out by blacklist in crm.lead + res.partner models\r\n- Added 'ignored' state for mass_mailing. Ignored = blacklisted, opted-out, invalid email synthax. \r\n  Ignored email are not included into final statistics to avoid confusion.\r\n- Unsubscribe(d) pages migrated from website_mass_mailing to mass_mailing module\r\n  as thoses pages should work without having the website module installed\r\n- Added an auto-blacklist rule when the email bounced to much\r\n\r\n--\r\nI confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr\r\n","created_at":"2018-07-25T11:11:21Z","updated_at":"2018-08-08T12:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e11a2f51ef5c2e85e03d04b0e69d62bd3801d076","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":106173385,"node_id":"MDU6TGFiZWwxMDYxNzMzODU=","url":"https://api.github.com/repos/odoo/odoo/labels/RD","name":"RD","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/odoo/odoo/pulls/25966/commits","review_comments_url":"https://api.github.com/repos/odoo/odoo/pulls/25966/comments","review_comment_url":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/25966/comments","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/5f115c572ff7aef9ec2d4b6b3f68993b3010e02b","head":{"label":"odoo-dev:master-mass-mail-blacklist-opt-out-dbe","ref":"master-mass-mail-blacklist-opt-out-dbe","sha":"5f115c572ff7aef9ec2d4b6b3f68993b3010e02b","user":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":19853934,"node_id":"MDEwOlJlcG9zaXRvcnkxOTg1MzkzNA==","name":"odoo","full_name":"odoo-dev/odoo","owner":{"login":"odoo-dev","id":7466976,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0NjY5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/7466976?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo-dev","html_url":"https://github.com/odoo-dev","followers_url":"https://api.github.com/users/odoo-dev/followers","following_url":"https://api.github.com/users/odoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/odoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo-dev/subscriptions","organizations_url":"https://api.github.com/users/odoo-dev/orgs","repos_url":"https://api.github.com/users/odoo-dev/repos","events_url":"https://api.github.com/users/odoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/odoo-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo-dev/odoo","description":"RD Dev Repository","fork":true,"url":"https://api.github.com/repos/odoo-dev/odoo","forks_url":"https://api.github.com/repos/odoo-dev/odoo/forks","keys_url":"https://api.github.com/repos/odoo-dev/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo-dev/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo-dev/odoo/teams","hooks_url":"https://api.github.com/repos/odoo-dev/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo-dev/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo-dev/odoo/events","assignees_url":"https://api.github.com/repos/odoo-dev/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo-dev/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo-dev/odoo/tags","blobs_url":"https://api.github.com/repos/odoo-dev/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo-dev/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo-dev/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo-dev/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo-dev/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo-dev/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo-dev/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo-dev/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo-dev/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo-dev/odoo/subscription","commits_url":"https://api.github.com/repos/odoo-dev/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo-dev/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo-dev/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo-dev/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo-dev/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo-dev/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo-dev/odoo/merges","archive_url":"https://api.github.com/repos/odoo-dev/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo-dev/odoo/downloads","issues_url":"https://api.github.com/repos/odoo-dev/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo-dev/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo-dev/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo-dev/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo-dev/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo-dev/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo-dev/odoo/deployments","created_at":"2014-05-16T11:16:19Z","updated_at":"2018-06-19T11:04:23Z","pushed_at":"2018-08-08T12:49:33Z","git_url":"git://github.com/odoo-dev/odoo.git","ssh_url":"git@github.com:odoo-dev/odoo.git","clone_url":"https://github.com/odoo-dev/odoo.git","svn_url":"https://github.com/odoo-dev/odoo","homepage":"https://www.odoo.com","size":2127575,"stargazers_count":80,"watchers_count":80,"language":null,"has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":39,"open_issues":0,"watchers":80,"default_branch":"master"}},"base":{"label":"odoo:master","ref":"master","sha":"41eb02c2181d6a5d3eecf4ad33bc1a1ae9956fb9","user":{"login":"odoo","id":6368483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"repo":{"id":19745004,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc0NTAwNA==","name":"odoo","full_name":"odoo/odoo","owner":{"login":"odoo","id":6368483,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzNjg0ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/6368483?v=4","gravatar_id":"","url":"https://api.github.com/users/odoo","html_url":"https://github.com/odoo","followers_url":"https://api.github.com/users/odoo/followers","following_url":"https://api.github.com/users/odoo/following{/other_user}","gists_url":"https://api.github.com/users/odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odoo/subscriptions","organizations_url":"https://api.github.com/users/odoo/orgs","repos_url":"https://api.github.com/users/odoo/repos","events_url":"https://api.github.com/users/odoo/events{/privacy}","received_events_url":"https://api.github.com/users/odoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/odoo/odoo","description":"Odoo. Open Source Apps To Grow Your Business.","fork":false,"url":"https://api.github.com/repos/odoo/odoo","forks_url":"https://api.github.com/repos/odoo/odoo/forks","keys_url":"https://api.github.com/repos/odoo/odoo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/odoo/odoo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/odoo/odoo/teams","hooks_url":"https://api.github.com/repos/odoo/odoo/hooks","issue_events_url":"https://api.github.com/repos/odoo/odoo/issues/events{/number}","events_url":"https://api.github.com/repos/odoo/odoo/events","assignees_url":"https://api.github.com/repos/odoo/odoo/assignees{/user}","branches_url":"https://api.github.com/repos/odoo/odoo/branches{/branch}","tags_url":"https://api.github.com/repos/odoo/odoo/tags","blobs_url":"https://api.github.com/repos/odoo/odoo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/odoo/odoo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/odoo/odoo/git/refs{/sha}","trees_url":"https://api.github.com/repos/odoo/odoo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/odoo/odoo/statuses/{sha}","languages_url":"https://api.github.com/repos/odoo/odoo/languages","stargazers_url":"https://api.github.com/repos/odoo/odoo/stargazers","contributors_url":"https://api.github.com/repos/odoo/odoo/contributors","subscribers_url":"https://api.github.com/repos/odoo/odoo/subscribers","subscription_url":"https://api.github.com/repos/odoo/odoo/subscription","commits_url":"https://api.github.com/repos/odoo/odoo/commits{/sha}","git_commits_url":"https://api.github.com/repos/odoo/odoo/git/commits{/sha}","comments_url":"https://api.github.com/repos/odoo/odoo/comments{/number}","issue_comment_url":"https://api.github.com/repos/odoo/odoo/issues/comments{/number}","contents_url":"https://api.github.com/repos/odoo/odoo/contents/{+path}","compare_url":"https://api.github.com/repos/odoo/odoo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/odoo/odoo/merges","archive_url":"https://api.github.com/repos/odoo/odoo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/odoo/odoo/downloads","issues_url":"https://api.github.com/repos/odoo/odoo/issues{/number}","pulls_url":"https://api.github.com/repos/odoo/odoo/pulls{/number}","milestones_url":"https://api.github.com/repos/odoo/odoo/milestones{/number}","notifications_url":"https://api.github.com/repos/odoo/odoo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/odoo/odoo/labels{/name}","releases_url":"https://api.github.com/repos/odoo/odoo/releases{/id}","deployments_url":"https://api.github.com/repos/odoo/odoo/deployments","created_at":"2014-05-13T15:38:58Z","updated_at":"2018-08-08T12:37:23Z","pushed_at":"2018-08-08T12:44:57Z","git_url":"git://github.com/odoo/odoo.git","ssh_url":"git@github.com:odoo/odoo.git","clone_url":"https://github.com/odoo/odoo.git","svn_url":"https://github.com/odoo/odoo","homepage":"https://www.odoo.com","size":2105086,"stargazers_count":10613,"watchers_count":10613,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8584,"mirror_url":null,"archived":false,"open_issues_count":1712,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8584,"open_issues":1712,"watchers":10613,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/odoo/odoo/pulls/25966"},"html":{"href":"https://github.com/odoo/odoo/pull/25966"},"issue":{"href":"https://api.github.com/repos/odoo/odoo/issues/25966"},"comments":{"href":"https://api.github.com/repos/odoo/odoo/issues/25966/comments"},"review_comments":{"href":"https://api.github.com/repos/odoo/odoo/pulls/25966/comments"},"review_comment":{"href":"https://api.github.com/repos/odoo/odoo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/odoo/odoo/pulls/25966/commits"},"statuses":{"href":"https://api.github.com/repos/odoo/odoo/statuses/5f115c572ff7aef9ec2d4b6b3f68993b3010e02b"}},"author_association":"NONE"}}
{"actor":{"display_login":"tde-banana-odoo"}}