{"action":"created","comment":{"url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/comments/191866735","pull_request_review_id":124524933,"id":191866735,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MTg2NjczNQ==","diff_hunk":"@@ -455,12 +455,6 @@ export class AbpSelectCustomElement {\n     this.domElm.on('changed.bs.select', (e, clickedIndex, newValue, oldValue) => {\n       this.selectedValue = this.domElm.selectpicker('val');\n       let selection = this.findItems(this.collection, this.selectedValue, this.objectKey);\n-      if (selection.indexes) {\n-        this.domElm.selectpicker('val', selection.indexes);\n-      }\n-\n-      // refresh the bindable value/item\n-      this.selectedValue = selection.indexes;","path":"aurelia-bootstrap-select/src/abp-select.js","position":9,"original_position":9,"commit_id":"1070ac6f284b2dd5b919f2bb3af44c3048a51adb","original_commit_id":"1070ac6f284b2dd5b919f2bb3af44c3048a51adb","user":{"login":"Mobe91","id":3024176,"node_id":"MDQ6VXNlcjMwMjQxNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3024176?v=4","gravatar_id":"","url":"https://api.github.com/users/Mobe91","html_url":"https://github.com/Mobe91","followers_url":"https://api.github.com/users/Mobe91/followers","following_url":"https://api.github.com/users/Mobe91/following{/other_user}","gists_url":"https://api.github.com/users/Mobe91/gists{/gist_id}","starred_url":"https://api.github.com/users/Mobe91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mobe91/subscriptions","organizations_url":"https://api.github.com/users/Mobe91/orgs","repos_url":"https://api.github.com/users/Mobe91/repos","events_url":"https://api.github.com/users/Mobe91/events{/privacy}","received_events_url":"https://api.github.com/users/Mobe91/received_events","type":"User","site_admin":false},"body":"Without removing this code, `newValue` and `oldValue` would be the same in `selectedValueChanged` and the `selectedValue` would end up being an array in case of single selection. I did not understand exactly why this is the case.\r\n\r\nWith respect to the deleted code, the selected value is already updated in line 456. And by setting `this.selectedItems`, `this.selectedValue` will be updated again in `selectedItemChanged` as far as I can see.\r\n\r\nI have only tested this with single selection so you might want to test it with multiple selection.","created_at":"2018-05-30T18:04:15Z","updated_at":"2018-05-30T18:04:15Z","html_url":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins/pull/52#discussion_r191866735","pull_request_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/52","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/comments/191866735"},"html":{"href":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins/pull/52#discussion_r191866735"},"pull_request":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/52"}},"in_reply_to_id":191842135},"pull_request":{"url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/52","id":191509680,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNTA5Njgw","html_url":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins/pull/52","diff_url":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins/pull/52.diff","patch_url":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins/pull/52.patch","issue_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/issues/52","number":52,"state":"open","locked":false,"title":"fix(select) issue #46 - add compatibility with bootstrap-select 1.13.1","user":{"login":"Mobe91","id":3024176,"node_id":"MDQ6VXNlcjMwMjQxNzY=","avatar_url":"https://avatars2.githubusercontent.com/u/3024176?v=4","gravatar_id":"","url":"https://api.github.com/users/Mobe91","html_url":"https://github.com/Mobe91","followers_url":"https://api.github.com/users/Mobe91/followers","following_url":"https://api.github.com/users/Mobe91/following{/other_user}","gists_url":"https://api.github.com/users/Mobe91/gists{/gist_id}","starred_url":"https://api.github.com/users/Mobe91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mobe91/subscriptions","organizations_url":"https://api.github.com/users/Mobe91/orgs","repos_url":"https://api.github.com/users/Mobe91/repos","events_url":"https://api.github.com/users/Mobe91/events{/privacy}","received_events_url":"https://api.github.com/users/Mobe91/received_events","type":"User","site_admin":false},"body":"This PR implements compatibility with the latest bootstrap-select 1.13.1.","created_at":"2018-05-30T16:22:11Z","updated_at":"2018-05-30T18:04:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d305e8ca57415deeaa7c2ccabc443cc8b0968073","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/52/commits","review_comments_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/52/comments","review_comment_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/issues/52/comments","statuses_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/statuses/1070ac6f284b2dd5b919f2bb3af44c3048a51adb","head":{"label":"ordami:issues/46","ref":"issues/46","sha":"1070ac6f284b2dd5b919f2bb3af44c3048a51adb","user":{"login":"ordami","id":36619611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjE5NjEx","avatar_url":"https://avatars3.githubusercontent.com/u/36619611?v=4","gravatar_id":"","url":"https://api.github.com/users/ordami","html_url":"https://github.com/ordami","followers_url":"https://api.github.com/users/ordami/followers","following_url":"https://api.github.com/users/ordami/following{/other_user}","gists_url":"https://api.github.com/users/ordami/gists{/gist_id}","starred_url":"https://api.github.com/users/ordami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordami/subscriptions","organizations_url":"https://api.github.com/users/ordami/orgs","repos_url":"https://api.github.com/users/ordami/repos","events_url":"https://api.github.com/users/ordami/events{/privacy}","received_events_url":"https://api.github.com/users/ordami/received_events","type":"Organization","site_admin":false},"repo":{"id":122033151,"node_id":"MDEwOlJlcG9zaXRvcnkxMjIwMzMxNTE=","name":"Aurelia-Bootstrap-Plugins","full_name":"ordami/Aurelia-Bootstrap-Plugins","owner":{"login":"ordami","id":36619611,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjE5NjEx","avatar_url":"https://avatars3.githubusercontent.com/u/36619611?v=4","gravatar_id":"","url":"https://api.github.com/users/ordami","html_url":"https://github.com/ordami","followers_url":"https://api.github.com/users/ordami/followers","following_url":"https://api.github.com/users/ordami/following{/other_user}","gists_url":"https://api.github.com/users/ordami/gists{/gist_id}","starred_url":"https://api.github.com/users/ordami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ordami/subscriptions","organizations_url":"https://api.github.com/users/ordami/orgs","repos_url":"https://api.github.com/users/ordami/repos","events_url":"https://api.github.com/users/ordami/events{/privacy}","received_events_url":"https://api.github.com/users/ordami/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ordami/Aurelia-Bootstrap-Plugins","description":"Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons","fork":true,"url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins","forks_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/forks","keys_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/teams","hooks_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/hooks","issue_events_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/issues/events{/number}","events_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/events","assignees_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/assignees{/user}","branches_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/branches{/branch}","tags_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/tags","blobs_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/languages","stargazers_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/stargazers","contributors_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/contributors","subscribers_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/subscribers","subscription_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/subscription","commits_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/contents/{+path}","compare_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/merges","archive_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/downloads","issues_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/issues{/number}","pulls_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/labels{/name}","releases_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/releases{/id}","deployments_url":"https://api.github.com/repos/ordami/Aurelia-Bootstrap-Plugins/deployments","created_at":"2018-02-19T08:01:31Z","updated_at":"2018-02-19T08:01:33Z","pushed_at":"2018-05-30T16:23:34Z","git_url":"git://github.com/ordami/Aurelia-Bootstrap-Plugins.git","ssh_url":"git@github.com:ordami/Aurelia-Bootstrap-Plugins.git","clone_url":"https://github.com/ordami/Aurelia-Bootstrap-Plugins.git","svn_url":"https://github.com/ordami/Aurelia-Bootstrap-Plugins","homepage":"https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins","size":3338,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ghiscoding:master","ref":"master","sha":"029e067954905b2f18be936b472c72dc30cc666c","user":{"login":"ghiscoding","id":643976,"node_id":"MDQ6VXNlcjY0Mzk3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/643976?v=4","gravatar_id":"","url":"https://api.github.com/users/ghiscoding","html_url":"https://github.com/ghiscoding","followers_url":"https://api.github.com/users/ghiscoding/followers","following_url":"https://api.github.com/users/ghiscoding/following{/other_user}","gists_url":"https://api.github.com/users/ghiscoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ghiscoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghiscoding/subscriptions","organizations_url":"https://api.github.com/users/ghiscoding/orgs","repos_url":"https://api.github.com/users/ghiscoding/repos","events_url":"https://api.github.com/users/ghiscoding/events{/privacy}","received_events_url":"https://api.github.com/users/ghiscoding/received_events","type":"User","site_admin":false},"repo":{"id":83002237,"node_id":"MDEwOlJlcG9zaXRvcnk4MzAwMjIzNw==","name":"Aurelia-Bootstrap-Plugins","full_name":"ghiscoding/Aurelia-Bootstrap-Plugins","owner":{"login":"ghiscoding","id":643976,"node_id":"MDQ6VXNlcjY0Mzk3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/643976?v=4","gravatar_id":"","url":"https://api.github.com/users/ghiscoding","html_url":"https://github.com/ghiscoding","followers_url":"https://api.github.com/users/ghiscoding/followers","following_url":"https://api.github.com/users/ghiscoding/following{/other_user}","gists_url":"https://api.github.com/users/ghiscoding/gists{/gist_id}","starred_url":"https://api.github.com/users/ghiscoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghiscoding/subscriptions","organizations_url":"https://api.github.com/users/ghiscoding/orgs","repos_url":"https://api.github.com/users/ghiscoding/repos","events_url":"https://api.github.com/users/ghiscoding/events{/privacy}","received_events_url":"https://api.github.com/users/ghiscoding/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins","description":"Aurelia-Bootstrap-Plugins are Custom Elements to bridge with a set of 3rd party Bootstrap addons","fork":false,"url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins","forks_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/forks","keys_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/teams","hooks_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/hooks","issue_events_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/issues/events{/number}","events_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/events","assignees_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/assignees{/user}","branches_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/branches{/branch}","tags_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/tags","blobs_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/statuses/{sha}","languages_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/languages","stargazers_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/stargazers","contributors_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/contributors","subscribers_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/subscribers","subscription_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/subscription","commits_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/contents/{+path}","compare_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/merges","archive_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/downloads","issues_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/issues{/number}","pulls_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls{/number}","milestones_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/milestones{/number}","notifications_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/labels{/name}","releases_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/releases{/id}","deployments_url":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/deployments","created_at":"2017-02-24T04:45:57Z","updated_at":"2018-05-17T09:12:12Z","pushed_at":"2018-05-30T16:23:35Z","git_url":"git://github.com/ghiscoding/Aurelia-Bootstrap-Plugins.git","ssh_url":"git@github.com:ghiscoding/Aurelia-Bootstrap-Plugins.git","clone_url":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins.git","svn_url":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins","homepage":"https://ghiscoding.github.io/Aurelia-Bootstrap-Plugins","size":3612,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":3,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/52"},"html":{"href":"https://github.com/ghiscoding/Aurelia-Bootstrap-Plugins/pull/52"},"issue":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/issues/52"},"comments":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/ghiscoding/Aurelia-Bootstrap-Plugins/statuses/1070ac6f284b2dd5b919f2bb3af44c3048a51adb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mobe91"}}