{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/3678","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/3678/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/3678/comments","events_url":"https://api.github.com/repos/istio/istio/issues/3678/events","html_url":"https://github.com/istio/istio/pull/3678","id":299224963,"number":3678,"title":"No more dep in makefile/build - long live dep through vendor/","user":{"login":"ldemailly","id":3664595,"avatar_url":"https://avatars2.githubusercontent.com/u/3664595?v=4","gravatar_id":"","url":"https://api.github.com/users/ldemailly","html_url":"https://github.com/ldemailly","followers_url":"https://api.github.com/users/ldemailly/followers","following_url":"https://api.github.com/users/ldemailly/following{/other_user}","gists_url":"https://api.github.com/users/ldemailly/gists{/gist_id}","starred_url":"https://api.github.com/users/ldemailly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldemailly/subscriptions","organizations_url":"https://api.github.com/users/ldemailly/orgs","repos_url":"https://api.github.com/users/ldemailly/repos","events_url":"https://api.github.com/users/ldemailly/events{/privacy}","received_events_url":"https://api.github.com/users/ldemailly/received_events","type":"User","site_admin":false},"labels":[{"id":659652351,"url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":660556986,"url":"https://api.github.com/repos/istio/istio/labels/lgtm","name":"lgtm","color":"bfdadc","default":false}],"state":"closed","locked":false,"assignee":{"login":"guptasu","id":11448595,"avatar_url":"https://avatars3.githubusercontent.com/u/11448595?v=4","gravatar_id":"","url":"https://api.github.com/users/guptasu","html_url":"https://github.com/guptasu","followers_url":"https://api.github.com/users/guptasu/followers","following_url":"https://api.github.com/users/guptasu/following{/other_user}","gists_url":"https://api.github.com/users/guptasu/gists{/gist_id}","starred_url":"https://api.github.com/users/guptasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guptasu/subscriptions","organizations_url":"https://api.github.com/users/guptasu/orgs","repos_url":"https://api.github.com/users/guptasu/repos","events_url":"https://api.github.com/users/guptasu/events{/privacy}","received_events_url":"https://api.github.com/users/guptasu/received_events","type":"User","site_admin":false},"assignees":[{"login":"guptasu","id":11448595,"avatar_url":"https://avatars3.githubusercontent.com/u/11448595?v=4","gravatar_id":"","url":"https://api.github.com/users/guptasu","html_url":"https://github.com/guptasu","followers_url":"https://api.github.com/users/guptasu/followers","following_url":"https://api.github.com/users/guptasu/following{/other_user}","gists_url":"https://api.github.com/users/guptasu/gists{/gist_id}","starred_url":"https://api.github.com/users/guptasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guptasu/subscriptions","organizations_url":"https://api.github.com/users/guptasu/orgs","repos_url":"https://api.github.com/users/guptasu/repos","events_url":"https://api.github.com/users/guptasu/events{/privacy}","received_events_url":"https://api.github.com/users/guptasu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2018-02-22T05:17:22Z","updated_at":"2018-04-24T00:50:38Z","closed_at":"2018-02-22T07:34:03Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/3678","html_url":"https://github.com/istio/istio/pull/3678","diff_url":"https://github.com/istio/istio/pull/3678.diff","patch_url":"https://github.com/istio/istio/pull/3678.patch"},"body":"Follow up on having vendor/ checked in (as submodule)\r\n\r\nWe don't need to run a bunch of dep commands anymore, or build/find dep for that matter\r\n\r\nThis should shave some time from the build, not counting the simpler Makefile and script\r\n\r\nWe can later make new targets to automate\r\nhttps://github.com/istio/istio/wiki/Vendor-FAQ#how-do-i-add--change-a-dependency\r\n(for instance we can follow up with #3679)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/383767503","html_url":"https://github.com/istio/istio/pull/3678#issuecomment-383767503","issue_url":"https://api.github.com/repos/istio/istio/issues/3678","id":383767503,"user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars3.githubusercontent.com/u/6493296?v=4","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"created_at":"2018-04-24T00:50:38Z","updated_at":"2018-04-24T00:50:38Z","author_association":"CONTRIBUTOR","body":"@ldemailly I was just chatting with @costinm and he's thinking that this PR incorrectly removed the `--update` from the `depend.update` target. I'm going to put a PR together to revert that target. "}}
{"actor":{"display_login":"nmittler"}}