{"action":"created","comment":{"url":"https://api.github.com/repos/lammps/lammps/pulls/comments/215602109","pull_request_review_id":152900093,"id":215602109,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTYwMjEwOQ==","diff_hunk":"@@ -1408,7 +1408,7 @@ void Neighbor::init_topology()\n void Neighbor::print_pairwise_info()\n {\n   int i,m;\n-  char str[128];\n+  char str[256];","path":"src/neighbor.cpp","position":5,"original_position":5,"commit_id":"ca04e8f31c62224dc8b01d19d229d21bf0cbe89a","original_commit_id":"ca04e8f31c62224dc8b01d19d229d21bf0cbe89a","user":{"login":"rbberger","id":2828630,"node_id":"MDQ6VXNlcjI4Mjg2MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/2828630?v=4","gravatar_id":"","url":"https://api.github.com/users/rbberger","html_url":"https://github.com/rbberger","followers_url":"https://api.github.com/users/rbberger/followers","following_url":"https://api.github.com/users/rbberger/following{/other_user}","gists_url":"https://api.github.com/users/rbberger/gists{/gist_id}","starred_url":"https://api.github.com/users/rbberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbberger/subscriptions","organizations_url":"https://api.github.com/users/rbberger/orgs","repos_url":"https://api.github.com/users/rbberger/repos","events_url":"https://api.github.com/users/rbberger/events{/privacy}","received_events_url":"https://api.github.com/users/rbberger/received_events","type":"User","site_admin":false},"body":"missing the changes of `sprintf` to `snprintf` in this file.","created_at":"2018-09-06T12:14:14Z","updated_at":"2018-09-06T12:14:25Z","html_url":"https://github.com/lammps/lammps/pull/1108#discussion_r215602109","pull_request_url":"https://api.github.com/repos/lammps/lammps/pulls/1108","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lammps/lammps/pulls/comments/215602109"},"html":{"href":"https://github.com/lammps/lammps/pull/1108#discussion_r215602109"},"pull_request":{"href":"https://api.github.com/repos/lammps/lammps/pulls/1108"}}},"pull_request":{"url":"https://api.github.com/repos/lammps/lammps/pulls/1108","id":213514977,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTE0OTc3","html_url":"https://github.com/lammps/lammps/pull/1108","diff_url":"https://github.com/lammps/lammps/pull/1108.diff","patch_url":"https://github.com/lammps/lammps/pull/1108.patch","issue_url":"https://api.github.com/repos/lammps/lammps/issues/1108","number":1108,"state":"open","locked":false,"title":"Avoid more buffer overflows due to using snprintf() on fixed size buffers","user":{"login":"akohlmey","id":289251,"node_id":"MDQ6VXNlcjI4OTI1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/289251?v=4","gravatar_id":"","url":"https://api.github.com/users/akohlmey","html_url":"https://github.com/akohlmey","followers_url":"https://api.github.com/users/akohlmey/followers","following_url":"https://api.github.com/users/akohlmey/following{/other_user}","gists_url":"https://api.github.com/users/akohlmey/gists{/gist_id}","starred_url":"https://api.github.com/users/akohlmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akohlmey/subscriptions","organizations_url":"https://api.github.com/users/akohlmey/orgs","repos_url":"https://api.github.com/users/akohlmey/repos","events_url":"https://api.github.com/users/akohlmey/events{/privacy}","received_events_url":"https://api.github.com/users/akohlmey/received_events","type":"User","site_admin":false},"body":"\r\n## Purpose\r\n\r\nThis pull request addresses more issues like in #1105 through using snprintf() when printing unchecked strings to fixed size buffers.\r\n\r\n## Author(s)\r\n\r\nIndonesia LAMMPS Tutorial 2018\r\n\r\n## Backward Compatibility\r\n\r\nYes. \r\n\r\n## Implementation Notes\r\n\r\nWe used to avoid snprintf() because it was not portable to Windows, but since VC++ has this since the 2015 version, it is less of a problem now.\r\n\r\n## Post Submission Checklist\r\n\r\n_Please check the fields below as they are completed_\r\n- [ ] The feature or features in this pull request is complete\r\n- [x] The source code follows the LAMMPS formatting guidelines\r\n\r\n","created_at":"2018-09-06T07:05:46Z","updated_at":"2018-09-06T12:14:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e3248880881f82ee0e40742a49f0b801e11ebad","assignee":{"login":"akohlmey","id":289251,"node_id":"MDQ6VXNlcjI4OTI1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/289251?v=4","gravatar_id":"","url":"https://api.github.com/users/akohlmey","html_url":"https://github.com/akohlmey","followers_url":"https://api.github.com/users/akohlmey/followers","following_url":"https://api.github.com/users/akohlmey/following{/other_user}","gists_url":"https://api.github.com/users/akohlmey/gists{/gist_id}","starred_url":"https://api.github.com/users/akohlmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akohlmey/subscriptions","organizations_url":"https://api.github.com/users/akohlmey/orgs","repos_url":"https://api.github.com/users/akohlmey/repos","events_url":"https://api.github.com/users/akohlmey/events{/privacy}","received_events_url":"https://api.github.com/users/akohlmey/received_events","type":"User","site_admin":false},"assignees":[{"login":"akohlmey","id":289251,"node_id":"MDQ6VXNlcjI4OTI1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/289251?v=4","gravatar_id":"","url":"https://api.github.com/users/akohlmey","html_url":"https://github.com/akohlmey","followers_url":"https://api.github.com/users/akohlmey/followers","following_url":"https://api.github.com/users/akohlmey/following{/other_user}","gists_url":"https://api.github.com/users/akohlmey/gists{/gist_id}","starred_url":"https://api.github.com/users/akohlmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akohlmey/subscriptions","organizations_url":"https://api.github.com/users/akohlmey/orgs","repos_url":"https://api.github.com/users/akohlmey/repos","events_url":"https://api.github.com/users/akohlmey/events{/privacy}","received_events_url":"https://api.github.com/users/akohlmey/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":389534152,"node_id":"MDU6TGFiZWwzODk1MzQxNTI=","url":"https://api.github.com/repos/lammps/lammps/labels/bugfix","name":"bugfix","color":"bfdadc","default":false}],"milestone":{"url":"https://api.github.com/repos/lammps/lammps/milestones/2","html_url":"https://github.com/lammps/lammps/milestone/2","labels_url":"https://api.github.com/repos/lammps/lammps/milestones/2/labels","id":3499619,"node_id":"MDk6TWlsZXN0b25lMzQ5OTYxOQ==","number":2,"title":"Stable Release Fall 2018","description":"Major goal for this release is the improvement of the CMake support based on freedback for the stable release 22 Aug 2018 and internal requirements.\r\nPlus the usual feature contributions and updates.","creator":{"login":"akohlmey","id":289251,"node_id":"MDQ6VXNlcjI4OTI1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/289251?v=4","gravatar_id":"","url":"https://api.github.com/users/akohlmey","html_url":"https://github.com/akohlmey","followers_url":"https://api.github.com/users/akohlmey/followers","following_url":"https://api.github.com/users/akohlmey/following{/other_user}","gists_url":"https://api.github.com/users/akohlmey/gists{/gist_id}","starred_url":"https://api.github.com/users/akohlmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akohlmey/subscriptions","organizations_url":"https://api.github.com/users/akohlmey/orgs","repos_url":"https://api.github.com/users/akohlmey/repos","events_url":"https://api.github.com/users/akohlmey/events{/privacy}","received_events_url":"https://api.github.com/users/akohlmey/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":14,"state":"open","created_at":"2018-07-16T13:00:55Z","updated_at":"2018-09-06T07:05:46Z","due_on":"2018-11-16T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/lammps/lammps/pulls/1108/commits","review_comments_url":"https://api.github.com/repos/lammps/lammps/pulls/1108/comments","review_comment_url":"https://api.github.com/repos/lammps/lammps/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lammps/lammps/issues/1108/comments","statuses_url":"https://api.github.com/repos/lammps/lammps/statuses/ca04e8f31c62224dc8b01d19d229d21bf0cbe89a","head":{"label":"akohlmey:fix-sprintf-buffer-overflows","ref":"fix-sprintf-buffer-overflows","sha":"ca04e8f31c62224dc8b01d19d229d21bf0cbe89a","user":{"login":"akohlmey","id":289251,"node_id":"MDQ6VXNlcjI4OTI1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/289251?v=4","gravatar_id":"","url":"https://api.github.com/users/akohlmey","html_url":"https://github.com/akohlmey","followers_url":"https://api.github.com/users/akohlmey/followers","following_url":"https://api.github.com/users/akohlmey/following{/other_user}","gists_url":"https://api.github.com/users/akohlmey/gists{/gist_id}","starred_url":"https://api.github.com/users/akohlmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akohlmey/subscriptions","organizations_url":"https://api.github.com/users/akohlmey/orgs","repos_url":"https://api.github.com/users/akohlmey/repos","events_url":"https://api.github.com/users/akohlmey/events{/privacy}","received_events_url":"https://api.github.com/users/akohlmey/received_events","type":"User","site_admin":false},"repo":{"id":41331387,"node_id":"MDEwOlJlcG9zaXRvcnk0MTMzMTM4Nw==","name":"lammps","full_name":"akohlmey/lammps","owner":{"login":"akohlmey","id":289251,"node_id":"MDQ6VXNlcjI4OTI1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/289251?v=4","gravatar_id":"","url":"https://api.github.com/users/akohlmey","html_url":"https://github.com/akohlmey","followers_url":"https://api.github.com/users/akohlmey/followers","following_url":"https://api.github.com/users/akohlmey/following{/other_user}","gists_url":"https://api.github.com/users/akohlmey/gists{/gist_id}","starred_url":"https://api.github.com/users/akohlmey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akohlmey/subscriptions","organizations_url":"https://api.github.com/users/akohlmey/orgs","repos_url":"https://api.github.com/users/akohlmey/repos","events_url":"https://api.github.com/users/akohlmey/events{/privacy}","received_events_url":"https://api.github.com/users/akohlmey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akohlmey/lammps","description":"Axel Kohlmeyer's development repository of the LAMMPS MD software package","fork":true,"url":"https://api.github.com/repos/akohlmey/lammps","forks_url":"https://api.github.com/repos/akohlmey/lammps/forks","keys_url":"https://api.github.com/repos/akohlmey/lammps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akohlmey/lammps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akohlmey/lammps/teams","hooks_url":"https://api.github.com/repos/akohlmey/lammps/hooks","issue_events_url":"https://api.github.com/repos/akohlmey/lammps/issues/events{/number}","events_url":"https://api.github.com/repos/akohlmey/lammps/events","assignees_url":"https://api.github.com/repos/akohlmey/lammps/assignees{/user}","branches_url":"https://api.github.com/repos/akohlmey/lammps/branches{/branch}","tags_url":"https://api.github.com/repos/akohlmey/lammps/tags","blobs_url":"https://api.github.com/repos/akohlmey/lammps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akohlmey/lammps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akohlmey/lammps/git/refs{/sha}","trees_url":"https://api.github.com/repos/akohlmey/lammps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akohlmey/lammps/statuses/{sha}","languages_url":"https://api.github.com/repos/akohlmey/lammps/languages","stargazers_url":"https://api.github.com/repos/akohlmey/lammps/stargazers","contributors_url":"https://api.github.com/repos/akohlmey/lammps/contributors","subscribers_url":"https://api.github.com/repos/akohlmey/lammps/subscribers","subscription_url":"https://api.github.com/repos/akohlmey/lammps/subscription","commits_url":"https://api.github.com/repos/akohlmey/lammps/commits{/sha}","git_commits_url":"https://api.github.com/repos/akohlmey/lammps/git/commits{/sha}","comments_url":"https://api.github.com/repos/akohlmey/lammps/comments{/number}","issue_comment_url":"https://api.github.com/repos/akohlmey/lammps/issues/comments{/number}","contents_url":"https://api.github.com/repos/akohlmey/lammps/contents/{+path}","compare_url":"https://api.github.com/repos/akohlmey/lammps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akohlmey/lammps/merges","archive_url":"https://api.github.com/repos/akohlmey/lammps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akohlmey/lammps/downloads","issues_url":"https://api.github.com/repos/akohlmey/lammps/issues{/number}","pulls_url":"https://api.github.com/repos/akohlmey/lammps/pulls{/number}","milestones_url":"https://api.github.com/repos/akohlmey/lammps/milestones{/number}","notifications_url":"https://api.github.com/repos/akohlmey/lammps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akohlmey/lammps/labels{/name}","releases_url":"https://api.github.com/repos/akohlmey/lammps/releases{/id}","deployments_url":"https://api.github.com/repos/akohlmey/lammps/deployments","created_at":"2015-08-24T23:05:18Z","updated_at":"2018-09-05T22:11:31Z","pushed_at":"2018-09-06T07:00:19Z","git_url":"git://github.com/akohlmey/lammps.git","ssh_url":"git@github.com:akohlmey/lammps.git","clone_url":"https://github.com/akohlmey/lammps.git","svn_url":"https://github.com/akohlmey/lammps","homepage":"http://lammps.sandia.gov","size":454285,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"lammps:master","ref":"master","sha":"0b951840f20752235e02730160877dce611b1255","user":{"login":"lammps","id":5199009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTkwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5199009?v=4","gravatar_id":"","url":"https://api.github.com/users/lammps","html_url":"https://github.com/lammps","followers_url":"https://api.github.com/users/lammps/followers","following_url":"https://api.github.com/users/lammps/following{/other_user}","gists_url":"https://api.github.com/users/lammps/gists{/gist_id}","starred_url":"https://api.github.com/users/lammps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lammps/subscriptions","organizations_url":"https://api.github.com/users/lammps/orgs","repos_url":"https://api.github.com/users/lammps/repos","events_url":"https://api.github.com/users/lammps/events{/privacy}","received_events_url":"https://api.github.com/users/lammps/received_events","type":"Organization","site_admin":false},"repo":{"id":12007030,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwNzAzMA==","name":"lammps","full_name":"lammps/lammps","owner":{"login":"lammps","id":5199009,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxOTkwMDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5199009?v=4","gravatar_id":"","url":"https://api.github.com/users/lammps","html_url":"https://github.com/lammps","followers_url":"https://api.github.com/users/lammps/followers","following_url":"https://api.github.com/users/lammps/following{/other_user}","gists_url":"https://api.github.com/users/lammps/gists{/gist_id}","starred_url":"https://api.github.com/users/lammps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lammps/subscriptions","organizations_url":"https://api.github.com/users/lammps/orgs","repos_url":"https://api.github.com/users/lammps/repos","events_url":"https://api.github.com/users/lammps/events{/privacy}","received_events_url":"https://api.github.com/users/lammps/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lammps/lammps","description":"Public development project of the LAMMPS MD software package  ","fork":false,"url":"https://api.github.com/repos/lammps/lammps","forks_url":"https://api.github.com/repos/lammps/lammps/forks","keys_url":"https://api.github.com/repos/lammps/lammps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lammps/lammps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lammps/lammps/teams","hooks_url":"https://api.github.com/repos/lammps/lammps/hooks","issue_events_url":"https://api.github.com/repos/lammps/lammps/issues/events{/number}","events_url":"https://api.github.com/repos/lammps/lammps/events","assignees_url":"https://api.github.com/repos/lammps/lammps/assignees{/user}","branches_url":"https://api.github.com/repos/lammps/lammps/branches{/branch}","tags_url":"https://api.github.com/repos/lammps/lammps/tags","blobs_url":"https://api.github.com/repos/lammps/lammps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lammps/lammps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lammps/lammps/git/refs{/sha}","trees_url":"https://api.github.com/repos/lammps/lammps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lammps/lammps/statuses/{sha}","languages_url":"https://api.github.com/repos/lammps/lammps/languages","stargazers_url":"https://api.github.com/repos/lammps/lammps/stargazers","contributors_url":"https://api.github.com/repos/lammps/lammps/contributors","subscribers_url":"https://api.github.com/repos/lammps/lammps/subscribers","subscription_url":"https://api.github.com/repos/lammps/lammps/subscription","commits_url":"https://api.github.com/repos/lammps/lammps/commits{/sha}","git_commits_url":"https://api.github.com/repos/lammps/lammps/git/commits{/sha}","comments_url":"https://api.github.com/repos/lammps/lammps/comments{/number}","issue_comment_url":"https://api.github.com/repos/lammps/lammps/issues/comments{/number}","contents_url":"https://api.github.com/repos/lammps/lammps/contents/{+path}","compare_url":"https://api.github.com/repos/lammps/lammps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lammps/lammps/merges","archive_url":"https://api.github.com/repos/lammps/lammps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lammps/lammps/downloads","issues_url":"https://api.github.com/repos/lammps/lammps/issues{/number}","pulls_url":"https://api.github.com/repos/lammps/lammps/pulls{/number}","milestones_url":"https://api.github.com/repos/lammps/lammps/milestones{/number}","notifications_url":"https://api.github.com/repos/lammps/lammps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lammps/lammps/labels{/name}","releases_url":"https://api.github.com/repos/lammps/lammps/releases{/id}","deployments_url":"https://api.github.com/repos/lammps/lammps/deployments","created_at":"2013-08-09T17:45:11Z","updated_at":"2018-09-06T10:53:26Z","pushed_at":"2018-09-06T07:05:47Z","git_url":"git://github.com/lammps/lammps.git","ssh_url":"git@github.com:lammps/lammps.git","clone_url":"https://github.com/lammps/lammps.git","svn_url":"https://github.com/lammps/lammps","homepage":"http://lammps.sandia.gov","size":374648,"stargazers_count":353,"watchers_count":353,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":493,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":493,"open_issues":65,"watchers":353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lammps/lammps/pulls/1108"},"html":{"href":"https://github.com/lammps/lammps/pull/1108"},"issue":{"href":"https://api.github.com/repos/lammps/lammps/issues/1108"},"comments":{"href":"https://api.github.com/repos/lammps/lammps/issues/1108/comments"},"review_comments":{"href":"https://api.github.com/repos/lammps/lammps/pulls/1108/comments"},"review_comment":{"href":"https://api.github.com/repos/lammps/lammps/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lammps/lammps/pulls/1108/commits"},"statuses":{"href":"https://api.github.com/repos/lammps/lammps/statuses/ca04e8f31c62224dc8b01d19d229d21bf0cbe89a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rbberger"}}