{"action":"closed","issue":{"url":"https://api.github.com/repos/CEED/Laghos/issues/22","repository_url":"https://api.github.com/repos/CEED/Laghos","labels_url":"https://api.github.com/repos/CEED/Laghos/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/CEED/Laghos/issues/22/comments","events_url":"https://api.github.com/repos/CEED/Laghos/issues/22/events","html_url":"https://github.com/CEED/Laghos/issues/22","id":357425473,"node_id":"MDU6SXNzdWUzNTc0MjU0NzM=","number":22,"title":"Incorrect assertion in laghos_assembly.cpp","user":{"login":"ilagunap","id":1209429,"node_id":"MDQ6VXNlcjEyMDk0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/1209429?v=4","gravatar_id":"","url":"https://api.github.com/users/ilagunap","html_url":"https://github.com/ilagunap","followers_url":"https://api.github.com/users/ilagunap/followers","following_url":"https://api.github.com/users/ilagunap/following{/other_user}","gists_url":"https://api.github.com/users/ilagunap/gists{/gist_id}","starred_url":"https://api.github.com/users/ilagunap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilagunap/subscriptions","organizations_url":"https://api.github.com/users/ilagunap/orgs","repos_url":"https://api.github.com/users/ilagunap/repos","events_url":"https://api.github.com/users/ilagunap/events{/privacy}","received_events_url":"https://api.github.com/users/ilagunap/received_events","type":"User","site_admin":false},"labels":[{"id":635441060,"node_id":"MDU6TGFiZWw2MzU0NDEwNjA=","url":"https://api.github.com/repos/CEED/Laghos/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"closed","locked":false,"assignee":{"login":"camierjs","id":20000517,"node_id":"MDQ6VXNlcjIwMDAwNTE3","avatar_url":"https://avatars1.githubusercontent.com/u/20000517?v=4","gravatar_id":"","url":"https://api.github.com/users/camierjs","html_url":"https://github.com/camierjs","followers_url":"https://api.github.com/users/camierjs/followers","following_url":"https://api.github.com/users/camierjs/following{/other_user}","gists_url":"https://api.github.com/users/camierjs/gists{/gist_id}","starred_url":"https://api.github.com/users/camierjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camierjs/subscriptions","organizations_url":"https://api.github.com/users/camierjs/orgs","repos_url":"https://api.github.com/users/camierjs/repos","events_url":"https://api.github.com/users/camierjs/events{/privacy}","received_events_url":"https://api.github.com/users/camierjs/received_events","type":"User","site_admin":false},"assignees":[{"login":"camierjs","id":20000517,"node_id":"MDQ6VXNlcjIwMDAwNTE3","avatar_url":"https://avatars1.githubusercontent.com/u/20000517?v=4","gravatar_id":"","url":"https://api.github.com/users/camierjs","html_url":"https://github.com/camierjs","followers_url":"https://api.github.com/users/camierjs/followers","following_url":"https://api.github.com/users/camierjs/following{/other_user}","gists_url":"https://api.github.com/users/camierjs/gists{/gist_id}","starred_url":"https://api.github.com/users/camierjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camierjs/subscriptions","organizations_url":"https://api.github.com/users/camierjs/orgs","repos_url":"https://api.github.com/users/camierjs/repos","events_url":"https://api.github.com/users/camierjs/events{/privacy}","received_events_url":"https://api.github.com/users/camierjs/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-05T22:21:02Z","updated_at":"2018-10-31T19:48:17Z","closed_at":"2018-10-31T19:48:17Z","author_association":"NONE","body":"On laghos_assembly.cpp (line 124 in raja-dev branch):\r\n\r\nAn array is compared against an integer. Compiling with Clang reports this error:\r\n\r\n```\r\n/usr/workspace/wsa/laguna/laghos_cuda/laghos/Laghos/laghos_assembly.cpp:124:20: \r\nerror: ordered comparison between pointer and zero ('int *' and 'int')\r\n   assert(ess_tdofs>0);\r\n```\r\n\r\nI believe the solution is `assert(ess_tdofs.Size()>0);`"}}
{"actor":{"display_login":"tzanio"}}