{"action":"created","issue":{"url":"https://api.github.com/repos/patternfly/patternfly-next/issues/391","repository_url":"https://api.github.com/repos/patternfly/patternfly-next","labels_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/391/labels{/name}","comments_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/391/comments","events_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/391/events","html_url":"https://github.com/patternfly/patternfly-next/pull/391","id":334534252,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2NDgyNDIw","number":391,"title":"feat(toolbar layout): implements toolbar layout","user":{"login":"mattnolting","id":5385435,"node_id":"MDQ6VXNlcjUzODU0MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5385435?v=4","gravatar_id":"","url":"https://api.github.com/users/mattnolting","html_url":"https://github.com/mattnolting","followers_url":"https://api.github.com/users/mattnolting/followers","following_url":"https://api.github.com/users/mattnolting/following{/other_user}","gists_url":"https://api.github.com/users/mattnolting/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnolting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnolting/subscriptions","organizations_url":"https://api.github.com/users/mattnolting/orgs","repos_url":"https://api.github.com/users/mattnolting/repos","events_url":"https://api.github.com/users/mattnolting/events{/privacy}","received_events_url":"https://api.github.com/users/mattnolting/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-21T15:00:20Z","updated_at":"2018-06-26T20:55:47Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/patternfly/patternfly-next/pulls/391","html_url":"https://github.com/patternfly/patternfly-next/pull/391","diff_url":"https://github.com/patternfly/patternfly-next/pull/391.diff","patch_url":"https://github.com/patternfly/patternfly-next/pull/391.patch"},"body":"closes #136 \r\n\r\nWorking PR\r\nBased on past experience, relying only on flexbox for responsive layout produces suboptimal results. Therefore, I included a few responsive modifiers to better control layout. \r\n\r\nQuestions:\r\n- Should the title of this component be genericized? In talking with @jgiardino about accessibility compliance, toolbars are limited to buttons or controls https://www.w3.org/TR/wai-aria-1.1/#toolbar. It seems this layout would benefit from a more generic name.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/patternfly/patternfly-next/issues/comments/400459239","html_url":"https://github.com/patternfly/patternfly-next/pull/391#issuecomment-400459239","issue_url":"https://api.github.com/repos/patternfly/patternfly-next/issues/391","id":400459239,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDQ1OTIzOQ==","user":{"login":"mattnolting","id":5385435,"node_id":"MDQ6VXNlcjUzODU0MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5385435?v=4","gravatar_id":"","url":"https://api.github.com/users/mattnolting","html_url":"https://github.com/mattnolting","followers_url":"https://api.github.com/users/mattnolting/followers","following_url":"https://api.github.com/users/mattnolting/following{/other_user}","gists_url":"https://api.github.com/users/mattnolting/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnolting/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnolting/subscriptions","organizations_url":"https://api.github.com/users/mattnolting/orgs","repos_url":"https://api.github.com/users/mattnolting/repos","events_url":"https://api.github.com/users/mattnolting/events{/privacy}","received_events_url":"https://api.github.com/users/mattnolting/received_events","type":"User","site_admin":false},"created_at":"2018-06-26T20:55:47Z","updated_at":"2018-06-26T20:55:47Z","author_association":"CONTRIBUTOR","body":"Based on the structure, this looks more like `pf-l-flex` layout, which could easily be applied to a toolbar demo, footer actions, etc, as it employs the same concepts as https://pf-next.com/layouts/Level/examples/, https://pf-next.com/layouts/Split/examples/, https://pf-next.com/layouts/Stack/examples/. However, that may be another, separate issue.."}}
{"actor":{"display_login":"mattnolting"}}