{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/videojs-flash/issues/92","repository_url":"https://api.github.com/repos/videojs/videojs-flash","labels_url":"https://api.github.com/repos/videojs/videojs-flash/issues/92/labels{/name}","comments_url":"https://api.github.com/repos/videojs/videojs-flash/issues/92/comments","events_url":"https://api.github.com/repos/videojs/videojs-flash/issues/92/events","html_url":"https://github.com/videojs/videojs-flash/issues/92","id":363289534,"node_id":"MDU6SXNzdWUzNjMyODk1MzQ=","number":92,"title":"Update package.json to use peerDependencies instead of dependencies for video.js","user":{"login":"rgfoley","id":7256749,"node_id":"MDQ6VXNlcjcyNTY3NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7256749?v=4","gravatar_id":"","url":"https://api.github.com/users/rgfoley","html_url":"https://github.com/rgfoley","followers_url":"https://api.github.com/users/rgfoley/followers","following_url":"https://api.github.com/users/rgfoley/following{/other_user}","gists_url":"https://api.github.com/users/rgfoley/gists{/gist_id}","starred_url":"https://api.github.com/users/rgfoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgfoley/subscriptions","organizations_url":"https://api.github.com/users/rgfoley/orgs","repos_url":"https://api.github.com/users/rgfoley/repos","events_url":"https://api.github.com/users/rgfoley/events{/privacy}","received_events_url":"https://api.github.com/users/rgfoley/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-24T19:34:02Z","updated_at":"2018-09-25T12:07:18Z","closed_at":null,"author_association":"NONE","body":"## Description\r\nWhen using the videojs-flash tech in an environment that respects node_modules structure (webpack, for example), the dependency structure will result in duplicate instances of VideoJS being installed, causing the Flash tech to be registered against the wrong instance of VideoJS at runtime.\r\n\r\n## Steps to reproduce\r\n1. Install video.js and videojs-flash\r\n2. Import them in a Webpack project\r\n3. Attempt to use the 'Flash' tech\r\n\r\n### Expected\r\nA working instance of the Flash tech being registered\r\n\r\n### Actual\r\nThe Flash tech being registered to a private instance of video.js\r\n\r\n## Additional Information\r\nThis should be easy to mitigate by using the peerDependencies field of the package.json. This will tell npm/yarn to use whatever version of video.js the client has installed, and will warn them if they do not have a compatible version.\r\n\r\n### versions\r\n#### videojs\r\n7.1.2\r\n\r\n#### browsers\r\nAll\r\n\r\n#### OSes\r\nAll\r\n\r\n### plugins\r\nvideojs-flash\r\n"},"comment":{"url":"https://api.github.com/repos/videojs/videojs-flash/issues/comments/424316446","html_url":"https://github.com/videojs/videojs-flash/issues/92#issuecomment-424316446","issue_url":"https://api.github.com/repos/videojs/videojs-flash/issues/92","id":424316446,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDMxNjQ0Ng==","user":{"login":"rgfoley","id":7256749,"node_id":"MDQ6VXNlcjcyNTY3NDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7256749?v=4","gravatar_id":"","url":"https://api.github.com/users/rgfoley","html_url":"https://github.com/rgfoley","followers_url":"https://api.github.com/users/rgfoley/followers","following_url":"https://api.github.com/users/rgfoley/following{/other_user}","gists_url":"https://api.github.com/users/rgfoley/gists{/gist_id}","starred_url":"https://api.github.com/users/rgfoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgfoley/subscriptions","organizations_url":"https://api.github.com/users/rgfoley/orgs","repos_url":"https://api.github.com/users/rgfoley/repos","events_url":"https://api.github.com/users/rgfoley/events{/privacy}","received_events_url":"https://api.github.com/users/rgfoley/received_events","type":"User","site_admin":false},"created_at":"2018-09-25T12:07:18Z","updated_at":"2018-09-25T12:07:18Z","author_association":"NONE","body":"I definitely agree that NPM/Yarn should be able to dedupe the dependencies, but in practice I found that even with Video.js 7.1.3 installed, videojs-flash installed its own copy of 7.1.2."}}
{"actor":{"display_login":"rgfoley"}}