{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/183622984","pull_request_review_id":114653659,"id":183622984,"diff_hunk":"@@ -90,13 +90,18 @@ The ofi_rxm provider checks for the following environment variables.\n *FI_OFI_RXM_BUFFER_SIZE*\n : Defines the transmit buffer size / inject size. Messages of size less than this\n   would be transmitted via an eager protocol and those above would be transmitted\n-  via a rendezvous protocol. Transmit data would be copied up to this size\n-  (default: ~16k).\n+  via a rendezvous or SAR (Segmentation And Reassembly) protocol. Transmit data\n+  would be copied up to this size (default: ~16k).\n \n *FI_OFI_RXM_COMP_PER_PROGRESS*\n : Defines the maximum number of MSG provider CQ entries (default: 1) that would\n   be read per progress (RxM CQ read).\n \n+*FI_OFI_RXM_SAR_LIMIT*\n+: Set this environment variable to control the RxM SAR (Segmentation And Reassembly)\n+  protocol. Messages of size less (greater) than this (default: 256 Kb) would be\n+  transmitted via eager (rendezvous) protocol.","path":"man/fi_rxm.7.md","position":16,"original_position":16,"commit_id":"770daa8265aa48b8bfd75041cfa2c4f9a0d9ada1","original_commit_id":"770daa8265aa48b8bfd75041cfa2c4f9a0d9ada1","user":{"login":"gladkovdmitry17","id":11650339,"avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/gladkovdmitry17","html_url":"https://github.com/gladkovdmitry17","followers_url":"https://api.github.com/users/gladkovdmitry17/followers","following_url":"https://api.github.com/users/gladkovdmitry17/following{/other_user}","gists_url":"https://api.github.com/users/gladkovdmitry17/gists{/gist_id}","starred_url":"https://api.github.com/users/gladkovdmitry17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladkovdmitry17/subscriptions","organizations_url":"https://api.github.com/users/gladkovdmitry17/orgs","repos_url":"https://api.github.com/users/gladkovdmitry17/repos","events_url":"https://api.github.com/users/gladkovdmitry17/events{/privacy}","received_events_url":"https://api.github.com/users/gladkovdmitry17/received_events","type":"User","site_admin":false},"body":"Oops, sorry. I wrote this at night :)\r\nThe wording was paraphrased","created_at":"2018-04-24T07:03:14Z","updated_at":"2018-04-24T07:31:49Z","html_url":"https://github.com/ofiwg/libfabric/pull/4032#discussion_r183622984","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4032","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/183622984"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4032#discussion_r183622984"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4032"}},"in_reply_to_id":183514959},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4032","id":183532275,"html_url":"https://github.com/ofiwg/libfabric/pull/4032","diff_url":"https://github.com/ofiwg/libfabric/pull/4032.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/4032.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4032","number":4032,"state":"open","locked":false,"title":"prov/rxm: Add run-time parameter for SAR protocol","user":{"login":"gladkovdmitry17","id":11650339,"avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/gladkovdmitry17","html_url":"https://github.com/gladkovdmitry17","followers_url":"https://api.github.com/users/gladkovdmitry17/followers","following_url":"https://api.github.com/users/gladkovdmitry17/following{/other_user}","gists_url":"https://api.github.com/users/gladkovdmitry17/gists{/gist_id}","starred_url":"https://api.github.com/users/gladkovdmitry17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladkovdmitry17/subscriptions","organizations_url":"https://api.github.com/users/gladkovdmitry17/orgs","repos_url":"https://api.github.com/users/gladkovdmitry17/repos","events_url":"https://api.github.com/users/gladkovdmitry17/events{/privacy}","received_events_url":"https://api.github.com/users/gladkovdmitry17/received_events","type":"User","site_admin":false},"body":"This patch updates initialization routine of RxM provider\r\nto define FI_OFI_RXM_SAR_LIMIT environment variable.\r\nThe value of this parameter is stored in objects of the rxm_ep\r\nstructure (RxM EPs).\r\nIf the passed value is less than min(FI_OFI_RXM_SAR_LIMIT;\r\nsizeof(struct rxm_pkt)) (i.e. RxM inject size), then the SAR limit\r\nis set to RxM inject size. If the value isn't passed, the SAR limit\r\nis set to the default one (256 Kb = 262144 bytes).\r\nThis patch add description of this variable to the fi_rxm(7) man page.\r\n\r\nAlso this patch appliesminor updates to the description of\r\nFI_OFI_RXM_BUFFER_SIZE variable in both the source code and the man page.\r\n\r\nSigned-off-by: Dmitry Gladkov <dmitry.gladkov@intel.com>","created_at":"2018-04-23T19:22:17Z","updated_at":"2018-04-24T07:31:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab2bac27a85760f83d9bc18683315bd92e880373","assignee":null,"assignees":[],"requested_reviewers":[{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars1.githubusercontent.com/u/8547674?v=4","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4032/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4032/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4032/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/770daa8265aa48b8bfd75041cfa2c4f9a0d9ada1","head":{"label":"gladkovdmitry17:rxm_dev","ref":"rxm_dev","sha":"770daa8265aa48b8bfd75041cfa2c4f9a0d9ada1","user":{"login":"gladkovdmitry17","id":11650339,"avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/gladkovdmitry17","html_url":"https://github.com/gladkovdmitry17","followers_url":"https://api.github.com/users/gladkovdmitry17/followers","following_url":"https://api.github.com/users/gladkovdmitry17/following{/other_user}","gists_url":"https://api.github.com/users/gladkovdmitry17/gists{/gist_id}","starred_url":"https://api.github.com/users/gladkovdmitry17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladkovdmitry17/subscriptions","organizations_url":"https://api.github.com/users/gladkovdmitry17/orgs","repos_url":"https://api.github.com/users/gladkovdmitry17/repos","events_url":"https://api.github.com/users/gladkovdmitry17/events{/privacy}","received_events_url":"https://api.github.com/users/gladkovdmitry17/received_events","type":"User","site_admin":false},"repo":{"id":80634217,"name":"libfabric","full_name":"gladkovdmitry17/libfabric","owner":{"login":"gladkovdmitry17","id":11650339,"avatar_url":"https://avatars1.githubusercontent.com/u/11650339?v=4","gravatar_id":"","url":"https://api.github.com/users/gladkovdmitry17","html_url":"https://github.com/gladkovdmitry17","followers_url":"https://api.github.com/users/gladkovdmitry17/followers","following_url":"https://api.github.com/users/gladkovdmitry17/following{/other_user}","gists_url":"https://api.github.com/users/gladkovdmitry17/gists{/gist_id}","starred_url":"https://api.github.com/users/gladkovdmitry17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gladkovdmitry17/subscriptions","organizations_url":"https://api.github.com/users/gladkovdmitry17/orgs","repos_url":"https://api.github.com/users/gladkovdmitry17/repos","events_url":"https://api.github.com/users/gladkovdmitry17/events{/privacy}","received_events_url":"https://api.github.com/users/gladkovdmitry17/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gladkovdmitry17/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/gladkovdmitry17/libfabric","forks_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/forks","keys_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/teams","hooks_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/hooks","issue_events_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/events","assignees_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/tags","blobs_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/languages","stargazers_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/stargazers","contributors_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/contributors","subscribers_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/subscribers","subscription_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/subscription","commits_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/merges","archive_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/downloads","issues_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/gladkovdmitry17/libfabric/deployments","created_at":"2017-02-01T15:37:30Z","updated_at":"2018-04-13T10:38:24Z","pushed_at":"2018-04-23T19:22:09Z","git_url":"git://github.com/gladkovdmitry17/libfabric.git","ssh_url":"git@github.com:gladkovdmitry17/libfabric.git","clone_url":"https://github.com/gladkovdmitry17/libfabric.git","svn_url":"https://github.com/gladkovdmitry17/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":17893,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"51af1de6acc79b9dd6923f5962fe73aa27ce704d","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2018-04-23T17:36:28Z","pushed_at":"2018-04-23T19:22:17Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://libfabric.org/","size":17891,"stargazers_count":147,"watchers_count":147,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":129,"mirror_url":null,"archived":false,"open_issues_count":104,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":129,"open_issues":104,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4032"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4032"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4032"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4032/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4032/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4032/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/770daa8265aa48b8bfd75041cfa2c4f9a0d9ada1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gladkovdmitry17"}}