{"action":"created","comment":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/comments/188223319","pull_request_review_id":120154506,"id":188223319,"diff_hunk":"@@ -738,3 +738,62 @@ HttpRequest::manager(const CbcPointer<ConnStateData> &aMgr, const AccessLogEntry\n     }\n }\n \n+/// a helper for validating FindListeningPortAddress()-found address candidates\n+static const Ip::Address *\n+FindListeningPortAddressInAddress(const Ip::Address *ip)\n+{\n+    // FindListeningPortAddress() callers do not want \"any\" addresses","path":"src/HttpRequest.cc","position":8,"original_position":8,"commit_id":"c05844f9048213916e426d35790d39b1033bd3b0","original_commit_id":"f50b087b2e9e0d302e9508cf2abe18593cb5cd5c","user":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"body":"s/\"any\"/INADDR_ANY/","created_at":"2018-05-15T09:34:09Z","updated_at":"2018-05-15T09:50:41Z","html_url":"https://github.com/squid-cache/squid/pull/198#discussion_r188223319","pull_request_url":"https://api.github.com/repos/squid-cache/squid/pulls/198","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments/188223319"},"html":{"href":"https://github.com/squid-cache/squid/pull/198#discussion_r188223319"},"pull_request":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/198","id":185506485,"html_url":"https://github.com/squid-cache/squid/pull/198","diff_url":"https://github.com/squid-cache/squid/pull/198.diff","patch_url":"https://github.com/squid-cache/squid/pull/198.patch","issue_url":"https://api.github.com/repos/squid-cache/squid/issues/198","number":198,"state":"open","locked":false,"title":"Support Local listening IP in error pages / deny_info URL","user":{"login":"amishxda","id":3330468,"avatar_url":"https://avatars3.githubusercontent.com/u/3330468?v=4","gravatar_id":"","url":"https://api.github.com/users/amishxda","html_url":"https://github.com/amishxda","followers_url":"https://api.github.com/users/amishxda/followers","following_url":"https://api.github.com/users/amishxda/following{/other_user}","gists_url":"https://api.github.com/users/amishxda/gists{/gist_id}","starred_url":"https://api.github.com/users/amishxda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amishxda/subscriptions","organizations_url":"https://api.github.com/users/amishxda/orgs","repos_url":"https://api.github.com/users/amishxda/repos","events_url":"https://api.github.com/users/amishxda/events{/privacy}","received_events_url":"https://api.github.com/users/amishxda/received_events","type":"User","site_admin":false},"body":"This PR adds support for Local listening IP address macro (%A)\r\nto error pages and deny_info URL\r\n\r\nDiscussion link:\r\nhttp://lists.squid-cache.org/pipermail/squid-users/2018-May/018174.html","created_at":"2018-05-02T17:22:08Z","updated_at":"2018-05-15T09:50:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e144cf1a5a52d076c732e8fe9ee8610eb3fd0b2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/squid-cache/squid/pulls/198/commits","review_comments_url":"https://api.github.com/repos/squid-cache/squid/pulls/198/comments","review_comment_url":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squid-cache/squid/issues/198/comments","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/c05844f9048213916e426d35790d39b1033bd3b0","head":{"label":"amishxda:listen_address_deny_info","ref":"listen_address_deny_info","sha":"c05844f9048213916e426d35790d39b1033bd3b0","user":{"login":"amishxda","id":3330468,"avatar_url":"https://avatars3.githubusercontent.com/u/3330468?v=4","gravatar_id":"","url":"https://api.github.com/users/amishxda","html_url":"https://github.com/amishxda","followers_url":"https://api.github.com/users/amishxda/followers","following_url":"https://api.github.com/users/amishxda/following{/other_user}","gists_url":"https://api.github.com/users/amishxda/gists{/gist_id}","starred_url":"https://api.github.com/users/amishxda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amishxda/subscriptions","organizations_url":"https://api.github.com/users/amishxda/orgs","repos_url":"https://api.github.com/users/amishxda/repos","events_url":"https://api.github.com/users/amishxda/events{/privacy}","received_events_url":"https://api.github.com/users/amishxda/received_events","type":"User","site_admin":false},"repo":{"id":131875681,"name":"squid","full_name":"amishxda/squid","owner":{"login":"amishxda","id":3330468,"avatar_url":"https://avatars3.githubusercontent.com/u/3330468?v=4","gravatar_id":"","url":"https://api.github.com/users/amishxda","html_url":"https://github.com/amishxda","followers_url":"https://api.github.com/users/amishxda/followers","following_url":"https://api.github.com/users/amishxda/following{/other_user}","gists_url":"https://api.github.com/users/amishxda/gists{/gist_id}","starred_url":"https://api.github.com/users/amishxda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amishxda/subscriptions","organizations_url":"https://api.github.com/users/amishxda/orgs","repos_url":"https://api.github.com/users/amishxda/repos","events_url":"https://api.github.com/users/amishxda/events{/privacy}","received_events_url":"https://api.github.com/users/amishxda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amishxda/squid","description":"Squid Web Proxy Cache","fork":true,"url":"https://api.github.com/repos/amishxda/squid","forks_url":"https://api.github.com/repos/amishxda/squid/forks","keys_url":"https://api.github.com/repos/amishxda/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amishxda/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amishxda/squid/teams","hooks_url":"https://api.github.com/repos/amishxda/squid/hooks","issue_events_url":"https://api.github.com/repos/amishxda/squid/issues/events{/number}","events_url":"https://api.github.com/repos/amishxda/squid/events","assignees_url":"https://api.github.com/repos/amishxda/squid/assignees{/user}","branches_url":"https://api.github.com/repos/amishxda/squid/branches{/branch}","tags_url":"https://api.github.com/repos/amishxda/squid/tags","blobs_url":"https://api.github.com/repos/amishxda/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amishxda/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amishxda/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/amishxda/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amishxda/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/amishxda/squid/languages","stargazers_url":"https://api.github.com/repos/amishxda/squid/stargazers","contributors_url":"https://api.github.com/repos/amishxda/squid/contributors","subscribers_url":"https://api.github.com/repos/amishxda/squid/subscribers","subscription_url":"https://api.github.com/repos/amishxda/squid/subscription","commits_url":"https://api.github.com/repos/amishxda/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/amishxda/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/amishxda/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/amishxda/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/amishxda/squid/contents/{+path}","compare_url":"https://api.github.com/repos/amishxda/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amishxda/squid/merges","archive_url":"https://api.github.com/repos/amishxda/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amishxda/squid/downloads","issues_url":"https://api.github.com/repos/amishxda/squid/issues{/number}","pulls_url":"https://api.github.com/repos/amishxda/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/amishxda/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/amishxda/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amishxda/squid/labels{/name}","releases_url":"https://api.github.com/repos/amishxda/squid/releases{/id}","deployments_url":"https://api.github.com/repos/amishxda/squid/deployments","created_at":"2018-05-02T16:10:17Z","updated_at":"2018-05-07T06:12:42Z","pushed_at":"2018-05-15T09:44:05Z","git_url":"git://github.com/amishxda/squid.git","ssh_url":"git@github.com:amishxda/squid.git","clone_url":"https://github.com/amishxda/squid.git","svn_url":"https://github.com/amishxda/squid","homepage":"http://www.squid-cache.org/","size":134861,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"squid-cache:master","ref":"master","sha":"d08caf47eb8b24faad9a578b4dc05e54451bd326","user":{"login":"squid-cache","id":363029,"avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"repo":{"id":24519987,"name":"squid","full_name":"squid-cache/squid","owner":{"login":"squid-cache","id":363029,"avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squid-cache/squid","description":"Squid Web Proxy Cache","fork":false,"url":"https://api.github.com/repos/squid-cache/squid","forks_url":"https://api.github.com/repos/squid-cache/squid/forks","keys_url":"https://api.github.com/repos/squid-cache/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squid-cache/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squid-cache/squid/teams","hooks_url":"https://api.github.com/repos/squid-cache/squid/hooks","issue_events_url":"https://api.github.com/repos/squid-cache/squid/issues/events{/number}","events_url":"https://api.github.com/repos/squid-cache/squid/events","assignees_url":"https://api.github.com/repos/squid-cache/squid/assignees{/user}","branches_url":"https://api.github.com/repos/squid-cache/squid/branches{/branch}","tags_url":"https://api.github.com/repos/squid-cache/squid/tags","blobs_url":"https://api.github.com/repos/squid-cache/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squid-cache/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squid-cache/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/squid-cache/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/squid-cache/squid/languages","stargazers_url":"https://api.github.com/repos/squid-cache/squid/stargazers","contributors_url":"https://api.github.com/repos/squid-cache/squid/contributors","subscribers_url":"https://api.github.com/repos/squid-cache/squid/subscribers","subscription_url":"https://api.github.com/repos/squid-cache/squid/subscription","commits_url":"https://api.github.com/repos/squid-cache/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/squid-cache/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/squid-cache/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/squid-cache/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/squid-cache/squid/contents/{+path}","compare_url":"https://api.github.com/repos/squid-cache/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squid-cache/squid/merges","archive_url":"https://api.github.com/repos/squid-cache/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squid-cache/squid/downloads","issues_url":"https://api.github.com/repos/squid-cache/squid/issues{/number}","pulls_url":"https://api.github.com/repos/squid-cache/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/squid-cache/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/squid-cache/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squid-cache/squid/labels{/name}","releases_url":"https://api.github.com/repos/squid-cache/squid/releases{/id}","deployments_url":"https://api.github.com/repos/squid-cache/squid/deployments","created_at":"2014-09-27T00:59:40Z","updated_at":"2018-05-14T05:10:18Z","pushed_at":"2018-05-15T09:44:06Z","git_url":"git://github.com/squid-cache/squid.git","ssh_url":"git@github.com:squid-cache/squid.git","clone_url":"https://github.com/squid-cache/squid.git","svn_url":"https://github.com/squid-cache/squid","homepage":"http://www.squid-cache.org/","size":161058,"stargazers_count":335,"watchers_count":335,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":133,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":133,"open_issues":20,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/198"},"html":{"href":"https://github.com/squid-cache/squid/pull/198"},"issue":{"href":"https://api.github.com/repos/squid-cache/squid/issues/198"},"comments":{"href":"https://api.github.com/repos/squid-cache/squid/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/squid-cache/squid/statuses/c05844f9048213916e426d35790d39b1033bd3b0"}},"author_association":"NONE"}}
{"actor":{"display_login":"yadij"}}