{"action":"closed","number":56,"pull_request":{"url":"https://api.github.com/repos/joeyates/metar-parser/pulls/56","id":241595386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTk1Mzg2","html_url":"https://github.com/joeyates/metar-parser/pull/56","diff_url":"https://github.com/joeyates/metar-parser/pull/56.diff","patch_url":"https://github.com/joeyates/metar-parser/pull/56.patch","issue_url":"https://api.github.com/repos/joeyates/metar-parser/issues/56","number":56,"state":"closed","locked":false,"title":"Fix issue with long running connections - Take 2","user":{"login":"cmiconi","id":10537333,"node_id":"MDQ6VXNlcjEwNTM3MzMz","avatar_url":"https://avatars0.githubusercontent.com/u/10537333?v=4","gravatar_id":"","url":"https://api.github.com/users/cmiconi","html_url":"https://github.com/cmiconi","followers_url":"https://api.github.com/users/cmiconi/followers","following_url":"https://api.github.com/users/cmiconi/following{/other_user}","gists_url":"https://api.github.com/users/cmiconi/gists{/gist_id}","starred_url":"https://api.github.com/users/cmiconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmiconi/subscriptions","organizations_url":"https://api.github.com/users/cmiconi/orgs","repos_url":"https://api.github.com/users/cmiconi/repos","events_url":"https://api.github.com/users/cmiconi/events{/privacy}","received_events_url":"https://api.github.com/users/cmiconi/received_events","type":"User","site_admin":false},"body":"This PR fixes the same issue as addressed in PR #55 and also updates the tests to allow and expect the FTP connection to be closed when the fetch operation completes.\r\n\r\nSide note:\r\nIt looks like jruby-9.0.0.0 is broken on the build system, possibly due to: https://blog.rubygems.org/2018/02/24/tls-10-and-11-deprecation-notice.html\r\n\r\nI've tested my changes and they appear to pass the test for the following versions:\r\n\r\nRuby:\r\n  2.3.0\r\n  2.4.0\r\n  2.5.0\r\n  2.5.3\r\n  2.6.0\r\n\r\nJRuby:\r\n  9.2.5.0","created_at":"2018-12-31T19:40:42Z","updated_at":"2019-01-05T15:53:32Z","closed_at":"2019-01-05T15:53:32Z","merged_at":"2019-01-05T15:53:32Z","merge_commit_sha":"94097bd2bb6484b8787e7699e036600733204801","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joeyates/metar-parser/pulls/56/commits","review_comments_url":"https://api.github.com/repos/joeyates/metar-parser/pulls/56/comments","review_comment_url":"https://api.github.com/repos/joeyates/metar-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joeyates/metar-parser/issues/56/comments","statuses_url":"https://api.github.com/repos/joeyates/metar-parser/statuses/94097bd2bb6484b8787e7699e036600733204801","head":{"label":"cmiconi:master","ref":"master","sha":"94097bd2bb6484b8787e7699e036600733204801","user":{"login":"cmiconi","id":10537333,"node_id":"MDQ6VXNlcjEwNTM3MzMz","avatar_url":"https://avatars0.githubusercontent.com/u/10537333?v=4","gravatar_id":"","url":"https://api.github.com/users/cmiconi","html_url":"https://github.com/cmiconi","followers_url":"https://api.github.com/users/cmiconi/followers","following_url":"https://api.github.com/users/cmiconi/following{/other_user}","gists_url":"https://api.github.com/users/cmiconi/gists{/gist_id}","starred_url":"https://api.github.com/users/cmiconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmiconi/subscriptions","organizations_url":"https://api.github.com/users/cmiconi/orgs","repos_url":"https://api.github.com/users/cmiconi/repos","events_url":"https://api.github.com/users/cmiconi/events{/privacy}","received_events_url":"https://api.github.com/users/cmiconi/received_events","type":"User","site_admin":false},"repo":{"id":163537117,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM1MzcxMTc=","name":"metar-parser","full_name":"cmiconi/metar-parser","private":false,"owner":{"login":"cmiconi","id":10537333,"node_id":"MDQ6VXNlcjEwNTM3MzMz","avatar_url":"https://avatars0.githubusercontent.com/u/10537333?v=4","gravatar_id":"","url":"https://api.github.com/users/cmiconi","html_url":"https://github.com/cmiconi","followers_url":"https://api.github.com/users/cmiconi/followers","following_url":"https://api.github.com/users/cmiconi/following{/other_user}","gists_url":"https://api.github.com/users/cmiconi/gists{/gist_id}","starred_url":"https://api.github.com/users/cmiconi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmiconi/subscriptions","organizations_url":"https://api.github.com/users/cmiconi/orgs","repos_url":"https://api.github.com/users/cmiconi/repos","events_url":"https://api.github.com/users/cmiconi/events{/privacy}","received_events_url":"https://api.github.com/users/cmiconi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmiconi/metar-parser","description":"A Ruby library for METAR weather reports","fork":true,"url":"https://api.github.com/repos/cmiconi/metar-parser","forks_url":"https://api.github.com/repos/cmiconi/metar-parser/forks","keys_url":"https://api.github.com/repos/cmiconi/metar-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmiconi/metar-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmiconi/metar-parser/teams","hooks_url":"https://api.github.com/repos/cmiconi/metar-parser/hooks","issue_events_url":"https://api.github.com/repos/cmiconi/metar-parser/issues/events{/number}","events_url":"https://api.github.com/repos/cmiconi/metar-parser/events","assignees_url":"https://api.github.com/repos/cmiconi/metar-parser/assignees{/user}","branches_url":"https://api.github.com/repos/cmiconi/metar-parser/branches{/branch}","tags_url":"https://api.github.com/repos/cmiconi/metar-parser/tags","blobs_url":"https://api.github.com/repos/cmiconi/metar-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmiconi/metar-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmiconi/metar-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmiconi/metar-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmiconi/metar-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/cmiconi/metar-parser/languages","stargazers_url":"https://api.github.com/repos/cmiconi/metar-parser/stargazers","contributors_url":"https://api.github.com/repos/cmiconi/metar-parser/contributors","subscribers_url":"https://api.github.com/repos/cmiconi/metar-parser/subscribers","subscription_url":"https://api.github.com/repos/cmiconi/metar-parser/subscription","commits_url":"https://api.github.com/repos/cmiconi/metar-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmiconi/metar-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmiconi/metar-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmiconi/metar-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmiconi/metar-parser/contents/{+path}","compare_url":"https://api.github.com/repos/cmiconi/metar-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmiconi/metar-parser/merges","archive_url":"https://api.github.com/repos/cmiconi/metar-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmiconi/metar-parser/downloads","issues_url":"https://api.github.com/repos/cmiconi/metar-parser/issues{/number}","pulls_url":"https://api.github.com/repos/cmiconi/metar-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/cmiconi/metar-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/cmiconi/metar-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmiconi/metar-parser/labels{/name}","releases_url":"https://api.github.com/repos/cmiconi/metar-parser/releases{/id}","deployments_url":"https://api.github.com/repos/cmiconi/metar-parser/deployments","created_at":"2018-12-29T19:52:32Z","updated_at":"2018-12-31T19:33:15Z","pushed_at":"2018-12-31T19:33:14Z","git_url":"git://github.com/cmiconi/metar-parser.git","ssh_url":"git@github.com:cmiconi/metar-parser.git","clone_url":"https://github.com/cmiconi/metar-parser.git","svn_url":"https://github.com/cmiconi/metar-parser","homepage":"","size":439,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joeyates:master","ref":"master","sha":"e55a057a09e4b4da446fdbc6998842001bd7134f","user":{"login":"joeyates","id":137838,"node_id":"MDQ6VXNlcjEzNzgzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/137838?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyates","html_url":"https://github.com/joeyates","followers_url":"https://api.github.com/users/joeyates/followers","following_url":"https://api.github.com/users/joeyates/following{/other_user}","gists_url":"https://api.github.com/users/joeyates/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyates/subscriptions","organizations_url":"https://api.github.com/users/joeyates/orgs","repos_url":"https://api.github.com/users/joeyates/repos","events_url":"https://api.github.com/users/joeyates/events{/privacy}","received_events_url":"https://api.github.com/users/joeyates/received_events","type":"User","site_admin":false},"repo":{"id":563475,"node_id":"MDEwOlJlcG9zaXRvcnk1NjM0NzU=","name":"metar-parser","full_name":"joeyates/metar-parser","private":false,"owner":{"login":"joeyates","id":137838,"node_id":"MDQ6VXNlcjEzNzgzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/137838?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyates","html_url":"https://github.com/joeyates","followers_url":"https://api.github.com/users/joeyates/followers","following_url":"https://api.github.com/users/joeyates/following{/other_user}","gists_url":"https://api.github.com/users/joeyates/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyates/subscriptions","organizations_url":"https://api.github.com/users/joeyates/orgs","repos_url":"https://api.github.com/users/joeyates/repos","events_url":"https://api.github.com/users/joeyates/events{/privacy}","received_events_url":"https://api.github.com/users/joeyates/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joeyates/metar-parser","description":"A Ruby library for METAR weather reports","fork":false,"url":"https://api.github.com/repos/joeyates/metar-parser","forks_url":"https://api.github.com/repos/joeyates/metar-parser/forks","keys_url":"https://api.github.com/repos/joeyates/metar-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joeyates/metar-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joeyates/metar-parser/teams","hooks_url":"https://api.github.com/repos/joeyates/metar-parser/hooks","issue_events_url":"https://api.github.com/repos/joeyates/metar-parser/issues/events{/number}","events_url":"https://api.github.com/repos/joeyates/metar-parser/events","assignees_url":"https://api.github.com/repos/joeyates/metar-parser/assignees{/user}","branches_url":"https://api.github.com/repos/joeyates/metar-parser/branches{/branch}","tags_url":"https://api.github.com/repos/joeyates/metar-parser/tags","blobs_url":"https://api.github.com/repos/joeyates/metar-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joeyates/metar-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joeyates/metar-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/joeyates/metar-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joeyates/metar-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/joeyates/metar-parser/languages","stargazers_url":"https://api.github.com/repos/joeyates/metar-parser/stargazers","contributors_url":"https://api.github.com/repos/joeyates/metar-parser/contributors","subscribers_url":"https://api.github.com/repos/joeyates/metar-parser/subscribers","subscription_url":"https://api.github.com/repos/joeyates/metar-parser/subscription","commits_url":"https://api.github.com/repos/joeyates/metar-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/joeyates/metar-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/joeyates/metar-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/joeyates/metar-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/joeyates/metar-parser/contents/{+path}","compare_url":"https://api.github.com/repos/joeyates/metar-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joeyates/metar-parser/merges","archive_url":"https://api.github.com/repos/joeyates/metar-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joeyates/metar-parser/downloads","issues_url":"https://api.github.com/repos/joeyates/metar-parser/issues{/number}","pulls_url":"https://api.github.com/repos/joeyates/metar-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/joeyates/metar-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/joeyates/metar-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joeyates/metar-parser/labels{/name}","releases_url":"https://api.github.com/repos/joeyates/metar-parser/releases{/id}","deployments_url":"https://api.github.com/repos/joeyates/metar-parser/deployments","created_at":"2010-03-15T16:13:50Z","updated_at":"2019-01-05T15:31:11Z","pushed_at":"2019-01-05T15:53:32Z","git_url":"git://github.com/joeyates/metar-parser.git","ssh_url":"git@github.com:joeyates/metar-parser.git","clone_url":"https://github.com/joeyates/metar-parser.git","svn_url":"https://github.com/joeyates/metar-parser","homepage":"","size":438,"stargazers_count":33,"watchers_count":33,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":0,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joeyates/metar-parser/pulls/56"},"html":{"href":"https://github.com/joeyates/metar-parser/pull/56"},"issue":{"href":"https://api.github.com/repos/joeyates/metar-parser/issues/56"},"comments":{"href":"https://api.github.com/repos/joeyates/metar-parser/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/joeyates/metar-parser/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/joeyates/metar-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joeyates/metar-parser/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/joeyates/metar-parser/statuses/94097bd2bb6484b8787e7699e036600733204801"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joeyates","id":137838,"node_id":"MDQ6VXNlcjEzNzgzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/137838?v=4","gravatar_id":"","url":"https://api.github.com/users/joeyates","html_url":"https://github.com/joeyates","followers_url":"https://api.github.com/users/joeyates/followers","following_url":"https://api.github.com/users/joeyates/following{/other_user}","gists_url":"https://api.github.com/users/joeyates/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyates/subscriptions","organizations_url":"https://api.github.com/users/joeyates/orgs","repos_url":"https://api.github.com/users/joeyates/repos","events_url":"https://api.github.com/users/joeyates/events{/privacy}","received_events_url":"https://api.github.com/users/joeyates/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":0,"additions":0,"deletions":0,"changed_files":0}}
{"actor":{"display_login":"joeyates"}}