{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/207804898","pull_request_review_id":143488634,"id":207804898,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzgwNDg5OA==","diff_hunk":"@@ -20,8 +20,8 @@ def select_requested_plugins(webpacked_plugin_ids, plugin_names)\n   end\n \n   def all_webpacked_plugins\n-    Foreman::Plugin.registered_plugins.values.select do |plugin|\n-      File.exist? File.join(plugin.path, 'webpack/index.js')\n+    Foreman::Plugin.all.select do |plugin|\n+      File.exist?(File.join(plugin.path, 'webpack/index.js')) || plugin.webpack_manifest_path","path":"app/helpers/reactjs_helper.rb","position":7,"original_position":7,"commit_id":"93ff50f6a0176d532f05835a3f0799d25098647c","original_commit_id":"93ff50f6a0176d532f05835a3f0799d25098647c","user":{"login":"tbrisker","id":1540531,"node_id":"MDQ6VXNlcjE1NDA1MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1540531?v=4","gravatar_id":"","url":"https://api.github.com/users/tbrisker","html_url":"https://github.com/tbrisker","followers_url":"https://api.github.com/users/tbrisker/followers","following_url":"https://api.github.com/users/tbrisker/following{/other_user}","gists_url":"https://api.github.com/users/tbrisker/gists{/gist_id}","starred_url":"https://api.github.com/users/tbrisker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbrisker/subscriptions","organizations_url":"https://api.github.com/users/tbrisker/orgs","repos_url":"https://api.github.com/users/tbrisker/repos","events_url":"https://api.github.com/users/tbrisker/events{/privacy}","received_events_url":"https://api.github.com/users/tbrisker/received_events","type":"User","site_admin":false},"body":"Would it make sense to push the entire check into `plugin.rb`? i.e. have some function such as `uses_webpack?` that encapsulates whatever checks are needed to tell if a plugin uses webpack or not","created_at":"2018-08-06T08:07:20Z","updated_at":"2018-08-06T08:07:26Z","html_url":"https://github.com/theforeman/foreman/pull/5849#discussion_r207804898","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/5849","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/207804898"},"html":{"href":"https://github.com/theforeman/foreman/pull/5849#discussion_r207804898"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5849"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/5849","id":202229826,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMjI5ODI2","html_url":"https://github.com/theforeman/foreman/pull/5849","diff_url":"https://github.com/theforeman/foreman/pull/5849.diff","patch_url":"https://github.com/theforeman/foreman/pull/5849.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/5849","number":5849,"state":"open","locked":false,"title":"[WIP] handle webpacked plugins without sources","user":{"login":"ekohl","id":155810,"node_id":"MDQ6VXNlcjE1NTgxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/155810?v=4","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"In a production setup the webpack sources might not be present. In that\ncase there is a manifest which we can test for.","created_at":"2018-07-18T12:02:08Z","updated_at":"2018-08-06T08:07:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"924a2dc4c2d54d573cb88eb07536449920894842","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":79040689,"node_id":"MDU6TGFiZWw3OTA0MDY4OQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Needs%20testing","name":"Needs testing","color":"fbca04","default":false},{"id":79040085,"node_id":"MDU6TGFiZWw3OTA0MDA4NQ==","url":"https://api.github.com/repos/theforeman/foreman/labels/Not%20yet%20reviewed","name":"Not yet reviewed","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/5849/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/5849/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/5849/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/93ff50f6a0176d532f05835a3f0799d25098647c","head":{"label":"ekohl:webpack-plugin-loading","ref":"webpack-plugin-loading","sha":"93ff50f6a0176d532f05835a3f0799d25098647c","user":{"login":"ekohl","id":155810,"node_id":"MDQ6VXNlcjE1NTgxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/155810?v=4","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"repo":{"id":4858470,"node_id":"MDEwOlJlcG9zaXRvcnk0ODU4NDcw","name":"foreman","full_name":"ekohl/foreman","owner":{"login":"ekohl","id":155810,"node_id":"MDQ6VXNlcjE1NTgxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/155810?v=4","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ekohl/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/ekohl/foreman","forks_url":"https://api.github.com/repos/ekohl/foreman/forks","keys_url":"https://api.github.com/repos/ekohl/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekohl/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekohl/foreman/teams","hooks_url":"https://api.github.com/repos/ekohl/foreman/hooks","issue_events_url":"https://api.github.com/repos/ekohl/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ekohl/foreman/events","assignees_url":"https://api.github.com/repos/ekohl/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ekohl/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ekohl/foreman/tags","blobs_url":"https://api.github.com/repos/ekohl/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekohl/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekohl/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekohl/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekohl/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ekohl/foreman/languages","stargazers_url":"https://api.github.com/repos/ekohl/foreman/stargazers","contributors_url":"https://api.github.com/repos/ekohl/foreman/contributors","subscribers_url":"https://api.github.com/repos/ekohl/foreman/subscribers","subscription_url":"https://api.github.com/repos/ekohl/foreman/subscription","commits_url":"https://api.github.com/repos/ekohl/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekohl/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekohl/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekohl/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekohl/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ekohl/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekohl/foreman/merges","archive_url":"https://api.github.com/repos/ekohl/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekohl/foreman/downloads","issues_url":"https://api.github.com/repos/ekohl/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ekohl/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ekohl/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ekohl/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekohl/foreman/labels{/name}","releases_url":"https://api.github.com/repos/ekohl/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/ekohl/foreman/deployments","created_at":"2012-07-02T10:25:51Z","updated_at":"2017-06-07T20:09:24Z","pushed_at":"2018-07-19T20:40:13Z","git_url":"git://github.com/ekohl/foreman.git","ssh_url":"git@github.com:ekohl/foreman.git","clone_url":"https://github.com/ekohl/foreman.git","svn_url":"https://github.com/ekohl/foreman","homepage":"http://theforeman.org","size":50323,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"e9e791c2329e8bb183c1ff0190150e53a24beb47","user":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"node_id":"MDEwOlJlcG9zaXRvcnkyNTg3NTA=","name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0Mzk4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1439844?v=4","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","deployments_url":"https://api.github.com/repos/theforeman/foreman/deployments","created_at":"2009-07-23T15:07:00Z","updated_at":"2018-08-06T07:37:35Z","pushed_at":"2018-08-06T07:37:16Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":76224,"stargazers_count":1470,"watchers_count":1470,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":750,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":750,"open_issues":130,"watchers":1470,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5849"},"html":{"href":"https://github.com/theforeman/foreman/pull/5849"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/5849"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/5849/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5849/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/5849/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/93ff50f6a0176d532f05835a3f0799d25098647c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tbrisker"}}