{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/206716204","pull_request_review_id":142183732,"id":206716204,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjcxNjIwNA==","diff_hunk":"@@ -242,6 +242,10 @@ public bool IsStandardScalar\n         /// </summary>\n         internal virtual int ValueCountCore { get { return 1; } }\n \n+        // IEquatable<T> interface recommends also to override base class implementations of\n+        // Object.Equals(Object) and GetHashCode. In classes below where Equals(ColumnType other)\n+        // is effectively a referencial comparison, there is no need to override base class implementations\n+        // of Object.Equals(Object) (and GetHashCode) since its also a referencial comparison.","path":"src/Microsoft.ML.Core/Data/ColumnType.cs","position":7,"original_position":7,"commit_id":"0192402d6eb6348a86056c4c61c6bfda1b59b688","original_commit_id":"0192402d6eb6348a86056c4c61c6bfda1b59b688","user":{"login":"sfilipi","id":19392467,"node_id":"MDQ6VXNlcjE5MzkyNDY3","avatar_url":"https://avatars1.githubusercontent.com/u/19392467?v=4","gravatar_id":"","url":"https://api.github.com/users/sfilipi","html_url":"https://github.com/sfilipi","followers_url":"https://api.github.com/users/sfilipi/followers","following_url":"https://api.github.com/users/sfilipi/following{/other_user}","gists_url":"https://api.github.com/users/sfilipi/gists{/gist_id}","starred_url":"https://api.github.com/users/sfilipi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sfilipi/subscriptions","organizations_url":"https://api.github.com/users/sfilipi/orgs","repos_url":"https://api.github.com/users/sfilipi/repos","events_url":"https://api.github.com/users/sfilipi/events{/privacy}","received_events_url":"https://api.github.com/users/sfilipi/received_events","type":"User","site_admin":false},"body":"switch to /// so documentation picks it up. ","created_at":"2018-07-31T23:35:43Z","updated_at":"2018-07-31T23:35:43Z","html_url":"https://github.com/dotnet/machinelearning/pull/620#discussion_r206716204","pull_request_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/620","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments/206716204"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/620#discussion_r206716204"},"pull_request":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/machinelearning/pulls/620","id":205241223,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjQxMjIz","html_url":"https://github.com/dotnet/machinelearning/pull/620","diff_url":"https://github.com/dotnet/machinelearning/pull/620.diff","patch_url":"https://github.com/dotnet/machinelearning/pull/620.patch","issue_url":"https://api.github.com/repos/dotnet/machinelearning/issues/620","number":620,"state":"open","locked":false,"title":"Overrides forObject.Equals(Object o), GetHashCode() for ... ","user":{"login":"ganik","id":18757686,"node_id":"MDQ6VXNlcjE4NzU3Njg2","avatar_url":"https://avatars2.githubusercontent.com/u/18757686?v=4","gravatar_id":"","url":"https://api.github.com/users/ganik","html_url":"https://github.com/ganik","followers_url":"https://api.github.com/users/ganik/followers","following_url":"https://api.github.com/users/ganik/following{/other_user}","gists_url":"https://api.github.com/users/ganik/gists{/gist_id}","starred_url":"https://api.github.com/users/ganik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganik/subscriptions","organizations_url":"https://api.github.com/users/ganik/orgs","repos_url":"https://api.github.com/users/ganik/repos","events_url":"https://api.github.com/users/ganik/events{/privacy}","received_events_url":"https://api.github.com/users/ganik/received_events","type":"User","site_admin":false},"body":"Issue #547\r\nAdded overrides for Object.Equals(Object o), GetHashCode() for VectorType, KeyType and ImageType\r\n\r\n","created_at":"2018-07-31T21:02:04Z","updated_at":"2018-07-31T23:35:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2c30e4d0f0e5d3f08923692027fe287a7b65fcf","assignee":{"login":"ganik","id":18757686,"node_id":"MDQ6VXNlcjE4NzU3Njg2","avatar_url":"https://avatars2.githubusercontent.com/u/18757686?v=4","gravatar_id":"","url":"https://api.github.com/users/ganik","html_url":"https://github.com/ganik","followers_url":"https://api.github.com/users/ganik/followers","following_url":"https://api.github.com/users/ganik/following{/other_user}","gists_url":"https://api.github.com/users/ganik/gists{/gist_id}","starred_url":"https://api.github.com/users/ganik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganik/subscriptions","organizations_url":"https://api.github.com/users/ganik/orgs","repos_url":"https://api.github.com/users/ganik/repos","events_url":"https://api.github.com/users/ganik/events{/privacy}","received_events_url":"https://api.github.com/users/ganik/received_events","type":"User","site_admin":false},"assignees":[{"login":"ganik","id":18757686,"node_id":"MDQ6VXNlcjE4NzU3Njg2","avatar_url":"https://avatars2.githubusercontent.com/u/18757686?v=4","gravatar_id":"","url":"https://api.github.com/users/ganik","html_url":"https://github.com/ganik","followers_url":"https://api.github.com/users/ganik/followers","following_url":"https://api.github.com/users/ganik/following{/other_user}","gists_url":"https://api.github.com/users/ganik/gists{/gist_id}","starred_url":"https://api.github.com/users/ganik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganik/subscriptions","organizations_url":"https://api.github.com/users/ganik/orgs","repos_url":"https://api.github.com/users/ganik/repos","events_url":"https://api.github.com/users/ganik/events{/privacy}","received_events_url":"https://api.github.com/users/ganik/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"TomFinley","id":8295757,"node_id":"MDQ6VXNlcjgyOTU3NTc=","avatar_url":"https://avatars1.githubusercontent.com/u/8295757?v=4","gravatar_id":"","url":"https://api.github.com/users/TomFinley","html_url":"https://github.com/TomFinley","followers_url":"https://api.github.com/users/TomFinley/followers","following_url":"https://api.github.com/users/TomFinley/following{/other_user}","gists_url":"https://api.github.com/users/TomFinley/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFinley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFinley/subscriptions","organizations_url":"https://api.github.com/users/TomFinley/orgs","repos_url":"https://api.github.com/users/TomFinley/repos","events_url":"https://api.github.com/users/TomFinley/events{/privacy}","received_events_url":"https://api.github.com/users/TomFinley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/620/commits","review_comments_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/620/comments","review_comment_url":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/issues/620/comments","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/0192402d6eb6348a86056c4c61c6bfda1b59b688","head":{"label":"ganik:ganik/hash","ref":"ganik/hash","sha":"0192402d6eb6348a86056c4c61c6bfda1b59b688","user":{"login":"ganik","id":18757686,"node_id":"MDQ6VXNlcjE4NzU3Njg2","avatar_url":"https://avatars2.githubusercontent.com/u/18757686?v=4","gravatar_id":"","url":"https://api.github.com/users/ganik","html_url":"https://github.com/ganik","followers_url":"https://api.github.com/users/ganik/followers","following_url":"https://api.github.com/users/ganik/following{/other_user}","gists_url":"https://api.github.com/users/ganik/gists{/gist_id}","starred_url":"https://api.github.com/users/ganik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganik/subscriptions","organizations_url":"https://api.github.com/users/ganik/orgs","repos_url":"https://api.github.com/users/ganik/repos","events_url":"https://api.github.com/users/ganik/events{/privacy}","received_events_url":"https://api.github.com/users/ganik/received_events","type":"User","site_admin":false},"repo":{"id":139206029,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkyMDYwMjk=","name":"machinelearning","full_name":"ganik/machinelearning","owner":{"login":"ganik","id":18757686,"node_id":"MDQ6VXNlcjE4NzU3Njg2","avatar_url":"https://avatars2.githubusercontent.com/u/18757686?v=4","gravatar_id":"","url":"https://api.github.com/users/ganik","html_url":"https://github.com/ganik","followers_url":"https://api.github.com/users/ganik/followers","following_url":"https://api.github.com/users/ganik/following{/other_user}","gists_url":"https://api.github.com/users/ganik/gists{/gist_id}","starred_url":"https://api.github.com/users/ganik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ganik/subscriptions","organizations_url":"https://api.github.com/users/ganik/orgs","repos_url":"https://api.github.com/users/ganik/repos","events_url":"https://api.github.com/users/ganik/events{/privacy}","received_events_url":"https://api.github.com/users/ganik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ganik/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":true,"url":"https://api.github.com/repos/ganik/machinelearning","forks_url":"https://api.github.com/repos/ganik/machinelearning/forks","keys_url":"https://api.github.com/repos/ganik/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ganik/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ganik/machinelearning/teams","hooks_url":"https://api.github.com/repos/ganik/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/ganik/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/ganik/machinelearning/events","assignees_url":"https://api.github.com/repos/ganik/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/ganik/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/ganik/machinelearning/tags","blobs_url":"https://api.github.com/repos/ganik/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ganik/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ganik/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ganik/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ganik/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/ganik/machinelearning/languages","stargazers_url":"https://api.github.com/repos/ganik/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/ganik/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/ganik/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/ganik/machinelearning/subscription","commits_url":"https://api.github.com/repos/ganik/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ganik/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ganik/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ganik/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ganik/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/ganik/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ganik/machinelearning/merges","archive_url":"https://api.github.com/repos/ganik/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ganik/machinelearning/downloads","issues_url":"https://api.github.com/repos/ganik/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/ganik/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/ganik/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/ganik/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ganik/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/ganik/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/ganik/machinelearning/deployments","created_at":"2018-06-30T00:01:49Z","updated_at":"2018-07-31T20:27:10Z","pushed_at":"2018-07-31T21:26:25Z","git_url":"git://github.com/ganik/machinelearning.git","ssh_url":"git@github.com:ganik/machinelearning.git","clone_url":"https://github.com/ganik/machinelearning.git","svn_url":"https://github.com/ganik/machinelearning","homepage":"http://dot.net/ml","size":20903,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"bdb742d3cc2bc273b18831e7e778f95a81e96a56","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":132021166,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIwMjExNjY=","name":"machinelearning","full_name":"dotnet/machinelearning","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/machinelearning","description":"ML.NET is an open source and cross-platform machine learning framework for .NET.","fork":false,"url":"https://api.github.com/repos/dotnet/machinelearning","forks_url":"https://api.github.com/repos/dotnet/machinelearning/forks","keys_url":"https://api.github.com/repos/dotnet/machinelearning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/machinelearning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/machinelearning/teams","hooks_url":"https://api.github.com/repos/dotnet/machinelearning/hooks","issue_events_url":"https://api.github.com/repos/dotnet/machinelearning/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/machinelearning/events","assignees_url":"https://api.github.com/repos/dotnet/machinelearning/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/machinelearning/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/machinelearning/tags","blobs_url":"https://api.github.com/repos/dotnet/machinelearning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/machinelearning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/machinelearning/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/machinelearning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/machinelearning/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/machinelearning/languages","stargazers_url":"https://api.github.com/repos/dotnet/machinelearning/stargazers","contributors_url":"https://api.github.com/repos/dotnet/machinelearning/contributors","subscribers_url":"https://api.github.com/repos/dotnet/machinelearning/subscribers","subscription_url":"https://api.github.com/repos/dotnet/machinelearning/subscription","commits_url":"https://api.github.com/repos/dotnet/machinelearning/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/machinelearning/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/machinelearning/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/machinelearning/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/machinelearning/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/machinelearning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/machinelearning/merges","archive_url":"https://api.github.com/repos/dotnet/machinelearning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/machinelearning/downloads","issues_url":"https://api.github.com/repos/dotnet/machinelearning/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/machinelearning/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/machinelearning/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/machinelearning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/machinelearning/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/machinelearning/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/machinelearning/deployments","created_at":"2018-05-03T16:20:42Z","updated_at":"2018-07-31T18:39:55Z","pushed_at":"2018-07-31T23:30:04Z","git_url":"git://github.com/dotnet/machinelearning.git","ssh_url":"git@github.com:dotnet/machinelearning.git","clone_url":"https://github.com/dotnet/machinelearning.git","svn_url":"https://github.com/dotnet/machinelearning","homepage":"https://dot.net/ml","size":20896,"stargazers_count":3275,"watchers_count":3275,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":457,"mirror_url":null,"archived":false,"open_issues_count":208,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":457,"open_issues":208,"watchers":3275,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/620"},"html":{"href":"https://github.com/dotnet/machinelearning/pull/620"},"issue":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/620"},"comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/machinelearning/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/machinelearning/statuses/0192402d6eb6348a86056c4c61c6bfda1b59b688"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sfilipi"}}