{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/174300832","pull_request_review_id":103632392,"id":174300832,"diff_hunk":"@@ -173,7 +173,16 @@ def __init__(self, processes=None, initializer=None, initargs=(),\n \n         self._processes = processes\n         self._pool = []\n-        self._repopulate_pool()\n+        try:\n+            self._repopulate_pool()\n+        except OSError:","path":"Lib/multiprocessing/pool.py","position":7,"original_position":7,"commit_id":"4a99c0a49f903f65304c626d7057c60270b808cd","original_commit_id":"4a99c0a49f903f65304c626d7057c60270b808cd","user":{"login":"pitrou","id":1721820,"avatar_url":"https://avatars2.githubusercontent.com/u/1721820?v=4","gravatar_id":"","url":"https://api.github.com/users/pitrou","html_url":"https://github.com/pitrou","followers_url":"https://api.github.com/users/pitrou/followers","following_url":"https://api.github.com/users/pitrou/following{/other_user}","gists_url":"https://api.github.com/users/pitrou/gists{/gist_id}","starred_url":"https://api.github.com/users/pitrou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pitrou/subscriptions","organizations_url":"https://api.github.com/users/pitrou/orgs","repos_url":"https://api.github.com/users/pitrou/repos","events_url":"https://api.github.com/users/pitrou/events{/privacy}","received_events_url":"https://api.github.com/users/pitrou/received_events","type":"User","site_admin":false},"body":"Simply `except Exception` sounds ok to me.","created_at":"2018-03-13T22:10:05Z","updated_at":"2018-03-13T22:10:06Z","html_url":"https://github.com/python/cpython/pull/5614#discussion_r174300832","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/5614","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/174300832"},"html":{"href":"https://github.com/python/cpython/pull/5614#discussion_r174300832"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/5614"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/5614","id":168425093,"html_url":"https://github.com/python/cpython/pull/5614","diff_url":"https://github.com/python/cpython/pull/5614.diff","patch_url":"https://github.com/python/cpython/pull/5614.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/5614","number":5614,"state":"open","locked":false,"title":"bpo-19675: Terminate processes if construction of a pool is failing.","user":{"login":"JulienPalard","id":239510,"avatar_url":"https://avatars2.githubusercontent.com/u/239510?v=4","gravatar_id":"","url":"https://api.github.com/users/JulienPalard","html_url":"https://github.com/JulienPalard","followers_url":"https://api.github.com/users/JulienPalard/followers","following_url":"https://api.github.com/users/JulienPalard/following{/other_user}","gists_url":"https://api.github.com/users/JulienPalard/gists{/gist_id}","starred_url":"https://api.github.com/users/JulienPalard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulienPalard/subscriptions","organizations_url":"https://api.github.com/users/JulienPalard/orgs","repos_url":"https://api.github.com/users/JulienPalard/repos","events_url":"https://api.github.com/users/JulienPalard/events{/privacy}","received_events_url":"https://api.github.com/users/JulienPalard/received_events","type":"User","site_admin":false},"body":"Trying another implementation of https://github.com/python/cpython/pull/57, avoiding to terminate all processes of a pool if a single one is failing to fork during the normal execution of the pool.\r\n\n\n<!-- issue-number: bpo-19675 -->\nhttps://bugs.python.org/issue19675\n<!-- /issue-number -->\n","created_at":"2018-02-10T22:44:17Z","updated_at":"2018-03-13T22:10:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f7a762d0c05e23f19541ac7bb39bf6c167ee0b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666980059,"url":"https://api.github.com/repos/python/cpython/labels/awaiting%20merge","name":"awaiting merge","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/5614/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/5614/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/5614/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/4a99c0a49f903f65304c626d7057c60270b808cd","head":{"label":"JulienPalard:bpo-19675","ref":"bpo-19675","sha":"4a99c0a49f903f65304c626d7057c60270b808cd","user":{"login":"JulienPalard","id":239510,"avatar_url":"https://avatars2.githubusercontent.com/u/239510?v=4","gravatar_id":"","url":"https://api.github.com/users/JulienPalard","html_url":"https://github.com/JulienPalard","followers_url":"https://api.github.com/users/JulienPalard/followers","following_url":"https://api.github.com/users/JulienPalard/following{/other_user}","gists_url":"https://api.github.com/users/JulienPalard/gists{/gist_id}","starred_url":"https://api.github.com/users/JulienPalard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulienPalard/subscriptions","organizations_url":"https://api.github.com/users/JulienPalard/orgs","repos_url":"https://api.github.com/users/JulienPalard/repos","events_url":"https://api.github.com/users/JulienPalard/events{/privacy}","received_events_url":"https://api.github.com/users/JulienPalard/received_events","type":"User","site_admin":false},"repo":{"id":82226771,"name":"cpython","full_name":"JulienPalard/cpython","owner":{"login":"JulienPalard","id":239510,"avatar_url":"https://avatars2.githubusercontent.com/u/239510?v=4","gravatar_id":"","url":"https://api.github.com/users/JulienPalard","html_url":"https://github.com/JulienPalard","followers_url":"https://api.github.com/users/JulienPalard/followers","following_url":"https://api.github.com/users/JulienPalard/following{/other_user}","gists_url":"https://api.github.com/users/JulienPalard/gists{/gist_id}","starred_url":"https://api.github.com/users/JulienPalard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JulienPalard/subscriptions","organizations_url":"https://api.github.com/users/JulienPalard/orgs","repos_url":"https://api.github.com/users/JulienPalard/repos","events_url":"https://api.github.com/users/JulienPalard/events{/privacy}","received_events_url":"https://api.github.com/users/JulienPalard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JulienPalard/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/JulienPalard/cpython","forks_url":"https://api.github.com/repos/JulienPalard/cpython/forks","keys_url":"https://api.github.com/repos/JulienPalard/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JulienPalard/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JulienPalard/cpython/teams","hooks_url":"https://api.github.com/repos/JulienPalard/cpython/hooks","issue_events_url":"https://api.github.com/repos/JulienPalard/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/JulienPalard/cpython/events","assignees_url":"https://api.github.com/repos/JulienPalard/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/JulienPalard/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/JulienPalard/cpython/tags","blobs_url":"https://api.github.com/repos/JulienPalard/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JulienPalard/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JulienPalard/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/JulienPalard/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JulienPalard/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/JulienPalard/cpython/languages","stargazers_url":"https://api.github.com/repos/JulienPalard/cpython/stargazers","contributors_url":"https://api.github.com/repos/JulienPalard/cpython/contributors","subscribers_url":"https://api.github.com/repos/JulienPalard/cpython/subscribers","subscription_url":"https://api.github.com/repos/JulienPalard/cpython/subscription","commits_url":"https://api.github.com/repos/JulienPalard/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/JulienPalard/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/JulienPalard/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/JulienPalard/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/JulienPalard/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/JulienPalard/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JulienPalard/cpython/merges","archive_url":"https://api.github.com/repos/JulienPalard/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JulienPalard/cpython/downloads","issues_url":"https://api.github.com/repos/JulienPalard/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/JulienPalard/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/JulienPalard/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/JulienPalard/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JulienPalard/cpython/labels{/name}","releases_url":"https://api.github.com/repos/JulienPalard/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/JulienPalard/cpython/deployments","created_at":"2017-02-16T21:13:57Z","updated_at":"2017-02-16T21:14:20Z","pushed_at":"2018-03-06T22:43:44Z","git_url":"git://github.com/JulienPalard/cpython.git","ssh_url":"git@github.com:JulienPalard/cpython.git","clone_url":"https://github.com/JulienPalard/cpython.git","svn_url":"https://github.com/JulienPalard/cpython","homepage":"https://www.python.org/","size":221107,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"8d1f2f40389c476d9240ec87a33da0373597c6af","user":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-03-13T20:28:39Z","pushed_at":"2018-03-13T22:06:02Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":230141,"stargazers_count":16576,"watchers_count":16576,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4650,"mirror_url":null,"archived":false,"open_issues_count":616,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4650,"open_issues":616,"watchers":16576,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/5614"},"html":{"href":"https://github.com/python/cpython/pull/5614"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/5614"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/5614/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/5614/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/5614/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/4a99c0a49f903f65304c626d7057c60270b808cd"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pitrou"}}