{"action":"created","comment":{"url":"https://api.github.com/repos/tango-controls/cppTango/pulls/comments/189254477","pull_request_review_id":121400786,"id":189254477,"diff_hunk":"@@ -1860,9 +1860,22 @@ void Tango::EventConsumer::initialize_received_from_admin(const Tango::DevVarLon\n \t\treceived_from_admin.channel_name = adm_name_lower;\n \t}\n \n-\tassert(!(received_from_admin.event_name.empty()));\n+    if (received_from_admin.event_name.empty())\n+    {\n+        EventSystemExcept::throw_exception(API_NotSupported,\n+                                           \"Server does not send event_name. Possibly to old server. Event system is not be initialized!\",\n+                                           \"EventConsumer::initialize_received_from_admin()\");\n+        throw;","path":"cppapi/client/event.cpp","position":10,"original_position":10,"commit_id":"e46d85bd8e25d9428e60130c3e5a3a5393c4520a","original_commit_id":"e46d85bd8e25d9428e60130c3e5a3a5393c4520a","user":{"login":"bourtemb","id":16306867,"avatar_url":"https://avatars2.githubusercontent.com/u/16306867?v=4","gravatar_id":"","url":"https://api.github.com/users/bourtemb","html_url":"https://github.com/bourtemb","followers_url":"https://api.github.com/users/bourtemb/followers","following_url":"https://api.github.com/users/bourtemb/following{/other_user}","gists_url":"https://api.github.com/users/bourtemb/gists{/gist_id}","starred_url":"https://api.github.com/users/bourtemb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bourtemb/subscriptions","organizations_url":"https://api.github.com/users/bourtemb/orgs","repos_url":"https://api.github.com/users/bourtemb/repos","events_url":"https://api.github.com/users/bourtemb/events{/privacy}","received_events_url":"https://api.github.com/users/bourtemb/received_events","type":"User","site_admin":false},"body":"I think this \"throw;\" is not necessary since EventSystemExcept::throw_exception is already throwing an exception.","created_at":"2018-05-18T12:37:14Z","updated_at":"2018-05-18T12:57:05Z","html_url":"https://github.com/tango-controls/cppTango/pull/454#discussion_r189254477","pull_request_url":"https://api.github.com/repos/tango-controls/cppTango/pulls/454","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/comments/189254477"},"html":{"href":"https://github.com/tango-controls/cppTango/pull/454#discussion_r189254477"},"pull_request":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/454"}}},"pull_request":{"url":"https://api.github.com/repos/tango-controls/cppTango/pulls/454","id":188822048,"html_url":"https://github.com/tango-controls/cppTango/pull/454","diff_url":"https://github.com/tango-controls/cppTango/pull/454.diff","patch_url":"https://github.com/tango-controls/cppTango/pull/454.patch","issue_url":"https://api.github.com/repos/tango-controls/cppTango/issues/454","number":454,"state":"open","locked":false,"title":"Fix #453: replace assert with exception","user":{"login":"Ingvord","id":11678364,"avatar_url":"https://avatars0.githubusercontent.com/u/11678364?v=4","gravatar_id":"","url":"https://api.github.com/users/Ingvord","html_url":"https://github.com/Ingvord","followers_url":"https://api.github.com/users/Ingvord/followers","following_url":"https://api.github.com/users/Ingvord/following{/other_user}","gists_url":"https://api.github.com/users/Ingvord/gists{/gist_id}","starred_url":"https://api.github.com/users/Ingvord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ingvord/subscriptions","organizations_url":"https://api.github.com/users/Ingvord/orgs","repos_url":"https://api.github.com/users/Ingvord/repos","events_url":"https://api.github.com/users/Ingvord/events{/privacy}","received_events_url":"https://api.github.com/users/Ingvord/received_events","type":"User","site_admin":false},"body":"subj","created_at":"2018-05-17T18:23:41Z","updated_at":"2018-05-18T12:57:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88bdb01a72b466c7ecb4d243d7c75209a6c4ccaf","assignee":{"login":"bourtemb","id":16306867,"avatar_url":"https://avatars2.githubusercontent.com/u/16306867?v=4","gravatar_id":"","url":"https://api.github.com/users/bourtemb","html_url":"https://github.com/bourtemb","followers_url":"https://api.github.com/users/bourtemb/followers","following_url":"https://api.github.com/users/bourtemb/following{/other_user}","gists_url":"https://api.github.com/users/bourtemb/gists{/gist_id}","starred_url":"https://api.github.com/users/bourtemb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bourtemb/subscriptions","organizations_url":"https://api.github.com/users/bourtemb/orgs","repos_url":"https://api.github.com/users/bourtemb/repos","events_url":"https://api.github.com/users/bourtemb/events{/privacy}","received_events_url":"https://api.github.com/users/bourtemb/received_events","type":"User","site_admin":false},"assignees":[{"login":"bourtemb","id":16306867,"avatar_url":"https://avatars2.githubusercontent.com/u/16306867?v=4","gravatar_id":"","url":"https://api.github.com/users/bourtemb","html_url":"https://github.com/bourtemb","followers_url":"https://api.github.com/users/bourtemb/followers","following_url":"https://api.github.com/users/bourtemb/following{/other_user}","gists_url":"https://api.github.com/users/bourtemb/gists{/gist_id}","starred_url":"https://api.github.com/users/bourtemb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bourtemb/subscriptions","organizations_url":"https://api.github.com/users/bourtemb/orgs","repos_url":"https://api.github.com/users/bourtemb/repos","events_url":"https://api.github.com/users/bourtemb/events{/privacy}","received_events_url":"https://api.github.com/users/bourtemb/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tango-controls/cppTango/pulls/454/commits","review_comments_url":"https://api.github.com/repos/tango-controls/cppTango/pulls/454/comments","review_comment_url":"https://api.github.com/repos/tango-controls/cppTango/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tango-controls/cppTango/issues/454/comments","statuses_url":"https://api.github.com/repos/tango-controls/cppTango/statuses/e46d85bd8e25d9428e60130c3e5a3a5393c4520a","head":{"label":"tango-controls:fix-453","ref":"fix-453","sha":"e46d85bd8e25d9428e60130c3e5a3a5393c4520a","user":{"login":"tango-controls","id":15830606,"avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":67682672,"name":"cppTango","full_name":"tango-controls/cppTango","owner":{"login":"tango-controls","id":15830606,"avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tango-controls/cppTango","description":"TANGO kernel c++ implementation","fork":false,"url":"https://api.github.com/repos/tango-controls/cppTango","forks_url":"https://api.github.com/repos/tango-controls/cppTango/forks","keys_url":"https://api.github.com/repos/tango-controls/cppTango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tango-controls/cppTango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tango-controls/cppTango/teams","hooks_url":"https://api.github.com/repos/tango-controls/cppTango/hooks","issue_events_url":"https://api.github.com/repos/tango-controls/cppTango/issues/events{/number}","events_url":"https://api.github.com/repos/tango-controls/cppTango/events","assignees_url":"https://api.github.com/repos/tango-controls/cppTango/assignees{/user}","branches_url":"https://api.github.com/repos/tango-controls/cppTango/branches{/branch}","tags_url":"https://api.github.com/repos/tango-controls/cppTango/tags","blobs_url":"https://api.github.com/repos/tango-controls/cppTango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tango-controls/cppTango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tango-controls/cppTango/git/refs{/sha}","trees_url":"https://api.github.com/repos/tango-controls/cppTango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tango-controls/cppTango/statuses/{sha}","languages_url":"https://api.github.com/repos/tango-controls/cppTango/languages","stargazers_url":"https://api.github.com/repos/tango-controls/cppTango/stargazers","contributors_url":"https://api.github.com/repos/tango-controls/cppTango/contributors","subscribers_url":"https://api.github.com/repos/tango-controls/cppTango/subscribers","subscription_url":"https://api.github.com/repos/tango-controls/cppTango/subscription","commits_url":"https://api.github.com/repos/tango-controls/cppTango/commits{/sha}","git_commits_url":"https://api.github.com/repos/tango-controls/cppTango/git/commits{/sha}","comments_url":"https://api.github.com/repos/tango-controls/cppTango/comments{/number}","issue_comment_url":"https://api.github.com/repos/tango-controls/cppTango/issues/comments{/number}","contents_url":"https://api.github.com/repos/tango-controls/cppTango/contents/{+path}","compare_url":"https://api.github.com/repos/tango-controls/cppTango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tango-controls/cppTango/merges","archive_url":"https://api.github.com/repos/tango-controls/cppTango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tango-controls/cppTango/downloads","issues_url":"https://api.github.com/repos/tango-controls/cppTango/issues{/number}","pulls_url":"https://api.github.com/repos/tango-controls/cppTango/pulls{/number}","milestones_url":"https://api.github.com/repos/tango-controls/cppTango/milestones{/number}","notifications_url":"https://api.github.com/repos/tango-controls/cppTango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tango-controls/cppTango/labels{/name}","releases_url":"https://api.github.com/repos/tango-controls/cppTango/releases{/id}","deployments_url":"https://api.github.com/repos/tango-controls/cppTango/deployments","created_at":"2016-09-08T08:10:34Z","updated_at":"2018-05-16T12:33:23Z","pushed_at":"2018-05-17T18:34:31Z","git_url":"git://github.com/tango-controls/cppTango.git","ssh_url":"git@github.com:tango-controls/cppTango.git","clone_url":"https://github.com/tango-controls/cppTango.git","svn_url":"https://github.com/tango-controls/cppTango","homepage":"http://tango-controls.org","size":8754,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":18,"open_issues":64,"watchers":19,"default_branch":"tango-9-lts"}},"base":{"label":"tango-controls:tango-9-lts","ref":"tango-9-lts","sha":"f60f53498e777606045abc366e7de2ac24178eee","user":{"login":"tango-controls","id":15830606,"avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"repo":{"id":67682672,"name":"cppTango","full_name":"tango-controls/cppTango","owner":{"login":"tango-controls","id":15830606,"avatar_url":"https://avatars2.githubusercontent.com/u/15830606?v=4","gravatar_id":"","url":"https://api.github.com/users/tango-controls","html_url":"https://github.com/tango-controls","followers_url":"https://api.github.com/users/tango-controls/followers","following_url":"https://api.github.com/users/tango-controls/following{/other_user}","gists_url":"https://api.github.com/users/tango-controls/gists{/gist_id}","starred_url":"https://api.github.com/users/tango-controls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tango-controls/subscriptions","organizations_url":"https://api.github.com/users/tango-controls/orgs","repos_url":"https://api.github.com/users/tango-controls/repos","events_url":"https://api.github.com/users/tango-controls/events{/privacy}","received_events_url":"https://api.github.com/users/tango-controls/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tango-controls/cppTango","description":"TANGO kernel c++ implementation","fork":false,"url":"https://api.github.com/repos/tango-controls/cppTango","forks_url":"https://api.github.com/repos/tango-controls/cppTango/forks","keys_url":"https://api.github.com/repos/tango-controls/cppTango/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tango-controls/cppTango/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tango-controls/cppTango/teams","hooks_url":"https://api.github.com/repos/tango-controls/cppTango/hooks","issue_events_url":"https://api.github.com/repos/tango-controls/cppTango/issues/events{/number}","events_url":"https://api.github.com/repos/tango-controls/cppTango/events","assignees_url":"https://api.github.com/repos/tango-controls/cppTango/assignees{/user}","branches_url":"https://api.github.com/repos/tango-controls/cppTango/branches{/branch}","tags_url":"https://api.github.com/repos/tango-controls/cppTango/tags","blobs_url":"https://api.github.com/repos/tango-controls/cppTango/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tango-controls/cppTango/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tango-controls/cppTango/git/refs{/sha}","trees_url":"https://api.github.com/repos/tango-controls/cppTango/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tango-controls/cppTango/statuses/{sha}","languages_url":"https://api.github.com/repos/tango-controls/cppTango/languages","stargazers_url":"https://api.github.com/repos/tango-controls/cppTango/stargazers","contributors_url":"https://api.github.com/repos/tango-controls/cppTango/contributors","subscribers_url":"https://api.github.com/repos/tango-controls/cppTango/subscribers","subscription_url":"https://api.github.com/repos/tango-controls/cppTango/subscription","commits_url":"https://api.github.com/repos/tango-controls/cppTango/commits{/sha}","git_commits_url":"https://api.github.com/repos/tango-controls/cppTango/git/commits{/sha}","comments_url":"https://api.github.com/repos/tango-controls/cppTango/comments{/number}","issue_comment_url":"https://api.github.com/repos/tango-controls/cppTango/issues/comments{/number}","contents_url":"https://api.github.com/repos/tango-controls/cppTango/contents/{+path}","compare_url":"https://api.github.com/repos/tango-controls/cppTango/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tango-controls/cppTango/merges","archive_url":"https://api.github.com/repos/tango-controls/cppTango/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tango-controls/cppTango/downloads","issues_url":"https://api.github.com/repos/tango-controls/cppTango/issues{/number}","pulls_url":"https://api.github.com/repos/tango-controls/cppTango/pulls{/number}","milestones_url":"https://api.github.com/repos/tango-controls/cppTango/milestones{/number}","notifications_url":"https://api.github.com/repos/tango-controls/cppTango/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tango-controls/cppTango/labels{/name}","releases_url":"https://api.github.com/repos/tango-controls/cppTango/releases{/id}","deployments_url":"https://api.github.com/repos/tango-controls/cppTango/deployments","created_at":"2016-09-08T08:10:34Z","updated_at":"2018-05-16T12:33:23Z","pushed_at":"2018-05-17T18:34:31Z","git_url":"git://github.com/tango-controls/cppTango.git","ssh_url":"git@github.com:tango-controls/cppTango.git","clone_url":"https://github.com/tango-controls/cppTango.git","svn_url":"https://github.com/tango-controls/cppTango","homepage":"http://tango-controls.org","size":8754,"stargazers_count":19,"watchers_count":19,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":18,"open_issues":64,"watchers":19,"default_branch":"tango-9-lts"}},"_links":{"self":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/454"},"html":{"href":"https://github.com/tango-controls/cppTango/pull/454"},"issue":{"href":"https://api.github.com/repos/tango-controls/cppTango/issues/454"},"comments":{"href":"https://api.github.com/repos/tango-controls/cppTango/issues/454/comments"},"review_comments":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/454/comments"},"review_comment":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tango-controls/cppTango/pulls/454/commits"},"statuses":{"href":"https://api.github.com/repos/tango-controls/cppTango/statuses/e46d85bd8e25d9428e60130c3e5a3a5393c4520a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bourtemb"}}