{"action":"created","comment":{"url":"https://api.github.com/repos/grommet/grommet/pulls/comments/201753492","pull_request_review_id":136315962,"id":201753492,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc1MzQ5Mg==","diff_hunk":"@@ -0,0 +1,52 @@\n+import React from 'react';\n+\n+import { TableCell } from '../Table';\n+import { Box } from '../Box';\n+import { Text } from '../Text';\n+\n+const Cell = ({\n+  column: { align, property, primary, render }, context, datum, scope, theme,\n+  ...rest\n+}) => {\n+  let content;\n+  if (render) {\n+    if (datum[property]) {\n+      content = render(datum);\n+    }\n+  } else if (datum[property]) {\n+    content = datum[property];\n+  }\n+\n+  if (typeof content === 'string' || typeof content === 'number') {\n+    if (primary) {\n+      content = <strong>{content}</strong>;\n+    }\n+    content = <Text>{content}</Text>;\n+  }\n+\n+  if (theme.dataTable[context]) {\n+    content = (\n+      <Box\n+        direction='row'\n+        justify={align}\n+        style={{ height: '100%' }}","path":"src/js/components/DataTable/Cell.js","position":32,"original_position":32,"commit_id":"346072916e3b29deb07fa515e98d2974529d70c4","original_commit_id":"346072916e3b29deb07fa515e98d2974529d70c4","user":{"login":"ericsoderberghp","id":11637956,"node_id":"MDQ6VXNlcjExNjM3OTU2","avatar_url":"https://avatars0.githubusercontent.com/u/11637956?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsoderberghp","html_url":"https://github.com/ericsoderberghp","followers_url":"https://api.github.com/users/ericsoderberghp/followers","following_url":"https://api.github.com/users/ericsoderberghp/following{/other_user}","gists_url":"https://api.github.com/users/ericsoderberghp/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsoderberghp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsoderberghp/subscriptions","organizations_url":"https://api.github.com/users/ericsoderberghp/orgs","repos_url":"https://api.github.com/users/ericsoderberghp/repos","events_url":"https://api.github.com/users/ericsoderberghp/events{/privacy}","received_events_url":"https://api.github.com/users/ericsoderberghp/received_events","type":"User","site_admin":false},"body":"Good suggestions. Box doesn't support this today, but I think it should.","created_at":"2018-07-11T16:11:52Z","updated_at":"2018-07-11T16:11:52Z","html_url":"https://github.com/grommet/grommet/pull/2080#discussion_r201753492","pull_request_url":"https://api.github.com/repos/grommet/grommet/pulls/2080","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/grommet/grommet/pulls/comments/201753492"},"html":{"href":"https://github.com/grommet/grommet/pull/2080#discussion_r201753492"},"pull_request":{"href":"https://api.github.com/repos/grommet/grommet/pulls/2080"}},"in_reply_to_id":201752231},"pull_request":{"url":"https://api.github.com/repos/grommet/grommet/pulls/2080","id":195265283,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjY1Mjgz","html_url":"https://github.com/grommet/grommet/pull/2080","diff_url":"https://github.com/grommet/grommet/pull/2080.diff","patch_url":"https://github.com/grommet/grommet/pull/2080.patch","issue_url":"https://api.github.com/repos/grommet/grommet/issues/2080","number":2080,"state":"open","locked":false,"title":"Added DataTable","user":{"login":"ericsoderberghp","id":11637956,"node_id":"MDQ6VXNlcjExNjM3OTU2","avatar_url":"https://avatars0.githubusercontent.com/u/11637956?v=4","gravatar_id":"","url":"https://api.github.com/users/ericsoderberghp","html_url":"https://github.com/ericsoderberghp","followers_url":"https://api.github.com/users/ericsoderberghp/followers","following_url":"https://api.github.com/users/ericsoderberghp/following{/other_user}","gists_url":"https://api.github.com/users/ericsoderberghp/gists{/gist_id}","starred_url":"https://api.github.com/users/ericsoderberghp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericsoderberghp/subscriptions","organizations_url":"https://api.github.com/users/ericsoderberghp/orgs","repos_url":"https://api.github.com/users/ericsoderberghp/repos","events_url":"https://api.github.com/users/ericsoderberghp/events{/privacy}","received_events_url":"https://api.github.com/users/ericsoderberghp/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\n\r\nAdded DataTable\r\n\r\n#### Where should the reviewer start?\r\n\r\nDataTable/doc.js\r\n\r\n#### What testing has been done on this PR?\r\n\r\nstorybook\r\n\r\n#### How should this be manually tested?\r\n\r\nstorybook\r\n\r\n#### Any background context you want to provide?\r\n\r\nMany thanks to @atanasster for the grommet paging-table inspiration.\r\n\r\n#### What are the relevant issues?\r\n\r\n#### Screenshots (if appropriate)\r\n\r\n#### Do the grommet docs need to be updated?\r\n\r\nautomatic\r\n\r\n#### Should this PR be mentioned in the release notes?\r\n\r\nyes\r\n\r\n#### Is this change backwards compatible or is it a breaking change?\r\n\r\nbackwards compatible\r\n","created_at":"2018-06-15T19:37:42Z","updated_at":"2018-07-11T16:11:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fda1884fd72b1c48b4aebcc5b9067dc5dd24e4d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grommet/grommet/pulls/2080/commits","review_comments_url":"https://api.github.com/repos/grommet/grommet/pulls/2080/comments","review_comment_url":"https://api.github.com/repos/grommet/grommet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grommet/grommet/issues/2080/comments","statuses_url":"https://api.github.com/repos/grommet/grommet/statuses/346072916e3b29deb07fa515e98d2974529d70c4","head":{"label":"grommet:NEXT-data-table","ref":"NEXT-data-table","sha":"346072916e3b29deb07fa515e98d2974529d70c4","user":{"login":"grommet","id":14203820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjAzODIw","avatar_url":"https://avatars3.githubusercontent.com/u/14203820?v=4","gravatar_id":"","url":"https://api.github.com/users/grommet","html_url":"https://github.com/grommet","followers_url":"https://api.github.com/users/grommet/followers","following_url":"https://api.github.com/users/grommet/following{/other_user}","gists_url":"https://api.github.com/users/grommet/gists{/gist_id}","starred_url":"https://api.github.com/users/grommet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grommet/subscriptions","organizations_url":"https://api.github.com/users/grommet/orgs","repos_url":"https://api.github.com/users/grommet/repos","events_url":"https://api.github.com/users/grommet/events{/privacy}","received_events_url":"https://api.github.com/users/grommet/received_events","type":"Organization","site_admin":false},"repo":{"id":32787174,"node_id":"MDEwOlJlcG9zaXRvcnkzMjc4NzE3NA==","name":"grommet","full_name":"grommet/grommet","owner":{"login":"grommet","id":14203820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjAzODIw","avatar_url":"https://avatars3.githubusercontent.com/u/14203820?v=4","gravatar_id":"","url":"https://api.github.com/users/grommet","html_url":"https://github.com/grommet","followers_url":"https://api.github.com/users/grommet/followers","following_url":"https://api.github.com/users/grommet/following{/other_user}","gists_url":"https://api.github.com/users/grommet/gists{/gist_id}","starred_url":"https://api.github.com/users/grommet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grommet/subscriptions","organizations_url":"https://api.github.com/users/grommet/orgs","repos_url":"https://api.github.com/users/grommet/repos","events_url":"https://api.github.com/users/grommet/events{/privacy}","received_events_url":"https://api.github.com/users/grommet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grommet/grommet","description":"Focus on the essential experience","fork":false,"url":"https://api.github.com/repos/grommet/grommet","forks_url":"https://api.github.com/repos/grommet/grommet/forks","keys_url":"https://api.github.com/repos/grommet/grommet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grommet/grommet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grommet/grommet/teams","hooks_url":"https://api.github.com/repos/grommet/grommet/hooks","issue_events_url":"https://api.github.com/repos/grommet/grommet/issues/events{/number}","events_url":"https://api.github.com/repos/grommet/grommet/events","assignees_url":"https://api.github.com/repos/grommet/grommet/assignees{/user}","branches_url":"https://api.github.com/repos/grommet/grommet/branches{/branch}","tags_url":"https://api.github.com/repos/grommet/grommet/tags","blobs_url":"https://api.github.com/repos/grommet/grommet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grommet/grommet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grommet/grommet/git/refs{/sha}","trees_url":"https://api.github.com/repos/grommet/grommet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grommet/grommet/statuses/{sha}","languages_url":"https://api.github.com/repos/grommet/grommet/languages","stargazers_url":"https://api.github.com/repos/grommet/grommet/stargazers","contributors_url":"https://api.github.com/repos/grommet/grommet/contributors","subscribers_url":"https://api.github.com/repos/grommet/grommet/subscribers","subscription_url":"https://api.github.com/repos/grommet/grommet/subscription","commits_url":"https://api.github.com/repos/grommet/grommet/commits{/sha}","git_commits_url":"https://api.github.com/repos/grommet/grommet/git/commits{/sha}","comments_url":"https://api.github.com/repos/grommet/grommet/comments{/number}","issue_comment_url":"https://api.github.com/repos/grommet/grommet/issues/comments{/number}","contents_url":"https://api.github.com/repos/grommet/grommet/contents/{+path}","compare_url":"https://api.github.com/repos/grommet/grommet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grommet/grommet/merges","archive_url":"https://api.github.com/repos/grommet/grommet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grommet/grommet/downloads","issues_url":"https://api.github.com/repos/grommet/grommet/issues{/number}","pulls_url":"https://api.github.com/repos/grommet/grommet/pulls{/number}","milestones_url":"https://api.github.com/repos/grommet/grommet/milestones{/number}","notifications_url":"https://api.github.com/repos/grommet/grommet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grommet/grommet/labels{/name}","releases_url":"https://api.github.com/repos/grommet/grommet/releases{/id}","deployments_url":"https://api.github.com/repos/grommet/grommet/deployments","created_at":"2015-03-24T08:54:10Z","updated_at":"2018-07-11T12:39:12Z","pushed_at":"2018-07-11T00:21:13Z","git_url":"git://github.com/grommet/grommet.git","ssh_url":"git@github.com:grommet/grommet.git","clone_url":"https://github.com/grommet/grommet.git","svn_url":"https://github.com/grommet/grommet","homepage":"https://grommet.github.io","size":125735,"stargazers_count":3434,"watchers_count":3434,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":419,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":419,"open_issues":49,"watchers":3434,"default_branch":"master"}},"base":{"label":"grommet:NEXT","ref":"NEXT","sha":"221c09eaec7f34642c8e68dbceb56a88cfe66de0","user":{"login":"grommet","id":14203820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjAzODIw","avatar_url":"https://avatars3.githubusercontent.com/u/14203820?v=4","gravatar_id":"","url":"https://api.github.com/users/grommet","html_url":"https://github.com/grommet","followers_url":"https://api.github.com/users/grommet/followers","following_url":"https://api.github.com/users/grommet/following{/other_user}","gists_url":"https://api.github.com/users/grommet/gists{/gist_id}","starred_url":"https://api.github.com/users/grommet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grommet/subscriptions","organizations_url":"https://api.github.com/users/grommet/orgs","repos_url":"https://api.github.com/users/grommet/repos","events_url":"https://api.github.com/users/grommet/events{/privacy}","received_events_url":"https://api.github.com/users/grommet/received_events","type":"Organization","site_admin":false},"repo":{"id":32787174,"node_id":"MDEwOlJlcG9zaXRvcnkzMjc4NzE3NA==","name":"grommet","full_name":"grommet/grommet","owner":{"login":"grommet","id":14203820,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjAzODIw","avatar_url":"https://avatars3.githubusercontent.com/u/14203820?v=4","gravatar_id":"","url":"https://api.github.com/users/grommet","html_url":"https://github.com/grommet","followers_url":"https://api.github.com/users/grommet/followers","following_url":"https://api.github.com/users/grommet/following{/other_user}","gists_url":"https://api.github.com/users/grommet/gists{/gist_id}","starred_url":"https://api.github.com/users/grommet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grommet/subscriptions","organizations_url":"https://api.github.com/users/grommet/orgs","repos_url":"https://api.github.com/users/grommet/repos","events_url":"https://api.github.com/users/grommet/events{/privacy}","received_events_url":"https://api.github.com/users/grommet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grommet/grommet","description":"Focus on the essential experience","fork":false,"url":"https://api.github.com/repos/grommet/grommet","forks_url":"https://api.github.com/repos/grommet/grommet/forks","keys_url":"https://api.github.com/repos/grommet/grommet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grommet/grommet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grommet/grommet/teams","hooks_url":"https://api.github.com/repos/grommet/grommet/hooks","issue_events_url":"https://api.github.com/repos/grommet/grommet/issues/events{/number}","events_url":"https://api.github.com/repos/grommet/grommet/events","assignees_url":"https://api.github.com/repos/grommet/grommet/assignees{/user}","branches_url":"https://api.github.com/repos/grommet/grommet/branches{/branch}","tags_url":"https://api.github.com/repos/grommet/grommet/tags","blobs_url":"https://api.github.com/repos/grommet/grommet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grommet/grommet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grommet/grommet/git/refs{/sha}","trees_url":"https://api.github.com/repos/grommet/grommet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grommet/grommet/statuses/{sha}","languages_url":"https://api.github.com/repos/grommet/grommet/languages","stargazers_url":"https://api.github.com/repos/grommet/grommet/stargazers","contributors_url":"https://api.github.com/repos/grommet/grommet/contributors","subscribers_url":"https://api.github.com/repos/grommet/grommet/subscribers","subscription_url":"https://api.github.com/repos/grommet/grommet/subscription","commits_url":"https://api.github.com/repos/grommet/grommet/commits{/sha}","git_commits_url":"https://api.github.com/repos/grommet/grommet/git/commits{/sha}","comments_url":"https://api.github.com/repos/grommet/grommet/comments{/number}","issue_comment_url":"https://api.github.com/repos/grommet/grommet/issues/comments{/number}","contents_url":"https://api.github.com/repos/grommet/grommet/contents/{+path}","compare_url":"https://api.github.com/repos/grommet/grommet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grommet/grommet/merges","archive_url":"https://api.github.com/repos/grommet/grommet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grommet/grommet/downloads","issues_url":"https://api.github.com/repos/grommet/grommet/issues{/number}","pulls_url":"https://api.github.com/repos/grommet/grommet/pulls{/number}","milestones_url":"https://api.github.com/repos/grommet/grommet/milestones{/number}","notifications_url":"https://api.github.com/repos/grommet/grommet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grommet/grommet/labels{/name}","releases_url":"https://api.github.com/repos/grommet/grommet/releases{/id}","deployments_url":"https://api.github.com/repos/grommet/grommet/deployments","created_at":"2015-03-24T08:54:10Z","updated_at":"2018-07-11T12:39:12Z","pushed_at":"2018-07-11T00:21:13Z","git_url":"git://github.com/grommet/grommet.git","ssh_url":"git@github.com:grommet/grommet.git","clone_url":"https://github.com/grommet/grommet.git","svn_url":"https://github.com/grommet/grommet","homepage":"https://grommet.github.io","size":125735,"stargazers_count":3434,"watchers_count":3434,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":419,"mirror_url":null,"archived":false,"open_issues_count":49,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":419,"open_issues":49,"watchers":3434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grommet/grommet/pulls/2080"},"html":{"href":"https://github.com/grommet/grommet/pull/2080"},"issue":{"href":"https://api.github.com/repos/grommet/grommet/issues/2080"},"comments":{"href":"https://api.github.com/repos/grommet/grommet/issues/2080/comments"},"review_comments":{"href":"https://api.github.com/repos/grommet/grommet/pulls/2080/comments"},"review_comment":{"href":"https://api.github.com/repos/grommet/grommet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grommet/grommet/pulls/2080/commits"},"statuses":{"href":"https://api.github.com/repos/grommet/grommet/statuses/346072916e3b29deb07fa515e98d2974529d70c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ericsoderberghp"}}