{"action":"created","issue":{"url":"https://api.github.com/repos/wizaplace/starterkit/issues/259","repository_url":"https://api.github.com/repos/wizaplace/starterkit","labels_url":"https://api.github.com/repos/wizaplace/starterkit/issues/259/labels{/name}","comments_url":"https://api.github.com/repos/wizaplace/starterkit/issues/259/comments","events_url":"https://api.github.com/repos/wizaplace/starterkit/issues/259/events","html_url":"https://github.com/wizaplace/starterkit/pull/259","id":296322304,"number":259,"title":"Upgrade Bootstrap from v3 to v4","user":{"login":"sergemazille","id":7364168,"avatar_url":"https://avatars3.githubusercontent.com/u/7364168?v=4","gravatar_id":"","url":"https://api.github.com/users/sergemazille","html_url":"https://github.com/sergemazille","followers_url":"https://api.github.com/users/sergemazille/followers","following_url":"https://api.github.com/users/sergemazille/following{/other_user}","gists_url":"https://api.github.com/users/sergemazille/gists{/gist_id}","starred_url":"https://api.github.com/users/sergemazille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergemazille/subscriptions","organizations_url":"https://api.github.com/users/sergemazille/orgs","repos_url":"https://api.github.com/users/sergemazille/repos","events_url":"https://api.github.com/users/sergemazille/events{/privacy}","received_events_url":"https://api.github.com/users/sergemazille/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"sergemazille","id":7364168,"avatar_url":"https://avatars3.githubusercontent.com/u/7364168?v=4","gravatar_id":"","url":"https://api.github.com/users/sergemazille","html_url":"https://github.com/sergemazille","followers_url":"https://api.github.com/users/sergemazille/followers","following_url":"https://api.github.com/users/sergemazille/following{/other_user}","gists_url":"https://api.github.com/users/sergemazille/gists{/gist_id}","starred_url":"https://api.github.com/users/sergemazille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergemazille/subscriptions","organizations_url":"https://api.github.com/users/sergemazille/orgs","repos_url":"https://api.github.com/users/sergemazille/repos","events_url":"https://api.github.com/users/sergemazille/events{/privacy}","received_events_url":"https://api.github.com/users/sergemazille/received_events","type":"User","site_admin":false},"assignees":[{"login":"sergemazille","id":7364168,"avatar_url":"https://avatars3.githubusercontent.com/u/7364168?v=4","gravatar_id":"","url":"https://api.github.com/users/sergemazille","html_url":"https://github.com/sergemazille","followers_url":"https://api.github.com/users/sergemazille/followers","following_url":"https://api.github.com/users/sergemazille/following{/other_user}","gists_url":"https://api.github.com/users/sergemazille/gists{/gist_id}","starred_url":"https://api.github.com/users/sergemazille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergemazille/subscriptions","organizations_url":"https://api.github.com/users/sergemazille/orgs","repos_url":"https://api.github.com/users/sergemazille/repos","events_url":"https://api.github.com/users/sergemazille/events{/privacy}","received_events_url":"https://api.github.com/users/sergemazille/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-02-12T10:14:29Z","updated_at":"2018-02-12T11:04:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/wizaplace/starterkit/pulls/259","html_url":"https://github.com/wizaplace/starterkit/pull/259","diff_url":"https://github.com/wizaplace/starterkit/pull/259.diff","patch_url":"https://github.com/wizaplace/starterkit/pull/259.patch"},"body":"fix 236\r\n\r\nPassage de Bootstrap 3 à Bootstrap 4\r\n\r\n## A noter :\r\n### Le positionnement des dropdowns du menu du header était complètement faux jusqu'à ce que je rajoute la classe `.navbar` à l'élément '.header-top'. \r\n- sans la classe .navbar :\r\n![wrong_dropdown](https://user-images.githubusercontent.com/7364168/36090814-028d45f4-0fe2-11e8-81d4-f4c2d71f3bb9.png)\r\n\r\n- avec la classe `.navbar`\r\n![image](https://user-images.githubusercontent.com/7364168/36090779-ed9b9484-0fe1-11e8-8f00-351cf99dea08.png)\r\n\r\nC'est la bibliothèque popper.js utilisée par Bootstrap 4 qui était responsable de ce mauvais positionnement. Un dropdown inclus dans un élément `.navbar` [ne fait pas appel à cette bibliothèque](https://getbootstrap.com/docs/4.0/components/dropdowns/#overview).\r\nLes dropdowns fonctionnent de la bonne façon ailleurs.\r\n![image](https://user-images.githubusercontent.com/7364168/36091134-0a46495c-0fe3-11e8-8c05-fc8e0f4b5873.png)\r\n\r\n### La tâche `concat` semble entrer en conflit avec la transpilation du sass de Bootstrap\r\n`clean-css` faisant le travail de minification, `concat` ne servait en réalité qu'à renommer le style en `app.css`. C'est désormais un autre modul `rename` qui se charge de la tâche\r\n\r\n### Bootstrap star rating\r\nBootstrap 4 n'incluant plus d'icone, ce sont désormais [les étoiles de font-awesome](https://github.com/wizaplace/starterkit/compare/bootstrap4?expand=1#diff-435cd77e924a58d7a3569efb08a22532R11) qui sont utilisées pour la bibliothèque de notation.\r\nJ'ai créé un fichier scss avec des variables pour paramétrer les couleurs des étoiles.\r\n\r\n### Nettoyage\r\nJ'ai fait un peu de nettoyage, ce qui a eu des conséquences imprévues sur certains éléments.\r\nIl faudra repasser sur certains éléments à remettre un peu d'aplomb comme par exemple le date picker de jqueryUI\r\n![image](https://user-images.githubusercontent.com/7364168/36091887-a9cf4044-0fe5-11e8-8689-ecc584d6d35b.png)"},"comment":{"url":"https://api.github.com/repos/wizaplace/starterkit/issues/comments/364891159","html_url":"https://github.com/wizaplace/starterkit/pull/259#issuecomment-364891159","issue_url":"https://api.github.com/repos/wizaplace/starterkit/issues/259","id":364891159,"user":{"login":"sergemazille","id":7364168,"avatar_url":"https://avatars3.githubusercontent.com/u/7364168?v=4","gravatar_id":"","url":"https://api.github.com/users/sergemazille","html_url":"https://github.com/sergemazille","followers_url":"https://api.github.com/users/sergemazille/followers","following_url":"https://api.github.com/users/sergemazille/following{/other_user}","gists_url":"https://api.github.com/users/sergemazille/gists{/gist_id}","starred_url":"https://api.github.com/users/sergemazille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergemazille/subscriptions","organizations_url":"https://api.github.com/users/sergemazille/orgs","repos_url":"https://api.github.com/users/sergemazille/repos","events_url":"https://api.github.com/users/sergemazille/events{/privacy}","received_events_url":"https://api.github.com/users/sergemazille/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T11:04:12Z","updated_at":"2018-02-12T11:04:12Z","author_association":"COLLABORATOR","body":"J'ai remis le style du date picker :\r\n![date_picker](https://user-images.githubusercontent.com/7364168/36094001-cf0a3c86-0fec-11e8-9bc8-f99fabdfa0d8.png)\r\n"}}
{"actor":{"display_login":"sergemazille"}}