{"action":"created","comment":{"url":"https://api.github.com/repos/riganti/dotvvm/pulls/comments/174098545","pull_request_review_id":103392450,"id":174098545,"diff_hunk":"@@ -138,12 +138,12 @@ public bool Enabled\n         public static readonly DotvvmProperty EnabledProperty =\n             DotvvmPropertyWithFallback.Register<bool, DataPager>(nameof(Enabled), FormControls.EnabledProperty);\n \n-        private HtmlGenericControl content;\n-        private HtmlGenericControl firstLi;\n-        private HtmlGenericControl previousLi;\n-        private PlaceHolder numbersPlaceHolder;\n-        private HtmlGenericControl nextLi;\n-        private HtmlGenericControl lastLi;\n+        protected HtmlGenericControl content;\n+        protected HtmlGenericControl firstLi;\n+        protected HtmlGenericControl previousLi;\n+        protected PlaceHolder numbersPlaceHolder;\n+        protected HtmlGenericControl nextLi;\n+        protected HtmlGenericControl lastLi;","path":"src/DotVVM.Framework/Controls/DataPager.cs","position":15,"original_position":15,"commit_id":"e3200aa680b6f18c6535500a13a260b69a29720c","original_commit_id":"e3200aa680b6f18c6535500a13a260b69a29720c","user":{"login":"djanosik","id":858180,"avatar_url":"https://avatars0.githubusercontent.com/u/858180?v=4","gravatar_id":"","url":"https://api.github.com/users/djanosik","html_url":"https://github.com/djanosik","followers_url":"https://api.github.com/users/djanosik/followers","following_url":"https://api.github.com/users/djanosik/following{/other_user}","gists_url":"https://api.github.com/users/djanosik/gists{/gist_id}","starred_url":"https://api.github.com/users/djanosik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djanosik/subscriptions","organizations_url":"https://api.github.com/users/djanosik/orgs","repos_url":"https://api.github.com/users/djanosik/repos","events_url":"https://api.github.com/users/djanosik/events{/privacy}","received_events_url":"https://api.github.com/users/djanosik/received_events","type":"User","site_admin":false},"body":"I think I don't like this. Can we instead have protected virtual methods like `CreateFirstLi()`?","created_at":"2018-03-13T11:40:41Z","updated_at":"2018-03-13T11:40:41Z","html_url":"https://github.com/riganti/dotvvm/pull/581#discussion_r174098545","pull_request_url":"https://api.github.com/repos/riganti/dotvvm/pulls/581","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/comments/174098545"},"html":{"href":"https://github.com/riganti/dotvvm/pull/581#discussion_r174098545"},"pull_request":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/581"}}},"pull_request":{"url":"https://api.github.com/repos/riganti/dotvvm/pulls/581","id":174627785,"html_url":"https://github.com/riganti/dotvvm/pull/581","diff_url":"https://github.com/riganti/dotvvm/pull/581.diff","patch_url":"https://github.com/riganti/dotvvm/pull/581.patch","issue_url":"https://api.github.com/repos/riganti/dotvvm/issues/581","number":581,"state":"open","locked":false,"title":"Refactored DataPager - added extensibility points","user":{"login":"MichalTichy","id":5333577,"avatar_url":"https://avatars3.githubusercontent.com/u/5333577?v=4","gravatar_id":"","url":"https://api.github.com/users/MichalTichy","html_url":"https://github.com/MichalTichy","followers_url":"https://api.github.com/users/MichalTichy/followers","following_url":"https://api.github.com/users/MichalTichy/following{/other_user}","gists_url":"https://api.github.com/users/MichalTichy/gists{/gist_id}","starred_url":"https://api.github.com/users/MichalTichy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MichalTichy/subscriptions","organizations_url":"https://api.github.com/users/MichalTichy/orgs","repos_url":"https://api.github.com/users/MichalTichy/repos","events_url":"https://api.github.com/users/MichalTichy/events{/privacy}","received_events_url":"https://api.github.com/users/MichalTichy/received_events","type":"User","site_admin":false},"body":"Added ways how to modify individual parts (buttons) of datapager","created_at":"2018-03-13T11:17:01Z","updated_at":"2018-03-13T11:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f3a9c974a84337b84d602442ef3da71ee53a9b0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adamjez","id":656406,"avatar_url":"https://avatars3.githubusercontent.com/u/656406?v=4","gravatar_id":"","url":"https://api.github.com/users/adamjez","html_url":"https://github.com/adamjez","followers_url":"https://api.github.com/users/adamjez/followers","following_url":"https://api.github.com/users/adamjez/following{/other_user}","gists_url":"https://api.github.com/users/adamjez/gists{/gist_id}","starred_url":"https://api.github.com/users/adamjez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamjez/subscriptions","organizations_url":"https://api.github.com/users/adamjez/orgs","repos_url":"https://api.github.com/users/adamjez/repos","events_url":"https://api.github.com/users/adamjez/events{/privacy}","received_events_url":"https://api.github.com/users/adamjez/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/riganti/dotvvm/pulls/581/commits","review_comments_url":"https://api.github.com/repos/riganti/dotvvm/pulls/581/comments","review_comment_url":"https://api.github.com/repos/riganti/dotvvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/riganti/dotvvm/issues/581/comments","statuses_url":"https://api.github.com/repos/riganti/dotvvm/statuses/e3200aa680b6f18c6535500a13a260b69a29720c","head":{"label":"riganti:DataPagerRefactor","ref":"DataPagerRefactor","sha":"e3200aa680b6f18c6535500a13a260b69a29720c","user":{"login":"riganti","id":9575026,"avatar_url":"https://avatars0.githubusercontent.com/u/9575026?v=4","gravatar_id":"","url":"https://api.github.com/users/riganti","html_url":"https://github.com/riganti","followers_url":"https://api.github.com/users/riganti/followers","following_url":"https://api.github.com/users/riganti/following{/other_user}","gists_url":"https://api.github.com/users/riganti/gists{/gist_id}","starred_url":"https://api.github.com/users/riganti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riganti/subscriptions","organizations_url":"https://api.github.com/users/riganti/orgs","repos_url":"https://api.github.com/users/riganti/repos","events_url":"https://api.github.com/users/riganti/events{/privacy}","received_events_url":"https://api.github.com/users/riganti/received_events","type":"Organization","site_admin":false},"repo":{"id":26230481,"name":"dotvvm","full_name":"riganti/dotvvm","owner":{"login":"riganti","id":9575026,"avatar_url":"https://avatars0.githubusercontent.com/u/9575026?v=4","gravatar_id":"","url":"https://api.github.com/users/riganti","html_url":"https://github.com/riganti","followers_url":"https://api.github.com/users/riganti/followers","following_url":"https://api.github.com/users/riganti/following{/other_user}","gists_url":"https://api.github.com/users/riganti/gists{/gist_id}","starred_url":"https://api.github.com/users/riganti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riganti/subscriptions","organizations_url":"https://api.github.com/users/riganti/orgs","repos_url":"https://api.github.com/users/riganti/repos","events_url":"https://api.github.com/users/riganti/events{/privacy}","received_events_url":"https://api.github.com/users/riganti/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riganti/dotvvm","description":"Open source MVVM framework for Web Apps","fork":false,"url":"https://api.github.com/repos/riganti/dotvvm","forks_url":"https://api.github.com/repos/riganti/dotvvm/forks","keys_url":"https://api.github.com/repos/riganti/dotvvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riganti/dotvvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riganti/dotvvm/teams","hooks_url":"https://api.github.com/repos/riganti/dotvvm/hooks","issue_events_url":"https://api.github.com/repos/riganti/dotvvm/issues/events{/number}","events_url":"https://api.github.com/repos/riganti/dotvvm/events","assignees_url":"https://api.github.com/repos/riganti/dotvvm/assignees{/user}","branches_url":"https://api.github.com/repos/riganti/dotvvm/branches{/branch}","tags_url":"https://api.github.com/repos/riganti/dotvvm/tags","blobs_url":"https://api.github.com/repos/riganti/dotvvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riganti/dotvvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riganti/dotvvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/riganti/dotvvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riganti/dotvvm/statuses/{sha}","languages_url":"https://api.github.com/repos/riganti/dotvvm/languages","stargazers_url":"https://api.github.com/repos/riganti/dotvvm/stargazers","contributors_url":"https://api.github.com/repos/riganti/dotvvm/contributors","subscribers_url":"https://api.github.com/repos/riganti/dotvvm/subscribers","subscription_url":"https://api.github.com/repos/riganti/dotvvm/subscription","commits_url":"https://api.github.com/repos/riganti/dotvvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/riganti/dotvvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/riganti/dotvvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/riganti/dotvvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/riganti/dotvvm/contents/{+path}","compare_url":"https://api.github.com/repos/riganti/dotvvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riganti/dotvvm/merges","archive_url":"https://api.github.com/repos/riganti/dotvvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riganti/dotvvm/downloads","issues_url":"https://api.github.com/repos/riganti/dotvvm/issues{/number}","pulls_url":"https://api.github.com/repos/riganti/dotvvm/pulls{/number}","milestones_url":"https://api.github.com/repos/riganti/dotvvm/milestones{/number}","notifications_url":"https://api.github.com/repos/riganti/dotvvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riganti/dotvvm/labels{/name}","releases_url":"https://api.github.com/repos/riganti/dotvvm/releases{/id}","deployments_url":"https://api.github.com/repos/riganti/dotvvm/deployments","created_at":"2014-11-05T17:14:34Z","updated_at":"2018-03-13T11:40:41Z","pushed_at":"2018-03-13T11:17:02Z","git_url":"git://github.com/riganti/dotvvm.git","ssh_url":"git@github.com:riganti/dotvvm.git","clone_url":"https://github.com/riganti/dotvvm.git","svn_url":"https://github.com/riganti/dotvvm","homepage":"https://www.dotvvm.com","size":31091,"stargazers_count":251,"watchers_count":251,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":56,"open_issues":111,"watchers":251,"default_branch":"master"}},"base":{"label":"riganti:master","ref":"master","sha":"01cc9a601e894fc3c13655f6b97b3e4223286989","user":{"login":"riganti","id":9575026,"avatar_url":"https://avatars0.githubusercontent.com/u/9575026?v=4","gravatar_id":"","url":"https://api.github.com/users/riganti","html_url":"https://github.com/riganti","followers_url":"https://api.github.com/users/riganti/followers","following_url":"https://api.github.com/users/riganti/following{/other_user}","gists_url":"https://api.github.com/users/riganti/gists{/gist_id}","starred_url":"https://api.github.com/users/riganti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riganti/subscriptions","organizations_url":"https://api.github.com/users/riganti/orgs","repos_url":"https://api.github.com/users/riganti/repos","events_url":"https://api.github.com/users/riganti/events{/privacy}","received_events_url":"https://api.github.com/users/riganti/received_events","type":"Organization","site_admin":false},"repo":{"id":26230481,"name":"dotvvm","full_name":"riganti/dotvvm","owner":{"login":"riganti","id":9575026,"avatar_url":"https://avatars0.githubusercontent.com/u/9575026?v=4","gravatar_id":"","url":"https://api.github.com/users/riganti","html_url":"https://github.com/riganti","followers_url":"https://api.github.com/users/riganti/followers","following_url":"https://api.github.com/users/riganti/following{/other_user}","gists_url":"https://api.github.com/users/riganti/gists{/gist_id}","starred_url":"https://api.github.com/users/riganti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riganti/subscriptions","organizations_url":"https://api.github.com/users/riganti/orgs","repos_url":"https://api.github.com/users/riganti/repos","events_url":"https://api.github.com/users/riganti/events{/privacy}","received_events_url":"https://api.github.com/users/riganti/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/riganti/dotvvm","description":"Open source MVVM framework for Web Apps","fork":false,"url":"https://api.github.com/repos/riganti/dotvvm","forks_url":"https://api.github.com/repos/riganti/dotvvm/forks","keys_url":"https://api.github.com/repos/riganti/dotvvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riganti/dotvvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riganti/dotvvm/teams","hooks_url":"https://api.github.com/repos/riganti/dotvvm/hooks","issue_events_url":"https://api.github.com/repos/riganti/dotvvm/issues/events{/number}","events_url":"https://api.github.com/repos/riganti/dotvvm/events","assignees_url":"https://api.github.com/repos/riganti/dotvvm/assignees{/user}","branches_url":"https://api.github.com/repos/riganti/dotvvm/branches{/branch}","tags_url":"https://api.github.com/repos/riganti/dotvvm/tags","blobs_url":"https://api.github.com/repos/riganti/dotvvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riganti/dotvvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riganti/dotvvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/riganti/dotvvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riganti/dotvvm/statuses/{sha}","languages_url":"https://api.github.com/repos/riganti/dotvvm/languages","stargazers_url":"https://api.github.com/repos/riganti/dotvvm/stargazers","contributors_url":"https://api.github.com/repos/riganti/dotvvm/contributors","subscribers_url":"https://api.github.com/repos/riganti/dotvvm/subscribers","subscription_url":"https://api.github.com/repos/riganti/dotvvm/subscription","commits_url":"https://api.github.com/repos/riganti/dotvvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/riganti/dotvvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/riganti/dotvvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/riganti/dotvvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/riganti/dotvvm/contents/{+path}","compare_url":"https://api.github.com/repos/riganti/dotvvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riganti/dotvvm/merges","archive_url":"https://api.github.com/repos/riganti/dotvvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riganti/dotvvm/downloads","issues_url":"https://api.github.com/repos/riganti/dotvvm/issues{/number}","pulls_url":"https://api.github.com/repos/riganti/dotvvm/pulls{/number}","milestones_url":"https://api.github.com/repos/riganti/dotvvm/milestones{/number}","notifications_url":"https://api.github.com/repos/riganti/dotvvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riganti/dotvvm/labels{/name}","releases_url":"https://api.github.com/repos/riganti/dotvvm/releases{/id}","deployments_url":"https://api.github.com/repos/riganti/dotvvm/deployments","created_at":"2014-11-05T17:14:34Z","updated_at":"2018-03-13T11:40:41Z","pushed_at":"2018-03-13T11:17:02Z","git_url":"git://github.com/riganti/dotvvm.git","ssh_url":"git@github.com:riganti/dotvvm.git","clone_url":"https://github.com/riganti/dotvvm.git","svn_url":"https://github.com/riganti/dotvvm","homepage":"https://www.dotvvm.com","size":31091,"stargazers_count":251,"watchers_count":251,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":56,"open_issues":111,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/581"},"html":{"href":"https://github.com/riganti/dotvvm/pull/581"},"issue":{"href":"https://api.github.com/repos/riganti/dotvvm/issues/581"},"comments":{"href":"https://api.github.com/repos/riganti/dotvvm/issues/581/comments"},"review_comments":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/581/comments"},"review_comment":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/riganti/dotvvm/pulls/581/commits"},"statuses":{"href":"https://api.github.com/repos/riganti/dotvvm/statuses/e3200aa680b6f18c6535500a13a260b69a29720c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"djanosik"}}