{"action":"created","issue":{"url":"https://api.github.com/repos/sbt/io/issues/175","repository_url":"https://api.github.com/repos/sbt/io","labels_url":"https://api.github.com/repos/sbt/io/issues/175/labels{/name}","comments_url":"https://api.github.com/repos/sbt/io/issues/175/comments","events_url":"https://api.github.com/repos/sbt/io/issues/175/events","html_url":"https://github.com/sbt/io/pull/175","id":346821997,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NTkyNDgy","number":175,"title":"Update relativize method for java 9","user":{"login":"eatkins","id":2658825,"node_id":"MDQ6VXNlcjI2NTg4MjU=","avatar_url":"https://avatars3.githubusercontent.com/u/2658825?v=4","gravatar_id":"","url":"https://api.github.com/users/eatkins","html_url":"https://github.com/eatkins","followers_url":"https://api.github.com/users/eatkins/followers","following_url":"https://api.github.com/users/eatkins/following{/other_user}","gists_url":"https://api.github.com/users/eatkins/gists{/gist_id}","starred_url":"https://api.github.com/users/eatkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eatkins/subscriptions","organizations_url":"https://api.github.com/users/eatkins/orgs","repos_url":"https://api.github.com/users/eatkins/repos","events_url":"https://api.github.com/users/eatkins/events{/privacy}","received_events_url":"https://api.github.com/users/eatkins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-02T01:02:32Z","updated_at":"2018-08-02T16:02:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sbt/io/pulls/175","html_url":"https://github.com/sbt/io/pull/175","diff_url":"https://github.com/sbt/io/pull/175.diff","patch_url":"https://github.com/sbt/io/pull/175.patch"},"body":"I noticed the io spec was failing on my mac on jdk9 (but passing on\r\ntravis, which was running jdk 8). The relativize method arguably didn't\r\nwork correctly on pre jdk 9 jres (at least on osx). For example, I ran\r\nthe following in the console:\r\n\r\nscala> import java.nio.file._\r\n\r\nscala> val base = Paths.get(\"/foo/bar/..\")\r\nval base = Paths.get(\"/foo/bar/..\")\r\nbase: java.nio.file.Path = /foo/bar/..\r\n\r\nscala> val file = Paths.get(\"/foo/buzz\")\r\nval file = Paths.get(\"/foo/buzz\")\r\nfile: java.nio.file.Path = /foo/buzz\r\n\r\nscala> val relative = base.relativize(file)\r\nval relative = base.relativize(file)\r\n                            ^\r\nrelative: java.nio.file.Path = ../../buzz\r\n\r\nscala> base.resolve(relative).normalize\r\nbase.resolve(relative).normalize\r\n                            ^\r\nres5: java.nio.file.Path = /buzz\r\n\r\nThis result is certainly not what I would expect. The fix is very easy,\r\njust always normalize the paths (which is not very expensive, especially\r\ncompared to any file system operation)."},"comment":{"url":"https://api.github.com/repos/sbt/io/issues/comments/409978776","html_url":"https://github.com/sbt/io/pull/175#issuecomment-409978776","issue_url":"https://api.github.com/repos/sbt/io/issues/175","id":409978776,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTk3ODc3Ng==","user":{"login":"eed3si9n","id":184683,"node_id":"MDQ6VXNlcjE4NDY4Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/184683?v=4","gravatar_id":"","url":"https://api.github.com/users/eed3si9n","html_url":"https://github.com/eed3si9n","followers_url":"https://api.github.com/users/eed3si9n/followers","following_url":"https://api.github.com/users/eed3si9n/following{/other_user}","gists_url":"https://api.github.com/users/eed3si9n/gists{/gist_id}","starred_url":"https://api.github.com/users/eed3si9n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eed3si9n/subscriptions","organizations_url":"https://api.github.com/users/eed3si9n/orgs","repos_url":"https://api.github.com/users/eed3si9n/repos","events_url":"https://api.github.com/users/eed3si9n/events{/privacy}","received_events_url":"https://api.github.com/users/eed3si9n/received_events","type":"User","site_admin":false},"created_at":"2018-08-02T16:02:03Z","updated_at":"2018-08-02T16:02:03Z","author_association":"MEMBER","body":"Dbuild doesn't work with sbt 1.2.0, so the test result is nonsensical."}}
{"actor":{"display_login":"eed3si9n"}}