{"action":"created","comment":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/169084372","pull_request_review_id":97552934,"id":169084372,"diff_hunk":"@@ -90,67 +25,215 @@ require \"c/unistd\"\n # ```\n #\n # Note:\n-# - Signals are processed through the event loop and run in their own Fiber.\n-# - Signals may be lost if the event loop doesn't run before exit.\n # - An uncaught exception in a signal handler is a fatal error.\n-enum Signal\n+enum Signal : Int32\n+  HUP    = LibC::SIGHUP\n+  INT    = LibC::SIGINT\n+  QUIT   = LibC::SIGQUIT\n+  ILL    = LibC::SIGILL\n+  TRAP   = LibC::SIGTRAP\n+  IOT    = LibC::SIGIOT\n+  ABRT   = LibC::SIGABRT\n+  FPE    = LibC::SIGFPE\n+  KILL   = LibC::SIGKILL\n+  BUS    = LibC::SIGBUS\n+  SEGV   = LibC::SIGSEGV\n+  SYS    = LibC::SIGSYS\n+  PIPE   = LibC::SIGPIPE\n+  ALRM   = LibC::SIGALRM\n+  TERM   = LibC::SIGTERM\n+  URG    = LibC::SIGURG\n+  STOP   = LibC::SIGSTOP\n+  TSTP   = LibC::SIGTSTP\n+  CONT   = LibC::SIGCONT\n+  CHLD   = LibC::SIGCHLD\n+  TTIN   = LibC::SIGTTIN\n+  TTOU   = LibC::SIGTTOU\n+  IO     = LibC::SIGIO\n+  XCPU   = LibC::SIGXCPU\n+  XFSZ   = LibC::SIGXFSZ\n+  VTALRM = LibC::SIGVTALRM\n+  USR1   = LibC::SIGUSR1\n+  USR2   = LibC::SIGUSR2\n+  WINCH  = LibC::SIGWINCH\n+\n+  {% if flag?(:linux) %}\n+    PWR    = LibC::SIGPWR\n+    STKFLT = LibC::SIGSTKFLT\n+    UNUSED = LibC::SIGUNUSED\n+  {% end %}\n+\n   # Sets the handler for this signal to the passed function.\n   #\n   # After executing this, whenever the current process receives the\n   # corresponding signal, the passed function will be run (instead of the OS\n   # default).\n-  def trap(block : Signal ->)\n-    trap &block\n-  end\n-\n-  # ditto\n-  def trap(&block : Signal ->)\n-    Event::SignalHandler.add_handler self, block\n+  def trap(&handler : Signal ->) : Nil\n+    Crystal::SignalHandler.trap(self, handler)\n   end\n \n   # Resets the handler for this signal to the OS default.\n-  def reset\n-    case self\n-    when CHLD\n-      # don't ignore by default.  send events to a waitpid service\n-      trap do\n-        Event::SignalChildHandler.instance.trigger\n-      end\n-    else\n-      del_handler Proc(Int32, Void).new(Pointer(Void).new(0_u64), Pointer(Void).null)\n-    end\n+  def reset : Nil\n+    Crystal::SignalHandler.reset(self)\n   end\n \n   # Clears the handler for this signal and prevents the OS default action.\n-  def ignore\n-    del_handler Proc(Int32, Void).new(Pointer(Void).new(1_u64), Pointer(Void).null)\n+  def ignore : Nil\n+    Crystal::SignalHandler.ignore(self)\n   end\n \n-  private def del_handler(block)\n-    Event::SignalHandler.del_handler self\n-    LibC.signal value, block\n-  end\n-\n-  @@default_handlers_setup = false\n+  @@setup_default_handlers = Atomic(Int32).new(0)\n \n   # :nodoc:\n   def self.setup_default_handlers\n-    return if @@default_handlers_setup\n-    @@default_handlers_setup = true\n+    _, success = @@setup_default_handlers.compare_and_set(0, 1)\n+    return unless success\n \n+    Crystal::SignalHandler.spawn\n     Signal::PIPE.ignore\n     Signal::CHLD.reset\n   end\n end\n \n # :nodoc:\n-fun __crystal_sigfault_handler(sig : LibC::Int, addr : Void*)\n-  Crystal.restore_blocking_state\n+module Crystal::SignalHandler\n+  # The number of libc functions that can be called safely from a signal(2)\n+  # handler is very limited. An usual safe solution is to use a pipe(2) and\n+  # just write the signal to the file descriptor and nothing more. A loop in\n+  # the main program is responsible for reading the signals back from the\n+  # pipe(2) and handle the signal there.\n+\n+  @@pipe = IO.pipe(read_blocking: false, write_blocking: true)\n+  @@procs = {} of Signal => Signal ->\n+  @@mutex = Mutex.new\n+\n+  def self.trap(signal, handler) : Nil\n+    @@mutex.synchronize do\n+      unless @@procs[signal]?\n+        LibC.signal(signal.value, ->(value : Int32) {\n+          writer.write_bytes(value)\n+        })\n+      end\n+      @@procs[signal] = handler\n+    end\n+  end\n+\n+  def self.reset(signal) : Nil\n+    set(signal, Proc(Int32, Void).new(Pointer(Void).new(0_u64), Pointer(Void).null))\n+  end\n \n-  # Capture fault signals (SEGV, BUS) and finish the process printing a backtrace first\n-  LibC.dprintf 2, \"Invalid memory access (signal %d) at address 0x%lx\\n\", sig, addr\n-  CallStack.print_backtrace\n-  LibC._exit sig\n+  def self.ignore(signal) : Nil\n+    set(signal, Proc(Int32, Void).new(Pointer(Void).new(1_u64), Pointer(Void).null))\n+  end\n+\n+  private def self.set(signal, handler)\n+    if signal == Signal::CHLD\n+      # don't reset/ignore SIGCHLD, Process#wait requires it\n+      trap(signal, ->(signal : Signal) {\n+        Crystal::SignalChildHandler.call\n+      })\n+    else\n+      @@mutex.synchronize do\n+        @@procs.delete(signal)\n+        LibC.signal(signal.value, handler)\n+      end\n+    end\n+  end\n+\n+  def self.spawn\n+    ::spawn do\n+      loop do\n+        value = reader.read_bytes(Int32)\n+        process(Signal.new(value))\n+      end\n+    end\n+  end\n+\n+  def self.process(signal) : Nil\n+    if handler = @@procs[signal]?\n+      handler.call(signal)\n+    else\n+      fatal(\"missing handler for #{signal}\")\n+    end\n+  rescue ex\n+    ex.inspect_with_backtrace(STDERR)\n+    fatal(\"uncaught exception while processing handler for #{signal}\")\n+  end\n+\n+  def self.after_fork\n+    @@pipe = IO.pipe(read_blocking: false, write_blocking: true)\n+  end\n+\n+  private def self.reader\n+    @@pipe[0]\n+  end\n+\n+  private def self.writer\n+    @@pipe[1]\n+  end\n+\n+  private def self.fatal(message : String)\n+    STDERR.puts(\"FATAL: #{message}, exiting\")\n+    STDERR.flush\n+    LibC._exit(1)","path":"src/signal.cr","position":275,"original_position":275,"commit_id":"42db52a666b18086c2f516ccafd00e86895a0f68","original_commit_id":"42db52a666b18086c2f516ccafd00e86895a0f68","user":{"login":"ysbaddaden","id":47380,"avatar_url":"https://avatars3.githubusercontent.com/u/47380?v=4","gravatar_id":"","url":"https://api.github.com/users/ysbaddaden","html_url":"https://github.com/ysbaddaden","followers_url":"https://api.github.com/users/ysbaddaden/followers","following_url":"https://api.github.com/users/ysbaddaden/following{/other_user}","gists_url":"https://api.github.com/users/ysbaddaden/gists{/gist_id}","starred_url":"https://api.github.com/users/ysbaddaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysbaddaden/subscriptions","organizations_url":"https://api.github.com/users/ysbaddaden/orgs","repos_url":"https://api.github.com/users/ysbaddaden/repos","events_url":"https://api.github.com/users/ysbaddaden/events{/privacy}","received_events_url":"https://api.github.com/users/ysbaddaden/received_events","type":"User","site_admin":false},"body":"Good point. Maybe a global `exit` immediately (and `abort(message)`) with some limited but required system cleanup could be nice? Sometimes skipping atexit handlers is useful (and sending SIGABRT).\r\n\r\nWhat should be done here? Just `exit(1)`?","created_at":"2018-02-19T14:05:30Z","updated_at":"2018-02-19T14:05:30Z","html_url":"https://github.com/crystal-lang/crystal/pull/5730#discussion_r169084372","pull_request_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5730","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments/169084372"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/5730#discussion_r169084372"},"pull_request":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5730"}},"in_reply_to_id":169036801},"pull_request":{"url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5730","id":169861041,"html_url":"https://github.com/crystal-lang/crystal/pull/5730","diff_url":"https://github.com/crystal-lang/crystal/pull/5730.diff","patch_url":"https://github.com/crystal-lang/crystal/pull/5730.patch","issue_url":"https://api.github.com/repos/crystal-lang/crystal/issues/5730","number":5730,"state":"open","locked":false,"title":"Refactor signal handlers","user":{"login":"ysbaddaden","id":47380,"avatar_url":"https://avatars3.githubusercontent.com/u/47380?v=4","gravatar_id":"","url":"https://api.github.com/users/ysbaddaden","html_url":"https://github.com/ysbaddaden","followers_url":"https://api.github.com/users/ysbaddaden/followers","following_url":"https://api.github.com/users/ysbaddaden/following{/other_user}","gists_url":"https://api.github.com/users/ysbaddaden/gists{/gist_id}","starred_url":"https://api.github.com/users/ysbaddaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysbaddaden/subscriptions","organizations_url":"https://api.github.com/users/ysbaddaden/orgs","repos_url":"https://api.github.com/users/ysbaddaden/repos","events_url":"https://api.github.com/users/ysbaddaden/events{/privacy}","received_events_url":"https://api.github.com/users/ysbaddaden/received_events","type":"User","site_admin":false},"body":"Move `SignalHandler` and `SignalChildEvent` from the `Event` to the `Crystal` namespace. Simplify implementation by using macros under enums (it wasn't possible before), with modules instead of singleton classes, and using `Channel` directly instead of `Concurrent::Future` —the stdlib doesn't use it anymore, and neither the `#delay`, `#future` or `#lazy` global methods.\r\n\r\nSynchronizes some accesses using a `Mutex` and an `Atomic` to further enhance potential concurrency issues. It's probably not possible until parallelism becomes a reality, so maybe it's not required.\r\n\r\nNo longer closes the pipe at exit, which prevents an unhandled exception when receiving a signal while the program is exiting.\r\n\r\nDoesn't ignore `SIGCHLD`, set the default `SignalChildHandler` instead, just like reset does. Maybe the `SIGCHLD` handler should never be replaced, since it will block `Process#wait` forever; maybe there ought to be a mechanism to be notified when a child has exited such as `Process.on_child_exit { |pid| }` instead.","created_at":"2018-02-19T00:50:27Z","updated_at":"2018-02-19T14:05:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46d2f1961a516f990dff564d5fb0a21df5ca5b1b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5730/commits","review_comments_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/5730/comments","review_comment_url":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/issues/5730/comments","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/42db52a666b18086c2f516ccafd00e86895a0f68","head":{"label":"ysbaddaden:core-refactor-signal-handlers","ref":"core-refactor-signal-handlers","sha":"42db52a666b18086c2f516ccafd00e86895a0f68","user":{"login":"ysbaddaden","id":47380,"avatar_url":"https://avatars3.githubusercontent.com/u/47380?v=4","gravatar_id":"","url":"https://api.github.com/users/ysbaddaden","html_url":"https://github.com/ysbaddaden","followers_url":"https://api.github.com/users/ysbaddaden/followers","following_url":"https://api.github.com/users/ysbaddaden/following{/other_user}","gists_url":"https://api.github.com/users/ysbaddaden/gists{/gist_id}","starred_url":"https://api.github.com/users/ysbaddaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysbaddaden/subscriptions","organizations_url":"https://api.github.com/users/ysbaddaden/orgs","repos_url":"https://api.github.com/users/ysbaddaden/repos","events_url":"https://api.github.com/users/ysbaddaden/events{/privacy}","received_events_url":"https://api.github.com/users/ysbaddaden/received_events","type":"User","site_admin":false},"repo":{"id":28955723,"name":"crystal","full_name":"ysbaddaden/crystal","owner":{"login":"ysbaddaden","id":47380,"avatar_url":"https://avatars3.githubusercontent.com/u/47380?v=4","gravatar_id":"","url":"https://api.github.com/users/ysbaddaden","html_url":"https://github.com/ysbaddaden","followers_url":"https://api.github.com/users/ysbaddaden/followers","following_url":"https://api.github.com/users/ysbaddaden/following{/other_user}","gists_url":"https://api.github.com/users/ysbaddaden/gists{/gist_id}","starred_url":"https://api.github.com/users/ysbaddaden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ysbaddaden/subscriptions","organizations_url":"https://api.github.com/users/ysbaddaden/orgs","repos_url":"https://api.github.com/users/ysbaddaden/repos","events_url":"https://api.github.com/users/ysbaddaden/events{/privacy}","received_events_url":"https://api.github.com/users/ysbaddaden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ysbaddaden/crystal","description":"The Crystal Programming Language","fork":true,"url":"https://api.github.com/repos/ysbaddaden/crystal","forks_url":"https://api.github.com/repos/ysbaddaden/crystal/forks","keys_url":"https://api.github.com/repos/ysbaddaden/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ysbaddaden/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ysbaddaden/crystal/teams","hooks_url":"https://api.github.com/repos/ysbaddaden/crystal/hooks","issue_events_url":"https://api.github.com/repos/ysbaddaden/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/ysbaddaden/crystal/events","assignees_url":"https://api.github.com/repos/ysbaddaden/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/ysbaddaden/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/ysbaddaden/crystal/tags","blobs_url":"https://api.github.com/repos/ysbaddaden/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ysbaddaden/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ysbaddaden/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/ysbaddaden/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ysbaddaden/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/ysbaddaden/crystal/languages","stargazers_url":"https://api.github.com/repos/ysbaddaden/crystal/stargazers","contributors_url":"https://api.github.com/repos/ysbaddaden/crystal/contributors","subscribers_url":"https://api.github.com/repos/ysbaddaden/crystal/subscribers","subscription_url":"https://api.github.com/repos/ysbaddaden/crystal/subscription","commits_url":"https://api.github.com/repos/ysbaddaden/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/ysbaddaden/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/ysbaddaden/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/ysbaddaden/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/ysbaddaden/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/ysbaddaden/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ysbaddaden/crystal/merges","archive_url":"https://api.github.com/repos/ysbaddaden/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ysbaddaden/crystal/downloads","issues_url":"https://api.github.com/repos/ysbaddaden/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/ysbaddaden/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/ysbaddaden/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/ysbaddaden/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ysbaddaden/crystal/labels{/name}","releases_url":"https://api.github.com/repos/ysbaddaden/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/ysbaddaden/crystal/deployments","created_at":"2015-01-08T08:08:48Z","updated_at":"2017-09-27T18:23:57Z","pushed_at":"2018-02-19T09:44:49Z","git_url":"git://github.com/ysbaddaden/crystal.git","ssh_url":"git@github.com:ysbaddaden/crystal.git","clone_url":"https://github.com/ysbaddaden/crystal.git","svn_url":"https://github.com/ysbaddaden/crystal","homepage":"http://crystal-lang.org","size":40530,"stargazers_count":1,"watchers_count":1,"language":"Crystal","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"crystal-lang:master","ref":"master","sha":"4f2e846a503fea183ec9a932a9dab06bea388911","user":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":6887813,"name":"crystal","full_name":"crystal-lang/crystal","owner":{"login":"crystal-lang","id":6539796,"avatar_url":"https://avatars0.githubusercontent.com/u/6539796?v=4","gravatar_id":"","url":"https://api.github.com/users/crystal-lang","html_url":"https://github.com/crystal-lang","followers_url":"https://api.github.com/users/crystal-lang/followers","following_url":"https://api.github.com/users/crystal-lang/following{/other_user}","gists_url":"https://api.github.com/users/crystal-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/crystal-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crystal-lang/subscriptions","organizations_url":"https://api.github.com/users/crystal-lang/orgs","repos_url":"https://api.github.com/users/crystal-lang/repos","events_url":"https://api.github.com/users/crystal-lang/events{/privacy}","received_events_url":"https://api.github.com/users/crystal-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crystal-lang/crystal","description":"The Crystal Programming Language","fork":false,"url":"https://api.github.com/repos/crystal-lang/crystal","forks_url":"https://api.github.com/repos/crystal-lang/crystal/forks","keys_url":"https://api.github.com/repos/crystal-lang/crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crystal-lang/crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crystal-lang/crystal/teams","hooks_url":"https://api.github.com/repos/crystal-lang/crystal/hooks","issue_events_url":"https://api.github.com/repos/crystal-lang/crystal/issues/events{/number}","events_url":"https://api.github.com/repos/crystal-lang/crystal/events","assignees_url":"https://api.github.com/repos/crystal-lang/crystal/assignees{/user}","branches_url":"https://api.github.com/repos/crystal-lang/crystal/branches{/branch}","tags_url":"https://api.github.com/repos/crystal-lang/crystal/tags","blobs_url":"https://api.github.com/repos/crystal-lang/crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crystal-lang/crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crystal-lang/crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/crystal-lang/crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crystal-lang/crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/crystal-lang/crystal/languages","stargazers_url":"https://api.github.com/repos/crystal-lang/crystal/stargazers","contributors_url":"https://api.github.com/repos/crystal-lang/crystal/contributors","subscribers_url":"https://api.github.com/repos/crystal-lang/crystal/subscribers","subscription_url":"https://api.github.com/repos/crystal-lang/crystal/subscription","commits_url":"https://api.github.com/repos/crystal-lang/crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/crystal-lang/crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/crystal-lang/crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/crystal-lang/crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/crystal-lang/crystal/contents/{+path}","compare_url":"https://api.github.com/repos/crystal-lang/crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crystal-lang/crystal/merges","archive_url":"https://api.github.com/repos/crystal-lang/crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crystal-lang/crystal/downloads","issues_url":"https://api.github.com/repos/crystal-lang/crystal/issues{/number}","pulls_url":"https://api.github.com/repos/crystal-lang/crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/crystal-lang/crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/crystal-lang/crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crystal-lang/crystal/labels{/name}","releases_url":"https://api.github.com/repos/crystal-lang/crystal/releases{/id}","deployments_url":"https://api.github.com/repos/crystal-lang/crystal/deployments","created_at":"2012-11-27T17:32:32Z","updated_at":"2018-02-19T10:02:45Z","pushed_at":"2018-02-19T09:44:50Z","git_url":"git://github.com/crystal-lang/crystal.git","ssh_url":"git@github.com:crystal-lang/crystal.git","clone_url":"https://github.com/crystal-lang/crystal.git","svn_url":"https://github.com/crystal-lang/crystal","homepage":"https://crystal-lang.org","size":36176,"stargazers_count":10246,"watchers_count":10246,"language":"Crystal","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":815,"mirror_url":null,"archived":false,"open_issues_count":622,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":815,"open_issues":622,"watchers":10246,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5730"},"html":{"href":"https://github.com/crystal-lang/crystal/pull/5730"},"issue":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/5730"},"comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/issues/5730/comments"},"review_comments":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5730/comments"},"review_comment":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crystal-lang/crystal/pulls/5730/commits"},"statuses":{"href":"https://api.github.com/repos/crystal-lang/crystal/statuses/42db52a666b18086c2f516ccafd00e86895a0f68"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ysbaddaden"}}