{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/216503387","pull_request_review_id":153999566,"id":216503387,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjUwMzM4Nw==","diff_hunk":"@@ -2288,6 +2295,25 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo\n     // Preload Tablet sounds\n     DependencyManager::get<TabletScriptingInterface>()->preloadSounds();\n \n+    connect(this, &Application::interstitialModeChanged, this, [this] (bool interstitialMode) {\n+        if (!interstitialMode) {\n+            DependencyManager::get<AudioClient>()->negotiateAudioFormat();\n+            _queryExpiry = SteadyClock::now();\n+            if (_avatarOverrideUrl.isValid()) {\n+                getMyAvatar()->useFullAvatarURL(_avatarOverrideUrl);\n+            }\n+\n+            if (getMyAvatar()->getFullAvatarURLFromPreferences() != getMyAvatar()->getSkeletonModelURL()) {\n+                getMyAvatar()->resetFullAvatarURL();\n+            }\n+            getMyAvatar()->markIdentityDataChanged();\n+            getMyAvatar()->resetLastSent();\n+\n+            // transmit a \"sendAll\" packet to the AvatarMixer we just connected to.\n+            getMyAvatar()->sendAvatarDataPacket(true);\n+        }\n+    });","path":"interface/src/Application.cpp","position":72,"original_position":72,"commit_id":"45b2098346b8ee716e08a99e4511cc40715cfbe2","original_commit_id":"45b2098346b8ee716e08a99e4511cc40715cfbe2","user":{"login":"birarda","id":724069,"node_id":"MDQ6VXNlcjcyNDA2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/724069?v=4","gravatar_id":"","url":"https://api.github.com/users/birarda","html_url":"https://github.com/birarda","followers_url":"https://api.github.com/users/birarda/followers","following_url":"https://api.github.com/users/birarda/following{/other_user}","gists_url":"https://api.github.com/users/birarda/gists{/gist_id}","starred_url":"https://api.github.com/users/birarda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/birarda/subscriptions","organizations_url":"https://api.github.com/users/birarda/orgs","repos_url":"https://api.github.com/users/birarda/repos","events_url":"https://api.github.com/users/birarda/events{/privacy}","received_events_url":"https://api.github.com/users/birarda/received_events","type":"User","site_admin":false},"body":"We should make the actions in here happen when you connect to the appropriate server that they apply to, not wholesale here whenever we drop the interstitial","created_at":"2018-09-10T23:12:05Z","updated_at":"2018-09-10T23:27:24Z","html_url":"https://github.com/highfidelity/hifi/pull/13938#discussion_r216503387","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13938","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/216503387"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13938#discussion_r216503387"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13938"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13938","id":213181158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTgxMTU4","html_url":"https://github.com/highfidelity/hifi/pull/13938","diff_url":"https://github.com/highfidelity/hifi/pull/13938.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13938.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13938","number":13938,"state":"open","locked":false,"title":"Interstitial Page with 404 Redirect","user":{"login":"wayne-chen","id":10539521,"node_id":"MDQ6VXNlcjEwNTM5NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10539521?v=4","gravatar_id":"","url":"https://api.github.com/users/wayne-chen","html_url":"https://github.com/wayne-chen","followers_url":"https://api.github.com/users/wayne-chen/followers","following_url":"https://api.github.com/users/wayne-chen/following{/other_user}","gists_url":"https://api.github.com/users/wayne-chen/gists{/gist_id}","starred_url":"https://api.github.com/users/wayne-chen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayne-chen/subscriptions","organizations_url":"https://api.github.com/users/wayne-chen/orgs","repos_url":"https://api.github.com/users/wayne-chen/repos","events_url":"https://api.github.com/users/wayne-chen/events{/privacy}","received_events_url":"https://api.github.com/users/wayne-chen/received_events","type":"User","site_admin":false},"body":"- Implementation of #13923 and #13744 merged together\r\n\r\n- directions\r\n1. Under developer menu check `Enable Interstitial`\r\n2. Run the interstitialPage.js under system directory \r\n\r\n- note. The interstitial mode is disabled when physics is enabled. The is a current bug in master which physics does not get enabled. If this happens to you, toggle `Show Overlays` menu option under developer and the toolbar should appear, then just goto a different domain.\r\n\r\n- getting to the 404 redirect serverless domain\r\n1. go to a domain where the connection is refused as a \"Not Authorized\" for the user or there is a protocol mismatch","created_at":"2018-09-05T06:23:33Z","updated_at":"2018-09-10T23:27:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5a3d30b24a1c956972d85134f3da2560fe47278","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sethalves","id":1137072,"node_id":"MDQ6VXNlcjExMzcwNzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1137072?v=4","gravatar_id":"","url":"https://api.github.com/users/sethalves","html_url":"https://github.com/sethalves","followers_url":"https://api.github.com/users/sethalves/followers","following_url":"https://api.github.com/users/sethalves/following{/other_user}","gists_url":"https://api.github.com/users/sethalves/gists{/gist_id}","starred_url":"https://api.github.com/users/sethalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethalves/subscriptions","organizations_url":"https://api.github.com/users/sethalves/orgs","repos_url":"https://api.github.com/users/sethalves/repos","events_url":"https://api.github.com/users/sethalves/events{/privacy}","received_events_url":"https://api.github.com/users/sethalves/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":907795710,"node_id":"MDU6TGFiZWw5MDc3OTU3MTA=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Android%20Smoke%20Required","name":"Android Smoke Required","color":"fbca04","default":false},{"id":743411186,"node_id":"MDU6TGFiZWw3NDM0MTExODY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Client","name":"Client","color":"2872fc","default":false},{"id":278749229,"node_id":"MDU6TGFiZWwyNzg3NDkyMjk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Feedback%20Welcome","name":"Feedback Welcome","color":"cafc94","default":false},{"id":314155316,"node_id":"MDU6TGFiZWwzMTQxNTUzMTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Approved%20:tada:","name":"QA Approved :tada:","color":"009800","default":false}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/33","html_url":"https://github.com/highfidelity/hifi/milestone/33","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/33/labels","id":3290832,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzMg==","number":33,"title":"v0.73.0","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":74,"state":"open","created_at":"2018-04-23T19:27:12Z","updated_at":"2018-09-10T22:42:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13938/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13938/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13938/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/45b2098346b8ee716e08a99e4511cc40715cfbe2","head":{"label":"wayne-chen:interstitalMerged","ref":"interstitalMerged","sha":"45b2098346b8ee716e08a99e4511cc40715cfbe2","user":{"login":"wayne-chen","id":10539521,"node_id":"MDQ6VXNlcjEwNTM5NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10539521?v=4","gravatar_id":"","url":"https://api.github.com/users/wayne-chen","html_url":"https://github.com/wayne-chen","followers_url":"https://api.github.com/users/wayne-chen/followers","following_url":"https://api.github.com/users/wayne-chen/following{/other_user}","gists_url":"https://api.github.com/users/wayne-chen/gists{/gist_id}","starred_url":"https://api.github.com/users/wayne-chen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayne-chen/subscriptions","organizations_url":"https://api.github.com/users/wayne-chen/orgs","repos_url":"https://api.github.com/users/wayne-chen/repos","events_url":"https://api.github.com/users/wayne-chen/events{/privacy}","received_events_url":"https://api.github.com/users/wayne-chen/received_events","type":"User","site_admin":false},"repo":{"id":132780358,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI3ODAzNTg=","name":"hifi","full_name":"wayne-chen/hifi","owner":{"login":"wayne-chen","id":10539521,"node_id":"MDQ6VXNlcjEwNTM5NTIx","avatar_url":"https://avatars1.githubusercontent.com/u/10539521?v=4","gravatar_id":"","url":"https://api.github.com/users/wayne-chen","html_url":"https://github.com/wayne-chen","followers_url":"https://api.github.com/users/wayne-chen/followers","following_url":"https://api.github.com/users/wayne-chen/following{/other_user}","gists_url":"https://api.github.com/users/wayne-chen/gists{/gist_id}","starred_url":"https://api.github.com/users/wayne-chen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayne-chen/subscriptions","organizations_url":"https://api.github.com/users/wayne-chen/orgs","repos_url":"https://api.github.com/users/wayne-chen/repos","events_url":"https://api.github.com/users/wayne-chen/events{/privacy}","received_events_url":"https://api.github.com/users/wayne-chen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wayne-chen/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":true,"url":"https://api.github.com/repos/wayne-chen/hifi","forks_url":"https://api.github.com/repos/wayne-chen/hifi/forks","keys_url":"https://api.github.com/repos/wayne-chen/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wayne-chen/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wayne-chen/hifi/teams","hooks_url":"https://api.github.com/repos/wayne-chen/hifi/hooks","issue_events_url":"https://api.github.com/repos/wayne-chen/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/wayne-chen/hifi/events","assignees_url":"https://api.github.com/repos/wayne-chen/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/wayne-chen/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/wayne-chen/hifi/tags","blobs_url":"https://api.github.com/repos/wayne-chen/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wayne-chen/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wayne-chen/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/wayne-chen/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wayne-chen/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/wayne-chen/hifi/languages","stargazers_url":"https://api.github.com/repos/wayne-chen/hifi/stargazers","contributors_url":"https://api.github.com/repos/wayne-chen/hifi/contributors","subscribers_url":"https://api.github.com/repos/wayne-chen/hifi/subscribers","subscription_url":"https://api.github.com/repos/wayne-chen/hifi/subscription","commits_url":"https://api.github.com/repos/wayne-chen/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/wayne-chen/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/wayne-chen/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/wayne-chen/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/wayne-chen/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/wayne-chen/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wayne-chen/hifi/merges","archive_url":"https://api.github.com/repos/wayne-chen/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wayne-chen/hifi/downloads","issues_url":"https://api.github.com/repos/wayne-chen/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/wayne-chen/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/wayne-chen/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/wayne-chen/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wayne-chen/hifi/labels{/name}","releases_url":"https://api.github.com/repos/wayne-chen/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/wayne-chen/hifi/deployments","created_at":"2018-05-09T15:54:06Z","updated_at":"2018-09-07T02:44:44Z","pushed_at":"2018-09-10T22:33:57Z","git_url":"git://github.com/wayne-chen/hifi.git","ssh_url":"git@github.com:wayne-chen/hifi.git","clone_url":"https://github.com/wayne-chen/hifi.git","svn_url":"https://github.com/wayne-chen/hifi","homepage":"","size":554778,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"7bbedf65c7e456ffb0723f25f435672d55db2461","user":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"node_id":"MDEwOlJlcG9zaXRvcnk1MzcyODcy","name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-09-10T22:42:21Z","pushed_at":"2018-09-10T23:25:28Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":557303,"stargazers_count":644,"watchers_count":644,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":412,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":412,"open_issues":176,"watchers":644,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13938"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13938"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13938"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13938/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13938/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13938/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/45b2098346b8ee716e08a99e4511cc40715cfbe2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"birarda"}}