{"action":"created","comment":{"url":"https://api.github.com/repos/Yoast/yoastcs/pulls/comments/219404027","pull_request_review_id":157571325,"id":219404027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTQwNDAyNw==","diff_hunk":"@@ -0,0 +1,56 @@\n+<?php\n+\n+class SomeThing {\n+\n+\t/**\n+\t * Active (non-deprecated) function.\n+\t */\n+\tfunction activeFunction() {}\n+\n+\t/**\n+\t * @deprecated x.x\n+\t * @codeCoverageIgnore\n+\t */\n+\tpublic /* don't get confused by this */ function correctDocblock() {\n+\t\t// Code\n+    } // end function\n+\n+    public function functionWithoutDocblock {}","path":"Yoast/Tests/Commenting/CodeCoverageIgnoreDeprecatedUnitTest.inc.fixed","position":18,"original_position":18,"commit_id":"04b8e943aafd5ad68b26af88d4b8acc322d30586","original_commit_id":"04b8e943aafd5ad68b26af88d4b8acc322d30586","user":{"login":"afercia","id":1682452,"node_id":"MDQ6VXNlcjE2ODI0NTI=","avatar_url":"https://avatars1.githubusercontent.com/u/1682452?v=4","gravatar_id":"","url":"https://api.github.com/users/afercia","html_url":"https://github.com/afercia","followers_url":"https://api.github.com/users/afercia/followers","following_url":"https://api.github.com/users/afercia/following{/other_user}","gists_url":"https://api.github.com/users/afercia/gists{/gist_id}","starred_url":"https://api.github.com/users/afercia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afercia/subscriptions","organizations_url":"https://api.github.com/users/afercia/orgs","repos_url":"https://api.github.com/users/afercia/repos","events_url":"https://api.github.com/users/afercia/events{/privacy}","received_events_url":"https://api.github.com/users/afercia/received_events","type":"User","site_admin":false},"body":"please notice this line uses spaces for indentation, it should use a tab character","created_at":"2018-09-21T07:21:29Z","updated_at":"2018-09-21T07:21:29Z","html_url":"https://github.com/Yoast/yoastcs/pull/96#discussion_r219404027","pull_request_url":"https://api.github.com/repos/Yoast/yoastcs/pulls/96","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Yoast/yoastcs/pulls/comments/219404027"},"html":{"href":"https://github.com/Yoast/yoastcs/pull/96#discussion_r219404027"},"pull_request":{"href":"https://api.github.com/repos/Yoast/yoastcs/pulls/96"}}},"pull_request":{"url":"https://api.github.com/repos/Yoast/yoastcs/pulls/96","id":216968774,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTY4Nzc0","html_url":"https://github.com/Yoast/yoastcs/pull/96","diff_url":"https://github.com/Yoast/yoastcs/pull/96.diff","patch_url":"https://github.com/Yoast/yoastcs/pull/96.patch","issue_url":"https://api.github.com/repos/Yoast/yoastcs/issues/96","number":96,"state":"closed","locked":false,"title":"New `CodeCoverageIgnoreDeprecated` sniff","user":{"login":"jrfnl","id":663378,"node_id":"MDQ6VXNlcjY2MzM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/663378?v=4","gravatar_id":"","url":"https://api.github.com/users/jrfnl","html_url":"https://github.com/jrfnl","followers_url":"https://api.github.com/users/jrfnl/followers","following_url":"https://api.github.com/users/jrfnl/following{/other_user}","gists_url":"https://api.github.com/users/jrfnl/gists{/gist_id}","starred_url":"https://api.github.com/users/jrfnl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrfnl/subscriptions","organizations_url":"https://api.github.com/users/jrfnl/orgs","repos_url":"https://api.github.com/users/jrfnl/repos","events_url":"https://api.github.com/users/jrfnl/events{/privacy}","received_events_url":"https://api.github.com/users/jrfnl/received_events","type":"User","site_admin":false},"body":"This sniff will check that functions which have a `@deprecated` tag in the function docblock, also have a  `@codeCoverageIgnore` tag in the same docblock.\r\n\r\nIf a `codeCoverageIgnore` text is found without the `@` sign, it will be recognized by the sniff and can be auto-fixed.\r\n\r\nIndividual plugins may have certain files `exclude`d for codeCoverage in the PHPUnit configuration file.\r\nFor those plugins corresponding `exclude`s need to be added to the PHPCS configuration file to ignore those files completely for the purposes of this sniff.\r\n\r\nExample:\r\n```xml\r\n<rule ref=\"Yoast.Commenting.CodeCoverageIgnoreDeprecated\">\r\n    <exclude-pattern>*/deprecated/*\\.php$</exclude-pattern>\r\n</rule>\r\n```\r\n\r\nFixes #95","created_at":"2018-09-20T13:18:49Z","updated_at":"2018-09-21T07:21:29Z","closed_at":"2018-09-21T07:18:42Z","merged_at":"2018-09-21T07:18:41Z","merge_commit_sha":"3d276b6749f3f78005ba950b5a5e0649610619b1","assignee":{"login":"moorscode","id":2005352,"node_id":"MDQ6VXNlcjIwMDUzNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2005352?v=4","gravatar_id":"","url":"https://api.github.com/users/moorscode","html_url":"https://github.com/moorscode","followers_url":"https://api.github.com/users/moorscode/followers","following_url":"https://api.github.com/users/moorscode/following{/other_user}","gists_url":"https://api.github.com/users/moorscode/gists{/gist_id}","starred_url":"https://api.github.com/users/moorscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorscode/subscriptions","organizations_url":"https://api.github.com/users/moorscode/orgs","repos_url":"https://api.github.com/users/moorscode/repos","events_url":"https://api.github.com/users/moorscode/events{/privacy}","received_events_url":"https://api.github.com/users/moorscode/received_events","type":"User","site_admin":false},"assignees":[{"login":"moorscode","id":2005352,"node_id":"MDQ6VXNlcjIwMDUzNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2005352?v=4","gravatar_id":"","url":"https://api.github.com/users/moorscode","html_url":"https://github.com/moorscode","followers_url":"https://api.github.com/users/moorscode/followers","following_url":"https://api.github.com/users/moorscode/following{/other_user}","gists_url":"https://api.github.com/users/moorscode/gists{/gist_id}","starred_url":"https://api.github.com/users/moorscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorscode/subscriptions","organizations_url":"https://api.github.com/users/moorscode/orgs","repos_url":"https://api.github.com/users/moorscode/repos","events_url":"https://api.github.com/users/moorscode/events{/privacy}","received_events_url":"https://api.github.com/users/moorscode/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/Yoast/yoastcs/milestones/6","html_url":"https://github.com/Yoast/yoastcs/milestone/6","labels_url":"https://api.github.com/repos/Yoast/yoastcs/milestones/6/labels","id":3676848,"node_id":"MDk6TWlsZXN0b25lMzY3Njg0OA==","number":6,"title":"1.1","description":null,"creator":{"login":"moorscode","id":2005352,"node_id":"MDQ6VXNlcjIwMDUzNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/2005352?v=4","gravatar_id":"","url":"https://api.github.com/users/moorscode","html_url":"https://github.com/moorscode","followers_url":"https://api.github.com/users/moorscode/followers","following_url":"https://api.github.com/users/moorscode/following{/other_user}","gists_url":"https://api.github.com/users/moorscode/gists{/gist_id}","starred_url":"https://api.github.com/users/moorscode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moorscode/subscriptions","organizations_url":"https://api.github.com/users/moorscode/orgs","repos_url":"https://api.github.com/users/moorscode/repos","events_url":"https://api.github.com/users/moorscode/events{/privacy}","received_events_url":"https://api.github.com/users/moorscode/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":1,"state":"open","created_at":"2018-09-21T07:19:19Z","updated_at":"2018-09-21T07:19:19Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/Yoast/yoastcs/pulls/96/commits","review_comments_url":"https://api.github.com/repos/Yoast/yoastcs/pulls/96/comments","review_comment_url":"https://api.github.com/repos/Yoast/yoastcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yoast/yoastcs/issues/96/comments","statuses_url":"https://api.github.com/repos/Yoast/yoastcs/statuses/04b8e943aafd5ad68b26af88d4b8acc322d30586","head":{"label":"Yoast:JRF/95-new-sniff-deprecated-no-code-coverage","ref":"JRF/95-new-sniff-deprecated-no-code-coverage","sha":"04b8e943aafd5ad68b26af88d4b8acc322d30586","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":30643578,"node_id":"MDEwOlJlcG9zaXRvcnkzMDY0MzU3OA==","name":"yoastcs","full_name":"Yoast/yoastcs","private":false,"owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yoast/yoastcs","description":"Yoast coding standards","fork":false,"url":"https://api.github.com/repos/Yoast/yoastcs","forks_url":"https://api.github.com/repos/Yoast/yoastcs/forks","keys_url":"https://api.github.com/repos/Yoast/yoastcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/yoastcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/yoastcs/teams","hooks_url":"https://api.github.com/repos/Yoast/yoastcs/hooks","issue_events_url":"https://api.github.com/repos/Yoast/yoastcs/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/yoastcs/events","assignees_url":"https://api.github.com/repos/Yoast/yoastcs/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/yoastcs/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/yoastcs/tags","blobs_url":"https://api.github.com/repos/Yoast/yoastcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/yoastcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/yoastcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/yoastcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/yoastcs/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/yoastcs/languages","stargazers_url":"https://api.github.com/repos/Yoast/yoastcs/stargazers","contributors_url":"https://api.github.com/repos/Yoast/yoastcs/contributors","subscribers_url":"https://api.github.com/repos/Yoast/yoastcs/subscribers","subscription_url":"https://api.github.com/repos/Yoast/yoastcs/subscription","commits_url":"https://api.github.com/repos/Yoast/yoastcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/yoastcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/yoastcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/yoastcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/yoastcs/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/yoastcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/yoastcs/merges","archive_url":"https://api.github.com/repos/Yoast/yoastcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/yoastcs/downloads","issues_url":"https://api.github.com/repos/Yoast/yoastcs/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/yoastcs/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/yoastcs/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/yoastcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/yoastcs/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/yoastcs/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/yoastcs/deployments","created_at":"2015-02-11T10:54:20Z","updated_at":"2018-09-21T07:18:45Z","pushed_at":"2018-09-21T07:18:45Z","git_url":"git://github.com/Yoast/yoastcs.git","ssh_url":"git@github.com:Yoast/yoastcs.git","clone_url":"https://github.com/Yoast/yoastcs.git","svn_url":"https://github.com/Yoast/yoastcs","homepage":"","size":200,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":9,"watchers":12,"default_branch":"develop"}},"base":{"label":"Yoast:develop","ref":"develop","sha":"9ee407ea42200d2cbc788192d44df9cb99034fe1","user":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"repo":{"id":30643578,"node_id":"MDEwOlJlcG9zaXRvcnkzMDY0MzU3OA==","name":"yoastcs","full_name":"Yoast/yoastcs","private":false,"owner":{"login":"Yoast","id":4690436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2OTA0MzY=","avatar_url":"https://avatars0.githubusercontent.com/u/4690436?v=4","gravatar_id":"","url":"https://api.github.com/users/Yoast","html_url":"https://github.com/Yoast","followers_url":"https://api.github.com/users/Yoast/followers","following_url":"https://api.github.com/users/Yoast/following{/other_user}","gists_url":"https://api.github.com/users/Yoast/gists{/gist_id}","starred_url":"https://api.github.com/users/Yoast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yoast/subscriptions","organizations_url":"https://api.github.com/users/Yoast/orgs","repos_url":"https://api.github.com/users/Yoast/repos","events_url":"https://api.github.com/users/Yoast/events{/privacy}","received_events_url":"https://api.github.com/users/Yoast/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Yoast/yoastcs","description":"Yoast coding standards","fork":false,"url":"https://api.github.com/repos/Yoast/yoastcs","forks_url":"https://api.github.com/repos/Yoast/yoastcs/forks","keys_url":"https://api.github.com/repos/Yoast/yoastcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yoast/yoastcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yoast/yoastcs/teams","hooks_url":"https://api.github.com/repos/Yoast/yoastcs/hooks","issue_events_url":"https://api.github.com/repos/Yoast/yoastcs/issues/events{/number}","events_url":"https://api.github.com/repos/Yoast/yoastcs/events","assignees_url":"https://api.github.com/repos/Yoast/yoastcs/assignees{/user}","branches_url":"https://api.github.com/repos/Yoast/yoastcs/branches{/branch}","tags_url":"https://api.github.com/repos/Yoast/yoastcs/tags","blobs_url":"https://api.github.com/repos/Yoast/yoastcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yoast/yoastcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yoast/yoastcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yoast/yoastcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yoast/yoastcs/statuses/{sha}","languages_url":"https://api.github.com/repos/Yoast/yoastcs/languages","stargazers_url":"https://api.github.com/repos/Yoast/yoastcs/stargazers","contributors_url":"https://api.github.com/repos/Yoast/yoastcs/contributors","subscribers_url":"https://api.github.com/repos/Yoast/yoastcs/subscribers","subscription_url":"https://api.github.com/repos/Yoast/yoastcs/subscription","commits_url":"https://api.github.com/repos/Yoast/yoastcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yoast/yoastcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yoast/yoastcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yoast/yoastcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yoast/yoastcs/contents/{+path}","compare_url":"https://api.github.com/repos/Yoast/yoastcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yoast/yoastcs/merges","archive_url":"https://api.github.com/repos/Yoast/yoastcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yoast/yoastcs/downloads","issues_url":"https://api.github.com/repos/Yoast/yoastcs/issues{/number}","pulls_url":"https://api.github.com/repos/Yoast/yoastcs/pulls{/number}","milestones_url":"https://api.github.com/repos/Yoast/yoastcs/milestones{/number}","notifications_url":"https://api.github.com/repos/Yoast/yoastcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yoast/yoastcs/labels{/name}","releases_url":"https://api.github.com/repos/Yoast/yoastcs/releases{/id}","deployments_url":"https://api.github.com/repos/Yoast/yoastcs/deployments","created_at":"2015-02-11T10:54:20Z","updated_at":"2018-09-21T07:18:45Z","pushed_at":"2018-09-21T07:18:45Z","git_url":"git://github.com/Yoast/yoastcs.git","ssh_url":"git@github.com:Yoast/yoastcs.git","clone_url":"https://github.com/Yoast/yoastcs.git","svn_url":"https://github.com/Yoast/yoastcs","homepage":"","size":200,"stargazers_count":12,"watchers_count":12,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":9,"watchers":12,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Yoast/yoastcs/pulls/96"},"html":{"href":"https://github.com/Yoast/yoastcs/pull/96"},"issue":{"href":"https://api.github.com/repos/Yoast/yoastcs/issues/96"},"comments":{"href":"https://api.github.com/repos/Yoast/yoastcs/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/Yoast/yoastcs/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/Yoast/yoastcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yoast/yoastcs/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/Yoast/yoastcs/statuses/04b8e943aafd5ad68b26af88d4b8acc322d30586"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"afercia"}}