{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico/pulls/comments/234760316","pull_request_review_id":176471174,"id":234760316,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDc2MDMxNg==","diff_hunk":"@@ -149,6 +149,26 @@ To use these manifests with a TLS-enabled etcd cluster you must do the following\n Depending on your cluster's authorization mode, you'll want to back these\n service accounts with the necessary permissions.\n \n+### Configuring service advertisement\n+\n+{{site.prodname}} supports [advertising Kubernetes services over\n+BGP]({{site.baseurl}}/{{page.version}}/usage/service-advertisement),\n+so that service cluster IPs are routable from outside the cluster.  To\n+enable this, add an `ADVERTISE_CLUSTER_IPS` variable setting to the\n+environment for {{site.nodecontainer}} in the `calico.yaml` manifest,\n+with value equal to the cluster IP range for your Kubernetes cluster;\n+for example:\n+\n+```yaml\n+          env:\n+            [...]\n+            - name: ADVERTISE_CLUSTER_IPS","path":"master/getting-started/kubernetes/installation/config-options.md","position":17,"original_position":17,"commit_id":"390524072ceff3d16fd61c09aeb00aa324a6c12a","original_commit_id":"390524072ceff3d16fd61c09aeb00aa324a6c12a","user":{"login":"caseydavenport","id":1944093,"node_id":"MDQ6VXNlcjE5NDQwOTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1944093?v=4","gravatar_id":"","url":"https://api.github.com/users/caseydavenport","html_url":"https://github.com/caseydavenport","followers_url":"https://api.github.com/users/caseydavenport/followers","following_url":"https://api.github.com/users/caseydavenport/following{/other_user}","gists_url":"https://api.github.com/users/caseydavenport/gists{/gist_id}","starred_url":"https://api.github.com/users/caseydavenport/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caseydavenport/subscriptions","organizations_url":"https://api.github.com/users/caseydavenport/orgs","repos_url":"https://api.github.com/users/caseydavenport/repos","events_url":"https://api.github.com/users/caseydavenport/events{/privacy}","received_events_url":"https://api.github.com/users/caseydavenport/received_events","type":"User","site_admin":false},"body":"Also, looks like the code currently supports `CALICO_ADVERTISE_CLUSTER_IPS`.\r\n\r\nSo, either need to make the code support both or update this value here. WDYT?","created_at":"2018-11-19T19:55:35Z","updated_at":"2018-11-19T19:55:35Z","html_url":"https://github.com/projectcalico/calico/pull/2303#discussion_r234760316","pull_request_url":"https://api.github.com/repos/projectcalico/calico/pulls/2303","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/comments/234760316"},"html":{"href":"https://github.com/projectcalico/calico/pull/2303#discussion_r234760316"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/2303"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico/pulls/2303","id":231991625,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxOTkxNjI1","html_url":"https://github.com/projectcalico/calico/pull/2303","diff_url":"https://github.com/projectcalico/calico/pull/2303.diff","patch_url":"https://github.com/projectcalico/calico/pull/2303.patch","issue_url":"https://api.github.com/repos/projectcalico/calico/issues/2303","number":2303,"state":"open","locked":false,"title":"Doc for service advertisement","user":{"login":"neiljerram","id":2089263,"node_id":"MDQ6VXNlcjIwODkyNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2089263?v=4","gravatar_id":"","url":"https://api.github.com/users/neiljerram","html_url":"https://github.com/neiljerram","followers_url":"https://api.github.com/users/neiljerram/followers","following_url":"https://api.github.com/users/neiljerram/following{/other_user}","gists_url":"https://api.github.com/users/neiljerram/gists{/gist_id}","starred_url":"https://api.github.com/users/neiljerram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neiljerram/subscriptions","organizations_url":"https://api.github.com/users/neiljerram/orgs","repos_url":"https://api.github.com/users/neiljerram/repos","events_url":"https://api.github.com/users/neiljerram/events{/privacy}","received_events_url":"https://api.github.com/users/neiljerram/received_events","type":"User","site_admin":false},"body":"## Release Note\r\n```release-note\r\nCalico now supports advertising Kubernetes service cluster IPs over BGP.\r\n```\r\n","created_at":"2018-11-19T14:25:56Z","updated_at":"2018-11-19T19:55:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fad86bdff27fcd32d8d8babb3272d1ae4b2874f1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"emanic","id":9090088,"node_id":"MDQ6VXNlcjkwOTAwODg=","avatar_url":"https://avatars1.githubusercontent.com/u/9090088?v=4","gravatar_id":"","url":"https://api.github.com/users/emanic","html_url":"https://github.com/emanic","followers_url":"https://api.github.com/users/emanic/followers","following_url":"https://api.github.com/users/emanic/following{/other_user}","gists_url":"https://api.github.com/users/emanic/gists{/gist_id}","starred_url":"https://api.github.com/users/emanic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanic/subscriptions","organizations_url":"https://api.github.com/users/emanic/orgs","repos_url":"https://api.github.com/users/emanic/repos","events_url":"https://api.github.com/users/emanic/events{/privacy}","received_events_url":"https://api.github.com/users/emanic/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":645037259,"node_id":"MDU6TGFiZWw2NDUwMzcyNTk=","url":"https://api.github.com/repos/projectcalico/calico/labels/release-note-required","name":"release-note-required","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calico/pulls/2303/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico/pulls/2303/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico/issues/2303/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico/statuses/390524072ceff3d16fd61c09aeb00aa324a6c12a","head":{"label":"neiljerram:service-advertisement","ref":"service-advertisement","sha":"390524072ceff3d16fd61c09aeb00aa324a6c12a","user":{"login":"neiljerram","id":2089263,"node_id":"MDQ6VXNlcjIwODkyNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2089263?v=4","gravatar_id":"","url":"https://api.github.com/users/neiljerram","html_url":"https://github.com/neiljerram","followers_url":"https://api.github.com/users/neiljerram/followers","following_url":"https://api.github.com/users/neiljerram/following{/other_user}","gists_url":"https://api.github.com/users/neiljerram/gists{/gist_id}","starred_url":"https://api.github.com/users/neiljerram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neiljerram/subscriptions","organizations_url":"https://api.github.com/users/neiljerram/orgs","repos_url":"https://api.github.com/users/neiljerram/repos","events_url":"https://api.github.com/users/neiljerram/events{/privacy}","received_events_url":"https://api.github.com/users/neiljerram/received_events","type":"User","site_admin":false},"repo":{"id":73129445,"node_id":"MDEwOlJlcG9zaXRvcnk3MzEyOTQ0NQ==","name":"calico","full_name":"neiljerram/calico","private":false,"owner":{"login":"neiljerram","id":2089263,"node_id":"MDQ6VXNlcjIwODkyNjM=","avatar_url":"https://avatars1.githubusercontent.com/u/2089263?v=4","gravatar_id":"","url":"https://api.github.com/users/neiljerram","html_url":"https://github.com/neiljerram","followers_url":"https://api.github.com/users/neiljerram/followers","following_url":"https://api.github.com/users/neiljerram/following{/other_user}","gists_url":"https://api.github.com/users/neiljerram/gists{/gist_id}","starred_url":"https://api.github.com/users/neiljerram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neiljerram/subscriptions","organizations_url":"https://api.github.com/users/neiljerram/orgs","repos_url":"https://api.github.com/users/neiljerram/repos","events_url":"https://api.github.com/users/neiljerram/events{/privacy}","received_events_url":"https://api.github.com/users/neiljerram/received_events","type":"User","site_admin":false},"html_url":"https://github.com/neiljerram/calico","description":"Documentation and guides for Calico","fork":true,"url":"https://api.github.com/repos/neiljerram/calico","forks_url":"https://api.github.com/repos/neiljerram/calico/forks","keys_url":"https://api.github.com/repos/neiljerram/calico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neiljerram/calico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neiljerram/calico/teams","hooks_url":"https://api.github.com/repos/neiljerram/calico/hooks","issue_events_url":"https://api.github.com/repos/neiljerram/calico/issues/events{/number}","events_url":"https://api.github.com/repos/neiljerram/calico/events","assignees_url":"https://api.github.com/repos/neiljerram/calico/assignees{/user}","branches_url":"https://api.github.com/repos/neiljerram/calico/branches{/branch}","tags_url":"https://api.github.com/repos/neiljerram/calico/tags","blobs_url":"https://api.github.com/repos/neiljerram/calico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neiljerram/calico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neiljerram/calico/git/refs{/sha}","trees_url":"https://api.github.com/repos/neiljerram/calico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neiljerram/calico/statuses/{sha}","languages_url":"https://api.github.com/repos/neiljerram/calico/languages","stargazers_url":"https://api.github.com/repos/neiljerram/calico/stargazers","contributors_url":"https://api.github.com/repos/neiljerram/calico/contributors","subscribers_url":"https://api.github.com/repos/neiljerram/calico/subscribers","subscription_url":"https://api.github.com/repos/neiljerram/calico/subscription","commits_url":"https://api.github.com/repos/neiljerram/calico/commits{/sha}","git_commits_url":"https://api.github.com/repos/neiljerram/calico/git/commits{/sha}","comments_url":"https://api.github.com/repos/neiljerram/calico/comments{/number}","issue_comment_url":"https://api.github.com/repos/neiljerram/calico/issues/comments{/number}","contents_url":"https://api.github.com/repos/neiljerram/calico/contents/{+path}","compare_url":"https://api.github.com/repos/neiljerram/calico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neiljerram/calico/merges","archive_url":"https://api.github.com/repos/neiljerram/calico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neiljerram/calico/downloads","issues_url":"https://api.github.com/repos/neiljerram/calico/issues{/number}","pulls_url":"https://api.github.com/repos/neiljerram/calico/pulls{/number}","milestones_url":"https://api.github.com/repos/neiljerram/calico/milestones{/number}","notifications_url":"https://api.github.com/repos/neiljerram/calico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neiljerram/calico/labels{/name}","releases_url":"https://api.github.com/repos/neiljerram/calico/releases{/id}","deployments_url":"https://api.github.com/repos/neiljerram/calico/deployments","created_at":"2016-11-07T23:12:42Z","updated_at":"2018-11-19T09:54:12Z","pushed_at":"2018-11-19T16:54:41Z","git_url":"git://github.com/neiljerram/calico.git","ssh_url":"git@github.com:neiljerram/calico.git","clone_url":"https://github.com/neiljerram/calico.git","svn_url":"https://github.com/neiljerram/calico","homepage":null,"size":22665,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"54d7707f9c2f38bbdb92b052b5e4ceee4f50a6cc","user":{"login":"projectcalico","id":12304728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzA0NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":63882194,"node_id":"MDEwOlJlcG9zaXRvcnk2Mzg4MjE5NA==","name":"calico","full_name":"projectcalico/calico","private":false,"owner":{"login":"projectcalico","id":12304728,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMzA0NzI4","avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/projectcalico/calico","description":"Cloud native connectivity and network policy","fork":false,"url":"https://api.github.com/repos/projectcalico/calico","forks_url":"https://api.github.com/repos/projectcalico/calico/forks","keys_url":"https://api.github.com/repos/projectcalico/calico/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico/events","assignees_url":"https://api.github.com/repos/projectcalico/calico/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico/merges","archive_url":"https://api.github.com/repos/projectcalico/calico/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/calico/deployments","created_at":"2016-07-21T15:45:54Z","updated_at":"2018-11-19T18:52:39Z","pushed_at":"2018-11-19T18:52:36Z","git_url":"git://github.com/projectcalico/calico.git","ssh_url":"git@github.com:projectcalico/calico.git","clone_url":"https://github.com/projectcalico/calico.git","svn_url":"https://github.com/projectcalico/calico","homepage":"http://docs.projectcalico.org","size":22901,"stargazers_count":753,"watchers_count":753,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":268,"mirror_url":null,"archived":false,"open_issues_count":139,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":268,"open_issues":139,"watchers":753,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/2303"},"html":{"href":"https://github.com/projectcalico/calico/pull/2303"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico/issues/2303"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico/issues/2303/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/2303/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico/pulls/2303/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico/statuses/390524072ceff3d16fd61c09aeb00aa324a6c12a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"caseydavenport"}}