{"action":"created","comment":{"url":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/comments/243563872","pull_request_review_id":187369604,"id":243563872,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzU2Mzg3Mg==","diff_hunk":"@@ -16,14 +16,34 @@\n from sklearn.externals import joblib\n \n from statsmodels import api as sm\n-from statsmodels.tsa.base.tsa_model import TimeSeriesModelResults\n import pandas as pd\n \n import warnings\n import pickle\n import pytest\n import time\n import os\n+import shutil\n+\n+\n+# test images directories\n+travis = os.environ.get(\"TESTING_ON_TRAVIS\", \"false\").lower() == \"true\"\n+\n+if not travis:\n+\n+    # Only do this setup if we are not running on Travis CI.\n+    from matplotlib.pyplot import savefig\n+    from matplotlib.testing.exceptions import ImageComparisonFailure\n+    import matplotlib._png as _png\n+\n+    test_images_input_path = \\\n+        os.path.join('pmdarima', 'arima', 'tests', 'input_images')\n+    test_images_output_path = \\\n+        test_images_input_path.replace('input_images', 'output_images')\n+\n+    # make output directory if it doesn't exist\n+    if not os.path.exists(test_images_output_path):\n+        os.makedirs(test_images_output_path)","path":"pmdarima/arima/tests/test_arima.py","position":32,"original_position":32,"commit_id":"59719a8bc8b22f78e0a4f8e6f76dc5a13a56ae1c","original_commit_id":"59719a8bc8b22f78e0a4f8e6f76dc5a13a56ae1c","user":{"login":"tgsmith61591","id":6124706,"node_id":"MDQ6VXNlcjYxMjQ3MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/6124706?v=4","gravatar_id":"","url":"https://api.github.com/users/tgsmith61591","html_url":"https://github.com/tgsmith61591","followers_url":"https://api.github.com/users/tgsmith61591/followers","following_url":"https://api.github.com/users/tgsmith61591/following{/other_user}","gists_url":"https://api.github.com/users/tgsmith61591/gists{/gist_id}","starred_url":"https://api.github.com/users/tgsmith61591/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgsmith61591/subscriptions","organizations_url":"https://api.github.com/users/tgsmith61591/orgs","repos_url":"https://api.github.com/users/tgsmith61591/repos","events_url":"https://api.github.com/users/tgsmith61591/events{/privacy}","received_events_url":"https://api.github.com/users/tgsmith61591/received_events","type":"User","site_admin":false},"body":"Can you put this whole `if not travis` block inside the other? And this portion in particular should go inside the `try/finally`","created_at":"2018-12-21T12:01:21Z","updated_at":"2018-12-21T12:01:21Z","html_url":"https://github.com/tgsmith61591/pmdarima/pull/60#discussion_r243563872","pull_request_url":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/60","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/comments/243563872"},"html":{"href":"https://github.com/tgsmith61591/pmdarima/pull/60#discussion_r243563872"},"pull_request":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/60","id":235358280,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MzU4Mjgw","html_url":"https://github.com/tgsmith61591/pmdarima/pull/60","diff_url":"https://github.com/tgsmith61591/pmdarima/pull/60.diff","patch_url":"https://github.com/tgsmith61591/pmdarima/pull/60.patch","issue_url":"https://api.github.com/repos/tgsmith61591/pmdarima/issues/60","number":60,"state":"open","locked":false,"title":"[MRG] Generate plot diff rmse","user":{"login":"charlesdrotar","id":3826821,"node_id":"MDQ6VXNlcjM4MjY4MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/3826821?v=4","gravatar_id":"","url":"https://api.github.com/users/charlesdrotar","html_url":"https://github.com/charlesdrotar","followers_url":"https://api.github.com/users/charlesdrotar/followers","following_url":"https://api.github.com/users/charlesdrotar/following{/other_user}","gists_url":"https://api.github.com/users/charlesdrotar/gists{/gist_id}","starred_url":"https://api.github.com/users/charlesdrotar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlesdrotar/subscriptions","organizations_url":"https://api.github.com/users/charlesdrotar/orgs","repos_url":"https://api.github.com/users/charlesdrotar/repos","events_url":"https://api.github.com/users/charlesdrotar/events{/privacy}","received_events_url":"https://api.github.com/users/charlesdrotar/received_events","type":"User","site_admin":false},"body":"Add the ability to calculate diffs of plots so changes in figures can be tested as well as the execution. This addresses [Issue#59](https://github.com/tgsmith61591/pmdarima/issues/59).","created_at":"2018-12-03T08:09:31Z","updated_at":"2018-12-21T12:01:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b4f1a242b5fdce8647b57988cb261f9a53fb576d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1146809712,"node_id":"MDU6TGFiZWwxMTQ2ODA5NzEy","url":"https://api.github.com/repos/tgsmith61591/pmdarima/labels/cicd","name":"cicd","color":"fcc7f0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/60/commits","review_comments_url":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/60/comments","review_comment_url":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tgsmith61591/pmdarima/issues/60/comments","statuses_url":"https://api.github.com/repos/tgsmith61591/pmdarima/statuses/59719a8bc8b22f78e0a4f8e6f76dc5a13a56ae1c","head":{"label":"tgsmith61591:generate_plot_diff_RMSE","ref":"generate_plot_diff_RMSE","sha":"59719a8bc8b22f78e0a4f8e6f76dc5a13a56ae1c","user":{"login":"tgsmith61591","id":6124706,"node_id":"MDQ6VXNlcjYxMjQ3MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/6124706?v=4","gravatar_id":"","url":"https://api.github.com/users/tgsmith61591","html_url":"https://github.com/tgsmith61591","followers_url":"https://api.github.com/users/tgsmith61591/followers","following_url":"https://api.github.com/users/tgsmith61591/following{/other_user}","gists_url":"https://api.github.com/users/tgsmith61591/gists{/gist_id}","starred_url":"https://api.github.com/users/tgsmith61591/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgsmith61591/subscriptions","organizations_url":"https://api.github.com/users/tgsmith61591/orgs","repos_url":"https://api.github.com/users/tgsmith61591/repos","events_url":"https://api.github.com/users/tgsmith61591/events{/privacy}","received_events_url":"https://api.github.com/users/tgsmith61591/received_events","type":"User","site_admin":false},"repo":{"id":86715491,"node_id":"MDEwOlJlcG9zaXRvcnk4NjcxNTQ5MQ==","name":"pmdarima","full_name":"tgsmith61591/pmdarima","private":false,"owner":{"login":"tgsmith61591","id":6124706,"node_id":"MDQ6VXNlcjYxMjQ3MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/6124706?v=4","gravatar_id":"","url":"https://api.github.com/users/tgsmith61591","html_url":"https://github.com/tgsmith61591","followers_url":"https://api.github.com/users/tgsmith61591/followers","following_url":"https://api.github.com/users/tgsmith61591/following{/other_user}","gists_url":"https://api.github.com/users/tgsmith61591/gists{/gist_id}","starred_url":"https://api.github.com/users/tgsmith61591/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgsmith61591/subscriptions","organizations_url":"https://api.github.com/users/tgsmith61591/orgs","repos_url":"https://api.github.com/users/tgsmith61591/repos","events_url":"https://api.github.com/users/tgsmith61591/events{/privacy}","received_events_url":"https://api.github.com/users/tgsmith61591/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tgsmith61591/pmdarima","description":"Pyramid brings R's beloved auto.arima to Python, making an even stronger case for why you don't need R for data science. ","fork":false,"url":"https://api.github.com/repos/tgsmith61591/pmdarima","forks_url":"https://api.github.com/repos/tgsmith61591/pmdarima/forks","keys_url":"https://api.github.com/repos/tgsmith61591/pmdarima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgsmith61591/pmdarima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgsmith61591/pmdarima/teams","hooks_url":"https://api.github.com/repos/tgsmith61591/pmdarima/hooks","issue_events_url":"https://api.github.com/repos/tgsmith61591/pmdarima/issues/events{/number}","events_url":"https://api.github.com/repos/tgsmith61591/pmdarima/events","assignees_url":"https://api.github.com/repos/tgsmith61591/pmdarima/assignees{/user}","branches_url":"https://api.github.com/repos/tgsmith61591/pmdarima/branches{/branch}","tags_url":"https://api.github.com/repos/tgsmith61591/pmdarima/tags","blobs_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgsmith61591/pmdarima/statuses/{sha}","languages_url":"https://api.github.com/repos/tgsmith61591/pmdarima/languages","stargazers_url":"https://api.github.com/repos/tgsmith61591/pmdarima/stargazers","contributors_url":"https://api.github.com/repos/tgsmith61591/pmdarima/contributors","subscribers_url":"https://api.github.com/repos/tgsmith61591/pmdarima/subscribers","subscription_url":"https://api.github.com/repos/tgsmith61591/pmdarima/subscription","commits_url":"https://api.github.com/repos/tgsmith61591/pmdarima/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgsmith61591/pmdarima/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgsmith61591/pmdarima/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgsmith61591/pmdarima/contents/{+path}","compare_url":"https://api.github.com/repos/tgsmith61591/pmdarima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgsmith61591/pmdarima/merges","archive_url":"https://api.github.com/repos/tgsmith61591/pmdarima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgsmith61591/pmdarima/downloads","issues_url":"https://api.github.com/repos/tgsmith61591/pmdarima/issues{/number}","pulls_url":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls{/number}","milestones_url":"https://api.github.com/repos/tgsmith61591/pmdarima/milestones{/number}","notifications_url":"https://api.github.com/repos/tgsmith61591/pmdarima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgsmith61591/pmdarima/labels{/name}","releases_url":"https://api.github.com/repos/tgsmith61591/pmdarima/releases{/id}","deployments_url":"https://api.github.com/repos/tgsmith61591/pmdarima/deployments","created_at":"2017-03-30T14:58:30Z","updated_at":"2018-12-19T00:53:46Z","pushed_at":"2018-12-21T11:57:40Z","git_url":"git://github.com/tgsmith61591/pmdarima.git","ssh_url":"git@github.com:tgsmith61591/pmdarima.git","clone_url":"https://github.com/tgsmith61591/pmdarima.git","svn_url":"https://github.com/tgsmith61591/pmdarima","homepage":"https://www.alkaline-ml.com/pmdarima","size":59527,"stargazers_count":237,"watchers_count":237,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":61,"open_issues":6,"watchers":237,"default_branch":"master"}},"base":{"label":"tgsmith61591:develop","ref":"develop","sha":"18df41cdc01e8e020d6b4546207d3373296ff73a","user":{"login":"tgsmith61591","id":6124706,"node_id":"MDQ6VXNlcjYxMjQ3MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/6124706?v=4","gravatar_id":"","url":"https://api.github.com/users/tgsmith61591","html_url":"https://github.com/tgsmith61591","followers_url":"https://api.github.com/users/tgsmith61591/followers","following_url":"https://api.github.com/users/tgsmith61591/following{/other_user}","gists_url":"https://api.github.com/users/tgsmith61591/gists{/gist_id}","starred_url":"https://api.github.com/users/tgsmith61591/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgsmith61591/subscriptions","organizations_url":"https://api.github.com/users/tgsmith61591/orgs","repos_url":"https://api.github.com/users/tgsmith61591/repos","events_url":"https://api.github.com/users/tgsmith61591/events{/privacy}","received_events_url":"https://api.github.com/users/tgsmith61591/received_events","type":"User","site_admin":false},"repo":{"id":86715491,"node_id":"MDEwOlJlcG9zaXRvcnk4NjcxNTQ5MQ==","name":"pmdarima","full_name":"tgsmith61591/pmdarima","private":false,"owner":{"login":"tgsmith61591","id":6124706,"node_id":"MDQ6VXNlcjYxMjQ3MDY=","avatar_url":"https://avatars0.githubusercontent.com/u/6124706?v=4","gravatar_id":"","url":"https://api.github.com/users/tgsmith61591","html_url":"https://github.com/tgsmith61591","followers_url":"https://api.github.com/users/tgsmith61591/followers","following_url":"https://api.github.com/users/tgsmith61591/following{/other_user}","gists_url":"https://api.github.com/users/tgsmith61591/gists{/gist_id}","starred_url":"https://api.github.com/users/tgsmith61591/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgsmith61591/subscriptions","organizations_url":"https://api.github.com/users/tgsmith61591/orgs","repos_url":"https://api.github.com/users/tgsmith61591/repos","events_url":"https://api.github.com/users/tgsmith61591/events{/privacy}","received_events_url":"https://api.github.com/users/tgsmith61591/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tgsmith61591/pmdarima","description":"Pyramid brings R's beloved auto.arima to Python, making an even stronger case for why you don't need R for data science. ","fork":false,"url":"https://api.github.com/repos/tgsmith61591/pmdarima","forks_url":"https://api.github.com/repos/tgsmith61591/pmdarima/forks","keys_url":"https://api.github.com/repos/tgsmith61591/pmdarima/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgsmith61591/pmdarima/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgsmith61591/pmdarima/teams","hooks_url":"https://api.github.com/repos/tgsmith61591/pmdarima/hooks","issue_events_url":"https://api.github.com/repos/tgsmith61591/pmdarima/issues/events{/number}","events_url":"https://api.github.com/repos/tgsmith61591/pmdarima/events","assignees_url":"https://api.github.com/repos/tgsmith61591/pmdarima/assignees{/user}","branches_url":"https://api.github.com/repos/tgsmith61591/pmdarima/branches{/branch}","tags_url":"https://api.github.com/repos/tgsmith61591/pmdarima/tags","blobs_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgsmith61591/pmdarima/statuses/{sha}","languages_url":"https://api.github.com/repos/tgsmith61591/pmdarima/languages","stargazers_url":"https://api.github.com/repos/tgsmith61591/pmdarima/stargazers","contributors_url":"https://api.github.com/repos/tgsmith61591/pmdarima/contributors","subscribers_url":"https://api.github.com/repos/tgsmith61591/pmdarima/subscribers","subscription_url":"https://api.github.com/repos/tgsmith61591/pmdarima/subscription","commits_url":"https://api.github.com/repos/tgsmith61591/pmdarima/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgsmith61591/pmdarima/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgsmith61591/pmdarima/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgsmith61591/pmdarima/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgsmith61591/pmdarima/contents/{+path}","compare_url":"https://api.github.com/repos/tgsmith61591/pmdarima/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgsmith61591/pmdarima/merges","archive_url":"https://api.github.com/repos/tgsmith61591/pmdarima/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgsmith61591/pmdarima/downloads","issues_url":"https://api.github.com/repos/tgsmith61591/pmdarima/issues{/number}","pulls_url":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls{/number}","milestones_url":"https://api.github.com/repos/tgsmith61591/pmdarima/milestones{/number}","notifications_url":"https://api.github.com/repos/tgsmith61591/pmdarima/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgsmith61591/pmdarima/labels{/name}","releases_url":"https://api.github.com/repos/tgsmith61591/pmdarima/releases{/id}","deployments_url":"https://api.github.com/repos/tgsmith61591/pmdarima/deployments","created_at":"2017-03-30T14:58:30Z","updated_at":"2018-12-19T00:53:46Z","pushed_at":"2018-12-21T11:57:40Z","git_url":"git://github.com/tgsmith61591/pmdarima.git","ssh_url":"git@github.com:tgsmith61591/pmdarima.git","clone_url":"https://github.com/tgsmith61591/pmdarima.git","svn_url":"https://github.com/tgsmith61591/pmdarima","homepage":"https://www.alkaline-ml.com/pmdarima","size":59527,"stargazers_count":237,"watchers_count":237,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":61,"open_issues":6,"watchers":237,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/60"},"html":{"href":"https://github.com/tgsmith61591/pmdarima/pull/60"},"issue":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/issues/60"},"comments":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/tgsmith61591/pmdarima/statuses/59719a8bc8b22f78e0a4f8e6f76dc5a13a56ae1c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tgsmith61591"}}