{"action":"created","comment":{"url":"https://api.github.com/repos/caffe2/caffe2/pulls/comments/170146571","pull_request_review_id":98790659,"id":170146571,"diff_hunk":"@@ -244,7 +244,11 @@ function(caffe2_binary_target target_name_or_src)\n   endif()\n   add_executable(${__target} ${__srcs})\n   add_dependencies(${__target} ${Caffe2_MAIN_LIBS_ORDER})\n-  target_link_libraries(${__target} ${Caffe2_MAIN_LIBS} ${Caffe2_DEPENDENCY_LIBS})\n+  if (USE_CUDA)","path":"cmake/Utils.cmake","position":5,"original_position":5,"commit_id":"e0fe273512fffce10b4768ab41842013c61eb521","original_commit_id":"e0fe273512fffce10b4768ab41842013c61eb521","user":{"login":"Yangqing","id":551151,"avatar_url":"https://avatars1.githubusercontent.com/u/551151?v=4","gravatar_id":"","url":"https://api.github.com/users/Yangqing","html_url":"https://github.com/Yangqing","followers_url":"https://api.github.com/users/Yangqing/followers","following_url":"https://api.github.com/users/Yangqing/following{/other_user}","gists_url":"https://api.github.com/users/Yangqing/gists{/gist_id}","starred_url":"https://api.github.com/users/Yangqing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yangqing/subscriptions","organizations_url":"https://api.github.com/users/Yangqing/orgs","repos_url":"https://api.github.com/users/Yangqing/repos","events_url":"https://api.github.com/users/Yangqing/events{/privacy}","received_events_url":"https://api.github.com/users/Yangqing/received_events","type":"User","site_admin":false},"body":"nvm, saw your note above.","created_at":"2018-02-23T01:45:04Z","updated_at":"2018-02-23T01:45:04Z","html_url":"https://github.com/caffe2/caffe2/pull/2004#discussion_r170146571","pull_request_url":"https://api.github.com/repos/caffe2/caffe2/pulls/2004","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/comments/170146571"},"html":{"href":"https://github.com/caffe2/caffe2/pull/2004#discussion_r170146571"},"pull_request":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/2004"}},"in_reply_to_id":170146284},"pull_request":{"url":"https://api.github.com/repos/caffe2/caffe2/pulls/2004","id":170859122,"html_url":"https://github.com/caffe2/caffe2/pull/2004","diff_url":"https://github.com/caffe2/caffe2/pull/2004.diff","patch_url":"https://github.com/caffe2/caffe2/pull/2004.patch","issue_url":"https://api.github.com/repos/caffe2/caffe2/issues/2004","number":2004,"state":"open","locked":false,"title":"Fixing an error building with CUDA on windows","user":{"login":"pjh5","id":6456020,"avatar_url":"https://avatars1.githubusercontent.com/u/6456020?v=4","gravatar_id":"","url":"https://api.github.com/users/pjh5","html_url":"https://github.com/pjh5","followers_url":"https://api.github.com/users/pjh5/followers","following_url":"https://api.github.com/users/pjh5/following{/other_user}","gists_url":"https://api.github.com/users/pjh5/gists{/gist_id}","starred_url":"https://api.github.com/users/pjh5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjh5/subscriptions","organizations_url":"https://api.github.com/users/pjh5/orgs","repos_url":"https://api.github.com/users/pjh5/repos","events_url":"https://api.github.com/users/pjh5/events{/privacy}","received_events_url":"https://api.github.com/users/pjh5/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-22T20:37:04Z","updated_at":"2018-02-23T01:45:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a9f22968666e8c9028661d2b033773af9fbe6a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":501675200,"url":"https://api.github.com/repos/caffe2/caffe2/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/caffe2/caffe2/pulls/2004/commits","review_comments_url":"https://api.github.com/repos/caffe2/caffe2/pulls/2004/comments","review_comment_url":"https://api.github.com/repos/caffe2/caffe2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caffe2/caffe2/issues/2004/comments","statuses_url":"https://api.github.com/repos/caffe2/caffe2/statuses/e0fe273512fffce10b4768ab41842013c61eb521","head":{"label":"pjh5:windows_binary_fix","ref":"windows_binary_fix","sha":"e0fe273512fffce10b4768ab41842013c61eb521","user":{"login":"pjh5","id":6456020,"avatar_url":"https://avatars1.githubusercontent.com/u/6456020?v=4","gravatar_id":"","url":"https://api.github.com/users/pjh5","html_url":"https://github.com/pjh5","followers_url":"https://api.github.com/users/pjh5/followers","following_url":"https://api.github.com/users/pjh5/following{/other_user}","gists_url":"https://api.github.com/users/pjh5/gists{/gist_id}","starred_url":"https://api.github.com/users/pjh5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjh5/subscriptions","organizations_url":"https://api.github.com/users/pjh5/orgs","repos_url":"https://api.github.com/users/pjh5/repos","events_url":"https://api.github.com/users/pjh5/events{/privacy}","received_events_url":"https://api.github.com/users/pjh5/received_events","type":"User","site_admin":false},"repo":{"id":113083809,"name":"caffe2","full_name":"pjh5/caffe2","owner":{"login":"pjh5","id":6456020,"avatar_url":"https://avatars1.githubusercontent.com/u/6456020?v=4","gravatar_id":"","url":"https://api.github.com/users/pjh5","html_url":"https://github.com/pjh5","followers_url":"https://api.github.com/users/pjh5/followers","following_url":"https://api.github.com/users/pjh5/following{/other_user}","gists_url":"https://api.github.com/users/pjh5/gists{/gist_id}","starred_url":"https://api.github.com/users/pjh5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjh5/subscriptions","organizations_url":"https://api.github.com/users/pjh5/orgs","repos_url":"https://api.github.com/users/pjh5/repos","events_url":"https://api.github.com/users/pjh5/events{/privacy}","received_events_url":"https://api.github.com/users/pjh5/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pjh5/caffe2","description":"Caffe2 is a lightweight, modular, and scalable deep learning framework.","fork":true,"url":"https://api.github.com/repos/pjh5/caffe2","forks_url":"https://api.github.com/repos/pjh5/caffe2/forks","keys_url":"https://api.github.com/repos/pjh5/caffe2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pjh5/caffe2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pjh5/caffe2/teams","hooks_url":"https://api.github.com/repos/pjh5/caffe2/hooks","issue_events_url":"https://api.github.com/repos/pjh5/caffe2/issues/events{/number}","events_url":"https://api.github.com/repos/pjh5/caffe2/events","assignees_url":"https://api.github.com/repos/pjh5/caffe2/assignees{/user}","branches_url":"https://api.github.com/repos/pjh5/caffe2/branches{/branch}","tags_url":"https://api.github.com/repos/pjh5/caffe2/tags","blobs_url":"https://api.github.com/repos/pjh5/caffe2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pjh5/caffe2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pjh5/caffe2/git/refs{/sha}","trees_url":"https://api.github.com/repos/pjh5/caffe2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pjh5/caffe2/statuses/{sha}","languages_url":"https://api.github.com/repos/pjh5/caffe2/languages","stargazers_url":"https://api.github.com/repos/pjh5/caffe2/stargazers","contributors_url":"https://api.github.com/repos/pjh5/caffe2/contributors","subscribers_url":"https://api.github.com/repos/pjh5/caffe2/subscribers","subscription_url":"https://api.github.com/repos/pjh5/caffe2/subscription","commits_url":"https://api.github.com/repos/pjh5/caffe2/commits{/sha}","git_commits_url":"https://api.github.com/repos/pjh5/caffe2/git/commits{/sha}","comments_url":"https://api.github.com/repos/pjh5/caffe2/comments{/number}","issue_comment_url":"https://api.github.com/repos/pjh5/caffe2/issues/comments{/number}","contents_url":"https://api.github.com/repos/pjh5/caffe2/contents/{+path}","compare_url":"https://api.github.com/repos/pjh5/caffe2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pjh5/caffe2/merges","archive_url":"https://api.github.com/repos/pjh5/caffe2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pjh5/caffe2/downloads","issues_url":"https://api.github.com/repos/pjh5/caffe2/issues{/number}","pulls_url":"https://api.github.com/repos/pjh5/caffe2/pulls{/number}","milestones_url":"https://api.github.com/repos/pjh5/caffe2/milestones{/number}","notifications_url":"https://api.github.com/repos/pjh5/caffe2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pjh5/caffe2/labels{/name}","releases_url":"https://api.github.com/repos/pjh5/caffe2/releases{/id}","deployments_url":"https://api.github.com/repos/pjh5/caffe2/deployments","created_at":"2017-12-04T19:12:16Z","updated_at":"2017-12-04T19:12:22Z","pushed_at":"2018-02-23T01:37:22Z","git_url":"git://github.com/pjh5/caffe2.git","ssh_url":"git@github.com:pjh5/caffe2.git","clone_url":"https://github.com/pjh5/caffe2.git","svn_url":"https://github.com/pjh5/caffe2","homepage":"https://caffe2.ai","size":275429,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"caffe2:master","ref":"master","sha":"c48918c101498d87e59435b39ac60027e3e4ae3d","user":{"login":"caffe2","id":13072719,"avatar_url":"https://avatars0.githubusercontent.com/u/13072719?v=4","gravatar_id":"","url":"https://api.github.com/users/caffe2","html_url":"https://github.com/caffe2","followers_url":"https://api.github.com/users/caffe2/followers","following_url":"https://api.github.com/users/caffe2/following{/other_user}","gists_url":"https://api.github.com/users/caffe2/gists{/gist_id}","starred_url":"https://api.github.com/users/caffe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caffe2/subscriptions","organizations_url":"https://api.github.com/users/caffe2/orgs","repos_url":"https://api.github.com/users/caffe2/repos","events_url":"https://api.github.com/users/caffe2/events{/privacy}","received_events_url":"https://api.github.com/users/caffe2/received_events","type":"Organization","site_admin":false},"repo":{"id":38066334,"name":"caffe2","full_name":"caffe2/caffe2","owner":{"login":"caffe2","id":13072719,"avatar_url":"https://avatars0.githubusercontent.com/u/13072719?v=4","gravatar_id":"","url":"https://api.github.com/users/caffe2","html_url":"https://github.com/caffe2","followers_url":"https://api.github.com/users/caffe2/followers","following_url":"https://api.github.com/users/caffe2/following{/other_user}","gists_url":"https://api.github.com/users/caffe2/gists{/gist_id}","starred_url":"https://api.github.com/users/caffe2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caffe2/subscriptions","organizations_url":"https://api.github.com/users/caffe2/orgs","repos_url":"https://api.github.com/users/caffe2/repos","events_url":"https://api.github.com/users/caffe2/events{/privacy}","received_events_url":"https://api.github.com/users/caffe2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caffe2/caffe2","description":"Caffe2 is a lightweight, modular, and scalable deep learning framework.","fork":false,"url":"https://api.github.com/repos/caffe2/caffe2","forks_url":"https://api.github.com/repos/caffe2/caffe2/forks","keys_url":"https://api.github.com/repos/caffe2/caffe2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caffe2/caffe2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caffe2/caffe2/teams","hooks_url":"https://api.github.com/repos/caffe2/caffe2/hooks","issue_events_url":"https://api.github.com/repos/caffe2/caffe2/issues/events{/number}","events_url":"https://api.github.com/repos/caffe2/caffe2/events","assignees_url":"https://api.github.com/repos/caffe2/caffe2/assignees{/user}","branches_url":"https://api.github.com/repos/caffe2/caffe2/branches{/branch}","tags_url":"https://api.github.com/repos/caffe2/caffe2/tags","blobs_url":"https://api.github.com/repos/caffe2/caffe2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caffe2/caffe2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caffe2/caffe2/git/refs{/sha}","trees_url":"https://api.github.com/repos/caffe2/caffe2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caffe2/caffe2/statuses/{sha}","languages_url":"https://api.github.com/repos/caffe2/caffe2/languages","stargazers_url":"https://api.github.com/repos/caffe2/caffe2/stargazers","contributors_url":"https://api.github.com/repos/caffe2/caffe2/contributors","subscribers_url":"https://api.github.com/repos/caffe2/caffe2/subscribers","subscription_url":"https://api.github.com/repos/caffe2/caffe2/subscription","commits_url":"https://api.github.com/repos/caffe2/caffe2/commits{/sha}","git_commits_url":"https://api.github.com/repos/caffe2/caffe2/git/commits{/sha}","comments_url":"https://api.github.com/repos/caffe2/caffe2/comments{/number}","issue_comment_url":"https://api.github.com/repos/caffe2/caffe2/issues/comments{/number}","contents_url":"https://api.github.com/repos/caffe2/caffe2/contents/{+path}","compare_url":"https://api.github.com/repos/caffe2/caffe2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caffe2/caffe2/merges","archive_url":"https://api.github.com/repos/caffe2/caffe2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caffe2/caffe2/downloads","issues_url":"https://api.github.com/repos/caffe2/caffe2/issues{/number}","pulls_url":"https://api.github.com/repos/caffe2/caffe2/pulls{/number}","milestones_url":"https://api.github.com/repos/caffe2/caffe2/milestones{/number}","notifications_url":"https://api.github.com/repos/caffe2/caffe2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caffe2/caffe2/labels{/name}","releases_url":"https://api.github.com/repos/caffe2/caffe2/releases{/id}","deployments_url":"https://api.github.com/repos/caffe2/caffe2/deployments","created_at":"2015-06-25T18:23:47Z","updated_at":"2018-02-23T00:21:19Z","pushed_at":"2018-02-23T01:43:54Z","git_url":"git://github.com/caffe2/caffe2.git","ssh_url":"git@github.com:caffe2/caffe2.git","clone_url":"https://github.com/caffe2/caffe2.git","svn_url":"https://github.com/caffe2/caffe2","homepage":"https://caffe2.ai","size":275411,"stargazers_count":7346,"watchers_count":7346,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1722,"mirror_url":null,"archived":false,"open_issues_count":539,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1722,"open_issues":539,"watchers":7346,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/2004"},"html":{"href":"https://github.com/caffe2/caffe2/pull/2004"},"issue":{"href":"https://api.github.com/repos/caffe2/caffe2/issues/2004"},"comments":{"href":"https://api.github.com/repos/caffe2/caffe2/issues/2004/comments"},"review_comments":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/2004/comments"},"review_comment":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caffe2/caffe2/pulls/2004/commits"},"statuses":{"href":"https://api.github.com/repos/caffe2/caffe2/statuses/e0fe273512fffce10b4768ab41842013c61eb521"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Yangqing"}}