{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/29214","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/29214/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/29214/comments","events_url":"https://api.github.com/repos/golang/go/issues/29214/events","html_url":"https://github.com/golang/go/issues/29214","id":390656311,"node_id":"MDU6SXNzdWUzOTA2NTYzMTE=","number":29214,"title":"os: CreateFile fails on Windows/exFAT after CL 143578","user":{"login":"egonelbre","id":192964,"node_id":"MDQ6VXNlcjE5Mjk2NA==","avatar_url":"https://avatars1.githubusercontent.com/u/192964?v=4","gravatar_id":"","url":"https://api.github.com/users/egonelbre","html_url":"https://github.com/egonelbre","followers_url":"https://api.github.com/users/egonelbre/followers","following_url":"https://api.github.com/users/egonelbre/following{/other_user}","gists_url":"https://api.github.com/users/egonelbre/gists{/gist_id}","starred_url":"https://api.github.com/users/egonelbre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/egonelbre/subscriptions","organizations_url":"https://api.github.com/users/egonelbre/orgs","repos_url":"https://api.github.com/users/egonelbre/repos","events_url":"https://api.github.com/users/egonelbre/events{/privacy}","received_events_url":"https://api.github.com/users/egonelbre/received_events","type":"User","site_admin":false},"labels":[{"id":373402289,"node_id":"MDU6TGFiZWwzNzM0MDIyODk=","url":"https://api.github.com/repos/golang/go/labels/NeedsInvestigation","name":"NeedsInvestigation","color":"ededed","default":false},{"id":199753992,"node_id":"MDU6TGFiZWwxOTk3NTM5OTI=","url":"https://api.github.com/repos/golang/go/labels/OS-Windows","name":"OS-Windows","color":"ededed","default":false},{"id":626114820,"node_id":"MDU6TGFiZWw2MjYxMTQ4MjA=","url":"https://api.github.com/repos/golang/go/labels/release-blocker","name":"release-blocker","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"alexbrainman","id":9796621,"node_id":"MDQ6VXNlcjk3OTY2MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9796621?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrainman","html_url":"https://github.com/alexbrainman","followers_url":"https://api.github.com/users/alexbrainman/followers","following_url":"https://api.github.com/users/alexbrainman/following{/other_user}","gists_url":"https://api.github.com/users/alexbrainman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrainman/subscriptions","organizations_url":"https://api.github.com/users/alexbrainman/orgs","repos_url":"https://api.github.com/users/alexbrainman/repos","events_url":"https://api.github.com/users/alexbrainman/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrainman/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexbrainman","id":9796621,"node_id":"MDQ6VXNlcjk3OTY2MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9796621?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbrainman","html_url":"https://github.com/alexbrainman","followers_url":"https://api.github.com/users/alexbrainman/followers","following_url":"https://api.github.com/users/alexbrainman/following{/other_user}","gists_url":"https://api.github.com/users/alexbrainman/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbrainman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbrainman/subscriptions","organizations_url":"https://api.github.com/users/alexbrainman/orgs","repos_url":"https://api.github.com/users/alexbrainman/repos","events_url":"https://api.github.com/users/alexbrainman/events{/privacy}","received_events_url":"https://api.github.com/users/alexbrainman/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/65","html_url":"https://github.com/golang/go/milestone/65","labels_url":"https://api.github.com/repos/golang/go/milestones/65/labels","id":3072996,"node_id":"MDk6TWlsZXN0b25lMzA3Mjk5Ng==","number":65,"title":"Go1.12","description":"","creator":{"login":"rsc","id":104030,"node_id":"MDQ6VXNlcjEwNDAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":374,"closed_issues":580,"state":"open","created_at":"2018-01-29T21:17:52Z","updated_at":"2018-12-16T23:34:42Z","due_on":"2019-01-31T08:00:00Z","closed_at":null},"comments":8,"created_at":"2018-12-13T12:26:45Z","updated_at":"2018-12-17T02:18:24Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"On a fairly clean Windows system running `make.bat` with `master` (944a9c7a4f) fails when using exFAT filesystem for the temporary / work directory.\r\n\r\n```\r\nBuilding Go cmd/dist using C:\\Go\r\nBuilding Go toolchain1 using C:\\Go.\r\nBuilding Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.\r\nBuilding Go toolchain2 using go_bootstrap and Go toolchain1.\r\n# sync/atomic\r\nGetFileInformationByHandleEx $WORK\\b015\\asm.o: The parameter is incorrect.\r\n# internal/cpu\r\nGetFileInformationByHandleEx $WORK\\b006\\cpu_x86.o: The parameter is incorrect.\r\n# runtime/internal/atomic\r\nGetFileInformationByHandleEx $WORK\\b012\\asm_amd64.o: The parameter is incorrect.\r\ngo tool dist: FAILED: c:\\Go.tip\\pkg\\tool\\windows_amd64\\go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: exit status 2\r\nThe system cannot find the batch label specified - fail\r\n```\r\n\r\nI bisected the issue to f10815898c0732e2e6cdb697d6f95f33f865.\r\n\r\nIt seems https://github.com/golang/go/blob/5dc144c607cb355e9f4a01bfa0b8f054899156a2/src/os/types_windows.go#L52 is failing for exFAT.\r\n\r\n_Sidenote `The system cannot find the batch label specified - fail` seems to be due to `.bat` files not using windows line endings_\r\n\r\n@alexbrainman\r\n\r\n### What version of Go are you using (`go version`)?\r\n\r\n`go1.11.2 windows/amd64` for bootstrap.\r\n\r\nWindows 10 Pro, Version 1809 (OS Build 117763.194)\r\n\r\n<details><summary><code>go.tip env</code> Output</summary><br><pre>\r\nc:\\Go.tip\\src>go env\r\nset GOARCH=amd64\r\nset GOBIN=\r\nset GOCACHE=c:\\Go.tip\\pkg\\obj\\go-build\r\nset GOEXE=.exe\r\nset GOFLAGS=\r\nset GOHOSTARCH=amd64\r\nset GOHOSTOS=windows\r\nset GOOS=windows\r\nset GOPATH=C:\\Users\\egone\\go\r\nset GOPROXY=\r\nset GORACE=\r\nset GOROOT=c:\\Go.tip\r\nset GOTMPDIR=\r\nset GOTOOLDIR=c:\\Go.tip\\pkg\\tool\\windows_amd64\r\nset GCCGO=gccgo\r\nset CC=gcc\r\nset CXX=g++\r\nset CGO_ENABLED=1\r\nset GOMOD=\r\nset CGO_CFLAGS=-g -O2\r\nset CGO_CPPFLAGS=\r\nset CGO_CXXFLAGS=-g -O2\r\nset CGO_FFLAGS=-g -O2\r\nset CGO_LDFLAGS=-g -O2\r\nset PKG_CONFIG=pkg-config\r\nset GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=Z:\\go-build032936922=/tmp/go-build -gno-record-gcc-switches\r\n</pre></details>\r\n\r\n### Bisect results\r\n\r\n<details><summary>bisect good d154ef60a0c88be98c70bbe</summary><br><pre>\r\nc:\\Go.tip\\src>git co d154ef60a0c88be98c70bbe\r\nPrevious HEAD position was a1ee0a21cf runtime, time: refactor startNano handling\r\nHEAD is now at d154ef60a0 path/filepath: change IsAbs(\"NUL\") to return true\r\n...\r\nc:\\Go.tip\\src>make.bat\r\nBuilding Go cmd/dist using C:\\Go\r\nBuilding Go toolchain1 using C:\\Go.\r\nBuilding Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.\r\nBuilding Go toolchain2 using go_bootstrap and Go toolchain1.\r\nBuilding Go toolchain3 using go_bootstrap and Go toolchain2.\r\nBuilding packages and commands for windows/amd64.\r\n---\r\nInstalled Go for windows/amd64 in c:\\Go.tip\r\nInstalled commands in c:\\Go.tip\\bin\r\n</pre></details>\r\n\r\n<details><summary>bisect bad f10815898c0732e2e6cdb697d6f95f33f865</summary><br><pre>\r\nc:\\Go.tip\\src>git co f10815898c0732e2e6cdb697d6f95f33f865\r\nPrevious HEAD position was d154ef60a0 path/filepath: change IsAbs(\"NUL\") to return true\r\nHEAD is now at f10815898c os: use CreateFile for Stat of symlinks\r\n...\r\nc:\\Go.tip\\src>make.bat\r\nBuilding Go cmd/dist using C:\\Go\r\nBuilding Go toolchain1 using C:\\Go.\r\nBuilding Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.\r\nBuilding Go toolchain2 using go_bootstrap and Go toolchain1.\r\n# sync/atomic\r\nGetFileInformationByHandleEx $WORK\\b015\\asm.o: The parameter is incorrect.\r\n# runtime/internal/atomic\r\nGetFileInformationByHandleEx $WORK\\b012\\asm_amd64.o: The parameter is incorrect.\r\n# internal/cpu\r\nGetFileInformationByHandleEx $WORK\\b006\\cpu_x86.o: The parameter is incorrect.\r\ngo tool dist: FAILED: c:\\Go.tip\\pkg\\tool\\windows_amd64\\go_bootstrap install -gcflags=all= -ldflags=all= -i cmd/asm cmd/cgo cmd/compile cmd/link: exit status 2\r\nThe system cannot find the batch label specified - fail\r\n</pre></details>\r\n"},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/447702751","html_url":"https://github.com/golang/go/issues/29214#issuecomment-447702751","issue_url":"https://api.github.com/repos/golang/go/issues/29214","id":447702751,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzcwMjc1MQ==","user":{"login":"odeke-em","id":4898263,"node_id":"MDQ6VXNlcjQ4OTgyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/4898263?v=4","gravatar_id":"","url":"https://api.github.com/users/odeke-em","html_url":"https://github.com/odeke-em","followers_url":"https://api.github.com/users/odeke-em/followers","following_url":"https://api.github.com/users/odeke-em/following{/other_user}","gists_url":"https://api.github.com/users/odeke-em/gists{/gist_id}","starred_url":"https://api.github.com/users/odeke-em/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/odeke-em/subscriptions","organizations_url":"https://api.github.com/users/odeke-em/orgs","repos_url":"https://api.github.com/users/odeke-em/repos","events_url":"https://api.github.com/users/odeke-em/events{/privacy}","received_events_url":"https://api.github.com/users/odeke-em/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T02:18:24Z","updated_at":"2018-12-17T02:18:24Z","author_association":"MEMBER","body":"Kindly paging @bradfitz @dmitshur for perhaps some ideas on attaching FAT filesystems to the builders as requested by @alexbrainman's https://github.com/golang/go/issues/29214#issuecomment-447549143"}}
{"actor":{"display_login":"odeke-em"}}