{"action":"created","issue":{"url":"https://api.github.com/repos/PolyglotDevsLondon/sharespots/issues/27","repository_url":"https://api.github.com/repos/PolyglotDevsLondon/sharespots","labels_url":"https://api.github.com/repos/PolyglotDevsLondon/sharespots/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/PolyglotDevsLondon/sharespots/issues/27/comments","events_url":"https://api.github.com/repos/PolyglotDevsLondon/sharespots/issues/27/events","html_url":"https://github.com/PolyglotDevsLondon/sharespots/pull/27","id":372316706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NTQyNTQw","number":27,"title":"Feat/create venue model","user":{"login":"darchard1984","id":32482170,"node_id":"MDQ6VXNlcjMyNDgyMTcw","avatar_url":"https://avatars2.githubusercontent.com/u/32482170?v=4","gravatar_id":"","url":"https://api.github.com/users/darchard1984","html_url":"https://github.com/darchard1984","followers_url":"https://api.github.com/users/darchard1984/followers","following_url":"https://api.github.com/users/darchard1984/following{/other_user}","gists_url":"https://api.github.com/users/darchard1984/gists{/gist_id}","starred_url":"https://api.github.com/users/darchard1984/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darchard1984/subscriptions","organizations_url":"https://api.github.com/users/darchard1984/orgs","repos_url":"https://api.github.com/users/darchard1984/repos","events_url":"https://api.github.com/users/darchard1984/events{/privacy}","received_events_url":"https://api.github.com/users/darchard1984/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-21T13:47:18Z","updated_at":"2018-10-21T19:35:21Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/PolyglotDevsLondon/sharespots/pulls/27","html_url":"https://github.com/PolyglotDevsLondon/sharespots/pull/27","diff_url":"https://github.com/PolyglotDevsLondon/sharespots/pull/27.diff","patch_url":"https://github.com/PolyglotDevsLondon/sharespots/pull/27.patch"},"body":"What change does this PR introduce?\r\n\r\n- Cafe Model created called Venue. Created in Core App.\r\n- init.py re-introduced to core\r\n- migrations created in core\r\n- models.py created in core\r\n- admin.py created in core and Venue model registered\r\n- test_models.py added to tests app\r\n- init.py added to tests app in order to run TestCases\r\n\r\nNotes\r\n\r\n- Removed apps.py from core, not needed at this stage but may be needed at a later date for app specific configs.\r\n\r\n- Ignore the Previous PR of this feature to Develop Branch.\r\n\r\nTicket\r\n\r\n    https://trello.com/c/i2vEsK2O/44-create-the-initial-cafe-model\r\n"},"comment":{"url":"https://api.github.com/repos/PolyglotDevsLondon/sharespots/issues/comments/431697305","html_url":"https://github.com/PolyglotDevsLondon/sharespots/pull/27#issuecomment-431697305","issue_url":"https://api.github.com/repos/PolyglotDevsLondon/sharespots/issues/27","id":431697305,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTY5NzMwNQ==","user":{"login":"CianciuStyles","id":3957868,"node_id":"MDQ6VXNlcjM5NTc4Njg=","avatar_url":"https://avatars1.githubusercontent.com/u/3957868?v=4","gravatar_id":"","url":"https://api.github.com/users/CianciuStyles","html_url":"https://github.com/CianciuStyles","followers_url":"https://api.github.com/users/CianciuStyles/followers","following_url":"https://api.github.com/users/CianciuStyles/following{/other_user}","gists_url":"https://api.github.com/users/CianciuStyles/gists{/gist_id}","starred_url":"https://api.github.com/users/CianciuStyles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CianciuStyles/subscriptions","organizations_url":"https://api.github.com/users/CianciuStyles/orgs","repos_url":"https://api.github.com/users/CianciuStyles/repos","events_url":"https://api.github.com/users/CianciuStyles/events{/privacy}","received_events_url":"https://api.github.com/users/CianciuStyles/received_events","type":"User","site_admin":false},"created_at":"2018-10-21T19:35:21Z","updated_at":"2018-10-21T19:35:21Z","author_association":"CONTRIBUTOR","body":"Hello Dafydd,\r\n\r\nthe reason why on your local machine tests are passing fine while on Travis CI they are not is because you're actually launching tests in two differents ways:\r\n\r\n- on your local machine, you're invoking `python3 manage.py test`\r\n- on Travis CI, the test are invoked with `pytest`\r\n\r\nIf you tried running `pytest` on your local machine, they should be failing as well (they are on my local machine). The error message you're getting from Pytest (`Apps aren't loaded yet.`) is happening because Pytest is not aware that Django is involved, as Django has some setup to do before being able to run its code. To solve this problem:\r\n\r\n- you should install `pytest-django` (docs are [here](https://pytest-django.readthedocs.io/en/latest/index.html)), and possibly add this dependency to the `requirements.txt` file;\r\n- you should try running on your local machine `pytest --ds=sharespots.settings` (the `--ds` option is added by `pytest-django` and allows Pytest to make Django do its setup based on the settings file you provide there);\r\n- once you have verified that this new command runs the tests fine, change the `script` section in the `.travis.yml` file to be `pytest --ds=sharespots.settings`.\r\n\r\nLet me know if you need further help!\r\n\r\nStefano"}}
{"actor":{"display_login":"CianciuStyles"}}