{"action":"created","comment":{"url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/comments/227872143","pull_request_review_id":168011880,"id":227872143,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzg3MjE0Mw==","diff_hunk":"@@ -35,6 +35,9 @@ module Configuration\n         verbosity: 1,\n         http1_error_code: 500,\n         http1_error_code_minimum: 500,\n+        max_buffered_spans: 1_000,","path":"lib/bigcommerce/lightstep/configuration.rb","position":4,"original_position":4,"commit_id":"21aa05509f2e26cb5777d072975dad8aebf96c9a","original_commit_id":"21aa05509f2e26cb5777d072975dad8aebf96c9a","user":{"login":"splittingred","id":233334,"node_id":"MDQ6VXNlcjIzMzMzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/233334?v=4","gravatar_id":"","url":"https://api.github.com/users/splittingred","html_url":"https://github.com/splittingred","followers_url":"https://api.github.com/users/splittingred/followers","following_url":"https://api.github.com/users/splittingred/following{/other_user}","gists_url":"https://api.github.com/users/splittingred/gists{/gist_id}","starred_url":"https://api.github.com/users/splittingred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splittingred/subscriptions","organizations_url":"https://api.github.com/users/splittingred/orgs","repos_url":"https://api.github.com/users/splittingred/repos","events_url":"https://api.github.com/users/splittingred/events{/privacy}","received_events_url":"https://api.github.com/users/splittingred/received_events","type":"User","site_admin":false},"body":"@pedelman That is the default size for the lightstep ruby gem.","created_at":"2018-10-24T16:48:15Z","updated_at":"2018-10-24T16:48:15Z","html_url":"https://github.com/bigcommerce/bc-lightstep-ruby/pull/9#discussion_r227872143","pull_request_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/9","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/comments/227872143"},"html":{"href":"https://github.com/bigcommerce/bc-lightstep-ruby/pull/9#discussion_r227872143"},"pull_request":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/9"}},"in_reply_to_id":227871940},"pull_request":{"url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/9","id":225422893,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NDIyODkz","html_url":"https://github.com/bigcommerce/bc-lightstep-ruby/pull/9","diff_url":"https://github.com/bigcommerce/bc-lightstep-ruby/pull/9.diff","patch_url":"https://github.com/bigcommerce/bc-lightstep-ruby/pull/9.patch","issue_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues/9","number":9,"state":"closed","locked":false,"title":"PEN-975: Add configuration around reporting options","user":{"login":"splittingred","id":233334,"node_id":"MDQ6VXNlcjIzMzMzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/233334?v=4","gravatar_id":"","url":"https://api.github.com/users/splittingred","html_url":"https://github.com/splittingred","followers_url":"https://api.github.com/users/splittingred/followers","following_url":"https://api.github.com/users/splittingred/following{/other_user}","gists_url":"https://api.github.com/users/splittingred/gists{/gist_id}","starred_url":"https://api.github.com/users/splittingred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splittingred/subscriptions","organizations_url":"https://api.github.com/users/splittingred/orgs","repos_url":"https://api.github.com/users/splittingred/repos","events_url":"https://api.github.com/users/splittingred/events{/privacy}","received_events_url":"https://api.github.com/users/splittingred/received_events","type":"User","site_admin":false},"body":"## What?\r\n\r\n- Adds LIGHTSTEP_MAX_BUFFERED_SPANS config ENV + setting for maximum number of spans to buffer\r\n- Adds LIGHTSTEP_MAX_LOG_RECORDS config ENV + setting for maximum number of log records that can be on a span\r\n- Adds LIGHTSTEP_MAX_REPORTING_INTERVAL_SECONDS config ENV + setting for max reporting flush interval to collector\r\n\r\nBumps lightstep gem to 0.13.0.\r\n\r\n## How was it tested?\r\n\r\nTested on a few various services, spans come in as expected, can successfully adjust reporting periods.\r\n\r\n----\r\n\r\n@bigcommerce/platform-engineering @pedelman @zackangelo @zvuki \r\n","created_at":"2018-10-24T14:19:42Z","updated_at":"2018-10-24T16:48:15Z","closed_at":"2018-10-24T16:47:31Z","merged_at":"2018-10-24T16:47:31Z","merge_commit_sha":"df611824804c75cf021b140f6dd0384eb26941d8","assignee":{"login":"splittingred","id":233334,"node_id":"MDQ6VXNlcjIzMzMzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/233334?v=4","gravatar_id":"","url":"https://api.github.com/users/splittingred","html_url":"https://github.com/splittingred","followers_url":"https://api.github.com/users/splittingred/followers","following_url":"https://api.github.com/users/splittingred/following{/other_user}","gists_url":"https://api.github.com/users/splittingred/gists{/gist_id}","starred_url":"https://api.github.com/users/splittingred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splittingred/subscriptions","organizations_url":"https://api.github.com/users/splittingred/orgs","repos_url":"https://api.github.com/users/splittingred/repos","events_url":"https://api.github.com/users/splittingred/events{/privacy}","received_events_url":"https://api.github.com/users/splittingred/received_events","type":"User","site_admin":false},"assignees":[{"login":"splittingred","id":233334,"node_id":"MDQ6VXNlcjIzMzMzNA==","avatar_url":"https://avatars3.githubusercontent.com/u/233334?v=4","gravatar_id":"","url":"https://api.github.com/users/splittingred","html_url":"https://github.com/splittingred","followers_url":"https://api.github.com/users/splittingred/followers","following_url":"https://api.github.com/users/splittingred/following{/other_user}","gists_url":"https://api.github.com/users/splittingred/gists{/gist_id}","starred_url":"https://api.github.com/users/splittingred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/splittingred/subscriptions","organizations_url":"https://api.github.com/users/splittingred/orgs","repos_url":"https://api.github.com/users/splittingred/repos","events_url":"https://api.github.com/users/splittingred/events{/privacy}","received_events_url":"https://api.github.com/users/splittingred/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/9/commits","review_comments_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/9/comments","review_comment_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues/9/comments","statuses_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/statuses/21aa05509f2e26cb5777d072975dad8aebf96c9a","head":{"label":"bigcommerce:PEN-975","ref":"PEN-975","sha":"21aa05509f2e26cb5777d072975dad8aebf96c9a","user":{"login":"bigcommerce","id":186342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjM0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/186342?v=4","gravatar_id":"","url":"https://api.github.com/users/bigcommerce","html_url":"https://github.com/bigcommerce","followers_url":"https://api.github.com/users/bigcommerce/followers","following_url":"https://api.github.com/users/bigcommerce/following{/other_user}","gists_url":"https://api.github.com/users/bigcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/bigcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigcommerce/subscriptions","organizations_url":"https://api.github.com/users/bigcommerce/orgs","repos_url":"https://api.github.com/users/bigcommerce/repos","events_url":"https://api.github.com/users/bigcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/bigcommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":132977831,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5Nzc4MzE=","name":"bc-lightstep-ruby","full_name":"bigcommerce/bc-lightstep-ruby","private":false,"owner":{"login":"bigcommerce","id":186342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjM0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/186342?v=4","gravatar_id":"","url":"https://api.github.com/users/bigcommerce","html_url":"https://github.com/bigcommerce","followers_url":"https://api.github.com/users/bigcommerce/followers","following_url":"https://api.github.com/users/bigcommerce/following{/other_user}","gists_url":"https://api.github.com/users/bigcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/bigcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigcommerce/subscriptions","organizations_url":"https://api.github.com/users/bigcommerce/orgs","repos_url":"https://api.github.com/users/bigcommerce/repos","events_url":"https://api.github.com/users/bigcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/bigcommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bigcommerce/bc-lightstep-ruby","description":"Generic lightstep library for distributed tracing in ruby","fork":false,"url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby","forks_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/forks","keys_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/teams","hooks_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/hooks","issue_events_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/events","assignees_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/tags","blobs_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/languages","stargazers_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/stargazers","contributors_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/contributors","subscribers_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/subscribers","subscription_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/subscription","commits_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/merges","archive_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/downloads","issues_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/labels{/name}","releases_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/deployments","created_at":"2018-05-11T02:18:55Z","updated_at":"2018-10-24T16:47:34Z","pushed_at":"2018-10-24T16:47:32Z","git_url":"git://github.com/bigcommerce/bc-lightstep-ruby.git","ssh_url":"git@github.com:bigcommerce/bc-lightstep-ruby.git","clone_url":"https://github.com/bigcommerce/bc-lightstep-ruby.git","svn_url":"https://github.com/bigcommerce/bc-lightstep-ruby","homepage":null,"size":51,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"bigcommerce:master","ref":"master","sha":"0bf04e354b3826c7a6de3d3421ce09f5b020f646","user":{"login":"bigcommerce","id":186342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjM0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/186342?v=4","gravatar_id":"","url":"https://api.github.com/users/bigcommerce","html_url":"https://github.com/bigcommerce","followers_url":"https://api.github.com/users/bigcommerce/followers","following_url":"https://api.github.com/users/bigcommerce/following{/other_user}","gists_url":"https://api.github.com/users/bigcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/bigcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigcommerce/subscriptions","organizations_url":"https://api.github.com/users/bigcommerce/orgs","repos_url":"https://api.github.com/users/bigcommerce/repos","events_url":"https://api.github.com/users/bigcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/bigcommerce/received_events","type":"Organization","site_admin":false},"repo":{"id":132977831,"node_id":"MDEwOlJlcG9zaXRvcnkxMzI5Nzc4MzE=","name":"bc-lightstep-ruby","full_name":"bigcommerce/bc-lightstep-ruby","private":false,"owner":{"login":"bigcommerce","id":186342,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjM0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/186342?v=4","gravatar_id":"","url":"https://api.github.com/users/bigcommerce","html_url":"https://github.com/bigcommerce","followers_url":"https://api.github.com/users/bigcommerce/followers","following_url":"https://api.github.com/users/bigcommerce/following{/other_user}","gists_url":"https://api.github.com/users/bigcommerce/gists{/gist_id}","starred_url":"https://api.github.com/users/bigcommerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigcommerce/subscriptions","organizations_url":"https://api.github.com/users/bigcommerce/orgs","repos_url":"https://api.github.com/users/bigcommerce/repos","events_url":"https://api.github.com/users/bigcommerce/events{/privacy}","received_events_url":"https://api.github.com/users/bigcommerce/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bigcommerce/bc-lightstep-ruby","description":"Generic lightstep library for distributed tracing in ruby","fork":false,"url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby","forks_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/forks","keys_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/teams","hooks_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/hooks","issue_events_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/events","assignees_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/tags","blobs_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/languages","stargazers_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/stargazers","contributors_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/contributors","subscribers_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/subscribers","subscription_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/subscription","commits_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/merges","archive_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/downloads","issues_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/labels{/name}","releases_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/deployments","created_at":"2018-05-11T02:18:55Z","updated_at":"2018-10-24T16:47:34Z","pushed_at":"2018-10-24T16:47:32Z","git_url":"git://github.com/bigcommerce/bc-lightstep-ruby.git","ssh_url":"git@github.com:bigcommerce/bc-lightstep-ruby.git","clone_url":"https://github.com/bigcommerce/bc-lightstep-ruby.git","svn_url":"https://github.com/bigcommerce/bc-lightstep-ruby","homepage":null,"size":51,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/9"},"html":{"href":"https://github.com/bigcommerce/bc-lightstep-ruby/pull/9"},"issue":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues/9"},"comments":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/bigcommerce/bc-lightstep-ruby/statuses/21aa05509f2e26cb5777d072975dad8aebf96c9a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"splittingred"}}