{"action":"created","comment":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/180647053","pull_request_review_id":111101140,"id":180647053,"diff_hunk":"@@ -485,4 +485,50 @@ describe('urlutil', function () {\n       assert.deepEqual(result, {data: 'iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAYAAACNbyblAAAAHElEQVQI12P4//8/w38GIAXDIBKE0DHxgljNBAAO9TXL0Y4OHwAAAABJRU//5ErkJggg==', ext: 'png'})\n     })\n   })\n+  describe('shortenUrlToDomainTLD', function () {\n+    it('null scenario', function () {\n+      const result = urlUtil.shortenUrlToDomainTLD(null)\n+      assert.equal(result, null)\n+    })\n+\n+    it('empty string', function () {\n+      const result = urlUtil.shortenUrlToDomainTLD('')\n+      assert.equal(result, '')\n+    })\n+\n+    it('normal url', function () {\n+      const result = urlUtil.shortenUrlToDomainTLD('https://brave.com')\n+      assert.equal(result, 'https://brave.com/')","path":"test/unit/lib/urlutilTest.js","position":18,"original_position":17,"commit_id":"8bde65261cd0fbd3dbae539a6c868620a4b1ef95","original_commit_id":"70be7d85a44215f23d31cb844575ef17bbcdd78d","user":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"body":"other unit tests are failing because of that","created_at":"2018-04-11T06:32:29Z","updated_at":"2018-04-11T06:32:29Z","html_url":"https://github.com/brave/browser-laptop/pull/13675#discussion_r180647053","pull_request_url":"https://api.github.com/repos/brave/browser-laptop/pulls/13675","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments/180647053"},"html":{"href":"https://github.com/brave/browser-laptop/pull/13675#discussion_r180647053"},"pull_request":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/13675"}},"in_reply_to_id":180646655},"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/13675","id":178661837,"html_url":"https://github.com/brave/browser-laptop/pull/13675","diff_url":"https://github.com/brave/browser-laptop/pull/13675.diff","patch_url":"https://github.com/brave/browser-laptop/pull/13675.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/13675","number":13675,"state":"open","locked":false,"title":"Some verified publishers no longer remove green tick at sublevels - Fixes issue #10484","user":{"login":"jasonrsadler","id":25326067,"avatar_url":"https://avatars2.githubusercontent.com/u/25326067?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrsadler","html_url":"https://github.com/jasonrsadler","followers_url":"https://api.github.com/users/jasonrsadler/followers","following_url":"https://api.github.com/users/jasonrsadler/following{/other_user}","gists_url":"https://api.github.com/users/jasonrsadler/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrsadler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrsadler/subscriptions","organizations_url":"https://api.github.com/users/jasonrsadler/orgs","repos_url":"https://api.github.com/users/jasonrsadler/repos","events_url":"https://api.github.com/users/jasonrsadler/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrsadler/received_events","type":"User","site_admin":false},"body":"Fixes #10484\r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [x] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n- [x] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review). (Ask a Brave employee to help if you cannot access this document.)\r\n\r\n## Test Plan:\r\n\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review) if one was not already requested.\r\n\r\nTests\r\n\r\n\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n- [ ] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\nI could only get this to repro on the brianbondy site. All other verified pubs didn't have this problem. \r\n\r\nRegardless the addition allows the brianbondy sub levels to show green tick\r\n\r\nReview Requested @bsclifton \r\nSecurity Review Requested @diracdeltas ","created_at":"2018-03-31T02:26:39Z","updated_at":"2018-04-11T06:32:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3131505dc3df443ccce126313f38687816a8eee","assignee":{"login":"jasonrsadler","id":25326067,"avatar_url":"https://avatars2.githubusercontent.com/u/25326067?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrsadler","html_url":"https://github.com/jasonrsadler","followers_url":"https://api.github.com/users/jasonrsadler/followers","following_url":"https://api.github.com/users/jasonrsadler/following{/other_user}","gists_url":"https://api.github.com/users/jasonrsadler/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrsadler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrsadler/subscriptions","organizations_url":"https://api.github.com/users/jasonrsadler/orgs","repos_url":"https://api.github.com/users/jasonrsadler/repos","events_url":"https://api.github.com/users/jasonrsadler/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrsadler/received_events","type":"User","site_admin":false},"assignees":[{"login":"jasonrsadler","id":25326067,"avatar_url":"https://avatars2.githubusercontent.com/u/25326067?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrsadler","html_url":"https://github.com/jasonrsadler","followers_url":"https://api.github.com/users/jasonrsadler/followers","following_url":"https://api.github.com/users/jasonrsadler/following{/other_user}","gists_url":"https://api.github.com/users/jasonrsadler/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrsadler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrsadler/subscriptions","organizations_url":"https://api.github.com/users/jasonrsadler/orgs","repos_url":"https://api.github.com/users/jasonrsadler/repos","events_url":"https://api.github.com/users/jasonrsadler/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrsadler/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":408464251,"url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/ledger","name":"feature/ledger","color":"ff5000","default":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/109","html_url":"https://github.com/brave/browser-laptop/milestone/109","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/109/labels","id":3246523,"number":109,"title":"0.22.x Release 3 (Beta channel)","description":"Single-webview","creator":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":34,"state":"open","created_at":"2018-04-05T23:58:53Z","updated_at":"2018-04-11T06:04:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/13675/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/13675/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/13675/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/8bde65261cd0fbd3dbae539a6c868620a4b1ef95","head":{"label":"jasonrsadler:working-dir5","ref":"working-dir5","sha":"8bde65261cd0fbd3dbae539a6c868620a4b1ef95","user":{"login":"jasonrsadler","id":25326067,"avatar_url":"https://avatars2.githubusercontent.com/u/25326067?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrsadler","html_url":"https://github.com/jasonrsadler","followers_url":"https://api.github.com/users/jasonrsadler/followers","following_url":"https://api.github.com/users/jasonrsadler/following{/other_user}","gists_url":"https://api.github.com/users/jasonrsadler/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrsadler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrsadler/subscriptions","organizations_url":"https://api.github.com/users/jasonrsadler/orgs","repos_url":"https://api.github.com/users/jasonrsadler/repos","events_url":"https://api.github.com/users/jasonrsadler/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrsadler/received_events","type":"User","site_admin":false},"repo":{"id":123183590,"name":"browser-laptop","full_name":"jasonrsadler/browser-laptop","owner":{"login":"jasonrsadler","id":25326067,"avatar_url":"https://avatars2.githubusercontent.com/u/25326067?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonrsadler","html_url":"https://github.com/jasonrsadler","followers_url":"https://api.github.com/users/jasonrsadler/followers","following_url":"https://api.github.com/users/jasonrsadler/following{/other_user}","gists_url":"https://api.github.com/users/jasonrsadler/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonrsadler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonrsadler/subscriptions","organizations_url":"https://api.github.com/users/jasonrsadler/orgs","repos_url":"https://api.github.com/users/jasonrsadler/repos","events_url":"https://api.github.com/users/jasonrsadler/events{/privacy}","received_events_url":"https://api.github.com/users/jasonrsadler/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasonrsadler/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/jasonrsadler/browser-laptop","forks_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/forks","keys_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/teams","hooks_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/events","assignees_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/tags","blobs_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/subscription","commits_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/merges","archive_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/downloads","issues_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/jasonrsadler/browser-laptop/deployments","created_at":"2018-02-27T20:21:50Z","updated_at":"2018-02-27T20:21:56Z","pushed_at":"2018-04-11T06:31:08Z","git_url":"git://github.com/jasonrsadler/browser-laptop.git","ssh_url":"git@github.com:jasonrsadler/browser-laptop.git","clone_url":"https://github.com/jasonrsadler/browser-laptop.git","svn_url":"https://github.com/jasonrsadler/browser-laptop","homepage":"https://www.brave.com","size":82685,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"a3d80eb3b75978a5852f6653ae17d31ea020d9a3","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars1.githubusercontent.com/u/12301619?v=4","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2018-04-11T00:57:47Z","pushed_at":"2018-04-11T06:31:10Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":85256,"stargazers_count":7202,"watchers_count":7202,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":946,"mirror_url":null,"archived":false,"open_issues_count":2772,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":946,"open_issues":2772,"watchers":7202,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/13675"},"html":{"href":"https://github.com/brave/browser-laptop/pull/13675"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/13675"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/13675/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/13675/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/13675/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/8bde65261cd0fbd3dbae539a6c868620a4b1ef95"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"NejcZdovc"}}