{"action":"created","comment":{"url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/comments/222539727","pull_request_review_id":161439270,"id":222539727,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjUzOTcyNw==","diff_hunk":"@@ -0,0 +1,59 @@\n+package com.github.bordertech.wcomponents.test;\n+\n+import com.github.bordertech.wcomponents.test.components.WEmailFieldUI;\n+import com.github.bordertech.wcomponents.test.selenium.ByButton;\n+import com.github.bordertech.wcomponents.test.selenium.ByLabel;\n+import com.github.bordertech.wcomponents.test.selenium.MultiBrowserRunner;\n+import com.github.bordertech.wcomponents.test.selenium.SeleniumJettyTestCase;\n+import com.github.bordertech.wcomponents.test.selenium.driver.SeleniumWComponentsWebDriver;\n+import com.github.bordertech.wcomponents.test.selenium.element.SeleniumWButtonWebElement;\n+import com.github.bordertech.wcomponents.test.selenium.element.SeleniumWEmailFieldWebElement;\n+import com.github.bordertech.wcomponents.test.selenium.element.SeleniumWFieldIndicatorWebElement;\n+import com.github.bordertech.wcomponents.validation.AbstractWFieldIndicator;\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+\n+import static org.junit.Assert.assertEquals;\n+\n+@RunWith(MultiBrowserRunner.class)\n+public class WEmailFieldWebElementTest extends SeleniumJettyTestCase {\n+\n+\n+\t/**\n+\t * Constructor...\n+\t */\n+\tpublic WEmailFieldWebElementTest() {\n+\t\tsuper(new WEmailFieldUI());\n+\t}\n+\n+\n+\t@Test\n+\tpublic void testFeaturesOfEmailField() {\n+\t\tSeleniumWComponentsWebDriver driver = getDriver();\n+\n+\t\tSeleniumWButtonWebElement validatingButton = driver.findWButton(new ByButton(\"Validate button\", false, true));\n+\n+\t\tvalidatingButton.click();\n+\n+\t\tSeleniumWEmailFieldWebElement emailField = driver.findWEmailField(new ByLabel(\"this is a email field\", false));\n+\n+\t\temailField.sendKeys(\"dummy text\");\n+\t\tassertEquals(\"dummy text\", emailField.getValue());\n+\n+\t\tvalidatingButton = driver.findWButton(new ByButton(\"Validate button\", false, true));\n+\t\tvalidatingButton.click();\n+\n+\t\tSeleniumWFieldIndicatorWebElement message = emailField.getFieldIndicatorMessage();\n+\t\tassertEquals(message.getText(), \"this is a email field must be an email address.\");\n+\t\tassertEquals(message.getIndicatorType(), AbstractWFieldIndicator.FieldIndicatorType.ERROR);\n+\n+\n+\t\temailField.clear();\n+\t\temailField.sendKeys(\"dummy@gmail.com\");\n+\t\tassertEquals(\"dummy@gmail.com\", emailField.getValue());\n+\n+\t\tmessage = emailField.getFieldIndicatorMessage();\n+\t\tassertEquals(message.getText(), \"Successfully updated.\");\n+\t\tassertEquals(message.getIndicatorType(), AbstractWFieldIndicator.FieldIndicatorType.SUCCESS);\n+\t}\n+}","path":"wcomponents-test-lib/src/test/java/com/github/bordertech/wcomponents/test/WEmailFieldWebElementTest.java","position":59,"original_position":59,"commit_id":"ba4503cd0b138e3c799f0901708b16faa616be89","original_commit_id":"ba4503cd0b138e3c799f0901708b16faa616be89","user":{"login":"marksreeves","id":11661938,"node_id":"MDQ6VXNlcjExNjYxOTM4","avatar_url":"https://avatars0.githubusercontent.com/u/11661938?v=4","gravatar_id":"","url":"https://api.github.com/users/marksreeves","html_url":"https://github.com/marksreeves","followers_url":"https://api.github.com/users/marksreeves/followers","following_url":"https://api.github.com/users/marksreeves/following{/other_user}","gists_url":"https://api.github.com/users/marksreeves/gists{/gist_id}","starred_url":"https://api.github.com/users/marksreeves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marksreeves/subscriptions","organizations_url":"https://api.github.com/users/marksreeves/orgs","repos_url":"https://api.github.com/users/marksreeves/repos","events_url":"https://api.github.com/users/marksreeves/events{/privacy}","received_events_url":"https://api.github.com/users/marksreeves/received_events","type":"User","site_admin":false},"body":"I like this but would also like to see tests of the rest of the web element extension - getting a WEmailField in a disabled and a read-only state.","created_at":"2018-10-04T05:14:06Z","updated_at":"2018-10-04T05:28:10Z","html_url":"https://github.com/BorderTech/wcomponents/pull/1593#discussion_r222539727","pull_request_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/1593","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/comments/222539727"},"html":{"href":"https://github.com/BorderTech/wcomponents/pull/1593#discussion_r222539727"},"pull_request":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/1593"}}},"pull_request":{"url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/1593","id":218817467,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4ODE3NDY3","html_url":"https://github.com/BorderTech/wcomponents/pull/1593","diff_url":"https://github.com/BorderTech/wcomponents/pull/1593.diff","patch_url":"https://github.com/BorderTech/wcomponents/pull/1593.patch","issue_url":"https://api.github.com/repos/BorderTech/wcomponents/issues/1593","number":1593,"state":"open","locked":false,"title":"Extend test lib","user":{"login":"chrisdavis83","id":7054268,"node_id":"MDQ6VXNlcjcwNTQyNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/7054268?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdavis83","html_url":"https://github.com/chrisdavis83","followers_url":"https://api.github.com/users/chrisdavis83/followers","following_url":"https://api.github.com/users/chrisdavis83/following{/other_user}","gists_url":"https://api.github.com/users/chrisdavis83/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdavis83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdavis83/subscriptions","organizations_url":"https://api.github.com/users/chrisdavis83/orgs","repos_url":"https://api.github.com/users/chrisdavis83/repos","events_url":"https://api.github.com/users/chrisdavis83/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdavis83/received_events","type":"User","site_admin":false},"body":"@ricksbrown @marksreeves @jonathanaustin ","created_at":"2018-09-27T23:39:10Z","updated_at":"2018-10-04T05:28:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/1593/commits","review_comments_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/1593/comments","review_comment_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BorderTech/wcomponents/issues/1593/comments","statuses_url":"https://api.github.com/repos/BorderTech/wcomponents/statuses/ba4503cd0b138e3c799f0901708b16faa616be89","head":{"label":"chrisdavis83:extend_test_lib","ref":"extend_test_lib","sha":"ba4503cd0b138e3c799f0901708b16faa616be89","user":{"login":"chrisdavis83","id":7054268,"node_id":"MDQ6VXNlcjcwNTQyNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/7054268?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdavis83","html_url":"https://github.com/chrisdavis83","followers_url":"https://api.github.com/users/chrisdavis83/followers","following_url":"https://api.github.com/users/chrisdavis83/following{/other_user}","gists_url":"https://api.github.com/users/chrisdavis83/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdavis83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdavis83/subscriptions","organizations_url":"https://api.github.com/users/chrisdavis83/orgs","repos_url":"https://api.github.com/users/chrisdavis83/repos","events_url":"https://api.github.com/users/chrisdavis83/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdavis83/received_events","type":"User","site_admin":false},"repo":{"id":133289098,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyODkwOTg=","name":"wcomponents","full_name":"chrisdavis83/wcomponents","private":false,"owner":{"login":"chrisdavis83","id":7054268,"node_id":"MDQ6VXNlcjcwNTQyNjg=","avatar_url":"https://avatars0.githubusercontent.com/u/7054268?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdavis83","html_url":"https://github.com/chrisdavis83","followers_url":"https://api.github.com/users/chrisdavis83/followers","following_url":"https://api.github.com/users/chrisdavis83/following{/other_user}","gists_url":"https://api.github.com/users/chrisdavis83/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdavis83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdavis83/subscriptions","organizations_url":"https://api.github.com/users/chrisdavis83/orgs","repos_url":"https://api.github.com/users/chrisdavis83/repos","events_url":"https://api.github.com/users/chrisdavis83/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdavis83/received_events","type":"User","site_admin":false},"html_url":"https://github.com/chrisdavis83/wcomponents","description":"Accessible Web UI Framework for Enterprise","fork":true,"url":"https://api.github.com/repos/chrisdavis83/wcomponents","forks_url":"https://api.github.com/repos/chrisdavis83/wcomponents/forks","keys_url":"https://api.github.com/repos/chrisdavis83/wcomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisdavis83/wcomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisdavis83/wcomponents/teams","hooks_url":"https://api.github.com/repos/chrisdavis83/wcomponents/hooks","issue_events_url":"https://api.github.com/repos/chrisdavis83/wcomponents/issues/events{/number}","events_url":"https://api.github.com/repos/chrisdavis83/wcomponents/events","assignees_url":"https://api.github.com/repos/chrisdavis83/wcomponents/assignees{/user}","branches_url":"https://api.github.com/repos/chrisdavis83/wcomponents/branches{/branch}","tags_url":"https://api.github.com/repos/chrisdavis83/wcomponents/tags","blobs_url":"https://api.github.com/repos/chrisdavis83/wcomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisdavis83/wcomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisdavis83/wcomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisdavis83/wcomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisdavis83/wcomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisdavis83/wcomponents/languages","stargazers_url":"https://api.github.com/repos/chrisdavis83/wcomponents/stargazers","contributors_url":"https://api.github.com/repos/chrisdavis83/wcomponents/contributors","subscribers_url":"https://api.github.com/repos/chrisdavis83/wcomponents/subscribers","subscription_url":"https://api.github.com/repos/chrisdavis83/wcomponents/subscription","commits_url":"https://api.github.com/repos/chrisdavis83/wcomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisdavis83/wcomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisdavis83/wcomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisdavis83/wcomponents/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisdavis83/wcomponents/contents/{+path}","compare_url":"https://api.github.com/repos/chrisdavis83/wcomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisdavis83/wcomponents/merges","archive_url":"https://api.github.com/repos/chrisdavis83/wcomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisdavis83/wcomponents/downloads","issues_url":"https://api.github.com/repos/chrisdavis83/wcomponents/issues{/number}","pulls_url":"https://api.github.com/repos/chrisdavis83/wcomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisdavis83/wcomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisdavis83/wcomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisdavis83/wcomponents/labels{/name}","releases_url":"https://api.github.com/repos/chrisdavis83/wcomponents/releases{/id}","deployments_url":"https://api.github.com/repos/chrisdavis83/wcomponents/deployments","created_at":"2018-05-14T01:23:43Z","updated_at":"2018-09-25T03:48:51Z","pushed_at":"2018-10-03T04:20:18Z","git_url":"git://github.com/chrisdavis83/wcomponents.git","ssh_url":"git@github.com:chrisdavis83/wcomponents.git","clone_url":"https://github.com/chrisdavis83/wcomponents.git","svn_url":"https://github.com/chrisdavis83/wcomponents","homepage":"","size":95285,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BorderTech:release-1.5.14","ref":"release-1.5.14","sha":"d41a8e7d3a83e2e93e89039999ca8deb44b9753a","user":{"login":"BorderTech","id":11400614,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDAwNjE0","avatar_url":"https://avatars2.githubusercontent.com/u/11400614?v=4","gravatar_id":"","url":"https://api.github.com/users/BorderTech","html_url":"https://github.com/BorderTech","followers_url":"https://api.github.com/users/BorderTech/followers","following_url":"https://api.github.com/users/BorderTech/following{/other_user}","gists_url":"https://api.github.com/users/BorderTech/gists{/gist_id}","starred_url":"https://api.github.com/users/BorderTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorderTech/subscriptions","organizations_url":"https://api.github.com/users/BorderTech/orgs","repos_url":"https://api.github.com/users/BorderTech/repos","events_url":"https://api.github.com/users/BorderTech/events{/privacy}","received_events_url":"https://api.github.com/users/BorderTech/received_events","type":"Organization","site_admin":false},"repo":{"id":31935307,"node_id":"MDEwOlJlcG9zaXRvcnkzMTkzNTMwNw==","name":"wcomponents","full_name":"BorderTech/wcomponents","private":false,"owner":{"login":"BorderTech","id":11400614,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNDAwNjE0","avatar_url":"https://avatars2.githubusercontent.com/u/11400614?v=4","gravatar_id":"","url":"https://api.github.com/users/BorderTech","html_url":"https://github.com/BorderTech","followers_url":"https://api.github.com/users/BorderTech/followers","following_url":"https://api.github.com/users/BorderTech/following{/other_user}","gists_url":"https://api.github.com/users/BorderTech/gists{/gist_id}","starred_url":"https://api.github.com/users/BorderTech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BorderTech/subscriptions","organizations_url":"https://api.github.com/users/BorderTech/orgs","repos_url":"https://api.github.com/users/BorderTech/repos","events_url":"https://api.github.com/users/BorderTech/events{/privacy}","received_events_url":"https://api.github.com/users/BorderTech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BorderTech/wcomponents","description":"Accessible Web UI Framework for Enterprise","fork":false,"url":"https://api.github.com/repos/BorderTech/wcomponents","forks_url":"https://api.github.com/repos/BorderTech/wcomponents/forks","keys_url":"https://api.github.com/repos/BorderTech/wcomponents/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BorderTech/wcomponents/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BorderTech/wcomponents/teams","hooks_url":"https://api.github.com/repos/BorderTech/wcomponents/hooks","issue_events_url":"https://api.github.com/repos/BorderTech/wcomponents/issues/events{/number}","events_url":"https://api.github.com/repos/BorderTech/wcomponents/events","assignees_url":"https://api.github.com/repos/BorderTech/wcomponents/assignees{/user}","branches_url":"https://api.github.com/repos/BorderTech/wcomponents/branches{/branch}","tags_url":"https://api.github.com/repos/BorderTech/wcomponents/tags","blobs_url":"https://api.github.com/repos/BorderTech/wcomponents/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BorderTech/wcomponents/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BorderTech/wcomponents/git/refs{/sha}","trees_url":"https://api.github.com/repos/BorderTech/wcomponents/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BorderTech/wcomponents/statuses/{sha}","languages_url":"https://api.github.com/repos/BorderTech/wcomponents/languages","stargazers_url":"https://api.github.com/repos/BorderTech/wcomponents/stargazers","contributors_url":"https://api.github.com/repos/BorderTech/wcomponents/contributors","subscribers_url":"https://api.github.com/repos/BorderTech/wcomponents/subscribers","subscription_url":"https://api.github.com/repos/BorderTech/wcomponents/subscription","commits_url":"https://api.github.com/repos/BorderTech/wcomponents/commits{/sha}","git_commits_url":"https://api.github.com/repos/BorderTech/wcomponents/git/commits{/sha}","comments_url":"https://api.github.com/repos/BorderTech/wcomponents/comments{/number}","issue_comment_url":"https://api.github.com/repos/BorderTech/wcomponents/issues/comments{/number}","contents_url":"https://api.github.com/repos/BorderTech/wcomponents/contents/{+path}","compare_url":"https://api.github.com/repos/BorderTech/wcomponents/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BorderTech/wcomponents/merges","archive_url":"https://api.github.com/repos/BorderTech/wcomponents/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BorderTech/wcomponents/downloads","issues_url":"https://api.github.com/repos/BorderTech/wcomponents/issues{/number}","pulls_url":"https://api.github.com/repos/BorderTech/wcomponents/pulls{/number}","milestones_url":"https://api.github.com/repos/BorderTech/wcomponents/milestones{/number}","notifications_url":"https://api.github.com/repos/BorderTech/wcomponents/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BorderTech/wcomponents/labels{/name}","releases_url":"https://api.github.com/repos/BorderTech/wcomponents/releases{/id}","deployments_url":"https://api.github.com/repos/BorderTech/wcomponents/deployments","created_at":"2015-03-10T02:59:08Z","updated_at":"2018-09-20T12:15:26Z","pushed_at":"2018-10-03T04:20:19Z","git_url":"git://github.com/BorderTech/wcomponents.git","ssh_url":"git@github.com:BorderTech/wcomponents.git","clone_url":"https://github.com/BorderTech/wcomponents.git","svn_url":"https://github.com/BorderTech/wcomponents","homepage":"","size":95247,"stargazers_count":17,"watchers_count":17,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":80,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":18,"open_issues":80,"watchers":17,"default_branch":"georgie"}},"_links":{"self":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/1593"},"html":{"href":"https://github.com/BorderTech/wcomponents/pull/1593"},"issue":{"href":"https://api.github.com/repos/BorderTech/wcomponents/issues/1593"},"comments":{"href":"https://api.github.com/repos/BorderTech/wcomponents/issues/1593/comments"},"review_comments":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/1593/comments"},"review_comment":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BorderTech/wcomponents/pulls/1593/commits"},"statuses":{"href":"https://api.github.com/repos/BorderTech/wcomponents/statuses/ba4503cd0b138e3c799f0901708b16faa616be89"}},"author_association":"NONE"}}
{"actor":{"display_login":"marksreeves"}}