{"action":"created","comment":{"url":"https://api.github.com/repos/strongloop/loopback-next/pulls/comments/171400906","pull_request_review_id":100247694,"id":171400906,"diff_hunk":"@@ -0,0 +1,76 @@\n+// Copyright IBM Corp. 2018. All Rights Reserved.\n+// Node module: @loopback/openapi-v3\n+// This file is licensed under the MIT License.\n+// License text available at https://opensource.org/licenses/MIT\n+\n+import {\n+  ControllerSpec,\n+  post,\n+  requestBody,\n+  getControllerSpec,\n+} from '../../../../../';\n+import {ContentObject, SchemaObject} from '@loopback/openapi-v3-types';\n+import {Class} from '@loopback/repository';\n+import {expect} from '@loopback/testlab';\n+\n+describe('requestBody decorator', () => {\n+  context('for a primitive type', () => {\n+    let actualSpec: ControllerSpec;\n+    let expectedContent: ContentObject;\n+\n+    it('infers number', () => {\n+      class MyController {\n+        @post('/greeting')\n+        greet(@requestBody() name: number) {}\n+      }\n+      assertRequestBodySpec({type: 'number'}, MyController);\n+    });\n+\n+    it('infers string', () => {\n+      class MyController {\n+        @post('/greeting')\n+        greet(@requestBody() name: string) {}\n+      }\n+      assertRequestBodySpec({type: 'string'}, MyController);\n+    });\n+\n+    it('infers boolean', () => {\n+      class MyController {\n+        @post('/greeting')\n+        greet(@requestBody() name: boolean) {}\n+      }\n+      assertRequestBodySpec({type: 'boolean'}, MyController);\n+    });\n+\n+    it('infers object', () => {\n+      class MyController {\n+        @post('/greeting')\n+        greet(@requestBody() name: object) {}\n+      }\n+      assertRequestBodySpec({type: 'object'}, MyController);\n+    });\n+\n+    it('infers array', () => {","path":"packages/openapi-v3/test/unit/controller-spec/controller-decorators/request-body-decorators/primative-types.test.ts","position":53,"original_position":53,"commit_id":"fb79382a78546a05458a15778181439aacd9c4e9","original_commit_id":"fb79382a78546a05458a15778181439aacd9c4e9","user":{"login":"jannyHou","id":12554153,"avatar_url":"https://avatars0.githubusercontent.com/u/12554153?v=4","gravatar_id":"","url":"https://api.github.com/users/jannyHou","html_url":"https://github.com/jannyHou","followers_url":"https://api.github.com/users/jannyHou/followers","following_url":"https://api.github.com/users/jannyHou/following{/other_user}","gists_url":"https://api.github.com/users/jannyHou/gists{/gist_id}","starred_url":"https://api.github.com/users/jannyHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannyHou/subscriptions","organizations_url":"https://api.github.com/users/jannyHou/orgs","repos_url":"https://api.github.com/users/jannyHou/repos","events_url":"https://api.github.com/users/jannyHou/events{/privacy}","received_events_url":"https://api.github.com/users/jannyHou/received_events","type":"User","site_admin":false},"body":"@shimks I am summarizing some features/improve we want for `@requestBody`, sorry I don't want to keep adding features in this PR since it blocks the 4th PR(upgrade the whole project), after land this one people can work on the improvement and upgrade in parallel.","created_at":"2018-02-28T22:05:45Z","updated_at":"2018-02-28T22:05:45Z","html_url":"https://github.com/strongloop/loopback-next/pull/1046#discussion_r171400906","pull_request_url":"https://api.github.com/repos/strongloop/loopback-next/pulls/1046","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/comments/171400906"},"html":{"href":"https://github.com/strongloop/loopback-next/pull/1046#discussion_r171400906"},"pull_request":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/1046"}},"in_reply_to_id":171288612},"pull_request":{"url":"https://api.github.com/repos/strongloop/loopback-next/pulls/1046","id":171114869,"html_url":"https://github.com/strongloop/loopback-next/pull/1046","diff_url":"https://github.com/strongloop/loopback-next/pull/1046.diff","patch_url":"https://github.com/strongloop/loopback-next/pull/1046.patch","issue_url":"https://api.github.com/repos/strongloop/loopback-next/issues/1046","number":1046,"state":"open","locked":false,"title":"feat: adding openapi-v3","user":{"login":"jannyHou","id":12554153,"avatar_url":"https://avatars0.githubusercontent.com/u/12554153?v=4","gravatar_id":"","url":"https://api.github.com/users/jannyHou","html_url":"https://github.com/jannyHou","followers_url":"https://api.github.com/users/jannyHou/followers","following_url":"https://api.github.com/users/jannyHou/following{/other_user}","gists_url":"https://api.github.com/users/jannyHou/gists{/gist_id}","starred_url":"https://api.github.com/users/jannyHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannyHou/subscriptions","organizations_url":"https://api.github.com/users/jannyHou/orgs","repos_url":"https://api.github.com/users/jannyHou/repos","events_url":"https://api.github.com/users/jannyHou/events{/privacy}","received_events_url":"https://api.github.com/users/jannyHou/received_events","type":"User","site_admin":false},"body":"connect to: https://github.com/strongloop/loopback-next/issues/753\r\n\r\n## Description\r\n\r\nThis is the 3rd PR of prototype PR: https://github.com/strongloop/loopback-next/pull/916#issuecomment-365980587\r\n\r\nconnect to issue: https://github.com/strongloop/loopback-next/issues/753\r\n\r\n## Review\r\n\r\n- the first commit just copy paste `openapi-v2` package for comparison, please review code change from the 2nd commit\r\n- commit `test: add tests` contains all the test files(30) update\r\n- other files update are separated into each commit, usually one or a few file's change\r\n\r\n\r\n## Checklist\r\n\r\n- [x] `npm test` passes on your machine\r\n- [x] New tests added or existing tests modified to cover all changes\r\n- [x] Code conforms with the [style guide](http://loopback.io/doc/en/contrib/style-guide.html)\r\n- [ ] Related API Documentation was updated\r\n- [ ] ~Affected artifact templates in `packages/cli` were updated~\r\n- [ ] ~Affected example projects in `packages/example-*` were updated~\r\n","created_at":"2018-02-23T20:58:38Z","updated_at":"2018-02-28T22:05:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d3a582f05bc75eb061ae21491e4dd424e1117114","assignee":{"login":"jannyHou","id":12554153,"avatar_url":"https://avatars0.githubusercontent.com/u/12554153?v=4","gravatar_id":"","url":"https://api.github.com/users/jannyHou","html_url":"https://github.com/jannyHou","followers_url":"https://api.github.com/users/jannyHou/followers","following_url":"https://api.github.com/users/jannyHou/following{/other_user}","gists_url":"https://api.github.com/users/jannyHou/gists{/gist_id}","starred_url":"https://api.github.com/users/jannyHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannyHou/subscriptions","organizations_url":"https://api.github.com/users/jannyHou/orgs","repos_url":"https://api.github.com/users/jannyHou/repos","events_url":"https://api.github.com/users/jannyHou/events{/privacy}","received_events_url":"https://api.github.com/users/jannyHou/received_events","type":"User","site_admin":false},"assignees":[{"login":"jannyHou","id":12554153,"avatar_url":"https://avatars0.githubusercontent.com/u/12554153?v=4","gravatar_id":"","url":"https://api.github.com/users/jannyHou","html_url":"https://github.com/jannyHou","followers_url":"https://api.github.com/users/jannyHou/followers","following_url":"https://api.github.com/users/jannyHou/following{/other_user}","gists_url":"https://api.github.com/users/jannyHou/gists{/gist_id}","starred_url":"https://api.github.com/users/jannyHou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jannyHou/subscriptions","organizations_url":"https://api.github.com/users/jannyHou/orgs","repos_url":"https://api.github.com/users/jannyHou/repos","events_url":"https://api.github.com/users/jannyHou/events{/privacy}","received_events_url":"https://api.github.com/users/jannyHou/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"raymondfeng","id":540892,"avatar_url":"https://avatars0.githubusercontent.com/u/540892?v=4","gravatar_id":"","url":"https://api.github.com/users/raymondfeng","html_url":"https://github.com/raymondfeng","followers_url":"https://api.github.com/users/raymondfeng/followers","following_url":"https://api.github.com/users/raymondfeng/following{/other_user}","gists_url":"https://api.github.com/users/raymondfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/raymondfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raymondfeng/subscriptions","organizations_url":"https://api.github.com/users/raymondfeng/orgs","repos_url":"https://api.github.com/users/raymondfeng/repos","events_url":"https://api.github.com/users/raymondfeng/events{/privacy}","received_events_url":"https://api.github.com/users/raymondfeng/received_events","type":"User","site_admin":false},{"login":"kjdelisle","id":2053534,"avatar_url":"https://avatars3.githubusercontent.com/u/2053534?v=4","gravatar_id":"","url":"https://api.github.com/users/kjdelisle","html_url":"https://github.com/kjdelisle","followers_url":"https://api.github.com/users/kjdelisle/followers","following_url":"https://api.github.com/users/kjdelisle/following{/other_user}","gists_url":"https://api.github.com/users/kjdelisle/gists{/gist_id}","starred_url":"https://api.github.com/users/kjdelisle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kjdelisle/subscriptions","organizations_url":"https://api.github.com/users/kjdelisle/orgs","repos_url":"https://api.github.com/users/kjdelisle/repos","events_url":"https://api.github.com/users/kjdelisle/events{/privacy}","received_events_url":"https://api.github.com/users/kjdelisle/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":570635289,"url":"https://api.github.com/repos/strongloop/loopback-next/labels/needs-priority","name":"needs-priority","color":"eeeeee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/strongloop/loopback-next/pulls/1046/commits","review_comments_url":"https://api.github.com/repos/strongloop/loopback-next/pulls/1046/comments","review_comment_url":"https://api.github.com/repos/strongloop/loopback-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongloop/loopback-next/issues/1046/comments","statuses_url":"https://api.github.com/repos/strongloop/loopback-next/statuses/fb79382a78546a05458a15778181439aacd9c4e9","head":{"label":"strongloop:oas3/openapi-v3","ref":"oas3/openapi-v3","sha":"fb79382a78546a05458a15778181439aacd9c4e9","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":78452015,"name":"loopback-next","full_name":"strongloop/loopback-next","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-next","description":"LoopBack makes it easy to build modern API applications that require complex integrations.","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-next","forks_url":"https://api.github.com/repos/strongloop/loopback-next/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-next/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-next/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-next/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-next/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-next/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-next/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-next/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-next/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-next/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-next/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-next/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-next/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-next/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-next/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-next/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-next/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-next/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-next/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-next/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-next/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-next/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-next/deployments","created_at":"2017-01-09T17:27:14Z","updated_at":"2018-02-27T23:12:47Z","pushed_at":"2018-02-28T14:56:10Z","git_url":"git://github.com/strongloop/loopback-next.git","ssh_url":"git@github.com:strongloop/loopback-next.git","clone_url":"https://github.com/strongloop/loopback-next.git","svn_url":"https://github.com/strongloop/loopback-next","homepage":"http://loopback.io","size":2256,"stargazers_count":505,"watchers_count":505,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":45,"open_issues":228,"watchers":505,"default_branch":"master"}},"base":{"label":"strongloop:master","ref":"master","sha":"3fccb5b735368ba47ba45482cb8bec7cdd56702b","user":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"repo":{"id":78452015,"name":"loopback-next","full_name":"strongloop/loopback-next","owner":{"login":"strongloop","id":3020012,"avatar_url":"https://avatars1.githubusercontent.com/u/3020012?v=4","gravatar_id":"","url":"https://api.github.com/users/strongloop","html_url":"https://github.com/strongloop","followers_url":"https://api.github.com/users/strongloop/followers","following_url":"https://api.github.com/users/strongloop/following{/other_user}","gists_url":"https://api.github.com/users/strongloop/gists{/gist_id}","starred_url":"https://api.github.com/users/strongloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongloop/subscriptions","organizations_url":"https://api.github.com/users/strongloop/orgs","repos_url":"https://api.github.com/users/strongloop/repos","events_url":"https://api.github.com/users/strongloop/events{/privacy}","received_events_url":"https://api.github.com/users/strongloop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strongloop/loopback-next","description":"LoopBack makes it easy to build modern API applications that require complex integrations.","fork":false,"url":"https://api.github.com/repos/strongloop/loopback-next","forks_url":"https://api.github.com/repos/strongloop/loopback-next/forks","keys_url":"https://api.github.com/repos/strongloop/loopback-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongloop/loopback-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongloop/loopback-next/teams","hooks_url":"https://api.github.com/repos/strongloop/loopback-next/hooks","issue_events_url":"https://api.github.com/repos/strongloop/loopback-next/issues/events{/number}","events_url":"https://api.github.com/repos/strongloop/loopback-next/events","assignees_url":"https://api.github.com/repos/strongloop/loopback-next/assignees{/user}","branches_url":"https://api.github.com/repos/strongloop/loopback-next/branches{/branch}","tags_url":"https://api.github.com/repos/strongloop/loopback-next/tags","blobs_url":"https://api.github.com/repos/strongloop/loopback-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongloop/loopback-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongloop/loopback-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongloop/loopback-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongloop/loopback-next/statuses/{sha}","languages_url":"https://api.github.com/repos/strongloop/loopback-next/languages","stargazers_url":"https://api.github.com/repos/strongloop/loopback-next/stargazers","contributors_url":"https://api.github.com/repos/strongloop/loopback-next/contributors","subscribers_url":"https://api.github.com/repos/strongloop/loopback-next/subscribers","subscription_url":"https://api.github.com/repos/strongloop/loopback-next/subscription","commits_url":"https://api.github.com/repos/strongloop/loopback-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongloop/loopback-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongloop/loopback-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongloop/loopback-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongloop/loopback-next/contents/{+path}","compare_url":"https://api.github.com/repos/strongloop/loopback-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongloop/loopback-next/merges","archive_url":"https://api.github.com/repos/strongloop/loopback-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongloop/loopback-next/downloads","issues_url":"https://api.github.com/repos/strongloop/loopback-next/issues{/number}","pulls_url":"https://api.github.com/repos/strongloop/loopback-next/pulls{/number}","milestones_url":"https://api.github.com/repos/strongloop/loopback-next/milestones{/number}","notifications_url":"https://api.github.com/repos/strongloop/loopback-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongloop/loopback-next/labels{/name}","releases_url":"https://api.github.com/repos/strongloop/loopback-next/releases{/id}","deployments_url":"https://api.github.com/repos/strongloop/loopback-next/deployments","created_at":"2017-01-09T17:27:14Z","updated_at":"2018-02-27T23:12:47Z","pushed_at":"2018-02-28T14:56:10Z","git_url":"git://github.com/strongloop/loopback-next.git","ssh_url":"git@github.com:strongloop/loopback-next.git","clone_url":"https://github.com/strongloop/loopback-next.git","svn_url":"https://github.com/strongloop/loopback-next","homepage":"http://loopback.io","size":2256,"stargazers_count":505,"watchers_count":505,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":228,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":45,"open_issues":228,"watchers":505,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/1046"},"html":{"href":"https://github.com/strongloop/loopback-next/pull/1046"},"issue":{"href":"https://api.github.com/repos/strongloop/loopback-next/issues/1046"},"comments":{"href":"https://api.github.com/repos/strongloop/loopback-next/issues/1046/comments"},"review_comments":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/1046/comments"},"review_comment":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongloop/loopback-next/pulls/1046/commits"},"statuses":{"href":"https://api.github.com/repos/strongloop/loopback-next/statuses/fb79382a78546a05458a15778181439aacd9c4e9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jannyHou"}}