{"action":"created","issue":{"url":"https://api.github.com/repos/gabime/spdlog/issues/691","repository_url":"https://api.github.com/repos/gabime/spdlog","labels_url":"https://api.github.com/repos/gabime/spdlog/issues/691/labels{/name}","comments_url":"https://api.github.com/repos/gabime/spdlog/issues/691/comments","events_url":"https://api.github.com/repos/gabime/spdlog/issues/691/events","html_url":"https://github.com/gabime/spdlog/pull/691","id":316293180,"number":691,"title":"Add allocator support","user":{"login":"Bousk","id":29147033,"avatar_url":"https://avatars3.githubusercontent.com/u/29147033?v=4","gravatar_id":"","url":"https://api.github.com/users/Bousk","html_url":"https://github.com/Bousk","followers_url":"https://api.github.com/users/Bousk/followers","following_url":"https://api.github.com/users/Bousk/following{/other_user}","gists_url":"https://api.github.com/users/Bousk/gists{/gist_id}","starred_url":"https://api.github.com/users/Bousk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bousk/subscriptions","organizations_url":"https://api.github.com/users/Bousk/orgs","repos_url":"https://api.github.com/users/Bousk/repos","events_url":"https://api.github.com/users/Bousk/events{/privacy}","received_events_url":"https://api.github.com/users/Bousk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-20T14:36:22Z","updated_at":"2018-04-23T08:47:16Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gabime/spdlog/pulls/691","html_url":"https://github.com/gabime/spdlog/pull/691","diff_url":"https://github.com/gabime/spdlog/pull/691.diff","patch_url":"https://github.com/gabime/spdlog/pull/691.patch"},"body":"Hi,\r\n\r\nI was trying to use spdlog, but evolving in a tight memory industry, I had to add allocator support first.\r\nThat being done, here is my modest contribution back to you. I could try only on PC though.\r\n\r\nAllocators default to std::malloc & std::free so if you don't care or are already using spdlog and want to keep using default allocators, it makes no difference to you\r\nTo override allocators, use\r\n> spdlog::allocator().allocate = xx; // or lambda [](size_t size) { return MyOwnMalloc(size); };\r\n> spdlog::allocator().deallocate = yy; // or lambda [](void* ptr) { MyOwnFree(ptr); };\r\n\r\nCheers,\r\nCyrille // Bousk"},"comment":{"url":"https://api.github.com/repos/gabime/spdlog/issues/comments/383501073","html_url":"https://github.com/gabime/spdlog/pull/691#issuecomment-383501073","issue_url":"https://api.github.com/repos/gabime/spdlog/issues/691","id":383501073,"user":{"login":"Bousk","id":29147033,"avatar_url":"https://avatars3.githubusercontent.com/u/29147033?v=4","gravatar_id":"","url":"https://api.github.com/users/Bousk","html_url":"https://github.com/Bousk","followers_url":"https://api.github.com/users/Bousk/followers","following_url":"https://api.github.com/users/Bousk/following{/other_user}","gists_url":"https://api.github.com/users/Bousk/gists{/gist_id}","starred_url":"https://api.github.com/users/Bousk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bousk/subscriptions","organizations_url":"https://api.github.com/users/Bousk/orgs","repos_url":"https://api.github.com/users/Bousk/repos","events_url":"https://api.github.com/users/Bousk/events{/privacy}","received_events_url":"https://api.github.com/users/Bousk/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T08:47:16Z","updated_at":"2018-04-23T08:47:16Z","author_association":"NONE","body":"Right now XOne & PS4. I have troubles with exceptions now though as those are disabled. I'm thinking adding a SPD_LOG_NO_EXCEPTION in tweakme.h but it could be quiet a lot of work to make it work properly. I'm still estimating how many hours it would take."}}
{"actor":{"display_login":"Bousk"}}