{"action":"created","issue":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/2944","repository_url":"https://api.github.com/repos/kaldi-asr/kaldi","labels_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/2944/labels{/name}","comments_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/2944/comments","events_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/2944/events","html_url":"https://github.com/kaldi-asr/kaldi/pull/2944","id":394425601,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTc2ODI5","number":2944,"title":"Handle dependencies for .cu files in addition to .cc files","user":{"login":"ryanleary","id":2212584,"node_id":"MDQ6VXNlcjIyMTI1ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2212584?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanleary","html_url":"https://github.com/ryanleary","followers_url":"https://api.github.com/users/ryanleary/followers","following_url":"https://api.github.com/users/ryanleary/following{/other_user}","gists_url":"https://api.github.com/users/ryanleary/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanleary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanleary/subscriptions","organizations_url":"https://api.github.com/users/ryanleary/orgs","repos_url":"https://api.github.com/users/ryanleary/repos","events_url":"https://api.github.com/users/ryanleary/events{/privacy}","received_events_url":"https://api.github.com/users/ryanleary/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-27T15:41:40Z","updated_at":"2018-12-27T20:39:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/pulls/2944","html_url":"https://github.com/kaldi-asr/kaldi/pull/2944","diff_url":"https://github.com/kaldi-asr/kaldi/pull/2944.diff","patch_url":"https://github.com/kaldi-asr/kaldi/pull/2944.patch"},"body":"Dependencies are not currently tracked properly for .cu files."},"comment":{"url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/comments/450227129","html_url":"https://github.com/kaldi-asr/kaldi/pull/2944#issuecomment-450227129","issue_url":"https://api.github.com/repos/kaldi-asr/kaldi/issues/2944","id":450227129,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDIyNzEyOQ==","user":{"login":"luitjens","id":6576498,"node_id":"MDQ6VXNlcjY1NzY0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6576498?v=4","gravatar_id":"","url":"https://api.github.com/users/luitjens","html_url":"https://github.com/luitjens","followers_url":"https://api.github.com/users/luitjens/followers","following_url":"https://api.github.com/users/luitjens/following{/other_user}","gists_url":"https://api.github.com/users/luitjens/gists{/gist_id}","starred_url":"https://api.github.com/users/luitjens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luitjens/subscriptions","organizations_url":"https://api.github.com/users/luitjens/orgs","repos_url":"https://api.github.com/users/luitjens/repos","events_url":"https://api.github.com/users/luitjens/events{/privacy}","received_events_url":"https://api.github.com/users/luitjens/received_events","type":"User","site_admin":false},"created_at":"2018-12-27T20:39:55Z","updated_at":"2018-12-27T20:39:55Z","author_association":"NONE","body":"I believe it does.  this patch only includes .cu dependencies if cuda is\nenabled.  it also improves on existing functionality by not assuming a .cc\nfile exists.\n\nOn Thu, Dec 27, 2018, 1:09 PM Daniel Povey <notifications@github.com wrote:\n\n> That type of failure is common, it's a long standing issue related to\n> caching, that we haven't been able to debug.\n> Sorry I didn't have a chance to get back to you yesterday about this.\n> Be aware that, I believe, we build without CUDA support in travis. You\n> need to make sure that your patch works both with and without CUDA being\n> enabled.\n>\n> On Thu, Dec 27, 2018 at 8:50 AM Justin Luitjens <notifications@github.com>\n> wrote:\n>\n> > Dan any idea why travis failed? It looks like it might have ran out of\n> > space:\n> >\n> > ../lat/libkaldi-lat.so: file not recognized: File truncated\n> > clang: error: linker command failed with exit code 1 (use -v to see\n> > invocation)\n> > make[2]: *** [libkaldi-decoder.so] Error 1\n> > make[2]: Leaving directory\n> `/home/travis/build/kaldi-asr/kaldi/src/decoder'\n> > make[1]: *** [decoder] Error 2\n> >\n> > —\n> > You are receiving this because you are subscribed to this thread.\n> > Reply to this email directly, view it on GitHub\n> > <https://github.com/kaldi-asr/kaldi/pull/2944#issuecomment-450189259>,\n> or mute\n> > the thread\n> > <\n> https://github.com/notifications/unsubscribe-auth/ADJVuwgMzT6ZEjZ71Xh5sEkSz9012ixJks5u9PpigaJpZM4Zi6TL\n> >\n> > .\n> >\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/kaldi-asr/kaldi/pull/2944#issuecomment-450221895>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AGRZchBqH2gLTj-09p-E26ZA-Yz_Iq9bks5u9SkDgaJpZM4Zi6TL>\n> .\n>\n"}}
{"actor":{"display_login":"luitjens"}}