{"action":"closed","number":182,"pull_request":{"url":"https://api.github.com/repos/Peripli/service-manager/pulls/182","id":230849485,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODQ5NDg1","html_url":"https://github.com/Peripli/service-manager/pull/182","diff_url":"https://github.com/Peripli/service-manager/pull/182.diff","patch_url":"https://github.com/Peripli/service-manager/pull/182.patch","issue_url":"https://api.github.com/repos/Peripli/service-manager/issues/182","number":182,"state":"closed","locked":false,"title":"Limit request body size and header size with configuration","user":{"login":"pankrator","id":4245946,"node_id":"MDQ6VXNlcjQyNDU5NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4245946?v=4","gravatar_id":"","url":"https://api.github.com/users/pankrator","html_url":"https://github.com/pankrator","followers_url":"https://api.github.com/users/pankrator/followers","following_url":"https://api.github.com/users/pankrator/following{/other_user}","gists_url":"https://api.github.com/users/pankrator/gists{/gist_id}","starred_url":"https://api.github.com/users/pankrator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pankrator/subscriptions","organizations_url":"https://api.github.com/users/pankrator/orgs","repos_url":"https://api.github.com/users/pankrator/repos","events_url":"https://api.github.com/users/pankrator/events{/privacy}","received_events_url":"https://api.github.com/users/pankrator/received_events","type":"User","site_admin":false},"body":"## Motivation\r\nSM should be able to configure the maximum body request size and header sizes\r\n\r\n## Pull Request status\r\n\r\n* [x] Limit the incoming request body size\r\n* [x] Limit the incoming request headers size\r\n* [ ] Limit the response body size from brokers\r\n* [ ] Unit tests\r\n\r\nCurrently there is no easy way to test request headers size, as this requires to start real http.Server, rather than a httptest.Server. Tested it with Postman and it rejects request with large header values.","created_at":"2018-11-14T14:13:14Z","updated_at":"2018-11-19T12:53:21Z","closed_at":"2018-11-19T12:53:21Z","merged_at":"2018-11-19T12:53:21Z","merge_commit_sha":"b8047ba64c856796ded0ed3187e249b07317fd14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Peripli/service-manager/pulls/182/commits","review_comments_url":"https://api.github.com/repos/Peripli/service-manager/pulls/182/comments","review_comment_url":"https://api.github.com/repos/Peripli/service-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Peripli/service-manager/issues/182/comments","statuses_url":"https://api.github.com/repos/Peripli/service-manager/statuses/cc858cb18d279f617bae830a6427751a46083471","head":{"label":"Peripli:limit-request","ref":"limit-request","sha":"cc858cb18d279f617bae830a6427751a46083471","user":{"login":"Peripli","id":36069234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDY5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/36069234?v=4","gravatar_id":"","url":"https://api.github.com/users/Peripli","html_url":"https://github.com/Peripli","followers_url":"https://api.github.com/users/Peripli/followers","following_url":"https://api.github.com/users/Peripli/following{/other_user}","gists_url":"https://api.github.com/users/Peripli/gists{/gist_id}","starred_url":"https://api.github.com/users/Peripli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peripli/subscriptions","organizations_url":"https://api.github.com/users/Peripli/orgs","repos_url":"https://api.github.com/users/Peripli/repos","events_url":"https://api.github.com/users/Peripli/events{/privacy}","received_events_url":"https://api.github.com/users/Peripli/received_events","type":"Organization","site_admin":false},"repo":{"id":123334573,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMzQ1NzM=","name":"service-manager","full_name":"Peripli/service-manager","private":false,"owner":{"login":"Peripli","id":36069234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDY5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/36069234?v=4","gravatar_id":"","url":"https://api.github.com/users/Peripli","html_url":"https://github.com/Peripli","followers_url":"https://api.github.com/users/Peripli/followers","following_url":"https://api.github.com/users/Peripli/following{/other_user}","gists_url":"https://api.github.com/users/Peripli/gists{/gist_id}","starred_url":"https://api.github.com/users/Peripli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peripli/subscriptions","organizations_url":"https://api.github.com/users/Peripli/orgs","repos_url":"https://api.github.com/users/Peripli/repos","events_url":"https://api.github.com/users/Peripli/events{/privacy}","received_events_url":"https://api.github.com/users/Peripli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Peripli/service-manager","description":"Service Manager Core","fork":false,"url":"https://api.github.com/repos/Peripli/service-manager","forks_url":"https://api.github.com/repos/Peripli/service-manager/forks","keys_url":"https://api.github.com/repos/Peripli/service-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Peripli/service-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Peripli/service-manager/teams","hooks_url":"https://api.github.com/repos/Peripli/service-manager/hooks","issue_events_url":"https://api.github.com/repos/Peripli/service-manager/issues/events{/number}","events_url":"https://api.github.com/repos/Peripli/service-manager/events","assignees_url":"https://api.github.com/repos/Peripli/service-manager/assignees{/user}","branches_url":"https://api.github.com/repos/Peripli/service-manager/branches{/branch}","tags_url":"https://api.github.com/repos/Peripli/service-manager/tags","blobs_url":"https://api.github.com/repos/Peripli/service-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Peripli/service-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Peripli/service-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Peripli/service-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Peripli/service-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/Peripli/service-manager/languages","stargazers_url":"https://api.github.com/repos/Peripli/service-manager/stargazers","contributors_url":"https://api.github.com/repos/Peripli/service-manager/contributors","subscribers_url":"https://api.github.com/repos/Peripli/service-manager/subscribers","subscription_url":"https://api.github.com/repos/Peripli/service-manager/subscription","commits_url":"https://api.github.com/repos/Peripli/service-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Peripli/service-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Peripli/service-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Peripli/service-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Peripli/service-manager/contents/{+path}","compare_url":"https://api.github.com/repos/Peripli/service-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Peripli/service-manager/merges","archive_url":"https://api.github.com/repos/Peripli/service-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Peripli/service-manager/downloads","issues_url":"https://api.github.com/repos/Peripli/service-manager/issues{/number}","pulls_url":"https://api.github.com/repos/Peripli/service-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/Peripli/service-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/Peripli/service-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Peripli/service-manager/labels{/name}","releases_url":"https://api.github.com/repos/Peripli/service-manager/releases{/id}","deployments_url":"https://api.github.com/repos/Peripli/service-manager/deployments","created_at":"2018-02-28T19:51:32Z","updated_at":"2018-11-16T09:46:49Z","pushed_at":"2018-11-19T12:53:21Z","git_url":"git://github.com/Peripli/service-manager.git","ssh_url":"git@github.com:Peripli/service-manager.git","clone_url":"https://github.com/Peripli/service-manager.git","svn_url":"https://github.com/Peripli/service-manager","homepage":"","size":976,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":37,"watchers":22,"default_branch":"master"}},"base":{"label":"Peripli:master","ref":"master","sha":"d5aafec33c2e8c8ba5051f5dba79d3421cddb2b6","user":{"login":"Peripli","id":36069234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDY5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/36069234?v=4","gravatar_id":"","url":"https://api.github.com/users/Peripli","html_url":"https://github.com/Peripli","followers_url":"https://api.github.com/users/Peripli/followers","following_url":"https://api.github.com/users/Peripli/following{/other_user}","gists_url":"https://api.github.com/users/Peripli/gists{/gist_id}","starred_url":"https://api.github.com/users/Peripli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peripli/subscriptions","organizations_url":"https://api.github.com/users/Peripli/orgs","repos_url":"https://api.github.com/users/Peripli/repos","events_url":"https://api.github.com/users/Peripli/events{/privacy}","received_events_url":"https://api.github.com/users/Peripli/received_events","type":"Organization","site_admin":false},"repo":{"id":123334573,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMzMzQ1NzM=","name":"service-manager","full_name":"Peripli/service-manager","private":false,"owner":{"login":"Peripli","id":36069234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDY5MjM0","avatar_url":"https://avatars1.githubusercontent.com/u/36069234?v=4","gravatar_id":"","url":"https://api.github.com/users/Peripli","html_url":"https://github.com/Peripli","followers_url":"https://api.github.com/users/Peripli/followers","following_url":"https://api.github.com/users/Peripli/following{/other_user}","gists_url":"https://api.github.com/users/Peripli/gists{/gist_id}","starred_url":"https://api.github.com/users/Peripli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peripli/subscriptions","organizations_url":"https://api.github.com/users/Peripli/orgs","repos_url":"https://api.github.com/users/Peripli/repos","events_url":"https://api.github.com/users/Peripli/events{/privacy}","received_events_url":"https://api.github.com/users/Peripli/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Peripli/service-manager","description":"Service Manager Core","fork":false,"url":"https://api.github.com/repos/Peripli/service-manager","forks_url":"https://api.github.com/repos/Peripli/service-manager/forks","keys_url":"https://api.github.com/repos/Peripli/service-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Peripli/service-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Peripli/service-manager/teams","hooks_url":"https://api.github.com/repos/Peripli/service-manager/hooks","issue_events_url":"https://api.github.com/repos/Peripli/service-manager/issues/events{/number}","events_url":"https://api.github.com/repos/Peripli/service-manager/events","assignees_url":"https://api.github.com/repos/Peripli/service-manager/assignees{/user}","branches_url":"https://api.github.com/repos/Peripli/service-manager/branches{/branch}","tags_url":"https://api.github.com/repos/Peripli/service-manager/tags","blobs_url":"https://api.github.com/repos/Peripli/service-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Peripli/service-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Peripli/service-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Peripli/service-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Peripli/service-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/Peripli/service-manager/languages","stargazers_url":"https://api.github.com/repos/Peripli/service-manager/stargazers","contributors_url":"https://api.github.com/repos/Peripli/service-manager/contributors","subscribers_url":"https://api.github.com/repos/Peripli/service-manager/subscribers","subscription_url":"https://api.github.com/repos/Peripli/service-manager/subscription","commits_url":"https://api.github.com/repos/Peripli/service-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Peripli/service-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Peripli/service-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Peripli/service-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Peripli/service-manager/contents/{+path}","compare_url":"https://api.github.com/repos/Peripli/service-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Peripli/service-manager/merges","archive_url":"https://api.github.com/repos/Peripli/service-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Peripli/service-manager/downloads","issues_url":"https://api.github.com/repos/Peripli/service-manager/issues{/number}","pulls_url":"https://api.github.com/repos/Peripli/service-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/Peripli/service-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/Peripli/service-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Peripli/service-manager/labels{/name}","releases_url":"https://api.github.com/repos/Peripli/service-manager/releases{/id}","deployments_url":"https://api.github.com/repos/Peripli/service-manager/deployments","created_at":"2018-02-28T19:51:32Z","updated_at":"2018-11-16T09:46:49Z","pushed_at":"2018-11-19T12:53:21Z","git_url":"git://github.com/Peripli/service-manager.git","ssh_url":"git@github.com:Peripli/service-manager.git","clone_url":"https://github.com/Peripli/service-manager.git","svn_url":"https://github.com/Peripli/service-manager","homepage":"","size":976,"stargazers_count":22,"watchers_count":22,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":37,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Peripli/service-manager/pulls/182"},"html":{"href":"https://github.com/Peripli/service-manager/pull/182"},"issue":{"href":"https://api.github.com/repos/Peripli/service-manager/issues/182"},"comments":{"href":"https://api.github.com/repos/Peripli/service-manager/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/Peripli/service-manager/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/Peripli/service-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Peripli/service-manager/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/Peripli/service-manager/statuses/cc858cb18d279f617bae830a6427751a46083471"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"pankrator","id":4245946,"node_id":"MDQ6VXNlcjQyNDU5NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/4245946?v=4","gravatar_id":"","url":"https://api.github.com/users/pankrator","html_url":"https://github.com/pankrator","followers_url":"https://api.github.com/users/pankrator/followers","following_url":"https://api.github.com/users/pankrator/following{/other_user}","gists_url":"https://api.github.com/users/pankrator/gists{/gist_id}","starred_url":"https://api.github.com/users/pankrator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pankrator/subscriptions","organizations_url":"https://api.github.com/users/pankrator/orgs","repos_url":"https://api.github.com/users/pankrator/repos","events_url":"https://api.github.com/users/pankrator/events{/privacy}","received_events_url":"https://api.github.com/users/pankrator/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":75,"deletions":13,"changed_files":4}}
{"actor":{"display_login":"pankrator"}}