{"action":"created","issue":{"url":"https://api.github.com/repos/spacetelescope/poppy/issues/183","repository_url":"https://api.github.com/repos/spacetelescope/poppy","labels_url":"https://api.github.com/repos/spacetelescope/poppy/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/spacetelescope/poppy/issues/183/comments","events_url":"https://api.github.com/repos/spacetelescope/poppy/issues/183/events","html_url":"https://github.com/spacetelescope/poppy/issues/183","id":353584671,"node_id":"MDU6SXNzdWUzNTM1ODQ2NzE=","number":183,"title":"Wavefront class display() method: fix the handling of user-specified vmin, vmax arguments for phase map plot","user":{"login":"mperrin","id":1151745,"node_id":"MDQ6VXNlcjExNTE3NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1151745?v=4","gravatar_id":"","url":"https://api.github.com/users/mperrin","html_url":"https://github.com/mperrin","followers_url":"https://api.github.com/users/mperrin/followers","following_url":"https://api.github.com/users/mperrin/following{/other_user}","gists_url":"https://api.github.com/users/mperrin/gists{/gist_id}","starred_url":"https://api.github.com/users/mperrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperrin/subscriptions","organizations_url":"https://api.github.com/users/mperrin/orgs","repos_url":"https://api.github.com/users/mperrin/repos","events_url":"https://api.github.com/users/mperrin/events{/privacy}","received_events_url":"https://api.github.com/users/mperrin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-23T23:01:16Z","updated_at":"2018-08-23T23:01:17Z","closed_at":null,"author_association":"COLLABORATOR","body":"<a href=\"https://github.com/neilzim\"><img src=\"https://avatars0.githubusercontent.com/u/3797277?v=4\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [neilzim](https://github.com/neilzim)**\n_Thursday Sep 08, 2016 at 19:51 GMT_\n_Originally opened as https://github.com/mperrin/poppy/pull/183_\n\n----\n\nCurrently, when you display a phase map, user-specified vmin and vmax values are ignored. I added a few lines of logic so that when the user provides parameters that are not None, they override the defaults (-0.25, 0.25).\n\n\n----\n\n_**[neilzim](https://github.com/neilzim)** included the following code: https://github.com/mperrin/poppy/pull/183/commits_\n"},"comment":{"url":"https://api.github.com/repos/spacetelescope/poppy/issues/comments/415599020","html_url":"https://github.com/spacetelescope/poppy/issues/183#issuecomment-415599020","issue_url":"https://api.github.com/repos/spacetelescope/poppy/issues/183","id":415599020,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTU5OTAyMA==","user":{"login":"mperrin","id":1151745,"node_id":"MDQ6VXNlcjExNTE3NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1151745?v=4","gravatar_id":"","url":"https://api.github.com/users/mperrin","html_url":"https://github.com/mperrin","followers_url":"https://api.github.com/users/mperrin/followers","following_url":"https://api.github.com/users/mperrin/following{/other_user}","gists_url":"https://api.github.com/users/mperrin/gists{/gist_id}","starred_url":"https://api.github.com/users/mperrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperrin/subscriptions","organizations_url":"https://api.github.com/users/mperrin/orgs","repos_url":"https://api.github.com/users/mperrin/repos","events_url":"https://api.github.com/users/mperrin/events{/privacy}","received_events_url":"https://api.github.com/users/mperrin/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T23:01:17Z","updated_at":"2018-08-23T23:01:17Z","author_association":"COLLABORATOR","body":"<a href=\"https://github.com/mperrin\"><img src=\"https://avatars0.githubusercontent.com/u/1151745?v=4\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [mperrin](https://github.com/mperrin)**\n_Thursday Sep 08, 2016 at 20:30 GMT_\n\n----\n\nI didn't have a chance to look at this before you merged it. A small suggestion would be to add to the docstring for vmin,vmax another sentence as follows:  \"If the scale parameter is set to 'log', then the default vmin for intensity becomes 1e-6*intens.max() instead of 0.\"\n\n"}}
{"actor":{"display_login":"mperrin"}}