{"action":"created","comment":{"url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments/230536574","pull_request_review_id":171306272,"id":230536574,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDUzNjU3NA==","diff_hunk":"@@ -16,9 +16,10 @@ def test_state_boundary(self):\n             'https://www.openstreetmap.org/relation/61320',\n         ], clip=self.tile_bbox(9, 150, 192, padding=2))\n \n+        # NOTE: might not have an ID if it has been merged","path":"integration-test/976-fractional-pois.py","position":4,"original_position":4,"commit_id":"f7bc30bc874689095cebbe42255fea5709bda463","original_commit_id":"f7bc30bc874689095cebbe42255fea5709bda463","user":{"login":"nvkelso","id":853051,"node_id":"MDQ6VXNlcjg1MzA1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/853051?v=4","gravatar_id":"","url":"https://api.github.com/users/nvkelso","html_url":"https://github.com/nvkelso","followers_url":"https://api.github.com/users/nvkelso/followers","following_url":"https://api.github.com/users/nvkelso/following{/other_user}","gists_url":"https://api.github.com/users/nvkelso/gists{/gist_id}","starred_url":"https://api.github.com/users/nvkelso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvkelso/subscriptions","organizations_url":"https://api.github.com/users/nvkelso/orgs","repos_url":"https://api.github.com/users/nvkelso/repos","events_url":"https://api.github.com/users/nvkelso/events{/privacy}","received_events_url":"https://api.github.com/users/nvkelso/received_events","type":"User","site_admin":false},"body":"👍 thanks for adding this note!","created_at":"2018-11-03T00:05:05Z","updated_at":"2018-11-03T00:05:05Z","html_url":"https://github.com/tilezen/vector-datasource/pull/1700#discussion_r230536574","pull_request_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1700","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments/230536574"},"html":{"href":"https://github.com/tilezen/vector-datasource/pull/1700#discussion_r230536574"},"pull_request":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1700"}}},"pull_request":{"url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1700","id":228043243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDQzMjQz","html_url":"https://github.com/tilezen/vector-datasource/pull/1700","diff_url":"https://github.com/tilezen/vector-datasource/pull/1700.diff","patch_url":"https://github.com/tilezen/vector-datasource/pull/1700.patch","issue_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/1700","number":1700,"state":"open","locked":false,"title":"Strip long names from boundaries.","user":{"login":"zerebubuth","id":271360,"node_id":"MDQ6VXNlcjI3MTM2MA==","avatar_url":"https://avatars1.githubusercontent.com/u/271360?v=4","gravatar_id":"","url":"https://api.github.com/users/zerebubuth","html_url":"https://github.com/zerebubuth","followers_url":"https://api.github.com/users/zerebubuth/followers","following_url":"https://api.github.com/users/zerebubuth/following{/other_user}","gists_url":"https://api.github.com/users/zerebubuth/gists{/gist_id}","starred_url":"https://api.github.com/users/zerebubuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zerebubuth/subscriptions","organizations_url":"https://api.github.com/users/zerebubuth/orgs","repos_url":"https://api.github.com/users/zerebubuth/repos","events_url":"https://api.github.com/users/zerebubuth/events{/privacy}","received_events_url":"https://api.github.com/users/zerebubuth/received_events","type":"User","site_admin":false},"body":"This strips names off boundaries between zooms 8 and 10 when they're too long to be reasonably rendered in the tile, based on some assumption about the scale at which we'll be rendering text. This can help remove many names on very short segments of boundary that we'd never have been able to render anyway.\r\n\r\nAdditionally, merges boundary lines. We weren't doing this previously, so would have a few fragmented boundaries which were duplicating properties and inflating feature count.\r\n\r\nSome quick tests show we're reducing GeoJSON boundaries layer size by around 23% on tile `8/134/89` and MVT boundaries layer size by 9% (because MVT is already deduplicating the name values there's less opportunity for us to save.)\r\n\r\nOne observation: Many of the names which are using a lot of bytes are not long in terms of number of rendered characters, but the characters take up more space encoded as UTF-8. It would be interesting to see how many of these we could compress away as transliterations, but that would require client-side support.\r\n\r\nConnects to #1683.\r\n","created_at":"2018-11-02T19:54:56Z","updated_at":"2018-11-03T00:05:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abbced20085f3507ab251cc5213260307923d7db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1700/commits","review_comments_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1700/comments","review_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/1700/comments","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/f7bc30bc874689095cebbe42255fea5709bda463","head":{"label":"tilezen:zerebubuth/1683-strip-names-off-boundary-lines","ref":"zerebubuth/1683-strip-names-off-boundary-lines","sha":"f7bc30bc874689095cebbe42255fea5709bda463","user":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"repo":{"id":13446739,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NjczOQ==","name":"vector-datasource","full_name":"tilezen/vector-datasource","private":false,"owner":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tilezen/vector-datasource","description":"Mapzen vector tile service - OpenStreetMap data in several formats","fork":false,"url":"https://api.github.com/repos/tilezen/vector-datasource","forks_url":"https://api.github.com/repos/tilezen/vector-datasource/forks","keys_url":"https://api.github.com/repos/tilezen/vector-datasource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilezen/vector-datasource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilezen/vector-datasource/teams","hooks_url":"https://api.github.com/repos/tilezen/vector-datasource/hooks","issue_events_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/events{/number}","events_url":"https://api.github.com/repos/tilezen/vector-datasource/events","assignees_url":"https://api.github.com/repos/tilezen/vector-datasource/assignees{/user}","branches_url":"https://api.github.com/repos/tilezen/vector-datasource/branches{/branch}","tags_url":"https://api.github.com/repos/tilezen/vector-datasource/tags","blobs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilezen/vector-datasource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilezen/vector-datasource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/{sha}","languages_url":"https://api.github.com/repos/tilezen/vector-datasource/languages","stargazers_url":"https://api.github.com/repos/tilezen/vector-datasource/stargazers","contributors_url":"https://api.github.com/repos/tilezen/vector-datasource/contributors","subscribers_url":"https://api.github.com/repos/tilezen/vector-datasource/subscribers","subscription_url":"https://api.github.com/repos/tilezen/vector-datasource/subscription","commits_url":"https://api.github.com/repos/tilezen/vector-datasource/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilezen/vector-datasource/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilezen/vector-datasource/contents/{+path}","compare_url":"https://api.github.com/repos/tilezen/vector-datasource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilezen/vector-datasource/merges","archive_url":"https://api.github.com/repos/tilezen/vector-datasource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilezen/vector-datasource/downloads","issues_url":"https://api.github.com/repos/tilezen/vector-datasource/issues{/number}","pulls_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls{/number}","milestones_url":"https://api.github.com/repos/tilezen/vector-datasource/milestones{/number}","notifications_url":"https://api.github.com/repos/tilezen/vector-datasource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilezen/vector-datasource/labels{/name}","releases_url":"https://api.github.com/repos/tilezen/vector-datasource/releases{/id}","deployments_url":"https://api.github.com/repos/tilezen/vector-datasource/deployments","created_at":"2013-10-09T15:54:45Z","updated_at":"2018-11-01T22:55:15Z","pushed_at":"2018-11-02T19:54:57Z","git_url":"git://github.com/tilezen/vector-datasource.git","ssh_url":"git@github.com:tilezen/vector-datasource.git","clone_url":"https://github.com/tilezen/vector-datasource.git","svn_url":"https://github.com/tilezen/vector-datasource","homepage":"https://mapzen.com/projects/vector-tiles/","size":66516,"stargazers_count":356,"watchers_count":356,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":338,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":100,"open_issues":338,"watchers":356,"default_branch":"master"}},"base":{"label":"tilezen:master","ref":"master","sha":"cfcc47f00bfca13f4993fe181e063286729e1532","user":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"repo":{"id":13446739,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NjczOQ==","name":"vector-datasource","full_name":"tilezen/vector-datasource","private":false,"owner":{"login":"tilezen","id":19462720,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDYyNzIw","avatar_url":"https://avatars2.githubusercontent.com/u/19462720?v=4","gravatar_id":"","url":"https://api.github.com/users/tilezen","html_url":"https://github.com/tilezen","followers_url":"https://api.github.com/users/tilezen/followers","following_url":"https://api.github.com/users/tilezen/following{/other_user}","gists_url":"https://api.github.com/users/tilezen/gists{/gist_id}","starred_url":"https://api.github.com/users/tilezen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilezen/subscriptions","organizations_url":"https://api.github.com/users/tilezen/orgs","repos_url":"https://api.github.com/users/tilezen/repos","events_url":"https://api.github.com/users/tilezen/events{/privacy}","received_events_url":"https://api.github.com/users/tilezen/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tilezen/vector-datasource","description":"Mapzen vector tile service - OpenStreetMap data in several formats","fork":false,"url":"https://api.github.com/repos/tilezen/vector-datasource","forks_url":"https://api.github.com/repos/tilezen/vector-datasource/forks","keys_url":"https://api.github.com/repos/tilezen/vector-datasource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilezen/vector-datasource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilezen/vector-datasource/teams","hooks_url":"https://api.github.com/repos/tilezen/vector-datasource/hooks","issue_events_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/events{/number}","events_url":"https://api.github.com/repos/tilezen/vector-datasource/events","assignees_url":"https://api.github.com/repos/tilezen/vector-datasource/assignees{/user}","branches_url":"https://api.github.com/repos/tilezen/vector-datasource/branches{/branch}","tags_url":"https://api.github.com/repos/tilezen/vector-datasource/tags","blobs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilezen/vector-datasource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilezen/vector-datasource/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilezen/vector-datasource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilezen/vector-datasource/statuses/{sha}","languages_url":"https://api.github.com/repos/tilezen/vector-datasource/languages","stargazers_url":"https://api.github.com/repos/tilezen/vector-datasource/stargazers","contributors_url":"https://api.github.com/repos/tilezen/vector-datasource/contributors","subscribers_url":"https://api.github.com/repos/tilezen/vector-datasource/subscribers","subscription_url":"https://api.github.com/repos/tilezen/vector-datasource/subscription","commits_url":"https://api.github.com/repos/tilezen/vector-datasource/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilezen/vector-datasource/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilezen/vector-datasource/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilezen/vector-datasource/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilezen/vector-datasource/contents/{+path}","compare_url":"https://api.github.com/repos/tilezen/vector-datasource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilezen/vector-datasource/merges","archive_url":"https://api.github.com/repos/tilezen/vector-datasource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilezen/vector-datasource/downloads","issues_url":"https://api.github.com/repos/tilezen/vector-datasource/issues{/number}","pulls_url":"https://api.github.com/repos/tilezen/vector-datasource/pulls{/number}","milestones_url":"https://api.github.com/repos/tilezen/vector-datasource/milestones{/number}","notifications_url":"https://api.github.com/repos/tilezen/vector-datasource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilezen/vector-datasource/labels{/name}","releases_url":"https://api.github.com/repos/tilezen/vector-datasource/releases{/id}","deployments_url":"https://api.github.com/repos/tilezen/vector-datasource/deployments","created_at":"2013-10-09T15:54:45Z","updated_at":"2018-11-01T22:55:15Z","pushed_at":"2018-11-02T19:54:57Z","git_url":"git://github.com/tilezen/vector-datasource.git","ssh_url":"git@github.com:tilezen/vector-datasource.git","clone_url":"https://github.com/tilezen/vector-datasource.git","svn_url":"https://github.com/tilezen/vector-datasource","homepage":"https://mapzen.com/projects/vector-tiles/","size":66516,"stargazers_count":356,"watchers_count":356,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":338,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":100,"open_issues":338,"watchers":356,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1700"},"html":{"href":"https://github.com/tilezen/vector-datasource/pull/1700"},"issue":{"href":"https://api.github.com/repos/tilezen/vector-datasource/issues/1700"},"comments":{"href":"https://api.github.com/repos/tilezen/vector-datasource/issues/1700/comments"},"review_comments":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1700/comments"},"review_comment":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tilezen/vector-datasource/pulls/1700/commits"},"statuses":{"href":"https://api.github.com/repos/tilezen/vector-datasource/statuses/f7bc30bc874689095cebbe42255fea5709bda463"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"nvkelso"}}