{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-azure/issues/740","repository_url":"https://api.github.com/repos/openshift/openshift-azure","labels_url":"https://api.github.com/repos/openshift/openshift-azure/issues/740/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-azure/issues/740/comments","events_url":"https://api.github.com/repos/openshift/openshift-azure/issues/740/events","html_url":"https://github.com/openshift/openshift-azure/pull/740","id":381574992,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNTExMTAw","number":740,"title":"geneva logging integration","user":{"login":"mjudeikis","id":3225744,"node_id":"MDQ6VXNlcjMyMjU3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/3225744?v=4","gravatar_id":"","url":"https://api.github.com/users/mjudeikis","html_url":"https://github.com/mjudeikis","followers_url":"https://api.github.com/users/mjudeikis/followers","following_url":"https://api.github.com/users/mjudeikis/following{/other_user}","gists_url":"https://api.github.com/users/mjudeikis/gists{/gist_id}","starred_url":"https://api.github.com/users/mjudeikis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjudeikis/subscriptions","organizations_url":"https://api.github.com/users/mjudeikis/orgs","repos_url":"https://api.github.com/users/mjudeikis/repos","events_url":"https://api.github.com/users/mjudeikis/events{/privacy}","received_events_url":"https://api.github.com/users/mjudeikis/received_events","type":"User","site_admin":false},"labels":[{"id":1006544929,"node_id":"MDU6TGFiZWwxMDA2NTQ0OTI5","url":"https://api.github.com/repos/openshift/openshift-azure/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1006543190,"node_id":"MDU6TGFiZWwxMDA2NTQzMTkw","url":"https://api.github.com/repos/openshift/openshift-azure/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-11-16T12:13:41Z","updated_at":"2018-11-22T22:45:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openshift/openshift-azure/pulls/740","html_url":"https://github.com/openshift/openshift-azure/pull/740","diff_url":"https://github.com/openshift/openshift-azure/pull/740.diff","patch_url":"https://github.com/openshift/openshift-azure/pull/740.patch"},"body":"First draft for logging integration.\r\n\r\nSome considerations taken:\r\n- The secret is data and not `stringData` because its binary cert, and with `stringData` it gets double hashed \r\n- Plugin config is enhanced with subscruct for all azure integration so we could move them around if needed\r\n- Values are persisted in config struct in the appropriate places\r\n\r\nTODO/To confirm:\r\n~~- [ ] vendor in pkcs12 library in separate commit (default does not implement`pkcs12.Encode` and after some research, this came as most mature implementation and closest to native. We can choose to implement this on our code base too.~~\r\n- [x] Agree on configuration structure for the internal model (do we want to have a separate struct as `AzureConfig` in the plugin in close to `Config` one or we add values as they are now)\r\n- [ ] Agree on `ImagePullSecret` format @sozercan ping on this.\r\n- [x] Fix tests (will fix when we agree on structs as they are very dependent) \r\n~~- [ ] Add more tests in TLS~~\r\n- [x] Where do we want to overwrite azure passed values with our default (current end of `generate.go`)\r\n- [x] Cut down RBAC for `geneva` SA. Now its just to make it work. \r\n"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-azure/issues/comments/441130184","html_url":"https://github.com/openshift/openshift-azure/pull/740#issuecomment-441130184","issue_url":"https://api.github.com/repos/openshift/openshift-azure/issues/740","id":441130184,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MTEzMDE4NA==","user":{"login":"jim-minter","id":1038301,"node_id":"MDQ6VXNlcjEwMzgzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"created_at":"2018-11-22T22:45:18Z","updated_at":"2018-11-22T22:45:18Z","author_association":"CONTRIBUTOR","body":"just a few niggles - this is really close."}}
{"actor":{"display_login":"jim-minter"}}