{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls/33","id":207268365,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MjY4MzY1","html_url":"https://github.com/HSLdevcom/hsl-map-generator-server/pull/33","diff_url":"https://github.com/HSLdevcom/hsl-map-generator-server/pull/33.diff","patch_url":"https://github.com/HSLdevcom/hsl-map-generator-server/pull/33.patch","issue_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues/33","number":33,"state":"closed","locked":false,"title":"Fix cors settings.","user":{"login":"danieldunderfelt","id":3145668,"node_id":"MDQ6VXNlcjMxNDU2Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/3145668?v=4","gravatar_id":"","url":"https://api.github.com/users/danieldunderfelt","html_url":"https://github.com/danieldunderfelt","followers_url":"https://api.github.com/users/danieldunderfelt/followers","following_url":"https://api.github.com/users/danieldunderfelt/following{/other_user}","gists_url":"https://api.github.com/users/danieldunderfelt/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldunderfelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldunderfelt/subscriptions","organizations_url":"https://api.github.com/users/danieldunderfelt/orgs","repos_url":"https://api.github.com/users/danieldunderfelt/repos","events_url":"https://api.github.com/users/danieldunderfelt/events{/privacy}","received_events_url":"https://api.github.com/users/danieldunderfelt/received_events","type":"User","site_admin":false},"body":"Fixes cors so that this can be used locally. Is there any risk to having a `*` cors setting in production?","created_at":"2018-08-09T10:21:34Z","updated_at":"2018-11-28T10:55:33Z","closed_at":"2018-11-28T10:55:33Z","merged_at":"2018-11-28T10:55:33Z","merge_commit_sha":"a795127cc17ffa3d044b416770d8eb94c9319084","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kronken","id":5954449,"node_id":"MDQ6VXNlcjU5NTQ0NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/5954449?v=4","gravatar_id":"","url":"https://api.github.com/users/kronken","html_url":"https://github.com/kronken","followers_url":"https://api.github.com/users/kronken/followers","following_url":"https://api.github.com/users/kronken/following{/other_user}","gists_url":"https://api.github.com/users/kronken/gists{/gist_id}","starred_url":"https://api.github.com/users/kronken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kronken/subscriptions","organizations_url":"https://api.github.com/users/kronken/orgs","repos_url":"https://api.github.com/users/kronken/repos","events_url":"https://api.github.com/users/kronken/events{/privacy}","received_events_url":"https://api.github.com/users/kronken/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls/33/commits","review_comments_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls/33/comments","review_comment_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues/33/comments","statuses_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/statuses/b085c0b3557f0d428acbf8963e427812ab020dca","head":{"label":"HSLdevcom:fix-cors-settings","ref":"fix-cors-settings","sha":"b085c0b3557f0d428acbf8963e427812ab020dca","user":{"login":"HSLdevcom","id":2813507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"repo":{"id":67486920,"node_id":"MDEwOlJlcG9zaXRvcnk2NzQ4NjkyMA==","name":"hsl-map-generator-server","full_name":"HSLdevcom/hsl-map-generator-server","private":false,"owner":{"login":"HSLdevcom","id":2813507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HSLdevcom/hsl-map-generator-server","description":null,"fork":false,"url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server","forks_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/forks","keys_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/teams","hooks_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/hooks","issue_events_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues/events{/number}","events_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/events","assignees_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/assignees{/user}","branches_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/branches{/branch}","tags_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/tags","blobs_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/statuses/{sha}","languages_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/languages","stargazers_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/stargazers","contributors_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/contributors","subscribers_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/subscribers","subscription_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/subscription","commits_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/contents/{+path}","compare_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/merges","archive_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/downloads","issues_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues{/number}","pulls_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls{/number}","milestones_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/milestones{/number}","notifications_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/labels{/name}","releases_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/releases{/id}","deployments_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/deployments","created_at":"2016-09-06T08:01:30Z","updated_at":"2018-07-03T07:57:22Z","pushed_at":"2018-11-28T10:55:33Z","git_url":"git://github.com/HSLdevcom/hsl-map-generator-server.git","ssh_url":"git@github.com:HSLdevcom/hsl-map-generator-server.git","clone_url":"https://github.com/HSLdevcom/hsl-map-generator-server.git","svn_url":"https://github.com/HSLdevcom/hsl-map-generator-server","homepage":null,"size":5512,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"HSLdevcom:master","ref":"master","sha":"8de0ec70d897bcd33df4a511a8445c1350cc784c","user":{"login":"HSLdevcom","id":2813507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"repo":{"id":67486920,"node_id":"MDEwOlJlcG9zaXRvcnk2NzQ4NjkyMA==","name":"hsl-map-generator-server","full_name":"HSLdevcom/hsl-map-generator-server","private":false,"owner":{"login":"HSLdevcom","id":2813507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MTM1MDc=","avatar_url":"https://avatars1.githubusercontent.com/u/2813507?v=4","gravatar_id":"","url":"https://api.github.com/users/HSLdevcom","html_url":"https://github.com/HSLdevcom","followers_url":"https://api.github.com/users/HSLdevcom/followers","following_url":"https://api.github.com/users/HSLdevcom/following{/other_user}","gists_url":"https://api.github.com/users/HSLdevcom/gists{/gist_id}","starred_url":"https://api.github.com/users/HSLdevcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HSLdevcom/subscriptions","organizations_url":"https://api.github.com/users/HSLdevcom/orgs","repos_url":"https://api.github.com/users/HSLdevcom/repos","events_url":"https://api.github.com/users/HSLdevcom/events{/privacy}","received_events_url":"https://api.github.com/users/HSLdevcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HSLdevcom/hsl-map-generator-server","description":null,"fork":false,"url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server","forks_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/forks","keys_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/teams","hooks_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/hooks","issue_events_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues/events{/number}","events_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/events","assignees_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/assignees{/user}","branches_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/branches{/branch}","tags_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/tags","blobs_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/statuses/{sha}","languages_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/languages","stargazers_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/stargazers","contributors_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/contributors","subscribers_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/subscribers","subscription_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/subscription","commits_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/contents/{+path}","compare_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/merges","archive_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/downloads","issues_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues{/number}","pulls_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls{/number}","milestones_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/milestones{/number}","notifications_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/labels{/name}","releases_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/releases{/id}","deployments_url":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/deployments","created_at":"2016-09-06T08:01:30Z","updated_at":"2018-07-03T07:57:22Z","pushed_at":"2018-11-28T10:55:33Z","git_url":"git://github.com/HSLdevcom/hsl-map-generator-server.git","ssh_url":"git@github.com:HSLdevcom/hsl-map-generator-server.git","clone_url":"https://github.com/HSLdevcom/hsl-map-generator-server.git","svn_url":"https://github.com/HSLdevcom/hsl-map-generator-server","homepage":null,"size":5512,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls/33"},"html":{"href":"https://github.com/HSLdevcom/hsl-map-generator-server/pull/33"},"issue":{"href":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues/33"},"comments":{"href":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/HSLdevcom/hsl-map-generator-server/statuses/b085c0b3557f0d428acbf8963e427812ab020dca"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danieldunderfelt","id":3145668,"node_id":"MDQ6VXNlcjMxNDU2Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/3145668?v=4","gravatar_id":"","url":"https://api.github.com/users/danieldunderfelt","html_url":"https://github.com/danieldunderfelt","followers_url":"https://api.github.com/users/danieldunderfelt/followers","following_url":"https://api.github.com/users/danieldunderfelt/following{/other_user}","gists_url":"https://api.github.com/users/danieldunderfelt/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldunderfelt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldunderfelt/subscriptions","organizations_url":"https://api.github.com/users/danieldunderfelt/orgs","repos_url":"https://api.github.com/users/danieldunderfelt/repos","events_url":"https://api.github.com/users/danieldunderfelt/events{/privacy}","received_events_url":"https://api.github.com/users/danieldunderfelt/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"danieldunderfelt"}}