{"action":"created","comment":{"url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/comments/204670552","pull_request_review_id":139788199,"id":204670552,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDY3MDU1Mg==","diff_hunk":"@@ -0,0 +1,7 @@\n+CFLAGS := -Ird235_libslirp/include -Ird235_libslirp/src -Iqemu/include -Iqemu/slirp $(CFLAGS)\n+\n+slirp4netns: slirp.o main.o $(subst .c,.o,$(wildcard qemu/slirp/*.c) $(wildcard rd235_libslirp/src/*.c))","path":"Makefile","position":3,"original_position":3,"commit_id":"61f0d52b384a8af1578ebe086d78ea2062daecd4","original_commit_id":"61f0d52b384a8af1578ebe086d78ea2062daecd4","user":{"login":"AkihiroSuda","id":9248427,"node_id":"MDQ6VXNlcjkyNDg0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"body":"could you update readme?","created_at":"2018-07-24T08:42:01Z","updated_at":"2018-07-24T08:42:05Z","html_url":"https://github.com/AkihiroSuda/slirp4netns/pull/1#discussion_r204670552","pull_request_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/comments/204670552"},"html":{"href":"https://github.com/AkihiroSuda/slirp4netns/pull/1#discussion_r204670552"},"pull_request":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/1","id":203326880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzI2ODgw","html_url":"https://github.com/AkihiroSuda/slirp4netns/pull/1","diff_url":"https://github.com/AkihiroSuda/slirp4netns/pull/1.diff","patch_url":"https://github.com/AkihiroSuda/slirp4netns/pull/1.patch","issue_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/issues/1","number":1,"state":"open","locked":false,"title":"slirp: configure the device and the routing","user":{"login":"giuseppe","id":67430,"node_id":"MDQ6VXNlcjY3NDMw","avatar_url":"https://avatars0.githubusercontent.com/u/67430?v=4","gravatar_id":"","url":"https://api.github.com/users/giuseppe","html_url":"https://github.com/giuseppe","followers_url":"https://api.github.com/users/giuseppe/followers","following_url":"https://api.github.com/users/giuseppe/following{/other_user}","gists_url":"https://api.github.com/users/giuseppe/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppe/subscriptions","organizations_url":"https://api.github.com/users/giuseppe/orgs","repos_url":"https://api.github.com/users/giuseppe/repos","events_url":"https://api.github.com/users/giuseppe/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppe/received_events","type":"User","site_admin":false},"body":"as I was working separately on https://github.com/giuseppe/slirp-forwarder to solve the same problem, and ending up with the exact same solution, it is probably worth to join our efforts.  This PR configures the network device (IP, netmask) and sets the routing.\r\n\r\nI've added a Makefile, if you are fine with it I can add all the autoconf/automake stuff.\r\n\r\n","created_at":"2018-07-23T19:59:46Z","updated_at":"2018-07-24T08:42:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b6fdbabb7c9e541fe971cbc93df22d60017a011","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/1/commits","review_comments_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/1/comments","review_comment_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/issues/1/comments","statuses_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/statuses/61f0d52b384a8af1578ebe086d78ea2062daecd4","head":{"label":"giuseppe:improvements","ref":"improvements","sha":"61f0d52b384a8af1578ebe086d78ea2062daecd4","user":{"login":"giuseppe","id":67430,"node_id":"MDQ6VXNlcjY3NDMw","avatar_url":"https://avatars0.githubusercontent.com/u/67430?v=4","gravatar_id":"","url":"https://api.github.com/users/giuseppe","html_url":"https://github.com/giuseppe","followers_url":"https://api.github.com/users/giuseppe/followers","following_url":"https://api.github.com/users/giuseppe/following{/other_user}","gists_url":"https://api.github.com/users/giuseppe/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppe/subscriptions","organizations_url":"https://api.github.com/users/giuseppe/orgs","repos_url":"https://api.github.com/users/giuseppe/repos","events_url":"https://api.github.com/users/giuseppe/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppe/received_events","type":"User","site_admin":false},"repo":{"id":142059926,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwNTk5MjY=","name":"slirp4netns","full_name":"giuseppe/slirp4netns","owner":{"login":"giuseppe","id":67430,"node_id":"MDQ6VXNlcjY3NDMw","avatar_url":"https://avatars0.githubusercontent.com/u/67430?v=4","gravatar_id":"","url":"https://api.github.com/users/giuseppe","html_url":"https://github.com/giuseppe","followers_url":"https://api.github.com/users/giuseppe/followers","following_url":"https://api.github.com/users/giuseppe/following{/other_user}","gists_url":"https://api.github.com/users/giuseppe/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppe/subscriptions","organizations_url":"https://api.github.com/users/giuseppe/orgs","repos_url":"https://api.github.com/users/giuseppe/repos","events_url":"https://api.github.com/users/giuseppe/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/giuseppe/slirp4netns","description":"slirp for network namespaces, without copying buffers across the namespaces","fork":true,"url":"https://api.github.com/repos/giuseppe/slirp4netns","forks_url":"https://api.github.com/repos/giuseppe/slirp4netns/forks","keys_url":"https://api.github.com/repos/giuseppe/slirp4netns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giuseppe/slirp4netns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giuseppe/slirp4netns/teams","hooks_url":"https://api.github.com/repos/giuseppe/slirp4netns/hooks","issue_events_url":"https://api.github.com/repos/giuseppe/slirp4netns/issues/events{/number}","events_url":"https://api.github.com/repos/giuseppe/slirp4netns/events","assignees_url":"https://api.github.com/repos/giuseppe/slirp4netns/assignees{/user}","branches_url":"https://api.github.com/repos/giuseppe/slirp4netns/branches{/branch}","tags_url":"https://api.github.com/repos/giuseppe/slirp4netns/tags","blobs_url":"https://api.github.com/repos/giuseppe/slirp4netns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giuseppe/slirp4netns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giuseppe/slirp4netns/git/refs{/sha}","trees_url":"https://api.github.com/repos/giuseppe/slirp4netns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giuseppe/slirp4netns/statuses/{sha}","languages_url":"https://api.github.com/repos/giuseppe/slirp4netns/languages","stargazers_url":"https://api.github.com/repos/giuseppe/slirp4netns/stargazers","contributors_url":"https://api.github.com/repos/giuseppe/slirp4netns/contributors","subscribers_url":"https://api.github.com/repos/giuseppe/slirp4netns/subscribers","subscription_url":"https://api.github.com/repos/giuseppe/slirp4netns/subscription","commits_url":"https://api.github.com/repos/giuseppe/slirp4netns/commits{/sha}","git_commits_url":"https://api.github.com/repos/giuseppe/slirp4netns/git/commits{/sha}","comments_url":"https://api.github.com/repos/giuseppe/slirp4netns/comments{/number}","issue_comment_url":"https://api.github.com/repos/giuseppe/slirp4netns/issues/comments{/number}","contents_url":"https://api.github.com/repos/giuseppe/slirp4netns/contents/{+path}","compare_url":"https://api.github.com/repos/giuseppe/slirp4netns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giuseppe/slirp4netns/merges","archive_url":"https://api.github.com/repos/giuseppe/slirp4netns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giuseppe/slirp4netns/downloads","issues_url":"https://api.github.com/repos/giuseppe/slirp4netns/issues{/number}","pulls_url":"https://api.github.com/repos/giuseppe/slirp4netns/pulls{/number}","milestones_url":"https://api.github.com/repos/giuseppe/slirp4netns/milestones{/number}","notifications_url":"https://api.github.com/repos/giuseppe/slirp4netns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giuseppe/slirp4netns/labels{/name}","releases_url":"https://api.github.com/repos/giuseppe/slirp4netns/releases{/id}","deployments_url":"https://api.github.com/repos/giuseppe/slirp4netns/deployments","created_at":"2018-07-23T19:29:35Z","updated_at":"2018-07-23T19:29:37Z","pushed_at":"2018-07-24T08:23:30Z","git_url":"git://github.com/giuseppe/slirp4netns.git","ssh_url":"git@github.com:giuseppe/slirp4netns.git","clone_url":"https://github.com/giuseppe/slirp4netns.git","svn_url":"https://github.com/giuseppe/slirp4netns","homepage":null,"size":219,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AkihiroSuda:master","ref":"master","sha":"2dae2def7012a6b95257a0f1696c6e953ce2b242","user":{"login":"AkihiroSuda","id":9248427,"node_id":"MDQ6VXNlcjkyNDg0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"repo":{"id":140418870,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MTg4NzA=","name":"slirp4netns","full_name":"AkihiroSuda/slirp4netns","owner":{"login":"AkihiroSuda","id":9248427,"node_id":"MDQ6VXNlcjkyNDg0Mjc=","avatar_url":"https://avatars2.githubusercontent.com/u/9248427?v=4","gravatar_id":"","url":"https://api.github.com/users/AkihiroSuda","html_url":"https://github.com/AkihiroSuda","followers_url":"https://api.github.com/users/AkihiroSuda/followers","following_url":"https://api.github.com/users/AkihiroSuda/following{/other_user}","gists_url":"https://api.github.com/users/AkihiroSuda/gists{/gist_id}","starred_url":"https://api.github.com/users/AkihiroSuda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AkihiroSuda/subscriptions","organizations_url":"https://api.github.com/users/AkihiroSuda/orgs","repos_url":"https://api.github.com/users/AkihiroSuda/repos","events_url":"https://api.github.com/users/AkihiroSuda/events{/privacy}","received_events_url":"https://api.github.com/users/AkihiroSuda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AkihiroSuda/slirp4netns","description":"slirp for network namespaces, without copying buffers across the namespaces","fork":false,"url":"https://api.github.com/repos/AkihiroSuda/slirp4netns","forks_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/forks","keys_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/teams","hooks_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/hooks","issue_events_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/issues/events{/number}","events_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/events","assignees_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/assignees{/user}","branches_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/branches{/branch}","tags_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/tags","blobs_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/git/refs{/sha}","trees_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/statuses/{sha}","languages_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/languages","stargazers_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/stargazers","contributors_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/contributors","subscribers_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/subscribers","subscription_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/subscription","commits_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/commits{/sha}","git_commits_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/git/commits{/sha}","comments_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/comments{/number}","issue_comment_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/issues/comments{/number}","contents_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/contents/{+path}","compare_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/merges","archive_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/downloads","issues_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/issues{/number}","pulls_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls{/number}","milestones_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/milestones{/number}","notifications_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/labels{/name}","releases_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/releases{/id}","deployments_url":"https://api.github.com/repos/AkihiroSuda/slirp4netns/deployments","created_at":"2018-07-10T10:57:54Z","updated_at":"2018-07-13T06:55:33Z","pushed_at":"2018-07-24T08:23:31Z","git_url":"git://github.com/AkihiroSuda/slirp4netns.git","ssh_url":"git@github.com:AkihiroSuda/slirp4netns.git","clone_url":"https://github.com/AkihiroSuda/slirp4netns.git","svn_url":"https://github.com/AkihiroSuda/slirp4netns","homepage":null,"size":213,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/1"},"html":{"href":"https://github.com/AkihiroSuda/slirp4netns/pull/1"},"issue":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/issues/1"},"comments":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/AkihiroSuda/slirp4netns/statuses/61f0d52b384a8af1578ebe086d78ea2062daecd4"}},"author_association":"NONE"}}
{"actor":{"display_login":"AkihiroSuda"}}