{"action":"created","issue":{"url":"https://api.github.com/repos/rdlowrey/auryn/issues/110","repository_url":"https://api.github.com/repos/rdlowrey/auryn","labels_url":"https://api.github.com/repos/rdlowrey/auryn/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/rdlowrey/auryn/issues/110/comments","events_url":"https://api.github.com/repos/rdlowrey/auryn/issues/110/events","html_url":"https://github.com/rdlowrey/auryn/issues/110","id":96640459,"node_id":"MDU6SXNzdWU5NjY0MDQ1OQ==","number":110,"title":"Detect sharing errors","user":{"login":"Danack","id":1505719,"node_id":"MDQ6VXNlcjE1MDU3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1505719?v=4","gravatar_id":"","url":"https://api.github.com/users/Danack","html_url":"https://github.com/Danack","followers_url":"https://api.github.com/users/Danack/followers","following_url":"https://api.github.com/users/Danack/following{/other_user}","gists_url":"https://api.github.com/users/Danack/gists{/gist_id}","starred_url":"https://api.github.com/users/Danack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danack/subscriptions","organizations_url":"https://api.github.com/users/Danack/orgs","repos_url":"https://api.github.com/users/Danack/repos","events_url":"https://api.github.com/users/Danack/events{/privacy}","received_events_url":"https://api.github.com/users/Danack/received_events","type":"User","site_admin":false},"labels":[{"id":15314834,"node_id":"MDU6TGFiZWwxNTMxNDgzNA==","url":"https://api.github.com/repos/rdlowrey/auryn/labels/feature%20request","name":"feature request","color":"207de5","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2015-07-22T19:00:16Z","updated_at":"2018-12-29T17:10:15Z","closed_at":"2018-12-29T17:10:15Z","author_association":"COLLABORATOR","body":"In a perfect world, the code below would throw an exception.\n\n```\nclass Request {}\n\nclass Bar {\n    function __construct(Request $request) {\n        $this->request = $request;\n    }\n}\n\n$injector = new Auryn\\Injector();\n\n$injector->share(Bar::class);\n$injector->make(Bar::class);\n\n```\n\nBecause the Bar class is shared, but the Request class is not shared, it is highly likely that this is going to be a bug.\n\nI'm guessing this might be difficult to do in a performant way during the actual usage of Auryn. I might investigate having a 'validate' method for the injector that checks the above doesn't happen and there is also no other errors like delegate functions that depend on interfaces, which Auryn doesn't know how to create.\n"},"comment":{"url":"https://api.github.com/repos/rdlowrey/auryn/issues/comments/450506637","html_url":"https://github.com/rdlowrey/auryn/issues/110#issuecomment-450506637","issue_url":"https://api.github.com/repos/rdlowrey/auryn/issues/110","id":450506637,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDUwNjYzNw==","user":{"login":"Danack","id":1505719,"node_id":"MDQ6VXNlcjE1MDU3MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1505719?v=4","gravatar_id":"","url":"https://api.github.com/users/Danack","html_url":"https://github.com/Danack","followers_url":"https://api.github.com/users/Danack/followers","following_url":"https://api.github.com/users/Danack/following{/other_user}","gists_url":"https://api.github.com/users/Danack/gists{/gist_id}","starred_url":"https://api.github.com/users/Danack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Danack/subscriptions","organizations_url":"https://api.github.com/users/Danack/orgs","repos_url":"https://api.github.com/users/Danack/repos","events_url":"https://api.github.com/users/Danack/events{/privacy}","received_events_url":"https://api.github.com/users/Danack/received_events","type":"User","site_admin":false},"created_at":"2018-12-29T17:10:15Z","updated_at":"2018-12-29T17:10:15Z","author_association":"COLLABORATOR","body":"Closing due to inactivity, not being a problem that needs solving in the first place."}}
{"actor":{"display_login":"Danack"}}