{"action":"created","comment":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/178557985","pull_request_review_id":108632229,"id":178557985,"diff_hunk":"@@ -258,7 +270,7 @@ jobs:\n       - LLVM_VERSION: 5.0.1\n       - HOST_LDC_VERSION: 1.6.0\n       - BOOTSTRAP_CMAKE_FLAGS: \"-DCMAKE_CXX_FLAGS='-stdlib=libc++' -DCMAKE_EXE_LINKER_FLAGS=-lc++\"\n-      - EXTRA_CMAKE_FLAGS: \"-DMULTILIB=ON -DCMAKE_CXX_FLAGS='-stdlib=libc++' -DCMAKE_EXE_LINKER_FLAGS=-lc++\"\n+      - EXTRA_CMAKE_FLAGS: \"-DMULTILIB=ON -DBUILD_BC_LIBS=ON -DD_FLAGS='-w;-flto=thin' -DCMAKE_CXX_FLAGS='-stdlib=libc++' -DCMAKE_EXE_LINKER_FLAGS=-lc++\"","path":".circleci/config.yml","position":42,"original_position":42,"commit_id":"52cda053e19401d833eedac99ff4d459086bdaad","original_commit_id":"52cda053e19401d833eedac99ff4d459086bdaad","user":{"login":"JohanEngelen","id":10983051,"avatar_url":"https://avatars1.githubusercontent.com/u/10983051?v=4","gravatar_id":"","url":"https://api.github.com/users/JohanEngelen","html_url":"https://github.com/JohanEngelen","followers_url":"https://api.github.com/users/JohanEngelen/followers","following_url":"https://api.github.com/users/JohanEngelen/following{/other_user}","gists_url":"https://api.github.com/users/JohanEngelen/gists{/gist_id}","starred_url":"https://api.github.com/users/JohanEngelen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohanEngelen/subscriptions","organizations_url":"https://api.github.com/users/JohanEngelen/orgs","repos_url":"https://api.github.com/users/JohanEngelen/repos","events_url":"https://api.github.com/users/JohanEngelen/events{/privacy}","received_events_url":"https://api.github.com/users/JohanEngelen/received_events","type":"User","site_admin":false},"body":"Adding `-flto` to `D_FLAGS` also builds the normal libs with that option, right? But then how do the tests pass: how does linking succeed without specifying the LLVMgold plugin on the linker line for normal tests without LTO ?","created_at":"2018-04-02T14:43:45Z","updated_at":"2018-04-02T14:43:45Z","html_url":"https://github.com/ldc-developers/ldc/pull/2640#discussion_r178557985","pull_request_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/2640","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments/178557985"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/2640#discussion_r178557985"},"pull_request":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/2640"}}},"pull_request":{"url":"https://api.github.com/repos/ldc-developers/ldc/pulls/2640","id":178685975,"html_url":"https://github.com/ldc-developers/ldc/pull/2640","diff_url":"https://github.com/ldc-developers/ldc/pull/2640.diff","patch_url":"https://github.com/ldc-developers/ldc/pull/2640.patch","issue_url":"https://api.github.com/repos/ldc-developers/ldc/issues/2640","number":2640,"state":"open","locked":false,"title":"Ship with LTO default libs on Linux & macOS","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"body":"This allows additional bitcode libs to be generated simultaneously with the normal druntime/Phobos libs (i.e., single compilation) by including something like `-DBUILD_BC_LIBS=ON -DD_FLAGS=\"-w;-flto=thin\"` in the CMake command line (additional D_FLAGS entry here to include the ThinLTO module summaries in the bitcode files; not needed for FullLTO).\r\n\r\nThis then allows linking against the LTO default libs via `ldc2 -flto=<thin|full> ... -defaultlib=phobos2-ldc-bc,druntime-ldc-bc`; unfortunately, I couldn't test this yet, as my LLVM 6 Linux build has a 0-byte LLVMgold.so...","created_at":"2018-03-31T15:00:28Z","updated_at":"2018-04-02T14:43:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"89ef7f0ed10c7c58d0c2484bfb1208357859d632","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/2640/commits","review_comments_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/2640/comments","review_comment_url":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/issues/2640/comments","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/52cda053e19401d833eedac99ff4d459086bdaad","head":{"label":"kinke:ltolibs","ref":"ltolibs","sha":"52cda053e19401d833eedac99ff4d459086bdaad","user":{"login":"kinke","id":1889215,"avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"repo":{"id":7853031,"name":"ldc","full_name":"kinke/ldc","owner":{"login":"kinke","id":1889215,"avatar_url":"https://avatars0.githubusercontent.com/u/1889215?v=4","gravatar_id":"","url":"https://api.github.com/users/kinke","html_url":"https://github.com/kinke","followers_url":"https://api.github.com/users/kinke/followers","following_url":"https://api.github.com/users/kinke/following{/other_user}","gists_url":"https://api.github.com/users/kinke/gists{/gist_id}","starred_url":"https://api.github.com/users/kinke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kinke/subscriptions","organizations_url":"https://api.github.com/users/kinke/orgs","repos_url":"https://api.github.com/users/kinke/repos","events_url":"https://api.github.com/users/kinke/events{/privacy}","received_events_url":"https://api.github.com/users/kinke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kinke/ldc","description":"The LLVM D compiler.","fork":true,"url":"https://api.github.com/repos/kinke/ldc","forks_url":"https://api.github.com/repos/kinke/ldc/forks","keys_url":"https://api.github.com/repos/kinke/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kinke/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kinke/ldc/teams","hooks_url":"https://api.github.com/repos/kinke/ldc/hooks","issue_events_url":"https://api.github.com/repos/kinke/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/kinke/ldc/events","assignees_url":"https://api.github.com/repos/kinke/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/kinke/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/kinke/ldc/tags","blobs_url":"https://api.github.com/repos/kinke/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kinke/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kinke/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/kinke/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kinke/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/kinke/ldc/languages","stargazers_url":"https://api.github.com/repos/kinke/ldc/stargazers","contributors_url":"https://api.github.com/repos/kinke/ldc/contributors","subscribers_url":"https://api.github.com/repos/kinke/ldc/subscribers","subscription_url":"https://api.github.com/repos/kinke/ldc/subscription","commits_url":"https://api.github.com/repos/kinke/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/kinke/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/kinke/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/kinke/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/kinke/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/kinke/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kinke/ldc/merges","archive_url":"https://api.github.com/repos/kinke/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kinke/ldc/downloads","issues_url":"https://api.github.com/repos/kinke/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/kinke/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/kinke/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/kinke/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kinke/ldc/labels{/name}","releases_url":"https://api.github.com/repos/kinke/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/kinke/ldc/deployments","created_at":"2013-01-27T14:20:48Z","updated_at":"2017-08-24T19:46:50Z","pushed_at":"2018-04-02T00:29:40Z","git_url":"git://github.com/kinke/ldc.git","ssh_url":"git@github.com:kinke/ldc.git","clone_url":"https://github.com/kinke/ldc.git","svn_url":"https://github.com/kinke/ldc","homepage":"http://wiki.dlang.org/LDC","size":28771,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"win64"}},"base":{"label":"ldc-developers:master","ref":"master","sha":"f82d6fe953554faeefdca2aaa926b214395628c3","user":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars2.githubusercontent.com/u/960112?v=4","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":2174666,"name":"ldc","full_name":"ldc-developers/ldc","owner":{"login":"ldc-developers","id":960112,"avatar_url":"https://avatars2.githubusercontent.com/u/960112?v=4","gravatar_id":"","url":"https://api.github.com/users/ldc-developers","html_url":"https://github.com/ldc-developers","followers_url":"https://api.github.com/users/ldc-developers/followers","following_url":"https://api.github.com/users/ldc-developers/following{/other_user}","gists_url":"https://api.github.com/users/ldc-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/ldc-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldc-developers/subscriptions","organizations_url":"https://api.github.com/users/ldc-developers/orgs","repos_url":"https://api.github.com/users/ldc-developers/repos","events_url":"https://api.github.com/users/ldc-developers/events{/privacy}","received_events_url":"https://api.github.com/users/ldc-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ldc-developers/ldc","description":"The LLVM-based D Compiler.","fork":false,"url":"https://api.github.com/repos/ldc-developers/ldc","forks_url":"https://api.github.com/repos/ldc-developers/ldc/forks","keys_url":"https://api.github.com/repos/ldc-developers/ldc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldc-developers/ldc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldc-developers/ldc/teams","hooks_url":"https://api.github.com/repos/ldc-developers/ldc/hooks","issue_events_url":"https://api.github.com/repos/ldc-developers/ldc/issues/events{/number}","events_url":"https://api.github.com/repos/ldc-developers/ldc/events","assignees_url":"https://api.github.com/repos/ldc-developers/ldc/assignees{/user}","branches_url":"https://api.github.com/repos/ldc-developers/ldc/branches{/branch}","tags_url":"https://api.github.com/repos/ldc-developers/ldc/tags","blobs_url":"https://api.github.com/repos/ldc-developers/ldc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldc-developers/ldc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldc-developers/ldc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldc-developers/ldc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldc-developers/ldc/statuses/{sha}","languages_url":"https://api.github.com/repos/ldc-developers/ldc/languages","stargazers_url":"https://api.github.com/repos/ldc-developers/ldc/stargazers","contributors_url":"https://api.github.com/repos/ldc-developers/ldc/contributors","subscribers_url":"https://api.github.com/repos/ldc-developers/ldc/subscribers","subscription_url":"https://api.github.com/repos/ldc-developers/ldc/subscription","commits_url":"https://api.github.com/repos/ldc-developers/ldc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldc-developers/ldc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldc-developers/ldc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldc-developers/ldc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldc-developers/ldc/contents/{+path}","compare_url":"https://api.github.com/repos/ldc-developers/ldc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldc-developers/ldc/merges","archive_url":"https://api.github.com/repos/ldc-developers/ldc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldc-developers/ldc/downloads","issues_url":"https://api.github.com/repos/ldc-developers/ldc/issues{/number}","pulls_url":"https://api.github.com/repos/ldc-developers/ldc/pulls{/number}","milestones_url":"https://api.github.com/repos/ldc-developers/ldc/milestones{/number}","notifications_url":"https://api.github.com/repos/ldc-developers/ldc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldc-developers/ldc/labels{/name}","releases_url":"https://api.github.com/repos/ldc-developers/ldc/releases{/id}","deployments_url":"https://api.github.com/repos/ldc-developers/ldc/deployments","created_at":"2011-08-08T17:10:27Z","updated_at":"2018-04-01T13:52:16Z","pushed_at":"2018-04-02T00:29:41Z","git_url":"git://github.com/ldc-developers/ldc.git","ssh_url":"git@github.com:ldc-developers/ldc.git","clone_url":"https://github.com/ldc-developers/ldc.git","svn_url":"https://github.com/ldc-developers/ldc","homepage":"http://wiki.dlang.org/LDC","size":29052,"stargazers_count":678,"watchers_count":678,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":279,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":145,"open_issues":279,"watchers":678,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/2640"},"html":{"href":"https://github.com/ldc-developers/ldc/pull/2640"},"issue":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/2640"},"comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/issues/2640/comments"},"review_comments":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/2640/comments"},"review_comment":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ldc-developers/ldc/pulls/2640/commits"},"statuses":{"href":"https://api.github.com/repos/ldc-developers/ldc/statuses/52cda053e19401d833eedac99ff4d459086bdaad"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"JohanEngelen"}}