{"action":"created","comment":{"url":"https://api.github.com/repos/exonum/exonum/pulls/comments/193101412","pull_request_review_id":125985736,"id":193101412,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzEwMTQxMg==","diff_hunk":"@@ -59,6 +59,8 @@ pub struct StoredConfiguration {\n     /// configuration will not take effect at all; the old configuration will\n     /// remain actual.\n     pub actual_from: Height,\n+    /// Core storage version.\n+    pub storage_version: u64,","path":"exonum/src/blockchain/config.rs","position":14,"original_position":14,"commit_id":"6e6915e73e04fc58e93d0a5cb8a0fe59dd9c927b","original_commit_id":"6e6915e73e04fc58e93d0a5cb8a0fe59dd9c927b","user":{"login":"DarkEld3r","id":2997902,"node_id":"MDQ6VXNlcjI5OTc5MDI=","avatar_url":"https://avatars1.githubusercontent.com/u/2997902?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkEld3r","html_url":"https://github.com/DarkEld3r","followers_url":"https://api.github.com/users/DarkEld3r/followers","following_url":"https://api.github.com/users/DarkEld3r/following{/other_user}","gists_url":"https://api.github.com/users/DarkEld3r/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkEld3r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkEld3r/subscriptions","organizations_url":"https://api.github.com/users/DarkEld3r/orgs","repos_url":"https://api.github.com/users/DarkEld3r/repos","events_url":"https://api.github.com/users/DarkEld3r/events{/privacy}","received_events_url":"https://api.github.com/users/DarkEld3r/received_events","type":"User","site_admin":false},"body":"I propose to remove version from the configuration: it looks like some rudiment, because storage version is our implementation detail and user probably should not be able to choose it.","created_at":"2018-06-05T14:47:59Z","updated_at":"2018-06-05T14:55:37Z","html_url":"https://github.com/exonum/exonum/pull/707#discussion_r193101412","pull_request_url":"https://api.github.com/repos/exonum/exonum/pulls/707","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum/pulls/comments/193101412"},"html":{"href":"https://github.com/exonum/exonum/pull/707#discussion_r193101412"},"pull_request":{"href":"https://api.github.com/repos/exonum/exonum/pulls/707"}}},"pull_request":{"url":"https://api.github.com/repos/exonum/exonum/pulls/707","id":191115374,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMTE1Mzc0","html_url":"https://github.com/exonum/exonum/pull/707","diff_url":"https://github.com/exonum/exonum/pull/707.diff","patch_url":"https://github.com/exonum/exonum/pull/707.patch","issue_url":"https://api.github.com/repos/exonum/exonum/issues/707","number":707,"state":"open","locked":false,"title":"Core Storage Versioning [ECR-1423]","user":{"login":"andreyluchin","id":9142036,"node_id":"MDQ6VXNlcjkxNDIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/9142036?v=4","gravatar_id":"","url":"https://api.github.com/users/andreyluchin","html_url":"https://github.com/andreyluchin","followers_url":"https://api.github.com/users/andreyluchin/followers","following_url":"https://api.github.com/users/andreyluchin/following{/other_user}","gists_url":"https://api.github.com/users/andreyluchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreyluchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreyluchin/subscriptions","organizations_url":"https://api.github.com/users/andreyluchin/orgs","repos_url":"https://api.github.com/users/andreyluchin/repos","events_url":"https://api.github.com/users/andreyluchin/events{/privacy}","received_events_url":"https://api.github.com/users/andreyluchin/received_events","type":"User","site_admin":false},"body":"This PR introduces basic Storage Versioning for core.\r\n\r\nThe version value is hardcoded in `storage::indexes_metadata::CORE_STORAGE_VERSION`.\r\nIt is stored in metadata index. This version is checked for existing databases, causes node to panic if invalid. If there is no existing database (first launch) the version is set automatically. This value is going to be changed manually upon the introduction of breaking changes on core's part.\r\n\r\nA new dev-dependency is introduced: `assert_matches`. We already use this crate in configuration service and it seems reliable + it is a dev-dependency.\r\n\r\n### Todo\r\n- [x] ~~Make `Version` a dedicated type.~~ Combine `Version` functions and `VersionStatus` class. \r\n- [x] Create `storage_version` field in the configuration.\r\n- [x] ~~Create `set-storage-version` command.~~","created_at":"2018-05-29T11:32:14Z","updated_at":"2018-06-05T14:55:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"164445e4dd859aa6be87f5fcd2fb55cd2607ee2e","assignee":{"login":"andreyluchin","id":9142036,"node_id":"MDQ6VXNlcjkxNDIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/9142036?v=4","gravatar_id":"","url":"https://api.github.com/users/andreyluchin","html_url":"https://github.com/andreyluchin","followers_url":"https://api.github.com/users/andreyluchin/followers","following_url":"https://api.github.com/users/andreyluchin/following{/other_user}","gists_url":"https://api.github.com/users/andreyluchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreyluchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreyluchin/subscriptions","organizations_url":"https://api.github.com/users/andreyluchin/orgs","repos_url":"https://api.github.com/users/andreyluchin/repos","events_url":"https://api.github.com/users/andreyluchin/events{/privacy}","received_events_url":"https://api.github.com/users/andreyluchin/received_events","type":"User","site_admin":false},"assignees":[{"login":"andreyluchin","id":9142036,"node_id":"MDQ6VXNlcjkxNDIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/9142036?v=4","gravatar_id":"","url":"https://api.github.com/users/andreyluchin","html_url":"https://github.com/andreyluchin","followers_url":"https://api.github.com/users/andreyluchin/followers","following_url":"https://api.github.com/users/andreyluchin/following{/other_user}","gists_url":"https://api.github.com/users/andreyluchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreyluchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreyluchin/subscriptions","organizations_url":"https://api.github.com/users/andreyluchin/orgs","repos_url":"https://api.github.com/users/andreyluchin/repos","events_url":"https://api.github.com/users/andreyluchin/events{/privacy}","received_events_url":"https://api.github.com/users/andreyluchin/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"vitvakatu","id":6566674,"node_id":"MDQ6VXNlcjY1NjY2NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6566674?v=4","gravatar_id":"","url":"https://api.github.com/users/vitvakatu","html_url":"https://github.com/vitvakatu","followers_url":"https://api.github.com/users/vitvakatu/followers","following_url":"https://api.github.com/users/vitvakatu/following{/other_user}","gists_url":"https://api.github.com/users/vitvakatu/gists{/gist_id}","starred_url":"https://api.github.com/users/vitvakatu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vitvakatu/subscriptions","organizations_url":"https://api.github.com/users/vitvakatu/orgs","repos_url":"https://api.github.com/users/vitvakatu/repos","events_url":"https://api.github.com/users/vitvakatu/events{/privacy}","received_events_url":"https://api.github.com/users/vitvakatu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":608685912,"node_id":"MDU6TGFiZWw2MDg2ODU5MTI=","url":"https://api.github.com/repos/exonum/exonum/labels/breaking%20change%20:warning:","name":"breaking change :warning:","color":"d93f0b","default":false},{"id":591367998,"node_id":"MDU6TGFiZWw1OTEzNjc5OTg=","url":"https://api.github.com/repos/exonum/exonum/labels/discussion%20:speech_balloon:","name":"discussion :speech_balloon:","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/exonum/exonum/pulls/707/commits","review_comments_url":"https://api.github.com/repos/exonum/exonum/pulls/707/comments","review_comment_url":"https://api.github.com/repos/exonum/exonum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/exonum/exonum/issues/707/comments","statuses_url":"https://api.github.com/repos/exonum/exonum/statuses/6e6915e73e04fc58e93d0a5cb8a0fe59dd9c927b","head":{"label":"andreyluchin:storage-versioning","ref":"storage-versioning","sha":"6e6915e73e04fc58e93d0a5cb8a0fe59dd9c927b","user":{"login":"andreyluchin","id":9142036,"node_id":"MDQ6VXNlcjkxNDIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/9142036?v=4","gravatar_id":"","url":"https://api.github.com/users/andreyluchin","html_url":"https://github.com/andreyluchin","followers_url":"https://api.github.com/users/andreyluchin/followers","following_url":"https://api.github.com/users/andreyluchin/following{/other_user}","gists_url":"https://api.github.com/users/andreyluchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreyluchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreyluchin/subscriptions","organizations_url":"https://api.github.com/users/andreyluchin/orgs","repos_url":"https://api.github.com/users/andreyluchin/repos","events_url":"https://api.github.com/users/andreyluchin/events{/privacy}","received_events_url":"https://api.github.com/users/andreyluchin/received_events","type":"User","site_admin":false},"repo":{"id":126792146,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY3OTIxNDY=","name":"exonum","full_name":"andreyluchin/exonum","owner":{"login":"andreyluchin","id":9142036,"node_id":"MDQ6VXNlcjkxNDIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/9142036?v=4","gravatar_id":"","url":"https://api.github.com/users/andreyluchin","html_url":"https://github.com/andreyluchin","followers_url":"https://api.github.com/users/andreyluchin/followers","following_url":"https://api.github.com/users/andreyluchin/following{/other_user}","gists_url":"https://api.github.com/users/andreyluchin/gists{/gist_id}","starred_url":"https://api.github.com/users/andreyluchin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreyluchin/subscriptions","organizations_url":"https://api.github.com/users/andreyluchin/orgs","repos_url":"https://api.github.com/users/andreyluchin/repos","events_url":"https://api.github.com/users/andreyluchin/events{/privacy}","received_events_url":"https://api.github.com/users/andreyluchin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreyluchin/exonum","description":"Exonum core repository","fork":true,"url":"https://api.github.com/repos/andreyluchin/exonum","forks_url":"https://api.github.com/repos/andreyluchin/exonum/forks","keys_url":"https://api.github.com/repos/andreyluchin/exonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreyluchin/exonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreyluchin/exonum/teams","hooks_url":"https://api.github.com/repos/andreyluchin/exonum/hooks","issue_events_url":"https://api.github.com/repos/andreyluchin/exonum/issues/events{/number}","events_url":"https://api.github.com/repos/andreyluchin/exonum/events","assignees_url":"https://api.github.com/repos/andreyluchin/exonum/assignees{/user}","branches_url":"https://api.github.com/repos/andreyluchin/exonum/branches{/branch}","tags_url":"https://api.github.com/repos/andreyluchin/exonum/tags","blobs_url":"https://api.github.com/repos/andreyluchin/exonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreyluchin/exonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreyluchin/exonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreyluchin/exonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreyluchin/exonum/statuses/{sha}","languages_url":"https://api.github.com/repos/andreyluchin/exonum/languages","stargazers_url":"https://api.github.com/repos/andreyluchin/exonum/stargazers","contributors_url":"https://api.github.com/repos/andreyluchin/exonum/contributors","subscribers_url":"https://api.github.com/repos/andreyluchin/exonum/subscribers","subscription_url":"https://api.github.com/repos/andreyluchin/exonum/subscription","commits_url":"https://api.github.com/repos/andreyluchin/exonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreyluchin/exonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreyluchin/exonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreyluchin/exonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreyluchin/exonum/contents/{+path}","compare_url":"https://api.github.com/repos/andreyluchin/exonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreyluchin/exonum/merges","archive_url":"https://api.github.com/repos/andreyluchin/exonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreyluchin/exonum/downloads","issues_url":"https://api.github.com/repos/andreyluchin/exonum/issues{/number}","pulls_url":"https://api.github.com/repos/andreyluchin/exonum/pulls{/number}","milestones_url":"https://api.github.com/repos/andreyluchin/exonum/milestones{/number}","notifications_url":"https://api.github.com/repos/andreyluchin/exonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreyluchin/exonum/labels{/name}","releases_url":"https://api.github.com/repos/andreyluchin/exonum/releases{/id}","deployments_url":"https://api.github.com/repos/andreyluchin/exonum/deployments","created_at":"2018-03-26T07:43:25Z","updated_at":"2018-06-05T14:25:29Z","pushed_at":"2018-06-05T14:25:27Z","git_url":"git://github.com/andreyluchin/exonum.git","ssh_url":"git@github.com:andreyluchin/exonum.git","clone_url":"https://github.com/andreyluchin/exonum.git","svn_url":"https://github.com/andreyluchin/exonum","homepage":"http://exonum.com","size":23648,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"exonum:master","ref":"master","sha":"9f29d5481388fdbdc4cd8177f5c677a7f54752eb","user":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"repo":{"id":80729805,"node_id":"MDEwOlJlcG9zaXRvcnk4MDcyOTgwNQ==","name":"exonum","full_name":"exonum/exonum","owner":{"login":"exonum","id":23138442,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTM4NDQy","avatar_url":"https://avatars1.githubusercontent.com/u/23138442?v=4","gravatar_id":"","url":"https://api.github.com/users/exonum","html_url":"https://github.com/exonum","followers_url":"https://api.github.com/users/exonum/followers","following_url":"https://api.github.com/users/exonum/following{/other_user}","gists_url":"https://api.github.com/users/exonum/gists{/gist_id}","starred_url":"https://api.github.com/users/exonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/exonum/subscriptions","organizations_url":"https://api.github.com/users/exonum/orgs","repos_url":"https://api.github.com/users/exonum/repos","events_url":"https://api.github.com/users/exonum/events{/privacy}","received_events_url":"https://api.github.com/users/exonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/exonum/exonum","description":"Exonum core repository","fork":false,"url":"https://api.github.com/repos/exonum/exonum","forks_url":"https://api.github.com/repos/exonum/exonum/forks","keys_url":"https://api.github.com/repos/exonum/exonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/exonum/exonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/exonum/exonum/teams","hooks_url":"https://api.github.com/repos/exonum/exonum/hooks","issue_events_url":"https://api.github.com/repos/exonum/exonum/issues/events{/number}","events_url":"https://api.github.com/repos/exonum/exonum/events","assignees_url":"https://api.github.com/repos/exonum/exonum/assignees{/user}","branches_url":"https://api.github.com/repos/exonum/exonum/branches{/branch}","tags_url":"https://api.github.com/repos/exonum/exonum/tags","blobs_url":"https://api.github.com/repos/exonum/exonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/exonum/exonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/exonum/exonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/exonum/exonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/exonum/exonum/statuses/{sha}","languages_url":"https://api.github.com/repos/exonum/exonum/languages","stargazers_url":"https://api.github.com/repos/exonum/exonum/stargazers","contributors_url":"https://api.github.com/repos/exonum/exonum/contributors","subscribers_url":"https://api.github.com/repos/exonum/exonum/subscribers","subscription_url":"https://api.github.com/repos/exonum/exonum/subscription","commits_url":"https://api.github.com/repos/exonum/exonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/exonum/exonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/exonum/exonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/exonum/exonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/exonum/exonum/contents/{+path}","compare_url":"https://api.github.com/repos/exonum/exonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/exonum/exonum/merges","archive_url":"https://api.github.com/repos/exonum/exonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/exonum/exonum/downloads","issues_url":"https://api.github.com/repos/exonum/exonum/issues{/number}","pulls_url":"https://api.github.com/repos/exonum/exonum/pulls{/number}","milestones_url":"https://api.github.com/repos/exonum/exonum/milestones{/number}","notifications_url":"https://api.github.com/repos/exonum/exonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/exonum/exonum/labels{/name}","releases_url":"https://api.github.com/repos/exonum/exonum/releases{/id}","deployments_url":"https://api.github.com/repos/exonum/exonum/deployments","created_at":"2017-02-02T13:56:57Z","updated_at":"2018-06-05T09:02:39Z","pushed_at":"2018-06-05T14:35:37Z","git_url":"git://github.com/exonum/exonum.git","ssh_url":"git@github.com:exonum/exonum.git","clone_url":"https://github.com/exonum/exonum.git","svn_url":"https://github.com/exonum/exonum","homepage":"http://exonum.com","size":23655,"stargazers_count":605,"watchers_count":605,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":112,"open_issues":66,"watchers":605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/exonum/exonum/pulls/707"},"html":{"href":"https://github.com/exonum/exonum/pull/707"},"issue":{"href":"https://api.github.com/repos/exonum/exonum/issues/707"},"comments":{"href":"https://api.github.com/repos/exonum/exonum/issues/707/comments"},"review_comments":{"href":"https://api.github.com/repos/exonum/exonum/pulls/707/comments"},"review_comment":{"href":"https://api.github.com/repos/exonum/exonum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/exonum/exonum/pulls/707/commits"},"statuses":{"href":"https://api.github.com/repos/exonum/exonum/statuses/6e6915e73e04fc58e93d0a5cb8a0fe59dd9c927b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DarkEld3r"}}