{"action":"created","issue":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10164","repository_url":"https://api.github.com/repos/civicrm/civicrm-core","labels_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10164/labels{/name}","comments_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10164/comments","events_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10164/events","html_url":"https://github.com/civicrm/civicrm-core/pull/10164","id":221807209,"number":10164,"title":"CRM-20430 save report criteria","user":{"login":"johanv","id":586145,"avatar_url":"https://avatars2.githubusercontent.com/u/586145?v=4","gravatar_id":"","url":"https://api.github.com/users/johanv","html_url":"https://github.com/johanv","followers_url":"https://api.github.com/users/johanv/followers","following_url":"https://api.github.com/users/johanv/following{/other_user}","gists_url":"https://api.github.com/users/johanv/gists{/gist_id}","starred_url":"https://api.github.com/users/johanv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johanv/subscriptions","organizations_url":"https://api.github.com/users/johanv/orgs","repos_url":"https://api.github.com/users/johanv/repos","events_url":"https://api.github.com/users/johanv/events{/privacy}","received_events_url":"https://api.github.com/users/johanv/received_events","type":"User","site_admin":false},"labels":[{"id":246037889,"url":"https://api.github.com/repos/civicrm/civicrm-core/labels/master","name":"master","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"seamuslee001","id":6799125,"avatar_url":"https://avatars2.githubusercontent.com/u/6799125?v=4","gravatar_id":"","url":"https://api.github.com/users/seamuslee001","html_url":"https://github.com/seamuslee001","followers_url":"https://api.github.com/users/seamuslee001/followers","following_url":"https://api.github.com/users/seamuslee001/following{/other_user}","gists_url":"https://api.github.com/users/seamuslee001/gists{/gist_id}","starred_url":"https://api.github.com/users/seamuslee001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seamuslee001/subscriptions","organizations_url":"https://api.github.com/users/seamuslee001/orgs","repos_url":"https://api.github.com/users/seamuslee001/repos","events_url":"https://api.github.com/users/seamuslee001/events{/privacy}","received_events_url":"https://api.github.com/users/seamuslee001/received_events","type":"User","site_admin":false},"assignees":[{"login":"seamuslee001","id":6799125,"avatar_url":"https://avatars2.githubusercontent.com/u/6799125?v=4","gravatar_id":"","url":"https://api.github.com/users/seamuslee001","html_url":"https://github.com/seamuslee001","followers_url":"https://api.github.com/users/seamuslee001/followers","following_url":"https://api.github.com/users/seamuslee001/following{/other_user}","gists_url":"https://api.github.com/users/seamuslee001/gists{/gist_id}","starred_url":"https://api.github.com/users/seamuslee001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seamuslee001/subscriptions","organizations_url":"https://api.github.com/users/seamuslee001/orgs","repos_url":"https://api.github.com/users/seamuslee001/repos","events_url":"https://api.github.com/users/seamuslee001/events{/privacy}","received_events_url":"https://api.github.com/users/seamuslee001/received_events","type":"User","site_admin":false}],"milestone":null,"comments":11,"created_at":"2017-04-14T13:15:39Z","updated_at":"2018-03-22T23:09:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/civicrm/civicrm-core/pulls/10164","html_url":"https://github.com/civicrm/civicrm-core/pull/10164","diff_url":"https://github.com/civicrm/civicrm-core/pull/10164.diff","patch_url":"https://github.com/civicrm/civicrm-core/pull/10164.patch"},"body":"This PR introduces a new permission for CiviReport: 'save Report Criteria'.\r\n(see also CRM-20430).\n\n---\n\n * [CRM-20430: A permission 'save Report Criteria'](https://issues.civicrm.org/jira/browse/CRM-20430)"},"comment":{"url":"https://api.github.com/repos/civicrm/civicrm-core/issues/comments/375487061","html_url":"https://github.com/civicrm/civicrm-core/pull/10164#issuecomment-375487061","issue_url":"https://api.github.com/repos/civicrm/civicrm-core/issues/10164","id":375487061,"user":{"login":"eileenmcnaughton","id":336308,"avatar_url":"https://avatars2.githubusercontent.com/u/336308?v=4","gravatar_id":"","url":"https://api.github.com/users/eileenmcnaughton","html_url":"https://github.com/eileenmcnaughton","followers_url":"https://api.github.com/users/eileenmcnaughton/followers","following_url":"https://api.github.com/users/eileenmcnaughton/following{/other_user}","gists_url":"https://api.github.com/users/eileenmcnaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/eileenmcnaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileenmcnaughton/subscriptions","organizations_url":"https://api.github.com/users/eileenmcnaughton/orgs","repos_url":"https://api.github.com/users/eileenmcnaughton/repos","events_url":"https://api.github.com/users/eileenmcnaughton/events{/privacy}","received_events_url":"https://api.github.com/users/eileenmcnaughton/received_events","type":"User","site_admin":false},"created_at":"2018-03-22T23:09:28Z","updated_at":"2018-03-22T23:09:28Z","author_association":"CONTRIBUTOR","body":"Ohh the test fail is actually related. I think the issue is that the permission check needs to be \r\n\r\nif (!$params['check_permissions'] || !CRM_Core_Permission::check('save Report Criteria')) {\r\n\r\nand we need to pass through that parameter from calling functions. "}}
{"actor":{"display_login":"eileenmcnaughton"}}