{"action":"created","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2688","repository_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2688/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2688/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2688/events","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2688","id":391778479,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5MTk2MzQ2","number":2688,"title":"Add k8s and CF TaskLaunchers into a single server implementation","user":{"login":"markpollack","id":247466,"node_id":"MDQ6VXNlcjI0NzQ2Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/247466?v=4","gravatar_id":"","url":"https://api.github.com/users/markpollack","html_url":"https://github.com/markpollack","followers_url":"https://api.github.com/users/markpollack/followers","following_url":"https://api.github.com/users/markpollack/following{/other_user}","gists_url":"https://api.github.com/users/markpollack/gists{/gist_id}","starred_url":"https://api.github.com/users/markpollack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markpollack/subscriptions","organizations_url":"https://api.github.com/users/markpollack/orgs","repos_url":"https://api.github.com/users/markpollack/repos","events_url":"https://api.github.com/users/markpollack/events{/privacy}","received_events_url":"https://api.github.com/users/markpollack/received_events","type":"User","site_admin":false},"labels":[{"id":286486351,"node_id":"MDU6TGFiZWwyODY0ODYzNTE=","url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels/in%20pr","name":"in pr","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"ilayaperumalg","id":151690,"node_id":"MDQ6VXNlcjE1MTY5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/151690?v=4","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"assignees":[{"login":"ilayaperumalg","id":151690,"node_id":"MDQ6VXNlcjE1MTY5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/151690?v=4","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-12-17T16:01:36Z","updated_at":"2018-12-19T04:14:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/2688","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2688","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2688.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2688.patch"},"body":"- Incorporated changes from first PR review and rebased to master\r\n\r\n- Renamed spring-cloud-dataflow-server-local to spring-cloud-dataflow-server\r\n- Two new maven modules that define platform releated Beans\r\n- Default version of local task deployer is created only if no other task deployers defined\r\n- Add k8s yml files from scdf-server-kubernetes repo\r\n\r\nNote\r\n\r\n- **TaskExecutionControllerTests is failing from the maven build** - not in IDE, don't know why, looks like something isn't cleaned up in JobInstanceControllerTests, JobExecutionControllerTests, or JobStepExecutionControllerTests.\r\n- Used a 'local' profile logback-scdf-local.xml to avoid local file logging on cloud platforms\r\n\r\nLimitations\r\n\r\n- Can only configure a single deployer per platform and it needs to be named 'default'\r\n\r\nTested on CF using the following manifest, did not test on K8s.  I believe one can't use the format\r\n\r\nto specify the accounts, to used SPRING_APPLICATION_JSON\r\n\r\n```\r\napplications:\r\n- name: mlp-dataflow-server\r\n  memory: 1G\r\n  disk_quota: 2G\r\n  buildpack: java_buildpack_offline\r\n  timeout: 180\r\n  path: ./spring-cloud-dataflow-server-2.0.0.BUILD-SNAPSHOT.jar\r\n  services:\r\n    - mysql\r\n  env:\r\n    SPRING_APPLICATION_NAME: data-flow-server\r\n    SPRING_APPLICATION_JSON: '{ \"maven\": { \"remote-repositories\": { \"repo1\": { \"url\": \"https://repo.spring.io/libs-snapshot\" } } }, \"spring\": { \"cloud\": { \"dataflow\": { \"task\": { \"platform\": { \"cloudfoundry\": { \"accounts\": { \"default\": { \"connection\": { \"url\": \"https://api.sys.huron.cf-app.com\", \"org\": \"mpollack\", \"space\": \"test\", \"domain\": \"app.huron.cf-app.com\", \"username\": \"***\", \"password\": \"****\", \"skipSslValidation\": true }, \"deployment\": { \"memory\": \"2048m\", \"disk\": \"2048m\", \"services\": \"mysql\", \"deleteRoutes\": false } } } } } } } } } }'\r\n    SPRING_CLOUD_DEPLOYER_CLOUDFOUNDRY_TASK_API_TIMEOUT: 300\r\n    SPRING_CLOUD_DEPLOYER_CLOUDFOUNDRY_TASK_SERVICES: mysql\r\n    TRUST_CERTS: api.sys.huron.cf-app.com\r\n    SPRING_CLOUD_SKIPPER_CLIENT_SERVER_URI: http://localhost:7577/api\r\n    SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_STREAM_TRUST_CERTS: api.sys.huron.cf-app.com\r\n    SPRING_CLOUD_DATAFLOW_APPLICATIONPROPERTIES_TASK_TRUST_CERTS: api.sys.huron.cf-app.com\r\n    SPRING_CLOUD_DEPLOYER_CLOUDFOUNDRY_STREAM_ENABLE_RANDOM_APP_NAME_PREFIX: false\r\n    SPRING_CLOUD_DATAFLOW_FEATURES_STREAMS_ENABLED: false\r\n    SPRING_CLOUD_DATAFLOW_FEATURES_ANALYTICS_ENABLED: false\r\n```\r\n\r\nFixes #2627\r\nResolves  spring-cloud/spring-cloud-dataflow-server-kubernetes#371\r\nResolved  spring-cloud/spring-cloud-dataflow#2684"},"comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments/448463751","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/2688#issuecomment-448463751","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/2688","id":448463751,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODQ2Mzc1MQ==","user":{"login":"ilayaperumalg","id":151690,"node_id":"MDQ6VXNlcjE1MTY5MA==","avatar_url":"https://avatars2.githubusercontent.com/u/151690?v=4","gravatar_id":"","url":"https://api.github.com/users/ilayaperumalg","html_url":"https://github.com/ilayaperumalg","followers_url":"https://api.github.com/users/ilayaperumalg/followers","following_url":"https://api.github.com/users/ilayaperumalg/following{/other_user}","gists_url":"https://api.github.com/users/ilayaperumalg/gists{/gist_id}","starred_url":"https://api.github.com/users/ilayaperumalg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilayaperumalg/subscriptions","organizations_url":"https://api.github.com/users/ilayaperumalg/orgs","repos_url":"https://api.github.com/users/ilayaperumalg/repos","events_url":"https://api.github.com/users/ilayaperumalg/events{/privacy}","received_events_url":"https://api.github.com/users/ilayaperumalg/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T04:14:25Z","updated_at":"2018-12-19T04:14:25Z","author_association":"CONTRIBUTOR","body":"LGTM, merging."}}
{"actor":{"display_login":"ilayaperumalg"}}