{"action":"created","comment":{"url":"https://api.github.com/repos/r-lib/pkgdown/pulls/comments/198626189","pull_request_review_id":132590564,"id":198626189,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODYyNjE4OQ==","diff_hunk":"@@ -70,7 +70,13 @@ tweak_md_links <- function(html) {\n tweak_tables <- function(html) {\n   # Ensure all tables have class=\"table\"\n   table <- xml2::xml_find_all(html, \".//table\")\n-  xml2::xml_attr(table, \"class\") <- \"table\"\n+  # prepend existing classes, so that existing classes can overrwrite .table css\n+  existing_classes <- xml2::xml_attr(table, \"class\")","path":"R/html-tweak.R","position":6,"original_position":6,"commit_id":"0267a3fde2053c1699287cfd336d9ce86f530d63","original_commit_id":"0267a3fde2053c1699287cfd336d9ce86f530d63","user":{"login":"jayhesselberth","id":355367,"node_id":"MDQ6VXNlcjM1NTM2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/355367?v=4","gravatar_id":"","url":"https://api.github.com/users/jayhesselberth","html_url":"https://github.com/jayhesselberth","followers_url":"https://api.github.com/users/jayhesselberth/followers","following_url":"https://api.github.com/users/jayhesselberth/following{/other_user}","gists_url":"https://api.github.com/users/jayhesselberth/gists{/gist_id}","starred_url":"https://api.github.com/users/jayhesselberth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayhesselberth/subscriptions","organizations_url":"https://api.github.com/users/jayhesselberth/orgs","repos_url":"https://api.github.com/users/jayhesselberth/repos","events_url":"https://api.github.com/users/jayhesselberth/events{/privacy}","received_events_url":"https://api.github.com/users/jayhesselberth/received_events","type":"User","site_admin":false},"body":"You need to return if existing is empty.\r\n\r\n```r\r\n  if (length(existing_classes) == 0) {\r\n    return()\r\n  }\r\n```","created_at":"2018-06-27T20:14:18Z","updated_at":"2018-06-27T20:14:18Z","html_url":"https://github.com/r-lib/pkgdown/pull/752#discussion_r198626189","pull_request_url":"https://api.github.com/repos/r-lib/pkgdown/pulls/752","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/comments/198626189"},"html":{"href":"https://github.com/r-lib/pkgdown/pull/752#discussion_r198626189"},"pull_request":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/752"}}},"pull_request":{"url":"https://api.github.com/repos/r-lib/pkgdown/pulls/752","id":197735145,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NzM1MTQ1","html_url":"https://github.com/r-lib/pkgdown/pull/752","diff_url":"https://github.com/r-lib/pkgdown/pull/752.diff","patch_url":"https://github.com/r-lib/pkgdown/pull/752.patch","issue_url":"https://api.github.com/repos/r-lib/pkgdown/issues/752","number":752,"state":"open","locked":false,"title":"prepend, not replace existing table classes with .table","user":{"login":"maxheld83","id":5372770,"node_id":"MDQ6VXNlcjUzNzI3NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/5372770?v=4","gravatar_id":"","url":"https://api.github.com/users/maxheld83","html_url":"https://github.com/maxheld83","followers_url":"https://api.github.com/users/maxheld83/followers","following_url":"https://api.github.com/users/maxheld83/following{/other_user}","gists_url":"https://api.github.com/users/maxheld83/gists{/gist_id}","starred_url":"https://api.github.com/users/maxheld83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxheld83/subscriptions","organizations_url":"https://api.github.com/users/maxheld83/orgs","repos_url":"https://api.github.com/users/maxheld83/repos","events_url":"https://api.github.com/users/maxheld83/events{/privacy}","received_events_url":"https://api.github.com/users/maxheld83/received_events","type":"User","site_admin":false},"body":"this is to close #746 ","created_at":"2018-06-27T13:34:31Z","updated_at":"2018-06-27T20:14:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38af4cbf99fa1df6833a64f5501f500a1a989f5d","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hadley","id":4196,"node_id":"MDQ6VXNlcjQxOTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4196?v=4","gravatar_id":"","url":"https://api.github.com/users/hadley","html_url":"https://github.com/hadley","followers_url":"https://api.github.com/users/hadley/followers","following_url":"https://api.github.com/users/hadley/following{/other_user}","gists_url":"https://api.github.com/users/hadley/gists{/gist_id}","starred_url":"https://api.github.com/users/hadley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadley/subscriptions","organizations_url":"https://api.github.com/users/hadley/orgs","repos_url":"https://api.github.com/users/hadley/repos","events_url":"https://api.github.com/users/hadley/events{/privacy}","received_events_url":"https://api.github.com/users/hadley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/r-lib/pkgdown/pulls/752/commits","review_comments_url":"https://api.github.com/repos/r-lib/pkgdown/pulls/752/comments","review_comment_url":"https://api.github.com/repos/r-lib/pkgdown/pulls/comments{/number}","comments_url":"https://api.github.com/repos/r-lib/pkgdown/issues/752/comments","statuses_url":"https://api.github.com/repos/r-lib/pkgdown/statuses/0267a3fde2053c1699287cfd336d9ce86f530d63","head":{"label":"maxheld83:master","ref":"master","sha":"0267a3fde2053c1699287cfd336d9ce86f530d63","user":{"login":"maxheld83","id":5372770,"node_id":"MDQ6VXNlcjUzNzI3NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/5372770?v=4","gravatar_id":"","url":"https://api.github.com/users/maxheld83","html_url":"https://github.com/maxheld83","followers_url":"https://api.github.com/users/maxheld83/followers","following_url":"https://api.github.com/users/maxheld83/following{/other_user}","gists_url":"https://api.github.com/users/maxheld83/gists{/gist_id}","starred_url":"https://api.github.com/users/maxheld83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxheld83/subscriptions","organizations_url":"https://api.github.com/users/maxheld83/orgs","repos_url":"https://api.github.com/users/maxheld83/repos","events_url":"https://api.github.com/users/maxheld83/events{/privacy}","received_events_url":"https://api.github.com/users/maxheld83/received_events","type":"User","site_admin":false},"repo":{"id":138497235,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg0OTcyMzU=","name":"pkgdown","full_name":"maxheld83/pkgdown","owner":{"login":"maxheld83","id":5372770,"node_id":"MDQ6VXNlcjUzNzI3NzA=","avatar_url":"https://avatars0.githubusercontent.com/u/5372770?v=4","gravatar_id":"","url":"https://api.github.com/users/maxheld83","html_url":"https://github.com/maxheld83","followers_url":"https://api.github.com/users/maxheld83/followers","following_url":"https://api.github.com/users/maxheld83/following{/other_user}","gists_url":"https://api.github.com/users/maxheld83/gists{/gist_id}","starred_url":"https://api.github.com/users/maxheld83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxheld83/subscriptions","organizations_url":"https://api.github.com/users/maxheld83/orgs","repos_url":"https://api.github.com/users/maxheld83/repos","events_url":"https://api.github.com/users/maxheld83/events{/privacy}","received_events_url":"https://api.github.com/users/maxheld83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxheld83/pkgdown","description":"Generate static html documentation for an R package","fork":true,"url":"https://api.github.com/repos/maxheld83/pkgdown","forks_url":"https://api.github.com/repos/maxheld83/pkgdown/forks","keys_url":"https://api.github.com/repos/maxheld83/pkgdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxheld83/pkgdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxheld83/pkgdown/teams","hooks_url":"https://api.github.com/repos/maxheld83/pkgdown/hooks","issue_events_url":"https://api.github.com/repos/maxheld83/pkgdown/issues/events{/number}","events_url":"https://api.github.com/repos/maxheld83/pkgdown/events","assignees_url":"https://api.github.com/repos/maxheld83/pkgdown/assignees{/user}","branches_url":"https://api.github.com/repos/maxheld83/pkgdown/branches{/branch}","tags_url":"https://api.github.com/repos/maxheld83/pkgdown/tags","blobs_url":"https://api.github.com/repos/maxheld83/pkgdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxheld83/pkgdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxheld83/pkgdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxheld83/pkgdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxheld83/pkgdown/statuses/{sha}","languages_url":"https://api.github.com/repos/maxheld83/pkgdown/languages","stargazers_url":"https://api.github.com/repos/maxheld83/pkgdown/stargazers","contributors_url":"https://api.github.com/repos/maxheld83/pkgdown/contributors","subscribers_url":"https://api.github.com/repos/maxheld83/pkgdown/subscribers","subscription_url":"https://api.github.com/repos/maxheld83/pkgdown/subscription","commits_url":"https://api.github.com/repos/maxheld83/pkgdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxheld83/pkgdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxheld83/pkgdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxheld83/pkgdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxheld83/pkgdown/contents/{+path}","compare_url":"https://api.github.com/repos/maxheld83/pkgdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxheld83/pkgdown/merges","archive_url":"https://api.github.com/repos/maxheld83/pkgdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxheld83/pkgdown/downloads","issues_url":"https://api.github.com/repos/maxheld83/pkgdown/issues{/number}","pulls_url":"https://api.github.com/repos/maxheld83/pkgdown/pulls{/number}","milestones_url":"https://api.github.com/repos/maxheld83/pkgdown/milestones{/number}","notifications_url":"https://api.github.com/repos/maxheld83/pkgdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxheld83/pkgdown/labels{/name}","releases_url":"https://api.github.com/repos/maxheld83/pkgdown/releases{/id}","deployments_url":"https://api.github.com/repos/maxheld83/pkgdown/deployments","created_at":"2018-06-24T16:22:02Z","updated_at":"2018-06-27T13:38:58Z","pushed_at":"2018-06-27T13:38:56Z","git_url":"git://github.com/maxheld83/pkgdown.git","ssh_url":"git@github.com:maxheld83/pkgdown.git","clone_url":"https://github.com/maxheld83/pkgdown.git","svn_url":"https://github.com/maxheld83/pkgdown","homepage":"http://pkgdown.r-lib.org","size":5361,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"r-lib:master","ref":"master","sha":"88eacb1caeeb9bfa4e929681917576579e06bd7f","user":{"login":"r-lib","id":22618716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjE4NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/22618716?v=4","gravatar_id":"","url":"https://api.github.com/users/r-lib","html_url":"https://github.com/r-lib","followers_url":"https://api.github.com/users/r-lib/followers","following_url":"https://api.github.com/users/r-lib/following{/other_user}","gists_url":"https://api.github.com/users/r-lib/gists{/gist_id}","starred_url":"https://api.github.com/users/r-lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-lib/subscriptions","organizations_url":"https://api.github.com/users/r-lib/orgs","repos_url":"https://api.github.com/users/r-lib/repos","events_url":"https://api.github.com/users/r-lib/events{/privacy}","received_events_url":"https://api.github.com/users/r-lib/received_events","type":"Organization","site_admin":false},"repo":{"id":3723845,"node_id":"MDEwOlJlcG9zaXRvcnkzNzIzODQ1","name":"pkgdown","full_name":"r-lib/pkgdown","owner":{"login":"r-lib","id":22618716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjE4NzE2","avatar_url":"https://avatars0.githubusercontent.com/u/22618716?v=4","gravatar_id":"","url":"https://api.github.com/users/r-lib","html_url":"https://github.com/r-lib","followers_url":"https://api.github.com/users/r-lib/followers","following_url":"https://api.github.com/users/r-lib/following{/other_user}","gists_url":"https://api.github.com/users/r-lib/gists{/gist_id}","starred_url":"https://api.github.com/users/r-lib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-lib/subscriptions","organizations_url":"https://api.github.com/users/r-lib/orgs","repos_url":"https://api.github.com/users/r-lib/repos","events_url":"https://api.github.com/users/r-lib/events{/privacy}","received_events_url":"https://api.github.com/users/r-lib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/r-lib/pkgdown","description":"Generate static html documentation for an R package","fork":false,"url":"https://api.github.com/repos/r-lib/pkgdown","forks_url":"https://api.github.com/repos/r-lib/pkgdown/forks","keys_url":"https://api.github.com/repos/r-lib/pkgdown/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r-lib/pkgdown/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r-lib/pkgdown/teams","hooks_url":"https://api.github.com/repos/r-lib/pkgdown/hooks","issue_events_url":"https://api.github.com/repos/r-lib/pkgdown/issues/events{/number}","events_url":"https://api.github.com/repos/r-lib/pkgdown/events","assignees_url":"https://api.github.com/repos/r-lib/pkgdown/assignees{/user}","branches_url":"https://api.github.com/repos/r-lib/pkgdown/branches{/branch}","tags_url":"https://api.github.com/repos/r-lib/pkgdown/tags","blobs_url":"https://api.github.com/repos/r-lib/pkgdown/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r-lib/pkgdown/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r-lib/pkgdown/git/refs{/sha}","trees_url":"https://api.github.com/repos/r-lib/pkgdown/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r-lib/pkgdown/statuses/{sha}","languages_url":"https://api.github.com/repos/r-lib/pkgdown/languages","stargazers_url":"https://api.github.com/repos/r-lib/pkgdown/stargazers","contributors_url":"https://api.github.com/repos/r-lib/pkgdown/contributors","subscribers_url":"https://api.github.com/repos/r-lib/pkgdown/subscribers","subscription_url":"https://api.github.com/repos/r-lib/pkgdown/subscription","commits_url":"https://api.github.com/repos/r-lib/pkgdown/commits{/sha}","git_commits_url":"https://api.github.com/repos/r-lib/pkgdown/git/commits{/sha}","comments_url":"https://api.github.com/repos/r-lib/pkgdown/comments{/number}","issue_comment_url":"https://api.github.com/repos/r-lib/pkgdown/issues/comments{/number}","contents_url":"https://api.github.com/repos/r-lib/pkgdown/contents/{+path}","compare_url":"https://api.github.com/repos/r-lib/pkgdown/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r-lib/pkgdown/merges","archive_url":"https://api.github.com/repos/r-lib/pkgdown/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r-lib/pkgdown/downloads","issues_url":"https://api.github.com/repos/r-lib/pkgdown/issues{/number}","pulls_url":"https://api.github.com/repos/r-lib/pkgdown/pulls{/number}","milestones_url":"https://api.github.com/repos/r-lib/pkgdown/milestones{/number}","notifications_url":"https://api.github.com/repos/r-lib/pkgdown/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r-lib/pkgdown/labels{/name}","releases_url":"https://api.github.com/repos/r-lib/pkgdown/releases{/id}","deployments_url":"https://api.github.com/repos/r-lib/pkgdown/deployments","created_at":"2012-03-15T00:36:24Z","updated_at":"2018-06-27T13:23:23Z","pushed_at":"2018-06-27T13:38:58Z","git_url":"git://github.com/r-lib/pkgdown.git","ssh_url":"git@github.com:r-lib/pkgdown.git","clone_url":"https://github.com/r-lib/pkgdown.git","svn_url":"https://github.com/r-lib/pkgdown","homepage":"http://pkgdown.r-lib.org","size":5371,"stargazers_count":339,"watchers_count":339,"language":"R","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":173,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":173,"open_issues":30,"watchers":339,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/752"},"html":{"href":"https://github.com/r-lib/pkgdown/pull/752"},"issue":{"href":"https://api.github.com/repos/r-lib/pkgdown/issues/752"},"comments":{"href":"https://api.github.com/repos/r-lib/pkgdown/issues/752/comments"},"review_comments":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/752/comments"},"review_comment":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/r-lib/pkgdown/pulls/752/commits"},"statuses":{"href":"https://api.github.com/repos/r-lib/pkgdown/statuses/0267a3fde2053c1699287cfd336d9ce86f530d63"}},"author_association":"NONE"}}
{"actor":{"display_login":"jayhesselberth"}}