{"action":"created","issue":{"url":"https://api.github.com/repos/manoharan-lab/holopy/issues/220","repository_url":"https://api.github.com/repos/manoharan-lab/holopy","labels_url":"https://api.github.com/repos/manoharan-lab/holopy/issues/220/labels{/name}","comments_url":"https://api.github.com/repos/manoharan-lab/holopy/issues/220/comments","events_url":"https://api.github.com/repos/manoharan-lab/holopy/issues/220/events","html_url":"https://github.com/manoharan-lab/holopy/pull/220","id":311721346,"number":220,"title":"Make HoloPy build on Windows with conda-forge","user":{"login":"barkls","id":19350183,"avatar_url":"https://avatars3.githubusercontent.com/u/19350183?v=4","gravatar_id":"","url":"https://api.github.com/users/barkls","html_url":"https://github.com/barkls","followers_url":"https://api.github.com/users/barkls/followers","following_url":"https://api.github.com/users/barkls/following{/other_user}","gists_url":"https://api.github.com/users/barkls/gists{/gist_id}","starred_url":"https://api.github.com/users/barkls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barkls/subscriptions","organizations_url":"https://api.github.com/users/barkls/orgs","repos_url":"https://api.github.com/users/barkls/repos","events_url":"https://api.github.com/users/barkls/events{/privacy}","received_events_url":"https://api.github.com/users/barkls/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-05T18:31:36Z","updated_at":"2018-04-05T18:39:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/manoharan-lab/holopy/pulls/220","html_url":"https://github.com/manoharan-lab/holopy/pull/220","diff_url":"https://github.com/manoharan-lab/holopy/pull/220.diff","patch_url":"https://github.com/manoharan-lab/holopy/pull/220.patch"},"body":"conda-forge can now use [flang](https://github.com/flang-compiler/flang) to compile Fortran on Windows. This PR includes 3 changes to make HoloPy build in this environment:\r\n\r\n1) Switch (revert) to using double precision axisymmetric T-matrix code. The flang compiler doesn't support quad-precision variables so we have to switch back to double precision, which I salvaged from an old PR.\r\n\r\n2) Removal of mie_f/scfodim.for parameter file for multisphere since Fortran's ``include`` command wasn't finding it. There are several degrees of separation between us and what is actually doing the compile, since it goes through conda-forge's machinery and also f2py, so it's not easy to add a flag when calling the compiler to help find the file. I just pasted the file contents everywhere we were supposed to include it. Note that this file doesn't allow us to easily change parameters anyway, see #88 comments thread.\r\n\r\n3) Let setup.py bypass compiling Tmatrix code. Our Makefile has gfortran hard-coded, but flang is a separate compiler. I can compile Tmatrix code with a ``bld.bat`` file independent of setup.py that will run only on conda-forge."},"comment":{"url":"https://api.github.com/repos/manoharan-lab/holopy/issues/comments/379036489","html_url":"https://github.com/manoharan-lab/holopy/pull/220#issuecomment-379036489","issue_url":"https://api.github.com/repos/manoharan-lab/holopy/issues/220","id":379036489,"user":{"login":"barkls","id":19350183,"avatar_url":"https://avatars3.githubusercontent.com/u/19350183?v=4","gravatar_id":"","url":"https://api.github.com/users/barkls","html_url":"https://github.com/barkls","followers_url":"https://api.github.com/users/barkls/followers","following_url":"https://api.github.com/users/barkls/following{/other_user}","gists_url":"https://api.github.com/users/barkls/gists{/gist_id}","starred_url":"https://api.github.com/users/barkls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barkls/subscriptions","organizations_url":"https://api.github.com/users/barkls/orgs","repos_url":"https://api.github.com/users/barkls/repos","events_url":"https://api.github.com/users/barkls/events{/privacy}","received_events_url":"https://api.github.com/users/barkls/received_events","type":"User","site_admin":false},"created_at":"2018-04-05T18:39:52Z","updated_at":"2018-04-05T18:39:52Z","author_association":"CONTRIBUTOR","body":"The failing test on Travis is a Multisphere failure, see #194. All tests passed locally."}}
{"actor":{"display_login":"barkls"}}