{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/230781229","pull_request_review_id":171543812,"id":230781229,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDc4MTIyOQ==","diff_hunk":"@@ -261,35 +266,45 @@ TEST_F(SimulatorTest, FailWhenSameAsProposalHeight) {\n TEST_F(SimulatorTest, RightNumberOfFailedTxs) {\n   // create a 3-height proposal, but validator returns only a 2-height verified\n   // proposal\n-  auto tx = shared_model::proto::TransactionBuilder()\n-                .createdTime(iroha::time::now())\n-                .creatorAccountId(\"admin@ru\")\n-                .addAssetQuantity(\"coin#coin\", \"1.0\")\n-                .quorum(1)\n-                .build()\n-                .signAndAddSignature(\n-                    shared_model::crypto::DefaultCryptoAlgorithmType::\n-                        generateKeypair())\n-                .finish();\n-\n-  std::vector<shared_model::proto::Transaction> txs = {tx, tx, tx};\n+  const int kNumTransactions = 3;\n+  std::vector<shared_model::proto::Transaction> txs;\n+  for (int i = 0; i < kNumTransactions; ++i) {\n+    txs.emplace_back(shared_model::proto::TransactionBuilder()\n+                         .createdTime(iroha::time::now() + i)","path":"test/module/irohad/simulator/simulator_test.cpp","position":82,"original_position":82,"commit_id":"3254608a9d34c39716f0787d4290e9538a236a36","original_commit_id":"3254608a9d34c39716f0787d4290e9538a236a36","user":{"login":"luckychess","id":3829208,"node_id":"MDQ6VXNlcjM4MjkyMDg=","avatar_url":"https://avatars3.githubusercontent.com/u/3829208?v=4","gravatar_id":"","url":"https://api.github.com/users/luckychess","html_url":"https://github.com/luckychess","followers_url":"https://api.github.com/users/luckychess/followers","following_url":"https://api.github.com/users/luckychess/following{/other_user}","gists_url":"https://api.github.com/users/luckychess/gists{/gist_id}","starred_url":"https://api.github.com/users/luckychess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luckychess/subscriptions","organizations_url":"https://api.github.com/users/luckychess/orgs","repos_url":"https://api.github.com/users/luckychess/repos","events_url":"https://api.github.com/users/luckychess/events{/privacy}","received_events_url":"https://api.github.com/users/luckychess/received_events","type":"User","site_admin":false},"body":"I guess we have a special wrapper for this, do we?","created_at":"2018-11-05T15:01:07Z","updated_at":"2018-11-05T15:19:40Z","html_url":"https://github.com/hyperledger/iroha/pull/1815#discussion_r230781229","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1815","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/230781229"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1815#discussion_r230781229"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1815"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/1815","id":226363397,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzYzMzk3","html_url":"https://github.com/hyperledger/iroha/pull/1815","diff_url":"https://github.com/hyperledger/iroha/pull/1815.diff","patch_url":"https://github.com/hyperledger/iroha/pull/1815.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/1815","number":1815,"state":"open","locked":false,"title":"Store rejected transactions' hashes in blockchain","user":{"login":"MBoldyrev","id":11086641,"node_id":"MDQ6VXNlcjExMDg2NjQx","avatar_url":"https://avatars0.githubusercontent.com/u/11086641?v=4","gravatar_id":"","url":"https://api.github.com/users/MBoldyrev","html_url":"https://github.com/MBoldyrev","followers_url":"https://api.github.com/users/MBoldyrev/followers","following_url":"https://api.github.com/users/MBoldyrev/following{/other_user}","gists_url":"https://api.github.com/users/MBoldyrev/gists{/gist_id}","starred_url":"https://api.github.com/users/MBoldyrev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MBoldyrev/subscriptions","organizations_url":"https://api.github.com/users/MBoldyrev/orgs","repos_url":"https://api.github.com/users/MBoldyrev/repos","events_url":"https://api.github.com/users/MBoldyrev/events{/privacy}","received_events_url":"https://api.github.com/users/MBoldyrev/received_events","type":"User","site_admin":false},"body":"### Description of the Change\r\n\r\nThe hashes of transactions rejected after proposal verification by simulator are passed to block creator along with the verified proposal. Then these hashes are added to a newly created field in the block.\r\n\r\n### Benefits\r\n\r\nThe rejected transactions' hashes stored in the blockchain let us guarantee a client that certain transaction was rejected and will never be executed.\r\n\r\n### Possible Drawbacks \r\n\r\nA malicious peer can bloat the blockchain with tons of fake invalid transactions' hashes.","created_at":"2018-10-28T12:29:15Z","updated_at":"2018-11-05T15:19:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18b1509c8b6b253ba750f49b7ed110cc812f7995","assignee":null,"assignees":[],"requested_reviewers":[{"login":"muratovv","id":7502801,"node_id":"MDQ6VXNlcjc1MDI4MDE=","avatar_url":"https://avatars2.githubusercontent.com/u/7502801?v=4","gravatar_id":"","url":"https://api.github.com/users/muratovv","html_url":"https://github.com/muratovv","followers_url":"https://api.github.com/users/muratovv/followers","following_url":"https://api.github.com/users/muratovv/following{/other_user}","gists_url":"https://api.github.com/users/muratovv/gists{/gist_id}","starred_url":"https://api.github.com/users/muratovv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muratovv/subscriptions","organizations_url":"https://api.github.com/users/muratovv/orgs","repos_url":"https://api.github.com/users/muratovv/repos","events_url":"https://api.github.com/users/muratovv/events{/privacy}","received_events_url":"https://api.github.com/users/muratovv/received_events","type":"User","site_admin":false},{"login":"kamilsa","id":9370151,"node_id":"MDQ6VXNlcjkzNzAxNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/9370151?v=4","gravatar_id":"","url":"https://api.github.com/users/kamilsa","html_url":"https://github.com/kamilsa","followers_url":"https://api.github.com/users/kamilsa/followers","following_url":"https://api.github.com/users/kamilsa/following{/other_user}","gists_url":"https://api.github.com/users/kamilsa/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilsa/subscriptions","organizations_url":"https://api.github.com/users/kamilsa/orgs","repos_url":"https://api.github.com/users/kamilsa/repos","events_url":"https://api.github.com/users/kamilsa/events{/privacy}","received_events_url":"https://api.github.com/users/kamilsa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":684699993,"node_id":"MDU6TGFiZWw2ODQ2OTk5OTM=","url":"https://api.github.com/repos/hyperledger/iroha/labels/needs-review","name":"needs-review","color":"f9d0c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1815/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/1815/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/1815/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/3254608a9d34c39716f0787d4290e9538a236a36","head":{"label":"hyperledger:feature/rejected-txs-in-block","ref":"feature/rejected-txs-in-block","sha":"3254608a9d34c39716f0787d4290e9538a236a36","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","private":false,"owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-11-05T09:19:21Z","pushed_at":"2018-11-05T13:48:36Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":56512,"stargazers_count":962,"watchers_count":962,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":304,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":304,"open_issues":60,"watchers":962,"default_branch":"master"}},"base":{"label":"hyperledger:dev","ref":"dev","sha":"1e0622134416f74eea73559a9f3d3f930acfb0e6","user":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM0MDU3NQ==","name":"iroha","full_name":"hyperledger/iroha","private":false,"owner":{"login":"hyperledger","id":7657900,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NTc5MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2018-11-05T09:19:21Z","pushed_at":"2018-11-05T13:48:36Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":56512,"stargazers_count":962,"watchers_count":962,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":304,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":304,"open_issues":60,"watchers":962,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1815"},"html":{"href":"https://github.com/hyperledger/iroha/pull/1815"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1815"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/1815/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1815/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/1815/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/3254608a9d34c39716f0787d4290e9538a236a36"}},"author_association":"NONE"}}
{"actor":{"display_login":"luckychess"}}