{"action":"created","issue":{"url":"https://api.github.com/repos/unitycontainer/container/issues/109","repository_url":"https://api.github.com/repos/unitycontainer/container","labels_url":"https://api.github.com/repos/unitycontainer/container/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/unitycontainer/container/issues/109/comments","events_url":"https://api.github.com/repos/unitycontainer/container/issues/109/events","html_url":"https://github.com/unitycontainer/container/pull/109","id":363082207,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NjA2NzM2","number":109,"title":"#108: Added parametrized version of GetOrAdd, so child containers can…","user":{"login":"bartoszkp","id":9852318,"node_id":"MDQ6VXNlcjk4NTIzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/9852318?v=4","gravatar_id":"","url":"https://api.github.com/users/bartoszkp","html_url":"https://github.com/bartoszkp","followers_url":"https://api.github.com/users/bartoszkp/followers","following_url":"https://api.github.com/users/bartoszkp/following{/other_user}","gists_url":"https://api.github.com/users/bartoszkp/gists{/gist_id}","starred_url":"https://api.github.com/users/bartoszkp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartoszkp/subscriptions","organizations_url":"https://api.github.com/users/bartoszkp/orgs","repos_url":"https://api.github.com/users/bartoszkp/repos","events_url":"https://api.github.com/users/bartoszkp/events{/privacy}","received_events_url":"https://api.github.com/users/bartoszkp/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-24T10:05:50Z","updated_at":"2018-09-24T17:36:34Z","closed_at":"2018-09-24T17:36:34Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/unitycontainer/container/pulls/109","html_url":"https://github.com/unitycontainer/container/pull/109","diff_url":"https://github.com/unitycontainer/container/pull/109.diff","patch_url":"https://github.com/unitycontainer/container/pull/109.patch"},"body":"… pass up their own way of creating a new registration. This way child container strategies will be used when creating a build child for a new registration."},"comment":{"url":"https://api.github.com/repos/unitycontainer/container/issues/comments/424060171","html_url":"https://github.com/unitycontainer/container/pull/109#issuecomment-424060171","issue_url":"https://api.github.com/repos/unitycontainer/container/issues/109","id":424060171,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDA2MDE3MQ==","user":{"login":"ENikS","id":1750155,"node_id":"MDQ6VXNlcjE3NTAxNTU=","avatar_url":"https://avatars2.githubusercontent.com/u/1750155?v=4","gravatar_id":"","url":"https://api.github.com/users/ENikS","html_url":"https://github.com/ENikS","followers_url":"https://api.github.com/users/ENikS/followers","following_url":"https://api.github.com/users/ENikS/following{/other_user}","gists_url":"https://api.github.com/users/ENikS/gists{/gist_id}","starred_url":"https://api.github.com/users/ENikS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ENikS/subscriptions","organizations_url":"https://api.github.com/users/ENikS/orgs","repos_url":"https://api.github.com/users/ENikS/repos","events_url":"https://api.github.com/users/ENikS/events{/privacy}","received_events_url":"https://api.github.com/users/ENikS/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T17:36:34Z","updated_at":"2018-09-24T17:36:34Z","author_association":"MEMBER","body":"Unfortunately this is not going to work.\r\n\r\nThe proper way of doing it is by [creating new instance](https://github.com/unitycontainer/container/blob/4c5672d0e2ca38edef1d627a6395b536c4d27c52/src/UnityContainer.Implementation.cs#L66) of ``StagedStrategyChain`` for the child container instead of just [getting reference from parent](https://github.com/unitycontainer/container/blob/9b5f526fc44f77c841af893fdd9ff3e6a3de6849/src/UnityContainer.Implementation.cs#L186).\r\n\r\nThis is one of these things that been optimized out of original version. If you look at original implementation it was done properly but later has been simplified. I was going to add it back later but never had time.\r\n\r\nThe idea is to create new instance only if collection of strategies has been modified. Once created it should monitor changes made in parent lists down the parent chain.\r\n\r\nIf you want to try implementing this logic properly I would help with advise and any info..."}}
{"actor":{"display_login":"ENikS"}}