{"action":"closed","number":1158,"pull_request":{"url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1158","id":209472911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NDcyOTEx","html_url":"https://github.com/ethereum/ethereumj/pull/1158","diff_url":"https://github.com/ethereum/ethereumj/pull/1158.diff","patch_url":"https://github.com/ethereum/ethereumj/pull/1158.patch","issue_url":"https://api.github.com/repos/ethereum/ethereumj/issues/1158","number":1158,"state":"closed","locked":false,"title":"fix same composed key of contract storage nodes","user":{"login":"ithinker1991","id":5145021,"node_id":"MDQ6VXNlcjUxNDUwMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5145021?v=4","gravatar_id":"","url":"https://api.github.com/users/ithinker1991","html_url":"https://github.com/ithinker1991","followers_url":"https://api.github.com/users/ithinker1991/followers","following_url":"https://api.github.com/users/ithinker1991/following{/other_user}","gists_url":"https://api.github.com/users/ithinker1991/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinker1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinker1991/subscriptions","organizations_url":"https://api.github.com/users/ithinker1991/orgs","repos_url":"https://api.github.com/users/ithinker1991/repos","events_url":"https://api.github.com/users/ithinker1991/events{/privacy}","received_events_url":"https://api.github.com/users/ithinker1991/received_events","type":"User","site_admin":false},"body":"32-bytes composed key should be \r\n[first 16-bytes of address hash:second 16-bytes of node key] \r\n\r\nThere seems a  BIG problem. I noticed in solidity, for dynamic type such as  `string`， `bytes`\r\nfirst 16-bytes of node-key are same and second 16-bytes of node are different.\r\nSo if one field has been encoded to many storage-key. the composed key will be same.\r\n\r\nFor example\r\n        s1 = \"1111111111111111111111111111111111111112222222222222222222222222222222222222222333333333333333333333333333333333333\";\r\n\r\nencoded result:\r\n```\r\nkey of storage node\t\t\t\t\t\t\t\tvalue of storage node\t\t\t\t\t\t\t\t\t\t\t\t\t     \r\n0000000000000000000000000000000000000000000000000000000000000000 00000000000000000000000000000000000000000000000000000000000000e7\r\n290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563 3131313131313131313131313131313131313131313131313131313131313131\r\n290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e564 3131313131313132323232323232323232323232323232323232323232323232\r\n290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e565 3232323232323232323232323232323333333333333333333333333333333333\r\n290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e566 3333333333333333333333333333333333333300000000000000000000000000\r\n```\r\n\r\n\r\n\r\n\r\n\r\n","created_at":"2018-08-20T10:12:55Z","updated_at":"2018-08-20T13:51:32Z","closed_at":"2018-08-20T13:51:32Z","merged_at":null,"merge_commit_sha":"73b521852ea6d019b357b2058557d8a8972f5a72","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1158/commits","review_comments_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1158/comments","review_comment_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/ethereumj/issues/1158/comments","statuses_url":"https://api.github.com/repos/ethereum/ethereumj/statuses/4f732bef867622e54ee7ff5ac1e68486be504943","head":{"label":"ithinker1991:fix/same-storage-key","ref":"fix/same-storage-key","sha":"4f732bef867622e54ee7ff5ac1e68486be504943","user":{"login":"ithinker1991","id":5145021,"node_id":"MDQ6VXNlcjUxNDUwMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5145021?v=4","gravatar_id":"","url":"https://api.github.com/users/ithinker1991","html_url":"https://github.com/ithinker1991","followers_url":"https://api.github.com/users/ithinker1991/followers","following_url":"https://api.github.com/users/ithinker1991/following{/other_user}","gists_url":"https://api.github.com/users/ithinker1991/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinker1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinker1991/subscriptions","organizations_url":"https://api.github.com/users/ithinker1991/orgs","repos_url":"https://api.github.com/users/ithinker1991/repos","events_url":"https://api.github.com/users/ithinker1991/events{/privacy}","received_events_url":"https://api.github.com/users/ithinker1991/received_events","type":"User","site_admin":false},"repo":{"id":145399053,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUzOTkwNTM=","name":"ethereumj","full_name":"ithinker1991/ethereumj","owner":{"login":"ithinker1991","id":5145021,"node_id":"MDQ6VXNlcjUxNDUwMjE=","avatar_url":"https://avatars0.githubusercontent.com/u/5145021?v=4","gravatar_id":"","url":"https://api.github.com/users/ithinker1991","html_url":"https://github.com/ithinker1991","followers_url":"https://api.github.com/users/ithinker1991/followers","following_url":"https://api.github.com/users/ithinker1991/following{/other_user}","gists_url":"https://api.github.com/users/ithinker1991/gists{/gist_id}","starred_url":"https://api.github.com/users/ithinker1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ithinker1991/subscriptions","organizations_url":"https://api.github.com/users/ithinker1991/orgs","repos_url":"https://api.github.com/users/ithinker1991/repos","events_url":"https://api.github.com/users/ithinker1991/events{/privacy}","received_events_url":"https://api.github.com/users/ithinker1991/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ithinker1991/ethereumj","description":"Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony","fork":true,"url":"https://api.github.com/repos/ithinker1991/ethereumj","forks_url":"https://api.github.com/repos/ithinker1991/ethereumj/forks","keys_url":"https://api.github.com/repos/ithinker1991/ethereumj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ithinker1991/ethereumj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ithinker1991/ethereumj/teams","hooks_url":"https://api.github.com/repos/ithinker1991/ethereumj/hooks","issue_events_url":"https://api.github.com/repos/ithinker1991/ethereumj/issues/events{/number}","events_url":"https://api.github.com/repos/ithinker1991/ethereumj/events","assignees_url":"https://api.github.com/repos/ithinker1991/ethereumj/assignees{/user}","branches_url":"https://api.github.com/repos/ithinker1991/ethereumj/branches{/branch}","tags_url":"https://api.github.com/repos/ithinker1991/ethereumj/tags","blobs_url":"https://api.github.com/repos/ithinker1991/ethereumj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ithinker1991/ethereumj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ithinker1991/ethereumj/git/refs{/sha}","trees_url":"https://api.github.com/repos/ithinker1991/ethereumj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ithinker1991/ethereumj/statuses/{sha}","languages_url":"https://api.github.com/repos/ithinker1991/ethereumj/languages","stargazers_url":"https://api.github.com/repos/ithinker1991/ethereumj/stargazers","contributors_url":"https://api.github.com/repos/ithinker1991/ethereumj/contributors","subscribers_url":"https://api.github.com/repos/ithinker1991/ethereumj/subscribers","subscription_url":"https://api.github.com/repos/ithinker1991/ethereumj/subscription","commits_url":"https://api.github.com/repos/ithinker1991/ethereumj/commits{/sha}","git_commits_url":"https://api.github.com/repos/ithinker1991/ethereumj/git/commits{/sha}","comments_url":"https://api.github.com/repos/ithinker1991/ethereumj/comments{/number}","issue_comment_url":"https://api.github.com/repos/ithinker1991/ethereumj/issues/comments{/number}","contents_url":"https://api.github.com/repos/ithinker1991/ethereumj/contents/{+path}","compare_url":"https://api.github.com/repos/ithinker1991/ethereumj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ithinker1991/ethereumj/merges","archive_url":"https://api.github.com/repos/ithinker1991/ethereumj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ithinker1991/ethereumj/downloads","issues_url":"https://api.github.com/repos/ithinker1991/ethereumj/issues{/number}","pulls_url":"https://api.github.com/repos/ithinker1991/ethereumj/pulls{/number}","milestones_url":"https://api.github.com/repos/ithinker1991/ethereumj/milestones{/number}","notifications_url":"https://api.github.com/repos/ithinker1991/ethereumj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ithinker1991/ethereumj/labels{/name}","releases_url":"https://api.github.com/repos/ithinker1991/ethereumj/releases{/id}","deployments_url":"https://api.github.com/repos/ithinker1991/ethereumj/deployments","created_at":"2018-08-20T09:52:03Z","updated_at":"2018-08-20T09:52:08Z","pushed_at":"2018-08-20T10:11:08Z","git_url":"git://github.com/ithinker1991/ethereumj.git","ssh_url":"git@github.com:ithinker1991/ethereumj.git","clone_url":"https://github.com/ithinker1991/ethereumj.git","svn_url":"https://github.com/ithinker1991/ethereumj","homepage":"","size":47061,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"ec3ce8fccb75987f101096c61af137c4f5b17adb","user":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":19730456,"node_id":"MDEwOlJlcG9zaXRvcnkxOTczMDQ1Ng==","name":"ethereumj","full_name":"ethereum/ethereumj","owner":{"login":"ethereum","id":6250754,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNTA3NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/ethereumj","description":"Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony","fork":false,"url":"https://api.github.com/repos/ethereum/ethereumj","forks_url":"https://api.github.com/repos/ethereum/ethereumj/forks","keys_url":"https://api.github.com/repos/ethereum/ethereumj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/ethereumj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/ethereumj/teams","hooks_url":"https://api.github.com/repos/ethereum/ethereumj/hooks","issue_events_url":"https://api.github.com/repos/ethereum/ethereumj/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/ethereumj/events","assignees_url":"https://api.github.com/repos/ethereum/ethereumj/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/ethereumj/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/ethereumj/tags","blobs_url":"https://api.github.com/repos/ethereum/ethereumj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/ethereumj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/ethereumj/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/ethereumj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/ethereumj/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/ethereumj/languages","stargazers_url":"https://api.github.com/repos/ethereum/ethereumj/stargazers","contributors_url":"https://api.github.com/repos/ethereum/ethereumj/contributors","subscribers_url":"https://api.github.com/repos/ethereum/ethereumj/subscribers","subscription_url":"https://api.github.com/repos/ethereum/ethereumj/subscription","commits_url":"https://api.github.com/repos/ethereum/ethereumj/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/ethereumj/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/ethereumj/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/ethereumj/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/ethereumj/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/ethereumj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/ethereumj/merges","archive_url":"https://api.github.com/repos/ethereum/ethereumj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/ethereumj/downloads","issues_url":"https://api.github.com/repos/ethereum/ethereumj/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/ethereumj/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/ethereumj/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/ethereumj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/ethereumj/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/ethereumj/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/ethereumj/deployments","created_at":"2014-05-13T07:50:14Z","updated_at":"2018-08-20T09:47:34Z","pushed_at":"2018-08-20T12:26:21Z","git_url":"git://github.com/ethereum/ethereumj.git","ssh_url":"git@github.com:ethereum/ethereumj.git","clone_url":"https://github.com/ethereum/ethereumj.git","svn_url":"https://github.com/ethereum/ethereumj","homepage":"","size":47065,"stargazers_count":1762,"watchers_count":1762,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":886,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":886,"open_issues":62,"watchers":1762,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1158"},"html":{"href":"https://github.com/ethereum/ethereumj/pull/1158"},"issue":{"href":"https://api.github.com/repos/ethereum/ethereumj/issues/1158"},"comments":{"href":"https://api.github.com/repos/ethereum/ethereumj/issues/1158/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1158/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1158/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/ethereumj/statuses/4f732bef867622e54ee7ff5ac1e68486be504943"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"ithinker1991"}}