{"action":"closed","number":827,"pull_request":{"url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/827","id":214902754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0OTAyNzU0","html_url":"https://github.com/kubeflow/tf-operator/pull/827","diff_url":"https://github.com/kubeflow/tf-operator/pull/827.diff","patch_url":"https://github.com/kubeflow/tf-operator/pull/827.patch","issue_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/827","number":827,"state":"closed","locked":false,"title":"Cleanup unused functions","user":{"login":"johnugeorge","id":2171903,"node_id":"MDQ6VXNlcjIxNzE5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2171903?v=4","gravatar_id":"","url":"https://api.github.com/users/johnugeorge","html_url":"https://github.com/johnugeorge","followers_url":"https://api.github.com/users/johnugeorge/followers","following_url":"https://api.github.com/users/johnugeorge/following{/other_user}","gists_url":"https://api.github.com/users/johnugeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/johnugeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnugeorge/subscriptions","organizations_url":"https://api.github.com/users/johnugeorge/orgs","repos_url":"https://api.github.com/users/johnugeorge/repos","events_url":"https://api.github.com/users/johnugeorge/events{/privacy}","received_events_url":"https://api.github.com/users/johnugeorge/received_events","type":"User","site_admin":false},"body":"The unused functions are removed. K8sutil package must contain only k8s utility functions and has to be independent of tf code. It can be then shared across operators\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/tf-operator/827)\n<!-- Reviewable:end -->\n","created_at":"2018-09-12T09:58:28Z","updated_at":"2018-09-12T11:51:59Z","closed_at":"2018-09-12T11:51:59Z","merged_at":"2018-09-12T11:51:59Z","merge_commit_sha":"b026d2b9873fed7c587c461adbac5dd94e7e1d08","assignee":{"login":"gaocegege","id":5100735,"node_id":"MDQ6VXNlcjUxMDA3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false},"assignees":[{"login":"gaocegege","id":5100735,"node_id":"MDQ6VXNlcjUxMDA3MzU=","avatar_url":"https://avatars3.githubusercontent.com/u/5100735?v=4","gravatar_id":"","url":"https://api.github.com/users/gaocegege","html_url":"https://github.com/gaocegege","followers_url":"https://api.github.com/users/gaocegege/followers","following_url":"https://api.github.com/users/gaocegege/following{/other_user}","gists_url":"https://api.github.com/users/gaocegege/gists{/gist_id}","starred_url":"https://api.github.com/users/gaocegege/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaocegege/subscriptions","organizations_url":"https://api.github.com/users/gaocegege/orgs","repos_url":"https://api.github.com/users/gaocegege/repos","events_url":"https://api.github.com/users/gaocegege/events{/privacy}","received_events_url":"https://api.github.com/users/gaocegege/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"willb","id":1161,"node_id":"MDQ6VXNlcjExNjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1161?v=4","gravatar_id":"","url":"https://api.github.com/users/willb","html_url":"https://github.com/willb","followers_url":"https://api.github.com/users/willb/followers","following_url":"https://api.github.com/users/willb/following{/other_user}","gists_url":"https://api.github.com/users/willb/gists{/gist_id}","starred_url":"https://api.github.com/users/willb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willb/subscriptions","organizations_url":"https://api.github.com/users/willb/orgs","repos_url":"https://api.github.com/users/willb/repos","events_url":"https://api.github.com/users/willb/events{/privacy}","received_events_url":"https://api.github.com/users/willb/received_events","type":"User","site_admin":false},{"login":"lluunn","id":32310205,"node_id":"MDQ6VXNlcjMyMzEwMjA1","avatar_url":"https://avatars0.githubusercontent.com/u/32310205?v=4","gravatar_id":"","url":"https://api.github.com/users/lluunn","html_url":"https://github.com/lluunn","followers_url":"https://api.github.com/users/lluunn/followers","following_url":"https://api.github.com/users/lluunn/following{/other_user}","gists_url":"https://api.github.com/users/lluunn/gists{/gist_id}","starred_url":"https://api.github.com/users/lluunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lluunn/subscriptions","organizations_url":"https://api.github.com/users/lluunn/orgs","repos_url":"https://api.github.com/users/lluunn/repos","events_url":"https://api.github.com/users/lluunn/events{/privacy}","received_events_url":"https://api.github.com/users/lluunn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":850672456,"node_id":"MDU6TGFiZWw4NTA2NzI0NTY=","url":"https://api.github.com/repos/kubeflow/tf-operator/labels/approved","name":"approved","color":"03db12","default":false},{"id":850672326,"node_id":"MDU6TGFiZWw4NTA2NzIzMjY=","url":"https://api.github.com/repos/kubeflow/tf-operator/labels/lgtm","name":"lgtm","color":"2efca4","default":false},{"id":835722463,"node_id":"MDU6TGFiZWw4MzU3MjI0NjM=","url":"https://api.github.com/repos/kubeflow/tf-operator/labels/size/S","name":"size/S","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/827/commits","review_comments_url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/827/comments","review_comment_url":"https://api.github.com/repos/kubeflow/tf-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/827/comments","statuses_url":"https://api.github.com/repos/kubeflow/tf-operator/statuses/3019b6abed16d532fa7efca99dc032767b1f2fd5","head":{"label":"johnugeorge:cleanup","ref":"cleanup","sha":"3019b6abed16d532fa7efca99dc032767b1f2fd5","user":{"login":"johnugeorge","id":2171903,"node_id":"MDQ6VXNlcjIxNzE5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2171903?v=4","gravatar_id":"","url":"https://api.github.com/users/johnugeorge","html_url":"https://github.com/johnugeorge","followers_url":"https://api.github.com/users/johnugeorge/followers","following_url":"https://api.github.com/users/johnugeorge/following{/other_user}","gists_url":"https://api.github.com/users/johnugeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/johnugeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnugeorge/subscriptions","organizations_url":"https://api.github.com/users/johnugeorge/orgs","repos_url":"https://api.github.com/users/johnugeorge/repos","events_url":"https://api.github.com/users/johnugeorge/events{/privacy}","received_events_url":"https://api.github.com/users/johnugeorge/received_events","type":"User","site_admin":false},"repo":{"id":141103218,"node_id":"MDEwOlJlcG9zaXRvcnkxNDExMDMyMTg=","name":"tf-operator","full_name":"johnugeorge/tf-operator","owner":{"login":"johnugeorge","id":2171903,"node_id":"MDQ6VXNlcjIxNzE5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/2171903?v=4","gravatar_id":"","url":"https://api.github.com/users/johnugeorge","html_url":"https://github.com/johnugeorge","followers_url":"https://api.github.com/users/johnugeorge/followers","following_url":"https://api.github.com/users/johnugeorge/following{/other_user}","gists_url":"https://api.github.com/users/johnugeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/johnugeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnugeorge/subscriptions","organizations_url":"https://api.github.com/users/johnugeorge/orgs","repos_url":"https://api.github.com/users/johnugeorge/repos","events_url":"https://api.github.com/users/johnugeorge/events{/privacy}","received_events_url":"https://api.github.com/users/johnugeorge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnugeorge/tf-operator","description":"Tools for ML/Tensorflow on Kubernetes.","fork":true,"url":"https://api.github.com/repos/johnugeorge/tf-operator","forks_url":"https://api.github.com/repos/johnugeorge/tf-operator/forks","keys_url":"https://api.github.com/repos/johnugeorge/tf-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnugeorge/tf-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnugeorge/tf-operator/teams","hooks_url":"https://api.github.com/repos/johnugeorge/tf-operator/hooks","issue_events_url":"https://api.github.com/repos/johnugeorge/tf-operator/issues/events{/number}","events_url":"https://api.github.com/repos/johnugeorge/tf-operator/events","assignees_url":"https://api.github.com/repos/johnugeorge/tf-operator/assignees{/user}","branches_url":"https://api.github.com/repos/johnugeorge/tf-operator/branches{/branch}","tags_url":"https://api.github.com/repos/johnugeorge/tf-operator/tags","blobs_url":"https://api.github.com/repos/johnugeorge/tf-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnugeorge/tf-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnugeorge/tf-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnugeorge/tf-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnugeorge/tf-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/johnugeorge/tf-operator/languages","stargazers_url":"https://api.github.com/repos/johnugeorge/tf-operator/stargazers","contributors_url":"https://api.github.com/repos/johnugeorge/tf-operator/contributors","subscribers_url":"https://api.github.com/repos/johnugeorge/tf-operator/subscribers","subscription_url":"https://api.github.com/repos/johnugeorge/tf-operator/subscription","commits_url":"https://api.github.com/repos/johnugeorge/tf-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnugeorge/tf-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnugeorge/tf-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnugeorge/tf-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnugeorge/tf-operator/contents/{+path}","compare_url":"https://api.github.com/repos/johnugeorge/tf-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnugeorge/tf-operator/merges","archive_url":"https://api.github.com/repos/johnugeorge/tf-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnugeorge/tf-operator/downloads","issues_url":"https://api.github.com/repos/johnugeorge/tf-operator/issues{/number}","pulls_url":"https://api.github.com/repos/johnugeorge/tf-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/johnugeorge/tf-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/johnugeorge/tf-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnugeorge/tf-operator/labels{/name}","releases_url":"https://api.github.com/repos/johnugeorge/tf-operator/releases{/id}","deployments_url":"https://api.github.com/repos/johnugeorge/tf-operator/deployments","created_at":"2018-07-16T07:36:32Z","updated_at":"2018-07-16T07:36:35Z","pushed_at":"2018-09-12T09:55:16Z","git_url":"git://github.com/johnugeorge/tf-operator.git","ssh_url":"git@github.com:johnugeorge/tf-operator.git","clone_url":"https://github.com/johnugeorge/tf-operator.git","svn_url":"https://github.com/johnugeorge/tf-operator","homepage":null,"size":38533,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"6af59249c2905ed19c3d0d294c129bb1fc08ae3e","user":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":95700338,"node_id":"MDEwOlJlcG9zaXRvcnk5NTcwMDMzOA==","name":"tf-operator","full_name":"kubeflow/tf-operator","owner":{"login":"kubeflow","id":33164907,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTY0OTA3","avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/tf-operator","description":"Tools for ML/Tensorflow on Kubernetes.","fork":false,"url":"https://api.github.com/repos/kubeflow/tf-operator","forks_url":"https://api.github.com/repos/kubeflow/tf-operator/forks","keys_url":"https://api.github.com/repos/kubeflow/tf-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/tf-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/tf-operator/teams","hooks_url":"https://api.github.com/repos/kubeflow/tf-operator/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/tf-operator/events","assignees_url":"https://api.github.com/repos/kubeflow/tf-operator/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/tf-operator/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/tf-operator/tags","blobs_url":"https://api.github.com/repos/kubeflow/tf-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/tf-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/tf-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/tf-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/tf-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/tf-operator/languages","stargazers_url":"https://api.github.com/repos/kubeflow/tf-operator/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/tf-operator/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/tf-operator/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/tf-operator/subscription","commits_url":"https://api.github.com/repos/kubeflow/tf-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/tf-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/tf-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/tf-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/tf-operator/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/tf-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/tf-operator/merges","archive_url":"https://api.github.com/repos/kubeflow/tf-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/tf-operator/downloads","issues_url":"https://api.github.com/repos/kubeflow/tf-operator/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/tf-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/tf-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/tf-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/tf-operator/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/tf-operator/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/tf-operator/deployments","created_at":"2017-06-28T18:38:14Z","updated_at":"2018-09-11T12:40:27Z","pushed_at":"2018-09-12T11:51:59Z","git_url":"git://github.com/kubeflow/tf-operator.git","ssh_url":"git@github.com:kubeflow/tf-operator.git","clone_url":"https://github.com/kubeflow/tf-operator.git","svn_url":"https://github.com/kubeflow/tf-operator","homepage":null,"size":58716,"stargazers_count":537,"watchers_count":537,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":162,"open_issues":62,"watchers":537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/tf-operator/pulls/827"},"html":{"href":"https://github.com/kubeflow/tf-operator/pull/827"},"issue":{"href":"https://api.github.com/repos/kubeflow/tf-operator/issues/827"},"comments":{"href":"https://api.github.com/repos/kubeflow/tf-operator/issues/827/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/tf-operator/pulls/827/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/tf-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/tf-operator/pulls/827/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/tf-operator/statuses/3019b6abed16d532fa7efca99dc032767b1f2fd5"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":19,"changed_files":1}}
{"actor":{"display_login":"k8s-ci-robot"}}