{"action":"created","issue":{"url":"https://api.github.com/repos/badges/shields/issues/1936","repository_url":"https://api.github.com/repos/badges/shields","labels_url":"https://api.github.com/repos/badges/shields/issues/1936/labels{/name}","comments_url":"https://api.github.com/repos/badges/shields/issues/1936/comments","events_url":"https://api.github.com/repos/badges/shields/issues/1936/events","html_url":"https://github.com/badges/shields/pull/1936","id":351736732,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MjU2MzY5","number":1936,"title":"Detect from commit history which service tests to run","user":{"login":"paulmelnikow","id":1487036,"node_id":"MDQ6VXNlcjE0ODcwMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1487036?v=4","gravatar_id":"","url":"https://api.github.com/users/paulmelnikow","html_url":"https://github.com/paulmelnikow","followers_url":"https://api.github.com/users/paulmelnikow/followers","following_url":"https://api.github.com/users/paulmelnikow/following{/other_user}","gists_url":"https://api.github.com/users/paulmelnikow/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmelnikow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmelnikow/subscriptions","organizations_url":"https://api.github.com/users/paulmelnikow/orgs","repos_url":"https://api.github.com/users/paulmelnikow/repos","events_url":"https://api.github.com/users/paulmelnikow/events{/privacy}","received_events_url":"https://api.github.com/users/paulmelnikow/received_events","type":"User","site_admin":false},"labels":[{"id":317278803,"node_id":"MDU6TGFiZWwzMTcyNzg4MDM=","url":"https://api.github.com/repos/badges/shields/labels/developer-experience","name":"developer-experience","color":"5319e7","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-17T20:59:39Z","updated_at":"2018-11-14T23:39:45Z","closed_at":"2018-11-14T23:39:45Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/badges/shields/pulls/1936","html_url":"https://github.com/badges/shields/pull/1936","diff_url":"https://github.com/badges/shields/pull/1936.diff","patch_url":"https://github.com/badges/shields/pull/1936.patch"},"body":"This reworking of the service test detection decouples it from pull requests. It automatically detects which services to run by examining the git working tree and commit history. This is a really nice dev experience. You run `npm run test:services` and it does the right thing. In the rare case where you don't want that, you can pass `-- --all` or `-- --only=`.\r\n\r\nCircleCI seems to clone the entire history and all its branches by default, so I think this will work there, too. 🤞\r\n\r\nService tests can no longer be tagged in the PR title. However, they can be tagged in a commit message. Any tagged services are tested in addition to the auto-detected services. There's a minor tradeoff here in the manual tagging: services can be tagged prior to opening the PR and the PR titles are less cluttered; however, it's necessary to push a commit if you want to test more services.\r\n\r\nThis approach is way more reliable and much simpler: a net deletion of 2 scripts, a temporary file, and 100 lines of code."},"comment":{"url":"https://api.github.com/repos/badges/shields/issues/comments/438860086","html_url":"https://github.com/badges/shields/pull/1936#issuecomment-438860086","issue_url":"https://api.github.com/repos/badges/shields/issues/1936","id":438860086,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODg2MDA4Ng==","user":{"login":"paulmelnikow","id":1487036,"node_id":"MDQ6VXNlcjE0ODcwMzY=","avatar_url":"https://avatars2.githubusercontent.com/u/1487036?v=4","gravatar_id":"","url":"https://api.github.com/users/paulmelnikow","html_url":"https://github.com/paulmelnikow","followers_url":"https://api.github.com/users/paulmelnikow/followers","following_url":"https://api.github.com/users/paulmelnikow/following{/other_user}","gists_url":"https://api.github.com/users/paulmelnikow/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmelnikow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmelnikow/subscriptions","organizations_url":"https://api.github.com/users/paulmelnikow/orgs","repos_url":"https://api.github.com/users/paulmelnikow/repos","events_url":"https://api.github.com/users/paulmelnikow/events{/privacy}","received_events_url":"https://api.github.com/users/paulmelnikow/received_events","type":"User","site_admin":false},"created_at":"2018-11-14T23:39:45Z","updated_at":"2018-11-14T23:39:45Z","author_association":"MEMBER","body":"I'm not happy with the current state of affairs, and while there are aspects of this approach I really prefer, it's clear it will need to be rethought through.\r\n\r\nMaybe we should use a bot. Could be in conjunction with CircleCI, another on-demand system, or something like [Drone](https://drone.io/). I'd prefer something on-demand so it doesn't require sysadmin effort or create a knowledge or access bottleneck."}}
{"actor":{"display_login":"paulmelnikow"}}