{"action":"created","issue":{"url":"https://api.github.com/repos/kata-containers/osbuilder/issues/149","repository_url":"https://api.github.com/repos/kata-containers/osbuilder","labels_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/149/labels{/name}","comments_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/149/comments","events_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/149/events","html_url":"https://github.com/kata-containers/osbuilder/pull/149","id":349775926,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3Nzk5ODMx","number":149,"title":"rootfs: Add script for Debian base OS","user":{"login":"mcgrof","id":1037180,"node_id":"MDQ6VXNlcjEwMzcxODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1037180?v=4","gravatar_id":"","url":"https://api.github.com/users/mcgrof","html_url":"https://github.com/mcgrof","followers_url":"https://api.github.com/users/mcgrof/followers","following_url":"https://api.github.com/users/mcgrof/following{/other_user}","gists_url":"https://api.github.com/users/mcgrof/gists{/gist_id}","starred_url":"https://api.github.com/users/mcgrof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcgrof/subscriptions","organizations_url":"https://api.github.com/users/mcgrof/orgs","repos_url":"https://api.github.com/users/mcgrof/repos","events_url":"https://api.github.com/users/mcgrof/events{/privacy}","received_events_url":"https://api.github.com/users/mcgrof/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-12T01:23:38Z","updated_at":"2018-08-13T10:00:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kata-containers/osbuilder/pulls/149","html_url":"https://github.com/kata-containers/osbuilder/pull/149","diff_url":"https://github.com/kata-containers/osbuilder/pull/149.diff","patch_url":"https://github.com/kata-containers/osbuilder/pull/149.patch"},"body":"Add scripts to build a rootfs based on Debian.\r\n\r\nSigned-off-by: Luis Chamberlain <mcgrof@kernel.org>"},"comment":{"url":"https://api.github.com/repos/kata-containers/osbuilder/issues/comments/412468344","html_url":"https://github.com/kata-containers/osbuilder/pull/149#issuecomment-412468344","issue_url":"https://api.github.com/repos/kata-containers/osbuilder/issues/149","id":412468344,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjQ2ODM0NA==","user":{"login":"jodh-intel","id":20315601,"node_id":"MDQ6VXNlcjIwMzE1NjAx","avatar_url":"https://avatars1.githubusercontent.com/u/20315601?v=4","gravatar_id":"","url":"https://api.github.com/users/jodh-intel","html_url":"https://github.com/jodh-intel","followers_url":"https://api.github.com/users/jodh-intel/followers","following_url":"https://api.github.com/users/jodh-intel/following{/other_user}","gists_url":"https://api.github.com/users/jodh-intel/gists{/gist_id}","starred_url":"https://api.github.com/users/jodh-intel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodh-intel/subscriptions","organizations_url":"https://api.github.com/users/jodh-intel/orgs","repos_url":"https://api.github.com/users/jodh-intel/repos","events_url":"https://api.github.com/users/jodh-intel/events{/privacy}","received_events_url":"https://api.github.com/users/jodh-intel/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T10:00:20Z","updated_at":"2018-08-13T10:00:20Z","author_association":"CONTRIBUTOR","body":"Hi @mcgrof - thanks for raising!\r\n\r\nWe have a small issue though - @ydjainopensource has raised #144 to support Ubuntu and I think that since Ubuntu+Debian are so similar, it makes sense to land support for both as they should be able to share 99.99% of the config (see https://github.com/kata-containers/osbuilder/pull/144#discussion_r206095779). @ydjainopensource - wdyt?\r\n\r\nOn a general note, you'll see that the CI's have failed. If you look at the Travis log, you'll see that it's failing since our [`checkcommits`](https://github.com/kata-containers/tests/tree/master/cmd/checkcommits) tool is complaining there is no \"`Fixes #XXX`\" comment in you commit, and pointing you to:\r\n\r\n- https://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format\r\n\r\n```\r\nFound 1 commit between commit 5237f1e27b438e6bacb9b026c6d576408f6aaa4b and branch master\r\nERROR: No \"Fixes\" found\r\nERROR: checkcommits failed. See the document below for help on formatting\r\ncommits for the project.\r\n\r\nhttps://github.com/kata-containers/community/blob/master/CONTRIBUTING.md#patch-format\r\n```\r\n\r\nTo resolve this issue, you'd need to tweak your commit to reference a github issue using the magic `Fixes #XXX` comment. Something like the following, rebase and then re-push:\r\n\r\n```\r\nrootfs: Add script for Debian base OS\r\n\r\nAdd scripts to build a rootfs based on Debian.\r\n\r\nFixes #XXX.\r\n\r\nSigned-off-by: Luis Chamberlain <mcgrof@kernel.org>\r\n```\r\n\r\nHowever, we need to resolve the Ubuntu vs. Debian issue first I think :smile:"}}
{"actor":{"display_login":"jodh-intel"}}