{"action":"created","issue":{"url":"https://api.github.com/repos/input-output-hk/rust-cardano/issues/285","repository_url":"https://api.github.com/repos/input-output-hk/rust-cardano","labels_url":"https://api.github.com/repos/input-output-hk/rust-cardano/issues/285/labels{/name}","comments_url":"https://api.github.com/repos/input-output-hk/rust-cardano/issues/285/comments","events_url":"https://api.github.com/repos/input-output-hk/rust-cardano/issues/285/events","html_url":"https://github.com/input-output-hk/rust-cardano/pull/285","id":367431193,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODY5ODM3","number":285,"title":"Adding Storage::load function for fixing issues in cardano-cli","user":{"login":"ilap","id":1113398,"node_id":"MDQ6VXNlcjExMTMzOTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1113398?v=4","gravatar_id":"","url":"https://api.github.com/users/ilap","html_url":"https://github.com/ilap","followers_url":"https://api.github.com/users/ilap/followers","following_url":"https://api.github.com/users/ilap/following{/other_user}","gists_url":"https://api.github.com/users/ilap/gists{/gist_id}","starred_url":"https://api.github.com/users/ilap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ilap/subscriptions","organizations_url":"https://api.github.com/users/ilap/orgs","repos_url":"https://api.github.com/users/ilap/repos","events_url":"https://api.github.com/users/ilap/events{/privacy}","received_events_url":"https://api.github.com/users/ilap/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-06T07:06:33Z","updated_at":"2018-10-10T02:56:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/input-output-hk/rust-cardano/pulls/285","html_url":"https://github.com/input-output-hk/rust-cardano/pull/285","diff_url":"https://github.com/input-output-hk/rust-cardano/pull/285.diff","patch_url":"https://github.com/input-output-hk/rust-cardano/pull/285.patch"},"body":"Cardano-cli has some issues see [#31](https://github.com/input-output-hk/cardano-cli/issues/31).\r\nThis PR and replacing the Storage::init /w the new Storage::load function in the [cardano-cli's Blockchain::load](https://github.com/input-output-hk/cardano-cli/blob/master/src/blockchain/mod.rs#L96), would fix the issues. "},"comment":{"url":"https://api.github.com/repos/input-output-hk/rust-cardano/issues/comments/428421084","html_url":"https://github.com/input-output-hk/rust-cardano/pull/285#issuecomment-428421084","issue_url":"https://api.github.com/repos/input-output-hk/rust-cardano/issues/285","id":428421084,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODQyMTA4NA==","user":{"login":"vincenthz","id":174631,"node_id":"MDQ6VXNlcjE3NDYzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/174631?v=4","gravatar_id":"","url":"https://api.github.com/users/vincenthz","html_url":"https://github.com/vincenthz","followers_url":"https://api.github.com/users/vincenthz/followers","following_url":"https://api.github.com/users/vincenthz/following{/other_user}","gists_url":"https://api.github.com/users/vincenthz/gists{/gist_id}","starred_url":"https://api.github.com/users/vincenthz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincenthz/subscriptions","organizations_url":"https://api.github.com/users/vincenthz/orgs","repos_url":"https://api.github.com/users/vincenthz/repos","events_url":"https://api.github.com/users/vincenthz/events{/privacy}","received_events_url":"https://api.github.com/users/vincenthz/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T02:56:32Z","updated_at":"2018-10-10T02:56:32Z","author_association":"MEMBER","body":"that looks fine in principle, but we need to move carefully between the current api which is overloading initialization and loading for the purpose of making sure we don't accidently use the wrong thing.\r\n\r\nwe really need to keep the current api and put a deprecation on it, and then offer an proper `initialization` that will fail if things already exist and a load that will fail is things not exist."}}
{"actor":{"display_login":"vincenthz"}}