{"action":"created","comment":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/167303454","pull_request_review_id":95511370,"id":167303454,"diff_hunk":"@@ -141,7 +144,10 @@ def self.escape_path(path)\n       #   sub-delims    = \"!\" / \"$\" / \"&\" / \"'\" / \"(\" / \")\"\n       #                 / \"*\" / \"+\" / \",\" / \";\" / \"=\"\n       path = Addressable::URI.encode(path)\n-      path.encode(\"utf-8\").sub(\"#\", \"%23\")\n+      escaped_path = path.encode(\"utf-8\").sub(\"#\", \"%23\")\n+      cache[raw_path] = escaped_path\n+\n+      escaped_path","path":"lib/jekyll/url.rb","position":18,"original_position":18,"commit_id":"9fce28e7087ce00f51cb1a1a94fcd244446e84b6","original_commit_id":"9fce28e7087ce00f51cb1a1a94fcd244446e84b6","user":{"login":"ashmaroli","id":12479464,"avatar_url":"https://avatars0.githubusercontent.com/u/12479464?v=4","gravatar_id":"","url":"https://api.github.com/users/ashmaroli","html_url":"https://github.com/ashmaroli","followers_url":"https://api.github.com/users/ashmaroli/followers","following_url":"https://api.github.com/users/ashmaroli/following{/other_user}","gists_url":"https://api.github.com/users/ashmaroli/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmaroli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmaroli/subscriptions","organizations_url":"https://api.github.com/users/ashmaroli/orgs","repos_url":"https://api.github.com/users/ashmaroli/repos","events_url":"https://api.github.com/users/ashmaroli/events{/privacy}","received_events_url":"https://api.github.com/users/ashmaroli/received_events","type":"User","site_admin":false},"body":"a bit, yes. But I like how DRY it is..\r\njust wasn't sure if that's the approach to take..","created_at":"2018-02-09T18:09:25Z","updated_at":"2018-02-09T18:09:25Z","html_url":"https://github.com/jekyll/jekyll/pull/6763#discussion_r167303454","pull_request_url":"https://api.github.com/repos/jekyll/jekyll/pulls/6763","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments/167303454"},"html":{"href":"https://github.com/jekyll/jekyll/pull/6763#discussion_r167303454"},"pull_request":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/6763"}},"in_reply_to_id":167298913},"pull_request":{"url":"https://api.github.com/repos/jekyll/jekyll/pulls/6763","id":168302088,"html_url":"https://github.com/jekyll/jekyll/pull/6763","diff_url":"https://github.com/jekyll/jekyll/pull/6763.diff","patch_url":"https://github.com/jekyll/jekyll/pull/6763.patch","issue_url":"https://api.github.com/repos/jekyll/jekyll/issues/6763","number":6763,"state":"open","locked":false,"title":"Cache and retrieve escaped path components","user":{"login":"ashmaroli","id":12479464,"avatar_url":"https://avatars0.githubusercontent.com/u/12479464?v=4","gravatar_id":"","url":"https://api.github.com/users/ashmaroli","html_url":"https://github.com/ashmaroli","followers_url":"https://api.github.com/users/ashmaroli/followers","following_url":"https://api.github.com/users/ashmaroli/following{/other_user}","gists_url":"https://api.github.com/users/ashmaroli/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmaroli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmaroli/subscriptions","organizations_url":"https://api.github.com/users/ashmaroli/orgs","repos_url":"https://api.github.com/users/ashmaroli/repos","events_url":"https://api.github.com/users/ashmaroli/events{/privacy}","received_events_url":"https://api.github.com/users/ashmaroli/received_events","type":"User","site_admin":false},"body":"This is to avoid calling `Addressable::URI.encode` on the same path components.\r\n\r\ne.g. `2018-02-09-test-post.md` and `2018-02-08-first-post.md` would send `2018` and `02` twice to be encoded / escaped..\r\n","created_at":"2018-02-09T17:45:45Z","updated_at":"2018-02-09T18:09:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f3e6548602f95fa3993e8d9d70d388a4ed9484c3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jekyll/jekyll/pulls/6763/commits","review_comments_url":"https://api.github.com/repos/jekyll/jekyll/pulls/6763/comments","review_comment_url":"https://api.github.com/repos/jekyll/jekyll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jekyll/jekyll/issues/6763/comments","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/9fce28e7087ce00f51cb1a1a94fcd244446e84b6","head":{"label":"ashmaroli:cache-escaped-urls","ref":"cache-escaped-urls","sha":"9fce28e7087ce00f51cb1a1a94fcd244446e84b6","user":{"login":"ashmaroli","id":12479464,"avatar_url":"https://avatars0.githubusercontent.com/u/12479464?v=4","gravatar_id":"","url":"https://api.github.com/users/ashmaroli","html_url":"https://github.com/ashmaroli","followers_url":"https://api.github.com/users/ashmaroli/followers","following_url":"https://api.github.com/users/ashmaroli/following{/other_user}","gists_url":"https://api.github.com/users/ashmaroli/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmaroli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmaroli/subscriptions","organizations_url":"https://api.github.com/users/ashmaroli/orgs","repos_url":"https://api.github.com/users/ashmaroli/repos","events_url":"https://api.github.com/users/ashmaroli/events{/privacy}","received_events_url":"https://api.github.com/users/ashmaroli/received_events","type":"User","site_admin":false},"repo":{"id":64485558,"name":"jekyll","full_name":"ashmaroli/jekyll","owner":{"login":"ashmaroli","id":12479464,"avatar_url":"https://avatars0.githubusercontent.com/u/12479464?v=4","gravatar_id":"","url":"https://api.github.com/users/ashmaroli","html_url":"https://github.com/ashmaroli","followers_url":"https://api.github.com/users/ashmaroli/followers","following_url":"https://api.github.com/users/ashmaroli/following{/other_user}","gists_url":"https://api.github.com/users/ashmaroli/gists{/gist_id}","starred_url":"https://api.github.com/users/ashmaroli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashmaroli/subscriptions","organizations_url":"https://api.github.com/users/ashmaroli/orgs","repos_url":"https://api.github.com/users/ashmaroli/repos","events_url":"https://api.github.com/users/ashmaroli/events{/privacy}","received_events_url":"https://api.github.com/users/ashmaroli/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ashmaroli/jekyll","description":":globe_with_meridians: Jekyll is a blog-aware, static site generator in Ruby","fork":true,"url":"https://api.github.com/repos/ashmaroli/jekyll","forks_url":"https://api.github.com/repos/ashmaroli/jekyll/forks","keys_url":"https://api.github.com/repos/ashmaroli/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ashmaroli/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ashmaroli/jekyll/teams","hooks_url":"https://api.github.com/repos/ashmaroli/jekyll/hooks","issue_events_url":"https://api.github.com/repos/ashmaroli/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/ashmaroli/jekyll/events","assignees_url":"https://api.github.com/repos/ashmaroli/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/ashmaroli/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/ashmaroli/jekyll/tags","blobs_url":"https://api.github.com/repos/ashmaroli/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ashmaroli/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ashmaroli/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/ashmaroli/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ashmaroli/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/ashmaroli/jekyll/languages","stargazers_url":"https://api.github.com/repos/ashmaroli/jekyll/stargazers","contributors_url":"https://api.github.com/repos/ashmaroli/jekyll/contributors","subscribers_url":"https://api.github.com/repos/ashmaroli/jekyll/subscribers","subscription_url":"https://api.github.com/repos/ashmaroli/jekyll/subscription","commits_url":"https://api.github.com/repos/ashmaroli/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/ashmaroli/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/ashmaroli/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/ashmaroli/jekyll/issues/comments{/number}","contents_url":"https://api.github.com/repos/ashmaroli/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/ashmaroli/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ashmaroli/jekyll/merges","archive_url":"https://api.github.com/repos/ashmaroli/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ashmaroli/jekyll/downloads","issues_url":"https://api.github.com/repos/ashmaroli/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/ashmaroli/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/ashmaroli/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/ashmaroli/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ashmaroli/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/ashmaroli/jekyll/releases{/id}","deployments_url":"https://api.github.com/repos/ashmaroli/jekyll/deployments","created_at":"2016-07-29T14:09:21Z","updated_at":"2016-11-03T19:01:51Z","pushed_at":"2018-02-09T17:41:42Z","git_url":"git://github.com/ashmaroli/jekyll.git","ssh_url":"git@github.com:ashmaroli/jekyll.git","clone_url":"https://github.com/ashmaroli/jekyll.git","svn_url":"https://github.com/ashmaroli/jekyll","homepage":"https://jekyllrb.com","size":14442,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jekyll:master","ref":"master","sha":"0b09c4ad8d790f9ed0fa923b370d907fedd029e1","user":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars0.githubusercontent.com/u/3083652?v=4","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"repo":{"id":65252,"name":"jekyll","full_name":"jekyll/jekyll","owner":{"login":"jekyll","id":3083652,"avatar_url":"https://avatars0.githubusercontent.com/u/3083652?v=4","gravatar_id":"","url":"https://api.github.com/users/jekyll","html_url":"https://github.com/jekyll","followers_url":"https://api.github.com/users/jekyll/followers","following_url":"https://api.github.com/users/jekyll/following{/other_user}","gists_url":"https://api.github.com/users/jekyll/gists{/gist_id}","starred_url":"https://api.github.com/users/jekyll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekyll/subscriptions","organizations_url":"https://api.github.com/users/jekyll/orgs","repos_url":"https://api.github.com/users/jekyll/repos","events_url":"https://api.github.com/users/jekyll/events{/privacy}","received_events_url":"https://api.github.com/users/jekyll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jekyll/jekyll","description":":globe_with_meridians: Jekyll is a blog-aware, static site generator in Ruby","fork":false,"url":"https://api.github.com/repos/jekyll/jekyll","forks_url":"https://api.github.com/repos/jekyll/jekyll/forks","keys_url":"https://api.github.com/repos/jekyll/jekyll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekyll/jekyll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekyll/jekyll/teams","hooks_url":"https://api.github.com/repos/jekyll/jekyll/hooks","issue_events_url":"https://api.github.com/repos/jekyll/jekyll/issues/events{/number}","events_url":"https://api.github.com/repos/jekyll/jekyll/events","assignees_url":"https://api.github.com/repos/jekyll/jekyll/assignees{/user}","branches_url":"https://api.github.com/repos/jekyll/jekyll/branches{/branch}","tags_url":"https://api.github.com/repos/jekyll/jekyll/tags","blobs_url":"https://api.github.com/repos/jekyll/jekyll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekyll/jekyll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekyll/jekyll/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekyll/jekyll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekyll/jekyll/statuses/{sha}","languages_url":"https://api.github.com/repos/jekyll/jekyll/languages","stargazers_url":"https://api.github.com/repos/jekyll/jekyll/stargazers","contributors_url":"https://api.github.com/repos/jekyll/jekyll/contributors","subscribers_url":"https://api.github.com/repos/jekyll/jekyll/subscribers","subscription_url":"https://api.github.com/repos/jekyll/jekyll/subscription","commits_url":"https://api.github.com/repos/jekyll/jekyll/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekyll/jekyll/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekyll/jekyll/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekyll/jekyll/issues/comments{/number}","contents_url":"https://api.github.com/repos/jekyll/jekyll/contents/{+path}","compare_url":"https://api.github.com/repos/jekyll/jekyll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekyll/jekyll/merges","archive_url":"https://api.github.com/repos/jekyll/jekyll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekyll/jekyll/downloads","issues_url":"https://api.github.com/repos/jekyll/jekyll/issues{/number}","pulls_url":"https://api.github.com/repos/jekyll/jekyll/pulls{/number}","milestones_url":"https://api.github.com/repos/jekyll/jekyll/milestones{/number}","notifications_url":"https://api.github.com/repos/jekyll/jekyll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekyll/jekyll/labels{/name}","releases_url":"https://api.github.com/repos/jekyll/jekyll/releases{/id}","deployments_url":"https://api.github.com/repos/jekyll/jekyll/deployments","created_at":"2008-10-20T06:29:03Z","updated_at":"2018-02-09T17:47:43Z","pushed_at":"2018-02-09T17:45:46Z","git_url":"git://github.com/jekyll/jekyll.git","ssh_url":"git@github.com:jekyll/jekyll.git","clone_url":"https://github.com/jekyll/jekyll.git","svn_url":"https://github.com/jekyll/jekyll","homepage":"https://jekyllrb.com","size":14062,"stargazers_count":33155,"watchers_count":33155,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7321,"mirror_url":null,"archived":false,"open_issues_count":145,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":7321,"open_issues":145,"watchers":33155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/6763"},"html":{"href":"https://github.com/jekyll/jekyll/pull/6763"},"issue":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/6763"},"comments":{"href":"https://api.github.com/repos/jekyll/jekyll/issues/6763/comments"},"review_comments":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/6763/comments"},"review_comment":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jekyll/jekyll/pulls/6763/commits"},"statuses":{"href":"https://api.github.com/repos/jekyll/jekyll/statuses/9fce28e7087ce00f51cb1a1a94fcd244446e84b6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ashmaroli"}}