{"action":"created","comment":{"url":"https://api.github.com/repos/delmic/odemis/pulls/comments/206129949","pull_request_review_id":141526836,"id":206129949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjEyOTk0OQ==","diff_hunk":"@@ -669,6 +669,41 @@ def __init__(self, name, detector, dataflow, emitter, analyzer=None, **kwargs):\n \n     # onActive & projection: same as the standard LiveStream\n \n+    # overwrite fct _is_active_setter in _base.py\n+    def _is_active_setter(self, active):\n+        # call fct _is_active_setter in _base.py\n+        active = super(ARSettingsStream, self)._is_active_setter(active)\n+        if active:\n+            self._linkHwAxes()\n+        else:\n+            self._unlinkHwAxes()\n+        return active\n+\n+    def _linkHwAxes(self):\n+        \"\"\"\"subscribe polarization VA: link VA to hardware axis\"\"\"\n+        try:\n+            logging.debug(\"Moving polarization analyzer to position %s.\", self.polarization.value)\n+            f = self.analyzer.moveAbs({\"pol\": self.polarization.value})\n+            f.result()\n+        except Exception:\n+            logging.exception(\"Failed to move polarization analyzer.\")\n+        self.polarization.subscribe(self._onPolarization)","path":"src/odemis/acq/stream/_helper.py","position":22,"original_position":22,"commit_id":"bda85dbe488294abc0b78dc02b5abbcc784bd8d2","original_commit_id":"bda85dbe488294abc0b78dc02b5abbcc784bd8d2","user":{"login":"pieleric","id":99444,"node_id":"MDQ6VXNlcjk5NDQ0","avatar_url":"https://avatars3.githubusercontent.com/u/99444?v=4","gravatar_id":"","url":"https://api.github.com/users/pieleric","html_url":"https://github.com/pieleric","followers_url":"https://api.github.com/users/pieleric/followers","following_url":"https://api.github.com/users/pieleric/following{/other_user}","gists_url":"https://api.github.com/users/pieleric/gists{/gist_id}","starred_url":"https://api.github.com/users/pieleric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pieleric/subscriptions","organizations_url":"https://api.github.com/users/pieleric/orgs","repos_url":"https://api.github.com/users/pieleric/repos","events_url":"https://api.github.com/users/pieleric/events{/privacy}","received_events_url":"https://api.github.com/users/pieleric/received_events","type":"User","site_admin":false},"body":"You could add a note/TODO that ideally, it would also listen to the `analyzer.position`, and update the `polarization` VA whenever the axis has moved.","created_at":"2018-07-30T13:22:04Z","updated_at":"2018-07-30T13:33:24Z","html_url":"https://github.com/delmic/odemis/pull/635#discussion_r206129949","pull_request_url":"https://api.github.com/repos/delmic/odemis/pulls/635","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/delmic/odemis/pulls/comments/206129949"},"html":{"href":"https://github.com/delmic/odemis/pull/635#discussion_r206129949"},"pull_request":{"href":"https://api.github.com/repos/delmic/odemis/pulls/635"}}},"pull_request":{"url":"https://api.github.com/repos/delmic/odemis/pulls/635","id":204142694,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTQyNjk0","html_url":"https://github.com/delmic/odemis/pull/635","diff_url":"https://github.com/delmic/odemis/pull/635.diff","patch_url":"https://github.com/delmic/odemis/pull/635.patch","issue_url":"https://api.github.com/repos/delmic/odemis/issues/635","number":635,"state":"open","locked":false,"title":"Polarimetry: live stream","user":{"login":"Sabrina85","id":16820066,"node_id":"MDQ6VXNlcjE2ODIwMDY2","avatar_url":"https://avatars3.githubusercontent.com/u/16820066?v=4","gravatar_id":"","url":"https://api.github.com/users/Sabrina85","html_url":"https://github.com/Sabrina85","followers_url":"https://api.github.com/users/Sabrina85/followers","following_url":"https://api.github.com/users/Sabrina85/following{/other_user}","gists_url":"https://api.github.com/users/Sabrina85/gists{/gist_id}","starred_url":"https://api.github.com/users/Sabrina85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sabrina85/subscriptions","organizations_url":"https://api.github.com/users/Sabrina85/orgs","repos_url":"https://api.github.com/users/Sabrina85/repos","events_url":"https://api.github.com/users/Sabrina85/events{/privacy}","received_events_url":"https://api.github.com/users/Sabrina85/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-07-26T13:29:47Z","updated_at":"2018-07-30T13:33:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b291d5d4072ecccb98b43e732aaf8f841728400e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/delmic/odemis/pulls/635/commits","review_comments_url":"https://api.github.com/repos/delmic/odemis/pulls/635/comments","review_comment_url":"https://api.github.com/repos/delmic/odemis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/delmic/odemis/issues/635/comments","statuses_url":"https://api.github.com/repos/delmic/odemis/statuses/bda85dbe488294abc0b78dc02b5abbcc784bd8d2","head":{"label":"Sabrina85:polarimetry-live-stream","ref":"polarimetry-live-stream","sha":"bda85dbe488294abc0b78dc02b5abbcc784bd8d2","user":{"login":"Sabrina85","id":16820066,"node_id":"MDQ6VXNlcjE2ODIwMDY2","avatar_url":"https://avatars3.githubusercontent.com/u/16820066?v=4","gravatar_id":"","url":"https://api.github.com/users/Sabrina85","html_url":"https://github.com/Sabrina85","followers_url":"https://api.github.com/users/Sabrina85/followers","following_url":"https://api.github.com/users/Sabrina85/following{/other_user}","gists_url":"https://api.github.com/users/Sabrina85/gists{/gist_id}","starred_url":"https://api.github.com/users/Sabrina85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sabrina85/subscriptions","organizations_url":"https://api.github.com/users/Sabrina85/orgs","repos_url":"https://api.github.com/users/Sabrina85/repos","events_url":"https://api.github.com/users/Sabrina85/events{/privacy}","received_events_url":"https://api.github.com/users/Sabrina85/received_events","type":"User","site_admin":false},"repo":{"id":128922836,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg5MjI4MzY=","name":"odemis","full_name":"Sabrina85/odemis","owner":{"login":"Sabrina85","id":16820066,"node_id":"MDQ6VXNlcjE2ODIwMDY2","avatar_url":"https://avatars3.githubusercontent.com/u/16820066?v=4","gravatar_id":"","url":"https://api.github.com/users/Sabrina85","html_url":"https://github.com/Sabrina85","followers_url":"https://api.github.com/users/Sabrina85/followers","following_url":"https://api.github.com/users/Sabrina85/following{/other_user}","gists_url":"https://api.github.com/users/Sabrina85/gists{/gist_id}","starred_url":"https://api.github.com/users/Sabrina85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sabrina85/subscriptions","organizations_url":"https://api.github.com/users/Sabrina85/orgs","repos_url":"https://api.github.com/users/Sabrina85/repos","events_url":"https://api.github.com/users/Sabrina85/events{/privacy}","received_events_url":"https://api.github.com/users/Sabrina85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sabrina85/odemis","description":"Open Delmic Microscope Software","fork":true,"url":"https://api.github.com/repos/Sabrina85/odemis","forks_url":"https://api.github.com/repos/Sabrina85/odemis/forks","keys_url":"https://api.github.com/repos/Sabrina85/odemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sabrina85/odemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sabrina85/odemis/teams","hooks_url":"https://api.github.com/repos/Sabrina85/odemis/hooks","issue_events_url":"https://api.github.com/repos/Sabrina85/odemis/issues/events{/number}","events_url":"https://api.github.com/repos/Sabrina85/odemis/events","assignees_url":"https://api.github.com/repos/Sabrina85/odemis/assignees{/user}","branches_url":"https://api.github.com/repos/Sabrina85/odemis/branches{/branch}","tags_url":"https://api.github.com/repos/Sabrina85/odemis/tags","blobs_url":"https://api.github.com/repos/Sabrina85/odemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sabrina85/odemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sabrina85/odemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sabrina85/odemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sabrina85/odemis/statuses/{sha}","languages_url":"https://api.github.com/repos/Sabrina85/odemis/languages","stargazers_url":"https://api.github.com/repos/Sabrina85/odemis/stargazers","contributors_url":"https://api.github.com/repos/Sabrina85/odemis/contributors","subscribers_url":"https://api.github.com/repos/Sabrina85/odemis/subscribers","subscription_url":"https://api.github.com/repos/Sabrina85/odemis/subscription","commits_url":"https://api.github.com/repos/Sabrina85/odemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sabrina85/odemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sabrina85/odemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sabrina85/odemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sabrina85/odemis/contents/{+path}","compare_url":"https://api.github.com/repos/Sabrina85/odemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sabrina85/odemis/merges","archive_url":"https://api.github.com/repos/Sabrina85/odemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sabrina85/odemis/downloads","issues_url":"https://api.github.com/repos/Sabrina85/odemis/issues{/number}","pulls_url":"https://api.github.com/repos/Sabrina85/odemis/pulls{/number}","milestones_url":"https://api.github.com/repos/Sabrina85/odemis/milestones{/number}","notifications_url":"https://api.github.com/repos/Sabrina85/odemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sabrina85/odemis/labels{/name}","releases_url":"https://api.github.com/repos/Sabrina85/odemis/releases{/id}","deployments_url":"https://api.github.com/repos/Sabrina85/odemis/deployments","created_at":"2018-04-10T11:35:32Z","updated_at":"2018-07-23T08:52:45Z","pushed_at":"2018-07-26T14:47:08Z","git_url":"git://github.com/Sabrina85/odemis.git","ssh_url":"git@github.com:Sabrina85/odemis.git","clone_url":"https://github.com/Sabrina85/odemis.git","svn_url":"https://github.com/Sabrina85/odemis","homepage":null,"size":189191,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"delmic:master","ref":"master","sha":"2c7a26e1c1731a92003569d57a194a77f8bbb892","user":{"login":"delmic","id":1955637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTU2Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1955637?v=4","gravatar_id":"","url":"https://api.github.com/users/delmic","html_url":"https://github.com/delmic","followers_url":"https://api.github.com/users/delmic/followers","following_url":"https://api.github.com/users/delmic/following{/other_user}","gists_url":"https://api.github.com/users/delmic/gists{/gist_id}","starred_url":"https://api.github.com/users/delmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delmic/subscriptions","organizations_url":"https://api.github.com/users/delmic/orgs","repos_url":"https://api.github.com/users/delmic/repos","events_url":"https://api.github.com/users/delmic/events{/privacy}","received_events_url":"https://api.github.com/users/delmic/received_events","type":"Organization","site_admin":false},"repo":{"id":4987197,"node_id":"MDEwOlJlcG9zaXRvcnk0OTg3MTk3","name":"odemis","full_name":"delmic/odemis","owner":{"login":"delmic","id":1955637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NTU2Mzc=","avatar_url":"https://avatars2.githubusercontent.com/u/1955637?v=4","gravatar_id":"","url":"https://api.github.com/users/delmic","html_url":"https://github.com/delmic","followers_url":"https://api.github.com/users/delmic/followers","following_url":"https://api.github.com/users/delmic/following{/other_user}","gists_url":"https://api.github.com/users/delmic/gists{/gist_id}","starred_url":"https://api.github.com/users/delmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delmic/subscriptions","organizations_url":"https://api.github.com/users/delmic/orgs","repos_url":"https://api.github.com/users/delmic/repos","events_url":"https://api.github.com/users/delmic/events{/privacy}","received_events_url":"https://api.github.com/users/delmic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/delmic/odemis","description":"Open Delmic Microscope Software","fork":false,"url":"https://api.github.com/repos/delmic/odemis","forks_url":"https://api.github.com/repos/delmic/odemis/forks","keys_url":"https://api.github.com/repos/delmic/odemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delmic/odemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delmic/odemis/teams","hooks_url":"https://api.github.com/repos/delmic/odemis/hooks","issue_events_url":"https://api.github.com/repos/delmic/odemis/issues/events{/number}","events_url":"https://api.github.com/repos/delmic/odemis/events","assignees_url":"https://api.github.com/repos/delmic/odemis/assignees{/user}","branches_url":"https://api.github.com/repos/delmic/odemis/branches{/branch}","tags_url":"https://api.github.com/repos/delmic/odemis/tags","blobs_url":"https://api.github.com/repos/delmic/odemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delmic/odemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delmic/odemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/delmic/odemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delmic/odemis/statuses/{sha}","languages_url":"https://api.github.com/repos/delmic/odemis/languages","stargazers_url":"https://api.github.com/repos/delmic/odemis/stargazers","contributors_url":"https://api.github.com/repos/delmic/odemis/contributors","subscribers_url":"https://api.github.com/repos/delmic/odemis/subscribers","subscription_url":"https://api.github.com/repos/delmic/odemis/subscription","commits_url":"https://api.github.com/repos/delmic/odemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/delmic/odemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/delmic/odemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/delmic/odemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/delmic/odemis/contents/{+path}","compare_url":"https://api.github.com/repos/delmic/odemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delmic/odemis/merges","archive_url":"https://api.github.com/repos/delmic/odemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delmic/odemis/downloads","issues_url":"https://api.github.com/repos/delmic/odemis/issues{/number}","pulls_url":"https://api.github.com/repos/delmic/odemis/pulls{/number}","milestones_url":"https://api.github.com/repos/delmic/odemis/milestones{/number}","notifications_url":"https://api.github.com/repos/delmic/odemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delmic/odemis/labels{/name}","releases_url":"https://api.github.com/repos/delmic/odemis/releases{/id}","deployments_url":"https://api.github.com/repos/delmic/odemis/deployments","created_at":"2012-07-11T09:49:00Z","updated_at":"2018-07-30T13:14:27Z","pushed_at":"2018-07-30T13:14:25Z","git_url":"git://github.com/delmic/odemis.git","ssh_url":"git@github.com:delmic/odemis.git","clone_url":"https://github.com/delmic/odemis.git","svn_url":"https://github.com/delmic/odemis","homepage":null,"size":189202,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":14,"open_issues":25,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/delmic/odemis/pulls/635"},"html":{"href":"https://github.com/delmic/odemis/pull/635"},"issue":{"href":"https://api.github.com/repos/delmic/odemis/issues/635"},"comments":{"href":"https://api.github.com/repos/delmic/odemis/issues/635/comments"},"review_comments":{"href":"https://api.github.com/repos/delmic/odemis/pulls/635/comments"},"review_comment":{"href":"https://api.github.com/repos/delmic/odemis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/delmic/odemis/pulls/635/commits"},"statuses":{"href":"https://api.github.com/repos/delmic/odemis/statuses/bda85dbe488294abc0b78dc02b5abbcc784bd8d2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pieleric"}}