{"action":"created","comment":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/235818237","pull_request_review_id":177773656,"id":235818237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTgxODIzNw==","diff_hunk":"@@ -73,7 +74,7 @@ _macosx_nodejs_template: &_macosx_nodejs_template\n   rust: nightly\n \n _to_deploy_template: &_to_deploy_template\n-  if: tag =~ /^v\\d+\\.\\d+\\.\\d+/\n+  if: tag =~ /^holochain-nodejs\\d+\\.\\d+\\.\\d+/","path":".travis.yml","position":13,"original_position":13,"commit_id":"945fd9975eba9f93f3e3f89514f19f24768a1e72","original_commit_id":"945fd9975eba9f93f3e3f89514f19f24768a1e72","user":{"login":"maackle","id":896230,"node_id":"MDQ6VXNlcjg5NjIzMA==","avatar_url":"https://avatars0.githubusercontent.com/u/896230?v=4","gravatar_id":"","url":"https://api.github.com/users/maackle","html_url":"https://github.com/maackle","followers_url":"https://api.github.com/users/maackle/followers","following_url":"https://api.github.com/users/maackle/following{/other_user}","gists_url":"https://api.github.com/users/maackle/gists{/gist_id}","starred_url":"https://api.github.com/users/maackle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maackle/subscriptions","organizations_url":"https://api.github.com/users/maackle/orgs","repos_url":"https://api.github.com/users/maackle/repos","events_url":"https://api.github.com/users/maackle/events{/privacy}","received_events_url":"https://api.github.com/users/maackle/received_events","type":"User","site_admin":false},"body":"Might be nice to have a dash if possible or even a dash-vee: \r\n`holochain-nodejs-1.2.3` or\r\n`holochain-nodejs-v1.2.3`","created_at":"2018-11-22T21:03:59Z","updated_at":"2018-11-22T21:06:40Z","html_url":"https://github.com/holochain/holochain-rust/pull/663#discussion_r235818237","pull_request_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/663","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments/235818237"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/663#discussion_r235818237"},"pull_request":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/663"}}},"pull_request":{"url":"https://api.github.com/repos/holochain/holochain-rust/pulls/663","id":233011864,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDExODY0","html_url":"https://github.com/holochain/holochain-rust/pull/663","diff_url":"https://github.com/holochain/holochain-rust/pull/663.diff","patch_url":"https://github.com/holochain/holochain-rust/pull/663.patch","issue_url":"https://api.github.com/repos/holochain/holochain-rust/issues/663","number":663,"state":"open","locked":false,"title":"Setup for holochain-nodejs deploys","user":{"login":"Connoropolous","id":1409121,"node_id":"MDQ6VXNlcjE0MDkxMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1409121?v=4","gravatar_id":"","url":"https://api.github.com/users/Connoropolous","html_url":"https://github.com/Connoropolous","followers_url":"https://api.github.com/users/Connoropolous/followers","following_url":"https://api.github.com/users/Connoropolous/following{/other_user}","gists_url":"https://api.github.com/users/Connoropolous/gists{/gist_id}","starred_url":"https://api.github.com/users/Connoropolous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connoropolous/subscriptions","organizations_url":"https://api.github.com/users/Connoropolous/orgs","repos_url":"https://api.github.com/users/Connoropolous/repos","events_url":"https://api.github.com/users/Connoropolous/events{/privacy}","received_events_url":"https://api.github.com/users/Connoropolous/received_events","type":"User","site_admin":false},"body":"What this does, and how to use it:\r\n\r\nWe need a way to upload binary releases of holochain-nodejs to this github repo.\r\nSo we use travis automation. These changes are required to make it work for macos, linux, and windows.\r\nThere are instructions in the nodejs_container README for how to perform a release. It involves tagging a commit on `develop` or `master` with a tag of the format `holochain-nodejsY.Y.Y` where Y.Y.Y matches the version number in `nodejs_container/package.json` (which should first have been modified using `npm version [type]`\r\n\r\nThis will cause travis to upload binary files for use by npm packages here\r\nhttps://github.com/holochain/holochain-rust/releases\r\n\r\nthis goes with the remote package name in package.json\r\nhttps://github.com/holochain/holochain-rust/blob/holochain-nodejs0.1.22/nodejs_container/package.json#L38","created_at":"2018-11-22T15:15:44Z","updated_at":"2018-11-22T21:06:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66e2f5ee63d95ecf9634e9ec8669d3d7522843c3","assignee":{"login":"Connoropolous","id":1409121,"node_id":"MDQ6VXNlcjE0MDkxMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1409121?v=4","gravatar_id":"","url":"https://api.github.com/users/Connoropolous","html_url":"https://github.com/Connoropolous","followers_url":"https://api.github.com/users/Connoropolous/followers","following_url":"https://api.github.com/users/Connoropolous/following{/other_user}","gists_url":"https://api.github.com/users/Connoropolous/gists{/gist_id}","starred_url":"https://api.github.com/users/Connoropolous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connoropolous/subscriptions","organizations_url":"https://api.github.com/users/Connoropolous/orgs","repos_url":"https://api.github.com/users/Connoropolous/repos","events_url":"https://api.github.com/users/Connoropolous/events{/privacy}","received_events_url":"https://api.github.com/users/Connoropolous/received_events","type":"User","site_admin":false},"assignees":[{"login":"Connoropolous","id":1409121,"node_id":"MDQ6VXNlcjE0MDkxMjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1409121?v=4","gravatar_id":"","url":"https://api.github.com/users/Connoropolous","html_url":"https://github.com/Connoropolous","followers_url":"https://api.github.com/users/Connoropolous/followers","following_url":"https://api.github.com/users/Connoropolous/following{/other_user}","gists_url":"https://api.github.com/users/Connoropolous/gists{/gist_id}","starred_url":"https://api.github.com/users/Connoropolous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Connoropolous/subscriptions","organizations_url":"https://api.github.com/users/Connoropolous/orgs","repos_url":"https://api.github.com/users/Connoropolous/repos","events_url":"https://api.github.com/users/Connoropolous/events{/privacy}","received_events_url":"https://api.github.com/users/Connoropolous/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"lucksus","id":311749,"node_id":"MDQ6VXNlcjMxMTc0OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/311749?v=4","gravatar_id":"","url":"https://api.github.com/users/lucksus","html_url":"https://github.com/lucksus","followers_url":"https://api.github.com/users/lucksus/followers","following_url":"https://api.github.com/users/lucksus/following{/other_user}","gists_url":"https://api.github.com/users/lucksus/gists{/gist_id}","starred_url":"https://api.github.com/users/lucksus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucksus/subscriptions","organizations_url":"https://api.github.com/users/lucksus/orgs","repos_url":"https://api.github.com/users/lucksus/repos","events_url":"https://api.github.com/users/lucksus/events{/privacy}","received_events_url":"https://api.github.com/users/lucksus/received_events","type":"User","site_admin":false},{"login":"sphinxc0re","id":3702016,"node_id":"MDQ6VXNlcjM3MDIwMTY=","avatar_url":"https://avatars3.githubusercontent.com/u/3702016?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinxc0re","html_url":"https://github.com/sphinxc0re","followers_url":"https://api.github.com/users/sphinxc0re/followers","following_url":"https://api.github.com/users/sphinxc0re/following{/other_user}","gists_url":"https://api.github.com/users/sphinxc0re/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinxc0re/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinxc0re/subscriptions","organizations_url":"https://api.github.com/users/sphinxc0re/orgs","repos_url":"https://api.github.com/users/sphinxc0re/repos","events_url":"https://api.github.com/users/sphinxc0re/events{/privacy}","received_events_url":"https://api.github.com/users/sphinxc0re/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":937673517,"node_id":"MDU6TGFiZWw5Mzc2NzM1MTc=","url":"https://api.github.com/repos/holochain/holochain-rust/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/663/commits","review_comments_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/663/comments","review_comment_url":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/issues/663/comments","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/945fd9975eba9f93f3e3f89514f19f24768a1e72","head":{"label":"holochain:change-tag-pattern","ref":"change-tag-pattern","sha":"945fd9975eba9f93f3e3f89514f19f24768a1e72","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"The core Holochain framework written in Rust, a container API for that, and hdk-rust library for Zomes","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2018-11-22T14:43:41Z","pushed_at":"2018-11-22T20:44:19Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":"","size":168458,"stargazers_count":204,"watchers_count":204,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":39,"open_issues":195,"watchers":204,"default_branch":"develop"}},"base":{"label":"holochain:develop","ref":"develop","sha":"11e00ceea0eb1985ce7e823c93982a02baa5ad83","user":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"repo":{"id":133449383,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0NDkzODM=","name":"holochain-rust","full_name":"holochain/holochain-rust","private":false,"owner":{"login":"holochain","id":29492745,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NDkyNzQ1","avatar_url":"https://avatars2.githubusercontent.com/u/29492745?v=4","gravatar_id":"","url":"https://api.github.com/users/holochain","html_url":"https://github.com/holochain","followers_url":"https://api.github.com/users/holochain/followers","following_url":"https://api.github.com/users/holochain/following{/other_user}","gists_url":"https://api.github.com/users/holochain/gists{/gist_id}","starred_url":"https://api.github.com/users/holochain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holochain/subscriptions","organizations_url":"https://api.github.com/users/holochain/orgs","repos_url":"https://api.github.com/users/holochain/repos","events_url":"https://api.github.com/users/holochain/events{/privacy}","received_events_url":"https://api.github.com/users/holochain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/holochain/holochain-rust","description":"The core Holochain framework written in Rust, a container API for that, and hdk-rust library for Zomes","fork":false,"url":"https://api.github.com/repos/holochain/holochain-rust","forks_url":"https://api.github.com/repos/holochain/holochain-rust/forks","keys_url":"https://api.github.com/repos/holochain/holochain-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/holochain/holochain-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/holochain/holochain-rust/teams","hooks_url":"https://api.github.com/repos/holochain/holochain-rust/hooks","issue_events_url":"https://api.github.com/repos/holochain/holochain-rust/issues/events{/number}","events_url":"https://api.github.com/repos/holochain/holochain-rust/events","assignees_url":"https://api.github.com/repos/holochain/holochain-rust/assignees{/user}","branches_url":"https://api.github.com/repos/holochain/holochain-rust/branches{/branch}","tags_url":"https://api.github.com/repos/holochain/holochain-rust/tags","blobs_url":"https://api.github.com/repos/holochain/holochain-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/holochain/holochain-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/holochain/holochain-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/holochain/holochain-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/holochain/holochain-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/holochain/holochain-rust/languages","stargazers_url":"https://api.github.com/repos/holochain/holochain-rust/stargazers","contributors_url":"https://api.github.com/repos/holochain/holochain-rust/contributors","subscribers_url":"https://api.github.com/repos/holochain/holochain-rust/subscribers","subscription_url":"https://api.github.com/repos/holochain/holochain-rust/subscription","commits_url":"https://api.github.com/repos/holochain/holochain-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/holochain/holochain-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/holochain/holochain-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/holochain/holochain-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/holochain/holochain-rust/contents/{+path}","compare_url":"https://api.github.com/repos/holochain/holochain-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/holochain/holochain-rust/merges","archive_url":"https://api.github.com/repos/holochain/holochain-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/holochain/holochain-rust/downloads","issues_url":"https://api.github.com/repos/holochain/holochain-rust/issues{/number}","pulls_url":"https://api.github.com/repos/holochain/holochain-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/holochain/holochain-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/holochain/holochain-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/holochain/holochain-rust/labels{/name}","releases_url":"https://api.github.com/repos/holochain/holochain-rust/releases{/id}","deployments_url":"https://api.github.com/repos/holochain/holochain-rust/deployments","created_at":"2018-05-15T02:42:12Z","updated_at":"2018-11-22T14:43:41Z","pushed_at":"2018-11-22T20:44:19Z","git_url":"git://github.com/holochain/holochain-rust.git","ssh_url":"git@github.com:holochain/holochain-rust.git","clone_url":"https://github.com/holochain/holochain-rust.git","svn_url":"https://github.com/holochain/holochain-rust","homepage":"","size":168458,"stargazers_count":204,"watchers_count":204,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":39,"open_issues":195,"watchers":204,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/663"},"html":{"href":"https://github.com/holochain/holochain-rust/pull/663"},"issue":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/663"},"comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/issues/663/comments"},"review_comments":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/663/comments"},"review_comment":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/holochain/holochain-rust/pulls/663/commits"},"statuses":{"href":"https://api.github.com/repos/holochain/holochain-rust/statuses/945fd9975eba9f93f3e3f89514f19f24768a1e72"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maackle"}}