{"action":"created","issue":{"url":"https://api.github.com/repos/locusrobotics/catkin_virtualenv/issues/13","repository_url":"https://api.github.com/repos/locusrobotics/catkin_virtualenv","labels_url":"https://api.github.com/repos/locusrobotics/catkin_virtualenv/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/locusrobotics/catkin_virtualenv/issues/13/comments","events_url":"https://api.github.com/repos/locusrobotics/catkin_virtualenv/issues/13/events","html_url":"https://github.com/locusrobotics/catkin_virtualenv/pull/13","id":318652598,"number":13,"title":"Skip combining requirements files","user":{"login":"wkentaro","id":4310419,"avatar_url":"https://avatars2.githubusercontent.com/u/4310419?v=4","gravatar_id":"","url":"https://api.github.com/users/wkentaro","html_url":"https://github.com/wkentaro","followers_url":"https://api.github.com/users/wkentaro/followers","following_url":"https://api.github.com/users/wkentaro/following{/other_user}","gists_url":"https://api.github.com/users/wkentaro/gists{/gist_id}","starred_url":"https://api.github.com/users/wkentaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wkentaro/subscriptions","organizations_url":"https://api.github.com/users/wkentaro/orgs","repos_url":"https://api.github.com/users/wkentaro/repos","events_url":"https://api.github.com/users/wkentaro/events{/privacy}","received_events_url":"https://api.github.com/users/wkentaro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-28T17:03:19Z","updated_at":"2018-05-01T19:31:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/locusrobotics/catkin_virtualenv/pulls/13","html_url":"https://github.com/locusrobotics/catkin_virtualenv/pull/13","diff_url":"https://github.com/locusrobotics/catkin_virtualenv/pull/13.diff","patch_url":"https://github.com/locusrobotics/catkin_virtualenv/pull/13.patch"},"body":"Related to #12 \r\n\r\n## Why?\r\n\r\nIt is difficult to merge 2 requirements files if they have complex version specification or pip options.\r\nSo skipping the merge seems a good idea if we have only one requirements file."},"comment":{"url":"https://api.github.com/repos/locusrobotics/catkin_virtualenv/issues/comments/385765722","html_url":"https://github.com/locusrobotics/catkin_virtualenv/pull/13#issuecomment-385765722","issue_url":"https://api.github.com/repos/locusrobotics/catkin_virtualenv/issues/13","id":385765722,"user":{"login":"paulbovbel","id":1694370,"avatar_url":"https://avatars0.githubusercontent.com/u/1694370?v=4","gravatar_id":"","url":"https://api.github.com/users/paulbovbel","html_url":"https://github.com/paulbovbel","followers_url":"https://api.github.com/users/paulbovbel/followers","following_url":"https://api.github.com/users/paulbovbel/following{/other_user}","gists_url":"https://api.github.com/users/paulbovbel/gists{/gist_id}","starred_url":"https://api.github.com/users/paulbovbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulbovbel/subscriptions","organizations_url":"https://api.github.com/users/paulbovbel/orgs","repos_url":"https://api.github.com/users/paulbovbel/repos","events_url":"https://api.github.com/users/paulbovbel/events{/privacy}","received_events_url":"https://api.github.com/users/paulbovbel/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T19:31:22Z","updated_at":"2018-05-01T19:31:22Z","author_association":"MEMBER","body":"I see what you're doing, but it feels a bit magical since it would break as soon as a package listing non-compliant requirements is included as a dependency by any other package.\r\n\r\nI would be much more comfortable with an option such as `catkin_generate_virtualenv(NO_DEPENDENT_REQUIREMENTS)` that would disable dependency globbing at build time entirely."}}
{"actor":{"display_login":"paulbovbel"}}