{"action":"created","comment":{"url":"https://api.github.com/repos/threema-ch/threema-web/pulls/comments/225548147","pull_request_review_id":165165230,"id":225548147,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTU0ODE0Nw==","diff_hunk":"@@ -1120,6 +1126,9 @@ export class WebClientService {\n             this.ackTimer = null;\n         }\n \n+        // Stop other timers\n+        this.timeoutService.cancelAll();","path":"src/services/webclient.ts","position":73,"original_position":73,"commit_id":"26ef2d08510261f6ee8236cb9bf42e9416bf924c","original_commit_id":"26ef2d08510261f6ee8236cb9bf42e9416bf924c","user":{"login":"lgrahl","id":1793755,"node_id":"MDQ6VXNlcjE3OTM3NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1793755?v=4","gravatar_id":"","url":"https://api.github.com/users/lgrahl","html_url":"https://github.com/lgrahl","followers_url":"https://api.github.com/users/lgrahl/followers","following_url":"https://api.github.com/users/lgrahl/following{/other_user}","gists_url":"https://api.github.com/users/lgrahl/gists{/gist_id}","starred_url":"https://api.github.com/users/lgrahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgrahl/subscriptions","organizations_url":"https://api.github.com/users/lgrahl/orgs","repos_url":"https://api.github.com/users/lgrahl/repos","events_url":"https://api.github.com/users/lgrahl/events{/privacy}","received_events_url":"https://api.github.com/users/lgrahl/received_events","type":"User","site_admin":false},"body":"This should only be done in case `close` is `true` (move it down). Furthermore, this also needs to be done when discarding a session after having tried to resume it.\r\n\r\nTL;DR: Move this directly beside calls to `this.wireMessageFutures.clear()`.","created_at":"2018-10-16T13:51:32Z","updated_at":"2018-10-16T13:55:10Z","html_url":"https://github.com/threema-ch/threema-web/pull/620#discussion_r225548147","pull_request_url":"https://api.github.com/repos/threema-ch/threema-web/pulls/620","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/threema-ch/threema-web/pulls/comments/225548147"},"html":{"href":"https://github.com/threema-ch/threema-web/pull/620#discussion_r225548147"},"pull_request":{"href":"https://api.github.com/repos/threema-ch/threema-web/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/threema-ch/threema-web/pulls/620","id":223178648,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMTc4NjQ4","html_url":"https://github.com/threema-ch/threema-web/pull/620","diff_url":"https://github.com/threema-ch/threema-web/pull/620.diff","patch_url":"https://github.com/threema-ch/threema-web/pull/620.patch","issue_url":"https://api.github.com/repos/threema-ch/threema-web/issues/620","number":620,"state":"open","locked":false,"title":"Cancel timeouts on stop","user":{"login":"dbrgn","id":105168,"node_id":"MDQ6VXNlcjEwNTE2OA==","avatar_url":"https://avatars1.githubusercontent.com/u/105168?v=4","gravatar_id":"","url":"https://api.github.com/users/dbrgn","html_url":"https://github.com/dbrgn","followers_url":"https://api.github.com/users/dbrgn/followers","following_url":"https://api.github.com/users/dbrgn/following{/other_user}","gists_url":"https://api.github.com/users/dbrgn/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrgn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrgn/subscriptions","organizations_url":"https://api.github.com/users/dbrgn/orgs","repos_url":"https://api.github.com/users/dbrgn/repos","events_url":"https://api.github.com/users/dbrgn/events{/privacy}","received_events_url":"https://api.github.com/users/dbrgn/received_events","type":"User","site_admin":false},"body":"Fixes #619.","created_at":"2018-10-16T09:34:36Z","updated_at":"2018-10-16T13:55:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea8c82c2b5fa1ad9a1c0ca3afa59e5fadbdb91e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":534968665,"node_id":"MDU6TGFiZWw1MzQ5Njg2NjU=","url":"https://api.github.com/repos/threema-ch/threema-web/labels/bug","name":"bug","color":"ee3f46","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/threema-ch/threema-web/pulls/620/commits","review_comments_url":"https://api.github.com/repos/threema-ch/threema-web/pulls/620/comments","review_comment_url":"https://api.github.com/repos/threema-ch/threema-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/threema-ch/threema-web/issues/620/comments","statuses_url":"https://api.github.com/repos/threema-ch/threema-web/statuses/26ef2d08510261f6ee8236cb9bf42e9416bf924c","head":{"label":"threema-ch:619-timeouts","ref":"619-timeouts","sha":"26ef2d08510261f6ee8236cb9bf42e9416bf924c","user":{"login":"threema-ch","id":11537072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTM3MDcy","avatar_url":"https://avatars3.githubusercontent.com/u/11537072?v=4","gravatar_id":"","url":"https://api.github.com/users/threema-ch","html_url":"https://github.com/threema-ch","followers_url":"https://api.github.com/users/threema-ch/followers","following_url":"https://api.github.com/users/threema-ch/following{/other_user}","gists_url":"https://api.github.com/users/threema-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/threema-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threema-ch/subscriptions","organizations_url":"https://api.github.com/users/threema-ch/orgs","repos_url":"https://api.github.com/users/threema-ch/repos","events_url":"https://api.github.com/users/threema-ch/events{/privacy}","received_events_url":"https://api.github.com/users/threema-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":81329223,"node_id":"MDEwOlJlcG9zaXRvcnk4MTMyOTIyMw==","name":"threema-web","full_name":"threema-ch/threema-web","private":false,"owner":{"login":"threema-ch","id":11537072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTM3MDcy","avatar_url":"https://avatars3.githubusercontent.com/u/11537072?v=4","gravatar_id":"","url":"https://api.github.com/users/threema-ch","html_url":"https://github.com/threema-ch","followers_url":"https://api.github.com/users/threema-ch/followers","following_url":"https://api.github.com/users/threema-ch/following{/other_user}","gists_url":"https://api.github.com/users/threema-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/threema-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threema-ch/subscriptions","organizations_url":"https://api.github.com/users/threema-ch/orgs","repos_url":"https://api.github.com/users/threema-ch/repos","events_url":"https://api.github.com/users/threema-ch/events{/privacy}","received_events_url":"https://api.github.com/users/threema-ch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/threema-ch/threema-web","description":"The Threema Web application.","fork":false,"url":"https://api.github.com/repos/threema-ch/threema-web","forks_url":"https://api.github.com/repos/threema-ch/threema-web/forks","keys_url":"https://api.github.com/repos/threema-ch/threema-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threema-ch/threema-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threema-ch/threema-web/teams","hooks_url":"https://api.github.com/repos/threema-ch/threema-web/hooks","issue_events_url":"https://api.github.com/repos/threema-ch/threema-web/issues/events{/number}","events_url":"https://api.github.com/repos/threema-ch/threema-web/events","assignees_url":"https://api.github.com/repos/threema-ch/threema-web/assignees{/user}","branches_url":"https://api.github.com/repos/threema-ch/threema-web/branches{/branch}","tags_url":"https://api.github.com/repos/threema-ch/threema-web/tags","blobs_url":"https://api.github.com/repos/threema-ch/threema-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threema-ch/threema-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threema-ch/threema-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/threema-ch/threema-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threema-ch/threema-web/statuses/{sha}","languages_url":"https://api.github.com/repos/threema-ch/threema-web/languages","stargazers_url":"https://api.github.com/repos/threema-ch/threema-web/stargazers","contributors_url":"https://api.github.com/repos/threema-ch/threema-web/contributors","subscribers_url":"https://api.github.com/repos/threema-ch/threema-web/subscribers","subscription_url":"https://api.github.com/repos/threema-ch/threema-web/subscription","commits_url":"https://api.github.com/repos/threema-ch/threema-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/threema-ch/threema-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/threema-ch/threema-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/threema-ch/threema-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/threema-ch/threema-web/contents/{+path}","compare_url":"https://api.github.com/repos/threema-ch/threema-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threema-ch/threema-web/merges","archive_url":"https://api.github.com/repos/threema-ch/threema-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threema-ch/threema-web/downloads","issues_url":"https://api.github.com/repos/threema-ch/threema-web/issues{/number}","pulls_url":"https://api.github.com/repos/threema-ch/threema-web/pulls{/number}","milestones_url":"https://api.github.com/repos/threema-ch/threema-web/milestones{/number}","notifications_url":"https://api.github.com/repos/threema-ch/threema-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threema-ch/threema-web/labels{/name}","releases_url":"https://api.github.com/repos/threema-ch/threema-web/releases{/id}","deployments_url":"https://api.github.com/repos/threema-ch/threema-web/deployments","created_at":"2017-02-08T12:46:24Z","updated_at":"2018-10-16T11:52:09Z","pushed_at":"2018-10-16T13:44:39Z","git_url":"git://github.com/threema-ch/threema-web.git","ssh_url":"git@github.com:threema-ch/threema-web.git","clone_url":"https://github.com/threema-ch/threema-web.git","svn_url":"https://github.com/threema-ch/threema-web","homepage":null,"size":25735,"stargazers_count":378,"watchers_count":378,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":141,"watchers":378,"default_branch":"master"}},"base":{"label":"threema-ch:beta","ref":"beta","sha":"3cd8e94f1c76310a062f085f06557affdb9f07de","user":{"login":"threema-ch","id":11537072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTM3MDcy","avatar_url":"https://avatars3.githubusercontent.com/u/11537072?v=4","gravatar_id":"","url":"https://api.github.com/users/threema-ch","html_url":"https://github.com/threema-ch","followers_url":"https://api.github.com/users/threema-ch/followers","following_url":"https://api.github.com/users/threema-ch/following{/other_user}","gists_url":"https://api.github.com/users/threema-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/threema-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threema-ch/subscriptions","organizations_url":"https://api.github.com/users/threema-ch/orgs","repos_url":"https://api.github.com/users/threema-ch/repos","events_url":"https://api.github.com/users/threema-ch/events{/privacy}","received_events_url":"https://api.github.com/users/threema-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":81329223,"node_id":"MDEwOlJlcG9zaXRvcnk4MTMyOTIyMw==","name":"threema-web","full_name":"threema-ch/threema-web","private":false,"owner":{"login":"threema-ch","id":11537072,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTM3MDcy","avatar_url":"https://avatars3.githubusercontent.com/u/11537072?v=4","gravatar_id":"","url":"https://api.github.com/users/threema-ch","html_url":"https://github.com/threema-ch","followers_url":"https://api.github.com/users/threema-ch/followers","following_url":"https://api.github.com/users/threema-ch/following{/other_user}","gists_url":"https://api.github.com/users/threema-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/threema-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threema-ch/subscriptions","organizations_url":"https://api.github.com/users/threema-ch/orgs","repos_url":"https://api.github.com/users/threema-ch/repos","events_url":"https://api.github.com/users/threema-ch/events{/privacy}","received_events_url":"https://api.github.com/users/threema-ch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/threema-ch/threema-web","description":"The Threema Web application.","fork":false,"url":"https://api.github.com/repos/threema-ch/threema-web","forks_url":"https://api.github.com/repos/threema-ch/threema-web/forks","keys_url":"https://api.github.com/repos/threema-ch/threema-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threema-ch/threema-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threema-ch/threema-web/teams","hooks_url":"https://api.github.com/repos/threema-ch/threema-web/hooks","issue_events_url":"https://api.github.com/repos/threema-ch/threema-web/issues/events{/number}","events_url":"https://api.github.com/repos/threema-ch/threema-web/events","assignees_url":"https://api.github.com/repos/threema-ch/threema-web/assignees{/user}","branches_url":"https://api.github.com/repos/threema-ch/threema-web/branches{/branch}","tags_url":"https://api.github.com/repos/threema-ch/threema-web/tags","blobs_url":"https://api.github.com/repos/threema-ch/threema-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threema-ch/threema-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threema-ch/threema-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/threema-ch/threema-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threema-ch/threema-web/statuses/{sha}","languages_url":"https://api.github.com/repos/threema-ch/threema-web/languages","stargazers_url":"https://api.github.com/repos/threema-ch/threema-web/stargazers","contributors_url":"https://api.github.com/repos/threema-ch/threema-web/contributors","subscribers_url":"https://api.github.com/repos/threema-ch/threema-web/subscribers","subscription_url":"https://api.github.com/repos/threema-ch/threema-web/subscription","commits_url":"https://api.github.com/repos/threema-ch/threema-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/threema-ch/threema-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/threema-ch/threema-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/threema-ch/threema-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/threema-ch/threema-web/contents/{+path}","compare_url":"https://api.github.com/repos/threema-ch/threema-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threema-ch/threema-web/merges","archive_url":"https://api.github.com/repos/threema-ch/threema-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threema-ch/threema-web/downloads","issues_url":"https://api.github.com/repos/threema-ch/threema-web/issues{/number}","pulls_url":"https://api.github.com/repos/threema-ch/threema-web/pulls{/number}","milestones_url":"https://api.github.com/repos/threema-ch/threema-web/milestones{/number}","notifications_url":"https://api.github.com/repos/threema-ch/threema-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threema-ch/threema-web/labels{/name}","releases_url":"https://api.github.com/repos/threema-ch/threema-web/releases{/id}","deployments_url":"https://api.github.com/repos/threema-ch/threema-web/deployments","created_at":"2017-02-08T12:46:24Z","updated_at":"2018-10-16T11:52:09Z","pushed_at":"2018-10-16T13:44:39Z","git_url":"git://github.com/threema-ch/threema-web.git","ssh_url":"git@github.com:threema-ch/threema-web.git","clone_url":"https://github.com/threema-ch/threema-web.git","svn_url":"https://github.com/threema-ch/threema-web","homepage":null,"size":25735,"stargazers_count":378,"watchers_count":378,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":141,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":141,"watchers":378,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/threema-ch/threema-web/pulls/620"},"html":{"href":"https://github.com/threema-ch/threema-web/pull/620"},"issue":{"href":"https://api.github.com/repos/threema-ch/threema-web/issues/620"},"comments":{"href":"https://api.github.com/repos/threema-ch/threema-web/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/threema-ch/threema-web/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/threema-ch/threema-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/threema-ch/threema-web/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/threema-ch/threema-web/statuses/26ef2d08510261f6ee8236cb9bf42e9416bf924c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lgrahl"}}