{"action":"created","issue":{"url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/260","repository_url":"https://api.github.com/repos/nodogsplash/nodogsplash","labels_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/260/labels{/name}","comments_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/260/comments","events_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/260/events","html_url":"https://github.com/nodogsplash/nodogsplash/pull/260","id":345310108,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDk2MTQ1","number":260,"title":"binauth feature and other changes","user":{"login":"mwarning","id":546193,"node_id":"MDQ6VXNlcjU0NjE5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/546193?v=4","gravatar_id":"","url":"https://api.github.com/users/mwarning","html_url":"https://github.com/mwarning","followers_url":"https://api.github.com/users/mwarning/followers","following_url":"https://api.github.com/users/mwarning/following{/other_user}","gists_url":"https://api.github.com/users/mwarning/gists{/gist_id}","starred_url":"https://api.github.com/users/mwarning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwarning/subscriptions","organizations_url":"https://api.github.com/users/mwarning/orgs","repos_url":"https://api.github.com/users/mwarning/repos","events_url":"https://api.github.com/users/mwarning/events{/privacy}","received_events_url":"https://api.github.com/users/mwarning/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-07-27T17:41:47Z","updated_at":"2018-08-01T16:14:07Z","closed_at":"2018-07-31T15:28:39Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodogsplash/nodogsplash/pulls/260","html_url":"https://github.com/nodogsplash/nodogsplash/pull/260","diff_url":"https://github.com/nodogsplash/nodogsplash/pull/260.diff","patch_url":"https://github.com/nodogsplash/nodogsplash/pull/260.patch"},"body":"This commit includes the binvoucher feature (#167) including a lot of changes.\r\n\r\nChanges:\r\n- binvoucher code is subsumed by the binauth setting. It can accept username and password instead of a voucher. Just the password or username alone can be used as a replacement for a voucher.\r\n- remove setting clienttimeout and clientforceout\r\n  - added preauth_idle_timeout  and authed_idle_timeout instead\r\n - now we can timeout preauthenticated and authenticated client independently\r\n- <strike>remove unused settings passwordauth, usernameauth, username, password, remoteauthenticatoraction, enablepreauth</strike> (merged into master)\r\n- use new execute and execute_ret methods\r\n- struct client now has a `session_start` and `session_end` fields instead of added_time.\r\n  - default session_end is 0 (no end)\r\n- replace ctime as it is deprecated\r\n- lots of code cleanups\r\n"},"comment":{"url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/comments/409631022","html_url":"https://github.com/nodogsplash/nodogsplash/pull/260#issuecomment-409631022","issue_url":"https://api.github.com/repos/nodogsplash/nodogsplash/issues/260","id":409631022,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTYzMTAyMg==","user":{"login":"mwarning","id":546193,"node_id":"MDQ6VXNlcjU0NjE5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/546193?v=4","gravatar_id":"","url":"https://api.github.com/users/mwarning","html_url":"https://github.com/mwarning","followers_url":"https://api.github.com/users/mwarning/followers","following_url":"https://api.github.com/users/mwarning/following{/other_user}","gists_url":"https://api.github.com/users/mwarning/gists{/gist_id}","starred_url":"https://api.github.com/users/mwarning/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwarning/subscriptions","organizations_url":"https://api.github.com/users/mwarning/orgs","repos_url":"https://api.github.com/users/mwarning/repos","events_url":"https://api.github.com/users/mwarning/events{/privacy}","received_events_url":"https://api.github.com/users/mwarning/received_events","type":"User","site_admin":false},"created_at":"2018-08-01T16:14:07Z","updated_at":"2018-08-01T16:14:07Z","author_association":"MEMBER","body":"@bluewavenet agreed, but the name clientforcetimeout is bugging me. clienttimeout seems to fit the meaning much better."}}
{"actor":{"display_login":"mwarning"}}