{"action":"opened","number":12,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/dp-filter/pulls/12","id":216264904,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MjY0OTA0","html_url":"https://github.com/ONSdigital/dp-filter/pull/12","diff_url":"https://github.com/ONSdigital/dp-filter/pull/12.diff","patch_url":"https://github.com/ONSdigital/dp-filter/pull/12.patch","issue_url":"https://api.github.com/repos/ONSdigital/dp-filter/issues/12","number":12,"state":"open","locked":false,"title":"Update filter query to work with empty dimension submissions","user":{"login":"eldeal","id":7114478,"node_id":"MDQ6VXNlcjcxMTQ0Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7114478?v=4","gravatar_id":"","url":"https://api.github.com/users/eldeal","html_url":"https://github.com/eldeal","followers_url":"https://api.github.com/users/eldeal/followers","following_url":"https://api.github.com/users/eldeal/following{/other_user}","gists_url":"https://api.github.com/users/eldeal/gists{/gist_id}","starred_url":"https://api.github.com/users/eldeal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eldeal/subscriptions","organizations_url":"https://api.github.com/users/eldeal/orgs","repos_url":"https://api.github.com/users/eldeal/repos","events_url":"https://api.github.com/users/eldeal/events{/privacy}","received_events_url":"https://api.github.com/users/eldeal/received_events","type":"User","site_admin":false},"body":"### What\r\n\r\nOnly add commas and multi-dimension filter parts of query when dimensions have definitely been submitted and are not empty\r\n\r\n### How to review\r\n\r\nSubmit a filter with the first dimension empty of optiolns and options in one or several others. Should actually filter rather than throw an error which is current behaviour\r\n\r\n### Who can review\r\n\r\nAnyone","created_at":"2018-09-18T10:53:50Z","updated_at":"2018-09-18T10:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/dp-filter/pulls/12/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/dp-filter/pulls/12/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/dp-filter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/dp-filter/issues/12/comments","statuses_url":"https://api.github.com/repos/ONSdigital/dp-filter/statuses/9030f07058e85c16d8e720feb891da481e8a23cf","head":{"label":"ONSdigital:fix/empty-dims","ref":"fix/empty-dims","sha":"9030f07058e85c16d8e720feb891da481e8a23cf","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":110131699,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxMzE2OTk=","name":"dp-filter","full_name":"ONSdigital/dp-filter","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/dp-filter","description":"A library used to filter ONS datasets using Neo4j","fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-filter","forks_url":"https://api.github.com/repos/ONSdigital/dp-filter/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-filter/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-filter/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-filter/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-filter/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-filter/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-filter/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-filter/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-filter/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-filter/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-filter/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-filter/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-filter/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-filter/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-filter/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-filter/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-filter/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-filter/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-filter/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-filter/deployments","created_at":"2017-11-09T15:23:33Z","updated_at":"2018-06-06T07:52:50Z","pushed_at":"2018-09-18T10:52:14Z","git_url":"git://github.com/ONSdigital/dp-filter.git","ssh_url":"git@github.com:ONSdigital/dp-filter.git","clone_url":"https://github.com/ONSdigital/dp-filter.git","svn_url":"https://github.com/ONSdigital/dp-filter","homepage":null,"size":139,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"cmd-develop"}},"base":{"label":"ONSdigital:cmd-develop","ref":"cmd-develop","sha":"f56797ab6de5f156eec979f304eee91872e00234","user":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":110131699,"node_id":"MDEwOlJlcG9zaXRvcnkxMTAxMzE2OTk=","name":"dp-filter","full_name":"ONSdigital/dp-filter","private":false,"owner":{"login":"ONSdigital","id":6865137,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NjUxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ONSdigital/dp-filter","description":"A library used to filter ONS datasets using Neo4j","fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-filter","forks_url":"https://api.github.com/repos/ONSdigital/dp-filter/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-filter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-filter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-filter/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-filter/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-filter/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-filter/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-filter/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-filter/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-filter/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-filter/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-filter/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-filter/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-filter/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-filter/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-filter/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-filter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-filter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-filter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-filter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-filter/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-filter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-filter/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-filter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-filter/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-filter/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-filter/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-filter/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-filter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-filter/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-filter/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-filter/deployments","created_at":"2017-11-09T15:23:33Z","updated_at":"2018-06-06T07:52:50Z","pushed_at":"2018-09-18T10:52:14Z","git_url":"git://github.com/ONSdigital/dp-filter.git","ssh_url":"git@github.com:ONSdigital/dp-filter.git","clone_url":"https://github.com/ONSdigital/dp-filter.git","svn_url":"https://github.com/ONSdigital/dp-filter","homepage":null,"size":139,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"cmd-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/dp-filter/pulls/12"},"html":{"href":"https://github.com/ONSdigital/dp-filter/pull/12"},"issue":{"href":"https://api.github.com/repos/ONSdigital/dp-filter/issues/12"},"comments":{"href":"https://api.github.com/repos/ONSdigital/dp-filter/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/dp-filter/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/dp-filter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/dp-filter/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/dp-filter/statuses/9030f07058e85c16d8e720feb891da481e8a23cf"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"eldeal"}}