{"action":"created","comment":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/212528725","pull_request_review_id":149178972,"id":212528725,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjUyODcyNQ==","diff_hunk":"@@ -360,7 +360,7 @@ func TestAnteHandlerMemoGas(t *testing.T) {\n \tvar tx sdk.Tx\n \tmsg := newTestMsg(addr1)\n \tprivs, accnums, seqs := []crypto.PrivKey{priv1}, []int64{0}, []int64{0}\n-\tfee := NewStdFee(0, sdk.NewInt64Coin(\"atom\", 0))\n+\tfee := NewStdFee(1, sdk.NewInt64Coin(\"atom\", 0))","path":"x/auth/ante_test.go","position":5,"original_position":5,"commit_id":"10e5751570160e1b982a2d0914f125929848c9b3","original_commit_id":"10e5751570160e1b982a2d0914f125929848c9b3","user":{"login":"ValarDragon","id":6440154,"node_id":"MDQ6VXNlcjY0NDAxNTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6440154?v=4","gravatar_id":"","url":"https://api.github.com/users/ValarDragon","html_url":"https://github.com/ValarDragon","followers_url":"https://api.github.com/users/ValarDragon/followers","following_url":"https://api.github.com/users/ValarDragon/following{/other_user}","gists_url":"https://api.github.com/users/ValarDragon/gists{/gist_id}","starred_url":"https://api.github.com/users/ValarDragon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ValarDragon/subscriptions","organizations_url":"https://api.github.com/users/ValarDragon/orgs","repos_url":"https://api.github.com/users/ValarDragon/repos","events_url":"https://api.github.com/users/ValarDragon/events{/privacy}","received_events_url":"https://api.github.com/users/ValarDragon/received_events","type":"User","site_admin":false},"body":"Why can't 0 be used for the fee here?","created_at":"2018-08-24T06:04:36Z","updated_at":"2018-08-24T06:11:11Z","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2047#discussion_r212528725","pull_request_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2047","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments/212528725"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/2047#discussion_r212528725"},"pull_request":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2047"}}},"pull_request":{"url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2047","id":208619629,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NjE5NjI5","html_url":"https://github.com/cosmos/cosmos-sdk/pull/2047","diff_url":"https://github.com/cosmos/cosmos-sdk/pull/2047.diff","patch_url":"https://github.com/cosmos/cosmos-sdk/pull/2047.patch","issue_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2047","number":2047,"state":"open","locked":false,"title":"Simulate transactions by default to set gas automatically","user":{"login":"alessio","id":229356,"node_id":"MDQ6VXNlcjIyOTM1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/229356?v=4","gravatar_id":"","url":"https://api.github.com/users/alessio","html_url":"https://github.com/alessio","followers_url":"https://api.github.com/users/alessio/followers","following_url":"https://api.github.com/users/alessio/following{/other_user}","gists_url":"https://api.github.com/users/alessio/gists{/gist_id}","starred_url":"https://api.github.com/users/alessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessio/subscriptions","organizations_url":"https://api.github.com/users/alessio/orgs","repos_url":"https://api.github.com/users/alessio/repos","events_url":"https://api.github.com/users/alessio/events{/privacy}","received_events_url":"https://api.github.com/users/alessio/received_events","type":"User","site_admin":false},"body":"Relevant issue: #1246\r\n\r\n* Change `--gas=0` semantic in order to enable gas auto estimate.\r\n* REST clients have been modified to simulate the execution of the tx first to then populate the context with the estimated gas amount returned by the simulation.\r\n* The simulation returns both an unadjusted gas estimate and an adjusted one. The adjustment is required to ensure that the ensuing execution doesn't fail due to state changes that might have occurred. Gas adjustment can be controlled via the CLI's `--gas-adjustment` flag.\r\n\r\nCloses: #1246\r\n\r\n- [x] Linked to github-issue with discussion and accepted design OR link to spec that describes this work.\r\n- [x] Updated all relevant documentation (`docs/`)\r\n- [x] Updated all relevant code comments\r\n- [x] Wrote tests\r\n- [x] Added entries in `PENDING.md` that include links to the relevant issue or PR that most accurately describes the change.\r\n- [ ] Updated `cmd/gaia` and `examples/`\r\n___________________________________\r\nFor Admin Use:\r\n- [ ] Added appropriate labels to PR (ex. wip, ready-for-review, docs)\r\n- [ ] Reviewers Assigned\r\n- [ ] Squashed all commits, uses message \"Merge pull request #XYZ: [title]\" ([coding standards](https://github.com/tendermint/coding/blob/master/README.md#merging-a-pr))\r\n","created_at":"2018-08-15T16:55:38Z","updated_at":"2018-08-24T06:11:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54fcbb27ce2078702a749788514ea0145dd5ff62","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false},{"login":"zramsay","id":8304391,"node_id":"MDQ6VXNlcjgzMDQzOTE=","avatar_url":"https://avatars2.githubusercontent.com/u/8304391?v=4","gravatar_id":"","url":"https://api.github.com/users/zramsay","html_url":"https://github.com/zramsay","followers_url":"https://api.github.com/users/zramsay/followers","following_url":"https://api.github.com/users/zramsay/following{/other_user}","gists_url":"https://api.github.com/users/zramsay/gists{/gist_id}","starred_url":"https://api.github.com/users/zramsay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zramsay/subscriptions","organizations_url":"https://api.github.com/users/zramsay/orgs","repos_url":"https://api.github.com/users/zramsay/repos","events_url":"https://api.github.com/users/zramsay/events{/privacy}","received_events_url":"https://api.github.com/users/zramsay/received_events","type":"User","site_admin":false},{"login":"rigelrozanski","id":20132176,"node_id":"MDQ6VXNlcjIwMTMyMTc2","avatar_url":"https://avatars1.githubusercontent.com/u/20132176?v=4","gravatar_id":"","url":"https://api.github.com/users/rigelrozanski","html_url":"https://github.com/rigelrozanski","followers_url":"https://api.github.com/users/rigelrozanski/followers","following_url":"https://api.github.com/users/rigelrozanski/following{/other_user}","gists_url":"https://api.github.com/users/rigelrozanski/gists{/gist_id}","starred_url":"https://api.github.com/users/rigelrozanski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rigelrozanski/subscriptions","organizations_url":"https://api.github.com/users/rigelrozanski/orgs","repos_url":"https://api.github.com/users/rigelrozanski/repos","events_url":"https://api.github.com/users/rigelrozanski/events{/privacy}","received_events_url":"https://api.github.com/users/rigelrozanski/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":965477209,"node_id":"MDU6TGFiZWw5NjU0NzcyMDk=","url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels/ready-for-review","name":"ready-for-review","color":"e6fad2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2047/commits","review_comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2047/comments","review_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2047/comments","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/10e5751570160e1b982a2d0914f125929848c9b3","head":{"label":"alessio:alessio/1246-simulate-txs","ref":"alessio/1246-simulate-txs","sha":"10e5751570160e1b982a2d0914f125929848c9b3","user":{"login":"alessio","id":229356,"node_id":"MDQ6VXNlcjIyOTM1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/229356?v=4","gravatar_id":"","url":"https://api.github.com/users/alessio","html_url":"https://github.com/alessio","followers_url":"https://api.github.com/users/alessio/followers","following_url":"https://api.github.com/users/alessio/following{/other_user}","gists_url":"https://api.github.com/users/alessio/gists{/gist_id}","starred_url":"https://api.github.com/users/alessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessio/subscriptions","organizations_url":"https://api.github.com/users/alessio/orgs","repos_url":"https://api.github.com/users/alessio/repos","events_url":"https://api.github.com/users/alessio/events{/privacy}","received_events_url":"https://api.github.com/users/alessio/received_events","type":"User","site_admin":false},"repo":{"id":125749342,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3NDkzNDI=","name":"cosmos-sdk","full_name":"alessio/cosmos-sdk","owner":{"login":"alessio","id":229356,"node_id":"MDQ6VXNlcjIyOTM1Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/229356?v=4","gravatar_id":"","url":"https://api.github.com/users/alessio","html_url":"https://github.com/alessio","followers_url":"https://api.github.com/users/alessio/followers","following_url":"https://api.github.com/users/alessio/following{/other_user}","gists_url":"https://api.github.com/users/alessio/gists{/gist_id}","starred_url":"https://api.github.com/users/alessio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessio/subscriptions","organizations_url":"https://api.github.com/users/alessio/orgs","repos_url":"https://api.github.com/users/alessio/repos","events_url":"https://api.github.com/users/alessio/events{/privacy}","received_events_url":"https://api.github.com/users/alessio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alessio/cosmos-sdk","description":"A cryptocurrency framework in Golang","fork":true,"url":"https://api.github.com/repos/alessio/cosmos-sdk","forks_url":"https://api.github.com/repos/alessio/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/alessio/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alessio/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alessio/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/alessio/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/alessio/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/alessio/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/alessio/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/alessio/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/alessio/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/alessio/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alessio/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alessio/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/alessio/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alessio/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/alessio/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/alessio/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/alessio/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/alessio/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/alessio/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/alessio/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/alessio/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/alessio/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/alessio/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/alessio/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/alessio/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alessio/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/alessio/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alessio/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/alessio/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/alessio/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/alessio/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/alessio/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alessio/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/alessio/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/alessio/cosmos-sdk/deployments","created_at":"2018-03-18T17:20:00Z","updated_at":"2018-04-02T22:39:04Z","pushed_at":"2018-08-23T21:11:42Z","git_url":"git://github.com/alessio/cosmos-sdk.git","ssh_url":"git@github.com:alessio/cosmos-sdk.git","clone_url":"https://github.com/alessio/cosmos-sdk.git","svn_url":"https://github.com/alessio/cosmos-sdk","homepage":"https://tendermint.com","size":32511,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cosmos:develop","ref":"develop","sha":"1024ccc459018aa0411eac32b28285f13592bd2d","user":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"repo":{"id":51193526,"node_id":"MDEwOlJlcG9zaXRvcnk1MTE5MzUyNg==","name":"cosmos-sdk","full_name":"cosmos/cosmos-sdk","owner":{"login":"cosmos","id":228843,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODg0Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/228843?v=4","gravatar_id":"","url":"https://api.github.com/users/cosmos","html_url":"https://github.com/cosmos","followers_url":"https://api.github.com/users/cosmos/followers","following_url":"https://api.github.com/users/cosmos/following{/other_user}","gists_url":"https://api.github.com/users/cosmos/gists{/gist_id}","starred_url":"https://api.github.com/users/cosmos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cosmos/subscriptions","organizations_url":"https://api.github.com/users/cosmos/orgs","repos_url":"https://api.github.com/users/cosmos/repos","events_url":"https://api.github.com/users/cosmos/events{/privacy}","received_events_url":"https://api.github.com/users/cosmos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cosmos/cosmos-sdk","description":"Secure Blockchain Framework","fork":false,"url":"https://api.github.com/repos/cosmos/cosmos-sdk","forks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/forks","keys_url":"https://api.github.com/repos/cosmos/cosmos-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cosmos/cosmos-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cosmos/cosmos-sdk/teams","hooks_url":"https://api.github.com/repos/cosmos/cosmos-sdk/hooks","issue_events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/cosmos/cosmos-sdk/events","assignees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/cosmos/cosmos-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/tags","blobs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/cosmos/cosmos-sdk/languages","stargazers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/stargazers","contributors_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contributors","subscribers_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscribers","subscription_url":"https://api.github.com/repos/cosmos/cosmos-sdk/subscription","commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cosmos/cosmos-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cosmos/cosmos-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/cosmos/cosmos-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cosmos/cosmos-sdk/merges","archive_url":"https://api.github.com/repos/cosmos/cosmos-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cosmos/cosmos-sdk/downloads","issues_url":"https://api.github.com/repos/cosmos/cosmos-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/cosmos/cosmos-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/cosmos/cosmos-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cosmos/cosmos-sdk/labels{/name}","releases_url":"https://api.github.com/repos/cosmos/cosmos-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/cosmos/cosmos-sdk/deployments","created_at":"2016-02-06T07:15:53Z","updated_at":"2018-08-24T05:20:52Z","pushed_at":"2018-08-24T03:57:03Z","git_url":"git://github.com/cosmos/cosmos-sdk.git","ssh_url":"git@github.com:cosmos/cosmos-sdk.git","clone_url":"https://github.com/cosmos/cosmos-sdk.git","svn_url":"https://github.com/cosmos/cosmos-sdk","homepage":"https://cosmos.network/","size":34217,"stargazers_count":533,"watchers_count":533,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"archived":false,"open_issues_count":342,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":185,"open_issues":342,"watchers":533,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2047"},"html":{"href":"https://github.com/cosmos/cosmos-sdk/pull/2047"},"issue":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2047"},"comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/issues/2047/comments"},"review_comments":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2047/comments"},"review_comment":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/pulls/2047/commits"},"statuses":{"href":"https://api.github.com/repos/cosmos/cosmos-sdk/statuses/10e5751570160e1b982a2d0914f125929848c9b3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ValarDragon"}}