{"action":"closed","number":2373,"pull_request":{"url":"https://api.github.com/repos/batfish/batfish/pulls/2373","id":219186412,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTg2NDEy","html_url":"https://github.com/batfish/batfish/pull/2373","diff_url":"https://github.com/batfish/batfish/pull/2373.diff","patch_url":"https://github.com/batfish/batfish/pull/2373.patch","issue_url":"https://api.github.com/repos/batfish/batfish/issues/2373","number":2373,"state":"closed","locked":false,"title":"Juniper: add support for ip- variants in firewall terms","user":{"login":"dhalperi","id":526415,"node_id":"MDQ6VXNlcjUyNjQxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"body":"These are allowed and equivalent to the same with out the ip- prefix.\r\n\r\nSee https://www.juniper.net/documentation/en_US/junos/topics/reference/general/firewall-filter-ex-series-match-conditions-description.html","created_at":"2018-09-30T05:43:39Z","updated_at":"2018-10-01T16:11:23Z","closed_at":"2018-10-01T16:11:23Z","merged_at":"2018-10-01T16:11:23Z","merge_commit_sha":"9ebe20bf9dd7ceb1f497763028c42e3e5d1ef2f9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"arifogel","id":7737874,"node_id":"MDQ6VXNlcjc3Mzc4NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7737874?v=4","gravatar_id":"","url":"https://api.github.com/users/arifogel","html_url":"https://github.com/arifogel","followers_url":"https://api.github.com/users/arifogel/followers","following_url":"https://api.github.com/users/arifogel/following{/other_user}","gists_url":"https://api.github.com/users/arifogel/gists{/gist_id}","starred_url":"https://api.github.com/users/arifogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arifogel/subscriptions","organizations_url":"https://api.github.com/users/arifogel/orgs","repos_url":"https://api.github.com/users/arifogel/repos","events_url":"https://api.github.com/users/arifogel/events{/privacy}","received_events_url":"https://api.github.com/users/arifogel/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/batfish/batfish/pulls/2373/commits","review_comments_url":"https://api.github.com/repos/batfish/batfish/pulls/2373/comments","review_comment_url":"https://api.github.com/repos/batfish/batfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/batfish/batfish/issues/2373/comments","statuses_url":"https://api.github.com/repos/batfish/batfish/statuses/b8fd9521c146c23e2938180bfc2db7c97f469a38","head":{"label":"dhalperi:juniper-parser","ref":"juniper-parser","sha":"b8fd9521c146c23e2938180bfc2db7c97f469a38","user":{"login":"dhalperi","id":526415,"node_id":"MDQ6VXNlcjUyNjQxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"repo":{"id":94917439,"node_id":"MDEwOlJlcG9zaXRvcnk5NDkxNzQzOQ==","name":"batfish","full_name":"dhalperi/batfish","private":false,"owner":{"login":"dhalperi","id":526415,"node_id":"MDQ6VXNlcjUyNjQxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dhalperi/batfish","description":"Batfish is a network configuration analysis tool that can find bugs and guarantee the correctness of (planned or current) network configurations. It enables network engineers to rapidly and safely evolve their network, without fear of outages or security breaches.","fork":true,"url":"https://api.github.com/repos/dhalperi/batfish","forks_url":"https://api.github.com/repos/dhalperi/batfish/forks","keys_url":"https://api.github.com/repos/dhalperi/batfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhalperi/batfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhalperi/batfish/teams","hooks_url":"https://api.github.com/repos/dhalperi/batfish/hooks","issue_events_url":"https://api.github.com/repos/dhalperi/batfish/issues/events{/number}","events_url":"https://api.github.com/repos/dhalperi/batfish/events","assignees_url":"https://api.github.com/repos/dhalperi/batfish/assignees{/user}","branches_url":"https://api.github.com/repos/dhalperi/batfish/branches{/branch}","tags_url":"https://api.github.com/repos/dhalperi/batfish/tags","blobs_url":"https://api.github.com/repos/dhalperi/batfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhalperi/batfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhalperi/batfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhalperi/batfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhalperi/batfish/statuses/{sha}","languages_url":"https://api.github.com/repos/dhalperi/batfish/languages","stargazers_url":"https://api.github.com/repos/dhalperi/batfish/stargazers","contributors_url":"https://api.github.com/repos/dhalperi/batfish/contributors","subscribers_url":"https://api.github.com/repos/dhalperi/batfish/subscribers","subscription_url":"https://api.github.com/repos/dhalperi/batfish/subscription","commits_url":"https://api.github.com/repos/dhalperi/batfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhalperi/batfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhalperi/batfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhalperi/batfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhalperi/batfish/contents/{+path}","compare_url":"https://api.github.com/repos/dhalperi/batfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhalperi/batfish/merges","archive_url":"https://api.github.com/repos/dhalperi/batfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhalperi/batfish/downloads","issues_url":"https://api.github.com/repos/dhalperi/batfish/issues{/number}","pulls_url":"https://api.github.com/repos/dhalperi/batfish/pulls{/number}","milestones_url":"https://api.github.com/repos/dhalperi/batfish/milestones{/number}","notifications_url":"https://api.github.com/repos/dhalperi/batfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhalperi/batfish/labels{/name}","releases_url":"https://api.github.com/repos/dhalperi/batfish/releases{/id}","deployments_url":"https://api.github.com/repos/dhalperi/batfish/deployments","created_at":"2017-06-20T17:26:17Z","updated_at":"2018-09-19T09:02:15Z","pushed_at":"2018-09-30T15:56:07Z","git_url":"git://github.com/dhalperi/batfish.git","ssh_url":"git@github.com:dhalperi/batfish.git","clone_url":"https://github.com/dhalperi/batfish.git","svn_url":"https://github.com/dhalperi/batfish","homepage":"http://www.batfish.org","size":130761,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"batfish:master","ref":"master","sha":"72d85ddc572044f17e501e8ee8f400f4f815a777","user":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"repo":{"id":27507850,"node_id":"MDEwOlJlcG9zaXRvcnkyNzUwNzg1MA==","name":"batfish","full_name":"batfish/batfish","private":false,"owner":{"login":"batfish","id":24584846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0NTg0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/24584846?v=4","gravatar_id":"","url":"https://api.github.com/users/batfish","html_url":"https://github.com/batfish","followers_url":"https://api.github.com/users/batfish/followers","following_url":"https://api.github.com/users/batfish/following{/other_user}","gists_url":"https://api.github.com/users/batfish/gists{/gist_id}","starred_url":"https://api.github.com/users/batfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/batfish/subscriptions","organizations_url":"https://api.github.com/users/batfish/orgs","repos_url":"https://api.github.com/users/batfish/repos","events_url":"https://api.github.com/users/batfish/events{/privacy}","received_events_url":"https://api.github.com/users/batfish/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/batfish/batfish","description":"Batfish is a network configuration analysis tool that can find bugs and guarantee the correctness of (planned or current) network configurations. It enables network engineers to rapidly and safely evolve their network, without fear of outages or security breaches.","fork":false,"url":"https://api.github.com/repos/batfish/batfish","forks_url":"https://api.github.com/repos/batfish/batfish/forks","keys_url":"https://api.github.com/repos/batfish/batfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/batfish/batfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/batfish/batfish/teams","hooks_url":"https://api.github.com/repos/batfish/batfish/hooks","issue_events_url":"https://api.github.com/repos/batfish/batfish/issues/events{/number}","events_url":"https://api.github.com/repos/batfish/batfish/events","assignees_url":"https://api.github.com/repos/batfish/batfish/assignees{/user}","branches_url":"https://api.github.com/repos/batfish/batfish/branches{/branch}","tags_url":"https://api.github.com/repos/batfish/batfish/tags","blobs_url":"https://api.github.com/repos/batfish/batfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/batfish/batfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/batfish/batfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/batfish/batfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/batfish/batfish/statuses/{sha}","languages_url":"https://api.github.com/repos/batfish/batfish/languages","stargazers_url":"https://api.github.com/repos/batfish/batfish/stargazers","contributors_url":"https://api.github.com/repos/batfish/batfish/contributors","subscribers_url":"https://api.github.com/repos/batfish/batfish/subscribers","subscription_url":"https://api.github.com/repos/batfish/batfish/subscription","commits_url":"https://api.github.com/repos/batfish/batfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/batfish/batfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/batfish/batfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/batfish/batfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/batfish/batfish/contents/{+path}","compare_url":"https://api.github.com/repos/batfish/batfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/batfish/batfish/merges","archive_url":"https://api.github.com/repos/batfish/batfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/batfish/batfish/downloads","issues_url":"https://api.github.com/repos/batfish/batfish/issues{/number}","pulls_url":"https://api.github.com/repos/batfish/batfish/pulls{/number}","milestones_url":"https://api.github.com/repos/batfish/batfish/milestones{/number}","notifications_url":"https://api.github.com/repos/batfish/batfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/batfish/batfish/labels{/name}","releases_url":"https://api.github.com/repos/batfish/batfish/releases{/id}","deployments_url":"https://api.github.com/repos/batfish/batfish/deployments","created_at":"2014-12-03T21:10:18Z","updated_at":"2018-09-30T23:24:41Z","pushed_at":"2018-10-01T16:11:23Z","git_url":"git://github.com/batfish/batfish.git","ssh_url":"git@github.com:batfish/batfish.git","clone_url":"https://github.com/batfish/batfish.git","svn_url":"https://github.com/batfish/batfish","homepage":"http://www.batfish.org","size":170687,"stargazers_count":114,"watchers_count":114,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":59,"open_issues":127,"watchers":114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/batfish/batfish/pulls/2373"},"html":{"href":"https://github.com/batfish/batfish/pull/2373"},"issue":{"href":"https://api.github.com/repos/batfish/batfish/issues/2373"},"comments":{"href":"https://api.github.com/repos/batfish/batfish/issues/2373/comments"},"review_comments":{"href":"https://api.github.com/repos/batfish/batfish/pulls/2373/comments"},"review_comment":{"href":"https://api.github.com/repos/batfish/batfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/batfish/batfish/pulls/2373/commits"},"statuses":{"href":"https://api.github.com/repos/batfish/batfish/statuses/b8fd9521c146c23e2938180bfc2db7c97f469a38"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dhalperi","id":526415,"node_id":"MDQ6VXNlcjUyNjQxNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/526415?v=4","gravatar_id":"","url":"https://api.github.com/users/dhalperi","html_url":"https://github.com/dhalperi","followers_url":"https://api.github.com/users/dhalperi/followers","following_url":"https://api.github.com/users/dhalperi/following{/other_user}","gists_url":"https://api.github.com/users/dhalperi/gists{/gist_id}","starred_url":"https://api.github.com/users/dhalperi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhalperi/subscriptions","organizations_url":"https://api.github.com/users/dhalperi/orgs","repos_url":"https://api.github.com/users/dhalperi/repos","events_url":"https://api.github.com/users/dhalperi/events{/privacy}","received_events_url":"https://api.github.com/users/dhalperi/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":139,"deletions":8,"changed_files":6}}
{"actor":{"display_login":"dhalperi"}}