{"action":"created","comment":{"url":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/comments/234978636","pull_request_review_id":176736040,"id":234978636,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDk3ODYzNg==","diff_hunk":"@@ -163,55 +166,51 @@ if(NOT EXISTS \"${CMAKE_BINARY_DIR}/conan.cmake\")\n                   \"${CMAKE_BINARY_DIR}/conan.cmake\")\n endif()\n \n-include(${CMAKE_BINARY_DIR}/conan.cmake)\n+#TODO fix this\n set(CMAKE_BUILD_TYPE Release)\n \n-#Sets the includeos default profile to clang-5.0\n+#NB 5.0 is llvm version should be a variable from CMAKE or profile ?\n+#TODO separate dependencies if build is GCC from if build is clang in\n+#conanfile.py and add requirement for the tools in the profile!!\n+#TODO create a NaCL package ?\n+#TODO create packages for \"other\" lib\n+\n+#Sets the includeos default profile to clang-7.0 mergeconflict?\n if (NOT DEFINED CONAN_PROFILE)\n   SET(CONAN_PROFILE clang-5.0)\n endif()\n \n-#NB 5.0 is llvm version should be a variable from CMAKE or profile ?\n-#TODO separate dependencies if build is GCC from if build is clang ?\n-#TODO create a NaCL package ?\n-#TODO create packages for tools in general ?\n-#TODO move these where they are actually needed and not bloat the global space with the package\n-SET(CONAN_DEPENDENCIES\n-  llvm/5.0@includeos/stable\n-  musl/v1.1.18@includeos/stable\n-  binutils/2.31/includeos/stable\n-\n-  GSL/2.0.0@includeos/test\n-  protobuf/3.5.1.1@includeos/test\n-  rapidjson/1.1.0@includeos/test\n-  botan/2.8.0@includeos/test\n-  openssl/1.1.1@includeos/test\n-  s2n/1.1.1@includeos/test\n-\n-  http-parser/2.8.1@includeos/test\n-  uzlib/v2.1.1@includeos/test\n-)\n-if (APPLE)\n-  SET(CONAN_DEPENDENCIES ${CONAN_DEPENDENCIES}\n-    libgcc/1.0@includeos/stable\n-    )\n-else()\n-  if (WITH_SOLO5)\n-    SET(CONAN_DEPENDENCIES ${CONAN_DEPENDENCIES}\n-      solo5/0.3.1@includeos/test\n-      )\n-  endif(WITH_SOLO5)\n-endif(APPLE)\n-\n-#TODO find a better way to handle profiles ?\n-conan_cmake_run(\n-  REQUIRES ${CONAN_DEPENDENCIES}\n-  PROFILE ${CONAN_PROFILE}\n-  BASIC_SETUP\n-  BUILD missing\n-  GENERATORS\n-  cmake\n- )\n+set(CONAN_APPLE False)\n+IF (APPLE)\n+  set(CONAN_APPLE True)","path":"CMakeLists.txt","position":132,"original_position":141,"commit_id":"18371d79ac2e076dd5282ad36506293b65778a85","original_commit_id":"5fc8ae998e9216c44b5049c6f494b612aedf8034","user":{"login":"KristianJerpetjon","id":43113951,"node_id":"MDQ6VXNlcjQzMTEzOTUx","avatar_url":"https://avatars0.githubusercontent.com/u/43113951?v=4","gravatar_id":"","url":"https://api.github.com/users/KristianJerpetjon","html_url":"https://github.com/KristianJerpetjon","followers_url":"https://api.github.com/users/KristianJerpetjon/followers","following_url":"https://api.github.com/users/KristianJerpetjon/following{/other_user}","gists_url":"https://api.github.com/users/KristianJerpetjon/gists{/gist_id}","starred_url":"https://api.github.com/users/KristianJerpetjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristianJerpetjon/subscriptions","organizations_url":"https://api.github.com/users/KristianJerpetjon/orgs","repos_url":"https://api.github.com/users/KristianJerpetjon/repos","events_url":"https://api.github.com/users/KristianJerpetjon/events{/privacy}","received_events_url":"https://api.github.com/users/KristianJerpetjon/received_events","type":"User","site_admin":false},"body":"merged","created_at":"2018-11-20T12:15:42Z","updated_at":"2018-11-20T12:15:42Z","html_url":"https://github.com/hioa-cs/IncludeOS/pull/1988#discussion_r234978636","pull_request_url":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/1988","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/comments/234978636"},"html":{"href":"https://github.com/hioa-cs/IncludeOS/pull/1988#discussion_r234978636"},"pull_request":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/1988"}},"in_reply_to_id":234932881},"pull_request":{"url":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/1988","id":232242724,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMjQyNzI0","html_url":"https://github.com/hioa-cs/IncludeOS/pull/1988","diff_url":"https://github.com/hioa-cs/IncludeOS/pull/1988.diff","patch_url":"https://github.com/hioa-cs/IncludeOS/pull/1988.patch","issue_url":"https://api.github.com/repos/hioa-cs/IncludeOS/issues/1988","number":1988,"state":"open","locked":false,"title":"Cleaned up some paths and fixed some more deps","user":{"login":"KristianJerpetjon","id":43113951,"node_id":"MDQ6VXNlcjQzMTEzOTUx","avatar_url":"https://avatars0.githubusercontent.com/u/43113951?v=4","gravatar_id":"","url":"https://api.github.com/users/KristianJerpetjon","html_url":"https://github.com/KristianJerpetjon","followers_url":"https://api.github.com/users/KristianJerpetjon/followers","following_url":"https://api.github.com/users/KristianJerpetjon/following{/other_user}","gists_url":"https://api.github.com/users/KristianJerpetjon/gists{/gist_id}","starred_url":"https://api.github.com/users/KristianJerpetjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristianJerpetjon/subscriptions","organizations_url":"https://api.github.com/users/KristianJerpetjon/orgs","repos_url":"https://api.github.com/users/KristianJerpetjon/repos","events_url":"https://api.github.com/users/KristianJerpetjon/events{/privacy}","received_events_url":"https://api.github.com/users/KristianJerpetjon/received_events","type":"User","site_admin":false},"body":"please review","created_at":"2018-11-20T09:19:12Z","updated_at":"2018-11-20T12:15:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57fee3cde9608d408e850b3995e2e3ff0a888bff","assignee":null,"assignees":[],"requested_reviewers":[{"login":"fwsGonzo","id":3758947,"node_id":"MDQ6VXNlcjM3NTg5NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3758947?v=4","gravatar_id":"","url":"https://api.github.com/users/fwsGonzo","html_url":"https://github.com/fwsGonzo","followers_url":"https://api.github.com/users/fwsGonzo/followers","following_url":"https://api.github.com/users/fwsGonzo/following{/other_user}","gists_url":"https://api.github.com/users/fwsGonzo/gists{/gist_id}","starred_url":"https://api.github.com/users/fwsGonzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fwsGonzo/subscriptions","organizations_url":"https://api.github.com/users/fwsGonzo/orgs","repos_url":"https://api.github.com/users/fwsGonzo/repos","events_url":"https://api.github.com/users/fwsGonzo/events{/privacy}","received_events_url":"https://api.github.com/users/fwsGonzo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/1988/commits","review_comments_url":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/1988/comments","review_comment_url":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hioa-cs/IncludeOS/issues/1988/comments","statuses_url":"https://api.github.com/repos/hioa-cs/IncludeOS/statuses/18371d79ac2e076dd5282ad36506293b65778a85","head":{"label":"KristianJerpetjon:conan-demo","ref":"conan-demo","sha":"18371d79ac2e076dd5282ad36506293b65778a85","user":{"login":"KristianJerpetjon","id":43113951,"node_id":"MDQ6VXNlcjQzMTEzOTUx","avatar_url":"https://avatars0.githubusercontent.com/u/43113951?v=4","gravatar_id":"","url":"https://api.github.com/users/KristianJerpetjon","html_url":"https://github.com/KristianJerpetjon","followers_url":"https://api.github.com/users/KristianJerpetjon/followers","following_url":"https://api.github.com/users/KristianJerpetjon/following{/other_user}","gists_url":"https://api.github.com/users/KristianJerpetjon/gists{/gist_id}","starred_url":"https://api.github.com/users/KristianJerpetjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristianJerpetjon/subscriptions","organizations_url":"https://api.github.com/users/KristianJerpetjon/orgs","repos_url":"https://api.github.com/users/KristianJerpetjon/repos","events_url":"https://api.github.com/users/KristianJerpetjon/events{/privacy}","received_events_url":"https://api.github.com/users/KristianJerpetjon/received_events","type":"User","site_admin":false},"repo":{"id":148544815,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg1NDQ4MTU=","name":"IncludeOS","full_name":"KristianJerpetjon/IncludeOS","private":false,"owner":{"login":"KristianJerpetjon","id":43113951,"node_id":"MDQ6VXNlcjQzMTEzOTUx","avatar_url":"https://avatars0.githubusercontent.com/u/43113951?v=4","gravatar_id":"","url":"https://api.github.com/users/KristianJerpetjon","html_url":"https://github.com/KristianJerpetjon","followers_url":"https://api.github.com/users/KristianJerpetjon/followers","following_url":"https://api.github.com/users/KristianJerpetjon/following{/other_user}","gists_url":"https://api.github.com/users/KristianJerpetjon/gists{/gist_id}","starred_url":"https://api.github.com/users/KristianJerpetjon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KristianJerpetjon/subscriptions","organizations_url":"https://api.github.com/users/KristianJerpetjon/orgs","repos_url":"https://api.github.com/users/KristianJerpetjon/repos","events_url":"https://api.github.com/users/KristianJerpetjon/events{/privacy}","received_events_url":"https://api.github.com/users/KristianJerpetjon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KristianJerpetjon/IncludeOS","description":"A minimal, resource efficient unikernel for cloud services","fork":true,"url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS","forks_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/forks","keys_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/teams","hooks_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/hooks","issue_events_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/issues/events{/number}","events_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/events","assignees_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/assignees{/user}","branches_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/branches{/branch}","tags_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/tags","blobs_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/statuses/{sha}","languages_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/languages","stargazers_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/stargazers","contributors_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/contributors","subscribers_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/subscribers","subscription_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/subscription","commits_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/contents/{+path}","compare_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/merges","archive_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/downloads","issues_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/issues{/number}","pulls_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/pulls{/number}","milestones_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/milestones{/number}","notifications_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/labels{/name}","releases_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/releases{/id}","deployments_url":"https://api.github.com/repos/KristianJerpetjon/IncludeOS/deployments","created_at":"2018-09-12T21:33:57Z","updated_at":"2018-09-12T21:34:01Z","pushed_at":"2018-11-20T12:13:49Z","git_url":"git://github.com/KristianJerpetjon/IncludeOS.git","ssh_url":"git@github.com:KristianJerpetjon/IncludeOS.git","clone_url":"https://github.com/KristianJerpetjon/IncludeOS.git","svn_url":"https://github.com/KristianJerpetjon/IncludeOS","homepage":"http://www.includeos.org","size":49701,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hioa-cs:conan","ref":"conan","sha":"36d10c91b09e052f98376913e2fb16db37a1b11c","user":{"login":"hioa-cs","id":3524846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MjQ4NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3524846?v=4","gravatar_id":"","url":"https://api.github.com/users/hioa-cs","html_url":"https://github.com/hioa-cs","followers_url":"https://api.github.com/users/hioa-cs/followers","following_url":"https://api.github.com/users/hioa-cs/following{/other_user}","gists_url":"https://api.github.com/users/hioa-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/hioa-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hioa-cs/subscriptions","organizations_url":"https://api.github.com/users/hioa-cs/orgs","repos_url":"https://api.github.com/users/hioa-cs/repos","events_url":"https://api.github.com/users/hioa-cs/events{/privacy}","received_events_url":"https://api.github.com/users/hioa-cs/received_events","type":"Organization","site_admin":false},"repo":{"id":21562567,"node_id":"MDEwOlJlcG9zaXRvcnkyMTU2MjU2Nw==","name":"IncludeOS","full_name":"hioa-cs/IncludeOS","private":false,"owner":{"login":"hioa-cs","id":3524846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MjQ4NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/3524846?v=4","gravatar_id":"","url":"https://api.github.com/users/hioa-cs","html_url":"https://github.com/hioa-cs","followers_url":"https://api.github.com/users/hioa-cs/followers","following_url":"https://api.github.com/users/hioa-cs/following{/other_user}","gists_url":"https://api.github.com/users/hioa-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/hioa-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hioa-cs/subscriptions","organizations_url":"https://api.github.com/users/hioa-cs/orgs","repos_url":"https://api.github.com/users/hioa-cs/repos","events_url":"https://api.github.com/users/hioa-cs/events{/privacy}","received_events_url":"https://api.github.com/users/hioa-cs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hioa-cs/IncludeOS","description":"A minimal, resource efficient unikernel for cloud services","fork":false,"url":"https://api.github.com/repos/hioa-cs/IncludeOS","forks_url":"https://api.github.com/repos/hioa-cs/IncludeOS/forks","keys_url":"https://api.github.com/repos/hioa-cs/IncludeOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hioa-cs/IncludeOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hioa-cs/IncludeOS/teams","hooks_url":"https://api.github.com/repos/hioa-cs/IncludeOS/hooks","issue_events_url":"https://api.github.com/repos/hioa-cs/IncludeOS/issues/events{/number}","events_url":"https://api.github.com/repos/hioa-cs/IncludeOS/events","assignees_url":"https://api.github.com/repos/hioa-cs/IncludeOS/assignees{/user}","branches_url":"https://api.github.com/repos/hioa-cs/IncludeOS/branches{/branch}","tags_url":"https://api.github.com/repos/hioa-cs/IncludeOS/tags","blobs_url":"https://api.github.com/repos/hioa-cs/IncludeOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hioa-cs/IncludeOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hioa-cs/IncludeOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/hioa-cs/IncludeOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hioa-cs/IncludeOS/statuses/{sha}","languages_url":"https://api.github.com/repos/hioa-cs/IncludeOS/languages","stargazers_url":"https://api.github.com/repos/hioa-cs/IncludeOS/stargazers","contributors_url":"https://api.github.com/repos/hioa-cs/IncludeOS/contributors","subscribers_url":"https://api.github.com/repos/hioa-cs/IncludeOS/subscribers","subscription_url":"https://api.github.com/repos/hioa-cs/IncludeOS/subscription","commits_url":"https://api.github.com/repos/hioa-cs/IncludeOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/hioa-cs/IncludeOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/hioa-cs/IncludeOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/hioa-cs/IncludeOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/hioa-cs/IncludeOS/contents/{+path}","compare_url":"https://api.github.com/repos/hioa-cs/IncludeOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hioa-cs/IncludeOS/merges","archive_url":"https://api.github.com/repos/hioa-cs/IncludeOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hioa-cs/IncludeOS/downloads","issues_url":"https://api.github.com/repos/hioa-cs/IncludeOS/issues{/number}","pulls_url":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls{/number}","milestones_url":"https://api.github.com/repos/hioa-cs/IncludeOS/milestones{/number}","notifications_url":"https://api.github.com/repos/hioa-cs/IncludeOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hioa-cs/IncludeOS/labels{/name}","releases_url":"https://api.github.com/repos/hioa-cs/IncludeOS/releases{/id}","deployments_url":"https://api.github.com/repos/hioa-cs/IncludeOS/deployments","created_at":"2014-07-07T08:15:06Z","updated_at":"2018-11-19T22:50:49Z","pushed_at":"2018-11-20T12:13:51Z","git_url":"git://github.com/hioa-cs/IncludeOS.git","ssh_url":"git@github.com:hioa-cs/IncludeOS.git","clone_url":"https://github.com/hioa-cs/IncludeOS.git","svn_url":"https://github.com/hioa-cs/IncludeOS","homepage":"http://www.includeos.org","size":49700,"stargazers_count":3344,"watchers_count":3344,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":267,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":267,"open_issues":58,"watchers":3344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/1988"},"html":{"href":"https://github.com/hioa-cs/IncludeOS/pull/1988"},"issue":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/issues/1988"},"comments":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/issues/1988/comments"},"review_comments":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/1988/comments"},"review_comment":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/pulls/1988/commits"},"statuses":{"href":"https://api.github.com/repos/hioa-cs/IncludeOS/statuses/18371d79ac2e076dd5282ad36506293b65778a85"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"KristianJerpetjon"}}