{"action":"created","comment":{"url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/comments/199541114","pull_request_review_id":133679944,"id":199541114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTU0MTExNA==","diff_hunk":"@@ -155,6 +155,22 @@ namespace fc {\n       }\n    }\n \n+    file_appender::file_appender( const config& arg ) : fc::appender(), \n+        my( new impl( arg ) )","path":"src/log/file_appender.cpp","position":42,"original_position":42,"commit_id":"3b39aa190ebd96c441ca7a91981241905a2d392a","original_commit_id":"3b39aa190ebd96c441ca7a91981241905a2d392a","user":{"login":"jmjatlanta","id":4626076,"node_id":"MDQ6VXNlcjQ2MjYwNzY=","avatar_url":"https://avatars3.githubusercontent.com/u/4626076?v=4","gravatar_id":"","url":"https://api.github.com/users/jmjatlanta","html_url":"https://github.com/jmjatlanta","followers_url":"https://api.github.com/users/jmjatlanta/followers","following_url":"https://api.github.com/users/jmjatlanta/following{/other_user}","gists_url":"https://api.github.com/users/jmjatlanta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmjatlanta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmjatlanta/subscriptions","organizations_url":"https://api.github.com/users/jmjatlanta/orgs","repos_url":"https://api.github.com/users/jmjatlanta/repos","events_url":"https://api.github.com/users/jmjatlanta/events{/privacy}","received_events_url":"https://api.github.com/users/jmjatlanta/received_events","type":"User","site_admin":false},"body":"And now fixed the SIGSEGV in the test. See this commit: https://github.com/bitshares/bitshares-fc/commit/a549c6e6db81854031cc5c3e42dc1e65c4d4389c","created_at":"2018-07-02T15:46:56Z","updated_at":"2018-07-02T15:46:57Z","html_url":"https://github.com/bitshares/bitshares-fc/pull/56#discussion_r199541114","pull_request_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/56","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/comments/199541114"},"html":{"href":"https://github.com/bitshares/bitshares-fc/pull/56#discussion_r199541114"},"pull_request":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/56"}},"in_reply_to_id":199354497},"pull_request":{"url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/56","id":198206837,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MjA2ODM3","html_url":"https://github.com/bitshares/bitshares-fc/pull/56","diff_url":"https://github.com/bitshares/bitshares-fc/pull/56.diff","patch_url":"https://github.com/bitshares/bitshares-fc/pull/56.patch","issue_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues/56","number":56,"state":"open","locked":false,"title":"fixed #809 issue","user":{"login":"nanomobile","id":3896745,"node_id":"MDQ6VXNlcjM4OTY3NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3896745?v=4","gravatar_id":"","url":"https://api.github.com/users/nanomobile","html_url":"https://github.com/nanomobile","followers_url":"https://api.github.com/users/nanomobile/followers","following_url":"https://api.github.com/users/nanomobile/following{/other_user}","gists_url":"https://api.github.com/users/nanomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomobile/subscriptions","organizations_url":"https://api.github.com/users/nanomobile/orgs","repos_url":"https://api.github.com/users/nanomobile/repos","events_url":"https://api.github.com/users/nanomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nanomobile/received_events","type":"User","site_admin":false},"body":"https://github.com/bitshares/bitshares-core/issues/809","created_at":"2018-06-29T03:34:56Z","updated_at":"2018-07-02T15:46:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c0566ab8a26b5d377b848a11e374d1c8b4f38373","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/56/commits","review_comments_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/56/comments","review_comment_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues/56/comments","statuses_url":"https://api.github.com/repos/bitshares/bitshares-fc/statuses/3b39aa190ebd96c441ca7a91981241905a2d392a","head":{"label":"nanomobile:valera_issue_809","ref":"valera_issue_809","sha":"3b39aa190ebd96c441ca7a91981241905a2d392a","user":{"login":"nanomobile","id":3896745,"node_id":"MDQ6VXNlcjM4OTY3NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3896745?v=4","gravatar_id":"","url":"https://api.github.com/users/nanomobile","html_url":"https://github.com/nanomobile","followers_url":"https://api.github.com/users/nanomobile/followers","following_url":"https://api.github.com/users/nanomobile/following{/other_user}","gists_url":"https://api.github.com/users/nanomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomobile/subscriptions","organizations_url":"https://api.github.com/users/nanomobile/orgs","repos_url":"https://api.github.com/users/nanomobile/repos","events_url":"https://api.github.com/users/nanomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nanomobile/received_events","type":"User","site_admin":false},"repo":{"id":139096683,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwOTY2ODM=","name":"bitshares-fc","full_name":"nanomobile/bitshares-fc","owner":{"login":"nanomobile","id":3896745,"node_id":"MDQ6VXNlcjM4OTY3NDU=","avatar_url":"https://avatars2.githubusercontent.com/u/3896745?v=4","gravatar_id":"","url":"https://api.github.com/users/nanomobile","html_url":"https://github.com/nanomobile","followers_url":"https://api.github.com/users/nanomobile/followers","following_url":"https://api.github.com/users/nanomobile/following{/other_user}","gists_url":"https://api.github.com/users/nanomobile/gists{/gist_id}","starred_url":"https://api.github.com/users/nanomobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nanomobile/subscriptions","organizations_url":"https://api.github.com/users/nanomobile/orgs","repos_url":"https://api.github.com/users/nanomobile/repos","events_url":"https://api.github.com/users/nanomobile/events{/privacy}","received_events_url":"https://api.github.com/users/nanomobile/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nanomobile/bitshares-fc","description":"Fast-compiling C++ library","fork":true,"url":"https://api.github.com/repos/nanomobile/bitshares-fc","forks_url":"https://api.github.com/repos/nanomobile/bitshares-fc/forks","keys_url":"https://api.github.com/repos/nanomobile/bitshares-fc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nanomobile/bitshares-fc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nanomobile/bitshares-fc/teams","hooks_url":"https://api.github.com/repos/nanomobile/bitshares-fc/hooks","issue_events_url":"https://api.github.com/repos/nanomobile/bitshares-fc/issues/events{/number}","events_url":"https://api.github.com/repos/nanomobile/bitshares-fc/events","assignees_url":"https://api.github.com/repos/nanomobile/bitshares-fc/assignees{/user}","branches_url":"https://api.github.com/repos/nanomobile/bitshares-fc/branches{/branch}","tags_url":"https://api.github.com/repos/nanomobile/bitshares-fc/tags","blobs_url":"https://api.github.com/repos/nanomobile/bitshares-fc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nanomobile/bitshares-fc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nanomobile/bitshares-fc/git/refs{/sha}","trees_url":"https://api.github.com/repos/nanomobile/bitshares-fc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nanomobile/bitshares-fc/statuses/{sha}","languages_url":"https://api.github.com/repos/nanomobile/bitshares-fc/languages","stargazers_url":"https://api.github.com/repos/nanomobile/bitshares-fc/stargazers","contributors_url":"https://api.github.com/repos/nanomobile/bitshares-fc/contributors","subscribers_url":"https://api.github.com/repos/nanomobile/bitshares-fc/subscribers","subscription_url":"https://api.github.com/repos/nanomobile/bitshares-fc/subscription","commits_url":"https://api.github.com/repos/nanomobile/bitshares-fc/commits{/sha}","git_commits_url":"https://api.github.com/repos/nanomobile/bitshares-fc/git/commits{/sha}","comments_url":"https://api.github.com/repos/nanomobile/bitshares-fc/comments{/number}","issue_comment_url":"https://api.github.com/repos/nanomobile/bitshares-fc/issues/comments{/number}","contents_url":"https://api.github.com/repos/nanomobile/bitshares-fc/contents/{+path}","compare_url":"https://api.github.com/repos/nanomobile/bitshares-fc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nanomobile/bitshares-fc/merges","archive_url":"https://api.github.com/repos/nanomobile/bitshares-fc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nanomobile/bitshares-fc/downloads","issues_url":"https://api.github.com/repos/nanomobile/bitshares-fc/issues{/number}","pulls_url":"https://api.github.com/repos/nanomobile/bitshares-fc/pulls{/number}","milestones_url":"https://api.github.com/repos/nanomobile/bitshares-fc/milestones{/number}","notifications_url":"https://api.github.com/repos/nanomobile/bitshares-fc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nanomobile/bitshares-fc/labels{/name}","releases_url":"https://api.github.com/repos/nanomobile/bitshares-fc/releases{/id}","deployments_url":"https://api.github.com/repos/nanomobile/bitshares-fc/deployments","created_at":"2018-06-29T03:31:23Z","updated_at":"2018-06-29T03:31:26Z","pushed_at":"2018-06-30T06:25:00Z","git_url":"git://github.com/nanomobile/bitshares-fc.git","ssh_url":"git@github.com:nanomobile/bitshares-fc.git","clone_url":"https://github.com/nanomobile/bitshares-fc.git","svn_url":"https://github.com/nanomobile/bitshares-fc","homepage":"","size":4918,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitshares:master","ref":"master","sha":"d8437ac286cdb408a5fcef81342f4b280069f630","user":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"repo":{"id":78883567,"node_id":"MDEwOlJlcG9zaXRvcnk3ODg4MzU2Nw==","name":"bitshares-fc","full_name":"bitshares/bitshares-fc","owner":{"login":"bitshares","id":6914094,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTQwOTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6914094?v=4","gravatar_id":"","url":"https://api.github.com/users/bitshares","html_url":"https://github.com/bitshares","followers_url":"https://api.github.com/users/bitshares/followers","following_url":"https://api.github.com/users/bitshares/following{/other_user}","gists_url":"https://api.github.com/users/bitshares/gists{/gist_id}","starred_url":"https://api.github.com/users/bitshares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitshares/subscriptions","organizations_url":"https://api.github.com/users/bitshares/orgs","repos_url":"https://api.github.com/users/bitshares/repos","events_url":"https://api.github.com/users/bitshares/events{/privacy}","received_events_url":"https://api.github.com/users/bitshares/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitshares/bitshares-fc","description":"Fast-compiling C++ library","fork":true,"url":"https://api.github.com/repos/bitshares/bitshares-fc","forks_url":"https://api.github.com/repos/bitshares/bitshares-fc/forks","keys_url":"https://api.github.com/repos/bitshares/bitshares-fc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitshares/bitshares-fc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitshares/bitshares-fc/teams","hooks_url":"https://api.github.com/repos/bitshares/bitshares-fc/hooks","issue_events_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues/events{/number}","events_url":"https://api.github.com/repos/bitshares/bitshares-fc/events","assignees_url":"https://api.github.com/repos/bitshares/bitshares-fc/assignees{/user}","branches_url":"https://api.github.com/repos/bitshares/bitshares-fc/branches{/branch}","tags_url":"https://api.github.com/repos/bitshares/bitshares-fc/tags","blobs_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitshares/bitshares-fc/statuses/{sha}","languages_url":"https://api.github.com/repos/bitshares/bitshares-fc/languages","stargazers_url":"https://api.github.com/repos/bitshares/bitshares-fc/stargazers","contributors_url":"https://api.github.com/repos/bitshares/bitshares-fc/contributors","subscribers_url":"https://api.github.com/repos/bitshares/bitshares-fc/subscribers","subscription_url":"https://api.github.com/repos/bitshares/bitshares-fc/subscription","commits_url":"https://api.github.com/repos/bitshares/bitshares-fc/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitshares/bitshares-fc/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitshares/bitshares-fc/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitshares/bitshares-fc/contents/{+path}","compare_url":"https://api.github.com/repos/bitshares/bitshares-fc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitshares/bitshares-fc/merges","archive_url":"https://api.github.com/repos/bitshares/bitshares-fc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitshares/bitshares-fc/downloads","issues_url":"https://api.github.com/repos/bitshares/bitshares-fc/issues{/number}","pulls_url":"https://api.github.com/repos/bitshares/bitshares-fc/pulls{/number}","milestones_url":"https://api.github.com/repos/bitshares/bitshares-fc/milestones{/number}","notifications_url":"https://api.github.com/repos/bitshares/bitshares-fc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitshares/bitshares-fc/labels{/name}","releases_url":"https://api.github.com/repos/bitshares/bitshares-fc/releases{/id}","deployments_url":"https://api.github.com/repos/bitshares/bitshares-fc/deployments","created_at":"2017-01-13T20:20:23Z","updated_at":"2018-06-28T07:54:12Z","pushed_at":"2018-07-02T15:45:02Z","git_url":"git://github.com/bitshares/bitshares-fc.git","ssh_url":"git@github.com:bitshares/bitshares-fc.git","clone_url":"https://github.com/bitshares/bitshares-fc.git","svn_url":"https://github.com/bitshares/bitshares-fc","homepage":"","size":4915,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":48,"open_issues":6,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/56"},"html":{"href":"https://github.com/bitshares/bitshares-fc/pull/56"},"issue":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/issues/56"},"comments":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/bitshares/bitshares-fc/statuses/3b39aa190ebd96c441ca7a91981241905a2d392a"}},"author_association":"NONE"}}
{"actor":{"display_login":"jmjatlanta"}}