{"action":"opened","number":1282,"pull_request":{"url":"https://api.github.com/repos/ros-visualization/rviz/pulls/1282","id":210248802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjQ4ODAy","html_url":"https://github.com/ros-visualization/rviz/pull/1282","diff_url":"https://github.com/ros-visualization/rviz/pull/1282.diff","patch_url":"https://github.com/ros-visualization/rviz/pull/1282.patch","issue_url":"https://api.github.com/repos/ros-visualization/rviz/issues/1282","number":1282,"state":"open","locked":false,"title":"Replace display error assert with warning, fallback and error ","user":{"login":"josephduchesne","id":2277843,"node_id":"MDQ6VXNlcjIyNzc4NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/2277843?v=4","gravatar_id":"","url":"https://api.github.com/users/josephduchesne","html_url":"https://github.com/josephduchesne","followers_url":"https://api.github.com/users/josephduchesne/followers","following_url":"https://api.github.com/users/josephduchesne/following{/other_user}","gists_url":"https://api.github.com/users/josephduchesne/gists{/gist_id}","starred_url":"https://api.github.com/users/josephduchesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephduchesne/subscriptions","organizations_url":"https://api.github.com/users/josephduchesne/orgs","repos_url":"https://api.github.com/users/josephduchesne/repos","events_url":"https://api.github.com/users/josephduchesne/events{/privacy}","received_events_url":"https://api.github.com/users/josephduchesne/received_events","type":"User","site_admin":false},"body":"Replace assert with warning, fallback and error so that when in release mode, librviz does not segfault with a misconfigured DISPLAY env.\r\n\r\nIn our use of librviz, RenderSystem::setupDummyWindowId() was segfaulting since display was not set correctly. This will provide warnings, fallback and a useful error in such cases.","created_at":"2018-08-22T20:05:43Z","updated_at":"2018-08-22T20:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/1282/commits","review_comments_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/1282/comments","review_comment_url":"https://api.github.com/repos/ros-visualization/rviz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros-visualization/rviz/issues/1282/comments","statuses_url":"https://api.github.com/repos/ros-visualization/rviz/statuses/7cb434b94786bac81bbf059b1b8d780c32b0e372","head":{"label":"josephduchesne:fix-display-init-edge-case","ref":"fix-display-init-edge-case","sha":"7cb434b94786bac81bbf059b1b8d780c32b0e372","user":{"login":"josephduchesne","id":2277843,"node_id":"MDQ6VXNlcjIyNzc4NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/2277843?v=4","gravatar_id":"","url":"https://api.github.com/users/josephduchesne","html_url":"https://github.com/josephduchesne","followers_url":"https://api.github.com/users/josephduchesne/followers","following_url":"https://api.github.com/users/josephduchesne/following{/other_user}","gists_url":"https://api.github.com/users/josephduchesne/gists{/gist_id}","starred_url":"https://api.github.com/users/josephduchesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephduchesne/subscriptions","organizations_url":"https://api.github.com/users/josephduchesne/orgs","repos_url":"https://api.github.com/users/josephduchesne/repos","events_url":"https://api.github.com/users/josephduchesne/events{/privacy}","received_events_url":"https://api.github.com/users/josephduchesne/received_events","type":"User","site_admin":false},"repo":{"id":145752809,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3NTI4MDk=","name":"rviz","full_name":"josephduchesne/rviz","owner":{"login":"josephduchesne","id":2277843,"node_id":"MDQ6VXNlcjIyNzc4NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/2277843?v=4","gravatar_id":"","url":"https://api.github.com/users/josephduchesne","html_url":"https://github.com/josephduchesne","followers_url":"https://api.github.com/users/josephduchesne/followers","following_url":"https://api.github.com/users/josephduchesne/following{/other_user}","gists_url":"https://api.github.com/users/josephduchesne/gists{/gist_id}","starred_url":"https://api.github.com/users/josephduchesne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephduchesne/subscriptions","organizations_url":"https://api.github.com/users/josephduchesne/orgs","repos_url":"https://api.github.com/users/josephduchesne/repos","events_url":"https://api.github.com/users/josephduchesne/events{/privacy}","received_events_url":"https://api.github.com/users/josephduchesne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/josephduchesne/rviz","description":"ROS 3D Robot Visualizer","fork":true,"url":"https://api.github.com/repos/josephduchesne/rviz","forks_url":"https://api.github.com/repos/josephduchesne/rviz/forks","keys_url":"https://api.github.com/repos/josephduchesne/rviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/josephduchesne/rviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/josephduchesne/rviz/teams","hooks_url":"https://api.github.com/repos/josephduchesne/rviz/hooks","issue_events_url":"https://api.github.com/repos/josephduchesne/rviz/issues/events{/number}","events_url":"https://api.github.com/repos/josephduchesne/rviz/events","assignees_url":"https://api.github.com/repos/josephduchesne/rviz/assignees{/user}","branches_url":"https://api.github.com/repos/josephduchesne/rviz/branches{/branch}","tags_url":"https://api.github.com/repos/josephduchesne/rviz/tags","blobs_url":"https://api.github.com/repos/josephduchesne/rviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/josephduchesne/rviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/josephduchesne/rviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/josephduchesne/rviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/josephduchesne/rviz/statuses/{sha}","languages_url":"https://api.github.com/repos/josephduchesne/rviz/languages","stargazers_url":"https://api.github.com/repos/josephduchesne/rviz/stargazers","contributors_url":"https://api.github.com/repos/josephduchesne/rviz/contributors","subscribers_url":"https://api.github.com/repos/josephduchesne/rviz/subscribers","subscription_url":"https://api.github.com/repos/josephduchesne/rviz/subscription","commits_url":"https://api.github.com/repos/josephduchesne/rviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/josephduchesne/rviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/josephduchesne/rviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/josephduchesne/rviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/josephduchesne/rviz/contents/{+path}","compare_url":"https://api.github.com/repos/josephduchesne/rviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/josephduchesne/rviz/merges","archive_url":"https://api.github.com/repos/josephduchesne/rviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/josephduchesne/rviz/downloads","issues_url":"https://api.github.com/repos/josephduchesne/rviz/issues{/number}","pulls_url":"https://api.github.com/repos/josephduchesne/rviz/pulls{/number}","milestones_url":"https://api.github.com/repos/josephduchesne/rviz/milestones{/number}","notifications_url":"https://api.github.com/repos/josephduchesne/rviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/josephduchesne/rviz/labels{/name}","releases_url":"https://api.github.com/repos/josephduchesne/rviz/releases{/id}","deployments_url":"https://api.github.com/repos/josephduchesne/rviz/deployments","created_at":"2018-08-22T19:21:13Z","updated_at":"2018-08-22T19:21:17Z","pushed_at":"2018-08-22T19:40:30Z","git_url":"git://github.com/josephduchesne/rviz.git","ssh_url":"git@github.com:josephduchesne/rviz.git","clone_url":"https://github.com/josephduchesne/rviz.git","svn_url":"https://github.com/josephduchesne/rviz","homepage":null,"size":10919,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"melodic-devel"}},"base":{"label":"ros-visualization:kinetic-devel","ref":"kinetic-devel","sha":"87742e4b8f40d8fe7e2a6952065651266faf73ba","user":{"login":"ros-visualization","id":2328629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2328629?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"repo":{"id":5860736,"node_id":"MDEwOlJlcG9zaXRvcnk1ODYwNzM2","name":"rviz","full_name":"ros-visualization/rviz","owner":{"login":"ros-visualization","id":2328629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMjg2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/2328629?v=4","gravatar_id":"","url":"https://api.github.com/users/ros-visualization","html_url":"https://github.com/ros-visualization","followers_url":"https://api.github.com/users/ros-visualization/followers","following_url":"https://api.github.com/users/ros-visualization/following{/other_user}","gists_url":"https://api.github.com/users/ros-visualization/gists{/gist_id}","starred_url":"https://api.github.com/users/ros-visualization/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros-visualization/subscriptions","organizations_url":"https://api.github.com/users/ros-visualization/orgs","repos_url":"https://api.github.com/users/ros-visualization/repos","events_url":"https://api.github.com/users/ros-visualization/events{/privacy}","received_events_url":"https://api.github.com/users/ros-visualization/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros-visualization/rviz","description":"ROS 3D Robot Visualizer","fork":false,"url":"https://api.github.com/repos/ros-visualization/rviz","forks_url":"https://api.github.com/repos/ros-visualization/rviz/forks","keys_url":"https://api.github.com/repos/ros-visualization/rviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros-visualization/rviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros-visualization/rviz/teams","hooks_url":"https://api.github.com/repos/ros-visualization/rviz/hooks","issue_events_url":"https://api.github.com/repos/ros-visualization/rviz/issues/events{/number}","events_url":"https://api.github.com/repos/ros-visualization/rviz/events","assignees_url":"https://api.github.com/repos/ros-visualization/rviz/assignees{/user}","branches_url":"https://api.github.com/repos/ros-visualization/rviz/branches{/branch}","tags_url":"https://api.github.com/repos/ros-visualization/rviz/tags","blobs_url":"https://api.github.com/repos/ros-visualization/rviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros-visualization/rviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros-visualization/rviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros-visualization/rviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros-visualization/rviz/statuses/{sha}","languages_url":"https://api.github.com/repos/ros-visualization/rviz/languages","stargazers_url":"https://api.github.com/repos/ros-visualization/rviz/stargazers","contributors_url":"https://api.github.com/repos/ros-visualization/rviz/contributors","subscribers_url":"https://api.github.com/repos/ros-visualization/rviz/subscribers","subscription_url":"https://api.github.com/repos/ros-visualization/rviz/subscription","commits_url":"https://api.github.com/repos/ros-visualization/rviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros-visualization/rviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros-visualization/rviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros-visualization/rviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros-visualization/rviz/contents/{+path}","compare_url":"https://api.github.com/repos/ros-visualization/rviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros-visualization/rviz/merges","archive_url":"https://api.github.com/repos/ros-visualization/rviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros-visualization/rviz/downloads","issues_url":"https://api.github.com/repos/ros-visualization/rviz/issues{/number}","pulls_url":"https://api.github.com/repos/ros-visualization/rviz/pulls{/number}","milestones_url":"https://api.github.com/repos/ros-visualization/rviz/milestones{/number}","notifications_url":"https://api.github.com/repos/ros-visualization/rviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros-visualization/rviz/labels{/name}","releases_url":"https://api.github.com/repos/ros-visualization/rviz/releases{/id}","deployments_url":"https://api.github.com/repos/ros-visualization/rviz/deployments","created_at":"2012-09-18T18:15:03Z","updated_at":"2018-08-21T09:25:13Z","pushed_at":"2018-08-14T04:29:51Z","git_url":"git://github.com/ros-visualization/rviz.git","ssh_url":"git@github.com:ros-visualization/rviz.git","clone_url":"https://github.com/ros-visualization/rviz.git","svn_url":"https://github.com/ros-visualization/rviz","homepage":null,"size":10919,"stargazers_count":205,"watchers_count":205,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":160,"license":null,"forks":253,"open_issues":160,"watchers":205,"default_branch":"melodic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/1282"},"html":{"href":"https://github.com/ros-visualization/rviz/pull/1282"},"issue":{"href":"https://api.github.com/repos/ros-visualization/rviz/issues/1282"},"comments":{"href":"https://api.github.com/repos/ros-visualization/rviz/issues/1282/comments"},"review_comments":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/1282/comments"},"review_comment":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros-visualization/rviz/pulls/1282/commits"},"statuses":{"href":"https://api.github.com/repos/ros-visualization/rviz/statuses/7cb434b94786bac81bbf059b1b8d780c32b0e372"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":12,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"josephduchesne"}}