{"action":"created","comment":{"url":"https://api.github.com/repos/cbeust/testng/pulls/comments/232446195","pull_request_review_id":173655260,"id":232446195,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ0NjE5NQ==","diff_hunk":"@@ -1309,6 +1312,18 @@ private void handleInvocationResults(\n     }\n   }\n \n+  private IRetryAnalyzer getRetryAnalyzerConsideringMethodParameteters(ITestNGMethod tm, ITestResult tr) {\n+    Object[] key = tr.getParameters();\n+    IRetryAnalyzer retryAnalyzer = tm.getRetryAnalyzer();\n+    if ((key != null && key.length != 0) && retryAnalyzer != null) {\n+      String keyAsString = tm.getTestClass().getRealClass().getName() + \"_\" +\n+          tm.getMethodName() + \"_\" + Arrays.toString(key);\n+      retryAnalyzer = m_testMethodToRetryAnalyzer.computeIfAbsent(keyAsString,\n+          o -> ClassHelper.newInstance(tm.getRetryAnalyzer().getClass()));","path":"src/main/java/org/testng/internal/Invoker.java","position":37,"original_position":37,"commit_id":"0592f97b5cd2db038a6cfcd5fc516561ad593002","original_commit_id":"0592f97b5cd2db038a6cfcd5fc516561ad593002","user":{"login":"juherr","id":254697,"node_id":"MDQ6VXNlcjI1NDY5Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/254697?v=4","gravatar_id":"","url":"https://api.github.com/users/juherr","html_url":"https://github.com/juherr","followers_url":"https://api.github.com/users/juherr/followers","following_url":"https://api.github.com/users/juherr/following{/other_user}","gists_url":"https://api.github.com/users/juherr/gists{/gist_id}","starred_url":"https://api.github.com/users/juherr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juherr/subscriptions","organizations_url":"https://api.github.com/users/juherr/orgs","repos_url":"https://api.github.com/users/juherr/repos","events_url":"https://api.github.com/users/juherr/events{/privacy}","received_events_url":"https://api.github.com/users/juherr/received_events","type":"User","site_admin":false},"body":"If I understand well the fix, we need a new instance by test method (or test result) instance?\r\nDoes it work if you map by TestResult instance (it will simplify the code)?\r\n\r\nI wonder if `tm.getRetryAnalyzer()` is broken and should be deprecated. Then maybe the current logic could be moved somewhere else.","created_at":"2018-11-10T08:37:26Z","updated_at":"2018-11-10T08:37:27Z","html_url":"https://github.com/cbeust/testng/pull/1948#discussion_r232446195","pull_request_url":"https://api.github.com/repos/cbeust/testng/pulls/1948","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments/232446195"},"html":{"href":"https://github.com/cbeust/testng/pull/1948#discussion_r232446195"},"pull_request":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1948"}}},"pull_request":{"url":"https://api.github.com/repos/cbeust/testng/pulls/1948","id":229876846,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODc2ODQ2","html_url":"https://github.com/cbeust/testng/pull/1948","diff_url":"https://github.com/cbeust/testng/pull/1948.diff","patch_url":"https://github.com/cbeust/testng/pull/1948.patch","issue_url":"https://api.github.com/repos/cbeust/testng/issues/1948","number":1948,"state":"open","locked":false,"title":"RetryAnalyzer should work with a data provider","user":{"login":"krmahadevan","id":909773,"node_id":"MDQ6VXNlcjkwOTc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"body":"Closes #1946\r\n\r\nFixes #1946 .\r\n\r\n### Did you remember to?\r\n\r\n- [X] Add test case(s)\r\n- [X] Update `CHANGES.txt`\r\n\r\nWe encourage pull requests that:\r\n\r\n* Add new features to TestNG (or)\r\n* Fix bugs in TestNG\r\n\r\nIf your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the \r\n[TestNG-dev](https://groups.google.com/forum/#!forum/testng-dev) before you spend time working on it.\r\n","created_at":"2018-11-10T07:51:16Z","updated_at":"2018-11-10T08:37:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c1dcb0d2f95c56ae6bce5b8dfa95af3248718a0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cbeust","id":92322,"node_id":"MDQ6VXNlcjkyMzIy","avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cbeust/testng/pulls/1948/commits","review_comments_url":"https://api.github.com/repos/cbeust/testng/pulls/1948/comments","review_comment_url":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cbeust/testng/issues/1948/comments","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/0592f97b5cd2db038a6cfcd5fc516561ad593002","head":{"label":"krmahadevan:fix-1946","ref":"fix-1946","sha":"0592f97b5cd2db038a6cfcd5fc516561ad593002","user":{"login":"krmahadevan","id":909773,"node_id":"MDQ6VXNlcjkwOTc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"repo":{"id":35460849,"node_id":"MDEwOlJlcG9zaXRvcnkzNTQ2MDg0OQ==","name":"testng","full_name":"krmahadevan/testng","private":false,"owner":{"login":"krmahadevan","id":909773,"node_id":"MDQ6VXNlcjkwOTc3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/909773?v=4","gravatar_id":"","url":"https://api.github.com/users/krmahadevan","html_url":"https://github.com/krmahadevan","followers_url":"https://api.github.com/users/krmahadevan/followers","following_url":"https://api.github.com/users/krmahadevan/following{/other_user}","gists_url":"https://api.github.com/users/krmahadevan/gists{/gist_id}","starred_url":"https://api.github.com/users/krmahadevan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krmahadevan/subscriptions","organizations_url":"https://api.github.com/users/krmahadevan/orgs","repos_url":"https://api.github.com/users/krmahadevan/repos","events_url":"https://api.github.com/users/krmahadevan/events{/privacy}","received_events_url":"https://api.github.com/users/krmahadevan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/krmahadevan/testng","description":"TestNG testing framework","fork":true,"url":"https://api.github.com/repos/krmahadevan/testng","forks_url":"https://api.github.com/repos/krmahadevan/testng/forks","keys_url":"https://api.github.com/repos/krmahadevan/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/krmahadevan/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/krmahadevan/testng/teams","hooks_url":"https://api.github.com/repos/krmahadevan/testng/hooks","issue_events_url":"https://api.github.com/repos/krmahadevan/testng/issues/events{/number}","events_url":"https://api.github.com/repos/krmahadevan/testng/events","assignees_url":"https://api.github.com/repos/krmahadevan/testng/assignees{/user}","branches_url":"https://api.github.com/repos/krmahadevan/testng/branches{/branch}","tags_url":"https://api.github.com/repos/krmahadevan/testng/tags","blobs_url":"https://api.github.com/repos/krmahadevan/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/krmahadevan/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/krmahadevan/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/krmahadevan/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/krmahadevan/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/krmahadevan/testng/languages","stargazers_url":"https://api.github.com/repos/krmahadevan/testng/stargazers","contributors_url":"https://api.github.com/repos/krmahadevan/testng/contributors","subscribers_url":"https://api.github.com/repos/krmahadevan/testng/subscribers","subscription_url":"https://api.github.com/repos/krmahadevan/testng/subscription","commits_url":"https://api.github.com/repos/krmahadevan/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/krmahadevan/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/krmahadevan/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/krmahadevan/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/krmahadevan/testng/contents/{+path}","compare_url":"https://api.github.com/repos/krmahadevan/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/krmahadevan/testng/merges","archive_url":"https://api.github.com/repos/krmahadevan/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/krmahadevan/testng/downloads","issues_url":"https://api.github.com/repos/krmahadevan/testng/issues{/number}","pulls_url":"https://api.github.com/repos/krmahadevan/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/krmahadevan/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/krmahadevan/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/krmahadevan/testng/labels{/name}","releases_url":"https://api.github.com/repos/krmahadevan/testng/releases{/id}","deployments_url":"https://api.github.com/repos/krmahadevan/testng/deployments","created_at":"2015-05-12T02:00:29Z","updated_at":"2018-10-28T15:59:33Z","pushed_at":"2018-11-10T07:49:42Z","git_url":"git://github.com/krmahadevan/testng.git","ssh_url":"git@github.com:krmahadevan/testng.git","clone_url":"https://github.com/krmahadevan/testng.git","svn_url":"https://github.com/krmahadevan/testng","homepage":"http://testng.org","size":28995,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cbeust:master","ref":"master","sha":"9cb1d2f4e9d7cca48cf44f67aef39a2a335594bd","user":{"login":"cbeust","id":92322,"node_id":"MDQ6VXNlcjkyMzIy","avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"repo":{"id":745749,"node_id":"MDEwOlJlcG9zaXRvcnk3NDU3NDk=","name":"testng","full_name":"cbeust/testng","private":false,"owner":{"login":"cbeust","id":92322,"node_id":"MDQ6VXNlcjkyMzIy","avatar_url":"https://avatars2.githubusercontent.com/u/92322?v=4","gravatar_id":"","url":"https://api.github.com/users/cbeust","html_url":"https://github.com/cbeust","followers_url":"https://api.github.com/users/cbeust/followers","following_url":"https://api.github.com/users/cbeust/following{/other_user}","gists_url":"https://api.github.com/users/cbeust/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeust/subscriptions","organizations_url":"https://api.github.com/users/cbeust/orgs","repos_url":"https://api.github.com/users/cbeust/repos","events_url":"https://api.github.com/users/cbeust/events{/privacy}","received_events_url":"https://api.github.com/users/cbeust/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cbeust/testng","description":"TestNG testing framework","fork":false,"url":"https://api.github.com/repos/cbeust/testng","forks_url":"https://api.github.com/repos/cbeust/testng/forks","keys_url":"https://api.github.com/repos/cbeust/testng/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbeust/testng/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbeust/testng/teams","hooks_url":"https://api.github.com/repos/cbeust/testng/hooks","issue_events_url":"https://api.github.com/repos/cbeust/testng/issues/events{/number}","events_url":"https://api.github.com/repos/cbeust/testng/events","assignees_url":"https://api.github.com/repos/cbeust/testng/assignees{/user}","branches_url":"https://api.github.com/repos/cbeust/testng/branches{/branch}","tags_url":"https://api.github.com/repos/cbeust/testng/tags","blobs_url":"https://api.github.com/repos/cbeust/testng/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbeust/testng/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbeust/testng/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbeust/testng/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbeust/testng/statuses/{sha}","languages_url":"https://api.github.com/repos/cbeust/testng/languages","stargazers_url":"https://api.github.com/repos/cbeust/testng/stargazers","contributors_url":"https://api.github.com/repos/cbeust/testng/contributors","subscribers_url":"https://api.github.com/repos/cbeust/testng/subscribers","subscription_url":"https://api.github.com/repos/cbeust/testng/subscription","commits_url":"https://api.github.com/repos/cbeust/testng/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbeust/testng/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbeust/testng/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbeust/testng/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbeust/testng/contents/{+path}","compare_url":"https://api.github.com/repos/cbeust/testng/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbeust/testng/merges","archive_url":"https://api.github.com/repos/cbeust/testng/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbeust/testng/downloads","issues_url":"https://api.github.com/repos/cbeust/testng/issues{/number}","pulls_url":"https://api.github.com/repos/cbeust/testng/pulls{/number}","milestones_url":"https://api.github.com/repos/cbeust/testng/milestones{/number}","notifications_url":"https://api.github.com/repos/cbeust/testng/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbeust/testng/labels{/name}","releases_url":"https://api.github.com/repos/cbeust/testng/releases{/id}","deployments_url":"https://api.github.com/repos/cbeust/testng/deployments","created_at":"2010-06-28T23:10:17Z","updated_at":"2018-11-10T01:43:43Z","pushed_at":"2018-11-10T07:51:16Z","git_url":"git://github.com/cbeust/testng.git","ssh_url":"git@github.com:cbeust/testng.git","clone_url":"https://github.com/cbeust/testng.git","svn_url":"https://github.com/cbeust/testng","homepage":"http://testng.org","size":28995,"stargazers_count":1127,"watchers_count":1127,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":707,"mirror_url":null,"archived":false,"open_issues_count":267,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":707,"open_issues":267,"watchers":1127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1948"},"html":{"href":"https://github.com/cbeust/testng/pull/1948"},"issue":{"href":"https://api.github.com/repos/cbeust/testng/issues/1948"},"comments":{"href":"https://api.github.com/repos/cbeust/testng/issues/1948/comments"},"review_comments":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1948/comments"},"review_comment":{"href":"https://api.github.com/repos/cbeust/testng/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cbeust/testng/pulls/1948/commits"},"statuses":{"href":"https://api.github.com/repos/cbeust/testng/statuses/0592f97b5cd2db038a6cfcd5fc516561ad593002"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"juherr"}}