{"action":"created","issue":{"url":"https://api.github.com/repos/pybee/toga/issues/383","repository_url":"https://api.github.com/repos/pybee/toga","labels_url":"https://api.github.com/repos/pybee/toga/issues/383/labels{/name}","comments_url":"https://api.github.com/repos/pybee/toga/issues/383/comments","events_url":"https://api.github.com/repos/pybee/toga/issues/383/events","html_url":"https://github.com/pybee/toga/pull/383","id":300880449,"number":383,"title":"[WIP] Convert Canvas Widget to Use a Drawing Stack","user":{"login":"danyeaw","id":10014976,"avatar_url":"https://avatars1.githubusercontent.com/u/10014976?v=4","gravatar_id":"","url":"https://api.github.com/users/danyeaw","html_url":"https://github.com/danyeaw","followers_url":"https://api.github.com/users/danyeaw/followers","following_url":"https://api.github.com/users/danyeaw/following{/other_user}","gists_url":"https://api.github.com/users/danyeaw/gists{/gist_id}","starred_url":"https://api.github.com/users/danyeaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danyeaw/subscriptions","organizations_url":"https://api.github.com/users/danyeaw/orgs","repos_url":"https://api.github.com/users/danyeaw/repos","events_url":"https://api.github.com/users/danyeaw/events{/privacy}","received_events_url":"https://api.github.com/users/danyeaw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-28T03:41:25Z","updated_at":"2018-03-03T02:57:30Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/pybee/toga/pulls/383","html_url":"https://github.com/pybee/toga/pull/383","diff_url":"https://github.com/pybee/toga/pull/383.diff","patch_url":"https://github.com/pybee/toga/pull/383.patch"},"body":"In #319 we discussed that it was desired to remove the callbacks created by using an on_draw handler, and instead push drawing commands to a stack to be drawn with.\r\n\r\n## PR Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n- [ ] All new features have been tested\r\n- [ ] All new features have been documented\r\n- [X] I have read the **CONTRIBUTING.md** file\r\n- [X] I will abide by the code of conduct\r\n\r\nQuestions:\r\nThe stack (called \"draw_commands\") is stored in the implementation right now, but the determination of whether to add or delete from the stack is made on the interface. I didn't like my initial attempt with everything on the implementation, since there was a lot of repetition in methods. But do you think it is better to keep the interface more clean? I would really appreciate any feedback in this area.\r\n\r\nCurrent status: the canvas widget is working properly and draws to the screen, but all tests are broken\r\n\r\n[ ] Fix tests\r\n[ ] Further testing with other contexts besides the default one"},"comment":{"url":"https://api.github.com/repos/pybee/toga/issues/comments/370111279","html_url":"https://github.com/pybee/toga/pull/383#issuecomment-370111279","issue_url":"https://api.github.com/repos/pybee/toga/issues/383","id":370111279,"user":{"login":"danyeaw","id":10014976,"avatar_url":"https://avatars1.githubusercontent.com/u/10014976?v=4","gravatar_id":"","url":"https://api.github.com/users/danyeaw","html_url":"https://github.com/danyeaw","followers_url":"https://api.github.com/users/danyeaw/followers","following_url":"https://api.github.com/users/danyeaw/following{/other_user}","gists_url":"https://api.github.com/users/danyeaw/gists{/gist_id}","starred_url":"https://api.github.com/users/danyeaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danyeaw/subscriptions","organizations_url":"https://api.github.com/users/danyeaw/orgs","repos_url":"https://api.github.com/users/danyeaw/repos","events_url":"https://api.github.com/users/danyeaw/events{/privacy}","received_events_url":"https://api.github.com/users/danyeaw/received_events","type":"User","site_admin":false},"created_at":"2018-03-03T02:57:30Z","updated_at":"2018-03-03T02:57:30Z","author_association":"MEMBER","body":"@DariusMontez Thanks! I'll take a look at those Tkinter docs."}}
{"actor":{"display_login":"danyeaw"}}