{"action":"created","comment":{"url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/comments/230741353","pull_request_review_id":171544256,"id":230741353,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDc0MTM1Mw==","diff_hunk":"@@ -26,6 +26,28 @@\n namespace RPG {\n \tclass SaveSystem {\n \tpublic:\n+\t\tenum ScreenRpgRt {","path":"src/generated/rpg_savesystem.h","position":null,"original_position":4,"commit_id":"3b1d092c5beab00d15e68437b8fb345e6fa7c1a4","original_commit_id":"5beb82a632955e63d944b851d891a80b60ccdf4a","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"body":"Well I guess we need to bikeshed this thing then. Here are some options:\r\n\r\n* SceneRPG_RT / scene_rpgrt\r\n* LegacyScene / legacy_scene\r\n* Scene / scene\r\n* Scene / scene - and change Player code / enums to use this\r\n\r\nVotes anyone?","created_at":"2018-11-05T13:04:28Z","updated_at":"2018-11-05T13:04:29Z","html_url":"https://github.com/EasyRPG/liblcf/pull/277#discussion_r230741353","pull_request_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/277","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/comments/230741353"},"html":{"href":"https://github.com/EasyRPG/liblcf/pull/277#discussion_r230741353"},"pull_request":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/277"}},"in_reply_to_id":230606714},"pull_request":{"url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/277","id":227811978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3ODExOTc4","html_url":"https://github.com/EasyRPG/liblcf/pull/277","diff_url":"https://github.com/EasyRPG/liblcf/pull/277.diff","patch_url":"https://github.com/EasyRPG/liblcf/pull/277.patch","issue_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/277","number":277,"state":"open","locked":false,"title":"SaveGame Fixes","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"body":"Depends on #268 \r\n\r\nThis PR is attempting to fix how LSD files are written from Player. A lot of this includes proper sizing of arrays and clearing out chunks which have the same value as in the LDB / LMU.\r\n\r\nThe way I'm testing this is:\r\n1. Create a very simple test game\r\n2. Start New Game and Save in `RPG_RT.exe`\r\n3. Start New Game and Save in `Player`\r\n4. Binary compare the resulting lsd files and track down differences.\r\n5. Start adding things to test game, and repeat the process.\r\n\r\nMost of this work will end up in liblcf, but some changes are needed in Player too. The corresponding Player PR is https://github.com/EasyRPG/Player/pull/1470\r\n\r\nMore work is needed here, but already I've come across some serious bugs in how we use save files and some unknown fields.\r\n\r\n@CherryDT\r\n\r\nWhat are these fields?\r\n* SaveSystem::screen 0x1\r\n* SavePartyLocation::stop_count 0x34\r\n\r\nOne very interesting problem is `Save::pictures`. For a new game, this array needs to be resized to exactly the number of a picture that this particular version of `RPG_RT.exe` supports.\r\n\r\nNumber of pictures changed quite a lot. I don't know all of the different versions and what their picture counts were.\r\n\r\nDoes anyone know:\r\n* What versions of rm2k and rm2k3 had picture count changes?\r\n* Can we accurately detect all of those versions?","created_at":"2018-11-02T02:12:06Z","updated_at":"2018-11-05T13:04:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61ae42ceb7a3b06ddbcdb0429db90fb0214c3b8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/EasyRPG/liblcf/milestones/7","html_url":"https://github.com/EasyRPG/liblcf/milestone/7","labels_url":"https://api.github.com/repos/EasyRPG/liblcf/milestones/7/labels","id":2068416,"node_id":"MDk6TWlsZXN0b25lMjA2ODQxNg==","number":7,"title":"0.5.5 (or 0.6.0) -> we will see","description":"","creator":{"login":"fdelapena","id":174885,"node_id":"MDQ6VXNlcjE3NDg4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174885?v=4","gravatar_id":"","url":"https://api.github.com/users/fdelapena","html_url":"https://github.com/fdelapena","followers_url":"https://api.github.com/users/fdelapena/followers","following_url":"https://api.github.com/users/fdelapena/following{/other_user}","gists_url":"https://api.github.com/users/fdelapena/gists{/gist_id}","starred_url":"https://api.github.com/users/fdelapena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdelapena/subscriptions","organizations_url":"https://api.github.com/users/fdelapena/orgs","repos_url":"https://api.github.com/users/fdelapena/repos","events_url":"https://api.github.com/users/fdelapena/events{/privacy}","received_events_url":"https://api.github.com/users/fdelapena/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":14,"state":"open","created_at":"2016-10-13T17:06:19Z","updated_at":"2018-11-04T20:27:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/277/commits","review_comments_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/277/comments","review_comment_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/277/comments","statuses_url":"https://api.github.com/repos/EasyRPG/liblcf/statuses/3b1d092c5beab00d15e68437b8fb345e6fa7c1a4","head":{"label":"fmatthew5876:lsd_defaults","ref":"lsd_defaults","sha":"3b1d092c5beab00d15e68437b8fb345e6fa7c1a4","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"repo":{"id":142932831,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MzI4MzE=","name":"liblcf","full_name":"fmatthew5876/liblcf","private":false,"owner":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fmatthew5876/liblcf","description":"Library to handle RPG Maker 2000/2003 and EasyRPG projects","fork":true,"url":"https://api.github.com/repos/fmatthew5876/liblcf","forks_url":"https://api.github.com/repos/fmatthew5876/liblcf/forks","keys_url":"https://api.github.com/repos/fmatthew5876/liblcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmatthew5876/liblcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmatthew5876/liblcf/teams","hooks_url":"https://api.github.com/repos/fmatthew5876/liblcf/hooks","issue_events_url":"https://api.github.com/repos/fmatthew5876/liblcf/issues/events{/number}","events_url":"https://api.github.com/repos/fmatthew5876/liblcf/events","assignees_url":"https://api.github.com/repos/fmatthew5876/liblcf/assignees{/user}","branches_url":"https://api.github.com/repos/fmatthew5876/liblcf/branches{/branch}","tags_url":"https://api.github.com/repos/fmatthew5876/liblcf/tags","blobs_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmatthew5876/liblcf/statuses/{sha}","languages_url":"https://api.github.com/repos/fmatthew5876/liblcf/languages","stargazers_url":"https://api.github.com/repos/fmatthew5876/liblcf/stargazers","contributors_url":"https://api.github.com/repos/fmatthew5876/liblcf/contributors","subscribers_url":"https://api.github.com/repos/fmatthew5876/liblcf/subscribers","subscription_url":"https://api.github.com/repos/fmatthew5876/liblcf/subscription","commits_url":"https://api.github.com/repos/fmatthew5876/liblcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmatthew5876/liblcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmatthew5876/liblcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmatthew5876/liblcf/contents/{+path}","compare_url":"https://api.github.com/repos/fmatthew5876/liblcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmatthew5876/liblcf/merges","archive_url":"https://api.github.com/repos/fmatthew5876/liblcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmatthew5876/liblcf/downloads","issues_url":"https://api.github.com/repos/fmatthew5876/liblcf/issues{/number}","pulls_url":"https://api.github.com/repos/fmatthew5876/liblcf/pulls{/number}","milestones_url":"https://api.github.com/repos/fmatthew5876/liblcf/milestones{/number}","notifications_url":"https://api.github.com/repos/fmatthew5876/liblcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmatthew5876/liblcf/labels{/name}","releases_url":"https://api.github.com/repos/fmatthew5876/liblcf/releases{/id}","deployments_url":"https://api.github.com/repos/fmatthew5876/liblcf/deployments","created_at":"2018-07-30T22:05:31Z","updated_at":"2018-11-04T17:11:31Z","pushed_at":"2018-11-05T01:57:23Z","git_url":"git://github.com/fmatthew5876/liblcf.git","ssh_url":"git@github.com:fmatthew5876/liblcf.git","clone_url":"https://github.com/fmatthew5876/liblcf.git","svn_url":"https://github.com/fmatthew5876/liblcf","homepage":"https://easyrpg.org","size":2838,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EasyRPG:master","ref":"master","sha":"f0ad2ead4977adba4775c7dd5a2beadb1ebfe363","user":{"login":"EasyRPG","id":1331871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1331871?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":3264627,"node_id":"MDEwOlJlcG9zaXRvcnkzMjY0NjI3","name":"liblcf","full_name":"EasyRPG/liblcf","private":false,"owner":{"login":"EasyRPG","id":1331871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1331871?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EasyRPG/liblcf","description":"Library to handle RPG Maker 2000/2003 and EasyRPG projects","fork":false,"url":"https://api.github.com/repos/EasyRPG/liblcf","forks_url":"https://api.github.com/repos/EasyRPG/liblcf/forks","keys_url":"https://api.github.com/repos/EasyRPG/liblcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyRPG/liblcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyRPG/liblcf/teams","hooks_url":"https://api.github.com/repos/EasyRPG/liblcf/hooks","issue_events_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/events{/number}","events_url":"https://api.github.com/repos/EasyRPG/liblcf/events","assignees_url":"https://api.github.com/repos/EasyRPG/liblcf/assignees{/user}","branches_url":"https://api.github.com/repos/EasyRPG/liblcf/branches{/branch}","tags_url":"https://api.github.com/repos/EasyRPG/liblcf/tags","blobs_url":"https://api.github.com/repos/EasyRPG/liblcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyRPG/liblcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyRPG/liblcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyRPG/liblcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyRPG/liblcf/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyRPG/liblcf/languages","stargazers_url":"https://api.github.com/repos/EasyRPG/liblcf/stargazers","contributors_url":"https://api.github.com/repos/EasyRPG/liblcf/contributors","subscribers_url":"https://api.github.com/repos/EasyRPG/liblcf/subscribers","subscription_url":"https://api.github.com/repos/EasyRPG/liblcf/subscription","commits_url":"https://api.github.com/repos/EasyRPG/liblcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyRPG/liblcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyRPG/liblcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyRPG/liblcf/contents/{+path}","compare_url":"https://api.github.com/repos/EasyRPG/liblcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyRPG/liblcf/merges","archive_url":"https://api.github.com/repos/EasyRPG/liblcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyRPG/liblcf/downloads","issues_url":"https://api.github.com/repos/EasyRPG/liblcf/issues{/number}","pulls_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyRPG/liblcf/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyRPG/liblcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyRPG/liblcf/labels{/name}","releases_url":"https://api.github.com/repos/EasyRPG/liblcf/releases{/id}","deployments_url":"https://api.github.com/repos/EasyRPG/liblcf/deployments","created_at":"2012-01-25T12:34:11Z","updated_at":"2018-11-04T20:05:40Z","pushed_at":"2018-11-05T01:57:24Z","git_url":"git://github.com/EasyRPG/liblcf.git","ssh_url":"git@github.com:EasyRPG/liblcf.git","clone_url":"https://github.com/EasyRPG/liblcf.git","svn_url":"https://github.com/EasyRPG/liblcf","homepage":"https://easyrpg.org","size":2665,"stargazers_count":45,"watchers_count":45,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":32,"open_issues":29,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/277"},"html":{"href":"https://github.com/EasyRPG/liblcf/pull/277"},"issue":{"href":"https://api.github.com/repos/EasyRPG/liblcf/issues/277"},"comments":{"href":"https://api.github.com/repos/EasyRPG/liblcf/issues/277/comments"},"review_comments":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/277/comments"},"review_comment":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/277/commits"},"statuses":{"href":"https://api.github.com/repos/EasyRPG/liblcf/statuses/3b1d092c5beab00d15e68437b8fb345e6fa7c1a4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fmatthew5876"}}