{"action":"created","issue":{"url":"https://api.github.com/repos/signalapp/Signal-Android/issues/7405","repository_url":"https://api.github.com/repos/signalapp/Signal-Android","labels_url":"https://api.github.com/repos/signalapp/Signal-Android/issues/7405/labels{/name}","comments_url":"https://api.github.com/repos/signalapp/Signal-Android/issues/7405/comments","events_url":"https://api.github.com/repos/signalapp/Signal-Android/issues/7405/events","html_url":"https://github.com/signalapp/Signal-Android/issues/7405","id":296038331,"number":7405,"title":"APK-release: Frequent crashes and no update notifications","user":{"login":"charlydelta","id":13337480,"avatar_url":"https://avatars3.githubusercontent.com/u/13337480?v=4","gravatar_id":"","url":"https://api.github.com/users/charlydelta","html_url":"https://github.com/charlydelta","followers_url":"https://api.github.com/users/charlydelta/followers","following_url":"https://api.github.com/users/charlydelta/following{/other_user}","gists_url":"https://api.github.com/users/charlydelta/gists{/gist_id}","starred_url":"https://api.github.com/users/charlydelta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlydelta/subscriptions","organizations_url":"https://api.github.com/users/charlydelta/orgs","repos_url":"https://api.github.com/users/charlydelta/repos","events_url":"https://api.github.com/users/charlydelta/events{/privacy}","received_events_url":"https://api.github.com/users/charlydelta/received_events","type":"User","site_admin":false},"labels":[{"id":16669670,"url":"https://api.github.com/repos/signalapp/Signal-Android/labels/bug","name":"bug","color":"e10c02","default":true},{"id":277179813,"url":"https://api.github.com/repos/signalapp/Signal-Android/labels/crash","name":"crash","color":"e11d21","default":false},{"id":530713520,"url":"https://api.github.com/repos/signalapp/Signal-Android/labels/help%20wanted","name":"help wanted","color":"0e8a16","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-02-09T22:58:30Z","updated_at":"2018-02-23T21:32:45Z","closed_at":null,"author_association":"NONE","body":"The exception below occured with signal 4.14.10 (i think). Signal kept crashing all the time and so I eventually checked the web page. I don't know when the version mentioned above was released, but I have not received any update notifications ever since. I then saw that 4.15.5 is the current version so I updated immediately (and then copied the log, so the app version indicated there is not accurate). I thought that I should submit the crashlog since this error obviously swallowed all update notifications. \r\n\r\nWhile searching for similar issues I only found #7234. Please let me know if I can somehow provide better information.\r\n\r\nI'm on a recent LineageOS system with no GApps installed, see info below.\r\n\r\n```\r\nDevice  : samsung GT-I9505 (jgedlteue)\r\nAndroid : 7.1.2 (c59ce246a7, lineage_jfltexx-userdebug 7.1.2 NJH47F c59ce246a7)\r\nMemory  : 14M (3.28% free, 512M max)\r\nMemclass: 192\r\nOS Host : iktinos.acc.umu.se\r\nApp     : Signal 4.15.5\r\n\r\n--------- beginning of crash\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: FATAL EXCEPTION: JobConsumer-4\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: Process: org.thoughtcrime.securesms, PID: 2216\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: android.os.FileUriExposedException: file:///storage/emulated/0/Android/data/org.thoughtcrime.securesms/files/signal-update-1.apk exposed beyond app through Intent.getData()\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat android.os.StrictMode.onFileUriExposed(StrictMode.java:1796)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat android.net.Uri.checkFileUriExposed(Uri.java:2346)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat android.content.Intent.prepareToLeaveProcess(Intent.java:8981)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat android.content.Intent.prepareToLeaveProcess(Intent.java:8942)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat android.app.PendingIntent.getActivity(PendingIntent.java:340)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat android.app.PendingIntent.getActivity(PendingIntent.java:302)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat org.thoughtcrime.securesms.service.UpdateApkReadyListener.displayInstallNotification(UpdateApkReadyListener.java:61)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat org.thoughtcrime.securesms.service.UpdateApkReadyListener.onReceive(UpdateApkReadyListener.java:48)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat org.thoughtcrime.securesms.jobs.UpdateApkJob.handleDownloadNotify(UpdateApkJob.java:165)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat org.thoughtcrime.securesms.jobs.UpdateApkJob.onRun(UpdateApkJob.java:78)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat org.whispersystems.jobqueue.JobConsumer.runJob(JobConsumer.java:76)\r\n02-09 10:55:08.369  2216  2238 E AndroidRuntime: \tat org.whispersystems.jobqueue.JobConsumer.run(JobConsumer.java:46)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: FATAL EXCEPTION: JobConsumer-4\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: Process: org.thoughtcrime.securesms, PID: 11529\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: android.os.FileUriExposedException: file:///storage/emulated/0/Android/data/org.thoughtcrime.securesms/files/signal-update-1.apk exposed beyond app through Intent.getData()\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat android.os.StrictMode.onFileUriExposed(StrictMode.java:1796)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat android.net.Uri.checkFileUriExposed(Uri.java:2346)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat android.content.Intent.prepareToLeaveProcess(Intent.java:8981)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat android.content.Intent.prepareToLeaveProcess(Intent.java:8942)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat android.app.PendingIntent.getActivity(PendingIntent.java:340)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat android.app.PendingIntent.getActivity(PendingIntent.java:302)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat org.thoughtcrime.securesms.service.UpdateApkReadyListener.displayInstallNotification(UpdateApkReadyListener.java:61)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat org.thoughtcrime.securesms.service.UpdateApkReadyListener.onReceive(UpdateApkReadyListener.java:48)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat org.thoughtcrime.securesms.jobs.UpdateApkJob.handleDownloadNotify(UpdateApkJob.java:165)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat org.thoughtcrime.securesms.jobs.UpdateApkJob.onRun(UpdateApkJob.java:78)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat org.whispersystems.jobqueue.JobConsumer.runJob(JobConsumer.java:76)\r\n02-09 16:59:10.533 11529 11578 E AndroidRuntime: \tat org.whispersystems.jobqueue.JobConsumer.run(JobConsumer.java:46)\r\n```"},"comment":{"url":"https://api.github.com/repos/signalapp/Signal-Android/issues/comments/368144531","html_url":"https://github.com/signalapp/Signal-Android/issues/7405#issuecomment-368144531","issue_url":"https://api.github.com/repos/signalapp/Signal-Android/issues/7405","id":368144531,"user":{"login":"nribeka","id":1143145,"avatar_url":"https://avatars0.githubusercontent.com/u/1143145?v=4","gravatar_id":"","url":"https://api.github.com/users/nribeka","html_url":"https://github.com/nribeka","followers_url":"https://api.github.com/users/nribeka/followers","following_url":"https://api.github.com/users/nribeka/following{/other_user}","gists_url":"https://api.github.com/users/nribeka/gists{/gist_id}","starred_url":"https://api.github.com/users/nribeka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nribeka/subscriptions","organizations_url":"https://api.github.com/users/nribeka/orgs","repos_url":"https://api.github.com/users/nribeka/repos","events_url":"https://api.github.com/users/nribeka/events{/privacy}","received_events_url":"https://api.github.com/users/nribeka/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T21:32:45Z","updated_at":"2018-02-23T21:32:45Z","author_association":"NONE","body":"I get it working on Android 25 with this attached changes: [Signal-diff.txt](https://github.com/signalapp/Signal-Android/files/1753220/Signal-diff.txt)\r\n\r\nAll the above changes didn't work on Android 21 and 22 though. The notification come up, but when I clicked the notification, it doesn't trigger the installation process. We could just do an if instead of using the existing ```FileProviderUtil``` too."}}
{"actor":{"display_login":"nribeka"}}