{"action":"created","issue":{"url":"https://api.github.com/repos/mcanevet/rspec-puppet-facts/issues/73","repository_url":"https://api.github.com/repos/mcanevet/rspec-puppet-facts","labels_url":"https://api.github.com/repos/mcanevet/rspec-puppet-facts/issues/73/labels{/name}","comments_url":"https://api.github.com/repos/mcanevet/rspec-puppet-facts/issues/73/comments","events_url":"https://api.github.com/repos/mcanevet/rspec-puppet-facts/issues/73/events","html_url":"https://github.com/mcanevet/rspec-puppet-facts/issues/73","id":373364196,"node_id":"MDU6SXNzdWUzNzMzNjQxOTY=","number":73,"title":"PR #72 breaks Puppet 6","user":{"login":"baurmatt","id":2098878,"node_id":"MDQ6VXNlcjIwOTg4Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/2098878?v=4","gravatar_id":"","url":"https://api.github.com/users/baurmatt","html_url":"https://github.com/baurmatt","followers_url":"https://api.github.com/users/baurmatt/followers","following_url":"https://api.github.com/users/baurmatt/following{/other_user}","gists_url":"https://api.github.com/users/baurmatt/gists{/gist_id}","starred_url":"https://api.github.com/users/baurmatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baurmatt/subscriptions","organizations_url":"https://api.github.com/users/baurmatt/orgs","repos_url":"https://api.github.com/users/baurmatt/repos","events_url":"https://api.github.com/users/baurmatt/events{/privacy}","received_events_url":"https://api.github.com/users/baurmatt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-24T08:30:53Z","updated_at":"2018-10-24T09:06:09Z","closed_at":null,"author_association":"NONE","body":"The change done in #72 breaks our CI using Puppet 6:\r\n\r\n```\r\nAn error occurred while loading ./spec/classes/vhosts_spec.rb.\r\nFailure/Error:\r\n  on_supported_os.each do |os, os_facts|\r\n    context \"on #{os}\" do\r\n      let(:facts) { os_facts }\r\n      let :pre_condition do\r\n        <<-EOF\r\n        # Fake assert_private function from stdlib to not fail within this test\r\n        function assert_private () { }\r\n        include apache\r\n        EOF\r\n      end\r\n\r\nLoadError:\r\n  cannot load such file -- augeas\r\n# /usr/local/bundle/gems/rspec-puppet-2.7.1/lib/rspec-puppet/monkey_patches.rb:350:in `require'\r\n# /usr/local/bundle/gems/rspec-puppet-2.7.1/lib/rspec-puppet/monkey_patches.rb:350:in `require'\r\n# /usr/local/bundle/gems/rspec-puppet-facts-1.9.1/lib/rspec-puppet-facts.rb:220:in `common_facts'\r\n# /usr/local/bundle/gems/rspec-puppet-facts-1.9.1/lib/rspec-puppet-facts.rb:134:in `block in on_supported_os'\r\n# /usr/local/bundle/gems/rspec-puppet-facts-1.9.1/lib/rspec-puppet-facts.rb:117:in `map'\r\n# /usr/local/bundle/gems/rspec-puppet-facts-1.9.1/lib/rspec-puppet-facts.rb:117:in `on_supported_os'\r\n# ./spec/classes/vhosts_spec.rb:4:in `block in <top (required)>'\r\n# ./spec/classes/vhosts_spec.rb:3:in `<top (required)>'\r\n```\r\n\r\nThat's probably because the rescue doesn't rescue a `LoadError`. I will submit a PR for this."},"comment":{"url":"https://api.github.com/repos/mcanevet/rspec-puppet-facts/issues/comments/432576348","html_url":"https://github.com/mcanevet/rspec-puppet-facts/issues/73#issuecomment-432576348","issue_url":"https://api.github.com/repos/mcanevet/rspec-puppet-facts/issues/73","id":432576348,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjU3NjM0OA==","user":{"login":"baurmatt","id":2098878,"node_id":"MDQ6VXNlcjIwOTg4Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/2098878?v=4","gravatar_id":"","url":"https://api.github.com/users/baurmatt","html_url":"https://github.com/baurmatt","followers_url":"https://api.github.com/users/baurmatt/followers","following_url":"https://api.github.com/users/baurmatt/following{/other_user}","gists_url":"https://api.github.com/users/baurmatt/gists{/gist_id}","starred_url":"https://api.github.com/users/baurmatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baurmatt/subscriptions","organizations_url":"https://api.github.com/users/baurmatt/orgs","repos_url":"https://api.github.com/users/baurmatt/repos","events_url":"https://api.github.com/users/baurmatt/events{/privacy}","received_events_url":"https://api.github.com/users/baurmatt/received_events","type":"User","site_admin":false},"created_at":"2018-10-24T09:06:09Z","updated_at":"2018-10-24T09:06:09Z","author_association":"NONE","body":"Alright then, opened up #74 for the fix."}}
{"actor":{"display_login":"baurmatt"}}