{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/account-closing/pulls/comments/243510423","pull_request_review_id":187291749,"id":243510423,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzUxMDQyMw==","diff_hunk":"@@ -56,13 +57,10 @@ def _create_move_and_lines(\n             self, amount, debit_account_id, credit_account_id,","path":"account_multicurrency_revaluation/wizard/wizard_currency_revaluation.py","position":57,"original_position":18,"commit_id":"633c36b2bc60083b7d841a4f775391ab443af9a8","original_commit_id":"00f4b77ff7f1c41a946b44346d180216f71f29ee","user":{"login":"hbto","id":7598010,"node_id":"MDQ6VXNlcjc1OTgwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7598010?v=4","gravatar_id":"","url":"https://api.github.com/users/hbto","html_url":"https://github.com/hbto","followers_url":"https://api.github.com/users/hbto/followers","following_url":"https://api.github.com/users/hbto/following{/other_user}","gists_url":"https://api.github.com/users/hbto/gists{/gist_id}","starred_url":"https://api.github.com/users/hbto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbto/subscriptions","organizations_url":"https://api.github.com/users/hbto/orgs","repos_url":"https://api.github.com/users/hbto/repos","events_url":"https://api.github.com/users/hbto/events{/privacy}","received_events_url":"https://api.github.com/users/hbto/received_events","type":"User","site_admin":false},"body":"@fclementic2c \r\n\r\nWhy do we have to write that many Journal Entries. They can be created in only one Journal Entry having several Journal Items. It is more convenient  to have only one Journal Entry per Revaluation call.\r\n\r\nRegarding Revaluation Entries for Bank/Liquidity accounts. Why to create that many Lines for each record found. \r\n\r\nThey can be grouped by account / by currency / by partners and not using partner at all for creating the journal items. It is better to just group them (Liquidity accounts) by account / by currency.\r\n\r\nWhat do you think?\r\nRegards","created_at":"2018-12-21T07:55:46Z","updated_at":"2018-12-21T07:57:34Z","html_url":"https://github.com/OCA/account-closing/pull/88#discussion_r243510423","pull_request_url":"https://api.github.com/repos/OCA/account-closing/pulls/88","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OCA/account-closing/pulls/comments/243510423"},"html":{"href":"https://github.com/OCA/account-closing/pull/88#discussion_r243510423"},"pull_request":{"href":"https://api.github.com/repos/OCA/account-closing/pulls/88"}}},"pull_request":{"url":"https://api.github.com/repos/OCA/account-closing/pulls/88","id":234124401,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTI0NDAx","html_url":"https://github.com/OCA/account-closing/pull/88","diff_url":"https://github.com/OCA/account-closing/pull/88.diff","patch_url":"https://github.com/OCA/account-closing/pull/88.patch","issue_url":"https://api.github.com/repos/OCA/account-closing/issues/88","number":88,"state":"open","locked":false,"title":"[MIG] account_multicurrency_revaluation: Migration to 12.0","user":{"login":"hbto","id":7598010,"node_id":"MDQ6VXNlcjc1OTgwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7598010?v=4","gravatar_id":"","url":"https://api.github.com/users/hbto","html_url":"https://github.com/hbto","followers_url":"https://api.github.com/users/hbto/followers","following_url":"https://api.github.com/users/hbto/following{/other_user}","gists_url":"https://api.github.com/users/hbto/gists{/gist_id}","starred_url":"https://api.github.com/users/hbto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbto/subscriptions","organizations_url":"https://api.github.com/users/hbto/orgs","repos_url":"https://api.github.com/users/hbto/repos","events_url":"https://api.github.com/users/hbto/events{/privacy}","received_events_url":"https://api.github.com/users/hbto/received_events","type":"User","site_admin":false},"body":"Main\r\n- \r\n\r\nPorting module to v12\r\n\r\nExplanation\r\n-\r\n\r\n- History of module has been taken in consideration.\r\n- Dependency on `account_reversal` module has been removed, hence on project account-financial-tools, it depends entirely on `account` module in core.\r\n- Bugs have been fixed.\r\n\r\n","created_at":"2018-11-28T02:13:18Z","updated_at":"2018-12-21T07:57:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5625460c96cf9d258f63cd2e1ad9c9ee3bfcc2b8","assignee":{"login":"hbto","id":7598010,"node_id":"MDQ6VXNlcjc1OTgwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7598010?v=4","gravatar_id":"","url":"https://api.github.com/users/hbto","html_url":"https://github.com/hbto","followers_url":"https://api.github.com/users/hbto/followers","following_url":"https://api.github.com/users/hbto/following{/other_user}","gists_url":"https://api.github.com/users/hbto/gists{/gist_id}","starred_url":"https://api.github.com/users/hbto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbto/subscriptions","organizations_url":"https://api.github.com/users/hbto/orgs","repos_url":"https://api.github.com/users/hbto/repos","events_url":"https://api.github.com/users/hbto/events{/privacy}","received_events_url":"https://api.github.com/users/hbto/received_events","type":"User","site_admin":false},"assignees":[{"login":"hbto","id":7598010,"node_id":"MDQ6VXNlcjc1OTgwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/7598010?v=4","gravatar_id":"","url":"https://api.github.com/users/hbto","html_url":"https://github.com/hbto","followers_url":"https://api.github.com/users/hbto/followers","following_url":"https://api.github.com/users/hbto/following{/other_user}","gists_url":"https://api.github.com/users/hbto/gists{/gist_id}","starred_url":"https://api.github.com/users/hbto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hbto/subscriptions","organizations_url":"https://api.github.com/users/hbto/orgs","repos_url":"https://api.github.com/users/hbto/repos","events_url":"https://api.github.com/users/hbto/events{/privacy}","received_events_url":"https://api.github.com/users/hbto/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":121860941,"node_id":"MDU6TGFiZWwxMjE4NjA5NDE=","url":"https://api.github.com/repos/OCA/account-closing/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/OCA/account-closing/milestones/6","html_url":"https://github.com/OCA/account-closing/milestone/6","labels_url":"https://api.github.com/repos/OCA/account-closing/milestones/6/labels","id":3691776,"node_id":"MDk6TWlsZXN0b25lMzY5MTc3Ng==","number":6,"title":"12.0","description":null,"creator":{"login":"OCA-git-bot","id":8723280,"node_id":"MDQ6VXNlcjg3MjMyODA=","avatar_url":"https://avatars2.githubusercontent.com/u/8723280?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA-git-bot","html_url":"https://github.com/OCA-git-bot","followers_url":"https://api.github.com/users/OCA-git-bot/followers","following_url":"https://api.github.com/users/OCA-git-bot/following{/other_user}","gists_url":"https://api.github.com/users/OCA-git-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA-git-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA-git-bot/subscriptions","organizations_url":"https://api.github.com/users/OCA-git-bot/orgs","repos_url":"https://api.github.com/users/OCA-git-bot/repos","events_url":"https://api.github.com/users/OCA-git-bot/events{/privacy}","received_events_url":"https://api.github.com/users/OCA-git-bot/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2018-09-27T00:01:51Z","updated_at":"2018-12-07T13:01:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/account-closing/pulls/88/commits","review_comments_url":"https://api.github.com/repos/OCA/account-closing/pulls/88/comments","review_comment_url":"https://api.github.com/repos/OCA/account-closing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/account-closing/issues/88/comments","statuses_url":"https://api.github.com/repos/OCA/account-closing/statuses/633c36b2bc60083b7d841a4f775391ab443af9a8","head":{"label":"vauxoo-dev:12.0-account_multicurrency_revaluation-goliveirab","ref":"12.0-account_multicurrency_revaluation-goliveirab","sha":"633c36b2bc60083b7d841a4f775391ab443af9a8","user":{"login":"vauxoo-dev","id":7662790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NjI3OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7662790?v=4","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":63623208,"node_id":"MDEwOlJlcG9zaXRvcnk2MzYyMzIwOA==","name":"account-closing","full_name":"vauxoo-dev/account-closing","private":false,"owner":{"login":"vauxoo-dev","id":7662790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2NjI3OTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7662790?v=4","gravatar_id":"","url":"https://api.github.com/users/vauxoo-dev","html_url":"https://github.com/vauxoo-dev","followers_url":"https://api.github.com/users/vauxoo-dev/followers","following_url":"https://api.github.com/users/vauxoo-dev/following{/other_user}","gists_url":"https://api.github.com/users/vauxoo-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/vauxoo-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vauxoo-dev/subscriptions","organizations_url":"https://api.github.com/users/vauxoo-dev/orgs","repos_url":"https://api.github.com/users/vauxoo-dev/repos","events_url":"https://api.github.com/users/vauxoo-dev/events{/privacy}","received_events_url":"https://api.github.com/users/vauxoo-dev/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vauxoo-dev/account-closing","description":null,"fork":true,"url":"https://api.github.com/repos/vauxoo-dev/account-closing","forks_url":"https://api.github.com/repos/vauxoo-dev/account-closing/forks","keys_url":"https://api.github.com/repos/vauxoo-dev/account-closing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vauxoo-dev/account-closing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vauxoo-dev/account-closing/teams","hooks_url":"https://api.github.com/repos/vauxoo-dev/account-closing/hooks","issue_events_url":"https://api.github.com/repos/vauxoo-dev/account-closing/issues/events{/number}","events_url":"https://api.github.com/repos/vauxoo-dev/account-closing/events","assignees_url":"https://api.github.com/repos/vauxoo-dev/account-closing/assignees{/user}","branches_url":"https://api.github.com/repos/vauxoo-dev/account-closing/branches{/branch}","tags_url":"https://api.github.com/repos/vauxoo-dev/account-closing/tags","blobs_url":"https://api.github.com/repos/vauxoo-dev/account-closing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vauxoo-dev/account-closing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vauxoo-dev/account-closing/git/refs{/sha}","trees_url":"https://api.github.com/repos/vauxoo-dev/account-closing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vauxoo-dev/account-closing/statuses/{sha}","languages_url":"https://api.github.com/repos/vauxoo-dev/account-closing/languages","stargazers_url":"https://api.github.com/repos/vauxoo-dev/account-closing/stargazers","contributors_url":"https://api.github.com/repos/vauxoo-dev/account-closing/contributors","subscribers_url":"https://api.github.com/repos/vauxoo-dev/account-closing/subscribers","subscription_url":"https://api.github.com/repos/vauxoo-dev/account-closing/subscription","commits_url":"https://api.github.com/repos/vauxoo-dev/account-closing/commits{/sha}","git_commits_url":"https://api.github.com/repos/vauxoo-dev/account-closing/git/commits{/sha}","comments_url":"https://api.github.com/repos/vauxoo-dev/account-closing/comments{/number}","issue_comment_url":"https://api.github.com/repos/vauxoo-dev/account-closing/issues/comments{/number}","contents_url":"https://api.github.com/repos/vauxoo-dev/account-closing/contents/{+path}","compare_url":"https://api.github.com/repos/vauxoo-dev/account-closing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vauxoo-dev/account-closing/merges","archive_url":"https://api.github.com/repos/vauxoo-dev/account-closing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vauxoo-dev/account-closing/downloads","issues_url":"https://api.github.com/repos/vauxoo-dev/account-closing/issues{/number}","pulls_url":"https://api.github.com/repos/vauxoo-dev/account-closing/pulls{/number}","milestones_url":"https://api.github.com/repos/vauxoo-dev/account-closing/milestones{/number}","notifications_url":"https://api.github.com/repos/vauxoo-dev/account-closing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vauxoo-dev/account-closing/labels{/name}","releases_url":"https://api.github.com/repos/vauxoo-dev/account-closing/releases{/id}","deployments_url":"https://api.github.com/repos/vauxoo-dev/account-closing/deployments","created_at":"2016-07-18T17:26:56Z","updated_at":"2016-07-18T17:26:57Z","pushed_at":"2018-12-20T14:37:33Z","git_url":"git://github.com/vauxoo-dev/account-closing.git","ssh_url":"git@github.com:vauxoo-dev/account-closing.git","clone_url":"https://github.com/vauxoo-dev/account-closing.git","svn_url":"https://github.com/vauxoo-dev/account-closing","homepage":null,"size":862,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OCA:12.0","ref":"12.0","sha":"10c3d432ef4670881d364fe898015c8b082055b1","user":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20881732,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg4MTczMg==","name":"account-closing","full_name":"OCA/account-closing","private":false,"owner":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OCA/account-closing","description":"Odoo Accountant closing tools","fork":false,"url":"https://api.github.com/repos/OCA/account-closing","forks_url":"https://api.github.com/repos/OCA/account-closing/forks","keys_url":"https://api.github.com/repos/OCA/account-closing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/account-closing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/account-closing/teams","hooks_url":"https://api.github.com/repos/OCA/account-closing/hooks","issue_events_url":"https://api.github.com/repos/OCA/account-closing/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/account-closing/events","assignees_url":"https://api.github.com/repos/OCA/account-closing/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/account-closing/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/account-closing/tags","blobs_url":"https://api.github.com/repos/OCA/account-closing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/account-closing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/account-closing/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/account-closing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/account-closing/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/account-closing/languages","stargazers_url":"https://api.github.com/repos/OCA/account-closing/stargazers","contributors_url":"https://api.github.com/repos/OCA/account-closing/contributors","subscribers_url":"https://api.github.com/repos/OCA/account-closing/subscribers","subscription_url":"https://api.github.com/repos/OCA/account-closing/subscription","commits_url":"https://api.github.com/repos/OCA/account-closing/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/account-closing/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/account-closing/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/account-closing/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/account-closing/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/account-closing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/account-closing/merges","archive_url":"https://api.github.com/repos/OCA/account-closing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/account-closing/downloads","issues_url":"https://api.github.com/repos/OCA/account-closing/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/account-closing/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/account-closing/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/account-closing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/account-closing/labels{/name}","releases_url":"https://api.github.com/repos/OCA/account-closing/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/account-closing/deployments","created_at":"2014-06-16T10:57:55Z","updated_at":"2018-12-20T10:00:58Z","pushed_at":"2018-12-20T14:37:35Z","git_url":"git://github.com/OCA/account-closing.git","ssh_url":"git@github.com:OCA/account-closing.git","clone_url":"https://github.com/OCA/account-closing.git","svn_url":"https://github.com/OCA/account-closing","homepage":"","size":2543,"stargazers_count":18,"watchers_count":18,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":97,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":97,"open_issues":16,"watchers":18,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/account-closing/pulls/88"},"html":{"href":"https://github.com/OCA/account-closing/pull/88"},"issue":{"href":"https://api.github.com/repos/OCA/account-closing/issues/88"},"comments":{"href":"https://api.github.com/repos/OCA/account-closing/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/account-closing/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/account-closing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/account-closing/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/account-closing/statuses/633c36b2bc60083b7d841a4f775391ab443af9a8"}},"author_association":"NONE"}}
{"actor":{"display_login":"hbto"}}