{"action":"created","comment":{"url":"https://api.github.com/repos/reaktoro/reaktoro/pulls/comments/243233059","pull_request_review_id":186946027,"id":243233059,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzIzMzA1OQ==","diff_hunk":"@@ -41,36 +41,36 @@ else()\n     set(ABSOLUTE_INSTALL_PATH ${INSTALL_PATH})\n endif()\n \n-# Set the build path for the external dependencies, if not provided\n-if(NOT DEFINED THIRDPARTY_BUILD_PATH)\n-    set(THIRDPARTY_BUILD_PATH ${CMAKE_SOURCE_DIR}/build/thirdparty)\n-endif()\n+# Check if ninja and make are installed\n+find_program(NINJA ninja)\n+find_program(MAKE make)\n \n-# Set the build type to Release by default for the external dependencies, if not provided\n-if(NOT DEFINED THIRDPARTY_BUILD_TYPE)\n-    set(THIRDPARTY_BUILD_TYPE Release)\n-endif()\n+# Extra arguments used during the build process (e.g., -j10)\n+set(ARGS \"\")\n+\n+# If make installed, use make\n+if(NOT DEFINED GENERATOR AND MAKE)","path":"install","position":31,"original_position":31,"commit_id":"b828e4a3b3f51da6ead89f31caf5d6a42c5f42ce","original_commit_id":"b828e4a3b3f51da6ead89f31caf5d6a42c5f42ce","user":{"login":"tadeu","id":955251,"node_id":"MDQ6VXNlcjk1NTI1MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/955251?v=4","gravatar_id":"","url":"https://api.github.com/users/tadeu","html_url":"https://github.com/tadeu","followers_url":"https://api.github.com/users/tadeu/followers","following_url":"https://api.github.com/users/tadeu/following{/other_user}","gists_url":"https://api.github.com/users/tadeu/gists{/gist_id}","starred_url":"https://api.github.com/users/tadeu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tadeu/subscriptions","organizations_url":"https://api.github.com/users/tadeu/orgs","repos_url":"https://api.github.com/users/tadeu/repos","events_url":"https://api.github.com/users/tadeu/events{/privacy}","received_events_url":"https://api.github.com/users/tadeu/received_events","type":"User","site_admin":false},"body":"`ninja` is usually faster than `make` (although not by much: https://david.rothlis.net/ninja-benchmark/). What do you think if `ninja` is the default in case both `make` and `ninja` are available?","created_at":"2018-12-20T11:03:48Z","updated_at":"2018-12-20T11:03:49Z","html_url":"https://github.com/reaktoro/reaktoro/pull/40#discussion_r243233059","pull_request_url":"https://api.github.com/repos/reaktoro/reaktoro/pulls/40","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/reaktoro/reaktoro/pulls/comments/243233059"},"html":{"href":"https://github.com/reaktoro/reaktoro/pull/40#discussion_r243233059"},"pull_request":{"href":"https://api.github.com/repos/reaktoro/reaktoro/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/reaktoro/reaktoro/pulls/40","id":239982416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTgyNDE2","html_url":"https://github.com/reaktoro/reaktoro/pull/40","diff_url":"https://github.com/reaktoro/reaktoro/pull/40.diff","patch_url":"https://github.com/reaktoro/reaktoro/pull/40.patch","issue_url":"https://api.github.com/repos/reaktoro/reaktoro/issues/40","number":40,"state":"open","locked":false,"title":"Pybind11 is now (temporarily) located in thirdparty dir","user":{"login":"allanleal","id":5825588,"node_id":"MDQ6VXNlcjU4MjU1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5825588?v=4","gravatar_id":"","url":"https://api.github.com/users/allanleal","html_url":"https://github.com/allanleal","followers_url":"https://api.github.com/users/allanleal/followers","following_url":"https://api.github.com/users/allanleal/following{/other_user}","gists_url":"https://api.github.com/users/allanleal/gists{/gist_id}","starred_url":"https://api.github.com/users/allanleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanleal/subscriptions","organizations_url":"https://api.github.com/users/allanleal/orgs","repos_url":"https://api.github.com/users/allanleal/repos","events_url":"https://api.github.com/users/allanleal/events{/privacy}","received_events_url":"https://api.github.com/users/allanleal/received_events","type":"User","site_admin":false},"body":"Some users have reported some runtime errors that I remember having in the past when using pybind11 without this [bugfix](https://github.com/pybind/pybind11/pull/1298).\r\n\r\npybind11 has not yet released a tag 2.3 with this bugfix, and conda-forge has v2.2.4 (without the bugfix).\r\n\r\nThis PR is a temp solution to ease the installation of reaktoro from sources without requiring the user to install pybind11 himself. Once v2.3 is available on conda-forge, this copy of pybind11 in the thirdparty dir can be removed.","created_at":"2018-12-19T21:38:47Z","updated_at":"2018-12-20T11:03:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80f6e492d7d952d1b177bec86026b6485c8fcd58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reaktoro/reaktoro/pulls/40/commits","review_comments_url":"https://api.github.com/repos/reaktoro/reaktoro/pulls/40/comments","review_comment_url":"https://api.github.com/repos/reaktoro/reaktoro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reaktoro/reaktoro/issues/40/comments","statuses_url":"https://api.github.com/repos/reaktoro/reaktoro/statuses/b828e4a3b3f51da6ead89f31caf5d6a42c5f42ce","head":{"label":"allanleal:pybind11-fix-build-deps","ref":"pybind11-fix-build-deps","sha":"b828e4a3b3f51da6ead89f31caf5d6a42c5f42ce","user":{"login":"allanleal","id":5825588,"node_id":"MDQ6VXNlcjU4MjU1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5825588?v=4","gravatar_id":"","url":"https://api.github.com/users/allanleal","html_url":"https://github.com/allanleal","followers_url":"https://api.github.com/users/allanleal/followers","following_url":"https://api.github.com/users/allanleal/following{/other_user}","gists_url":"https://api.github.com/users/allanleal/gists{/gist_id}","starred_url":"https://api.github.com/users/allanleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanleal/subscriptions","organizations_url":"https://api.github.com/users/allanleal/orgs","repos_url":"https://api.github.com/users/allanleal/repos","events_url":"https://api.github.com/users/allanleal/events{/privacy}","received_events_url":"https://api.github.com/users/allanleal/received_events","type":"User","site_admin":false},"repo":{"id":151134002,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMzQwMDI=","name":"reaktoro","full_name":"allanleal/reaktoro","private":false,"owner":{"login":"allanleal","id":5825588,"node_id":"MDQ6VXNlcjU4MjU1ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/5825588?v=4","gravatar_id":"","url":"https://api.github.com/users/allanleal","html_url":"https://github.com/allanleal","followers_url":"https://api.github.com/users/allanleal/followers","following_url":"https://api.github.com/users/allanleal/following{/other_user}","gists_url":"https://api.github.com/users/allanleal/gists{/gist_id}","starred_url":"https://api.github.com/users/allanleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allanleal/subscriptions","organizations_url":"https://api.github.com/users/allanleal/orgs","repos_url":"https://api.github.com/users/allanleal/repos","events_url":"https://api.github.com/users/allanleal/events{/privacy}","received_events_url":"https://api.github.com/users/allanleal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/allanleal/reaktoro","description":"a unified framework for modeling chemically reactive systems","fork":true,"url":"https://api.github.com/repos/allanleal/reaktoro","forks_url":"https://api.github.com/repos/allanleal/reaktoro/forks","keys_url":"https://api.github.com/repos/allanleal/reaktoro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allanleal/reaktoro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allanleal/reaktoro/teams","hooks_url":"https://api.github.com/repos/allanleal/reaktoro/hooks","issue_events_url":"https://api.github.com/repos/allanleal/reaktoro/issues/events{/number}","events_url":"https://api.github.com/repos/allanleal/reaktoro/events","assignees_url":"https://api.github.com/repos/allanleal/reaktoro/assignees{/user}","branches_url":"https://api.github.com/repos/allanleal/reaktoro/branches{/branch}","tags_url":"https://api.github.com/repos/allanleal/reaktoro/tags","blobs_url":"https://api.github.com/repos/allanleal/reaktoro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allanleal/reaktoro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allanleal/reaktoro/git/refs{/sha}","trees_url":"https://api.github.com/repos/allanleal/reaktoro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allanleal/reaktoro/statuses/{sha}","languages_url":"https://api.github.com/repos/allanleal/reaktoro/languages","stargazers_url":"https://api.github.com/repos/allanleal/reaktoro/stargazers","contributors_url":"https://api.github.com/repos/allanleal/reaktoro/contributors","subscribers_url":"https://api.github.com/repos/allanleal/reaktoro/subscribers","subscription_url":"https://api.github.com/repos/allanleal/reaktoro/subscription","commits_url":"https://api.github.com/repos/allanleal/reaktoro/commits{/sha}","git_commits_url":"https://api.github.com/repos/allanleal/reaktoro/git/commits{/sha}","comments_url":"https://api.github.com/repos/allanleal/reaktoro/comments{/number}","issue_comment_url":"https://api.github.com/repos/allanleal/reaktoro/issues/comments{/number}","contents_url":"https://api.github.com/repos/allanleal/reaktoro/contents/{+path}","compare_url":"https://api.github.com/repos/allanleal/reaktoro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allanleal/reaktoro/merges","archive_url":"https://api.github.com/repos/allanleal/reaktoro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allanleal/reaktoro/downloads","issues_url":"https://api.github.com/repos/allanleal/reaktoro/issues{/number}","pulls_url":"https://api.github.com/repos/allanleal/reaktoro/pulls{/number}","milestones_url":"https://api.github.com/repos/allanleal/reaktoro/milestones{/number}","notifications_url":"https://api.github.com/repos/allanleal/reaktoro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allanleal/reaktoro/labels{/name}","releases_url":"https://api.github.com/repos/allanleal/reaktoro/releases{/id}","deployments_url":"https://api.github.com/repos/allanleal/reaktoro/deployments","created_at":"2018-10-01T18:02:23Z","updated_at":"2018-12-19T11:38:15Z","pushed_at":"2018-12-20T09:37:50Z","git_url":"git://github.com/allanleal/reaktoro.git","ssh_url":"git@github.com:allanleal/reaktoro.git","clone_url":"https://github.com/allanleal/reaktoro.git","svn_url":"https://github.com/allanleal/reaktoro","homepage":"https://reaktoro.org","size":42332,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"reaktoro:master","ref":"master","sha":"65f0860e05853fc0ca7830f6a02fb7210acea1e8","user":{"login":"reaktoro","id":26537565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTM3NTY1","avatar_url":"https://avatars2.githubusercontent.com/u/26537565?v=4","gravatar_id":"","url":"https://api.github.com/users/reaktoro","html_url":"https://github.com/reaktoro","followers_url":"https://api.github.com/users/reaktoro/followers","following_url":"https://api.github.com/users/reaktoro/following{/other_user}","gists_url":"https://api.github.com/users/reaktoro/gists{/gist_id}","starred_url":"https://api.github.com/users/reaktoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaktoro/subscriptions","organizations_url":"https://api.github.com/users/reaktoro/orgs","repos_url":"https://api.github.com/users/reaktoro/repos","events_url":"https://api.github.com/users/reaktoro/events{/privacy}","received_events_url":"https://api.github.com/users/reaktoro/received_events","type":"Organization","site_admin":false},"repo":{"id":85572910,"node_id":"MDEwOlJlcG9zaXRvcnk4NTU3MjkxMA==","name":"reaktoro","full_name":"reaktoro/reaktoro","private":false,"owner":{"login":"reaktoro","id":26537565,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTM3NTY1","avatar_url":"https://avatars2.githubusercontent.com/u/26537565?v=4","gravatar_id":"","url":"https://api.github.com/users/reaktoro","html_url":"https://github.com/reaktoro","followers_url":"https://api.github.com/users/reaktoro/followers","following_url":"https://api.github.com/users/reaktoro/following{/other_user}","gists_url":"https://api.github.com/users/reaktoro/gists{/gist_id}","starred_url":"https://api.github.com/users/reaktoro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaktoro/subscriptions","organizations_url":"https://api.github.com/users/reaktoro/orgs","repos_url":"https://api.github.com/users/reaktoro/repos","events_url":"https://api.github.com/users/reaktoro/events{/privacy}","received_events_url":"https://api.github.com/users/reaktoro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reaktoro/reaktoro","description":"a unified framework for modeling chemically reactive systems","fork":false,"url":"https://api.github.com/repos/reaktoro/reaktoro","forks_url":"https://api.github.com/repos/reaktoro/reaktoro/forks","keys_url":"https://api.github.com/repos/reaktoro/reaktoro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaktoro/reaktoro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaktoro/reaktoro/teams","hooks_url":"https://api.github.com/repos/reaktoro/reaktoro/hooks","issue_events_url":"https://api.github.com/repos/reaktoro/reaktoro/issues/events{/number}","events_url":"https://api.github.com/repos/reaktoro/reaktoro/events","assignees_url":"https://api.github.com/repos/reaktoro/reaktoro/assignees{/user}","branches_url":"https://api.github.com/repos/reaktoro/reaktoro/branches{/branch}","tags_url":"https://api.github.com/repos/reaktoro/reaktoro/tags","blobs_url":"https://api.github.com/repos/reaktoro/reaktoro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaktoro/reaktoro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaktoro/reaktoro/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaktoro/reaktoro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaktoro/reaktoro/statuses/{sha}","languages_url":"https://api.github.com/repos/reaktoro/reaktoro/languages","stargazers_url":"https://api.github.com/repos/reaktoro/reaktoro/stargazers","contributors_url":"https://api.github.com/repos/reaktoro/reaktoro/contributors","subscribers_url":"https://api.github.com/repos/reaktoro/reaktoro/subscribers","subscription_url":"https://api.github.com/repos/reaktoro/reaktoro/subscription","commits_url":"https://api.github.com/repos/reaktoro/reaktoro/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaktoro/reaktoro/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaktoro/reaktoro/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaktoro/reaktoro/issues/comments{/number}","contents_url":"https://api.github.com/repos/reaktoro/reaktoro/contents/{+path}","compare_url":"https://api.github.com/repos/reaktoro/reaktoro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaktoro/reaktoro/merges","archive_url":"https://api.github.com/repos/reaktoro/reaktoro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaktoro/reaktoro/downloads","issues_url":"https://api.github.com/repos/reaktoro/reaktoro/issues{/number}","pulls_url":"https://api.github.com/repos/reaktoro/reaktoro/pulls{/number}","milestones_url":"https://api.github.com/repos/reaktoro/reaktoro/milestones{/number}","notifications_url":"https://api.github.com/repos/reaktoro/reaktoro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaktoro/reaktoro/labels{/name}","releases_url":"https://api.github.com/repos/reaktoro/reaktoro/releases{/id}","deployments_url":"https://api.github.com/repos/reaktoro/reaktoro/deployments","created_at":"2017-03-20T12:13:53Z","updated_at":"2018-12-19T11:50:15Z","pushed_at":"2018-12-20T09:37:51Z","git_url":"git://github.com/reaktoro/reaktoro.git","ssh_url":"git@github.com:reaktoro/reaktoro.git","clone_url":"https://github.com/reaktoro/reaktoro.git","svn_url":"https://github.com/reaktoro/reaktoro","homepage":"https://reaktoro.org","size":41953,"stargazers_count":12,"watchers_count":12,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":11,"open_issues":8,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reaktoro/reaktoro/pulls/40"},"html":{"href":"https://github.com/reaktoro/reaktoro/pull/40"},"issue":{"href":"https://api.github.com/repos/reaktoro/reaktoro/issues/40"},"comments":{"href":"https://api.github.com/repos/reaktoro/reaktoro/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/reaktoro/reaktoro/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/reaktoro/reaktoro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reaktoro/reaktoro/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/reaktoro/reaktoro/statuses/b828e4a3b3f51da6ead89f31caf5d6a42c5f42ce"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tadeu"}}