{"action":"created","comment":{"url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/comments/203699591","pull_request_review_id":138639012,"id":203699591,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzY5OTU5MQ==","diff_hunk":"@@ -193,20 +193,16 @@ private function registerPropertyType(array $typeDef, $property)\n      */\n     private function getNestedTypeInArray(PropertyMetadata $item)\n     {\n-        if ('array' !== $item->type['name'] && 'ArrayCollection' !== $item->type['name']) {\n+        if (('array' !== $item->type['name'] && 'ArrayCollection' !== $item->type['name']) || !isset($item->type['params'][0]['name'])) {\n             return null;\n         }\n \n-        // array<string, MyNamespaceMyObject>\n         if (isset($item->type['params'][1]['name'])) {\n-            return [$item->type['params'][1]['name'], true];\n+            // array<string, MyNamespaceMyObject>\n+            return [$item->type['params'][1]['name'], 'integer' !== $item->type['params'][0]['name']];","path":"ModelDescriber/JMSModelDescriber.php","position":30,"original_position":30,"commit_id":"d83ba207f3aecb28eb33c5b735cea12ab21184e1","original_commit_id":"d83ba207f3aecb28eb33c5b735cea12ab21184e1","user":{"login":"dbu","id":76576,"node_id":"MDQ6VXNlcjc2NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/76576?v=4","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"body":"i guess in many cases, its the right interpretation. the \"problem\" is that PHP does not really distinguish plain array vs hashmap, while every other programming language does. its convenient, but when building json it makes a difference. not sure if jms itself has anything to handle it explicitly, or if not if we should add something additional to this bundle?\r\n\r\nftr, the problem we are talking about is:\r\n```\r\nphp > var_dump(json_encode([0 => 'a', 2 => 'b']));\r\nstring(17) \"{\"0\":\"a\",\"2\":\"b\"}\"\r\nphp > var_dump(json_encode([0 => 'a', 1 => 'b']));\r\nstring(9) \"[\"a\",\"b\"]\"\r\n```","created_at":"2018-07-19T12:01:34Z","updated_at":"2018-07-19T12:01:34Z","html_url":"https://github.com/nelmio/NelmioApiDocBundle/pull/1363#discussion_r203699591","pull_request_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/1363","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/comments/203699591"},"html":{"href":"https://github.com/nelmio/NelmioApiDocBundle/pull/1363#discussion_r203699591"},"pull_request":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/1363"}},"in_reply_to_id":203610335},"pull_request":{"url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/1363","id":202319737,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzE5NzM3","html_url":"https://github.com/nelmio/NelmioApiDocBundle/pull/1363","diff_url":"https://github.com/nelmio/NelmioApiDocBundle/pull/1363.diff","patch_url":"https://github.com/nelmio/NelmioApiDocBundle/pull/1363.patch","issue_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/1363","number":1363,"state":"open","locked":false,"title":"[WIP] [JMSModelDescriber] Infer integer indexed arrays as \"array\" instead of \"object\"","user":{"login":"phansys","id":1231441,"node_id":"MDQ6VXNlcjEyMzE0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1231441?v=4","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"body":"|Q            |A     |\n|---          |---   |\n|Branch       |master|\n|Bug fix?     |yes   |\n|New feature? |no    |\n|BC breaks?   |no    |\n|Deprecations?|no    |\n|Tests pass?  |yes   |\n|Fixed tickets|n/a   |\n|License      |MIT   |\n|Doc PR       |n/a   |","created_at":"2018-07-18T17:02:36Z","updated_at":"2018-07-19T12:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e4055810cb78fea8347684fd52d37861f1a6538e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/1363/commits","review_comments_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/1363/comments","review_comment_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/1363/comments","statuses_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/statuses/d83ba207f3aecb28eb33c5b735cea12ab21184e1","head":{"label":"phansys:jms_model_describer","ref":"jms_model_describer","sha":"d83ba207f3aecb28eb33c5b735cea12ab21184e1","user":{"login":"phansys","id":1231441,"node_id":"MDQ6VXNlcjEyMzE0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1231441?v=4","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"repo":{"id":34863712,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg2MzcxMg==","name":"NelmioApiDocBundle","full_name":"phansys/NelmioApiDocBundle","owner":{"login":"phansys","id":1231441,"node_id":"MDQ6VXNlcjEyMzE0NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1231441?v=4","gravatar_id":"","url":"https://api.github.com/users/phansys","html_url":"https://github.com/phansys","followers_url":"https://api.github.com/users/phansys/followers","following_url":"https://api.github.com/users/phansys/following{/other_user}","gists_url":"https://api.github.com/users/phansys/gists{/gist_id}","starred_url":"https://api.github.com/users/phansys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phansys/subscriptions","organizations_url":"https://api.github.com/users/phansys/orgs","repos_url":"https://api.github.com/users/phansys/repos","events_url":"https://api.github.com/users/phansys/events{/privacy}","received_events_url":"https://api.github.com/users/phansys/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phansys/NelmioApiDocBundle","description":"Generates documentation for your REST API from annotations","fork":true,"url":"https://api.github.com/repos/phansys/NelmioApiDocBundle","forks_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/forks","keys_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/teams","hooks_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/hooks","issue_events_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/issues/events{/number}","events_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/events","assignees_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/assignees{/user}","branches_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/branches{/branch}","tags_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/tags","blobs_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/languages","stargazers_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/stargazers","contributors_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/contributors","subscribers_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/subscribers","subscription_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/subscription","commits_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/contents/{+path}","compare_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/merges","archive_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/downloads","issues_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/issues{/number}","pulls_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/labels{/name}","releases_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/releases{/id}","deployments_url":"https://api.github.com/repos/phansys/NelmioApiDocBundle/deployments","created_at":"2015-04-30T16:05:23Z","updated_at":"2016-05-31T16:24:11Z","pushed_at":"2018-07-18T17:02:00Z","git_url":"git://github.com/phansys/NelmioApiDocBundle.git","ssh_url":"git@github.com:phansys/NelmioApiDocBundle.git","clone_url":"https://github.com/phansys/NelmioApiDocBundle.git","svn_url":"https://github.com/phansys/NelmioApiDocBundle","homepage":"","size":6313,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nelmio:master","ref":"master","sha":"9ca68b426c6a9b80652c9163b2bfb4879c337644","user":{"login":"nelmio","id":460596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/460596?v=4","gravatar_id":"","url":"https://api.github.com/users/nelmio","html_url":"https://github.com/nelmio","followers_url":"https://api.github.com/users/nelmio/followers","following_url":"https://api.github.com/users/nelmio/following{/other_user}","gists_url":"https://api.github.com/users/nelmio/gists{/gist_id}","starred_url":"https://api.github.com/users/nelmio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelmio/subscriptions","organizations_url":"https://api.github.com/users/nelmio/orgs","repos_url":"https://api.github.com/users/nelmio/repos","events_url":"https://api.github.com/users/nelmio/events{/privacy}","received_events_url":"https://api.github.com/users/nelmio/received_events","type":"Organization","site_admin":false},"repo":{"id":4006755,"node_id":"MDEwOlJlcG9zaXRvcnk0MDA2NzU1","name":"NelmioApiDocBundle","full_name":"nelmio/NelmioApiDocBundle","owner":{"login":"nelmio","id":460596,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDU5Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/460596?v=4","gravatar_id":"","url":"https://api.github.com/users/nelmio","html_url":"https://github.com/nelmio","followers_url":"https://api.github.com/users/nelmio/followers","following_url":"https://api.github.com/users/nelmio/following{/other_user}","gists_url":"https://api.github.com/users/nelmio/gists{/gist_id}","starred_url":"https://api.github.com/users/nelmio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nelmio/subscriptions","organizations_url":"https://api.github.com/users/nelmio/orgs","repos_url":"https://api.github.com/users/nelmio/repos","events_url":"https://api.github.com/users/nelmio/events{/privacy}","received_events_url":"https://api.github.com/users/nelmio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nelmio/NelmioApiDocBundle","description":"Generates documentation for your REST API from annotations","fork":false,"url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle","forks_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/forks","keys_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/teams","hooks_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/hooks","issue_events_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/events{/number}","events_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/events","assignees_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/assignees{/user}","branches_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/branches{/branch}","tags_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/tags","blobs_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/languages","stargazers_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/stargazers","contributors_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/contributors","subscribers_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/subscribers","subscription_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/subscription","commits_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/contents/{+path}","compare_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/merges","archive_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/downloads","issues_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues{/number}","pulls_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/labels{/name}","releases_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/releases{/id}","deployments_url":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/deployments","created_at":"2012-04-12T16:28:15Z","updated_at":"2018-07-17T06:47:29Z","pushed_at":"2018-07-18T17:02:37Z","git_url":"git://github.com/nelmio/NelmioApiDocBundle.git","ssh_url":"git@github.com:nelmio/NelmioApiDocBundle.git","clone_url":"https://github.com/nelmio/NelmioApiDocBundle.git","svn_url":"https://github.com/nelmio/NelmioApiDocBundle","homepage":"","size":6682,"stargazers_count":1485,"watchers_count":1485,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":637,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":637,"open_issues":55,"watchers":1485,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/1363"},"html":{"href":"https://github.com/nelmio/NelmioApiDocBundle/pull/1363"},"issue":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/1363"},"comments":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/issues/1363/comments"},"review_comments":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/1363/comments"},"review_comment":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/pulls/1363/commits"},"statuses":{"href":"https://api.github.com/repos/nelmio/NelmioApiDocBundle/statuses/d83ba207f3aecb28eb33c5b735cea12ab21184e1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dbu"}}