{"action":"created","issue":{"url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4522","repository_url":"https://api.github.com/repos/qmk/qmk_firmware","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4522/labels{/name}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4522/comments","events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4522/events","html_url":"https://github.com/qmk/qmk_firmware/pull/4522","id":386308583,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDgyODY0","number":4522,"title":"Refactor quantum/split_common/i2c.c, quantum/split_common/serial.c","user":{"login":"mtei","id":2170248,"node_id":"MDQ6VXNlcjIxNzAyNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/2170248?v=4","gravatar_id":"","url":"https://api.github.com/users/mtei","html_url":"https://github.com/mtei","followers_url":"https://api.github.com/users/mtei/followers","following_url":"https://api.github.com/users/mtei/following{/other_user}","gists_url":"https://api.github.com/users/mtei/gists{/gist_id}","starred_url":"https://api.github.com/users/mtei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtei/subscriptions","organizations_url":"https://api.github.com/users/mtei/orgs","repos_url":"https://api.github.com/users/mtei/repos","events_url":"https://api.github.com/users/mtei/events{/privacy}","received_events_url":"https://api.github.com/users/mtei/received_events","type":"User","site_admin":false},"labels":[{"id":720613800,"node_id":"MDU6TGFiZWw3MjA2MTM4MDA=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/core","name":"core","color":"f92925","default":false},{"id":604002030,"node_id":"MDU6TGFiZWw2MDQwMDIwMzA=","url":"https://api.github.com/repos/qmk/qmk_firmware/labels/optimization","name":"optimization","color":"c5def5","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-30T18:55:13Z","updated_at":"2018-12-15T05:31:35Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4522","html_url":"https://github.com/qmk/qmk_firmware/pull/4522","diff_url":"https://github.com/qmk/qmk_firmware/pull/4522.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/4522.patch"},"body":"Changed quantum/split_common/serial.o and quantum/split_common/i2c.o so that they are automatically selected when linking.\r\n\r\n* Enhance `build_keyboard.mk`, `tmk_core/rules.mk`.\r\n  add `LIB_SRC`, `QUANTUM_LIB_SRC` support.\r\n  Support compiled object enclosed in library.\r\n    \r\n* Modify `common_features.mk`, `quantum/split_common/i2c.c`, `quantum/split_common/serial.c`.\r\n  * Using `QUANTUM_LIB_SRC`, i2c.o and serial.o are stored in the library.  \r\n  * remove `#if defined(USE_I2C) || defined(EH)` from quantum/split_common/i2c.c\r\n  * remove `#ifndef USE_I2C` from quantum/split_common/serial.c\r\n\r\n#4254's \"Support both I2C and Serial at the same time\""},"comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments/447539144","html_url":"https://github.com/qmk/qmk_firmware/pull/4522#issuecomment-447539144","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4522","id":447539144,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzUzOTE0NA==","user":{"login":"drashna","id":2584963,"node_id":"MDQ6VXNlcjI1ODQ5NjM=","avatar_url":"https://avatars2.githubusercontent.com/u/2584963?v=4","gravatar_id":"","url":"https://api.github.com/users/drashna","html_url":"https://github.com/drashna","followers_url":"https://api.github.com/users/drashna/followers","following_url":"https://api.github.com/users/drashna/following{/other_user}","gists_url":"https://api.github.com/users/drashna/gists{/gist_id}","starred_url":"https://api.github.com/users/drashna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drashna/subscriptions","organizations_url":"https://api.github.com/users/drashna/orgs","repos_url":"https://api.github.com/users/drashna/repos","events_url":"https://api.github.com/users/drashna/events{/privacy}","received_events_url":"https://api.github.com/users/drashna/received_events","type":"User","site_admin":false},"created_at":"2018-12-15T05:31:35Z","updated_at":"2018-12-15T05:31:35Z","author_association":"COLLABORATOR","body":"Awesome, thanks! \r\n\r\nAnd closes #4650"}}
{"actor":{"display_login":"drashna"}}