{"action":"created","comment":{"url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/comments/204218812","pull_request_review_id":139266342,"id":204218812,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDIxODgxMg==","diff_hunk":"@@ -513,7 +516,11 @@ class MoveRight extends BaseMovement {\n   keys = ['l'];\n \n   public async execAction(position: Position, vimState: VimState): Promise<Position> {\n-    return new Position(position.line, position.character + 1);\n+    if (shouldWrapKey(vimState, this.keysPressed)) {\n+      const includeEol = vimState.currentMode === ModeName.Insert;","path":"src/actions/motion.ts","position":30,"original_position":30,"commit_id":"44eca6758d267ade1dc3b21fc640fcec66f74403","original_commit_id":"44eca6758d267ade1dc3b21fc640fcec66f74403","user":{"login":"xconverge","id":4219348,"node_id":"MDQ6VXNlcjQyMTkzNDg=","avatar_url":"https://avatars2.githubusercontent.com/u/4219348?v=4","gravatar_id":"","url":"https://api.github.com/users/xconverge","html_url":"https://github.com/xconverge","followers_url":"https://api.github.com/users/xconverge/followers","following_url":"https://api.github.com/users/xconverge/following{/other_user}","gists_url":"https://api.github.com/users/xconverge/gists{/gist_id}","starred_url":"https://api.github.com/users/xconverge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xconverge/subscriptions","organizations_url":"https://api.github.com/users/xconverge/orgs","repos_url":"https://api.github.com/users/xconverge/repos","events_url":"https://api.github.com/users/xconverge/events{/privacy}","received_events_url":"https://api.github.com/users/xconverge/received_events","type":"User","site_admin":false},"body":"is this even possible? l during insert will just insert an l","created_at":"2018-07-21T18:59:36Z","updated_at":"2018-07-21T18:59:36Z","html_url":"https://github.com/VSCodeVim/Vim/pull/2864#discussion_r204218812","pull_request_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/2864","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/comments/204218812"},"html":{"href":"https://github.com/VSCodeVim/Vim/pull/2864#discussion_r204218812"},"pull_request":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/2864"}}},"pull_request":{"url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/2864","id":202981733,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTgxNzMz","html_url":"https://github.com/VSCodeVim/Vim/pull/2864","diff_url":"https://github.com/VSCodeVim/Vim/pull/2864.diff","patch_url":"https://github.com/VSCodeVim/Vim/pull/2864.patch","issue_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/2864","number":2864,"state":"open","locked":false,"title":"Add whichwrap","user":{"login":"davidmfoley","id":128350,"node_id":"MDQ6VXNlcjEyODM1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/128350?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmfoley","html_url":"https://github.com/davidmfoley","followers_url":"https://api.github.com/users/davidmfoley/followers","following_url":"https://api.github.com/users/davidmfoley/following{/other_user}","gists_url":"https://api.github.com/users/davidmfoley/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmfoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmfoley/subscriptions","organizations_url":"https://api.github.com/users/davidmfoley/orgs","repos_url":"https://api.github.com/users/davidmfoley/repos","events_url":"https://api.github.com/users/davidmfoley/events{/privacy}","received_events_url":"https://api.github.com/users/davidmfoley/received_events","type":"User","site_admin":false},"body":"<!--\r\nYay! Thanks for sending us a PR! 🎊\r\n\r\nPlease ensure your PR adheres to:\r\n\r\n- [ ] Commit messages has a short & issue references when necessary\r\n- [ ] Each commit does a logical chunk of work.\r\n- [ ] It builds and tests pass (e.g `gulp`)\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nAdds support for whichwrap\r\nhttp://vim.wikia.com/wiki/Automatically_wrap_left_and_right\r\n\r\n**Which issue(s) this PR fixes**\r\n\r\n#1211\r\n\r\n<!--\r\nCommits in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)\r\n-->\r\n\r\n**Special notes for your reviewer**:\r\n\r\nI am new to VS Code extension development, typescript, and this codebase. I tried to match style/etc. to the existing code. Let me know what changes are needed.","created_at":"2018-07-21T00:27:51Z","updated_at":"2018-07-21T18:59:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d5ee3e731915580b6ad770869bbf53ff88c2a16","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/2864/commits","review_comments_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/2864/comments","review_comment_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/2864/comments","statuses_url":"https://api.github.com/repos/VSCodeVim/Vim/statuses/44eca6758d267ade1dc3b21fc640fcec66f74403","head":{"label":"davidmfoley:add-whichwrap","ref":"add-whichwrap","sha":"44eca6758d267ade1dc3b21fc640fcec66f74403","user":{"login":"davidmfoley","id":128350,"node_id":"MDQ6VXNlcjEyODM1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/128350?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmfoley","html_url":"https://github.com/davidmfoley","followers_url":"https://api.github.com/users/davidmfoley/followers","following_url":"https://api.github.com/users/davidmfoley/following{/other_user}","gists_url":"https://api.github.com/users/davidmfoley/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmfoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmfoley/subscriptions","organizations_url":"https://api.github.com/users/davidmfoley/orgs","repos_url":"https://api.github.com/users/davidmfoley/repos","events_url":"https://api.github.com/users/davidmfoley/events{/privacy}","received_events_url":"https://api.github.com/users/davidmfoley/received_events","type":"User","site_admin":false},"repo":{"id":141624063,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE2MjQwNjM=","name":"Vim","full_name":"davidmfoley/Vim","owner":{"login":"davidmfoley","id":128350,"node_id":"MDQ6VXNlcjEyODM1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/128350?v=4","gravatar_id":"","url":"https://api.github.com/users/davidmfoley","html_url":"https://github.com/davidmfoley","followers_url":"https://api.github.com/users/davidmfoley/followers","following_url":"https://api.github.com/users/davidmfoley/following{/other_user}","gists_url":"https://api.github.com/users/davidmfoley/gists{/gist_id}","starred_url":"https://api.github.com/users/davidmfoley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidmfoley/subscriptions","organizations_url":"https://api.github.com/users/davidmfoley/orgs","repos_url":"https://api.github.com/users/davidmfoley/repos","events_url":"https://api.github.com/users/davidmfoley/events{/privacy}","received_events_url":"https://api.github.com/users/davidmfoley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidmfoley/Vim","description":":star: Vim for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/davidmfoley/Vim","forks_url":"https://api.github.com/repos/davidmfoley/Vim/forks","keys_url":"https://api.github.com/repos/davidmfoley/Vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidmfoley/Vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidmfoley/Vim/teams","hooks_url":"https://api.github.com/repos/davidmfoley/Vim/hooks","issue_events_url":"https://api.github.com/repos/davidmfoley/Vim/issues/events{/number}","events_url":"https://api.github.com/repos/davidmfoley/Vim/events","assignees_url":"https://api.github.com/repos/davidmfoley/Vim/assignees{/user}","branches_url":"https://api.github.com/repos/davidmfoley/Vim/branches{/branch}","tags_url":"https://api.github.com/repos/davidmfoley/Vim/tags","blobs_url":"https://api.github.com/repos/davidmfoley/Vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidmfoley/Vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidmfoley/Vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidmfoley/Vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidmfoley/Vim/statuses/{sha}","languages_url":"https://api.github.com/repos/davidmfoley/Vim/languages","stargazers_url":"https://api.github.com/repos/davidmfoley/Vim/stargazers","contributors_url":"https://api.github.com/repos/davidmfoley/Vim/contributors","subscribers_url":"https://api.github.com/repos/davidmfoley/Vim/subscribers","subscription_url":"https://api.github.com/repos/davidmfoley/Vim/subscription","commits_url":"https://api.github.com/repos/davidmfoley/Vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidmfoley/Vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidmfoley/Vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidmfoley/Vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidmfoley/Vim/contents/{+path}","compare_url":"https://api.github.com/repos/davidmfoley/Vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidmfoley/Vim/merges","archive_url":"https://api.github.com/repos/davidmfoley/Vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidmfoley/Vim/downloads","issues_url":"https://api.github.com/repos/davidmfoley/Vim/issues{/number}","pulls_url":"https://api.github.com/repos/davidmfoley/Vim/pulls{/number}","milestones_url":"https://api.github.com/repos/davidmfoley/Vim/milestones{/number}","notifications_url":"https://api.github.com/repos/davidmfoley/Vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidmfoley/Vim/labels{/name}","releases_url":"https://api.github.com/repos/davidmfoley/Vim/releases{/id}","deployments_url":"https://api.github.com/repos/davidmfoley/Vim/deployments","created_at":"2018-07-19T19:47:07Z","updated_at":"2018-07-19T19:47:09Z","pushed_at":"2018-07-20T20:25:45Z","git_url":"git://github.com/davidmfoley/Vim.git","ssh_url":"git@github.com:davidmfoley/Vim.git","clone_url":"https://github.com/davidmfoley/Vim.git","svn_url":"https://github.com/davidmfoley/Vim","homepage":"http://aka.ms/vscodevim","size":6294,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VSCodeVim:master","ref":"master","sha":"7f1c80406176f0031f489cccf52b8d4931577184","user":{"login":"VSCodeVim","id":15813386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODEzMzg2","avatar_url":"https://avatars1.githubusercontent.com/u/15813386?v=4","gravatar_id":"","url":"https://api.github.com/users/VSCodeVim","html_url":"https://github.com/VSCodeVim","followers_url":"https://api.github.com/users/VSCodeVim/followers","following_url":"https://api.github.com/users/VSCodeVim/following{/other_user}","gists_url":"https://api.github.com/users/VSCodeVim/gists{/gist_id}","starred_url":"https://api.github.com/users/VSCodeVim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSCodeVim/subscriptions","organizations_url":"https://api.github.com/users/VSCodeVim/orgs","repos_url":"https://api.github.com/users/VSCodeVim/repos","events_url":"https://api.github.com/users/VSCodeVim/events{/privacy}","received_events_url":"https://api.github.com/users/VSCodeVim/received_events","type":"Organization","site_admin":false},"repo":{"id":46041284,"node_id":"MDEwOlJlcG9zaXRvcnk0NjA0MTI4NA==","name":"Vim","full_name":"VSCodeVim/Vim","owner":{"login":"VSCodeVim","id":15813386,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODEzMzg2","avatar_url":"https://avatars1.githubusercontent.com/u/15813386?v=4","gravatar_id":"","url":"https://api.github.com/users/VSCodeVim","html_url":"https://github.com/VSCodeVim","followers_url":"https://api.github.com/users/VSCodeVim/followers","following_url":"https://api.github.com/users/VSCodeVim/following{/other_user}","gists_url":"https://api.github.com/users/VSCodeVim/gists{/gist_id}","starred_url":"https://api.github.com/users/VSCodeVim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSCodeVim/subscriptions","organizations_url":"https://api.github.com/users/VSCodeVim/orgs","repos_url":"https://api.github.com/users/VSCodeVim/repos","events_url":"https://api.github.com/users/VSCodeVim/events{/privacy}","received_events_url":"https://api.github.com/users/VSCodeVim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VSCodeVim/Vim","description":":star: Vim for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/VSCodeVim/Vim","forks_url":"https://api.github.com/repos/VSCodeVim/Vim/forks","keys_url":"https://api.github.com/repos/VSCodeVim/Vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VSCodeVim/Vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VSCodeVim/Vim/teams","hooks_url":"https://api.github.com/repos/VSCodeVim/Vim/hooks","issue_events_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/events{/number}","events_url":"https://api.github.com/repos/VSCodeVim/Vim/events","assignees_url":"https://api.github.com/repos/VSCodeVim/Vim/assignees{/user}","branches_url":"https://api.github.com/repos/VSCodeVim/Vim/branches{/branch}","tags_url":"https://api.github.com/repos/VSCodeVim/Vim/tags","blobs_url":"https://api.github.com/repos/VSCodeVim/Vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VSCodeVim/Vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VSCodeVim/Vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/VSCodeVim/Vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VSCodeVim/Vim/statuses/{sha}","languages_url":"https://api.github.com/repos/VSCodeVim/Vim/languages","stargazers_url":"https://api.github.com/repos/VSCodeVim/Vim/stargazers","contributors_url":"https://api.github.com/repos/VSCodeVim/Vim/contributors","subscribers_url":"https://api.github.com/repos/VSCodeVim/Vim/subscribers","subscription_url":"https://api.github.com/repos/VSCodeVim/Vim/subscription","commits_url":"https://api.github.com/repos/VSCodeVim/Vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/VSCodeVim/Vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/VSCodeVim/Vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/VSCodeVim/Vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/VSCodeVim/Vim/contents/{+path}","compare_url":"https://api.github.com/repos/VSCodeVim/Vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VSCodeVim/Vim/merges","archive_url":"https://api.github.com/repos/VSCodeVim/Vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VSCodeVim/Vim/downloads","issues_url":"https://api.github.com/repos/VSCodeVim/Vim/issues{/number}","pulls_url":"https://api.github.com/repos/VSCodeVim/Vim/pulls{/number}","milestones_url":"https://api.github.com/repos/VSCodeVim/Vim/milestones{/number}","notifications_url":"https://api.github.com/repos/VSCodeVim/Vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VSCodeVim/Vim/labels{/name}","releases_url":"https://api.github.com/repos/VSCodeVim/Vim/releases{/id}","deployments_url":"https://api.github.com/repos/VSCodeVim/Vim/deployments","created_at":"2015-11-12T09:02:23Z","updated_at":"2018-07-21T02:19:21Z","pushed_at":"2018-07-21T18:48:23Z","git_url":"git://github.com/VSCodeVim/Vim.git","ssh_url":"git@github.com:VSCodeVim/Vim.git","clone_url":"https://github.com/VSCodeVim/Vim.git","svn_url":"https://github.com/VSCodeVim/Vim","homepage":"http://aka.ms/vscodevim","size":6294,"stargazers_count":3627,"watchers_count":3627,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":395,"mirror_url":null,"archived":false,"open_issues_count":419,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":395,"open_issues":419,"watchers":3627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/2864"},"html":{"href":"https://github.com/VSCodeVim/Vim/pull/2864"},"issue":{"href":"https://api.github.com/repos/VSCodeVim/Vim/issues/2864"},"comments":{"href":"https://api.github.com/repos/VSCodeVim/Vim/issues/2864/comments"},"review_comments":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/2864/comments"},"review_comment":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VSCodeVim/Vim/pulls/2864/commits"},"statuses":{"href":"https://api.github.com/repos/VSCodeVim/Vim/statuses/44eca6758d267ade1dc3b21fc640fcec66f74403"}},"author_association":"NONE"}}
{"actor":{"display_login":"xconverge"}}