{"action":"created","comment":{"url":"https://api.github.com/repos/python/cpython/pulls/comments/216287491","pull_request_review_id":153731328,"id":216287491,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjI4NzQ5MQ==","diff_hunk":"@@ -293,7 +288,7 @@ _sre_ascii_iscased_impl(PyObject *module, int character)\n /*[clinic end generated code: output=4f454b630fbd19a2 input=9f0bd952812c7ed3]*/\n {\n     unsigned int ch = (unsigned int)character;\n-    return ch != sre_lower_ascii(ch) || ch != sre_upper_ascii(ch);\n+    return ch <= 'z' && Py_ISALPHA(ch);","path":"Modules/_sre.c","position":17,"original_position":17,"commit_id":"736a9c12ee4800b7ad4374ceda46fe1dc396298d","original_commit_id":"736a9c12ee4800b7ad4374ceda46fe1dc396298d","user":{"login":"serhiy-storchaka","id":3659035,"node_id":"MDQ6VXNlcjM2NTkwMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/3659035?v=4","gravatar_id":"","url":"https://api.github.com/users/serhiy-storchaka","html_url":"https://github.com/serhiy-storchaka","followers_url":"https://api.github.com/users/serhiy-storchaka/followers","following_url":"https://api.github.com/users/serhiy-storchaka/following{/other_user}","gists_url":"https://api.github.com/users/serhiy-storchaka/gists{/gist_id}","starred_url":"https://api.github.com/users/serhiy-storchaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serhiy-storchaka/subscriptions","organizations_url":"https://api.github.com/users/serhiy-storchaka/orgs","repos_url":"https://api.github.com/users/serhiy-storchaka/repos","events_url":"https://api.github.com/users/serhiy-storchaka/events{/privacy}","received_events_url":"https://api.github.com/users/serhiy-storchaka/received_events","type":"User","site_admin":false},"body":"I would use `127` instead of `'z'`.","created_at":"2018-09-10T11:31:33Z","updated_at":"2018-09-10T11:31:34Z","html_url":"https://github.com/python/cpython/pull/9097#discussion_r216287491","pull_request_url":"https://api.github.com/repos/python/cpython/pulls/9097","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/comments/216287491"},"html":{"href":"https://github.com/python/cpython/pull/9097#discussion_r216287491"},"pull_request":{"href":"https://api.github.com/repos/python/cpython/pulls/9097"}}},"pull_request":{"url":"https://api.github.com/repos/python/cpython/pulls/9097","id":213889304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODg5MzA0","html_url":"https://github.com/python/cpython/pull/9097","diff_url":"https://github.com/python/cpython/pull/9097.diff","patch_url":"https://github.com/python/cpython/pull/9097.patch","issue_url":"https://api.github.com/repos/python/cpython/issues/9097","number":9097,"state":"open","locked":false,"title":"Simplified implementation of _sre.ascii_iscased().","user":{"login":"sir-sigurd","id":481910,"node_id":"MDQ6VXNlcjQ4MTkxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/481910?v=4","gravatar_id":"","url":"https://api.github.com/users/sir-sigurd","html_url":"https://github.com/sir-sigurd","followers_url":"https://api.github.com/users/sir-sigurd/followers","following_url":"https://api.github.com/users/sir-sigurd/following{/other_user}","gists_url":"https://api.github.com/users/sir-sigurd/gists{/gist_id}","starred_url":"https://api.github.com/users/sir-sigurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sir-sigurd/subscriptions","organizations_url":"https://api.github.com/users/sir-sigurd/orgs","repos_url":"https://api.github.com/users/sir-sigurd/repos","events_url":"https://api.github.com/users/sir-sigurd/events{/privacy}","received_events_url":"https://api.github.com/users/sir-sigurd/received_events","type":"User","site_admin":false},"body":"<!--\r\nThanks for your contribution!\r\nPlease read this comment in its entirety. It's quite important.\r\n\r\n# Pull Request title\r\n\r\nIt should be in the following format:\r\n\r\n```\r\nbpo-NNNN: Summary of the changes made\r\n```\r\n\r\nWhere: bpo-NNNN refers to the issue number in the https://bugs.python.org.\r\n\r\nMost PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.\r\n\r\n# Backport Pull Request title\r\n\r\nIf this is a backport PR (PR made against branches other than `master`),\r\nplease ensure that the PR title is in the following format:\r\n\r\n```\r\n[X.Y] <title from the original PR> (GH-NNNN)\r\n```\r\n\r\nWhere: [X.Y] is the branch name, e.g. [3.6].\r\n\r\nGH-NNNN refers to the PR number from `master`.\r\n\r\n-->\r\n","created_at":"2018-09-07T10:47:00Z","updated_at":"2018-09-10T11:31:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78fac2422b847c9afce3283a4d1b416faccdbf86","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":536945472,"node_id":"MDU6TGFiZWw1MzY5NDU0NzI=","url":"https://api.github.com/repos/python/cpython/labels/CLA%20signed","name":"CLA signed","color":"0e8a16","default":false},{"id":666980059,"node_id":"MDU6TGFiZWw2NjY5ODAwNTk=","url":"https://api.github.com/repos/python/cpython/labels/awaiting%20merge","name":"awaiting merge","color":"fbca04","default":false},{"id":647202665,"node_id":"MDU6TGFiZWw2NDcyMDI2NjU=","url":"https://api.github.com/repos/python/cpython/labels/skip%20issue","name":"skip issue","color":"000000","default":false},{"id":667924166,"node_id":"MDU6TGFiZWw2Njc5MjQxNjY=","url":"https://api.github.com/repos/python/cpython/labels/skip%20news","name":"skip news","color":"000000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/python/cpython/pulls/9097/commits","review_comments_url":"https://api.github.com/repos/python/cpython/pulls/9097/comments","review_comment_url":"https://api.github.com/repos/python/cpython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python/cpython/issues/9097/comments","statuses_url":"https://api.github.com/repos/python/cpython/statuses/736a9c12ee4800b7ad4374ceda46fe1dc396298d","head":{"label":"sir-sigurd:sre-ascii-iscased","ref":"sre-ascii-iscased","sha":"736a9c12ee4800b7ad4374ceda46fe1dc396298d","user":{"login":"sir-sigurd","id":481910,"node_id":"MDQ6VXNlcjQ4MTkxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/481910?v=4","gravatar_id":"","url":"https://api.github.com/users/sir-sigurd","html_url":"https://github.com/sir-sigurd","followers_url":"https://api.github.com/users/sir-sigurd/followers","following_url":"https://api.github.com/users/sir-sigurd/following{/other_user}","gists_url":"https://api.github.com/users/sir-sigurd/gists{/gist_id}","starred_url":"https://api.github.com/users/sir-sigurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sir-sigurd/subscriptions","organizations_url":"https://api.github.com/users/sir-sigurd/orgs","repos_url":"https://api.github.com/users/sir-sigurd/repos","events_url":"https://api.github.com/users/sir-sigurd/events{/privacy}","received_events_url":"https://api.github.com/users/sir-sigurd/received_events","type":"User","site_admin":false},"repo":{"id":94994425,"node_id":"MDEwOlJlcG9zaXRvcnk5NDk5NDQyNQ==","name":"cpython","full_name":"sir-sigurd/cpython","owner":{"login":"sir-sigurd","id":481910,"node_id":"MDQ6VXNlcjQ4MTkxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/481910?v=4","gravatar_id":"","url":"https://api.github.com/users/sir-sigurd","html_url":"https://github.com/sir-sigurd","followers_url":"https://api.github.com/users/sir-sigurd/followers","following_url":"https://api.github.com/users/sir-sigurd/following{/other_user}","gists_url":"https://api.github.com/users/sir-sigurd/gists{/gist_id}","starred_url":"https://api.github.com/users/sir-sigurd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sir-sigurd/subscriptions","organizations_url":"https://api.github.com/users/sir-sigurd/orgs","repos_url":"https://api.github.com/users/sir-sigurd/repos","events_url":"https://api.github.com/users/sir-sigurd/events{/privacy}","received_events_url":"https://api.github.com/users/sir-sigurd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sir-sigurd/cpython","description":"The Python programming language","fork":true,"url":"https://api.github.com/repos/sir-sigurd/cpython","forks_url":"https://api.github.com/repos/sir-sigurd/cpython/forks","keys_url":"https://api.github.com/repos/sir-sigurd/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sir-sigurd/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sir-sigurd/cpython/teams","hooks_url":"https://api.github.com/repos/sir-sigurd/cpython/hooks","issue_events_url":"https://api.github.com/repos/sir-sigurd/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/sir-sigurd/cpython/events","assignees_url":"https://api.github.com/repos/sir-sigurd/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/sir-sigurd/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/sir-sigurd/cpython/tags","blobs_url":"https://api.github.com/repos/sir-sigurd/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sir-sigurd/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sir-sigurd/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/sir-sigurd/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sir-sigurd/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/sir-sigurd/cpython/languages","stargazers_url":"https://api.github.com/repos/sir-sigurd/cpython/stargazers","contributors_url":"https://api.github.com/repos/sir-sigurd/cpython/contributors","subscribers_url":"https://api.github.com/repos/sir-sigurd/cpython/subscribers","subscription_url":"https://api.github.com/repos/sir-sigurd/cpython/subscription","commits_url":"https://api.github.com/repos/sir-sigurd/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/sir-sigurd/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/sir-sigurd/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/sir-sigurd/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/sir-sigurd/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/sir-sigurd/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sir-sigurd/cpython/merges","archive_url":"https://api.github.com/repos/sir-sigurd/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sir-sigurd/cpython/downloads","issues_url":"https://api.github.com/repos/sir-sigurd/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/sir-sigurd/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/sir-sigurd/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/sir-sigurd/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sir-sigurd/cpython/labels{/name}","releases_url":"https://api.github.com/repos/sir-sigurd/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/sir-sigurd/cpython/deployments","created_at":"2017-06-21T10:53:33Z","updated_at":"2017-06-21T10:53:57Z","pushed_at":"2018-09-10T09:45:50Z","git_url":"git://github.com/sir-sigurd/cpython.git","ssh_url":"git@github.com:sir-sigurd/cpython.git","clone_url":"https://github.com/sir-sigurd/cpython.git","svn_url":"https://github.com/sir-sigurd/cpython","homepage":"https://www.python.org/","size":234764,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python:master","ref":"master","sha":"25fa141487e61b94f15289619cb3af764cf65e58","user":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"repo":{"id":81598961,"node_id":"MDEwOlJlcG9zaXRvcnk4MTU5ODk2MQ==","name":"cpython","full_name":"python/cpython","owner":{"login":"python","id":1525981,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjU5ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1525981?v=4","gravatar_id":"","url":"https://api.github.com/users/python","html_url":"https://github.com/python","followers_url":"https://api.github.com/users/python/followers","following_url":"https://api.github.com/users/python/following{/other_user}","gists_url":"https://api.github.com/users/python/gists{/gist_id}","starred_url":"https://api.github.com/users/python/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python/subscriptions","organizations_url":"https://api.github.com/users/python/orgs","repos_url":"https://api.github.com/users/python/repos","events_url":"https://api.github.com/users/python/events{/privacy}","received_events_url":"https://api.github.com/users/python/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python/cpython","description":"The Python programming language","fork":false,"url":"https://api.github.com/repos/python/cpython","forks_url":"https://api.github.com/repos/python/cpython/forks","keys_url":"https://api.github.com/repos/python/cpython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python/cpython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python/cpython/teams","hooks_url":"https://api.github.com/repos/python/cpython/hooks","issue_events_url":"https://api.github.com/repos/python/cpython/issues/events{/number}","events_url":"https://api.github.com/repos/python/cpython/events","assignees_url":"https://api.github.com/repos/python/cpython/assignees{/user}","branches_url":"https://api.github.com/repos/python/cpython/branches{/branch}","tags_url":"https://api.github.com/repos/python/cpython/tags","blobs_url":"https://api.github.com/repos/python/cpython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python/cpython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python/cpython/git/refs{/sha}","trees_url":"https://api.github.com/repos/python/cpython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python/cpython/statuses/{sha}","languages_url":"https://api.github.com/repos/python/cpython/languages","stargazers_url":"https://api.github.com/repos/python/cpython/stargazers","contributors_url":"https://api.github.com/repos/python/cpython/contributors","subscribers_url":"https://api.github.com/repos/python/cpython/subscribers","subscription_url":"https://api.github.com/repos/python/cpython/subscription","commits_url":"https://api.github.com/repos/python/cpython/commits{/sha}","git_commits_url":"https://api.github.com/repos/python/cpython/git/commits{/sha}","comments_url":"https://api.github.com/repos/python/cpython/comments{/number}","issue_comment_url":"https://api.github.com/repos/python/cpython/issues/comments{/number}","contents_url":"https://api.github.com/repos/python/cpython/contents/{+path}","compare_url":"https://api.github.com/repos/python/cpython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python/cpython/merges","archive_url":"https://api.github.com/repos/python/cpython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python/cpython/downloads","issues_url":"https://api.github.com/repos/python/cpython/issues{/number}","pulls_url":"https://api.github.com/repos/python/cpython/pulls{/number}","milestones_url":"https://api.github.com/repos/python/cpython/milestones{/number}","notifications_url":"https://api.github.com/repos/python/cpython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python/cpython/labels{/name}","releases_url":"https://api.github.com/repos/python/cpython/releases{/id}","deployments_url":"https://api.github.com/repos/python/cpython/deployments","created_at":"2017-02-10T19:23:51Z","updated_at":"2018-09-10T09:45:14Z","pushed_at":"2018-09-10T10:45:55Z","git_url":"git://github.com/python/cpython.git","ssh_url":"git@github.com:python/cpython.git","clone_url":"https://github.com/python/cpython.git","svn_url":"https://github.com/python/cpython","homepage":"https://www.python.org/","size":247255,"stargazers_count":19653,"watchers_count":19653,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6730,"mirror_url":null,"archived":false,"open_issues_count":902,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":6730,"open_issues":902,"watchers":19653,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python/cpython/pulls/9097"},"html":{"href":"https://github.com/python/cpython/pull/9097"},"issue":{"href":"https://api.github.com/repos/python/cpython/issues/9097"},"comments":{"href":"https://api.github.com/repos/python/cpython/issues/9097/comments"},"review_comments":{"href":"https://api.github.com/repos/python/cpython/pulls/9097/comments"},"review_comment":{"href":"https://api.github.com/repos/python/cpython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python/cpython/pulls/9097/commits"},"statuses":{"href":"https://api.github.com/repos/python/cpython/statuses/736a9c12ee4800b7ad4374ceda46fe1dc396298d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"serhiy-storchaka"}}