{"action":"created","comment":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/223691087","pull_request_review_id":162876168,"id":223691087,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzY5MTA4Nw==","diff_hunk":"@@ -317,67 +317,138 @@ func ensureNoNewEvent(ch <-chan interface{}, timeout time.Duration,\n \t}\n }\n \n-func ensureNoNewStep(stepCh <-chan interface{}) {\n+func ensureNoNewEventOnChannel(ch <-chan interface{}) {\n+\tensureNoNewEvent(ch, ensureTimeout, \"We should be stuck waiting, \"+\n+\t\t\"not receiving new event on the channel\")\n+}\n+\n+func ensureNoNewRoundStep(stepCh <-chan interface{}) {\n \tensureNoNewEvent(stepCh, ensureTimeout, \"We should be stuck waiting, \"+\n-\t\t\"not moving to the next step\")\n+\t\t\"not receiving NewRoundStep event\")\n+}\n+\n+func ensureNoNewUnlock(unlockCh <-chan interface{}) {\n+\tensureNoNewEvent(unlockCh, ensureTimeout, \"We should be stuck waiting, \"+\n+\t\t\"not receiving Unlock event\")\n }\n \n func ensureNoNewTimeout(stepCh <-chan interface{}, timeout int64) {\n \ttimeoutDuration := time.Duration(timeout*5) * time.Nanosecond\n \tensureNoNewEvent(stepCh, timeoutDuration, \"We should be stuck waiting, \"+\n-\t\t\"not moving to the next step\")\n+\t\t\"not receiving NewTimeout event\")","path":"consensus/common_test.go","position":25,"original_position":25,"commit_id":"82846935925950647e6209b3aa106818a21febe7","original_commit_id":"82846935925950647e6209b3aa106818a21febe7","user":{"login":"xla","id":1585,"node_id":"MDQ6VXNlcjE1ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1585?v=4","gravatar_id":"","url":"https://api.github.com/users/xla","html_url":"https://github.com/xla","followers_url":"https://api.github.com/users/xla/followers","following_url":"https://api.github.com/users/xla/following{/other_user}","gists_url":"https://api.github.com/users/xla/gists{/gist_id}","starred_url":"https://api.github.com/users/xla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xla/subscriptions","organizations_url":"https://api.github.com/users/xla/orgs","repos_url":"https://api.github.com/users/xla/repos","events_url":"https://api.github.com/users/xla/events{/privacy}","received_events_url":"https://api.github.com/users/xla/received_events","type":"User","site_admin":false},"body":"Same as above.","created_at":"2018-10-09T13:04:52Z","updated_at":"2018-10-09T13:18:51Z","html_url":"https://github.com/tendermint/tendermint/pull/2540#discussion_r223691087","pull_request_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2540","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments/223691087"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2540#discussion_r223691087"},"pull_request":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2540"}}},"pull_request":{"url":"https://api.github.com/repos/tendermint/tendermint/pulls/2540","id":220367164,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMzY3MTY0","html_url":"https://github.com/tendermint/tendermint/pull/2540","diff_url":"https://github.com/tendermint/tendermint/pull/2540.diff","patch_url":"https://github.com/tendermint/tendermint/pull/2540.patch","issue_url":"https://api.github.com/repos/tendermint/tendermint/issues/2540","number":2540,"state":"open","locked":false,"title":"consensus: Wait for proposal or timeout before prevote","user":{"login":"milosevic","id":1465543,"node_id":"MDQ6VXNlcjE0NjU1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1465543?v=4","gravatar_id":"","url":"https://api.github.com/users/milosevic","html_url":"https://github.com/milosevic","followers_url":"https://api.github.com/users/milosevic/followers","following_url":"https://api.github.com/users/milosevic/following{/other_user}","gists_url":"https://api.github.com/users/milosevic/gists{/gist_id}","starred_url":"https://api.github.com/users/milosevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milosevic/subscriptions","organizations_url":"https://api.github.com/users/milosevic/orgs","repos_url":"https://api.github.com/users/milosevic/repos","events_url":"https://api.github.com/users/milosevic/events{/privacy}","received_events_url":"https://api.github.com/users/milosevic/received_events","type":"User","site_admin":false},"body":"- Fix #1745. \r\n- Improve tests.\r\n \r\n","created_at":"2018-10-04T12:59:26Z","updated_at":"2018-10-09T13:18:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c45bc95dab86b419fa22c49356112fd9b92787b4","assignee":{"login":"milosevic","id":1465543,"node_id":"MDQ6VXNlcjE0NjU1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1465543?v=4","gravatar_id":"","url":"https://api.github.com/users/milosevic","html_url":"https://github.com/milosevic","followers_url":"https://api.github.com/users/milosevic/followers","following_url":"https://api.github.com/users/milosevic/following{/other_user}","gists_url":"https://api.github.com/users/milosevic/gists{/gist_id}","starred_url":"https://api.github.com/users/milosevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milosevic/subscriptions","organizations_url":"https://api.github.com/users/milosevic/orgs","repos_url":"https://api.github.com/users/milosevic/repos","events_url":"https://api.github.com/users/milosevic/events{/privacy}","received_events_url":"https://api.github.com/users/milosevic/received_events","type":"User","site_admin":false},"assignees":[{"login":"milosevic","id":1465543,"node_id":"MDQ6VXNlcjE0NjU1NDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1465543?v=4","gravatar_id":"","url":"https://api.github.com/users/milosevic","html_url":"https://github.com/milosevic","followers_url":"https://api.github.com/users/milosevic/followers","following_url":"https://api.github.com/users/milosevic/following{/other_user}","gists_url":"https://api.github.com/users/milosevic/gists{/gist_id}","starred_url":"https://api.github.com/users/milosevic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/milosevic/subscriptions","organizations_url":"https://api.github.com/users/milosevic/orgs","repos_url":"https://api.github.com/users/milosevic/repos","events_url":"https://api.github.com/users/milosevic/events{/privacy}","received_events_url":"https://api.github.com/users/milosevic/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"melekes","id":1282182,"node_id":"MDQ6VXNlcjEyODIxODI=","avatar_url":"https://avatars2.githubusercontent.com/u/1282182?v=4","gravatar_id":"","url":"https://api.github.com/users/melekes","html_url":"https://github.com/melekes","followers_url":"https://api.github.com/users/melekes/followers","following_url":"https://api.github.com/users/melekes/following{/other_user}","gists_url":"https://api.github.com/users/melekes/gists{/gist_id}","starred_url":"https://api.github.com/users/melekes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melekes/subscriptions","organizations_url":"https://api.github.com/users/melekes/orgs","repos_url":"https://api.github.com/users/melekes/repos","events_url":"https://api.github.com/users/melekes/events{/privacy}","received_events_url":"https://api.github.com/users/melekes/received_events","type":"User","site_admin":false},{"login":"ebuchman","id":2300911,"node_id":"MDQ6VXNlcjIzMDA5MTE=","avatar_url":"https://avatars3.githubusercontent.com/u/2300911?v=4","gravatar_id":"","url":"https://api.github.com/users/ebuchman","html_url":"https://github.com/ebuchman","followers_url":"https://api.github.com/users/ebuchman/followers","following_url":"https://api.github.com/users/ebuchman/following{/other_user}","gists_url":"https://api.github.com/users/ebuchman/gists{/gist_id}","starred_url":"https://api.github.com/users/ebuchman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebuchman/subscriptions","organizations_url":"https://api.github.com/users/ebuchman/orgs","repos_url":"https://api.github.com/users/ebuchman/repos","events_url":"https://api.github.com/users/ebuchman/events{/privacy}","received_events_url":"https://api.github.com/users/ebuchman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2540/commits","review_comments_url":"https://api.github.com/repos/tendermint/tendermint/pulls/2540/comments","review_comment_url":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tendermint/tendermint/issues/2540/comments","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/82846935925950647e6209b3aa106818a21febe7","head":{"label":"tendermint:zarko/1745-wait-for-proposal-or-timeout-before-prevote","ref":"zarko/1745-wait-for-proposal-or-timeout-before-prevote","sha":"82846935925950647e6209b3aa106818a21febe7","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","private":false,"owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-10-09T12:29:16Z","pushed_at":"2018-10-09T12:51:15Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":51479,"stargazers_count":2370,"watchers_count":2370,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":582,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":582,"open_issues":321,"watchers":2370,"default_branch":"master"}},"base":{"label":"tendermint:develop","ref":"develop","sha":"8761b274896861aef79cd3341a84a65bfd905f44","user":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"repo":{"id":19799491,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc5OTQ5MQ==","name":"tendermint","full_name":"tendermint/tendermint","private":false,"owner":{"login":"tendermint","id":7572940,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc1NzI5NDA=","avatar_url":"https://avatars1.githubusercontent.com/u/7572940?v=4","gravatar_id":"","url":"https://api.github.com/users/tendermint","html_url":"https://github.com/tendermint","followers_url":"https://api.github.com/users/tendermint/followers","following_url":"https://api.github.com/users/tendermint/following{/other_user}","gists_url":"https://api.github.com/users/tendermint/gists{/gist_id}","starred_url":"https://api.github.com/users/tendermint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tendermint/subscriptions","organizations_url":"https://api.github.com/users/tendermint/orgs","repos_url":"https://api.github.com/users/tendermint/repos","events_url":"https://api.github.com/users/tendermint/events{/privacy}","received_events_url":"https://api.github.com/users/tendermint/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tendermint/tendermint","description":"⟁ Tendermint Core (BFT Consensus) in Go","fork":false,"url":"https://api.github.com/repos/tendermint/tendermint","forks_url":"https://api.github.com/repos/tendermint/tendermint/forks","keys_url":"https://api.github.com/repos/tendermint/tendermint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tendermint/tendermint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tendermint/tendermint/teams","hooks_url":"https://api.github.com/repos/tendermint/tendermint/hooks","issue_events_url":"https://api.github.com/repos/tendermint/tendermint/issues/events{/number}","events_url":"https://api.github.com/repos/tendermint/tendermint/events","assignees_url":"https://api.github.com/repos/tendermint/tendermint/assignees{/user}","branches_url":"https://api.github.com/repos/tendermint/tendermint/branches{/branch}","tags_url":"https://api.github.com/repos/tendermint/tendermint/tags","blobs_url":"https://api.github.com/repos/tendermint/tendermint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tendermint/tendermint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tendermint/tendermint/git/refs{/sha}","trees_url":"https://api.github.com/repos/tendermint/tendermint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tendermint/tendermint/statuses/{sha}","languages_url":"https://api.github.com/repos/tendermint/tendermint/languages","stargazers_url":"https://api.github.com/repos/tendermint/tendermint/stargazers","contributors_url":"https://api.github.com/repos/tendermint/tendermint/contributors","subscribers_url":"https://api.github.com/repos/tendermint/tendermint/subscribers","subscription_url":"https://api.github.com/repos/tendermint/tendermint/subscription","commits_url":"https://api.github.com/repos/tendermint/tendermint/commits{/sha}","git_commits_url":"https://api.github.com/repos/tendermint/tendermint/git/commits{/sha}","comments_url":"https://api.github.com/repos/tendermint/tendermint/comments{/number}","issue_comment_url":"https://api.github.com/repos/tendermint/tendermint/issues/comments{/number}","contents_url":"https://api.github.com/repos/tendermint/tendermint/contents/{+path}","compare_url":"https://api.github.com/repos/tendermint/tendermint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tendermint/tendermint/merges","archive_url":"https://api.github.com/repos/tendermint/tendermint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tendermint/tendermint/downloads","issues_url":"https://api.github.com/repos/tendermint/tendermint/issues{/number}","pulls_url":"https://api.github.com/repos/tendermint/tendermint/pulls{/number}","milestones_url":"https://api.github.com/repos/tendermint/tendermint/milestones{/number}","notifications_url":"https://api.github.com/repos/tendermint/tendermint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tendermint/tendermint/labels{/name}","releases_url":"https://api.github.com/repos/tendermint/tendermint/releases{/id}","deployments_url":"https://api.github.com/repos/tendermint/tendermint/deployments","created_at":"2014-05-14T23:21:35Z","updated_at":"2018-10-09T12:29:16Z","pushed_at":"2018-10-09T12:51:15Z","git_url":"git://github.com/tendermint/tendermint.git","ssh_url":"git@github.com:tendermint/tendermint.git","clone_url":"https://github.com/tendermint/tendermint.git","svn_url":"https://github.com/tendermint/tendermint","homepage":"https://tendermint.com/","size":51479,"stargazers_count":2370,"watchers_count":2370,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":582,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":582,"open_issues":321,"watchers":2370,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2540"},"html":{"href":"https://github.com/tendermint/tendermint/pull/2540"},"issue":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2540"},"comments":{"href":"https://api.github.com/repos/tendermint/tendermint/issues/2540/comments"},"review_comments":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2540/comments"},"review_comment":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tendermint/tendermint/pulls/2540/commits"},"statuses":{"href":"https://api.github.com/repos/tendermint/tendermint/statuses/82846935925950647e6209b3aa106818a21febe7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"xla"}}