{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/210433020","pull_request_review_id":146647849,"id":210433020,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDQzMzAyMA==","diff_hunk":"@@ -132,28 +133,15 @@ in\n       # outputs TODO: note that the tools will often not be linked by default\n       postBuild =\n         ''\n-          if [ -x $out/bin/update-mime-database -a -w $out/share/mime ]; then\n-              XDG_DATA_DIRS=$out/share $out/bin/update-mime-database -V $out/share/mime > /dev/null\n-          fi\n-\n           if [ -x $out/bin/gtk-update-icon-cache -a -f $out/share/icons/hicolor/index.theme ]; then","path":"nixos/modules/config/system-path.nix","position":34,"original_position":34,"commit_id":"2d6302a673e46a47965f6670ebe71154e3ff3b8a","original_commit_id":"2d6302a673e46a47965f6670ebe71154e3ff3b8a","user":{"login":"jtojnar","id":705123,"node_id":"MDQ6VXNlcjcwNTEyMw==","avatar_url":"https://avatars1.githubusercontent.com/u/705123?v=4","gravatar_id":"","url":"https://api.github.com/users/jtojnar","html_url":"https://github.com/jtojnar","followers_url":"https://api.github.com/users/jtojnar/followers","following_url":"https://api.github.com/users/jtojnar/following{/other_user}","gists_url":"https://api.github.com/users/jtojnar/gists{/gist_id}","starred_url":"https://api.github.com/users/jtojnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtojnar/subscriptions","organizations_url":"https://api.github.com/users/jtojnar/orgs","repos_url":"https://api.github.com/users/jtojnar/repos","events_url":"https://api.github.com/users/jtojnar/events{/privacy}","received_events_url":"https://api.github.com/users/jtojnar/received_events","type":"User","site_admin":false},"body":"Right, that looks like GTK thing: https://developer.gnome.org/gtk3/stable/gtk-update-icon-cache.html\r\n\r\nWe should probably get a module later.","created_at":"2018-08-15T22:47:36Z","updated_at":"2018-08-15T22:47:36Z","html_url":"https://github.com/NixOS/nixpkgs/pull/45058#discussion_r210433020","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45058","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/210433020"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45058#discussion_r210433020"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45058"}},"in_reply_to_id":210364797},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45058","id":208526932,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTI2OTMy","html_url":"https://github.com/NixOS/nixpkgs/pull/45058","diff_url":"https://github.com/NixOS/nixpkgs/pull/45058.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/45058.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45058","number":45058,"state":"open","locked":false,"title":"freedesktop modules: init","user":{"login":"michaelpj","id":1699466,"node_id":"MDQ6VXNlcjE2OTk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1699466?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelpj","html_url":"https://github.com/michaelpj","followers_url":"https://api.github.com/users/michaelpj/followers","following_url":"https://api.github.com/users/michaelpj/following{/other_user}","gists_url":"https://api.github.com/users/michaelpj/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpj/subscriptions","organizations_url":"https://api.github.com/users/michaelpj/orgs","repos_url":"https://api.github.com/users/michaelpj/repos","events_url":"https://api.github.com/users/michaelpj/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpj/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nFollow-up to/supersedes https://github.com/NixOS/nixpkgs/pull/44866.\r\n\r\nThis adds some modules that handle various parts of the XDG specs. This allows us to move some of the logic out of `system-path.nix`, and have a more sensible way to decide whether to update MIME caches.\r\n\r\nI then added an option to `system-path` to allow extra environment setup commands to be defined by other modules, so the MIME module can also have the setup code in it.\r\n\r\nPoints I'm unsure about\r\n- Should the XDG modules be enabled by default? Lots of things probably assume they are, but I could see the argument for not doing so. Currently all the DEs turn them on, so off by default would mean that a machine without a DE or X would also not have all the MIME stuff linked in, and so on.\r\n- I wasn't brave enough to try and have a module controlling the use of the base directory spec - this is pretty deeply woven into everything, so I'm not sure that gains us much. However, it would give us a central location to define the constants `/share` and `/etc/xdg`, which might have some value.\r\n- Is the `extraSetup` mechanism for `system-path` OK? It's a bit ugly that clients use `$out` to be the output of another derivation.\r\n\r\n@jtojnar @vcunat \r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-08-15T10:29:52Z","updated_at":"2018-08-15T22:47:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da9c25a9511410c6c3084f77639437105878077d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"node_id":"MDU6TGFiZWw3Mzc2NDI0MDg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false},{"id":60265212,"node_id":"MDU6TGFiZWw2MDI2NTIxMg==","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20nixos","name":"6.topic: nixos","color":"fef2c0","default":false},{"id":290122655,"node_id":"MDU6TGFiZWwyOTAxMjI2NTU=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20documentation","name":"8.has: documentation","color":"009800","default":false},{"id":290122884,"node_id":"MDU6TGFiZWwyOTAxMjI4ODQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20module%20(update)","name":"8.has: module (update)","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45058/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45058/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45058/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2d6302a673e46a47965f6670ebe71154e3ff3b8a","head":{"label":"michaelpj:imp/freedesktop-modules","ref":"imp/freedesktop-modules","sha":"2d6302a673e46a47965f6670ebe71154e3ff3b8a","user":{"login":"michaelpj","id":1699466,"node_id":"MDQ6VXNlcjE2OTk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1699466?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelpj","html_url":"https://github.com/michaelpj","followers_url":"https://api.github.com/users/michaelpj/followers","following_url":"https://api.github.com/users/michaelpj/following{/other_user}","gists_url":"https://api.github.com/users/michaelpj/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpj/subscriptions","organizations_url":"https://api.github.com/users/michaelpj/orgs","repos_url":"https://api.github.com/users/michaelpj/repos","events_url":"https://api.github.com/users/michaelpj/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpj/received_events","type":"User","site_admin":false},"repo":{"id":43151762,"node_id":"MDEwOlJlcG9zaXRvcnk0MzE1MTc2Mg==","name":"nixpkgs","full_name":"michaelpj/nixpkgs","owner":{"login":"michaelpj","id":1699466,"node_id":"MDQ6VXNlcjE2OTk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1699466?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelpj","html_url":"https://github.com/michaelpj","followers_url":"https://api.github.com/users/michaelpj/followers","following_url":"https://api.github.com/users/michaelpj/following{/other_user}","gists_url":"https://api.github.com/users/michaelpj/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpj/subscriptions","organizations_url":"https://api.github.com/users/michaelpj/orgs","repos_url":"https://api.github.com/users/michaelpj/repos","events_url":"https://api.github.com/users/michaelpj/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michaelpj/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/michaelpj/nixpkgs","forks_url":"https://api.github.com/repos/michaelpj/nixpkgs/forks","keys_url":"https://api.github.com/repos/michaelpj/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelpj/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelpj/nixpkgs/teams","hooks_url":"https://api.github.com/repos/michaelpj/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/michaelpj/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/michaelpj/nixpkgs/events","assignees_url":"https://api.github.com/repos/michaelpj/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/michaelpj/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/michaelpj/nixpkgs/tags","blobs_url":"https://api.github.com/repos/michaelpj/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelpj/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelpj/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelpj/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelpj/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelpj/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/michaelpj/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/michaelpj/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/michaelpj/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/michaelpj/nixpkgs/subscription","commits_url":"https://api.github.com/repos/michaelpj/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelpj/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelpj/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelpj/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelpj/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/michaelpj/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelpj/nixpkgs/merges","archive_url":"https://api.github.com/repos/michaelpj/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelpj/nixpkgs/downloads","issues_url":"https://api.github.com/repos/michaelpj/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/michaelpj/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelpj/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelpj/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelpj/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/michaelpj/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/michaelpj/nixpkgs/deployments","created_at":"2015-09-25T14:55:38Z","updated_at":"2017-01-01T17:13:27Z","pushed_at":"2018-08-15T17:30:00Z","git_url":"git://github.com/michaelpj/nixpkgs.git","ssh_url":"git@github.com:michaelpj/nixpkgs.git","clone_url":"https://github.com/michaelpj/nixpkgs.git","svn_url":"https://github.com/michaelpj/nixpkgs","homepage":null,"size":726875,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"cc288eef072c5feb6dd74740799a1349ef8fa58e","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-15T22:32:32Z","pushed_at":"2018-08-15T22:46:59Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":835739,"stargazers_count":2675,"watchers_count":2675,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2947,"mirror_url":null,"archived":false,"open_issues_count":3137,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2947,"open_issues":3137,"watchers":2675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45058"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45058"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45058"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45058/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45058/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45058/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/2d6302a673e46a47965f6670ebe71154e3ff3b8a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jtojnar"}}