{"action":"created","comment":{"url":"https://api.github.com/repos/killnine/s7netplus/pulls/comments/179959766","pull_request_review_id":110298708,"id":179959766,"diff_hunk":"@@ -108,8 +108,14 @@ public bool IsConnected\n         ///  If you use an external ethernet card, this must be set accordingly.</param>\n         public Plc(CpuType cpu, string ip, Int16 rack, Int16 slot)\n         {\n-            IP = ip;\n+            if (!Enum.IsDefined(typeof(CpuType), cpu))\n+                throw new InvalidEnumArgumentException(nameof(cpu), (int) cpu, typeof(CpuType));\n+\n+            if (string.IsNullOrEmpty(ip))\n+                throw new ArgumentException(\"IP address must valid.\", nameof(ip));\n+\n             CPU = cpu;\n+            IP = ip;","path":"S7.Net/PLC.cs","position":80,"original_position":12,"commit_id":"a99ea469ce23e5d3cfff7886bf558bc8a6a687a7","original_commit_id":"dd71e1bf0b89631fecf8668ec8373343bdcb6683","user":{"login":"mesta1","id":1765613,"avatar_url":"https://avatars3.githubusercontent.com/u/1765613?v=4","gravatar_id":"","url":"https://api.github.com/users/mesta1","html_url":"https://github.com/mesta1","followers_url":"https://api.github.com/users/mesta1/followers","following_url":"https://api.github.com/users/mesta1/following{/other_user}","gists_url":"https://api.github.com/users/mesta1/gists{/gist_id}","starred_url":"https://api.github.com/users/mesta1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mesta1/subscriptions","organizations_url":"https://api.github.com/users/mesta1/orgs","repos_url":"https://api.github.com/users/mesta1/repos","events_url":"https://api.github.com/users/mesta1/events{/privacy}","received_events_url":"https://api.github.com/users/mesta1/received_events","type":"User","site_admin":false},"body":"I prefere not to break anything, if possible. Imho wrong IP address is not a major concern. If it's invalid, it will throw exception.","created_at":"2018-04-08T20:11:06Z","updated_at":"2018-04-08T20:11:06Z","html_url":"https://github.com/killnine/s7netplus/pull/102#discussion_r179959766","pull_request_url":"https://api.github.com/repos/killnine/s7netplus/pulls/102","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/comments/179959766"},"html":{"href":"https://github.com/killnine/s7netplus/pull/102#discussion_r179959766"},"pull_request":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/102"}},"in_reply_to_id":176249242},"pull_request":{"url":"https://api.github.com/repos/killnine/s7netplus/pulls/102","id":176618547,"html_url":"https://github.com/killnine/s7netplus/pull/102","diff_url":"https://github.com/killnine/s7netplus/pull/102.diff","patch_url":"https://github.com/killnine/s7netplus/pull/102.patch","issue_url":"https://api.github.com/repos/killnine/s7netplus/issues/102","number":102,"state":"open","locked":false,"title":"Non breaking changes. Code styling, comments, etc...","user":{"login":"mbalous","id":10358985,"avatar_url":"https://avatars0.githubusercontent.com/u/10358985?v=4","gravatar_id":"","url":"https://api.github.com/users/mbalous","html_url":"https://github.com/mbalous","followers_url":"https://api.github.com/users/mbalous/followers","following_url":"https://api.github.com/users/mbalous/following{/other_user}","gists_url":"https://api.github.com/users/mbalous/gists{/gist_id}","starred_url":"https://api.github.com/users/mbalous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbalous/subscriptions","organizations_url":"https://api.github.com/users/mbalous/orgs","repos_url":"https://api.github.com/users/mbalous/repos","events_url":"https://api.github.com/users/mbalous/events{/privacy}","received_events_url":"https://api.github.com/users/mbalous/received_events","type":"User","site_admin":false},"body":"Improved XML comments.\r\nThrowing more descriptive exceptions.\r\nChecking constructor parameters.\r\nImproved code styling consistency.\r\n\r\nThese should be non-breaking changes.","created_at":"2018-03-21T21:45:01Z","updated_at":"2018-04-08T20:11:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dd0f5688ff2e30d03e9f4daa2700386e4c39f09","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/killnine/s7netplus/pulls/102/commits","review_comments_url":"https://api.github.com/repos/killnine/s7netplus/pulls/102/comments","review_comment_url":"https://api.github.com/repos/killnine/s7netplus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/killnine/s7netplus/issues/102/comments","statuses_url":"https://api.github.com/repos/killnine/s7netplus/statuses/a99ea469ce23e5d3cfff7886bf558bc8a6a687a7","head":{"label":"mbalous:master","ref":"master","sha":"a99ea469ce23e5d3cfff7886bf558bc8a6a687a7","user":{"login":"mbalous","id":10358985,"avatar_url":"https://avatars0.githubusercontent.com/u/10358985?v=4","gravatar_id":"","url":"https://api.github.com/users/mbalous","html_url":"https://github.com/mbalous","followers_url":"https://api.github.com/users/mbalous/followers","following_url":"https://api.github.com/users/mbalous/following{/other_user}","gists_url":"https://api.github.com/users/mbalous/gists{/gist_id}","starred_url":"https://api.github.com/users/mbalous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbalous/subscriptions","organizations_url":"https://api.github.com/users/mbalous/orgs","repos_url":"https://api.github.com/users/mbalous/repos","events_url":"https://api.github.com/users/mbalous/events{/privacy}","received_events_url":"https://api.github.com/users/mbalous/received_events","type":"User","site_admin":false},"repo":{"id":126241765,"name":"s7netplus","full_name":"mbalous/s7netplus","owner":{"login":"mbalous","id":10358985,"avatar_url":"https://avatars0.githubusercontent.com/u/10358985?v=4","gravatar_id":"","url":"https://api.github.com/users/mbalous","html_url":"https://github.com/mbalous","followers_url":"https://api.github.com/users/mbalous/followers","following_url":"https://api.github.com/users/mbalous/following{/other_user}","gists_url":"https://api.github.com/users/mbalous/gists{/gist_id}","starred_url":"https://api.github.com/users/mbalous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbalous/subscriptions","organizations_url":"https://api.github.com/users/mbalous/orgs","repos_url":"https://api.github.com/users/mbalous/repos","events_url":"https://api.github.com/users/mbalous/events{/privacy}","received_events_url":"https://api.github.com/users/mbalous/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbalous/s7netplus","description":"S7.NET+ -- A .NET library to connect to Siemens Step7 devices","fork":true,"url":"https://api.github.com/repos/mbalous/s7netplus","forks_url":"https://api.github.com/repos/mbalous/s7netplus/forks","keys_url":"https://api.github.com/repos/mbalous/s7netplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbalous/s7netplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbalous/s7netplus/teams","hooks_url":"https://api.github.com/repos/mbalous/s7netplus/hooks","issue_events_url":"https://api.github.com/repos/mbalous/s7netplus/issues/events{/number}","events_url":"https://api.github.com/repos/mbalous/s7netplus/events","assignees_url":"https://api.github.com/repos/mbalous/s7netplus/assignees{/user}","branches_url":"https://api.github.com/repos/mbalous/s7netplus/branches{/branch}","tags_url":"https://api.github.com/repos/mbalous/s7netplus/tags","blobs_url":"https://api.github.com/repos/mbalous/s7netplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbalous/s7netplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbalous/s7netplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbalous/s7netplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbalous/s7netplus/statuses/{sha}","languages_url":"https://api.github.com/repos/mbalous/s7netplus/languages","stargazers_url":"https://api.github.com/repos/mbalous/s7netplus/stargazers","contributors_url":"https://api.github.com/repos/mbalous/s7netplus/contributors","subscribers_url":"https://api.github.com/repos/mbalous/s7netplus/subscribers","subscription_url":"https://api.github.com/repos/mbalous/s7netplus/subscription","commits_url":"https://api.github.com/repos/mbalous/s7netplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbalous/s7netplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbalous/s7netplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbalous/s7netplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbalous/s7netplus/contents/{+path}","compare_url":"https://api.github.com/repos/mbalous/s7netplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbalous/s7netplus/merges","archive_url":"https://api.github.com/repos/mbalous/s7netplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbalous/s7netplus/downloads","issues_url":"https://api.github.com/repos/mbalous/s7netplus/issues{/number}","pulls_url":"https://api.github.com/repos/mbalous/s7netplus/pulls{/number}","milestones_url":"https://api.github.com/repos/mbalous/s7netplus/milestones{/number}","notifications_url":"https://api.github.com/repos/mbalous/s7netplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbalous/s7netplus/labels{/name}","releases_url":"https://api.github.com/repos/mbalous/s7netplus/releases{/id}","deployments_url":"https://api.github.com/repos/mbalous/s7netplus/deployments","created_at":"2018-03-21T21:18:06Z","updated_at":"2018-03-21T21:40:33Z","pushed_at":"2018-03-21T21:40:32Z","git_url":"git://github.com/mbalous/s7netplus.git","ssh_url":"git@github.com:mbalous/s7netplus.git","clone_url":"https://github.com/mbalous/s7netplus.git","svn_url":"https://github.com/mbalous/s7netplus","homepage":null,"size":2019,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"killnine:master","ref":"master","sha":"f6a2e11045aaf4a92c83c04f9c9be38a96a9fafa","user":{"login":"killnine","id":660420,"avatar_url":"https://avatars2.githubusercontent.com/u/660420?v=4","gravatar_id":"","url":"https://api.github.com/users/killnine","html_url":"https://github.com/killnine","followers_url":"https://api.github.com/users/killnine/followers","following_url":"https://api.github.com/users/killnine/following{/other_user}","gists_url":"https://api.github.com/users/killnine/gists{/gist_id}","starred_url":"https://api.github.com/users/killnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killnine/subscriptions","organizations_url":"https://api.github.com/users/killnine/orgs","repos_url":"https://api.github.com/users/killnine/repos","events_url":"https://api.github.com/users/killnine/events{/privacy}","received_events_url":"https://api.github.com/users/killnine/received_events","type":"User","site_admin":false},"repo":{"id":8101288,"name":"s7netplus","full_name":"killnine/s7netplus","owner":{"login":"killnine","id":660420,"avatar_url":"https://avatars2.githubusercontent.com/u/660420?v=4","gravatar_id":"","url":"https://api.github.com/users/killnine","html_url":"https://github.com/killnine","followers_url":"https://api.github.com/users/killnine/followers","following_url":"https://api.github.com/users/killnine/following{/other_user}","gists_url":"https://api.github.com/users/killnine/gists{/gist_id}","starred_url":"https://api.github.com/users/killnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killnine/subscriptions","organizations_url":"https://api.github.com/users/killnine/orgs","repos_url":"https://api.github.com/users/killnine/repos","events_url":"https://api.github.com/users/killnine/events{/privacy}","received_events_url":"https://api.github.com/users/killnine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/killnine/s7netplus","description":"S7.NET+ -- A .NET library to connect to Siemens Step7 devices","fork":false,"url":"https://api.github.com/repos/killnine/s7netplus","forks_url":"https://api.github.com/repos/killnine/s7netplus/forks","keys_url":"https://api.github.com/repos/killnine/s7netplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/killnine/s7netplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/killnine/s7netplus/teams","hooks_url":"https://api.github.com/repos/killnine/s7netplus/hooks","issue_events_url":"https://api.github.com/repos/killnine/s7netplus/issues/events{/number}","events_url":"https://api.github.com/repos/killnine/s7netplus/events","assignees_url":"https://api.github.com/repos/killnine/s7netplus/assignees{/user}","branches_url":"https://api.github.com/repos/killnine/s7netplus/branches{/branch}","tags_url":"https://api.github.com/repos/killnine/s7netplus/tags","blobs_url":"https://api.github.com/repos/killnine/s7netplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/killnine/s7netplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/killnine/s7netplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/killnine/s7netplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/killnine/s7netplus/statuses/{sha}","languages_url":"https://api.github.com/repos/killnine/s7netplus/languages","stargazers_url":"https://api.github.com/repos/killnine/s7netplus/stargazers","contributors_url":"https://api.github.com/repos/killnine/s7netplus/contributors","subscribers_url":"https://api.github.com/repos/killnine/s7netplus/subscribers","subscription_url":"https://api.github.com/repos/killnine/s7netplus/subscription","commits_url":"https://api.github.com/repos/killnine/s7netplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/killnine/s7netplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/killnine/s7netplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/killnine/s7netplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/killnine/s7netplus/contents/{+path}","compare_url":"https://api.github.com/repos/killnine/s7netplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/killnine/s7netplus/merges","archive_url":"https://api.github.com/repos/killnine/s7netplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/killnine/s7netplus/downloads","issues_url":"https://api.github.com/repos/killnine/s7netplus/issues{/number}","pulls_url":"https://api.github.com/repos/killnine/s7netplus/pulls{/number}","milestones_url":"https://api.github.com/repos/killnine/s7netplus/milestones{/number}","notifications_url":"https://api.github.com/repos/killnine/s7netplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/killnine/s7netplus/labels{/name}","releases_url":"https://api.github.com/repos/killnine/s7netplus/releases{/id}","deployments_url":"https://api.github.com/repos/killnine/s7netplus/deployments","created_at":"2013-02-08T21:00:55Z","updated_at":"2018-04-08T20:08:30Z","pushed_at":"2018-04-08T20:08:28Z","git_url":"git://github.com/killnine/s7netplus.git","ssh_url":"git@github.com:killnine/s7netplus.git","clone_url":"https://github.com/killnine/s7netplus.git","svn_url":"https://github.com/killnine/s7netplus","homepage":null,"size":2005,"stargazers_count":133,"watchers_count":133,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":86,"open_issues":27,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/102"},"html":{"href":"https://github.com/killnine/s7netplus/pull/102"},"issue":{"href":"https://api.github.com/repos/killnine/s7netplus/issues/102"},"comments":{"href":"https://api.github.com/repos/killnine/s7netplus/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/killnine/s7netplus/statuses/a99ea469ce23e5d3cfff7886bf558bc8a6a687a7"}},"author_association":"NONE"}}
{"actor":{"display_login":"mesta1"}}