{"action":"created","comment":{"url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/comments/171706943","pull_request_review_id":100593594,"id":171706943,"diff_hunk":"@@ -282,56 +721,92 @@\n             },\n \n             /**\n-             * If true, every other row in the table will appear with a background color to improve visual scanning.\n+             * Set to `true` to add a background color to every other row in\n+             * the grid. Can make it easier for users to scan across long rows.\n+             * Striping is disabled in group-by-column mode.\n              */\n             striped: {\n               type: Boolean,\n               value: false\n             },\n \n             /**\n-             * If true sets all columns to use ellipsis when text overflows the column,\n-             * enabling wrap mode while ellisis mode is enabled is an undefined state.\n+             * Set to `true` to show an ellipsis and truncate text for columns\n+             * where the text doesn't fit in the column.\n+             *\n+             * Do not enable wrap mode while ellipsis mode is enabled.\n              */\n             ellipsis: {\n               type: Boolean,\n               value: false\n             },\n \n             /**\n-             * How many milliseconds before loading spinner will be shown\n+             * Number of milliseconds to wait before showing the loading spinner\n+             * when requesting new data from the `remoteDataProvider`.\n              */\n             loadingSpinnerDebounce: {\n               type: Number,\n               value: 500\n             },\n \n             /**\n-             * To enable automatic filtering change property to true\n+             * Set to `true` to enable simple filtering. When enabled a search\n+             * box will be shown at the top of the grid. The user can type\n+             * in the search box to hide rows that don't include the stringified\n+             * value they're looking for.\n+             *\n+             * See `filterable` property for a more advanced filter option.\n              */\n             autoFilter: {\n               type: Boolean,\n               value: false\n             },\n \n             /**\n-             * Array of objects of conditions used to highlight specific columns.\n-             * Format:\n+             * List of rules used to highligh specific columns, rows, cells.","path":"px-data-grid-paginated.html","position":695,"original_position":695,"commit_id":"d8a92b202f792d7a0c22a12b61a4e5d808e57fde","original_commit_id":"d8a92b202f792d7a0c22a12b61a4e5d808e57fde","user":{"login":"randyaskin","id":2130613,"avatar_url":"https://avatars2.githubusercontent.com/u/2130613?v=4","gravatar_id":"","url":"https://api.github.com/users/randyaskin","html_url":"https://github.com/randyaskin","followers_url":"https://api.github.com/users/randyaskin/followers","following_url":"https://api.github.com/users/randyaskin/following{/other_user}","gists_url":"https://api.github.com/users/randyaskin/gists{/gist_id}","starred_url":"https://api.github.com/users/randyaskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randyaskin/subscriptions","organizations_url":"https://api.github.com/users/randyaskin/orgs","repos_url":"https://api.github.com/users/randyaskin/repos","events_url":"https://api.github.com/users/randyaskin/events{/privacy}","received_events_url":"https://api.github.com/users/randyaskin/received_events","type":"User","site_admin":false},"body":"`highlight` ... `rows, or cells.`","created_at":"2018-03-01T21:58:14Z","updated_at":"2018-03-01T22:04:33Z","html_url":"https://github.com/vaadin/px-data-grid/pull/723#discussion_r171706943","pull_request_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/723","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/comments/171706943"},"html":{"href":"https://github.com/vaadin/px-data-grid/pull/723#discussion_r171706943"},"pull_request":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/723"}}},"pull_request":{"url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/723","id":172352461,"html_url":"https://github.com/vaadin/px-data-grid/pull/723","diff_url":"https://github.com/vaadin/px-data-grid/pull/723.diff","patch_url":"https://github.com/vaadin/px-data-grid/pull/723.patch","issue_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/723","number":723,"state":"open","locked":false,"title":"[WIP DON'T MERGE] Update API docs for px-data-grid","user":{"login":"davidrleonard","id":6456757,"avatar_url":"https://avatars3.githubusercontent.com/u/6456757?v=4","gravatar_id":"","url":"https://api.github.com/users/davidrleonard","html_url":"https://github.com/davidrleonard","followers_url":"https://api.github.com/users/davidrleonard/followers","following_url":"https://api.github.com/users/davidrleonard/following{/other_user}","gists_url":"https://api.github.com/users/davidrleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrleonard/subscriptions","organizations_url":"https://api.github.com/users/davidrleonard/orgs","repos_url":"https://api.github.com/users/davidrleonard/repos","events_url":"https://api.github.com/users/davidrleonard/events{/privacy}","received_events_url":"https://api.github.com/users/davidrleonard/received_events","type":"User","site_admin":false},"body":"Rewrites a lot of the API docs in px-data-grid and px-data-grid-paginated for tone and style, expands on some properties that needed more definition.\r\n\r\nWe need to review this on GE's side before we merge. I'll have some of my team take a look. I'll mark it when it's ready to merge.\r\n\r\n@drewharvey If someone on your side has any time to glance over and see if we got anything wrong, that would be helpful. Otherwise no worries.","created_at":"2018-03-01T21:01:09Z","updated_at":"2018-03-01T22:04:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1450d92e2ffbb466eb4ac5d304f19deefde7b7a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/723/commits","review_comments_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/723/comments","review_comment_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/723/comments","statuses_url":"https://api.github.com/repos/vaadin/px-data-grid/statuses/d8a92b202f792d7a0c22a12b61a4e5d808e57fde","head":{"label":"davidrleonard:api-doc-fixes","ref":"api-doc-fixes","sha":"d8a92b202f792d7a0c22a12b61a4e5d808e57fde","user":{"login":"davidrleonard","id":6456757,"avatar_url":"https://avatars3.githubusercontent.com/u/6456757?v=4","gravatar_id":"","url":"https://api.github.com/users/davidrleonard","html_url":"https://github.com/davidrleonard","followers_url":"https://api.github.com/users/davidrleonard/followers","following_url":"https://api.github.com/users/davidrleonard/following{/other_user}","gists_url":"https://api.github.com/users/davidrleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrleonard/subscriptions","organizations_url":"https://api.github.com/users/davidrleonard/orgs","repos_url":"https://api.github.com/users/davidrleonard/repos","events_url":"https://api.github.com/users/davidrleonard/events{/privacy}","received_events_url":"https://api.github.com/users/davidrleonard/received_events","type":"User","site_admin":false},"repo":{"id":112514374,"name":"px-data-grid","full_name":"davidrleonard/px-data-grid","owner":{"login":"davidrleonard","id":6456757,"avatar_url":"https://avatars3.githubusercontent.com/u/6456757?v=4","gravatar_id":"","url":"https://api.github.com/users/davidrleonard","html_url":"https://github.com/davidrleonard","followers_url":"https://api.github.com/users/davidrleonard/followers","following_url":"https://api.github.com/users/davidrleonard/following{/other_user}","gists_url":"https://api.github.com/users/davidrleonard/gists{/gist_id}","starred_url":"https://api.github.com/users/davidrleonard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidrleonard/subscriptions","organizations_url":"https://api.github.com/users/davidrleonard/orgs","repos_url":"https://api.github.com/users/davidrleonard/repos","events_url":"https://api.github.com/users/davidrleonard/events{/privacy}","received_events_url":"https://api.github.com/users/davidrleonard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidrleonard/px-data-grid","description":"Predix UI component which defines a data grid","fork":true,"url":"https://api.github.com/repos/davidrleonard/px-data-grid","forks_url":"https://api.github.com/repos/davidrleonard/px-data-grid/forks","keys_url":"https://api.github.com/repos/davidrleonard/px-data-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidrleonard/px-data-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidrleonard/px-data-grid/teams","hooks_url":"https://api.github.com/repos/davidrleonard/px-data-grid/hooks","issue_events_url":"https://api.github.com/repos/davidrleonard/px-data-grid/issues/events{/number}","events_url":"https://api.github.com/repos/davidrleonard/px-data-grid/events","assignees_url":"https://api.github.com/repos/davidrleonard/px-data-grid/assignees{/user}","branches_url":"https://api.github.com/repos/davidrleonard/px-data-grid/branches{/branch}","tags_url":"https://api.github.com/repos/davidrleonard/px-data-grid/tags","blobs_url":"https://api.github.com/repos/davidrleonard/px-data-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidrleonard/px-data-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidrleonard/px-data-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidrleonard/px-data-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidrleonard/px-data-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/davidrleonard/px-data-grid/languages","stargazers_url":"https://api.github.com/repos/davidrleonard/px-data-grid/stargazers","contributors_url":"https://api.github.com/repos/davidrleonard/px-data-grid/contributors","subscribers_url":"https://api.github.com/repos/davidrleonard/px-data-grid/subscribers","subscription_url":"https://api.github.com/repos/davidrleonard/px-data-grid/subscription","commits_url":"https://api.github.com/repos/davidrleonard/px-data-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidrleonard/px-data-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidrleonard/px-data-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidrleonard/px-data-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidrleonard/px-data-grid/contents/{+path}","compare_url":"https://api.github.com/repos/davidrleonard/px-data-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidrleonard/px-data-grid/merges","archive_url":"https://api.github.com/repos/davidrleonard/px-data-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidrleonard/px-data-grid/downloads","issues_url":"https://api.github.com/repos/davidrleonard/px-data-grid/issues{/number}","pulls_url":"https://api.github.com/repos/davidrleonard/px-data-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/davidrleonard/px-data-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/davidrleonard/px-data-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidrleonard/px-data-grid/labels{/name}","releases_url":"https://api.github.com/repos/davidrleonard/px-data-grid/releases{/id}","deployments_url":"https://api.github.com/repos/davidrleonard/px-data-grid/deployments","created_at":"2017-11-29T18:49:26Z","updated_at":"2017-11-29T18:49:27Z","pushed_at":"2018-03-01T20:59:33Z","git_url":"git://github.com/davidrleonard/px-data-grid.git","ssh_url":"git@github.com:davidrleonard/px-data-grid.git","clone_url":"https://github.com/davidrleonard/px-data-grid.git","svn_url":"https://github.com/davidrleonard/px-data-grid","homepage":"","size":11141,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"db6ba2ff287bd9aa8b643c41c575402942343c9a","user":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":109969268,"name":"px-data-grid","full_name":"vaadin/px-data-grid","owner":{"login":"vaadin","id":1171922,"avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vaadin/px-data-grid","description":"Predix UI component which defines a data grid","fork":false,"url":"https://api.github.com/repos/vaadin/px-data-grid","forks_url":"https://api.github.com/repos/vaadin/px-data-grid/forks","keys_url":"https://api.github.com/repos/vaadin/px-data-grid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/px-data-grid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/px-data-grid/teams","hooks_url":"https://api.github.com/repos/vaadin/px-data-grid/hooks","issue_events_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/px-data-grid/events","assignees_url":"https://api.github.com/repos/vaadin/px-data-grid/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/px-data-grid/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/px-data-grid/tags","blobs_url":"https://api.github.com/repos/vaadin/px-data-grid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/px-data-grid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/px-data-grid/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/px-data-grid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/px-data-grid/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/px-data-grid/languages","stargazers_url":"https://api.github.com/repos/vaadin/px-data-grid/stargazers","contributors_url":"https://api.github.com/repos/vaadin/px-data-grid/contributors","subscribers_url":"https://api.github.com/repos/vaadin/px-data-grid/subscribers","subscription_url":"https://api.github.com/repos/vaadin/px-data-grid/subscription","commits_url":"https://api.github.com/repos/vaadin/px-data-grid/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/px-data-grid/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/px-data-grid/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/px-data-grid/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/px-data-grid/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/px-data-grid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/px-data-grid/merges","archive_url":"https://api.github.com/repos/vaadin/px-data-grid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/px-data-grid/downloads","issues_url":"https://api.github.com/repos/vaadin/px-data-grid/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/px-data-grid/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/px-data-grid/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/px-data-grid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/px-data-grid/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/px-data-grid/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/px-data-grid/deployments","created_at":"2017-11-08T11:50:20Z","updated_at":"2018-02-10T08:46:44Z","pushed_at":"2018-03-01T21:01:10Z","git_url":"git://github.com/vaadin/px-data-grid.git","ssh_url":"git@github.com:vaadin/px-data-grid.git","clone_url":"https://github.com/vaadin/px-data-grid.git","svn_url":"https://github.com/vaadin/px-data-grid","homepage":"","size":2186,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":4,"open_issues":58,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/723"},"html":{"href":"https://github.com/vaadin/px-data-grid/pull/723"},"issue":{"href":"https://api.github.com/repos/vaadin/px-data-grid/issues/723"},"comments":{"href":"https://api.github.com/repos/vaadin/px-data-grid/issues/723/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/723/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/px-data-grid/pulls/723/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/px-data-grid/statuses/d8a92b202f792d7a0c22a12b61a4e5d808e57fde"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"randyaskin"}}