{"action":"created","issue":{"url":"https://api.github.com/repos/librenms/librenms/issues/8293","repository_url":"https://api.github.com/repos/librenms/librenms","labels_url":"https://api.github.com/repos/librenms/librenms/issues/8293/labels{/name}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/8293/comments","events_url":"https://api.github.com/repos/librenms/librenms/issues/8293/events","html_url":"https://github.com/librenms/librenms/pull/8293","id":299979737,"number":8293,"title":"feature: Added new alert rule builder UI","user":{"login":"laf","id":3941142,"avatar_url":"https://avatars0.githubusercontent.com/u/3941142?v=4","gravatar_id":"","url":"https://api.github.com/users/laf","html_url":"https://github.com/laf","followers_url":"https://api.github.com/users/laf/followers","following_url":"https://api.github.com/users/laf/following{/other_user}","gists_url":"https://api.github.com/users/laf/gists{/gist_id}","starred_url":"https://api.github.com/users/laf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laf/subscriptions","organizations_url":"https://api.github.com/users/laf/orgs","repos_url":"https://api.github.com/users/laf/repos","events_url":"https://api.github.com/users/laf/events{/privacy}","received_events_url":"https://api.github.com/users/laf/received_events","type":"User","site_admin":false},"labels":[{"id":210071360,"url":"https://api.github.com/repos/librenms/librenms/labels/Alerting%20:bell:","name":"Alerting :bell:","color":"ff99ff","default":false},{"id":301956724,"url":"https://api.github.com/repos/librenms/librenms/labels/Blocker%20:no_entry_sign:","name":"Blocker :no_entry_sign:","color":"000000","default":false},{"id":294557201,"url":"https://api.github.com/repos/librenms/librenms/labels/Schema","name":"Schema","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-02-24T22:51:28Z","updated_at":"2018-03-03T06:23:36Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/8293","html_url":"https://github.com/librenms/librenms/pull/8293","diff_url":"https://github.com/librenms/librenms/pull/8293.diff","patch_url":"https://github.com/librenms/librenms/pull/8293.patch"},"body":"DO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\n\r\nThis isn't ready for merging yet.\r\n\r\nIt provides an update to the ui for creating alert rules. It's had limited testing so far so be warned.\r\n\r\nSome things to note:\r\n\r\n  - [x] ~~A console error will show when editing a new rule. This is expected.~~\r\n  - [x] ~~Rules created the old way should continue to work. If you edit an old rule, it will be updated.~~\r\n  - [x] ~~You can still create a new rule using the old system.~~\r\n  - [x] ~~Interval no longer seems to be honoured so I need to look in to that.~~\r\n\r\nTo do:\r\n\r\n- [x] ~~Automatically import old rules when they are edited.~~ Manually allow the importing of old rules.\r\n- [x] Allow users to paste in an SQL query that will be parsed.\r\n- [x] Fix sql gen when adding default rules\r\n- [x] Collection fully converted to query_builder format\r\n- [x] Allow add from collection to use query_builder format\r\n- [x] (<,>,<=,>=) missing for integer type\r\n- [x] List showing SQL instead of rule/query_builder\r\n- [x] Convert to new format ~~button in old edit dialog or simply~~ - auto convert on edit\r\n- [ ] The webui layout / button will change. This is purely for testing so far.\r\n- [ ] Query Builder select too wide (layout issue not select box)\r\n- [ ] Remove old modal for adding / editing rules.\r\n\r\nPlease expect something to break so don't attempt to test this unless you are prepared.\r\n\r\n![image](https://user-images.githubusercontent.com/3941142/36690558-8fb51f44-1b2a-11e8-9676-620babe3e509.png)\r\n"},"comment":{"url":"https://api.github.com/repos/librenms/librenms/issues/comments/370123400","html_url":"https://github.com/librenms/librenms/pull/8293#issuecomment-370123400","issue_url":"https://api.github.com/repos/librenms/librenms/issues/8293","id":370123400,"user":{"login":"scrutinizer-notifier","id":6398257,"avatar_url":"https://avatars3.githubusercontent.com/u/6398257?v=4","gravatar_id":"","url":"https://api.github.com/users/scrutinizer-notifier","html_url":"https://github.com/scrutinizer-notifier","followers_url":"https://api.github.com/users/scrutinizer-notifier/followers","following_url":"https://api.github.com/users/scrutinizer-notifier/following{/other_user}","gists_url":"https://api.github.com/users/scrutinizer-notifier/gists{/gist_id}","starred_url":"https://api.github.com/users/scrutinizer-notifier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrutinizer-notifier/subscriptions","organizations_url":"https://api.github.com/users/scrutinizer-notifier/orgs","repos_url":"https://api.github.com/users/scrutinizer-notifier/repos","events_url":"https://api.github.com/users/scrutinizer-notifier/events{/privacy}","received_events_url":"https://api.github.com/users/scrutinizer-notifier/received_events","type":"User","site_admin":false},"created_at":"2018-03-03T06:23:36Z","updated_at":"2018-03-03T06:23:36Z","author_association":"NONE","body":"A [new inspection](https://scrutinizer-ci.com/g/librenms/librenms/inspections/3410ea83-49e2-4a7d-a917-932cb5e5c6ba) was created."}}
{"actor":{"display_login":"scrutinizer-notifier"}}