{"action":"created","comment":{"url":"https://api.github.com/repos/qorelanguage/module-jni/pulls/comments/236131123","pull_request_review_id":178142824,"id":236131123,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjEzMTEyMw==","diff_hunk":"@@ -47,104 +47,103 @@ template<typename T>\n class LocalReference {\n \n public:\n-   /**\n-    * \\brief Creates an instance.\n-    * \\param ref the local reference\n-    */\n-   DLLLOCAL LocalReference(T ref = nullptr) : ref(ref) {\n-      assert(ref == nullptr || Jvm::getEnv()->GetObjectRefType(ref) == JNILocalRefType);\n-      if (ref != nullptr) {\n-         printd(LogLevel + 1, \"LocalReference created: %p\\n\", ref);\n-      }\n-   }\n-\n-   /**\n-    * \\brief Destroys the local reference represented by this instance.\n-    */\n-   DLLLOCAL ~LocalReference() {\n-      del();\n-   }\n-\n-   /**\n-    * \\brief Move constructor.\n-    * \\param src the source local reference wrapper\n-    */\n-   DLLLOCAL LocalReference(LocalReference &&src) : ref(src.ref) {\n-      src.ref = nullptr;\n-   }\n-\n-   /**\n-    * \\brief Move assignment.\n-    * \\param src the source local reference wrapper\n-    * \\return *this\n-    */\n-   DLLLOCAL LocalReference &operator=(LocalReference &&src) {\n-      del();\n-      ref = src.ref;\n-      src.ref = nullptr;\n-      return *this;\n-   }\n-\n-   /**\n-    * \\brief Implicit conversion to the reference type.\n-    */\n-   DLLLOCAL operator T() const {\n-      return ref;\n-   }\n-\n-   /**\n-    * \\brief Creates a corresponding GlobalReference.\n-    * \\return a global reference representing the same object\n-    * \\throws JavaException if the global reference cannot be created\n-    */\n-   DLLLOCAL GlobalReference<T> makeGlobal() const {\n-      assert(ref != nullptr);\n-      T global = static_cast<T>(Jvm::getEnv()->NewGlobalRef(ref));\n-      if (global == nullptr) {\n-         throw JavaException();\n-      }\n-      return global;\n-   }\n-\n-   /**\n-    * \\brief Converts the reference to another type.\n-    *\n-    * This object becomes empty - the reference it contains is moved to the new object.\n-    * \\tparam T2 the type of the resulting reference\n-    * \\return a local reference of type T2\n-    */\n-   template<typename T2>\n-   DLLLOCAL LocalReference<T2> as() {\n-      T2 r = static_cast<T2>(ref);\n-      ref = nullptr;\n-      return r;\n-   }\n-\n-   template<typename T2>\n-   DLLLOCAL T2 cast() {\n-      return static_cast<T2>(ref);\n-   }\n-\n-   DLLLOCAL T release() {\n-      T r = ref;\n-      ref = nullptr;\n-      return r;\n-   }\n+    /**\n+     * \\brief Creates an instance.\n+     * \\param ref the local reference\n+     */\n+    DLLLOCAL LocalReference(T ref = nullptr) : ref(ref) {\n+        assert(ref == nullptr || Jvm::getEnv()->GetObjectRefType(ref) == JNILocalRefType);\n+        if (ref != nullptr) {\n+            printd(LogLevel + 1, \"LocalReference created: %p\\n\", ref);\n+        }\n+    }\n+\n+    /**\n+     * \\brief Destroys the local reference represented by this instance.\n+     */\n+    DLLLOCAL ~LocalReference() {\n+        del();\n+    }\n+\n+    /**\n+     * \\brief Move constructor.\n+     * \\param src the source local reference wrapper\n+     */\n+    DLLLOCAL LocalReference(LocalReference &&src) : ref(src.ref) {\n+        src.ref = nullptr;\n+    }\n+\n+    /**\n+     * \\brief Move assignment.\n+     * \\param src the source local reference wrapper\n+     * \\return *this\n+     */\n+    DLLLOCAL LocalReference &operator=(LocalReference &&src) {\n+        del();\n+        ref = src.ref;\n+        src.ref = nullptr;","path":"src/LocalReference.h","position":null,"original_position":121,"commit_id":"23395397490eb7f908950b1f0f631e5b59c395e7","original_commit_id":"d188e0b99a3a31319ba08ed7aaa2f722c626cafc","user":{"login":"davidnich","id":13432105,"node_id":"MDQ6VXNlcjEzNDMyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/13432105?v=4","gravatar_id":"","url":"https://api.github.com/users/davidnich","html_url":"https://github.com/davidnich","followers_url":"https://api.github.com/users/davidnich/followers","following_url":"https://api.github.com/users/davidnich/following{/other_user}","gists_url":"https://api.github.com/users/davidnich/gists{/gist_id}","starred_url":"https://api.github.com/users/davidnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidnich/subscriptions","organizations_url":"https://api.github.com/users/davidnich/orgs","repos_url":"https://api.github.com/users/davidnich/repos","events_url":"https://api.github.com/users/davidnich/events{/privacy}","received_events_url":"https://api.github.com/users/davidnich/received_events","type":"User","site_admin":false},"body":"fixed","created_at":"2018-11-26T06:07:31Z","updated_at":"2018-11-26T06:07:31Z","html_url":"https://github.com/qorelanguage/module-jni/pull/39#discussion_r236131123","pull_request_url":"https://api.github.com/repos/qorelanguage/module-jni/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qorelanguage/module-jni/pulls/comments/236131123"},"html":{"href":"https://github.com/qorelanguage/module-jni/pull/39#discussion_r236131123"},"pull_request":{"href":"https://api.github.com/repos/qorelanguage/module-jni/pulls/39"}},"in_reply_to_id":235745719},"pull_request":{"url":"https://api.github.com/repos/qorelanguage/module-jni/pulls/39","id":232956870,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTU2ODcw","html_url":"https://github.com/qorelanguage/module-jni/pull/39","diff_url":"https://github.com/qorelanguage/module-jni/pull/39.diff","patch_url":"https://github.com/qorelanguage/module-jni/pull/39.patch","issue_url":"https://api.github.com/repos/qorelanguage/module-jni/issues/39","number":39,"state":"open","locked":false,"title":"Feature/3026 jni date","user":{"login":"davidnich","id":13432105,"node_id":"MDQ6VXNlcjEzNDMyMTA1","avatar_url":"https://avatars0.githubusercontent.com/u/13432105?v=4","gravatar_id":"","url":"https://api.github.com/users/davidnich","html_url":"https://github.com/davidnich","followers_url":"https://api.github.com/users/davidnich/followers","following_url":"https://api.github.com/users/davidnich/following{/other_user}","gists_url":"https://api.github.com/users/davidnich/gists{/gist_id}","starred_url":"https://api.github.com/users/davidnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidnich/subscriptions","organizations_url":"https://api.github.com/users/davidnich/orgs","repos_url":"https://api.github.com/users/davidnich/repos","events_url":"https://api.github.com/users/davidnich/events{/privacy}","received_events_url":"https://api.github.com/users/davidnich/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-22T12:06:24Z","updated_at":"2018-11-26T06:07:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ade10d02a16aec58020c50afa7c31255b44dea7a","assignee":{"login":"sejvlond","id":5747824,"node_id":"MDQ6VXNlcjU3NDc4MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5747824?v=4","gravatar_id":"","url":"https://api.github.com/users/sejvlond","html_url":"https://github.com/sejvlond","followers_url":"https://api.github.com/users/sejvlond/followers","following_url":"https://api.github.com/users/sejvlond/following{/other_user}","gists_url":"https://api.github.com/users/sejvlond/gists{/gist_id}","starred_url":"https://api.github.com/users/sejvlond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sejvlond/subscriptions","organizations_url":"https://api.github.com/users/sejvlond/orgs","repos_url":"https://api.github.com/users/sejvlond/repos","events_url":"https://api.github.com/users/sejvlond/events{/privacy}","received_events_url":"https://api.github.com/users/sejvlond/received_events","type":"User","site_admin":false},"assignees":[{"login":"sejvlond","id":5747824,"node_id":"MDQ6VXNlcjU3NDc4MjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5747824?v=4","gravatar_id":"","url":"https://api.github.com/users/sejvlond","html_url":"https://github.com/sejvlond","followers_url":"https://api.github.com/users/sejvlond/followers","following_url":"https://api.github.com/users/sejvlond/following{/other_user}","gists_url":"https://api.github.com/users/sejvlond/gists{/gist_id}","starred_url":"https://api.github.com/users/sejvlond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sejvlond/subscriptions","organizations_url":"https://api.github.com/users/sejvlond/orgs","repos_url":"https://api.github.com/users/sejvlond/repos","events_url":"https://api.github.com/users/sejvlond/events{/privacy}","received_events_url":"https://api.github.com/users/sejvlond/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qorelanguage/module-jni/pulls/39/commits","review_comments_url":"https://api.github.com/repos/qorelanguage/module-jni/pulls/39/comments","review_comment_url":"https://api.github.com/repos/qorelanguage/module-jni/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qorelanguage/module-jni/issues/39/comments","statuses_url":"https://api.github.com/repos/qorelanguage/module-jni/statuses/23395397490eb7f908950b1f0f631e5b59c395e7","head":{"label":"qorelanguage:feature/3026_jni_date","ref":"feature/3026_jni_date","sha":"23395397490eb7f908950b1f0f631e5b59c395e7","user":{"login":"qorelanguage","id":13414799,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDE0Nzk5","avatar_url":"https://avatars2.githubusercontent.com/u/13414799?v=4","gravatar_id":"","url":"https://api.github.com/users/qorelanguage","html_url":"https://github.com/qorelanguage","followers_url":"https://api.github.com/users/qorelanguage/followers","following_url":"https://api.github.com/users/qorelanguage/following{/other_user}","gists_url":"https://api.github.com/users/qorelanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/qorelanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qorelanguage/subscriptions","organizations_url":"https://api.github.com/users/qorelanguage/orgs","repos_url":"https://api.github.com/users/qorelanguage/repos","events_url":"https://api.github.com/users/qorelanguage/events{/privacy}","received_events_url":"https://api.github.com/users/qorelanguage/received_events","type":"Organization","site_admin":false},"repo":{"id":66921098,"node_id":"MDEwOlJlcG9zaXRvcnk2NjkyMTA5OA==","name":"module-jni","full_name":"qorelanguage/module-jni","private":false,"owner":{"login":"qorelanguage","id":13414799,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDE0Nzk5","avatar_url":"https://avatars2.githubusercontent.com/u/13414799?v=4","gravatar_id":"","url":"https://api.github.com/users/qorelanguage","html_url":"https://github.com/qorelanguage","followers_url":"https://api.github.com/users/qorelanguage/followers","following_url":"https://api.github.com/users/qorelanguage/following{/other_user}","gists_url":"https://api.github.com/users/qorelanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/qorelanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qorelanguage/subscriptions","organizations_url":"https://api.github.com/users/qorelanguage/orgs","repos_url":"https://api.github.com/users/qorelanguage/repos","events_url":"https://api.github.com/users/qorelanguage/events{/privacy}","received_events_url":"https://api.github.com/users/qorelanguage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qorelanguage/module-jni","description":null,"fork":false,"url":"https://api.github.com/repos/qorelanguage/module-jni","forks_url":"https://api.github.com/repos/qorelanguage/module-jni/forks","keys_url":"https://api.github.com/repos/qorelanguage/module-jni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qorelanguage/module-jni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qorelanguage/module-jni/teams","hooks_url":"https://api.github.com/repos/qorelanguage/module-jni/hooks","issue_events_url":"https://api.github.com/repos/qorelanguage/module-jni/issues/events{/number}","events_url":"https://api.github.com/repos/qorelanguage/module-jni/events","assignees_url":"https://api.github.com/repos/qorelanguage/module-jni/assignees{/user}","branches_url":"https://api.github.com/repos/qorelanguage/module-jni/branches{/branch}","tags_url":"https://api.github.com/repos/qorelanguage/module-jni/tags","blobs_url":"https://api.github.com/repos/qorelanguage/module-jni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qorelanguage/module-jni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qorelanguage/module-jni/git/refs{/sha}","trees_url":"https://api.github.com/repos/qorelanguage/module-jni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qorelanguage/module-jni/statuses/{sha}","languages_url":"https://api.github.com/repos/qorelanguage/module-jni/languages","stargazers_url":"https://api.github.com/repos/qorelanguage/module-jni/stargazers","contributors_url":"https://api.github.com/repos/qorelanguage/module-jni/contributors","subscribers_url":"https://api.github.com/repos/qorelanguage/module-jni/subscribers","subscription_url":"https://api.github.com/repos/qorelanguage/module-jni/subscription","commits_url":"https://api.github.com/repos/qorelanguage/module-jni/commits{/sha}","git_commits_url":"https://api.github.com/repos/qorelanguage/module-jni/git/commits{/sha}","comments_url":"https://api.github.com/repos/qorelanguage/module-jni/comments{/number}","issue_comment_url":"https://api.github.com/repos/qorelanguage/module-jni/issues/comments{/number}","contents_url":"https://api.github.com/repos/qorelanguage/module-jni/contents/{+path}","compare_url":"https://api.github.com/repos/qorelanguage/module-jni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qorelanguage/module-jni/merges","archive_url":"https://api.github.com/repos/qorelanguage/module-jni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qorelanguage/module-jni/downloads","issues_url":"https://api.github.com/repos/qorelanguage/module-jni/issues{/number}","pulls_url":"https://api.github.com/repos/qorelanguage/module-jni/pulls{/number}","milestones_url":"https://api.github.com/repos/qorelanguage/module-jni/milestones{/number}","notifications_url":"https://api.github.com/repos/qorelanguage/module-jni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qorelanguage/module-jni/labels{/name}","releases_url":"https://api.github.com/repos/qorelanguage/module-jni/releases{/id}","deployments_url":"https://api.github.com/repos/qorelanguage/module-jni/deployments","created_at":"2016-08-30T08:19:43Z","updated_at":"2018-11-22T12:05:19Z","pushed_at":"2018-11-25T21:00:43Z","git_url":"git://github.com/qorelanguage/module-jni.git","ssh_url":"git@github.com:qorelanguage/module-jni.git","clone_url":"https://github.com/qorelanguage/module-jni.git","svn_url":"https://github.com/qorelanguage/module-jni","homepage":null,"size":548,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"base":{"label":"qorelanguage:develop","ref":"develop","sha":"1c77dedac65efd1c97350f2edbe1d45939fc02af","user":{"login":"qorelanguage","id":13414799,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDE0Nzk5","avatar_url":"https://avatars2.githubusercontent.com/u/13414799?v=4","gravatar_id":"","url":"https://api.github.com/users/qorelanguage","html_url":"https://github.com/qorelanguage","followers_url":"https://api.github.com/users/qorelanguage/followers","following_url":"https://api.github.com/users/qorelanguage/following{/other_user}","gists_url":"https://api.github.com/users/qorelanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/qorelanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qorelanguage/subscriptions","organizations_url":"https://api.github.com/users/qorelanguage/orgs","repos_url":"https://api.github.com/users/qorelanguage/repos","events_url":"https://api.github.com/users/qorelanguage/events{/privacy}","received_events_url":"https://api.github.com/users/qorelanguage/received_events","type":"Organization","site_admin":false},"repo":{"id":66921098,"node_id":"MDEwOlJlcG9zaXRvcnk2NjkyMTA5OA==","name":"module-jni","full_name":"qorelanguage/module-jni","private":false,"owner":{"login":"qorelanguage","id":13414799,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDE0Nzk5","avatar_url":"https://avatars2.githubusercontent.com/u/13414799?v=4","gravatar_id":"","url":"https://api.github.com/users/qorelanguage","html_url":"https://github.com/qorelanguage","followers_url":"https://api.github.com/users/qorelanguage/followers","following_url":"https://api.github.com/users/qorelanguage/following{/other_user}","gists_url":"https://api.github.com/users/qorelanguage/gists{/gist_id}","starred_url":"https://api.github.com/users/qorelanguage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qorelanguage/subscriptions","organizations_url":"https://api.github.com/users/qorelanguage/orgs","repos_url":"https://api.github.com/users/qorelanguage/repos","events_url":"https://api.github.com/users/qorelanguage/events{/privacy}","received_events_url":"https://api.github.com/users/qorelanguage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qorelanguage/module-jni","description":null,"fork":false,"url":"https://api.github.com/repos/qorelanguage/module-jni","forks_url":"https://api.github.com/repos/qorelanguage/module-jni/forks","keys_url":"https://api.github.com/repos/qorelanguage/module-jni/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qorelanguage/module-jni/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qorelanguage/module-jni/teams","hooks_url":"https://api.github.com/repos/qorelanguage/module-jni/hooks","issue_events_url":"https://api.github.com/repos/qorelanguage/module-jni/issues/events{/number}","events_url":"https://api.github.com/repos/qorelanguage/module-jni/events","assignees_url":"https://api.github.com/repos/qorelanguage/module-jni/assignees{/user}","branches_url":"https://api.github.com/repos/qorelanguage/module-jni/branches{/branch}","tags_url":"https://api.github.com/repos/qorelanguage/module-jni/tags","blobs_url":"https://api.github.com/repos/qorelanguage/module-jni/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qorelanguage/module-jni/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qorelanguage/module-jni/git/refs{/sha}","trees_url":"https://api.github.com/repos/qorelanguage/module-jni/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qorelanguage/module-jni/statuses/{sha}","languages_url":"https://api.github.com/repos/qorelanguage/module-jni/languages","stargazers_url":"https://api.github.com/repos/qorelanguage/module-jni/stargazers","contributors_url":"https://api.github.com/repos/qorelanguage/module-jni/contributors","subscribers_url":"https://api.github.com/repos/qorelanguage/module-jni/subscribers","subscription_url":"https://api.github.com/repos/qorelanguage/module-jni/subscription","commits_url":"https://api.github.com/repos/qorelanguage/module-jni/commits{/sha}","git_commits_url":"https://api.github.com/repos/qorelanguage/module-jni/git/commits{/sha}","comments_url":"https://api.github.com/repos/qorelanguage/module-jni/comments{/number}","issue_comment_url":"https://api.github.com/repos/qorelanguage/module-jni/issues/comments{/number}","contents_url":"https://api.github.com/repos/qorelanguage/module-jni/contents/{+path}","compare_url":"https://api.github.com/repos/qorelanguage/module-jni/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qorelanguage/module-jni/merges","archive_url":"https://api.github.com/repos/qorelanguage/module-jni/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qorelanguage/module-jni/downloads","issues_url":"https://api.github.com/repos/qorelanguage/module-jni/issues{/number}","pulls_url":"https://api.github.com/repos/qorelanguage/module-jni/pulls{/number}","milestones_url":"https://api.github.com/repos/qorelanguage/module-jni/milestones{/number}","notifications_url":"https://api.github.com/repos/qorelanguage/module-jni/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qorelanguage/module-jni/labels{/name}","releases_url":"https://api.github.com/repos/qorelanguage/module-jni/releases{/id}","deployments_url":"https://api.github.com/repos/qorelanguage/module-jni/deployments","created_at":"2016-08-30T08:19:43Z","updated_at":"2018-11-22T12:05:19Z","pushed_at":"2018-11-25T21:00:43Z","git_url":"git://github.com/qorelanguage/module-jni.git","ssh_url":"git@github.com:qorelanguage/module-jni.git","clone_url":"https://github.com/qorelanguage/module-jni.git","svn_url":"https://github.com/qorelanguage/module-jni","homepage":null,"size":548,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/qorelanguage/module-jni/pulls/39"},"html":{"href":"https://github.com/qorelanguage/module-jni/pull/39"},"issue":{"href":"https://api.github.com/repos/qorelanguage/module-jni/issues/39"},"comments":{"href":"https://api.github.com/repos/qorelanguage/module-jni/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/qorelanguage/module-jni/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/qorelanguage/module-jni/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qorelanguage/module-jni/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/qorelanguage/module-jni/statuses/23395397490eb7f908950b1f0f631e5b59c395e7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidnich"}}