{"action":"created","comment":{"url":"https://api.github.com/repos/FabricMC/fabric/pulls/comments/245491324","pull_request_review_id":189611440,"id":245491324,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ5MTMyNA==","diff_hunk":"@@ -0,0 +1,14 @@\n+package net.fabricmc.fabric.mixin.client.model;\n+\n+import net.minecraft.util.math.Direction;\n+\n+class MixinBakedModelHelper {\n+    /**\n+     * This is here for use by {@link MixinBakedModel} which cannot define\n+     * static fields without Mixin complaining.  The implementation there","path":"src/main/java/net/fabricmc/fabric/mixin/client/model/MixinBakedModelHelper.java","position":8,"original_position":8,"commit_id":"79ffc15cbe505ec3a829e879699ecea0daecd6a3","original_commit_id":"7217a92b574ee34e02b564f1b7e4edb12f97c7e4","user":{"login":"asiekierka","id":113514,"node_id":"MDQ6VXNlcjExMzUxNA==","avatar_url":"https://avatars3.githubusercontent.com/u/113514?v=4","gravatar_id":"","url":"https://api.github.com/users/asiekierka","html_url":"https://github.com/asiekierka","followers_url":"https://api.github.com/users/asiekierka/followers","following_url":"https://api.github.com/users/asiekierka/following{/other_user}","gists_url":"https://api.github.com/users/asiekierka/gists{/gist_id}","starred_url":"https://api.github.com/users/asiekierka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asiekierka/subscriptions","organizations_url":"https://api.github.com/users/asiekierka/orgs","repos_url":"https://api.github.com/users/asiekierka/repos","events_url":"https://api.github.com/users/asiekierka/events{/privacy}","received_events_url":"https://api.github.com/users/asiekierka/received_events","type":"User","site_admin":false},"body":"I wish! That was TOTALLY NOT what I tried to imply. Nope. We have to support J8.","created_at":"2019-01-05T23:11:23Z","updated_at":"2019-01-05T23:11:23Z","html_url":"https://github.com/FabricMC/fabric/pull/55#discussion_r245491324","pull_request_url":"https://api.github.com/repos/FabricMC/fabric/pulls/55","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/FabricMC/fabric/pulls/comments/245491324"},"html":{"href":"https://github.com/FabricMC/fabric/pull/55#discussion_r245491324"},"pull_request":{"href":"https://api.github.com/repos/FabricMC/fabric/pulls/55"}},"in_reply_to_id":245484041},"pull_request":{"url":"https://api.github.com/repos/FabricMC/fabric/pulls/55","id":241660245,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjYwMjQ1","html_url":"https://github.com/FabricMC/fabric/pull/55","diff_url":"https://github.com/FabricMC/fabric/pull/55.diff","patch_url":"https://github.com/FabricMC/fabric/pull/55.patch","issue_url":"https://api.github.com/repos/FabricMC/fabric/issues/55","number":55,"state":"open","locked":false,"title":"Alternative Enhanced Model Approach","user":{"login":"grondag","id":6106235,"node_id":"MDQ6VXNlcjYxMDYyMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6106235?v=4","gravatar_id":"","url":"https://api.github.com/users/grondag","html_url":"https://github.com/grondag","followers_url":"https://api.github.com/users/grondag/followers","following_url":"https://api.github.com/users/grondag/following{/other_user}","gists_url":"https://api.github.com/users/grondag/gists{/gist_id}","starred_url":"https://api.github.com/users/grondag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grondag/subscriptions","organizations_url":"https://api.github.com/users/grondag/orgs","repos_url":"https://api.github.com/users/grondag/repos","events_url":"https://api.github.com/users/grondag/events{/privacy}","received_events_url":"https://api.github.com/users/grondag/received_events","type":"User","site_admin":false},"body":"This PR  defines standards for implementing a RenderPlugin and standard vertex formats and interfaces to be used by enhanced and/or dynamic models to provide vertex data to such plugins.  The intention is to allow cross-compatibility across the widest possible range of rendering needs and implementation approaches with minimum viable patches and logic in the Fabric API itself.  \r\n\r\nIt includes a reliable and performant hook for an enhanced and/or dynamic model to retrieve extended world state in response to chunk rebuilds. \r\n\r\nIt establishes minimal interfaces and functional expectations for a rendering plug in and creates a lightweight registration system for such a plug into make itself accessible. (WIP). \r\n\r\nIt does not make any changes to vertex lighting or buffering. All such hooks are delegated to plug in implementations.","created_at":"2019-01-02T01:21:25Z","updated_at":"2019-01-05T23:11:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4f965f06101d9782d7bac924ad1351a8370eb8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FabricMC/fabric/pulls/55/commits","review_comments_url":"https://api.github.com/repos/FabricMC/fabric/pulls/55/comments","review_comment_url":"https://api.github.com/repos/FabricMC/fabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FabricMC/fabric/issues/55/comments","statuses_url":"https://api.github.com/repos/FabricMC/fabric/statuses/79ffc15cbe505ec3a829e879699ecea0daecd6a3","head":{"label":"grondag:master","ref":"master","sha":"79ffc15cbe505ec3a829e879699ecea0daecd6a3","user":{"login":"grondag","id":6106235,"node_id":"MDQ6VXNlcjYxMDYyMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6106235?v=4","gravatar_id":"","url":"https://api.github.com/users/grondag","html_url":"https://github.com/grondag","followers_url":"https://api.github.com/users/grondag/followers","following_url":"https://api.github.com/users/grondag/following{/other_user}","gists_url":"https://api.github.com/users/grondag/gists{/gist_id}","starred_url":"https://api.github.com/users/grondag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grondag/subscriptions","organizations_url":"https://api.github.com/users/grondag/orgs","repos_url":"https://api.github.com/users/grondag/repos","events_url":"https://api.github.com/users/grondag/events{/privacy}","received_events_url":"https://api.github.com/users/grondag/received_events","type":"User","site_admin":false},"repo":{"id":163760023,"node_id":"MDEwOlJlcG9zaXRvcnkxNjM3NjAwMjM=","name":"fabric","full_name":"grondag/fabric","private":false,"owner":{"login":"grondag","id":6106235,"node_id":"MDQ6VXNlcjYxMDYyMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/6106235?v=4","gravatar_id":"","url":"https://api.github.com/users/grondag","html_url":"https://github.com/grondag","followers_url":"https://api.github.com/users/grondag/followers","following_url":"https://api.github.com/users/grondag/following{/other_user}","gists_url":"https://api.github.com/users/grondag/gists{/gist_id}","starred_url":"https://api.github.com/users/grondag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grondag/subscriptions","organizations_url":"https://api.github.com/users/grondag/orgs","repos_url":"https://api.github.com/users/grondag/repos","events_url":"https://api.github.com/users/grondag/events{/privacy}","received_events_url":"https://api.github.com/users/grondag/received_events","type":"User","site_admin":false},"html_url":"https://github.com/grondag/fabric","description":"Essential hooks and patches for modding with Fabric.","fork":true,"url":"https://api.github.com/repos/grondag/fabric","forks_url":"https://api.github.com/repos/grondag/fabric/forks","keys_url":"https://api.github.com/repos/grondag/fabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grondag/fabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grondag/fabric/teams","hooks_url":"https://api.github.com/repos/grondag/fabric/hooks","issue_events_url":"https://api.github.com/repos/grondag/fabric/issues/events{/number}","events_url":"https://api.github.com/repos/grondag/fabric/events","assignees_url":"https://api.github.com/repos/grondag/fabric/assignees{/user}","branches_url":"https://api.github.com/repos/grondag/fabric/branches{/branch}","tags_url":"https://api.github.com/repos/grondag/fabric/tags","blobs_url":"https://api.github.com/repos/grondag/fabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grondag/fabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grondag/fabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/grondag/fabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grondag/fabric/statuses/{sha}","languages_url":"https://api.github.com/repos/grondag/fabric/languages","stargazers_url":"https://api.github.com/repos/grondag/fabric/stargazers","contributors_url":"https://api.github.com/repos/grondag/fabric/contributors","subscribers_url":"https://api.github.com/repos/grondag/fabric/subscribers","subscription_url":"https://api.github.com/repos/grondag/fabric/subscription","commits_url":"https://api.github.com/repos/grondag/fabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/grondag/fabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/grondag/fabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/grondag/fabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/grondag/fabric/contents/{+path}","compare_url":"https://api.github.com/repos/grondag/fabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grondag/fabric/merges","archive_url":"https://api.github.com/repos/grondag/fabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grondag/fabric/downloads","issues_url":"https://api.github.com/repos/grondag/fabric/issues{/number}","pulls_url":"https://api.github.com/repos/grondag/fabric/pulls{/number}","milestones_url":"https://api.github.com/repos/grondag/fabric/milestones{/number}","notifications_url":"https://api.github.com/repos/grondag/fabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grondag/fabric/labels{/name}","releases_url":"https://api.github.com/repos/grondag/fabric/releases{/id}","deployments_url":"https://api.github.com/repos/grondag/fabric/deployments","created_at":"2019-01-01T19:08:53Z","updated_at":"2019-01-05T19:22:27Z","pushed_at":"2019-01-05T19:22:25Z","git_url":"git://github.com/grondag/fabric.git","ssh_url":"git@github.com:grondag/fabric.git","clone_url":"https://github.com/grondag/fabric.git","svn_url":"https://github.com/grondag/fabric","homepage":null,"size":359,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FabricMC:master","ref":"master","sha":"1345c08cb84b481ee04ac385637e8bb8a251a3c5","user":{"login":"FabricMC","id":21025855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDI1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/21025855?v=4","gravatar_id":"","url":"https://api.github.com/users/FabricMC","html_url":"https://github.com/FabricMC","followers_url":"https://api.github.com/users/FabricMC/followers","following_url":"https://api.github.com/users/FabricMC/following{/other_user}","gists_url":"https://api.github.com/users/FabricMC/gists{/gist_id}","starred_url":"https://api.github.com/users/FabricMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabricMC/subscriptions","organizations_url":"https://api.github.com/users/FabricMC/orgs","repos_url":"https://api.github.com/users/FabricMC/repos","events_url":"https://api.github.com/users/FabricMC/events{/privacy}","received_events_url":"https://api.github.com/users/FabricMC/received_events","type":"Organization","site_admin":false},"repo":{"id":156061229,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYwNjEyMjk=","name":"fabric","full_name":"FabricMC/fabric","private":false,"owner":{"login":"FabricMC","id":21025855,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDI1ODU1","avatar_url":"https://avatars1.githubusercontent.com/u/21025855?v=4","gravatar_id":"","url":"https://api.github.com/users/FabricMC","html_url":"https://github.com/FabricMC","followers_url":"https://api.github.com/users/FabricMC/followers","following_url":"https://api.github.com/users/FabricMC/following{/other_user}","gists_url":"https://api.github.com/users/FabricMC/gists{/gist_id}","starred_url":"https://api.github.com/users/FabricMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FabricMC/subscriptions","organizations_url":"https://api.github.com/users/FabricMC/orgs","repos_url":"https://api.github.com/users/FabricMC/repos","events_url":"https://api.github.com/users/FabricMC/events{/privacy}","received_events_url":"https://api.github.com/users/FabricMC/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FabricMC/fabric","description":"Essential hooks and patches for modding with Fabric.","fork":false,"url":"https://api.github.com/repos/FabricMC/fabric","forks_url":"https://api.github.com/repos/FabricMC/fabric/forks","keys_url":"https://api.github.com/repos/FabricMC/fabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FabricMC/fabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FabricMC/fabric/teams","hooks_url":"https://api.github.com/repos/FabricMC/fabric/hooks","issue_events_url":"https://api.github.com/repos/FabricMC/fabric/issues/events{/number}","events_url":"https://api.github.com/repos/FabricMC/fabric/events","assignees_url":"https://api.github.com/repos/FabricMC/fabric/assignees{/user}","branches_url":"https://api.github.com/repos/FabricMC/fabric/branches{/branch}","tags_url":"https://api.github.com/repos/FabricMC/fabric/tags","blobs_url":"https://api.github.com/repos/FabricMC/fabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FabricMC/fabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FabricMC/fabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/FabricMC/fabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FabricMC/fabric/statuses/{sha}","languages_url":"https://api.github.com/repos/FabricMC/fabric/languages","stargazers_url":"https://api.github.com/repos/FabricMC/fabric/stargazers","contributors_url":"https://api.github.com/repos/FabricMC/fabric/contributors","subscribers_url":"https://api.github.com/repos/FabricMC/fabric/subscribers","subscription_url":"https://api.github.com/repos/FabricMC/fabric/subscription","commits_url":"https://api.github.com/repos/FabricMC/fabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/FabricMC/fabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/FabricMC/fabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/FabricMC/fabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/FabricMC/fabric/contents/{+path}","compare_url":"https://api.github.com/repos/FabricMC/fabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FabricMC/fabric/merges","archive_url":"https://api.github.com/repos/FabricMC/fabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FabricMC/fabric/downloads","issues_url":"https://api.github.com/repos/FabricMC/fabric/issues{/number}","pulls_url":"https://api.github.com/repos/FabricMC/fabric/pulls{/number}","milestones_url":"https://api.github.com/repos/FabricMC/fabric/milestones{/number}","notifications_url":"https://api.github.com/repos/FabricMC/fabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FabricMC/fabric/labels{/name}","releases_url":"https://api.github.com/repos/FabricMC/fabric/releases{/id}","deployments_url":"https://api.github.com/repos/FabricMC/fabric/deployments","created_at":"2018-11-04T09:02:05Z","updated_at":"2019-01-02T22:29:57Z","pushed_at":"2019-01-05T19:22:26Z","git_url":"git://github.com/FabricMC/fabric.git","ssh_url":"git@github.com:FabricMC/fabric.git","clone_url":"https://github.com/FabricMC/fabric.git","svn_url":"https://github.com/FabricMC/fabric","homepage":null,"size":260,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":16,"open_issues":32,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FabricMC/fabric/pulls/55"},"html":{"href":"https://github.com/FabricMC/fabric/pull/55"},"issue":{"href":"https://api.github.com/repos/FabricMC/fabric/issues/55"},"comments":{"href":"https://api.github.com/repos/FabricMC/fabric/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/FabricMC/fabric/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/FabricMC/fabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FabricMC/fabric/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/FabricMC/fabric/statuses/79ffc15cbe505ec3a829e879699ecea0daecd6a3"}},"author_association":"NONE"}}
{"actor":{"display_login":"asiekierka"}}