{"action":"created","comment":{"url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments/224045891","pull_request_review_id":163317368,"id":224045891,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDA0NTg5MQ==","diff_hunk":"@@ -513,7 +512,7 @@ public Task<string> GetContentAsync()\n         /// <returns>Task.</returns>\n         /// <seealso cref=\"Page.SetContentAsync(string)\"/>\n         public Task SetContentAsync(string html)\n-            => EvaluateFunctionAsync(@\"html => {\n+            => EvaluateFunctionAsync<object>(@\"html => {","path":"lib/PuppeteerSharp/Frame.cs","position":97,"original_position":97,"commit_id":"df7a3384039ae3037bf8c97aabbee28225afa513","original_commit_id":"df7a3384039ae3037bf8c97aabbee28225afa513","user":{"login":"tommymonk","id":574131,"node_id":"MDQ6VXNlcjU3NDEzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/574131?v=4","gravatar_id":"","url":"https://api.github.com/users/tommymonk","html_url":"https://github.com/tommymonk","followers_url":"https://api.github.com/users/tommymonk/followers","following_url":"https://api.github.com/users/tommymonk/following{/other_user}","gists_url":"https://api.github.com/users/tommymonk/gists{/gist_id}","starred_url":"https://api.github.com/users/tommymonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommymonk/subscriptions","organizations_url":"https://api.github.com/users/tommymonk/orgs","repos_url":"https://api.github.com/users/tommymonk/repos","events_url":"https://api.github.com/users/tommymonk/events{/privacy}","received_events_url":"https://api.github.com/users/tommymonk/received_events","type":"User","site_admin":false},"body":"Ah yes, the line number was pointing me at GetContentAsync","created_at":"2018-10-10T12:00:48Z","updated_at":"2018-10-10T12:00:48Z","html_url":"https://github.com/kblok/puppeteer-sharp/pull/652#discussion_r224045891","pull_request_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/652","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments/224045891"},"html":{"href":"https://github.com/kblok/puppeteer-sharp/pull/652#discussion_r224045891"},"pull_request":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/652"}},"in_reply_to_id":224044111},"pull_request":{"url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/652","id":218911952,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4OTExOTUy","html_url":"https://github.com/kblok/puppeteer-sharp/pull/652","diff_url":"https://github.com/kblok/puppeteer-sharp/pull/652.diff","patch_url":"https://github.com/kblok/puppeteer-sharp/pull/652.patch","issue_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/652","number":652,"state":"open","locked":false,"title":"Remove unnecessary use of dynamics","user":{"login":"tommymonk","id":574131,"node_id":"MDQ6VXNlcjU3NDEzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/574131?v=4","gravatar_id":"","url":"https://api.github.com/users/tommymonk","html_url":"https://github.com/tommymonk","followers_url":"https://api.github.com/users/tommymonk/followers","following_url":"https://api.github.com/users/tommymonk/following{/other_user}","gists_url":"https://api.github.com/users/tommymonk/gists{/gist_id}","starred_url":"https://api.github.com/users/tommymonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommymonk/subscriptions","organizations_url":"https://api.github.com/users/tommymonk/orgs","repos_url":"https://api.github.com/users/tommymonk/repos","events_url":"https://api.github.com/users/tommymonk/events{/privacy}","received_events_url":"https://api.github.com/users/tommymonk/received_events","type":"User","site_admin":false},"body":"The use of dynamic throughout the code made it difficult to safely make a change relating to #650 \r\nDynamics are terrible for hiding refactor mistakes until run-time.\r\n\r\nI've plumbed through JObject for response and JToken for method interface, this clarity allowed me to do a lot of streamlining of the response processing and in some places identify where we are serialize/de-serialize the same data many times.\r\n\r\nI didn't want to add to the string debt so I pulled out a large amount of the key strings into a Consts class to help with quality and refactor and reduce risk of future mistake.\r\n\r\nAs discussed in #650 it seemed like a sensible idea to remove the 'dynamic' or 'object overloads of methods like EvaluateFunctionAsync which are a cause of confusion, however if someone wants to use the type 'object' they will now get the correct types serialized for numerics.\r\n\r\nAll of the existing tests are passing for me, I wanted to add extra tests to cover #650 but wasn't sure which test class to use, maybe you could guide me ?","created_at":"2018-09-28T09:47:10Z","updated_at":"2018-10-10T12:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d36633bfc7062855033c138b35ec63341c1906a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/652/commits","review_comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/652/comments","review_comment_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/652/comments","statuses_url":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/df7a3384039ae3037bf8c97aabbee28225afa513","head":{"label":"tommymonk:features/remove-dynamic-overuse","ref":"features/remove-dynamic-overuse","sha":"df7a3384039ae3037bf8c97aabbee28225afa513","user":{"login":"tommymonk","id":574131,"node_id":"MDQ6VXNlcjU3NDEzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/574131?v=4","gravatar_id":"","url":"https://api.github.com/users/tommymonk","html_url":"https://github.com/tommymonk","followers_url":"https://api.github.com/users/tommymonk/followers","following_url":"https://api.github.com/users/tommymonk/following{/other_user}","gists_url":"https://api.github.com/users/tommymonk/gists{/gist_id}","starred_url":"https://api.github.com/users/tommymonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommymonk/subscriptions","organizations_url":"https://api.github.com/users/tommymonk/orgs","repos_url":"https://api.github.com/users/tommymonk/repos","events_url":"https://api.github.com/users/tommymonk/events{/privacy}","received_events_url":"https://api.github.com/users/tommymonk/received_events","type":"User","site_admin":false},"repo":{"id":150598259,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1OTgyNTk=","name":"puppeteer-sharp","full_name":"tommymonk/puppeteer-sharp","private":false,"owner":{"login":"tommymonk","id":574131,"node_id":"MDQ6VXNlcjU3NDEzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/574131?v=4","gravatar_id":"","url":"https://api.github.com/users/tommymonk","html_url":"https://github.com/tommymonk","followers_url":"https://api.github.com/users/tommymonk/followers","following_url":"https://api.github.com/users/tommymonk/following{/other_user}","gists_url":"https://api.github.com/users/tommymonk/gists{/gist_id}","starred_url":"https://api.github.com/users/tommymonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommymonk/subscriptions","organizations_url":"https://api.github.com/users/tommymonk/orgs","repos_url":"https://api.github.com/users/tommymonk/repos","events_url":"https://api.github.com/users/tommymonk/events{/privacy}","received_events_url":"https://api.github.com/users/tommymonk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tommymonk/puppeteer-sharp","description":"Headless Chrome .NET API","fork":true,"url":"https://api.github.com/repos/tommymonk/puppeteer-sharp","forks_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/forks","keys_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/teams","hooks_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/hooks","issue_events_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/issues/events{/number}","events_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/events","assignees_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/assignees{/user}","branches_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/branches{/branch}","tags_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/tags","blobs_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/languages","stargazers_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/stargazers","contributors_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/contributors","subscribers_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/subscribers","subscription_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/subscription","commits_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/contents/{+path}","compare_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/merges","archive_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/downloads","issues_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/issues{/number}","pulls_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/labels{/name}","releases_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/releases{/id}","deployments_url":"https://api.github.com/repos/tommymonk/puppeteer-sharp/deployments","created_at":"2018-09-27T14:16:19Z","updated_at":"2018-09-27T14:16:22Z","pushed_at":"2018-10-08T13:10:56Z","git_url":"git://github.com/tommymonk/puppeteer-sharp.git","ssh_url":"git@github.com:tommymonk/puppeteer-sharp.git","clone_url":"https://github.com/tommymonk/puppeteer-sharp.git","svn_url":"https://github.com/tommymonk/puppeteer-sharp","homepage":"https://www.puppeteersharp.com","size":2212,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kblok:master","ref":"master","sha":"7c29c545a49fb0c891fcf92d041ee8669ac65cc3","user":{"login":"kblok","id":2198466,"node_id":"MDQ6VXNlcjIxOTg0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"repo":{"id":105399035,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUzOTkwMzU=","name":"puppeteer-sharp","full_name":"kblok/puppeteer-sharp","private":false,"owner":{"login":"kblok","id":2198466,"node_id":"MDQ6VXNlcjIxOTg0NjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2198466?v=4","gravatar_id":"","url":"https://api.github.com/users/kblok","html_url":"https://github.com/kblok","followers_url":"https://api.github.com/users/kblok/followers","following_url":"https://api.github.com/users/kblok/following{/other_user}","gists_url":"https://api.github.com/users/kblok/gists{/gist_id}","starred_url":"https://api.github.com/users/kblok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kblok/subscriptions","organizations_url":"https://api.github.com/users/kblok/orgs","repos_url":"https://api.github.com/users/kblok/repos","events_url":"https://api.github.com/users/kblok/events{/privacy}","received_events_url":"https://api.github.com/users/kblok/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kblok/puppeteer-sharp","description":"Headless Chrome .NET API","fork":false,"url":"https://api.github.com/repos/kblok/puppeteer-sharp","forks_url":"https://api.github.com/repos/kblok/puppeteer-sharp/forks","keys_url":"https://api.github.com/repos/kblok/puppeteer-sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kblok/puppeteer-sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kblok/puppeteer-sharp/teams","hooks_url":"https://api.github.com/repos/kblok/puppeteer-sharp/hooks","issue_events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/events{/number}","events_url":"https://api.github.com/repos/kblok/puppeteer-sharp/events","assignees_url":"https://api.github.com/repos/kblok/puppeteer-sharp/assignees{/user}","branches_url":"https://api.github.com/repos/kblok/puppeteer-sharp/branches{/branch}","tags_url":"https://api.github.com/repos/kblok/puppeteer-sharp/tags","blobs_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/kblok/puppeteer-sharp/languages","stargazers_url":"https://api.github.com/repos/kblok/puppeteer-sharp/stargazers","contributors_url":"https://api.github.com/repos/kblok/puppeteer-sharp/contributors","subscribers_url":"https://api.github.com/repos/kblok/puppeteer-sharp/subscribers","subscription_url":"https://api.github.com/repos/kblok/puppeteer-sharp/subscription","commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/kblok/puppeteer-sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/kblok/puppeteer-sharp/contents/{+path}","compare_url":"https://api.github.com/repos/kblok/puppeteer-sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kblok/puppeteer-sharp/merges","archive_url":"https://api.github.com/repos/kblok/puppeteer-sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kblok/puppeteer-sharp/downloads","issues_url":"https://api.github.com/repos/kblok/puppeteer-sharp/issues{/number}","pulls_url":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/kblok/puppeteer-sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/kblok/puppeteer-sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kblok/puppeteer-sharp/labels{/name}","releases_url":"https://api.github.com/repos/kblok/puppeteer-sharp/releases{/id}","deployments_url":"https://api.github.com/repos/kblok/puppeteer-sharp/deployments","created_at":"2017-09-30T20:32:25Z","updated_at":"2018-10-10T11:56:59Z","pushed_at":"2018-10-10T11:43:43Z","git_url":"git://github.com/kblok/puppeteer-sharp.git","ssh_url":"git@github.com:kblok/puppeteer-sharp.git","clone_url":"https://github.com/kblok/puppeteer-sharp.git","svn_url":"https://github.com/kblok/puppeteer-sharp","homepage":"https://www.puppeteersharp.com","size":2180,"stargazers_count":255,"watchers_count":255,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":45,"open_issues":48,"watchers":255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/652"},"html":{"href":"https://github.com/kblok/puppeteer-sharp/pull/652"},"issue":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/652"},"comments":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/issues/652/comments"},"review_comments":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/652/comments"},"review_comment":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/pulls/652/commits"},"statuses":{"href":"https://api.github.com/repos/kblok/puppeteer-sharp/statuses/df7a3384039ae3037bf8c97aabbee28225afa513"}},"author_association":"NONE"}}
{"actor":{"display_login":"tommymonk"}}