{"action":"created","comment":{"url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/comments/196037237","pull_request_review_id":129513096,"id":196037237,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjAzNzIzNw==","diff_hunk":"@@ -1,9 +1,11 @@\n object handling\n updateFromRequest: aRouteSuffix with: anId\n- \n-    | updatedObject jsonString aRPModelClass|\n+\n+\t| updatedObject jsonString aRPModelClass objectFromDatabase |","path":"packages/RatPack.package/RPApplication.class/instance/updateFromRequest.with..st","position":null,"original_position":6,"commit_id":"9c9131205e126319ae57a4d61db84a988094b851","original_commit_id":"26bde2c45255e5a991403636b68d9849d2aa21cf","user":{"login":"He3lixxx","id":13838962,"node_id":"MDQ6VXNlcjEzODM4OTYy","avatar_url":"https://avatars0.githubusercontent.com/u/13838962?v=4","gravatar_id":"","url":"https://api.github.com/users/He3lixxx","html_url":"https://github.com/He3lixxx","followers_url":"https://api.github.com/users/He3lixxx/followers","following_url":"https://api.github.com/users/He3lixxx/following{/other_user}","gists_url":"https://api.github.com/users/He3lixxx/gists{/gist_id}","starred_url":"https://api.github.com/users/He3lixxx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/He3lixxx/subscriptions","organizations_url":"https://api.github.com/users/He3lixxx/orgs","repos_url":"https://api.github.com/users/He3lixxx/repos","events_url":"https://api.github.com/users/He3lixxx/events{/privacy}","received_events_url":"https://api.github.com/users/He3lixxx/received_events","type":"User","site_admin":false},"body":"Hmm?\r\n\r\n```smalltalk\r\nobject := self database loadModelObject: (anId asNumber) from: aRPModelClass.\r\nobject := aRPModelClass updateObject: object object withJson: jsonString.\r\n```\r\nhas the same ugliness, just one variable less, don't you think?","created_at":"2018-06-18T10:57:03Z","updated_at":"2018-06-18T10:57:03Z","html_url":"https://github.com/hpi-swa-teaching/RatPack2.0/pull/103#discussion_r196037237","pull_request_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/103","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/comments/196037237"},"html":{"href":"https://github.com/hpi-swa-teaching/RatPack2.0/pull/103#discussion_r196037237"},"pull_request":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/103"}},"in_reply_to_id":195909699},"pull_request":{"url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/103","id":195200275,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjAwMjc1","html_url":"https://github.com/hpi-swa-teaching/RatPack2.0/pull/103","diff_url":"https://github.com/hpi-swa-teaching/RatPack2.0/pull/103.diff","patch_url":"https://github.com/hpi-swa-teaching/RatPack2.0/pull/103.patch","issue_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues/103","number":103,"state":"open","locked":false,"title":"Reworked UpdateFromRequest.","user":{"login":"skydivin4ng3l","id":23174066,"node_id":"MDQ6VXNlcjIzMTc0MDY2","avatar_url":"https://avatars2.githubusercontent.com/u/23174066?v=4","gravatar_id":"","url":"https://api.github.com/users/skydivin4ng3l","html_url":"https://github.com/skydivin4ng3l","followers_url":"https://api.github.com/users/skydivin4ng3l/followers","following_url":"https://api.github.com/users/skydivin4ng3l/following{/other_user}","gists_url":"https://api.github.com/users/skydivin4ng3l/gists{/gist_id}","starred_url":"https://api.github.com/users/skydivin4ng3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skydivin4ng3l/subscriptions","organizations_url":"https://api.github.com/users/skydivin4ng3l/orgs","repos_url":"https://api.github.com/users/skydivin4ng3l/repos","events_url":"https://api.github.com/users/skydivin4ng3l/events{/privacy}","received_events_url":"https://api.github.com/users/skydivin4ng3l/received_events","type":"User","site_admin":false},"body":"It now handles incomplete Json, the way it is expected. loads the existing object from database and replaces only the altered json which is given to the method.","created_at":"2018-06-15T14:54:41Z","updated_at":"2018-06-18T10:57:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d5f7b27d23c10dacdcb7ee09bce12bdb848f54f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/103/commits","review_comments_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/103/comments","review_comment_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues/103/comments","statuses_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/statuses/9c9131205e126319ae57a4d61db84a988094b851","head":{"label":"hpi-swa-teaching:80-put-incomplete-json","ref":"80-put-incomplete-json","sha":"9c9131205e126319ae57a4d61db84a988094b851","user":{"login":"hpi-swa-teaching","id":7048439,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDg0Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7048439?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swa-teaching","html_url":"https://github.com/hpi-swa-teaching","followers_url":"https://api.github.com/users/hpi-swa-teaching/followers","following_url":"https://api.github.com/users/hpi-swa-teaching/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swa-teaching/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swa-teaching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swa-teaching/subscriptions","organizations_url":"https://api.github.com/users/hpi-swa-teaching/orgs","repos_url":"https://api.github.com/users/hpi-swa-teaching/repos","events_url":"https://api.github.com/users/hpi-swa-teaching/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swa-teaching/received_events","type":"Organization","site_admin":false},"repo":{"id":34439628,"node_id":"MDEwOlJlcG9zaXRvcnkzNDQzOTYyOA==","name":"RatPack2.0","full_name":"hpi-swa-teaching/RatPack2.0","owner":{"login":"hpi-swa-teaching","id":7048439,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDg0Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7048439?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swa-teaching","html_url":"https://github.com/hpi-swa-teaching","followers_url":"https://api.github.com/users/hpi-swa-teaching/followers","following_url":"https://api.github.com/users/hpi-swa-teaching/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swa-teaching/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swa-teaching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swa-teaching/subscriptions","organizations_url":"https://api.github.com/users/hpi-swa-teaching/orgs","repos_url":"https://api.github.com/users/hpi-swa-teaching/repos","events_url":"https://api.github.com/users/hpi-swa-teaching/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swa-teaching/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpi-swa-teaching/RatPack2.0","description":null,"fork":true,"url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0","forks_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/forks","keys_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/teams","hooks_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/hooks","issue_events_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues/events{/number}","events_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/events","assignees_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/assignees{/user}","branches_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/branches{/branch}","tags_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/tags","blobs_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/statuses/{sha}","languages_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/languages","stargazers_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/stargazers","contributors_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/contributors","subscribers_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/subscribers","subscription_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/subscription","commits_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/contents/{+path}","compare_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/merges","archive_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/downloads","issues_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues{/number}","pulls_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls{/number}","milestones_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/milestones{/number}","notifications_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/labels{/name}","releases_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/releases{/id}","deployments_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/deployments","created_at":"2015-04-23T07:04:27Z","updated_at":"2018-06-06T14:02:48Z","pushed_at":"2018-06-18T09:47:11Z","git_url":"git://github.com/hpi-swa-teaching/RatPack2.0.git","ssh_url":"git@github.com:hpi-swa-teaching/RatPack2.0.git","clone_url":"https://github.com/hpi-swa-teaching/RatPack2.0.git","svn_url":"https://github.com/hpi-swa-teaching/RatPack2.0","homepage":null,"size":522,"stargazers_count":0,"watchers_count":0,"language":"Smalltalk","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":29,"watchers":0,"default_branch":"master"}},"base":{"label":"hpi-swa-teaching:develop","ref":"develop","sha":"26b7b1e54bcf578b551a132626e551e443dba307","user":{"login":"hpi-swa-teaching","id":7048439,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDg0Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7048439?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swa-teaching","html_url":"https://github.com/hpi-swa-teaching","followers_url":"https://api.github.com/users/hpi-swa-teaching/followers","following_url":"https://api.github.com/users/hpi-swa-teaching/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swa-teaching/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swa-teaching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swa-teaching/subscriptions","organizations_url":"https://api.github.com/users/hpi-swa-teaching/orgs","repos_url":"https://api.github.com/users/hpi-swa-teaching/repos","events_url":"https://api.github.com/users/hpi-swa-teaching/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swa-teaching/received_events","type":"Organization","site_admin":false},"repo":{"id":34439628,"node_id":"MDEwOlJlcG9zaXRvcnkzNDQzOTYyOA==","name":"RatPack2.0","full_name":"hpi-swa-teaching/RatPack2.0","owner":{"login":"hpi-swa-teaching","id":7048439,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcwNDg0Mzk=","avatar_url":"https://avatars1.githubusercontent.com/u/7048439?v=4","gravatar_id":"","url":"https://api.github.com/users/hpi-swa-teaching","html_url":"https://github.com/hpi-swa-teaching","followers_url":"https://api.github.com/users/hpi-swa-teaching/followers","following_url":"https://api.github.com/users/hpi-swa-teaching/following{/other_user}","gists_url":"https://api.github.com/users/hpi-swa-teaching/gists{/gist_id}","starred_url":"https://api.github.com/users/hpi-swa-teaching/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpi-swa-teaching/subscriptions","organizations_url":"https://api.github.com/users/hpi-swa-teaching/orgs","repos_url":"https://api.github.com/users/hpi-swa-teaching/repos","events_url":"https://api.github.com/users/hpi-swa-teaching/events{/privacy}","received_events_url":"https://api.github.com/users/hpi-swa-teaching/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpi-swa-teaching/RatPack2.0","description":null,"fork":true,"url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0","forks_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/forks","keys_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/teams","hooks_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/hooks","issue_events_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues/events{/number}","events_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/events","assignees_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/assignees{/user}","branches_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/branches{/branch}","tags_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/tags","blobs_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/statuses/{sha}","languages_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/languages","stargazers_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/stargazers","contributors_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/contributors","subscribers_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/subscribers","subscription_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/subscription","commits_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/contents/{+path}","compare_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/merges","archive_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/downloads","issues_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues{/number}","pulls_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls{/number}","milestones_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/milestones{/number}","notifications_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/labels{/name}","releases_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/releases{/id}","deployments_url":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/deployments","created_at":"2015-04-23T07:04:27Z","updated_at":"2018-06-06T14:02:48Z","pushed_at":"2018-06-18T09:47:11Z","git_url":"git://github.com/hpi-swa-teaching/RatPack2.0.git","ssh_url":"git@github.com:hpi-swa-teaching/RatPack2.0.git","clone_url":"https://github.com/hpi-swa-teaching/RatPack2.0.git","svn_url":"https://github.com/hpi-swa-teaching/RatPack2.0","homepage":null,"size":522,"stargazers_count":0,"watchers_count":0,"language":"Smalltalk","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":29,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":29,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/103"},"html":{"href":"https://github.com/hpi-swa-teaching/RatPack2.0/pull/103"},"issue":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues/103"},"comments":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/hpi-swa-teaching/RatPack2.0/statuses/9c9131205e126319ae57a4d61db84a988094b851"}},"author_association":"NONE"}}
{"actor":{"display_login":"He3lixxx"}}