{"action":"created","comment":{"url":"https://api.github.com/repos/oleksiyp/mockk/pulls/comments/174054026","pull_request_review_id":103340109,"id":174054026,"diff_hunk":"@@ -67,7 +67,7 @@ internal object JvmMockFactoryHelper {\n                 .filter { it.kind != KParameter.Kind.INSTANCE }\n                 .indexOfFirst { it.isVararg }\n         else\n-            parameters.indexOfFirst { it.isVarArgs }\n+            if (isVarArgs) parameterTypes.size - 1 else -1","path":"mockk/src/main/kotlin/io/mockk/impl/instantiation/JvmMockFactoryHelper.kt","position":null,"original_position":5,"commit_id":"53331d0c2bdc4c620561d97f3bcc2094936d3c91","original_commit_id":"80483450894e9d15e53a8951ca08de29bcfbc2d7","user":{"login":"monosoul","id":5037832,"avatar_url":"https://avatars0.githubusercontent.com/u/5037832?v=4","gravatar_id":"","url":"https://api.github.com/users/monosoul","html_url":"https://github.com/monosoul","followers_url":"https://api.github.com/users/monosoul/followers","following_url":"https://api.github.com/users/monosoul/following{/other_user}","gists_url":"https://api.github.com/users/monosoul/gists{/gist_id}","starred_url":"https://api.github.com/users/monosoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monosoul/subscriptions","organizations_url":"https://api.github.com/users/monosoul/orgs","repos_url":"https://api.github.com/users/monosoul/repos","events_url":"https://api.github.com/users/monosoul/events{/privacy}","received_events_url":"https://api.github.com/users/monosoul/received_events","type":"User","site_admin":false},"body":"Indeed that's so for Kotlin, but we're using Java's `Method` here. I've moved this method out of `JvmMockFactoryHelper ` and introduced a simple test for it.","created_at":"2018-03-13T08:59:18Z","updated_at":"2018-03-13T08:59:44Z","html_url":"https://github.com/oleksiyp/mockk/pull/44#discussion_r174054026","pull_request_url":"https://api.github.com/repos/oleksiyp/mockk/pulls/44","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/oleksiyp/mockk/pulls/comments/174054026"},"html":{"href":"https://github.com/oleksiyp/mockk/pull/44#discussion_r174054026"},"pull_request":{"href":"https://api.github.com/repos/oleksiyp/mockk/pulls/44"}},"in_reply_to_id":174031835},"pull_request":{"url":"https://api.github.com/repos/oleksiyp/mockk/pulls/44","id":174567697,"html_url":"https://github.com/oleksiyp/mockk/pull/44","diff_url":"https://github.com/oleksiyp/mockk/pull/44.diff","patch_url":"https://github.com/oleksiyp/mockk/pull/44.patch","issue_url":"https://api.github.com/repos/oleksiyp/mockk/issues/44","number":44,"state":"open","locked":false,"title":"fix JDK7 compatibility (#43)","user":{"login":"monosoul","id":5037832,"avatar_url":"https://avatars0.githubusercontent.com/u/5037832?v=4","gravatar_id":"","url":"https://api.github.com/users/monosoul","html_url":"https://github.com/monosoul","followers_url":"https://api.github.com/users/monosoul/followers","following_url":"https://api.github.com/users/monosoul/following{/other_user}","gists_url":"https://api.github.com/users/monosoul/gists{/gist_id}","starred_url":"https://api.github.com/users/monosoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monosoul/subscriptions","organizations_url":"https://api.github.com/users/monosoul/orgs","repos_url":"https://api.github.com/users/monosoul/repos","events_url":"https://api.github.com/users/monosoul/events{/privacy}","received_events_url":"https://api.github.com/users/monosoul/received_events","type":"User","site_admin":false},"body":"It took only 2 small changes to bring JDK7 compatibility back. At least functionality that I'm currently using is working perfectly now.","created_at":"2018-03-13T06:21:04Z","updated_at":"2018-03-13T08:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7d50559358b9d382c3b912f68157693321d2566","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/oleksiyp/mockk/pulls/44/commits","review_comments_url":"https://api.github.com/repos/oleksiyp/mockk/pulls/44/comments","review_comment_url":"https://api.github.com/repos/oleksiyp/mockk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/oleksiyp/mockk/issues/44/comments","statuses_url":"https://api.github.com/repos/oleksiyp/mockk/statuses/53331d0c2bdc4c620561d97f3bcc2094936d3c91","head":{"label":"monosoul:jdk7-compatibility","ref":"jdk7-compatibility","sha":"53331d0c2bdc4c620561d97f3bcc2094936d3c91","user":{"login":"monosoul","id":5037832,"avatar_url":"https://avatars0.githubusercontent.com/u/5037832?v=4","gravatar_id":"","url":"https://api.github.com/users/monosoul","html_url":"https://github.com/monosoul","followers_url":"https://api.github.com/users/monosoul/followers","following_url":"https://api.github.com/users/monosoul/following{/other_user}","gists_url":"https://api.github.com/users/monosoul/gists{/gist_id}","starred_url":"https://api.github.com/users/monosoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monosoul/subscriptions","organizations_url":"https://api.github.com/users/monosoul/orgs","repos_url":"https://api.github.com/users/monosoul/repos","events_url":"https://api.github.com/users/monosoul/events{/privacy}","received_events_url":"https://api.github.com/users/monosoul/received_events","type":"User","site_admin":false},"repo":{"id":124885144,"name":"mockk","full_name":"monosoul/mockk","owner":{"login":"monosoul","id":5037832,"avatar_url":"https://avatars0.githubusercontent.com/u/5037832?v=4","gravatar_id":"","url":"https://api.github.com/users/monosoul","html_url":"https://github.com/monosoul","followers_url":"https://api.github.com/users/monosoul/followers","following_url":"https://api.github.com/users/monosoul/following{/other_user}","gists_url":"https://api.github.com/users/monosoul/gists{/gist_id}","starred_url":"https://api.github.com/users/monosoul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monosoul/subscriptions","organizations_url":"https://api.github.com/users/monosoul/orgs","repos_url":"https://api.github.com/users/monosoul/repos","events_url":"https://api.github.com/users/monosoul/events{/privacy}","received_events_url":"https://api.github.com/users/monosoul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/monosoul/mockk","description":"mocking library for Kotlin","fork":true,"url":"https://api.github.com/repos/monosoul/mockk","forks_url":"https://api.github.com/repos/monosoul/mockk/forks","keys_url":"https://api.github.com/repos/monosoul/mockk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/monosoul/mockk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/monosoul/mockk/teams","hooks_url":"https://api.github.com/repos/monosoul/mockk/hooks","issue_events_url":"https://api.github.com/repos/monosoul/mockk/issues/events{/number}","events_url":"https://api.github.com/repos/monosoul/mockk/events","assignees_url":"https://api.github.com/repos/monosoul/mockk/assignees{/user}","branches_url":"https://api.github.com/repos/monosoul/mockk/branches{/branch}","tags_url":"https://api.github.com/repos/monosoul/mockk/tags","blobs_url":"https://api.github.com/repos/monosoul/mockk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/monosoul/mockk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/monosoul/mockk/git/refs{/sha}","trees_url":"https://api.github.com/repos/monosoul/mockk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/monosoul/mockk/statuses/{sha}","languages_url":"https://api.github.com/repos/monosoul/mockk/languages","stargazers_url":"https://api.github.com/repos/monosoul/mockk/stargazers","contributors_url":"https://api.github.com/repos/monosoul/mockk/contributors","subscribers_url":"https://api.github.com/repos/monosoul/mockk/subscribers","subscription_url":"https://api.github.com/repos/monosoul/mockk/subscription","commits_url":"https://api.github.com/repos/monosoul/mockk/commits{/sha}","git_commits_url":"https://api.github.com/repos/monosoul/mockk/git/commits{/sha}","comments_url":"https://api.github.com/repos/monosoul/mockk/comments{/number}","issue_comment_url":"https://api.github.com/repos/monosoul/mockk/issues/comments{/number}","contents_url":"https://api.github.com/repos/monosoul/mockk/contents/{+path}","compare_url":"https://api.github.com/repos/monosoul/mockk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/monosoul/mockk/merges","archive_url":"https://api.github.com/repos/monosoul/mockk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/monosoul/mockk/downloads","issues_url":"https://api.github.com/repos/monosoul/mockk/issues{/number}","pulls_url":"https://api.github.com/repos/monosoul/mockk/pulls{/number}","milestones_url":"https://api.github.com/repos/monosoul/mockk/milestones{/number}","notifications_url":"https://api.github.com/repos/monosoul/mockk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/monosoul/mockk/labels{/name}","releases_url":"https://api.github.com/repos/monosoul/mockk/releases{/id}","deployments_url":"https://api.github.com/repos/monosoul/mockk/deployments","created_at":"2018-03-12T12:23:32Z","updated_at":"2018-03-12T13:05:28Z","pushed_at":"2018-03-13T08:55:48Z","git_url":"git://github.com/monosoul/mockk.git","ssh_url":"git@github.com:monosoul/mockk.git","clone_url":"https://github.com/monosoul/mockk.git","svn_url":"https://github.com/monosoul/mockk","homepage":"http://mockk.io","size":1860,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"oleksiyp:master","ref":"master","sha":"61b2225d314457de7a7d0b85c9bbce9e27d2c107","user":{"login":"oleksiyp","id":5249932,"avatar_url":"https://avatars2.githubusercontent.com/u/5249932?v=4","gravatar_id":"","url":"https://api.github.com/users/oleksiyp","html_url":"https://github.com/oleksiyp","followers_url":"https://api.github.com/users/oleksiyp/followers","following_url":"https://api.github.com/users/oleksiyp/following{/other_user}","gists_url":"https://api.github.com/users/oleksiyp/gists{/gist_id}","starred_url":"https://api.github.com/users/oleksiyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleksiyp/subscriptions","organizations_url":"https://api.github.com/users/oleksiyp/orgs","repos_url":"https://api.github.com/users/oleksiyp/repos","events_url":"https://api.github.com/users/oleksiyp/events{/privacy}","received_events_url":"https://api.github.com/users/oleksiyp/received_events","type":"User","site_admin":false},"repo":{"id":107331132,"name":"mockk","full_name":"oleksiyp/mockk","owner":{"login":"oleksiyp","id":5249932,"avatar_url":"https://avatars2.githubusercontent.com/u/5249932?v=4","gravatar_id":"","url":"https://api.github.com/users/oleksiyp","html_url":"https://github.com/oleksiyp","followers_url":"https://api.github.com/users/oleksiyp/followers","following_url":"https://api.github.com/users/oleksiyp/following{/other_user}","gists_url":"https://api.github.com/users/oleksiyp/gists{/gist_id}","starred_url":"https://api.github.com/users/oleksiyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oleksiyp/subscriptions","organizations_url":"https://api.github.com/users/oleksiyp/orgs","repos_url":"https://api.github.com/users/oleksiyp/repos","events_url":"https://api.github.com/users/oleksiyp/events{/privacy}","received_events_url":"https://api.github.com/users/oleksiyp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oleksiyp/mockk","description":"mocking library for Kotlin","fork":false,"url":"https://api.github.com/repos/oleksiyp/mockk","forks_url":"https://api.github.com/repos/oleksiyp/mockk/forks","keys_url":"https://api.github.com/repos/oleksiyp/mockk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oleksiyp/mockk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oleksiyp/mockk/teams","hooks_url":"https://api.github.com/repos/oleksiyp/mockk/hooks","issue_events_url":"https://api.github.com/repos/oleksiyp/mockk/issues/events{/number}","events_url":"https://api.github.com/repos/oleksiyp/mockk/events","assignees_url":"https://api.github.com/repos/oleksiyp/mockk/assignees{/user}","branches_url":"https://api.github.com/repos/oleksiyp/mockk/branches{/branch}","tags_url":"https://api.github.com/repos/oleksiyp/mockk/tags","blobs_url":"https://api.github.com/repos/oleksiyp/mockk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oleksiyp/mockk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oleksiyp/mockk/git/refs{/sha}","trees_url":"https://api.github.com/repos/oleksiyp/mockk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oleksiyp/mockk/statuses/{sha}","languages_url":"https://api.github.com/repos/oleksiyp/mockk/languages","stargazers_url":"https://api.github.com/repos/oleksiyp/mockk/stargazers","contributors_url":"https://api.github.com/repos/oleksiyp/mockk/contributors","subscribers_url":"https://api.github.com/repos/oleksiyp/mockk/subscribers","subscription_url":"https://api.github.com/repos/oleksiyp/mockk/subscription","commits_url":"https://api.github.com/repos/oleksiyp/mockk/commits{/sha}","git_commits_url":"https://api.github.com/repos/oleksiyp/mockk/git/commits{/sha}","comments_url":"https://api.github.com/repos/oleksiyp/mockk/comments{/number}","issue_comment_url":"https://api.github.com/repos/oleksiyp/mockk/issues/comments{/number}","contents_url":"https://api.github.com/repos/oleksiyp/mockk/contents/{+path}","compare_url":"https://api.github.com/repos/oleksiyp/mockk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oleksiyp/mockk/merges","archive_url":"https://api.github.com/repos/oleksiyp/mockk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oleksiyp/mockk/downloads","issues_url":"https://api.github.com/repos/oleksiyp/mockk/issues{/number}","pulls_url":"https://api.github.com/repos/oleksiyp/mockk/pulls{/number}","milestones_url":"https://api.github.com/repos/oleksiyp/mockk/milestones{/number}","notifications_url":"https://api.github.com/repos/oleksiyp/mockk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oleksiyp/mockk/labels{/name}","releases_url":"https://api.github.com/repos/oleksiyp/mockk/releases{/id}","deployments_url":"https://api.github.com/repos/oleksiyp/mockk/deployments","created_at":"2017-10-17T22:31:23Z","updated_at":"2018-03-13T07:06:49Z","pushed_at":"2018-03-13T08:55:49Z","git_url":"git://github.com/oleksiyp/mockk.git","ssh_url":"git@github.com:oleksiyp/mockk.git","clone_url":"https://github.com/oleksiyp/mockk.git","svn_url":"https://github.com/oleksiyp/mockk","homepage":"http://mockk.io","size":1858,"stargazers_count":402,"watchers_count":402,"language":"Kotlin","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":19,"open_issues":9,"watchers":402,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/oleksiyp/mockk/pulls/44"},"html":{"href":"https://github.com/oleksiyp/mockk/pull/44"},"issue":{"href":"https://api.github.com/repos/oleksiyp/mockk/issues/44"},"comments":{"href":"https://api.github.com/repos/oleksiyp/mockk/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/oleksiyp/mockk/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/oleksiyp/mockk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/oleksiyp/mockk/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/oleksiyp/mockk/statuses/53331d0c2bdc4c620561d97f3bcc2094936d3c91"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"monosoul"}}