{"action":"closed","issue":{"url":"https://api.github.com/repos/apollographql/apollo-server/issues/1935","repository_url":"https://api.github.com/repos/apollographql/apollo-server","labels_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1935/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1935/comments","events_url":"https://api.github.com/repos/apollographql/apollo-server/issues/1935/events","html_url":"https://github.com/apollographql/apollo-server/issues/1935","id":378683275,"node_id":"MDU6SXNzdWUzNzg2ODMyNzU=","number":1935,"title":"generateSchemaHash doesn't await execution result","user":{"login":"wmertens","id":54934,"node_id":"MDQ6VXNlcjU0OTM0","avatar_url":"https://avatars2.githubusercontent.com/u/54934?v=4","gravatar_id":"","url":"https://api.github.com/users/wmertens","html_url":"https://github.com/wmertens","followers_url":"https://api.github.com/users/wmertens/followers","following_url":"https://api.github.com/users/wmertens/following{/other_user}","gists_url":"https://api.github.com/users/wmertens/gists{/gist_id}","starred_url":"https://api.github.com/users/wmertens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmertens/subscriptions","organizations_url":"https://api.github.com/users/wmertens/orgs","repos_url":"https://api.github.com/users/wmertens/repos","events_url":"https://api.github.com/users/wmertens/events{/privacy}","received_events_url":"https://api.github.com/users/wmertens/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-11-08T11:07:46Z","updated_at":"2018-11-14T08:07:36Z","closed_at":"2018-11-14T08:07:36Z","author_association":"CONTRIBUTOR","body":"There's a problem here: https://github.com/apollographql/apollo-server/blob/6bd73b175ff628a5e9858e2a5da1aa9dab5ed348/packages/apollo-server-core/src/utils/schemaHash.ts#L11\r\n\r\nin graphql-js, this can return a Promise:\r\nhttps://github.com/graphql/graphql-js/blob/f529809f5408fb9a343e669ea4d4851add3df004/src/execution/execute.js#L141-L144\r\n\r\nSo generateSchemaHash has to always return a Promise, too.\r\n\r\nThis probably causes all the graphql-middleware issues, like #1934 \t"}}
{"actor":{"display_login":"abernix"}}