{"action":"closed","number":941,"pull_request":{"url":"https://api.github.com/repos/andymccurdy/redis-py/pulls/941","id":160067160,"node_id":"MDExOlB1bGxSZXF1ZXN0MTYwMDY3MTYw","html_url":"https://github.com/andymccurdy/redis-py/pull/941","diff_url":"https://github.com/andymccurdy/redis-py/pull/941.diff","patch_url":"https://github.com/andymccurdy/redis-py/pull/941.patch","issue_url":"https://api.github.com/repos/andymccurdy/redis-py/issues/941","number":941,"state":"closed","locked":false,"title":"Fix handling for empty arguments in commands that throw server-side error","user":{"login":"tzickel","id":7489847,"node_id":"MDQ6VXNlcjc0ODk4NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/7489847?v=4","gravatar_id":"","url":"https://api.github.com/users/tzickel","html_url":"https://github.com/tzickel","followers_url":"https://api.github.com/users/tzickel/followers","following_url":"https://api.github.com/users/tzickel/following{/other_user}","gists_url":"https://api.github.com/users/tzickel/gists{/gist_id}","starred_url":"https://api.github.com/users/tzickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzickel/subscriptions","organizations_url":"https://api.github.com/users/tzickel/orgs","repos_url":"https://api.github.com/users/tzickel/repos","events_url":"https://api.github.com/users/tzickel/events{/privacy}","received_events_url":"https://api.github.com/users/tzickel/received_events","type":"User","site_admin":false},"body":"Sometimes you pass an array to mget as an input, if the array is empty, instead of returning an empty array, mget throws an exception from the server (rightfully so) but it's not very pythonic.\r\n\r\nI have lots of places in the code which call mget with an array that might or might not be empty, since in the end i just iterate over the result, adding an if not empty check before each mget call is superfluous (and if someone really wants to check it, he can).","created_at":"2017-12-25T19:55:02Z","updated_at":"2018-11-05T21:56:43Z","closed_at":"2018-11-05T21:56:43Z","merged_at":null,"merge_commit_sha":"f68559227d2bc22afc38b31c022fdb263e3b11db","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andymccurdy/redis-py/pulls/941/commits","review_comments_url":"https://api.github.com/repos/andymccurdy/redis-py/pulls/941/comments","review_comment_url":"https://api.github.com/repos/andymccurdy/redis-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andymccurdy/redis-py/issues/941/comments","statuses_url":"https://api.github.com/repos/andymccurdy/redis-py/statuses/2230500222d4d31f1a28ce3cce7f4ef6871a5dab","head":{"label":"tzickel:mgetfix","ref":"mgetfix","sha":"2230500222d4d31f1a28ce3cce7f4ef6871a5dab","user":{"login":"tzickel","id":7489847,"node_id":"MDQ6VXNlcjc0ODk4NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/7489847?v=4","gravatar_id":"","url":"https://api.github.com/users/tzickel","html_url":"https://github.com/tzickel","followers_url":"https://api.github.com/users/tzickel/followers","following_url":"https://api.github.com/users/tzickel/following{/other_user}","gists_url":"https://api.github.com/users/tzickel/gists{/gist_id}","starred_url":"https://api.github.com/users/tzickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzickel/subscriptions","organizations_url":"https://api.github.com/users/tzickel/orgs","repos_url":"https://api.github.com/users/tzickel/repos","events_url":"https://api.github.com/users/tzickel/events{/privacy}","received_events_url":"https://api.github.com/users/tzickel/received_events","type":"User","site_admin":false},"repo":{"id":19615775,"node_id":"MDEwOlJlcG9zaXRvcnkxOTYxNTc3NQ==","name":"redis-py","full_name":"tzickel/redis-py","private":false,"owner":{"login":"tzickel","id":7489847,"node_id":"MDQ6VXNlcjc0ODk4NDc=","avatar_url":"https://avatars0.githubusercontent.com/u/7489847?v=4","gravatar_id":"","url":"https://api.github.com/users/tzickel","html_url":"https://github.com/tzickel","followers_url":"https://api.github.com/users/tzickel/followers","following_url":"https://api.github.com/users/tzickel/following{/other_user}","gists_url":"https://api.github.com/users/tzickel/gists{/gist_id}","starred_url":"https://api.github.com/users/tzickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzickel/subscriptions","organizations_url":"https://api.github.com/users/tzickel/orgs","repos_url":"https://api.github.com/users/tzickel/repos","events_url":"https://api.github.com/users/tzickel/events{/privacy}","received_events_url":"https://api.github.com/users/tzickel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tzickel/redis-py","description":"Redis Python Client","fork":true,"url":"https://api.github.com/repos/tzickel/redis-py","forks_url":"https://api.github.com/repos/tzickel/redis-py/forks","keys_url":"https://api.github.com/repos/tzickel/redis-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tzickel/redis-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tzickel/redis-py/teams","hooks_url":"https://api.github.com/repos/tzickel/redis-py/hooks","issue_events_url":"https://api.github.com/repos/tzickel/redis-py/issues/events{/number}","events_url":"https://api.github.com/repos/tzickel/redis-py/events","assignees_url":"https://api.github.com/repos/tzickel/redis-py/assignees{/user}","branches_url":"https://api.github.com/repos/tzickel/redis-py/branches{/branch}","tags_url":"https://api.github.com/repos/tzickel/redis-py/tags","blobs_url":"https://api.github.com/repos/tzickel/redis-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tzickel/redis-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tzickel/redis-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/tzickel/redis-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tzickel/redis-py/statuses/{sha}","languages_url":"https://api.github.com/repos/tzickel/redis-py/languages","stargazers_url":"https://api.github.com/repos/tzickel/redis-py/stargazers","contributors_url":"https://api.github.com/repos/tzickel/redis-py/contributors","subscribers_url":"https://api.github.com/repos/tzickel/redis-py/subscribers","subscription_url":"https://api.github.com/repos/tzickel/redis-py/subscription","commits_url":"https://api.github.com/repos/tzickel/redis-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/tzickel/redis-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/tzickel/redis-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/tzickel/redis-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/tzickel/redis-py/contents/{+path}","compare_url":"https://api.github.com/repos/tzickel/redis-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tzickel/redis-py/merges","archive_url":"https://api.github.com/repos/tzickel/redis-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tzickel/redis-py/downloads","issues_url":"https://api.github.com/repos/tzickel/redis-py/issues{/number}","pulls_url":"https://api.github.com/repos/tzickel/redis-py/pulls{/number}","milestones_url":"https://api.github.com/repos/tzickel/redis-py/milestones{/number}","notifications_url":"https://api.github.com/repos/tzickel/redis-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tzickel/redis-py/labels{/name}","releases_url":"https://api.github.com/repos/tzickel/redis-py/releases{/id}","deployments_url":"https://api.github.com/repos/tzickel/redis-py/deployments","created_at":"2014-05-09T15:27:39Z","updated_at":"2015-03-14T12:52:17Z","pushed_at":"2018-11-05T04:32:59Z","git_url":"git://github.com/tzickel/redis-py.git","ssh_url":"git@github.com:tzickel/redis-py.git","clone_url":"https://github.com/tzickel/redis-py.git","svn_url":"https://github.com/tzickel/redis-py","homepage":"","size":1690,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"andymccurdy:master","ref":"master","sha":"350362405112d6047ade4c3cc81931a2b4e33e36","user":{"login":"andymccurdy","id":89265,"node_id":"MDQ6VXNlcjg5MjY1","avatar_url":"https://avatars1.githubusercontent.com/u/89265?v=4","gravatar_id":"","url":"https://api.github.com/users/andymccurdy","html_url":"https://github.com/andymccurdy","followers_url":"https://api.github.com/users/andymccurdy/followers","following_url":"https://api.github.com/users/andymccurdy/following{/other_user}","gists_url":"https://api.github.com/users/andymccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/andymccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymccurdy/subscriptions","organizations_url":"https://api.github.com/users/andymccurdy/orgs","repos_url":"https://api.github.com/users/andymccurdy/repos","events_url":"https://api.github.com/users/andymccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/andymccurdy/received_events","type":"User","site_admin":false},"repo":{"id":363150,"node_id":"MDEwOlJlcG9zaXRvcnkzNjMxNTA=","name":"redis-py","full_name":"andymccurdy/redis-py","private":false,"owner":{"login":"andymccurdy","id":89265,"node_id":"MDQ6VXNlcjg5MjY1","avatar_url":"https://avatars1.githubusercontent.com/u/89265?v=4","gravatar_id":"","url":"https://api.github.com/users/andymccurdy","html_url":"https://github.com/andymccurdy","followers_url":"https://api.github.com/users/andymccurdy/followers","following_url":"https://api.github.com/users/andymccurdy/following{/other_user}","gists_url":"https://api.github.com/users/andymccurdy/gists{/gist_id}","starred_url":"https://api.github.com/users/andymccurdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andymccurdy/subscriptions","organizations_url":"https://api.github.com/users/andymccurdy/orgs","repos_url":"https://api.github.com/users/andymccurdy/repos","events_url":"https://api.github.com/users/andymccurdy/events{/privacy}","received_events_url":"https://api.github.com/users/andymccurdy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andymccurdy/redis-py","description":"Redis Python Client","fork":false,"url":"https://api.github.com/repos/andymccurdy/redis-py","forks_url":"https://api.github.com/repos/andymccurdy/redis-py/forks","keys_url":"https://api.github.com/repos/andymccurdy/redis-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andymccurdy/redis-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andymccurdy/redis-py/teams","hooks_url":"https://api.github.com/repos/andymccurdy/redis-py/hooks","issue_events_url":"https://api.github.com/repos/andymccurdy/redis-py/issues/events{/number}","events_url":"https://api.github.com/repos/andymccurdy/redis-py/events","assignees_url":"https://api.github.com/repos/andymccurdy/redis-py/assignees{/user}","branches_url":"https://api.github.com/repos/andymccurdy/redis-py/branches{/branch}","tags_url":"https://api.github.com/repos/andymccurdy/redis-py/tags","blobs_url":"https://api.github.com/repos/andymccurdy/redis-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andymccurdy/redis-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andymccurdy/redis-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/andymccurdy/redis-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andymccurdy/redis-py/statuses/{sha}","languages_url":"https://api.github.com/repos/andymccurdy/redis-py/languages","stargazers_url":"https://api.github.com/repos/andymccurdy/redis-py/stargazers","contributors_url":"https://api.github.com/repos/andymccurdy/redis-py/contributors","subscribers_url":"https://api.github.com/repos/andymccurdy/redis-py/subscribers","subscription_url":"https://api.github.com/repos/andymccurdy/redis-py/subscription","commits_url":"https://api.github.com/repos/andymccurdy/redis-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/andymccurdy/redis-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/andymccurdy/redis-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/andymccurdy/redis-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/andymccurdy/redis-py/contents/{+path}","compare_url":"https://api.github.com/repos/andymccurdy/redis-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andymccurdy/redis-py/merges","archive_url":"https://api.github.com/repos/andymccurdy/redis-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andymccurdy/redis-py/downloads","issues_url":"https://api.github.com/repos/andymccurdy/redis-py/issues{/number}","pulls_url":"https://api.github.com/repos/andymccurdy/redis-py/pulls{/number}","milestones_url":"https://api.github.com/repos/andymccurdy/redis-py/milestones{/number}","notifications_url":"https://api.github.com/repos/andymccurdy/redis-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andymccurdy/redis-py/labels{/name}","releases_url":"https://api.github.com/repos/andymccurdy/redis-py/releases{/id}","deployments_url":"https://api.github.com/repos/andymccurdy/redis-py/deployments","created_at":"2009-11-06T10:22:26Z","updated_at":"2018-11-05T20:28:02Z","pushed_at":"2018-11-05T20:27:43Z","git_url":"git://github.com/andymccurdy/redis-py.git","ssh_url":"git@github.com:andymccurdy/redis-py.git","clone_url":"https://github.com/andymccurdy/redis-py.git","svn_url":"https://github.com/andymccurdy/redis-py","homepage":"","size":1690,"stargazers_count":6797,"watchers_count":6797,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1575,"mirror_url":null,"archived":false,"open_issues_count":301,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1575,"open_issues":301,"watchers":6797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/andymccurdy/redis-py/pulls/941"},"html":{"href":"https://github.com/andymccurdy/redis-py/pull/941"},"issue":{"href":"https://api.github.com/repos/andymccurdy/redis-py/issues/941"},"comments":{"href":"https://api.github.com/repos/andymccurdy/redis-py/issues/941/comments"},"review_comments":{"href":"https://api.github.com/repos/andymccurdy/redis-py/pulls/941/comments"},"review_comment":{"href":"https://api.github.com/repos/andymccurdy/redis-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andymccurdy/redis-py/pulls/941/commits"},"statuses":{"href":"https://api.github.com/repos/andymccurdy/redis-py/statuses/2230500222d4d31f1a28ce3cce7f4ef6871a5dab"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":43,"deletions":11,"changed_files":3}}
{"actor":{"display_login":"andymccurdy"}}