{"action":"created","comment":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/comments/205647803","pull_request_review_id":140962147,"id":205647803,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTY0NzgwMw==","diff_hunk":"@@ -4,5 +4,14 @@ project(external)\n add_subdirectory(Box2D)\n add_subdirectory(recast)\n \n+if(ANDROID)","path":"source/external/CMakeLists.txt","position":4,"original_position":4,"commit_id":"da450bee0029bbb962250cf09dfcbdbaabf5d6e9","original_commit_id":"da450bee0029bbb962250cf09dfcbdbaabf5d6e9","user":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"body":"more clear, indeed","created_at":"2018-07-27T01:41:55Z","updated_at":"2018-07-27T01:41:55Z","html_url":"https://github.com/cocos2d/cocos2d-x-external/pull/6#discussion_r205647803","pull_request_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/6","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/comments/205647803"},"html":{"href":"https://github.com/cocos2d/cocos2d-x-external/pull/6#discussion_r205647803"},"pull_request":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/6"}},"in_reply_to_id":205589635},"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/6","id":204176422,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTc2NDIy","html_url":"https://github.com/cocos2d/cocos2d-x-external/pull/6","diff_url":"https://github.com/cocos2d/cocos2d-x-external/pull/6.diff","patch_url":"https://github.com/cocos2d/cocos2d-x-external/pull/6.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/issues/6","number":6,"state":"open","locked":false,"title":" copy android-specific from 3rd-party-libs-bin","user":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"body":"1. copy android-specific from 3rd-party-libs-bin to this repo\r\n2. adapt CMakeLists.txt for new added","created_at":"2018-07-26T15:14:13Z","updated_at":"2018-07-27T01:41:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a628db648061f639c372734809a5661d7a8c647","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/6/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/6/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/issues/6/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/statuses/da450bee0029bbb962250cf09dfcbdbaabf5d6e9","head":{"label":"drelaptop:master-mine","ref":"master-mine","sha":"da450bee0029bbb962250cf09dfcbdbaabf5d6e9","user":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"repo":{"id":142457916,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI0NTc5MTY=","name":"cocos2d-x-external","full_name":"drelaptop/cocos2d-x-external","owner":{"login":"drelaptop","id":26329291,"node_id":"MDQ6VXNlcjI2MzI5Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/26329291?v=4","gravatar_id":"","url":"https://api.github.com/users/drelaptop","html_url":"https://github.com/drelaptop","followers_url":"https://api.github.com/users/drelaptop/followers","following_url":"https://api.github.com/users/drelaptop/following{/other_user}","gists_url":"https://api.github.com/users/drelaptop/gists{/gist_id}","starred_url":"https://api.github.com/users/drelaptop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drelaptop/subscriptions","organizations_url":"https://api.github.com/users/drelaptop/orgs","repos_url":"https://api.github.com/users/drelaptop/repos","events_url":"https://api.github.com/users/drelaptop/events{/privacy}","received_events_url":"https://api.github.com/users/drelaptop/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drelaptop/cocos2d-x-external","description":"use CMake to build external 3rd party modules for cocos2d-x","fork":true,"url":"https://api.github.com/repos/drelaptop/cocos2d-x-external","forks_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/forks","keys_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/teams","hooks_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/hooks","issue_events_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/issues/events{/number}","events_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/events","assignees_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/assignees{/user}","branches_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/branches{/branch}","tags_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/tags","blobs_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/git/refs{/sha}","trees_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/statuses/{sha}","languages_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/languages","stargazers_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/stargazers","contributors_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/contributors","subscribers_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/subscribers","subscription_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/subscription","commits_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/commits{/sha}","git_commits_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/git/commits{/sha}","comments_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/comments{/number}","issue_comment_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/issues/comments{/number}","contents_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/contents/{+path}","compare_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/merges","archive_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/downloads","issues_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/issues{/number}","pulls_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/pulls{/number}","milestones_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/milestones{/number}","notifications_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/labels{/name}","releases_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/releases{/id}","deployments_url":"https://api.github.com/repos/drelaptop/cocos2d-x-external/deployments","created_at":"2018-07-26T15:12:22Z","updated_at":"2018-07-26T15:12:23Z","pushed_at":"2018-07-26T15:30:30Z","git_url":"git://github.com/drelaptop/cocos2d-x-external.git","ssh_url":"git@github.com:drelaptop/cocos2d-x-external.git","clone_url":"https://github.com/drelaptop/cocos2d-x-external.git","svn_url":"https://github.com/drelaptop/cocos2d-x-external","homepage":null,"size":771,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cocos2d:master","ref":"master","sha":"a9581f222e38e46fae734588d4345a8d880ed8e1","user":{"login":"cocos2d","id":234324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDMyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":141731655,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE3MzE2NTU=","name":"cocos2d-x-external","full_name":"cocos2d/cocos2d-x-external","owner":{"login":"cocos2d","id":234324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDMyNA==","avatar_url":"https://avatars3.githubusercontent.com/u/234324?v=4","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-x-external","description":"use CMake to build external 3rd party modules for cocos2d-x","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-x-external","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/releases{/id}","deployments_url":"https://api.github.com/repos/cocos2d/cocos2d-x-external/deployments","created_at":"2018-07-20T15:58:22Z","updated_at":"2018-07-26T13:30:28Z","pushed_at":"2018-07-26T15:30:31Z","git_url":"git://github.com/cocos2d/cocos2d-x-external.git","ssh_url":"git@github.com:cocos2d/cocos2d-x-external.git","clone_url":"https://github.com/cocos2d/cocos2d-x-external.git","svn_url":"https://github.com/cocos2d/cocos2d-x-external","homepage":null,"size":510,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":1,"open_issues":7,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/6"},"html":{"href":"https://github.com/cocos2d/cocos2d-x-external/pull/6"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/issues/6"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-x-external/statuses/da450bee0029bbb962250cf09dfcbdbaabf5d6e9"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"drelaptop"}}