{"action":"created","issue":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2327","repository_url":"https://api.github.com/repos/NuGet/NuGet.Client","labels_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2327/labels{/name}","comments_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2327/comments","events_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2327/events","html_url":"https://github.com/NuGet/NuGet.Client/pull/2327","id":337704863,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODIwNjI5","number":2327,"title":"Clarifies nuspec parsing exceptions","user":{"login":"TechnikEmpire","id":11234763,"node_id":"MDQ6VXNlcjExMjM0NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/11234763?v=4","gravatar_id":"","url":"https://api.github.com/users/TechnikEmpire","html_url":"https://github.com/TechnikEmpire","followers_url":"https://api.github.com/users/TechnikEmpire/followers","following_url":"https://api.github.com/users/TechnikEmpire/following{/other_user}","gists_url":"https://api.github.com/users/TechnikEmpire/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnikEmpire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnikEmpire/subscriptions","organizations_url":"https://api.github.com/users/TechnikEmpire/orgs","repos_url":"https://api.github.com/users/TechnikEmpire/repos","events_url":"https://api.github.com/users/TechnikEmpire/events{/privacy}","received_events_url":"https://api.github.com/users/TechnikEmpire/received_events","type":"User","site_admin":false},"labels":[{"id":788888526,"node_id":"MDU6TGFiZWw3ODg4ODg1MjY=","url":"https://api.github.com/repos/NuGet/NuGet.Client/labels/Approved%20for%20CI","name":"Approved for CI","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-03T00:24:14Z","updated_at":"2018-07-08T07:02:15Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/pulls/2327","html_url":"https://github.com/NuGet/NuGet.Client/pull/2327","diff_url":"https://github.com/NuGet/NuGet.Client/pull/2327.diff","patch_url":"https://github.com/NuGet/NuGet.Client/pull/2327.patch"},"body":"## Bug\r\nFixes: https://github.com/NuGet/Home/issues/2714\r\nRegression: No\r\nIf Regression then when did it last work:   \r\nIf Regression then how are we preventing it in future:   \r\n\r\n## Fix\r\nDetails:\r\nAdds a new exception string.\r\nWraps exceptions thrown while parsing nuspec properties and then throws parent exceptions that specify exactly what property caused the fatal issue.\r\nThe exception strings offers a helpful hint to the number one reason why this problem occurs, by reminding users to target the project file when using replacement tokens.\r\n\r\n\r\n## Testing/Validation\r\nTests Added: No  \r\nReason for not adding tests:  Not needed.\r\nValidation done:  Manually tested against https://github.com/NuGet/Home/files/249649/repro2714-badErrorInPackWhenVersionIsParameterized.zip"},"comment":{"url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/comments/403267421","html_url":"https://github.com/NuGet/NuGet.Client/pull/2327#issuecomment-403267421","issue_url":"https://api.github.com/repos/NuGet/NuGet.Client/issues/2327","id":403267421,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzI2NzQyMQ==","user":{"login":"TechnikEmpire","id":11234763,"node_id":"MDQ6VXNlcjExMjM0NzYz","avatar_url":"https://avatars2.githubusercontent.com/u/11234763?v=4","gravatar_id":"","url":"https://api.github.com/users/TechnikEmpire","html_url":"https://github.com/TechnikEmpire","followers_url":"https://api.github.com/users/TechnikEmpire/followers","following_url":"https://api.github.com/users/TechnikEmpire/following{/other_user}","gists_url":"https://api.github.com/users/TechnikEmpire/gists{/gist_id}","starred_url":"https://api.github.com/users/TechnikEmpire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechnikEmpire/subscriptions","organizations_url":"https://api.github.com/users/TechnikEmpire/orgs","repos_url":"https://api.github.com/users/TechnikEmpire/repos","events_url":"https://api.github.com/users/TechnikEmpire/events{/privacy}","received_events_url":"https://api.github.com/users/TechnikEmpire/received_events","type":"User","site_admin":false},"created_at":"2018-07-08T07:02:15Z","updated_at":"2018-07-08T07:02:15Z","author_association":"NONE","body":"@rohit21agrawal I didn't run any tests because the change is so insignificant that if it causes a test to fail, then the test is simply invalid.\r\n\r\nSorry but I've destroyed my local copy of this and moved on. I've got a million other things to do. If that's going to block merging though let me know."}}
{"actor":{"display_login":"TechnikEmpire"}}