{"action":"reopened","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/30157","repository_url":"https://api.github.com/repos/owncloud/core","labels_url":"https://api.github.com/repos/owncloud/core/issues/30157/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/30157/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/30157/events","html_url":"https://github.com/owncloud/core/issues/30157","id":288865373,"number":30157,"title":"[10.0.4] Sessions created from application passwords result in \"Login failed\" errors when used","user":{"login":"SamuAlfageme","id":2644445,"avatar_url":"https://avatars2.githubusercontent.com/u/2644445?v=4","gravatar_id":"","url":"https://api.github.com/users/SamuAlfageme","html_url":"https://github.com/SamuAlfageme","followers_url":"https://api.github.com/users/SamuAlfageme/followers","following_url":"https://api.github.com/users/SamuAlfageme/following{/other_user}","gists_url":"https://api.github.com/users/SamuAlfageme/gists{/gist_id}","starred_url":"https://api.github.com/users/SamuAlfageme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamuAlfageme/subscriptions","organizations_url":"https://api.github.com/users/SamuAlfageme/orgs","repos_url":"https://api.github.com/users/SamuAlfageme/repos","events_url":"https://api.github.com/users/SamuAlfageme/events{/privacy}","received_events_url":"https://api.github.com/users/SamuAlfageme/received_events","type":"User","site_admin":false},"labels":[{"id":120033380,"url":"https://api.github.com/repos/owncloud/core/labels/blue-ticket","name":"blue-ticket","color":"0033CC","default":false},{"id":12406434,"url":"https://api.github.com/repos/owncloud/core/labels/bug","name":"bug","color":"fc2929","default":true},{"id":298283218,"url":"https://api.github.com/repos/owncloud/core/labels/p1-urgent","name":"p1-urgent","color":"fc2929","default":false},{"id":82077581,"url":"https://api.github.com/repos/owncloud/core/labels/security","name":"security","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":{"login":"IljaN","id":246983,"avatar_url":"https://avatars3.githubusercontent.com/u/246983?v=4","gravatar_id":"","url":"https://api.github.com/users/IljaN","html_url":"https://github.com/IljaN","followers_url":"https://api.github.com/users/IljaN/followers","following_url":"https://api.github.com/users/IljaN/following{/other_user}","gists_url":"https://api.github.com/users/IljaN/gists{/gist_id}","starred_url":"https://api.github.com/users/IljaN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IljaN/subscriptions","organizations_url":"https://api.github.com/users/IljaN/orgs","repos_url":"https://api.github.com/users/IljaN/repos","events_url":"https://api.github.com/users/IljaN/events{/privacy}","received_events_url":"https://api.github.com/users/IljaN/received_events","type":"User","site_admin":false},"assignees":[{"login":"IljaN","id":246983,"avatar_url":"https://avatars3.githubusercontent.com/u/246983?v=4","gravatar_id":"","url":"https://api.github.com/users/IljaN","html_url":"https://github.com/IljaN","followers_url":"https://api.github.com/users/IljaN/followers","following_url":"https://api.github.com/users/IljaN/following{/other_user}","gists_url":"https://api.github.com/users/IljaN/gists{/gist_id}","starred_url":"https://api.github.com/users/IljaN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IljaN/subscriptions","organizations_url":"https://api.github.com/users/IljaN/orgs","repos_url":"https://api.github.com/users/IljaN/repos","events_url":"https://api.github.com/users/IljaN/events{/privacy}","received_events_url":"https://api.github.com/users/IljaN/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/119","html_url":"https://github.com/owncloud/core/milestone/119","labels_url":"https://api.github.com/repos/owncloud/core/milestones/119/labels","id":2827584,"number":119,"title":"development","description":"10.0.6","creator":{"login":"PVince81","id":277525,"avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"open_issues":140,"closed_issues":179,"state":"open","created_at":"2017-10-10T13:37:01Z","updated_at":"2018-02-07T12:25:07Z","due_on":null,"closed_at":null},"comments":17,"created_at":"2018-01-16T10:59:12Z","updated_at":"2018-02-07T12:25:07Z","closed_at":null,"author_association":"NONE","body":"### Context:\r\n~~Prior to 10.0.4, there was a problem with application password and the sessions left behind after deletion (see https://github.com/owncloud/core/issues/28553). This is most likely a collateral of the new logic for the fix on https://github.com/owncloud/core/pull/28879 (lacking a migration strategy maybe)~~\r\n\r\nThe clients send 2 auth. methods (required) on the headers for **all their requests**: `Authorization: Basic` and `Cookies`. \r\n\r\n\r\n### Steps to reproduce\r\n0. Setup lockout mechanism\r\n1. Create an application password on a 10.0.4 installation\r\n2. Use it to log in to the Desktop client \r\n3. Observe the server logs\r\n\r\n### Expected behavior\r\nEverything goes smooth\r\n\r\n### Actual behavior\r\nSee https://github.com/owncloud/core/issues/30157#issuecomment-360444643; **each client request** results in 2 entries on the logs:\r\n\r\n```\r\nowncloud_1  | {\"reqId\":\"b5PoKuAGyNkriyfFAMbG\",\"level\":2,\"time\":\"2018-01-30T16:06:51+00:00\",\"remoteAddr\":\"172.19.0.1\",\"user\":\"admin\",\"app\":\"core\",\"method\":\"PROPFIND\",\"url\":\"\\/remote.php\\/dav\\/files\\/admin\\/\",\"message\":\"Login failed: 'admin' (Remote IP: '172.19.0.1')\"}\r\nowncloud_1  | 172.19.0.1 - admin [30/Jan/2018:16:06:51 +0000] \"PROPFIND /remote.php/dav/files/admin/ HTTP/1.1\" 207 1551 \"-\" \"Mozilla/5.0 (Macintosh) mirall/2.3.4 (build 8537)\"\r\n```\r\n\r\n- **One successful, for the `Authorization` header.**\r\n- **One that causes a `Login failed` in core, that can be attributed to the `Cookie`** -> the issue here; this makes password lockout mechanisms to trigger if present (see 0)\r\n\r\n### Cause:\r\nhttps://github.com/owncloud/core/pull/29525\r\n\r\n### Related Issues:\r\n- https://github.com/owncloud/client/issues/6258\r\n- https://github.com/owncloud/user_ldap/issues/167\r\n\r\n~~I'm assigning @IljaN since he's familiar with the https://github.com/owncloud/core/pull/28879 patch, feel free to change assignment.~~"}}
{"actor":{"display_login":"SamuAlfageme"}}