{"push_id":2820779760,"size":5,"distinct_size":0,"ref":"refs/heads/release-2.1","head":"eed302cfd74829461115188c3f9c33efd1a6e560","before":"246edfb437ef93927e4e2395b908d23227a3c387","commits":[{"sha":"992219e1fff8f08842e35fa44f16b8c5471c288e","author":{"name":"Alex Robinson","email":"e522668276737e0807508286ee469559f9379f53@gmail.com"},"message":"workload/tpcc: Fix index-out-of-range panic\n\nI'm not sure whether this suggests something is broken with our tpc-c\nimplementation, our test fixtures, or cockroach itself, but I've seen\npanics caused by the customers slice being empty a couple times now.\nHow unexpected is this?\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/992219e1fff8f08842e35fa44f16b8c5471c288e"},{"sha":"4982f96611a6f2c02c1b9a08fe33427c504f239a","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"opt: Avoid allocation in idxconstraints\n\nUse ListBuilder to construct And/Or/Filters lists. Change ListBuilder\nto allocate 8 slots up front.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/4982f96611a6f2c02c1b9a08fe33427c504f239a"},{"sha":"b67adaa76cc443bbc8cb71567682a025bec75d7f","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"opt: Add Memo.NormOp helper method\n\nAdd helper method to get the operator type of the normalized expression\nin a memo group.\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/b67adaa76cc443bbc8cb71567682a025bec75d7f"},{"sha":"e968215830a5bdd9575799ab043e74fc563a67b4","author":{"name":"Andrew Kimball","email":"47fb46b442a7228b0951bd0a39a9bd256934d92d@cockroachlabs.com"},"message":"opt: Improve performance of IndexJoin planning\n\nPreviously, we were generating an IndexJoin+Scan expression for every\nsecondary index on a table. However, unless the Scan is constrained or\nlimited, the IndexJoin has almost no chance of being the best plan. And\nyet we were paying a sizeable perf penalty for generating the IndexJoins\nand then not using them.\n\nThe change is to generate IndexJoins \"one level up\", only when a Scan is\nwrapped in a Select or Limit. At this point, they become viable plans that\nhave a reasonable chance of being selected.\n\nThere are significant planning-time improvements from this change. Here are\nsingle CPU numbers showing the effects on optbuild + normalization + exploration\ntimes:\n\n  name                      old time/op  new time/op  delta\n  Phases/kv-read/Explore    30.1µs ± 2%  27.7µs ± 3%   -8.12%  (p=0.008 n=5+5)\n  Phases/planning1/Explore  15.4µs ± 1%  10.6µs ± 1%  -30.90%  (p=0.008 n=5+5)\n  Phases/planning2/Explore  56.8µs ± 2%  31.7µs ± 3%  -44.13%  (p=0.008 n=5+5)\n  Phases/planning3/Explore  54.2µs ± 3%  36.7µs ± 3%  -32.21%  (p=0.008 n=5+5)\n  Phases/planning4/Explore  67.8µs ± 1%  44.4µs ± 3%  -34.45%  (p=0.008 n=5+5)\n  Phases/planning5/Explore  54.0µs ± 3%  35.5µs ± 1%  -34.37%  (p=0.008 n=5+5)\n  Phases/planning6/Explore   218µs ± 1%    64µs ± 2%  -70.41%  (p=0.008 n=5+5)\n\nRelease note: None","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/e968215830a5bdd9575799ab043e74fc563a67b4"},{"sha":"eed302cfd74829461115188c3f9c33efd1a6e560","author":{"name":"craig[bot]","email":"3a2c29237f73c7cf88424b80e427b1884f346b35@cockroachlabs.com"},"message":"Merge #29009 #29011\n\n29009: backport-2.1: workload/tpcc: Fix index-out-of-range panic r=a-robinson a=a-robinson\n\nBackport 1/1 commits from #28989.\r\n\r\n/cc @cockroachdb/release\r\n\r\n---\r\n\r\nI'm not sure whether this suggests something is broken with our tpc-c\r\nimplementation, our test fixtures, or cockroach itself, but I've seen\r\npanics caused by the customers slice being empty a couple times now.\r\nHow unexpected is this?\r\n\r\nRelease note: None\r\n\r\n---\r\n\r\nGiven that tpcc is now being shipped as part of the cockroach binary (https://github.com/cockroachdb/cockroach/pull/28978), fixing a crash in it seems backport-worthy.\n\n29011: release-2.1: opt: Improve performance of IndexJoin planning r=andy-kimball a=andy-kimball\n\nBackport 3/3 commits from #28870.\r\n\r\n/cc @cockroachdb/release\r\n\r\n---\r\n\r\nPreviously, we were generating an IndexJoin+Scan expression for every\r\nsecondary index on a table. However, unless the Scan is constrained or\r\nlimited, the IndexJoin has almost no chance of being the best plan. And\r\nyet we were paying a sizeable perf penalty for generating the IndexJoins\r\nand then not using them.\r\n\r\nThe change is to generate IndexJoins \"one level up\", only when a Scan is\r\nwrapped in a Select or Limit. At this point, they become viable plans that\r\nhave a reasonable chance of being selected.\r\n\r\nThere are significant planning-time improvements from this change. Here are\r\nsingle CPU numbers showing the effects on optbuild + normalization + exploration\r\ntimes:\r\n```\r\n  name                      old time/op  new time/op  delta\r\n  Phases/kv-read/Explore    30.1µs ± 2%  27.7µs ± 3%   -8.12%  (p=0.008 n=5+5)\r\n  Phases/planning1/Explore  15.4µs ± 1%  10.6µs ± 1%  -30.90%  (p=0.008 n=5+5)\r\n  Phases/planning2/Explore  56.8µs ± 2%  31.7µs ± 3%  -44.13%  (p=0.008 n=5+5)\r\n  Phases/planning3/Explore  54.2µs ± 3%  36.7µs ± 3%  -32.21%  (p=0.008 n=5+5)\r\n  Phases/planning4/Explore  67.8µs ± 1%  44.4µs ± 3%  -34.45%  (p=0.008 n=5+5)\r\n  Phases/planning5/Explore  54.0µs ± 3%  35.5µs ± 1%  -34.37%  (p=0.008 n=5+5)\r\n  Phases/planning6/Explore   218µs ± 1%    64µs ± 2%  -70.41%  (p=0.008 n=5+5)\r\n```\r\n\n\nCo-authored-by: Alex Robinson <alexdwanerobinson@gmail.com>\nCo-authored-by: Andrew Kimball <andyk@cockroachlabs.com>","distinct":false,"url":"https://api.github.com/repos/cockroachdb/cockroach/commits/eed302cfd74829461115188c3f9c33efd1a6e560"}]}
{"actor":{"display_login":"craig"}}