{"action":"created","issue":{"url":"https://api.github.com/repos/hr-js/sta_access_manager/issues/121","repository_url":"https://api.github.com/repos/hr-js/sta_access_manager","labels_url":"https://api.github.com/repos/hr-js/sta_access_manager/issues/121/labels{/name}","comments_url":"https://api.github.com/repos/hr-js/sta_access_manager/issues/121/comments","events_url":"https://api.github.com/repos/hr-js/sta_access_manager/issues/121/events","html_url":"https://github.com/hr-js/sta_access_manager/pull/121","id":337275037,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NTE0MjU3","number":121,"title":"Ikkyu 3","user":{"login":"ikkyu-3","id":20366376,"node_id":"MDQ6VXNlcjIwMzY2Mzc2","avatar_url":"https://avatars0.githubusercontent.com/u/20366376?v=4","gravatar_id":"","url":"https://api.github.com/users/ikkyu-3","html_url":"https://github.com/ikkyu-3","followers_url":"https://api.github.com/users/ikkyu-3/followers","following_url":"https://api.github.com/users/ikkyu-3/following{/other_user}","gists_url":"https://api.github.com/users/ikkyu-3/gists{/gist_id}","starred_url":"https://api.github.com/users/ikkyu-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikkyu-3/subscriptions","organizations_url":"https://api.github.com/users/ikkyu-3/orgs","repos_url":"https://api.github.com/users/ikkyu-3/repos","events_url":"https://api.github.com/users/ikkyu-3/events{/privacy}","received_events_url":"https://api.github.com/users/ikkyu-3/received_events","type":"User","site_admin":false},"labels":[{"id":910105803,"node_id":"MDU6TGFiZWw5MTAxMDU4MDM=","url":"https://api.github.com/repos/hr-js/sta_access_manager/labels/Raspberry%20Pi","name":"Raspberry Pi","color":"bc0d5f","default":false}],"state":"open","locked":false,"assignee":{"login":"ikkyu-3","id":20366376,"node_id":"MDQ6VXNlcjIwMzY2Mzc2","avatar_url":"https://avatars0.githubusercontent.com/u/20366376?v=4","gravatar_id":"","url":"https://api.github.com/users/ikkyu-3","html_url":"https://github.com/ikkyu-3","followers_url":"https://api.github.com/users/ikkyu-3/followers","following_url":"https://api.github.com/users/ikkyu-3/following{/other_user}","gists_url":"https://api.github.com/users/ikkyu-3/gists{/gist_id}","starred_url":"https://api.github.com/users/ikkyu-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikkyu-3/subscriptions","organizations_url":"https://api.github.com/users/ikkyu-3/orgs","repos_url":"https://api.github.com/users/ikkyu-3/repos","events_url":"https://api.github.com/users/ikkyu-3/events{/privacy}","received_events_url":"https://api.github.com/users/ikkyu-3/received_events","type":"User","site_admin":false},"assignees":[{"login":"ikkyu-3","id":20366376,"node_id":"MDQ6VXNlcjIwMzY2Mzc2","avatar_url":"https://avatars0.githubusercontent.com/u/20366376?v=4","gravatar_id":"","url":"https://api.github.com/users/ikkyu-3","html_url":"https://github.com/ikkyu-3","followers_url":"https://api.github.com/users/ikkyu-3/followers","following_url":"https://api.github.com/users/ikkyu-3/following{/other_user}","gists_url":"https://api.github.com/users/ikkyu-3/gists{/gist_id}","starred_url":"https://api.github.com/users/ikkyu-3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ikkyu-3/subscriptions","organizations_url":"https://api.github.com/users/ikkyu-3/orgs","repos_url":"https://api.github.com/users/ikkyu-3/repos","events_url":"https://api.github.com/users/ikkyu-3/events{/privacy}","received_events_url":"https://api.github.com/users/ikkyu-3/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-07-01T08:49:26Z","updated_at":"2018-07-03T04:55:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/hr-js/sta_access_manager/pulls/121","html_url":"https://github.com/hr-js/sta_access_manager/pull/121","diff_url":"https://github.com/hr-js/sta_access_manager/pull/121.diff","patch_url":"https://github.com/hr-js/sta_access_manager/pull/121.patch"},"body":"## 該当issue\r\n[メニューコンポーネント作成 #104 ](https://github.com/hr-js/sta_access_manager/issues/104)\r\n\r\n## 概要\r\n### 1. 変更\r\n#### 1-1. flow-typedを追加 & 変更\r\n#### 1-2. エイリアスを使用できるようにしました\r\ntestファイル作成時に、`import`のpathが`../../../../....`と毎回テストを作成するのが大変だと判断したので、  \r\nエイリアスを使用し、`@components/xxx`と記述できるように変更\r\n\r\ntest以外でも使用できるように、flowとwebpackの設定を変更して対応\r\n\r\n- testに関しては、`package.json`のjest.moduleNameMapperで設定\r\n- flowに関しては、`.flowconfig`のoptionsで設定\r\n- webpackに関しては、`webpack.config.js`のresolveで設定\r\n\r\n#### 1-3. eslintの変更\r\n開発の際にエラーとなったものを無効化してます。  \r\n=> 無効化の基準としては、他の実装にもエラーがでるもの(ex. パスでエイリアスの使用時に発生するeslintのエラーなど)\r\n\r\n### 2. コンポーネント作成\r\n#### 2-1. src/client/components/atoms/MenuButton\r\n- ボタン\r\n- テスト済み\r\n#### 2-2. src/client/components/molecules/MenuList\r\n- MenuButtonを使用したリスト\r\n- テスト済み\r\n#### 2-3. src/client/components/organisms/Menu\r\n- MenuListを使用し、横幅などを指定したメニュー\r\n- テスト済み\r\n\r\n### 3. stroybookの導入\r\n- 作成したコンポーネントを確認するために作成\r\n#### src/client/components/storybook\r\n##### 確認方法\r\n```\r\n$ yarn run storybook\r\n```\r\n- http://localhost:9001/ にアクセスして確認"},"comment":{"url":"https://api.github.com/repos/hr-js/sta_access_manager/issues/comments/402013065","html_url":"https://github.com/hr-js/sta_access_manager/pull/121#issuecomment-402013065","issue_url":"https://api.github.com/repos/hr-js/sta_access_manager/issues/121","id":402013065,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjAxMzA2NQ==","user":{"login":"krhrtky","id":22273094,"node_id":"MDQ6VXNlcjIyMjczMDk0","avatar_url":"https://avatars1.githubusercontent.com/u/22273094?v=4","gravatar_id":"","url":"https://api.github.com/users/krhrtky","html_url":"https://github.com/krhrtky","followers_url":"https://api.github.com/users/krhrtky/followers","following_url":"https://api.github.com/users/krhrtky/following{/other_user}","gists_url":"https://api.github.com/users/krhrtky/gists{/gist_id}","starred_url":"https://api.github.com/users/krhrtky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krhrtky/subscriptions","organizations_url":"https://api.github.com/users/krhrtky/orgs","repos_url":"https://api.github.com/users/krhrtky/repos","events_url":"https://api.github.com/users/krhrtky/events{/privacy}","received_events_url":"https://api.github.com/users/krhrtky/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T04:55:47Z","updated_at":"2018-07-03T04:55:47Z","author_association":"CONTRIBUTOR","body":"@ikkyu-3 \r\n横やりすいません。\r\n\r\nPRで確認することがかなり多くなっている気がします。\r\n* 設定\r\n  * 型定義\r\n  * alias\r\n  * lint\r\n\r\n* 実装\r\n\r\n* storybook\r\n\r\nこれだけあると一度に見れないと思いますし、\r\n分けてレビューしても、どこまでやったか分かりにくいのかなと感じました。\r\n\r\n## flowの型定義ファイルについて、\r\n*  flow-typed/* についてもリポジトリで管理する必要ってあるのでしょうか？\r\n* npmから取得しているようですし、どこかにインストールする一覧を定義してあれば一括インストールみたいなことはできないでしょうか？\r\n* updateが入るごとに型定義ファイルもPRにdiffが出てしまうので、それも見にくさ・確認の観点が曖昧になる気がします。"}}
{"actor":{"display_login":"krhrtky"}}