{"action":"created","issue":{"url":"https://api.github.com/repos/folio-org/stripes-components/issues/364","repository_url":"https://api.github.com/repos/folio-org/stripes-components","labels_url":"https://api.github.com/repos/folio-org/stripes-components/issues/364/labels{/name}","comments_url":"https://api.github.com/repos/folio-org/stripes-components/issues/364/comments","events_url":"https://api.github.com/repos/folio-org/stripes-components/issues/364/events","html_url":"https://github.com/folio-org/stripes-components/pull/364","id":320645999,"number":364,"title":"Updated / added CSS variables + Various style updates","user":{"login":"rasmuswoelk","id":640976,"avatar_url":"https://avatars3.githubusercontent.com/u/640976?v=4","gravatar_id":"","url":"https://api.github.com/users/rasmuswoelk","html_url":"https://github.com/rasmuswoelk","followers_url":"https://api.github.com/users/rasmuswoelk/followers","following_url":"https://api.github.com/users/rasmuswoelk/following{/other_user}","gists_url":"https://api.github.com/users/rasmuswoelk/gists{/gist_id}","starred_url":"https://api.github.com/users/rasmuswoelk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rasmuswoelk/subscriptions","organizations_url":"https://api.github.com/users/rasmuswoelk/orgs","repos_url":"https://api.github.com/users/rasmuswoelk/repos","events_url":"https://api.github.com/users/rasmuswoelk/events{/privacy}","received_events_url":"https://api.github.com/users/rasmuswoelk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-07T01:05:49Z","updated_at":"2018-05-07T01:09:57Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/folio-org/stripes-components/pulls/364","html_url":"https://github.com/folio-org/stripes-components/pull/364","diff_url":"https://github.com/folio-org/stripes-components/pull/364.diff","patch_url":"https://github.com/folio-org/stripes-components/pull/364.patch"},"body":"- Added new CSS variables and replaced old variables (kept old ones for now)\r\n- Added CSS variables in a lot of places that had hardcoded colors\r\n- Updated Checkbox and RadioButton styling\r\n- Removed hardcoded fill on icons in Timepicker\r\n\r\nThere is still some work to be done here but we are closer to being consistent when it comes to CSS variables. This will come in handy when we do theming and user changeable system colors, font weights etc.\r\n\r\nI will follow up these updates with changes in other relevant repos (stripes-core, stripes-smart-components etc.)"},"comment":{"url":"https://api.github.com/repos/folio-org/stripes-components/issues/comments/386931951","html_url":"https://github.com/folio-org/stripes-components/pull/364#issuecomment-386931951","issue_url":"https://api.github.com/repos/folio-org/stripes-components/issues/364","id":386931951,"user":{"login":"id-jenkins","id":16718781,"avatar_url":"https://avatars0.githubusercontent.com/u/16718781?v=4","gravatar_id":"","url":"https://api.github.com/users/id-jenkins","html_url":"https://github.com/id-jenkins","followers_url":"https://api.github.com/users/id-jenkins/followers","following_url":"https://api.github.com/users/id-jenkins/following{/other_user}","gists_url":"https://api.github.com/users/id-jenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/id-jenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/id-jenkins/subscriptions","organizations_url":"https://api.github.com/users/id-jenkins/orgs","repos_url":"https://api.github.com/users/id-jenkins/repos","events_url":"https://api.github.com/users/id-jenkins/events{/privacy}","received_events_url":"https://api.github.com/users/id-jenkins/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T01:09:57Z","updated_at":"2018-05-07T01:09:57Z","author_association":"CONTRIBUTOR","body":"<html><body><pre>\nyarn run v1.6.0\n$ eslint lib && stylelint \"lib/**/*.css\"\n\n/home/jenkins/workspace/folio-org/stripes-components/PR-364/project/lib/Accordion/tests/Accordion-test.js\n   11:7   error  'accordion' is never reassigned. Use 'const' instead                   prefer-const\n   24:5   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n   38:7   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n   48:9   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n   66:7   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n   76:9   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n   86:11  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n   97:39  error  A space is required before closing bracket                             react/jsx-tag-spacing\n  107:7   error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n\n/home/jenkins/workspace/folio-org/stripes-components/PR-364/project/lib/Button/tests/Button-test.js\n  26:5  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n  30:5  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n  61:7  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n  81:7  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n\n/home/jenkins/workspace/folio-org/stripes-components/PR-364/project/lib/EntrySelector/EntrySelector.js\n  76:92  error  'resources' is missing in props validation  react/prop-types\n\n/home/jenkins/workspace/folio-org/stripes-components/PR-364/project/lib/IconButton/tests/IconButton-test.js\n  24:5  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n  39:7  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n  53:7  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n  71:7  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n  93:7  error  Expected an assignment or function call and instead saw an expression  no-unused-expressions\n\n✖ 19 problems (19 errors, 0 warnings)\n  2 errors, 0 warnings potentially fixable with the `--fix` option.\n\ninfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.\n</pre><body></html>\n"}}
{"actor":{"display_login":"id-jenkins"}}