{"action":"created","issue":{"url":"https://api.github.com/repos/dmacvicar/terraform-provider-libvirt/issues/432","repository_url":"https://api.github.com/repos/dmacvicar/terraform-provider-libvirt","labels_url":"https://api.github.com/repos/dmacvicar/terraform-provider-libvirt/issues/432/labels{/name}","comments_url":"https://api.github.com/repos/dmacvicar/terraform-provider-libvirt/issues/432/comments","events_url":"https://api.github.com/repos/dmacvicar/terraform-provider-libvirt/issues/432/events","html_url":"https://github.com/dmacvicar/terraform-provider-libvirt/pull/432","id":364345563,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NTU0ODQx","number":432,"title":"WIP: Use upstream DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT and libvirt events","user":{"login":"MalloZup","id":10886597,"node_id":"MDQ6VXNlcjEwODg2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/10886597?v=4","gravatar_id":"","url":"https://api.github.com/users/MalloZup","html_url":"https://github.com/MalloZup","followers_url":"https://api.github.com/users/MalloZup/followers","following_url":"https://api.github.com/users/MalloZup/following{/other_user}","gists_url":"https://api.github.com/users/MalloZup/gists{/gist_id}","starred_url":"https://api.github.com/users/MalloZup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalloZup/subscriptions","organizations_url":"https://api.github.com/users/MalloZup/orgs","repos_url":"https://api.github.com/users/MalloZup/repos","events_url":"https://api.github.com/users/MalloZup/events{/privacy}","received_events_url":"https://api.github.com/users/MalloZup/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-27T07:47:29Z","updated_at":"2018-10-06T08:55:16Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/dmacvicar/terraform-provider-libvirt/pulls/432","html_url":"https://github.com/dmacvicar/terraform-provider-libvirt/pull/432","diff_url":"https://github.com/dmacvicar/terraform-provider-libvirt/pull/432.diff","patch_url":"https://github.com/dmacvicar/terraform-provider-libvirt/pull/432.patch"},"body":"# What does this PR:\r\n\r\nIn past we used ` domain.QemuAgentCommand` for getting the Interfaces via qemu-agent.\r\n\r\n* Now we are using `domain.ListAllInterfaceAddresses(libvirt.DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE`\r\n\r\n* additionally as you can see, we get more simpler codebase with the new function from upstream.\r\n\r\n* for domains which are `down` we just skip. This was also the behaviour from libvirt-api\r\n\r\nWe still need a loop function with timeouts because otherwise we might endup in a situation where the QEMU-AGENT is installed but not already setup. So we need to wait and retry for a delay of time.\r\n\r\nIf we don't have the timeout with the loop we will get at 1st try error: `Guest agent is not responding: QEMU guest agent is not connected`\r\n"},"comment":{"url":"https://api.github.com/repos/dmacvicar/terraform-provider-libvirt/issues/comments/427557986","html_url":"https://github.com/dmacvicar/terraform-provider-libvirt/pull/432#issuecomment-427557986","issue_url":"https://api.github.com/repos/dmacvicar/terraform-provider-libvirt/issues/432","id":427557986,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzU1Nzk4Ng==","user":{"login":"MalloZup","id":10886597,"node_id":"MDQ6VXNlcjEwODg2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/10886597?v=4","gravatar_id":"","url":"https://api.github.com/users/MalloZup","html_url":"https://github.com/MalloZup","followers_url":"https://api.github.com/users/MalloZup/followers","following_url":"https://api.github.com/users/MalloZup/following{/other_user}","gists_url":"https://api.github.com/users/MalloZup/gists{/gist_id}","starred_url":"https://api.github.com/users/MalloZup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MalloZup/subscriptions","organizations_url":"https://api.github.com/users/MalloZup/orgs","repos_url":"https://api.github.com/users/MalloZup/repos","events_url":"https://api.github.com/users/MalloZup/events{/privacy}","received_events_url":"https://api.github.com/users/MalloZup/received_events","type":"User","site_admin":false},"created_at":"2018-10-06T08:55:16Z","updated_at":"2018-10-06T08:55:16Z","author_association":"COLLABORATOR","body":"@dmacvicar i am not finished yet with the events code, but we need either tk wait forever for thea event with (EventRunDefaultImpl) or we add possible timeout for listening. Other"}}
{"actor":{"display_login":"MalloZup"}}