{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/165833786","pull_request_review_id":93835363,"id":165833786,"diff_hunk":"@@ -2109,6 +2139,8 @@ def create_s2wasm_args(temp_s):\n   args += ['--global-base=%d' % shared.Settings.GLOBAL_BASE]\n   args += ['--initial-memory=%d' % shared.Settings.TOTAL_MEMORY]\n   args += ['--allow-memory-growth'] if shared.Settings.ALLOW_MEMORY_GROWTH else []\n+  args += ['--emscripten-reserved-function-pointers=%d' %","path":"emscripten.py","position":116,"original_position":116,"commit_id":"63d89993a0968d22e9d379955e2d8121eb76b343","original_commit_id":"63d89993a0968d22e9d379955e2d8121eb76b343","user":{"login":"aheejin","id":8726997,"avatar_url":"https://avatars1.githubusercontent.com/u/8726997?v=4","gravatar_id":"","url":"https://api.github.com/users/aheejin","html_url":"https://github.com/aheejin","followers_url":"https://api.github.com/users/aheejin/followers","following_url":"https://api.github.com/users/aheejin/following{/other_user}","gists_url":"https://api.github.com/users/aheejin/gists{/gist_id}","starred_url":"https://api.github.com/users/aheejin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheejin/subscriptions","organizations_url":"https://api.github.com/users/aheejin/orgs","repos_url":"https://api.github.com/users/aheejin/repos","events_url":"https://api.github.com/users/aheejin/events{/privacy}","received_events_url":"https://api.github.com/users/aheejin/received_events","type":"User","site_admin":false},"body":"You mean the way it is looks ok, right?","created_at":"2018-02-04T05:00:31Z","updated_at":"2018-02-04T05:00:31Z","html_url":"https://github.com/kripken/emscripten/pull/6176#discussion_r165833786","pull_request_url":"https://api.github.com/repos/kripken/emscripten/pulls/6176","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/165833786"},"html":{"href":"https://github.com/kripken/emscripten/pull/6176#discussion_r165833786"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/6176"}},"in_reply_to_id":165508788},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/6176","id":166668871,"html_url":"https://github.com/kripken/emscripten/pull/6176","diff_url":"https://github.com/kripken/emscripten/pull/6176.diff","patch_url":"https://github.com/kripken/emscripten/pull/6176.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/6176","number":6176,"state":"open","locked":false,"title":"addFunction support for Wasm backend","user":{"login":"aheejin","id":8726997,"avatar_url":"https://avatars1.githubusercontent.com/u/8726997?v=4","gravatar_id":"","url":"https://api.github.com/users/aheejin","html_url":"https://github.com/aheejin","followers_url":"https://api.github.com/users/aheejin/followers","following_url":"https://api.github.com/users/aheejin/following{/other_user}","gists_url":"https://api.github.com/users/aheejin/gists{/gist_id}","starred_url":"https://api.github.com/users/aheejin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheejin/subscriptions","organizations_url":"https://api.github.com/users/aheejin/orgs","repos_url":"https://api.github.com/users/aheejin/repos","events_url":"https://api.github.com/users/aheejin/events{/privacy}","received_events_url":"https://api.github.com/users/aheejin/received_events","type":"User","site_admin":false},"body":"This introduces a breaking change; when using `addFunction` on Wasm backend, you should provide an additional second argument, a Wasm function signature string. See changelog for details.\r\n\r\nShould land after WebAssembly/binaryen#1395. Closes #5673 and closes #6100.","created_at":"2018-02-01T22:24:40Z","updated_at":"2018-02-04T05:00:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"806a0f6fa1235efa40c19acf9b64ec2840e243ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/6176/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/6176/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/6176/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/63d89993a0968d22e9d379955e2d8121eb76b343","head":{"label":"aheejin:add_function","ref":"add_function","sha":"63d89993a0968d22e9d379955e2d8121eb76b343","user":{"login":"aheejin","id":8726997,"avatar_url":"https://avatars1.githubusercontent.com/u/8726997?v=4","gravatar_id":"","url":"https://api.github.com/users/aheejin","html_url":"https://github.com/aheejin","followers_url":"https://api.github.com/users/aheejin/followers","following_url":"https://api.github.com/users/aheejin/following{/other_user}","gists_url":"https://api.github.com/users/aheejin/gists{/gist_id}","starred_url":"https://api.github.com/users/aheejin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheejin/subscriptions","organizations_url":"https://api.github.com/users/aheejin/orgs","repos_url":"https://api.github.com/users/aheejin/repos","events_url":"https://api.github.com/users/aheejin/events{/privacy}","received_events_url":"https://api.github.com/users/aheejin/received_events","type":"User","site_admin":false},"repo":{"id":64959959,"name":"emscripten","full_name":"aheejin/emscripten","owner":{"login":"aheejin","id":8726997,"avatar_url":"https://avatars1.githubusercontent.com/u/8726997?v=4","gravatar_id":"","url":"https://api.github.com/users/aheejin","html_url":"https://github.com/aheejin","followers_url":"https://api.github.com/users/aheejin/followers","following_url":"https://api.github.com/users/aheejin/following{/other_user}","gists_url":"https://api.github.com/users/aheejin/gists{/gist_id}","starred_url":"https://api.github.com/users/aheejin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheejin/subscriptions","organizations_url":"https://api.github.com/users/aheejin/orgs","repos_url":"https://api.github.com/users/aheejin/repos","events_url":"https://api.github.com/users/aheejin/events{/privacy}","received_events_url":"https://api.github.com/users/aheejin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aheejin/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/aheejin/emscripten","forks_url":"https://api.github.com/repos/aheejin/emscripten/forks","keys_url":"https://api.github.com/repos/aheejin/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aheejin/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aheejin/emscripten/teams","hooks_url":"https://api.github.com/repos/aheejin/emscripten/hooks","issue_events_url":"https://api.github.com/repos/aheejin/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/aheejin/emscripten/events","assignees_url":"https://api.github.com/repos/aheejin/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/aheejin/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/aheejin/emscripten/tags","blobs_url":"https://api.github.com/repos/aheejin/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aheejin/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aheejin/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/aheejin/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aheejin/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/aheejin/emscripten/languages","stargazers_url":"https://api.github.com/repos/aheejin/emscripten/stargazers","contributors_url":"https://api.github.com/repos/aheejin/emscripten/contributors","subscribers_url":"https://api.github.com/repos/aheejin/emscripten/subscribers","subscription_url":"https://api.github.com/repos/aheejin/emscripten/subscription","commits_url":"https://api.github.com/repos/aheejin/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/aheejin/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/aheejin/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/aheejin/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/aheejin/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/aheejin/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aheejin/emscripten/merges","archive_url":"https://api.github.com/repos/aheejin/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aheejin/emscripten/downloads","issues_url":"https://api.github.com/repos/aheejin/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/aheejin/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/aheejin/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/aheejin/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aheejin/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/aheejin/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/aheejin/emscripten/deployments","created_at":"2016-08-04T18:59:46Z","updated_at":"2016-08-04T19:00:08Z","pushed_at":"2018-02-03T09:53:37Z","git_url":"git://github.com/aheejin/emscripten.git","ssh_url":"git@github.com:aheejin/emscripten.git","clone_url":"https://github.com/aheejin/emscripten.git","svn_url":"https://github.com/aheejin/emscripten","homepage":"","size":157122,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"incoming"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"6d2798e0af2af4101bf58b3a378bdbb7101fba6a","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars0.githubusercontent.com/u/173661?v=4","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","deployments_url":"https://api.github.com/repos/kripken/emscripten/deployments","created_at":"2011-02-12T05:23:30Z","updated_at":"2018-02-04T04:56:28Z","pushed_at":"2018-02-04T04:34:45Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":157393,"stargazers_count":13996,"watchers_count":13996,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1670,"mirror_url":null,"archived":false,"open_issues_count":1351,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1670,"open_issues":1351,"watchers":13996,"default_branch":"incoming"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/6176"},"html":{"href":"https://github.com/kripken/emscripten/pull/6176"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/6176"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/6176/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/6176/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/6176/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/63d89993a0968d22e9d379955e2d8121eb76b343"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aheejin"}}