{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/233697552","pull_request_review_id":175173060,"id":233697552,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzY5NzU1Mg==","diff_hunk":"@@ -180,8 +180,11 @@ include \"beam-sdks-python-container\"\n project(\":beam-sdks-python-container\").dir = file(\"sdks/python/container\")\n include \"beam-sdks-python-container-py3\"\n project(\":beam-sdks-python-container-py3\").dir = file(\"sdks/python/container/py3\")\n+// Temporary version that will be deleted once we migrate to using the published version.\n include \"beam-vendor-grpc-v1_13_1\"\n project(\":beam-vendor-grpc-v1_13_1\").dir = file(\"vendor/grpc-v1_13_1\")\n+include \"beam-vendor-grpc-1_13_1\"","path":"settings.gradle","position":7,"original_position":7,"commit_id":"7ee1700f951cd36b64275c3db89cb9040c533177","original_commit_id":"7ee1700f951cd36b64275c3db89cb9040c533177","user":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"body":"It could be that we would have two versions in the codebase as stuff gets migrated from one version to another and following the pattern that Kenn was establishing. `git mv` is pretty easy to use for these cases and the cost of changing this isn't high if this becomes a big hassle.","created_at":"2018-11-15T02:56:23Z","updated_at":"2018-11-15T02:56:24Z","html_url":"https://github.com/apache/beam/pull/7042#discussion_r233697552","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/7042","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/233697552"},"html":{"href":"https://github.com/apache/beam/pull/7042#discussion_r233697552"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/7042"}},"in_reply_to_id":233663231},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/7042","id":230976441,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTc2NDQx","html_url":"https://github.com/apache/beam/pull/7042","diff_url":"https://github.com/apache/beam/pull/7042.diff","patch_url":"https://github.com/apache/beam/pull/7042.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/7042","number":7042,"state":"open","locked":false,"title":"[BEAM-6058] Publish gRPC 1.13.1 as a vendored dependency.","user":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"body":"For vendored artifacts, this change\r\n* adds license headers and properties related to our project to the pom.xml\r\n* includes the pom.xml and pom.properties in the jar\r\n* adds support for signing\r\n\r\n------------------------\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.\r\n - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\nIt will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.\r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-11-14T20:48:31Z","updated_at":"2018-11-15T02:56:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cca0d83944908aaeb39eac5896daaceae868dba0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/7042/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/7042/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/7042/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/7ee1700f951cd36b64275c3db89cb9040c533177","head":{"label":"lukecwik:beam6058.2","ref":"beam6058.2","sha":"7ee1700f951cd36b64275c3db89cb9040c533177","user":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"repo":{"id":52895685,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg5NTY4NQ==","name":"incubator-beam","full_name":"lukecwik/incubator-beam","private":false,"owner":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lukecwik/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/lukecwik/incubator-beam","forks_url":"https://api.github.com/repos/lukecwik/incubator-beam/forks","keys_url":"https://api.github.com/repos/lukecwik/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukecwik/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukecwik/incubator-beam/teams","hooks_url":"https://api.github.com/repos/lukecwik/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/lukecwik/incubator-beam/events","assignees_url":"https://api.github.com/repos/lukecwik/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/lukecwik/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/lukecwik/incubator-beam/tags","blobs_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukecwik/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/lukecwik/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/lukecwik/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/lukecwik/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/lukecwik/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/lukecwik/incubator-beam/subscription","commits_url":"https://api.github.com/repos/lukecwik/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukecwik/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukecwik/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/lukecwik/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukecwik/incubator-beam/merges","archive_url":"https://api.github.com/repos/lukecwik/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukecwik/incubator-beam/downloads","issues_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/lukecwik/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/lukecwik/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/lukecwik/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukecwik/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/lukecwik/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/lukecwik/incubator-beam/deployments","created_at":"2016-03-01T17:24:29Z","updated_at":"2018-07-25T19:58:13Z","pushed_at":"2018-11-14T23:17:57Z","git_url":"git://github.com/lukecwik/incubator-beam.git","ssh_url":"git@github.com:lukecwik/incubator-beam.git","clone_url":"https://github.com/lukecwik/incubator-beam.git","svn_url":"https://github.com/lukecwik/incubator-beam","homepage":null,"size":110703,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8eef97c3c8eb7a06e6d6711276b0a76fd1065f30","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-11-15T02:00:29Z","pushed_at":"2018-11-15T02:20:48Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":111458,"stargazers_count":2319,"watchers_count":2319,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1446,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1446,"open_issues":86,"watchers":2319,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/7042"},"html":{"href":"https://github.com/apache/beam/pull/7042"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/7042"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/7042/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/7042/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/7042/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/7ee1700f951cd36b64275c3db89cb9040c533177"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lukecwik"}}