{"action":"created","issue":{"url":"https://api.github.com/repos/tensorlayer/tensorlayer/issues/640","repository_url":"https://api.github.com/repos/tensorlayer/tensorlayer","labels_url":"https://api.github.com/repos/tensorlayer/tensorlayer/issues/640/labels{/name}","comments_url":"https://api.github.com/repos/tensorlayer/tensorlayer/issues/640/comments","events_url":"https://api.github.com/repos/tensorlayer/tensorlayer/issues/640/events","html_url":"https://github.com/tensorlayer/tensorlayer/pull/640","id":324604313,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5MTcyNzMy","number":640,"title":"[WIP] Fix Issue #561 - Convolution Support NCHW","user":{"login":"2wins","id":12285405,"node_id":"MDQ6VXNlcjEyMjg1NDA1","avatar_url":"https://avatars0.githubusercontent.com/u/12285405?v=4","gravatar_id":"","url":"https://api.github.com/users/2wins","html_url":"https://github.com/2wins","followers_url":"https://api.github.com/users/2wins/followers","following_url":"https://api.github.com/users/2wins/following{/other_user}","gists_url":"https://api.github.com/users/2wins/gists{/gist_id}","starred_url":"https://api.github.com/users/2wins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2wins/subscriptions","organizations_url":"https://api.github.com/users/2wins/orgs","repos_url":"https://api.github.com/users/2wins/repos","events_url":"https://api.github.com/users/2wins/events{/privacy}","received_events_url":"https://api.github.com/users/2wins/received_events","type":"User","site_admin":false},"labels":[{"id":933852280,"node_id":"MDU6TGFiZWw5MzM4NTIyODA=","url":"https://api.github.com/repos/tensorlayer/tensorlayer/labels/awaiting_response","name":"awaiting_response","color":"421a99","default":false},{"id":389085656,"node_id":"MDU6TGFiZWwzODkwODU2NTY=","url":"https://api.github.com/repos/tensorlayer/tensorlayer/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":927920186,"node_id":"MDU6TGFiZWw5Mjc5MjAxODY=","url":"https://api.github.com/repos/tensorlayer/tensorlayer/labels/feature_request","name":"feature_request","color":"e6d747","default":false},{"id":933852863,"node_id":"MDU6TGFiZWw5MzM4NTI4NjM=","url":"https://api.github.com/repos/tensorlayer/tensorlayer/labels/stale","name":"stale","color":"fcbd1e","default":false}],"state":"open","locked":false,"assignee":{"login":"DEKHTIARJonathan","id":10923599,"node_id":"MDQ6VXNlcjEwOTIzNTk5","avatar_url":"https://avatars2.githubusercontent.com/u/10923599?v=4","gravatar_id":"","url":"https://api.github.com/users/DEKHTIARJonathan","html_url":"https://github.com/DEKHTIARJonathan","followers_url":"https://api.github.com/users/DEKHTIARJonathan/followers","following_url":"https://api.github.com/users/DEKHTIARJonathan/following{/other_user}","gists_url":"https://api.github.com/users/DEKHTIARJonathan/gists{/gist_id}","starred_url":"https://api.github.com/users/DEKHTIARJonathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DEKHTIARJonathan/subscriptions","organizations_url":"https://api.github.com/users/DEKHTIARJonathan/orgs","repos_url":"https://api.github.com/users/DEKHTIARJonathan/repos","events_url":"https://api.github.com/users/DEKHTIARJonathan/events{/privacy}","received_events_url":"https://api.github.com/users/DEKHTIARJonathan/received_events","type":"User","site_admin":false},"assignees":[{"login":"DEKHTIARJonathan","id":10923599,"node_id":"MDQ6VXNlcjEwOTIzNTk5","avatar_url":"https://avatars2.githubusercontent.com/u/10923599?v=4","gravatar_id":"","url":"https://api.github.com/users/DEKHTIARJonathan","html_url":"https://github.com/DEKHTIARJonathan","followers_url":"https://api.github.com/users/DEKHTIARJonathan/followers","following_url":"https://api.github.com/users/DEKHTIARJonathan/following{/other_user}","gists_url":"https://api.github.com/users/DEKHTIARJonathan/gists{/gist_id}","starred_url":"https://api.github.com/users/DEKHTIARJonathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DEKHTIARJonathan/subscriptions","organizations_url":"https://api.github.com/users/DEKHTIARJonathan/orgs","repos_url":"https://api.github.com/users/DEKHTIARJonathan/repos","events_url":"https://api.github.com/users/DEKHTIARJonathan/events{/privacy}","received_events_url":"https://api.github.com/users/DEKHTIARJonathan/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/tensorlayer/tensorlayer/milestones/1","html_url":"https://github.com/tensorlayer/tensorlayer/milestone/1","labels_url":"https://api.github.com/repos/tensorlayer/tensorlayer/milestones/1/labels","id":3273276,"node_id":"MDk6TWlsZXN0b25lMzI3MzI3Ng==","number":1,"title":"1.8.6","description":"","creator":{"login":"DEKHTIARJonathan","id":10923599,"node_id":"MDQ6VXNlcjEwOTIzNTk5","avatar_url":"https://avatars2.githubusercontent.com/u/10923599?v=4","gravatar_id":"","url":"https://api.github.com/users/DEKHTIARJonathan","html_url":"https://github.com/DEKHTIARJonathan","followers_url":"https://api.github.com/users/DEKHTIARJonathan/followers","following_url":"https://api.github.com/users/DEKHTIARJonathan/following{/other_user}","gists_url":"https://api.github.com/users/DEKHTIARJonathan/gists{/gist_id}","starred_url":"https://api.github.com/users/DEKHTIARJonathan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DEKHTIARJonathan/subscriptions","organizations_url":"https://api.github.com/users/DEKHTIARJonathan/orgs","repos_url":"https://api.github.com/users/DEKHTIARJonathan/repos","events_url":"https://api.github.com/users/DEKHTIARJonathan/events{/privacy}","received_events_url":"https://api.github.com/users/DEKHTIARJonathan/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":15,"state":"open","created_at":"2018-04-17T09:35:38Z","updated_at":"2018-06-01T14:59:34Z","due_on":null,"closed_at":null},"comments":21,"created_at":"2018-05-19T05:52:43Z","updated_at":"2018-09-29T12:09:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/tensorlayer/tensorlayer/pulls/640","html_url":"https://github.com/tensorlayer/tensorlayer/pull/640","diff_url":"https://github.com/tensorlayer/tensorlayer/pull/640.diff","patch_url":"https://github.com/tensorlayer/tensorlayer/pull/640.patch"},"body":"<!-- ============================================================================================================\r\nThanks for contributing to _TensorLayer_! We really appreciate your help !\r\nBefore you submit your pull request, please make sure to check the following boxes by putting an x in the [ ] \r\n============================================================================================================= -->\r\n\r\n### Checklist\r\n- [x] I've tested that my changes are compatible with the latest version of TensorFlow.\r\n- [x] I've read the [Contribution Guidelines](https://github.com/tensorlayer/tensorlayer/blob/master/CONTRIBUTING.md)\r\n- [ ] I've updated the documentation if necessary.\r\n\r\n### Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n<!--- Please describe in detail how you tested your changes. --->\r\nIssue #561 \r\n\r\n### Description\r\n<!--- Describe your changes in detail -->\r\n- [x] `Conv1dLayer`\r\n- [x] `Conv2dLayer`\r\n- [ ] `DeConv2dLayer`\r\n- [x] `Conv3dLayer`\r\n- [ ] `DeConv3dLayer`\r\n- [ ] `UpSampling2dLayer`\r\n- [ ] `DownSampling2dLayer`\r\n- [ ] `DeformableConv2d`\r\n- [ ] `AtrousConv1dLayer`\r\n- [ ] `AtrousConv2dLayer`\r\n- [ ] `deconv2d_bilinear_upsampling_initializer`\r\n- [x] `Conv1d`\r\n- [x] `Conv2d`\r\n- [ ] `DeConv2d`\r\n- [ ] `DeConv3d`\r\n- [ ] `DepthwiseConv2d`\r\n- [ ] `SeparableConv1d`\r\n- [ ] `SeparableConv2d`\r\n- [ ] `GroupConv2d` "},"comment":{"url":"https://api.github.com/repos/tensorlayer/tensorlayer/issues/comments/425640070","html_url":"https://github.com/tensorlayer/tensorlayer/pull/640#issuecomment-425640070","issue_url":"https://api.github.com/repos/tensorlayer/tensorlayer/issues/640","id":425640070,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTY0MDA3MA==","user":{"login":"2wins","id":12285405,"node_id":"MDQ6VXNlcjEyMjg1NDA1","avatar_url":"https://avatars0.githubusercontent.com/u/12285405?v=4","gravatar_id":"","url":"https://api.github.com/users/2wins","html_url":"https://github.com/2wins","followers_url":"https://api.github.com/users/2wins/followers","following_url":"https://api.github.com/users/2wins/following{/other_user}","gists_url":"https://api.github.com/users/2wins/gists{/gist_id}","starred_url":"https://api.github.com/users/2wins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2wins/subscriptions","organizations_url":"https://api.github.com/users/2wins/orgs","repos_url":"https://api.github.com/users/2wins/repos","events_url":"https://api.github.com/users/2wins/events{/privacy}","received_events_url":"https://api.github.com/users/2wins/received_events","type":"User","site_admin":false},"created_at":"2018-09-29T12:09:09Z","updated_at":"2018-09-29T12:09:09Z","author_association":"CONTRIBUTOR","body":"> @DEKHTIARJonathan Actually, if we want to provide two kinds of `data_format`s, then we allow users use consistent arguments e.g. only `channel_last/first` instead of `NCHW/NHCW`, or both of them. At that time, string mapping techniques are needed. (Some convs in TF take `channel_last/first` while others do `NCHW/NHCW`)\r\n> If we only support the argument `channel_last` (`NHWC`), we don't need such processing because a user don't put an argument into it and we just handle `data_format` internally.\r\n\r\n\r\n\r\n> @DEKHTIARJonathan As seen in the @zsdonghao 's last comment, we can handle this issue by removing `data_format` and just using the argument set to `channels_last` internally.\r\n\r\n@DEKHTIARJonathan, @zsdonghao As I said before, many conv layers are inconsistent in terms of argument `data_format`. Some of them take `NCHW/NHWC` and others do `channels_first/channels_last`. Meanwhile, some do not have `data_format` and process features (tensors) in a `NHWC/channels_last` way internally. We have to discuss it."}}
{"actor":{"display_login":"2wins"}}