{"action":"created","issue":{"url":"https://api.github.com/repos/storybooks/storybook/issues/4430","repository_url":"https://api.github.com/repos/storybooks/storybook","labels_url":"https://api.github.com/repos/storybooks/storybook/issues/4430/labels{/name}","comments_url":"https://api.github.com/repos/storybooks/storybook/issues/4430/comments","events_url":"https://api.github.com/repos/storybooks/storybook/issues/4430/events","html_url":"https://github.com/storybooks/storybook/issues/4430","id":370181243,"node_id":"MDU6SXNzdWUzNzAxODEyNDM=","number":4430,"title":"@storybook/angular has dependencies that should be peerDependencies","user":{"login":"kroeder","id":5478899,"node_id":"MDQ6VXNlcjU0Nzg4OTk=","avatar_url":"https://avatars1.githubusercontent.com/u/5478899?v=4","gravatar_id":"","url":"https://api.github.com/users/kroeder","html_url":"https://github.com/kroeder","followers_url":"https://api.github.com/users/kroeder/followers","following_url":"https://api.github.com/users/kroeder/following{/other_user}","gists_url":"https://api.github.com/users/kroeder/gists{/gist_id}","starred_url":"https://api.github.com/users/kroeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroeder/subscriptions","organizations_url":"https://api.github.com/users/kroeder/orgs","repos_url":"https://api.github.com/users/kroeder/repos","events_url":"https://api.github.com/users/kroeder/events{/privacy}","received_events_url":"https://api.github.com/users/kroeder/received_events","type":"User","site_admin":false},"labels":[{"id":642055226,"node_id":"MDU6TGFiZWw2NDIwNTUyMjY=","url":"https://api.github.com/repos/storybooks/storybook/labels/app:%20angular","name":"app: angular","color":"f9d0c4","default":false},{"id":589411025,"node_id":"MDU6TGFiZWw1ODk0MTEwMjU=","url":"https://api.github.com/repos/storybooks/storybook/labels/babel%20/%20webpack","name":"babel / webpack","color":"fbca04","default":false},{"id":820606800,"node_id":"MDU6TGFiZWw4MjA2MDY4MDA=","url":"https://api.github.com/repos/storybooks/storybook/labels/core","name":"core","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-15T14:08:22Z","updated_at":"2018-10-16T16:20:09Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"### Bug or support request summary\r\n\r\nAfter updating my storybook to `alpha.25` I got a strange error from webpack. After some investigations I found out that `webpack-sources` was installed twice, by \r\n- `@angular-devkit/build-angular@0.7.1` => `webpack-sources@1.1.0 `\r\n- `@storybook/angular@4.0.0-alpha.25` => `webpack-sources@1.3.0`\r\n\r\nThis mostly is because my local `@angular` / `webpack` version differs from the one's storybook is requiring.\r\n\r\n**Edit:** this throws an error in `build-storybook` and prevents building it.\r\n\r\n### Steps to reproduce\r\n- Install `\"@angular-devkit/build-angular\": \"~0.7.1\",`\r\n- Install `@storybook/angular@4.0.0-alpha.25`\r\n- Try to build storybook / or `npm ll webpack-sources`\r\n\r\n### Please specify which version of Storybook and optionally any affected addons that you're running\r\n\r\n```\r\n    \"@storybook/addon-actions\": \"4.0.0-alpha.25\",\r\n    \"@storybook/addon-knobs\": \"4.0.0-alpha.25\",\r\n    \"@storybook/addon-links\": \"4.0.0-alpha.25\",\r\n    \"@storybook/addon-notes\": \"4.0.0-alpha.25\",\r\n    \"@storybook/addon-options\": \"4.0.0-alpha.25\",\r\n    \"@storybook/addon-storysource\": \"4.0.0-alpha.25\",\r\n    \"@storybook/addons\": \"4.0.0-alpha.25\",\r\n    \"@storybook/angular\": \"4.0.0-alpha.25\",\r\n```\r\n\r\n### Work summary\r\n\r\nI'd strongly recommend to set `webpack` as a peerDependency since `@angular-devkit/build-angular` has already a dependency on webpack.\r\n\r\nAlso, `@storybook/angular` is strongly bound to the webpack stuff in angular.\r\n\r\n### Who to contact\r\n\r\n@igor-dv what do you think? In order to fix this in our project I would've to push versions around to match exactly storybooks dependencies. I find this odd tbh\r\n"},"comment":{"url":"https://api.github.com/repos/storybooks/storybook/issues/comments/430302129","html_url":"https://github.com/storybooks/storybook/issues/4430#issuecomment-430302129","issue_url":"https://api.github.com/repos/storybooks/storybook/issues/4430","id":430302129,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDMwMjEyOQ==","user":{"login":"igor-dv","id":7867954,"node_id":"MDQ6VXNlcjc4Njc5NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7867954?v=4","gravatar_id":"","url":"https://api.github.com/users/igor-dv","html_url":"https://github.com/igor-dv","followers_url":"https://api.github.com/users/igor-dv/followers","following_url":"https://api.github.com/users/igor-dv/following{/other_user}","gists_url":"https://api.github.com/users/igor-dv/gists{/gist_id}","starred_url":"https://api.github.com/users/igor-dv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igor-dv/subscriptions","organizations_url":"https://api.github.com/users/igor-dv/orgs","repos_url":"https://api.github.com/users/igor-dv/repos","events_url":"https://api.github.com/users/igor-dv/events{/privacy}","received_events_url":"https://api.github.com/users/igor-dv/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T16:20:09Z","updated_at":"2018-10-16T16:20:09Z","author_association":"MEMBER","body":"But hypothetically, if we were able to extract every webpack related code to something like `@storybook/preset-webpack`, then we were able to have:\r\n\r\n- `@storybook/preset-webpack@3` \r\n- `@storybook/preset-webpack@4` \r\n- `@storybook/preset-webpack@pikachu` \r\n\r\n"}}
{"actor":{"display_login":"igor-dv"}}