{"action":"created","comment":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/177021523","pull_request_review_id":106821140,"id":177021523,"diff_hunk":"@@ -163,41 +147,42 @@ private void updateCounter(RMEvent event) {\n      * @param filter\n      * @return rmInitialState where all the events bigger than 'filter'\n      */\n-    public RMInitialState cloneAndFilter(long filter) {\n-        long actualFilter;\n-        if (filter <= latestCounter.get()) {\n-            actualFilter = filter;\n+    public RMStateDTO cloneAndFilter(long filter) {\n+        long actualFilter = computeActualFilter(filter);\n+\n+        final List<RMEvent> responseEvents = events.getSortedItems()\n+                                                   .tailSet(new RMEvent(actualFilter + 1)) // because tailSet returns event which is equal or greater","path":"rm/rm-client/src/main/java/org/ow2/proactive/resourcemanager/common/event/RMInitialState.java","position":169,"original_position":169,"commit_id":"3e4c3e0b657ff31286ce78d2885e457678dd4d76","original_commit_id":"3e4c3e0b657ff31286ce78d2885e457678dd4d76","user":{"login":"jrochas","id":10711209,"avatar_url":"https://avatars3.githubusercontent.com/u/10711209?v=4","gravatar_id":"","url":"https://api.github.com/users/jrochas","html_url":"https://github.com/jrochas","followers_url":"https://api.github.com/users/jrochas/followers","following_url":"https://api.github.com/users/jrochas/following{/other_user}","gists_url":"https://api.github.com/users/jrochas/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochas/subscriptions","organizations_url":"https://api.github.com/users/jrochas/orgs","repos_url":"https://api.github.com/users/jrochas/repos","events_url":"https://api.github.com/users/jrochas/events{/privacy}","received_events_url":"https://api.github.com/users/jrochas/received_events","type":"User","site_admin":false},"body":"Instead of adding one here, we could make computeActualFilter return already the value that includes the first element of the tailSet.","created_at":"2018-03-26T09:03:08Z","updated_at":"2018-03-26T09:03:08Z","html_url":"https://github.com/ow2-proactive/scheduling/pull/3172#discussion_r177021523","pull_request_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments/177021523"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/3172#discussion_r177021523"},"pull_request":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3172"}}},"pull_request":{"url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3172","id":177082872,"html_url":"https://github.com/ow2-proactive/scheduling/pull/3172","diff_url":"https://github.com/ow2-proactive/scheduling/pull/3172.diff","patch_url":"https://github.com/ow2-proactive/scheduling/pull/3172.patch","issue_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3172","number":3172,"state":"open","locked":false,"title":"Second attemp to unfreeze rm portal","user":{"login":"Mykhailenko","id":761558,"avatar_url":"https://avatars3.githubusercontent.com/u/761558?v=4","gravatar_id":"","url":"https://api.github.com/users/Mykhailenko","html_url":"https://github.com/Mykhailenko","followers_url":"https://api.github.com/users/Mykhailenko/followers","following_url":"https://api.github.com/users/Mykhailenko/following{/other_user}","gists_url":"https://api.github.com/users/Mykhailenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Mykhailenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mykhailenko/subscriptions","organizations_url":"https://api.github.com/users/Mykhailenko/orgs","repos_url":"https://api.github.com/users/Mykhailenko/repos","events_url":"https://api.github.com/users/Mykhailenko/events{/privacy}","received_events_url":"https://api.github.com/users/Mykhailenko/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-23T14:17:48Z","updated_at":"2018-03-26T09:03:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbffe4df46b9552b7c70a608c421d346f9537ad0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3172/commits","review_comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3172/comments","review_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3172/comments","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/3e4c3e0b657ff31286ce78d2885e457678dd4d76","head":{"label":"Mykhailenko:second-attemp-unfreeze-rm","ref":"second-attemp-unfreeze-rm","sha":"3e4c3e0b657ff31286ce78d2885e457678dd4d76","user":{"login":"Mykhailenko","id":761558,"avatar_url":"https://avatars3.githubusercontent.com/u/761558?v=4","gravatar_id":"","url":"https://api.github.com/users/Mykhailenko","html_url":"https://github.com/Mykhailenko","followers_url":"https://api.github.com/users/Mykhailenko/followers","following_url":"https://api.github.com/users/Mykhailenko/following{/other_user}","gists_url":"https://api.github.com/users/Mykhailenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Mykhailenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mykhailenko/subscriptions","organizations_url":"https://api.github.com/users/Mykhailenko/orgs","repos_url":"https://api.github.com/users/Mykhailenko/repos","events_url":"https://api.github.com/users/Mykhailenko/events{/privacy}","received_events_url":"https://api.github.com/users/Mykhailenko/received_events","type":"User","site_admin":false},"repo":{"id":107121787,"name":"scheduling","full_name":"Mykhailenko/scheduling","owner":{"login":"Mykhailenko","id":761558,"avatar_url":"https://avatars3.githubusercontent.com/u/761558?v=4","gravatar_id":"","url":"https://api.github.com/users/Mykhailenko","html_url":"https://github.com/Mykhailenko","followers_url":"https://api.github.com/users/Mykhailenko/followers","following_url":"https://api.github.com/users/Mykhailenko/following{/other_user}","gists_url":"https://api.github.com/users/Mykhailenko/gists{/gist_id}","starred_url":"https://api.github.com/users/Mykhailenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mykhailenko/subscriptions","organizations_url":"https://api.github.com/users/Mykhailenko/orgs","repos_url":"https://api.github.com/users/Mykhailenko/repos","events_url":"https://api.github.com/users/Mykhailenko/events{/privacy}","received_events_url":"https://api.github.com/users/Mykhailenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mykhailenko/scheduling","description":"Multi-platform Scheduling and Workflows Engine","fork":true,"url":"https://api.github.com/repos/Mykhailenko/scheduling","forks_url":"https://api.github.com/repos/Mykhailenko/scheduling/forks","keys_url":"https://api.github.com/repos/Mykhailenko/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mykhailenko/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mykhailenko/scheduling/teams","hooks_url":"https://api.github.com/repos/Mykhailenko/scheduling/hooks","issue_events_url":"https://api.github.com/repos/Mykhailenko/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/Mykhailenko/scheduling/events","assignees_url":"https://api.github.com/repos/Mykhailenko/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/Mykhailenko/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/Mykhailenko/scheduling/tags","blobs_url":"https://api.github.com/repos/Mykhailenko/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mykhailenko/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mykhailenko/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mykhailenko/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mykhailenko/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/Mykhailenko/scheduling/languages","stargazers_url":"https://api.github.com/repos/Mykhailenko/scheduling/stargazers","contributors_url":"https://api.github.com/repos/Mykhailenko/scheduling/contributors","subscribers_url":"https://api.github.com/repos/Mykhailenko/scheduling/subscribers","subscription_url":"https://api.github.com/repos/Mykhailenko/scheduling/subscription","commits_url":"https://api.github.com/repos/Mykhailenko/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mykhailenko/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mykhailenko/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mykhailenko/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mykhailenko/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/Mykhailenko/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mykhailenko/scheduling/merges","archive_url":"https://api.github.com/repos/Mykhailenko/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mykhailenko/scheduling/downloads","issues_url":"https://api.github.com/repos/Mykhailenko/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/Mykhailenko/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/Mykhailenko/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/Mykhailenko/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mykhailenko/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/Mykhailenko/scheduling/releases{/id}","deployments_url":"https://api.github.com/repos/Mykhailenko/scheduling/deployments","created_at":"2017-10-16T12:04:11Z","updated_at":"2017-10-16T12:04:19Z","pushed_at":"2018-03-23T15:55:25Z","git_url":"git://github.com/Mykhailenko/scheduling.git","ssh_url":"git@github.com:Mykhailenko/scheduling.git","clone_url":"https://github.com/Mykhailenko/scheduling.git","svn_url":"https://github.com/Mykhailenko/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":72824,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ow2-proactive:master","ref":"master","sha":"c572054971d7ffb944bc6fd19f25cde692f9a66c","user":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"repo":{"id":35725079,"name":"scheduling","full_name":"ow2-proactive/scheduling","owner":{"login":"ow2-proactive","id":11553998,"avatar_url":"https://avatars1.githubusercontent.com/u/11553998?v=4","gravatar_id":"","url":"https://api.github.com/users/ow2-proactive","html_url":"https://github.com/ow2-proactive","followers_url":"https://api.github.com/users/ow2-proactive/followers","following_url":"https://api.github.com/users/ow2-proactive/following{/other_user}","gists_url":"https://api.github.com/users/ow2-proactive/gists{/gist_id}","starred_url":"https://api.github.com/users/ow2-proactive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ow2-proactive/subscriptions","organizations_url":"https://api.github.com/users/ow2-proactive/orgs","repos_url":"https://api.github.com/users/ow2-proactive/repos","events_url":"https://api.github.com/users/ow2-proactive/events{/privacy}","received_events_url":"https://api.github.com/users/ow2-proactive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ow2-proactive/scheduling","description":"Multi-platform Scheduling and Workflows Engine","fork":false,"url":"https://api.github.com/repos/ow2-proactive/scheduling","forks_url":"https://api.github.com/repos/ow2-proactive/scheduling/forks","keys_url":"https://api.github.com/repos/ow2-proactive/scheduling/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ow2-proactive/scheduling/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ow2-proactive/scheduling/teams","hooks_url":"https://api.github.com/repos/ow2-proactive/scheduling/hooks","issue_events_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/events{/number}","events_url":"https://api.github.com/repos/ow2-proactive/scheduling/events","assignees_url":"https://api.github.com/repos/ow2-proactive/scheduling/assignees{/user}","branches_url":"https://api.github.com/repos/ow2-proactive/scheduling/branches{/branch}","tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/tags","blobs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/refs{/sha}","trees_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/{sha}","languages_url":"https://api.github.com/repos/ow2-proactive/scheduling/languages","stargazers_url":"https://api.github.com/repos/ow2-proactive/scheduling/stargazers","contributors_url":"https://api.github.com/repos/ow2-proactive/scheduling/contributors","subscribers_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscribers","subscription_url":"https://api.github.com/repos/ow2-proactive/scheduling/subscription","commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/commits{/sha}","git_commits_url":"https://api.github.com/repos/ow2-proactive/scheduling/git/commits{/sha}","comments_url":"https://api.github.com/repos/ow2-proactive/scheduling/comments{/number}","issue_comment_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues/comments{/number}","contents_url":"https://api.github.com/repos/ow2-proactive/scheduling/contents/{+path}","compare_url":"https://api.github.com/repos/ow2-proactive/scheduling/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ow2-proactive/scheduling/merges","archive_url":"https://api.github.com/repos/ow2-proactive/scheduling/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ow2-proactive/scheduling/downloads","issues_url":"https://api.github.com/repos/ow2-proactive/scheduling/issues{/number}","pulls_url":"https://api.github.com/repos/ow2-proactive/scheduling/pulls{/number}","milestones_url":"https://api.github.com/repos/ow2-proactive/scheduling/milestones{/number}","notifications_url":"https://api.github.com/repos/ow2-proactive/scheduling/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ow2-proactive/scheduling/labels{/name}","releases_url":"https://api.github.com/repos/ow2-proactive/scheduling/releases{/id}","deployments_url":"https://api.github.com/repos/ow2-proactive/scheduling/deployments","created_at":"2015-05-16T13:38:55Z","updated_at":"2018-03-22T09:59:53Z","pushed_at":"2018-03-26T01:30:16Z","git_url":"git://github.com/ow2-proactive/scheduling.git","ssh_url":"git@github.com:ow2-proactive/scheduling.git","clone_url":"https://github.com/ow2-proactive/scheduling.git","svn_url":"https://github.com/ow2-proactive/scheduling","homepage":"http://www.activeeon.com/workflows-scheduling","size":73337,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":168,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0"},"forks":39,"open_issues":168,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3172"},"html":{"href":"https://github.com/ow2-proactive/scheduling/pull/3172"},"issue":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3172"},"comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/issues/3172/comments"},"review_comments":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3172/comments"},"review_comment":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/pulls/3172/commits"},"statuses":{"href":"https://api.github.com/repos/ow2-proactive/scheduling/statuses/3e4c3e0b657ff31286ce78d2885e457678dd4d76"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jrochas"}}