{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/244581716","pull_request_review_id":188492850,"id":244581716,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU4MTcxNg==","diff_hunk":"@@ -171,6 +171,7 @@ typedef enum {\n \tSTREAM_CRYPTO_METHOD_TLSv1_0_CLIENT = (1 << 3 | 1),\n \tSTREAM_CRYPTO_METHOD_TLSv1_1_CLIENT = (1 << 4 | 1),\n \tSTREAM_CRYPTO_METHOD_TLSv1_2_CLIENT = (1 << 5 | 1),\n+\tSTREAM_CRYPTO_METHOD_TLSv1_3_CLIENT = (1 << 6 | 1),\n \t/* TLS equates to TLS_ANY as of PHP 7.2 */\n \tSTREAM_CRYPTO_METHOD_TLS_CLIENT = ((1 << 3) | (1 << 4) | (1 << 5) | 1),\n \tSTREAM_CRYPTO_METHOD_TLS_ANY_CLIENT = ((1 << 3) | (1 << 4) | (1 << 5) | 1),","path":"main/streams/php_stream_transport.h","position":7,"original_position":7,"commit_id":"741ff7ae5d4adbbf3e2a909a402fb29d46be35d0","original_commit_id":"741ff7ae5d4adbbf3e2a909a402fb29d46be35d0","user":{"login":"kelunik","id":2743004,"node_id":"MDQ6VXNlcjI3NDMwMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2743004?v=4","gravatar_id":"","url":"https://api.github.com/users/kelunik","html_url":"https://github.com/kelunik","followers_url":"https://api.github.com/users/kelunik/followers","following_url":"https://api.github.com/users/kelunik/following{/other_user}","gists_url":"https://api.github.com/users/kelunik/gists{/gist_id}","starred_url":"https://api.github.com/users/kelunik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelunik/subscriptions","organizations_url":"https://api.github.com/users/kelunik/orgs","repos_url":"https://api.github.com/users/kelunik/repos","events_url":"https://api.github.com/users/kelunik/events{/privacy}","received_events_url":"https://api.github.com/users/kelunik/received_events","type":"User","site_admin":false},"body":"These generic constants for any version need to include TLS v1.3, too.","created_at":"2018-12-31T12:45:58Z","updated_at":"2018-12-31T12:45:58Z","html_url":"https://github.com/php/php-src/pull/3700#discussion_r244581716","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/3700","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/244581716"},"html":{"href":"https://github.com/php/php-src/pull/3700#discussion_r244581716"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/3700"}}},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/3700","id":236043020,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDQzMDIw","html_url":"https://github.com/php/php-src/pull/3700","diff_url":"https://github.com/php/php-src/pull/3700.diff","patch_url":"https://github.com/php/php-src/pull/3700.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/3700","number":3700,"state":"open","locked":false,"title":"[Patch v2] Added tls 1.3 support for PHP","user":{"login":"codarrenvelvindron","id":4686416,"node_id":"MDQ6VXNlcjQ2ODY0MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4686416?v=4","gravatar_id":"","url":"https://api.github.com/users/codarrenvelvindron","html_url":"https://github.com/codarrenvelvindron","followers_url":"https://api.github.com/users/codarrenvelvindron/followers","following_url":"https://api.github.com/users/codarrenvelvindron/following{/other_user}","gists_url":"https://api.github.com/users/codarrenvelvindron/gists{/gist_id}","starred_url":"https://api.github.com/users/codarrenvelvindron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codarrenvelvindron/subscriptions","organizations_url":"https://api.github.com/users/codarrenvelvindron/orgs","repos_url":"https://api.github.com/users/codarrenvelvindron/repos","events_url":"https://api.github.com/users/codarrenvelvindron/events{/privacy}","received_events_url":"https://api.github.com/users/codarrenvelvindron/received_events","type":"User","site_admin":false},"body":"Compiled/Tested php with openssl 1.1.1/1.1.0 official\r\nThis is a clean version of original(in sync with current) with all changes made according to review by @bukka : \r\nOriginal: https://github.com/php/php-src/pull/3650\r\n\r\n- Added tls 1.3 support for php\r\n- Added/Updated test files\r\n\r\nRan make tests - OK\r\nWork done during IETF 103 hackathon\r\n\r\n~ codarren at cyberstorm.mu ~","created_at":"2018-12-05T04:29:27Z","updated_at":"2018-12-31T12:45:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a2e78a46aa0d443d8cec2a3f96435eba6a081e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":148912334,"node_id":"MDU6TGFiZWwxNDg5MTIzMzQ=","url":"https://api.github.com/repos/php/php-src/labels/Enhancement","name":"Enhancement","color":"bfe5bf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/3700/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/3700/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/3700/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/741ff7ae5d4adbbf3e2a909a402fb29d46be35d0","head":{"label":"codarrenvelvindron:master","ref":"master","sha":"741ff7ae5d4adbbf3e2a909a402fb29d46be35d0","user":{"login":"codarrenvelvindron","id":4686416,"node_id":"MDQ6VXNlcjQ2ODY0MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4686416?v=4","gravatar_id":"","url":"https://api.github.com/users/codarrenvelvindron","html_url":"https://github.com/codarrenvelvindron","followers_url":"https://api.github.com/users/codarrenvelvindron/followers","following_url":"https://api.github.com/users/codarrenvelvindron/following{/other_user}","gists_url":"https://api.github.com/users/codarrenvelvindron/gists{/gist_id}","starred_url":"https://api.github.com/users/codarrenvelvindron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codarrenvelvindron/subscriptions","organizations_url":"https://api.github.com/users/codarrenvelvindron/orgs","repos_url":"https://api.github.com/users/codarrenvelvindron/repos","events_url":"https://api.github.com/users/codarrenvelvindron/events{/privacy}","received_events_url":"https://api.github.com/users/codarrenvelvindron/received_events","type":"User","site_admin":false},"repo":{"id":160455458,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA0NTU0NTg=","name":"php-src","full_name":"codarrenvelvindron/php-src","private":false,"owner":{"login":"codarrenvelvindron","id":4686416,"node_id":"MDQ6VXNlcjQ2ODY0MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/4686416?v=4","gravatar_id":"","url":"https://api.github.com/users/codarrenvelvindron","html_url":"https://github.com/codarrenvelvindron","followers_url":"https://api.github.com/users/codarrenvelvindron/followers","following_url":"https://api.github.com/users/codarrenvelvindron/following{/other_user}","gists_url":"https://api.github.com/users/codarrenvelvindron/gists{/gist_id}","starred_url":"https://api.github.com/users/codarrenvelvindron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codarrenvelvindron/subscriptions","organizations_url":"https://api.github.com/users/codarrenvelvindron/orgs","repos_url":"https://api.github.com/users/codarrenvelvindron/repos","events_url":"https://api.github.com/users/codarrenvelvindron/events{/privacy}","received_events_url":"https://api.github.com/users/codarrenvelvindron/received_events","type":"User","site_admin":false},"html_url":"https://github.com/codarrenvelvindron/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/codarrenvelvindron/php-src","forks_url":"https://api.github.com/repos/codarrenvelvindron/php-src/forks","keys_url":"https://api.github.com/repos/codarrenvelvindron/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codarrenvelvindron/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codarrenvelvindron/php-src/teams","hooks_url":"https://api.github.com/repos/codarrenvelvindron/php-src/hooks","issue_events_url":"https://api.github.com/repos/codarrenvelvindron/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/codarrenvelvindron/php-src/events","assignees_url":"https://api.github.com/repos/codarrenvelvindron/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/codarrenvelvindron/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/codarrenvelvindron/php-src/tags","blobs_url":"https://api.github.com/repos/codarrenvelvindron/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codarrenvelvindron/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codarrenvelvindron/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/codarrenvelvindron/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codarrenvelvindron/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/codarrenvelvindron/php-src/languages","stargazers_url":"https://api.github.com/repos/codarrenvelvindron/php-src/stargazers","contributors_url":"https://api.github.com/repos/codarrenvelvindron/php-src/contributors","subscribers_url":"https://api.github.com/repos/codarrenvelvindron/php-src/subscribers","subscription_url":"https://api.github.com/repos/codarrenvelvindron/php-src/subscription","commits_url":"https://api.github.com/repos/codarrenvelvindron/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/codarrenvelvindron/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/codarrenvelvindron/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/codarrenvelvindron/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/codarrenvelvindron/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/codarrenvelvindron/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codarrenvelvindron/php-src/merges","archive_url":"https://api.github.com/repos/codarrenvelvindron/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codarrenvelvindron/php-src/downloads","issues_url":"https://api.github.com/repos/codarrenvelvindron/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/codarrenvelvindron/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/codarrenvelvindron/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/codarrenvelvindron/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codarrenvelvindron/php-src/labels{/name}","releases_url":"https://api.github.com/repos/codarrenvelvindron/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/codarrenvelvindron/php-src/deployments","created_at":"2018-12-05T03:31:32Z","updated_at":"2018-12-10T03:39:20Z","pushed_at":"2018-12-10T03:39:13Z","git_url":"git://github.com/codarrenvelvindron/php-src.git","ssh_url":"git@github.com:codarrenvelvindron/php-src.git","clone_url":"https://github.com/codarrenvelvindron/php-src.git","svn_url":"https://github.com/codarrenvelvindron/php-src","homepage":"http://www.php.net","size":333537,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"a680f4f2be2ae8f6bf40bf9fcb3fac93b60b0b33","user":{"login":"php","id":25158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAzNTIy","name":"php-src","full_name":"php/php-src","private":false,"owner":{"login":"php","id":25158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2018-12-31T11:34:31Z","pushed_at":"2018-12-31T09:25:06Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":335160,"stargazers_count":21122,"watchers_count":21122,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5165,"mirror_url":null,"archived":false,"open_issues_count":165,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5165,"open_issues":165,"watchers":21122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/3700"},"html":{"href":"https://github.com/php/php-src/pull/3700"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/3700"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/3700/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/3700/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/3700/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/741ff7ae5d4adbbf3e2a909a402fb29d46be35d0"}},"author_association":"NONE"}}
{"actor":{"display_login":"kelunik"}}