{"action":"created","comment":{"url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/comments/179593977","pull_request_review_id":109869133,"id":179593977,"diff_hunk":"@@ -719,10 +719,21 @@ def start(self,  # pylint: disable=keyword-arg-before-vararg\n             raise cmdexc.CommandError(\"No URL set for this page yet!\")\n         self._context.args = args\n         self._context.group = group\n-        selector = webelem.SELECTORS[self._context.group]\n+        selector = self._get_selector()\n         self._context.tab.elements.find_css(selector, self._start_cb,\n                                             only_visible=True)\n \n+    def _get_selector(self):\n+        \"\"\"Get the CSS selectors for this url and hinting group.\"\"\"\n+        group = self._context.group\n+        selector = webelem.SELECTORS[group]\n+\n+        url = self._context.baseurl\n+        group_name = webelem.Group(group).name","path":"qutebrowser/browser/hints.py","position":15,"original_position":15,"commit_id":"2e3b54c2d9b2bbbb5155dfb9344694425eb04405","original_commit_id":"2e3b54c2d9b2bbbb5155dfb9344694425eb04405","user":{"login":"jgkamat","id":4349709,"avatar_url":"https://avatars2.githubusercontent.com/u/4349709?v=4","gravatar_id":"","url":"https://api.github.com/users/jgkamat","html_url":"https://github.com/jgkamat","followers_url":"https://api.github.com/users/jgkamat/followers","following_url":"https://api.github.com/users/jgkamat/following{/other_user}","gists_url":"https://api.github.com/users/jgkamat/gists{/gist_id}","starred_url":"https://api.github.com/users/jgkamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgkamat/subscriptions","organizations_url":"https://api.github.com/users/jgkamat/orgs","repos_url":"https://api.github.com/users/jgkamat/repos","events_url":"https://api.github.com/users/jgkamat/events{/privacy}","received_events_url":"https://api.github.com/users/jgkamat/received_events","type":"User","site_admin":false},"body":"Can't this just be `group.name`?","created_at":"2018-04-05T20:40:08Z","updated_at":"2018-04-05T20:43:52Z","html_url":"https://github.com/qutebrowser/qutebrowser/pull/3806#discussion_r179593977","pull_request_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3806","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/comments/179593977"},"html":{"href":"https://github.com/qutebrowser/qutebrowser/pull/3806#discussion_r179593977"},"pull_request":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3806"}}},"pull_request":{"url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3806","id":179107619,"html_url":"https://github.com/qutebrowser/qutebrowser/pull/3806","diff_url":"https://github.com/qutebrowser/qutebrowser/pull/3806.diff","patch_url":"https://github.com/qutebrowser/qutebrowser/pull/3806.patch","issue_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/3806","number":3806,"state":"open","locked":false,"title":"Add hints.selector setting","user":{"login":"olmokramer","id":3612514,"avatar_url":"https://avatars1.githubusercontent.com/u/3612514?v=4","gravatar_id":"","url":"https://api.github.com/users/olmokramer","html_url":"https://github.com/olmokramer","followers_url":"https://api.github.com/users/olmokramer/followers","following_url":"https://api.github.com/users/olmokramer/following{/other_user}","gists_url":"https://api.github.com/users/olmokramer/gists{/gist_id}","starred_url":"https://api.github.com/users/olmokramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olmokramer/subscriptions","organizations_url":"https://api.github.com/users/olmokramer/orgs","repos_url":"https://api.github.com/users/olmokramer/repos","events_url":"https://api.github.com/users/olmokramer/events{/privacy}","received_events_url":"https://api.github.com/users/olmokramer/received_events","type":"User","site_admin":false},"body":"Make it possible for users to configure additional CSS selectors that are used to determine which elements on the page should be hinted. The setting supports patterns, i.e. is configurable on a per-domain basis.\r\n\r\nTODO:\r\n\r\n- [ ] Add tests. Didn't really know where to start though.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/qutebrowser/qutebrowser/3806)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-04-03T13:58:42Z","updated_at":"2018-04-05T20:43:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6098b945dab3b6b379b18222ec21ee93d78a952e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":708435425,"url":"https://api.github.com/repos/qutebrowser/qutebrowser/labels/status:%20needs%20review","name":"status: needs review","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3806/commits","review_comments_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3806/comments","review_comment_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/3806/comments","statuses_url":"https://api.github.com/repos/qutebrowser/qutebrowser/statuses/2e3b54c2d9b2bbbb5155dfb9344694425eb04405","head":{"label":"olmokramer:config-hints-selectors","ref":"config-hints-selectors","sha":"2e3b54c2d9b2bbbb5155dfb9344694425eb04405","user":{"login":"olmokramer","id":3612514,"avatar_url":"https://avatars1.githubusercontent.com/u/3612514?v=4","gravatar_id":"","url":"https://api.github.com/users/olmokramer","html_url":"https://github.com/olmokramer","followers_url":"https://api.github.com/users/olmokramer/followers","following_url":"https://api.github.com/users/olmokramer/following{/other_user}","gists_url":"https://api.github.com/users/olmokramer/gists{/gist_id}","starred_url":"https://api.github.com/users/olmokramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olmokramer/subscriptions","organizations_url":"https://api.github.com/users/olmokramer/orgs","repos_url":"https://api.github.com/users/olmokramer/repos","events_url":"https://api.github.com/users/olmokramer/events{/privacy}","received_events_url":"https://api.github.com/users/olmokramer/received_events","type":"User","site_admin":false},"repo":{"id":124010414,"name":"qutebrowser","full_name":"olmokramer/qutebrowser","owner":{"login":"olmokramer","id":3612514,"avatar_url":"https://avatars1.githubusercontent.com/u/3612514?v=4","gravatar_id":"","url":"https://api.github.com/users/olmokramer","html_url":"https://github.com/olmokramer","followers_url":"https://api.github.com/users/olmokramer/followers","following_url":"https://api.github.com/users/olmokramer/following{/other_user}","gists_url":"https://api.github.com/users/olmokramer/gists{/gist_id}","starred_url":"https://api.github.com/users/olmokramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olmokramer/subscriptions","organizations_url":"https://api.github.com/users/olmokramer/orgs","repos_url":"https://api.github.com/users/olmokramer/repos","events_url":"https://api.github.com/users/olmokramer/events{/privacy}","received_events_url":"https://api.github.com/users/olmokramer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olmokramer/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":true,"url":"https://api.github.com/repos/olmokramer/qutebrowser","forks_url":"https://api.github.com/repos/olmokramer/qutebrowser/forks","keys_url":"https://api.github.com/repos/olmokramer/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olmokramer/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olmokramer/qutebrowser/teams","hooks_url":"https://api.github.com/repos/olmokramer/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/olmokramer/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/olmokramer/qutebrowser/events","assignees_url":"https://api.github.com/repos/olmokramer/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/olmokramer/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/olmokramer/qutebrowser/tags","blobs_url":"https://api.github.com/repos/olmokramer/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olmokramer/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olmokramer/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/olmokramer/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olmokramer/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/olmokramer/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/olmokramer/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/olmokramer/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/olmokramer/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/olmokramer/qutebrowser/subscription","commits_url":"https://api.github.com/repos/olmokramer/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/olmokramer/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/olmokramer/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/olmokramer/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/olmokramer/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/olmokramer/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olmokramer/qutebrowser/merges","archive_url":"https://api.github.com/repos/olmokramer/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olmokramer/qutebrowser/downloads","issues_url":"https://api.github.com/repos/olmokramer/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/olmokramer/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/olmokramer/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/olmokramer/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olmokramer/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/olmokramer/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/olmokramer/qutebrowser/deployments","created_at":"2018-03-06T02:45:33Z","updated_at":"2018-03-06T02:45:37Z","pushed_at":"2018-04-03T21:50:14Z","git_url":"git://github.com/olmokramer/qutebrowser.git","ssh_url":"git@github.com:olmokramer/qutebrowser.git","clone_url":"https://github.com/olmokramer/qutebrowser.git","svn_url":"https://github.com/olmokramer/qutebrowser","homepage":"https://www.qutebrowser.org/","size":31639,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qutebrowser:master","ref":"master","sha":"79823a9a0bb934d92226a8a47ce8830b231ce167","user":{"login":"qutebrowser","id":21955151,"avatar_url":"https://avatars1.githubusercontent.com/u/21955151?v=4","gravatar_id":"","url":"https://api.github.com/users/qutebrowser","html_url":"https://github.com/qutebrowser","followers_url":"https://api.github.com/users/qutebrowser/followers","following_url":"https://api.github.com/users/qutebrowser/following{/other_user}","gists_url":"https://api.github.com/users/qutebrowser/gists{/gist_id}","starred_url":"https://api.github.com/users/qutebrowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutebrowser/subscriptions","organizations_url":"https://api.github.com/users/qutebrowser/orgs","repos_url":"https://api.github.com/users/qutebrowser/repos","events_url":"https://api.github.com/users/qutebrowser/events{/privacy}","received_events_url":"https://api.github.com/users/qutebrowser/received_events","type":"Organization","site_admin":false},"repo":{"id":21244505,"name":"qutebrowser","full_name":"qutebrowser/qutebrowser","owner":{"login":"qutebrowser","id":21955151,"avatar_url":"https://avatars1.githubusercontent.com/u/21955151?v=4","gravatar_id":"","url":"https://api.github.com/users/qutebrowser","html_url":"https://github.com/qutebrowser","followers_url":"https://api.github.com/users/qutebrowser/followers","following_url":"https://api.github.com/users/qutebrowser/following{/other_user}","gists_url":"https://api.github.com/users/qutebrowser/gists{/gist_id}","starred_url":"https://api.github.com/users/qutebrowser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qutebrowser/subscriptions","organizations_url":"https://api.github.com/users/qutebrowser/orgs","repos_url":"https://api.github.com/users/qutebrowser/repos","events_url":"https://api.github.com/users/qutebrowser/events{/privacy}","received_events_url":"https://api.github.com/users/qutebrowser/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qutebrowser/qutebrowser","description":"A keyboard-driven, vim-like browser based on PyQt5.","fork":false,"url":"https://api.github.com/repos/qutebrowser/qutebrowser","forks_url":"https://api.github.com/repos/qutebrowser/qutebrowser/forks","keys_url":"https://api.github.com/repos/qutebrowser/qutebrowser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qutebrowser/qutebrowser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qutebrowser/qutebrowser/teams","hooks_url":"https://api.github.com/repos/qutebrowser/qutebrowser/hooks","issue_events_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/events{/number}","events_url":"https://api.github.com/repos/qutebrowser/qutebrowser/events","assignees_url":"https://api.github.com/repos/qutebrowser/qutebrowser/assignees{/user}","branches_url":"https://api.github.com/repos/qutebrowser/qutebrowser/branches{/branch}","tags_url":"https://api.github.com/repos/qutebrowser/qutebrowser/tags","blobs_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/refs{/sha}","trees_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qutebrowser/qutebrowser/statuses/{sha}","languages_url":"https://api.github.com/repos/qutebrowser/qutebrowser/languages","stargazers_url":"https://api.github.com/repos/qutebrowser/qutebrowser/stargazers","contributors_url":"https://api.github.com/repos/qutebrowser/qutebrowser/contributors","subscribers_url":"https://api.github.com/repos/qutebrowser/qutebrowser/subscribers","subscription_url":"https://api.github.com/repos/qutebrowser/qutebrowser/subscription","commits_url":"https://api.github.com/repos/qutebrowser/qutebrowser/commits{/sha}","git_commits_url":"https://api.github.com/repos/qutebrowser/qutebrowser/git/commits{/sha}","comments_url":"https://api.github.com/repos/qutebrowser/qutebrowser/comments{/number}","issue_comment_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/comments{/number}","contents_url":"https://api.github.com/repos/qutebrowser/qutebrowser/contents/{+path}","compare_url":"https://api.github.com/repos/qutebrowser/qutebrowser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qutebrowser/qutebrowser/merges","archive_url":"https://api.github.com/repos/qutebrowser/qutebrowser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qutebrowser/qutebrowser/downloads","issues_url":"https://api.github.com/repos/qutebrowser/qutebrowser/issues{/number}","pulls_url":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls{/number}","milestones_url":"https://api.github.com/repos/qutebrowser/qutebrowser/milestones{/number}","notifications_url":"https://api.github.com/repos/qutebrowser/qutebrowser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qutebrowser/qutebrowser/labels{/name}","releases_url":"https://api.github.com/repos/qutebrowser/qutebrowser/releases{/id}","deployments_url":"https://api.github.com/repos/qutebrowser/qutebrowser/deployments","created_at":"2014-06-26T14:59:34Z","updated_at":"2018-04-05T18:14:21Z","pushed_at":"2018-04-05T15:26:13Z","git_url":"git://github.com/qutebrowser/qutebrowser.git","ssh_url":"git@github.com:qutebrowser/qutebrowser.git","clone_url":"https://github.com/qutebrowser/qutebrowser.git","svn_url":"https://github.com/qutebrowser/qutebrowser","homepage":"https://www.qutebrowser.org/","size":33433,"stargazers_count":3233,"watchers_count":3233,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":449,"mirror_url":null,"archived":false,"open_issues_count":565,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":449,"open_issues":565,"watchers":3233,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3806"},"html":{"href":"https://github.com/qutebrowser/qutebrowser/pull/3806"},"issue":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/3806"},"comments":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/issues/3806/comments"},"review_comments":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3806/comments"},"review_comment":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/pulls/3806/commits"},"statuses":{"href":"https://api.github.com/repos/qutebrowser/qutebrowser/statuses/2e3b54c2d9b2bbbb5155dfb9344694425eb04405"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jgkamat"}}