{"action":"created","issue":{"url":"https://api.github.com/repos/linkedin/ambry/issues/1039","repository_url":"https://api.github.com/repos/linkedin/ambry","labels_url":"https://api.github.com/repos/linkedin/ambry/issues/1039/labels{/name}","comments_url":"https://api.github.com/repos/linkedin/ambry/issues/1039/comments","events_url":"https://api.github.com/repos/linkedin/ambry/issues/1039/events","html_url":"https://github.com/linkedin/ambry/pull/1039","id":354413135,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTgwNzY5","number":1039,"title":"Make server detect Disk_Unavailable correctly","user":{"login":"jsjtzyy","id":20885933,"node_id":"MDQ6VXNlcjIwODg1OTMz","avatar_url":"https://avatars2.githubusercontent.com/u/20885933?v=4","gravatar_id":"","url":"https://api.github.com/users/jsjtzyy","html_url":"https://github.com/jsjtzyy","followers_url":"https://api.github.com/users/jsjtzyy/followers","following_url":"https://api.github.com/users/jsjtzyy/following{/other_user}","gists_url":"https://api.github.com/users/jsjtzyy/gists{/gist_id}","starred_url":"https://api.github.com/users/jsjtzyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsjtzyy/subscriptions","organizations_url":"https://api.github.com/users/jsjtzyy/orgs","repos_url":"https://api.github.com/users/jsjtzyy/repos","events_url":"https://api.github.com/users/jsjtzyy/events{/privacy}","received_events_url":"https://api.github.com/users/jsjtzyy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jsjtzyy","id":20885933,"node_id":"MDQ6VXNlcjIwODg1OTMz","avatar_url":"https://avatars2.githubusercontent.com/u/20885933?v=4","gravatar_id":"","url":"https://api.github.com/users/jsjtzyy","html_url":"https://github.com/jsjtzyy","followers_url":"https://api.github.com/users/jsjtzyy/followers","following_url":"https://api.github.com/users/jsjtzyy/following{/other_user}","gists_url":"https://api.github.com/users/jsjtzyy/gists{/gist_id}","starred_url":"https://api.github.com/users/jsjtzyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsjtzyy/subscriptions","organizations_url":"https://api.github.com/users/jsjtzyy/orgs","repos_url":"https://api.github.com/users/jsjtzyy/repos","events_url":"https://api.github.com/users/jsjtzyy/events{/privacy}","received_events_url":"https://api.github.com/users/jsjtzyy/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsjtzyy","id":20885933,"node_id":"MDQ6VXNlcjIwODg1OTMz","avatar_url":"https://avatars2.githubusercontent.com/u/20885933?v=4","gravatar_id":"","url":"https://api.github.com/users/jsjtzyy","html_url":"https://github.com/jsjtzyy","followers_url":"https://api.github.com/users/jsjtzyy/followers","following_url":"https://api.github.com/users/jsjtzyy/following{/other_user}","gists_url":"https://api.github.com/users/jsjtzyy/gists{/gist_id}","starred_url":"https://api.github.com/users/jsjtzyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsjtzyy/subscriptions","organizations_url":"https://api.github.com/users/jsjtzyy/orgs","repos_url":"https://api.github.com/users/jsjtzyy/repos","events_url":"https://api.github.com/users/jsjtzyy/events{/privacy}","received_events_url":"https://api.github.com/users/jsjtzyy/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-08-27T17:48:59Z","updated_at":"2018-08-27T18:15:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/linkedin/ambry/pulls/1039","html_url":"https://github.com/linkedin/ambry/pull/1039","diff_url":"https://github.com/linkedin/ambry/pull/1039.diff","patch_url":"https://github.com/linkedin/ambry/pull/1039.patch"},"body":"Current code has an issue that server cannot detect its own unavailable disks. To address it, when store is unavailable, server will check all stores on the same disk to determine disk state. If at least one store is available then disk is up, otherwise, mark disk as down.\r\n\r\n./gradlew build && ./gradlew test succeeded."},"comment":{"url":"https://api.github.com/repos/linkedin/ambry/issues/comments/416318135","html_url":"https://github.com/linkedin/ambry/pull/1039#issuecomment-416318135","issue_url":"https://api.github.com/repos/linkedin/ambry/issues/1039","id":416318135,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjMxODEzNQ==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T18:15:49Z","updated_at":"2018-08-27T18:15:49Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/linkedin/ambry/pull/1039?src=pr&el=h1) Report\n> Merging [#1039](https://codecov.io/gh/linkedin/ambry/pull/1039?src=pr&el=desc) into [master](https://codecov.io/gh/linkedin/ambry/commit/b081ce1552eeae1191be6e5739743c91681494fb?src=pr&el=desc) will **increase** coverage by `0.02%`.\n> The diff coverage is `84.61%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/linkedin/ambry/pull/1039/graphs/tree.svg?width=650&token=4qBsOzF9lU&height=150&src=pr)](https://codecov.io/gh/linkedin/ambry/pull/1039?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master    #1039      +/-   ##\n============================================\n+ Coverage     68.31%   68.33%   +0.02%     \n- Complexity     4758     4761       +3     \n============================================\n  Files           379      379              \n  Lines         30189    30212      +23     \n  Branches       3847     3842       -5     \n============================================\n+ Hits          20624    20646      +22     \n- Misses         8524     8528       +4     \n+ Partials       1041     1038       -3\n```\n\n\n| [Impacted Files](https://codecov.io/gh/linkedin/ambry/pull/1039?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...java/com.github.ambry.clustermap/AmbryReplica.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktY2x1c3Rlcm1hcC9zcmMvbWFpbi9qYXZhL2NvbS5naXRodWIuYW1icnkuY2x1c3Rlcm1hcC9BbWJyeVJlcGxpY2EuamF2YQ==) | `94.59% <0%> (-5.41%)` | `21 <0> (ø)` | |\n| [...main/java/com.github.ambry.clustermap/Replica.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktY2x1c3Rlcm1hcC9zcmMvbWFpbi9qYXZhL2NvbS5naXRodWIuYW1icnkuY2x1c3Rlcm1hcC9SZXBsaWNhLmphdmE=) | `67.3% <0%> (-2.7%)` | `18 <0> (ø)` | |\n| [.../com.github.ambry.store/StorageManagerMetrics.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktc3RvcmUvc3JjL21haW4vamF2YS9jb20uZ2l0aHViLmFtYnJ5LnN0b3JlL1N0b3JhZ2VNYW5hZ2VyTWV0cmljcy5qYXZh) | `100% <100%> (ø)` | `6 <1> (+1)` | :arrow_up: |\n| [...in/java/com.github.ambry.store/StorageManager.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktc3RvcmUvc3JjL21haW4vamF2YS9jb20uZ2l0aHViLmFtYnJ5LnN0b3JlL1N0b3JhZ2VNYW5hZ2VyLmphdmE=) | `94.89% <100%> (+0.21%)` | `37 <3> (+3)` | :arrow_up: |\n| [...main/java/com.github.ambry.store/StoreMetrics.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktc3RvcmUvc3JjL21haW4vamF2YS9jb20uZ2l0aHViLmFtYnJ5LnN0b3JlL1N0b3JlTWV0cmljcy5qYXZh) | `100% <100%> (+3.87%)` | `10 <1> (-2)` | :arrow_down: |\n| [.../main/java/com.github.ambry.store/DiskManager.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktc3RvcmUvc3JjL21haW4vamF2YS9jb20uZ2l0aHViLmFtYnJ5LnN0b3JlL0Rpc2tNYW5hZ2VyLmphdmE=) | `86.92% <100%> (+0.53%)` | `42 <4> (+4)` | :arrow_up: |\n| [...in/java/com.github.ambry.server/AmbryRequests.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktc2VydmVyL3NyYy9tYWluL2phdmEvY29tLmdpdGh1Yi5hbWJyeS5zZXJ2ZXIvQW1icnlSZXF1ZXN0cy5qYXZh) | `76.61% <81.81%> (ø)` | `88 <0> (-1)` | :arrow_down: |\n| [.../java/com.github.ambry.router/DeleteOperation.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktcm91dGVyL3NyYy9tYWluL2phdmEvY29tLmdpdGh1Yi5hbWJyeS5yb3V0ZXIvRGVsZXRlT3BlcmF0aW9uLmphdmE=) | `92.19% <0%> (-1.42%)` | `47% <0%> (-1%)` | |\n| [...m.github.ambry.clustermap/HelixClusterManager.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktY2x1c3Rlcm1hcC9zcmMvbWFpbi9qYXZhL2NvbS5naXRodWIuYW1icnkuY2x1c3Rlcm1hcC9IZWxpeENsdXN0ZXJNYW5hZ2VyLmphdmE=) | `92.39% <0%> (-1.13%)` | `33% <0%> (ø)` | |\n| [...in/java/com.github.ambry.store/BlobStoreStats.java](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree#diff-YW1icnktc3RvcmUvc3JjL21haW4vamF2YS9jb20uZ2l0aHViLmFtYnJ5LnN0b3JlL0Jsb2JTdG9yZVN0YXRzLmphdmE=) | `70.62% <0%> (-0.65%)` | `101% <0%> (ø)` | |\n| ... and [3 more](https://codecov.io/gh/linkedin/ambry/pull/1039/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/linkedin/ambry/pull/1039?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/linkedin/ambry/pull/1039?src=pr&el=footer). Last update [b081ce1...9b6fc1c](https://codecov.io/gh/linkedin/ambry/pull/1039?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}