{"action":"created","comment":{"url":"https://api.github.com/repos/Cognifide/aet/pulls/comments/167521171","pull_request_review_id":95740384,"id":167521171,"diff_hunk":"@@ -0,0 +1,82 @@\n+/**\n+ * AET\n+ *\n+ * Copyright (C) 2013 Cognifide Limited\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use this file except\n+ * in compliance with the License. You may obtain a copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+package com.cognifide.aet.worker.drivers.chrome;\n+\n+import com.cognifide.aet.job.api.collector.HttpRequestExecutor;\n+import com.cognifide.aet.job.api.collector.JsErrorLog;\n+import com.cognifide.aet.job.api.collector.ProxyServerWrapper;\n+import com.cognifide.aet.job.api.collector.WebCommunicationWrapper;\n+import com.google.common.collect.Ordering;\n+import java.util.Set;\n+import java.util.TreeSet;\n+import java.util.function.Predicate;\n+import java.util.logging.Level;\n+import java.util.stream.Collectors;\n+import java.util.stream.StreamSupport;\n+import org.openqa.selenium.WebDriver;\n+import org.openqa.selenium.logging.LogEntries;\n+import org.openqa.selenium.logging.LogEntry;\n+import org.openqa.selenium.logging.LogType;\n+\n+public class ChromeCommunicationWrapperImpl implements WebCommunicationWrapper {\n+\n+  private static final LogEntryToJsError LOG_ENTRY_TO_JS_ERROR = new LogEntryToJsError();","path":"core/worker/src/main/java/com/cognifide/aet/worker/drivers/chrome/ChromeCommunicationWrapperImpl.java","position":36,"original_position":36,"commit_id":"cb8b60548077444eb6cae7e49bf35a6e1d0d712c","original_commit_id":"cb8b60548077444eb6cae7e49bf35a6e1d0d712c","user":{"login":"wiiitek","id":5294646,"avatar_url":"https://avatars1.githubusercontent.com/u/5294646?v=4","gravatar_id":"","url":"https://api.github.com/users/wiiitek","html_url":"https://github.com/wiiitek","followers_url":"https://api.github.com/users/wiiitek/followers","following_url":"https://api.github.com/users/wiiitek/following{/other_user}","gists_url":"https://api.github.com/users/wiiitek/gists{/gist_id}","starred_url":"https://api.github.com/users/wiiitek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wiiitek/subscriptions","organizations_url":"https://api.github.com/users/wiiitek/orgs","repos_url":"https://api.github.com/users/wiiitek/repos","events_url":"https://api.github.com/users/wiiitek/events{/privacy}","received_events_url":"https://api.github.com/users/wiiitek/received_events","type":"User","site_admin":false},"body":"Lets change from\r\n\r\n```\r\nprivate static final LogEntryToJsError\r\n```\r\nto\r\n\r\n```\r\nprivate static final Function<LogEntry, JsErrorLog>\r\n```\r\nto use interface in declaration so that it is obvious that `LOG_ENTRY_TO_JS_ERROR` is a function.","created_at":"2018-02-12T10:56:59Z","updated_at":"2018-02-12T10:58:20Z","html_url":"https://github.com/Cognifide/aet/pull/219#discussion_r167521171","pull_request_url":"https://api.github.com/repos/Cognifide/aet/pulls/219","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Cognifide/aet/pulls/comments/167521171"},"html":{"href":"https://github.com/Cognifide/aet/pull/219#discussion_r167521171"},"pull_request":{"href":"https://api.github.com/repos/Cognifide/aet/pulls/219"}}},"pull_request":{"url":"https://api.github.com/repos/Cognifide/aet/pulls/219","id":167620164,"html_url":"https://github.com/Cognifide/aet/pull/219","diff_url":"https://github.com/Cognifide/aet/pull/219.diff","patch_url":"https://github.com/Cognifide/aet/pull/219.patch","issue_url":"https://api.github.com/repos/Cognifide/aet/issues/219","number":219,"state":"open","locked":false,"title":"Chrome selenium grid","user":{"login":"szymon-owczarzak-cognifide","id":25975896,"avatar_url":"https://avatars1.githubusercontent.com/u/25975896?v=4","gravatar_id":"","url":"https://api.github.com/users/szymon-owczarzak-cognifide","html_url":"https://github.com/szymon-owczarzak-cognifide","followers_url":"https://api.github.com/users/szymon-owczarzak-cognifide/followers","following_url":"https://api.github.com/users/szymon-owczarzak-cognifide/following{/other_user}","gists_url":"https://api.github.com/users/szymon-owczarzak-cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/szymon-owczarzak-cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szymon-owczarzak-cognifide/subscriptions","organizations_url":"https://api.github.com/users/szymon-owczarzak-cognifide/orgs","repos_url":"https://api.github.com/users/szymon-owczarzak-cognifide/repos","events_url":"https://api.github.com/users/szymon-owczarzak-cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/szymon-owczarzak-cognifide/received_events","type":"User","site_admin":false},"body":"# ChromeDriver support\r\n\r\n| !BETA FEATURE |\r\n|------------------|\r\n\r\n## Description\r\nWith this feature you will be able to run tests on ChromeDriver trough selenium grid.\r\nNewest ChromeDriver can be found [here](https://sites.google.com/a/chromium.org/chromedriver/).\r\n\r\n## Types of changes\r\n- [x] New configuration available in _Apache Karaf Web Console_ under: _ChromeWebDriverFactory_\r\n\r\n## Required configuration\r\n- [x] Working selenium grid with ChromeDriver nodes. Example node command:\r\n```\r\njava -Dwebdriver.chrome.driver=\"C:\\chromedriver.exe\" \r\n    -jar selenium-server-standalone-3.8.1.jar \r\n    -role node -hub http://192.168.123.100:4444/grid/register\r\n    -browser \"browserName=chrome,version=ANY,platform=WINDOWS,maxInstances=20\" \r\n    -maxSession 20\r\n```\r\n- [x] _ChromeWebDriverFactory_ configured on _Apache Karaf Web Console_. Example configuration:\r\n  - name = _chrome_\r\n  - path = [empty]\r\n  - seleniumGridUrl = _http://localhost:4444/wd/hub_\r\n- [x] _RestProxyManager_ configured on _Apache Karaf Web Console_. Example configuration:\r\n  - server = _192.168.123.100_\r\n  - port = _8080_\r\n  - maxAttempts = _3_\r\n  - attemptsInterval = _50_\r\n- [x] all _CollectorMessageListenerImpl_ configured on _Apache Karaf Web Console_. Example configuration:\r\n  - name = [some name]\r\n  - consumerQueueName = _AET.collectorJobs_\r\n  - producerQueueName = _AET.collectorResults_\r\n  - webDriverName = _chrome_\r\n  - pf = _1_\r\n\r\n## Known issues :warning:\r\n- ChromeDriver takes screenshots only of a viewport of browser not the entire page \r\n\r\n## Checklist:\r\n- [x] My code follows the [code style](https://github.com/Cognifide/aet/blob/master/CONTRIBUTING.md#coding-conventions) of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n\r\n---\r\nI hereby agree to the terms of the AET Contributor License Agreement.","created_at":"2018-02-07T07:52:03Z","updated_at":"2018-02-12T10:58:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22204f927c02f50514d642fd6232dd2e98621709","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cognifide/aet/pulls/219/commits","review_comments_url":"https://api.github.com/repos/Cognifide/aet/pulls/219/comments","review_comment_url":"https://api.github.com/repos/Cognifide/aet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cognifide/aet/issues/219/comments","statuses_url":"https://api.github.com/repos/Cognifide/aet/statuses/cb8b60548077444eb6cae7e49bf35a6e1d0d712c","head":{"label":"Cognifide:chrome-selenium-grid","ref":"chrome-selenium-grid","sha":"cb8b60548077444eb6cae7e49bf35a6e1d0d712c","user":{"login":"Cognifide","id":932257,"avatar_url":"https://avatars3.githubusercontent.com/u/932257?v=4","gravatar_id":"","url":"https://api.github.com/users/Cognifide","html_url":"https://github.com/Cognifide","followers_url":"https://api.github.com/users/Cognifide/followers","following_url":"https://api.github.com/users/Cognifide/following{/other_user}","gists_url":"https://api.github.com/users/Cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/Cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cognifide/subscriptions","organizations_url":"https://api.github.com/users/Cognifide/orgs","repos_url":"https://api.github.com/users/Cognifide/repos","events_url":"https://api.github.com/users/Cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/Cognifide/received_events","type":"Organization","site_admin":false},"repo":{"id":60241390,"name":"aet","full_name":"Cognifide/aet","owner":{"login":"Cognifide","id":932257,"avatar_url":"https://avatars3.githubusercontent.com/u/932257?v=4","gravatar_id":"","url":"https://api.github.com/users/Cognifide","html_url":"https://github.com/Cognifide","followers_url":"https://api.github.com/users/Cognifide/followers","following_url":"https://api.github.com/users/Cognifide/following{/other_user}","gists_url":"https://api.github.com/users/Cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/Cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cognifide/subscriptions","organizations_url":"https://api.github.com/users/Cognifide/orgs","repos_url":"https://api.github.com/users/Cognifide/repos","events_url":"https://api.github.com/users/Cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/Cognifide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cognifide/aet","description":"AET - a system that detects changes on web sites and performs basic page health check","fork":false,"url":"https://api.github.com/repos/Cognifide/aet","forks_url":"https://api.github.com/repos/Cognifide/aet/forks","keys_url":"https://api.github.com/repos/Cognifide/aet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cognifide/aet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cognifide/aet/teams","hooks_url":"https://api.github.com/repos/Cognifide/aet/hooks","issue_events_url":"https://api.github.com/repos/Cognifide/aet/issues/events{/number}","events_url":"https://api.github.com/repos/Cognifide/aet/events","assignees_url":"https://api.github.com/repos/Cognifide/aet/assignees{/user}","branches_url":"https://api.github.com/repos/Cognifide/aet/branches{/branch}","tags_url":"https://api.github.com/repos/Cognifide/aet/tags","blobs_url":"https://api.github.com/repos/Cognifide/aet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cognifide/aet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cognifide/aet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cognifide/aet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cognifide/aet/statuses/{sha}","languages_url":"https://api.github.com/repos/Cognifide/aet/languages","stargazers_url":"https://api.github.com/repos/Cognifide/aet/stargazers","contributors_url":"https://api.github.com/repos/Cognifide/aet/contributors","subscribers_url":"https://api.github.com/repos/Cognifide/aet/subscribers","subscription_url":"https://api.github.com/repos/Cognifide/aet/subscription","commits_url":"https://api.github.com/repos/Cognifide/aet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cognifide/aet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cognifide/aet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cognifide/aet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cognifide/aet/contents/{+path}","compare_url":"https://api.github.com/repos/Cognifide/aet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cognifide/aet/merges","archive_url":"https://api.github.com/repos/Cognifide/aet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cognifide/aet/downloads","issues_url":"https://api.github.com/repos/Cognifide/aet/issues{/number}","pulls_url":"https://api.github.com/repos/Cognifide/aet/pulls{/number}","milestones_url":"https://api.github.com/repos/Cognifide/aet/milestones{/number}","notifications_url":"https://api.github.com/repos/Cognifide/aet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cognifide/aet/labels{/name}","releases_url":"https://api.github.com/repos/Cognifide/aet/releases{/id}","deployments_url":"https://api.github.com/repos/Cognifide/aet/deployments","created_at":"2016-06-02T07:18:24Z","updated_at":"2018-02-02T17:45:51Z","pushed_at":"2018-02-12T10:21:17Z","git_url":"git://github.com/Cognifide/aet.git","ssh_url":"git@github.com:Cognifide/aet.git","clone_url":"https://github.com/Cognifide/aet.git","svn_url":"https://github.com/Cognifide/aet","homepage":"http://cognifide.github.io/aet/","size":28869,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12,"open_issues":35,"watchers":35,"default_branch":"master"}},"base":{"label":"Cognifide:master","ref":"master","sha":"1a55885cf62adfdb121c0408a766b430074b8f82","user":{"login":"Cognifide","id":932257,"avatar_url":"https://avatars3.githubusercontent.com/u/932257?v=4","gravatar_id":"","url":"https://api.github.com/users/Cognifide","html_url":"https://github.com/Cognifide","followers_url":"https://api.github.com/users/Cognifide/followers","following_url":"https://api.github.com/users/Cognifide/following{/other_user}","gists_url":"https://api.github.com/users/Cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/Cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cognifide/subscriptions","organizations_url":"https://api.github.com/users/Cognifide/orgs","repos_url":"https://api.github.com/users/Cognifide/repos","events_url":"https://api.github.com/users/Cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/Cognifide/received_events","type":"Organization","site_admin":false},"repo":{"id":60241390,"name":"aet","full_name":"Cognifide/aet","owner":{"login":"Cognifide","id":932257,"avatar_url":"https://avatars3.githubusercontent.com/u/932257?v=4","gravatar_id":"","url":"https://api.github.com/users/Cognifide","html_url":"https://github.com/Cognifide","followers_url":"https://api.github.com/users/Cognifide/followers","following_url":"https://api.github.com/users/Cognifide/following{/other_user}","gists_url":"https://api.github.com/users/Cognifide/gists{/gist_id}","starred_url":"https://api.github.com/users/Cognifide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cognifide/subscriptions","organizations_url":"https://api.github.com/users/Cognifide/orgs","repos_url":"https://api.github.com/users/Cognifide/repos","events_url":"https://api.github.com/users/Cognifide/events{/privacy}","received_events_url":"https://api.github.com/users/Cognifide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cognifide/aet","description":"AET - a system that detects changes on web sites and performs basic page health check","fork":false,"url":"https://api.github.com/repos/Cognifide/aet","forks_url":"https://api.github.com/repos/Cognifide/aet/forks","keys_url":"https://api.github.com/repos/Cognifide/aet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cognifide/aet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cognifide/aet/teams","hooks_url":"https://api.github.com/repos/Cognifide/aet/hooks","issue_events_url":"https://api.github.com/repos/Cognifide/aet/issues/events{/number}","events_url":"https://api.github.com/repos/Cognifide/aet/events","assignees_url":"https://api.github.com/repos/Cognifide/aet/assignees{/user}","branches_url":"https://api.github.com/repos/Cognifide/aet/branches{/branch}","tags_url":"https://api.github.com/repos/Cognifide/aet/tags","blobs_url":"https://api.github.com/repos/Cognifide/aet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cognifide/aet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cognifide/aet/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cognifide/aet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cognifide/aet/statuses/{sha}","languages_url":"https://api.github.com/repos/Cognifide/aet/languages","stargazers_url":"https://api.github.com/repos/Cognifide/aet/stargazers","contributors_url":"https://api.github.com/repos/Cognifide/aet/contributors","subscribers_url":"https://api.github.com/repos/Cognifide/aet/subscribers","subscription_url":"https://api.github.com/repos/Cognifide/aet/subscription","commits_url":"https://api.github.com/repos/Cognifide/aet/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cognifide/aet/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cognifide/aet/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cognifide/aet/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cognifide/aet/contents/{+path}","compare_url":"https://api.github.com/repos/Cognifide/aet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cognifide/aet/merges","archive_url":"https://api.github.com/repos/Cognifide/aet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cognifide/aet/downloads","issues_url":"https://api.github.com/repos/Cognifide/aet/issues{/number}","pulls_url":"https://api.github.com/repos/Cognifide/aet/pulls{/number}","milestones_url":"https://api.github.com/repos/Cognifide/aet/milestones{/number}","notifications_url":"https://api.github.com/repos/Cognifide/aet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cognifide/aet/labels{/name}","releases_url":"https://api.github.com/repos/Cognifide/aet/releases{/id}","deployments_url":"https://api.github.com/repos/Cognifide/aet/deployments","created_at":"2016-06-02T07:18:24Z","updated_at":"2018-02-02T17:45:51Z","pushed_at":"2018-02-12T10:21:17Z","git_url":"git://github.com/Cognifide/aet.git","ssh_url":"git@github.com:Cognifide/aet.git","clone_url":"https://github.com/Cognifide/aet.git","svn_url":"https://github.com/Cognifide/aet","homepage":"http://cognifide.github.io/aet/","size":28869,"stargazers_count":35,"watchers_count":35,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12,"open_issues":35,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cognifide/aet/pulls/219"},"html":{"href":"https://github.com/Cognifide/aet/pull/219"},"issue":{"href":"https://api.github.com/repos/Cognifide/aet/issues/219"},"comments":{"href":"https://api.github.com/repos/Cognifide/aet/issues/219/comments"},"review_comments":{"href":"https://api.github.com/repos/Cognifide/aet/pulls/219/comments"},"review_comment":{"href":"https://api.github.com/repos/Cognifide/aet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cognifide/aet/pulls/219/commits"},"statuses":{"href":"https://api.github.com/repos/Cognifide/aet/statuses/cb8b60548077444eb6cae7e49bf35a6e1d0d712c"}},"author_association":"NONE"}}
{"actor":{"display_login":"wiiitek"}}