{"action":"created","issue":{"url":"https://api.github.com/repos/aaFn/Bookmark-search-plus-2/issues/3","repository_url":"https://api.github.com/repos/aaFn/Bookmark-search-plus-2","labels_url":"https://api.github.com/repos/aaFn/Bookmark-search-plus-2/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/aaFn/Bookmark-search-plus-2/issues/3/comments","events_url":"https://api.github.com/repos/aaFn/Bookmark-search-plus-2/issues/3/events","html_url":"https://github.com/aaFn/Bookmark-search-plus-2/issues/3","id":295347460,"number":3,"title":"Upon bookmark search result: open web page and tree location V open tree location only","user":{"login":"JohnLukeBentley","id":18357541,"avatar_url":"https://avatars2.githubusercontent.com/u/18357541?v=4","gravatar_id":"","url":"https://api.github.com/users/JohnLukeBentley","html_url":"https://github.com/JohnLukeBentley","followers_url":"https://api.github.com/users/JohnLukeBentley/followers","following_url":"https://api.github.com/users/JohnLukeBentley/following{/other_user}","gists_url":"https://api.github.com/users/JohnLukeBentley/gists{/gist_id}","starred_url":"https://api.github.com/users/JohnLukeBentley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JohnLukeBentley/subscriptions","organizations_url":"https://api.github.com/users/JohnLukeBentley/orgs","repos_url":"https://api.github.com/users/JohnLukeBentley/repos","events_url":"https://api.github.com/users/JohnLukeBentley/events{/privacy}","received_events_url":"https://api.github.com/users/JohnLukeBentley/received_events","type":"User","site_admin":false},"labels":[{"id":827360252,"url":"https://api.github.com/repos/aaFn/Bookmark-search-plus-2/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":{"login":"aaFn","id":36155054,"avatar_url":"https://avatars1.githubusercontent.com/u/36155054?v=4","gravatar_id":"","url":"https://api.github.com/users/aaFn","html_url":"https://github.com/aaFn","followers_url":"https://api.github.com/users/aaFn/followers","following_url":"https://api.github.com/users/aaFn/following{/other_user}","gists_url":"https://api.github.com/users/aaFn/gists{/gist_id}","starred_url":"https://api.github.com/users/aaFn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaFn/subscriptions","organizations_url":"https://api.github.com/users/aaFn/orgs","repos_url":"https://api.github.com/users/aaFn/repos","events_url":"https://api.github.com/users/aaFn/events{/privacy}","received_events_url":"https://api.github.com/users/aaFn/received_events","type":"User","site_admin":false},"assignees":[{"login":"aaFn","id":36155054,"avatar_url":"https://avatars1.githubusercontent.com/u/36155054?v=4","gravatar_id":"","url":"https://api.github.com/users/aaFn","html_url":"https://github.com/aaFn","followers_url":"https://api.github.com/users/aaFn/followers","following_url":"https://api.github.com/users/aaFn/following{/other_user}","gists_url":"https://api.github.com/users/aaFn/gists{/gist_id}","starred_url":"https://api.github.com/users/aaFn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaFn/subscriptions","organizations_url":"https://api.github.com/users/aaFn/orgs","repos_url":"https://api.github.com/users/aaFn/repos","events_url":"https://api.github.com/users/aaFn/events{/privacy}","received_events_url":"https://api.github.com/users/aaFn/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-02-08T00:51:48Z","updated_at":"2018-02-12T02:23:26Z","closed_at":null,"author_association":"NONE","body":"@aaFn wrote (quoting @NicolasWeb intiallly) in #1:\r\n>>  I would love to be able to show parent folders while not having to open the web page of search result bookmark.\r\n>\r\n> Sorry to be so slow gents ... as a matter of fact, you can do it :-)\r\n> \r\n> Simply, click on the search result on left or right of the \"image+text\", where the mouse pointer is an arrow, and not where it is a \"hand with finger\" ... and you'll get what you want.\r\n> Indeed, you'll notice that when you hover the mouse over the result you want to look for, the whole result row is highlighted .. that is to signal to you that you can click anywhere on it and:\r\n> \r\n> - left clicking on a part which is not the link nor the image will simply show where it is in the bookmark pane, no other action,\r\n> - left clicking on the link or image will open it in current tab, and also show the item in the bookmark pane\r\n> - right clicking anywhere in the result will show a context menu to chose where to open the link -> I guess I could add a menu option to \"show bookmark\" also, to make it \"not only one way of doing things\" .. let me know.\r\n> \r\n> By the way, the same behavior occurs for normal bookmarks, clicking outside the link/image simply highlights it with no action, clicking on it opens it in current tab, and right click = context menu ..\r\n\r\nThanks for that explanation. That works fairly well, once explained. \r\n\r\nHowever, if possible it is better to design an interface/system that has clues, or some discoverablity mechanism, that the user can pick up on ... making an explanation unnecessary.\r\n\r\nSo although it is true that there is a sense that your pattern (clicking inside v outside icon+text) is consistent with the native bookmarks tree ... I don't think users learn this pattern from using the native bookmark tree. That is, because it is not quite analogous. \r\n\r\nWhen you use the native bookmark tree:\r\n\r\n* If you click inside the icon+text then you get the web page loaded.\r\n* If you click outside the icon+text then nothing happens. \r\n\r\nWith the second option users are not learning that \"some action happens when I click outside icon+text\". So I don't think you can leverage the way the native bookmark tree works to have users learn about how your BSP2 works.\r\n\r\nAlternative patterns are a creative matter. My personally preferred solution would be to ...\r\n\r\nFirst note that we probably want different behaviour for interacting with a bookmark in the search result window V the tree. Bookmark interaction behaviour in the tree should just follow whatever the native patterns are (as they appear to currently do ... e.g. middle click on a bookmark here loads the web page in a new tab). So this is mostly a matter of what ought be done with bookmarks in the search result window.\r\n\r\nI'd suggest a change to the right click menu of the search results to:\r\n\r\n* **Find in tree**\r\n* Find in tree and open in this tab [Shift + Click]\r\n* Find in tree and open in new tab [Middle Click]\r\n* Find in tree and open in private window\r\n\r\nI'm not necessarily attached to the phrase \"Find in tree\" but at least for our discussion you'll know what is meant. I don't think it is bad phrase, but there might be something better.\r\n\r\nFollowing the Windows pattern the first option is bolded to indicate the default (this is a pattern you currently observe). So the consequence of that is:\r\n\r\n* If a user `LEFT CLICK`s it only executes \"Find in tree\".\r\n* If a user `SHIFT + LEFT CLICK`s this executes  \"Find in tree and open in this tab\".\r\n* If a user `RIGHT CLICK`s this opens the menu (as it does currently in conformance with Windows pattern s) and the above two commands are discoverable.\r\n\r\nIf you implemented the above pattern you wouldn't have to necessarily remove your existing pattern (click inside V outside icon+text), e.g. if you had some particular fondness for your existing pattern. That is, because those two patterns don't interfere with each other.\r\n\r\n@NicolasWeb's view about this would be valueable.\r\n\r\nEdit: Include references to issue #1.\r\n"},"comment":{"url":"https://api.github.com/repos/aaFn/Bookmark-search-plus-2/issues/comments/364815276","html_url":"https://github.com/aaFn/Bookmark-search-plus-2/issues/3#issuecomment-364815276","issue_url":"https://api.github.com/repos/aaFn/Bookmark-search-plus-2/issues/3","id":364815276,"user":{"login":"aaFn","id":36155054,"avatar_url":"https://avatars1.githubusercontent.com/u/36155054?v=4","gravatar_id":"","url":"https://api.github.com/users/aaFn","html_url":"https://github.com/aaFn","followers_url":"https://api.github.com/users/aaFn/followers","following_url":"https://api.github.com/users/aaFn/following{/other_user}","gists_url":"https://api.github.com/users/aaFn/gists{/gist_id}","starred_url":"https://api.github.com/users/aaFn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaFn/subscriptions","organizations_url":"https://api.github.com/users/aaFn/orgs","repos_url":"https://api.github.com/users/aaFn/repos","events_url":"https://api.github.com/users/aaFn/events{/privacy}","received_events_url":"https://api.github.com/users/aaFn/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T02:23:26Z","updated_at":"2018-02-12T02:23:26Z","author_association":"OWNER","body":"@JohnLukeBentley, 2.0.4 is out, with the above defined behavior (repeated below). Let me know if we can close that issue for now, and we should open another one if this is creating more trouble, if you agree.\r\n\r\n1. If a user LEFT CLICKs it should execute \"Find in tree\" always, and additionally \"open page in current tab\" if the user clicked on the image or url link (this is an HTML <a> link) = like today and like on native\r\n2. If a user SHIFT + LEFT CLICKs this should execute \"Find in tree and open in this tab\", wherever he clicks (=> will not have to change if we change 1) for the other option)\r\n3. If a user MIDDLE CLICKs, this should execute \"Find in tree and open in new tab\"\r\n4. If a user RIGHT CLICKs this should open the menu (as it does currently in conformance with Windows patterns) and the above three commands are part of the menu."}}
{"actor":{"display_login":"aaFn"}}