{"action":"created","comment":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/comments/214214548","pull_request_review_id":151223002,"id":214214548,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDIxNDU0OA==","diff_hunk":"@@ -129,6 +129,12 @@ void MDAL::LoaderBinaryDat::load( MDAL::Mesh *mesh, MDAL_Status *status )\n   group->uri = mDatFile;\n   group->isOnVertices = true;\n \n+  // in TUFLOW results there could be also a special timestep (99999) with maximums\n+  // we will put it into a separate dataset\n+  std::shared_ptr<DatasetGroup> groupMax( new DatasetGroup() );","path":"external/mdal/frmts/mdal_binary_dat.cpp","position":6,"original_position":6,"commit_id":"f71089f6008f391365c2780babd876231a2bc6b0","original_commit_id":"f71089f6008f391365c2780babd876231a2bc6b0","user":{"login":"nyalldawson","id":1829991,"node_id":"MDQ6VXNlcjE4Mjk5OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1829991?v=4","gravatar_id":"","url":"https://api.github.com/users/nyalldawson","html_url":"https://github.com/nyalldawson","followers_url":"https://api.github.com/users/nyalldawson/followers","following_url":"https://api.github.com/users/nyalldawson/following{/other_user}","gists_url":"https://api.github.com/users/nyalldawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nyalldawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nyalldawson/subscriptions","organizations_url":"https://api.github.com/users/nyalldawson/orgs","repos_url":"https://api.github.com/users/nyalldawson/repos","events_url":"https://api.github.com/users/nyalldawson/events{/privacy}","received_events_url":"https://api.github.com/users/nyalldawson/received_events","type":"User","site_admin":false},"body":"this should be std::make_shared - but I'll fix in mdal","created_at":"2018-08-31T00:00:32Z","updated_at":"2018-08-31T00:12:35Z","html_url":"https://github.com/qgis/QGIS/pull/7745#discussion_r214214548","pull_request_url":"https://api.github.com/repos/qgis/QGIS/pulls/7745","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments/214214548"},"html":{"href":"https://github.com/qgis/QGIS/pull/7745#discussion_r214214548"},"pull_request":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7745"}}},"pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/7745","id":211700839,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNzAwODM5","html_url":"https://github.com/qgis/QGIS/pull/7745","diff_url":"https://github.com/qgis/QGIS/pull/7745.diff","patch_url":"https://github.com/qgis/QGIS/pull/7745.patch","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/7745","number":7745,"state":"open","locked":false,"title":"[mesh] [feature] Support for different active scalar and vector dataset groups","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"body":"![vectors_contours_mesh](https://user-images.githubusercontent.com/804608/44781565-094f6b80-ab85-11e8-9f2c-7e3ad57591fa.gif)\r\n\r\nheavily inspired by crayfish implementation https://github.com/lutraconsulting/qgis-crayfish-plugin/blob/master/crayfish/gui/dataset_view.py","created_at":"2018-08-29T10:16:53Z","updated_at":"2018-08-31T00:12:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49e78184ebf77f50f8e23b8607bef2caab150025","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":310142278,"node_id":"MDU6TGFiZWwzMTAxNDIyNzg=","url":"https://api.github.com/repos/qgis/QGIS/labels/Feature","name":"Feature","color":"bfd4f2","default":false}],"milestone":{"url":"https://api.github.com/repos/qgis/QGIS/milestones/13","html_url":"https://github.com/qgis/QGIS/milestone/13","labels_url":"https://api.github.com/repos/qgis/QGIS/milestones/13/labels","id":3380708,"node_id":"MDk6TWlsZXN0b25lMzM4MDcwOA==","number":13,"title":"3.4","description":"","creator":{"login":"m-kuhn","id":588407,"node_id":"MDQ6VXNlcjU4ODQwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/588407?v=4","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":243,"state":"open","created_at":"2018-05-28T11:10:30Z","updated_at":"2018-08-30T23:59:41Z","due_on":"2018-10-26T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/qgis/QGIS/pulls/7745/commits","review_comments_url":"https://api.github.com/repos/qgis/QGIS/pulls/7745/comments","review_comment_url":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/7745/comments","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/f71089f6008f391365c2780babd876231a2bc6b0","head":{"label":"PeterPetrik:pp_mesh_groups_gui","ref":"pp_mesh_groups_gui","sha":"f71089f6008f391365c2780babd876231a2bc6b0","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"repo":{"id":38666026,"node_id":"MDEwOlJlcG9zaXRvcnkzODY2NjAyNg==","name":"QGIS","full_name":"PeterPetrik/QGIS","owner":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PeterPetrik/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/PeterPetrik/QGIS","forks_url":"https://api.github.com/repos/PeterPetrik/QGIS/forks","keys_url":"https://api.github.com/repos/PeterPetrik/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeterPetrik/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeterPetrik/QGIS/teams","hooks_url":"https://api.github.com/repos/PeterPetrik/QGIS/hooks","issue_events_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/PeterPetrik/QGIS/events","assignees_url":"https://api.github.com/repos/PeterPetrik/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/PeterPetrik/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/tags","blobs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeterPetrik/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/PeterPetrik/QGIS/languages","stargazers_url":"https://api.github.com/repos/PeterPetrik/QGIS/stargazers","contributors_url":"https://api.github.com/repos/PeterPetrik/QGIS/contributors","subscribers_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscribers","subscription_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscription","commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeterPetrik/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeterPetrik/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/PeterPetrik/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeterPetrik/QGIS/merges","archive_url":"https://api.github.com/repos/PeterPetrik/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeterPetrik/QGIS/downloads","issues_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/PeterPetrik/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/PeterPetrik/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeterPetrik/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/PeterPetrik/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/PeterPetrik/QGIS/deployments","created_at":"2015-07-07T05:24:42Z","updated_at":"2018-08-28T07:20:30Z","pushed_at":"2018-08-29T13:16:48Z","git_url":"git://github.com/PeterPetrik/QGIS.git","ssh_url":"git@github.com:PeterPetrik/QGIS.git","clone_url":"https://github.com/PeterPetrik/QGIS.git","svn_url":"https://github.com/PeterPetrik/QGIS","homepage":"http://qgis.org","size":1386410,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"qgis:master","ref":"master","sha":"e5e14dd68072473ade0f747034b63c6f89d88a1c","user":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"repo":{"id":1690480,"node_id":"MDEwOlJlcG9zaXRvcnkxNjkwNDgw","name":"QGIS","full_name":"qgis/QGIS","owner":{"login":"qgis","id":483444,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4MzQ0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/483444?v=4","gravatar_id":"","url":"https://api.github.com/users/qgis","html_url":"https://github.com/qgis","followers_url":"https://api.github.com/users/qgis/followers","following_url":"https://api.github.com/users/qgis/following{/other_user}","gists_url":"https://api.github.com/users/qgis/gists{/gist_id}","starred_url":"https://api.github.com/users/qgis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qgis/subscriptions","organizations_url":"https://api.github.com/users/qgis/orgs","repos_url":"https://api.github.com/users/qgis/repos","events_url":"https://api.github.com/users/qgis/events{/privacy}","received_events_url":"https://api.github.com/users/qgis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qgis/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":false,"url":"https://api.github.com/repos/qgis/QGIS","forks_url":"https://api.github.com/repos/qgis/QGIS/forks","keys_url":"https://api.github.com/repos/qgis/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qgis/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qgis/QGIS/teams","hooks_url":"https://api.github.com/repos/qgis/QGIS/hooks","issue_events_url":"https://api.github.com/repos/qgis/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/qgis/QGIS/events","assignees_url":"https://api.github.com/repos/qgis/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/qgis/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/qgis/QGIS/tags","blobs_url":"https://api.github.com/repos/qgis/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qgis/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qgis/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/qgis/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qgis/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/qgis/QGIS/languages","stargazers_url":"https://api.github.com/repos/qgis/QGIS/stargazers","contributors_url":"https://api.github.com/repos/qgis/QGIS/contributors","subscribers_url":"https://api.github.com/repos/qgis/QGIS/subscribers","subscription_url":"https://api.github.com/repos/qgis/QGIS/subscription","commits_url":"https://api.github.com/repos/qgis/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/qgis/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/qgis/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/qgis/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/qgis/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/qgis/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qgis/QGIS/merges","archive_url":"https://api.github.com/repos/qgis/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qgis/QGIS/downloads","issues_url":"https://api.github.com/repos/qgis/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/qgis/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/qgis/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/qgis/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qgis/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/qgis/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/qgis/QGIS/deployments","created_at":"2011-05-02T08:06:26Z","updated_at":"2018-08-30T23:59:24Z","pushed_at":"2018-08-30T23:59:17Z","git_url":"git://github.com/qgis/QGIS.git","ssh_url":"git@github.com:qgis/QGIS.git","clone_url":"https://github.com/qgis/QGIS.git","svn_url":"https://github.com/qgis/QGIS","homepage":"http://qgis.org","size":1450272,"stargazers_count":2194,"watchers_count":2194,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1300,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1300,"open_issues":24,"watchers":2194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7745"},"html":{"href":"https://github.com/qgis/QGIS/pull/7745"},"issue":{"href":"https://api.github.com/repos/qgis/QGIS/issues/7745"},"comments":{"href":"https://api.github.com/repos/qgis/QGIS/issues/7745/comments"},"review_comments":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7745/comments"},"review_comment":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qgis/QGIS/pulls/7745/commits"},"statuses":{"href":"https://api.github.com/repos/qgis/QGIS/statuses/f71089f6008f391365c2780babd876231a2bc6b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nyalldawson"}}