{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39925","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39925/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39925/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39925/events","html_url":"https://github.com/NixOS/nixpkgs/pull/39925","id":319924242,"number":39925,"title":"Zabbix-agent 3.4","user":{"login":"Assassinkin","id":20524473,"avatar_url":"https://avatars0.githubusercontent.com/u/20524473?v=4","gravatar_id":"","url":"https://api.github.com/users/Assassinkin","html_url":"https://github.com/Assassinkin","followers_url":"https://api.github.com/users/Assassinkin/followers","following_url":"https://api.github.com/users/Assassinkin/following{/other_user}","gists_url":"https://api.github.com/users/Assassinkin/gists{/gist_id}","starred_url":"https://api.github.com/users/Assassinkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Assassinkin/subscriptions","organizations_url":"https://api.github.com/users/Assassinkin/orgs","repos_url":"https://api.github.com/users/Assassinkin/repos","events_url":"https://api.github.com/users/Assassinkin/events{/privacy}","received_events_url":"https://api.github.com/users/Assassinkin/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":737642408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%200","name":"10.rebuild-linux: 0","color":"eeffee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T13:37:28Z","updated_at":"2018-05-05T05:30:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/39925","html_url":"https://github.com/NixOS/nixpkgs/pull/39925","diff_url":"https://github.com/NixOS/nixpkgs/pull/39925.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/39925.patch"},"body":"###### Motivation for this change\r\nThe latest Zabbix agent offered by Nixpkgs is currently 2.2 which is pretty old, the default package is even older (1.8) which include the agent and the server. I think it is time to move to a newer version of Zabbix. It would be better to merge this pull request thought ( #31123 ) as it include the version 3.4 of the agent and the server in the default.nix package instead of 1.8. If it is preferable to keep the default.nix the way it is, I think my PR can be usefull for people who want to use the 3.4 version of the agent.\r\n\r\nWhen testing I used the following nix expression to make sure to use the 3.4 version instead of the default one:\r\n\r\n```nixpkgs.config.packageOverrides = pkgs: {\r\n     zabbix.agent = pkgs.zabbix34.agent or (lib.overrideDerivation pkgs.zabbix20.agent (a: rec {\r\n       name = \"zabbix-${version}\";\r\n       version = \"3.4.8\";\r\n \r\n       src = pkgs.fetchurl {\r\n         url = \"https://netix.dl.sourceforge.net/project/zabbix/ZABBIX%20Latest%20Stable/${version}/zabbix-${version}.tar.gz\";\r\n         sha256 = \"cec14993d1ec2c9d8c51f6608c9408620f27174db92edc2347bafa7b841ccc07\";\r\n       };\r\n     }));\r\n   };\r\n```\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/386780908","html_url":"https://github.com/NixOS/nixpkgs/pull/39925#issuecomment-386780908","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/39925","id":386780908,"user":{"login":"matthewbauer","id":19036,"avatar_url":"https://avatars0.githubusercontent.com/u/19036?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewbauer","html_url":"https://github.com/matthewbauer","followers_url":"https://api.github.com/users/matthewbauer/followers","following_url":"https://api.github.com/users/matthewbauer/following{/other_user}","gists_url":"https://api.github.com/users/matthewbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewbauer/subscriptions","organizations_url":"https://api.github.com/users/matthewbauer/orgs","repos_url":"https://api.github.com/users/matthewbauer/repos","events_url":"https://api.github.com/users/matthewbauer/events{/privacy}","received_events_url":"https://api.github.com/users/matthewbauer/received_events","type":"User","site_admin":false},"created_at":"2018-05-05T05:30:16Z","updated_at":"2018-05-05T05:30:16Z","author_association":"MEMBER","body":"@Grahamcofborg build zabbix34"}}
{"actor":{"display_login":"matthewbauer"}}