{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/209223800","pull_request_review_id":145196806,"id":209223800,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTIyMzgwMA==","diff_hunk":"@@ -52,9 +52,12 @@ def get_scanner(hass, config):\n             TplinkDeviceScanner, Tplink5DeviceScanner, Tplink4DeviceScanner,\n             Tplink3DeviceScanner, Tplink2DeviceScanner, Tplink1DeviceScanner\n     ]:\n-        scanner = cls(config[DOMAIN])\n-        if scanner.success_init:\n-            return scanner\n+        try:","path":"homeassistant/components/device_tracker/tplink.py","position":7,"original_position":7,"commit_id":"de3333a86dc0d8f6033f02267a9edc7d7ddf7937","original_commit_id":"de3333a86dc0d8f6033f02267a9edc7d7ddf7937","user":{"login":"awarecan","id":7366491,"node_id":"MDQ6VXNlcjczNjY0OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7366491?v=4","gravatar_id":"","url":"https://api.github.com/users/awarecan","html_url":"https://github.com/awarecan","followers_url":"https://api.github.com/users/awarecan/followers","following_url":"https://api.github.com/users/awarecan/following{/other_user}","gists_url":"https://api.github.com/users/awarecan/gists{/gist_id}","starred_url":"https://api.github.com/users/awarecan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awarecan/subscriptions","organizations_url":"https://api.github.com/users/awarecan/orgs","repos_url":"https://api.github.com/users/awarecan/repos","events_url":"https://api.github.com/users/awarecan/events{/privacy}","received_events_url":"https://api.github.com/users/awarecan/received_events","type":"User","site_admin":false},"body":"This try/catch should move into `TplinkDevice[*]Scanner._update_info()`, wrapping `self.tplink_client.get_connected_devices()`","created_at":"2018-08-10T11:05:15Z","updated_at":"2018-08-10T11:08:59Z","html_url":"https://github.com/home-assistant/home-assistant/pull/15918#discussion_r209223800","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15918","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/209223800"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/15918#discussion_r209223800"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15918"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15918","id":207544968,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NTQ0OTY4","html_url":"https://github.com/home-assistant/home-assistant/pull/15918","diff_url":"https://github.com/home-assistant/home-assistant/pull/15918.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/15918.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/15918","number":15918,"state":"open","locked":false,"title":"TpLink Device Tracker Error","user":{"login":"TimBailey-pnk","id":23645404,"node_id":"MDQ6VXNlcjIzNjQ1NDA0","avatar_url":"https://avatars2.githubusercontent.com/u/23645404?v=4","gravatar_id":"","url":"https://api.github.com/users/TimBailey-pnk","html_url":"https://github.com/TimBailey-pnk","followers_url":"https://api.github.com/users/TimBailey-pnk/followers","following_url":"https://api.github.com/users/TimBailey-pnk/following{/other_user}","gists_url":"https://api.github.com/users/TimBailey-pnk/gists{/gist_id}","starred_url":"https://api.github.com/users/TimBailey-pnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimBailey-pnk/subscriptions","organizations_url":"https://api.github.com/users/TimBailey-pnk/orgs","repos_url":"https://api.github.com/users/TimBailey-pnk/repos","events_url":"https://api.github.com/users/TimBailey-pnk/events{/privacy}","received_events_url":"https://api.github.com/users/TimBailey-pnk/received_events","type":"User","site_admin":false},"body":"## Description:\r\nI am a Software developer (C#/NodeJS) and this is my first ever fix for Python code.\r\nI have a TPLink EAP245 Access Point which when I configured the device_tracker was causing a Error setting up platform tplink log entry. On further investigation it seems that the code tries a number of scanners in order to try to get the user list. In my case the scanner that works is the second in the list but it never gets there due to an exception in the first.\r\n\r\nMy fix is to log any errors but just pass so that the next scanner can have a try.\r\nI've run the tests and they all pass locally.\r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [ ] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [ ] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [ ] New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [ ] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-08-10T08:45:15Z","updated_at":"2018-08-10T11:08:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40dc091dd12e4d3ef370946d1f6433309bc09466","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":540056046,"node_id":"MDU6TGFiZWw1NDAwNTYwNDY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20device_tracker","name":"component: device_tracker","color":"ededed","default":false},{"id":451931292,"node_id":"MDU6TGFiZWw0NTE5MzEyOTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":832964196,"node_id":"MDU6TGFiZWw4MzI5NjQxOTY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/small-pr","name":"small-pr","color":"e5bd7e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15918/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15918/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/15918/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/de3333a86dc0d8f6033f02267a9edc7d7ddf7937","head":{"label":"TimBailey-pnk:tplink_device_tracker_error_2","ref":"tplink_device_tracker_error_2","sha":"de3333a86dc0d8f6033f02267a9edc7d7ddf7937","user":{"login":"TimBailey-pnk","id":23645404,"node_id":"MDQ6VXNlcjIzNjQ1NDA0","avatar_url":"https://avatars2.githubusercontent.com/u/23645404?v=4","gravatar_id":"","url":"https://api.github.com/users/TimBailey-pnk","html_url":"https://github.com/TimBailey-pnk","followers_url":"https://api.github.com/users/TimBailey-pnk/followers","following_url":"https://api.github.com/users/TimBailey-pnk/following{/other_user}","gists_url":"https://api.github.com/users/TimBailey-pnk/gists{/gist_id}","starred_url":"https://api.github.com/users/TimBailey-pnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimBailey-pnk/subscriptions","organizations_url":"https://api.github.com/users/TimBailey-pnk/orgs","repos_url":"https://api.github.com/users/TimBailey-pnk/repos","events_url":"https://api.github.com/users/TimBailey-pnk/events{/privacy}","received_events_url":"https://api.github.com/users/TimBailey-pnk/received_events","type":"User","site_admin":false},"repo":{"id":144247886,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyNDc4ODY=","name":"home-assistant","full_name":"TimBailey-pnk/home-assistant","owner":{"login":"TimBailey-pnk","id":23645404,"node_id":"MDQ6VXNlcjIzNjQ1NDA0","avatar_url":"https://avatars2.githubusercontent.com/u/23645404?v=4","gravatar_id":"","url":"https://api.github.com/users/TimBailey-pnk","html_url":"https://github.com/TimBailey-pnk","followers_url":"https://api.github.com/users/TimBailey-pnk/followers","following_url":"https://api.github.com/users/TimBailey-pnk/following{/other_user}","gists_url":"https://api.github.com/users/TimBailey-pnk/gists{/gist_id}","starred_url":"https://api.github.com/users/TimBailey-pnk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimBailey-pnk/subscriptions","organizations_url":"https://api.github.com/users/TimBailey-pnk/orgs","repos_url":"https://api.github.com/users/TimBailey-pnk/repos","events_url":"https://api.github.com/users/TimBailey-pnk/events{/privacy}","received_events_url":"https://api.github.com/users/TimBailey-pnk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TimBailey-pnk/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/TimBailey-pnk/home-assistant","forks_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/forks","keys_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/teams","hooks_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/events","assignees_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/tags","blobs_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/languages","stargazers_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/subscription","commits_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/merges","archive_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/downloads","issues_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/TimBailey-pnk/home-assistant/deployments","created_at":"2018-08-10T06:47:47Z","updated_at":"2018-08-10T06:47:57Z","pushed_at":"2018-08-10T10:37:24Z","git_url":"git://github.com/TimBailey-pnk/home-assistant.git","ssh_url":"git@github.com:TimBailey-pnk/home-assistant.git","clone_url":"https://github.com/TimBailey-pnk/home-assistant.git","svn_url":"https://github.com/TimBailey-pnk/home-assistant","homepage":"https://home-assistant.io","size":85746,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"f98629b8953717e5baa0c5cab3946fd8030f86b9","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-08-10T10:38:11Z","pushed_at":"2018-08-10T10:37:31Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":85748,"stargazers_count":15622,"watchers_count":15622,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4666,"mirror_url":null,"archived":false,"open_issues_count":807,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4666,"open_issues":807,"watchers":15622,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15918"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/15918"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/15918"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/15918/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15918/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/15918/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/de3333a86dc0d8f6033f02267a9edc7d7ddf7937"}},"author_association":"NONE"}}
{"actor":{"display_login":"awarecan"}}