{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/713","repository_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev","labels_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/713/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/713/comments","events_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/713/events","html_url":"https://github.com/mozilla-neutrino/neutrino-dev/issues/713","id":298148103,"number":713,"title":"Scale back default minification in core presets","user":{"login":"timkelty","id":18329,"avatar_url":"https://avatars3.githubusercontent.com/u/18329?v=4","gravatar_id":"","url":"https://api.github.com/users/timkelty","html_url":"https://github.com/timkelty","followers_url":"https://api.github.com/users/timkelty/followers","following_url":"https://api.github.com/users/timkelty/following{/other_user}","gists_url":"https://api.github.com/users/timkelty/gists{/gist_id}","starred_url":"https://api.github.com/users/timkelty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timkelty/subscriptions","organizations_url":"https://api.github.com/users/timkelty/orgs","repos_url":"https://api.github.com/users/timkelty/repos","events_url":"https://api.github.com/users/timkelty/events{/privacy}","received_events_url":"https://api.github.com/users/timkelty/received_events","type":"User","site_admin":false},"labels":[{"id":749140796,"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/labels/breaking%20change","name":"breaking change","color":"f2527f","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-19T02:48:25Z","updated_at":"2018-03-09T15:27:18Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"There have been a number of issues since we began including `@neutrinojs/minify` (minimizing babel, styles, images) in core presets: #678, #673, #700\r\n\r\nMy preference would be to scale back what the core presets do by default, and instead point users to additional middleware they may want to use (image-minify, style-minify).\r\n\r\nThat said - we probably also need to make sure the minify middleware include an `enabled` option (defaulting to `NODE_ENV === 'production'`), so that users could just include them without having to configure them.\r\n\r\nEspecially if we go this route, I'm not convinced theres much value in keeping `@neutrinojs/minify` around. Seems more explicit to have `@neutrinojs/web` include `@neutrinojs/babel-minify` directly, and direct users to include `@neutrinojs/image-minify` and `@neutrinojs/style-minify` if they desire.\r\n\r\nI can work on a PR for v9, but curious to hear what others think first.\r\n\r\n/cc @edmorley @mozilla-neutrino/core-contributors "},"comment":{"url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/comments/371844576","html_url":"https://github.com/mozilla-neutrino/neutrino-dev/issues/713#issuecomment-371844576","issue_url":"https://api.github.com/repos/mozilla-neutrino/neutrino-dev/issues/713","id":371844576,"user":{"login":"timkelty","id":18329,"avatar_url":"https://avatars3.githubusercontent.com/u/18329?v=4","gravatar_id":"","url":"https://api.github.com/users/timkelty","html_url":"https://github.com/timkelty","followers_url":"https://api.github.com/users/timkelty/followers","following_url":"https://api.github.com/users/timkelty/following{/other_user}","gists_url":"https://api.github.com/users/timkelty/gists{/gist_id}","starred_url":"https://api.github.com/users/timkelty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timkelty/subscriptions","organizations_url":"https://api.github.com/users/timkelty/orgs","repos_url":"https://api.github.com/users/timkelty/repos","events_url":"https://api.github.com/users/timkelty/events{/privacy}","received_events_url":"https://api.github.com/users/timkelty/received_events","type":"User","site_admin":false},"created_at":"2018-03-09T15:27:18Z","updated_at":"2018-03-09T15:27:18Z","author_association":"CONTRIBUTOR","body":"@edmorley anything besides what is mentioned here (image/style-minify) you might want considered for removal from web?"}}
{"actor":{"display_login":"timkelty"}}