{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/19841","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/19841/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/19841/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/19841/events","html_url":"https://github.com/openshift/origin/pull/19841","id":326235849,"number":19841,"title":"WIP: rewrite lifecycle hooks executor","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars2.githubusercontent.com/u/44136?v=4","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"labels":[{"id":223051294,"url":"https://api.github.com/repos/openshift/origin/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":686389978,"url":"https://api.github.com/repos/openshift/origin/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":640548662,"url":"https://api.github.com/repos/openshift/origin/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-24T18:18:40Z","updated_at":"2018-05-28T13:59:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/19841","html_url":"https://github.com/openshift/origin/pull/19841","diff_url":"https://github.com/openshift/origin/pull/19841.diff","patch_url":"https://github.com/openshift/origin/pull/19841.patch"},"body":"Deployment configs is a tech debt that keeps giving. The intent of this PR is to simplify the hook pod executor and log reading. It should also separate the tag hook from the pod hook. There are no new features, just refactoring and hopefully less flakes.\r\n\r\nTodo:\r\n\r\n- [ ] write unit tests\r\n- [x] move tagging hook\r\n- [x] stop crazy conversions in `createHookPod()`\r\n- [x] switch deployer to external client\r\n\r\n/cc @tnozicka "},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/392534691","html_url":"https://github.com/openshift/origin/pull/19841#issuecomment-392534691","issue_url":"https://api.github.com/repos/openshift/origin/issues/19841","id":392534691,"user":{"login":"openshift-ci-robot","id":30189103,"avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T13:59:19Z","updated_at":"2018-05-28T13:59:19Z","author_association":"NONE","body":"@mfojtik: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/integration | 4347fd9a9553f123e4fb8b61f58070163d36d637 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19841/test_pull_request_origin_integration/18207/) | `/test integration`\nci/openshift-jenkins/end_to_end | 4347fd9a9553f123e4fb8b61f58070163d36d637 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19841/test_pull_request_origin_end_to_end/13426/) | `/test end_to_end`\nci/openshift-jenkins/gcp | 4347fd9a9553f123e4fb8b61f58070163d36d637 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19841/test_pull_request_origin_extended_conformance_gce/20789/) | `/test gcp`\nci/openshift-jenkins/extended_conformance_install | 4347fd9a9553f123e4fb8b61f58070163d36d637 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19841/test_pull_request_origin_extended_conformance_install/11915/) | `/test extended_conformance_install`\nci/openshift-jenkins/unit | 62bf1228f67e3e65fe649e4824b028e32217014c | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19841/test_pull_request_origin_unit/13474/) | `/test unit`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/19841). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/mfojtik). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/origin/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}