{"action":"created","issue":{"url":"https://api.github.com/repos/ando-khachatryan/Kalah/issues/1","repository_url":"https://api.github.com/repos/ando-khachatryan/Kalah","labels_url":"https://api.github.com/repos/ando-khachatryan/Kalah/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/ando-khachatryan/Kalah/issues/1/comments","events_url":"https://api.github.com/repos/ando-khachatryan/Kalah/issues/1/events","html_url":"https://github.com/ando-khachatryan/Kalah/issues/1","id":317429207,"number":1,"title":"A little confusions in tests","user":{"login":"RubenAshughyan","id":13535887,"avatar_url":"https://avatars1.githubusercontent.com/u/13535887?v=4","gravatar_id":"","url":"https://api.github.com/users/RubenAshughyan","html_url":"https://github.com/RubenAshughyan","followers_url":"https://api.github.com/users/RubenAshughyan/followers","following_url":"https://api.github.com/users/RubenAshughyan/following{/other_user}","gists_url":"https://api.github.com/users/RubenAshughyan/gists{/gist_id}","starred_url":"https://api.github.com/users/RubenAshughyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubenAshughyan/subscriptions","organizations_url":"https://api.github.com/users/RubenAshughyan/orgs","repos_url":"https://api.github.com/users/RubenAshughyan/repos","events_url":"https://api.github.com/users/RubenAshughyan/events{/privacy}","received_events_url":"https://api.github.com/users/RubenAshughyan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-24T23:24:49Z","updated_at":"2018-04-25T06:13:23Z","closed_at":null,"author_association":"NONE","body":"Dear @ando-khachatryan I had some confusions about the tests. Can you please look at them. \r\nThanks\r\n1) test_make_move_9\r\n```\r\nbefore:\r\n   [ 4  2 13  3  0  1]   \r\n0                        0\r\n   [1 2 3 4 5 6]   \r\n\r\nafter:\r\n   [5 3 0 4 1 2]   \r\n1                  1\r\n   [2 3 4 5 6 7]   \r\n```\r\nSo shouldn't it be \r\n`should_be = KalahGame([2, 3, 4, 5, 6, 7], [2, 1, 4, 0, 3, 5], Side.SOUTH, 1, 1)`?\r\ninstead of:\r\n`should_be = KalahGame([2, 3, 0, 5, 6, 7], [2, 1, 4, 0, 3, 5], Side.SOUTH, 0, 6)`\r\n\r\n\r\n\r\n\r\n2) testGameEndCondition1\r\n```\r\nbefore:\r\n   [1 0 0 0 0 0]   \r\n0                  0\r\n   [1 2 1 3 1 4]   \r\n\r\n\r\nafter:\r\n   [0 0 0 0 0 0]   \r\n1                  0\r\n   [1 2 1 3 1 4]   \r\n```\r\nShouldn't it be\r\n`self.assertEqual(finished, False)`\r\n`self.assertEqual(res, -2)`\r\n?\r\n3) testGameEndCondition2\r\n```\r\nbefore:\r\n   [ 4  2 13  3  0  1]   \r\n35                       0\r\n   [1 2 3 4 5 6]   \r\nTurn: North #Stones : 79 \r\n\r\nafter:\r\n   [5 3 0 4 1 2]   \r\n36                 1\r\n   [2 3 4 5 6 7]   \r\nTurn: North #Stones : 79 \r\n```\r\n`2*36 < 79` so shouldn't it be\r\n`self.assertEqual(finished, False)`?\r\n`self.assertEqual(res, -2)`?\r\nsince the game is not finished"},"comment":{"url":"https://api.github.com/repos/ando-khachatryan/Kalah/issues/comments/384171811","html_url":"https://github.com/ando-khachatryan/Kalah/issues/1#issuecomment-384171811","issue_url":"https://api.github.com/repos/ando-khachatryan/Kalah/issues/1","id":384171811,"user":{"login":"ando-khachatryan","id":4376090,"avatar_url":"https://avatars0.githubusercontent.com/u/4376090?v=4","gravatar_id":"","url":"https://api.github.com/users/ando-khachatryan","html_url":"https://github.com/ando-khachatryan","followers_url":"https://api.github.com/users/ando-khachatryan/followers","following_url":"https://api.github.com/users/ando-khachatryan/following{/other_user}","gists_url":"https://api.github.com/users/ando-khachatryan/gists{/gist_id}","starred_url":"https://api.github.com/users/ando-khachatryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ando-khachatryan/subscriptions","organizations_url":"https://api.github.com/users/ando-khachatryan/orgs","repos_url":"https://api.github.com/users/ando-khachatryan/repos","events_url":"https://api.github.com/users/ando-khachatryan/events{/privacy}","received_events_url":"https://api.github.com/users/ando-khachatryan/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T06:13:23Z","updated_at":"2018-04-25T06:13:23Z","author_association":"OWNER","body":"Ruben, have a look at the rules of the game.\r\n1. You don't put a stone in your opponents Kalah.\r\n2. If one of the players has no stones in all their pits, the game is over -- the opponent removes all their stones, puts on his Kalah, and then you count the stones in Kalahs."}}
{"actor":{"display_login":"ando-khachatryan"}}