{"action":"created","issue":{"url":"https://api.github.com/repos/friendica/friendica/issues/5862","repository_url":"https://api.github.com/repos/friendica/friendica","labels_url":"https://api.github.com/repos/friendica/friendica/issues/5862/labels{/name}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/5862/comments","events_url":"https://api.github.com/repos/friendica/friendica/issues/5862/events","html_url":"https://github.com/friendica/friendica/pull/5862","id":368335049,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTM2OTIx","number":5862,"title":"Rename app methods","user":{"login":"nupplaphil","id":379654,"node_id":"MDQ6VXNlcjM3OTY1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/379654?v=4","gravatar_id":"","url":"https://api.github.com/users/nupplaphil","html_url":"https://github.com/nupplaphil","followers_url":"https://api.github.com/users/nupplaphil/followers","following_url":"https://api.github.com/users/nupplaphil/following{/other_user}","gists_url":"https://api.github.com/users/nupplaphil/gists{/gist_id}","starred_url":"https://api.github.com/users/nupplaphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupplaphil/subscriptions","organizations_url":"https://api.github.com/users/nupplaphil/orgs","repos_url":"https://api.github.com/users/nupplaphil/repos","events_url":"https://api.github.com/users/nupplaphil/events{/privacy}","received_events_url":"https://api.github.com/users/nupplaphil/received_events","type":"User","site_admin":false},"labels":[{"id":739003526,"node_id":"MDU6TGFiZWw3MzkwMDM1MjY=","url":"https://api.github.com/repos/friendica/friendica/labels/Enhancement","name":"Enhancement","color":"40ce79","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/friendica/friendica/milestones/14","html_url":"https://github.com/friendica/friendica/milestone/14","labels_url":"https://api.github.com/repos/friendica/friendica/milestones/14/labels","id":3367850,"node_id":"MDk6TWlsZXN0b25lMzM2Nzg1MA==","number":14,"title":"2018.12","description":"","creator":{"login":"tobiasd","id":433490,"node_id":"MDQ6VXNlcjQzMzQ5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/433490?v=4","gravatar_id":"","url":"https://api.github.com/users/tobiasd","html_url":"https://github.com/tobiasd","followers_url":"https://api.github.com/users/tobiasd/followers","following_url":"https://api.github.com/users/tobiasd/following{/other_user}","gists_url":"https://api.github.com/users/tobiasd/gists{/gist_id}","starred_url":"https://api.github.com/users/tobiasd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobiasd/subscriptions","organizations_url":"https://api.github.com/users/tobiasd/orgs","repos_url":"https://api.github.com/users/tobiasd/repos","events_url":"https://api.github.com/users/tobiasd/events{/privacy}","received_events_url":"https://api.github.com/users/tobiasd/received_events","type":"User","site_admin":false},"open_issues":115,"closed_issues":76,"state":"open","created_at":"2018-05-23T06:47:22Z","updated_at":"2018-10-10T12:17:40Z","due_on":"2018-12-02T08:00:00Z","closed_at":null},"comments":11,"created_at":"2018-10-09T18:18:02Z","updated_at":"2018-10-10T12:41:20Z","closed_at":"2018-10-10T12:17:40Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/5862","html_url":"https://github.com/friendica/friendica/pull/5862","diff_url":"https://github.com/friendica/friendica/pull/5862.diff","patch_url":"https://github.com/friendica/friendica/pull/5862.patch"},"body":"I changed the method signatures from a_method_name to aMethodName() for every `App` method.\r\n\r\nIt's one step and the next step is to create some `getVariable()` and `setVariable()` methods for accessing variables from outside.\r\n=> With this encapsulation, it's a progress to mock methods in tests and to increase the OOP-Pattern in Friendica"},"comment":{"url":"https://api.github.com/repos/friendica/friendica/issues/comments/428556174","html_url":"https://github.com/friendica/friendica/pull/5862#issuecomment-428556174","issue_url":"https://api.github.com/repos/friendica/friendica/issues/5862","id":428556174,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODU1NjE3NA==","user":{"login":"AlfredSK","id":3656054,"node_id":"MDQ6VXNlcjM2NTYwNTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3656054?v=4","gravatar_id":"","url":"https://api.github.com/users/AlfredSK","html_url":"https://github.com/AlfredSK","followers_url":"https://api.github.com/users/AlfredSK/followers","following_url":"https://api.github.com/users/AlfredSK/following{/other_user}","gists_url":"https://api.github.com/users/AlfredSK/gists{/gist_id}","starred_url":"https://api.github.com/users/AlfredSK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlfredSK/subscriptions","organizations_url":"https://api.github.com/users/AlfredSK/orgs","repos_url":"https://api.github.com/users/AlfredSK/repos","events_url":"https://api.github.com/users/AlfredSK/events{/privacy}","received_events_url":"https://api.github.com/users/AlfredSK/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T12:41:20Z","updated_at":"2018-10-10T12:41:20Z","author_association":"NONE","body":"````\r\n[10-Oct-2018 12:39:25 UTC] PHP Fatal error:  Uncaught Error: Call to undefined method Friendica\\App::getBaseURL() in /var/www/html/libranet/addon/openstreetmap/openstreetmap.php:54\r\nStack trace:\r\n#0 /var/www/html/libranet/src/Core/Addon.php(309): openstreetmap_alterheader(Object(Friendica\\App), '<div id=\"panel\"...')\r\n#1 /var/www/html/libranet/src/Core/Addon.php(286): Friendica\\Core\\Addon::callSingleHook(Object(Friendica\\App), 'page_header', Array, '<div id=\"panel\"...')\r\n#2 /var/www/html/libranet/src/Content/Nav.php(61): Friendica\\Core\\Addon::callHooks('page_header', '<div id=\"panel\"...')\r\n#3 /var/www/html/libranet/index.php(429): Friendica\\Content\\Nav::build(Object(Friendica\\App))\r\n#4 {main}\r\n  thrown in /var/www/html/libranet/addon/openstreetmap/openstreetmap.php on line 54\r\n````\r\n"}}
{"actor":{"display_login":"AlfredSK"}}