{"action":"created","comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/239502825","pull_request_review_id":182304073,"id":239502825,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTUwMjgyNQ==","diff_hunk":"@@ -53,7 +54,13 @@\n \n    private final Map<SimpleString, Integer> routingNamePositions = new ConcurrentHashMap<>();\n \n-   private final Map<Long, Binding> bindingsMap = new ConcurrentHashMap<>();\n+   private final Map<Long, Binding> bindingsIdMap = new ConcurrentHashMap<>();\n+\n+   /**\n+    * This is the same as bindingsIdMap but indexed on the binding's uniqueName rather than ID. Two maps are\n+    * maintained to speed routing, otherwise we'd have to loop through the bindingsIdMap when routing to an FQQN.\n+    */\n+   private final Map<SimpleString, Binding> bindingsNameMap = new ConcurrentHashMap<>();","path":"artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/BindingsImpl.java","position":19,"original_position":19,"commit_id":"27d7ea59eee90384792c1bd8868715ec44552ede","original_commit_id":"27d7ea59eee90384792c1bd8868715ec44552ede","user":{"login":"jbertram","id":1336948,"node_id":"MDQ6VXNlcjEzMzY5NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1336948?v=4","gravatar_id":"","url":"https://api.github.com/users/jbertram","html_url":"https://github.com/jbertram","followers_url":"https://api.github.com/users/jbertram/followers","following_url":"https://api.github.com/users/jbertram/following{/other_user}","gists_url":"https://api.github.com/users/jbertram/gists{/gist_id}","starred_url":"https://api.github.com/users/jbertram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbertram/subscriptions","organizations_url":"https://api.github.com/users/jbertram/orgs","repos_url":"https://api.github.com/users/jbertram/repos","events_url":"https://api.github.com/users/jbertram/events{/privacy}","received_events_url":"https://api.github.com/users/jbertram/received_events","type":"User","site_admin":false},"body":"Do you mean the same?  I'm not sure I'm following you here.","created_at":"2018-12-06T15:46:08Z","updated_at":"2018-12-06T15:46:09Z","html_url":"https://github.com/apache/activemq-artemis/pull/2434#discussion_r239502825","pull_request_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2434","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments/239502825"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/2434#discussion_r239502825"},"pull_request":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2434"}},"in_reply_to_id":239488173},"pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2434","id":231054995,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDU0OTk1","html_url":"https://github.com/apache/activemq-artemis/pull/2434","diff_url":"https://github.com/apache/activemq-artemis/pull/2434.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/2434.patch","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2434","number":2434,"state":"open","locked":false,"title":"ARTEMIS-1867 FQQN for producers ","user":{"login":"jbertram","id":1336948,"node_id":"MDQ6VXNlcjEzMzY5NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1336948?v=4","gravatar_id":"","url":"https://api.github.com/users/jbertram","html_url":"https://github.com/jbertram","followers_url":"https://api.github.com/users/jbertram/followers","following_url":"https://api.github.com/users/jbertram/following{/other_user}","gists_url":"https://api.github.com/users/jbertram/gists{/gist_id}","starred_url":"https://api.github.com/users/jbertram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbertram/subscriptions","organizations_url":"https://api.github.com/users/jbertram/orgs","repos_url":"https://api.github.com/users/jbertram/repos","events_url":"https://api.github.com/users/jbertram/events{/privacy}","received_events_url":"https://api.github.com/users/jbertram/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-15T03:16:06Z","updated_at":"2018-12-06T15:46:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98b6148e4db4be50522de590ff57a79718afafa3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2434/commits","review_comments_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/2434/comments","review_comment_url":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/2434/comments","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/27d7ea59eee90384792c1bd8868715ec44552ede","head":{"label":"jbertram:ARTEMIS-1867-2","ref":"ARTEMIS-1867-2","sha":"27d7ea59eee90384792c1bd8868715ec44552ede","user":{"login":"jbertram","id":1336948,"node_id":"MDQ6VXNlcjEzMzY5NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1336948?v=4","gravatar_id":"","url":"https://api.github.com/users/jbertram","html_url":"https://github.com/jbertram","followers_url":"https://api.github.com/users/jbertram/followers","following_url":"https://api.github.com/users/jbertram/following{/other_user}","gists_url":"https://api.github.com/users/jbertram/gists{/gist_id}","starred_url":"https://api.github.com/users/jbertram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbertram/subscriptions","organizations_url":"https://api.github.com/users/jbertram/orgs","repos_url":"https://api.github.com/users/jbertram/repos","events_url":"https://api.github.com/users/jbertram/events{/privacy}","received_events_url":"https://api.github.com/users/jbertram/received_events","type":"User","site_admin":false},"repo":{"id":36080809,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA4MDgwOQ==","name":"activemq-artemis","full_name":"jbertram/activemq-artemis","private":false,"owner":{"login":"jbertram","id":1336948,"node_id":"MDQ6VXNlcjEzMzY5NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/1336948?v=4","gravatar_id":"","url":"https://api.github.com/users/jbertram","html_url":"https://github.com/jbertram","followers_url":"https://api.github.com/users/jbertram/followers","following_url":"https://api.github.com/users/jbertram/following{/other_user}","gists_url":"https://api.github.com/users/jbertram/gists{/gist_id}","starred_url":"https://api.github.com/users/jbertram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbertram/subscriptions","organizations_url":"https://api.github.com/users/jbertram/orgs","repos_url":"https://api.github.com/users/jbertram/repos","events_url":"https://api.github.com/users/jbertram/events{/privacy}","received_events_url":"https://api.github.com/users/jbertram/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jbertram/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":true,"url":"https://api.github.com/repos/jbertram/activemq-artemis","forks_url":"https://api.github.com/repos/jbertram/activemq-artemis/forks","keys_url":"https://api.github.com/repos/jbertram/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbertram/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbertram/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/jbertram/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/jbertram/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/jbertram/activemq-artemis/events","assignees_url":"https://api.github.com/repos/jbertram/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/jbertram/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/jbertram/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/jbertram/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbertram/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbertram/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbertram/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbertram/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/jbertram/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/jbertram/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/jbertram/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/jbertram/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/jbertram/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/jbertram/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbertram/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbertram/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbertram/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbertram/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/jbertram/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbertram/activemq-artemis/merges","archive_url":"https://api.github.com/repos/jbertram/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbertram/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/jbertram/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/jbertram/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/jbertram/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/jbertram/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbertram/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/jbertram/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/jbertram/activemq-artemis/deployments","created_at":"2015-05-22T15:50:17Z","updated_at":"2018-06-14T02:59:41Z","pushed_at":"2018-12-05T02:18:39Z","git_url":"git://github.com/jbertram/activemq-artemis.git","ssh_url":"git@github.com:jbertram/activemq-artemis.git","clone_url":"https://github.com/jbertram/activemq-artemis.git","svn_url":"https://github.com/jbertram/activemq-artemis","homepage":"","size":58645,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9d680cc0baf7882d9b216b78c7cd3db73eef39bf","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":36057260,"node_id":"MDEwOlJlcG9zaXRvcnkzNjA1NzI2MA==","name":"activemq-artemis","full_name":"apache/activemq-artemis","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/activemq-artemis","description":"Mirror of Apache ActiveMQ Artemis","fork":false,"url":"https://api.github.com/repos/apache/activemq-artemis","forks_url":"https://api.github.com/repos/apache/activemq-artemis/forks","keys_url":"https://api.github.com/repos/apache/activemq-artemis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/activemq-artemis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/activemq-artemis/teams","hooks_url":"https://api.github.com/repos/apache/activemq-artemis/hooks","issue_events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/events{/number}","events_url":"https://api.github.com/repos/apache/activemq-artemis/events","assignees_url":"https://api.github.com/repos/apache/activemq-artemis/assignees{/user}","branches_url":"https://api.github.com/repos/apache/activemq-artemis/branches{/branch}","tags_url":"https://api.github.com/repos/apache/activemq-artemis/tags","blobs_url":"https://api.github.com/repos/apache/activemq-artemis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/activemq-artemis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/activemq-artemis/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/activemq-artemis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/activemq-artemis/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/activemq-artemis/languages","stargazers_url":"https://api.github.com/repos/apache/activemq-artemis/stargazers","contributors_url":"https://api.github.com/repos/apache/activemq-artemis/contributors","subscribers_url":"https://api.github.com/repos/apache/activemq-artemis/subscribers","subscription_url":"https://api.github.com/repos/apache/activemq-artemis/subscription","commits_url":"https://api.github.com/repos/apache/activemq-artemis/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/activemq-artemis/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/activemq-artemis/contents/{+path}","compare_url":"https://api.github.com/repos/apache/activemq-artemis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/activemq-artemis/merges","archive_url":"https://api.github.com/repos/apache/activemq-artemis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/activemq-artemis/downloads","issues_url":"https://api.github.com/repos/apache/activemq-artemis/issues{/number}","pulls_url":"https://api.github.com/repos/apache/activemq-artemis/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/activemq-artemis/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/activemq-artemis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/activemq-artemis/labels{/name}","releases_url":"https://api.github.com/repos/apache/activemq-artemis/releases{/id}","deployments_url":"https://api.github.com/repos/apache/activemq-artemis/deployments","created_at":"2015-05-22T07:00:05Z","updated_at":"2018-12-06T15:14:33Z","pushed_at":"2018-12-06T15:14:09Z","git_url":"git://github.com/apache/activemq-artemis.git","ssh_url":"git@github.com:apache/activemq-artemis.git","clone_url":"https://github.com/apache/activemq-artemis.git","svn_url":"https://github.com/apache/activemq-artemis","homepage":"","size":56163,"stargazers_count":372,"watchers_count":372,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":396,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":396,"open_issues":42,"watchers":372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2434"},"html":{"href":"https://github.com/apache/activemq-artemis/pull/2434"},"issue":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/2434"},"comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/issues/2434/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2434/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/activemq-artemis/pulls/2434/commits"},"statuses":{"href":"https://api.github.com/repos/apache/activemq-artemis/statuses/27d7ea59eee90384792c1bd8868715ec44552ede"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jbertram"}}