{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments/175007232","pull_request_review_id":104464912,"id":175007232,"diff_hunk":"@@ -174,6 +232,30 @@ def change_bls_key(looper, txnPoolNodeSet,\n     return new_blspk\n \n \n+def sdk_change_bls_key(looper, txnPoolNodeSet,\n+                       node,\n+                       sdk_pool_handle,\n+                       sdk_wallet_steward,\n+                       add_wrong=False,\n+                       new_bls=None):\n+    new_blspk = init_bls_keys(node.keys_dir, node.name)\n+    key_in_txn = new_bls or new_blspk \\\n+        if not add_wrong \\\n+        else base58.b58encode(randomString(128).encode())\n+    node_dest = hexToFriendly(node.nodestack.verhex)\n+    sdk_send_update_node(looper, sdk_wallet_steward,\n+                         sdk_pool_handle,\n+                         node_dest, node.name,\n+                         None, None,\n+                         None, None,\n+                         bls_key=key_in_txn,\n+                         services=None)\n+    waitNodeDataEquality(looper, node, *txnPoolNodeSet[:-1])","path":"plenum/test/bls/helper.py","position":165,"original_position":165,"commit_id":"c4dc58301542e0a98294520cfa04f5d8302ebf82","original_commit_id":"c4dc58301542e0a98294520cfa04f5d8302ebf82","user":{"login":"dsurnin","id":28005170,"avatar_url":"https://avatars2.githubusercontent.com/u/28005170?v=4","gravatar_id":"","url":"https://api.github.com/users/dsurnin","html_url":"https://github.com/dsurnin","followers_url":"https://api.github.com/users/dsurnin/followers","following_url":"https://api.github.com/users/dsurnin/following{/other_user}","gists_url":"https://api.github.com/users/dsurnin/gists{/gist_id}","starred_url":"https://api.github.com/users/dsurnin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsurnin/subscriptions","organizations_url":"https://api.github.com/users/dsurnin/orgs","repos_url":"https://api.github.com/users/dsurnin/repos","events_url":"https://api.github.com/users/dsurnin/events{/privacy}","received_events_url":"https://api.github.com/users/dsurnin/received_events","type":"User","site_admin":false},"body":"you pass some node to the func, it could be any node from txnPoolNodeSet, but to check equality you exclude always the last one.\r\nI think you need to exclude the node you pass to func but not the last one","created_at":"2018-03-16T06:37:21Z","updated_at":"2018-03-16T06:43:56Z","html_url":"https://github.com/hyperledger/indy-plenum/pull/564#discussion_r175007232","pull_request_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/564","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments/175007232"},"html":{"href":"https://github.com/hyperledger/indy-plenum/pull/564#discussion_r175007232"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/564"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/564","id":173375789,"html_url":"https://github.com/hyperledger/indy-plenum/pull/564","diff_url":"https://github.com/hyperledger/indy-plenum/pull/564.diff","patch_url":"https://github.com/hyperledger/indy-plenum/pull/564.patch","issue_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/564","number":564,"state":"open","locked":false,"title":"[INDY-992] Move bls tests to sdk","user":{"login":"ArtObr","id":25934159,"avatar_url":"https://avatars2.githubusercontent.com/u/25934159?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtObr","html_url":"https://github.com/ArtObr","followers_url":"https://api.github.com/users/ArtObr/followers","following_url":"https://api.github.com/users/ArtObr/following{/other_user}","gists_url":"https://api.github.com/users/ArtObr/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtObr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtObr/subscriptions","organizations_url":"https://api.github.com/users/ArtObr/orgs","repos_url":"https://api.github.com/users/ArtObr/repos","events_url":"https://api.github.com/users/ArtObr/events{/privacy}","received_events_url":"https://api.github.com/users/ArtObr/received_events","type":"User","site_admin":false},"body":"Signed-off-by: ArtObr <artemobruchnikov@gmail.com>","created_at":"2018-03-07T07:51:52Z","updated_at":"2018-03-16T06:43:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"016aaffe0684ddd7c3d0d9854d1f33b665cf3040","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/564/commits","review_comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/564/comments","review_comment_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/564/comments","statuses_url":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/c4dc58301542e0a98294520cfa04f5d8302ebf82","head":{"label":"ArtObr:indy-sdk-integration/INDY-992","ref":"indy-sdk-integration/INDY-992","sha":"c4dc58301542e0a98294520cfa04f5d8302ebf82","user":{"login":"ArtObr","id":25934159,"avatar_url":"https://avatars2.githubusercontent.com/u/25934159?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtObr","html_url":"https://github.com/ArtObr","followers_url":"https://api.github.com/users/ArtObr/followers","following_url":"https://api.github.com/users/ArtObr/following{/other_user}","gists_url":"https://api.github.com/users/ArtObr/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtObr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtObr/subscriptions","organizations_url":"https://api.github.com/users/ArtObr/orgs","repos_url":"https://api.github.com/users/ArtObr/repos","events_url":"https://api.github.com/users/ArtObr/events{/privacy}","received_events_url":"https://api.github.com/users/ArtObr/received_events","type":"User","site_admin":false},"repo":{"id":117691801,"name":"indy-plenum","full_name":"ArtObr/indy-plenum","owner":{"login":"ArtObr","id":25934159,"avatar_url":"https://avatars2.githubusercontent.com/u/25934159?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtObr","html_url":"https://github.com/ArtObr","followers_url":"https://api.github.com/users/ArtObr/followers","following_url":"https://api.github.com/users/ArtObr/following{/other_user}","gists_url":"https://api.github.com/users/ArtObr/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtObr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtObr/subscriptions","organizations_url":"https://api.github.com/users/ArtObr/orgs","repos_url":"https://api.github.com/users/ArtObr/repos","events_url":"https://api.github.com/users/ArtObr/events{/privacy}","received_events_url":"https://api.github.com/users/ArtObr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ArtObr/indy-plenum","description":"Plenum Byzantine Fault Tolerant Protocol","fork":true,"url":"https://api.github.com/repos/ArtObr/indy-plenum","forks_url":"https://api.github.com/repos/ArtObr/indy-plenum/forks","keys_url":"https://api.github.com/repos/ArtObr/indy-plenum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArtObr/indy-plenum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArtObr/indy-plenum/teams","hooks_url":"https://api.github.com/repos/ArtObr/indy-plenum/hooks","issue_events_url":"https://api.github.com/repos/ArtObr/indy-plenum/issues/events{/number}","events_url":"https://api.github.com/repos/ArtObr/indy-plenum/events","assignees_url":"https://api.github.com/repos/ArtObr/indy-plenum/assignees{/user}","branches_url":"https://api.github.com/repos/ArtObr/indy-plenum/branches{/branch}","tags_url":"https://api.github.com/repos/ArtObr/indy-plenum/tags","blobs_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArtObr/indy-plenum/statuses/{sha}","languages_url":"https://api.github.com/repos/ArtObr/indy-plenum/languages","stargazers_url":"https://api.github.com/repos/ArtObr/indy-plenum/stargazers","contributors_url":"https://api.github.com/repos/ArtObr/indy-plenum/contributors","subscribers_url":"https://api.github.com/repos/ArtObr/indy-plenum/subscribers","subscription_url":"https://api.github.com/repos/ArtObr/indy-plenum/subscription","commits_url":"https://api.github.com/repos/ArtObr/indy-plenum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArtObr/indy-plenum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArtObr/indy-plenum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArtObr/indy-plenum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArtObr/indy-plenum/contents/{+path}","compare_url":"https://api.github.com/repos/ArtObr/indy-plenum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArtObr/indy-plenum/merges","archive_url":"https://api.github.com/repos/ArtObr/indy-plenum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArtObr/indy-plenum/downloads","issues_url":"https://api.github.com/repos/ArtObr/indy-plenum/issues{/number}","pulls_url":"https://api.github.com/repos/ArtObr/indy-plenum/pulls{/number}","milestones_url":"https://api.github.com/repos/ArtObr/indy-plenum/milestones{/number}","notifications_url":"https://api.github.com/repos/ArtObr/indy-plenum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArtObr/indy-plenum/labels{/name}","releases_url":"https://api.github.com/repos/ArtObr/indy-plenum/releases{/id}","deployments_url":"https://api.github.com/repos/ArtObr/indy-plenum/deployments","created_at":"2018-01-16T14:11:22Z","updated_at":"2018-01-16T14:11:26Z","pushed_at":"2018-03-16T06:15:23Z","git_url":"git://github.com/ArtObr/indy-plenum.git","ssh_url":"git@github.com:ArtObr/indy-plenum.git","clone_url":"https://github.com/ArtObr/indy-plenum.git","svn_url":"https://github.com/ArtObr/indy-plenum","homepage":"","size":7945,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hyperledger:master","ref":"master","sha":"a7ff7f2d97a5f11a745ee316b8e8c010ef3985e9","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":51585028,"name":"indy-plenum","full_name":"hyperledger/indy-plenum","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/indy-plenum","description":"Plenum Byzantine Fault Tolerant Protocol","fork":false,"url":"https://api.github.com/repos/hyperledger/indy-plenum","forks_url":"https://api.github.com/repos/hyperledger/indy-plenum/forks","keys_url":"https://api.github.com/repos/hyperledger/indy-plenum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/indy-plenum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/indy-plenum/teams","hooks_url":"https://api.github.com/repos/hyperledger/indy-plenum/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/indy-plenum/events","assignees_url":"https://api.github.com/repos/hyperledger/indy-plenum/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/indy-plenum/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/indy-plenum/tags","blobs_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/indy-plenum/languages","stargazers_url":"https://api.github.com/repos/hyperledger/indy-plenum/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/indy-plenum/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/indy-plenum/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/indy-plenum/subscription","commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/indy-plenum/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/indy-plenum/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/indy-plenum/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/indy-plenum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/indy-plenum/merges","archive_url":"https://api.github.com/repos/hyperledger/indy-plenum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/indy-plenum/downloads","issues_url":"https://api.github.com/repos/hyperledger/indy-plenum/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/indy-plenum/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/indy-plenum/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/indy-plenum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/indy-plenum/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/indy-plenum/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/indy-plenum/deployments","created_at":"2016-02-12T12:03:16Z","updated_at":"2018-03-15T14:06:47Z","pushed_at":"2018-03-16T06:15:25Z","git_url":"git://github.com/hyperledger/indy-plenum.git","ssh_url":"git@github.com:hyperledger/indy-plenum.git","clone_url":"https://github.com/hyperledger/indy-plenum.git","svn_url":"https://github.com/hyperledger/indy-plenum","homepage":"","size":7911,"stargazers_count":101,"watchers_count":101,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":111,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":111,"open_issues":9,"watchers":101,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/564"},"html":{"href":"https://github.com/hyperledger/indy-plenum/pull/564"},"issue":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/issues/564"},"comments":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/issues/564/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/564/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/pulls/564/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/indy-plenum/statuses/c4dc58301542e0a98294520cfa04f5d8302ebf82"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dsurnin"}}