{"action":"created","comment":{"url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/comments/210074996","pull_request_review_id":146216177,"id":210074996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDA3NDk5Ng==","diff_hunk":"@@ -0,0 +1,55 @@\n+- Start Date: 2018-08-15\r\n+- RFC PR: (leave this empty)\r\n+- Yarn Issue: (leave this empty)\r\n+\r\n+# Summary\r\n+\r\n+Static safety-check for packages\r\n+\r\n+# Motivation\r\n+\r\n+The recent eslint-scope security incident has came as a surprise for many, if not all developers, as very few of us would expect a widely-used package on npm would be `hacked` in such a way.\r\n+\r\n+Although measures must and have be taken in the publishing process both for eslint and npm team, human error and negligence are in its nature unavoidable; Thereof, for the developers to trust and embrace open source packages, actions must also be taken from the package manager's side, which developer interact everyday to download their packages, to provide an extra safety-net from malicious attackers.\r\n+\r\n+The most concerning malware are the ones that steals data, thereof, we need to let developers know if the package they install have the ability to access the internet or not, and it should be up to the developers to decide if it is desired.\r\n+\r\n+# Detailed design\r\n+\r\n+The design is pretty straightforward:\r\n+\r\n+Any network access would end up in requiring certain node modules or using certain browser api, therefore, it should not be difficult to do static analyses of those packages and provide basic safety check as for whether those packages requires those modules and/or calls those globals.\r","path":"accepted/0000-static-safety-check.md","position":21,"original_position":21,"commit_id":"ad28c9ddfe4da8ab6e6ce10152a5a8f27b47403f","original_commit_id":"ad28c9ddfe4da8ab6e6ce10152a5a8f27b47403f","user":{"login":"arcanis","id":1037931,"node_id":"MDQ6VXNlcjEwMzc5MzE=","avatar_url":"https://avatars2.githubusercontent.com/u/1037931?v=4","gravatar_id":"","url":"https://api.github.com/users/arcanis","html_url":"https://github.com/arcanis","followers_url":"https://api.github.com/users/arcanis/followers","following_url":"https://api.github.com/users/arcanis/following{/other_user}","gists_url":"https://api.github.com/users/arcanis/gists{/gist_id}","starred_url":"https://api.github.com/users/arcanis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arcanis/subscriptions","organizations_url":"https://api.github.com/users/arcanis/orgs","repos_url":"https://api.github.com/users/arcanis/repos","events_url":"https://api.github.com/users/arcanis/events{/privacy}","received_events_url":"https://api.github.com/users/arcanis/received_events","type":"User","site_admin":false},"body":"Not sure the implementation cost would be that low. Also consider that such a measure would be pointless unless followed by the ecosystem. And the ecosystem would only follow it if it actually worked. So imo, any solution will have to be designed to be the silver bullet and solve all the use cases from the very beginning.","created_at":"2018-08-14T19:26:18Z","updated_at":"2018-08-14T19:26:19Z","html_url":"https://github.com/yarnpkg/rfcs/pull/96#discussion_r210074996","pull_request_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/96","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/comments/210074996"},"html":{"href":"https://github.com/yarnpkg/rfcs/pull/96#discussion_r210074996"},"pull_request":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/96"}},"in_reply_to_id":210063560},"pull_request":{"url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/96","id":208370672,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzcwNjcy","html_url":"https://github.com/yarnpkg/rfcs/pull/96","diff_url":"https://github.com/yarnpkg/rfcs/pull/96.diff","patch_url":"https://github.com/yarnpkg/rfcs/pull/96.patch","issue_url":"https://api.github.com/repos/yarnpkg/rfcs/issues/96","number":96,"state":"open","locked":false,"title":"Proposal to provide package safety check","user":{"login":"viztor","id":3511050,"node_id":"MDQ6VXNlcjM1MTEwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3511050?v=4","gravatar_id":"","url":"https://api.github.com/users/viztor","html_url":"https://github.com/viztor","followers_url":"https://api.github.com/users/viztor/followers","following_url":"https://api.github.com/users/viztor/following{/other_user}","gists_url":"https://api.github.com/users/viztor/gists{/gist_id}","starred_url":"https://api.github.com/users/viztor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viztor/subscriptions","organizations_url":"https://api.github.com/users/viztor/orgs","repos_url":"https://api.github.com/users/viztor/repos","events_url":"https://api.github.com/users/viztor/events{/privacy}","received_events_url":"https://api.github.com/users/viztor/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-08-14T18:30:08Z","updated_at":"2018-08-14T19:26:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c99e68962bbac1508c76eb149ef7136a4fda5cbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/96/commits","review_comments_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/96/comments","review_comment_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yarnpkg/rfcs/issues/96/comments","statuses_url":"https://api.github.com/repos/yarnpkg/rfcs/statuses/ad28c9ddfe4da8ab6e6ce10152a5a8f27b47403f","head":{"label":"viztor:master","ref":"master","sha":"ad28c9ddfe4da8ab6e6ce10152a5a8f27b47403f","user":{"login":"viztor","id":3511050,"node_id":"MDQ6VXNlcjM1MTEwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3511050?v=4","gravatar_id":"","url":"https://api.github.com/users/viztor","html_url":"https://github.com/viztor","followers_url":"https://api.github.com/users/viztor/followers","following_url":"https://api.github.com/users/viztor/following{/other_user}","gists_url":"https://api.github.com/users/viztor/gists{/gist_id}","starred_url":"https://api.github.com/users/viztor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viztor/subscriptions","organizations_url":"https://api.github.com/users/viztor/orgs","repos_url":"https://api.github.com/users/viztor/repos","events_url":"https://api.github.com/users/viztor/events{/privacy}","received_events_url":"https://api.github.com/users/viztor/received_events","type":"User","site_admin":false},"repo":{"id":144757751,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ3NTc3NTE=","name":"rfcs","full_name":"viztor/rfcs","owner":{"login":"viztor","id":3511050,"node_id":"MDQ6VXNlcjM1MTEwNTA=","avatar_url":"https://avatars0.githubusercontent.com/u/3511050?v=4","gravatar_id":"","url":"https://api.github.com/users/viztor","html_url":"https://github.com/viztor","followers_url":"https://api.github.com/users/viztor/followers","following_url":"https://api.github.com/users/viztor/following{/other_user}","gists_url":"https://api.github.com/users/viztor/gists{/gist_id}","starred_url":"https://api.github.com/users/viztor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viztor/subscriptions","organizations_url":"https://api.github.com/users/viztor/orgs","repos_url":"https://api.github.com/users/viztor/repos","events_url":"https://api.github.com/users/viztor/events{/privacy}","received_events_url":"https://api.github.com/users/viztor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viztor/rfcs","description":"RFCs for changes to Yarn","fork":true,"url":"https://api.github.com/repos/viztor/rfcs","forks_url":"https://api.github.com/repos/viztor/rfcs/forks","keys_url":"https://api.github.com/repos/viztor/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viztor/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viztor/rfcs/teams","hooks_url":"https://api.github.com/repos/viztor/rfcs/hooks","issue_events_url":"https://api.github.com/repos/viztor/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/viztor/rfcs/events","assignees_url":"https://api.github.com/repos/viztor/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/viztor/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/viztor/rfcs/tags","blobs_url":"https://api.github.com/repos/viztor/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viztor/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viztor/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/viztor/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viztor/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/viztor/rfcs/languages","stargazers_url":"https://api.github.com/repos/viztor/rfcs/stargazers","contributors_url":"https://api.github.com/repos/viztor/rfcs/contributors","subscribers_url":"https://api.github.com/repos/viztor/rfcs/subscribers","subscription_url":"https://api.github.com/repos/viztor/rfcs/subscription","commits_url":"https://api.github.com/repos/viztor/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/viztor/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/viztor/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/viztor/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/viztor/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/viztor/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viztor/rfcs/merges","archive_url":"https://api.github.com/repos/viztor/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viztor/rfcs/downloads","issues_url":"https://api.github.com/repos/viztor/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/viztor/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/viztor/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/viztor/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viztor/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/viztor/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/viztor/rfcs/deployments","created_at":"2018-08-14T18:28:34Z","updated_at":"2018-08-14T18:30:00Z","pushed_at":"2018-08-14T18:29:58Z","git_url":"git://github.com/viztor/rfcs.git","ssh_url":"git@github.com:viztor/rfcs.git","clone_url":"https://github.com/viztor/rfcs.git","svn_url":"https://github.com/viztor/rfcs","homepage":"","size":81,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yarnpkg:master","ref":"master","sha":"c0c8f15298d671c039279de811ca225fdfe1ca43","user":{"login":"yarnpkg","id":22247014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjQ3MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"repo":{"id":68416532,"node_id":"MDEwOlJlcG9zaXRvcnk2ODQxNjUzMg==","name":"rfcs","full_name":"yarnpkg/rfcs","owner":{"login":"yarnpkg","id":22247014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjQ3MDE0","avatar_url":"https://avatars3.githubusercontent.com/u/22247014?v=4","gravatar_id":"","url":"https://api.github.com/users/yarnpkg","html_url":"https://github.com/yarnpkg","followers_url":"https://api.github.com/users/yarnpkg/followers","following_url":"https://api.github.com/users/yarnpkg/following{/other_user}","gists_url":"https://api.github.com/users/yarnpkg/gists{/gist_id}","starred_url":"https://api.github.com/users/yarnpkg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarnpkg/subscriptions","organizations_url":"https://api.github.com/users/yarnpkg/orgs","repos_url":"https://api.github.com/users/yarnpkg/repos","events_url":"https://api.github.com/users/yarnpkg/events{/privacy}","received_events_url":"https://api.github.com/users/yarnpkg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yarnpkg/rfcs","description":"RFCs for changes to Yarn","fork":false,"url":"https://api.github.com/repos/yarnpkg/rfcs","forks_url":"https://api.github.com/repos/yarnpkg/rfcs/forks","keys_url":"https://api.github.com/repos/yarnpkg/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yarnpkg/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yarnpkg/rfcs/teams","hooks_url":"https://api.github.com/repos/yarnpkg/rfcs/hooks","issue_events_url":"https://api.github.com/repos/yarnpkg/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/yarnpkg/rfcs/events","assignees_url":"https://api.github.com/repos/yarnpkg/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/yarnpkg/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/yarnpkg/rfcs/tags","blobs_url":"https://api.github.com/repos/yarnpkg/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yarnpkg/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yarnpkg/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/yarnpkg/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yarnpkg/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/yarnpkg/rfcs/languages","stargazers_url":"https://api.github.com/repos/yarnpkg/rfcs/stargazers","contributors_url":"https://api.github.com/repos/yarnpkg/rfcs/contributors","subscribers_url":"https://api.github.com/repos/yarnpkg/rfcs/subscribers","subscription_url":"https://api.github.com/repos/yarnpkg/rfcs/subscription","commits_url":"https://api.github.com/repos/yarnpkg/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/yarnpkg/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/yarnpkg/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/yarnpkg/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/yarnpkg/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/yarnpkg/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yarnpkg/rfcs/merges","archive_url":"https://api.github.com/repos/yarnpkg/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yarnpkg/rfcs/downloads","issues_url":"https://api.github.com/repos/yarnpkg/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/yarnpkg/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/yarnpkg/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/yarnpkg/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yarnpkg/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/yarnpkg/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/yarnpkg/rfcs/deployments","created_at":"2016-09-16T21:44:14Z","updated_at":"2018-08-14T07:50:16Z","pushed_at":"2018-08-14T18:30:08Z","git_url":"git://github.com/yarnpkg/rfcs.git","ssh_url":"git@github.com:yarnpkg/rfcs.git","clone_url":"https://github.com/yarnpkg/rfcs.git","svn_url":"https://github.com/yarnpkg/rfcs","homepage":"","size":81,"stargazers_count":155,"watchers_count":155,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":14,"license":null,"forks":80,"open_issues":14,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/96"},"html":{"href":"https://github.com/yarnpkg/rfcs/pull/96"},"issue":{"href":"https://api.github.com/repos/yarnpkg/rfcs/issues/96"},"comments":{"href":"https://api.github.com/repos/yarnpkg/rfcs/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yarnpkg/rfcs/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/yarnpkg/rfcs/statuses/ad28c9ddfe4da8ab6e6ce10152a5a8f27b47403f"}},"author_association":"NONE"}}
{"actor":{"display_login":"arcanis"}}