{"action":"created","comment":{"url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/comments/190250401","pull_request_review_id":122589343,"id":190250401,"diff_hunk":"@@ -107,6 +109,15 @@ trait BaseByteArrayJournalDao extends JournalDao {\n       db.run(actions.transactionally)\n     }\n \n+  def update(persistenceId: String, sequenceNr: Long, payload: AnyRef): Future[Unit] = {\n+    val write = PersistentRepr(payload, sequenceNr, persistenceId)\n+    val serializedRow = serializer.serialize(write) match {\n+      case Success(t)  => t\n+      case Failure(ex) => throw new IllegalArgumentException(s\"Failed to serialize ${write.getClass} for update of [$persistenceId] @ [$sequenceNr]\")\n+    }\n+    db.run(queries.update(persistenceId, sequenceNr, serializedRow.message)).map(_ => ())","path":"src/main/scala/akka/persistence/jdbc/journal/dao/ByteArrayJournalDao.scala","position":34,"original_position":34,"commit_id":"02a6770f341fb8fc067349b2a34c9edbd81bd50a","original_commit_id":"02a6770f341fb8fc067349b2a34c9edbd81bd50a","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars1.githubusercontent.com/u/120979?v=4","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-05-23T13:42:30Z","updated_at":"2018-05-23T13:42:30Z","html_url":"https://github.com/dnvriend/akka-persistence-jdbc/pull/183#discussion_r190250401","pull_request_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/183","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/comments/190250401"},"html":{"href":"https://github.com/dnvriend/akka-persistence-jdbc/pull/183#discussion_r190250401"},"pull_request":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/183"}},"in_reply_to_id":184764903},"pull_request":{"url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/183","id":183994214,"html_url":"https://github.com/dnvriend/akka-persistence-jdbc/pull/183","diff_url":"https://github.com/dnvriend/akka-persistence-jdbc/pull/183.diff","patch_url":"https://github.com/dnvriend/akka-persistence-jdbc/pull/183.patch","issue_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/issues/183","number":183,"state":"open","locked":false,"title":"initial impl of in-place updates, needed for data migrations","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars1.githubusercontent.com/u/120979?v=4","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"Proposal for https://github.com/dnvriend/akka-persistence-jdbc/issues/182\r\n\r\nIt is not entirely complete yet as it will need some types from Akka itself.\r\nThis would allow us to write \"encrypt all events\" and other migrations on existing data","created_at":"2018-04-25T10:45:37Z","updated_at":"2018-05-23T13:42:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fd499c8a054c0a140ad1481b738eacbe345aca2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/183/commits","review_comments_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/183/comments","review_comment_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/issues/183/comments","statuses_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/statuses/02a6770f341fb8fc067349b2a34c9edbd81bd50a","head":{"label":"ktoso:wip-event-update","ref":"wip-event-update","sha":"02a6770f341fb8fc067349b2a34c9edbd81bd50a","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars1.githubusercontent.com/u/120979?v=4","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"repo":{"id":56047368,"name":"akka-persistence-jdbc","full_name":"ktoso/akka-persistence-jdbc","owner":{"login":"ktoso","id":120979,"avatar_url":"https://avatars1.githubusercontent.com/u/120979?v=4","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktoso/akka-persistence-jdbc","description":"Asynchronously writes journal and snapshot entries to configured JDBC databases so that Akka Actors can recover state","fork":true,"url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc","forks_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/forks","keys_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/teams","hooks_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/hooks","issue_events_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/issues/events{/number}","events_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/events","assignees_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/assignees{/user}","branches_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/branches{/branch}","tags_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/tags","blobs_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/languages","stargazers_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/stargazers","contributors_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/contributors","subscribers_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/subscribers","subscription_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/subscription","commits_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/contents/{+path}","compare_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/merges","archive_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/downloads","issues_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/issues{/number}","pulls_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/labels{/name}","releases_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/releases{/id}","deployments_url":"https://api.github.com/repos/ktoso/akka-persistence-jdbc/deployments","created_at":"2016-04-12T08:59:33Z","updated_at":"2018-04-25T04:27:45Z","pushed_at":"2018-04-27T06:18:41Z","git_url":"git://github.com/ktoso/akka-persistence-jdbc.git","ssh_url":"git@github.com:ktoso/akka-persistence-jdbc.git","clone_url":"https://github.com/ktoso/akka-persistence-jdbc.git","svn_url":"https://github.com/ktoso/akka-persistence-jdbc","homepage":"","size":6244,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dnvriend:master","ref":"master","sha":"10d5d8de075ff479994cd20bc930552f1831356d","user":{"login":"dnvriend","id":4494623,"avatar_url":"https://avatars3.githubusercontent.com/u/4494623?v=4","gravatar_id":"","url":"https://api.github.com/users/dnvriend","html_url":"https://github.com/dnvriend","followers_url":"https://api.github.com/users/dnvriend/followers","following_url":"https://api.github.com/users/dnvriend/following{/other_user}","gists_url":"https://api.github.com/users/dnvriend/gists{/gist_id}","starred_url":"https://api.github.com/users/dnvriend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnvriend/subscriptions","organizations_url":"https://api.github.com/users/dnvriend/orgs","repos_url":"https://api.github.com/users/dnvriend/repos","events_url":"https://api.github.com/users/dnvriend/events{/privacy}","received_events_url":"https://api.github.com/users/dnvriend/received_events","type":"User","site_admin":false},"repo":{"id":20113016,"name":"akka-persistence-jdbc","full_name":"dnvriend/akka-persistence-jdbc","owner":{"login":"dnvriend","id":4494623,"avatar_url":"https://avatars3.githubusercontent.com/u/4494623?v=4","gravatar_id":"","url":"https://api.github.com/users/dnvriend","html_url":"https://github.com/dnvriend","followers_url":"https://api.github.com/users/dnvriend/followers","following_url":"https://api.github.com/users/dnvriend/following{/other_user}","gists_url":"https://api.github.com/users/dnvriend/gists{/gist_id}","starred_url":"https://api.github.com/users/dnvriend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnvriend/subscriptions","organizations_url":"https://api.github.com/users/dnvriend/orgs","repos_url":"https://api.github.com/users/dnvriend/repos","events_url":"https://api.github.com/users/dnvriend/events{/privacy}","received_events_url":"https://api.github.com/users/dnvriend/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnvriend/akka-persistence-jdbc","description":"Asynchronously writes journal and snapshot entries to configured JDBC databases so that Akka Actors can recover state","fork":false,"url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc","forks_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/forks","keys_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/teams","hooks_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/hooks","issue_events_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/issues/events{/number}","events_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/events","assignees_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/assignees{/user}","branches_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/branches{/branch}","tags_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/tags","blobs_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/languages","stargazers_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/stargazers","contributors_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/contributors","subscribers_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/subscribers","subscription_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/subscription","commits_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/contents/{+path}","compare_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/merges","archive_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/downloads","issues_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/issues{/number}","pulls_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/labels{/name}","releases_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/releases{/id}","deployments_url":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/deployments","created_at":"2014-05-23T20:26:52Z","updated_at":"2018-05-02T19:56:32Z","pushed_at":"2018-05-04T18:38:44Z","git_url":"git://github.com/dnvriend/akka-persistence-jdbc.git","ssh_url":"git@github.com:dnvriend/akka-persistence-jdbc.git","clone_url":"https://github.com/dnvriend/akka-persistence-jdbc.git","svn_url":"https://github.com/dnvriend/akka-persistence-jdbc","homepage":"","size":6249,"stargazers_count":181,"watchers_count":181,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":83,"open_issues":13,"watchers":181,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/183"},"html":{"href":"https://github.com/dnvriend/akka-persistence-jdbc/pull/183"},"issue":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/issues/183"},"comments":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/issues/183/comments"},"review_comments":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/183/comments"},"review_comment":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/pulls/183/commits"},"statuses":{"href":"https://api.github.com/repos/dnvriend/akka-persistence-jdbc/statuses/02a6770f341fb8fc067349b2a34c9edbd81bd50a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ktoso"}}