{"action":"created","comment":{"url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/comments/245452043","pull_request_review_id":189567958,"id":245452043,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ1MjA0Mw==","diff_hunk":"@@ -22,11 +22,32 @@ const main = module.exports = opts => { // eslint-disable-line max-statements\n   program.option(\"-m, --minimal\", \"Minimal mode\");\n   program.option(\"-t, --title [title]\", \"Terminal window title\");\n   program.option(\"-p, --port [port]\", \"Socket listener port\");\n+  program.option(\"-e, --example\", \"Run example\");","path":"bin/webpack-dashboard.js","position":13,"original_position":13,"commit_id":"2a16cbad948537efe844459c14b86c6b01f1f971","original_commit_id":"2a16cbad948537efe844459c14b86c6b01f1f971","user":{"login":"parkerziegler","id":19421190,"node_id":"MDQ6VXNlcjE5NDIxMTkw","avatar_url":"https://avatars0.githubusercontent.com/u/19421190?v=4","gravatar_id":"","url":"https://api.github.com/users/parkerziegler","html_url":"https://github.com/parkerziegler","followers_url":"https://api.github.com/users/parkerziegler/followers","following_url":"https://api.github.com/users/parkerziegler/following{/other_user}","gists_url":"https://api.github.com/users/parkerziegler/gists{/gist_id}","starred_url":"https://api.github.com/users/parkerziegler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkerziegler/subscriptions","organizations_url":"https://api.github.com/users/parkerziegler/orgs","repos_url":"https://api.github.com/users/parkerziegler/repos","events_url":"https://api.github.com/users/parkerziegler/events{/privacy}","received_events_url":"https://api.github.com/users/parkerziegler/received_events","type":"User","site_admin":false},"body":"Also, do you have any ideas about how to break that `isExample` code out? The reason we have it in there is b/c the `webpack-dashboard` CLI command spawns a child process that is responsible for running your startup script. And in this case, we basically short circuit that and say, \"Hey run the example project instead.\" I'll experiment, but not sure how easy it'll be to pull that out without duplicating all of the `socket-io` server code.","created_at":"2019-01-04T23:53:22Z","updated_at":"2019-01-04T23:53:22Z","html_url":"https://github.com/FormidableLabs/webpack-dashboard/pull/267#discussion_r245452043","pull_request_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/267","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/comments/245452043"},"html":{"href":"https://github.com/FormidableLabs/webpack-dashboard/pull/267#discussion_r245452043"},"pull_request":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/267"}},"in_reply_to_id":245449179},"pull_request":{"url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/267","id":242329907,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzI5OTA3","html_url":"https://github.com/FormidableLabs/webpack-dashboard/pull/267","diff_url":"https://github.com/FormidableLabs/webpack-dashboard/pull/267.diff","patch_url":"https://github.com/FormidableLabs/webpack-dashboard/pull/267.patch","issue_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues/267","number":267,"state":"open","locked":false,"title":"Simplify contribution process. Integrate inspectpack fixtures.","user":{"login":"parkerziegler","id":19421190,"node_id":"MDQ6VXNlcjE5NDIxMTkw","avatar_url":"https://avatars0.githubusercontent.com/u/19421190?v=4","gravatar_id":"","url":"https://api.github.com/users/parkerziegler","html_url":"https://github.com/parkerziegler","followers_url":"https://api.github.com/users/parkerziegler/followers","following_url":"https://api.github.com/users/parkerziegler/following{/other_user}","gists_url":"https://api.github.com/users/parkerziegler/gists{/gist_id}","starred_url":"https://api.github.com/users/parkerziegler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parkerziegler/subscriptions","organizations_url":"https://api.github.com/users/parkerziegler/orgs","repos_url":"https://api.github.com/users/parkerziegler/repos","events_url":"https://api.github.com/users/parkerziegler/events{/privacy}","received_events_url":"https://api.github.com/users/parkerziegler/received_events","type":"User","site_admin":false},"body":"This PR adds some niceties to make the contributing process for `webpack-dashboard` a bit easier. Specifically, we introduce a `yarn dev` command that allows a user to immediately run one of the example fixtures in `/examples`. The example being run is controlled by `process.env.EXAMPLE`, which can be altered in `package.json`.\r\n\r\nI need to give @mhink credit for the implementation idea here. He suggested adding some sort of flag to the CLI to indicate that we want to run the example project. When that flag (supplied as `-e, --example`) gets passed, we spin up a separate child process to run one of the fixtures specified in `/examples` (based on the value of `process.env.EXAMPLE`). This will _only_ work currently if no other command is passed to `webpack-dashboard` and you're running `-e` from a clone of this repository (since `/examples` will not get published to `npm`).\r\n\r\nLastly, I made the decision to just duplicate a few of the `inspectpack` fixtures here rather than try to bring them in as a Git dependency. Attempting to access those fixtures deep in `node_modules` was proving to be a bit brittle, and the heavy use of `env` variables made me a bit worried about having full dev support for Windows users. So I stripped the config down to only run against latest `webpack`, and use `cross-env` to support Windows environments for our single environment variable `EXAMPLE`.\r\n\r\nWould love thoughts, opinions, and feelings about this approach. Do you feel this makes it easier to get started working on `webpack-dashboard`?","created_at":"2019-01-04T17:51:39Z","updated_at":"2019-01-04T23:53:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"314d423ec5e5dd24d0dd5b88c1485ebd362ddd33","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mhink","id":780461,"node_id":"MDQ6VXNlcjc4MDQ2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/780461?v=4","gravatar_id":"","url":"https://api.github.com/users/mhink","html_url":"https://github.com/mhink","followers_url":"https://api.github.com/users/mhink/followers","following_url":"https://api.github.com/users/mhink/following{/other_user}","gists_url":"https://api.github.com/users/mhink/gists{/gist_id}","starred_url":"https://api.github.com/users/mhink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhink/subscriptions","organizations_url":"https://api.github.com/users/mhink/orgs","repos_url":"https://api.github.com/users/mhink/repos","events_url":"https://api.github.com/users/mhink/events{/privacy}","received_events_url":"https://api.github.com/users/mhink/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/267/commits","review_comments_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/267/comments","review_comment_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues/267/comments","statuses_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/statuses/2a16cbad948537efe844459c14b86c6b01f1f971","head":{"label":"FormidableLabs:task/simplify-contribution-process","ref":"task/simplify-contribution-process","sha":"2a16cbad948537efe844459c14b86c6b01f1f971","user":{"login":"FormidableLabs","id":5078602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzg2MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5078602?v=4","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":65678789,"node_id":"MDEwOlJlcG9zaXRvcnk2NTY3ODc4OQ==","name":"webpack-dashboard","full_name":"FormidableLabs/webpack-dashboard","private":false,"owner":{"login":"FormidableLabs","id":5078602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzg2MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5078602?v=4","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FormidableLabs/webpack-dashboard","description":"A CLI dashboard for webpack dev server","fork":false,"url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard","forks_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/forks","keys_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/events","assignees_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/merges","archive_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/deployments","created_at":"2016-08-14T17:44:33Z","updated_at":"2019-01-04T19:44:36Z","pushed_at":"2019-01-04T18:48:13Z","git_url":"git://github.com/FormidableLabs/webpack-dashboard.git","ssh_url":"git@github.com:FormidableLabs/webpack-dashboard.git","clone_url":"https://github.com/FormidableLabs/webpack-dashboard.git","svn_url":"https://github.com/FormidableLabs/webpack-dashboard","homepage":null,"size":604,"stargazers_count":12964,"watchers_count":12964,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":378,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":378,"open_issues":33,"watchers":12964,"default_branch":"master"}},"base":{"label":"FormidableLabs:master","ref":"master","sha":"ab047f98bd848682482d268541a8ecb8ed71d5b9","user":{"login":"FormidableLabs","id":5078602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzg2MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5078602?v=4","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":65678789,"node_id":"MDEwOlJlcG9zaXRvcnk2NTY3ODc4OQ==","name":"webpack-dashboard","full_name":"FormidableLabs/webpack-dashboard","private":false,"owner":{"login":"FormidableLabs","id":5078602,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNzg2MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5078602?v=4","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/FormidableLabs/webpack-dashboard","description":"A CLI dashboard for webpack dev server","fork":false,"url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard","forks_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/forks","keys_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/events","assignees_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/merges","archive_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/deployments","created_at":"2016-08-14T17:44:33Z","updated_at":"2019-01-04T19:44:36Z","pushed_at":"2019-01-04T18:48:13Z","git_url":"git://github.com/FormidableLabs/webpack-dashboard.git","ssh_url":"git@github.com:FormidableLabs/webpack-dashboard.git","clone_url":"https://github.com/FormidableLabs/webpack-dashboard.git","svn_url":"https://github.com/FormidableLabs/webpack-dashboard","homepage":null,"size":604,"stargazers_count":12964,"watchers_count":12964,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":378,"mirror_url":null,"archived":false,"open_issues_count":33,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":378,"open_issues":33,"watchers":12964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/267"},"html":{"href":"https://github.com/FormidableLabs/webpack-dashboard/pull/267"},"issue":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues/267"},"comments":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/issues/267/comments"},"review_comments":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/267/comments"},"review_comment":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/pulls/267/commits"},"statuses":{"href":"https://api.github.com/repos/FormidableLabs/webpack-dashboard/statuses/2a16cbad948537efe844459c14b86c6b01f1f971"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"parkerziegler"}}