{"action":"created","issue":{"url":"https://api.github.com/repos/azavea/cac-tripplanner-android/issues/94","repository_url":"https://api.github.com/repos/azavea/cac-tripplanner-android","labels_url":"https://api.github.com/repos/azavea/cac-tripplanner-android/issues/94/labels{/name}","comments_url":"https://api.github.com/repos/azavea/cac-tripplanner-android/issues/94/comments","events_url":"https://api.github.com/repos/azavea/cac-tripplanner-android/issues/94/events","html_url":"https://github.com/azavea/cac-tripplanner-android/pull/94","id":333393436,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NjE2ODM5","number":94,"title":"Fancy notifications","user":{"login":"flibbertigibbet","id":960264,"node_id":"MDQ6VXNlcjk2MDI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/960264?v=4","gravatar_id":"","url":"https://api.github.com/users/flibbertigibbet","html_url":"https://github.com/flibbertigibbet","followers_url":"https://api.github.com/users/flibbertigibbet/followers","following_url":"https://api.github.com/users/flibbertigibbet/following{/other_user}","gists_url":"https://api.github.com/users/flibbertigibbet/gists{/gist_id}","starred_url":"https://api.github.com/users/flibbertigibbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibbertigibbet/subscriptions","organizations_url":"https://api.github.com/users/flibbertigibbet/orgs","repos_url":"https://api.github.com/users/flibbertigibbet/repos","events_url":"https://api.github.com/users/flibbertigibbet/events{/privacy}","received_events_url":"https://api.github.com/users/flibbertigibbet/received_events","type":"User","site_admin":false},"labels":[{"id":831344577,"node_id":"MDU6TGFiZWw4MzEzNDQ1Nzc=","url":"https://api.github.com/repos/azavea/cac-tripplanner-android/labels/in%20review","name":"in review","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":{"login":"maurizi","id":4432106,"node_id":"MDQ6VXNlcjQ0MzIxMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4432106?v=4","gravatar_id":"","url":"https://api.github.com/users/maurizi","html_url":"https://github.com/maurizi","followers_url":"https://api.github.com/users/maurizi/followers","following_url":"https://api.github.com/users/maurizi/following{/other_user}","gists_url":"https://api.github.com/users/maurizi/gists{/gist_id}","starred_url":"https://api.github.com/users/maurizi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurizi/subscriptions","organizations_url":"https://api.github.com/users/maurizi/orgs","repos_url":"https://api.github.com/users/maurizi/repos","events_url":"https://api.github.com/users/maurizi/events{/privacy}","received_events_url":"https://api.github.com/users/maurizi/received_events","type":"User","site_admin":false},"assignees":[{"login":"maurizi","id":4432106,"node_id":"MDQ6VXNlcjQ0MzIxMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/4432106?v=4","gravatar_id":"","url":"https://api.github.com/users/maurizi","html_url":"https://github.com/maurizi","followers_url":"https://api.github.com/users/maurizi/followers","following_url":"https://api.github.com/users/maurizi/following{/other_user}","gists_url":"https://api.github.com/users/maurizi/gists{/gist_id}","starred_url":"https://api.github.com/users/maurizi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurizi/subscriptions","organizations_url":"https://api.github.com/users/maurizi/orgs","repos_url":"https://api.github.com/users/maurizi/repos","events_url":"https://api.github.com/users/maurizi/events{/privacy}","received_events_url":"https://api.github.com/users/maurizi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-06-18T18:56:04Z","updated_at":"2018-06-19T20:44:52Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/azavea/cac-tripplanner-android/pulls/94","html_url":"https://github.com/azavea/cac-tripplanner-android/pull/94","diff_url":"https://github.com/azavea/cac-tripplanner-android/pull/94.diff","patch_url":"https://github.com/azavea/cac-tripplanner-android/pull/94.patch"},"body":"## Overview\r\n\r\nAdd 'been' button to geofence notifications; on tap, open detail view and change flag from 'want to go' to 'been.' Add image to notification, where present, with text fallback in case image not available or fails to load for some reason. (It should always exist, though).\r\n\r\nAlso expands Crashlytics logging. Note that because we are using Crashlytics with Firebase integration, custom events are not supported, so simple log messages are sent for geofence add/remove events instead.\r\n\r\nAlso updates documentation and files for setting various app service keys for Fabric/Crashlytics support.\r\n\r\n## Demo\r\n\r\n![image](https://user-images.githubusercontent.com/960264/41604647-bb6d8cbc-73ad-11e8-8c7c-fb4ec5a12172.png)\r\n\r\n\r\n\r\n## Notes\r\n\r\nAdds some logic for notification grouping, but currently notifications will only group with the auto-grouping behavior, which happens when there are four or more. To logically group them for fewer notices would require a single notification be sent and then subsequently updated with the same identifier and with a shared title, which might make sense to do for multiple events occurring at the same location. But as that would require significant additional effort to support and will likely be implemented very differently once [support for custom locations on events](azavea/cac-tripplanner#1008) has been added, this PR does not do that. We may want to add grouping events by destination once that has been done.\r\n\r\n## Testing\r\n\r\n - Mark a place or event with an associated place as 'want to go'\r\n - Use emulator location mock to set location to at or near the place\r\n - Open Maps in emulator to cause location to update\r\n - Notification should appear within a few minutes with the image as above\r\n - In-notification 'been' button should function as expected\r\n\r\nCloses #46.\r\n"},"comment":{"url":"https://api.github.com/repos/azavea/cac-tripplanner-android/issues/comments/398539375","html_url":"https://github.com/azavea/cac-tripplanner-android/pull/94#issuecomment-398539375","issue_url":"https://api.github.com/repos/azavea/cac-tripplanner-android/issues/94","id":398539375,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODUzOTM3NQ==","user":{"login":"flibbertigibbet","id":960264,"node_id":"MDQ6VXNlcjk2MDI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/960264?v=4","gravatar_id":"","url":"https://api.github.com/users/flibbertigibbet","html_url":"https://github.com/flibbertigibbet","followers_url":"https://api.github.com/users/flibbertigibbet/followers","following_url":"https://api.github.com/users/flibbertigibbet/following{/other_user}","gists_url":"https://api.github.com/users/flibbertigibbet/gists{/gist_id}","starred_url":"https://api.github.com/users/flibbertigibbet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flibbertigibbet/subscriptions","organizations_url":"https://api.github.com/users/flibbertigibbet/orgs","repos_url":"https://api.github.com/users/flibbertigibbet/repos","events_url":"https://api.github.com/users/flibbertigibbet/events{/privacy}","received_events_url":"https://api.github.com/users/flibbertigibbet/received_events","type":"User","site_admin":false},"created_at":"2018-06-19T20:44:52Z","updated_at":"2018-06-19T20:44:52Z","author_association":"COLLABORATOR","body":"Cannot reproduce. Flags set on detail view."}}
{"actor":{"display_login":"flibbertigibbet"}}