{"action":"created","comment":{"url":"https://api.github.com/repos/cython/cython/pulls/comments/200550382","pull_request_review_id":134888393,"id":200550382,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDU1MDM4Mg==","diff_hunk":"@@ -111,10 +118,33 @@ def pythran_indexing_type(type_, indices):\n def pythran_indexing_code(indices):\n     return _index_access(_index_code, indices)\n \n+def np_func_to_list(func):\n+    if not func.is_numpy_attribute:\n+        return []\n+    assert(func.is_numpy_attribute)","path":"Cython/Compiler/Pythran.py","position":31,"original_position":31,"commit_id":"271308ad87ec5f8ccd4d4eb257d287c6906f6d4d","original_commit_id":"271308ad87ec5f8ccd4d4eb257d287c6906f6d4d","user":{"login":"scoder","id":491659,"node_id":"MDQ6VXNlcjQ5MTY1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/491659?v=4","gravatar_id":"","url":"https://api.github.com/users/scoder","html_url":"https://github.com/scoder","followers_url":"https://api.github.com/users/scoder/followers","following_url":"https://api.github.com/users/scoder/following{/other_user}","gists_url":"https://api.github.com/users/scoder/gists{/gist_id}","starred_url":"https://api.github.com/users/scoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoder/subscriptions","organizations_url":"https://api.github.com/users/scoder/orgs","repos_url":"https://api.github.com/users/scoder/repos","events_url":"https://api.github.com/users/scoder/events{/privacy}","received_events_url":"https://api.github.com/users/scoder/received_events","type":"User","site_admin":false},"body":"Oh, and this assertion is obviously useless, given the `return` right above.","created_at":"2018-07-06T05:08:15Z","updated_at":"2018-07-06T05:08:16Z","html_url":"https://github.com/cython/cython/pull/2469#discussion_r200550382","pull_request_url":"https://api.github.com/repos/cython/cython/pulls/2469","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cython/cython/pulls/comments/200550382"},"html":{"href":"https://github.com/cython/cython/pull/2469#discussion_r200550382"},"pull_request":{"href":"https://api.github.com/repos/cython/cython/pulls/2469"}},"in_reply_to_id":200184704},"pull_request":{"url":"https://api.github.com/repos/cython/cython/pulls/2469","id":199165713,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTY1NzEz","html_url":"https://github.com/cython/cython/pull/2469","diff_url":"https://github.com/cython/cython/pull/2469.diff","patch_url":"https://github.com/cython/cython/pull/2469.patch","issue_url":"https://api.github.com/repos/cython/cython/issues/2469","number":2469,"state":"open","locked":false,"title":"Pythran: verify that pythran supports called Numpy APIs","user":{"login":"aguinet","id":1874053,"node_id":"MDQ6VXNlcjE4NzQwNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1874053?v=4","gravatar_id":"","url":"https://api.github.com/users/aguinet","html_url":"https://github.com/aguinet","followers_url":"https://api.github.com/users/aguinet/followers","following_url":"https://api.github.com/users/aguinet/following{/other_user}","gists_url":"https://api.github.com/users/aguinet/gists{/gist_id}","starred_url":"https://api.github.com/users/aguinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguinet/subscriptions","organizations_url":"https://api.github.com/users/aguinet/orgs","repos_url":"https://api.github.com/users/aguinet/repos","events_url":"https://api.github.com/users/aguinet/events{/privacy}","received_events_url":"https://api.github.com/users/aguinet/received_events","type":"User","site_admin":false},"body":"This fixes the way Cython verifies that Pythran supports the function we are translating!","created_at":"2018-07-04T07:51:11Z","updated_at":"2018-07-06T05:08:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60fa5a14a94df1a42e12f06d002c167dc7445e0b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/cython/cython/milestones/51","html_url":"https://github.com/cython/cython/milestone/51","labels_url":"https://api.github.com/repos/cython/cython/milestones/51/labels","id":3166944,"node_id":"MDk6TWlsZXN0b25lMzE2Njk0NA==","number":51,"title":"0.29","description":null,"creator":{"login":"scoder","id":491659,"node_id":"MDQ6VXNlcjQ5MTY1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/491659?v=4","gravatar_id":"","url":"https://api.github.com/users/scoder","html_url":"https://github.com/scoder","followers_url":"https://api.github.com/users/scoder/followers","following_url":"https://api.github.com/users/scoder/following{/other_user}","gists_url":"https://api.github.com/users/scoder/gists{/gist_id}","starred_url":"https://api.github.com/users/scoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scoder/subscriptions","organizations_url":"https://api.github.com/users/scoder/orgs","repos_url":"https://api.github.com/users/scoder/repos","events_url":"https://api.github.com/users/scoder/events{/privacy}","received_events_url":"https://api.github.com/users/scoder/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":8,"state":"open","created_at":"2018-03-06T19:20:48Z","updated_at":"2018-07-04T18:28:36Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cython/cython/pulls/2469/commits","review_comments_url":"https://api.github.com/repos/cython/cython/pulls/2469/comments","review_comment_url":"https://api.github.com/repos/cython/cython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cython/cython/issues/2469/comments","statuses_url":"https://api.github.com/repos/cython/cython/statuses/271308ad87ec5f8ccd4d4eb257d287c6906f6d4d","head":{"label":"aguinet:fix/pythran_numpy","ref":"fix/pythran_numpy","sha":"271308ad87ec5f8ccd4d4eb257d287c6906f6d4d","user":{"login":"aguinet","id":1874053,"node_id":"MDQ6VXNlcjE4NzQwNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1874053?v=4","gravatar_id":"","url":"https://api.github.com/users/aguinet","html_url":"https://github.com/aguinet","followers_url":"https://api.github.com/users/aguinet/followers","following_url":"https://api.github.com/users/aguinet/following{/other_user}","gists_url":"https://api.github.com/users/aguinet/gists{/gist_id}","starred_url":"https://api.github.com/users/aguinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguinet/subscriptions","organizations_url":"https://api.github.com/users/aguinet/orgs","repos_url":"https://api.github.com/users/aguinet/repos","events_url":"https://api.github.com/users/aguinet/events{/privacy}","received_events_url":"https://api.github.com/users/aguinet/received_events","type":"User","site_admin":false},"repo":{"id":82093038,"node_id":"MDEwOlJlcG9zaXRvcnk4MjA5MzAzOA==","name":"cython","full_name":"aguinet/cython","owner":{"login":"aguinet","id":1874053,"node_id":"MDQ6VXNlcjE4NzQwNTM=","avatar_url":"https://avatars3.githubusercontent.com/u/1874053?v=4","gravatar_id":"","url":"https://api.github.com/users/aguinet","html_url":"https://github.com/aguinet","followers_url":"https://api.github.com/users/aguinet/followers","following_url":"https://api.github.com/users/aguinet/following{/other_user}","gists_url":"https://api.github.com/users/aguinet/gists{/gist_id}","starred_url":"https://api.github.com/users/aguinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aguinet/subscriptions","organizations_url":"https://api.github.com/users/aguinet/orgs","repos_url":"https://api.github.com/users/aguinet/repos","events_url":"https://api.github.com/users/aguinet/events{/privacy}","received_events_url":"https://api.github.com/users/aguinet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aguinet/cython","description":"A Python to C compiler","fork":true,"url":"https://api.github.com/repos/aguinet/cython","forks_url":"https://api.github.com/repos/aguinet/cython/forks","keys_url":"https://api.github.com/repos/aguinet/cython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aguinet/cython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aguinet/cython/teams","hooks_url":"https://api.github.com/repos/aguinet/cython/hooks","issue_events_url":"https://api.github.com/repos/aguinet/cython/issues/events{/number}","events_url":"https://api.github.com/repos/aguinet/cython/events","assignees_url":"https://api.github.com/repos/aguinet/cython/assignees{/user}","branches_url":"https://api.github.com/repos/aguinet/cython/branches{/branch}","tags_url":"https://api.github.com/repos/aguinet/cython/tags","blobs_url":"https://api.github.com/repos/aguinet/cython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aguinet/cython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aguinet/cython/git/refs{/sha}","trees_url":"https://api.github.com/repos/aguinet/cython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aguinet/cython/statuses/{sha}","languages_url":"https://api.github.com/repos/aguinet/cython/languages","stargazers_url":"https://api.github.com/repos/aguinet/cython/stargazers","contributors_url":"https://api.github.com/repos/aguinet/cython/contributors","subscribers_url":"https://api.github.com/repos/aguinet/cython/subscribers","subscription_url":"https://api.github.com/repos/aguinet/cython/subscription","commits_url":"https://api.github.com/repos/aguinet/cython/commits{/sha}","git_commits_url":"https://api.github.com/repos/aguinet/cython/git/commits{/sha}","comments_url":"https://api.github.com/repos/aguinet/cython/comments{/number}","issue_comment_url":"https://api.github.com/repos/aguinet/cython/issues/comments{/number}","contents_url":"https://api.github.com/repos/aguinet/cython/contents/{+path}","compare_url":"https://api.github.com/repos/aguinet/cython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aguinet/cython/merges","archive_url":"https://api.github.com/repos/aguinet/cython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aguinet/cython/downloads","issues_url":"https://api.github.com/repos/aguinet/cython/issues{/number}","pulls_url":"https://api.github.com/repos/aguinet/cython/pulls{/number}","milestones_url":"https://api.github.com/repos/aguinet/cython/milestones{/number}","notifications_url":"https://api.github.com/repos/aguinet/cython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aguinet/cython/labels{/name}","releases_url":"https://api.github.com/repos/aguinet/cython/releases{/id}","deployments_url":"https://api.github.com/repos/aguinet/cython/deployments","created_at":"2017-02-15T18:34:44Z","updated_at":"2017-02-15T18:34:49Z","pushed_at":"2018-06-22T12:40:58Z","git_url":"git://github.com/aguinet/cython.git","ssh_url":"git@github.com:aguinet/cython.git","clone_url":"https://github.com/aguinet/cython.git","svn_url":"https://github.com/aguinet/cython","homepage":"http://cython.org","size":51026,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cython:master","ref":"master","sha":"cd3a0079d13681c2ccb61e4e9e0f70024dd67b0f","user":{"login":"cython","id":486082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NjA4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/486082?v=4","gravatar_id":"","url":"https://api.github.com/users/cython","html_url":"https://github.com/cython","followers_url":"https://api.github.com/users/cython/followers","following_url":"https://api.github.com/users/cython/following{/other_user}","gists_url":"https://api.github.com/users/cython/gists{/gist_id}","starred_url":"https://api.github.com/users/cython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cython/subscriptions","organizations_url":"https://api.github.com/users/cython/orgs","repos_url":"https://api.github.com/users/cython/repos","events_url":"https://api.github.com/users/cython/events{/privacy}","received_events_url":"https://api.github.com/users/cython/received_events","type":"Organization","site_admin":false},"repo":{"id":1099265,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5MjY1","name":"cython","full_name":"cython/cython","owner":{"login":"cython","id":486082,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NjA4Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/486082?v=4","gravatar_id":"","url":"https://api.github.com/users/cython","html_url":"https://github.com/cython","followers_url":"https://api.github.com/users/cython/followers","following_url":"https://api.github.com/users/cython/following{/other_user}","gists_url":"https://api.github.com/users/cython/gists{/gist_id}","starred_url":"https://api.github.com/users/cython/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cython/subscriptions","organizations_url":"https://api.github.com/users/cython/orgs","repos_url":"https://api.github.com/users/cython/repos","events_url":"https://api.github.com/users/cython/events{/privacy}","received_events_url":"https://api.github.com/users/cython/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cython/cython","description":"The most widely used Python to C compiler","fork":false,"url":"https://api.github.com/repos/cython/cython","forks_url":"https://api.github.com/repos/cython/cython/forks","keys_url":"https://api.github.com/repos/cython/cython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cython/cython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cython/cython/teams","hooks_url":"https://api.github.com/repos/cython/cython/hooks","issue_events_url":"https://api.github.com/repos/cython/cython/issues/events{/number}","events_url":"https://api.github.com/repos/cython/cython/events","assignees_url":"https://api.github.com/repos/cython/cython/assignees{/user}","branches_url":"https://api.github.com/repos/cython/cython/branches{/branch}","tags_url":"https://api.github.com/repos/cython/cython/tags","blobs_url":"https://api.github.com/repos/cython/cython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cython/cython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cython/cython/git/refs{/sha}","trees_url":"https://api.github.com/repos/cython/cython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cython/cython/statuses/{sha}","languages_url":"https://api.github.com/repos/cython/cython/languages","stargazers_url":"https://api.github.com/repos/cython/cython/stargazers","contributors_url":"https://api.github.com/repos/cython/cython/contributors","subscribers_url":"https://api.github.com/repos/cython/cython/subscribers","subscription_url":"https://api.github.com/repos/cython/cython/subscription","commits_url":"https://api.github.com/repos/cython/cython/commits{/sha}","git_commits_url":"https://api.github.com/repos/cython/cython/git/commits{/sha}","comments_url":"https://api.github.com/repos/cython/cython/comments{/number}","issue_comment_url":"https://api.github.com/repos/cython/cython/issues/comments{/number}","contents_url":"https://api.github.com/repos/cython/cython/contents/{+path}","compare_url":"https://api.github.com/repos/cython/cython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cython/cython/merges","archive_url":"https://api.github.com/repos/cython/cython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cython/cython/downloads","issues_url":"https://api.github.com/repos/cython/cython/issues{/number}","pulls_url":"https://api.github.com/repos/cython/cython/pulls{/number}","milestones_url":"https://api.github.com/repos/cython/cython/milestones{/number}","notifications_url":"https://api.github.com/repos/cython/cython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cython/cython/labels{/name}","releases_url":"https://api.github.com/repos/cython/cython/releases{/id}","deployments_url":"https://api.github.com/repos/cython/cython/deployments","created_at":"2010-11-21T07:44:20Z","updated_at":"2018-07-06T01:25:19Z","pushed_at":"2018-07-05T16:28:12Z","git_url":"git://github.com/cython/cython.git","ssh_url":"git@github.com:cython/cython.git","clone_url":"https://github.com/cython/cython.git","svn_url":"https://github.com/cython/cython","homepage":"http://cython.org","size":51048,"stargazers_count":3248,"watchers_count":3248,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":687,"mirror_url":null,"archived":false,"open_issues_count":587,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":687,"open_issues":587,"watchers":3248,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cython/cython/pulls/2469"},"html":{"href":"https://github.com/cython/cython/pull/2469"},"issue":{"href":"https://api.github.com/repos/cython/cython/issues/2469"},"comments":{"href":"https://api.github.com/repos/cython/cython/issues/2469/comments"},"review_comments":{"href":"https://api.github.com/repos/cython/cython/pulls/2469/comments"},"review_comment":{"href":"https://api.github.com/repos/cython/cython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cython/cython/pulls/2469/commits"},"statuses":{"href":"https://api.github.com/repos/cython/cython/statuses/271308ad87ec5f8ccd4d4eb257d287c6906f6d4d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"scoder"}}