{"action":"created","comment":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/comments/217186653","pull_request_review_id":154841044,"id":217186653,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE4NjY1Mw==","diff_hunk":"@@ -932,7 +932,13 @@ public void perProject(ProjectWorkspaceOptions opts, PerProject run) throws Exce\n \t\tfinal Set<Project> projectsWellDone = new HashSet<>();\n \n \t\tfor (Project p : projects) {\n-\t\t\tfinal Set<Project> projectDeps = p.getDependents(); // is ordered\n+\t\t\tfinal Collection<Project> projectDeps = p.getDependson(); // ordered\n+\t\t\tif (opts.verbose()) {\n+\t\t\t\tSystem.out.println(\"Project dependencies for: \" + p.getName());\n+\t\t\t\tprojectDeps.stream()\n+\t\t\t\t\t.forEachOrdered(pr -> System.out.println(","path":"biz.aQute.bnd/src/aQute/bnd/main/bnd.java","position":9,"original_position":9,"commit_id":"5cf0b5fcc32f507f77a42791d5c1c274509f9fa0","original_commit_id":"5cf0b5fcc32f507f77a42791d5c1c274509f9fa0","user":{"login":"bjhargrave","id":277682,"node_id":"MDQ6VXNlcjI3NzY4Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/277682?v=4","gravatar_id":"","url":"https://api.github.com/users/bjhargrave","html_url":"https://github.com/bjhargrave","followers_url":"https://api.github.com/users/bjhargrave/followers","following_url":"https://api.github.com/users/bjhargrave/following{/other_user}","gists_url":"https://api.github.com/users/bjhargrave/gists{/gist_id}","starred_url":"https://api.github.com/users/bjhargrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjhargrave/subscriptions","organizations_url":"https://api.github.com/users/bjhargrave/orgs","repos_url":"https://api.github.com/users/bjhargrave/repos","events_url":"https://api.github.com/users/bjhargrave/events{/privacy}","received_events_url":"https://api.github.com/users/bjhargrave/received_events","type":"User","site_admin":false},"body":"LOL. I did not notice this before, but since all you want to do with the collection is `forEach`, you don't even need `stream()`. In fact it is a waste to make a stream for this. Just use `projectDeps.forEach` since Collection now has `forEach`.","created_at":"2018-09-12T20:58:40Z","updated_at":"2018-09-12T20:58:40Z","html_url":"https://github.com/bndtools/bnd/pull/2626#discussion_r217186653","pull_request_url":"https://api.github.com/repos/bndtools/bnd/pulls/2626","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments/217186653"},"html":{"href":"https://github.com/bndtools/bnd/pull/2626#discussion_r217186653"},"pull_request":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2626"}}},"pull_request":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/2626","id":215070650,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDcwNjUw","html_url":"https://github.com/bndtools/bnd/pull/2626","diff_url":"https://github.com/bndtools/bnd/pull/2626.diff","patch_url":"https://github.com/bndtools/bnd/pull/2626.patch","issue_url":"https://api.github.com/repos/bndtools/bnd/issues/2626","number":2626,"state":"open","locked":false,"title":"fix handling of dependencys, deps shown in verbose option","user":{"login":"stbischof","id":33224746,"node_id":"MDQ6VXNlcjMzMjI0NzQ2","avatar_url":"https://avatars0.githubusercontent.com/u/33224746?v=4","gravatar_id":"","url":"https://api.github.com/users/stbischof","html_url":"https://github.com/stbischof","followers_url":"https://api.github.com/users/stbischof/followers","following_url":"https://api.github.com/users/stbischof/following{/other_user}","gists_url":"https://api.github.com/users/stbischof/gists{/gist_id}","starred_url":"https://api.github.com/users/stbischof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbischof/subscriptions","organizations_url":"https://api.github.com/users/stbischof/orgs","repos_url":"https://api.github.com/users/stbischof/repos","events_url":"https://api.github.com/users/stbischof/events{/privacy}","received_events_url":"https://api.github.com/users/stbischof/received_events","type":"User","site_admin":false},"body":"fix handling of demeondsOn (not Dependents), \r\ndemeondsOn shown in verbose option","created_at":"2018-09-12T19:30:38Z","updated_at":"2018-09-12T20:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4883c29787c37ef68aab4dc233327be529dac2b3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bndtools/bnd/pulls/2626/commits","review_comments_url":"https://api.github.com/repos/bndtools/bnd/pulls/2626/comments","review_comment_url":"https://api.github.com/repos/bndtools/bnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bndtools/bnd/issues/2626/comments","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/5cf0b5fcc32f507f77a42791d5c1c274509f9fa0","head":{"label":"ScienceCityJena:builddeps","ref":"builddeps","sha":"5cf0b5fcc32f507f77a42791d5c1c274509f9fa0","user":{"login":"ScienceCityJena","id":33526927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTI2OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/33526927?v=4","gravatar_id":"","url":"https://api.github.com/users/ScienceCityJena","html_url":"https://github.com/ScienceCityJena","followers_url":"https://api.github.com/users/ScienceCityJena/followers","following_url":"https://api.github.com/users/ScienceCityJena/following{/other_user}","gists_url":"https://api.github.com/users/ScienceCityJena/gists{/gist_id}","starred_url":"https://api.github.com/users/ScienceCityJena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScienceCityJena/subscriptions","organizations_url":"https://api.github.com/users/ScienceCityJena/orgs","repos_url":"https://api.github.com/users/ScienceCityJena/repos","events_url":"https://api.github.com/users/ScienceCityJena/events{/privacy}","received_events_url":"https://api.github.com/users/ScienceCityJena/received_events","type":"Organization","site_admin":false},"repo":{"id":142001568,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwMDE1Njg=","name":"bnd","full_name":"ScienceCityJena/bnd","owner":{"login":"ScienceCityJena","id":33526927,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzNTI2OTI3","avatar_url":"https://avatars0.githubusercontent.com/u/33526927?v=4","gravatar_id":"","url":"https://api.github.com/users/ScienceCityJena","html_url":"https://github.com/ScienceCityJena","followers_url":"https://api.github.com/users/ScienceCityJena/followers","following_url":"https://api.github.com/users/ScienceCityJena/following{/other_user}","gists_url":"https://api.github.com/users/ScienceCityJena/gists{/gist_id}","starred_url":"https://api.github.com/users/ScienceCityJena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ScienceCityJena/subscriptions","organizations_url":"https://api.github.com/users/ScienceCityJena/orgs","repos_url":"https://api.github.com/users/ScienceCityJena/repos","events_url":"https://api.github.com/users/ScienceCityJena/events{/privacy}","received_events_url":"https://api.github.com/users/ScienceCityJena/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ScienceCityJena/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build OSGi bundles.","fork":true,"url":"https://api.github.com/repos/ScienceCityJena/bnd","forks_url":"https://api.github.com/repos/ScienceCityJena/bnd/forks","keys_url":"https://api.github.com/repos/ScienceCityJena/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ScienceCityJena/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ScienceCityJena/bnd/teams","hooks_url":"https://api.github.com/repos/ScienceCityJena/bnd/hooks","issue_events_url":"https://api.github.com/repos/ScienceCityJena/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/ScienceCityJena/bnd/events","assignees_url":"https://api.github.com/repos/ScienceCityJena/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/ScienceCityJena/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/ScienceCityJena/bnd/tags","blobs_url":"https://api.github.com/repos/ScienceCityJena/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ScienceCityJena/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ScienceCityJena/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ScienceCityJena/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ScienceCityJena/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/ScienceCityJena/bnd/languages","stargazers_url":"https://api.github.com/repos/ScienceCityJena/bnd/stargazers","contributors_url":"https://api.github.com/repos/ScienceCityJena/bnd/contributors","subscribers_url":"https://api.github.com/repos/ScienceCityJena/bnd/subscribers","subscription_url":"https://api.github.com/repos/ScienceCityJena/bnd/subscription","commits_url":"https://api.github.com/repos/ScienceCityJena/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ScienceCityJena/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ScienceCityJena/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ScienceCityJena/bnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ScienceCityJena/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/ScienceCityJena/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ScienceCityJena/bnd/merges","archive_url":"https://api.github.com/repos/ScienceCityJena/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ScienceCityJena/bnd/downloads","issues_url":"https://api.github.com/repos/ScienceCityJena/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/ScienceCityJena/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/ScienceCityJena/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/ScienceCityJena/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ScienceCityJena/bnd/labels{/name}","releases_url":"https://api.github.com/repos/ScienceCityJena/bnd/releases{/id}","deployments_url":"https://api.github.com/repos/ScienceCityJena/bnd/deployments","created_at":"2018-07-23T10:52:42Z","updated_at":"2018-08-09T12:41:10Z","pushed_at":"2018-09-12T20:04:24Z","git_url":"git://github.com/ScienceCityJena/bnd.git","ssh_url":"git@github.com:ScienceCityJena/bnd.git","clone_url":"https://github.com/ScienceCityJena/bnd.git","svn_url":"https://github.com/ScienceCityJena/bnd","homepage":"https://bnd.bndtools.org","size":309394,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bndtools:master","ref":"master","sha":"e5de17744be8f7247ed98863609e8beecf2cb615","user":{"login":"bndtools","id":1130828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzA4Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1130828?v=4","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"repo":{"id":606956,"node_id":"MDEwOlJlcG9zaXRvcnk2MDY5NTY=","name":"bnd","full_name":"bndtools/bnd","owner":{"login":"bndtools","id":1130828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzA4Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/1130828?v=4","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bndtools/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build OSGi bundles.","fork":false,"url":"https://api.github.com/repos/bndtools/bnd","forks_url":"https://api.github.com/repos/bndtools/bnd/forks","keys_url":"https://api.github.com/repos/bndtools/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bndtools/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bndtools/bnd/teams","hooks_url":"https://api.github.com/repos/bndtools/bnd/hooks","issue_events_url":"https://api.github.com/repos/bndtools/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/bndtools/bnd/events","assignees_url":"https://api.github.com/repos/bndtools/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/bndtools/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/bndtools/bnd/tags","blobs_url":"https://api.github.com/repos/bndtools/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bndtools/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bndtools/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bndtools/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/bndtools/bnd/languages","stargazers_url":"https://api.github.com/repos/bndtools/bnd/stargazers","contributors_url":"https://api.github.com/repos/bndtools/bnd/contributors","subscribers_url":"https://api.github.com/repos/bndtools/bnd/subscribers","subscription_url":"https://api.github.com/repos/bndtools/bnd/subscription","commits_url":"https://api.github.com/repos/bndtools/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bndtools/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bndtools/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bndtools/bnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bndtools/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/bndtools/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bndtools/bnd/merges","archive_url":"https://api.github.com/repos/bndtools/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bndtools/bnd/downloads","issues_url":"https://api.github.com/repos/bndtools/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/bndtools/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/bndtools/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/bndtools/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bndtools/bnd/labels{/name}","releases_url":"https://api.github.com/repos/bndtools/bnd/releases{/id}","deployments_url":"https://api.github.com/repos/bndtools/bnd/deployments","created_at":"2010-04-12T17:30:15Z","updated_at":"2018-09-12T18:44:53Z","pushed_at":"2018-09-12T20:04:25Z","git_url":"git://github.com/bndtools/bnd.git","ssh_url":"git@github.com:bndtools/bnd.git","clone_url":"https://github.com/bndtools/bnd.git","svn_url":"https://github.com/bndtools/bnd","homepage":"https://bnd.bndtools.org","size":309347,"stargazers_count":320,"watchers_count":320,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":209,"mirror_url":null,"archived":false,"open_issues_count":85,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":209,"open_issues":85,"watchers":320,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2626"},"html":{"href":"https://github.com/bndtools/bnd/pull/2626"},"issue":{"href":"https://api.github.com/repos/bndtools/bnd/issues/2626"},"comments":{"href":"https://api.github.com/repos/bndtools/bnd/issues/2626/comments"},"review_comments":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2626/comments"},"review_comment":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2626/commits"},"statuses":{"href":"https://api.github.com/repos/bndtools/bnd/statuses/5cf0b5fcc32f507f77a42791d5c1c274509f9fa0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bjhargrave"}}